Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-22 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/#review222104
---


Ship it!




Ship It!

- Sarath Subramanian


On Oct. 22, 2020, 2:01 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72908/
> ---
> 
> (Updated Oct. 22, 2020, 2:01 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3957
> https://issues.apache.org/jira/browse/ATLAS-3957
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> By using Audit Framework, capture audit entries for "Server Start" and 
> "Server In Active mode" (HA)
> 
> These audit entries can be seen under the "Audits" tab of Admin section.
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json 1de9e57 
>   
> addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
>  a27525e 
>   intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
> 9ed4168 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
>   webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 6985291 
>   webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 
> 
> 
> Diff: https://reviews.apache.org/r/72908/diff/5/
> 
> 
> Testing
> ---
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/75/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-22 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/
---

(Updated Oct. 22, 2020, 9:01 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Some formatting changes.


Bugs: ATLAS-3957
https://issues.apache.org/jira/browse/ATLAS-3957


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 1de9e57 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 a27525e 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
  webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 


Diff: https://reviews.apache.org/r/72908/diff/5/

Changes: https://reviews.apache.org/r/72908/diff/4-5/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/75/console


Thanks,

Mandar Ambawane

Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-21 Thread Mandar Ambawane 


> On Oct. 21, 2020, 4:31 a.m., Sarath Subramanian wrote:
> > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java
> > Lines 128 (patched)
> > 
> >
> > consider moving initialization lines - 128 and 129 to the constructor

These lines cannot be moved to the constructor because at that moment Spring 
ApplicationContext container is yet to be populated.
Hence we get NPE in BeanUtil.java where ApplicationContext is still null.


- Mandar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/#review222083
---


On Oct. 21, 2020, 10:56 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72908/
> ---
> 
> (Updated Oct. 21, 2020, 10:56 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3957
> https://issues.apache.org/jira/browse/ATLAS-3957
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> By using Audit Framework, capture audit entries for "Server Start" and 
> "Server In Active mode" (HA)
> 
> These audit entries can be seen under the "Audits" tab of Admin section.
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json 1de9e57 
>   
> addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
>  a27525e 
>   intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
> 9ed4168 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
>   webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 6985291 
>   webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 
> 
> 
> Diff: https://reviews.apache.org/r/72908/diff/4/
> 
> 
> Testing
> ---
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/75/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-21 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/
---

(Updated Oct. 21, 2020, 10:56 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3957
https://issues.apache.org/jira/browse/ATLAS-3957


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 1de9e57 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 a27525e 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
  webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 


Diff: https://reviews.apache.org/r/72908/diff/4/

Changes: https://reviews.apache.org/r/72908/diff/3-4/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/75/console


Thanks,

Mandar Ambawane

Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-20 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/#review222083
---


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java
Lines 128 (patched)


consider moving initialization lines - 128 and 129 to the constructor



webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java
Lines 133 (patched)


nit: add new line before 'if' statement in lline 133, 136



webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java
Lines 140 (patched)


nit: add new line before try statement start in line 140 and line 146


- Sarath Subramanian


On Oct. 9, 2020, 7:46 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72908/
> ---
> 
> (Updated Oct. 9, 2020, 7:46 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3957
> https://issues.apache.org/jira/browse/ATLAS-3957
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> By using Audit Framework, capture audit entries for "Server Start" and 
> "Server In Active mode" (HA)
> 
> These audit entries can be seen under the "Audits" tab of Admin section.
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json 1de9e57 
>   
> addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
>  a27525e 
>   intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
> 9ed4168 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
>   webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 6985291 
>   webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 
> 
> 
> Diff: https://reviews.apache.org/r/72908/diff/3/
> 
> 
> Testing
> ---
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/75/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-09 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/
---

(Updated Oct. 9, 2020, 2:46 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3957
https://issues.apache.org/jira/browse/ATLAS-3957


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 1de9e57 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 a27525e 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
  webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 


Diff: https://reviews.apache.org/r/72908/diff/3/

Changes: https://reviews.apache.org/r/72908/diff/2-3/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull


Thanks,

Mandar Ambawane

Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-07 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/#review222003
---




addons/models/-Area0/0010-base_model.json
Lines 47 (patched)


SERVER_STOP and SERVER_STATE_PASSIVE is not handled yet. Consider not 
adding to enum if the states are not used. Review patch file, atlas audit entry 
as well.



webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java
Lines 57 (patched)


atlasAuditService => auditService



webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java
Lines 146 (patched)


record server start time in beginning of method, instead of calling new 
Date() method. Server start time and server active time should be same time.



webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java
Lines 56 (patched)


atlasAuditService => auditService


- Sarath Subramanian


On Oct. 7, 2020, 1:39 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72908/
> ---
> 
> (Updated Oct. 7, 2020, 1:39 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3957
> https://issues.apache.org/jira/browse/ATLAS-3957
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> By using Audit Framework, capture audit entries for "Server Start" and 
> "Server In Active mode" (HA)
> 
> These audit entries can be seen under the "Audits" tab of Admin section.
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json 1de9e57 
>   
> addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
>  a27525e 
>   intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
> 9ed4168 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
>   webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 6985291 
>   webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 
> 
> 
> Diff: https://reviews.apache.org/r/72908/diff/2/
> 
> 
> Testing
> ---
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-07 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/
---

(Updated Oct. 7, 2020, 8:39 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

1. Added Host name and Host address.
2. Changed Server start time.


Bugs: ATLAS-3957
https://issues.apache.org/jira/browse/ATLAS-3957


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 1de9e57 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 a27525e 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
  webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 


Diff: https://reviews.apache.org/r/72908/diff/2/

Changes: https://reviews.apache.org/r/72908/diff/1-2/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console


Thanks,

Mandar Ambawane

Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-09-24 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3957
https://issues.apache.org/jira/browse/ATLAS-3957


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.


Diffs
-

  addons/models/-Area0/0010-base_model.json 1de9e57 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 a27525e 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
  webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 


Diff: https://reviews.apache.org/r/72908/diff/1/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console


Thanks,

Mandar Ambawane