Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-10 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/#review223135
---


Ship it!




Ship It!

- Sarath Subramanian


On June 8, 2021, 4:07 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73404/
> ---
> 
> (Updated June 8, 2021, 4:07 p.m.)
> 
> 
> Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4324
> https://issues.apache.org/jira/browse/ATLAS-4324
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Updates:
> - Simplified approach.
> - Maintained abstraction.
> - Updated unit tests.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 94ef22577 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
>  737c637bf 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
>  9163c4709 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
>  4dde1dc2f 
>   addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 881ee105e 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json
>  42553b5cf 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json
>  a5b810f72 
>   addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json 
> 8e55b7282 
>   addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json 
> 801918e04 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json 
> dd31aa073 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json
>  7f90d1986 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json
>  dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-table-rename-v2.json 
> f2b2bf7a8 
> 
> 
> Diff: https://reviews.apache.org/r/73404/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Additional unit test.
> 
> **PC Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/617/
> 
> 
> File Attachments
> 
> 
> Screen Shot 2021-06-08 at 4.05.26 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2021/06/08/b15b33fc-007d-4ee3-8862-64750af16432__Screen_Shot_2021-06-08_at_4.05.26_PM.png
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-10 Thread Radhika Kundam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/#review223133
---


Ship it!




Ship It!

- Radhika Kundam


On June 8, 2021, 4:07 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73404/
> ---
> 
> (Updated June 8, 2021, 4:07 p.m.)
> 
> 
> Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4324
> https://issues.apache.org/jira/browse/ATLAS-4324
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Updates:
> - Simplified approach.
> - Maintained abstraction.
> - Updated unit tests.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 94ef22577 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
>  737c637bf 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
>  9163c4709 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
>  4dde1dc2f 
>   addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 881ee105e 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json
>  42553b5cf 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json
>  a5b810f72 
>   addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json 
> 8e55b7282 
>   addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json 
> 801918e04 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json 
> dd31aa073 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json
>  7f90d1986 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json
>  dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-table-rename-v2.json 
> f2b2bf7a8 
> 
> 
> Diff: https://reviews.apache.org/r/73404/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Additional unit test.
> 
> **PC Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/617/
> 
> 
> File Attachments
> 
> 
> Screen Shot 2021-06-08 at 4.05.26 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2021/06/08/b15b33fc-007d-4ee3-8862-64750af16432__Screen_Shot_2021-06-08_at_4.05.26_PM.png
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-08 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/
---

(Updated June 8, 2021, 11:07 p.m.)


Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath 
Subramanian.


Changes
---

Updates include: Added screen shot from functional testing.


Bugs: ATLAS-4324
https://issues.apache.org/jira/browse/ATLAS-4324


Repository: atlas


Description
---

**Approach**
Updates:
- Simplified approach.
- Maintained abstraction.
- Updated unit tests.


Diffs
-

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
94ef22577 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
 737c637bf 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
 9163c4709 
  
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
 4dde1dc2f 
  addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 881ee105e 
  
addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json
 42553b5cf 
  
addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json
 a5b810f72 
  addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json 
8e55b7282 
  addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json 801918e04 
  addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json dd31aa073 
  
addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json
 7f90d1986 
  
addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json
 dd31aa073 
  addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 
  addons/hive-bridge/src/test/resources/json/hs2-table-rename-v2.json f2b2bf7a8 


Diff: https://reviews.apache.org/r/73404/diff/2/


Testing
---

**Unit tests**
- Additional unit test.

**PC Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/617/


File Attachments (updated)


Screen Shot 2021-06-08 at 4.05.26 PM.png
  
https://reviews.apache.org/media/uploaded/files/2021/06/08/b15b33fc-007d-4ee3-8862-64750af16432__Screen_Shot_2021-06-08_at_4.05.26_PM.png


Thanks,

Ashutosh Mestry

Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-06 Thread Ashutosh Mestry via Review Board 


> On June 4, 2021, 10:46 p.m., Radhika Kundam wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
> > Line 200 (original), 194 (patched)
> > 
> >
> > This will keep negative guid not only to Path entity types but for all 
> > typesToRetain.IdBasedResolver will not be able to find the entities like 
> > hive_table with -ve guid which are already created. We need to keep 
> > negative guid only for Path entity types.

The allowed types are OK to be resolved locally. Also, the way lineage entities 
are created, they don't refer to each other. The inputs and output refer to 
Asset types. Hence this is fine this way.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/#review223107
---


On June 4, 2021, 8:43 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73404/
> ---
> 
> (Updated June 4, 2021, 8:43 p.m.)
> 
> 
> Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4324
> https://issues.apache.org/jira/browse/ATLAS-4324
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Updates:
> - Simplified approach.
> - Maintained abstraction.
> - Updated unit tests.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 94ef22577 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
>  737c637bf 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
>  9163c4709 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
>  4dde1dc2f 
>   addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 881ee105e 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json
>  42553b5cf 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json
>  a5b810f72 
>   addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json 
> 8e55b7282 
>   addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json 
> 801918e04 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json 
> dd31aa073 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json
>  7f90d1986 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json
>  dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-table-rename-v2.json 
> f2b2bf7a8 
> 
> 
> Diff: https://reviews.apache.org/r/73404/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Additional unit test.
> 
> **PC Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/617/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-04 Thread Radhika Kundam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/#review223107
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
Line 200 (original), 194 (patched)


This will keep negative guid not only to Path entity types but for all 
typesToRetain.IdBasedResolver will not be able to find the entities like 
hive_table with -ve guid which are already created. We need to keep negative 
guid only for Path entity types.


- Radhika Kundam


On June 4, 2021, 1:43 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73404/
> ---
> 
> (Updated June 4, 2021, 1:43 p.m.)
> 
> 
> Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4324
> https://issues.apache.org/jira/browse/ATLAS-4324
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Updates:
> - Simplified approach.
> - Maintained abstraction.
> - Updated unit tests.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 94ef22577 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
>  737c637bf 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
>  9163c4709 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
>  4dde1dc2f 
>   addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 881ee105e 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json
>  42553b5cf 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json
>  a5b810f72 
>   addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json 
> 8e55b7282 
>   addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json 
> 801918e04 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json 
> dd31aa073 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json
>  7f90d1986 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json
>  dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-table-rename-v2.json 
> f2b2bf7a8 
> 
> 
> Diff: https://reviews.apache.org/r/73404/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Additional unit test.
> 
> **PC Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/617/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-04 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/
---

(Updated June 4, 2021, 8:43 p.m.)


Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath 
Subramanian.


Changes
---

Updates include: Addressed review comments.


Bugs: ATLAS-4324
https://issues.apache.org/jira/browse/ATLAS-4324


Repository: atlas


Description
---

**Approach**
Updates:
- Simplified approach.
- Maintained abstraction.
- Updated unit tests.


Diffs (updated)
-

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
94ef22577 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
 737c637bf 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
 9163c4709 
  
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
 4dde1dc2f 
  addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 881ee105e 
  
addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json
 42553b5cf 
  
addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json
 a5b810f72 
  addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json 
8e55b7282 
  addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json 801918e04 
  addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json dd31aa073 
  
addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json
 7f90d1986 
  
addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json
 dd31aa073 
  addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 
  addons/hive-bridge/src/test/resources/json/hs2-table-rename-v2.json f2b2bf7a8 


Diff: https://reviews.apache.org/r/73404/diff/2/

Changes: https://reviews.apache.org/r/73404/diff/1-2/


Testing (updated)
---

**Unit tests**
- Additional unit test.

**PC Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/617/


Thanks,

Ashutosh Mestry

Re: Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-03 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/#review223103
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
Lines 62 (patched)


If config property is set, user should be mindful of including all the 6 
path types as well, else shell entities will be created. The types specified 
from config should only append to the default types. Without defaultTypes all 
path lineage will be broken.



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
Lines 182 (patched)


we may not need separate instanceof check for AtlasRelatedObjectId. Lines 
188-192 should suffice, since guid belongs to parent - AtlasObjectId. Consider 
removing 182-187



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
Line 201 (original), 191 (patched)


This will also set all path entity types guid to null. If guid is null 
(non-negative guid is not specified). IdBasedResolver will be ignored and 
UniqueAttributeBasedResolver will not be able to fetch the entity and result in 
shell entity creation. The earlier check to ignore path entity types would 
avoid this. Please review.


- Sarath Subramanian


On June 3, 2021, 2:52 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73404/
> ---
> 
> (Updated June 3, 2021, 2:52 p.m.)
> 
> 
> Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4324
> https://issues.apache.org/jira/browse/ATLAS-4324
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Updates:
> - Simplified approach.
> - Maintained abstraction.
> - Updated unit tests.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
>  737c637bf 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
>  9163c4709 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
>  4dde1dc2f 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json
>  42553b5cf 
>   
> addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json
>  a5b810f72 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json 
> dd31aa073 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json
>  7f90d1986 
>   
> addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json
>  dd31aa073 
>   addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 
> 
> 
> Diff: https://reviews.apache.org/r/73404/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Additional unit test.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Review Request 73404: ATLAS-4324: FS entity created for load data inpath is created as shell entity - Part 2

2021-06-03 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/
---

Review request for atlas and Radhika Kundam.


Bugs: ATLAS-4324
https://issues.apache.org/jira/browse/ATLAS-4324


Repository: atlas


Description
---

**Approach**
Updates:
- Simplified approach.
- Maintained abstraction.
- Updated unit tests.


Diffs
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
 737c637bf 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
 9163c4709 
  
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
 4dde1dc2f 
  
addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json
 42553b5cf 
  
addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json
 a5b810f72 
  addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json dd31aa073 
  
addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json
 7f90d1986 
  
addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json
 dd31aa073 
  addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 


Diff: https://reviews.apache.org/r/73404/diff/1/


Testing
---

**Unit tests**
- Additional unit test.


Thanks,

Ashutosh Mestry