Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Shwetha GS]

> On Sept. 30, 2016, 5:21 a.m., Shwetha GS wrote:
> > Previously, the common module contained some common code required for atlas 
> > server. Since the new classes that are added are client side classes, can 
> > you move them to new module clientv2 so that we have clear dependencies for 
> > atlas clients.
> > 
> > Also, move the server side rest API to webappv2 and webapp can depend on 
> > webappv2
> 
> Madhan Neethiraj wrote:
> atlas-common module is being referenced by a number of other modules - 
> not just Atlas server. Like: typesystem, notification, authorization, 
> hive-bridge, falcon-bridge, sqoop-bridge, storm-bridge. Hence I have the new 
> classes in atlas-common module.

Type system module, for example has both client and server side code. Since the 
clients would anyway depend on type system module, it becomes difficult to 
restrict the clients to not use any server side classes in the type system 
module, and they will be confused about the right classes to use. Instead, if 
we separate out the dependencies right, it will go a long way in helping the 
clients to integrate easily

Yes, the server side modules need to depend on this new module. If I understand 
your intentions right, clientv2 will be the only point of atlas reference for 
all clients, and will replace all existing dependencies(common, typesystem, 
notification etc)


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150984
---


On Sept. 30, 2016, 12:04 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 30, 2016, 12:04 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

> On Sept. 30, 2016, 5:21 a.m., Shwetha GS wrote:
> > Previously, the common module contained some common code required for atlas 
> > server. Since the new classes that are added are client side classes, can 
> > you move them to new module clientv2 so that we have clear dependencies for 
> > atlas clients.
> > 
> > Also, move the server side rest API to webappv2 and webapp can depend on 
> > webappv2

atlas-common module is being referenced by a number of other modules - not just 
Atlas server. Like: typesystem, notification, authorization, hive-bridge, 
falcon-bridge, sqoop-bridge, storm-bridge. Hence I have the new classes in 
atlas-common module.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150984
---


On Sept. 30, 2016, 12:04 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 30, 2016, 12:04 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Shwetha GS]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150984
---



Previously, the common module contained some common code required for atlas 
server. Since the new classes that are added are client side classes, can you 
move them to new module clientv2 so that we have clear dependencies for atlas 
clients.

Also, move the server side rest API to webappv2 and webapp can depend on 
webappv2

- Shwetha GS


On Sept. 30, 2016, 12:04 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 30, 2016, 12:04 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150982
---


Ship it!




Ship It!

- Suma Shivaprasad


On Sept. 30, 2016, 12:04 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 30, 2016, 12:04 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

> On Sept. 30, 2016, 12:51 a.m., Suma Shivaprasad wrote:
> > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, 
> > line 242
> > 
> >
> > would prefer valuesMinCount and valuesMaxCount also to be part of the 
> > Enum Def and @XmlEnummapping for unmarshalling. the reason we want this is 
> > valuesMinCount/maxCount are not part of constructor and could easily be 
> > missed by user while supplying values
> 
> Madhan Neethiraj wrote:
> Suma - I am not sure if Java allows enums that can take parameterized 
> values at instantiation. Like: attr.cardinality = Cardinality.LIST(1, 10). If 
> you are suggesting a different syntax, can you please add details?
> 
> >> the reason we want this is valuesMinCount/maxCount are not part of 
> constructor and could easily be missed by user while supplying values
> 
> Initially I had a constructor that took minCount and maxCount parameters. 
> But had to get rid of it since it violated a PMD rule that complained about 
> "too many parameters.." (> 7).

Yes missed that enums wudnt allow this. We could make it a class instead like 
current Multiplicity and the getters/setters should take care of the 
unmarshalling?


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150973
---


On Sept. 30, 2016, 12:04 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 30, 2016, 12:04 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

> On Sept. 30, 2016, 12:51 a.m., Suma Shivaprasad wrote:
> > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, 
> > line 242
> > 
> >
> > would prefer valuesMinCount and valuesMaxCount also to be part of the 
> > Enum Def and @XmlEnummapping for unmarshalling. the reason we want this is 
> > valuesMinCount/maxCount are not part of constructor and could easily be 
> > missed by user while supplying values

Suma - I am not sure if Java allows enums that can take parameterized values at 
instantiation. Like: attr.cardinality = Cardinality.LIST(1, 10). If you are 
suggesting a different syntax, can you please add details?

>> the reason we want this is valuesMinCount/maxCount are not part of 
>> constructor and could easily be missed by user while supplying values

Initially I had a constructor that took minCount and maxCount parameters. But 
had to get rid of it since it violated a PMD rule that complained about "too 
many parameters.." (> 7).


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150973
---


On Sept. 30, 2016, 12:04 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 30, 2016, 12:04 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150973
---




common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java (line 
242)


would prefer valuesMinCount and valuesMaxCount also to be part of the Enum 
Def and @XmlEnummapping for unmarshalling. the reason we want this is 
valuesMinCount/maxCount are not part of constructor and could easily be missed 
by user while supplying values


- Suma Shivaprasad


On Sept. 30, 2016, 12:04 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 30, 2016, 12:04 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/
---

(Updated Sept. 30, 2016, 12:04 a.m.)


Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.


Changes
---

Updated AtlasAttributeDef to replace { isMultiValued, areValuesUnique } with an 
enum - Cardinality { SINGLE, LIST, SET } - thanks Suma for the suggestion.


Bugs: ATLAS-1171
https://issues.apache.org/jira/browse/ATLAS-1171


Repository: atlas


Description
---

ATLAS-1171: structured, high-level APIs - phase #1
- define data-strctures for use in the interface (REST, ..) to describe types 
and instances: in package org.apache.atlas.model
- implementation of runtime behaviour of types - create/validate/normalize 
instances (i.e. from values in REST to typed-values): in package 
org.apache.atlas.type

I think phase #1 in providing high-level APIs is now ready to review and 
commit. Please note this patch only includes new files and there are no changes 
to any existing code. Please review.

Next steps:
- Phase #2 will include the REST API and the modules that deal with persistence 
of type and instance objects (defined in phase #1) in Tital Graph database.
- Phase #3 will replace current REST API implementation to use the new APIs, 
while continuing to provide the current REST API.
- GUI updates to use the new API can  begin once phase #2 goes in.


Diffs (updated)
-

  common/pom.xml e3b6465 
  common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
PRE-CREATION 
  
common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEntityType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasStructType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDateType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasIntType.java PRE-CREATION 
  

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/
---

(Updated Sept. 29, 2016, 9:12 p.m.)


Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.


Changes
---

- updates to address review comments
- Removed AtlasEntity.classfications member, so that AtlasEntity will only deal 
with an entity's attributes. We will add another class to capture extended 
details of an entity - like classifications, terms


Bugs: ATLAS-1171
https://issues.apache.org/jira/browse/ATLAS-1171


Repository: atlas


Description
---

ATLAS-1171: structured, high-level APIs - phase #1
- define data-strctures for use in the interface (REST, ..) to describe types 
and instances: in package org.apache.atlas.model
- implementation of runtime behaviour of types - create/validate/normalize 
instances (i.e. from values in REST to typed-values): in package 
org.apache.atlas.type

I think phase #1 in providing high-level APIs is now ready to review and 
commit. Please note this patch only includes new files and there are no changes 
to any existing code. Please review.

Next steps:
- Phase #2 will include the REST API and the modules that deal with persistence 
of type and instance objects (defined in phase #1) in Tital Graph database.
- Phase #3 will replace current REST API implementation to use the new APIs, 
while continuing to provide the current REST API.
- GUI updates to use the new API can  begin once phase #2 goes in.


Diffs (updated)
-

  common/pom.xml e3b6465 
  common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
PRE-CREATION 
  
common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEntityType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasStructType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDateType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java 

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

> On Sept. 29, 2016, 8:41 p.m., Madhan Neethiraj wrote:
> > common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java, line 31
> > 
> >
> > I agree, such API could be useful. Once we have concrete usecases 
> > identified, lets update the API to support the usecases. I suggest we take 
> > this up in a subsequent patch.

Sure.


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150920
---


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

> On Sept. 29, 2016, 6:55 p.m., Suma Shivaprasad wrote:
> > common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java, line 31
> > 
> >
> > Current existing implementations of the Atlas entity CRUD apis had a 
> > limitation while trying to  do multiple types of operations in the same 
> > transaction - for eg: a rename table had multiple operations like update a 
> > bunch of columns, rename storage descriptor, table etc. We should also 
> > support batch entity apis which allow for multiple CRUD operations to be 
> > batched in the same request which would all go through one transaction?

The other use case for this was in Falcon Hook where it was required to 
partially update a hive table and fully update a falcon entity as part of a 
single transaction.  There is no way to do this currently


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150901
---


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

> On Sept. 29, 2016, 7:31 p.m., Suma Shivaprasad wrote:
> > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, 
> > line 247
> > 
> >
> > since we have split this, valuesMinCount and valueMaxCount could be 
> > interpreted to apply even for primitive integer type attributes as a kind 
> > of value constraint. Was this the intention or its only for collection/set 
> > types? If thats the case, it may be more confusing with this split than 
> > with the earlier Multiplicity options.

also is the case with areValuesUnique . Is it confusing with this and isUnique 
also around. We need to think through this and come up with something better


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150913
---


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150913
---




common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java (line 
247)


since we have split this, valuesMinCount and valueMaxCount could be 
interpreted to apply even for primitive integer type attributes as a kind of 
value constraint. Was this the intention or its only for collection/set types? 
If thats the case, it may be more confusing with this split than with the 
earlier Multiplicity options.


- Suma Shivaprasad


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   

Build failed in Jenkins: apache-atlas-nightly #431

[Apache Jenkins Server]

See 

Changes:

[sshivalingamurthy] ATLAS-1184 ReservedTypesRegistrar checks for existence of 
1st class type

--
[...truncated 9250 lines...]
127.0.0.1 - - [29/Sep/2016:19:22:42 +] "GET 
/api/atlas/lineage/hive/table/default.tablenswyg7orbi@primary/inputs/graph 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:47 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablejkf8a1u87s@primary:1475176965000-%3E:PATH_WRITE
 HTTP/1.1" 404 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablejkf8a1u87s@primary:1475176965000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablejkf8a1u87s@primary:1475176965000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities/b0c431a7-a37f-4bbe-8938-c10e7b36561b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities/fc3aaa8d-3b06-445b-bfc9-ff3d8a75cb8d HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities/cb8f4a49-6631-4d45-adaf-78b08822553b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities/cb8f4a49-6631-4d45-adaf-78b08822553b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablejkf8a1u87s@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablejkf8a1u87s@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:52 +] "GET 
/api/atlas/entities/fc3aaa8d-3b06-445b-bfc9-ff3d8a75cb8d HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:54 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablejkf8a1u87s@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:54 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablejkf8a1u87s@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:54 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablejkf8a1u87s@primary:1475176965000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:54 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablejkf8a1u87s@primary:1475176965000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:54 +] "GET 
/api/atlas/entities/b0c431a7-a37f-4bbe-8938-c10e7b36561b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:54 +] "GET 
/api/atlas/entities/fc3aaa8d-3b06-445b-bfc9-ff3d8a75cb8d HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:54 +] "GET 
/api/atlas/entities/cb8f4a49-6631-4d45-adaf-78b08822553b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:54 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:54 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:54 +] "GET 
/api/atlas/entities/cb8f4a49-6631-4d45-adaf-78b08822553b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:57 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablejkf8a1u87s@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:57 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablejkf8a1u87s@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:57 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablejkf8a1u87s@primary:1475176965000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:19:22:57 +] "GET 

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150910
---




common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java (line 258)


currently there is a in memory type cache and a storecackedtypecache and 
are implementations of the TypeCache interface. Where are we handling this?


- Suma Shivaprasad


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150905
---




common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java (line 49)


would be better to have REST APIs deal with Struct and entity interfaces 
instead of concrete implemenations and map them to concrete classes through 
JAXB annotations?


- Suma Shivaprasad


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150904
---




common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java (line 40)


current APIs support batch deletion of entities by guids. If we support 
batch API with multiple CRUD operations , should get covered as part of that


- Suma Shivaprasad


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150901
---




common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java (line 31)


Current existing implementations of the Atlas entity CRUD apis had a 
limitation while trying to  do multiple types of operations in the same 
transaction - for eg: a rename table had multiple operations like update a 
bunch of columns, rename storage descriptor, table etc. We should also support 
batch entity apis which allow for multiple CRUD operations to be batched in the 
same request which would all go through one transaction?


- Suma Shivaprasad


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150900
---




common/src/main/java/org/apache/atlas/api/SearchFilter.java (line 48)


long here as well


- Suma Shivaprasad


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

> On Sept. 29, 2016, 4:48 a.m., Sarath Kumar Subramanian wrote:
> > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, 
> > line 249
> > 
> >
> > reverseAttributeName and isComposite attributes are missing

I am not clear on reverseAttributeName usage. From the name, it seems to be 
something for the server side to use (for quick look up?); it that is the case, 
then this attribute is not necessary in the interface.

I think we should revisit the use of isComposite attribute. Can we get to this 
in the next iteration?


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150809
---


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
> 

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

> On Sept. 29, 2016, 5:06 a.m., Sarath Kumar Subramanian wrote:
> > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, 
> > line 243
> > 
> >
> > In current design, Multiplicity attribute is overloaded to determine if 
> > an attribute can be optional, required, collection or set. These are broken 
> > down into granular attributes in this design. If the plan is to continue 
> > supporting existing REST APIs, what will be the mapping from this granular 
> > attributes to current one? 
> > eg. Required Collection or Optional Set. Which one takes precedence?

Current implmentation does not seem to allow a multi-valued attribute to be 
optional. If this is the case, I think the following mapping would work:

if(isOptional()) ==> OPTIONAL
else if(!isMultiValued()) ==> REQUIRED
else if(areValuesUnique()) ==> SET
else ==> COLLECTION


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150812
---


On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 6:11 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> 

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/
---

(Updated Sept. 29, 2016, 6:11 p.m.)


Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.


Changes
---

Updated to fix NPE in enums with no default values. Added unit tests to cover 
this case.


Bugs: ATLAS-1171
https://issues.apache.org/jira/browse/ATLAS-1171


Repository: atlas


Description
---

ATLAS-1171: structured, high-level APIs - phase #1
- define data-strctures for use in the interface (REST, ..) to describe types 
and instances: in package org.apache.atlas.model
- implementation of runtime behaviour of types - create/validate/normalize 
instances (i.e. from values in REST to typed-values): in package 
org.apache.atlas.type

I think phase #1 in providing high-level APIs is now ready to review and 
commit. Please note this patch only includes new files and there are no changes 
to any existing code. Please review.

Next steps:
- Phase #2 will include the REST API and the modules that deal with persistence 
of type and instance objects (defined in phase #1) in Tital Graph database.
- Phase #3 will replace current REST API implementation to use the new APIs, 
while continuing to provide the current REST API.
- GUI updates to use the new API can  begin once phase #2 goes in.


Diffs (updated)
-

  common/pom.xml e3b6465 
  common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
PRE-CREATION 
  
common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEntityType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasStructType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDateType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasIntType.java PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasLongType.java 

Re: Review Request 52077: Column level lineage in Hive

[Suma Shivaprasad]

> On Sept. 21, 2016, 8:58 p.m., Suma Shivaprasad wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java,
> >  line 97
> > 
> >
> > why is column qualifiedName different from the convention we are using 
> > for hive_column instances which are referred to from the table. Why is 
> > clustername removed?
> 
> Vimal Sharma wrote:
> Cluster information is not available in Lineage information provided by 
> Hive. Further, qualifiedName used in this patch is used only while setting 
> column lineage and is not used for communication with rest of Atlas codebase.
> 
> Suma Shivaprasad wrote:
> If we do not provide the same qualifiedName as in the current 
> HMSB.getColumnQualifiedName() , it will result in a another entity being 
> created for the columns. Cluster information is available in 
> HMSB.getClusterName()
> 
> Vimal Sharma wrote:
> In the function populateColumnReferenceableMap, we are setting a mapping 
> from column string identifier(named as column qualified name) to its 
> corresponding column Referenceable object in Atlas. No new column 
> Referenceable entity is created. 
> 
> Further, in buildLineageMap, we are setting a mapping from destination 
> column qualified name to list of source column qualified names. Now, in the 
> key value pairs of the type (LineageInfo.DependencyKey, 
> LineageInfo.Dependency) in LineageInfo from Hive, there is no cluster 
> information available. So here we can't use the same pattern for column 
> qualified name as used in HMSB.getColumnQualifiedName.
> 
> If we set column string identifier as HMSB.getColumnQualifiedName in 
> function populateColumnReferenceableMap, we won't be able to access the 
> column referenceable objects from the map(created in 
> populateColumnReferenceableMap) in HiveHook when we are setting up column 
> lineage process in function createColumnLineageProcessInstances(lines 803 and 
> 812).

Sounds good


- Suma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52077/#review149896
---


On Sept. 29, 2016, 8:15 a.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52077/
> ---
> 
> (Updated Sept. 29, 2016, 8:15 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1184 and ATLAS-247
> https://issues.apache.org/jira/browse/ATLAS-1184
> https://issues.apache.org/jira/browse/ATLAS-247
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> After a CTAS query, lineage relationship between source columns and 
> destination column can be captured. This information can be used to create a 
> column lineage process.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java
>  PRE-CREATION 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> a3464a0 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  45f0bc9 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataTypes.java
>  e094cb6 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> a5838b4 
> 
> Diff: https://reviews.apache.org/r/52077/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>

[jira] [Updated] (ATLAS-1200) Enhance the Exception mechanism

[Apoorv Naik (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apoorv Naik updated ATLAS-1200:
---
Description: 
Currently the error/exception messages are hand constructed all over the Atlas 
code base, making it hard to understand the origin of the problem. Also since 
Atlas is moving towards a more RESTful nature it's better to create a catalog 
for the error message with support for localization

Proposal:

Format: 
internal_error_code=external_error_code|error_description
internal_error_code_status=http_status_code

e.g.
entity_not_found=entity_not_found|Given entity doesn't exist
entity_not_found_status=404

  was:
Currently the error/exception messages are hand constructed all over the Atlas 
code base, making it hard to understand the origin of the problem. Also since 
Atlas is moving towards a more RESTful nature it's better to create a catalog 
for the error message with support for localization

Proposal:

Format: internal_error_code=http_status_code|error_description

e.g.
entity_not_found=404|Given entity doesn't exist


> Enhance the Exception mechanism
> ---
>
> Key: ATLAS-1200
> URL: https://issues.apache.org/jira/browse/ATLAS-1200
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating, 0.8-incubating
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>
> Currently the error/exception messages are hand constructed all over the 
> Atlas code base, making it hard to understand the origin of the problem. Also 
> since Atlas is moving towards a more RESTful nature it's better to create a 
> catalog for the error message with support for localization
> Proposal:
> Format: 
> internal_error_code=external_error_code|error_description
> internal_error_code_status=http_status_code
> e.g.
> entity_not_found=entity_not_found|Given entity doesn't exist
> entity_not_found_status=404



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150858
---




common/src/main/java/org/apache/atlas/type/AtlasEnumType.java (line 50)


e.get(0) on map ? Getting NPEs because of this.


- Apoorv Naik


On Sept. 29, 2016, 4:08 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 4:08 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> 

[jira] [Commented] (ATLAS-694) Update Atlas code to use abstraction layer

[Jeffrey Hagelberg (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532743#comment-15532743
 ] 

Jeffrey Hagelberg commented on ATLAS-694:
-

Thanks.  I'm still in the process updating the abstraction layer index creation 
methods and generally applying the changes from the other code review comments. 
 Some urgent stuff has come up, and I've also been out sick, but I'm hoping to 
get back to that soon.

> Update Atlas code to use abstraction layer
> --
>
> Key: ATLAS-694
> URL: https://issues.apache.org/jira/browse/ATLAS-694
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
> Attachments: ATLAS-694.patch, rb47810.patch
>
>
> In this task, we will update Atlas to replace the direct usage of titan 
> classes with usage of the equivalent interfaces in the abstraction layer.  At 
> this point, there will be no options to configure the abstraction layer 
> implementation that gets used.  Atlas will be hard-coded to use the titan 
> 0.5.4 implementation.  It will also continue to have a compile time 
> dependency on the titan 0.5.4 graph database implementation.  When this task 
> is complete, Atlas will only be accessing titan through the abstraction layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-694) Update Atlas code to use abstraction layer

[Shwetha G S (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated ATLAS-694:
--
Attachment: ATLAS-694.patch

re-based patch

> Update Atlas code to use abstraction layer
> --
>
> Key: ATLAS-694
> URL: https://issues.apache.org/jira/browse/ATLAS-694
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Jeffrey Hagelberg
>Assignee: Jeffrey Hagelberg
> Attachments: ATLAS-694.patch, rb47810.patch
>
>
> In this task, we will update Atlas to replace the direct usage of titan 
> classes with usage of the equivalent interfaces in the abstraction layer.  At 
> this point, there will be no options to configure the abstraction layer 
> implementation that gets used.  Atlas will be hard-coded to use the titan 
> 0.5.4 implementation.  It will also continue to have a compile time 
> dependency on the titan 0.5.4 graph database implementation.  When this task 
> is complete, Atlas will only be accessing titan through the abstraction layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Rename trait to classification

[Nigel Jones]

On 27/09/2016 21:19, Suma Shivaprasad wrote:

> 1. Classification - that are locked down and that have a classification
> scheme to group together a set of classification concepts
> 2. Annotation - that are free form and are not locked down
>
> So Traits could be renamed as Annotation and Classification is a
> specialization of an Annotation with an additional classification scheme
> associated with it.


One additional consideration once we've decided is to see if we can also 
persuade the Apache Ranger team to adopt the same terminology


The use of classifications to control access to data, ie to perform 
governance actions including audit, check, permit/deny, mask, filter 
etc, is very important to get the simplicity and scalability we need in 
governing data.


Today we refer to "tags" in atlas and ranger -- I wonder if ranger 
should then use "classification" too (though I'm also aware there are 
tag sources other than atlas, such as kafka)


In the ranger atlas tagsync process we pull all entities with traits - 
and so need to decide whether to
 - allow governance policies to refer to any traits (in proposal above 
annotation)

 - allow them to apply to classification only.

I think in most cases it is classification that matters, plus the volume 
of traits could get massive,  though any context can be relevant for 
making a policy decision. Perhaps we can differentiate on the properties 
of the trait as to whether to sync, and how they get used when composing 
a ranger rule. In fact that's another point, ranger uses the word 
"policy" when in my opinion it's a rule. A policy is imo logical ie 
"prevent access to PII data for normal users" and should be represented 
in Atlas whilst the rule is technology-specific, an implementation of 
the policy. This relationship needs recording too.


Do we have any of the atlas team also closely involved with ranger? I'm 
also happy to raise the issue over there, after we've decided how to 
best model. I'm looking more at that over here and how we should model 
these relationships.


Nigel.



---
Nigel Jones - Software Architect - IBM Analytics Group
IBM United Kingdom Limited / Registered in England and Wales with number 
741598 / Registered office: PO Box 41, North Harbour, Portsmouth, Hants. 
PO6 3AU

[jira] [Created] (ATLAS-1202) Falcon hook to capture Falcon entity update,delete events.

[Sharmadha Sainath (JIRA)]

Sharmadha Sainath created ATLAS-1202:


 Summary: Falcon hook to capture Falcon entity update,delete events.
 Key: ATLAS-1202
 URL: https://issues.apache.org/jira/browse/ATLAS-1202
 Project: Atlas
  Issue Type: New Feature
Reporter: Sharmadha Sainath


Currently Falcon hook captures only Submit entity . Update and Delete events 
should also be detected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52077: Column level lineage in Hive

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52077/
---

(Updated Sept. 29, 2016, 8:15 a.m.)


Review request for atlas.


Changes
---

Addressed Shwetha's review comments. I think it would make sense to address 
Type update changes in ATLAS-1184. Marked ATLAS-1184 as required for this patch


Bugs: ATLAS-1184 and ATLAS-247
https://issues.apache.org/jira/browse/ATLAS-1184
https://issues.apache.org/jira/browse/ATLAS-247


Repository: atlas


Description
---

After a CTAS query, lineage relationship between source columns and destination 
column can be captured. This information can be used to create a column lineage 
process.


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java
 PRE-CREATION 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
a3464a0 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
 45f0bc9 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataTypes.java 
e094cb6 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
a5838b4 

Diff: https://reviews.apache.org/r/52077/diff/


Testing
---


Thanks,

Vimal Sharma

[jira] [Updated] (ATLAS-247) Hive Column level lineage

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-247:
---
Attachment: ATLAS-247-v7.patch

> Hive Column level lineage
> -
>
> Key: ATLAS-247
> URL: https://issues.apache.org/jira/browse/ATLAS-247
> Project: Atlas
>  Issue Type: New Feature
>Affects Versions: 0.5-incubating
>Reporter: Herman Yu
>Assignee: Harish Butani
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-247-v4.patch, ATLAS-247-v5.patch, 
> ATLAS-247-v6.patch, ATLAS-247-v7.patch, ATLAS-247.2.patch, ATLAS-247.patch
>
>
> hive_column is not inherited from DataSet, thus can't be using hive_process 
> to track column level lineages
> Is there specific reason that hive_column is not inheriting from Data Set? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: apache-atlas-nightly #430

[Apache Jenkins Server]

See 

Changes:

[sshivalingamurthy] ATLAS-1199 Atlas UI not loading after fresh build due to

--
[...truncated 9235 lines...]
127.0.0.1 - - [29/Sep/2016:07:45:13 +] "GET 
/api/atlas/lineage/hive/table/default.tableuwdlbj7kbp@primary/inputs/graph 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:18 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tabledzcpwlod5f@primary:1475135116000-%3E:PATH_WRITE
 HTTP/1.1" 404 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tabledzcpwlod5f@primary:1475135116000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tabledzcpwlod5f@primary:1475135116000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities/ec095ca4-d9dc-4b0f-a372-9b3b1534643d HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities/00355505-5308-4557-b7a4-47a3a0ba10b4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities/502b11b6-f8be-4c57-97e3-fa3902deff9a HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities/502b11b6-f8be-4c57-97e3-fa3902deff9a HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tabledzcpwlod5f@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tabledzcpwlod5f@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:23 +] "GET 
/api/atlas/entities/00355505-5308-4557-b7a4-47a3a0ba10b4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:26 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tabledzcpwlod5f@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:26 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tabledzcpwlod5f@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:26 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tabledzcpwlod5f@primary:1475135116000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:26 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tabledzcpwlod5f@primary:1475135116000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:26 +] "GET 
/api/atlas/entities/ec095ca4-d9dc-4b0f-a372-9b3b1534643d HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:26 +] "GET 
/api/atlas/entities/00355505-5308-4557-b7a4-47a3a0ba10b4 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:26 +] "GET 
/api/atlas/entities/502b11b6-f8be-4c57-97e3-fa3902deff9a HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:26 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:26 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:26 +] "GET 
/api/atlas/entities/502b11b6-f8be-4c57-97e3-fa3902deff9a HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:28 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tabledzcpwlod5f@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:28 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tabledzcpwlod5f@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:28 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tabledzcpwlod5f@primary:1475135116000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [29/Sep/2016:07:45:28 +] "GET 

Re: Review Request 52077: Column level lineage in Hive

[Shwetha GS]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52077/#review150821
---


Fix it, then Ship it!





addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 
634)


change to warn as we continue even without it



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 
1049)


remove toString



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 
1051)


Change to warn



addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
(line 1110)


Add a comment on why its disabled and when the test can be enabled



addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
(line 1163)


add assert that vertices contains a_guid and b_guid



addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
(line 1169)


Add assert that vertices contains sourceTableGUID


- Shwetha GS


On Sept. 26, 2016, 1:06 p.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52077/
> ---
> 
> (Updated Sept. 26, 2016, 1:06 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1184 and ATLAS-247
> https://issues.apache.org/jira/browse/ATLAS-1184
> https://issues.apache.org/jira/browse/ATLAS-247
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> After a CTAS query, lineage relationship between source columns and 
> destination column can be captured. This information can be used to create a 
> column lineage process.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java
>  PRE-CREATION 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> a3464a0 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
>  45f0bc9 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataTypes.java
>  e094cb6 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> a5838b4 
> 
> Diff: https://reviews.apache.org/r/52077/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>

Re: Review Request 52336: ReservedTypesRegistrar checks for existence of 1st class type

[Shwetha GS]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52336/#review150818
---


Ship it!




Ship It!

- Shwetha GS


On Sept. 28, 2016, 9:10 a.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52336/
> ---
> 
> (Updated Sept. 28, 2016, 9:10 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1184
> https://issues.apache.org/jira/browse/ATLAS-1184
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ReservedTypesRegistrar registers the models for supported integrations like 
> hive, falcon, sqoop and storm. ReservedTypesRegistrar reads the model files 
> and registers the types defined in the model file. The check thats done to 
> verify if the model is already registered - checks for existence of first 
> class type. This will not work if we add more class types to the existing 
> model or modify the existing type to add optional attributes.
> ReservedTypesRegistrar should check for every type in the model file. Also, 
> ReservedTypesRegistrar should do type update which does create if not exists, 
> and update if exists
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  41c0155 
>   repository/src/test/java/org/apache/atlas/TestUtils.java bd9df62 
>   
> repository/src/test/java/org/apache/atlas/services/ReservedTypesRegistrarTest.java
>  d602bd8 
> 
> Diff: https://reviews.apache.org/r/52336/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>

[jira] [Commented] (ATLAS-916) Return system attributes in get entity definition

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531917#comment-15531917
 ] 

Vimal Sharma commented on ATLAS-916:


Thanks [~dkantor]

> Return system attributes in get entity definition
> -
>
> Key: ATLAS-916
> URL: https://issues.apache.org/jira/browse/ATLAS-916
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Shwetha G S
>Assignee: Vimal Sharma
> Attachments: ATLAS-916.patch
>
>
> Atlas should maintain system attributes created time, last modified time, 
> created by user and last modified by user for every entity. This information 
> should be returned in get entity definition



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1201) using progaurd in android for cordova plugin

[lokesh (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531900#comment-15531900
 ] 

lokesh commented on ATLAS-1201:
---

Hi,

Thanks 

> using progaurd in android for cordova plugin
> 
>
> Key: ATLAS-1201
> URL: https://issues.apache.org/jira/browse/ATLAS-1201
> Project: Atlas
>  Issue Type: Bug
>Reporter: lokesh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)