----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52077/#review150821 -----------------------------------------------------------
Fix it, then Ship it! addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 634) <https://reviews.apache.org/r/52077/#comment218885> change to warn as we continue even without it addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 1049) <https://reviews.apache.org/r/52077/#comment218887> remove toString addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 1051) <https://reviews.apache.org/r/52077/#comment218886> Change to warn addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java (line 1110) <https://reviews.apache.org/r/52077/#comment218891> Add a comment on why its disabled and when the test can be enabled addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java (line 1163) <https://reviews.apache.org/r/52077/#comment218892> add assert that vertices contains a_guid and b_guid addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java (line 1169) <https://reviews.apache.org/r/52077/#comment218893> Add assert that vertices contains sourceTableGUID - Shwetha GS On Sept. 26, 2016, 1:06 p.m., Vimal Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52077/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 1:06 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1184 and ATLAS-247 > https://issues.apache.org/jira/browse/ATLAS-1184 > https://issues.apache.org/jira/browse/ATLAS-247 > > > Repository: atlas > > > Description > ------- > > After a CTAS query, lineage relationship between source columns and > destination column can be captured. This information can be used to create a > column lineage process. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java > PRE-CREATION > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > a3464a0 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java > 45f0bc9 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataTypes.java > e094cb6 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > a5838b4 > > Diff: https://reviews.apache.org/r/52077/diff/ > > > Testing > ------- > > > Thanks, > > Vimal Sharma > >
