Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code simplification
/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30ae webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de844 webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0 webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2 webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b8 webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de4 webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java f85892ac webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9 webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc638 webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc39 webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c830 webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121f Diff: https://reviews.apache.org/r/53789/diff/ Testing --- Unit Tests passing. Thanks, Apoorv Naik
Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code simplification
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53789/#review159373 --- typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java (line 100) <https://reviews.apache.org/r/53789/#comment230356> This change shouldn't be here. It's a wrong negation expression. - Apoorv Naik On Dec. 14, 2016, 8:40 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53789/ > --- > > (Updated Dec. 14, 2016, 8:40 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > Suma Shivaprasad, and Vimal Sharma. > > > Bugs: ATLAS-1304 > https://issues.apache.org/jira/browse/ATLAS-1304 > > > Repository: atlas > > > Description > --- > > Redundant code removal and code simplification > > > Diffs > - > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java > 0b918ba0 > > addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java > 8d0a47a6 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > cbc51cc4 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > cf8851c0 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java > 79a1afe7 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java > 5abf2dfe > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java > 0cba27ea > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 23a13ea3 > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java > edd95ba4 > > authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java > b42162fd > authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java > 9c50a040 > > authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java > e34c7403 > > authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java > e48c5ae7 > > authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java > 68362491 > > authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java > 2a6929a6 > > authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java > 9508eb3e > > authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java > 57156b78 > > authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java > 453364d7 > > authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java > 3453bf0e > > authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java > 8b27e2ea > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > ee9fbba6 > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > f111eb61 > catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java > d60e3f3c > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > 47d182cc > catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java > 78436c0c > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > 510378e4 > client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213b > client/src/main/java/org/apache/atlas/security/SecureClientUtils.java > e13d826e > client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891 > common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java > b60edef9 > > common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java > fb32ff55 > common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java > bf1175f4 > common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c43 > dashboardv2/public/js/views/tag/addTagModalView.js fdaea5bd > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java > 5d60c678 > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java > f2e0f9d6 > > graphdb/common/src/main/java/org/apache/atlas/repository/gr
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54233/ --- (Updated Dec. 15, 2016, 1:07 a.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad. Changes --- Rebased with latest master Bugs: ATLAS-1345 https://issues.apache.org/jira/browse/ATLAS-1345 Repository: atlas Description --- ATLAS-1345: Enhance search APIs to resolve hierarchical references Diffs (updated) - intg/src/main/java/org/apache/atlas/model/SearchFilter.java 93e89c8f89d970bb8dec728e3bece7aaa24665dc intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104699b48cfafad46e6cbe9c0e83ad26102 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8 repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7 repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java cdbde1b8cf00975752df80213d06015aff3fd308 webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 43414c9597b5c88c3e5fed45628abd1bbe0b9185 Diff: https://reviews.apache.org/r/54233/diff/ Testing --- UTs passing for AtlasTypedefStore Thanks, Apoorv Naik
Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code simplification
/rest/module/RestModule.java 62e1e578 webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30ae webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de844 webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0 webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2 webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b8 webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de4 webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java f85892ac webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9 webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc638 webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc39 webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c830 webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121f Diff: https://reviews.apache.org/r/53789/diff/ Testing --- Unit Tests passing. Thanks, Apoorv Naik
[jira] [Updated] (ATLAS-1304) Code cleanup and simplification
[ https://issues.apache.org/jira/browse/ATLAS-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1304: --- Attachment: ATLAS-1304.patch > Code cleanup and simplification > --- > > Key: ATLAS-1304 > URL: https://issues.apache.org/jira/browse/ATLAS-1304 > Project: Atlas > Issue Type: Improvement > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Attachments: ATLAS-1304.patch > > > This change addresses the following problems > 1. Lot of redundant code across modules. > 2. Simplification of boolean expressions > 3. Embrace JDK7 style (instead of List aList = new ArrayList(); it > should be List aList = new ArrayList<>();) > 4. Unnecessary typecasts -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Dec. 13, 2016, 11:30 p.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. Changes --- Addressed review comments. Bugs: ATLAS-1311 https://issues.apache.org/jira/browse/ATLAS-1311 Repository: atlas Description --- ATLAS-1311: Integration tests for the V2 Entity APIs Diffs (updated) - addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3 client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f41187 repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578 webapp/src/main/resources/spring-security.xml 4ba30255 webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2 webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b8 webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 Diff: https://reviews.apache.org/r/54058/diff/ Testing --- UTs and ITs are running fine. mvn clean install -Pdist was successful Thanks, Apoorv Naik
[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311.v5.patch > Integration tests for Entity V2 REST APIs > - > > Key: ATLAS-1311 > URL: https://issues.apache.org/jira/browse/ATLAS-1311 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1311-v2.patch, ATLAS-1311-v3.patch, > ATLAS-1311.patch, ATLAS-1311.v4.patch, ATLAS-1311.v5.patch > > > Currently there's no IT for the new REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
> On Dec. 6, 2016, 2:22 a.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java, line 197 > > <https://reviews.apache.org/r/54058/diff/4/?file=1573384#file1573384line197> > > > > add validations to have typename or supertype in the request to be > > provided mandatorily. Else it will end up running a query which may not be > > indexed. > > Apoorv Naik wrote: > I've added a todo section for this in the store class. Will be adding this as a part of the actual V2 implementation. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158102 ------- On Dec. 13, 2016, 6:47 a.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > --- > > (Updated Dec. 13, 2016, 6:47 a.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > --- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > - > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 23a13ea3 > client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f41187 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 84608d9d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 6b2b2166 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 5756adb5 > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b14 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c28 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1a > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207c > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd > webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java > 62e1e578 > webapp/src/main/resources/spring-security.xml 4ba30255 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2 > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > ec62112f > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > de0a459b > > webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java > 2a4babae > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 325c25b4 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > 7e4db13f > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > b5af111f > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > c681a0f9 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > ed37c3a1 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > 87bf9a89 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > --- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > >
Review Request 54722: ATLAS-1301: Client simplification and bugfixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54722/ --- Review request for atlas, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma. Bugs: ATLAS-1301 https://issues.apache.org/jira/browse/ATLAS-1301 Repository: atlas Description --- ATLAS-1301: Client simplification and bugfixes Diffs - client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 client/src/main/java/org/apache/atlas/ResourceCreator.java 53f92aac client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891 webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java 2b714896 webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 Diff: https://reviews.apache.org/r/54722/diff/ Testing --- UnitTests passing Integration tests passing Thanks, Apoorv Naik
[jira] [Updated] (ATLAS-1301) Client calls from the IT retries more than what's specified
[ https://issues.apache.org/jira/browse/ATLAS-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1301: --- Attachment: ATLAS-1301.patch > Client calls from the IT retries more than what's specified > --- > > Key: ATLAS-1301 > URL: https://issues.apache.org/jira/browse/ATLAS-1301 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1301.patch > > > The client refactoring led to nesting of two retry calls, so the retry > mechanism will end up running n*n time. > The patch fixes the nesting and simplifies the client API -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1245) More objects should have a unique guid
[ https://issues.apache.org/jira/browse/ATLAS-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745967#comment-15745967 ] Apoorv Naik commented on ATLAS-1245: Ok so in V2 we call trait as classification and during creation the type/entities are assigned a GUID. There's no change in the Catalog section though, not sure if that's where (taxonomy reference) you're looking to make a change. > More objects should have a unique guid > -- > > Key: ATLAS-1245 > URL: https://issues.apache.org/jira/browse/ATLAS-1245 > Project: Atlas > Issue Type: Improvement > Environment: >Reporter: David Radley >Assignee: David Radley > > Currently only some Atlas objects have guids. The entity REST API exposes > guids as the unique identifiers by which entities can be found. > Some objects like taxonomy have a guid internally but externally it is > referenced by name. My feeling is that an object can have a unique guid and a > unique name. > Some objects like trait and trait instance do not have guids at all. So their > management is tied to their name. > Having a unique identifier for all objects allows for common ways for them to > be managed, it also means that renames do not change the object identity. > We have system level attributes already. In a similar way I suggest we add in > guids to all objects. > Also at the graph level if every vertex has a guid property - which is > indexed, Gremlin queries are simpler (possibly more perfomant), and edges can > be created in a standard way by supplying the in and out guids. > I suggest types, traits and trait types gain a guid. > I can see that some artifacts like comments may not need an exposed guid. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ATLAS-1245) More objects should have a unique guid
[ https://issues.apache.org/jira/browse/ATLAS-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745967#comment-15745967 ] Apoorv Naik edited comment on ATLAS-1245 at 12/13/16 7:09 PM: -- Ok so in V2 we call trait/tag as classification and during creation the type/entities are assigned a GUID. There's no change in the Catalog section though, not sure if that's where (taxonomy reference) you're looking to make a change. was (Author: apoorvnaik): Ok so in V2 we call trait as classification and during creation the type/entities are assigned a GUID. There's no change in the Catalog section though, not sure if that's where (taxonomy reference) you're looking to make a change. > More objects should have a unique guid > -- > > Key: ATLAS-1245 > URL: https://issues.apache.org/jira/browse/ATLAS-1245 > Project: Atlas > Issue Type: Improvement > Environment: >Reporter: David Radley >Assignee: David Radley > > Currently only some Atlas objects have guids. The entity REST API exposes > guids as the unique identifiers by which entities can be found. > Some objects like taxonomy have a guid internally but externally it is > referenced by name. My feeling is that an object can have a unique guid and a > unique name. > Some objects like trait and trait instance do not have guids at all. So their > management is tied to their name. > Having a unique identifier for all objects allows for common ways for them to > be managed, it also means that renames do not change the object identity. > We have system level attributes already. In a similar way I suggest we add in > guids to all objects. > Also at the graph level if every vertex has a guid property - which is > indexed, Gremlin queries are simpler (possibly more perfomant), and edges can > be created in a standard way by supplying the in and out guids. > I suggest types, traits and trait types gain a guid. > I can see that some artifacts like comments may not need an exposed guid. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 53748: Updated equals and hashCode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53748/ --- (Updated Dec. 13, 2016, 6:52 a.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. Changes --- Rebased on latest changes. Bugs: ATLAS-1303 https://issues.apache.org/jira/browse/ATLAS-1303 Repository: atlas Description --- Updated equals and hashCode methods Using JDK7's built-in classes to simplify the code and make it more readable/understandable. Diffs (updated) - catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f4 client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab0 common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5f intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf7 intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74aeb intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585c intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java bedd4d93 intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bbf intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f41187 intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f336 intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91a intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java feae00d0 intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 1be5ee15 intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 0312176a intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b2 intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 16e03442 intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b31 notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e0 notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc8 repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cdeb117d typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 0b3ffe3c typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java a3f9421d typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f5562232 typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d9 typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a38 typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 80694224 typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2eed typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc8 webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76c Diff: https://reviews.apache.org/r/53748/diff/ Testing (updated) --- Unit tests passing. Thanks, Apoorv Naik
[jira] [Updated] (ATLAS-1303) Update hashCode and equals method to use standard JDK libraries
[ https://issues.apache.org/jira/browse/ATLAS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1303: --- Attachment: (was: 0001-Updated-equals-and-hashCode-signatures.patch) > Update hashCode and equals method to use standard JDK libraries > --- > > Key: ATLAS-1303 > URL: https://issues.apache.org/jira/browse/ATLAS-1303 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1303.patch > > > Currently all the hashCode and equals methods use numerous if-else branches > to determine the result. This change uses the existing JDK7 > Objects.equals(...) and Objects.hashCode(...) instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1303) Update hashCode and equals method to use standard JDK libraries
[ https://issues.apache.org/jira/browse/ATLAS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1303: --- Attachment: ATLAS-1303.patch > Update hashCode and equals method to use standard JDK libraries > --- > > Key: ATLAS-1303 > URL: https://issues.apache.org/jira/browse/ATLAS-1303 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1303.patch > > > Currently all the hashCode and equals methods use numerous if-else branches > to determine the result. This change uses the existing JDK7 > Objects.equals(...) and Objects.hashCode(...) instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311.v4.patch > Integration tests for Entity V2 REST APIs > - > > Key: ATLAS-1311 > URL: https://issues.apache.org/jira/browse/ATLAS-1311 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1311-v2.patch, ATLAS-1311-v3.patch, > ATLAS-1311.patch, ATLAS-1311.v4.patch > > > Currently there's no IT for the new REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Dec. 13, 2016, 6:47 a.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. Changes --- IT passing for webapp module. Bugs: ATLAS-1311 https://issues.apache.org/jira/browse/ATLAS-1311 Repository: atlas Description --- ATLAS-1311: Integration tests for the V2 Entity APIs Diffs (updated) - addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3 client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f41187 repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578 webapp/src/main/resources/spring-security.xml 4ba30255 webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2 webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 Diff: https://reviews.apache.org/r/54058/diff/ Testing --- UTs and ITs are running fine. mvn clean install -Pdist was successful Thanks, Apoorv Naik
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
> On Dec. 6, 2016, 2:42 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java, > > line 486 > > <https://reviews.apache.org/r/54058/diff/4/?file=1573393#file1573393line486> > > > > would be good to add columns attribute since its a composite attribute Column additions are present in the test code, so I think we can skip it here. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158111 --- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > --- > > (Updated Nov. 30, 2016, 11:22 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > --- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > - > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 23a13ea > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f4118 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 84608d9 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 5756adb > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b1 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c2 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f > webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java > 62e1e57 > webapp/src/main/resources/spring-security.xml 4ba3025 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 081d5ca > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > de0a459 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 1777f75 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > d9f14d0 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 38c823a > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > cf25814 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > 13ef503 > > webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java > 2fa1602 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > fd15544 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > --- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > >
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
> On Dec. 6, 2016, 2:22 a.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java, line 197 > > <https://reviews.apache.org/r/54058/diff/4/?file=1573384#file1573384line197> > > > > add validations to have typename or supertype in the request to be > > provided mandatorily. Else it will end up running a query which may not be > > indexed. I've added a todo section for this in the store class. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158102 ------- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > --- > > (Updated Nov. 30, 2016, 11:22 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > --- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > - > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 23a13ea > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f4118 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 84608d9 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 5756adb > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b1 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c2 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f > webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java > 62e1e57 > webapp/src/main/resources/spring-security.xml 4ba3025 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 081d5ca > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > de0a459 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 1777f75 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > d9f14d0 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 38c823a > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > cf25814 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > 13ef503 > > webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java > 2fa1602 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > fd15544 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > --- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > >
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
> On Dec. 6, 2016, 2:48 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java, > > line 288 > > <https://reviews.apache.org/r/54058/diff/4/?file=1573397#file1573397line288> > > > > is this not available for test already in the same patch through > > EntitiesREST.searchEntities? > > Apoorv Naik wrote: > Search was marked as a todo feature, hence added a todo here as well. The search functionality is being added to the store, right now the code doesn't utilize the store code. Once that's in place we can add corresponding tests. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158113 ------- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > --- > > (Updated Nov. 30, 2016, 11:22 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > --- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > - > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 23a13ea > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f4118 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 84608d9 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 5756adb > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b1 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c2 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f > webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java > 62e1e57 > webapp/src/main/resources/spring-security.xml 4ba3025 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 081d5ca > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > de0a459 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 1777f75 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > d9f14d0 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 38c823a > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > cf25814 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > 13ef503 > > webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java > 2fa1602 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > fd15544 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > --- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > >
[jira] [Created] (ATLAS-1370) Built-in API testbed
Apoorv Naik created ATLAS-1370: -- Summary: Built-in API testbed Key: ATLAS-1370 URL: https://issues.apache.org/jira/browse/ATLAS-1370 Project: Atlas Issue Type: Improvement Affects Versions: 0.8-incubating Reporter: Apoorv Naik Fix For: 0.8-incubating Currently there's no UI that lists down all the API implemented within Atlas. The tech docs are a good source of understanding Atlas APIs but I feel a visual tool (something like an built-in postman client) would be a good addition for developers to setup atlas and start playing around with the APIs. Swagger has really good capabilities and there are a couple of other tools too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1318) Atlas Type System does not have DELETE API
[ https://issues.apache.org/jira/browse/ATLAS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743056#comment-15743056 ] Apoorv Naik commented on ATLAS-1318: Right now there's an experimental API in the TypesREST class. Please follow that code path to see how this use case fits into the new REST APIs. Logic wise the deletion looks good, it everyone's OK you can enhance the DELETE API for TypesREST, EntityREST and EntitiesREST. Please do not make any changes to the TypesResource or EntityResource as they're marked for deprecation. > Atlas Type System does not have DELETE API > -- > > Key: ATLAS-1318 > URL: https://issues.apache.org/jira/browse/ATLAS-1318 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Zineng Yuan > > I am trying to extend Atlas Type System by adding custom data type. However, > when I found a type name was misspecified and needed to be recreated, I can't > find a Restful Delete API. > Question is does Atlas expose a Delete API for custom data types/attributes? > Without this delete API, it's difficult to rely on Atlas as a meta store to > extend custom data. > Please do suggest how to recreate a data type in this case. Thank you! > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 54430: Atlas-1186: Add glossary Categories
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54430/#review158352
---
catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java (line 115)
<https://reviews.apache.org/r/54430/#comment229113>
I think the methods referring to any graph element shouldn't be here as
this is an abstraction for the typesystem.
catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java (line 61)
<https://reviews.apache.org/r/54430/#comment229114>
Looks like your system is using tabs, can you revert to spaces for better
code alignment.
catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java (line 99)
<https://reviews.apache.org/r/54430/#comment229115>
No concatenations in the info string, please use template/variable
placeholder "{}"
catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java (line 114)
<https://reviews.apache.org/r/54430/#comment229116>
Same here.
catalog/src/main/java/org/apache/atlas/catalog/GlossaryCategoryResourceProvider.java
(line 58)
<https://reviews.apache.org/r/54430/#comment229118>
Template instead of string concatenation.
- Apoorv Naik
On Dec. 7, 2016, 2:42 p.m., David Radley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54430/
> ---
>
> (Updated Dec. 7, 2016, 2:42 p.m.)
>
>
> Review request for atlas, DaveEL DaveEL, Shwetha GS, and Hemanth Yamijala.
>
>
> Repository: atlas
>
>
> Description
> ---
>
> I am looking to make this a small minimum viable contribution evolutionary
> change rather than a revolutionary change and have raised follow on
> enhancements in Jiras listed below. I do not see the need for a new version
> of API with these changes as the APIs are either new or introduce optional
> parameters to existing requests and add extra fields in responses. All of
> this should be tolerated by existing apps. For example the Atlas UI still
> works as before .
>
> 1) I have adding a glossary category to a taxonomy. It creates an edge in the
> graph between the taxonomy (an entity) and the glossary category (an entity)
> 2) I can do basic updates and gets for the category (change the description
> and rename).
> 3) I can add child categories to categories. The children properties are
> derived from the edges in the graph, via projections and relationships
> 4) You may wonder why the category is an entity not a type or a trait or a
> trait instance. It seems that only entities have unique uuids called guids. I
> have raised Jira 1245 to get more of these important objects having a guid -
> but in the meantime categories are entities
> 5) I can add terms (and subterms) to categories - terms are traits and trait
> instances. So to go with the code I have amended addtrait to create a new
> edge if a parent category has been specified.
> 6) I can update the parent category to another category (as long it is in the
> same taxonomy, not replacing the top category or trying to add to my children
> or to myself).
> 7) I was thinking of adds and updates not allowed if the name clashes with
> one of the categories parents children.(I will upper case the strings for the
> compare). there is a case to not have this check and allow duplicate named
> child categories - which could have a different description or different
> categories & terms attached. It will work without this restriction; which I
> have not coded - maybe this could be on optional constraint held in Ranger.
> 8) Part of this change exposes the guid for the taxonomy on the API.
> 9) For deletes, I will delete a category. The delete will fail if the
> category has children categories or terms. The delete is a soft delete for
> the vertex.
> 10) I could expose soft deletes, either using the existing isDeleted flag or
> introduce a non editable end date which I would need to check. This would
> leave an audit trail in the graph. But we would need a hard delete as well .
> I am not sure the performance implications of a proliferation of old vertices
> in the graph (I would hard delete edges). So for the moment I am leaning
> towards adding hard deletes.
> 11) At the moment I have just added to the existing V1 taxonomy API, as I
> have only added optional fields to existing objects and returned more
> information, so the APIs are not being changed in an incompatible way.
> 12) I notice that transactions are committed operation by operation -
[jira] [Commented] (ATLAS-1245) More objects should have a unique guid
[ https://issues.apache.org/jira/browse/ATLAS-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742654#comment-15742654 ] Apoorv Naik commented on ATLAS-1245: Hey David, There are new v2 APIs in place in which all the types and entities have GUIDs. Can you check if that suffices ? > More objects should have a unique guid > -- > > Key: ATLAS-1245 > URL: https://issues.apache.org/jira/browse/ATLAS-1245 > Project: Atlas > Issue Type: Improvement > Environment: >Reporter: David Radley >Assignee: David Radley > > Currently only some Atlas objects have guids. The entity REST API exposes > guids as the unique identifiers by which entities can be found. > Some objects like taxonomy have a guid internally but externally it is > referenced by name. My feeling is that an object can have a unique guid and a > unique name. > Some objects like trait and trait instance do not have guids at all. So their > management is tied to their name. > Having a unique identifier for all objects allows for common ways for them to > be managed, it also means that renames do not change the object identity. > We have system level attributes already. In a similar way I suggest we add in > guids to all objects. > Also at the graph level if every vertex has a guid property - which is > indexed, Gremlin queries are simpler (possibly more perfomant), and edges can > be created in a standard way by supplying the in and out guids. > I suggest types, traits and trait types gain a guid. > I can see that some artifacts like comments may not need an exposed guid. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1363) Upgrade front end maven plugin to 1.0
[
https://issues.apache.org/jira/browse/ATLAS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736127#comment-15736127
]
Apoorv Naik commented on ATLAS-1363:
+1
> Upgrade front end maven plugin to 1.0
> -
>
> Key: ATLAS-1363
> URL: https://issues.apache.org/jira/browse/ATLAS-1363
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Suma Shivaprasad
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1363.patch
>
>
> Upgrading frontend-maven-plugin to resolve build failures in SUSE/Ubuntu
> issue -
> {noformat}
> 2016/12/09 14:50:04 INFO: [ERROR] Failed to execute goal
> com.github.eirslett:frontend-maven-plugin:0.0.29:install-node-and-npm
> (install node and npm) on project atlas-dashboardv2: Could not extract the
> Node archive: Could not extract archive:
> '/grid/0/jenkins/.m2/repository/com/github/eirslett/node/4.4.2/node-4.4.2-linux-x64.tar.gz':
> EOFException -> [Help 1]
> I did little bit of digging into this issue. This issue looks like a problem
> with frontend-maven-plugin. When fronend-maven-plugin download the tar.gz
> from http://nodejs.org content-type is "application/octet-stream" and when it
> downloads from cache the content-type ids "application/x-gzip". This issue is
> fixed in frontend-maven-plugin version 1.0. Here is the complete analysis of
> this issue:
> https://github.com/eirslett/frontend-maven-plugin/issues/225
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ATLAS-1358) NPE in AtlasTypedefStoreTest after SearchFilter changes
[ https://issues.apache.org/jira/browse/ATLAS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1358: --- Attachment: ATLAS-1358.1.patch Few more fixes are ITs were failing > NPE in AtlasTypedefStoreTest after SearchFilter changes > --- > > Key: ATLAS-1358 > URL: https://issues.apache.org/jira/browse/ATLAS-1358 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1358.1.patch, ATLAS-1358.patch > > > Recent search filter changes introduced an NPE in the test code. This patch > fixes the bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ATLAS-1360) Actual UnitTests instead of ITs disguised as UTs
Apoorv Naik created ATLAS-1360: -- Summary: Actual UnitTests instead of ITs disguised as UTs Key: ATLAS-1360 URL: https://issues.apache.org/jira/browse/ATLAS-1360 Project: Atlas Issue Type: Wish Affects Versions: 0.8-incubating Reporter: Apoorv Naik Fix For: 0.8-incubating Currently all Unit test do actual module injection and they act more like integration tests. Actual unit tests should only test a single class or unit and all the dependencies should be mocked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1345) V2 Search API enhancement to honor hierarchical references
[ https://issues.apache.org/jira/browse/ATLAS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1345: --- Attachment: ATLAS-1345.1.patch > V2 Search API enhancement to honor hierarchical references > -- > > Key: ATLAS-1345 > URL: https://issues.apache.org/jira/browse/ATLAS-1345 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1345.1.patch, ATLAS-1345.patch > > > Currently there's no REST API that can resolve all supertypes for a given > type name or entity name. This change introduces new REST endpoint that will > yield all supertypes for a given typename. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54233/ --- (Updated Dec. 8, 2016, 9:08 p.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad. Changes --- Added UTs for new search function. Bugs: ATLAS-1345 https://issues.apache.org/jira/browse/ATLAS-1345 Repository: atlas Description --- ATLAS-1345: Enhance search APIs to resolve hierarchical references Diffs (updated) - intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104699b48cfafad46e6cbe9c0e83ad26102 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8 repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7 repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java cdbde1b8cf00975752df80213d06015aff3fd308 webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649 Diff: https://reviews.apache.org/r/54233/diff/ Testing --- UTs passing for AtlasTypedefStore Thanks, Apoorv Naik
[jira] [Created] (ATLAS-1359) Move new client classes to atlas-intg
Apoorv Naik created ATLAS-1359: -- Summary: Move new client classes to atlas-intg Key: ATLAS-1359 URL: https://issues.apache.org/jira/browse/ATLAS-1359 Project: Atlas Issue Type: Improvement Affects Versions: 0.8-incubating Reporter: Apoorv Naik Assignee: Apoorv Naik Fix For: 0.8-incubating Currently V2 classes are located under atlas-client. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1358) NPE in AtlasTypedefStoreTest after SearchFilter changes
[ https://issues.apache.org/jira/browse/ATLAS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732936#comment-15732936 ] Apoorv Naik commented on ATLAS-1358: UnitTests running correctly now. I haven't been able to run Integration tests successfully on my system ever (so hopefully this won't break that). > NPE in AtlasTypedefStoreTest after SearchFilter changes > --- > > Key: ATLAS-1358 > URL: https://issues.apache.org/jira/browse/ATLAS-1358 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1358.patch > > > Recent search filter changes introduced an NPE in the test code. This patch > fixes the bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1358) NPE in AtlasTypedefStoreTest after SearchFilter changes
[ https://issues.apache.org/jira/browse/ATLAS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1358: --- Attachment: ATLAS-1358.patch > NPE in AtlasTypedefStoreTest after SearchFilter changes > --- > > Key: ATLAS-1358 > URL: https://issues.apache.org/jira/browse/ATLAS-1358 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1358.patch > > > Recent search filter changes introduced an NPE in the test code. This patch > fixes the bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ATLAS-1358) NPE in AtlasTypedefStoreTest after SearchFilter changes
Apoorv Naik created ATLAS-1358: -- Summary: NPE in AtlasTypedefStoreTest after SearchFilter changes Key: ATLAS-1358 URL: https://issues.apache.org/jira/browse/ATLAS-1358 Project: Atlas Issue Type: Bug Affects Versions: 0.8-incubating Reporter: Apoorv Naik Assignee: Apoorv Naik Fix For: 0.8-incubating Recent search filter changes introduced an NPE in the test code. This patch fixes the bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1357) Fix for failures from ATLAS-1307
[ https://issues.apache.org/jira/browse/ATLAS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1357: --- Attachment: ATLAS-1357.patch > Fix for failures from ATLAS-1307 > > > Key: ATLAS-1357 > URL: https://issues.apache.org/jira/browse/ATLAS-1357 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1357.patch > > > Recent refactoring included simplification of the callAPI methods which led > to ambiguity and hence the GET calls were getting translated to a POST call > causing all the failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ATLAS-1357) Fix for failures from ATLAS-1307
Apoorv Naik created ATLAS-1357: -- Summary: Fix for failures from ATLAS-1307 Key: ATLAS-1357 URL: https://issues.apache.org/jira/browse/ATLAS-1357 Project: Atlas Issue Type: Bug Affects Versions: 0.8-incubating Reporter: Apoorv Naik Assignee: Apoorv Naik Fix For: 0.8-incubating Recent refactoring included simplification of the callAPI methods which led to ambiguity and hence the GET calls were getting translated to a POST call causing all the failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
> On Dec. 6, 2016, 2:25 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java, > > line 104 > > <https://reviews.apache.org/r/54058/diff/4/?file=1573392#file1573392line104> > > > > Use constants for qualifiedName, clusterName in all the tests will do. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158107 --- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > --- > > (Updated Nov. 30, 2016, 11:22 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > --- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > - > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 23a13ea > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f4118 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 84608d9 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 5756adb > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b1 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c2 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f > webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java > 62e1e57 > webapp/src/main/resources/spring-security.xml 4ba3025 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 081d5ca > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > de0a459 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 1777f75 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > d9f14d0 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 38c823a > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > cf25814 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > 13ef503 > > webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java > 2fa1602 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > fd15544 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > --- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > >
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
> On Dec. 6, 2016, 2:45 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java, > > line 123 > > <https://reviews.apache.org/r/54058/diff/4/?file=1573397#file1573397line123> > > > > will cause timing issues if we dont wait and match the notification > > that we need here. Was debugging hence commented it out. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158112 ------- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > --- > > (Updated Nov. 30, 2016, 11:22 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > --- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > - > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 23a13ea > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f4118 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 84608d9 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 5756adb > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b1 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c2 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f > webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java > 62e1e57 > webapp/src/main/resources/spring-security.xml 4ba3025 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 081d5ca > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > de0a459 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 1777f75 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > d9f14d0 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 38c823a > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > cf25814 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > 13ef503 > > webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java > 2fa1602 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > fd15544 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > --- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > >
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
> On Dec. 6, 2016, 2:48 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java, > > line 288 > > <https://reviews.apache.org/r/54058/diff/4/?file=1573397#file1573397line288> > > > > is this not available for test already in the same patch through > > EntitiesREST.searchEntities? Search was marked as a todo feature, hence added a todo here as well. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158113 ------- On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > --- > > (Updated Nov. 30, 2016, 11:22 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > --- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > - > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 23a13ea > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f4118 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 84608d9 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 5756adb > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b1 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c2 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f > webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java > 62e1e57 > webapp/src/main/resources/spring-security.xml 4ba3025 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 081d5ca > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > de0a459 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 1777f75 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > d9f14d0 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 38c823a > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > cf25814 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > 13ef503 > > webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java > 2fa1602 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > fd15544 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > --- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > >
[jira] [Updated] (ATLAS-1355) Removal of superType during type updates results in a 500 Internal Server error
[
https://issues.apache.org/jira/browse/ATLAS-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Naik updated ATLAS-1355:
---
Attachment: ATLAS-1355.patch
> Removal of superType during type updates results in a 500 Internal Server
> error
> ---
>
> Key: ATLAS-1355
> URL: https://issues.apache.org/jira/browse/ATLAS-1355
> Project: Atlas
> Issue Type: Bug
>Reporter: Suma Shivaprasad
> Assignee: Apoorv Naik
> Attachments: ATLAS-1355.patch
>
>
> {noformat}
> 2016-12-06 15:19:26,398 INFO - [main:] ~ Testing going to start for:
> org.apache.atlas.regression.tests.TypeUpdateResourceTest.removeClassSuperTypeWithNewClassSuperType([])
> (TestNGListener:44)
> 2016-12-06 15:19:26,399 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Request Url:
> http://ctr-e64-1480733150053-3726-01-04.hwx.site:21000/api/atlas/types?user.name=hrt_qa
> (BaseRequest:165)
> 2016-12-06 15:19:26,399 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Request Method: POST
> (BaseRequest:166)
> 2016-12-06 15:19:26,399 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Request Header:
> Name=Content-Type Value=application/json; charset=UTF-8 (BaseRequest:169)
> 2016-12-06 15:19:26,399 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Request Header:
> Name=Authorization Value=Basic YWRtaW46YWRtaW4= (BaseRequest:169)
> 2016-12-06 15:19:26,560 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Status: HTTP/1.1
> 201 Created (BaseRequest:196)
> 2016-12-06 15:19:26,560 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header: Name=Date
> Value=Tue, 06 Dec 2016 15:19:26 GMT (BaseRequest:198)
> 2016-12-06 15:19:26,560 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header:
> Name=Set-Cookie
> Value=ATLASSESSIONID=1cmr75ljl1zrs1d23ibpkhme4a;Path=/;HttpOnly
> (BaseRequest:198)
> 2016-12-06 15:19:26,562 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header:
> Name=Expires Value=Thu, 01 Jan 1970 00:00:00 GMT (BaseRequest:198)
> 2016-12-06 15:19:26,562 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header:
> Name=Content-Type Value=application/json; charset=UTF-8 (BaseRequest:198)
> 2016-12-06 15:19:26,563 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header:
> Name=Transfer-Encoding Value=chunked (BaseRequest:198)
> 2016-12-06 15:19:26,563 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header:
> Name=Server Value=Jetty(9.2.12.v20150709) (BaseRequest:198)
> 2016-12-06 15:19:26,563 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Request Url:
> http://ctr-e64-1480733150053-3726-01-04.hwx.site:21000/api/atlas/types?user.name=hrt_qa
> (BaseRequest:165)
> 2016-12-06 15:19:26,563 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Request Method: POST
> (BaseRequest:166)
> 2016-12-06 15:19:26,564 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Request Header:
> Name=Content-Type Value=application/json; charset=UTF-8 (BaseRequest:169)
> 2016-12-06 15:19:26,564 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Request Header:
> Name=Authorization Value=Basic YWRtaW46YWRtaW4= (BaseRequest:169)
> 2016-12-06 15:19:26,719 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Status: HTTP/1.1
> 201 Created (BaseRequest:196)
> 2016-12-06 15:19:26,719 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header: Name=Date
> Value=Tue, 06 Dec 2016 15:19:26 GMT (BaseRequest:198)
> 2016-12-06 15:19:26,719 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header:
> Name=Set-Cookie
> Value=ATLASSESSIONID=1qg5zxeqx69kyycz1hfj3nzaj;Path=/;HttpOnly
> (BaseRequest:198)
> 2016-12-06 15:19:26,720 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header:
> Name=Expires Value=Thu, 01 Jan 1970 00:00:00 GMT (BaseRequest:198)
> 2016-12-06 15:19:26,720 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header:
> Name=Content-Type Value=application/json; charset=UTF-8 (BaseRequest:198)
> 2016-12-06 15:19:26,720 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header:
> Name=Transfer-Encoding Value=chunked (BaseRequest:198)
> 2016-12-06 15:19:26,720 INFO -
> [main:removeClassSuperTypeWithNewClassSuperType] ~ Response Header:
> Name=Server Value=Jetty(9.2.12.v20150709) (BaseRequest:198)
&g
Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.
> On Dec. 7, 2016, 3:54 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java, > > line 102 > > <https://reviews.apache.org/r/53960/diff/1-2/?file=1568170#file1568170line102> > > > > use constantf for qualifiedName and hive_db Will fix as a part of ATLAS-1311 - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53960/#review158293 --- On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53960/ > --- > > (Updated Dec. 7, 2016, 12:30 a.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1307 > https://issues.apache.org/jira/browse/ATLAS-1307 > > > Repository: atlas > > > Description > --- > > ATLAS-1307: Integration test calls routing via the Client. > > > Diffs > - > > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a > client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 081d5ca > > webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java > e7af0b2 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 1777f75 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > d9f14d0 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 38c823a > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > cf25814 > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > 13ef503 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > fd15544 > > Diff: https://reviews.apache.org/r/53960/diff/ > > > Testing > --- > > All tests passing > > > Thanks, > > Apoorv Naik > >
Review Request 54500: ATLAS-1355: Fix for bad error translation from V2 API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54500/ --- Review request for atlas, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma. Bugs: ATLAS-1355 https://issues.apache.org/jira/browse/ATLAS-1355 Repository: atlas Description --- ATLAS-1355: Fix for bad error translation from V2 API Diffs - webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 355fb8ddc9be7800f60c339a4f31990824142cf0 webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649 Diff: https://reviews.apache.org/r/54500/diff/ Testing --- Unit tests passing. IT run pending. Thanks, Apoorv Naik
Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.
> On Dec. 7, 2016, 3:56 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java, > > line 68 > > <https://reviews.apache.org/r/53960/diff/2/?file=1578164#file1578164line68> > > > > switch to the modified API wo null for this IT Can't do here as the signature causes conflicts and some other methods are affected by this change too. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53960/#review158294 --- On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53960/ > --- > > (Updated Dec. 7, 2016, 12:30 a.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1307 > https://issues.apache.org/jira/browse/ATLAS-1307 > > > Repository: atlas > > > Description > --- > > ATLAS-1307: Integration test calls routing via the Client. > > > Diffs > - > > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a > client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 081d5ca > > webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java > e7af0b2 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 1777f75 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > d9f14d0 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 38c823a > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > cf25814 > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > 13ef503 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > fd15544 > > Diff: https://reviews.apache.org/r/53960/diff/ > > > Testing > --- > > All tests passing > > > Thanks, > > Apoorv Naik > >
[jira] [Commented] (ATLAS-1353) Invalid error message(500 internal server error) for lineage query on non-existing table.
[
https://issues.apache.org/jira/browse/ATLAS-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727724#comment-15727724
]
Apoorv Naik commented on ATLAS-1353:
Looks good to me. +1
> Invalid error message(500 internal server error) for lineage query on
> non-existing table.
> -
>
> Key: ATLAS-1353
> URL: https://issues.apache.org/jira/browse/ATLAS-1353
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Ayub Khan
>Assignee: Suma Shivaprasad
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1353.patch
>
>
> Invalid error message(500 internal server error) for lineage query on
> non-existing table.
> Expected: 404 not found.
> {noformat}
> 2016-12-06 13:45:20,923 ERROR - [pool-2-thread-9 -
> cfcab1af-7b81-475e-a879-7d2d66a3de47:hrt_qa:GET/api/atlas/lineage/thisisinvaliddvwotwiefq/outputs/graph]
> ~ Unable to get lineage outputs graph for entity
> guid=thisisinvaliddvwotwiefq (DataSetLineageResource:123)
> org.apache.atlas.exception.AtlasBaseException: Given instance guid
> thisisinvaliddvwotwiefq is invalid
> at
> org.apache.atlas.discovery.EntityLineageService.getAtlasLineageInfo(EntityLineageService.java:82)
> at
> org.apache.atlas.web.resources.LineageResource.outputsGraph(LineageResource.java:114)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
> at
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
> at
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
> at
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
> at
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
> at
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
> at
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
> at
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
> at
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
> at
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)
> at
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:286)
> at
> com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:276)
> at
> com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:181)
> at
> com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)
> at
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)
> at
> org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:73)
> at
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
> at
> com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:120)
> at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:135)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
> at
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.d
[jira] [Commented] (ATLAS-1342) Titan Solrclient - Add timeouts for zookeeper connect and session
[ https://issues.apache.org/jira/browse/ATLAS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727721#comment-15727721 ] Apoorv Naik commented on ATLAS-1342: Changes look good at a higher level. > Titan Solrclient - Add timeouts for zookeeper connect and session > - > > Key: ATLAS-1342 > URL: https://issues.apache.org/jira/browse/ATLAS-1342 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating, 0.8-incubating >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad > Fix For: 0.8-incubating > > Attachments: ATLAS-1342.1.patch, ATLAS-1342.patch > > > Currently the Solr5Index class which is shaded from Titan doesnt have session > and connect timeouts configurable. Need to do this so that we avoid session > timeout related issues when ATLAS server is busy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references
> On Dec. 6, 2016, 10:31 p.m., Apoorv Naik wrote: > > repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java, > > line 122 > > <https://reviews.apache.org/r/54233/diff/1/?file=1573340#file1573340line122> > > > > The type parameter is passed in as a query param, this the toUpperCase > > for that and then the comparison. The other option is to try getting an > > enum from that value if that fails return false. > > Suma Shivaprasad wrote: > yeah I think getting an enum if more efficient Since we've moved from Class to Entity and Trait to Classification with the new APIs deriving from the Enum.valueOf will still require two if checks for these cases. So I think this is better here. Dropping the issue. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54233/#review158234 --- On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54233/ > --- > > (Updated Nov. 30, 2016, 10:33 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma > Shivaprasad. > > > Bugs: ATLAS-1345 > https://issues.apache.org/jira/browse/ATLAS-1345 > > > Repository: atlas > > > Description > --- > > ATLAS-1345: Enhance search APIs to resolve hierarchical references > > > Diffs > - > > intg/src/main/java/org/apache/atlas/model/SearchFilter.java > b5f6c3af739ebd1383cfccc99b80abf8309803dc > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 816832b912130e89279cd6cd3e8c3e94c85fa6a8 > repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java > d7e38b8d6423358751b3423b2695a00b126701b7 > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java > 867307f04d380b7b1296c2794722b5499d6e6649 > > Diff: https://reviews.apache.org/r/54233/diff/ > > > Testing > --- > > UTs passing for AtlasTypedefStore > > > Thanks, > > Apoorv Naik > >
[jira] [Updated] (ATLAS-1307) All Integration tests should route the calls through the Client
[ https://issues.apache.org/jira/browse/ATLAS-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1307: --- Attachment: ATLAS-1307.1.patch > All Integration tests should route the calls through the Client > > > Key: ATLAS-1307 > URL: https://issues.apache.org/jira/browse/ATLAS-1307 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1307.1.patch > > > Currently there's a mix of calling patterns. Some ITs go through the > Atlas*Client and some operate on the web resource directly. There should be > consistent code across the code base. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53960/ --- (Updated Dec. 7, 2016, 12:30 a.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. Bugs: ATLAS-1307 https://issues.apache.org/jira/browse/ATLAS-1307 Repository: atlas Description --- ATLAS-1307: Integration test calls routing via the Client. Diffs - client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 Diff: https://reviews.apache.org/r/53960/diff/ Testing --- All tests passing Thanks, Apoorv Naik
Re: Review Request 53748: Updated equals and hashCode
> On Nov. 17, 2016, 8:01 p.m., Sarath Subramanian wrote: > > client/src/main/java/org/apache/atlas/EntityAuditEvent.java, line 57 > > <https://reviews.apache.org/r/53748/diff/1/?file=1563757#file1563757line57> > > > > we can also consider using the commons lang - EqualsBuilder and > > HashCodeBuilder. Same here, absolute preference for JDK utils over third-party libraries. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53748/#review156234 --- On Nov. 29, 2016, 8:38 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53748/ > --- > > (Updated Nov. 29, 2016, 8:38 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1303 > https://issues.apache.org/jira/browse/ATLAS-1303 > > > Repository: atlas > > > Description > --- > > Updated equals and hashCode methods > > Using JDK7's built-in classes to simplify the code and make it more > readable/understandable. > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f > client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab > common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > d9c74ae > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java > 4ddd585 > intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java > bedd4d9 > intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f4118 > intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java > e489f33 > intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java > 61b7f91 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java > feae00d > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java > 1be5ee1 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java > 0312176 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > 16e0344 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java > a3929b3 > > notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java > fda588e > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > ed5b9fc > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > cdeb117 > typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java > 0b3ffe3 > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java > a3f9421 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java > f556223 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java > 9cb0d0d > > typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java > ac3b5a3 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java > 8069422 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java > 18ef2ee > > typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java > c9316cc > webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76 > > Diff: https://reviews.apache.org/r/53748/diff/ > > > Testing > --- > > Working on executing all tests > > > Thanks, > > Apoorv Naik > >
Re: Review Request 53748: Updated equals and hashCode
> On Nov. 17, 2016, 1:37 a.m., Suma Shivaprasad wrote: > > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java, line 87 > > <https://reviews.apache.org/r/53748/diff/1/?file=1563756#file1563756line87> > > > > Can we switch to/think of using Lombok instead which would make the > > code more concise and less error prone - > > https://projectlombok.org/features/index.html. We could use it later for > > Getter/Setters and other useful features > > Apoorv Naik wrote: > Sure I can give it a try. Is MIT licensing ok with ASF projects ? > > Suma Shivaprasad wrote: > Yes it is compatible. Pls include the license in the LICENSE file it it > doesnt exist already. Dropping the issue for now as Madhan wants to discuss this further. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53748/#review156164 ------- On Nov. 29, 2016, 8:38 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53748/ > --- > > (Updated Nov. 29, 2016, 8:38 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1303 > https://issues.apache.org/jira/browse/ATLAS-1303 > > > Repository: atlas > > > Description > --- > > Updated equals and hashCode methods > > Using JDK7's built-in classes to simplify the code and make it more > readable/understandable. > > > Diffs > - > > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f > client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab > common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > d9c74ae > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java > 4ddd585 > intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java > bedd4d9 > intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f4118 > intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java > e489f33 > intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java > 61b7f91 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java > feae00d > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java > 1be5ee1 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java > 0312176 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > 16e0344 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java > a3929b3 > > notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java > fda588e > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > ed5b9fc > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > cdeb117 > typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java > 0b3ffe3 > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java > a3f9421 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java > f556223 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java > 9cb0d0d > > typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java > ac3b5a3 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java > 8069422 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java > 18ef2ee > > typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java > c9316cc > webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76 > > Diff: https://reviews.apache.org/r/53748/diff/ > > > Testing > --- > > Working on executing all tests > > > Thanks, > > Apoorv Naik > >
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54233/#review158237 --- repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java (line 859) <https://reviews.apache.org/r/54233/#comment229030> The reason for transformation is to actually resolve all hierarchical supertypes till the parent typedef. Currently the type registry deals with the TypeDef instead of *Type which means that the supertype resolution doesn't happen, so only immediate supertypes pass through the filter. - Apoorv Naik On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54233/ > --- > > (Updated Nov. 30, 2016, 10:33 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma > Shivaprasad. > > > Bugs: ATLAS-1345 > https://issues.apache.org/jira/browse/ATLAS-1345 > > > Repository: atlas > > > Description > --- > > ATLAS-1345: Enhance search APIs to resolve hierarchical references > > > Diffs > - > > intg/src/main/java/org/apache/atlas/model/SearchFilter.java > b5f6c3af739ebd1383cfccc99b80abf8309803dc > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 816832b912130e89279cd6cd3e8c3e94c85fa6a8 > repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java > d7e38b8d6423358751b3423b2695a00b126701b7 > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java > 867307f04d380b7b1296c2794722b5499d6e6649 > > Diff: https://reviews.apache.org/r/54233/diff/ > > > Testing > --- > > UTs passing for AtlasTypedefStore > > > Thanks, > > Apoorv Naik > >
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54233/#review158234 --- repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java (line 122) <https://reviews.apache.org/r/54233/#comment229027> The type parameter is passed in as a query param, this the toUpperCase for that and then the comparison. The other option is to try getting an enum from that value if that fails return false. - Apoorv Naik On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54233/ > --- > > (Updated Nov. 30, 2016, 10:33 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma > Shivaprasad. > > > Bugs: ATLAS-1345 > https://issues.apache.org/jira/browse/ATLAS-1345 > > > Repository: atlas > > > Description > --- > > ATLAS-1345: Enhance search APIs to resolve hierarchical references > > > Diffs > - > > intg/src/main/java/org/apache/atlas/model/SearchFilter.java > b5f6c3af739ebd1383cfccc99b80abf8309803dc > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 816832b912130e89279cd6cd3e8c3e94c85fa6a8 > repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java > d7e38b8d6423358751b3423b2695a00b126701b7 > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java > 867307f04d380b7b1296c2794722b5499d6e6649 > > Diff: https://reviews.apache.org/r/54233/diff/ > > > Testing > --- > > UTs passing for AtlasTypedefStore > > > Thanks, > > Apoorv Naik > >
Re: Review Request 54260: ATLAS-1347: Fix error codes for exceptions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54260/ --- (Updated Dec. 6, 2016, 7:56 p.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad. Changes --- Addressed review comments. Bugs: ATLAS-1347 https://issues.apache.org/jira/browse/ATLAS-1347 Repository: atlas Description --- ATLAS-1347: Fix error codes for exceptions Diffs (updated) - intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 84d8173acfbc8bd78263d37adab8fec011e84654 webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 7a9840b686c35936fbeae5f18cea513fc9b96655 Diff: https://reviews.apache.org/r/54260/diff/ Testing --- Thanks, Apoorv Naik
[jira] [Updated] (ATLAS-1347) Creating a class with unknown supertype results in "409 Conflict", where as expected is "400 Bad Message"
[
https://issues.apache.org/jira/browse/ATLAS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Naik updated ATLAS-1347:
---
Attachment: ATLAS-1347.v1.patch
> Creating a class with unknown supertype results in "409 Conflict", where as
> expected is "400 Bad Message"
> -
>
> Key: ATLAS-1347
> URL: https://issues.apache.org/jira/browse/ATLAS-1347
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.8-incubating
> Reporter: Ayub Khan
>Assignee: Apoorv Naik
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1347.patch, ATLAS-1347.v1.patch
>
>
> Creating a class with unknown supertype results in "409 Conflict", where as
> expected is "400 Bad Message"
> {noformat}
> {
> "enumTypes":[
> ],
> "structTypes":[
> ],
> "traitTypes":[
> ],
> "classTypes":[
> {
> "superTypes":[
> "superClassw4ny4wbeck"
> ],
>
> "hierarchicalMetaTypeName":"org.apache.atlas.typesystem.types.ClassType",
> "typeName":"classw4ny4wbeck",
> "typeDescription":null,
> "typeVersion":"1.0",
> "attributeDefinitions":null
> }
> ]
> }
> {noformat}
> {noformat}
> 2016-12-01 08:52:00,087 ERROR - [pool-2-thread-9 -
> 9ae5cce3-0634-423d-b648-d01e81674750:] ~ graph rollback due to exception
> (GraphTransactionInterceptor:57)
> org.apache.atlas.exception.AtlasBaseException: superClassw4ny4wbeck: Unknown
> typename
> at
> org.apache.atlas.type.AtlasTypeRegistry.getType(AtlasTypeRegistry.java:94)
> at
> org.apache.atlas.type.AtlasEntityType.collectTypeHierarchyInfo(AtlasEntityType.java:267)
> at
> org.apache.atlas.type.AtlasEntityType.getTypeHierarchyInfo(AtlasEntityType.java:248)
> at
> org.apache.atlas.type.AtlasEntityType.resolveReferences(AtlasEntityType.java:76)
> at
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.resolveReferences(AtlasTypeRegistry.java:285)
> at
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.addTypes(AtlasTypeRegistry.java:344)
> at
> org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStore.createTypesDef(AtlasTypeDefGraphStore.java:577)
> at
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:50)
> at
> org.apache.atlas.web.rest.TypesREST.createAtlasTypeDefs(TypesREST.java:438)
> at
> org.apache.atlas.web.resources.TypesResource.submit(TypesResource.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
> at
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
> at
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
> at
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
> at
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
> at
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
> at
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
> at
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
>
[jira] [Updated] (ATLAS-1347) Creating a class with unknown supertype results in "409 Conflict", where as expected is "400 Bad Message"
[
https://issues.apache.org/jira/browse/ATLAS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Naik updated ATLAS-1347:
---
Attachment: (was: ATLAS-1347.v1.patch)
> Creating a class with unknown supertype results in "409 Conflict", where as
> expected is "400 Bad Message"
> -
>
> Key: ATLAS-1347
> URL: https://issues.apache.org/jira/browse/ATLAS-1347
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.8-incubating
> Reporter: Ayub Khan
>Assignee: Apoorv Naik
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1347.patch, ATLAS-1347.v1.patch
>
>
> Creating a class with unknown supertype results in "409 Conflict", where as
> expected is "400 Bad Message"
> {noformat}
> {
> "enumTypes":[
> ],
> "structTypes":[
> ],
> "traitTypes":[
> ],
> "classTypes":[
> {
> "superTypes":[
> "superClassw4ny4wbeck"
> ],
>
> "hierarchicalMetaTypeName":"org.apache.atlas.typesystem.types.ClassType",
> "typeName":"classw4ny4wbeck",
> "typeDescription":null,
> "typeVersion":"1.0",
> "attributeDefinitions":null
> }
> ]
> }
> {noformat}
> {noformat}
> 2016-12-01 08:52:00,087 ERROR - [pool-2-thread-9 -
> 9ae5cce3-0634-423d-b648-d01e81674750:] ~ graph rollback due to exception
> (GraphTransactionInterceptor:57)
> org.apache.atlas.exception.AtlasBaseException: superClassw4ny4wbeck: Unknown
> typename
> at
> org.apache.atlas.type.AtlasTypeRegistry.getType(AtlasTypeRegistry.java:94)
> at
> org.apache.atlas.type.AtlasEntityType.collectTypeHierarchyInfo(AtlasEntityType.java:267)
> at
> org.apache.atlas.type.AtlasEntityType.getTypeHierarchyInfo(AtlasEntityType.java:248)
> at
> org.apache.atlas.type.AtlasEntityType.resolveReferences(AtlasEntityType.java:76)
> at
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.resolveReferences(AtlasTypeRegistry.java:285)
> at
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.addTypes(AtlasTypeRegistry.java:344)
> at
> org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStore.createTypesDef(AtlasTypeDefGraphStore.java:577)
> at
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:50)
> at
> org.apache.atlas.web.rest.TypesREST.createAtlasTypeDefs(TypesREST.java:438)
> at
> org.apache.atlas.web.resources.TypesResource.submit(TypesResource.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
> at
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
> at
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
> at
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
> at
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
> at
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
> at
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
> at
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
>
[jira] [Updated] (ATLAS-1347) Creating a class with unknown supertype results in "409 Conflict", where as expected is "400 Bad Message"
[
https://issues.apache.org/jira/browse/ATLAS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Naik updated ATLAS-1347:
---
Attachment: ATLAS-1347.v1.patch
> Creating a class with unknown supertype results in "409 Conflict", where as
> expected is "400 Bad Message"
> -
>
> Key: ATLAS-1347
> URL: https://issues.apache.org/jira/browse/ATLAS-1347
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.8-incubating
> Reporter: Ayub Khan
>Assignee: Apoorv Naik
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1347.patch, ATLAS-1347.v1.patch
>
>
> Creating a class with unknown supertype results in "409 Conflict", where as
> expected is "400 Bad Message"
> {noformat}
> {
> "enumTypes":[
> ],
> "structTypes":[
> ],
> "traitTypes":[
> ],
> "classTypes":[
> {
> "superTypes":[
> "superClassw4ny4wbeck"
> ],
>
> "hierarchicalMetaTypeName":"org.apache.atlas.typesystem.types.ClassType",
> "typeName":"classw4ny4wbeck",
> "typeDescription":null,
> "typeVersion":"1.0",
> "attributeDefinitions":null
> }
> ]
> }
> {noformat}
> {noformat}
> 2016-12-01 08:52:00,087 ERROR - [pool-2-thread-9 -
> 9ae5cce3-0634-423d-b648-d01e81674750:] ~ graph rollback due to exception
> (GraphTransactionInterceptor:57)
> org.apache.atlas.exception.AtlasBaseException: superClassw4ny4wbeck: Unknown
> typename
> at
> org.apache.atlas.type.AtlasTypeRegistry.getType(AtlasTypeRegistry.java:94)
> at
> org.apache.atlas.type.AtlasEntityType.collectTypeHierarchyInfo(AtlasEntityType.java:267)
> at
> org.apache.atlas.type.AtlasEntityType.getTypeHierarchyInfo(AtlasEntityType.java:248)
> at
> org.apache.atlas.type.AtlasEntityType.resolveReferences(AtlasEntityType.java:76)
> at
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.resolveReferences(AtlasTypeRegistry.java:285)
> at
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.addTypes(AtlasTypeRegistry.java:344)
> at
> org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStore.createTypesDef(AtlasTypeDefGraphStore.java:577)
> at
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:50)
> at
> org.apache.atlas.web.rest.TypesREST.createAtlasTypeDefs(TypesREST.java:438)
> at
> org.apache.atlas.web.resources.TypesResource.submit(TypesResource.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
> at
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
> at
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
> at
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
> at
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
> at
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
> at
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
> at
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
>
Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/#review157763 --- intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 102) <https://reviews.apache.org/r/54287/#comment228375> This one can also be Objects.equals as it internally calls .equals repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java (line 197) <https://reviews.apache.org/r/54287/#comment228377> Any reason we're not using AtlasGraphQuery to build our queries ? repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java (line 201) <https://reviews.apache.org/r/54287/#comment228378> Misleading name, if it's named isEntitiesList I'd expect instanceof checks against a *Entity class - Apoorv Naik On Dec. 2, 2016, 3:11 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54287/ > --- > > (Updated Dec. 2, 2016, 3:11 a.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad. > > > Bugs: ATLAS-1308 > https://issues.apache.org/jira/browse/ATLAS-1308 > > > Repository: atlas > > > Description > --- > > Model and implement the new Discovery REST API's for the following search > types: > * DSL Search > * Full Text Search > and retrieve search results in a structured model using AtlasEntityHeader > information. > > > Diffs > - > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 84d8173 > > intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > d9c74ae > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java > d3903fb > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > PRE-CREATION > repository/src/main/scala/org/apache/atlas/query/Expressions.scala 297aa2b > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/54287/diff/ > > > Testing > --- > > UTs in progress, tested using POSTMAN rest client. > > > Thanks, > > Sarath Subramanian > >
[jira] [Updated] (ATLAS-1349) Reduce excess error logging in atlas logs
[ https://issues.apache.org/jira/browse/ATLAS-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1349: --- Attachment: ATLAS-1349.patch > Reduce excess error logging in atlas logs > - > > Key: ATLAS-1349 > URL: https://issues.apache.org/jira/browse/ATLAS-1349 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1349.patch > > > Currently there's lot of exception logging in the altas application logs > because of the graph transaction interceptor and the custom exception > mappers. This changeset fixes those problems. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 54260: ATLAS-1347: Fix error codes for exceptions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54260/ --- Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad. Repository: atlas Description --- ATLAS-1347: Fix error codes for exceptions Diffs - intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 84d8173acfbc8bd78263d37adab8fec011e84654 webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 7a9840b686c35936fbeae5f18cea513fc9b96655 Diff: https://reviews.apache.org/r/54260/diff/ Testing --- Thanks, Apoorv Naik
[jira] [Assigned] (ATLAS-1347) Creating a class with unknown supertype results in "409 Conflict", where as expected is "400 Bad Message"
[
https://issues.apache.org/jira/browse/ATLAS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Naik reassigned ATLAS-1347:
--
Assignee: Apoorv Naik
> Creating a class with unknown supertype results in "409 Conflict", where as
> expected is "400 Bad Message"
> -
>
> Key: ATLAS-1347
> URL: https://issues.apache.org/jira/browse/ATLAS-1347
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.8-incubating
> Reporter: Ayub Khan
>Assignee: Apoorv Naik
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1347.patch
>
>
> Creating a class with unknown supertype results in "409 Conflict", where as
> expected is "400 Bad Message"
> {noformat}
> {
> "enumTypes":[
> ],
> "structTypes":[
> ],
> "traitTypes":[
> ],
> "classTypes":[
> {
> "superTypes":[
> "superClassw4ny4wbeck"
> ],
>
> "hierarchicalMetaTypeName":"org.apache.atlas.typesystem.types.ClassType",
> "typeName":"classw4ny4wbeck",
> "typeDescription":null,
> "typeVersion":"1.0",
> "attributeDefinitions":null
> }
> ]
> }
> {noformat}
> {noformat}
> 2016-12-01 08:52:00,087 ERROR - [pool-2-thread-9 -
> 9ae5cce3-0634-423d-b648-d01e81674750:] ~ graph rollback due to exception
> (GraphTransactionInterceptor:57)
> org.apache.atlas.exception.AtlasBaseException: superClassw4ny4wbeck: Unknown
> typename
> at
> org.apache.atlas.type.AtlasTypeRegistry.getType(AtlasTypeRegistry.java:94)
> at
> org.apache.atlas.type.AtlasEntityType.collectTypeHierarchyInfo(AtlasEntityType.java:267)
> at
> org.apache.atlas.type.AtlasEntityType.getTypeHierarchyInfo(AtlasEntityType.java:248)
> at
> org.apache.atlas.type.AtlasEntityType.resolveReferences(AtlasEntityType.java:76)
> at
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.resolveReferences(AtlasTypeRegistry.java:285)
> at
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.addTypes(AtlasTypeRegistry.java:344)
> at
> org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStore.createTypesDef(AtlasTypeDefGraphStore.java:577)
> at
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:50)
> at
> org.apache.atlas.web.rest.TypesREST.createAtlasTypeDefs(TypesREST.java:438)
> at
> org.apache.atlas.web.resources.TypesResource.submit(TypesResource.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
> at
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
> at
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
> at
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
> at
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
> at
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
> at
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
> at
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
> at
> com.sun.jersey.spi.container.servlet.ServletContainer.serv
[jira] [Updated] (ATLAS-1347) Creating a class with unknown supertype results in "409 Conflict", where as expected is "400 Bad Message"
[
https://issues.apache.org/jira/browse/ATLAS-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Naik updated ATLAS-1347:
---
Attachment: ATLAS-1347.patch
> Creating a class with unknown supertype results in "409 Conflict", where as
> expected is "400 Bad Message"
> -
>
> Key: ATLAS-1347
> URL: https://issues.apache.org/jira/browse/ATLAS-1347
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.8-incubating
> Reporter: Ayub Khan
>Assignee: Apoorv Naik
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1347.patch
>
>
> Creating a class with unknown supertype results in "409 Conflict", where as
> expected is "400 Bad Message"
> {noformat}
> {
> "enumTypes":[
> ],
> "structTypes":[
> ],
> "traitTypes":[
> ],
> "classTypes":[
> {
> "superTypes":[
> "superClassw4ny4wbeck"
> ],
>
> "hierarchicalMetaTypeName":"org.apache.atlas.typesystem.types.ClassType",
> "typeName":"classw4ny4wbeck",
> "typeDescription":null,
> "typeVersion":"1.0",
> "attributeDefinitions":null
> }
> ]
> }
> {noformat}
> {noformat}
> 2016-12-01 08:52:00,087 ERROR - [pool-2-thread-9 -
> 9ae5cce3-0634-423d-b648-d01e81674750:] ~ graph rollback due to exception
> (GraphTransactionInterceptor:57)
> org.apache.atlas.exception.AtlasBaseException: superClassw4ny4wbeck: Unknown
> typename
> at
> org.apache.atlas.type.AtlasTypeRegistry.getType(AtlasTypeRegistry.java:94)
> at
> org.apache.atlas.type.AtlasEntityType.collectTypeHierarchyInfo(AtlasEntityType.java:267)
> at
> org.apache.atlas.type.AtlasEntityType.getTypeHierarchyInfo(AtlasEntityType.java:248)
> at
> org.apache.atlas.type.AtlasEntityType.resolveReferences(AtlasEntityType.java:76)
> at
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.resolveReferences(AtlasTypeRegistry.java:285)
> at
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.addTypes(AtlasTypeRegistry.java:344)
> at
> org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStore.createTypesDef(AtlasTypeDefGraphStore.java:577)
> at
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:50)
> at
> org.apache.atlas.web.rest.TypesREST.createAtlasTypeDefs(TypesREST.java:438)
> at
> org.apache.atlas.web.resources.TypesResource.submit(TypesResource.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
> at
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
> at
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
> at
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
> at
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
> at
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
> at
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
> at
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
> at
> com.sun.jersey.spi.container.servlet.ServletContainer.serv
[jira] [Created] (ATLAS-1349) Reduce excess error logging in atlas logs
Apoorv Naik created ATLAS-1349: -- Summary: Reduce excess error logging in atlas logs Key: ATLAS-1349 URL: https://issues.apache.org/jira/browse/ATLAS-1349 Project: Atlas Issue Type: Improvement Affects Versions: 0.8-incubating Reporter: Apoorv Naik Assignee: Apoorv Naik Fix For: 0.8-incubating Currently there's lot of exception logging in the altas application logs because of the graph transaction interceptor and the custom exception mappers. This changeset fixes those problems. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1346) Search APIs should return empty list instead of throwing exception
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1346: --- Summary: Search APIs should return empty list instead of throwing exception (was: Fix for excessive error logging in atlas logs) > Search APIs should return empty list instead of throwing exception > -- > > Key: ATLAS-1346 > URL: https://issues.apache.org/jira/browse/ATLAS-1346 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > > Currently the APIs return a 404 when there's no result found in the > repository which causes the graph transaction to rollback, instead the search > API should return an empty list and the rest layer should translate it to a > 404 or the read-only APIs should be excluded from the GraphTransaction > interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1346) Fix for excessive error logging in atlas logs
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1346: --- Summary: Fix for excessive error logging in atlas logs (was: Exception interception fixes and reduced logging) > Fix for excessive error logging in atlas logs > - > > Key: ATLAS-1346 > URL: https://issues.apache.org/jira/browse/ATLAS-1346 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > > Currently the APIs return a 404 when there's no result found in the > repository which causes the graph transaction to rollback, instead the search > API should return an empty list and the rest layer should translate it to a > 404 or the read-only APIs should be excluded from the GraphTransaction > interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1346) Exception interception fixes and reduced logging
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1346: --- Summary: Exception interception fixes and reduced logging (was: Search APIs should return empty list instead of throwing exception) > Exception interception fixes and reduced logging > > > Key: ATLAS-1346 > URL: https://issues.apache.org/jira/browse/ATLAS-1346 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > > Currently the APIs return a 404 when there's no result found in the > repository which causes the graph transaction to rollback, instead the search > API should return an empty list and the rest layer should translate it to a > 404 or the read-only APIs should be excluded from the GraphTransaction > interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1346) Search APIs should return empty list instead of throwing exception
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712575#comment-15712575 ] Apoorv Naik commented on ATLAS-1346: [~yhemanth] Thanks for the clarification Hemanth. Will look into it. > Search APIs should return empty list instead of throwing exception > -- > > Key: ATLAS-1346 > URL: https://issues.apache.org/jira/browse/ATLAS-1346 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > > Currently the APIs return a 404 when there's no result found in the > repository which causes the graph transaction to rollback, instead the search > API should return an empty list and the rest layer should translate it to a > 404 or the read-only APIs should be excluded from the GraphTransaction > interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1346) Search APIs should return empty list instead of throwing exception
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1346: --- Attachment: (was: ATLAS-1346.patch) > Search APIs should return empty list instead of throwing exception > -- > > Key: ATLAS-1346 > URL: https://issues.apache.org/jira/browse/ATLAS-1346 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > > Currently the APIs return a 404 when there's no result found in the > repository which causes the graph transaction to rollback, instead the search > API should return an empty list and the rest layer should translate it to a > 404 or the read-only APIs should be excluded from the GraphTransaction > interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1346) Search APIs should return empty list instead of throwing exception
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1346: --- Attachment: ATLAS-1346.patch > Search APIs should return empty list instead of throwing exception > -- > > Key: ATLAS-1346 > URL: https://issues.apache.org/jira/browse/ATLAS-1346 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1346.patch > > > Currently the APIs return a 404 when there's no result found in the > repository which causes the graph transaction to rollback, instead the search > API should return an empty list and the rest layer should translate it to a > 404 or the read-only APIs should be excluded from the GraphTransaction > interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ATLAS-1346) Search APIs should return empty list instead of throwing exception
Apoorv Naik created ATLAS-1346: -- Summary: Search APIs should return empty list instead of throwing exception Key: ATLAS-1346 URL: https://issues.apache.org/jira/browse/ATLAS-1346 Project: Atlas Issue Type: Bug Affects Versions: 0.8-incubating Reporter: Apoorv Naik Assignee: Apoorv Naik Fix For: 0.8-incubating Currently the APIs return a 404 when there's no result found in the repository which causes the graph transaction to rollback, instead the search API should return an empty list and the rest layer should translate it to a 404 or the read-only APIs should be excluded from the GraphTransaction interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311-v3.patch > Integration tests for Entity V2 REST APIs > - > > Key: ATLAS-1311 > URL: https://issues.apache.org/jira/browse/ATLAS-1311 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1311-v2.patch, ATLAS-1311-v3.patch, > ATLAS-1311.patch > > > Currently there's no IT for the new REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Nov. 30, 2016, 11:22 p.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. Changes --- Updated the test and added a helper function. Bugs: ATLAS-1311 https://issues.apache.org/jira/browse/ATLAS-1311 Repository: atlas Description --- ATLAS-1311: Integration tests for the V2 Entity APIs Diffs (updated) - addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 webapp/src/main/resources/spring-security.xml 4ba3025 webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 Diff: https://reviews.apache.org/r/54058/diff/ Testing --- UTs and ITs are running fine. mvn clean install -Pdist was successful Thanks, Apoorv Naik
Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54233/ --- Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad. Bugs: ATLAS-1345 https://issues.apache.org/jira/browse/ATLAS-1345 Repository: atlas Description --- ATLAS-1345: Enhance search APIs to resolve hierarchical references Diffs - intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8 repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7 webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649 Diff: https://reviews.apache.org/r/54233/diff/ Testing --- UTs passing for AtlasTypedefStore Thanks, Apoorv Naik
[jira] [Created] (ATLAS-1345) V2 API to provide all supertypes for a given type/entity
Apoorv Naik created ATLAS-1345: -- Summary: V2 API to provide all supertypes for a given type/entity Key: ATLAS-1345 URL: https://issues.apache.org/jira/browse/ATLAS-1345 Project: Atlas Issue Type: Improvement Affects Versions: 0.8-incubating Reporter: Apoorv Naik Assignee: Apoorv Naik Fix For: 0.8-incubating Currently there's no REST API that can resolve all supertypes for a given type name or entity name. This change introduces new REST endpoint that will yield all supertypes for a given typename. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311-v2.patch > Integration tests for Entity V2 REST APIs > - > > Key: ATLAS-1311 > URL: https://issues.apache.org/jira/browse/ATLAS-1311 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1311-v2.patch, ATLAS-1311.patch > > > Currently there's no IT for the new REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Nov. 29, 2016, 10:17 p.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. Changes --- Fix after rebase. Bugs: ATLAS-1311 https://issues.apache.org/jira/browse/ATLAS-1311 Repository: atlas Description --- ATLAS-1311: Integration tests for the V2 Entity APIs Diffs (updated) - addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 40866fe client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 webapp/src/main/resources/spring-security.xml 4ba3025 webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 Diff: https://reviews.apache.org/r/54058/diff/ Testing --- UTs and ITs are running fine. mvn clean install -Pdist was successful Thanks, Apoorv Naik
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review157336 --- Needs update after the FormatAdapter changes. - Apoorv Naik On Nov. 29, 2016, 7:49 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > --- > > (Updated Nov. 29, 2016, 7:49 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > --- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > - > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 40866fe > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f4118 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 84608d9 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b1 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c2 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f > webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java > 62e1e57 > webapp/src/main/resources/spring-security.xml 4ba3025 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 081d5ca > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > de0a459 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 1777f75 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > d9f14d0 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 38c823a > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > cf25814 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > 13ef503 > > webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java > 2fa1602 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > fd15544 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > --- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > >
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Nov. 29, 2016, 7:49 p.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. Changes --- Reverting code rearrangment/ import-only changes. Bugs: ATLAS-1311 https://issues.apache.org/jira/browse/ATLAS-1311 Repository: atlas Description --- ATLAS-1311: Integration tests for the V2 Entity APIs Diffs (updated) - addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 40866fe client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 webapp/src/main/resources/spring-security.xml 4ba3025 webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 Diff: https://reviews.apache.org/r/54058/diff/ Testing (updated) --- UTs and ITs are running fine. mvn clean install -Pdist was successful Thanks, Apoorv Naik
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review157292 --- Need to revert import only changes in several files. typesystem/src/test/resources/atlas-application.properties (line 38) <https://reviews.apache.org/r/54058/#comment227815> Need to revert this. typesystem/src/test/resources/atlas-application.properties (line 84) <https://reviews.apache.org/r/54058/#comment227816> Same here. - Apoorv Naik On Nov. 29, 2016, 6:20 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > --- > > (Updated Nov. 29, 2016, 6:20 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > --- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > - > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 40866fe > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f4118 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 84608d9 > typesystem/src/test/resources/atlas-application.properties 108630b > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 8322bc6 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java bc937e4 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 5756adb > webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855 > webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java > 9042e88 > > webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java > 70b2482 > webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java > a14f939 > webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java > 1ff8000 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationEntryPoint.java > 382b494 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > 3307015 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java > 5bd2bd7 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java > 3cc83c5 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java > 75a884d > webapp/src/main/java/org/apache/atlas/web/filters/NullServletContext.java > 25621c6 > webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java > 3bab650 > webapp/src/main/java/org/apache/atlas/web/model/User.java 54a19c5 > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b1 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c2 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f > webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java > 62e1e57 > > webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java > aea939a > > webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java > b99a30a > > webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java > 953d737 > > webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java > 3e1e2e6 > > webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java > 468daf6 > webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java > a6af5a2 > w
Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
/apache/atlas/web/listeners/TestModule.java b00080f webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java f9e4c40 webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 9aff145 webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453 webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java ea55698 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java b6dae4d webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc3 webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationTest.java 44b7cac webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c83 webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java 2648ca7 webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceElectorServiceTest.java c0ffc6e webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cb webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121 webapp/src/test/java/org/apache/atlas/web/setup/SetupStepsTest.java 82abc1b webapp/src/test/java/org/apache/atlas/web/util/ServletsTest.java e732dbf Diff: https://reviews.apache.org/r/54058/diff/ Testing --- Thanks, Apoorv Naik
[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Attachment: ATLAS-1311.patch > Integration tests for Entity V2 REST APIs > - > > Key: ATLAS-1311 > URL: https://issues.apache.org/jira/browse/ATLAS-1311 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1311.patch > > > Currently there's no IT for the new REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 53748: Updated equals and hashCode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53748/ --- (Updated Nov. 28, 2016, 8:32 p.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. Changes --- Rebased on latest master Bugs: ATLAS-1303 https://issues.apache.org/jira/browse/ATLAS-1303 Repository: atlas Description --- Updated equals and hashCode methods Using JDK7's built-in classes to simplify the code and make it more readable/understandable. Diffs (updated) - catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5 intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585 intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java bedd4d9 intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33 intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91 intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java feae00d intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 1be5ee1 intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 0312176 intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java ef12896 intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3 notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 6ef407a notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cdeb117 typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 0b3ffe3 typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java a3f9421 typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223 typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3 typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422 typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76 Diff: https://reviews.apache.org/r/53748/diff/ Testing --- Working on executing all tests Thanks, Apoorv Naik
Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs
/BaseResourceIT.java 1777f75 webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java f9e4c40 webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 9aff145 webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453 webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java ea55698 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java b6dae4d webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc3 webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationTest.java 44b7cac webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c83 webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java 2648ca7 webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceElectorServiceTest.java c0ffc6e webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cb webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121 webapp/src/test/java/org/apache/atlas/web/setup/SetupStepsTest.java 82abc1b webapp/src/test/java/org/apache/atlas/web/util/ServletsTest.java e732dbf Diff: https://reviews.apache.org/r/54058/diff/ Testing --- Thanks, Apoorv Naik
Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54023/#review156804 --- Ship it! Looks good to me. - Apoorv Naik On Nov. 23, 2016, 11:55 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54023/ > --- > > (Updated Nov. 23, 2016, 11:55 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1319 > https://issues.apache.org/jira/browse/ATLAS-1319 > > > Repository: atlas > > > Description > --- > > Updated converter classes to handle struct type attributes > > > Diffs > - > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 80a539a > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 6cecd46 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasAbstractFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java > 5485efa > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasClassificationFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java > ec0661d > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java > c146d72 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java > 5238a75 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java > c3dfb61 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > dc42f10 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java > 761c8a7 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java > 66be58e > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java > ba77c67 > > webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java > 15c41c8 > > webapp/src/main/java/org/apache/atlas/web/adapters/v1/TraitToAtlasClassificationConverter.java > 6ac9013 > > webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasClassificationToTraitConverter.java > ece483c > > webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java > fab051f > > webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java > f0b4b12 > webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java > c245596 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > f8e18bf > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > 6dd21d1 > > Diff: https://reviews.apache.org/r/54023/diff/ > > > Testing > --- > > - verified that creation of entity with struct type attribute is handled > correctly by EntityREST API > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54023/#review156786 --- webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java (line 40) <https://reviews.apache.org/r/54023/#comment227080> I think dynamic selection of the converter is better for future-proofing the converters. webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java (line 49) <https://reviews.apache.org/r/54023/#comment227077> AtlasErrorCode instead of manual string concatenation. Overall looks good to me. - Apoorv Naik On Nov. 23, 2016, 11:17 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54023/ > --- > > (Updated Nov. 23, 2016, 11:17 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1319 > https://issues.apache.org/jira/browse/ATLAS-1319 > > > Repository: atlas > > > Description > --- > > Updated converter classes to handle struct type attributes > > > Diffs > - > > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasAbstractFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java > 5485efa > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasClassificationFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java > ec0661d > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java > c146d72 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java > 5238a75 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java > c3dfb61 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > dc42f10 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java > 761c8a7 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java > 66be58e > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/v1/ReferenceableToAtlasEntityConverter.java > ba77c67 > > webapp/src/main/java/org/apache/atlas/web/adapters/v1/StructToAtlasStructConverter.java > 15c41c8 > > webapp/src/main/java/org/apache/atlas/web/adapters/v1/TraitToAtlasClassificationConverter.java > 6ac9013 > > webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasClassificationToTraitConverter.java > ece483c > > webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasEntityToReferenceableConverter.java > fab051f > > webapp/src/main/java/org/apache/atlas/web/adapters/v2/AtlasStructToStructConverter.java > f0b4b12 > webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java > c245596 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > f8e18bf > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > 6dd21d1 > > Diff: https://reviews.apache.org/r/54023/diff/ > > > Testing > --- > > - verified that creation of entity with struct type attribute is handled > correctly by EntityREST API > > > Thanks, > > Madhan Neethiraj > >
[jira] [Comment Edited] (ATLAS-1316) V2 API webapp tests are failing
[
https://issues.apache.org/jira/browse/ATLAS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690704#comment-15690704
]
Apoorv Naik edited comment on ATLAS-1316 at 11/23/16 4:57 PM:
--
If the mvn verify is going through fine then lets go ahead with the same patch.
:)
Thanks a lot Ayub.
was (Author: apoorvnaik):
If the mvn verify is going through fine then lets go ahead with the same patch.
:)
> V2 API webapp tests are failing
> ---
>
> Key: ATLAS-1316
> URL: https://issues.apache.org/jira/browse/ATLAS-1316
> Project: Atlas
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Ayub Khan
>Assignee: Ayub Khan
> Fix For: trunk
>
> Attachments: ATLAS-1316.patch, application.log,
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT-output.txt,
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT.txt
>
>
> {noformat}
> Failed tests:
> EntityLineageJerseyResourceIT.testInputLineageInfo:74 expected:<200> but
> was:<404>
> EntityLineageJerseyResourceIT.testLineageInfo:134 expected:<200> but
> was:<404>
> EntityLineageJerseyResourceIT.testOutputLineageInfo:104 expected:<200> but
> was:<404>
> TypedefsJerseyResourceIT.testCreate:86 » AtlasService Metadata service API
> org...
> TypedefsJerseyResourceIT.testDuplicateCreate:98 » AtlasService Metadata
> servic...
> TypedefsJerseyResourceIT.testListTypesByFilter:254 » AtlasService Metadata
> ser...
> TypedefsJerseyResourceIT.testUpdate:118 » AtlasService Metadata service API
> or...
> {noformat}
> *From high level this seems like AtlasAuthorizationUtils.java is not handling
> V2 API's properly*
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-1316) V2 API webapp tests are failing
[
https://issues.apache.org/jira/browse/ATLAS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690704#comment-15690704
]
Apoorv Naik commented on ATLAS-1316:
If the mvn verify is going through fine then lets go ahead with the same patch.
:)
> V2 API webapp tests are failing
> ---
>
> Key: ATLAS-1316
> URL: https://issues.apache.org/jira/browse/ATLAS-1316
> Project: Atlas
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Ayub Khan
>Assignee: Ayub Khan
> Fix For: trunk
>
> Attachments: ATLAS-1316.patch, application.log,
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT-output.txt,
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT.txt
>
>
> {noformat}
> Failed tests:
> EntityLineageJerseyResourceIT.testInputLineageInfo:74 expected:<200> but
> was:<404>
> EntityLineageJerseyResourceIT.testLineageInfo:134 expected:<200> but
> was:<404>
> EntityLineageJerseyResourceIT.testOutputLineageInfo:104 expected:<200> but
> was:<404>
> TypedefsJerseyResourceIT.testCreate:86 » AtlasService Metadata service API
> org...
> TypedefsJerseyResourceIT.testDuplicateCreate:98 » AtlasService Metadata
> servic...
> TypedefsJerseyResourceIT.testListTypesByFilter:254 » AtlasService Metadata
> ser...
> TypedefsJerseyResourceIT.testUpdate:118 » AtlasService Metadata service API
> or...
> {noformat}
> *From high level this seems like AtlasAuthorizationUtils.java is not handling
> V2 API's properly*
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-1315) Fix webapp Integration tests
[ https://issues.apache.org/jira/browse/ATLAS-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688515#comment-15688515 ] Apoorv Naik commented on ATLAS-1315: Just compiled and ran on a brand new VM. Looks fine now, tests passing. +1 > Fix webapp Integration tests > > > Key: ATLAS-1315 > URL: https://issues.apache.org/jira/browse/ATLAS-1315 > Project: Atlas > Issue Type: Bug >Reporter: Vimal Sharma >Assignee: Ayub Khan > Fix For: trunk > > Attachments: ATLAS-1315-v1.patch, ATLAS-1315.patch, Screen Shot > 2016-11-22 at 9.02.53 AM.png, Screen Shot 2016-11-22 at 9.03.51 AM.png, > Screen Shot 2016-11-22 at 9.05.41 AM.png, Screen Shot 2016-11-22 at 9.11.55 > AM.png > > > webapp tests are failing. Below are the failing tests > EntityNotificationIT.testCreateEntity:90 NullPointer > EntityNotificationIT.testDeleteEntity:119 NullPointer > EntityJerseyResourceIT.testEntityDeduping:233 » AtlasService Metadata > service ... > org.apache.atlas.web.resources.EntityJerseyResourceIT.testEntityInvalidValue(org.apache.atlas.web.resources.EntityJerseyResourceIT) > Run 1: EntityJerseyResourceIT.testEntityInvalidValue:291 Expected > AtlasServiceException > Run 2: EntityJerseyResourceIT.testEntityInvalidValue:291 Expected > AtlasServiceException > EntityJerseyResourceIT.testSubmitEntity:128 NullPointer > EntityJerseyResourceIT.testSubmitEntityWithBadDateFormat:323 Was expecting > an exception here > EntityJerseyResourceIT.testUTF8:754 NullPointer > EntityLineageJerseyResourceIT.testInputLineageInfo:74 expected:<200> but > was:<404> > EntityLineageJerseyResourceIT.testLineageInfo:134 expected:<200> but > was:<404> > EntityLineageJerseyResourceIT.testOutputLineageInfo:104 expected:<200> but > was:<404> > MetadataDiscoveryJerseyResourceIT.testSearchByDSL:76 expected:<200> but > was:<400> > MetadataDiscoveryJerseyResourceIT.testSearchDSLLimits:108 expected:<200> > but was:<400> > MetadataDiscoveryJerseyResourceIT.testSearchUsingDSL:196 expected: but > was: > TypedefsJerseyResourceIT.testCreate:86 » AtlasService Metadata service API > org... > TypedefsJerseyResourceIT.testDuplicateCreate:98 » AtlasService Metadata > servic... > TypedefsJerseyResourceIT.testListTypesByFilter:254 » AtlasService Metadata > ser... > TypedefsJerseyResourceIT.testUpdate:118 » AtlasService Metadata service API > or... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1317) Disable the problematic ITs
[ https://issues.apache.org/jira/browse/ATLAS-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1317: --- Attachment: ATLAS-1317.patch Disabling the inconsistent tests temporarily > Disable the problematic ITs > --- > > Key: ATLAS-1317 > URL: https://issues.apache.org/jira/browse/ATLAS-1317 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1317.patch > > > Currently there are a few ITs that seem to be working on and off, works on > some systems but not the others. Such a finicky behavior is not ideal. > Disabling the tests for now and rewrite of the same tests is what I'd > recommend. Test environment shouldn't be an interfering factor when running > the tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1316) V2 API webapp tests are failing
[
https://issues.apache.org/jira/browse/ATLAS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687722#comment-15687722
]
Apoorv Naik commented on ATLAS-1316:
This is because the web.xml is not in sync with the main web.xml, so the
resource scanning is not working for the new V2 APIs. Once the context params
are copied over, the tests seem to be passing with ATLAS-1315 patch.
> V2 API webapp tests are failing
> ---
>
> Key: ATLAS-1316
> URL: https://issues.apache.org/jira/browse/ATLAS-1316
> Project: Atlas
> Issue Type: Bug
>Reporter: Ayub Khan
> Attachments: application.log,
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT-output.txt,
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT.txt
>
>
> {noformat}
> Failed tests:
> EntityLineageJerseyResourceIT.testInputLineageInfo:74 expected:<200> but
> was:<404>
> EntityLineageJerseyResourceIT.testLineageInfo:134 expected:<200> but
> was:<404>
> EntityLineageJerseyResourceIT.testOutputLineageInfo:104 expected:<200> but
> was:<404>
> TypedefsJerseyResourceIT.testCreate:86 » AtlasService Metadata service API
> org...
> TypedefsJerseyResourceIT.testDuplicateCreate:98 » AtlasService Metadata
> servic...
> TypedefsJerseyResourceIT.testListTypesByFilter:254 » AtlasService Metadata
> ser...
> TypedefsJerseyResourceIT.testUpdate:118 » AtlasService Metadata service API
> or...
> {noformat}
> *From high level this seems like AtlasAuthorizationUtils.java is not handling
> V2 API's properly*
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (ATLAS-1317) Disable the problematic ITs
Apoorv Naik created ATLAS-1317: -- Summary: Disable the problematic ITs Key: ATLAS-1317 URL: https://issues.apache.org/jira/browse/ATLAS-1317 Project: Atlas Issue Type: Bug Affects Versions: 0.8-incubating Reporter: Apoorv Naik Assignee: Apoorv Naik Fix For: 0.8-incubating Currently there are a few ITs that seem to be working on and off, works on some systems but not the others. Such a finicky behavior is not ideal. Disabling the tests for now and rewrite of the same tests is what I'd recommend. Test environment shouldn't be an interfering factor when running the tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1315) Fix webapp Integration tests
[ https://issues.apache.org/jira/browse/ATLAS-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1315: --- Attachment: Screen Shot 2016-11-22 at 9.11.55 AM.png > Fix webapp Integration tests > > > Key: ATLAS-1315 > URL: https://issues.apache.org/jira/browse/ATLAS-1315 > Project: Atlas > Issue Type: Bug >Reporter: Vimal Sharma >Assignee: Ayub Khan > Fix For: trunk > > Attachments: ATLAS-1315-v1.patch, ATLAS-1315.patch, Screen Shot > 2016-11-22 at 9.02.53 AM.png, Screen Shot 2016-11-22 at 9.03.51 AM.png, > Screen Shot 2016-11-22 at 9.05.41 AM.png, Screen Shot 2016-11-22 at 9.11.55 > AM.png > > > webapp tests are failing. Below are the failing tests > EntityNotificationIT.testCreateEntity:90 NullPointer > EntityNotificationIT.testDeleteEntity:119 NullPointer > EntityJerseyResourceIT.testEntityDeduping:233 » AtlasService Metadata > service ... > org.apache.atlas.web.resources.EntityJerseyResourceIT.testEntityInvalidValue(org.apache.atlas.web.resources.EntityJerseyResourceIT) > Run 1: EntityJerseyResourceIT.testEntityInvalidValue:291 Expected > AtlasServiceException > Run 2: EntityJerseyResourceIT.testEntityInvalidValue:291 Expected > AtlasServiceException > EntityJerseyResourceIT.testSubmitEntity:128 NullPointer > EntityJerseyResourceIT.testSubmitEntityWithBadDateFormat:323 Was expecting > an exception here > EntityJerseyResourceIT.testUTF8:754 NullPointer > EntityLineageJerseyResourceIT.testInputLineageInfo:74 expected:<200> but > was:<404> > EntityLineageJerseyResourceIT.testLineageInfo:134 expected:<200> but > was:<404> > EntityLineageJerseyResourceIT.testOutputLineageInfo:104 expected:<200> but > was:<404> > MetadataDiscoveryJerseyResourceIT.testSearchByDSL:76 expected:<200> but > was:<400> > MetadataDiscoveryJerseyResourceIT.testSearchDSLLimits:108 expected:<200> > but was:<400> > MetadataDiscoveryJerseyResourceIT.testSearchUsingDSL:196 expected: but > was: > TypedefsJerseyResourceIT.testCreate:86 » AtlasService Metadata service API > org... > TypedefsJerseyResourceIT.testDuplicateCreate:98 » AtlasService Metadata > servic... > TypedefsJerseyResourceIT.testListTypesByFilter:254 » AtlasService Metadata > ser... > TypedefsJerseyResourceIT.testUpdate:118 » AtlasService Metadata service API > or... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1315) Fix webapp Integration tests
[ https://issues.apache.org/jira/browse/ATLAS-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1315: --- Attachment: Screen Shot 2016-11-22 at 9.05.41 AM.png Screen Shot 2016-11-22 at 9.03.51 AM.png Screen Shot 2016-11-22 at 9.02.53 AM.png Test runs > Fix webapp Integration tests > > > Key: ATLAS-1315 > URL: https://issues.apache.org/jira/browse/ATLAS-1315 > Project: Atlas > Issue Type: Bug >Reporter: Vimal Sharma >Assignee: Ayub Khan > Fix For: trunk > > Attachments: ATLAS-1315-v1.patch, ATLAS-1315.patch, Screen Shot > 2016-11-22 at 9.02.53 AM.png, Screen Shot 2016-11-22 at 9.03.51 AM.png, > Screen Shot 2016-11-22 at 9.05.41 AM.png > > > webapp tests are failing. Below are the failing tests > EntityNotificationIT.testCreateEntity:90 NullPointer > EntityNotificationIT.testDeleteEntity:119 NullPointer > EntityJerseyResourceIT.testEntityDeduping:233 » AtlasService Metadata > service ... > org.apache.atlas.web.resources.EntityJerseyResourceIT.testEntityInvalidValue(org.apache.atlas.web.resources.EntityJerseyResourceIT) > Run 1: EntityJerseyResourceIT.testEntityInvalidValue:291 Expected > AtlasServiceException > Run 2: EntityJerseyResourceIT.testEntityInvalidValue:291 Expected > AtlasServiceException > EntityJerseyResourceIT.testSubmitEntity:128 NullPointer > EntityJerseyResourceIT.testSubmitEntityWithBadDateFormat:323 Was expecting > an exception here > EntityJerseyResourceIT.testUTF8:754 NullPointer > EntityLineageJerseyResourceIT.testInputLineageInfo:74 expected:<200> but > was:<404> > EntityLineageJerseyResourceIT.testLineageInfo:134 expected:<200> but > was:<404> > EntityLineageJerseyResourceIT.testOutputLineageInfo:104 expected:<200> but > was:<404> > MetadataDiscoveryJerseyResourceIT.testSearchByDSL:76 expected:<200> but > was:<400> > MetadataDiscoveryJerseyResourceIT.testSearchDSLLimits:108 expected:<200> > but was:<400> > MetadataDiscoveryJerseyResourceIT.testSearchUsingDSL:196 expected: but > was: > TypedefsJerseyResourceIT.testCreate:86 » AtlasService Metadata service API > org... > TypedefsJerseyResourceIT.testDuplicateCreate:98 » AtlasService Metadata > servic... > TypedefsJerseyResourceIT.testListTypesByFilter:254 » AtlasService Metadata > ser... > TypedefsJerseyResourceIT.testUpdate:118 » AtlasService Metadata service API > or... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1315) Fix webapp Integration tests
[ https://issues.apache.org/jira/browse/ATLAS-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687261#comment-15687261 ] Apoorv Naik commented on ATLAS-1315: Hey Ayub, The patch doesn't work on my system, I still see EntityNotificationIT failing consistently and the above mentioned tests don't fail for me. > Fix webapp Integration tests > > > Key: ATLAS-1315 > URL: https://issues.apache.org/jira/browse/ATLAS-1315 > Project: Atlas > Issue Type: Bug >Reporter: Vimal Sharma >Assignee: Ayub Khan > Fix For: trunk > > Attachments: ATLAS-1315-v1.patch, ATLAS-1315.patch > > > webapp tests are failing. Below are the failing tests > EntityNotificationIT.testCreateEntity:90 NullPointer > EntityNotificationIT.testDeleteEntity:119 NullPointer > EntityJerseyResourceIT.testEntityDeduping:233 » AtlasService Metadata > service ... > org.apache.atlas.web.resources.EntityJerseyResourceIT.testEntityInvalidValue(org.apache.atlas.web.resources.EntityJerseyResourceIT) > Run 1: EntityJerseyResourceIT.testEntityInvalidValue:291 Expected > AtlasServiceException > Run 2: EntityJerseyResourceIT.testEntityInvalidValue:291 Expected > AtlasServiceException > EntityJerseyResourceIT.testSubmitEntity:128 NullPointer > EntityJerseyResourceIT.testSubmitEntityWithBadDateFormat:323 Was expecting > an exception here > EntityJerseyResourceIT.testUTF8:754 NullPointer > EntityLineageJerseyResourceIT.testInputLineageInfo:74 expected:<200> but > was:<404> > EntityLineageJerseyResourceIT.testLineageInfo:134 expected:<200> but > was:<404> > EntityLineageJerseyResourceIT.testOutputLineageInfo:104 expected:<200> but > was:<404> > MetadataDiscoveryJerseyResourceIT.testSearchByDSL:76 expected:<200> but > was:<400> > MetadataDiscoveryJerseyResourceIT.testSearchDSLLimits:108 expected:<200> > but was:<400> > MetadataDiscoveryJerseyResourceIT.testSearchUsingDSL:196 expected: but > was: > TypedefsJerseyResourceIT.testCreate:86 » AtlasService Metadata service API > org... > TypedefsJerseyResourceIT.testDuplicateCreate:98 » AtlasService Metadata > servic... > TypedefsJerseyResourceIT.testListTypesByFilter:254 » AtlasService Metadata > ser... > TypedefsJerseyResourceIT.testUpdate:118 » AtlasService Metadata service API > or... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1316) V2 API webapp tests are failing
[
https://issues.apache.org/jira/browse/ATLAS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687247#comment-15687247
]
Apoorv Naik commented on ATLAS-1316:
Can you share the stacktrace of the failures ? This seems a little weird, all
these ITs are passing on my system.
> V2 API webapp tests are failing
> ---
>
> Key: ATLAS-1316
> URL: https://issues.apache.org/jira/browse/ATLAS-1316
> Project: Atlas
> Issue Type: Bug
>Reporter: Ayub Khan
>
> {noformat}
> Failed tests:
> EntityLineageJerseyResourceIT.testInputLineageInfo:74 expected:<200> but
> was:<404>
> EntityLineageJerseyResourceIT.testLineageInfo:134 expected:<200> but
> was:<404>
> EntityLineageJerseyResourceIT.testOutputLineageInfo:104 expected:<200> but
> was:<404>
> TypedefsJerseyResourceIT.testCreate:86 » AtlasService Metadata service API
> org...
> TypedefsJerseyResourceIT.testDuplicateCreate:98 » AtlasService Metadata
> servic...
> TypedefsJerseyResourceIT.testListTypesByFilter:254 » AtlasService Metadata
> ser...
> TypedefsJerseyResourceIT.testUpdate:118 » AtlasService Metadata service API
> or...
> {noformat}
> *From high level this seems like AtlasAuthorizationUtils.java is not handling
> V2 API's properly*
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Review Request 53976: ATLAS-1292: Fix for integration tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53976/ --- Review request for atlas, Ayub Pathan, Madhan Neethiraj, Nixon Rodrigues, Saqeeb Shaikh, Sarath Subramanian, and Vimal Sharma. Repository: atlas Description --- ATLAS-1292: Fix for integration tests Diffs - client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 50ca842 webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java f9e4c40 Diff: https://reviews.apache.org/r/53976/diff/ Testing --- All ITs passing except the EntityNotificationIT Thanks, Apoorv Naik
Re: Review Request 53968: ATLAS-1314: update typedefs with addition of 'options' attribute
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53968/#review156546 --- Ship it! Ship It! - Apoorv Naik On Nov. 21, 2016, 11:02 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53968/ > --- > > (Updated Nov. 21, 2016, 11:02 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1314 > https://issues.apache.org/jira/browse/ATLAS-1314 > > > Repository: atlas > > > Description > --- > > - added 'options' attribute to AtlasBaseTypeDef > - created 'UPDATE_TYPEDEF_OPTIONS' patch handler > - added typedef-patch to update options for hive_table and hive_column > > > Diffs > - > > addons/models/patches/002-hive_column_table_add_options.json PRE-CREATION > common/src/main/java/org/apache/atlas/repository/Constants.java 6175ac2 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 8ee3458 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java > d953633 > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java > 2e34127 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java > 86e2388 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > 582b095 > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > c8c22eb > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java > ffa73e2 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java > 53d6591 > > Diff: https://reviews.apache.org/r/53968/diff/ > > > Testing > --- > > - verified that Atlas server startup loads the typedef-patches that add > options attribute and REST APIs handle the new attribute correctly > > > Thanks, > > Madhan Neethiraj > >
Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53960/ --- Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. Repository: atlas Description --- ATLAS-1307: Integration test calls routing via the Client. Diffs - client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 1d50884 webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 50ca842 webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java f9e4c40 webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 18d4642 webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 9aff145 webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java b6dae4d Diff: https://reviews.apache.org/r/53960/diff/ Testing --- All tests passing Thanks, Apoorv Naik
[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Summary: Integration tests for Entity V2 REST APIs (was: New client for Entity V2 REST APIs) > Integration tests for Entity V2 REST APIs > - > > Key: ATLAS-1311 > URL: https://issues.apache.org/jira/browse/ATLAS-1311 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > > Currently there's no client that can be used for client integration/ ITs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1311) Integration tests for Entity V2 REST APIs
[ https://issues.apache.org/jira/browse/ATLAS-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1311: --- Description: Currently there's no IT for the new REST API. (was: Currently there's no client that can be used for client integration/ ITs.) > Integration tests for Entity V2 REST APIs > - > > Key: ATLAS-1311 > URL: https://issues.apache.org/jira/browse/ATLAS-1311 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > > Currently there's no IT for the new REST API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1301) Client calls from the IT retries more than what's specified
[ https://issues.apache.org/jira/browse/ATLAS-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1301: --- Summary: Client calls from the IT retries more than what's specified (was: New Client retries more than what's specified) > Client calls from the IT retries more than what's specified > --- > > Key: ATLAS-1301 > URL: https://issues.apache.org/jira/browse/ATLAS-1301 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > > The client refactoring led to nesting of two retry calls, so the retry > mechanism will end up running n*n time. > The patch fixes the nesting and simplifies the client API -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ATLAS-1303) Update hashCode and equals method to use standard JDK libraries
[ https://issues.apache.org/jira/browse/ATLAS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1303: --- Attachment: 0001-Updated-equals-and-hashCode-signatures.patch > Update hashCode and equals method to use standard JDK libraries > --- > > Key: ATLAS-1303 > URL: https://issues.apache.org/jira/browse/ATLAS-1303 > Project: Atlas > Issue Type: Improvement >Affects Versions: 0.8-incubating > Reporter: Apoorv Naik > Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: 0001-Updated-equals-and-hashCode-signatures.patch > > > Currently all the hashCode and equals methods use numerous if-else branches > to determine the result. This change uses the existing JDK7 > Objects.equals(...) and Objects.hashCode(...) instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
