Re: Making C++ implementation same as std
Thank you. On Tuesday, 17 December, 2019, 09:36:44 am IST, Purushotham Nayak wrote: Hi Thiru, Thanks for pointers. I will split up the changes into two parts. First, just add support for C++11 without breaking existing users and then in next step will work on updating the streams. Will create a pull request once the first part is done. Thanks, Purush
[jira] [Commented] (AVRO-2657) Fix broken data interop test for Python2
[
https://issues.apache.org/jira/browse/AVRO-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998334#comment-16998334
]
Ryan Skraba commented on AVRO-2657:
---
Oh, nice catch! I didn't notice these files moved.
Perhaps a quick check to explicitly fail (for a case like this) would be to
validate the contents of the build/interop/data directory between
*interop-data-generate* and *interop-data-test* in the root `./build.sh`
script. Either count the files or verify a minimum set to make sure that all
languages participated in the setup correctly.
A heavyweight check would be to note every time we test language1 -> language2
(in a file?), and check that there aren't any "holes" in the coverage after
running all the interop tests, but that doesn't seem to offer much more for the
extra effort.
> Fix broken data interop test for Python2
>
>
> Key: AVRO-2657
> URL: https://issues.apache.org/jira/browse/AVRO-2657
> Project: Apache Avro
> Issue Type: Bug
> Components: interop, python
>Reporter: Kengo Seki
>Assignee: Michael A. Smith
>Priority: Major
>
> [~kojiromike] [~ryanskraba], after AVRO-831 has been merged, the data interop
> test for Python2 seems to be broken.
> The interop tests should refer to build/interop/data in the Avro's toplevel
> directory, but the one for Python2 refers to lang/py/avro/test/interop/data.
> So other bindings don't check the output from Python2 and vice versa for now.
> {code}
> $ ./build.sh docker
> (snip)
> sekikn@8359bbe828fe:~/avro$ ./build.sh clean test
> (snip)
> sekikn@8359bbe828fe:~/avro$ ls build/interop/data
> c.avro java.avro java_snappy.avro perl.avro
> php.avro py3_bzip2.avropy3_xz.avro ruby_deflate.avro
> csharp.avro java_bzip2.avrojava_xz.avro
> perl_deflate.avrophp_deflate.avro py3_deflate.avro py3_zstandard.avro
> ruby_snappy.avro
> csharp_deflate.avro java_deflate.avro java_zstandard.avro
> perl_zstandard.avro py3.avro py3_snappy.avro ruby.avro
> ruby_zstandard.avro
> sekikn@8359bbe828fe:~/avro$ ls lang/py/avro/test/interop/data
> py.avro py_deflate.avro py_snappy.avro py_zstandard.avro
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2634) Fix critical CVE in Javascript component
[ https://issues.apache.org/jira/browse/AVRO-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998244#comment-16998244 ] ASF subversion and git services commented on AVRO-2634: --- Commit 38c3d0b804e848f676e1e02cf80e6d9d73feda30 in avro's branch refs/heads/branch-1.9 from Colm O hEigeartaigh [ https://gitbox.apache.org/repos/asf?p=avro.git;h=38c3d0b ] AVRO-2634: Fix critical CVE in Javascript component > Fix critical CVE in Javascript component > > > Key: AVRO-2634 > URL: https://issues.apache.org/jira/browse/AVRO-2634 > Project: Apache Avro > Issue Type: Improvement > Components: javascript >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Major > Fix For: 1.9.2 > > > There is a critical CVE in the Javascript component that we should fix > (https://npmjs.com/advisories/146) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AVRO-2634) Fix critical CVE in Javascript component
[ https://issues.apache.org/jira/browse/AVRO-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía resolved AVRO-2634. Resolution: Fixed > Fix critical CVE in Javascript component > > > Key: AVRO-2634 > URL: https://issues.apache.org/jira/browse/AVRO-2634 > Project: Apache Avro > Issue Type: Improvement > Components: javascript >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Major > Fix For: 1.9.2 > > > There is a critical CVE in the Javascript component that we should fix > (https://npmjs.com/advisories/146) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AVRO-2641) Generated code results in java.lang.ClassCastException when deserializing
[ https://issues.apache.org/jira/browse/AVRO-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Magne Moss Helleborg updated AVRO-2641: --- Description: SpecificRecord put() used by datumreader does not account for that String fields can be represented as org.apache.avro.util.Utf8 or other CharSequence which might not be castable to java.lang.String. The result is that when it tries to deserialize Utf8-fields it fails with a ClassCastException. Proposed solution: toString() instead of cast for Strings. To reproduce error: Serialize schema with String definitions from the .Net Avro library, ex Confluent.Apache.Avro. It will default to UTF-8 for strings, and fail when deserializing the same schema from the JVM. was: SpecificRecord put() used by datumreader does not account for that String fields can be represented as org.apache.avro.util.Utf8 or other CharSequence which might not be castable to java.lang.String. The result is that when it tries to deserialize Utf8-fields it fails with a ClassCastException. Proposed solution: toString() instead of cast for Strings. To reproduce error: Serialize from the C# > Generated code results in java.lang.ClassCastException when deserializing > - > > Key: AVRO-2641 > URL: https://issues.apache.org/jira/browse/AVRO-2641 > Project: Apache Avro > Issue Type: Bug > Components: java >Affects Versions: 1.8.0 >Reporter: Magne Moss Helleborg >Priority: Major > > SpecificRecord put() used by datumreader does not account for that String > fields can be represented as org.apache.avro.util.Utf8 or other CharSequence > which might not be castable to java.lang.String. > The result is that when it tries to deserialize Utf8-fields it fails with a > ClassCastException. > Proposed solution: toString() instead of cast for Strings. > > To reproduce error: Serialize schema with String definitions from the .Net > Avro library, ex Confluent.Apache.Avro. It will default to UTF-8 for strings, > and fail when deserializing the same schema from the JVM. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AVRO-2641) Generated code results in java.lang.ClassCastException when deserializing
[ https://issues.apache.org/jira/browse/AVRO-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Magne Moss Helleborg updated AVRO-2641: --- Description: SpecificRecord put() used by datumreader does not account for that String fields can be represented as org.apache.avro.util.Utf8 or other CharSequence which might not be castable to java.lang.String. The result is that when it tries to deserialize Utf8-fields it fails with a ClassCastException. Proposed solution: toString() instead of cast for Strings. To reproduce error: Serialize from the C# was: SpecificRecord put() used by datumreader does not account for that String fields can be represented as org.apache.avro.util.Utf8 or other CharSequence which might not be castable to java.lang.String. The result is that when it tries to deserialize Utf8-fields it fails with a ClassCastException. Proposed solution: toString() instead of cast for Strings. > Generated code results in java.lang.ClassCastException when deserializing > - > > Key: AVRO-2641 > URL: https://issues.apache.org/jira/browse/AVRO-2641 > Project: Apache Avro > Issue Type: Bug > Components: java >Affects Versions: 1.8.0 >Reporter: Magne Moss Helleborg >Priority: Major > > SpecificRecord put() used by datumreader does not account for that String > fields can be represented as org.apache.avro.util.Utf8 or other CharSequence > which might not be castable to java.lang.String. > The result is that when it tries to deserialize Utf8-fields it fails with a > ClassCastException. > Proposed solution: toString() instead of cast for Strings. > > To reproduce error: Serialize from the C# -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2625) System.out should not be used as a log record
[
https://issues.apache.org/jira/browse/AVRO-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998081#comment-16998081
]
Hudson commented on AVRO-2625:
--
SUCCESS: Integrated in Jenkins build AvroJava #787 (See
[https://builds.apache.org/job/AvroJava/787/])
AVRO-2625:System.out.print should not be used a log record (ryan:
[https://github.com/apache/avro/commit/b9679a8986638304ffde1c99d203bb34754bc1ad])
* (edit)
lang/java/mapred/src/main/java/org/apache/avro/mapred/AvroMultipleInputs.java
* (edit)
lang/java/mapred/src/main/java/org/apache/avro/mapred/DelegatingInputFormat.java
* (edit)
lang/java/mapred/src/main/java/org/apache/avro/mapred/tether/TetheredProcess.java
> System.out should not be used as a log record
> -
>
> Key: AVRO-2625
> URL: https://issues.apache.org/jira/browse/AVRO-2625
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
>Reporter: Zezeng Wang
>Assignee: Zezeng Wang
>Priority: Minor
> Fix For: 1.10.0, 1.9.2
>
>
> {panel:title=Description|titleBGColor=#88DE88|bgColor=#DDD}
> In Avro-mapred:
> [https://github.com/apache/avro/blob/eab8e019d6452c5cf54c1278db51861ca9bf6aac/lang/java/mapred/src/main/java/org/apache/avro/mapred/tether/TetheredProcess.java#L219|http://example.com]
> Using system.out.print and log to print together, which makes me wonder, is
> this a specific intention?
> If you change to log.info, do you have any other comments?
> {panel}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: New Committer: Ryan Skraba
Congratulations and thanks for the great work, Ryan! On Tue, Dec 17, 2019 at 04:43 Driesprong, Fokko wrote: > Folks, > > The Project Management Committee (PMC) for Apache Avro has invited Ryan > Skraba to become a committer and we are pleased to announce that he has > accepted. Ryan is actively fixing bugs by providing patches and reviewing > pull requests by others. We're very happy to have him on board. > > Being a committer enables easier contribution to the project since there is > no need to go via the patch submission process. This should enable better > productivity. > > Please join me in congratulating Ryan on his recognition of great work thus > far in our community. > > Cheers, Fokko >
[jira] [Updated] (AVRO-2634) Fix critical CVE in Javascript component
[ https://issues.apache.org/jira/browse/AVRO-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía updated AVRO-2634: --- Fix Version/s: (was: 1.10.0) > Fix critical CVE in Javascript component > > > Key: AVRO-2634 > URL: https://issues.apache.org/jira/browse/AVRO-2634 > Project: Apache Avro > Issue Type: Improvement > Components: javascript >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Major > Fix For: 1.9.2 > > > There is a critical CVE in the Javascript component that we should fix > (https://npmjs.com/advisories/146) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AVRO-2625) System.out should not be used as a log record
[
https://issues.apache.org/jira/browse/AVRO-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Skraba resolved AVRO-2625.
---
Resolution: Fixed
> System.out should not be used as a log record
> -
>
> Key: AVRO-2625
> URL: https://issues.apache.org/jira/browse/AVRO-2625
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
>Reporter: Zezeng Wang
>Assignee: Zezeng Wang
>Priority: Minor
> Fix For: 1.10.0, 1.9.2
>
>
> {panel:title=Description|titleBGColor=#88DE88|bgColor=#DDD}
> In Avro-mapred:
> [https://github.com/apache/avro/blob/eab8e019d6452c5cf54c1278db51861ca9bf6aac/lang/java/mapred/src/main/java/org/apache/avro/mapred/tether/TetheredProcess.java#L219|http://example.com]
> Using system.out.print and log to print together, which makes me wonder, is
> this a specific intention?
> If you change to log.info, do you have any other comments?
> {panel}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (AVRO-2625) System.out should not be used as a log record
[
https://issues.apache.org/jira/browse/AVRO-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Skraba reassigned AVRO-2625:
-
Assignee: Zezeng Wang
> System.out should not be used as a log record
> -
>
> Key: AVRO-2625
> URL: https://issues.apache.org/jira/browse/AVRO-2625
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
>Reporter: Zezeng Wang
>Assignee: Zezeng Wang
>Priority: Minor
> Fix For: 1.10.0, 1.9.2
>
>
> {panel:title=Description|titleBGColor=#88DE88|bgColor=#DDD}
> In Avro-mapred:
> [https://github.com/apache/avro/blob/eab8e019d6452c5cf54c1278db51861ca9bf6aac/lang/java/mapred/src/main/java/org/apache/avro/mapred/tether/TetheredProcess.java#L219|http://example.com]
> Using system.out.print and log to print together, which makes me wonder, is
> this a specific intention?
> If you change to log.info, do you have any other comments?
> {panel}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2625) System.out should not be used as a log record
[
https://issues.apache.org/jira/browse/AVRO-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998073#comment-16998073
]
ASF subversion and git services commented on AVRO-2625:
---
Commit 98f4a65ca29437912d1ae2bfbe5ca599b409eeea in avro's branch
refs/heads/branch-1.9 from zeshuai007
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=98f4a65 ]
AVRO-2625:System.out.print should not be used a log record
> System.out should not be used as a log record
> -
>
> Key: AVRO-2625
> URL: https://issues.apache.org/jira/browse/AVRO-2625
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
>Reporter: Zezeng Wang
>Priority: Minor
> Fix For: 1.10.0, 1.9.2
>
>
> {panel:title=Description|titleBGColor=#88DE88|bgColor=#DDD}
> In Avro-mapred:
> [https://github.com/apache/avro/blob/eab8e019d6452c5cf54c1278db51861ca9bf6aac/lang/java/mapred/src/main/java/org/apache/avro/mapred/tether/TetheredProcess.java#L219|http://example.com]
> Using system.out.print and log to print together, which makes me wonder, is
> this a specific intention?
> If you change to log.info, do you have any other comments?
> {panel}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (AVRO-2625) System.out should not be used as a log record
[
https://issues.apache.org/jira/browse/AVRO-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Skraba updated AVRO-2625:
--
Fix Version/s: 1.9.2
> System.out should not be used as a log record
> -
>
> Key: AVRO-2625
> URL: https://issues.apache.org/jira/browse/AVRO-2625
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
>Reporter: Zezeng Wang
>Priority: Minor
> Fix For: 1.10.0, 1.9.2
>
>
> {panel:title=Description|titleBGColor=#88DE88|bgColor=#DDD}
> In Avro-mapred:
> [https://github.com/apache/avro/blob/eab8e019d6452c5cf54c1278db51861ca9bf6aac/lang/java/mapred/src/main/java/org/apache/avro/mapred/tether/TetheredProcess.java#L219|http://example.com]
> Using system.out.print and log to print together, which makes me wonder, is
> this a specific intention?
> If you change to log.info, do you have any other comments?
> {panel}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (AVRO-2625) System.out should not be used as a log record
[
https://issues.apache.org/jira/browse/AVRO-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Skraba updated AVRO-2625:
--
Fix Version/s: 1.10.0
> System.out should not be used as a log record
> -
>
> Key: AVRO-2625
> URL: https://issues.apache.org/jira/browse/AVRO-2625
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
>Reporter: Zezeng Wang
>Priority: Minor
> Fix For: 1.10.0
>
>
> {panel:title=Description|titleBGColor=#88DE88|bgColor=#DDD}
> In Avro-mapred:
> [https://github.com/apache/avro/blob/eab8e019d6452c5cf54c1278db51861ca9bf6aac/lang/java/mapred/src/main/java/org/apache/avro/mapred/tether/TetheredProcess.java#L219|http://example.com]
> Using system.out.print and log to print together, which makes me wonder, is
> this a specific intention?
> If you change to log.info, do you have any other comments?
> {panel}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2625) System.out should not be used as a log record
[
https://issues.apache.org/jira/browse/AVRO-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998038#comment-16998038
]
ASF subversion and git services commented on AVRO-2625:
---
Commit b9679a8986638304ffde1c99d203bb34754bc1ad in avro's branch
refs/heads/master from zeshuai007
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=b9679a8 ]
AVRO-2625:System.out.print should not be used a log record
> System.out should not be used as a log record
> -
>
> Key: AVRO-2625
> URL: https://issues.apache.org/jira/browse/AVRO-2625
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
>Reporter: Zezeng Wang
>Priority: Minor
>
> {panel:title=Description|titleBGColor=#88DE88|bgColor=#DDD}
> In Avro-mapred:
> [https://github.com/apache/avro/blob/eab8e019d6452c5cf54c1278db51861ca9bf6aac/lang/java/mapred/src/main/java/org/apache/avro/mapred/tether/TetheredProcess.java#L219|http://example.com]
> Using system.out.print and log to print together, which makes me wonder, is
> this a specific intention?
> If you change to log.info, do you have any other comments?
> {panel}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: New Committer: Ryan Skraba
Welcome and congrats! On 2019. Dec 17., Tue at 10:43, Driesprong, Fokko wrote: > Folks, > > The Project Management Committee (PMC) for Apache Avro has invited Ryan > Skraba to become a committer and we are pleased to announce that he has > accepted. Ryan is actively fixing bugs by providing patches and reviewing > pull requests by others. We're very happy to have him on board. > > Being a committer enables easier contribution to the project since there is > no need to go via the patch submission process. This should enable better > productivity. > > Please join me in congratulating Ryan on his recognition of great work thus > far in our community. > > Cheers, Fokko >
New Committer: Ryan Skraba
Folks, The Project Management Committee (PMC) for Apache Avro has invited Ryan Skraba to become a committer and we are pleased to announce that he has accepted. Ryan is actively fixing bugs by providing patches and reviewing pull requests by others. We're very happy to have him on board. Being a committer enables easier contribution to the project since there is no need to go via the patch submission process. This should enable better productivity. Please join me in congratulating Ryan on his recognition of great work thus far in our community. Cheers, Fokko
