[jira] [Commented] (AVRO-3051) Modernize C++ implementation
[
https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296889#comment-17296889
]
Thiruvalluvan M. G. commented on AVRO-3051:
---
Merged the PR. Thanks a lot [~emkornfield] for your review. I hope you won't
mind if I mark you as a reviewer for the forthcoming patches as well.
> Modernize C++ implementation
>
>
> Key: AVRO-3051
> URL: https://issues.apache.org/jira/browse/AVRO-3051
> Project: Apache Avro
> Issue Type: Improvement
> Components: c++
>Reporter: Thiruvalluvan M. G.
>Assignee: Thiruvalluvan M. G.
>Priority: Major
>
> We have mandated C++11 in out builds. But the code itself is mostly C++98 or
> C++03 style. Thanks to C++ backward compatibility, it works well. But moving
> to "modern C++" (in the sense used by [Scott
> Meyers|[https://learning.oreilly.com/library/view/effective-modern-c/9781491908419/],]
> will make the code more compact, more readable and in some cases even faster.
> In this ticket I intend to introduce a series of pull requests modernizing
> the C++ implementation. I'll take extra care to keep the interface to the
> users the same. So most of the changes will be in the {{impl}} directory. The
> {{api}} directory may change a bit but will not break the current clients.
> For the initial round, we'll continue make it compile against C++11 standard.
> We can reap even more benefits by moving to something like C++17. But that is
> for another day.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-3051) Modernize C++ implementation
[
https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296888#comment-17296888
]
ASF subversion and git services commented on AVRO-3051:
---
Commit f4e2ebaadaf6e6d99b59882233f8024243adb55d in avro's branch
refs/heads/master from Thiruvalluvan M. G.
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=f4e2eba ]
AVRO-3051: Core C++ implementation is modernized (#1106)
* Core C++ implementation is modernized
* Addressed review comments
* One more review comment addressed
Co-authored-by: Thiruvalluvan M G
> Modernize C++ implementation
>
>
> Key: AVRO-3051
> URL: https://issues.apache.org/jira/browse/AVRO-3051
> Project: Apache Avro
> Issue Type: Improvement
> Components: c++
>Reporter: Thiruvalluvan M. G.
>Assignee: Thiruvalluvan M. G.
>Priority: Major
>
> We have mandated C++11 in out builds. But the code itself is mostly C++98 or
> C++03 style. Thanks to C++ backward compatibility, it works well. But moving
> to "modern C++" (in the sense used by [Scott
> Meyers|[https://learning.oreilly.com/library/view/effective-modern-c/9781491908419/],]
> will make the code more compact, more readable and in some cases even faster.
> In this ticket I intend to introduce a series of pull requests modernizing
> the C++ implementation. I'll take extra care to keep the interface to the
> users the same. So most of the changes will be in the {{impl}} directory. The
> {{api}} directory may change a bit but will not break the current clients.
> For the initial round, we'll continue make it compile against C++11 standard.
> We can reap even more benefits by moving to something like C++17. But that is
> for another day.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [avro] thiru-mg merged pull request #1106: AVRO-3051: Core C++ implementation is modernized
thiru-mg merged pull request #1106: URL: https://github.com/apache/avro/pull/1106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (AVRO-2933) avro c++ CMakeList enforces a specific version of C++ instead of letting user CXXFLAGS
[
https://issues.apache.org/jira/browse/AVRO-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvalluvan M. G. resolved AVRO-2933.
---
Fix Version/s: 1.11.0
Resolution: Fixed
Merged the pull request. Thank you [~tbarbier]. I'm very sorry about
extraordinary delay in merging this.
> avro c++ CMakeList enforces a specific version of C++ instead of letting user
> CXXFLAGS
> --
>
> Key: AVRO-2933
> URL: https://issues.apache.org/jira/browse/AVRO-2933
> Project: Apache Avro
> Issue Type: Bug
> Components: c++
>Affects Versions: 1.10.0, 1.9.2
>Reporter: Thomas Barbier
>Assignee: Thomas Barbier
>Priority: Minor
> Fix For: 1.11.0
>
>
> Hello,
> I have an issue with Avro C++:
> The CMakeList enforces the use of C++11
> (https://github.com/apache/avro/blob/master/lang/c%2B%2B/CMakeLists.txt#L57)
> {code:java}
> add_definitions(-std=c++11 -fPIC)
> {code}
> In local, I need to build with c++20 and therefore removed this line from my
> CMakeList (the std== parameters is in my CXXFLAGS).
>
> As I don't know what is the best practice to let users choose their C++
> version I create the issue to open the discussion and will submit a PR in
> case you agree with it.
>
> Best Regards
> Thomas
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (AVRO-2933) avro c++ CMakeList enforces a specific version of C++ instead of letting user CXXFLAGS
[
https://issues.apache.org/jira/browse/AVRO-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvalluvan M. G. reassigned AVRO-2933:
-
Assignee: Thomas Barbier
> avro c++ CMakeList enforces a specific version of C++ instead of letting user
> CXXFLAGS
> --
>
> Key: AVRO-2933
> URL: https://issues.apache.org/jira/browse/AVRO-2933
> Project: Apache Avro
> Issue Type: Bug
> Components: c++
>Affects Versions: 1.10.0, 1.9.2
>Reporter: Thomas Barbier
>Assignee: Thomas Barbier
>Priority: Minor
>
> Hello,
> I have an issue with Avro C++:
> The CMakeList enforces the use of C++11
> (https://github.com/apache/avro/blob/master/lang/c%2B%2B/CMakeLists.txt#L57)
> {code:java}
> add_definitions(-std=c++11 -fPIC)
> {code}
> In local, I need to build with c++20 and therefore removed this line from my
> CMakeList (the std== parameters is in my CXXFLAGS).
>
> As I don't know what is the best practice to let users choose their C++
> version I create the issue to open the discussion and will submit a PR in
> case you agree with it.
>
> Best Regards
> Thomas
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2933) avro c++ CMakeList enforces a specific version of C++ instead of letting user CXXFLAGS
[
https://issues.apache.org/jira/browse/AVRO-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296885#comment-17296885
]
ASF subversion and git services commented on AVRO-2933:
---
Commit 04928ad70d7c56f821f0cce2033984874c13f53a in avro's branch
refs/heads/master from Thomas-Barbier-1A
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=04928ad ]
Tentative fix for AVRO-2933 avro c++ CMakeList enforces a specific version of
C++ instead of letting user CXXFLAGS (#960)
> avro c++ CMakeList enforces a specific version of C++ instead of letting user
> CXXFLAGS
> --
>
> Key: AVRO-2933
> URL: https://issues.apache.org/jira/browse/AVRO-2933
> Project: Apache Avro
> Issue Type: Bug
> Components: c++
>Affects Versions: 1.10.0, 1.9.2
>Reporter: Thomas Barbier
>Priority: Minor
>
> Hello,
> I have an issue with Avro C++:
> The CMakeList enforces the use of C++11
> (https://github.com/apache/avro/blob/master/lang/c%2B%2B/CMakeLists.txt#L57)
> {code:java}
> add_definitions(-std=c++11 -fPIC)
> {code}
> In local, I need to build with c++20 and therefore removed this line from my
> CMakeList (the std== parameters is in my CXXFLAGS).
>
> As I don't know what is the best practice to let users choose their C++
> version I create the issue to open the discussion and will submit a PR in
> case you agree with it.
>
> Best Regards
> Thomas
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [avro] thiru-mg merged pull request #960: Tentative fix for AVRO-2933 avro c++ CMakeList enforces a specific ve…
thiru-mg merged pull request #960: URL: https://github.com/apache/avro/pull/960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (AVRO-3071) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/AVRO-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296833#comment-17296833 ] Sebb commented on AVRO-3071: Thanks for the prompt attention to this! > Please delete old releases from mirroring system > > > Key: AVRO-3071 > URL: https://issues.apache.org/jira/browse/AVRO-3071 > Project: Apache Avro > Issue Type: Task >Reporter: Sebb >Assignee: Ismaël Mejía >Priority: Major > > To reduce the load on the ASF mirrors, projects are required to archive old > releases [1] > It's unfair to expect the 3rd party mirrors to carry old releases. > Please can you archive all non-current releases? > [Remember to update the download page before dropping the files from > dist.apache.org!] > The following releases appear to be non-current: > https://dist.apache.org/repos/dist/release/avro/avro-1.9.2/ > If necessary, please also update your release procedures to ensure old > releases are archived > once a new release has been published. > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-3071) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/AVRO-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296799#comment-17296799 ] Ismaël Mejía commented on AVRO-3071: Thanks for letting us know [~sebb] it was me who forgot to remove the 1.9.2 version when doing the 1.10.0 release. All should be good now! > Please delete old releases from mirroring system > > > Key: AVRO-3071 > URL: https://issues.apache.org/jira/browse/AVRO-3071 > Project: Apache Avro > Issue Type: Task >Reporter: Sebb >Assignee: Ismaël Mejía >Priority: Major > > To reduce the load on the ASF mirrors, projects are required to archive old > releases [1] > It's unfair to expect the 3rd party mirrors to carry old releases. > Please can you archive all non-current releases? > [Remember to update the download page before dropping the files from > dist.apache.org!] > The following releases appear to be non-current: > https://dist.apache.org/repos/dist/release/avro/avro-1.9.2/ > If necessary, please also update your release procedures to ensure old > releases are archived > once a new release has been published. > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (AVRO-3071) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/AVRO-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía closed AVRO-3071. -- > Please delete old releases from mirroring system > > > Key: AVRO-3071 > URL: https://issues.apache.org/jira/browse/AVRO-3071 > Project: Apache Avro > Issue Type: Task >Reporter: Sebb >Assignee: Ismaël Mejía >Priority: Major > > To reduce the load on the ASF mirrors, projects are required to archive old > releases [1] > It's unfair to expect the 3rd party mirrors to carry old releases. > Please can you archive all non-current releases? > [Remember to update the download page before dropping the files from > dist.apache.org!] > The following releases appear to be non-current: > https://dist.apache.org/repos/dist/release/avro/avro-1.9.2/ > If necessary, please also update your release procedures to ensure old > releases are archived > once a new release has been published. > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AVRO-3071) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/AVRO-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía resolved AVRO-3071. Resolution: Fixed > Please delete old releases from mirroring system > > > Key: AVRO-3071 > URL: https://issues.apache.org/jira/browse/AVRO-3071 > Project: Apache Avro > Issue Type: Task >Reporter: Sebb >Assignee: Ismaël Mejía >Priority: Major > > To reduce the load on the ASF mirrors, projects are required to archive old > releases [1] > It's unfair to expect the 3rd party mirrors to carry old releases. > Please can you archive all non-current releases? > [Remember to update the download page before dropping the files from > dist.apache.org!] > The following releases appear to be non-current: > https://dist.apache.org/repos/dist/release/avro/avro-1.9.2/ > If necessary, please also update your release procedures to ensure old > releases are archived > once a new release has been published. > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (AVRO-3071) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/AVRO-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía reassigned AVRO-3071: -- Assignee: Ismaël Mejía > Please delete old releases from mirroring system > > > Key: AVRO-3071 > URL: https://issues.apache.org/jira/browse/AVRO-3071 > Project: Apache Avro > Issue Type: Task >Reporter: Sebb >Assignee: Ismaël Mejía >Priority: Major > > To reduce the load on the ASF mirrors, projects are required to archive old > releases [1] > It's unfair to expect the 3rd party mirrors to carry old releases. > Please can you archive all non-current releases? > [Remember to update the download page before dropping the files from > dist.apache.org!] > The following releases appear to be non-current: > https://dist.apache.org/repos/dist/release/avro/avro-1.9.2/ > If necessary, please also update your release procedures to ensure old > releases are archived > once a new release has been published. > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian Jira (v8.3.4#803005)
