[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685175#comment-16685175
]
ASF GitHub Bot commented on AVRO-2229:
--
Fokko closed pull request #343: AVRO-2229. Test using a Docker image
URL: https://github.com/apache/avro/pull/343
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.dockerignore b/.dockerignore
new file mode 100644
index 0..1d085cacc
--- /dev/null
+++ b/.dockerignore
@@ -0,0 +1 @@
+**
diff --git a/build.sh b/build.sh
index 8810d6bfa..dc1277208 100755
--- a/build.sh
+++ b/build.sh
@@ -38,41 +38,35 @@ do
case "$target" in
test)
- # run lang-specific tests
- (cd lang/java; ./build.sh test)
- # install java artifacts required by other builds and interop tests
- mvn install -DskipTests
- (cd lang/py; ./build.sh test)
- (cd lang/py3; ./build.sh test)
- (cd lang/c; ./build.sh test)
- (cd lang/c++; ./build.sh test)
- (cd lang/csharp; ./build.sh test)
- (cd lang/js; ./build.sh test)
- (cd lang/ruby; ./build.sh test)
- (cd lang/php; ./build.sh test)
- (cd lang/perl; ./build.sh test)
-
# create interop test data
mkdir -p build/interop/data
- (cd lang/java/avro; mvn -P interop-data-generate generate-resources)
- (cd lang/py; ant interop-data-generate)
- (cd lang/c; ./build.sh interop-data-generate)
- #(cd lang/c++; make interop-data-generate)
- (cd lang/ruby; rake generate_interop)
- (cd lang/php; ./build.sh interop-data-generate)
-
- # run interop data tests
- (cd lang/java; mvn test -P interop-data-test)
- (cd lang/py; ant interop-data-test)
- (cd lang/c; ./build.sh interop-data-test)
- #(cd lang/c++; make interop-data-test)
- (cd lang/ruby; rake interop)
- (cd lang/php; ./build.sh test-interop)
+
+ # install java artifacts required by other builds and interop tests
+ mvn -B install -DskipTests
+
+ for buildstep in test interop-data-generate interop-data-test
+ do
+for lang in `pwd`/lang/*/
+do
+ headline "# Run ${buildstep} for $lang"
+
+ if [[ "$lang" = *"c++"* ]]; then
+# The current cpp tests are failing:
+# https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2230
+(cd "$lang"; ./build.sh ${buildstep} || true)
+ else
+(cd "$lang"; ./build.sh ${buildstep})
+ fi
+done
+ done
# java needs to package the jars for the interop rpc tests
(cd lang/java; mvn package -DskipTests)
+
# run interop rpc test
- /bin/bash share/test/interop/bin/test_rpc_interop.sh
+ # Currently failing, need to be fixed:
+ # https://issues.apache.org/jira/browse/AVRO-2239
+ # /bin/bash share/test/interop/bin/test_rpc_interop.sh
;;
dist)
@@ -238,7 +232,10 @@ UserSpecificDocker
docker-test)
docker build -t avro-test -f share/docker/Dockerfile .
- docker run --rm -v ${PWD}:/avro/ avro-test
+ docker run --rm \
+ -v ${PWD}:/avro/ \
+ -v ${HOME}/.m2:/root/.m2 \
+ avro-test
;;
*)
@@ -247,5 +244,3 @@ UserSpecificDocker
esac
done
-
-exit 0
diff --git a/lang/c++/build.sh b/lang/c++/build.sh
index 17fff4089..2a018d602 100755
--- a/lang/c++/build.sh
+++ b/lang/c++/build.sh
@@ -18,7 +18,7 @@
set -e # exit on error
function usage {
- echo "Usage: $0 {test|dist|clean|install|doc}"
+ echo "Usage: $0
{test|dist|clean|install|doc|interop-data-test|interop-data-generate}"
exit 1
}
@@ -103,6 +103,14 @@ case "$target" in
rm -rf doc test.avro test6.df
;;
+ interop-data-generate)
+echo "Not (yet) implemented"
+;;
+
+ interop-data-test)
+echo "Not (yet) implemented"
+;;
+
install)
(cd build && cmake -G "Unix Makefiles" -D CMAKE_BUILD_TYPE=Release .. &&
make install)
;;
@@ -112,5 +120,3 @@ case "$target" in
esac
done
-
-exit 0
diff --git a/lang/c/build.sh b/lang/c/build.sh
index f76f03550..fcd0fe732 100755
--- a/lang/c/build.sh
+++ b/lang/c/build.sh
@@ -92,5 +92,3 @@ case "$1" in
echo "Usage: $0 {interop-data-generate|interop-data-test|test|dist|clean}"
exit 1
esac
-
-exit 0
diff --git a/lang/csharp/build.sh b/lang/csharp/build.sh
index cb9f7fc89..b6f585c91 100755
--- a/lang/csharp/build.sh
+++ b/lang/csharp/build.sh
@@ -58,9 +58,15 @@ case "$1" in
rm -f TestResult.xml
;;
+ interop-data-generate)
+echo "Not (yet) implemented"
+;;
+
+ interop-data-test)
+echo "Not (yet) implemented"
+;;
+
*)
echo "Usage: $0 {test|clean|dist|perf}"
exit 1
esac
-
-exit 0
diff --git
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680697#comment-16680697 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #343: AVRO-2229. Test using a Docker image URL: https://github.com/apache/avro/pull/343#issuecomment-437214743 Do you still want to merge this? I can't tell what this provides that wasn't in the other PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Apache Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646696#comment-16646696 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #343: [AVRO-2229][WIP] Test using a Docker image URL: https://github.com/apache/avro/pull/343#issuecomment-429016706 Lets wait with this one until we get #344 in This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640576#comment-16640576
]
ASF GitHub Bot commented on AVRO-2229:
--
Fokko commented on a change in pull request #343: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/343#discussion_r223173111
##
File path: lang/java/avro/build.sh
##
@@ -15,24 +15,30 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-headline(){
- echo -e
"\e[1;34m#"
- echo -e "# $1 \e[1;37m"
- echo -e
"\e[1;34m#\e[0m"
+set -e # exit on error
+
+function usage {
+ echo "Usage: $0 {test|clean|interop-data-generate|interop-data-test}"
+ exit 1
}
-set -e
+case "$target" in
+ test)
+mvn -B test
+;;
+
+ clean)
+mvn clean
+;;
-for lang in /avro/lang/*/
-do
- headline "Run tests: $lang"
- cd "$lang"
+ interop-data-test)
+mvn clean
+;;
+
+ *)
+usage
+esac
- if [[ "$lang" = *"c++"* ]]; then
-# The current cpp tests are failing:
-# https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2230
-./build.sh test || true
- else
-./build.sh test
- fi
done
+
+exit 0
Review comment:
Thanks, this was a copy-paste from other `build.sh` files
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Assignee: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640574#comment-16640574
]
ASF GitHub Bot commented on AVRO-2229:
--
Fokko commented on a change in pull request #343: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/343#discussion_r223173046
##
File path: build.sh
##
@@ -26,6 +26,12 @@ function usage {
exit 1
}
+headline(){
+ echo -e
"\e[1;34m#"
+ echo -e "# $1 \e[1;37m"
+ echo -e
"\e[1;34m#\e[0m"
Review comment:
Good point, I've ran into issues when running the scripts with Docker. It
does not have any tty: `tput: No value for $TERM and no -T specified`. For now
I've removed the colors since it doesn't really add much value.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Assignee: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640343#comment-16640343 ] ASF GitHub Bot commented on AVRO-2229: -- cutting commented on issue #343: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/343#issuecomment-427498739 We can merge this in under AVRO-2229, but it might also be a separate issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640296#comment-16640296
]
ASF GitHub Bot commented on AVRO-2229:
--
kojiromike commented on a change in pull request #343: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/343#discussion_r223125939
##
File path: lang/java/avro/build.sh
##
@@ -15,24 +15,30 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-headline(){
- echo -e
"\e[1;34m#"
- echo -e "# $1 \e[1;37m"
- echo -e
"\e[1;34m#\e[0m"
+set -e # exit on error
+
+function usage {
+ echo "Usage: $0 {test|clean|interop-data-generate|interop-data-test}"
+ exit 1
}
-set -e
+case "$target" in
+ test)
+mvn -B test
+;;
+
+ clean)
+mvn clean
+;;
-for lang in /avro/lang/*/
-do
- headline "Run tests: $lang"
- cd "$lang"
+ interop-data-test)
+mvn clean
+;;
+
+ *)
+usage
+esac
- if [[ "$lang" = *"c++"* ]]; then
-# The current cpp tests are failing:
-# https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2230
-./build.sh test || true
- else
-./build.sh test
- fi
done
+
+exit 0
Review comment:
This exit statement isn't necessary.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Assignee: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640028#comment-16640028 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427420247 Thanks for merging @cutting. I was still working on the PR, should have put a `[WIP]` in the title. I have a follow up PR here: https://github.com/apache/avro/pull/343 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640025#comment-16640025 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko opened a new pull request #343: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/343 Follow up PR of https://github.com/apache/avro/pull/336 Integrate the testing with the Docker image with the existing build.sh. @cutting @kojiromike This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639980#comment-16639980 ] ASF subversion and git services commented on AVRO-2229: --- Commit a11bd49e86d50f5a840ab2cdfe4f6927bedb4f93 in avro's branch refs/heads/master from [~Fokko] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=a11bd49 ] [AVRO-2229] Test using a Docker image (#336) * [AVRO-2229] Fix the docker-based build/test. > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639979#comment-16639979 ] ASF subversion and git services commented on AVRO-2229: --- Commit a11bd49e86d50f5a840ab2cdfe4f6927bedb4f93 in avro's branch refs/heads/master from [~Fokko] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=a11bd49 ] [AVRO-2229] Test using a Docker image (#336) * [AVRO-2229] Fix the docker-based build/test. > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639978#comment-16639978
]
ASF GitHub Bot commented on AVRO-2229:
--
cutting closed pull request #336: [AVRO-2229] Test using a Docker image
URL: https://github.com/apache/avro/pull/336
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/BUILD.txt b/BUILD.md
similarity index 67%
rename from BUILD.txt
rename to BUILD.md
index 223bc4d04..882338aee 100644
--- a/BUILD.txt
+++ b/BUILD.md
@@ -1,6 +1,6 @@
-Apache Avro Build Instructions
+# Apache Avro Build Instructions
-REQUIREMENTS
+## Requirements
The following packages must be installed before Avro can be built:
@@ -18,13 +18,18 @@ The following packages must be installed before Avro can be
built:
IO::String, Object::Tiny, Compress::ZLib, Test::More,
Test::Exception, Test::Pod
- Apache Ant 1.7
- - Apache Forrest 0.8 (for documentation)
+ - Apache Forrest 0.9 (for documentation)
- md5sum, sha1sum, used by top-level dist target
To simplify this, you can run a Docker container with all the above
-dependencies installed by installing docker.io and typing:
+dependencies installed by installing Docker and run:
- ./build.sh docker
+```bash
+./build.sh docker
+docker@539f6535c9db:~/avro$ cd lang/java/
+docker@539f6535c9db:~/avro/lang/java$ ./build.sh test
+[INFO] Scanning for projects...
+```
When this completes you will be in a shell running in the
container. Building the image the first time may take a while (20
@@ -36,11 +41,22 @@ The working directory in the container is mounted from your
host. This
allows you to access the files in your Avro development tree from the
Docker container.
-BUILDING
+## Building
Once the requirements are installed (or from the Docker container),
build.sh can be used as follows:
- './build.sh test' runs tests for all languages
- './build.sh dist' creates all release distribution files in dist/
- './build.sh clean' removes all generated artifacts
+```
+./build.sh test # runs tests for all languages
+./build.sh dist # creates all release distribution files in dist/
+./build.sh clean # removes all generated artifacts
+```
+
+## Testing
+
+Testing is done with the same Docker container as mentioned in the building
+step. The difference is that it will do clean run of the full test suite:
+
+```bash
+./build.sh docker-test
+```
diff --git a/build.sh b/build.sh
index 255e46af7..8810d6bfa 100755
--- a/build.sh
+++ b/build.sh
@@ -22,7 +22,7 @@ cd `dirname "$0"` # connect to root
VERSION=`cat share/VERSION.txt`
function usage {
- echo "Usage: $0 {test|dist|sign|clean|docker|rat|githooks}"
+ echo "Usage: $0 {test|dist|sign|clean|docker|rat|githooks|docker-test}"
exit 1
}
@@ -197,7 +197,7 @@ do
;;
docker)
- docker build -t avro-build share/docker
+ docker build -t avro-build -f share/docker/Dockerfile .
if [ "$(uname -s)" == "Linux" ]; then
USER_NAME=${SUDO_USER:=$USER}
USER_ID=$(id -u $USER_NAME)
@@ -217,13 +217,13 @@ UserSpecificDocker
# within the container and use the result on your normal
# system. And this also is a significant speedup in subsequent
# builds because the dependencies are downloaded only once.
- docker run --rm=true -t -i \
+ docker run --rm -t -i \
-v ${PWD}:/home/${USER_NAME}/avro \
-w /home/${USER_NAME}/avro \
-v ${HOME}/.m2:/home/${USER_NAME}/.m2 \
-v ${HOME}/.gnupg:/home/${USER_NAME}/.gnupg \
-u ${USER_NAME} \
-avro-build-${USER_NAME}
+avro-build-${USER_NAME} bash
;;
rat)
@@ -236,6 +236,11 @@ UserSpecificDocker
find .git/hooks/ -type f | fgrep -v sample | xargs chmod 755
;;
+docker-test)
+ docker build -t avro-test -f share/docker/Dockerfile .
+ docker run --rm -v ${PWD}:/avro/ avro-test
+ ;;
+
*)
usage
;;
diff --git a/lang/csharp/src/apache/codegen/app.config
b/lang/csharp/src/apache/codegen/app.config
index ae2479060..e8a42543c 100755
--- a/lang/csharp/src/apache/codegen/app.config
+++ b/lang/csharp/src/apache/codegen/app.config
@@ -15,5 +15,8 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-
-
+
+
+
+
+
diff --git a/lang/csharp/src/apache/perf/app.config
b/lang/csharp/src/apache/perf/app.config
index ae2479060..e8a42543c 100755
--- a/lang/csharp/src/apache/perf/app.config
+++ b/lang/csharp/src/apache/perf/app.config
@@ -15,5 +15,8 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-
-
+
+
+
+
+
diff --git
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639967#comment-16639967 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427409728 I've created a ticket for fixing the interop tests: https://issues.apache.org/jira/browse/AVRO-2239 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639156#comment-16639156 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427222300 (For your notes in the description, #335 is closed, duplicates work done in #326, which is now merged.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639146#comment-16639146 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427221202 @kojiromike I fully agree. But instead instead of introducing a new file for Docker testing (https://github.com/apache/avro/pull/336/files#diff-be31a75fe0e789d10685a4ab885644ad), I would prefer to use the current tests: https://github.com/apache/avro/blob/master/build.sh#L40-L75 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639145#comment-16639145 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427220920 Apologies, I hit enter too soon -- I want to add that I confirmed that the `test_rpc_interop.sh` fails with the exact same error in master. It has nothing to do with this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639143#comment-16639143 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427220777 I don't think the `test_rpc_interop.sh` test breakage has anything to do with this PR. I think it's a bug in the ruby implementation. I think this PR is fine and (besides the rat thing) moves the project forward. My vote fwiw is that this changeset get merged in so we can move forward with other incremental fixups. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639124#comment-16639124 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427217379 @kojiromike I'm working on integrating the Docker testing with the existing `build.sh`'s. But this requires some more love. At the current state of the PR, with the docker tests we'd only execute the unit tests. I think it is important to also add the interop tests, but this needs some more attention. I hope to finish this the upcoming days. Recently there was a mail about the Python versions. I've checked and the current CI uses Python 2.7 and Python 3.4. We should decide on Python versions, and add them to the `BUILD.md` and the `setup.py` of the specific project to communicate which versions of Python we support. I've created a Jira to move from the deprecated `java` docker image to `openjdk`: https://issues.apache.org/jira/browse/AVRO-2238 Updating is not trivial since the `java` is based on Debian Jessie, and `openjdk` is based on Debian Stretch. This will update a lot of different packages, for example, it comes with a newer version of Perl and PHP. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637337#comment-16637337
]
ASF GitHub Bot commented on AVRO-2229:
--
kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image
URL: https://github.com/apache/avro/pull/336#issuecomment-426742942
Bypassing the rat test and all the known-passing tests, I ran the rest of
the `./build.sh test` in docker as described above. The very last step failed:
```
+ /bin/bash share/test/interop/bin/test_rpc_interop.sh
TEST: share/test/interop/rpc/add/onePlusOne
18/10/03 18:16:25 INFO util.log: Logging initialized @337ms to
org.eclipse.jetty.util.log.Slf4jLog
18/10/03 18:16:25 INFO server.Server: jetty-9.4.z-SNAPSHOT
18/10/03 18:16:25 INFO handler.ContextHandler: Started
o.e.j.s.ServletContextHandler@441772e{/,null,AVAILABLE}
18/10/03 18:16:25 INFO server.AbstractConnector: Started
ServerConnector@79924b{HTTP/1.1,[http/1.1]}{0.0.0.0:46719}
18/10/03 18:16:25 INFO server.Server: Started @813ms
2
Closing server.
18/10/03 18:16:27 INFO server.AbstractConnector: Stopped
ServerConnector@79924b{HTTP/1.1,[http/1.1]}{0.0.0.0:0}
18/10/03 18:16:27 INFO handler.ContextHandler: Stopped
o.e.j.s.ServletContextHandler@441772e{/,null,UNAVAILABLE}
18/10/03 18:16:27 INFO util.log: Logging initialized @324ms to
org.eclipse.jetty.util.log.Slf4jLog
18/10/03 18:16:27 INFO server.Server: jetty-9.4.z-SNAPSHOT
18/10/03 18:16:28 INFO handler.ContextHandler: Started
o.e.j.s.ServletContextHandler@441772e{/,null,AVAILABLE}
18/10/03 18:16:28 INFO server.AbstractConnector: Started
ServerConnector@79924b{HTTP/1.1,[http/1.1]}{0.0.0.0:33359}
18/10/03 18:16:28 INFO server.Server: Started @420ms
2
Closing server.
18/10/03 18:16:29 INFO server.AbstractConnector: Stopped
ServerConnector@79924b{HTTP/1.1,[http/1.1]}{0.0.0.0:0}
18/10/03 18:16:29 INFO handler.ContextHandler: Stopped
o.e.j.s.ServletContextHandler@441772e{/,null,UNAVAILABLE}
18/10/03 18:16:30 INFO util.log: Logging initialized @323ms to
org.eclipse.jetty.util.log.Slf4jLog
18/10/03 18:16:30 INFO server.Server: jetty-9.4.z-SNAPSHOT
18/10/03 18:16:30 INFO handler.ContextHandler: Started
o.e.j.s.ServletContextHandler@441772e{/,null,AVAILABLE}
18/10/03 18:16:30 INFO server.AbstractConnector: Started
ServerConnector@79924b{HTTP/1.1,[http/1.1]}{0.0.0.0:34025}
18/10/03 18:16:30 INFO server.Server: Started @419ms
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:127:in
`validate_map': undefined method `keys' for nil:NilClass (NoMethodError)
from
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:103:in
`validate_recursive'
from
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:156:in `block in
validate_possible_types'
from
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:154:in `map'
from
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:154:in
`validate_possible_types'
from
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:141:in
`validate_union'
from
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:105:in
`validate_recursive'
from
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:110:in `block in
validate_recursive'
from
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:108:in `each'
from
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:108:in
`validate_recursive'
from
/home/michaels/avro/lang/ruby/lib/avro/schema_validator.rb:67:in `validate!'
from /home/michaels/avro/lang/ruby/lib/avro/schema.rb:97:in
`validate'
from /home/michaels/avro/lang/ruby/lib/avro/io.rb:503:in `write_data'
from /home/michaels/avro/lang/ruby/lib/avro/io.rb:499:in `write'
from /home/michaels/avro/lang/ruby/lib/avro/ipc.rb:136:in
`write_handshake_request'
from /home/michaels/avro/lang/ruby/lib/avro/ipc.rb:105:in `request'
from lang/ruby/test/tool.rb:69:in `send_message'
from lang/ruby/test/tool.rb:137:in `main'
from lang/ruby/test/tool.rb:143:in `'
```
I don't know if this is reflected in any other ticket.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635788#comment-16635788 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-426340029 @kojiromike This is actually a valid point of the rat checker. The licenses need to be set correctly I think I'll integrate the `run-tests.sh` in the root `build.sh`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634653#comment-16634653 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-426069227 Locally, I rebased master into this branch. Then I ran `./build.sh docker-test`. That passed. Then, I ran `./build.sh docker` followed by `./build.sh test` inside the container. That failed, due to rat, which complains that BUILD.md does not have a valid license header. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634647#comment-16634647 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-426067253 @Fokko Could you please rebase or merge master into this PR so we can have the fix for AVRO-2196? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634384#comment-16634384 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-425998771 @cutting well, to be strictly correct, we know that C++ tests do not pass, irrespective of this PR. That is AVRO-2230 and fixed in #335 as previously mentioned in @Fokko 's comments. This PR runs the C++ tests, but then continues even when they fail. Otherwise, I will run the rest of the tests a couple different ways and get back to you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633420#comment-16633420 ] ASF GitHub Bot commented on AVRO-2229: -- busbey commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-425732775 If I'm going to provide a review you'll have to be extremely patient. I have very limited volunteer time these days and right now it mostly gets used up in email related to the project. Given the importance of this changeset, I'd expect my turn around time to be 1-2 weeks. That's not to say anyone should block on me; I'm just setting expectations. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633407#comment-16633407 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-425729391 @busbey @nandorKollar @cutting PTAL. Any further suggestions, or it this good to go? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633260#comment-16633260
]
ASF GitHub Bot commented on AVRO-2229:
--
Fokko commented on a change in pull request #336: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/336#discussion_r221448847
##
File path: share/docker/run-tests.sh
##
@@ -0,0 +1,38 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+headline(){
+ echo -e
"\e[1;34m#"
+ echo -e "# $1 \e[1;37m"
+ echo -e
"\e[1;34m#\e[0m"
+}
+
+set -e
+
+for lang in $(ls /avro/lang/)
Review comment:
Thanks, just did
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633020#comment-16633020 ] Michael A. Smith commented on AVRO-2229: Did you not run into a java test failure due to AVRO-2196? I found that that failed for me until I included Niels Basjes fix for that. > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633010#comment-16633010
]
ASF GitHub Bot commented on AVRO-2229:
--
kojiromike commented on a change in pull request #336: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/336#discussion_r221427987
##
File path: share/docker/run-tests.sh
##
@@ -0,0 +1,38 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+headline(){
+ echo -e
"\e[1;34m#"
+ echo -e "# $1 \e[1;37m"
+ echo -e
"\e[1;34m#\e[0m"
+}
+
+set -e
+
+for lang in $(ls /avro/lang/)
Review comment:
Please write this using a glob expression
```
for lang in /avro/lang/*/
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632785#comment-16632785
]
ASF GitHub Bot commented on AVRO-2229:
--
Fokko commented on a change in pull request #336: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/336#discussion_r221416112
##
File path: share/docker/run-tests.sh
##
@@ -0,0 +1,66 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+function headline(){
+ echo -e
"\e[1;34m#"
+ echo -e "# $1 \e[1;37m"
+ echo -e
"\e[1;34m#\e[0m"
+}
+
+set -e
+
+headline "Run Java tests"
+cd /avro/lang/java
+./build.sh test
+
+headline "Run Python2 tests"
+cd /avro/lang/py
+./build.sh test
+
+headline "Run Python3 tests"
+cd /avro/lang/py3
+./build.sh test
+
+headline "Run C tests"
+cd /avro/lang/c
+./build.sh test
+
+headline "Run C++ tests"
+cd /avro/lang/c++
+# The current cpp tests are failing:
+# https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2230
Review comment:
My C++ skills are not so great. After university I haven't done much, so I'm
not familiar with the different versions. My preference would be to update #335
after this one gets merged and then enable the test again
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632784#comment-16632784 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-425615871 @kojiromike My pleasure, I've updated the PR based on your comments. Let me know what you think. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632783#comment-16632783
]
ASF GitHub Bot commented on AVRO-2229:
--
Fokko commented on a change in pull request #336: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/336#discussion_r221416089
##
File path: share/docker/run-tests.sh
##
@@ -0,0 +1,66 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+function headline(){
+ echo -e
"\e[1;34m#"
+ echo -e "# $1 \e[1;37m"
+ echo -e
"\e[1;34m#\e[0m"
+}
+
+set -e
+
+headline "Run Java tests"
+cd /avro/lang/java
+./build.sh test
+
+headline "Run Python2 tests"
+cd /avro/lang/py
+./build.sh test
+
+headline "Run Python3 tests"
+cd /avro/lang/py3
+./build.sh test
+
+headline "Run C tests"
+cd /avro/lang/c
+./build.sh test
+
+headline "Run C++ tests"
+cd /avro/lang/c++
+# The current cpp tests are failing:
+# https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2230
+./build.sh test || true
+
+headline "Run C# tests"
+cd /avro/lang/csharp
+./build.sh test
+
+echo "Run Ruby tests"
+cd /avro/lang/ruby
+./build.sh test
+
+echo "Run PHP tests"
+cd /avro/lang/php
+./build.sh test
+
+echo "Run JS tests"
+cd /avro/lang/js
+./build.sh test
+
+echo "Run Perl tests"
+cd /avro/lang/perl
+./build.sh test
Review comment:
Thanks for the tip, I didn't know spellcheck, but it really helps. I've
added some double quotes, as suggested by spellcheck.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632770#comment-16632770 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on a change in pull request #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#discussion_r221414827 ## File path: share/docker/Dockerfile ## @@ -21,52 +21,88 @@ FROM java:8-jdk WORKDIR /root +SHELL ["/bin/bash", "-o", "pipefail", "-c"] + # Add the repository for node.js 4.x RUN curl -sL https://deb.nodesource.com/setup_4.x | bash - # Install dependencies from packages -RUN apt-get update && apt-get install --no-install-recommends -y \ - git subversion curl ant make maven \ - gcc cmake libjansson-dev asciidoc source-highlight \ - g++ flex bison libboost-all-dev doxygen \ - mono-devel mono-gmcs nunit \ - nodejs \ - perl \ - php5 phpunit php5-gmp bzip2 \ - python python-setuptools python3-setuptools \ - ruby ruby-dev rake \ - libsnappy1 libsnappy-dev +RUN apt-get update && \ + apt-get install --no-install-recommends -y \ +ant \ +asciidoc \ +bison \ +bzip2 \ +cmake \ +curl \ +doxygen \ +flex \ +g++ \ +gcc \ +git \ +libboost-all-dev \ +libfontconfig1-dev \ +libfreetype6-dev \ +libglib2.0-dev \ +libjansson-dev \ +libsnappy-dev \ +libsnappy1 \ +make \ +maven \ +mono-devel \ +nodejs \ +nunit \ +perl \ +php5 \ +php5-gmp \ +phpunit \ +python \ +python-setuptools \ +python3-setuptools \ +rake \ +ruby \ +ruby-dev \ +source-highlight \ +subversion && \ + apt-get clean && \ + rm -rf /var/lib/apt/lists/* # Install Forrest in /usr/local/apache-forrest -# Download -RUN cd /usr/local/ && wget "http://www.apache.org/dyn/closer.lua?action=download=/forrest/apache-forrest-0.9-sources.tar.gz; -O "apache-forrest-0.9-sources.tar.gz" -RUN cd /usr/local/ && wget "http://www.apache.org/dyn/closer.lua?action=download=/forrest/apache-forrest-0.9-dependencies.tar.gz; -O "apache-forrest-0.9-dependencies.tar.gz" - -# Unpack Apache Forrest -RUN cd /usr/local/ && \ -tar xzf apache-forrest-0.9-sources.tar.gz && \ -tar xzf apache-forrest-0.9-dependencies.tar.gz && \ -mv apache-forrest-0.9 apache-forrest -RUN cd /usr/local/apache-forrest/main && ./build.sh +RUN curl -L -s "http://www.apache.org/dyn/closer.lua?action=download=/forrest/apache-forrest-0.9-sources.tar.gz; | tar -xzf - -C /usr/local/ && \ +curl -L -s "http://www.apache.org/dyn/closer.lua?action=download=/forrest/apache-forrest-0.9-dependencies.tar.gz; | tar -xzf - -C /usr/local/ && \ +mv /usr/local/apache-forrest-0.9 /usr/local/apache-forrest && \ +cd /usr/local/apache-forrest/main && \ +./build.sh # The solution for https://issues.apache.org/jira/browse/PIG-3906 -RUN mkdir -p /usr/local/apache-forrest/plugins && chmod a+rwX -R /usr/local/apache-forrest/plugins -RUN mkdir -p /usr/local/apache-forrest/build/plugins && chmod a+rwX -R /usr/local/apache-forrest/build/plugins - # Configure where forrest can be found -RUN echo 'forrest.home=/usr/local/apache-forrest' > build.properties +RUN mkdir -p /usr/local/apache-forrest/plugins && chmod a+rwX -R /usr/local/apache-forrest/plugins && \ +mkdir -p /usr/local/apache-forrest/build/plugins && chmod a+rwX -R /usr/local/apache-forrest/build/plugins && \ +echo 'forrest.home=/usr/local/apache-forrest' > build.properties + ENV FORREST_HOME /usr/local/apache-forrest # Install Perl modules -RUN curl -L http://cpanmin.us | perl - --self-upgrade # non-interactive cpan -RUN cpanm install Module::Install Module::Install::ReadmeFromPod \ +RUN curl -L http://cpanmin.us | perl - --self-upgrade && \ + cpanm install Module::Install Module::Install::ReadmeFromPod \ Module::Install::Repository \ Math::BigInt JSON::XS Try::Tiny Regexp::Common Encode \ IO::String Object::Tiny Compress::Zlib Test::More \ Test::Exception Test::Pod +# Install mono modules +RUN mkdir -p /tmp/nunit/ && \ + cd /tmp/nunit/ && \ + curl -L -s -o nunit.zip https://github.com/nunit-legacy/nunitv2/releases/download/2.7.0/NUnit-2.7.0.zip && \ Review comment: I'm aware of multistage builds, but I don't think it will add a lot of value in this case. I also had some issues with it on the Dockerhub builder when using multistage. Then the imported file from the earlier stage would be 0bytes. The reason I don't think it is useful, for the CI we won't cache the image at all. The `build.sh docker-test` will run on the CI, and for now it doesn't store the image somewhere. For local development, it makes more sense to use `build.sh docker`. Also, if the Dockerfile isn't changed, the layers are cached and it will just reuse the existing image. This
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632768#comment-16632768
]
ASF GitHub Bot commented on AVRO-2229:
--
Fokko commented on a change in pull request #336: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/336#discussion_r221414727
##
File path: share/docker/run-tests.sh
##
@@ -0,0 +1,66 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+function headline(){
Review comment:
Good one, thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632767#comment-16632767
]
ASF GitHub Bot commented on AVRO-2229:
--
Fokko commented on a change in pull request #336: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/336#discussion_r221414723
##
File path: share/docker/run-tests.sh
##
@@ -0,0 +1,66 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+function headline(){
+ echo -e
"\e[1;34m#"
+ echo -e "# $1 \e[1;37m"
+ echo -e
"\e[1;34m#\e[0m"
+}
+
+set -e
+
+headline "Run Java tests"
+cd /avro/lang/java
+./build.sh test
Review comment:
I've considered it a loop, so let me change it if you prefer a loop
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632187#comment-16632187 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-425517284 Thank you _so much_ for doing this work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632186#comment-16632186
]
ASF GitHub Bot commented on AVRO-2229:
--
kojiromike commented on a change in pull request #336: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/336#discussion_r221334189
##
File path: share/docker/run-tests.sh
##
@@ -0,0 +1,66 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+function headline(){
+ echo -e
"\e[1;34m#"
+ echo -e "# $1 \e[1;37m"
+ echo -e
"\e[1;34m#\e[0m"
+}
+
+set -e
+
+headline "Run Java tests"
+cd /avro/lang/java
+./build.sh test
+
+headline "Run Python2 tests"
+cd /avro/lang/py
+./build.sh test
+
+headline "Run Python3 tests"
+cd /avro/lang/py3
+./build.sh test
+
+headline "Run C tests"
+cd /avro/lang/c
+./build.sh test
+
+headline "Run C++ tests"
+cd /avro/lang/c++
+# The current cpp tests are failing:
+# https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2230
+./build.sh test || true
+
+headline "Run C# tests"
+cd /avro/lang/csharp
+./build.sh test
+
+echo "Run Ruby tests"
+cd /avro/lang/ruby
+./build.sh test
+
+echo "Run PHP tests"
+cd /avro/lang/php
+./build.sh test
+
+echo "Run JS tests"
+cd /avro/lang/js
+./build.sh test
+
+echo "Run Perl tests"
+cd /avro/lang/perl
+./build.sh test
Review comment:
Please consider running [shellcheck](https://github.com/koalaman/shellcheck)
on the shell scripts here. (Granted, it'll find bugs that have been around
forever and weren't introduced in this PR, but it's still worth fixing anything
relevant here.)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632182#comment-16632182 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on a change in pull request #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#discussion_r221333274 ## File path: share/docker/Dockerfile ## @@ -21,52 +21,88 @@ FROM java:8-jdk WORKDIR /root +SHELL ["/bin/bash", "-o", "pipefail", "-c"] + # Add the repository for node.js 4.x RUN curl -sL https://deb.nodesource.com/setup_4.x | bash - # Install dependencies from packages -RUN apt-get update && apt-get install --no-install-recommends -y \ - git subversion curl ant make maven \ - gcc cmake libjansson-dev asciidoc source-highlight \ - g++ flex bison libboost-all-dev doxygen \ - mono-devel mono-gmcs nunit \ - nodejs \ - perl \ - php5 phpunit php5-gmp bzip2 \ - python python-setuptools python3-setuptools \ - ruby ruby-dev rake \ - libsnappy1 libsnappy-dev +RUN apt-get update && \ + apt-get install --no-install-recommends -y \ +ant \ +asciidoc \ +bison \ +bzip2 \ +cmake \ +curl \ +doxygen \ +flex \ +g++ \ +gcc \ +git \ +libboost-all-dev \ +libfontconfig1-dev \ +libfreetype6-dev \ +libglib2.0-dev \ +libjansson-dev \ +libsnappy-dev \ +libsnappy1 \ +make \ +maven \ +mono-devel \ +nodejs \ +nunit \ +perl \ +php5 \ +php5-gmp \ +phpunit \ +python \ +python-setuptools \ +python3-setuptools \ +rake \ +ruby \ +ruby-dev \ +source-highlight \ +subversion && \ + apt-get clean && \ + rm -rf /var/lib/apt/lists/* # Install Forrest in /usr/local/apache-forrest -# Download -RUN cd /usr/local/ && wget "http://www.apache.org/dyn/closer.lua?action=download=/forrest/apache-forrest-0.9-sources.tar.gz; -O "apache-forrest-0.9-sources.tar.gz" -RUN cd /usr/local/ && wget "http://www.apache.org/dyn/closer.lua?action=download=/forrest/apache-forrest-0.9-dependencies.tar.gz; -O "apache-forrest-0.9-dependencies.tar.gz" - -# Unpack Apache Forrest -RUN cd /usr/local/ && \ -tar xzf apache-forrest-0.9-sources.tar.gz && \ -tar xzf apache-forrest-0.9-dependencies.tar.gz && \ -mv apache-forrest-0.9 apache-forrest -RUN cd /usr/local/apache-forrest/main && ./build.sh +RUN curl -L -s "http://www.apache.org/dyn/closer.lua?action=download=/forrest/apache-forrest-0.9-sources.tar.gz; | tar -xzf - -C /usr/local/ && \ +curl -L -s "http://www.apache.org/dyn/closer.lua?action=download=/forrest/apache-forrest-0.9-dependencies.tar.gz; | tar -xzf - -C /usr/local/ && \ +mv /usr/local/apache-forrest-0.9 /usr/local/apache-forrest && \ +cd /usr/local/apache-forrest/main && \ +./build.sh # The solution for https://issues.apache.org/jira/browse/PIG-3906 -RUN mkdir -p /usr/local/apache-forrest/plugins && chmod a+rwX -R /usr/local/apache-forrest/plugins -RUN mkdir -p /usr/local/apache-forrest/build/plugins && chmod a+rwX -R /usr/local/apache-forrest/build/plugins - # Configure where forrest can be found -RUN echo 'forrest.home=/usr/local/apache-forrest' > build.properties +RUN mkdir -p /usr/local/apache-forrest/plugins && chmod a+rwX -R /usr/local/apache-forrest/plugins && \ +mkdir -p /usr/local/apache-forrest/build/plugins && chmod a+rwX -R /usr/local/apache-forrest/build/plugins && \ +echo 'forrest.home=/usr/local/apache-forrest' > build.properties + ENV FORREST_HOME /usr/local/apache-forrest # Install Perl modules -RUN curl -L http://cpanmin.us | perl - --self-upgrade # non-interactive cpan -RUN cpanm install Module::Install Module::Install::ReadmeFromPod \ +RUN curl -L http://cpanmin.us | perl - --self-upgrade && \ + cpanm install Module::Install Module::Install::ReadmeFromPod \ Module::Install::Repository \ Math::BigInt JSON::XS Try::Tiny Regexp::Common Encode \ IO::String Object::Tiny Compress::Zlib Test::More \ Test::Exception Test::Pod +# Install mono modules +RUN mkdir -p /tmp/nunit/ && \ + cd /tmp/nunit/ && \ + curl -L -s -o nunit.zip https://github.com/nunit-legacy/nunitv2/releases/download/2.7.0/NUnit-2.7.0.zip && \ Review comment: One pattern I've found useful in Dockerfile lately is using [multistage builds](https://docs.docker.com/develop/develop-images/multistage-build) to encapsulate all download/unpack/cleanup in a image before the main build. This means if you make a cache-invalidating change early in the main build, it doesn't have to re-fetch the download. Something like this: ``` FROM java:8-jdk as fetchcache # Use any base here with curl, zip, tar, etc. WORKDIR /fetch/ RUN mkdir -p nunit && cd nunit && curl -L -s -o nunit.zip https://github.com/nunit-legacy/nunitv2/releases/download/2.7.0/NUnit-2.7.0.zip && unzip nunit.zip && rm nunit.zip # ...
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632171#comment-16632171
]
ASF GitHub Bot commented on AVRO-2229:
--
kojiromike commented on a change in pull request #336: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/336#discussion_r221330735
##
File path: share/docker/run-tests.sh
##
@@ -0,0 +1,66 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+function headline(){
Review comment:
It's slightly more portable to omit the `function` keyword.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632169#comment-16632169
]
ASF GitHub Bot commented on AVRO-2229:
--
kojiromike commented on a change in pull request #336: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/336#discussion_r221330628
##
File path: share/docker/run-tests.sh
##
@@ -0,0 +1,66 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+function headline(){
+ echo -e
"\e[1;34m#"
+ echo -e "# $1 \e[1;37m"
+ echo -e
"\e[1;34m#\e[0m"
+}
+
+set -e
+
+headline "Run Java tests"
+cd /avro/lang/java
+./build.sh test
Review comment:
What would you say to using a for loop here for all the langs?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632168#comment-16632168
]
ASF GitHub Bot commented on AVRO-2229:
--
kojiromike commented on a change in pull request #336: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/336#discussion_r221330306
##
File path: share/docker/run-tests.sh
##
@@ -0,0 +1,66 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+function headline(){
+ echo -e
"\e[1;34m#"
+ echo -e "# $1 \e[1;37m"
+ echo -e
"\e[1;34m#\e[0m"
+}
+
+set -e
+
+headline "Run Java tests"
+cd /avro/lang/java
+./build.sh test
+
+headline "Run Python2 tests"
+cd /avro/lang/py
+./build.sh test
+
+headline "Run Python3 tests"
+cd /avro/lang/py3
+./build.sh test
+
+headline "Run C tests"
+cd /avro/lang/c
+./build.sh test
+
+headline "Run C++ tests"
+cd /avro/lang/c++
+# The current cpp tests are failing:
+# https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2230
Review comment:
It's possible that upgrading to C++11 will also fix this issue. That may be
preferable to my fix in #335
Up to you if you want to give it a shot in this PR.
https://stackoverflow.com/a/25639772/418413
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
