Re: [Proposal] Enable Branch Protection for `release-.*` branches
This is done. We should be unable to delete release branches accidentally. Thanks everyone. On 2021/06/14 19:45:24, Robert Burke wrote: > Filed with INFRA: > https://issues.apache.org/jira/browse/INFRA-21995 > > On 2021/06/10 15:11:51, Robert Burke wrote: > > Ok. I'll fill a ticket with Infra tomorrow once the objection period has > > passed. Thanks! > > > > On Wed, Jun 9, 2021, 12:51 PM Kenneth Knowles wrote: > > > > > Great idea. I think only infra can do it. > > > > > > On Tue, Jun 8, 2021, 14:27 Robert Burke wrote: > > > > > >> During the last branch cleanup, it appears I accidentally deleted the > > >> release-2.26.0 branch. > > >> > > >> Lukasz Cwik pointed this out to me, and fortunately I was able to recover > > >> and push it back to the repo. However, Brian Hulette then pointed out > > >> github lets us set up rules to avoid accidental deletion of branches that > > >> match certain names. > > >> > > >> > > >> https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule > > >> > > >> So the proposal is we guard our release branches from accidental deletion > > >> using this mechanism. A repo admin (which I think is probably a PMC > > >> member?) can do so by following the linked instructions. > > >> > > >> My only note is that setting up such a rule sets the protection by > > >> default, and there shouldn't be any need to select other options (except > > >> at > > >> the PMC's discretion). > > >> > > >> Unless there's an objection (in the traditional ~3 day period), could a > > >> volunteer PMC set up such a protection rule, and prevent my error from > > >> recurring? > > >> > > >> Cheers > > >> Robert Burke > > >> Beam Go Busybody. > > >> > > >> > > >
Re: [Proposal] Enable Branch Protection for `release-.*` branches
Filed with INFRA: https://issues.apache.org/jira/browse/INFRA-21995 On 2021/06/10 15:11:51, Robert Burke wrote: > Ok. I'll fill a ticket with Infra tomorrow once the objection period has > passed. Thanks! > > On Wed, Jun 9, 2021, 12:51 PM Kenneth Knowles wrote: > > > Great idea. I think only infra can do it. > > > > On Tue, Jun 8, 2021, 14:27 Robert Burke wrote: > > > >> During the last branch cleanup, it appears I accidentally deleted the > >> release-2.26.0 branch. > >> > >> Lukasz Cwik pointed this out to me, and fortunately I was able to recover > >> and push it back to the repo. However, Brian Hulette then pointed out > >> github lets us set up rules to avoid accidental deletion of branches that > >> match certain names. > >> > >> > >> https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule > >> > >> So the proposal is we guard our release branches from accidental deletion > >> using this mechanism. A repo admin (which I think is probably a PMC > >> member?) can do so by following the linked instructions. > >> > >> My only note is that setting up such a rule sets the protection by > >> default, and there shouldn't be any need to select other options (except at > >> the PMC's discretion). > >> > >> Unless there's an objection (in the traditional ~3 day period), could a > >> volunteer PMC set up such a protection rule, and prevent my error from > >> recurring? > >> > >> Cheers > >> Robert Burke > >> Beam Go Busybody. > >> > >> >
Re: [Proposal] Enable Branch Protection for `release-.*` branches
Ok. I'll fill a ticket with Infra tomorrow once the objection period has passed. Thanks! On Wed, Jun 9, 2021, 12:51 PM Kenneth Knowles wrote: > Great idea. I think only infra can do it. > > On Tue, Jun 8, 2021, 14:27 Robert Burke wrote: > >> During the last branch cleanup, it appears I accidentally deleted the >> release-2.26.0 branch. >> >> Lukasz Cwik pointed this out to me, and fortunately I was able to recover >> and push it back to the repo. However, Brian Hulette then pointed out >> github lets us set up rules to avoid accidental deletion of branches that >> match certain names. >> >> >> https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule >> >> So the proposal is we guard our release branches from accidental deletion >> using this mechanism. A repo admin (which I think is probably a PMC >> member?) can do so by following the linked instructions. >> >> My only note is that setting up such a rule sets the protection by >> default, and there shouldn't be any need to select other options (except at >> the PMC's discretion). >> >> Unless there's an objection (in the traditional ~3 day period), could a >> volunteer PMC set up such a protection rule, and prevent my error from >> recurring? >> >> Cheers >> Robert Burke >> Beam Go Busybody. >> >>
Re: [Proposal] Enable Branch Protection for `release-.*` branches
Great idea. I think only infra can do it. On Tue, Jun 8, 2021, 14:27 Robert Burke wrote: > During the last branch cleanup, it appears I accidentally deleted the > release-2.26.0 branch. > > Lukasz Cwik pointed this out to me, and fortunately I was able to recover > and push it back to the repo. However, Brian Hulette then pointed out > github lets us set up rules to avoid accidental deletion of branches that > match certain names. > > > https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule > > So the proposal is we guard our release branches from accidental deletion > using this mechanism. A repo admin (which I think is probably a PMC > member?) can do so by following the linked instructions. > > My only note is that setting up such a rule sets the protection by > default, and there shouldn't be any need to select other options (except at > the PMC's discretion). > > Unless there's an objection (in the traditional ~3 day period), could a > volunteer PMC set up such a protection rule, and prevent my error from > recurring? > > Cheers > Robert Burke > Beam Go Busybody. > >
[Proposal] Enable Branch Protection for `release-.*` branches
During the last branch cleanup, it appears I accidentally deleted the release-2.26.0 branch. Lukasz Cwik pointed this out to me, and fortunately I was able to recover and push it back to the repo. However, Brian Hulette then pointed out github lets us set up rules to avoid accidental deletion of branches that match certain names. https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule So the proposal is we guard our release branches from accidental deletion using this mechanism. A repo admin (which I think is probably a PMC member?) can do so by following the linked instructions. My only note is that setting up such a rule sets the protection by default, and there shouldn't be any need to select other options (except at the PMC's discretion). Unless there's an objection (in the traditional ~3 day period), could a volunteer PMC set up such a protection rule, and prevent my error from recurring? Cheers Robert Burke Beam Go Busybody.
