Re: [Proposal] Enable EnricoMi/publish-unit-test-result-action

2023-09-11 Thread Kenneth Knowles
Awesome, thanks!

On Fri, Sep 8, 2023 at 1:22 PM Yi Hu via dev  wrote:

> Thanks for the feedback! A request has been sent to Apache Infra.
>
> I checked that GitHub Action workflows actually published the gradle scan
> (done by [1]), but some workflow added after [1] simply missed that
> setting. Opened [2] for clean up and improvements.
>
> Best,
> Yi
>
> [1] https://github.com/apache/beam/pull/28212
> [2] https://github.com/apache/beam/issues/28378
>
> On Tue, Sep 5, 2023 at 12:26 PM Kenneth Knowles  wrote:
>
>> +1 this seems useful.
>>
>> Some of the same functionality is also done pretty well or even more in
>> depth via gradle scan. If I recall, some GHA jobs do not upload those. Is
>> that also on the roadmap or is it blocked for some reason?
>>
>> Kenn
>>
>> On Tue, Sep 5, 2023 at 11:54 AM Bruno Volpato via dev <
>> dev@beam.apache.org> wrote:
>>
>>> +1, this is helpful.
>>>
>>> We had a similar situation with DataflowTemplates
>>> .
>>> Even though we used a different repository (mikepenz/action-junit-report
>>> ), this strategy was
>>> invaluable to reduce troubleshoot time (sample report
>>> 
>>> ).
>>>
>>> Thanks Yi!
>>>
>>>
>>>
>>> On Tue, Sep 5, 2023 at 11:26 AM Danny McCormick via dev <
>>> dev@beam.apache.org> wrote:
>>>
 Thanks Yi, I'm definitely +1 on adding this, this is definitely a gap
 in our GitHub Actions infra today.

 Thanks,
 Danny

 On Tue, Sep 5, 2023 at 10:35 AM Yi Hu via dev 
 wrote:

> Hi everyone,
>
> As you may have noticed, GitHub Action for test suites are setting up
> in the Beam repository. A current gap is that Jenkins has a pretty
> convenient test result page showing all tests / failed tests and stack
> trace, while these are not available in github workflow logs.
>
> Here we propose to introduce EnricoMi/publish-unit-test-result-action (
> https://github.com/EnricoMi/publish-unit-test-result-action) to
> publish Java (and possibly Python in the future) test results. An example
> PR can be found [1] and an INFRA ticket in [2]. Currently both Java and
> Python test reports are supported by this action (note that Jenkins test
> report page is also available only for Java and Python currently).
>
> Please feel free to comment if you have any questions and suggestions.
>
>
> [1] https://github.com/apache/beam/pull/28075
> [2] https://issues.apache.org/jira/browse/INFRA-24950
>
> Regards,
> Yi
> --
>
> Yi Hu, (he/him/his)
>
> Software Engineer
>
>
>


Re: [Proposal] Enable EnricoMi/publish-unit-test-result-action

2023-09-08 Thread Yi Hu via dev
Thanks for the feedback! A request has been sent to Apache Infra.

I checked that GitHub Action workflows actually published the gradle scan
(done by [1]), but some workflow added after [1] simply missed that
setting. Opened [2] for clean up and improvements.

Best,
Yi

[1] https://github.com/apache/beam/pull/28212
[2] https://github.com/apache/beam/issues/28378

On Tue, Sep 5, 2023 at 12:26 PM Kenneth Knowles  wrote:

> +1 this seems useful.
>
> Some of the same functionality is also done pretty well or even more in
> depth via gradle scan. If I recall, some GHA jobs do not upload those. Is
> that also on the roadmap or is it blocked for some reason?
>
> Kenn
>
> On Tue, Sep 5, 2023 at 11:54 AM Bruno Volpato via dev 
> wrote:
>
>> +1, this is helpful.
>>
>> We had a similar situation with DataflowTemplates
>> .
>> Even though we used a different repository (mikepenz/action-junit-report
>> ), this strategy was
>> invaluable to reduce troubleshoot time (sample report
>> 
>> ).
>>
>> Thanks Yi!
>>
>>
>>
>> On Tue, Sep 5, 2023 at 11:26 AM Danny McCormick via dev <
>> dev@beam.apache.org> wrote:
>>
>>> Thanks Yi, I'm definitely +1 on adding this, this is definitely a gap in
>>> our GitHub Actions infra today.
>>>
>>> Thanks,
>>> Danny
>>>
>>> On Tue, Sep 5, 2023 at 10:35 AM Yi Hu via dev 
>>> wrote:
>>>
 Hi everyone,

 As you may have noticed, GitHub Action for test suites are setting up
 in the Beam repository. A current gap is that Jenkins has a pretty
 convenient test result page showing all tests / failed tests and stack
 trace, while these are not available in github workflow logs.

 Here we propose to introduce EnricoMi/publish-unit-test-result-action (
 https://github.com/EnricoMi/publish-unit-test-result-action) to
 publish Java (and possibly Python in the future) test results. An example
 PR can be found [1] and an INFRA ticket in [2]. Currently both Java and
 Python test reports are supported by this action (note that Jenkins test
 report page is also available only for Java and Python currently).

 Please feel free to comment if you have any questions and suggestions.


 [1] https://github.com/apache/beam/pull/28075
 [2] https://issues.apache.org/jira/browse/INFRA-24950

 Regards,
 Yi
 --

 Yi Hu, (he/him/his)

 Software Engineer





Re: [Proposal] Enable EnricoMi/publish-unit-test-result-action

2023-09-05 Thread Kenneth Knowles
+1 this seems useful.

Some of the same functionality is also done pretty well or even more in
depth via gradle scan. If I recall, some GHA jobs do not upload those. Is
that also on the roadmap or is it blocked for some reason?

Kenn

On Tue, Sep 5, 2023 at 11:54 AM Bruno Volpato via dev 
wrote:

> +1, this is helpful.
>
> We had a similar situation with DataflowTemplates
> .
> Even though we used a different repository (mikepenz/action-junit-report
> ), this strategy was
> invaluable to reduce troubleshoot time (sample report
> 
> ).
>
> Thanks Yi!
>
>
>
> On Tue, Sep 5, 2023 at 11:26 AM Danny McCormick via dev <
> dev@beam.apache.org> wrote:
>
>> Thanks Yi, I'm definitely +1 on adding this, this is definitely a gap in
>> our GitHub Actions infra today.
>>
>> Thanks,
>> Danny
>>
>> On Tue, Sep 5, 2023 at 10:35 AM Yi Hu via dev 
>> wrote:
>>
>>> Hi everyone,
>>>
>>> As you may have noticed, GitHub Action for test suites are setting up in
>>> the Beam repository. A current gap is that Jenkins has a pretty convenient
>>> test result page showing all tests / failed tests and stack trace, while
>>> these are not available in github workflow logs.
>>>
>>> Here we propose to introduce EnricoMi/publish-unit-test-result-action (
>>> https://github.com/EnricoMi/publish-unit-test-result-action) to publish
>>> Java (and possibly Python in the future) test results. An example PR can be
>>> found [1] and an INFRA ticket in [2]. Currently both Java and Python test
>>> reports are supported by this action (note that Jenkins test report page is
>>> also available only for Java and Python currently).
>>>
>>> Please feel free to comment if you have any questions and suggestions.
>>>
>>>
>>> [1] https://github.com/apache/beam/pull/28075
>>> [2] https://issues.apache.org/jira/browse/INFRA-24950
>>>
>>> Regards,
>>> Yi
>>> --
>>>
>>> Yi Hu, (he/him/his)
>>>
>>> Software Engineer
>>>
>>>
>>>


Re: [Proposal] Enable EnricoMi/publish-unit-test-result-action

2023-09-05 Thread Bruno Volpato via dev
+1, this is helpful.

We had a similar situation with DataflowTemplates
.
Even though we used a different repository (mikepenz/action-junit-report
), this strategy was
invaluable to reduce troubleshoot time (sample report

).

Thanks Yi!



On Tue, Sep 5, 2023 at 11:26 AM Danny McCormick via dev 
wrote:

> Thanks Yi, I'm definitely +1 on adding this, this is definitely a gap in
> our GitHub Actions infra today.
>
> Thanks,
> Danny
>
> On Tue, Sep 5, 2023 at 10:35 AM Yi Hu via dev  wrote:
>
>> Hi everyone,
>>
>> As you may have noticed, GitHub Action for test suites are setting up in
>> the Beam repository. A current gap is that Jenkins has a pretty convenient
>> test result page showing all tests / failed tests and stack trace, while
>> these are not available in github workflow logs.
>>
>> Here we propose to introduce EnricoMi/publish-unit-test-result-action (
>> https://github.com/EnricoMi/publish-unit-test-result-action) to publish
>> Java (and possibly Python in the future) test results. An example PR can be
>> found [1] and an INFRA ticket in [2]. Currently both Java and Python test
>> reports are supported by this action (note that Jenkins test report page is
>> also available only for Java and Python currently).
>>
>> Please feel free to comment if you have any questions and suggestions.
>>
>>
>> [1] https://github.com/apache/beam/pull/28075
>> [2] https://issues.apache.org/jira/browse/INFRA-24950
>>
>> Regards,
>> Yi
>> --
>>
>> Yi Hu, (he/him/his)
>>
>> Software Engineer
>>
>>
>>


Re: [Proposal] Enable EnricoMi/publish-unit-test-result-action

2023-09-05 Thread Danny McCormick via dev
Thanks Yi, I'm definitely +1 on adding this, this is definitely a gap in
our GitHub Actions infra today.

Thanks,
Danny

On Tue, Sep 5, 2023 at 10:35 AM Yi Hu via dev  wrote:

> Hi everyone,
>
> As you may have noticed, GitHub Action for test suites are setting up in
> the Beam repository. A current gap is that Jenkins has a pretty convenient
> test result page showing all tests / failed tests and stack trace, while
> these are not available in github workflow logs.
>
> Here we propose to introduce EnricoMi/publish-unit-test-result-action (
> https://github.com/EnricoMi/publish-unit-test-result-action) to publish
> Java (and possibly Python in the future) test results. An example PR can be
> found [1] and an INFRA ticket in [2]. Currently both Java and Python test
> reports are supported by this action (note that Jenkins test report page is
> also available only for Java and Python currently).
>
> Please feel free to comment if you have any questions and suggestions.
>
>
> [1] https://github.com/apache/beam/pull/28075
> [2] https://issues.apache.org/jira/browse/INFRA-24950
>
> Regards,
> Yi
> --
>
> Yi Hu, (he/him/his)
>
> Software Engineer
>
>
>


[Proposal] Enable EnricoMi/publish-unit-test-result-action

2023-09-05 Thread Yi Hu via dev
Hi everyone,

As you may have noticed, GitHub Action for test suites are setting up in
the Beam repository. A current gap is that Jenkins has a pretty convenient
test result page showing all tests / failed tests and stack trace, while
these are not available in github workflow logs.

Here we propose to introduce EnricoMi/publish-unit-test-result-action (
https://github.com/EnricoMi/publish-unit-test-result-action) to publish
Java (and possibly Python in the future) test results. An example PR can be
found [1] and an INFRA ticket in [2]. Currently both Java and Python test
reports are supported by this action (note that Jenkins test report page is
also available only for Java and Python currently).

Please feel free to comment if you have any questions and suggestions.


[1] https://github.com/apache/beam/pull/28075
[2] https://issues.apache.org/jira/browse/INFRA-24950

Regards,
Yi
-- 

Yi Hu, (he/him/his)

Software Engineer