Re: Precommits fire for wrong PRs

[Kenneth Knowles]

One reason it would trigger is that it modified
buildSrc/.../BeamModulePlugin.groovy

Edits there are rare. But if it is a problem, each of the "applyXYZNature"
methods could and probably should be moved to a separate plugin, maybe with
a little work.

Kenn

On Thu, Dec 5, 2019 at 2:38 AM Michał Walenia 
wrote:

> Hi all,
> I noticed that sometimes the precommit jobs are launched for unrelated
> PRs, eg. Python or website precommit runs for some Java and gradle changes.
> AFAIK, the 'responsibility regions' for the jobs are defined in Job DSL
> scripts and are regexes that file changed paths are checked against.
> for Python PreCommit the paths are:
>   '^model/.*$',
>   '^sdks/python/.*$',
>   '^release/.*$',
>   '^build.gradle$',
>   '^buildSrc/.*$',
>   '^gradle/.*$',
>   '^gradle.properties$',
>   '^gradlew$',
>   '^gradle.bat$',
>   '^settings.gradle$'
>
> and for Website:
>   '^website/.*$'
>   '^build.gradle$',
>   '^buildSrc/.*$',
>   '^gradle/.*$',
>   '^gradle.properties$',
>   '^gradlew$',
>   '^gradle.bat$',
>   '^settings.gradle$'
>
> What I don't understand is why they both triggered for Łukasz's PR
> , which touches some Java
> files, Jenkins scripts and two non top-level gradle files.
> Can anyone shed some light on this? I'd like to understand it thoroughly -
> by fixing misfires of precommits it would be possible to alleviate the
> strain on our Jenkins workers.
> Thanks!
> Michal
> --
>
> Michał Walenia
> Polidea  | Software Engineer
>
> M: +48 791 432 002 <+48791432002>
> E: michal.wale...@polidea.com
>
> Unique Tech
> Check out our projects! 
>

Precommits fire for wrong PRs

[Michał Walenia]

Hi all,
I noticed that sometimes the precommit jobs are launched for unrelated PRs,
eg. Python or website precommit runs for some Java and gradle changes.
AFAIK, the 'responsibility regions' for the jobs are defined in Job DSL
scripts and are regexes that file changed paths are checked against.
for Python PreCommit the paths are:
  '^model/.*$',
  '^sdks/python/.*$',
  '^release/.*$',
  '^build.gradle$',
  '^buildSrc/.*$',
  '^gradle/.*$',
  '^gradle.properties$',
  '^gradlew$',
  '^gradle.bat$',
  '^settings.gradle$'

and for Website:
  '^website/.*$'
  '^build.gradle$',
  '^buildSrc/.*$',
  '^gradle/.*$',
  '^gradle.properties$',
  '^gradlew$',
  '^gradle.bat$',
  '^settings.gradle$'

What I don't understand is why they both triggered for Łukasz's PR
, which touches some Java files,
Jenkins scripts and two non top-level gradle files.
Can anyone shed some light on this? I'd like to understand it thoroughly -
by fixing misfires of precommits it would be possible to alleviate the
strain on our Jenkins workers.
Thanks!
Michal
-- 

Michał Walenia
Polidea  | Software Engineer

M: +48 791 432 002 <+48791432002>
E: michal.wale...@polidea.com

Unique Tech
Check out our projects!