Re: Testing code in extensions against runner
So if I understood correctly; Emulate the SQL precommit / postcommit extension and incorporate running the test against different runners. Would be snazzy indeed! A bit beyond my skill set I fear :-) On Wed, 19 Jun 2019 at 10:34, Kenneth Knowles wrote: > Slight point here: @ValidatesRunner should only be for tests that the > runner implements the core model. > > Also, outside of the SDK core, you don't need it. If you use TestPipeline > it already picks up the config for what runner. So all you need is to use > TestPipeline and add it to some suite of tests that is run. Perhaps the > Java precommit/postcommit or a postcommit dedicated to that extension (SQL > has one). > > There's also a pretty big difference in terms of *who* is initiating the > test / *what* is under test. Your tests are probably best viewed as tests > of the extension, not tests of the runner. So that is another reason they > should not be @ValidatesRunner. > > It would be snazzy if it were a one-liner to add all this testing in the > gradle config for extensions. > > Kenn > > On Tue, Jun 18, 2019 at 12:05 AM Reza Rokni wrote: > >> Thanx! >> >> It would definitely be great to have the ability for folks adding utility >> / extensions to be able to have them run against all runners. >> >> Cheers >> Reza >> >> On Fri, 7 Jun 2019, 19:05 Lukasz Cwik, wrote: >> >>> We have been currently been having every runner define and manage its >>> own suite/tests so yes modifying flink_runner.gradle is currently the >>> correct thing to do. >>> >>> There is a larger discussion about whether this is the right way since >>> we would like to capture things like perf benchmarks and validates runner >>> tests so we can add information to the website about how well a feature is >>> supported by each runner automatically. >>> >>> >>> >>> On Thu, Jun 6, 2019 at 8:36 PM Reza Rokni wrote: >>> Hi, I would like to validate some code that I am building under extensions against different runners. It makes use of some caches in a DoFn which are a little off the beaten path. I have added @ValidatesRunner to the class and by adding the right values to the gradle file in flink_runner have got the tests to run. However it does not feel right for me to change the flink_runner.gradle file to achieve this, especially as this is all experimental and under extensions. I could copy over all the bits needed from the gradle file over to my extensions gradle, but then I would need to do that for all runners , which also feels a bit heavy weight. Is there a way, or should there be a way of having a task added to my gradle file which will do tests against all runners for me? Cheers Reza -- This email may be confidential and privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. The above terms reflect a potential business arrangement, are provided solely as a basis for further discussion, and are not intended to be and do not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is executed in writing by all parties involved. >>> -- This email may be confidential and privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. The above terms reflect a potential business arrangement, are provided solely as a basis for further discussion, and are not intended to be and do not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is executed in writing by all parties involved.
Re: Testing code in extensions against runner
Thanx! It would definitely be great to have the ability for folks adding utility / extensions to be able to have them run against all runners. Cheers Reza On Fri, 7 Jun 2019, 19:05 Lukasz Cwik, wrote: > We have been currently been having every runner define and manage its own > suite/tests so yes modifying flink_runner.gradle is currently the correct > thing to do. > > There is a larger discussion about whether this is the right way since we > would like to capture things like perf benchmarks and validates runner > tests so we can add information to the website about how well a feature is > supported by each runner automatically. > > > > On Thu, Jun 6, 2019 at 8:36 PM Reza Rokni wrote: > >> Hi, >> >> I would like to validate some code that I am building under >> extensions against different runners. It makes use of some caches in a DoFn >> which are a little off the beaten path. >> >> I have added @ValidatesRunner to the class and by adding the right >> values to the gradle file in flink_runner have got the tests to run. >> However it does not feel right for me to change the flink_runner.gradle >> file to achieve this, especially as this is all experimental and under >> extensions. >> >> I could copy over all the bits needed from the gradle file over to my >> extensions gradle, but then I would need to do that for all runners , which >> also feels a bit heavy weight. Is there a way, or should there be a way of >> having a task added to my gradle file which will do tests against all >> runners for me? >> >> Cheers >> Reza >> >> -- >> >> This email may be confidential and privileged. If you received this >> communication by mistake, please don't forward it to anyone else, please >> erase all copies and attachments, and please let me know that it has gone >> to the wrong person. >> >> The above terms reflect a potential business arrangement, are provided >> solely as a basis for further discussion, and are not intended to be and do >> not constitute a legally binding obligation. No legally binding obligations >> will be created, implied, or inferred until an agreement in final form is >> executed in writing by all parties involved. >> >
Re: Testing code in extensions against runner
We have been currently been having every runner define and manage its own suite/tests so yes modifying flink_runner.gradle is currently the correct thing to do. There is a larger discussion about whether this is the right way since we would like to capture things like perf benchmarks and validates runner tests so we can add information to the website about how well a feature is supported by each runner automatically. On Thu, Jun 6, 2019 at 8:36 PM Reza Rokni wrote: > Hi, > > I would like to validate some code that I am building under > extensions against different runners. It makes use of some caches in a DoFn > which are a little off the beaten path. > > I have added @ValidatesRunner to the class and by adding the right values > to the gradle file in flink_runner have got the tests to run. However it > does not feel right for me to change the flink_runner.gradle file to > achieve this, especially as this is all experimental and under extensions. > > I could copy over all the bits needed from the gradle file over to my > extensions gradle, but then I would need to do that for all runners , which > also feels a bit heavy weight. Is there a way, or should there be a way of > having a task added to my gradle file which will do tests against all > runners for me? > > Cheers > Reza > > -- > > This email may be confidential and privileged. If you received this > communication by mistake, please don't forward it to anyone else, please > erase all copies and attachments, and please let me know that it has gone > to the wrong person. > > The above terms reflect a potential business arrangement, are provided > solely as a basis for further discussion, and are not intended to be and do > not constitute a legally binding obligation. No legally binding obligations > will be created, implied, or inferred until an agreement in final form is > executed in writing by all parties involved. >
Testing code in extensions against runner
Hi, I would like to validate some code that I am building under extensions against different runners. It makes use of some caches in a DoFn which are a little off the beaten path. I have added @ValidatesRunner to the class and by adding the right values to the gradle file in flink_runner have got the tests to run. However it does not feel right for me to change the flink_runner.gradle file to achieve this, especially as this is all experimental and under extensions. I could copy over all the bits needed from the gradle file over to my extensions gradle, but then I would need to do that for all runners , which also feels a bit heavy weight. Is there a way, or should there be a way of having a task added to my gradle file which will do tests against all runners for me? Cheers Reza -- This email may be confidential and privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. The above terms reflect a potential business arrangement, are provided solely as a basis for further discussion, and are not intended to be and do not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is executed in writing by all parties involved.
