DCOS/OS Package users
Hi BookKeepers ! During the release process we are submitting packages to Mesosphere Universe for running BookKeeper in DCOS environment, like this PR: https://github.com/mesosphere/universe/pull/1998 Is there any active user of that package ? If there is no interest we can stop delivering such artifacts. We will still continue to provide the docker image https://hub.docker.com/r/apache/bookkeeper/ Best regards Enrico
Errors while buding docker image for 4.8.1
Hi, On Docker hub there is some problem in building 4.8.1 tag build on "latest" (which is 4.8.1 succedeed) https://hub.docker.com/r/apache/bookkeeper/builds/bd6ndfczwnwtz2bdg7rgslm/ but for tag 4.8.1 failed https://hub.docker.com/r/apache/bookkeeper/builds/bkjqqqz38rsijpelqvwjbva/ They should be building mostly the same Dockerfile Is there any way to force a rebuild ? Who has administrative privileges on that account ? Enrico
Re: [VOTE] Release 4.7.3, release candidate #0
+1 (binding) from me as well. On Fri, Nov 30, 2018 at 2:52 AM Sijie Guo wrote: > Hi everyone, > > Please review and vote on the release candidate #0 for the version 4.7.3, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > * Release notes [1] > * The official Apache source and binary distributions to be deployed to > dist.apache.org [2] > * All artifacts to be deployed to the Maven Central Repository [3] > * Source code tag "v4.7.3-rc0" [4] with git sha > 7a25ac301910271e80986e287db4595ae5f7785e > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > Please download these packages and review this release candidate: > > - Review release notes > - Download the source package (verify shasum, and asc) and follow the > instructions to build and run the bookkeeper service. > - Download the binary package (verify shasum, and asc) and follow the > instructions to run the bookkeeper service. > - Review maven repo, release tag, licenses, and any other things you think > it is important to a release. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Sijie > > [1] https://github.com/apache/bookkeeper/pull/1850 > [2] > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.3-rc0/ > [3] > https://repository.apache.org/content/repositories/orgapachebookkeeper-1036/ > [4] https://github.com/apache/bookkeeper/tree/v4.7.3-rc0 >
Re: [VOTE] Release 4.7.3, release candidate #0
+1 (binding) * LICENSE & NOTICE look good. * Rat good * spotbugs good * checkstyle had some issues, finding configs, but I'm not worried about it * sha512 and gpg good * tests ran cleanly * ran pulsar master integration tests against it. all passed Good work Sijie! -Ivan On Mon, Dec 3, 2018 at 8:19 PM Matteo Merli wrote: > > +1 > > * Check binary, checksums, and ran a localbookie > * Source, checked rat and compiled with tests > > -- > Matteo Merli > > > > On Fri, Nov 30, 2018 at 2:53 AM Sijie Guo wrote: > > > Hi everyone, > > > > Please review and vote on the release candidate #0 for the version 4.7.3, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed to > > dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "v4.7.3-rc0" [4] with git sha > > 7a25ac301910271e80986e287db4595ae5f7785e > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > > > - Review release notes > > - Download the source package (verify shasum, and asc) and follow the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify shasum, and asc) and follow the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you think > > it is important to a release. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Sijie > > > > [1] https://github.com/apache/bookkeeper/pull/1850 > > [2] > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.3-rc0/ > > [3] > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1036/ > > [4] https://github.com/apache/bookkeeper/tree/v4.7.3-rc0 > >
Re: Bug with blockAddCompletions decrement
> > Not an issue with master as blockAddCompletions has been replaced with > > a simple boolean and failure handling changed to only deal with one > > failure at a time. However, looking at it again, I think I did spot a > > similar bug. will dig in after I send this. > > Great; looking forward. It was something that sam had raised in the original patch. Fix is up. https://github.com/apache/bookkeeper/pull/1857 > updateMetadataIfPossible() is called from resolveConflict() -> "return > updateMetadataIfPossible(newMeta);" > There is only one case in the updateMetadataIfPossible(newMeta); that will > rereadMetadata in other cases > it can just return TRUE so there is no ChangeEnsembleCb. When updateMetadataIfPossible is called, the precondition is that there is at least one 'bump' that needs to be decremented on blockAddCompletions before adds can be completed. There's 3 branches in the code. 1. existing metadata is newer. reread is called, which will eventually call updateMetadataIfPossible again under the same conditions 2. isConflictWith is true, so kill the ledger, we don't want to decrement because we are in an undefined condition 3. we write new metadata, in which case ChangeEnsembleCb does the decrement. This code is awful. It gives me nightmares. But AFAICS it is correct w.r.t. to the preconditions stated above. [1] https://github.com/apache/bookkeeper/blob/621799172a0de84f97b87d795c31e263de80e8a3/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java#L2197 -Ivan
