[jira] [Commented] (BOOKKEEPER-826) PendingAddOp is ignoring ack response after meet ack quorum constraint
[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944811#comment-14944811
]
Hudson commented on BOOKKEEPER-826:
---
FAILURE: Integrated in bookkeeper-master #1163 (See
[https://builds.apache.org/job/bookkeeper-master/1163/])
BOOKKEEPER-826: PendingAddOp is ignoring ack response after meet ack (sijie:
rev 885cebf113ea104dc579f93d6e112825a3bf1959)
* bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
* CHANGES.txt
> PendingAddOp is ignoring ack response after meet ack quorum constraint
> ---
>
> Key: BOOKKEEPER-826
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client
>Reporter: Charles X
>Assignee: Sijie Guo
> Attachments: BOOKKEEPER-826.diff, BOOKKEEPER-826.patch
>
>
> PendingAddOp is set to completed when it meets ack quorum.
> {code}
> if (ackSet.addBookieAndCheck(bookieIndex) && !completed) {
> completed = true;
> LOG.debug("Complete (lid:{}, eid:{}).", ledgerId, entryId);
> // when completed an entry, try to send success add callbacks in
> order
> lh.sendAddSuccessCallbacks();
> }
> {code}
> responses are ignored after completed flag is set.
> {code}
>if (completed) {
> // I am already finished, ignore incoming responses.
> // otherwise, we might hit the following error handling logic,
> which might cause bad things.
> return;
> }
> {code}
> It is not a correctness problem, but it would introduce performance issue
> during ensemble change. A callback (could be acknowledge before ensemble
> change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-826) PendingAddOp is ignoring ack response after meet ack quorum constraint
[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907760#comment-14907760
]
Jia Zhai commented on BOOKKEEPER-826:
-
Hi [~hustlmsp], thanks a lot for this. The fix looks good, that is indeed a
more suitable place to call sendSuccessfulCallback.
> PendingAddOp is ignoring ack response after meet ack quorum constraint
> ---
>
> Key: BOOKKEEPER-826
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client
>Reporter: Charles X
>Assignee: Jia Zhai
> Attachments: BOOKKEEPER-826.diff, BOOKKEEPER-826.patch
>
>
> PendingAddOp is set to completed when it meets ack quorum.
> {code}
> if (ackSet.addBookieAndCheck(bookieIndex) && !completed) {
> completed = true;
> LOG.debug("Complete (lid:{}, eid:{}).", ledgerId, entryId);
> // when completed an entry, try to send success add callbacks in
> order
> lh.sendAddSuccessCallbacks();
> }
> {code}
> responses are ignored after completed flag is set.
> {code}
>if (completed) {
> // I am already finished, ignore incoming responses.
> // otherwise, we might hit the following error handling logic,
> which might cause bad things.
> return;
> }
> {code}
> It is not a correctness problem, but it would introduce performance issue
> during ensemble change. A callback (could be acknowledge before ensemble
> change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-826) PendingAddOp is ignoring ack response after meet ack quorum constraint
[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745127#comment-14745127
]
Sijie Guo commented on BOOKKEEPER-826:
--
[~zhaijia] could you review that?
> PendingAddOp is ignoring ack response after meet ack quorum constraint
> ---
>
> Key: BOOKKEEPER-826
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client
>Reporter: Charles X
>Assignee: Jia Zhai
> Attachments: BOOKKEEPER-826.diff, BOOKKEEPER-826.patch
>
>
> PendingAddOp is set to completed when it meets ack quorum.
> {code}
> if (ackSet.addBookieAndCheck(bookieIndex) && !completed) {
> completed = true;
> LOG.debug("Complete (lid:{}, eid:{}).", ledgerId, entryId);
> // when completed an entry, try to send success add callbacks in
> order
> lh.sendAddSuccessCallbacks();
> }
> {code}
> responses are ignored after completed flag is set.
> {code}
>if (completed) {
> // I am already finished, ignore incoming responses.
> // otherwise, we might hit the following error handling logic,
> which might cause bad things.
> return;
> }
> {code}
> It is not a correctness problem, but it would introduce performance issue
> during ensemble change. A callback (could be acknowledge before ensemble
> change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-826) PendingAddOp is ignoring ack response after meet ack quorum constraint
[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745374#comment-14745374
]
Hadoop QA commented on BOOKKEEPER-826:
--
Testing JIRA BOOKKEEPER-826
Patch
[BOOKKEEPER-826.diff|https://issues.apache.org/jira/secure/attachment/12754530/BOOKKEEPER-826.diff]
downloaded at Tue Sep 15 12:05:57 UTC 2015
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
.Tests run: 948
.Tests failed: 1
.Tests errors: 3
.The patch failed the following testcases:
. testSimpleChat(org.apache.hedwig.jms.BasicJMSTest)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/958/
> PendingAddOp is ignoring ack response after meet ack quorum constraint
> ---
>
> Key: BOOKKEEPER-826
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client
>Reporter: Charles X
>Assignee: Jia Zhai
> Attachments: BOOKKEEPER-826.diff, BOOKKEEPER-826.patch
>
>
> PendingAddOp is set to completed when it meets ack quorum.
> {code}
> if (ackSet.addBookieAndCheck(bookieIndex) && !completed) {
> completed = true;
> LOG.debug("Complete (lid:{}, eid:{}).", ledgerId, entryId);
> // when completed an entry, try to send success add callbacks in
> order
> lh.sendAddSuccessCallbacks();
> }
> {code}
> responses are ignored after completed flag is set.
> {code}
>if (completed) {
> // I am already finished, ignore incoming responses.
> // otherwise, we might hit the following error handling logic,
> which might cause bad things.
> return;
> }
> {code}
> It is not a correctness problem, but it would introduce performance issue
> during ensemble change. A callback (could be acknowledge before ensemble
> change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-826) PendingAddOp is ignoring ack response after meet ack quorum constraint
[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744670#comment-14744670
]
Jia Zhai commented on BOOKKEEPER-826:
-
Thanks, that is indeed a more suitable place to call sendSuccessfulCallback
> PendingAddOp is ignoring ack response after meet ack quorum constraint
> ---
>
> Key: BOOKKEEPER-826
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client
>Reporter: Charles X
>Assignee: Jia Zhai
> Attachments: BOOKKEEPER-826.diff, BOOKKEEPER-826.patch
>
>
> PendingAddOp is set to completed when it meets ack quorum.
> {code}
> if (ackSet.addBookieAndCheck(bookieIndex) && !completed) {
> completed = true;
> LOG.debug("Complete (lid:{}, eid:{}).", ledgerId, entryId);
> // when completed an entry, try to send success add callbacks in
> order
> lh.sendAddSuccessCallbacks();
> }
> {code}
> responses are ignored after completed flag is set.
> {code}
>if (completed) {
> // I am already finished, ignore incoming responses.
> // otherwise, we might hit the following error handling logic,
> which might cause bad things.
> return;
> }
> {code}
> It is not a correctness problem, but it would introduce performance issue
> during ensemble change. A callback (could be acknowledge before ensemble
> change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-826) PendingAddOp is ignoring ack response after meet ack quorum constraint
[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744671#comment-14744671
]
Jia Zhai commented on BOOKKEEPER-826:
-
Thanks, that is indeed a more suitable place to call sendSuccessfulCallback
> PendingAddOp is ignoring ack response after meet ack quorum constraint
> ---
>
> Key: BOOKKEEPER-826
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client
>Reporter: Charles X
>Assignee: Jia Zhai
> Attachments: BOOKKEEPER-826.diff, BOOKKEEPER-826.patch
>
>
> PendingAddOp is set to completed when it meets ack quorum.
> {code}
> if (ackSet.addBookieAndCheck(bookieIndex) && !completed) {
> completed = true;
> LOG.debug("Complete (lid:{}, eid:{}).", ledgerId, entryId);
> // when completed an entry, try to send success add callbacks in
> order
> lh.sendAddSuccessCallbacks();
> }
> {code}
> responses are ignored after completed flag is set.
> {code}
>if (completed) {
> // I am already finished, ignore incoming responses.
> // otherwise, we might hit the following error handling logic,
> which might cause bad things.
> return;
> }
> {code}
> It is not a correctness problem, but it would introduce performance issue
> during ensemble change. A callback (could be acknowledge before ensemble
> change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-826) PendingAddOp is ignoring ack response after meet ack quorum constraint
[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733955#comment-14733955
]
Sijie Guo commented on BOOKKEEPER-826:
--
[~zhaijia] thank you for your patch. but the change here isn't safe. since
after ensemble change, it would unset successful results which would break the
ack quorum constraint. sendSuccessfulCallback just after ensemble change isn't
safe. I would propose a different patch.
> PendingAddOp is ignoring ack response after meet ack quorum constraint
> ---
>
> Key: BOOKKEEPER-826
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client
>Reporter: Charles X
>Assignee: Jia Zhai
> Attachments: BOOKKEEPER-826.patch
>
>
> PendingAddOp is set to completed when it meets ack quorum.
> {code}
> if (ackSet.addBookieAndCheck(bookieIndex) && !completed) {
> completed = true;
> LOG.debug("Complete (lid:{}, eid:{}).", ledgerId, entryId);
> // when completed an entry, try to send success add callbacks in
> order
> lh.sendAddSuccessCallbacks();
> }
> {code}
> responses are ignored after completed flag is set.
> {code}
>if (completed) {
> // I am already finished, ignore incoming responses.
> // otherwise, we might hit the following error handling logic,
> which might cause bad things.
> return;
> }
> {code}
> It is not a correctness problem, but it would introduce performance issue
> during ensemble change. A callback (could be acknowledge before ensemble
> change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-826) PendingAddOp is ignoring ack response after meet ack quorum constraint
[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698652#comment-14698652
]
Jia Zhai commented on BOOKKEEPER-826:
-
Seems we need try to submit all completed pendingAddOps when ensemble change
happens.
PendingAddOp is ignoring ack response after meet ack quorum constraint
---
Key: BOOKKEEPER-826
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
Project: Bookkeeper
Issue Type: Improvement
Components: bookkeeper-client
Reporter: Charles X
Assignee: Jia Zhai
PendingAddOp is set to completed when it meets ack quorum.
{code}
if (ackSet.addBookieAndCheck(bookieIndex) !completed) {
completed = true;
LOG.debug(Complete (lid:{}, eid:{})., ledgerId, entryId);
// when completed an entry, try to send success add callbacks in
order
lh.sendAddSuccessCallbacks();
}
{code}
responses are ignored after completed flag is set.
{code}
if (completed) {
// I am already finished, ignore incoming responses.
// otherwise, we might hit the following error handling logic,
which might cause bad things.
return;
}
{code}
It is not a correctness problem, but it would introduce performance issue
during ensemble change. A callback (could be acknowledge before ensemble
change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-826) PendingAddOp is ignoring ack response after meet ack quorum constraint
[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698640#comment-14698640
]
Jia Zhai commented on BOOKKEEPER-826:
-
I would like to contribute to this ticket.
PendingAddOp is ignoring ack response after meet ack quorum constraint
---
Key: BOOKKEEPER-826
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
Project: Bookkeeper
Issue Type: Improvement
Components: bookkeeper-client
Reporter: Charles X
Assignee: Jia Zhai
PendingAddOp is set to completed when it meets ack quorum.
{code}
if (ackSet.addBookieAndCheck(bookieIndex) !completed) {
completed = true;
LOG.debug(Complete (lid:{}, eid:{})., ledgerId, entryId);
// when completed an entry, try to send success add callbacks in
order
lh.sendAddSuccessCallbacks();
}
{code}
responses are ignored after completed flag is set.
{code}
if (completed) {
// I am already finished, ignore incoming responses.
// otherwise, we might hit the following error handling logic,
which might cause bad things.
return;
}
{code}
It is not a correctness problem, but it would introduce performance issue
during ensemble change. A callback (could be acknowledge before ensemble
change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-826) PendingAddOp is ignoring ack response after meet ack quorum constraint
[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698942#comment-14698942
]
Hadoop QA commented on BOOKKEEPER-826:
--
Testing JIRA BOOKKEEPER-826
Patch
[BOOKKEEPER-826.patch|https://issues.apache.org/jira/secure/attachment/12750734/BOOKKEEPER-826.patch]
downloaded at Mon Aug 17 01:59:50 UTC 2015
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
.Tests run: 947
.Tests failed: 0
.Tests errors: 1
.The patch failed the following testcases:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/955/
PendingAddOp is ignoring ack response after meet ack quorum constraint
---
Key: BOOKKEEPER-826
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
Project: Bookkeeper
Issue Type: Improvement
Components: bookkeeper-client
Reporter: Charles X
Assignee: Jia Zhai
Attachments: BOOKKEEPER-826.patch
PendingAddOp is set to completed when it meets ack quorum.
{code}
if (ackSet.addBookieAndCheck(bookieIndex) !completed) {
completed = true;
LOG.debug(Complete (lid:{}, eid:{})., ledgerId, entryId);
// when completed an entry, try to send success add callbacks in
order
lh.sendAddSuccessCallbacks();
}
{code}
responses are ignored after completed flag is set.
{code}
if (completed) {
// I am already finished, ignore incoming responses.
// otherwise, we might hit the following error handling logic,
which might cause bad things.
return;
}
{code}
It is not a correctness problem, but it would introduce performance issue
during ensemble change. A callback (could be acknowledge before ensemble
change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
