[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-22 Thread Sijie Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968656#comment-14968656
 ] 

Sijie Guo commented on BOOKKEEPER-867:
--

the failed tests aren't related to this patch. the patch looks good to me +1. 

> New Client API to allow applications pass-in EntryId.
> -
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client
>Affects Versions: 4.3.1
>Reporter: Venkateswararao Jujjuri
>Assignee: Venkateswararao Jujjuri
>  Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments: 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> BOOKKEEPER-867.patch, 
> git-format-patch-norefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch,
>  noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-20 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964804#comment-14964804
 ] 

Hadoop QA commented on BOOKKEEPER-867:
--

Testing JIRA BOOKKEEPER-867


Patch 
[git-format-patch-norefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch|https://issues.apache.org/jira/secure/attachment/12767390/git-format-patch-norefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch]
 downloaded at Tue Oct 20 00:16:42 PDT 2015



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 23 line(s) with trailing spaces
.   L38: 
L53: 
L69: 
L176: 
L181: 
L196: 
L213: 
L217: 
L225: 
L230: 
L254: 
L282: 
L309: 
L348: 
L363: 
L401: 
L405: 
L633: 
L640: 
L644: 
L665: 
L715: 
L1042:-- 
.{color:red}-1{color} the patch contains 9 line(s) longer than 120 
characters
.   L20:diff --git 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java
L63:diff --git 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
L167:diff --git 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java
 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java
L207:diff --git 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
L407:diff --git 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
L577:+void doAsyncAddEntry(final PendingAddOp op, final byte[] 
data, final int offset, final int length, final AddCallback cb, final Object 
ctx) {
L626:diff --git 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
L659:diff --git 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLedgerTest.java
 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLedgerTest.java
L811:+ArrayList ensemble = 
lh.getLedgerMetadata().getEnsembles().entrySet().iterator().next()
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs 
warnings
{color:red}-1 TESTS{color}
.Tests run: 624
.Tests failed: 0
.Tests errors: 1

.The patch failed the following testcases:

.  

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.

> New Client API to allow applications pass-in EntryId.
> -
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client
>Affects Versions: 4.3.1
>Reporter: Venkateswararao Jujjuri
>Assignee: Venkateswararao Jujjuri
>  Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments: 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> BOOKKEEPER-867.patch, 
>

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-20 Thread Sijie Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965224#comment-14965224
 ] 

Sijie Guo commented on BOOKKEEPER-867:
--

I ran the test-patch locally. it seems to pass the findbugs checking. but 
failed with two long lines (doAsyncAddEntry in LedgerHandleAdv and 
getLedgerMetadata in BookieWriteLedgerTest)

- I will check why pre-commit job doesn't catch long lines but fail with 
findbugs
- [~jujjuri] could you fix the long lines? you could run "bin/test-patch 
--patch=${patch_file_path} --dirty-scm" in you clean master repo. it would give 
you a detail report under test-patch directory.

> New Client API to allow applications pass-in EntryId.
> -
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client
>Affects Versions: 4.3.1
>Reporter: Venkateswararao Jujjuri
>Assignee: Venkateswararao Jujjuri
>  Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments: 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> BOOKKEEPER-867.patch, 
> git-format-patch-norefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch,
>  noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-17 Thread Venkateswararao Jujjuri (JIRA) 

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962079#comment-14962079
 ] 

Venkateswararao Jujjuri commented on BOOKKEEPER-867:


Adding two more patches one is the output of
git format-patch HEAD^

and other one is

git format-patch HEAD^^ --no-prefix

Please advise me if you have any specific way of taking the patch
I applied it back using 

git apply 
git add 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
git commit -a


> New Client API to allow applications pass-in EntryId.
> -
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client
>Affects Versions: 4.3.1
>Reporter: Venkateswararao Jujjuri
>Assignee: Venkateswararao Jujjuri
>  Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments: 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> BOOKKEEPER-867.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-17 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962087#comment-14962087
 ] 

Hadoop QA commented on BOOKKEEPER-867:
--

Testing JIRA BOOKKEEPER-867


Patch 
[noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch|https://issues.apache.org/jira/secure/attachment/12767228/noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch]
 downloaded at Sat Oct 17 20:39:02 UTC 2015



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
120
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1 FINDBUGS{color}
.{color:red}-1{color} the patch seems to introduce 1 new Findbugs 
warning(s) in module(s) [bookkeeper-server]
{color:red}-1 TESTS{color}
.Tests run: 924
.Tests failed: 2
.Tests errors: 5

.The patch failed the following testcases:

.  
testDuplicateEnDisableAutoRecovery[2](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)
.  
testReadOnlyBookieExclusionFromURLedgersCheck[2](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/965/

> New Client API to allow applications pass-in EntryId.
> -
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client
>Affects Versions: 4.3.1
>Reporter: Venkateswararao Jujjuri
>Assignee: Venkateswararao Jujjuri
>  Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments: 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> BOOKKEEPER-867.patch, 
> noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-16 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961619#comment-14961619
 ] 

Hadoop QA commented on BOOKKEEPER-867:
--

Testing JIRA BOOKKEEPER-867


Patch 
[0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch|https://issues.apache.org/jira/secure/attachment/12767164/0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch]
 downloaded at Sat Oct 17 01:06:41 UTC 2015



{color:red}-1{color} Patch failed to apply to head of branch



> New Client API to allow applications pass-in EntryId.
> -
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client
>Affects Versions: 4.3.1
>Reporter: Venkateswararao Jujjuri
>Assignee: Venkateswararao Jujjuri
>  Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments: 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> BOOKKEEPER-867.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-15 Thread Sijie Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960128#comment-14960128
 ] 

Sijie Guo commented on BOOKKEEPER-867:
--

[~jujjuri] could you generate the patch with '--no-prefix' next time? we need 
the patch pass bookkeeper pre-commit build. check more details on 
http://bookkeeper.apache.org/svn.html



> New Client API to allow applications pass-in EntryId.
> -
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client
>Affects Versions: 4.3.1
>Reporter: Venkateswararao Jujjuri
>Assignee: Venkateswararao Jujjuri
>  Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments: 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> BOOKKEEPER-867.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-15 Thread Sijie Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960130#comment-14960130
 ] 

Sijie Guo commented on BOOKKEEPER-867:
--

the patch looks good to me. +1

> New Client API to allow applications pass-in EntryId.
> -
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client
>Affects Versions: 4.3.1
>Reporter: Venkateswararao Jujjuri
>Assignee: Venkateswararao Jujjuri
>  Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments: 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> BOOKKEEPER-867.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-15 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960157#comment-14960157
 ] 

Hadoop QA commented on BOOKKEEPER-867:
--

Testing JIRA BOOKKEEPER-867


Patch 
[BOOKKEEPER-867.patch|https://issues.apache.org/jira/secure/attachment/12766972/BOOKKEEPER-867.patch]
 downloaded at Fri Oct 16 03:59:27 UTC 2015



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
120
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:red}-1 JAVADOC{color}
.{color:red}-1{color} the patch seems to introduce 23 new Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1 FINDBUGS{color}
.{color:red}-1{color} the patch seems to introduce 2 new Findbugs 
warning(s) in module(s) [bookkeeper-server]
{color:red}-1 TESTS{color}
.Tests run: 921
.Tests failed: 0
.Tests errors: 1

.The patch failed the following testcases:

.  

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/963/

> New Client API to allow applications pass-in EntryId.
> -
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client
>Affects Versions: 4.3.1
>Reporter: Venkateswararao Jujjuri
>Assignee: Venkateswararao Jujjuri
>  Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments: 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> BOOKKEEPER-867.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-15 Thread Sijie Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960181#comment-14960181
 ] 

Sijie Guo commented on BOOKKEEPER-867:
--

[~jujjuri] there are 23 javadoc warnings and 2 findbugs warnings in the patch. 
it would be good for you to fix the patch. run 'mvn clean javadoc:aggregate' to 
figure out what are the javadoc warnings and 'mvn findbugs:findbugs' for 
findbug warnings.

> New Client API to allow applications pass-in EntryId.
> -
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
>  Issue Type: Sub-task
>  Components: bookkeeper-client
>Affects Versions: 4.3.1
>Reporter: Venkateswararao Jujjuri
>Assignee: Venkateswararao Jujjuri
>  Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments: 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, 
> BOOKKEEPER-867.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-09-07 Thread Venkateswara Rao Jujjuri 
Thanks Sijie.

On Mon, Sep 7, 2015 at 9:19 AM, Sijie Guo (JIRA)  wrote:

>
> [
> https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733882#comment-14733882
> ]
>
> Sijie Guo commented on BOOKKEEPER-867:
> --
>
> A couple comments:
>
> - It might not worth changing the ConcurrentLinkedQueue for LedgerHandle.
> it would impact all people that uses LedgerHandle. there isn't performance
> side effects using PriorityBlockingQueue. You could use
> PriorityBlockingQueue in WriteLedgerHandle.
> - I'd suggest not adding addEntry(long EntryId ..) methods to LedgerHandle.
>   * it might be worth to call WriteLedgerHandle as LedgerHandleAdv.
>   * introduce a new CreateAdvCallback, which only returns  LedgerHandleAdv.
>   * move most of LedgerHandle's code (except addEntry) to
> AbstractLedgerHandle, and let LedgerHandle extend AbstractLedgerHandle and
> provide addEntry methods (without entry id). and let LedgerHandleAdv extend
> AbstractLedgerHandle and provide addEntry method with entry id. so there
> won't be two set of addEntry apis in each ledger handle class.
> - addEntry with entry ids should have the logic to prevent adding
> duplicated entries.
> - tests should cover add entries but out-of-order entry ids (not just
> reverse order) and might be test cases cover gap.
>
> It would be good to attach this patch to review board :
> https://reviews.apache.org/dashboard/ It is a patch of new API, it would
> be easier to comment on review board.
>
> > New Client API to allow applications pass-in EntryId.
> > -
> >
> > Key: BOOKKEEPER-867
> > URL:
> https://issues.apache.org/jira/browse/BOOKKEEPER-867
> > Project: Bookkeeper
> >  Issue Type: Sub-task
> >  Components: bookkeeper-client
> >Reporter: Venkateswararao Jujjuri
> >Assignee: Venkateswararao Jujjuri
> >  Labels: features, newbie
> > Fix For: 4.4.0
> >
> > Attachments:
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch
> >
> >
>
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>



-- 
Jvrao
---
First they ignore you, then they laugh at you, then they fight you, then
you win. - Mahatma Gandhi

Re: [jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-09-07 Thread Venkateswara Rao Jujjuri 
Can you explain little more on "might be test cases cover gap."?

You mean ledger getting closed with gaps? or something else?

Regarding your suggestion of creating abstract class, you basically wanted
AdvLedgerHandle users to deal two handles,
for reading(trailing or general)  use LedgerHandle(ReadOnlyLedgerHandle)
and for writing, use AdvLedgerHandle.

Thanks,
JV

On Mon, Sep 7, 2015 at 11:15 AM, Venkateswara Rao Jujjuri  wrote:

> Thanks Sijie.
>
> On Mon, Sep 7, 2015 at 9:19 AM, Sijie Guo (JIRA)  wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733882#comment-14733882
>> ]
>>
>> Sijie Guo commented on BOOKKEEPER-867:
>> --
>>
>> A couple comments:
>>
>> - It might not worth changing the ConcurrentLinkedQueue for LedgerHandle.
>> it would impact all people that uses LedgerHandle. there isn't performance
>> side effects using PriorityBlockingQueue. You could use
>> PriorityBlockingQueue in WriteLedgerHandle.
>> - I'd suggest not adding addEntry(long EntryId ..) methods to
>> LedgerHandle.
>>   * it might be worth to call WriteLedgerHandle as LedgerHandleAdv.
>>   * introduce a new CreateAdvCallback, which only returns
>> LedgerHandleAdv.
>>   * move most of LedgerHandle's code (except addEntry) to
>> AbstractLedgerHandle, and let LedgerHandle extend AbstractLedgerHandle and
>> provide addEntry methods (without entry id). and let LedgerHandleAdv extend
>> AbstractLedgerHandle and provide addEntry method with entry id. so there
>> won't be two set of addEntry apis in each ledger handle class.
>> - addEntry with entry ids should have the logic to prevent adding
>> duplicated entries.
>> - tests should cover add entries but out-of-order entry ids (not just
>> reverse order) and might be test cases cover gap.
>>
>> It would be good to attach this patch to review board :
>> https://reviews.apache.org/dashboard/ It is a patch of new API, it would
>> be easier to comment on review board.
>>
>> > New Client API to allow applications pass-in EntryId.
>> > -
>> >
>> > Key: BOOKKEEPER-867
>> > URL:
>> https://issues.apache.org/jira/browse/BOOKKEEPER-867
>> > Project: Bookkeeper
>> >  Issue Type: Sub-task
>> >  Components: bookkeeper-client
>> >Reporter: Venkateswararao Jujjuri
>> >Assignee: Venkateswararao Jujjuri
>> >  Labels: features, newbie
>> > Fix For: 4.4.0
>> >
>> > Attachments:
>> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch
>> >
>> >
>>
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
>
>
> --
> Jvrao
> ---
> First they ignore you, then they laugh at you, then they fight you, then
> you win. - Mahatma Gandhi
>
>
>


-- 
Jvrao
---
First they ignore you, then they laugh at you, then they fight you, then
you win. - Mahatma Gandhi