[GitHub] brooklyn-library pull request #129: Move chef from brooklyn-software-base to...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-library/pull/129


---

[GitHub] brooklyn-library pull request #129: Move chef from brooklyn-software-base to...

[aledsage]

Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-library/pull/129#discussion_r139619615
  
--- Diff: software/cm/chef/src/main/resources/catalog.bom ---
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+brooklyn.catalog:
+version: "0.12.0-SNAPSHOT" # BROOKLYN_VERSION
+itemType: entity
+items:
+- id: org.apache.brooklyn.entity.chef.ChefEntity
+  item:
+type: org.apache.brooklyn.entity.chef.ChefEntity
+name: Chef Entity
+description: Software managed by Chef
--- End diff --

@tbouron was planning to add iconUrl as a separate step (it needs added to 
`src/main/resources`, so we can reference it offline). But I'll do that now in 
a second commit in this PR.


---

[GitHub] brooklyn-library pull request #129: Move chef from brooklyn-software-base to...

[tbouron]

Github user tbouron commented on a diff in the pull request:

https://github.com/apache/brooklyn-library/pull/129#discussion_r139284272
  
--- Diff: software/cm/chef/src/main/resources/catalog.bom ---
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+brooklyn.catalog:
+version: "0.12.0-SNAPSHOT" # BROOKLYN_VERSION
+itemType: entity
+items:
+- id: org.apache.brooklyn.entity.chef.ChefEntity
+  item:
+type: org.apache.brooklyn.entity.chef.ChefEntity
+name: Chef Entity
+description: Software managed by Chef
--- End diff --

Shouldn't you add directly the `iconUrl` field to match the changes made in 
#128 ?


---

[GitHub] brooklyn-library pull request #129: Move chef from brooklyn-software-base to...

[aledsage]

GitHub user aledsage opened a pull request:

https://github.com/apache/brooklyn-library/pull/129

Move chef from brooklyn-software-base to own module

This contains no code changes. It just moves files to the new locations, 
and moves snippets of some files (e.g. catalog.bom, blueprint.xml and 
`org.apache.brooklyn.core.resolve.entity.EntitySpecResolver`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aledsage/brooklyn-library move-chef-to-library

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-library/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #129


commit 50a175200d963e5917f8331cd594caf2fad4fa46
Author: Aled Sage 
Date:   2017-09-15T19:48:28Z

Move chef from brooklyn—software-base to own module




---