[GitHub] [camel-quarkus] asf-ci commented on issue #226: Use MainSupport as base for running Camel
asf-ci commented on issue #226: Use MainSupport as base for running Camel URL: https://github.com/apache/camel-quarkus/pull/226#issuecomment-538066722 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/195/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #226: Use MainSupport as base for running Camel
lburgazzoli commented on issue #226: Use MainSupport as base for running Camel URL: https://github.com/apache/camel-quarkus/pull/226#issuecomment-538014708 Relates to https://issues.apache.org/jira/browse/CAMEL-14031 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #225: Rename substitutions class names
ppalaga commented on a change in pull request #225: Rename substitutions class
names
URL: https://github.com/apache/camel-quarkus/pull/225#discussion_r331089810
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/graal/SubstituteIntrospectionSupport.java
##
@@ -21,14 +21,17 @@
import com.oracle.svm.core.annotate.Alias;
import com.oracle.svm.core.annotate.RecomputeFieldValue;
import com.oracle.svm.core.annotate.TargetClass;
+import com.oracle.svm.core.annotate.TargetElement;
import org.apache.camel.spi.BeanIntrospection;
import org.apache.camel.support.LRUCacheFactory;
+//
+// Don't use class here to avoid warning triggered by IntrospectionSupport
deprecation
+//
@TargetClass(className = "org.apache.camel.support.IntrospectionSupport")
-final class Target_org_apache_camel_support_IntrospectionSupport {
-
+final class SubstituteIntrospectionSupport {
@Alias
+@TargetElement(name = "CACHE")
@RecomputeFieldValue(kind = RecomputeFieldValue.Kind.FromAlias)
-private static Map, BeanIntrospection.ClassInfo> CACHE =
LRUCacheFactory.newLRUWeakCache(256);
-
+private static Map, BeanIntrospection.ClassInfo> cache =
LRUCacheFactory.newLRUWeakCache(256);
Review comment:
No, your solution is one line less :-)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Re: Daemonized maven distro available
Applying some workarounds [1], mvnd clean install -DskipTests now takes ~25 sec on my ThinkPad P50 which was ~57 sec with the sock Maven. Guillaume, you are a treasure! -- P [1] https://github.com/gnodet/mvnd/issues/12 On 30/09/2019 16:49, Peter Palaga wrote: I started using it and I like it. Thanks, -- P On 27/09/2019 23:45, Guillaume Nodet wrote: Hey guys, In my fight to speed up the camel build, I've been working these past days on maven improvements. After having worked on the build (need to push some fixes btw), then maven (speed improvements incorporated in maven 3.6.2), i've decided to spend some time enhancing maven further. What I came up with is something which looks like gradle but works with maven. The maven client spawns a daemon if needed instead of running the build locally. The benefits is that the second time the build is launched, the JVM does have everything ready and that speeds things a lot. Note that the build is run concurrently, so this still causes some problems with the Camel build which still rely on the pom ordering instead of explicit dependencies. The outcome is available at [1]. It's really easy to build and the only thing is that you should use the mvnd executable instead of the maven. Please have a look and do not hesitate to raise issues if you encounter any problem or think about any way to enhance it. If you think the project is interesting enough, i'll fix them. [1] https://github.com/gnodet/mvnd
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #225: Rename substitutions class names
lburgazzoli commented on a change in pull request #225: Rename substitutions
class names
URL: https://github.com/apache/camel-quarkus/pull/225#discussion_r331072870
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/graal/SubstituteIntrospectionSupport.java
##
@@ -21,14 +21,17 @@
import com.oracle.svm.core.annotate.Alias;
import com.oracle.svm.core.annotate.RecomputeFieldValue;
import com.oracle.svm.core.annotate.TargetClass;
+import com.oracle.svm.core.annotate.TargetElement;
import org.apache.camel.spi.BeanIntrospection;
import org.apache.camel.support.LRUCacheFactory;
+//
+// Don't use class here to avoid warning triggered by IntrospectionSupport
deprecation
+//
@TargetClass(className = "org.apache.camel.support.IntrospectionSupport")
-final class Target_org_apache_camel_support_IntrospectionSupport {
-
+final class SubstituteIntrospectionSupport {
@Alias
+@TargetElement(name = "CACHE")
@RecomputeFieldValue(kind = RecomputeFieldValue.Kind.FromAlias)
-private static Map, BeanIntrospection.ClassInfo> CACHE =
LRUCacheFactory.newLRUWeakCache(256);
-
+private static Map, BeanIntrospection.ClassInfo> cache =
LRUCacheFactory.newLRUWeakCache(256);
Review comment:
Yes, everything adds a little bit of noise, if you feel the check-style
comment is better, feel free to change it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #225: Rename substitutions class names
ppalaga commented on a change in pull request #225: Rename substitutions class
names
URL: https://github.com/apache/camel-quarkus/pull/225#discussion_r331070526
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/graal/SubstituteIntrospectionSupport.java
##
@@ -21,14 +21,17 @@
import com.oracle.svm.core.annotate.Alias;
import com.oracle.svm.core.annotate.RecomputeFieldValue;
import com.oracle.svm.core.annotate.TargetClass;
+import com.oracle.svm.core.annotate.TargetElement;
import org.apache.camel.spi.BeanIntrospection;
import org.apache.camel.support.LRUCacheFactory;
+//
+// Don't use class here to avoid warning triggered by IntrospectionSupport
deprecation
+//
@TargetClass(className = "org.apache.camel.support.IntrospectionSupport")
-final class Target_org_apache_camel_support_IntrospectionSupport {
-
+final class SubstituteIntrospectionSupport {
@Alias
+@TargetElement(name = "CACHE")
@RecomputeFieldValue(kind = RecomputeFieldValue.Kind.FromAlias)
-private static Map, BeanIntrospection.ClassInfo> CACHE =
LRUCacheFactory.newLRUWeakCache(256);
-
+private static Map, BeanIntrospection.ClassInfo> cache =
LRUCacheFactory.newLRUWeakCache(256);
Review comment:
Thanks for the explanation. BTW, there is also `// CHECKSTYLE:OFF` and `//
CHECKSTYLE:ON` that can be used to skip specific lines of code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #225: Rename substitutions class names
oscerd commented on issue #225: Rename substitutions class names URL: https://github.com/apache/camel-quarkus/pull/225#issuecomment-537967707 LGTM, let me merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #225: Rename substitutions class names
oscerd merged pull request #225: Rename substitutions class names URL: https://github.com/apache/camel-quarkus/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #224: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
asf-ci commented on issue #224: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/224#issuecomment-537967365 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/193/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #225: Rename substitutions class names
asf-ci commented on issue #225: Rename substitutions class names URL: https://github.com/apache/camel-quarkus/pull/225#issuecomment-537967357 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/194/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #225: Rename substitutions class names
lburgazzoli commented on a change in pull request #225: Rename substitutions
class names
URL: https://github.com/apache/camel-quarkus/pull/225#discussion_r331051866
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/graal/SubstituteIntrospectionSupport.java
##
@@ -21,14 +21,17 @@
import com.oracle.svm.core.annotate.Alias;
import com.oracle.svm.core.annotate.RecomputeFieldValue;
import com.oracle.svm.core.annotate.TargetClass;
+import com.oracle.svm.core.annotate.TargetElement;
import org.apache.camel.spi.BeanIntrospection;
import org.apache.camel.support.LRUCacheFactory;
+//
+// Don't use class here to avoid warning triggered by IntrospectionSupport
deprecation
+//
@TargetClass(className = "org.apache.camel.support.IntrospectionSupport")
-final class Target_org_apache_camel_support_IntrospectionSupport {
-
+final class SubstituteIntrospectionSupport {
@Alias
+@TargetElement(name = "CACHE")
@RecomputeFieldValue(kind = RecomputeFieldValue.Kind.FromAlias)
-private static Map, BeanIntrospection.ClassInfo> CACHE =
LRUCacheFactory.newLRUWeakCache(256);
-
+private static Map, BeanIntrospection.ClassInfo> cache =
LRUCacheFactory.newLRUWeakCache(256);
Review comment:
Yes, one of the reason for the renaming was to be able to run checkstyle
against substitutions but then `final` does not make much sense for substrate
and uppercase makes checkstyle unhappy so this is a compromise.
As alternative I can explicit ignore that class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #225: Rename substitutions class names
ppalaga commented on a change in pull request #225: Rename substitutions class
names
URL: https://github.com/apache/camel-quarkus/pull/225#discussion_r331033479
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/graal/SubstituteIntrospectionSupport.java
##
@@ -21,14 +21,17 @@
import com.oracle.svm.core.annotate.Alias;
import com.oracle.svm.core.annotate.RecomputeFieldValue;
import com.oracle.svm.core.annotate.TargetClass;
+import com.oracle.svm.core.annotate.TargetElement;
import org.apache.camel.spi.BeanIntrospection;
import org.apache.camel.support.LRUCacheFactory;
+//
+// Don't use class here to avoid warning triggered by IntrospectionSupport
deprecation
+//
@TargetClass(className = "org.apache.camel.support.IntrospectionSupport")
-final class Target_org_apache_camel_support_IntrospectionSupport {
-
+final class SubstituteIntrospectionSupport {
@Alias
+@TargetElement(name = "CACHE")
@RecomputeFieldValue(kind = RecomputeFieldValue.Kind.FromAlias)
-private static Map, BeanIntrospection.ClassInfo> CACHE =
LRUCacheFactory.newLRUWeakCache(256);
-
+private static Map, BeanIntrospection.ClassInfo> cache =
LRUCacheFactory.newLRUWeakCache(256);
Review comment:
Why `@TargetElement(name = "CACHE")` and `cache` field? Is our checkstyle
protesting against an uppercase field name given it is not final?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #223: support for camel-freemarker
ppalaga commented on issue #223: support for camel-freemarker URL: https://github.com/apache/camel-quarkus/issues/223#issuecomment-537941064 @carlosthe19916 new extensions are welcome! You may find https://camel.apache.org/camel-quarkus/latest/contributor-guide.html useful. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed pull request #224: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
lburgazzoli closed pull request #224: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] oscerd merged pull request #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
oscerd merged pull request #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
asf-ci commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/222#issuecomment-537928070 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/192/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti closed issue #972: Remove references to host that did compilation in stacktraces
astefanutti closed issue #972: Remove references to host that did compilation in stacktraces URL: https://github.com/apache/camel-k/issues/972 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti merged pull request #980: fix #972: strip local host data from build
astefanutti merged pull request #980: fix #972: strip local host data from build URL: https://github.com/apache/camel-k/pull/980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti closed issue #947: Permission error on a OpenStack/Cinder persistent volume while creating a temporary dir
astefanutti closed issue #947: Permission error on a OpenStack/Cinder persistent volume while creating a temporary dir URL: https://github.com/apache/camel-k/issues/947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti merged pull request #979: Fix gke permissions
astefanutti merged pull request #979: Fix gke permissions URL: https://github.com/apache/camel-k/pull/979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] astefanutti closed issue #915: Kamel run fails on Google Cloud Infrastructure (GKE)
astefanutti closed issue #915: Kamel run fails on Google Cloud Infrastructure (GKE) URL: https://github.com/apache/camel-k/issues/915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] carlosthe19916 commented on issue #223: support for camel-freemarker
carlosthe19916 commented on issue #223: support for camel-freemarker URL: https://github.com/apache/camel-quarkus/issues/223#issuecomment-537923746 @ppalaga I'd like to contribute in some way and I'm really curious about using Quakus and Freemarker in personal projects. I'm not sure if I will achieve the goal of adding a new extension but I'd like to give it a try. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
aldettinger commented on a change in pull request #222: chore: rename
CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
URL: https://github.com/apache/camel-quarkus/pull/222#discussion_r331010023
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelBeanBuildItem.java
##
@@ -20,18 +20,24 @@
import io.quarkus.builder.item.MultiBuildItem;
-public final class CamelRegistryBuildItem extends MultiBuildItem {
+/**
+ * A {@link MultiBuildItem} holding beans to add to {@link
org.apache.camel.spi.Registry} during
+ * static initialization phase.
+ * Can be produced only by methods that do not depend on {@linke CamelRuntime}
because otherwise
Review comment:
Small typo there if you have time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #223: support for camel-freemarker
ppalaga commented on issue #223: support for camel-freemarker URL: https://github.com/apache/camel-quarkus/issues/223#issuecomment-537920649 @carlosthe19916 are you working on this one? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] carlosthe19916 opened a new issue #223: support for camel-freemarke
carlosthe19916 opened a new issue #223: support for camel-freemarke URL: https://github.com/apache/camel-quarkus/issues/223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
asf-ci commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/222#issuecomment-537917899 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/191/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new issue #981: Require go >= 1.13 for development
nicolaferraro opened a new issue #981: Require go >= 1.13 for development URL: https://github.com/apache/camel-k/issues/981 And add the new `-trimpath` to the build args, as explained in #972 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new pull request #980: fix #972: strip local host data from build
nicolaferraro opened a new pull request #980: fix #972: strip local host data from build URL: https://github.com/apache/camel-k/pull/980 Problem was that go flags were not forwarded to cross-compile. I prefer not requiring everybody to upgrade to go 1.13 for using the new flag. Will open an issue for next milestone. **Release Note** ```release-note NONE ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
lburgazzoli commented on a change in pull request #222: chore: rename
CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
URL: https://github.com/apache/camel-quarkus/pull/222#discussion_r330953610
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelBeanBuildItem.java
##
@@ -20,18 +20,22 @@
import io.quarkus.builder.item.MultiBuildItem;
-public final class CamelRegistryBuildItem extends MultiBuildItem {
+/**
+ * A MultiBuildItem holding beans to add to CamelRegistry during static
initialization phase.
+ * Can be produced only by methods that do not depend on CamelRuntime (because
otherwise there is a circular dependency).
+ */
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on issue #947: Permission error on a OpenStack/Cinder persistent volume while creating a temporary dir
nicolaferraro commented on issue #947: Permission error on a OpenStack/Cinder persistent volume while creating a temporary dir URL: https://github.com/apache/camel-k/issues/947#issuecomment-537872578 This should be fixed by https://github.com/apache/camel-k/pull/979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
ppalaga commented on a change in pull request #222: chore: rename
CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
URL: https://github.com/apache/camel-quarkus/pull/222#discussion_r330952088
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelBeanBuildItem.java
##
@@ -20,18 +20,22 @@
import io.quarkus.builder.item.MultiBuildItem;
-public final class CamelRegistryBuildItem extends MultiBuildItem {
+/**
+ * A MultiBuildItem holding beans to add to CamelRegistry during static
initialization phase.
+ * Can be produced only by methods that do not depend on CamelRuntime (because
otherwise there is a circular dependency).
+ */
Review comment:
The text is perfect, but having MultiBuildItem CamelRegistry and
CamelRuntime as links (or at least FQ names) would be nice.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
asf-ci commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/222#issuecomment-537871299 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/190/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
lburgazzoli commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/222#issuecomment-537871353 > > About the naing I didn't add a prefix as I think adding it to the runtime one is enough and BuildTimeCamelBeanBuildItem looks a little bit bloated (IMHO) but I can add it if you think it is better. > > No problem with sticking to this convention, but plz add some javadoc to the build item so that the users (incl. future me) do not need to dive deep into the source code to figure these things out. done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
ppalaga commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/222#issuecomment-537871212 > About the naing I didn't add a prefix as I think adding it to the runtime one is enough and BuildTimeCamelBeanBuildItem looks a little bit bloated (IMHO) but I can add it if you think it is better. No problem with sticking to this convention, but plz add some javadoc to the build item so that the users (incl. future me) do not need to dive deep into the source code to figure these things out. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
lburgazzoli edited a comment on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/222#issuecomment-537868942 > `RuntimeCamelBeanBuildItem` I only need the build time one for the moment so I didn't added trhe runtime one because I do not yet know how it should look like. About the naing I didn't add a prefix as I think adding it to the runtime one is enough and `BuildTimeCamelBeanBuildItem` looks a little bit bloated (IMHO) but I can add it if you think it is better. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
lburgazzoli edited a comment on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/222#issuecomment-537868942 > `RuntimeCamelBeanBuildItem` I only need the build time one for the moment so I didn't added the runtime one because I do not yet know how it should look like. About the naing I didn't add a prefix as I think adding it to the runtime one is enough and `BuildTimeCamelBeanBuildItem` looks a little bit bloated (IMHO) but I can add it if you think it is better. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
lburgazzoli commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/222#issuecomment-537868942 > `RuntimeCamelBeanBuildItem` I only need the build time one for the moment so I didn't added trhe runtime one because I do not yet know how it should look like. About the naing I didn't add a prefix as I think adding it to the runtime one is enough and BuildTimeCamelBeanBuildItem looks a little bit bloated (IMHO) but I can add it if you think it is better. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new pull request #979: Fix gke permissions
nicolaferraro opened a new pull request #979: Fix gke permissions URL: https://github.com/apache/camel-k/pull/979 Fixes #915 Kaniko builds are executed with multiple containers, some of which still need to run as root. This PR sets the permissions during init so that any UID has full access over the `/workspace` dir. **Release Note** ```release-note Fixed issue which prevented creating builds on GKE ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
ppalaga commented on a change in pull request #222: chore: rename
CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
URL: https://github.com/apache/camel-quarkus/pull/222#discussion_r330943493
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelBeanBuildItem.java
##
@@ -20,18 +20,18 @@
import io.quarkus.builder.item.MultiBuildItem;
-public final class CamelRegistryBuildItem extends MultiBuildItem {
+public final class CamelBeanBuildItem extends MultiBuildItem {
Review comment:
A short class level javadoc stating the purpose and limitations would be
nice. Something like
> A MultiBuildItem holding beans to add to CamelRegistry immediately after
the registry is created. Can be produced only by methods that do not depend on
CamelRuntime (because otherwise there is a circular dependency).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
lburgazzoli commented on issue #222: chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem URL: https://github.com/apache/camel-quarkus/pull/222#issuecomment-537845138 @ppalaga renamed as I need it too for #9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] davsclaus merged pull request #201: Fix #184 Leverage platform http service
davsclaus merged pull request #201: Fix #184 Leverage platform http service URL: https://github.com/apache/camel-quarkus/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] davsclaus closed issue #184: Leverage platform http service
davsclaus closed issue #184: Leverage platform http service URL: https://github.com/apache/camel-quarkus/issues/184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Bug?Camel FTP streamdownload+move options
Hi
I logged a ticket and are looking into fixing this based on your suggestions
https://issues.apache.org/jira/browse/CAMEL-14030
On Mon, Sep 30, 2019 at 10:53 AM Claus Ibsen wrote:
>
> Hi Peter
>
> Thanks for checking. Yeah its a little bug. Thanks for reporting it.
> You are welcome to log a JIRA and provide a PR with a fix if possible.
>
> On Mon, Sep 30, 2019 at 10:17 AM Peter Nowak wrote:
> >
> > Hi Claus,
> >
> > yes, if "streamDownload" is set to "false" or the "streamDownload"
> > option (so the file is completely loaded into memory) is omitted the
> > "move" works as expected.
> >
> > Am So., 29. Sept. 2019 um 17:20 Uhr schrieb Claus Ibsen
> > :
> > >
> > > Hi
> > >
> > > And does it work when you have stream download off also ?
> > >
> > > On Sun, Sep 29, 2019 at 4:00 PM Peter Nowak
> > > wrote:
> > > >
> > > > Hi guys,
> > > >
> > > > i think i found a bug in the "GenericFileRenameProcessStrategy" when
> > > > using the ftp component with the options "streamDownload=true" and
> > > > "move=testfolder".
> > > >
> > > > After successfully retrieving the stream, the rename command (and the
> > > > directory checks) is executed before the
> > > > "FTPClient.completePendingCommand()". The "PWD" command therefor
> > > > returns the line "226 Successfully transferred /demo/demofile.txt" but
> > > > expects the replycode "257" (complete response "257 "/" is current
> > > > directory") and now the following commands and their responses are all
> > > > mixed up and the renaming fails. I think it is a bug and the method
> > > > "FTPOperations.releaseRetrievedFileResources()" (which calls
> > > > "FTPClient.completePendingCommand()") should be called at the
> > > > beginning of "GenericFileRenameProcessStrategy.commit()" (like in the
> > > > "GenericFileDeleteProcessStrategy" line 64) instead of the end.
> > > >
> > > > WIthout the "streamDownload=true" option everything works fine, as the
> > > > "FTPClient._retrieveFile()" method calls the
> > > > "completePendingCommand()" directly after it finished downloading the
> > > > file.
> > > >
> > > > Tested version: 2.23.1 (and 2.24.2)
> > > > FTP Server: Filezilla 0.96.0
> > > > Demoroute:
> > > >
> > > >
> > > > from("ftp://demo@localhost/demo?password=demo=12;
> > > > + "=archive"
> > > > + "=archive/**"
> > > > + "=true"
> > > > + "=true")
> > > > .log("Consuming file")
> > > > .process(exchange -> {
> > > > System.out.println(exchange.getIn().getBody(String.class));
> > > > })
> > > > .end();
> > > >
> > > > *
> > > > Log output:
> > > >
> > > > ...
> > > > 2019-09-29 15:36:10.739 INFO 13852 --- [ main]
> > > > o.a.camel.spring.SpringCamelContext : Route: route1 started and
> > > > consuming from:
> > > > ftp://demo@localhost/demo?antExclude=archive%2F**=12=true=archive=xx=true
> > > > 2019-09-29 15:36:10.741 INFO 13852 --- [ main]
> > > > o.a.camel.spring.SpringCamelContext : Total 1 routes, of which 1
> > > > are started
> > > > 2019-09-29 15:36:10.744 INFO 13852 --- [ main]
> > > > o.a.camel.spring.SpringCamelContext : Apache Camel 2.24.2
> > > > (CamelContext: camel-1) started in 0.427 seconds
> > > > 2019-09-29 15:36:10.749 INFO 13852 --- [ main]
> > > > c.e.c.CamelFtpDemoApplication: Started
> > > > CamelFtpDemoApplication in 4.023 seconds (JVM running for 4.651)
> > > > 2019-09-29 15:36:11.774 INFO 13852 --- [@localhost/demo] route1
> > > > : Consuming file
> > > > Hi, i am a demo file
> > > > 2019-09-29 15:36:11.789 WARN 13852 --- [@localhost/demo]
> > > > o.a.c.c.file.GenericFileOnCompletion : Error during commit.
> > > > Exchange[ID-peter-1569764169435-0-1]. Caused by:
> > > > [org.apache.camel.component.file.GenericFileOperationFailedException -
> > > > Cannot rename file: RemoteFile[demofile.txt] to:
> > > > RemoteFile[archive/demofile.txt]]
> > > >
> > > > org.apache.camel.component.file.GenericFileOperationFailedException:
> > > > Cannot rename file: RemoteFile[demofile.txt] to:
> > > > RemoteFile[archive/demofile.txt]
> > > > at
> > > > org.apache.camel.component.file.strategy.GenericFileProcessStrategySupport.renameFile(GenericFileProcessStrategySupport.java:130)
> > > > ~[camel-core-2.24.2.jar:2.24.2]
> > > > at
> > > > org.apache.camel.component.file.strategy.GenericFileRenameProcessStrategy.commit(GenericFileRenameProcessStrategy.java:111)
> > > > ~[camel-core-2.24.2.jar:2.24.2]
> > > > at
> > > > org.apache.camel.component.file.GenericFileOnCompletion.processStrategyCommit(GenericFileOnCompletion.java:127)
> > > > [camel-core-2.24.2.jar:2.24.2]
> > > > at
> > > > org.apache.camel.component.file.GenericFileOnCompletion.onCompletion(GenericFileOnCompletion.java:83)
> > > > [camel-core-2.24.2.jar:2.24.2]
> > > > at
> > > >
