Re: [HEADS UP] - URI encoding of query parameters - spaces vs plus issue

2021-03-30 Thread Claus Ibsen
Hi

I do think it may be better to make this configurable and keep the old
behavior as default (so Camel stays the same).
And then allow to turn on to use %20 as spaces for the HTTP components
so this can be used for HTTP servers that has problems.

For non HTTP components then its the "problem" with + as spaces still.



On Fri, Mar 26, 2021 at 9:28 AM Claus Ibsen  wrote:
>
> Hi
>
> I am currently working on an outstanding "issue" we have with the way
> endpoint URIs have been encoded and decoded by Camel. It goes back to
> Camel 1.x and 2.x.
>
> However here for Camel 3 we have improved the parser and optimized it
> in various ways, that it allows the opportunity to get one last
> annoyance resolved.
>
> It mostly affects when using HTTP/REST based components where you may
> have query parameters that are using spaces. Those spaces can/would be
> decimal decoded into a plus sign, which then would be sent over in the
> HTTP request.
>
> You can avoid this if the query parameters were not part of endpoint
> uri, but provided as message headers etc.
>
> We have this reported on user forums and JIRAs over the time, and we
> have been able to improve this gradually - however with the overhaul
> of camel-core in Camel 3, we got to the point where this is worth the
> effort.
>
> The JIRA ticket that the commit will be linked to would be
> https://issues.apache.org/jira/browse/CAMEL-15410
>
> This work will land in Camel 3.10 onwards.
>
>
>
>
> --
> Claus Ibsen
> -
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2



-- 
Claus Ibsen
-
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2


[HEADS UP] - URI encoding of query parameters - spaces vs plus issue

2021-03-26 Thread Claus Ibsen
Hi

I am currently working on an outstanding "issue" we have with the way
endpoint URIs have been encoded and decoded by Camel. It goes back to
Camel 1.x and 2.x.

However here for Camel 3 we have improved the parser and optimized it
in various ways, that it allows the opportunity to get one last
annoyance resolved.

It mostly affects when using HTTP/REST based components where you may
have query parameters that are using spaces. Those spaces can/would be
decimal decoded into a plus sign, which then would be sent over in the
HTTP request.

You can avoid this if the query parameters were not part of endpoint
uri, but provided as message headers etc.

We have this reported on user forums and JIRAs over the time, and we
have been able to improve this gradually - however with the overhaul
of camel-core in Camel 3, we got to the point where this is worth the
effort.

The JIRA ticket that the commit will be linked to would be
https://issues.apache.org/jira/browse/CAMEL-15410

This work will land in Camel 3.10 onwards.




-- 
Claus Ibsen
-
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2