Re: [VOTE] Release Apache Camel 2.25.4
Hi, Thanks for looking into it, if you want me to review anything (I've checked 100's of releases) I'm happy to help. Kind Regards, Justin
Re: [VOTE] Release Apache Camel 2.25.4
Hello, I'm looking at fixing this. The docs are included because they are versioned and part of the project documentation. But the binaries should not be there. Thanks. Il giorno mar 8 giu 2021 alle ore 04:51 Justin Mclean ha scritto: > Hi, > > I took a look at this release and found what I think are a couple of > issues with it. > - First off the LICENSE and NOTICE file don't seem to follow what is > expected [1] in that: > - There's 3rd party code in the release that is not mentioned in the > LICENSE file. A quick search finds BSD and MIT licensed code. > - The NOTICE file is not in the standard format [2] which includes a > copyright year > - There is what looks to be complied binary artefacts in the source > release e.g. [3][4] > > I'm not on your PMC or part of your project, but if I was this release > would have got a -1 from me. > > Although it possible that the docs were accidentally included in the > source release? Were they meant to be included? > > Thanks, > Justin > > 1. https://infra.apache.org/licensing-howto.html > 2. https://www.apache.org/licenses/NOTICE-2.0 > 3. ./docs/node/node > 4. > ./components/camel-lumberjack/src/test/resources/org/apache/camel/component/lumberjack/io/window10 >
Re: [VOTE] Release Apache Camel 2.25.4
Hi, BTW I also took a quick look at the 3.9.0 release and saw similar issues. Kind Regards, Justin
Re: [VOTE] Release Apache Camel 2.25.4
Hi, I took a look at this release and found what I think are a couple of issues with it. - First off the LICENSE and NOTICE file don't seem to follow what is expected [1] in that: - There's 3rd party code in the release that is not mentioned in the LICENSE file. A quick search finds BSD and MIT licensed code. - The NOTICE file is not in the standard format [2] which includes a copyright year - There is what looks to be complied binary artefacts in the source release e.g. [3][4] I'm not on your PMC or part of your project, but if I was this release would have got a -1 from me. Although it possible that the docs were accidentally included in the source release? Were they meant to be included? Thanks, Justin 1. https://infra.apache.org/licensing-howto.html 2. https://www.apache.org/licenses/NOTICE-2.0 3. ./docs/node/node 4. ./components/camel-lumberjack/src/test/resources/org/apache/camel/component/lumberjack/io/window10
Re: [VOTE] Release Apache Camel 2.25.4
No problem! Il ven 28 mag 2021, 08:57 Gregor Zurowski ha scritto: > Sorry, missed your vote Andrea... Just sent out the result mail. > > On Fri, May 28, 2021 at 8:52 AM Andrea Cosentino > wrote: > > > > +1 (binding) > > > > Thanks Gregor > > > > Il giorno ven 28 mag 2021 alle ore 08:49 Gregor Zurowski < > > gre...@list.zurowski.org> ha scritto: > > > > > +1 (binding) > > > > > > Gregor > > > > > > On Tue, May 25, 2021 at 8:56 AM Gregor Zurowski > > > wrote: > > > > > > > > Hi Everyone: > > > > > > > > This is a vote to release Apache Camel 2.25.4, a new patch release > for > > > > the 2.25.x branch with 10 improvements and fixes. > > > > > > > > Release notes: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349511=12311211 > > > > > > > > Staging repository: > > > > > https://repository.apache.org/content/repositories/orgapachecamel-1323/ > > > > > > > > Tarballs: > > > > https://repository.apache.org/content/repositories/orgapachecamel-1323/org/apache/camel/apache-camel/2.25.4/ > > > > > > > > Tag: > > > > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.25.4 > > > > > > > > Please test this release candidate and cast your vote. > > > > [ ] +1 Release the binary as Apache Camel 2.25.4 > > > > [ ] -1 Veto the release (provide specific comments) > > > > > > > > The vote is open for at least 72 hours. > > > > > > > > Thanks, > > > > Gregor > > > >
Re: [VOTE] Release Apache Camel 2.25.4
Sorry, missed your vote Andrea... Just sent out the result mail. On Fri, May 28, 2021 at 8:52 AM Andrea Cosentino wrote: > > +1 (binding) > > Thanks Gregor > > Il giorno ven 28 mag 2021 alle ore 08:49 Gregor Zurowski < > gre...@list.zurowski.org> ha scritto: > > > +1 (binding) > > > > Gregor > > > > On Tue, May 25, 2021 at 8:56 AM Gregor Zurowski > > wrote: > > > > > > Hi Everyone: > > > > > > This is a vote to release Apache Camel 2.25.4, a new patch release for > > > the 2.25.x branch with 10 improvements and fixes. > > > > > > Release notes: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349511=12311211 > > > > > > Staging repository: > > > https://repository.apache.org/content/repositories/orgapachecamel-1323/ > > > > > > Tarballs: > > https://repository.apache.org/content/repositories/orgapachecamel-1323/org/apache/camel/apache-camel/2.25.4/ > > > > > > Tag: > > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.25.4 > > > > > > Please test this release candidate and cast your vote. > > > [ ] +1 Release the binary as Apache Camel 2.25.4 > > > [ ] -1 Veto the release (provide specific comments) > > > > > > The vote is open for at least 72 hours. > > > > > > Thanks, > > > Gregor > >
Re: [VOTE] Release Apache Camel 2.25.4
+1 (binding) Thanks Gregor Il giorno ven 28 mag 2021 alle ore 08:49 Gregor Zurowski < gre...@list.zurowski.org> ha scritto: > +1 (binding) > > Gregor > > On Tue, May 25, 2021 at 8:56 AM Gregor Zurowski > wrote: > > > > Hi Everyone: > > > > This is a vote to release Apache Camel 2.25.4, a new patch release for > > the 2.25.x branch with 10 improvements and fixes. > > > > Release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349511=12311211 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachecamel-1323/ > > > > Tarballs: > https://repository.apache.org/content/repositories/orgapachecamel-1323/org/apache/camel/apache-camel/2.25.4/ > > > > Tag: > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.25.4 > > > > Please test this release candidate and cast your vote. > > [ ] +1 Release the binary as Apache Camel 2.25.4 > > [ ] -1 Veto the release (provide specific comments) > > > > The vote is open for at least 72 hours. > > > > Thanks, > > Gregor >
Re: [VOTE] Release Apache Camel 2.25.4
+1 (binding) Tested with CiA2 source code. There is a NPE bug in latest ActiveMQ 5.15.15 that the test found. However using 5.15.7 worked fine, which was the version used before. On Tue, May 25, 2021 at 8:56 AM Gregor Zurowski wrote: > > Hi Everyone: > > This is a vote to release Apache Camel 2.25.4, a new patch release for > the 2.25.x branch with 10 improvements and fixes. > > Release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349511=12311211 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachecamel-1323/ > > Tarballs: > https://repository.apache.org/content/repositories/orgapachecamel-1323/org/apache/camel/apache-camel/2.25.4/ > > Tag: > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.25.4 > > Please test this release candidate and cast your vote. > [ ] +1 Release the binary as Apache Camel 2.25.4 > [ ] -1 Veto the release (provide specific comments) > > The vote is open for at least 72 hours. > > Thanks, > Gregor -- Claus Ibsen - http://davsclaus.com @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
Re: [VOTE] Release Apache Camel 2.25.4
+1 (binding) Thanks! On Tue, May 25, 2021 at 2:52 PM Zoran Regvart wrote: > +1 (binding) > > Thanks Gregor! > > On Tue, May 25, 2021 at 8:57 AM Gregor Zurowski > wrote: > > > > Hi Everyone: > > > > This is a vote to release Apache Camel 2.25.4, a new patch release for > > the 2.25.x branch with 10 improvements and fixes. > > > > Release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349511=12311211 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachecamel-1323/ > > > > Tarballs: > https://repository.apache.org/content/repositories/orgapachecamel-1323/org/apache/camel/apache-camel/2.25.4/ > > > > Tag: > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.25.4 > > > > Please test this release candidate and cast your vote. > > [ ] +1 Release the binary as Apache Camel 2.25.4 > > [ ] -1 Veto the release (provide specific comments) > > > > The vote is open for at least 72 hours. > > > > Thanks, > > Gregor > > > > -- > Zoran Regvart >
Re: [VOTE] Release Apache Camel 2.25.4
+1 (binding) Thanks Gregor! On Tue, May 25, 2021 at 8:57 AM Gregor Zurowski wrote: > > Hi Everyone: > > This is a vote to release Apache Camel 2.25.4, a new patch release for > the 2.25.x branch with 10 improvements and fixes. > > Release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349511=12311211 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachecamel-1323/ > > Tarballs: > https://repository.apache.org/content/repositories/orgapachecamel-1323/org/apache/camel/apache-camel/2.25.4/ > > Tag: > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.25.4 > > Please test this release candidate and cast your vote. > [ ] +1 Release the binary as Apache Camel 2.25.4 > [ ] -1 Veto the release (provide specific comments) > > The vote is open for at least 72 hours. > > Thanks, > Gregor -- Zoran Regvart
Re: [VOTE] Release Apache Camel 2.25.4
+1 (binding) Regards JB > Le 25 mai 2021 à 08:56, Gregor Zurowski a écrit : > > Hi Everyone: > > This is a vote to release Apache Camel 2.25.4, a new patch release for > the 2.25.x branch with 10 improvements and fixes. > > Release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349511=12311211 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachecamel-1323/ > > Tarballs: > https://repository.apache.org/content/repositories/orgapachecamel-1323/org/apache/camel/apache-camel/2.25.4/ > > Tag: > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.25.4 > > Please test this release candidate and cast your vote. > [ ] +1 Release the binary as Apache Camel 2.25.4 > [ ] -1 Veto the release (provide specific comments) > > The vote is open for at least 72 hours. > > Thanks, > Gregor
Re: [VOTE] Release Apache Camel 2.25.4
+1 (binding) Thanks Gregor Babak > On 25 May 2021, at 08:56, Gregor Zurowski wrote: > > Hi Everyone: > > This is a vote to release Apache Camel 2.25.4, a new patch release for > the 2.25.x branch with 10 improvements and fixes. > > Release notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349511=12311211 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachecamel-1323/ > > Tarballs: > https://repository.apache.org/content/repositories/orgapachecamel-1323/org/apache/camel/apache-camel/2.25.4/ > > Tag: > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-2.25.4 > > Please test this release candidate and cast your vote. > [ ] +1 Release the binary as Apache Camel 2.25.4 > [ ] -1 Veto the release (provide specific comments) > > The vote is open for at least 72 hours. > > Thanks, > Gregor
