Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR

2013-10-21 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27231
---



test/integration/component/maint/test_multiple_ip_ranges.py
https://reviews.apache.org/r/14737/#comment53039

Remove this line



test/integration/component/maint/test_multiple_ip_ranges.py
https://reviews.apache.org/r/14737/#comment53043

Skip the test if the zone.networktype is not basic. 

if cls.zone.networktype == 'Basic':
   cls.new_vlan = PublicIpRange.create(cls.api_client, 
cls.services[vlan_ip_range])
else:
   self.skipTest(This test can be run only on basic zone)


- SrikanteswaraRao Talluri


On Oct. 18, 2013, 9:27 a.m., sanjeev n wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14737/
 ---
 
 (Updated Oct. 18, 2013, 9:27 a.m.)
 
 
 Review request for cloudstack and SrikanteswaraRao Talluri.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Added following code in the existing test
 1.Moved vm deployment code to setUp method and vm destroy code to tearDown 
 method
 2.Added test to verify ip alias removal after destroying last vm in the cidr
 3.Added tests to verify ip alias verification on VR after reboot and 
 stop/start VR
 
 
 Diffs
 -
 
   test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e 
 
 Diff: https://reviews.apache.org/r/14737/diff/
 
 
 Testing
 ---
 
 Yes
 
 
 Thanks,
 
 sanjeev n
 




Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR

2013-10-21 Thread SrikanteswaraRao Talluri


 On Oct. 21, 2013, 7:19 a.m., SrikanteswaraRao Talluri wrote:
  test/integration/component/maint/test_multiple_ip_ranges.py, line 150
  https://reviews.apache.org/r/14737/diff/1/?file=366277#file366277line150
 
  Skip the test if the zone.networktype is not basic. 
  
  if cls.zone.networktype == 'Basic':
 cls.new_vlan = PublicIpRange.create(cls.api_client, 
  cls.services[vlan_ip_range])
  else:
 self.skipTest(This test can be run only on basic zone)

Oh this is in setupclass, you can use this

if cls.zone.networktype == 'Basic':
   cls.new_vlan = PublicIpRange.create(cls.api_client, 
cls.services[vlan_ip_range])
else:
   raise unittest.SkipTest(This can be run only on basic zone only)


- SrikanteswaraRao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27231
---


On Oct. 18, 2013, 9:27 a.m., sanjeev n wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14737/
 ---
 
 (Updated Oct. 18, 2013, 9:27 a.m.)
 
 
 Review request for cloudstack and SrikanteswaraRao Talluri.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Added following code in the existing test
 1.Moved vm deployment code to setUp method and vm destroy code to tearDown 
 method
 2.Added test to verify ip alias removal after destroying last vm in the cidr
 3.Added tests to verify ip alias verification on VR after reboot and 
 stop/start VR
 
 
 Diffs
 -
 
   test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e 
 
 Diff: https://reviews.apache.org/r/14737/diff/
 
 
 Testing
 ---
 
 Yes
 
 
 Thanks,
 
 sanjeev n
 




Re: LXC and Networking

2013-10-21 Thread Shanker Balan

On 21-Oct-2013, at 2:41 AM, Francois Gaudreault fgaudrea...@cloudops.com 
wrote:

 Shanker,

 We were using the nonoss build, and we had to add a line in the 
 nonossComponentContext.xml (like the ticket says). I did not try with the oss 
 version, maybe there is a ossComponentContext.xml somewhere... I don't know.

I rebuilt ACS 4.2 nonoss from Git. Cluster addition works now. Thanks for the 
tip.

 list clusters name=LXC1
count = 1
cluster:
name = LXC1
id = a723620c-2f89-487d-993b-343442906fac
allocationstate = Enabled
clustertype = CloudManaged
cpuovercommitratio = 3
hypervisortype = LXC
managedstate = Managed
memoryovercommitratio = 1
podid = 56b8baec-94f2-42b8-8483-3362c8bd0601
podname = Zone21-Pod1
zoneid = 2f328497-79bf-44dd-93a4-d5844b151437
zonename = Zone21



 After I got pass this issue, I am still stuck on KVM system vms not coming 
 online properly. Something kills the VM randomly. Sometimes the Console Proxy 
 gets some IP, sometimes not. Same for SSVM. But that's another issue :)


:)

Will update on the progress at my end too.


 Francois

 On 10/20/2013, 4:04 PM, Shanker Balan wrote:
 On 20-Oct-2013, at 10:41 PM, Shanker Balan shanker.ba...@shapeblue.com 
 wrote:

 On 10-Oct-2013, at 2:40 AM, Francois Gaudreault fgaudrea...@cloudops.com 
 wrote:

 Thanks Phong about the networking answers. I will follow the KVM docs.

 Regarding the resource manager, we did compile the nonoss package on our 
 own.  Are you saying we require an extra deps?
 Hi Francois,

 Have you been able to make progress with LXC?

 I just hit the Could not find corresponding resource manager for lxc 
 issue too.
 This is with the RPMs from http://cloudstack.apt-get.eu/rhel/4.2/.

 It looks to me that the RPMs don't have LXC compiled in or are missing the 
 required JAR dep.

 [root@csman2-1 ~]# rpm -ql cloudstack-management |grep hyperviso
 /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-plugin-hypervisor-baremetal-4.2.0.jar
 /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-plugin-hypervisor-kvm-4.2.0.jar
 /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-plugin-hypervisor-ovm-4.2.0.jar
 /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-plugin-hypervisor-ucs-4.2.0.jar
 /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-plugin-hypervisor-vmware-4.2.0.jar
 /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-plugin-hypervisor-xen-4.2.0.jar


 [root@csman2-1 ~]# cloudmonkey add cluster clustername=lxc hypervisor=lxc
 zoneid=2f328497-79bf-44dd-93a4-d5844b151437 
 podid=56b8baec-94f2-42b8-8483-3362c8bd0601
 clustertype=CloudManaged
 : Could not find corresponding resource manager for lxc

 [root@csman2-1 WEB-INF]# rpm -qa|grep cloudstack-
 cloudstack-management-4.2.0-1.el6.x86_64
 cloudstack-common-4.2.0-1.el6.x86_64
 cloudstack-awsapi-4.2.0-1.el6.x86_64
 cloudstack-cli-4.2.0-1.el6.x86_64
 cloudstack-usage-4.2.0-1.el6.x86_64

 [root@csman2-1 WEB-INF]# lsb_release -a
 LSB Version:
 :base-4.0-amd64:base-4.0-noarch:core-4.0-amd64:core-4.0-noarch
 Distributor ID: CentOS
 Description:CentOS release 6.4 (Final)
 Release:6.4
 Codename:   Final
 [root@csman2-1 WEB-INF]#

 Looks like you already have a ticket open at 
 https://issues.apache.org/jira/browse/CLOUDSTACK-4849.
 I can see that the LxcServerDiscoverer beam is indeed loaded but still 
 unable to add an LXC cluster.

 2013-10-20 15:44:13,778 INFO  [utils.component.ComponentContext] 
 (Timer-2:null) Configuring 
 com.cloud.hypervisor.kvm.discoverer.LxcServerDiscoverer_EnhancerByCloudStack_42c0e23d
 2013-10-20 15:44:17,508 INFO  [utils.component.ComponentContext] 
 (Timer-2:null) Starting 
 com.cloud.hypervisor.kvm.discoverer.LxcServerDiscoverer_EnhancerByCloudStack_42c0e23d

 [root@csman2-1 ~]# grep -A 6 -B 6 -i lxc 
 /usr/share/cloudstack-management/webapps/client/WEB-INF/classes/componentContext.xml
   bean id=resourceDiscoverers 
 class=com.cloud.utils.component.AdapterList
 property name=Adapters
   list
   ref bean=XcpServerDiscoverer/
   ref bean=SecondaryStorageDiscoverer/
   ref bean=KvmServerDiscoverer/
   ref bean=LxcServerDiscoverer/
   ref bean=BareMetalDiscoverer/
   ref bean=OvmDiscoverer/
   /list
 /property
   /bean

 Regards.

 --
 @shankerbalan

 M: +91 98860 60539 | O: +91 (80) 67935867
 shanker.ba...@shapeblue.com | www.shapeblue.com | Twitter:@shapeblue
 ShapeBlue Services India LLP, 22nd floor, Unit 2201A, World Trade Centre, 
 Bangalore - 560 055

 CloudStack Bootcamp Training on 27/28 November, Bangalore
 http://www.shapeblue.com/cloudstack-training/




 This email and any attachments to it may be confidential and are intended 
 solely for the use of the individual to whom it is addressed. Any views or 
 opinions expressed are solely those of the author and do not necessarily 
 represent those of Shape Blue Ltd or related companies. If you are not the 
 intended recipient 

Re: Review Request 14467: fix for Invalid SMTP breaks HA

2013-10-21 Thread Anshul Gangwar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14467/
---

(Updated Oct. 21, 2013, 8:29 a.m.)


Review request for cloudstack and Devdeep Singh.


Changes
---

updated the patch according to current master


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4792

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4792


Repository: cloudstack-git


Description
---

added the connection and socket timeout parameters for SMTP and sending message 
in new thread so that HA doesn't get blocked beacause of hang in sending email 
alert


Diffs (updated)
-

  server/src/com/cloud/alert/AlertManagerImpl.java ed0c9fd 

Diff: https://reviews.apache.org/r/14467/diff/


Testing
---

tested manually on my local setup


Thanks,

Anshul Gangwar



4.3 Management resource design

2013-10-21 Thread Frankie Onuonga
Hi Team,

Trust you had an amazing weekend and all is well.

I would like to get involved in the 4.3 management resource side of things.
Is it possible?

Of particular interest to me is something I saw on this link:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Update+UI+visual+appearance#

I hope to be of more help in other projects as time goes by.
I also believe this will assist in making better documentation.

Kindly do advice.
Thank you in advance

Kind Regards,

Onuonga Frankie.


Review Request 14780: add netaddr package to the marvin dependency list

2013-10-21 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14780/
---

Review request for cloudstack and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

add netaddr package to the marvin dependency list


Diffs
-

  tools/marvin/setup.py eeed3bf 

Diff: https://reviews.apache.org/r/14780/diff/


Testing
---

tested the marvin installation


Thanks,

SrikanteswaraRao Talluri



Re: Review Request 14738: Testscript for DeployVM User data enhancement

2013-10-21 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14738/#review27236
---



test/integration/component/test_deploy_vm_userdata_reg.py
https://reviews.apache.org/r/14738/#comment53046

remove this



test/integration/component/test_deploy_vm_userdata_reg.py
https://reviews.apache.org/r/14738/#comment53047

remove this,you are not using this anywhere.



test/integration/component/test_deploy_vm_userdata_reg.py
https://reviews.apache.org/r/14738/#comment53048

unnecessary line



test/integration/component/test_deploy_vm_userdata_reg.py
https://reviews.apache.org/r/14738/#comment53049

remove this line



test/integration/component/test_deploy_vm_userdata_reg.py
https://reviews.apache.org/r/14738/#comment53050

Is 'test' tag required?



test/integration/component/test_deploy_vm_userdata_reg.py
https://reviews.apache.org/r/14738/#comment53051

remove print statement , use self.debug instead



test/integration/component/test_deploy_vm_userdata_reg.py
https://reviews.apache.org/r/14738/#comment53053

fix the indentation



test/integration/component/test_deploy_vm_userdata_reg.py
https://reviews.apache.org/r/14738/#comment53052

remove this line


- SrikanteswaraRao Talluri


On Oct. 18, 2013, 10:56 a.m., suresh sadhu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14738/
 ---
 
 (Updated Oct. 18, 2013, 10:56 a.m.)
 
 
 Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna 
 Santhanam.
 
 
 Bugs: cloudstack-2272
 https://issues.apache.org/jira/browse/cloudstack-2272
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 This script validates VM-deployment  with user-data of size more than 
 2048(which includes deployment as well as validation part after applying the 
 user-data)
 
  
 
 
 Diffs
 -
 
   test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/14738/diff/
 
 
 Testing
 ---
 
 yes
 
 
 Thanks,
 
 suresh sadhu
 




RE: Cannot create VM instance using template converted from snapshot

2013-10-21 Thread Suresh Sadhu
Your assumption is right and  it's a bug. An  issue exits for the same in open 
state .please update your observation in below bug:

CLOUDSTACK-4549 ceph:deployvm from template created from snapshot is failing

https://issues.apache.org/jira/browse/CLOUDSTACK-4549


regards
sadhu


-Original Message-
From: Indra Pramana [mailto:in...@sg.or.id] 
Sent: 21 October 2013 11:29
To: us...@cloudstack.apache.org; dev@cloudstack.apache.org
Subject: Cannot create VM instance using template converted from snapshot

Dear all,

We are using CloudStack 4.2.0, KVM hypervisors and Ceph RBD primary storage.

We are able to create a volume snapshot of a VM instance's root-disk, and 
convert the snapshot into a template. However, we are not able to create a new 
VM instance based on the template.Error messages on both the 
management-server.log and agent.log shows that the problem happened during the 
creation of the volume, specifically during the copying of the template from 
secondary storage for volume creation.

Logs on management-server.log:

=
2013-10-16 11:57:23,118 DEBUG [agent.transport.Request]
(AgentManager-Handler-13:null) Seq 34-1629225029: Processing:  { Ans: ,
MgmtId: 161342671900, via: 34, Ver: v1, Flags: 10, 
[{com.cloud.agent.api.Answer:{result:false,details:
java.lang.NullPointerException\n\tat
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.execute(LibvirtComputingResource.java:2469)\n\tat
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingR
esource.java:1230)\n\tat
com.cloud.agent.Agent.processRequest(Agent.java:525)\n\tat
com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:852)\n\tat
com.cloud.utils.nio.Task.run(Task.java:83)\n\tat
java.util.concurrent.ThreadPoolEx
ecutor.runWorker(ThreadPoolExecutor.java:1146)\n\tat
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)\n\tat
java.lang.Thread.run(Thread.java:679)\n,wait:0}}] }
2013-10-16 11:57:23,119 DEBUG [agent.transport.Request]
(StatsCollector-3:null) Seq 34-1629225029: Received:  { Ans: , MgmtId:
161342671900, via: 34, Ver: v1, Flags: 10, { Answer } }
2013-10-16 11:57:23,549 DEBUG [cloud.api.ApiServlet] (catalina-exec-3:null) 
===START===  103.25.200.2 -- GET 
command=queryAsyncJobResultjobId=1a5ba5a7-5756-4bae-bf21-67fc4d1b5a5aresponse=jsonsessionkey=PA1sQOGCDpcgv9KuxH6rulGrhhM%3D
_=1381895842670
2013-10-16 11:57:23,594 DEBUG [cloud.api.ApiServlet] (catalina-exec-3:null) 
===END===  103.25.200.2 -- GET 
command=queryAsyncJobResultjobId=1a5ba5a7-5756-4bae-bf21-67fc4d1b5a5aresponse=jsonsessionkey=PA1sQOGCDpcgv9KuxH6rulGrhhM%3D_=
1381895842670
2013-10-16 11:57:26,547 DEBUG [cloud.api.ApiServlet]
(catalina-exec-22:null) ===START===  103.25.200.2 -- GET 
command=queryAsyncJobResultjobId=1a5ba5a7-5756-4bae-bf21-67fc4d1b5a5aresponse=jsonsessionkey=PA1sQOGCDpcgv9KuxH6rulGrhhM%3D
_=1381895845670
2013-10-16 11:57:26,602 DEBUG [cloud.api.ApiServlet]
(catalina-exec-22:null) ===END===  103.25.200.2 -- GET 
command=queryAsyncJobResultjobId=1a5ba5a7-5756-4bae-bf21-67fc4d1b5a5aresponse=jsonsessionkey=PA1sQOGCDpcgv9KuxH6rulGrhhM%3D_
=1381895845670
2013-10-16 11:57:27,255 DEBUG [agent.manager.AgentManagerImpl]
(AgentManager-Handler-14:null) SeqA 61-109650: Processing Seq 61-109650:  { Cmd 
, MgmtId: -1, via: 61, Ver: v1, Flags: 11, 
[{com.cloud.agent.api.ConsoleProxyLoadReportComman
d:{_proxyVmId:2039,_loadInfo:{\n  \connections\: []\n},wait:0}}] }
2013-10-16 11:57:27,278 DEBUG [agent.manager.AgentManagerImpl]
(AgentManager-Handler-14:null) SeqA 61-109650: Sending Seq 61-109650:  {
Ans: , MgmtId: 161342671900, via: 61, Ver: v1, Flags: 100010, 
[{com.cloud.agent.api.AgentControlAnsw
er:{result:true,wait:0}}] }
2013-10-16 11:57:28,060 DEBUG [agent.transport.Request]
(AgentManager-Handler-15:null) Seq 34-1629225027: Processing:  { Ans: ,
MgmtId: 161342671900, via: 34, Ver: v1, Flags: 110, 
[{org.apache.cloudstack.storage.command.CopyCmdAnswer:{
result:false,details:com.cloud.utils.exception.CloudRuntimeException:
Failed to copy
/mnt/91afb8e1-6117-3e7e-a068-f980c49570a4/61e60cb9-88ec-401a-b7f8-940a568c23c2.raw
to b622fa54-aa6e-424d-a351-5a2d3f2728fe,wait:0}}] }
2013-10-16 11:57:28,060 DEBUG [agent.manager.AgentAttache]
(AgentManager-Handler-15:null) Seq 34-1629225027: No more commands found
2013-10-16 11:57:28,060 DEBUG [agent.transport.Request]
(Job-Executor-3:job-2437 = [ 1a5ba5a7-5756-4bae-bf21-67fc4d1b5a5a ]) Seq
34-1629225027: Received:  { Ans: , MgmtId: 161342671900, via: 34, Ver: v1,
Flags: 110, { CopyCmdAnswer } }
2013-10-16 11:57:28,144 INFO  [storage.volume.VolumeServiceImpl]
(Job-Executor-3:job-2437 = [ 1a5ba5a7-5756-4bae-bf21-67fc4d1b5a5a ]) releasing 
lock for VMTemplateStoragePool 122
2013-10-16 11:57:28,145 WARN  [utils.db.Merovingian2]
(Job-Executor-3:job-2437 = [ 1a5ba5a7-5756-4bae-bf21-67fc4d1b5a5a ]) Was unable 
to find lock for the key template_spool_ref122 and thread id 7779986
2013-10-16 11:57:28,146 DEBUG [cloud.storage.VolumeManagerImpl]

Re: Review Request 14738: Testscript for DeployVM User data enhancement

2013-10-21 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14738/#review27237
---



test/integration/component/test_deploy_vm_userdata_reg.py
https://reviews.apache.org/r/14738/#comment53054

This test is not cleaning up the resources it has created.


- SrikanteswaraRao Talluri


On Oct. 18, 2013, 10:56 a.m., suresh sadhu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14738/
 ---
 
 (Updated Oct. 18, 2013, 10:56 a.m.)
 
 
 Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna 
 Santhanam.
 
 
 Bugs: cloudstack-2272
 https://issues.apache.org/jira/browse/cloudstack-2272
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 This script validates VM-deployment  with user-data of size more than 
 2048(which includes deployment as well as validation part after applying the 
 user-data)
 
  
 
 
 Diffs
 -
 
   test/integration/component/test_deploy_vm_userdata_reg.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/14738/diff/
 
 
 Testing
 ---
 
 yes
 
 
 Thanks,
 
 suresh sadhu
 




Re: Review Request 14647: CLOUDSTACK-3583: Management server stop is not removing the PID

2013-10-21 Thread Rajesh Battala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14647/#review27238
---

Ship it!


LGTM.

- Rajesh Battala


On Oct. 15, 2013, 10:05 a.m., Saksham Srivastava wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14647/
 ---
 
 (Updated Oct. 15, 2013, 10:05 a.m.)
 
 
 Review request for cloudstack and Rajesh Battala.
 
 
 Bugs: CLOUDSTACK-3583
 https://issues.apache.org/jira/browse/CLOUDSTACK-3583
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The current implementation of #service cloudstack-management stop 
 kills the process. The PID file and the lock file both continue to exist 
 until the the service is started again, which replaces them.
 When the service has been stopped this causes #service cloudstack-management 
 status to return message like:
 cloudstack-management dead but pid file exists 
 The pid file locates at /var/run/cloudstack-management.pid and lock file at 
 /var/lock/subsys/cloudstack-management. 
 Starting cloudstack-management will take care of them or you can manually 
 clean up
 
 In the fix I am removing the PID and the lock file once the service has been 
 successfully killed.
 Also when the service is cleanly stopped the return value is 3, added the 
 same check in handle_pid_file().
 
 
 Diffs
 -
 
   packaging/centos63/cloud-management.rc 35f31b2 
 
 Diff: https://reviews.apache.org/r/14647/diff/
 
 
 Testing
 ---
 
 Tested locally :
 The status is now as #service cloudstack-management status
 cloudstack-management is stopped
 
 
 Thanks,
 
 Saksham Srivastava
 




Re: Incomplete API docs?

2013-10-21 Thread David Nalley
Yes - it's really a bug in ApiXmlDocWriter. Please file it.

--David

On Thu, Oct 17, 2013 at 4:39 PM, Demetrius Tsitrelis
demetrius.tsitre...@citrix.com wrote:
 Do you still think there needs to be a bug filed for the missing APIs?

 -Original Message-
 From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
 Sent: Thursday, October 17, 2013 1:21 PM
 To: dev@cloudstack.apache.org
 Subject: RE: Incomplete API docs?


 +1

 Radhika on the 4.3 release page I have solicited volunteers for different 
 release activities. Looks like the high level tasks could use a better 
 breakdown, do you want to take a stab at breaking doc into sub tasks and 
 folks interested can fill in their name.

 Animesh

 -Original Message-
 From: Radhika Puthiyetath [mailto:radhika.puthiyet...@citrix.com]
 Sent: Wednesday, October 16, 2013 3:24 AM
 To: dev@cloudstack.apache.org
 Subject: RE: Incomplete API docs?

 Hi All,

 Our API documentation requires a serious refurbishment.

 How about creating a doc sprint for enhancing API documentation ?

 I am in the process of setting up a Wiki page at
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Documentation+S
 pr
 int+for+Enhancing+API+Documentation to track this activity. Feel free
 int+for+Enhancing+API+to
 add/ edit/ remove the page content.

 I request all of you to volunteer so that we will have a comprehensive
 API doc set by next release.

 Appreciate your feedback.

 Regards
 -Radhika



 -Original Message-
 From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
 Sent: Wednesday, October 16, 2013 7:36 AM
 To: dev@cloudstack.apache.org
 Subject: RE: Incomplete API docs?

 Demetrius do you mind creating an issue in JIRA?

  -Original Message-
  From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com]
  Sent: Tuesday, October 15, 2013 5:15 PM
  To: dev@cloudstack.apache.org
  Subject: Re: Incomplete API docs?
 
  The commands.xml generated as a result of mvn build (mvn clean
  install
  - P developer,systemvm -DskipTests), doesn't include the commands
  mentioned by Demetrius. Looks like some regression bug in
  ApiXmlDocWriter - it used to include all the commands in 3.0.x
  version of the code.
 
  -Alena.
 
  From: Demetrius Tsitrelis
  dtsitre...@live.commailto:dtsitre...@live.com
  Reply-To:
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
  dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
  Date: Tuesday, October 15, 2013 4:33 PM
  To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
  dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
  Subject: Incomplete API docs?
 
 
 
  I grep'ed the source code and came up with a list of the APIs which
  the UI uses.  That list is at the end of this message.
  You can see that many of them (addNetscalerLoadBalancer,
  addVmwareDc,
  etc.) are not in the generated API documentation which appears at
  http://cloudstack.apache.org/docs/api/apidocs-4.2/TOC_Root_Admin.htm
  l
 
 
  Is this something wrong with the input files or is a tool at fault?
 
 
  Here's the list of APIs used by the UI:
 
  activateProject
 
  addAccountToProject
 
  addBaremetalDhcp
 
  addBaremetalPxeKickStartServer
 
  addCluster
 
  addHost
 
  addImageStore
 
  addIpToNic
 
  addLdapConfiguration
 
  addNetscalerLoadBalancer
 
  addNetworkServiceProvider
 
  addNicToVirtualMachine
 
  addRegion
 
  addTrafficType
 
  addUcsManager
 
  addVmwareDc
 
  addVpnUser
 
  archiveAlerts
 
  archiveEvents
 
  assignToGlobalLoadBalancerRule
 
  assignToLoadBalancerRule
 
  assignVirtualMachine
 
  associateIpAddress
 
  associateUcsProfileToBlade
 
  attachIso
 
  attachVolume
 
  authorizeSecurityGroupEgress
 
  authorizeSecurityGroupIngress
 
  cancelHostMaintenance
 
  cancelStorageMaintenance
 
  configureInternalLoadBalancerElement
 
  configureVirtualRouterElement
 
  copyIso
 
  copyTemplate
 
  createAccount
 
  createAffinityGroup
 
  createAutoScalePolicy
 
  createAutoScaleVmGroup
 
  createAutoScaleVmProfile
 
  createCondition
 
  createDiskOffering
 
  createDomain
 
  createEgressFirewallRule
 
  createFirewallRule
 
  createGlobalLoadBalancerRule
 
  createIpForwardingRule
 
  createLBHealthCheckPolicy
 
  createLBStickinessPolicy
 
  createLoadBalancer
 
  createLoadBalancerRule
 
  createNetwork
 
  createNetworkACL
 
  createNetworkACLList
 
  createNetworkOffering
 
  createPhysicalNetwork
 
  createPod
 
  createPortableIpRange
 
  createPortForwardingRule
 
  createPrivateGateway
 
  createProject
 
  createRemoteAccessVpn
 
  createSecondaryStagingStore
 
  createSecurityGroup
 
  createServiceOffering
 
  createSnapshot
 
  createSnapshotPolicy
 
  createStaticRoute
 
  createStorageNetworkIpRange
 
  createStoragePool
 
  createTags
 
  createTemplate
 
  createUser
 
  createVlanIpRange
 
  createVMSnapshot
 
  createVolume
 
  createVPC
 
  createVpnConnection
 
  createVpnCustomerGateway
 
  createVpnGateway
 
  createZone
 
  dedicateCluster
 
  

Re: Incomplete API docs?

2013-10-21 Thread David Nalley
On Wed, Oct 16, 2013 at 6:24 AM, Radhika Puthiyetath
radhika.puthiyet...@citrix.com wrote:
 Hi All,

 Our API documentation requires a serious refurbishment.



Hi Radhika:

What do you see as lacking in our current API docs (aside from them
not working ;) )



 How about creating a doc sprint for enhancing API documentation ?

 I am in the process of setting up a Wiki page at 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Documentation+Sprint+for+Enhancing+API+Documentation
  to track this activity. Feel free to add/ edit/ remove the page content.

 I request all of you to volunteer so that we will have a comprehensive API 
 doc set by next release.

 Appreciate your feedback.



Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR

2013-10-21 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/
---

(Updated Oct. 21, 2013, 9:29 a.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Changes
---

Incorporated the review comments.


Repository: cloudstack-git


Description
---

Added following code in the existing test
1.Moved vm deployment code to setUp method and vm destroy code to tearDown 
method
2.Added test to verify ip alias removal after destroying last vm in the cidr
3.Added tests to verify ip alias verification on VR after reboot and stop/start 
VR


Diffs (updated)
-

  test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e 

Diff: https://reviews.apache.org/r/14737/diff/


Testing
---

Yes


Thanks,

sanjeev n



Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR

2013-10-21 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27240
---

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14737/
 ---
 
 (Updated Oct. 21, 2013, 9:29 a.m.)
 
 
 Review request for cloudstack and SrikanteswaraRao Talluri.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Added following code in the existing test
 1.Moved vm deployment code to setUp method and vm destroy code to tearDown 
 method
 2.Added test to verify ip alias removal after destroying last vm in the cidr
 3.Added tests to verify ip alias verification on VR after reboot and 
 stop/start VR
 
 
 Diffs
 -
 
   test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e 
 
 Diff: https://reviews.apache.org/r/14737/diff/
 
 
 Testing
 ---
 
 Yes
 
 
 Thanks,
 
 sanjeev n
 




Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual machine test cases

2013-10-21 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/#review27239
---



tools/marvin/setup.py
https://reviews.apache.org/r/14593/#comment53055

Remove brackets 
ddt = 0.4.0 is enough


- SrikanteswaraRao Talluri


On Oct. 16, 2013, 12:08 p.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14593/
 ---
 
 (Updated Oct. 16, 2013, 12:08 p.m.)
 
 
 Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
 More tests to be added on top of this - in progress.
 
 DDT library needed to run the test case.
 It can be installed with pip install ddt command.
 
 
 Diffs
 -
 
   test/integration/component/test_scale_vm.py PRE-CREATION 
   tools/marvin/marvin/integration/lib/base.py 0d52224 
   tools/marvin/marvin/integration/lib/common.py 164ef20 
   tools/marvin/setup.py eeed3bf 
 
 Diff: https://reviews.apache.org/r/14593/diff/
 
 
 Testing
 ---
 
 Tested on XenServer. Not attaching logs because different test cases were run 
 at different time, not all at once.
 All test cases running on XenServer, if at all needed, will add log after 
 running them once again.
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Incomplete API docs?

2013-10-21 Thread David Nalley
That's actually a great point. One of my favorites is:
http://cloudstack.apache.org/docs/api/apidocs-4.2/root_admin/changeServiceForSystemVm.html

Is ID really UUID? or the human readable ID?

--David.

On Mon, Oct 21, 2013 at 5:32 AM, Radhika Puthiyetath
radhika.puthiyet...@citrix.com wrote:
 Hi David,

 They are simple one liners that do not convey  anything about the API.

 -Original Message-
 From: David Nalley [mailto:da...@gnsa.us]
 Sent: Monday, October 21, 2013 2:54 PM
 To: dev@cloudstack.apache.org
 Subject: Re: Incomplete API docs?

 On Wed, Oct 16, 2013 at 6:24 AM, Radhika Puthiyetath 
 radhika.puthiyet...@citrix.com wrote:
 Hi All,

 Our API documentation requires a serious refurbishment.



 Hi Radhika:

 What do you see as lacking in our current API docs (aside from them not 
 working ;) )



 How about creating a doc sprint for enhancing API documentation ?

 I am in the process of setting up a Wiki page at 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Documentation+Sprint+for+Enhancing+API+Documentation
  to track this activity. Feel free to add/ edit/ remove the page content.

 I request all of you to volunteer so that we will have a comprehensive API 
 doc set by next release.

 Appreciate your feedback.



[Proposal] cpu socket count of hosts

2013-10-21 Thread Harikrishna Patnala
Hi,

I'm planning to provide some additional infrastructure statistics i.e., number 
of hosts/ CPU sockets apart from the details that we have in our dash board.
Cloustack manages various number of hosts / cpu sockets which reflects the size 
of cloud.
When we add the host we collect the number of CPU sockets and add this 
information in HostReponse.

So we can calculate the cpu socket number summing the number of sockets for 
each host using listHostsAPI.

Please provide me comments/feedback

Thanks
Harikrishna 

Re: [proposal] Autoscaling CPU/RAM feature

2013-10-21 Thread Harikrishna Patnala
Hi,
We have cpu and ram overcommit ratios that can be set. Hypervisor does the 
autoscaling based on contention.

-Harikrishna

On 21-Oct-2013, at 10:13 AM, Nguyen Anh Tu ng.t...@gmail.com wrote:

 Hi guys,
 
 I read about the new feature on 4.2 version: dynamic scaling of CPU and
 RAM -
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamic+scaling+of+CPU+and+RAM
 
 I'm wonder why we don't support autoscaling CPU and RAM feature, which acts
 like the current autoscaling. Particularly, when deploying VM, users set
 memory_static_min and memory_static_max and ACS choose memory_dynamic_min
 and memory_dynamic_max, for
 example, memory_dynamic_min=memory_dynamic_max=memory_static_min. While
 running, if the VM is in pressure, ACS automatically
 change memory_dynamic_min, memory_dynamic_max based on pre-defined policy.
 
 At configuration period, users may set these below parameters:
 
 memory_static_min
 memory_static_max
 duration
 quiet time
 interval
 threshold
 
 
 Any idea?
 
 Cheers,
 
 -- 
 
 N.g.U.y.e.N.A.n.H.t.U



Re: [Proposal] cpu socket count of hosts

2013-10-21 Thread Harikrishna Patnala
I have filed a ticket for this 
https://issues.apache.org/jira/browse/CLOUDSTACK-4908

-Harikrishna

On 21-Oct-2013, at 4:13 PM, HARIKRISHNA PATNALA harikrishna.patn...@citrix.com
 wrote:

 Hi,
 
 I'm planning to provide some additional infrastructure statistics i.e., 
 number of hosts/ CPU sockets apart from the details that we have in our dash 
 board.
 Cloustack manages various number of hosts / cpu sockets which reflects the 
 size of cloud.
 When we add the host we collect the number of CPU sockets and add this 
 information in HostReponse.
 
 So we can calculate the cpu socket number summing the number of sockets for 
 each host using listHostsAPI.
 
 Please provide me comments/feedback
 
 Thanks
 Harikrishna



Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual machine test cases

2013-10-21 Thread Gaurav Aradhye


 On Oct. 21, 2013, 3:17 p.m., SrikanteswaraRao Talluri wrote:
  tools/marvin/setup.py, line 55
  https://reviews.apache.org/r/14593/diff/3/?file=365068#file365068line55
 
  Remove brackets 
  ddt = 0.4.0 is enough

Done


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/#review27239
---


On Oct. 21, 2013, 6:24 p.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14593/
 ---
 
 (Updated Oct. 21, 2013, 6:24 p.m.)
 
 
 Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
 More tests to be added on top of this - in progress.
 
 DDT library needed to run the test case.
 It can be installed with pip install ddt command.
 
 
 Diffs
 -
 
   test/integration/component/test_scale_vm.py PRE-CREATION 
   tools/marvin/marvin/integration/lib/base.py 4f15137 
   tools/marvin/marvin/integration/lib/common.py 164ef20 
   tools/marvin/setup.py eeed3bf 
 
 Diff: https://reviews.apache.org/r/14593/diff/
 
 
 Testing
 ---
 
 Tested on XenServer. Not attaching logs because different test cases were run 
 at different time, not all at once.
 All test cases running on XenServer, if at all needed, will add log after 
 running them once again.
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual machine test cases

2013-10-21 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/
---

(Updated Oct. 21, 2013, 6:24 p.m.)


Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.


Changes
---

Review Changes.


Repository: cloudstack-git


Description
---

Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
More tests to be added on top of this - in progress.

DDT library needed to run the test case.
It can be installed with pip install ddt command.


Diffs (updated)
-

  test/integration/component/test_scale_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py 4f15137 
  tools/marvin/marvin/integration/lib/common.py 164ef20 
  tools/marvin/setup.py eeed3bf 

Diff: https://reviews.apache.org/r/14593/diff/


Testing
---

Tested on XenServer. Not attaching logs because different test cases were run 
at different time, not all at once.
All test cases running on XenServer, if at all needed, will add log after 
running them once again.


Thanks,

Gaurav Aradhye



RE: [Discuss] Donation of RDP client code

2013-10-21 Thread Donal Lafferty
Hi Wei ZHOU,

Thank you for your positive feedback.

Adding the console to the systemVM would happen after a donation, because we 
would want to do the integration in public.  Therefore, it would be premature 
to contact Hugo about his system VM work. 

DL


 -Original Message-
 From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
 Sent: 17 October 2013 18:15
 To: dev@cloudstack.apache.org
 Subject: Re: [Discuss] Donation of RDP client code
 
 It looks very nice. Thanks!
 
 Hugo are working on the refactor of systemvm. Maybe it need to be
 modified.
 
 
 2013/10/17 Donal Lafferty donal.laffe...@citrix.com
 
  This donation addresses our need for an RDP client free of IP
  restrictions that can be included with Apache CloudStack's console VM.
 
 
 
  RDP is of interest, because Hyper-V exposes VM consoles over RDP.
   However, Apache CloudStack does not have an RDP client that is easy
  to build, can easily run in the console VM, and has no IP dependencies.
 
 
 
  The donated code addresses this gap.  The source is for an all-Java
  solution, which meets the console VM's expectations of a Java-based
  renderer.  A Maven pom.xml is included that can be incorporated in the
  Apache CloudStack build.  Finally, the code has no significant IP
  dependencies.  Only JUnit 3.8.1 (Common Public License Version 1.0)
  and tomcat-embed-core 7.0.30 (Apache License, Version 2.03) are
  referenced by the pom.xml.  No third party Java code is used or included.
 
 
 
  The client's source is in the diff attached to the Review Board
  submission https://reviews.apache.org/r/14701/  This submission
  includes technical details in the description field.  The code was
  developed for Citrix Systems by a contractor.
 
 
 
  Note that the client still has to be integrated with console system VM.
   However, it makes more sense to do this after we're certain that the
  client will go into ACS.
 
 
 
  Please have a look, all opinions welcome!
 
 


[ACS 42] Problem when creating template from Root-disk

2013-10-21 Thread benoit lair
Hi Guys,

I got a problem with my acs 42 installation :

Trying to create a template from an existing vm, but it never become
available.
It keeps in state Ready : No

On my secondary storage, the right directory is well created, but it
doesn't contain the template.properties file.

I didn't found any mgmt server logs entries that could explain me the
reason why the template isn't available.

I've tried to restart my mgmt server daemon and also my ssvm and my nfs
secondary storage daemon, but no changes.

Any idea about my problem ?

Also, my secondary storage is 96% full, could this be a part of the root
cause of the problem ?

I have also tried to delete this template from the UI, but i got this error
msg : Failed to update state.

In the mgmt server log i got theses entries :

2013-10-21 14:53:35,945 ERROR [cloud.async.AsyncJobManagerImpl]
(Job-Executor-2:job-591 = [ 481fa987-3967-44c1-90d7-1a6c7dfb49ac ])
Unexpected exception while executing
org.apache.cloudstack.api.command.user.template.DeleteTemplateCmd
com.cloud.utils.exception.CloudRuntimeException: Failed to update state
at
org.apache.cloudstack.storage.image.store.TemplateObject.processEvent(TemplateObject.java:164)
at
org.apache.cloudstack.storage.image.TemplateServiceImpl.deleteTemplateAsync(TemplateServiceImpl.java:558)
at
com.cloud.template.HypervisorTemplateAdapter.delete(HypervisorTemplateAdapter.java:324)
at
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at
com.cloud.template.TemplateManagerImpl.deleteTemplate(TemplateManagerImpl.java:1080)
at
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at
org.apache.cloudstack.api.command.user.template.DeleteTemplateCmd.execute(DeleteTemplateCmd.java:112)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
at
com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)
Caused by: com.cloud.utils.fsm.NoTransitionException: Unable to transition
to a new state from Creating via DestroyRequested
at com.cloud.utils.fsm.StateMachine2.getNextState(StateMachine2.java:83)
at com.cloud.utils.fsm.StateMachine2.transitTo(StateMachine2.java:100)
at
org.apache.cloudstack.storage.datastore.ObjectInDataStoreManagerImpl.update(ObjectInDataStoreManagerImpl.java:301)
at
org.apache.cloudstack.storage.image.store.TemplateObject.processEvent(TemplateObject.java:162)
... 22 more


Any clues ?

Thanks for your help.

Regards, Benoit.


Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-21 Thread SuichII, Christopher
John,

Will you be able to take a look at this revision soon? It is a small change to 
address your comments so it should not take very long.

Thanks,
Chris
--
Chris Suich
chris.su...@netapp.commailto:chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco  Red Hat

On Oct 17, 2013, at 2:46 PM, Chris Suich 
chris.su...@netapp.commailto:chris.su...@netapp.com wrote:

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/14522/

Review request for cloudstack, Brian Federle, edison su, John Burwell, and Mike 
Tutkowski.
By Chris Suich.

Updated Oct. 17, 2013, 6:46 p.m.

Changes

-Added context to the error messages for not finding DataMotionStrategies. 
However, it appears that the place where pickStrategy() is called for 
SnapshotStrategies is not able to actually throw error messages. I will open a 
separate issue for this.
-Added TODOs for DRYing out the overloaded pickStrategy() methods.
-Added context to the error message for failing to find the image store 
snapshot info for a snapshot response. However, this also is unable to throw a 
meaning full error message as the exception would be caught and replaced with a 
generic error. I will create a separate issue for this as well.


Repository: cloudstack-git
Description

After the last batch of work to the revertSnapshot API, SnapshotServiceImpl was 
not tied into the workflow to be used by storage providers. I have added the 
logic in a similar fashion to takeSnapshot(), backupSnapshot() and 
deleteSnapshot().

I have also added a 'Revert to Snapshot' action to the volume snapshots list in 
the UI.


Testing

I have tested all of this locally with a custom storage provider.

Unfortunately, I'm still in the middle of figuring out how to properly unit 
test this type of code. If anyone has any recommendations, please let me know.


Diffs (updated)

  *   
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
 (81034b1)
  *   
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java
 (2d31320)
  *   server/src/com/cloud/api/ApiResponseHelper.java (f4ca112)
  *   server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java (dade983)

View Diffhttps://reviews.apache.org/r/14522/diff/




Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

2013-10-21 Thread John Burwell
Chris,

I am in-transit to CloudConnect.  I will try to review the latest patch by
COB today (21 Oct 2013).

Thanks,
-John




On Oct 21, 2013, at 9:31 AM, SuichII, Christopher chris.su...@netapp.com
wrote:

 John,

 Will you be able to take a look at this revision soon? It is a small
change to address your comments so it should not take very long.

 Thanks,
Chris
-- 
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco  Red Hat

 On Oct 17, 2013, at 2:46 PM, Chris Suich chris.su...@netapp.com wrote:

   This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14522/
  Review request for cloudstack, Brian Federle, edison su, John Burwell,
and Mike Tutkowski.
By Chris Suich.

*Updated Oct. 17, 2013, 6:46 p.m.*
Changes

-Added context to the error messages for not finding
DataMotionStrategies. However, it appears that the place where
pickStrategy() is called for SnapshotStrategies is not able to
actually throw error messages. I will open a separate issue for this.
-Added TODOs for DRYing out the overloaded pickStrategy() methods.
-Added context to the error message for failing to find the image
store snapshot info for a snapshot response. However, this also is
unable to throw a meaning full error message as the exception would be
caught and replaced with a generic error. I will create a separate
issue for this as well.

  *Repository: *cloudstack-git
Description

After the last batch of work to the revertSnapshot API,
SnapshotServiceImpl was not tied into the workflow to be used by
storage providers. I have added the logic in a similar fashion to
takeSnapshot(), backupSnapshot() and deleteSnapshot().

I have also added a 'Revert to Snapshot' action to the volume
snapshots list in the UI.

  Testing

I have tested all of this locally with a custom storage provider.

Unfortunately, I'm still in the middle of figuring out how to properly
unit test this type of code. If anyone has any recommendations, please
let me know.

  Diffs (updated)

   - 
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
   (81034b1)
   - 
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java
   (2d31320)
   - server/src/com/cloud/api/ApiResponseHelper.java (f4ca112)
   - server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
   (dade983)

View Diff https://reviews.apache.org/r/14522/diff/


RE: [Discuss] Donation of RDP client code

2013-10-21 Thread Ram Ganesh
Are we looking good with the donation code and can we make progress to get this 
code into  a private branch?

Thanks,
RamG


 -Original Message-
 From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
 Sent: 21 October 2013 18:37
 To: dev@cloudstack.apache.org
 Subject: RE: [Discuss] Donation of RDP client code
 
 Hi Wei ZHOU,
 
 Thank you for your positive feedback.
 
 Adding the console to the systemVM would happen after a donation,
 because we would want to do the integration in public.  Therefore, it would
 be premature to contact Hugo about his system VM work.
 
 DL
 
 
  -Original Message-
  From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
  Sent: 17 October 2013 18:15
  To: dev@cloudstack.apache.org
  Subject: Re: [Discuss] Donation of RDP client code
 
  It looks very nice. Thanks!
 
  Hugo are working on the refactor of systemvm. Maybe it need to be
  modified.
 
 
  2013/10/17 Donal Lafferty donal.laffe...@citrix.com
 
   This donation addresses our need for an RDP client free of IP
   restrictions that can be included with Apache CloudStack's console VM.
  
  
  
   RDP is of interest, because Hyper-V exposes VM consoles over RDP.
However, Apache CloudStack does not have an RDP client that is easy
   to build, can easily run in the console VM, and has no IP dependencies.
  
  
  
   The donated code addresses this gap.  The source is for an all-Java
   solution, which meets the console VM's expectations of a Java-based
   renderer.  A Maven pom.xml is included that can be incorporated in
   the Apache CloudStack build.  Finally, the code has no significant
   IP dependencies.  Only JUnit 3.8.1 (Common Public License Version
   1.0) and tomcat-embed-core 7.0.30 (Apache License, Version 2.03) are
   referenced by the pom.xml.  No third party Java code is used or included.
  
  
  
   The client's source is in the diff attached to the Review Board
   submission https://reviews.apache.org/r/14701/  This submission
   includes technical details in the description field.  The code was
   developed for Citrix Systems by a contractor.
  
  
  
   Note that the client still has to be integrated with console system VM.
However, it makes more sense to do this after we're certain that
   the client will go into ACS.
  
  
  
   Please have a look, all opinions welcome!
  
  


Review Request 14782: [CLOUDSTACK-4910] Take VM snapshot instantly returns success regardless of actual result

2013-10-21 Thread Chris Suich

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14782/
---

Review request for cloudstack, Brian Federle and Jessica Wang.


Repository: cloudstack-git


Description
---

Fixed a typo causing vm snapshot requests to always instantly return successful 
in the CloudStack UI.


Diffs
-

  ui/scripts/instances.js 41d1772 

Diff: https://reviews.apache.org/r/14782/diff/


Testing
---


Thanks,

Chris Suich



Review Request 14783: [CLOUDSTACK-4844] Docs show incorrect URL for Windows password reset service download

2013-10-21 Thread Travis Graham

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14783/
---

Review request for cloudstack.


Repository: cloudstack-docs


Description
---

(Section 12.13.2) Removes the windows MSI link from the linux section and 
corrects the MSI link in the windows section.


Diffs
-

  en-US/linux-installation.xml 14a2f51 
  en-US/windows-installation.xml bcecc80 

Diff: https://reviews.apache.org/r/14783/diff/


Testing
---


Thanks,

Travis Graham



Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu

2013-10-21 Thread Travis Graham

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14784/
---

Review request for cloudstack.


Repository: cloudstack-docs


Description
---

(section 4.5.7.2) reflect steps for RHEL/CentOS and Ubuntu.


Diffs
-

  en-US/nfs-shares-on-management-server.xml 881ca8d 

Diff: https://reviews.apache.org/r/14784/diff/


Testing
---


Thanks,

Travis Graham



Review Request 14785: [CLOUDSTACK-4692] Release notes refer to componentsContext.xml instead of componentContext.xml

2013-10-21 Thread Travis Graham

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14785/
---

Review request for cloudstack.


Repository: cloudstack-docs


Description
---

Corrects the two references in Release Notes.


Diffs
-

  release-notes/en-US/Release_Notes.xml a65cca9 

Diff: https://reviews.apache.org/r/14785/diff/


Testing
---


Thanks,

Travis Graham



Review Request 14786: [CLOUDSTACK-4609] [doc] Review Comments on Dedicated Resources: POD, CLUSTER

2013-10-21 Thread Travis Graham

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14786/
---

Review request for cloudstack.


Repository: cloudstack-docs


Description
---

(sections 2.3 and 2.4) Updated references to organization unit within 
CloudStack for Pods and Clusters


Diffs
-

  en-US/about-clusters.xml d2f0220 
  en-US/about-pods.xml 57ae1a3 

Diff: https://reviews.apache.org/r/14786/diff/


Testing
---


Thanks,

Travis Graham



Re: contrail virtual network controller

2013-10-21 Thread Pedro Roque Marques
Prasana,

On Oct 2, 2013, at 9:18 PM, Prasanna Santhanam wrote:

 On Tue, Sep 17, 2013 at 10:18:29AM -0700, Pedro Roque Marques wrote:
 
 We have an integration test which requires spawning a mysql db,
 initialize it and then go through the process of creating a zone,
 etc.  This allows us to test the plugin against the API. The
 drawback is that this test takes a bit to spawn the mysql db...
 Does anyone have a recipe to run against an in-memory database for
 testing purposes ? 
 
 
 Does the mysqldb contain fixture data from when contrail is deployed
 on a cloudstack cloud? I presume then the integration test can run
 without the contrail device added to cloudstack?

mysql is required for the *Dao objects necessary to simulate zone create, 
physical network and guest  network creation. The contrail API server is being 
mocked.

 
 -- 
 Prasanna.,
 
 
 Powered by BigRock.com
 



Re: [ASF4.2.1] Progress

2013-10-21 Thread Patrick Miller
 Hi,
   I posted a question on dev Friday regarding Cloudstack-4828.  This was
broken between 4.1 and 4.2.
   What is the corrrect process to get this in the queue for 4.2.1.

 Thanks for all the great work all of you have put in to this.

 Patrick


On Sun, Oct 20, 2013 at 8:42 PM, Abhinandan Prateek 
abhinandan.prat...@citrix.com wrote:

 With active help of community and dedicated engineers from Citrix we have
 made some tremendous progress in fixing blockers and criticals targeted for
 this maintenance release. In last two weeks around 70 tickets were resolved
 (~38 blockers and criticals).

 There are roughly 15 criticals/blockers ticket open now. Our target is to
 be code complete early this week and we are on our way to meet it. A timely
 maintenance release will also help the next big release.

 -abhi



Re: Review Request 14549: Rename net.juniper.contrail to org.apache.cloudstack.network.contrail

2013-10-21 Thread Pedro Marques

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/
---

(Updated Oct. 21, 2013, 4:39 p.m.)


Review request for cloudstack.


Changes
---

Patch created by git format-patch on a new local branch tracking 
origin/master with the contrail plugin changes merged.


Repository: cloudstack-git


Description
---

Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 49f380b 
  client/pom.xml fd1f13a 
  client/tomcatconf/applicationContext.xml.in 6dda5c7 
  client/tomcatconf/applicationContext.xml.in 0ab2515 
  client/tomcatconf/commands.properties.in 58c770d 
  client/tomcatconf/componentContext.xml.in df5b002 
  client/tomcatconf/componentContext.xml.in 157ad5a 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 92fbab2 
  plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION 
  plugins/network-elements/juniper-contrail/pom.xml 60ce059 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java
 9a84d31 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java
 92f5eeb 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java
 00fe7d3 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java
 1b7a7d8 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java
 bd2bdbc 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java
 885a60f 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java
 d407edd 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java
 3a38020 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java
 d77 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java
 c655b0b 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java
 c517660 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java
 5195793 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java
 271b016 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java
 8a3ca1b 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java
 54e2e14 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java
 d169b37 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java
 445a2cf 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java
 acd1bed 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java
 3c23016 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java
 bad2502 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java
 PRE-CREATION 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java
 90c67cc 
  
plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java
 f9e7c24 
  

Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)

2013-10-21 Thread Koushik Das

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/#review27250
---

Ship it!


Ship It!

- Koushik Das


On Oct. 21, 2013, 5:14 a.m., Harikrishna Patnala wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14305/
 ---
 
 (Updated Oct. 21, 2013, 5:14 a.m.)
 
 
 Review request for cloudstack and Koushik Das.
 
 
 Bugs: CLOUDSTACK-4493
 https://issues.apache.org/jira/browse/CLOUDSTACK-4493
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CLOUDSTACK-4493:  registerSSHKeyPair API doc contains wrong API response 
 (private key) 
 Changing the response object of register and list ssh keypairs APIs
 
 
 Diffs
 -
 
   api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 
 56bec7e 
   api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java 
 PRE-CREATION 
   api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853 
 
 Diff: https://reviews.apache.org/r/14305/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Harikrishna Patnala
 




RE: Incomplete API docs?

2013-10-21 Thread Demetrius Tsitrelis
Filed as CLOUDSTACK-4912.

-Original Message-
From: David Nalley [mailto:da...@gnsa.us] 
Sent: Monday, October 21, 2013 2:22 AM
To: dev@cloudstack.apache.org
Subject: Re: Incomplete API docs?

Yes - it's really a bug in ApiXmlDocWriter. Please file it.

--David

On Thu, Oct 17, 2013 at 4:39 PM, Demetrius Tsitrelis 
demetrius.tsitre...@citrix.com wrote:
 Do you still think there needs to be a bug filed for the missing APIs?

 -Original Message-
 From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
 Sent: Thursday, October 17, 2013 1:21 PM
 To: dev@cloudstack.apache.org
 Subject: RE: Incomplete API docs?


 +1

 Radhika on the 4.3 release page I have solicited volunteers for different 
 release activities. Looks like the high level tasks could use a better 
 breakdown, do you want to take a stab at breaking doc into sub tasks and 
 folks interested can fill in their name.

 Animesh

 -Original Message-
 From: Radhika Puthiyetath [mailto:radhika.puthiyet...@citrix.com]
 Sent: Wednesday, October 16, 2013 3:24 AM
 To: dev@cloudstack.apache.org
 Subject: RE: Incomplete API docs?

 Hi All,

 Our API documentation requires a serious refurbishment.

 How about creating a doc sprint for enhancing API documentation ?

 I am in the process of setting up a Wiki page at 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Documentation+
 S
 pr
 int+for+Enhancing+API+Documentation to track this activity. Feel free 
 int+for+Enhancing+API+to
 add/ edit/ remove the page content.

 I request all of you to volunteer so that we will have a 
 comprehensive API doc set by next release.

 Appreciate your feedback.

 Regards
 -Radhika



 -Original Message-
 From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
 Sent: Wednesday, October 16, 2013 7:36 AM
 To: dev@cloudstack.apache.org
 Subject: RE: Incomplete API docs?

 Demetrius do you mind creating an issue in JIRA?

  -Original Message-
  From: Alena Prokharchyk [mailto:alena.prokharc...@citrix.com]
  Sent: Tuesday, October 15, 2013 5:15 PM
  To: dev@cloudstack.apache.org
  Subject: Re: Incomplete API docs?
 
  The commands.xml generated as a result of mvn build (mvn clean 
  install
  - P developer,systemvm -DskipTests), doesn't include the commands 
  mentioned by Demetrius. Looks like some regression bug in 
  ApiXmlDocWriter - it used to include all the commands in 3.0.x 
  version of the code.
 
  -Alena.
 
  From: Demetrius Tsitrelis
  dtsitre...@live.commailto:dtsitre...@live.com
  Reply-To:
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
  dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
  Date: Tuesday, October 15, 2013 4:33 PM
  To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
  dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
  Subject: Incomplete API docs?
 
 
 
  I grep'ed the source code and came up with a list of the APIs which 
  the UI uses.  That list is at the end of this message.
  You can see that many of them (addNetscalerLoadBalancer, 
  addVmwareDc,
  etc.) are not in the generated API documentation which appears at 
  http://cloudstack.apache.org/docs/api/apidocs-4.2/TOC_Root_Admin.ht
  m
  l
 
 
  Is this something wrong with the input files or is a tool at fault?
 
 
  Here's the list of APIs used by the UI:
 
  activateProject
 
  addAccountToProject
 
  addBaremetalDhcp
 
  addBaremetalPxeKickStartServer
 
  addCluster
 
  addHost
 
  addImageStore
 
  addIpToNic
 
  addLdapConfiguration
 
  addNetscalerLoadBalancer
 
  addNetworkServiceProvider
 
  addNicToVirtualMachine
 
  addRegion
 
  addTrafficType
 
  addUcsManager
 
  addVmwareDc
 
  addVpnUser
 
  archiveAlerts
 
  archiveEvents
 
  assignToGlobalLoadBalancerRule
 
  assignToLoadBalancerRule
 
  assignVirtualMachine
 
  associateIpAddress
 
  associateUcsProfileToBlade
 
  attachIso
 
  attachVolume
 
  authorizeSecurityGroupEgress
 
  authorizeSecurityGroupIngress
 
  cancelHostMaintenance
 
  cancelStorageMaintenance
 
  configureInternalLoadBalancerElement
 
  configureVirtualRouterElement
 
  copyIso
 
  copyTemplate
 
  createAccount
 
  createAffinityGroup
 
  createAutoScalePolicy
 
  createAutoScaleVmGroup
 
  createAutoScaleVmProfile
 
  createCondition
 
  createDiskOffering
 
  createDomain
 
  createEgressFirewallRule
 
  createFirewallRule
 
  createGlobalLoadBalancerRule
 
  createIpForwardingRule
 
  createLBHealthCheckPolicy
 
  createLBStickinessPolicy
 
  createLoadBalancer
 
  createLoadBalancerRule
 
  createNetwork
 
  createNetworkACL
 
  createNetworkACLList
 
  createNetworkOffering
 
  createPhysicalNetwork
 
  createPod
 
  createPortableIpRange
 
  createPortForwardingRule
 
  createPrivateGateway
 
  createProject
 
  createRemoteAccessVpn
 
  createSecondaryStagingStore
 
  createSecurityGroup
 
  createServiceOffering
 
  createSnapshot
 
  createSnapshotPolicy
 
  createStaticRoute
 
  createStorageNetworkIpRange
 
  createStoragePool
 
  createTags
 
  

Re: Review Request 14782: [CLOUDSTACK-4910] Take VM snapshot instantly returns success regardless of actual result

2013-10-21 Thread Brian Federle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14782/#review27252
---

Ship it!


Ship It!

- Brian Federle


On Oct. 21, 2013, 3:27 p.m., Chris Suich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14782/
 ---
 
 (Updated Oct. 21, 2013, 3:27 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Fixed a typo causing vm snapshot requests to always instantly return 
 successful in the CloudStack UI.
 
 
 Diffs
 -
 
   ui/scripts/instances.js 41d1772 
 
 Diff: https://reviews.apache.org/r/14782/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Chris Suich
 




Re: Review Request 14782: [CLOUDSTACK-4910] Take VM snapshot instantly returns success regardless of actual result

2013-10-21 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14782/#review27253
---


Commit 5c5326f6f710932afc121fd2528681933c716bdc in branch refs/heads/master 
from Chris Suich
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5326f ]

CLOUDSTACK-4910 Fixed issue with Take VM Snapshot UI always returning success


- ASF Subversion and Git Services


On Oct. 21, 2013, 3:27 p.m., Chris Suich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14782/
 ---
 
 (Updated Oct. 21, 2013, 3:27 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Fixed a typo causing vm snapshot requests to always instantly return 
 successful in the CloudStack UI.
 
 
 Diffs
 -
 
   ui/scripts/instances.js 41d1772 
 
 Diff: https://reviews.apache.org/r/14782/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Chris Suich
 




[VOTE] Accept the donation of RDP client code into Apache CloudStack

2013-10-21 Thread Donal Lafferty
As stated in a previous thread [1], Citrix is proposing the donation of source 
for an RDP client.  After donation, the client would be integrated with the 
console system VM in order to provide access to Hyper-V based VMs.

The client's source is in the diff attached to the Review Board submission 
https://reviews.apache.org/r/14701/

[1] http://markmail.org/thread/q6sfqrhosmirm3bg

I would like to call a vote here, so that we have a formal consensus on 
accepting the code into the project.  I suggest that it be accepted into a 
branch, and then we work through any technical concerns / reviews / changes 
prior to a master branch merge.

VOTING will be left open for 72 hours.

This is a technical decision, which means committer and PMC votes are binding.


DL



[ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Chip Childers
The Project Management Committee (PMC) for Apache CloudStack has asked
Animesh Chaturvedi to join the PMC and we are pleased to announce that they
have accepted.

Join me in congratulating Animesh!

-The CloudStack PMC


Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Hugo Trippaers
Congrats Animesh!

Cheers,

Hugo

On 21 okt. 2013, at 20:01, Chip Childers chipchild...@apache.org wrote:

 The Project Management Committee (PMC) for Apache CloudStack has asked
 Animesh Chaturvedi to join the PMC and we are pleased to announce that they
 have accepted.
 
 Join me in congratulating Animesh!
 
 -The CloudStack PMC



Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-10-21 Thread Mike Tutkowski
Hey Marcus,

Just wanted to let you know the branch of mine that has your code and mine
appears to work well with regards to attaching a data disk to a running VM:

fdisk -l from hypervisor:

http://i.imgur.com/NkP5fo0.png

fdisk -l from within VM:

http://i.imgur.com/8YwiiC7.png

I plan to do more testing on this over the coming days.

If all goes well, perhaps we can check this code in by the end of the week?

Talk to you later,
Mike


On Sun, Oct 20, 2013 at 10:23 PM, Mike Tutkowski 
mike.tutkow...@solidfire.com wrote:

 Don't ask me, but it works now (I've been having this trouble quite a
 while today).

 I guess the trick is to send you an e-mail. :)


 On Sun, Oct 20, 2013 at 10:05 PM, Marcus Sorensen shadow...@gmail.comwrote:

 Did you create a service offering that uses local storage, or add a
 shared primary storage? By default there is no storage that matches the
 built in offerings.
 On Oct 20, 2013 9:39 PM, Mike Tutkowski mike.tutkow...@solidfire.com
 wrote:

 Hey Marcus,

 So, I went back to the branch of mine that has your code and mine and
 was able to create a new CloudStack install from scratch with it (once
 again, after manually deleting what was in /var/lib/libvirt/images to the
 get system VMs to start).

 Anyways, my system VMs are running now and I tried to kick off a VM
 using the CentOS 6.3 image you provided me a while back.

 The virtual router has a Status of Running; however, my VM fails to
 start (with the generic message of Insufficient Capacity).

 I've not seen this exception before (related to the VR). Do you have any
 insight into this?:

 com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] is
 unreachable: Unable to apply userdata and password entry on router
  at
 com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkApplianceManagerImpl.java:3793)
 at
 com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkApplianceManagerImpl.java:3017)
  at
 com.cloud.network.element.VirtualRouterElement.addPasswordAndUserdata(VirtualRouterElement.java:933)
 at
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareElement(NetworkOrchestrator.java:1172)
  at
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareNic(NetworkOrchestrator.java:1288)
 at
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepare(NetworkOrchestrator.java:1224)
  at
 com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:826)
 at
 com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:508)
  at
 org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VMEntityManagerImpl.java:227)
 at
 org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMachineEntityImpl.java:209)
  at
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3338)
 at
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2919)
  at
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2905)
 at
 com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
  at
 org.apache.cloudstack.api.command.user.vm.DeployVMCmd.execute(DeployVMCmd.java:421)
 at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161)
  at
 com.cloud.api.ApiAsyncJobDispatcher.runJobInContext(ApiAsyncJobDispatcher.java:109)
 at
 com.cloud.api.ApiAsyncJobDispatcher$1.run(ApiAsyncJobDispatcher.java:66)
  at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
 at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
  at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
 at
 com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:63)
  at
 org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$1.runInContext(AsyncJobManagerImpl.java:532)
 at
 org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
  at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
 at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
  at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
 at
 org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
  at
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
 at java.util.concurrent.FutureTask.run(FutureTask.java:262)
  at
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 at
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
  at 

Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Wei ZHOU
Congratulations!


2013/10/21 Chip Childers chipchild...@apache.org

 The Project Management Committee (PMC) for Apache CloudStack has asked
 Animesh Chaturvedi to join the PMC and we are pleased to announce that they
 have accepted.

 Join me in congratulating Animesh!

 -The CloudStack PMC



Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Mike Tutkowski
Congratulations, Animesh!


On Mon, Oct 21, 2013 at 1:17 PM, Wei ZHOU ustcweiz...@gmail.com wrote:

 Congratulations!


 2013/10/21 Chip Childers chipchild...@apache.org

  The Project Management Committee (PMC) for Apache CloudStack has asked
  Animesh Chaturvedi to join the PMC and we are pleased to announce that
 they
  have accepted.
 
  Join me in congratulating Animesh!
 
  -The CloudStack PMC
 




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


Re: [Discuss] Donation of RDP client code

2013-10-21 Thread Chip Childers
On Mon, Oct 21, 2013 at 2:27 PM, Donal Lafferty
donal.laffe...@citrix.com wrote:
 Hi Ram,

 The next step is to have the community decide on the donation.

 Therefore, I have sent out an email to kick off the VOTE for accepting the 
 code into a separate branch from master.


 DL

Awesome.  Thanks Donal.  That's exactly what I was going to ask you to do!


Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Ahmad Emneina
Congrats Animesh. Your contributions to 4.2 were tremendous... Looking
forward to more great things!
On Oct 21, 2013 12:06 PM, Chip Childers chipchild...@apache.org wrote:

 The Project Management Committee (PMC) for Apache CloudStack has asked
 Animesh Chaturvedi to join the PMC and we are pleased to announce that they
 have accepted.

 Join me in congratulating Animesh!

 -The CloudStack PMC



Can't add shared network with public IPs

2013-10-21 Thread Denis Finko
Hello CloudStack community,

Could you please help me investigate following issue. I am tring to add
new network in CloudStack4.1 with vmware via API call.
For doing this I have use:

- DefaultSharedNetworkOffering
- public IP address range
- api call

http://cs-manage41.ourdomain.com:8080/client/api?
command=createNetwork
gateway=xx.xxx.xxx.1
netmask=255.255.255.0
displaytext=CS_Default_network
name=CS
networkofferingid=eedfa08e-c2a2-4392-b561-45b1a7dd9968
zoneid=ddefc1dd-187a-4849-94d6-ac0466b905bd
cidr=xx.xxx.xxx.0/24
vlan=3
apiKey=i1HtdAADSs4P5fMyGmPTPdpmtcHUtXRNnDdCaxepBm9n3URrpdYWehzXO85qI5l3MMcG_9UW8MkWgU6vn39UdA
sessionkey=4ruxkWEF6PSRaxrrUVoGBq0bH1M%3D_=1382752053469

Network was successfully added. But when I go to: CloudStack GI --
Network --  click on created network -- View IP Addresses -- Acquire
New IP
I get error: The owner of the network is not the same as owner of the IP

2013-10-21 15:26:05,824 ERROR [cloud.async.AsyncJobManagerImpl]
(Job-Executor-4:job-30) Unexpected exception while executing
org.apache.cloudstack.api.command.user.address.AssociateIPAddrCmd
com.cloud.exception.InvalidParameterValueException: The owner of the
network is not the same as owner of the IP
at
com.cloud.network.NetworkManagerImpl.associateIPToGuestNetwork(NetworkManagerImpl.java:744)
at
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at
com.cloud.network.NetworkServiceImpl.associateIPToNetwork(NetworkServiceImpl.java:2852)
at
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at
org.apache.cloudstack.api.command.user.address.AssociateIPAddrCmd.execute(AssociateIPAddrCmd.java:244)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:162)
at
com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:437)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at
java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:679)

Thank you!

-- 
Best regards,

Denis Finko
System Administrator, SA
Ecommerce corporation
www.ecommerce.com



Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread SuichII, Christopher
Congrats, Animesh!

-- 
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco  Red Hat

On Oct 21, 2013, at 3:26 PM, Ahmad Emneina aemne...@gmail.com wrote:

 Congrats Animesh. Your contributions to 4.2 were tremendous... Looking
 forward to more great things!
 On Oct 21, 2013 12:06 PM, Chip Childers chipchild...@apache.org wrote:
 
 The Project Management Committee (PMC) for Apache CloudStack has asked
 Animesh Chaturvedi to join the PMC and we are pleased to announce that they
 have accepted.
 
 Join me in congratulating Animesh!
 
 -The CloudStack PMC
 



Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Min Chen
Congrats, Animesh.

-min

On 10/21/13 12:01 PM, Chip Childers chipchild...@apache.org wrote:

The Project Management Committee (PMC) for Apache CloudStack has asked
Animesh Chaturvedi to join the PMC and we are pleased to announce that
they
have accepted.

Join me in congratulating Animesh!

-The CloudStack PMC



Re: KVM systemvm not getting IP

2013-10-21 Thread Francois Gaudreault
Can someone explain why CS tries to load PremiumSecondaryStorageResource 
on a LXC zone?


2013-10-21 15:37:16,697 DEBUG 
[storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:null) 
VmWare hypervisor configured, telling the ssvm to load the 
PremiumSecondaryStorageResource


I don't even have a VMWare zone anymore in my setup I am still 
having issues with my SSVM/CPVM being killed. Do I need to update 
anything on the systemvm image itself if I use non-oss?


Francois

On 10/15/2013, 5:12 PM, Francois Gaudreault wrote:
Interesting. We built our CS with noredist (nonoss). So I should spin 
the KVM VM image, update the ISO on it, and then recreate the image? 
Did I understand you properly?


Thanks!

Francois

On 10/15/2013, 5:10 PM, Marcus Sorensen wrote:

This has to do with how your cloudstack was built. Are you using
community provided packages? It's looking for the VMWare secondary
storage service, which isn't running.  I forget exactly how to fix it,
but it's something to do with compiling as '-Dnonoss' or '-Dnoredist'.
Something like that. After that you need to reinstall the packages so
that the systemvm.iso gets updated to the new code you compiled.

On Tue, Oct 15, 2013 at 2:50 PM, Francois Gaudreault
fgaudrea...@cloudops.com wrote:

Apparently, the cloud agent is not able to run on the version of the
systemvm I have. This one:
http://download.cloud.com/templates/4.2/systemvmtemplate-2013-06-12-master-kvm.qcow2.bz2 



The error is :
2013-10-15 20:39:25,195 ERROR [cloud.agent.AgentShell] (main:null) 
Unable to

start agent: Resource class not found:
com.cloud.storage.resource.PremiumSecondaryStorageResource due to:
java.lang.ClassNotFoundException:
com.cloud.storage.resource.PremiumSecondaryStorageResource

After couple time, the VM is killed by CloudStack. I should precise 
I am

running an LXC zone (I understand this type requires the KVM image for
systemvm).

Francois


On 10/12/2013, 10:13 AM, Francois Gaudreault wrote:
I got the new template, and the VMs are having IPs now. One thing 
fixed :)


My other problem is regarding libvirt/qemu. My VMs are killed 
randomly :S


Francois

On 10/11/2013, 10:23 PM, Rajesh Battala wrote:
Acton template won't work. In 4.2 there is a new template. You can 
check

it by checking the release version of it.
4.2  systemvm is generated from debian wheezy.

Thanks
Rajesh Battala

-Original Message-
From: Francois Gaudreault [mailto:fgaudrea...@cloudops.com]
Sent: Friday, October 11, 2013 9:48 PM
To: dev@cloudstack.apache.org
Subject: Re: KVM systemvm not getting IP

Hmm... How do I know if I am using the old or new :P

I downloaded this one:

http://download.cloud.com/templates/acton/acton-systemvm-02062012.qcow2.bz2 



FG

On 10/11/2013, 12:12 PM, Rajesh Battala wrote:

Hi Francois,
Are you using the new systemvm template.
System vm's ip's info (boot args) are passed via socket in 4.2. 
Please

check whether you are using new or old systemvm template.

Thanks
Rajesh Battala

-Original Message-
From: Francois Gaudreault [mailto:fgaudrea...@cloudops.com]
Sent: Friday, October 11, 2013 8:30 PM
To: dev@cloudstack.apache.org
Subject: KVM systemvm not getting IP

Anyone faced an issue where the KVM system VM doesn't set IPs on the
network interfaces? In fact there is no interfaces definitions in
/etc/network/interfaces.

I am using CS 4.2. I re-installed my host to use Ubuntu 13.04 (I 
have

the same behavior on CentOS 6).

--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_




--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_







--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_









--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_



Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread La Motta, David
Awesome! Congrats, Animesh.


David La Motta
Technical Marketing Engineer - Citrix Solutions | NetApp
Direct: 1.919.476.5042



On 10/21/13 3:01 PM, Chip Childers chipchild...@apache.org wrote:

The Project Management Committee (PMC) for Apache CloudStack has asked
Animesh Chaturvedi to join the PMC and we are pleased to announce that
they
have accepted.

Join me in congratulating Animesh!

-The CloudStack PMC



Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Nitin Mehta

Congrats Animesh.

On 21/10/13 12:51 PM, La Motta, David david.lamo...@netapp.com wrote:

Awesome! Congrats, Animesh.


David La Motta
Technical Marketing Engineer - Citrix Solutions | NetApp
Direct: 1.919.476.5042



On 10/21/13 3:01 PM, Chip Childers chipchild...@apache.org wrote:

The Project Management Committee (PMC) for Apache CloudStack has asked
Animesh Chaturvedi to join the PMC and we are pleased to announce that
they
have accepted.

Join me in congratulating Animesh!

-The CloudStack PMC




LXC and SSVM/CPVM on the host

2013-10-21 Thread Francois Gaudreault
Ok I think we have to look at this further. I'll stop hijacking other 
threads.


I am trying to get the SSVM/CPVM to run on a LXC host. The SSVM/CPVM 
starts, get IPs, but then CloudStack kill them for some reason. Yes, I 
use the 4.2 images :


2013-10-21 16:19:21,605 DEBUG [agent.manager.AgentManagerImpl] 
(AgentManager-Handler-9:null) SeqA 73--1: Processing Seq 73--1:  { Cmd , 
MgmtId: -1, via: 73, Ver: v1, Flags: 111, 
[{com.cloud.agent.api.ShutdownCommand:{reason:sig.kill,wait:0}}] }
2013-10-21 16:19:21,605 INFO  [agent.manager.AgentManagerImpl] 
(AgentManager-Handler-9:null) Host 73 has informed us that it is 
shutting down with reason sig.kill and detail null
2013-10-21 16:19:21,606 INFO  [agent.manager.AgentManagerImpl] 
(AgentTaskPool-11:null) Host 73 is disconnecting with event 
ShutdownRequested
2013-10-21 16:19:21,609 DEBUG [agent.manager.AgentManagerImpl] 
(AgentTaskPool-11:null) The next status of agent 73is Disconnected, 
current status is Up
2013-10-21 16:19:21,609 DEBUG [agent.manager.AgentManagerImpl] 
(AgentTaskPool-11:null) Deregistering link for 73 with state Disconnected
2013-10-21 16:19:21,609 DEBUG [agent.manager.AgentManagerImpl] 
(AgentTaskPool-11:null) Remove Agent : 73
2013-10-21 16:19:21,609 DEBUG [agent.manager.ConnectedAgentAttache] 
(AgentTaskPool-11:null) Processing Disconnect.


I transferred the host to KVM, and now the same SSVM/CPVM images are 
running fine for the last 30min ( so I assume it works fine...). 
Something seems to be wrong with the LXC side :S


Anyone wants to invest some time to troubleshoot? I'll open a ticket also.

--
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_



RE: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Prachi Damle
Congrats Animesh!

-Original Message-
From: Nitin Mehta [mailto:nitin.me...@citrix.com] 
Sent: Monday, October 21, 2013 1:09 PM
To: dev@cloudstack.apache.org
Subject: Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi


Congrats Animesh.

On 21/10/13 12:51 PM, La Motta, David david.lamo...@netapp.com wrote:

Awesome! Congrats, Animesh.


David La Motta
Technical Marketing Engineer - Citrix Solutions | NetApp
Direct: 1.919.476.5042



On 10/21/13 3:01 PM, Chip Childers chipchild...@apache.org wrote:

The Project Management Committee (PMC) for Apache CloudStack has asked 
Animesh Chaturvedi to join the PMC and we are pleased to announce that 
they have accepted.

Join me in congratulating Animesh!

-The CloudStack PMC




RE: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Frank Zhang
Congrats Animesh! You deserve it! 

 -Original Message-
 From: Prachi Damle [mailto:prachi.da...@citrix.com]
 Sent: Monday, October 21, 2013 2:24 PM
 To: dev@cloudstack.apache.org
 Subject: RE: [ANNOUNCE] New PMC member: Animesh Chaturvedi
 
 Congrats Animesh!
 
 -Original Message-
 From: Nitin Mehta [mailto:nitin.me...@citrix.com]
 Sent: Monday, October 21, 2013 1:09 PM
 To: dev@cloudstack.apache.org
 Subject: Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi
 
 
 Congrats Animesh.
 
 On 21/10/13 12:51 PM, La Motta, David david.lamo...@netapp.com
 wrote:
 
 Awesome! Congrats, Animesh.
 
 
 David La Motta
 Technical Marketing Engineer - Citrix Solutions | NetApp
 Direct: 1.919.476.5042
 
 
 
 On 10/21/13 3:01 PM, Chip Childers chipchild...@apache.org wrote:
 
 The Project Management Committee (PMC) for Apache CloudStack has
 asked
 Animesh Chaturvedi to join the PMC and we are pleased to announce that
 they have accepted.
 
 Join me in congratulating Animesh!
 
 -The CloudStack PMC
 



[Merge]pluggable_vm_snapshot branch

2013-10-21 Thread Edison Su
Hi All,
Per discussion on the thread: http://markmail.org/message/ybw2yy5snkvkuc57, 
we decide to use coarse-graind interface to make taking vm snapshot pluggable. 
On pluggable_vm_snapshot, a new interface is added:

public interface VMSnapshotStrategy {
VMSnapshot takeVMSnapshot(VMSnapshot vmSnapshot);
boolean deleteVMSnapshot(VMSnapshot vmSnapshot);
boolean revertVMSnapshot(VMSnapshot vmSnapshot);
boolean canHandle(VMSnapshot vmSnapshot);
}

Any vendor can implement this interface to customize vm snapshot procedure.
Unit test is added.
If no objection, I'd like to merge it into master. Comments/feedback are 
welcome, thanks!


RE: [VOTE] Accept the donation of RDP client code into Apache CloudStack

2013-10-21 Thread Animesh Chaturvedi
+1

 -Original Message-
 From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
 Sent: Monday, October 21, 2013 11:12 AM
 To: dev@cloudstack.apache.org
 Subject: [VOTE] Accept the donation of RDP client code into Apache
 CloudStack
 
 As stated in a previous thread [1], Citrix is proposing the donation of
 source for an RDP client.  After donation, the client would be
 integrated with the console system VM in order to provide access to
 Hyper-V based VMs.
 
 The client's source is in the diff attached to the Review Board
 submission https://reviews.apache.org/r/14701/
 
 [1] http://markmail.org/thread/q6sfqrhosmirm3bg
 
 I would like to call a vote here, so that we have a formal consensus on
 accepting the code into the project.  I suggest that it be accepted into
 a branch, and then we work through any technical concerns / reviews /
 changes prior to a master branch merge.
 
 VOTING will be left open for 72 hours.
 
 This is a technical decision, which means committer and PMC votes are
 binding.
 
 
 DL



Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-10-21 Thread Mike Tutkowski
Hey Marcus,

So...now that this works well for data disks, I was wondering what might be
involved in getting this process to work for root disks.

Can you point me in the right direction as far as what gets invoked when a
VM is being created on KVM (so that its root disk can be created and the
necessary template laid down or ISO installed)?

Thanks!


On Mon, Oct 21, 2013 at 1:14 PM, Mike Tutkowski 
mike.tutkow...@solidfire.com wrote:

 Hey Marcus,

 Just wanted to let you know the branch of mine that has your code and mine
 appears to work well with regards to attaching a data disk to a running VM:

 fdisk -l from hypervisor:

 http://i.imgur.com/NkP5fo0.png

 fdisk -l from within VM:

 http://i.imgur.com/8YwiiC7.png

 I plan to do more testing on this over the coming days.

 If all goes well, perhaps we can check this code in by the end of the week?

 Talk to you later,
 Mike


 On Sun, Oct 20, 2013 at 10:23 PM, Mike Tutkowski 
 mike.tutkow...@solidfire.com wrote:

 Don't ask me, but it works now (I've been having this trouble quite a
 while today).

 I guess the trick is to send you an e-mail. :)


 On Sun, Oct 20, 2013 at 10:05 PM, Marcus Sorensen shadow...@gmail.comwrote:

 Did you create a service offering that uses local storage, or add a
 shared primary storage? By default there is no storage that matches the
 built in offerings.
 On Oct 20, 2013 9:39 PM, Mike Tutkowski mike.tutkow...@solidfire.com
 wrote:

 Hey Marcus,

 So, I went back to the branch of mine that has your code and mine and
 was able to create a new CloudStack install from scratch with it (once
 again, after manually deleting what was in /var/lib/libvirt/images to the
 get system VMs to start).

 Anyways, my system VMs are running now and I tried to kick off a VM
 using the CentOS 6.3 image you provided me a while back.

 The virtual router has a Status of Running; however, my VM fails to
 start (with the generic message of Insufficient Capacity).

 I've not seen this exception before (related to the VR). Do you have
 any insight into this?:

 com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] is
 unreachable: Unable to apply userdata and password entry on router
  at
 com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkApplianceManagerImpl.java:3793)
 at
 com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkApplianceManagerImpl.java:3017)
  at
 com.cloud.network.element.VirtualRouterElement.addPasswordAndUserdata(VirtualRouterElement.java:933)
 at
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareElement(NetworkOrchestrator.java:1172)
  at
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareNic(NetworkOrchestrator.java:1288)
 at
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepare(NetworkOrchestrator.java:1224)
  at
 com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:826)
 at
 com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:508)
  at
 org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VMEntityManagerImpl.java:227)
 at
 org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMachineEntityImpl.java:209)
  at
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3338)
 at
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2919)
  at
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2905)
 at
 com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
  at
 org.apache.cloudstack.api.command.user.vm.DeployVMCmd.execute(DeployVMCmd.java:421)
 at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:161)
  at
 com.cloud.api.ApiAsyncJobDispatcher.runJobInContext(ApiAsyncJobDispatcher.java:109)
 at
 com.cloud.api.ApiAsyncJobDispatcher$1.run(ApiAsyncJobDispatcher.java:66)
  at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
 at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
  at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
 at
 com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:63)
  at
 org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$1.runInContext(AsyncJobManagerImpl.java:532)
 at
 org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
  at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
 at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
  at
 

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-10-21 Thread Marcus Sorensen
Do you have the capability to clone the root disk? Normally the
template is installed to primary, and then cloned for each root disk.
In some cases (such as CLVM), this isn't efficient and so the template
is copied fresh to populate each root disk.

I'm actually not 100% sure how this works in the new code. It used to
be handled by copyPhysicalDisk in the storage adaptor, called by
copyTemplateToPrimaryStorage, which runs on the agent. It would pass
template/secondary storage info, and the destination volume/primary
storage info, and copyPhysicalDisk would do the work of installing the
image to the destination.  Then subsequent root disks would be cloned
in CreateCommand by calling createDiskFromTemplate.

In master it looks like this was moved to KVMStorageProcessor
'cloneVolumeFromBaseTemplate', although I think this just takes over
as default, and there's something in your storage driver that should
be capable of cloning templates on the mgmt server side. I'm less sure
about how the template gets to primary storage in the first place, I
assume copyTemplateToPrimaryStorage in KVMStorageProcessor calling
copyPhysicalDisk in your adaptor. It's a bit tough for me to tell
since our earlier storage adaptor did everything on the host it mostly
just worked with the default stuff.

On Mon, Oct 21, 2013 at 4:49 PM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
 Hey Marcus,

 So...now that this works well for data disks, I was wondering what might be
 involved in getting this process to work for root disks.

 Can you point me in the right direction as far as what gets invoked when a
 VM is being created on KVM (so that its root disk can be created and the
 necessary template laid down or ISO installed)?

 Thanks!


 On Mon, Oct 21, 2013 at 1:14 PM, Mike Tutkowski
 mike.tutkow...@solidfire.com wrote:

 Hey Marcus,

 Just wanted to let you know the branch of mine that has your code and mine
 appears to work well with regards to attaching a data disk to a running VM:

 fdisk -l from hypervisor:

 http://i.imgur.com/NkP5fo0.png

 fdisk -l from within VM:

 http://i.imgur.com/8YwiiC7.png

 I plan to do more testing on this over the coming days.

 If all goes well, perhaps we can check this code in by the end of the
 week?

 Talk to you later,
 Mike


 On Sun, Oct 20, 2013 at 10:23 PM, Mike Tutkowski
 mike.tutkow...@solidfire.com wrote:

 Don't ask me, but it works now (I've been having this trouble quite a
 while today).

 I guess the trick is to send you an e-mail. :)


 On Sun, Oct 20, 2013 at 10:05 PM, Marcus Sorensen shadow...@gmail.com
 wrote:

 Did you create a service offering that uses local storage, or add a
 shared primary storage? By default there is no storage that matches the
 built in offerings.

 On Oct 20, 2013 9:39 PM, Mike Tutkowski mike.tutkow...@solidfire.com
 wrote:

 Hey Marcus,

 So, I went back to the branch of mine that has your code and mine and
 was able to create a new CloudStack install from scratch with it (once
 again, after manually deleting what was in /var/lib/libvirt/images to the
 get system VMs to start).

 Anyways, my system VMs are running now and I tried to kick off a VM
 using the CentOS 6.3 image you provided me a while back.

 The virtual router has a Status of Running; however, my VM fails to
 start (with the generic message of Insufficient Capacity).

 I've not seen this exception before (related to the VR). Do you have
 any insight into this?:

 com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] is
 unreachable: Unable to apply userdata and password entry on router
 at
 com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkApplianceManagerImpl.java:3793)
 at
 com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkApplianceManagerImpl.java:3017)
 at
 com.cloud.network.element.VirtualRouterElement.addPasswordAndUserdata(VirtualRouterElement.java:933)
 at
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareElement(NetworkOrchestrator.java:1172)
 at
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareNic(NetworkOrchestrator.java:1288)
 at
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepare(NetworkOrchestrator.java:1224)
 at
 com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:826)
 at
 com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:508)
 at
 org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VMEntityManagerImpl.java:227)
 at
 org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMachineEntityImpl.java:209)
 at
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3338)
 at
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2919)
 at
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2905)
 at
 

access instance's console using apikey failed

2013-10-21 Thread yao hu
I compiled cloudstack 4.1.1 source code in cygwin, then test it using
jetty, it works fine. But, when I access instance's console through vnc
using apikey, it fails, the browser shows the follow message:
Access denied. Invalid web session or API key in request

my url:
http://localhost:8080/client/console?cmd=accessvm=b194369f-e0d4-45d8-a50f-09ec51095e68apikey=fmS7oyThP6MGxN5X_CgeOCxQIqgTu5QFDz46r2Pv5kLp88EYYBquSu6_3s3d9MXdbUHPpxj5qDDy1jvhEpQWvQsignature=y3dNHn580NJiCVRGwrBTR4JHImo%3D

I test the listAccounts api, it's ok.
my url:
http://localhost:8080/client/api?command=listAccountsapikey=fmS7oyThP6MGxN5X_CgeOCxQIqgTu5QFDz46r2Pv5kLp88EYYBquSu6_3s3d9MXdbUHPpxj5qDDy1jvhEpQWvQsignature=ALhJtw%2Bzi7Rcmo%2Bkk3xH3cTJgp4%3D

then, I debug the source code, find where it fails.
file: ConsoleProxyServlet.java
private boolean verifyRequest(MapString, Object[] requestParameters) {
try {
...
...

unsignedRequest = unsignedRequest.toLowerCase();

Mac mac = Mac.getInstance(HmacSHA1);
SecretKeySpec keySpec = new SecretKeySpec(secretKey.getBytes(),
HmacSHA1);
mac.init(keySpec);
mac.update(unsignedRequest.getBytes());
byte[] encryptedBytes = mac.doFinal();
String computedSignature =
Base64.encodeBase64URLSafeString(encryptedBytes);
boolean equalSig = signature.equals(computedSignature);
if (!equalSig) {
s_logger.debug(User signature:  + signature +  is not equaled to
computed signature:  + computedSignature);
}
...
...
return equalSig;
} catch (Exception ex) {
s_logger.error(unable to verifty request signature, ex);
}
return false;
}

in this method, signature not equals to computedSignature, so it returns
false


then, I view ApiServer.java,the verifyRequest method:
public boolean verifyRequest(MapString, Object[] requestParameters, Long
userId) throws ServerApiException {
try {
...
...

unsignedRequest = unsignedRequest.toLowerCase();

Mac mac = Mac.getInstance(HmacSHA1);
SecretKeySpec keySpec = new SecretKeySpec(secretKey.getBytes(),
HmacSHA1);
mac.init(keySpec);
mac.update(unsignedRequest.getBytes());
byte[] encryptedBytes = mac.doFinal();
String computedSignature = Base64.encodeBase64String(encryptedBytes);
boolean equalSig = signature.equals(computedSignature);
if (!equalSig) {
s_logger.debug(User signature:  + signature +  is not equaled to
computed signature:  + computedSignature);
}
...
...
return equalSig;
} catch (Exception ex) {
s_logger.error(unable to verifty request signature, ex);
}
return false;
}

these two verifyRequest method produce different signature, because the
former use :
String computedSignature =
Base64.encodeBase64URLSafeString(encryptedBytes);

while the later use:
String computedSignature = Base64.encodeBase64String(encryptedBytes);

this is why listAccouts works fine, but vnc console is failed.

when I replace Base64.encodeBase64URLSafeString by
Base64.encodeBase64String, vnc console is ok too.


so I am confused, why use different encode method? It is a bug?


Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Go Chiba
Congrats, Animesh!


On Tue, Oct 22, 2013 at 4:01 AM, Chip Childers chipchild...@apache.orgwrote:

 The Project Management Committee (PMC) for Apache CloudStack has asked
 Animesh Chaturvedi to join the PMC and we are pleased to announce that they
 have accepted.

 Join me in congratulating Animesh!

 -The CloudStack PMC




-- 
千葉 豪  Go Chiba
E-mail:go.ch...@gmail.com


Review Request 14823: Refactor StrategyPriority

2013-10-21 Thread Darren Shepherd

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14823/
---

Review request for cloudstack, Chris Suich and edison su.


Repository: cloudstack-git


Description
---

I specifically ran into a problem in the spring modularization branch with 
StrategyPriority.sortStrategies().  The lists of strategies are unmodifiable 
collections so Collection.sort() can not be used.  I went to do a quick fix for 
this but then decided to try remove the duplicated logic in each code that 
needs a SnapshotStrategy or DataMotionStrategy and then ended up refactoring 
quite a bit.


Diffs
-

  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java
 950f9e2 
  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotStrategy.java
 e4cecb6 
  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StorageStrategyFactory.java
 PRE-CREATION 
  
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
 81034b1 
  
engine/api/test/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
 3d75279 
  
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
 5f5f01e 
  
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java
 2d31320 
  
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 6a874d6 
  
engine/storage/src/org/apache/cloudstack/storage/helper/StorageStrategyFactoryImpl.java
 PRE-CREATION 
  
engine/storage/test/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
 PRE-CREATION 
  
plugins/hypervisors/xen/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java
 8578a9a 
  server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java dade983 

Diff: https://reviews.apache.org/r/14823/diff/


Testing
---


Thanks,

Darren Shepherd



Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)

2013-10-21 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/#review27274
---


Commit f9731144cda4d7982cc4be1e60c1e4aa3b3ca2e2 in branch refs/heads/4.2 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f973114 ]

CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response 
(private key) Changing the response object of register and list ssh keypairs 
APIs

Signed-off-by: Koushik Das kous...@apache.org


- ASF Subversion and Git Services


On Oct. 21, 2013, 5:14 a.m., Harikrishna Patnala wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14305/
 ---
 
 (Updated Oct. 21, 2013, 5:14 a.m.)
 
 
 Review request for cloudstack and Koushik Das.
 
 
 Bugs: CLOUDSTACK-4493
 https://issues.apache.org/jira/browse/CLOUDSTACK-4493
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CLOUDSTACK-4493:  registerSSHKeyPair API doc contains wrong API response 
 (private key) 
 Changing the response object of register and list ssh keypairs APIs
 
 
 Diffs
 -
 
   api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 
 56bec7e 
   api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java 
 PRE-CREATION 
   api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853 
 
 Diff: https://reviews.apache.org/r/14305/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Harikrishna Patnala
 




Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Jayapal Reddy Uradi
Congrats, Animesh!

On 22-Oct-2013, at 8:55 AM, Go Chiba go.ch...@gmail.com wrote:

 Congrats, Animesh!
 
 
 On Tue, Oct 22, 2013 at 4:01 AM, Chip Childers chipchild...@apache.orgwrote:
 
 The Project Management Committee (PMC) for Apache CloudStack has asked
 Animesh Chaturvedi to join the PMC and we are pleased to announce that they
 have accepted.
 
 Join me in congratulating Animesh!
 
 -The CloudStack PMC
 
 
 
 
 -- 
 千葉 豪  Go Chiba
 E-mail:go.ch...@gmail.com



RE: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Sailaja Mada
Congrats Animesh. 

Regards,
Sailaja.M

-Original Message-
From: chip.child...@sungard.com [mailto:chip.child...@sungard.com] On Behalf Of 
Chip Childers
Sent: Tuesday, October 22, 2013 12:31 AM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] New PMC member: Animesh Chaturvedi

The Project Management Committee (PMC) for Apache CloudStack has asked Animesh 
Chaturvedi to join the PMC and we are pleased to announce that they have 
accepted.

Join me in congratulating Animesh!

-The CloudStack PMC


RE: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Radhika Puthiyetath
Congrats, Animesh.

-Original Message-
From: chip.child...@sungard.com [mailto:chip.child...@sungard.com] On Behalf Of 
Chip Childers
Sent: Tuesday, October 22, 2013 12:31 AM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] New PMC member: Animesh Chaturvedi

The Project Management Committee (PMC) for Apache CloudStack has asked Animesh 
Chaturvedi to join the PMC and we are pleased to announce that they have 
accepted.

Join me in congratulating Animesh!

-The CloudStack PMC


RE: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Venkata SwamyBabu B
Congrats Animesh!

-Original Message-
From: Radhika Puthiyetath [mailto:radhika.puthiyet...@citrix.com]
Sent: 22 October 2013 10:24
To: dev@cloudstack.apache.org
Subject: RE: [ANNOUNCE] New PMC member: Animesh Chaturvedi

Congrats, Animesh.

-Original Message-
From: chip.child...@sungard.com [mailto:chip.child...@sungard.com] On
Behalf Of Chip Childers
Sent: Tuesday, October 22, 2013 12:31 AM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] New PMC member: Animesh Chaturvedi

The Project Management Committee (PMC) for Apache CloudStack has asked
Animesh Chaturvedi to join the PMC and we are pleased to announce that
they have accepted.

Join me in congratulating Animesh!

-The CloudStack PMC


Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-10-21 Thread Mike Tutkowski
Thanks for that info, Marcus.

By the way, I wanted to see if I could attach my volume to a VM in the
Stopped State.

The attach logic didn't trigger any exceptions; however, when I started the
VM, I received an Insufficient Capacity exception.

If I detach the volume and then start the VM, the VM starts just fine.

I noticed a problem here (in StoragePoolHostDaoImpl):

@Override

public StoragePoolHostVO findByPoolHost(long poolId, long hostId) {

SearchCriteriaStoragePoolHostVO sc = PoolHostSearch.create();

sc.setParameters(pool_id, poolId);

sc.setParameters(host_id, hostId);

return findOneIncludingRemovedBy(sc);

}
The findOneIncludingRemovedBy method returns null (the poolId is my storage
pool's ID and the hostId is the expected host ID).

I'm not sure what this method is trying to do.

I looked in the storage_pool_host_ref table (is that the correct table?)
and it only has one row, which maps the local storage pool of the KVM host
to the KVM host (which explains why no match is found for my situation).

Do you understand what this logic is trying to do?

Thanks!



On Mon, Oct 21, 2013 at 8:08 PM, Marcus Sorensen shadow...@gmail.comwrote:

 Do you have the capability to clone the root disk? Normally the
 template is installed to primary, and then cloned for each root disk.
 In some cases (such as CLVM), this isn't efficient and so the template
 is copied fresh to populate each root disk.

 I'm actually not 100% sure how this works in the new code. It used to
 be handled by copyPhysicalDisk in the storage adaptor, called by
 copyTemplateToPrimaryStorage, which runs on the agent. It would pass
 template/secondary storage info, and the destination volume/primary
 storage info, and copyPhysicalDisk would do the work of installing the
 image to the destination.  Then subsequent root disks would be cloned
 in CreateCommand by calling createDiskFromTemplate.

 In master it looks like this was moved to KVMStorageProcessor
 'cloneVolumeFromBaseTemplate', although I think this just takes over
 as default, and there's something in your storage driver that should
 be capable of cloning templates on the mgmt server side. I'm less sure
 about how the template gets to primary storage in the first place, I
 assume copyTemplateToPrimaryStorage in KVMStorageProcessor calling
 copyPhysicalDisk in your adaptor. It's a bit tough for me to tell
 since our earlier storage adaptor did everything on the host it mostly
 just worked with the default stuff.

 On Mon, Oct 21, 2013 at 4:49 PM, Mike Tutkowski
 mike.tutkow...@solidfire.com wrote:
  Hey Marcus,
 
  So...now that this works well for data disks, I was wondering what might
 be
  involved in getting this process to work for root disks.
 
  Can you point me in the right direction as far as what gets invoked when
 a
  VM is being created on KVM (so that its root disk can be created and the
  necessary template laid down or ISO installed)?
 
  Thanks!
 
 
  On Mon, Oct 21, 2013 at 1:14 PM, Mike Tutkowski
  mike.tutkow...@solidfire.com wrote:
 
  Hey Marcus,
 
  Just wanted to let you know the branch of mine that has your code and
 mine
  appears to work well with regards to attaching a data disk to a running
 VM:
 
  fdisk -l from hypervisor:
 
  http://i.imgur.com/NkP5fo0.png
 
  fdisk -l from within VM:
 
  http://i.imgur.com/8YwiiC7.png
 
  I plan to do more testing on this over the coming days.
 
  If all goes well, perhaps we can check this code in by the end of the
  week?
 
  Talk to you later,
  Mike
 
 
  On Sun, Oct 20, 2013 at 10:23 PM, Mike Tutkowski
  mike.tutkow...@solidfire.com wrote:
 
  Don't ask me, but it works now (I've been having this trouble quite a
  while today).
 
  I guess the trick is to send you an e-mail. :)
 
 
  On Sun, Oct 20, 2013 at 10:05 PM, Marcus Sorensen shadow...@gmail.com
 
  wrote:
 
  Did you create a service offering that uses local storage, or add a
  shared primary storage? By default there is no storage that matches
 the
  built in offerings.
 
  On Oct 20, 2013 9:39 PM, Mike Tutkowski 
 mike.tutkow...@solidfire.com
  wrote:
 
  Hey Marcus,
 
  So, I went back to the branch of mine that has your code and mine and
  was able to create a new CloudStack install from scratch with it
 (once
  again, after manually deleting what was in /var/lib/libvirt/images
 to the
  get system VMs to start).
 
  Anyways, my system VMs are running now and I tried to kick off a VM
  using the CentOS 6.3 image you provided me a while back.
 
  The virtual router has a Status of Running; however, my VM fails to
  start (with the generic message of Insufficient Capacity).
 
  I've not seen this exception before (related to the VR). Do you have
  any insight into this?:
 
  com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] is
  unreachable: Unable to apply userdata and password entry on router
  at
 
 

RE: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Suresh Sadhu
Congrats.. Animesh.

-Original Message-
From: Radhika Puthiyetath [mailto:radhika.puthiyet...@citrix.com] 
Sent: 22 October 2013 10:24
To: dev@cloudstack.apache.org
Subject: RE: [ANNOUNCE] New PMC member: Animesh Chaturvedi

Congrats, Animesh.

-Original Message-
From: chip.child...@sungard.com [mailto:chip.child...@sungard.com] On Behalf Of 
Chip Childers
Sent: Tuesday, October 22, 2013 12:31 AM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] New PMC member: Animesh Chaturvedi

The Project Management Committee (PMC) for Apache CloudStack has asked Animesh 
Chaturvedi to join the PMC and we are pleased to announce that they have 
accepted.

Join me in congratulating Animesh!

-The CloudStack PMC


Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)

2013-10-21 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14305/#review27276
---


Commit 54e365d00b5ae504c59c025b37387b9c9d166422 in branch refs/heads/master 
from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=54e365d ]

CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response 
(private key) Changing the response object of register and list ssh keypairs 
APIs

Signed-off-by: Koushik Das kous...@apache.org

Conflicts:

api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java


- ASF Subversion and Git Services


On Oct. 21, 2013, 5:14 a.m., Harikrishna Patnala wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/14305/
 ---
 
 (Updated Oct. 21, 2013, 5:14 a.m.)
 
 
 Review request for cloudstack and Koushik Das.
 
 
 Bugs: CLOUDSTACK-4493
 https://issues.apache.org/jira/browse/CLOUDSTACK-4493
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CLOUDSTACK-4493:  registerSSHKeyPair API doc contains wrong API response 
 (private key) 
 Changing the response object of register and list ssh keypairs APIs
 
 
 Diffs
 -
 
   api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 
 56bec7e 
   api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java 
 PRE-CREATION 
   api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853 
 
 Diff: https://reviews.apache.org/r/14305/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Harikrishna Patnala
 




RE: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Devdeep Singh
Congrats Animesh.

Regards,
Devdeep

-Original Message-
From: chip.child...@sungard.com [mailto:chip.child...@sungard.com] On Behalf Of 
Chip Childers
Sent: Tuesday, October 22, 2013 12:31 AM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] New PMC member: Animesh Chaturvedi

The Project Management Committee (PMC) for Apache CloudStack has asked Animesh 
Chaturvedi to join the PMC and we are pleased to announce that they have 
accepted.

Join me in congratulating Animesh!

-The CloudStack PMC


S3 API broken in 4.2

2013-10-21 Thread Darren S
I didn't even know this feature existed until yesterday, so I thought I'd try 
it out, but it seems that the S3 API in CloudStack completely doesn't work in 
4.2.  Is it supposed to?  Is this an official feature or some tech preview type 
thing?

Darren


Re: [MERGE] txn-refactor

2013-10-21 Thread Darren Shepherd
I plan to merge this wed morning unless I or others find issues.  

Darren

 On Oct 17, 2013, at 3:05 PM, Darren Shepherd darren.s.sheph...@gmail.com 
 wrote:
 
 On Thu, Oct 17, 2013 at 12:59 PM, Hugo Trippaers trip...@gmail.com wrote:
 Maybe just mark start() as deprecated then. Would at least put a marker for 
 anybody writing new code that they should think again about using it.
 
 Good idea.
 
 
 A unit test would be really nice to have for this piece of code. Especially 
 now we know there will be changes is this area for some time to come. The DB 
 layer is at the core of CloudStack so a test is a real requirement here. I 
 know there is a bunch of stuff disabled, we decided long ago to fix those 
 tests when we would touch that bit of code, and you just hit the jackpot ;-)
 
 I wrote some tests, I'll commit them in a bit.
 
 Did you have a look at the build link? The current build for your branch 
 appears broken. One test failure and a compile error as far as I can tell.
 
 I had no clue that build-with-branch jenkins jobs existed!  That is
 very useful.  How do I get an account to kick off jobs?  I do feel
 stupid now looking at the build error.  I had some maven projects
 disabled, so I forgot to update about 10 different projects.  I'll fix
 those real quick and commit.
 
 Darren


RE: Can't add shared network with public IPs

2013-10-21 Thread Sanjeev Neelarapu
Its because the API uses system as the user and for UI you might have used 
default admin user.
So while creating network pass account as admin to createNetwork API.

-Sanjeev

-Original Message-
From: Denis Finko [mailto:denis.fi...@ecommerce.com] 
Sent: Tuesday, October 22, 2013 1:05 AM
To: dev@cloudstack.apache.org
Subject: Can't add shared network with public IPs

Hello CloudStack community,

Could you please help me investigate following issue. I am tring to add new 
network in CloudStack4.1 with vmware via API call.
For doing this I have use:

- DefaultSharedNetworkOffering
- public IP address range
- api call

http://cs-manage41.ourdomain.com:8080/client/api?
command=createNetwork
gateway=xx.xxx.xxx.1
netmask=255.255.255.0
displaytext=CS_Default_network
name=CS
networkofferingid=eedfa08e-c2a2-4392-b561-45b1a7dd9968
zoneid=ddefc1dd-187a-4849-94d6-ac0466b905bd
cidr=xx.xxx.xxx.0/24
vlan=3
apiKey=i1HtdAADSs4P5fMyGmPTPdpmtcHUtXRNnDdCaxepBm9n3URrpdYWehzXO85qI5l3MMcG_9UW8MkWgU6vn39UdA
sessionkey=4ruxkWEF6PSRaxrrUVoGBq0bH1M%3D_=1382752053469

Network was successfully added. But when I go to: CloudStack GI -- Network -- 
 click on created network -- View IP Addresses -- Acquire New IP I get 
error: The owner of the network is not the same as owner of the IP

2013-10-21 15:26:05,824 ERROR [cloud.async.AsyncJobManagerImpl]
(Job-Executor-4:job-30) Unexpected exception while executing 
org.apache.cloudstack.api.command.user.address.AssociateIPAddrCmd
com.cloud.exception.InvalidParameterValueException: The owner of the network is 
not the same as owner of the IP
at
com.cloud.network.NetworkManagerImpl.associateIPToGuestNetwork(NetworkManagerImpl.java:744)
at
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at
com.cloud.network.NetworkServiceImpl.associateIPToNetwork(NetworkServiceImpl.java:2852)
at
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at
org.apache.cloudstack.api.command.user.address.AssociateIPAddrCmd.execute(AssociateIPAddrCmd.java:244)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:162)
at
com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:437)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at
java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:679)

Thank you!

--
Best regards,

Denis Finko
System Administrator, SA
Ecommerce corporation
www.ecommerce.com



Re: S3 API broken in 4.2

2013-10-21 Thread Chiradeep Vittal
Yeah, it was always a tech preview kind of thing. The basic operations
used to work, but since most of the available client tools
(s3cmd/boto/etc) had special workarounds for odd AWS behaviors (in the
return behavior), they would have a hard time working with the S3
implementation in CloudStack which was based entirely on the WSDL.

On 10/21/13 10:16 PM, Darren S darren.s.sheph...@gmail.com wrote:

I didn't even know this feature existed until yesterday, so I thought I'd
try it out, but it seems that the S3 API in CloudStack completely doesn't
work in 4.2.  Is it supposed to?  Is this an official feature or some
tech preview type thing?

Darren



Re: [VOTE] Accept the donation of RDP client code into Apache CloudStack

2013-10-21 Thread Chiradeep Vittal
+1

On 10/21/13 11:11 AM, Donal Lafferty donal.laffe...@citrix.com wrote:

As stated in a previous thread [1], Citrix is proposing the donation of
source for an RDP client.  After donation, the client would be integrated
with the console system VM in order to provide access to Hyper-V based
VMs.

The client's source is in the diff attached to the Review Board
submission https://reviews.apache.org/r/14701/

[1] http://markmail.org/thread/q6sfqrhosmirm3bg

I would like to call a vote here, so that we have a formal consensus on
accepting the code into the project.  I suggest that it be accepted into
a branch, and then we work through any technical concerns / reviews /
changes prior to a master branch merge.

VOTING will be left open for 72 hours.

This is a technical decision, which means committer and PMC votes are
binding.


DL




Re: LXC and SSVM/CPVM on the host

2013-10-21 Thread Chiradeep Vittal
As far as I understand, in an LXC scenario, the system vms are expected to
run on real hypervisors.
You can always use the QuickCloud way to not use system vms at all.

On 10/21/13 1:45 PM, Francois Gaudreault fgaudrea...@cloudops.com
wrote:

Ok I think we have to look at this further. I'll stop hijacking other
threads.

I am trying to get the SSVM/CPVM to run on a LXC host. The SSVM/CPVM
starts, get IPs, but then CloudStack kill them for some reason. Yes, I
use the 4.2 images :

2013-10-21 16:19:21,605 DEBUG [agent.manager.AgentManagerImpl]
(AgentManager-Handler-9:null) SeqA 73--1: Processing Seq 73--1:  { Cmd ,
MgmtId: -1, via: 73, Ver: v1, Flags: 111,
[{com.cloud.agent.api.ShutdownCommand:{reason:sig.kill,wait:0}}] }
2013-10-21 16:19:21,605 INFO  [agent.manager.AgentManagerImpl]
(AgentManager-Handler-9:null) Host 73 has informed us that it is
shutting down with reason sig.kill and detail null
2013-10-21 16:19:21,606 INFO  [agent.manager.AgentManagerImpl]
(AgentTaskPool-11:null) Host 73 is disconnecting with event
ShutdownRequested
2013-10-21 16:19:21,609 DEBUG [agent.manager.AgentManagerImpl]
(AgentTaskPool-11:null) The next status of agent 73is Disconnected,
current status is Up
2013-10-21 16:19:21,609 DEBUG [agent.manager.AgentManagerImpl]
(AgentTaskPool-11:null) Deregistering link for 73 with state Disconnected
2013-10-21 16:19:21,609 DEBUG [agent.manager.AgentManagerImpl]
(AgentTaskPool-11:null) Remove Agent : 73
2013-10-21 16:19:21,609 DEBUG [agent.manager.ConnectedAgentAttache]
(AgentTaskPool-11:null) Processing Disconnect.

I transferred the host to KVM, and now the same SSVM/CPVM images are
running fine for the last 30min ( so I assume it works fine...).
Something seems to be wrong with the LXC side :S

Anyone wants to invest some time to troubleshoot? I'll open a ticket also.

-- 
Francois Gaudreault
Architecte de Solution Cloud | Cloud Solutions Architect
fgaudrea...@cloudops.com
514-629-6775
- - -
CloudOps
420 rue Guy
Montréal QC  H3J 1S6
www.cloudops.com
@CloudOps_




Re: [ANNOUNCE] New PMC member: Animesh Chaturvedi

2013-10-21 Thread Bharat Kumar
Congrats Animesh!




Re: [VOTE] Accept the donation of RDP client code into Apache CloudStack

2013-10-21 Thread Ahmad Emneina
+1


On Mon, Oct 21, 2013 at 10:05 PM, Devdeep Singh devdeep.si...@citrix.comwrote:

 +1

 -Original Message-
 From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
 Sent: Monday, October 21, 2013 11:42 PM
 To: dev@cloudstack.apache.org
 Subject: [VOTE] Accept the donation of RDP client code into Apache
 CloudStack

 As stated in a previous thread [1], Citrix is proposing the donation of
 source for an RDP client.  After donation, the client would be integrated
 with the console system VM in order to provide access to Hyper-V based VMs.

 The client's source is in the diff attached to the Review Board submission
 https://reviews.apache.org/r/14701/

 [1] http://markmail.org/thread/q6sfqrhosmirm3bg

 I would like to call a vote here, so that we have a formal consensus on
 accepting the code into the project.  I suggest that it be accepted into a
 branch, and then we work through any technical concerns / reviews / changes
 prior to a master branch merge.

 VOTING will be left open for 72 hours.

 This is a technical decision, which means committer and PMC votes are
 binding.


 DL




Re: [VOTE] Accept the donation of RDP client code into Apache CloudStack

2013-10-21 Thread Wido den Hollander

I'm +0 on this.

I can't fully say if the code is correct or not. I've never used 
Hyper-V, so I don't think it would be wise for me to vote.


Just want to show I saw this VOTE.

Wido

On 10/21/2013 08:11 PM, Donal Lafferty wrote:

As stated in a previous thread [1], Citrix is proposing the donation of source 
for an RDP client.  After donation, the client would be integrated with the 
console system VM in order to provide access to Hyper-V based VMs.

The client's source is in the diff attached to the Review Board submission 
https://reviews.apache.org/r/14701/

[1] http://markmail.org/thread/q6sfqrhosmirm3bg

I would like to call a vote here, so that we have a formal consensus on 
accepting the code into the project.  I suggest that it be accepted into a 
branch, and then we work through any technical concerns / reviews / changes 
prior to a master branch merge.

VOTING will be left open for 72 hours.

This is a technical decision, which means committer and PMC votes are binding.


DL




RE: [VOTE] Accept the donation of RDP client code into Apache CloudStack

2013-10-21 Thread Rajesh Battala
+1 

-Original Message-
From: Donal Lafferty [mailto:donal.laffe...@citrix.com] 
Sent: Monday, October 21, 2013 11:42 PM
To: dev@cloudstack.apache.org
Subject: [VOTE] Accept the donation of RDP client code into Apache CloudStack

As stated in a previous thread [1], Citrix is proposing the donation of source 
for an RDP client.  After donation, the client would be integrated with the 
console system VM in order to provide access to Hyper-V based VMs.

The client's source is in the diff attached to the Review Board submission 
https://reviews.apache.org/r/14701/

[1] http://markmail.org/thread/q6sfqrhosmirm3bg

I would like to call a vote here, so that we have a formal consensus on 
accepting the code into the project.  I suggest that it be accepted into a 
branch, and then we work through any technical concerns / reviews / changes 
prior to a master branch merge.

VOTING will be left open for 72 hours.

This is a technical decision, which means committer and PMC votes are binding.


DL