Re: Review Request 16086: Added a temp sleep fix for vm start command

2013-12-09 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16086/#review29992
---


Can you add more description about why this sleep is required? or add the 
related JIRA bug number to the RB request.

- SrikanteswaraRao Talluri


On Dec. 6, 2013, 6:28 p.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16086/
 ---
 
 (Updated Dec. 6, 2013, 6:28 p.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Added a temporary time sleep fix post a restart command. Applies to 
 4.2,master,4.3
 
 Note: Has to clean other things as well and will do more cleaner way of 
 handling things.
 
 
 Diffs
 -
 
   test/integration/smoke/test_volumes.py 816ae03 
 
 Diff: https://reviews.apache.org/r/16086/diff/
 
 
 Testing
 ---
 
 No.
 
 
 Thanks,
 
 Santhosh Edukulla
 




Re: Review Request 16086: Added a temp sleep fix for vm start command

2013-12-09 Thread Sebastien Goasguen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16086/#review29993
---


what happens if the machine starts only after 31 s ?
Can we have a polling mechanism instead.

- Sebastien Goasguen


On Dec. 6, 2013, 6:28 p.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16086/
 ---
 
 (Updated Dec. 6, 2013, 6:28 p.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Added a temporary time sleep fix post a restart command. Applies to 
 4.2,master,4.3
 
 Note: Has to clean other things as well and will do more cleaner way of 
 handling things.
 
 
 Diffs
 -
 
   test/integration/smoke/test_volumes.py 816ae03 
 
 Diff: https://reviews.apache.org/r/16086/diff/
 
 
 Testing
 ---
 
 No.
 
 
 Thanks,
 
 Santhosh Edukulla
 




Re: Review Request 16086: Added a temp sleep fix for vm start command

2013-12-09 Thread Santhosh Edukulla


 On Dec. 9, 2013, 8:24 a.m., Sebastien Goasguen wrote:
  what happens if the machine starts only after 31 s ?
  Can we have a polling mechanism instead.

1. I mentioned it as part of Note under review description.  Here, i 
mentioned to do more cleaner way once time permits.

2. Actually, this is not a permanent fix. There were other clean ups required 
here. The fix is added when xen team using marvin reported an issue. Sometimes, 
volume is being detached while the VM is still starting up. If we see there is 
no status check for vmstart and post the operation. So, post discussion agreed 
to add up a temp sleep. Thats what even the subject for this review mentions 
temp seep... 


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16086/#review29993
---


On Dec. 6, 2013, 6:28 p.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16086/
 ---
 
 (Updated Dec. 6, 2013, 6:28 p.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Added a temporary time sleep fix post a restart command. Applies to 
 4.2,master,4.3
 
 Note: Has to clean other things as well and will do more cleaner way of 
 handling things.
 
 
 Diffs
 -
 
   test/integration/smoke/test_volumes.py 816ae03 
 
 Diff: https://reviews.apache.org/r/16086/diff/
 
 
 Testing
 ---
 
 No.
 
 
 Thanks,
 
 Santhosh Edukulla
 




Re: Review Request 16121: Added Fix for CLOUDSTACK-5269, CLOUDSTACK-5378

2013-12-09 Thread Sebastien Goasguen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16121/#review29995
---


you can get the extension in a single line:
extension = os.path.splitext(filename)[1]

- Sebastien Goasguen


On Dec. 9, 2013, 7:03 a.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16121/
 ---
 
 (Updated Dec. 9, 2013, 7:03 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-5269 and CLOUDSTACK-5378
 https://issues.apache.org/jira/browse/CLOUDSTACK-5269
 https://issues.apache.org/jira/browse/CLOUDSTACK-5378
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Currently, post discovery other scripts away from python files are as well 
 pickedup for running which are available in a given package and 
 which follows nose default convention, though these files sometimes are not 
 tests. 
 
 Added explicit check to pickup only python tests for execution for now.
 
 Note: As of now python integration tests are only run using nose. If there 
 are any requirements that can be modified.
 
 
 Diffs
 -
 
   tools/marvin/marvin/marvinPlugin.py 852b84a 
 
 Diff: https://reviews.apache.org/r/16121/diff/
 
 
 Testing
 ---
 
 Tested DeployDC,Basic Sanity post the changes
 
 
 Thanks,
 
 Santhosh Edukulla
 




Re: Review Request 15922: Enhanced few features under Marvin

2013-12-09 Thread Sebastien Goasguen
Will,

Did that solve your problem ?

On Dec 7, 2013, at 3:15 AM, Girish Shilamkar gir...@clogeny.com wrote:

 Fixed in 4.2, 4.3 and master.
 
 Regards,
 Girish
 
 On 07-Dec-2013, at 12:47 PM, Girish Shilamkar gir...@clogeny.com wrote:
 
 Mea culpa. I will push the missed out files.
 
 Regards,
 Girish
 
 On 07-Dec-2013, at 12:34 PM, Santhosh Edukulla 
 santhosh.eduku...@citrix.com wrote:
 
 I was thinking that it was an install issue. So, I just pulled the latest 
 code for 4.3 and master to see the changes for this patch, i could see 
 marvinLog.py and marvinInit.py files seems to be missing and so is the 
 reason for this failure.  If we see, these files were available as part of 
 the patch, these were not pushed.
 
 Regards,
 Santhosh
 
 From: williamstev...@gmail.com [williamstev...@gmail.com] on behalf of Will 
 Stevens [wstev...@cloudops.com]
 Sent: Saturday, December 07, 2013 12:24 AM
 To: Santhosh Edukulla
 Cc: dev@cloudstack.apache.org; Girish Shilamkar
 Subject: Re: Review Request 15922: Enhanced few features under Marvin
 
 If you looked at the steps I have done, you will see that I have done 
 that...
 
 I have done a clean install in order to get the latest marvin.  That didnt 
 work so I tried grabbing a version from online.  That didnt work.  I also 
 tried doing a 'python setup.py install'.  That also didn't work...
 
 So you're saying that this SHOULD work???
 
 
 # clean install (I have to skip tests because 'Apache CloudStack Console 
 Proxy - RDP Client' fails tests)
 $ mvn -P developer,systemvm clean install -Dmaven.test.skip=true
 
 # deploy the db
 $ mvn -P developer -pl developer,tools/devcloud -Ddeploydb
 
 # I have done it with and without the following lines
 $ cd tools/marvin
 $ python setup.py install
 
 # start the server
 $ chmod 755 
 /mnt/hgfs/palo_alto/cloudstack/client/target/cloud-client-ui-4.3.0-SNAPSHOT/WEB-INF/classes/scripts/vm/systemvm/injectkeys.sh
 $ export MAVEN_OPTS=-Xmx1024m -XX:MaxPermSize=512m -Xdebug 
 -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n
 $ mvn -pl :cloud-client-ui jetty:run
 
 # now I try to deploy the server
 $ export MAVEN_OPTS=
 $ mvn -P developer -pl tools/devcloud -Ddeploysvr -X
 
 This results in:
 
 [DEBUG] Executing command line: python ../marvin/marvin/deployDataCenter.py 
 -i devcloud.cfg
 Traceback (most recent call last):
 File ../marvin/marvin/deployDataCenter.py, line 567, in module
  from marvin.marvinLog import MarvinLog
 ImportError: No module named marvinLog
 
 
 On Fri, Dec 6, 2013 at 11:32 PM, Santhosh Edukulla 
 santhosh.eduku...@citrix.commailto:santhosh.eduku...@citrix.com wrote:
 1. The path mentioned below does not contain latest.
 
 2.  When you pull the latest 4.3 code, the latest marvin for that build is 
 available with it. So, running python setup.py install in that folder 
 should install latest marvin
 
 3. In your case of running mvn, under devcloud pom.xml, you are asking it 
 to run deploy data center as well using -Ddeploysvr switch which requires 
 latest marvin to work with deployDataCenter.
 
 So for devcloud module, you need latest marvin. I would recommend running 
 mvn clean install or with other some profile as mvn clean install -P 
 developer,systemvm It will  get you latest marvin with cloudstackAPI 
 folder and running
 python setup.py install from tools/marvin should install the marvin.
 
 Thereafter you can build devcloud. Let me know.
 
 
 Regards,
 Santhosh
 
 From: williamstev...@gmail.commailto:williamstev...@gmail.com 
 [williamstev...@gmail.commailto:williamstev...@gmail.com] on behalf of 
 Will Stevens [wstev...@cloudops.commailto:wstev...@cloudops.com]
 Sent: Friday, December 06, 2013 10:59 PM
 To: Santhosh Edukulla
 Cc: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org; Girish 
 Shilamkar
 Subject: Re: Review Request 15922: Enhanced few features under Marvin
 
 Where do I get the latest package?  I was getting 1555 from here: 
 https://builds.apache.org/job/cloudstack-marvin/
 
 I did run 'python setup.py install' in the 'tools/marvin' directory and 
 that did not work either.
 
 Can you specify the steps I need to take to get this working?
 
 Thanks,
 
 Will
 
 
 On Fri, Dec 6, 2013 at 10:55 PM, Santhosh Edukulla 
 santhosh.eduku...@citrix.commailto:santhosh.eduku...@citrix.commailto:santhosh.eduku...@citrix.commailto:santhosh.eduku...@citrix.com
  wrote:
 Hi will,
 
 You need to install latest marvin. Changes to it requires for users to 
 install it again. Using mvn, it just builds and packages, it wont install.
 
 under marvin folder, run python setup.py install, or can use pip install 
 marvin..tar.gz
 
 Thanks!
 Santhosh
 
 From: Will Stevens 
 [nore...@reviews.apache.orgmailto:nore...@reviews.apache.orgmailto:nore...@reviews.apache.orgmailto:nore...@reviews.apache.org]
  on behalf of Will Stevens 
 

Review Request 16122: CLOUDSTACK-4498 cherry picked from 4.2

2013-12-09 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16122/
---

Review request for cloudstack and Jayapal Reddy.


Bugs: CLOUDSTACK-4498
https://issues.apache.org/jira/browse/CLOUDSTACK-4498


Repository: cloudstack-git


Description
---

 CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the 
vmware.reserve.cpu and vmware.reserve.mem are set to false.


Diffs
-

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
081c651 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 066a395 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 e34d5e1 

Diff: https://reviews.apache.org/r/16122/diff/


Testing
---

tested on master.


Thanks,

bharat kumar



Re: Template not in ready state

2013-12-09 Thread Girish Shilamkar
Talluri/Nitin,

I did check the ms logs. There were no errors. 
The issue was with the download url, it was a local url and the webserver was 
down.

Thanks for your help.

Regards,
Girish

On 07-Dec-2013, at 9:06 PM, Nitin Mehta nitin.me...@citrix.com wrote:

 Can you check the MS logs, what errors are reported for this template
 download ? And then refer to the wiki suggested below.
 
 On 07/12/13 6:21 AM, Srikanteswararao Talluri
 srikanteswararao.tall...@citrix.com wrote:
 
 Have you checked all the points in this wiki ?
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSVM,+templates,+Se
 c
 ondary+storage+troubleshooting
 
 
 ~Talluri
 
 On 07/12/13 4:07 pm, Girish Shilamkar gir...@clogeny.com wrote:
 
 Hello,
 
 I am trying to get a CS setup up, zones etc are setup. But templates are
 not in ready state.
 I tried various things like:
 - Checking agent status
 - Running ssvm health check
 - Checked ssvm logs for errors, nothing useful
 
 In db template_host_ref is empty. But I can see templates listed in in
 Templates section.
 
 What else I can check to get to the bottom of this problem ?
 
 Regards,
 Girish
 
 
 



Re: Template not in ready state

2013-12-09 Thread Rafael Weingartner
What states are the templates in ?


2013/12/9 Girish Shilamkar gir...@clogeny.com

 Talluri/Nitin,

 I did check the ms logs. There were no errors.
 The issue was with the download url, it was a local url and the webserver
 was down.

 Thanks for your help.

 Regards,
 Girish

 On 07-Dec-2013, at 9:06 PM, Nitin Mehta nitin.me...@citrix.com wrote:

  Can you check the MS logs, what errors are reported for this template
  download ? And then refer to the wiki suggested below.
 
  On 07/12/13 6:21 AM, Srikanteswararao Talluri
  srikanteswararao.tall...@citrix.com wrote:
 
  Have you checked all the points in this wiki ?
 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSVM,+templates,+Se
  c
  ondary+storage+troubleshooting
 
 
  ~Talluri
 
  On 07/12/13 4:07 pm, Girish Shilamkar gir...@clogeny.com wrote:
 
  Hello,
 
  I am trying to get a CS setup up, zones etc are setup. But templates
 are
  not in ready state.
  I tried various things like:
  - Checking agent status
  - Running ssvm health check
  - Checked ssvm logs for errors, nothing useful
 
  In db template_host_ref is empty. But I can see templates listed in in
  Templates section.
 
  What else I can check to get to the bottom of this problem ?
 
  Regards,
  Girish
 
 
 




-- 
Rafael Weingärtner


Re: Template not in ready state

2013-12-09 Thread Girish Shilamkar
The problem is fixed. 
The CS was setup to use internal webserver for downloading the template and it 
was running.

Regards,
Girish

On 09-Dec-2013, at 2:54 PM, Rafael Weingartner rafaelweingart...@gmail.com 
wrote:

 What states are the templates in ?
 
 
 2013/12/9 Girish Shilamkar gir...@clogeny.com
 
 Talluri/Nitin,
 
 I did check the ms logs. There were no errors.
 The issue was with the download url, it was a local url and the webserver
 was down.
 
 Thanks for your help.
 
 Regards,
 Girish
 
 On 07-Dec-2013, at 9:06 PM, Nitin Mehta nitin.me...@citrix.com wrote:
 
 Can you check the MS logs, what errors are reported for this template
 download ? And then refer to the wiki suggested below.
 
 On 07/12/13 6:21 AM, Srikanteswararao Talluri
 srikanteswararao.tall...@citrix.com wrote:
 
 Have you checked all the points in this wiki ?
 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSVM,+templates,+Se
 c
 ondary+storage+troubleshooting
 
 
 ~Talluri
 
 On 07/12/13 4:07 pm, Girish Shilamkar gir...@clogeny.com wrote:
 
 Hello,
 
 I am trying to get a CS setup up, zones etc are setup. But templates
 are
 not in ready state.
 I tried various things like:
 - Checking agent status
 - Running ssvm health check
 - Checked ssvm logs for errors, nothing useful
 
 In db template_host_ref is empty. But I can see templates listed in in
 Templates section.
 
 What else I can check to get to the bottom of this problem ?
 
 Regards,
 Girish
 
 
 
 
 
 
 
 -- 
 Rafael Weingärtner



Re: [VOTE] 2nd round of voting for ASF 4.2.1 RC

2013-12-09 Thread Abhinandan Prateek
On 05/12/13 4:17 pm, David Nalley da...@gnsa.us wrote:

While in a perfect world we wouldn't have any schema changes two
things jump out at me in this case.

1. We have precedent in doing schema changes in bugfix (both 4.0.1 and
4.1.1 had some schema changes)
2. We already have some schema changes in 4.2.1 (admittedly, just a
change in a view, but still a schema change)
 
Point taken, the upgrade issue has been fixed and the ACL ticket is worked
on by Kishan.
Hopefully, I will be able to respin RC for second round of voting by EOD
today.

For future releases I will request community members to be more proactive
in escalating the issues and not wait till the time of voting.

-abhi





Review Request 16126: CLOUDSTACK-5404: Fix timezone bug in network usages

2013-12-09 Thread Olivier Lemasle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16126/
---

Review request for cloudstack, Kishan Kavala and Wei Zhou.


Bugs: CLOUDSTACK-5404
https://issues.apache.org/jira/browse/CLOUDSTACK-5404


Repository: cloudstack-git


Description
---

Fix CLOUDSTACK-5404, which was causing a timezone issue: network usages 
(network bytes sent/received) are in local time, whereas other usages 
(instances, volumes, network offerings, etc.) are in GMT. More details on Jira 
(CLOUDSTACK-5404).

I did the patch on branch 4.2 where I encountered the bug, but it should be 
applied on master and 4.3.


Diffs
-

  engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 8b79257 

Diff: https://reviews.apache.org/r/16126/diff/


Testing
---

I packaged the patch version in RPMs, installed it, and the bug is fixed. No 
regression found.


Thanks,

Olivier Lemasle



Re: Review Request 16122: CLOUDSTACK-4498 cherry picked from 4.2

2013-12-09 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16122/
---

(Updated Dec. 9, 2013, 10:39 a.m.)


Review request for cloudstack and Jayapal Reddy.


Changes
---

patch for 4.3


Bugs: CLOUDSTACK-4498
https://issues.apache.org/jira/browse/CLOUDSTACK-4498


Repository: cloudstack-git


Description
---

 CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the 
vmware.reserve.cpu and vmware.reserve.mem are set to false.


Diffs (updated)
-

  plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
eb3cb6b 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 d306b74 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 69f1b74 

Diff: https://reviews.apache.org/r/16122/diff/


Testing
---

tested on master.


Thanks,

bharat kumar



Review Request 16127: Fixed CLOUDSTACK-5411

2013-12-09 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16127/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5411
https://issues.apache.org/jira/browse/CLOUDSTACK-5411


Repository: cloudstack-git


Description
---

1. Currently, there was an issue with logging formatter under marvin. Proper 
format messages are not getting printed. Fixed that.

2. There were few references in existing cfg files for earlier used logger 
node. Removed them and added new logger node as part of pending clean up.

3. Added TC information started, flow and the result accordingly to runlog. 
This will simplify to see the test case starting , sequence of steps and final 
result including timestamps for test c

4. Added few changes to dump the exception throwing tc's to the explicit 
exception file.


Diffs
-

  tools/marvin/marvin/misc/build/CI.md PRE-CREATION 
  tools/marvin/marvin/misc/build/README.md PRE-CREATION 
  tools/marvin/marvin/misc/build/advanced_env.py PRE-CREATION 
  tools/marvin/marvin/misc/build/asf_test.cfg PRE-CREATION 
  tools/marvin/marvin/misc/build/bashUtils.py PRE-CREATION 
  tools/marvin/marvin/misc/build/buildGenerator.py PRE-CREATION 
  tools/marvin/marvin/misc/build/configure.py PRE-CREATION 
  tools/marvin/marvin/misc/build/hudson.sh PRE-CREATION 
  tools/marvin/marvin/misc/build/kvm.cfg PRE-CREATION 
  tools/marvin/marvin/misc/build/kvm.properties PRE-CREATION 
  tools/marvin/marvin/misc/build/openport.py PRE-CREATION 
  tools/marvin/marvin/misc/build/redeploy.sh PRE-CREATION 
  tools/marvin/marvin/misc/build/restartMgmt.py PRE-CREATION 
  tools/marvin/marvin/misc/build/system.properties PRE-CREATION 
  tools/marvin/marvin/misc/build/testSetupSuccess.py PRE-CREATION 
  tools/marvin/marvin/misc/build/vm-start.sh PRE-CREATION 
  tools/marvin/marvin/misc/build/vm-uninstall.sh PRE-CREATION 
  tools/marvin/marvin/misc/build/xen.cfg PRE-CREATION 
  tools/marvin/marvin/misc/build/xen.properties PRE-CREATION 
  tools/marvin/marvin/misc/build/xunitmp/setup.py PRE-CREATION 
  tools/marvin/marvin/misc/build/xunitmp/xunitmultiprocess.py PRE-CREATION 

Diff: https://reviews.apache.org/r/16127/diff/


Testing
---

Tested running basic sanity post changes.


Thanks,

Santhosh Edukulla



Re: Review Request 16127: Fixed CLOUDSTACK-5411

2013-12-09 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16127/
---

(Updated Dec. 9, 2013, 11:17 a.m.)


Review request for cloudstack and Girish Shilamkar.


Changes
---

Added correct patch


Bugs: CLOUDSTACK-5411
https://issues.apache.org/jira/browse/CLOUDSTACK-5411


Repository: cloudstack-git


Description
---

1. Currently, there was an issue with logging formatter under marvin. Proper 
format messages are not getting printed. Fixed that.

2. There were few references in existing cfg files for earlier used logger 
node. Removed them and added new logger node as part of pending clean up.

3. Added TC information started, flow and the result accordingly to runlog. 
This will simplify to see the test case starting , sequence of steps and final 
result including timestamps for test c

4. Added few changes to dump the exception throwing tc's to the explicit 
exception file.


Diffs (updated)
-

  setup/dev/advancedsg.cfg c6a1f59 
  setup/dev/basic.cfg e91c87a 
  tools/devcloud/devcloud.cfg e209b55 
  tools/marvin/marvin/codes.py 8f0f88d 
  tools/marvin/marvin/config/setup.cfg 216314f 
  tools/marvin/marvin/marvinInit.py d822a2b 
  tools/marvin/marvin/marvinLog.py ca4d600 
  tools/marvin/marvin/marvinPlugin.py f5b7a88 

Diff: https://reviews.apache.org/r/16127/diff/


Testing
---

Tested running basic sanity post changes.


Thanks,

Santhosh Edukulla



Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

2013-12-09 Thread Saksham Srivastava

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
---

(Updated Dec. 9, 2013, 11:30 a.m.)


Review request for cloudstack and Sateesh Chodapuneedi.


Changes
---

Updating a three month old patch as it was not applying cleanly on master.


Bugs: CLOUDSTACK-4622
https://issues.apache.org/jira/browse/CLOUDSTACK-4622


Repository: cloudstack-git


Description
---

Add a new utility method for comparing 2 CIDRs.
The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP 
range is equal or a subset of cidrB's IP range.


Diffs (updated)
-

  server/src/com/cloud/network/NetworkServiceImpl.java 6855587 
  utils/src/com/cloud/utils/net/NetUtils.java c0c792f 
  utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf 

Diff: https://reviews.apache.org/r/14124/diff/


Testing
---

Added unit test for the utility.
Tested locally.
Build is successful.
Patch applies cleanly.


Thanks,

Saksham Srivastava



Re: Review Request 13745: CLOUDSTACK-4329: [DOC] Added Linux template creation documentation

2013-12-09 Thread Sebastien Goasguen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13745/#review29997
---

Ship it!


thanks, applied to master
0c439696301dc6a776b085b580f12ca6f054f0b0

- Sebastien Goasguen


On Dec. 8, 2013, 3:34 p.m., Marty Sweet wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13745/
 ---
 
 (Updated Dec. 8, 2013, 3:34 p.m.)
 
 
 Review request for cloudstack.
 
 
 Bugs: CLOUDSTACK-4329
 https://issues.apache.org/jira/browse/CLOUDSTACK-4329
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Added 2 documents (prepare-linux-template and create-linux-template) which 
 covers details explained in CLOUDSTACK-4329 on how to create a working Linux 
 Template.
 Adjusted working-with-templates.xml to add menu item.
 
 
 Diffs
 -
 
   en-US/create-linux-template.xml PRE-CREATION 
   en-US/prepare-linux-template.xml PRE-CREATION 
   en-US/working-with-templates.xml 9f4e750 
 
 Diff: https://reviews.apache.org/r/13745/diff/
 
 
 Testing
 ---
 
 Documents build with Publican
 
 
 Thanks,
 
 Marty Sweet
 




Review Request 16128: CLOUDSTACK-4973: Specified locale keyboard language is not showing as default in consoleView passed during deployVM.

2013-12-09 Thread Sanjay Tripathi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16128/
---

Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh 
Chodapuneedi.


Bugs: CLOUUDSTACK-4973
https://issues.apache.org/jira/browse/CLOUUDSTACK-4973


Repository: cloudstack-git


Description
---

CLOUDSTACK-4973: Specified locale keyboard language is not showing as default 
in consoleView passed during deployVM.

While deploying a VM, user passes the keyboard parameter to specify the
default language for that VM but in the consoleView, the default language
selected is en-us irrespective of the default language of the VM.


Diffs
-

  server/src/com/cloud/servlet/ConsoleProxyClientParam.java e420110 
  server/src/com/cloud/servlet/ConsoleProxyServlet.java b3415db 
  
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
 6cadeca 
  
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java
 07a1b6f 
  
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientParam.java
 8de4955 
  
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java
 297e711 

Diff: https://reviews.apache.org/r/16128/diff/


Testing
---

Verified the fix locally by deploying a VM with keyboard=uk and keyboard=jp.


Thanks,

Sanjay Tripathi



Re: Isolated Network with no Services

2013-12-09 Thread Murali Reddy

From the UI yes, you can try with API directly.

On 09/12/13 12:19 PM, Simon Murphy simon.mur...@vifx.co.nz wrote:

I can successfully create the network offering with no services, however
when I go to deploy it is not listed under the available network
offerings.Seems like only Isolated Networks with SourceNAT enabled are
displayedŠis this correct?


Simon Murphy
Solutions Architect
  
ViFX | Cloud Infrastructure
Level 7, 57 Fort Street, Auckland, New Zealand 1010
PO Box 106700, Auckland, New Zealand 1143
M +64 21 285 4519 | S simon_a_murphy
www.vifx.co.nz http://www.vifx.co.nz/ follow us on twitter
https://twitter.com/ViFX
Auckland | Wellington | Christchurch
   

 
experience. expertise. execution.
 
This email and any files transmitted with it are confidential, without
prejudice and may contain information that is subject to legal privilege.
It is intended solely for the use of the individual/s to whom it is
addressed in accordance with the provisions of the Privacy Act (1993). The
content contained in this email does not, necessarily, reflect the
official policy position of ViFX nor does ViFX have any responsibility for
any alterations to the contents of this email that may occur following
transmission. If you are not the addressee it may be unlawful for you to
read, copy, distribute, disclose or otherwise use the information
contained within this email. If you are not the intended recipient, please
notify the sender prior to deleting this email message from your system.
Please note ViFX reserves the right to monitor, from time to time, the
communications sent to and from its email network.






On 3/12/13 6:29 PM, Murali Reddy murali.re...@citrix.com wrote:

HTH

http://blog.remibergsma.com/2012/03/10/howto-create-a-network-in-cloudsta
c
k-without-a-virtual-router/

From: Simon Murphy
simon.mur...@vifx.co.nzmailto:simon.mur...@vifx.co.nz
Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Date: Tuesday, 3 December 2013 8:15 AM
To: us...@cloudstack.apache.orgmailto:us...@cloudstack.apache.org
us...@cloudstack.apache.orgmailto:us...@cloudstack.apache.org,
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Subject: Isolated Network with no Services

Is it possible to configure a network offering for an isolated network
that has no services? I would like to give the customer the option to
create a network that is totally isolated (no L3 connectivity) so that
they can bring their own software router/firewall. The isolated network
would be connected to other networks via the customers virtual router.

I can create the network offering however it is not listed as an
available service when I try to create the network.

Cheers,
Simon





Simon Murphy
Solutions Architect

ViFX | Cloud Infrastructure
Level 7, 57 Fort Street, Auckland, New Zealand 1010
PO Box 106700, Auckland, New Zealand 1143
M +64 21 285 4519 | S simon_a_murphy
www.vifx.co.nzhttp://www.vifx.co.nz/ follow us on
twitterhttps://twitter.com/ViFX
Auckland | Wellington | Christchurch

[cid:image003.jpg@01CDDF95.815BF160]

experience. expertise. execution.

This email and any files transmitted with it are confidential, without
prejudice and may contain information that is subject to legal privilege.
It is intended solely for the use of the individual/s to whom it is
addressed in accordance with the provisions of the Privacy Act (1993).
The content contained in this email does not, necessarily, reflect the
official policy position of ViFX nor does ViFX have any responsibility
for any alterations to the contents of this email that may occur
following transmission. If you are not the addressee it may be unlawful
for you to read, copy, distribute, disclose or otherwise use the
information contained within this email. If you are not the intended
recipient, please notify the sender prior to deleting this email message
from your system. Please note ViFX reserves the right to monitor, from
time to time, the communications sent to and from its email network.






[DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-09 Thread sebgoa
Hi,

There has been lots of discussion about docs over the last 3/4 months, in 
summary the issues are:

-Difficult to maintain and keep website up to date (issues with lang and issues 
with pdf formatting lately)
-Difficult to contribute to easily, docbook is fine but tedious to work on.
-Errors in the docs don't get properly fixed
-Mix of OS information
-Lack of content for certain features
-Docs release cycle. Docs have bugs that will never get fixed in that specific 
release (because we see it as code release)

To remedy some of those issues and work on a new release process specific to 
docs we moved the docs to its own repo:

https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git

*I propose that we move away from docbook and use a more readable format: 
restructuredtext*

I have worked on a prototype that uses restructured text:
http://docutils.sourceforge.net/rst.html

This format makes it extremely easy to write docs. Existing docbook content 
could be converted to .rst using a tool like pandoc:
http://johnmacfarlane.net/pandoc/

*In addition to changing the format I propose that we use readthedocs.org*

This will help with the release and build of the docs. readthedocs grabs the 
docs from a git repo, builds html, pdf and epub.
It can also maintain several releases. We can apply a specific -theme- to our 
docs. 

See a prototype here:

http://cloudstack.readthedocs.org/en/latest/

*I propose that we move to this as early as 4.3 documentation*

Assuming this proposal passes, we would need to:

-re-architect the repo
-create the proper cnames to be in accordance with trademark guidelines
-we can decide what content to keep or not and convert what we keep.
-decide how we organize the content
-start accepting pull requests (noting that pages can be edited directly from 
github)
-make a first release of this new doc site at the same time than 4.3 release.


Thoughts, flames ?


-Sebastien

Review Request 16129: CLOUDSTACK-5419: missing parameters in configuration table and to remove unused parameters

2013-12-09 Thread Harikrishna Patnala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16129/
---

Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-5419
https://issues.apache.org/jira/browse/CLOUDSTACK-5419


Repository: cloudstack-git


Description
---

CLOUDSTACK-5419: missing parameters in configuration table and to remove unused 
parameters

Following parameters are unused which were introduced in 3.0.6.
xen.update.url, update.check.interval, baremetal_dhcp_devices, 
host.updates.enable

Following parameters are missing upon upgrade from 3.0.6 to 4.3
vmsnapshot.create.wait, vmsnapshot.max 


Diffs
-

  server/src/com/cloud/configuration/Config.java 6ffeb26 
  setup/db/db/schema-421to430.sql a9c850f 

Diff: https://reviews.apache.org/r/16129/diff/


Testing
---


Thanks,

Harikrishna Patnala



Re: Review Request 15566: Remove the comparison between GuestOSCategoryVO.CATEGORY_NONE and guestOSCategory.getName() to make OS category of 'None' to be a valid option.

2013-12-09 Thread Yichi Lu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15566/
---

(Updated Dec. 9, 2013, 1:32 p.m.)


Review request for cloudstack and daan Hoogland.


Changes
---

updated patch against 4.4.0


Bugs: CLOUDSTACK-4969
https://issues.apache.org/jira/browse/CLOUDSTACK-4969


Repository: cloudstack-git


Description
---

CLOUDSTACK-4969
In server/src/com/cloud/resource/ResourceManagerImpl.java near line 1264, there 
is a line:  if (guestOSCategory != null  
!GuestOSCategoryVO.CATEGORY_NONE.equalsIgnoreCase(guestOSCategory.getName())). 
But since GuestOSCategoryVO.CATEGORY_NONE = 'None' and 
guestOSCategory.getName() = 'None', this would cause OS category of 'None' to 
not be selected. Removing it does the job.
Notice the OS category of 'None' at the top of the dropdown list does not have 
a valid guestOSCategoryid (and would be null).


Diffs (updated)
-

  server/src/com/cloud/resource/ResourceManagerImpl.java 7579b8f 

Diff: https://reviews.apache.org/r/15566/diff/


Testing
---

Tested against cloudstack GUI. Was able to change OS category to 'None', the 
bottom one, and change it back to other OS categories. Selecting the top 'None' 
would have no effect.


Thanks,

Yichi Lu



Re: Review Request #15566 - CLOUDSTACK-4969

2013-12-09 Thread Yichi Lu
Daan:
I updated patch. Thanks.

Yichi


On Tue, Nov 26, 2013 at 2:38 AM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 Yichi,

 Can you update your patch? I will apply it but it doesn't apply to master
 now.

 regards

 On Fri, Nov 22, 2013 at 8:37 PM, Yichi Lu yichi...@sungard.com wrote:
  -- Forwarded message --
  From: Yichi Lu yichi...@sungard.com
  Date: Fri, Nov 22, 2013 at 9:38 AM
  Subject: Review Request #15566 - CLOUDSTACK-4969
  To: us...@cloudstack.apache.org
 
 
  Dear Committers:
  I submitted this review request a week ago, but have not received any
  response. I'd appreciate if someone could review this for me. (My another
  request, # 15633, CLOUDSTACK-5079 is about 5 days old). Thanks.
 
  Yichi




Re: Review Request 15999: CLOUDSTACK-5364: Resolving network cleanup issue in egress fw rules test cases

2013-12-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15999/#review29998
---


Commit 71aa2c0881760b8df75b6b8110833fb850c04317 in branch refs/heads/master 
from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=71aa2c0 ]

CLOUDSTACK-5364: Fail the test incase cleanup is not successful


- ASF Subversion and Git Services


On Dec. 4, 2013, 12:12 p.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/15999/
 ---
 
 (Updated Dec. 4, 2013, 12:12 p.m.)
 
 
 Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-5364
 https://issues.apache.org/jira/browse/CLOUDSTACK-5364
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Following test cases failed:
 test_11_egress_fr11 
 test_11_1_egress_fr11
 
 They failed due to two isolated networks were being created in an account, 
 that happened in case where network from the previous test did not get 
 deleted.
 
 Added loop in tearDown to check if all the vms in the network are expunged 
 before deleting the network, so that the network gets deleted properly before 
 execution of next test case.
 
 
 Diffs
 -
 
   test/integration/component/test_egress_fw_rules.py 6dcc2c4d 
 
 Diff: https://reviews.apache.org/r/15999/diff/
 
 
 Testing
 ---
 
 Tested locally on KVM advances setup.
 
 Log:
 
 test_01_1_egress_fr1 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test By-default the communication from guest n/w to public n/w is NOT 
 allowed. ... skipped 'Skip'
 test_01_egress_fr1 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test By-default the communication from guest n/w to public n/w is allowed. 
 ... skipped 'Skip'
 test_02_1_egress_fr2 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. 
 ... skipped 'Skip'
 test_02_egress_fr2 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. 
 ... skipped 'Skip'
 test_03_1_egress_fr3 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Communication blocked with network that is other than specified ... 
 skipped 'Skip'
 test_03_egress_fr3 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Communication blocked with network that is other than specified ... 
 skipped 'Skip'
 test_04_1_egress_fr4 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the Firewall_Rules DB table ... skipped 
 'Skip'
 test_04_egress_fr4 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the Firewall_Rules DB table ... skipped 
 'Skip'
 test_05_1_egress_fr5 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the IP tables ... skipped 'Skip'
 test_05_egress_fr5 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the IP tables ... skipped 'Skip'
 test_06_1_egress_fr6 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without CIDR ... skipped 'Skip'
 test_06_egress_fr6 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without CIDR ... skipped 'Skip'
 test_07_1_egress_fr7 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without End Port ... skipped 'Skip'
 test_07_egress_fr7 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without End Port ... skipped 'Skip'
 test_08_1_egress_fr8 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Port Forwarding and Egress Conflict ... skipped 'Skip'
 test_08_egress_fr8 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Port Forwarding and Egress Conflict ... skipped 'Skip'
 test_09_1_egress_fr9 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Delete Egress rule ... skipped 'Skip'
 test_09_egress_fr9 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Delete Egress rule ... skipped 'Skip'
 test_10_1_egress_fr10 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Invalid CIDR and Invalid Port ranges ... skipped 'Skip'
 test_10_egress_fr10 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Invalid CIDR and Invalid Port ranges ... skipped 'Skip'
 test_11_1_egress_fr11 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Regression on Firewall + PF + LB + SNAT ... ok
 test_11_egress_fr11 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Regression on Firewall + PF + LB + SNAT ... ok
 test_12_1_egress_fr12 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Reboot Router ... skipped 'Skip'
 test_12_egress_fr12 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Reboot Router ... skipped 'Skip'
 test_13_1_egress_fr13 

Re: Review Request 15999: CLOUDSTACK-5364: Resolving network cleanup issue in egress fw rules test cases

2013-12-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15999/#review2
---


Commit 0533001feb60bf03ef3839774b6ce515f3694857 in branch refs/heads/4.3 from 
Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0533001 ]

CLOUDSTACK-5364: Fail the test incase cleanup is not successful


- ASF Subversion and Git Services


On Dec. 4, 2013, 12:12 p.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/15999/
 ---
 
 (Updated Dec. 4, 2013, 12:12 p.m.)
 
 
 Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-5364
 https://issues.apache.org/jira/browse/CLOUDSTACK-5364
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Following test cases failed:
 test_11_egress_fr11 
 test_11_1_egress_fr11
 
 They failed due to two isolated networks were being created in an account, 
 that happened in case where network from the previous test did not get 
 deleted.
 
 Added loop in tearDown to check if all the vms in the network are expunged 
 before deleting the network, so that the network gets deleted properly before 
 execution of next test case.
 
 
 Diffs
 -
 
   test/integration/component/test_egress_fw_rules.py 6dcc2c4d 
 
 Diff: https://reviews.apache.org/r/15999/diff/
 
 
 Testing
 ---
 
 Tested locally on KVM advances setup.
 
 Log:
 
 test_01_1_egress_fr1 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test By-default the communication from guest n/w to public n/w is NOT 
 allowed. ... skipped 'Skip'
 test_01_egress_fr1 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test By-default the communication from guest n/w to public n/w is allowed. 
 ... skipped 'Skip'
 test_02_1_egress_fr2 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. 
 ... skipped 'Skip'
 test_02_egress_fr2 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. 
 ... skipped 'Skip'
 test_03_1_egress_fr3 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Communication blocked with network that is other than specified ... 
 skipped 'Skip'
 test_03_egress_fr3 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Communication blocked with network that is other than specified ... 
 skipped 'Skip'
 test_04_1_egress_fr4 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the Firewall_Rules DB table ... skipped 
 'Skip'
 test_04_egress_fr4 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the Firewall_Rules DB table ... skipped 
 'Skip'
 test_05_1_egress_fr5 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the IP tables ... skipped 'Skip'
 test_05_egress_fr5 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the IP tables ... skipped 'Skip'
 test_06_1_egress_fr6 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without CIDR ... skipped 'Skip'
 test_06_egress_fr6 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without CIDR ... skipped 'Skip'
 test_07_1_egress_fr7 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without End Port ... skipped 'Skip'
 test_07_egress_fr7 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without End Port ... skipped 'Skip'
 test_08_1_egress_fr8 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Port Forwarding and Egress Conflict ... skipped 'Skip'
 test_08_egress_fr8 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Port Forwarding and Egress Conflict ... skipped 'Skip'
 test_09_1_egress_fr9 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Delete Egress rule ... skipped 'Skip'
 test_09_egress_fr9 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Delete Egress rule ... skipped 'Skip'
 test_10_1_egress_fr10 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Invalid CIDR and Invalid Port ranges ... skipped 'Skip'
 test_10_egress_fr10 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Invalid CIDR and Invalid Port ranges ... skipped 'Skip'
 test_11_1_egress_fr11 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Regression on Firewall + PF + LB + SNAT ... ok
 test_11_egress_fr11 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Regression on Firewall + PF + LB + SNAT ... ok
 test_12_1_egress_fr12 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Reboot Router ... skipped 'Skip'
 test_12_egress_fr12 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Reboot Router ... skipped 'Skip'
 test_13_1_egress_fr13 

Re: Review Request 15999: CLOUDSTACK-5364: Resolving network cleanup issue in egress fw rules test cases

2013-12-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15999/#review3
---


Commit 66b7b7e25c8cbc73b5c33ffc87303045913b491b in branch refs/heads/4.2 from 
Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=66b7b7e ]

CLOUDSTACK-5364: Fail the test incase cleanup is not successful


- ASF Subversion and Git Services


On Dec. 4, 2013, 12:12 p.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/15999/
 ---
 
 (Updated Dec. 4, 2013, 12:12 p.m.)
 
 
 Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-5364
 https://issues.apache.org/jira/browse/CLOUDSTACK-5364
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Following test cases failed:
 test_11_egress_fr11 
 test_11_1_egress_fr11
 
 They failed due to two isolated networks were being created in an account, 
 that happened in case where network from the previous test did not get 
 deleted.
 
 Added loop in tearDown to check if all the vms in the network are expunged 
 before deleting the network, so that the network gets deleted properly before 
 execution of next test case.
 
 
 Diffs
 -
 
   test/integration/component/test_egress_fw_rules.py 6dcc2c4d 
 
 Diff: https://reviews.apache.org/r/15999/diff/
 
 
 Testing
 ---
 
 Tested locally on KVM advances setup.
 
 Log:
 
 test_01_1_egress_fr1 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test By-default the communication from guest n/w to public n/w is NOT 
 allowed. ... skipped 'Skip'
 test_01_egress_fr1 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test By-default the communication from guest n/w to public n/w is allowed. 
 ... skipped 'Skip'
 test_02_1_egress_fr2 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. 
 ... skipped 'Skip'
 test_02_egress_fr2 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. 
 ... skipped 'Skip'
 test_03_1_egress_fr3 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Communication blocked with network that is other than specified ... 
 skipped 'Skip'
 test_03_egress_fr3 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Communication blocked with network that is other than specified ... 
 skipped 'Skip'
 test_04_1_egress_fr4 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the Firewall_Rules DB table ... skipped 
 'Skip'
 test_04_egress_fr4 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the Firewall_Rules DB table ... skipped 
 'Skip'
 test_05_1_egress_fr5 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the IP tables ... skipped 'Skip'
 test_05_egress_fr5 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule and check the IP tables ... skipped 'Skip'
 test_06_1_egress_fr6 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without CIDR ... skipped 'Skip'
 test_06_egress_fr6 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without CIDR ... skipped 'Skip'
 test_07_1_egress_fr7 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without End Port ... skipped 'Skip'
 test_07_egress_fr7 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Create Egress rule without End Port ... skipped 'Skip'
 test_08_1_egress_fr8 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Port Forwarding and Egress Conflict ... skipped 'Skip'
 test_08_egress_fr8 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Port Forwarding and Egress Conflict ... skipped 'Skip'
 test_09_1_egress_fr9 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Delete Egress rule ... skipped 'Skip'
 test_09_egress_fr9 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Delete Egress rule ... skipped 'Skip'
 test_10_1_egress_fr10 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Invalid CIDR and Invalid Port ranges ... skipped 'Skip'
 test_10_egress_fr10 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Invalid CIDR and Invalid Port ranges ... skipped 'Skip'
 test_11_1_egress_fr11 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Regression on Firewall + PF + LB + SNAT ... ok
 test_11_egress_fr11 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Regression on Firewall + PF + LB + SNAT ... ok
 test_12_1_egress_fr12 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Reboot Router ... skipped 'Skip'
 test_12_egress_fr12 (test_egress_fw_rules_fixed.TestEgressFWRules)
 Test Reboot Router ... skipped 'Skip'
 test_13_1_egress_fr13 

Re: Master branch - can't run up systemvm with KVM hypervisor

2013-12-09 Thread Nguyen Anh Tu
On Mon, Dec 9, 2013 at 2:56 PM, Wido den Hollander w...@widodh.nl wrote:

 Hmm, that might be due to my patch from two weeks ago. Let me look into
 this!

Yeah, Thanks Wido :-)

--Tuna


Re: Review Request 16120: Fixed-CLOUDSTACK-5411

2013-12-09 Thread Girish Shilamkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16120/#review30002
---

Ship it!


Pushed to 4.2, 4.3 and master.

- Girish Shilamkar


On Dec. 9, 2013, 7:05 a.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16120/
 ---
 
 (Updated Dec. 9, 2013, 7:05 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-5411
 https://issues.apache.org/jira/browse/CLOUDSTACK-5411
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Moved build scripts currently maintained in separate repo to marvin.
 
 
 Diffs
 -
 
   tools/marvin/marvin/misc/build/CI.md PRE-CREATION 
   tools/marvin/marvin/misc/build/README.md PRE-CREATION 
   tools/marvin/marvin/misc/build/advanced_env.py PRE-CREATION 
   tools/marvin/marvin/misc/build/asf_test.cfg PRE-CREATION 
   tools/marvin/marvin/misc/build/bashUtils.py PRE-CREATION 
   tools/marvin/marvin/misc/build/buildGenerator.py PRE-CREATION 
   tools/marvin/marvin/misc/build/configure.py PRE-CREATION 
   tools/marvin/marvin/misc/build/hudson.sh PRE-CREATION 
   tools/marvin/marvin/misc/build/kvm.cfg PRE-CREATION 
   tools/marvin/marvin/misc/build/kvm.properties PRE-CREATION 
   tools/marvin/marvin/misc/build/openport.py PRE-CREATION 
   tools/marvin/marvin/misc/build/redeploy.sh PRE-CREATION 
   tools/marvin/marvin/misc/build/restartMgmt.py PRE-CREATION 
   tools/marvin/marvin/misc/build/system.properties PRE-CREATION 
   tools/marvin/marvin/misc/build/testSetupSuccess.py PRE-CREATION 
   tools/marvin/marvin/misc/build/vm-start.sh PRE-CREATION 
   tools/marvin/marvin/misc/build/vm-uninstall.sh PRE-CREATION 
   tools/marvin/marvin/misc/build/xen.cfg PRE-CREATION 
   tools/marvin/marvin/misc/build/xen.properties PRE-CREATION 
   tools/marvin/marvin/misc/build/xunitmp/setup.py PRE-CREATION 
   tools/marvin/marvin/misc/build/xunitmp/xunitmultiprocess.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/16120/diff/
 
 
 Testing
 ---
 
 Yes, post these changes tested deployDC and running sanity.
 
 
 Thanks,
 
 Santhosh Edukulla
 




Re: Review Request 16121: Added Fix for CLOUDSTACK-5269, CLOUDSTACK-5378

2013-12-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16121/#review30004
---


Commit 5cbda8b64a127090a255fdfdf188b84e5ed53c74 in branch refs/heads/master 
from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5cbda8b ]

CLOUDSTACK-5269: Fix nose failures.


- ASF Subversion and Git Services


On Dec. 9, 2013, 7:03 a.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16121/
 ---
 
 (Updated Dec. 9, 2013, 7:03 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-5269 and CLOUDSTACK-5378
 https://issues.apache.org/jira/browse/CLOUDSTACK-5269
 https://issues.apache.org/jira/browse/CLOUDSTACK-5378
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Currently, post discovery other scripts away from python files are as well 
 pickedup for running which are available in a given package and 
 which follows nose default convention, though these files sometimes are not 
 tests. 
 
 Added explicit check to pickup only python tests for execution for now.
 
 Note: As of now python integration tests are only run using nose. If there 
 are any requirements that can be modified.
 
 
 Diffs
 -
 
   tools/marvin/marvin/marvinPlugin.py 852b84a 
 
 Diff: https://reviews.apache.org/r/16121/diff/
 
 
 Testing
 ---
 
 Tested DeployDC,Basic Sanity post the changes
 
 
 Thanks,
 
 Santhosh Edukulla
 




Re: Review Request 16126: CLOUDSTACK-5404: Fix timezone bug in network usages

2013-12-09 Thread Olivier Lemasle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16126/
---

(Updated Dec. 9, 2013, 2:11 p.m.)


Review request for cloudstack, Kishan Kavala and Wei Zhou.


Bugs: CLOUDSTACK-5404
https://issues.apache.org/jira/browse/CLOUDSTACK-5404


Repository: cloudstack-git


Description
---

Fix CLOUDSTACK-5404, which was causing a timezone issue: network usages 
(network bytes sent/received) are in local time, whereas other usages 
(instances, volumes, network offerings, etc.) are in GMT. More details on Jira 
(CLOUDSTACK-5404).

I did the patch on branch 4.2 where I encountered the bug, but it should be 
applied on master and 4.3.


Diffs
-

  engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 8b79257 

Diff: https://reviews.apache.org/r/16126/diff/


Testing (updated)
---

I packaged the patch version in RPMs (branch 4.2), installed it, and the bug is 
fixed. No regression found.


Thanks,

Olivier Lemasle



Re: Review Request 16121: Added Fix for CLOUDSTACK-5269, CLOUDSTACK-5378

2013-12-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16121/#review30005
---


Commit 6b5402bbff9fc6aedd27033316b8ad988a21dd60 in branch refs/heads/4.3 from 
Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6b5402b ]

CLOUDSTACK-5269: Fix nose failures.


- ASF Subversion and Git Services


On Dec. 9, 2013, 7:03 a.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16121/
 ---
 
 (Updated Dec. 9, 2013, 7:03 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-5269 and CLOUDSTACK-5378
 https://issues.apache.org/jira/browse/CLOUDSTACK-5269
 https://issues.apache.org/jira/browse/CLOUDSTACK-5378
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Currently, post discovery other scripts away from python files are as well 
 pickedup for running which are available in a given package and 
 which follows nose default convention, though these files sometimes are not 
 tests. 
 
 Added explicit check to pickup only python tests for execution for now.
 
 Note: As of now python integration tests are only run using nose. If there 
 are any requirements that can be modified.
 
 
 Diffs
 -
 
   tools/marvin/marvin/marvinPlugin.py 852b84a 
 
 Diff: https://reviews.apache.org/r/16121/diff/
 
 
 Testing
 ---
 
 Tested DeployDC,Basic Sanity post the changes
 
 
 Thanks,
 
 Santhosh Edukulla
 




Re: Review Request 16121: Added Fix for CLOUDSTACK-5269, CLOUDSTACK-5378

2013-12-09 Thread Girish Shilamkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16121/#review30006
---

Ship it!


Committed to 4.2, 4.3 and master

- Girish Shilamkar


On Dec. 9, 2013, 7:03 a.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16121/
 ---
 
 (Updated Dec. 9, 2013, 7:03 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-5269 and CLOUDSTACK-5378
 https://issues.apache.org/jira/browse/CLOUDSTACK-5269
 https://issues.apache.org/jira/browse/CLOUDSTACK-5378
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Currently, post discovery other scripts away from python files are as well 
 pickedup for running which are available in a given package and 
 which follows nose default convention, though these files sometimes are not 
 tests. 
 
 Added explicit check to pickup only python tests for execution for now.
 
 Note: As of now python integration tests are only run using nose. If there 
 are any requirements that can be modified.
 
 
 Diffs
 -
 
   tools/marvin/marvin/marvinPlugin.py 852b84a 
 
 Diff: https://reviews.apache.org/r/16121/diff/
 
 
 Testing
 ---
 
 Tested DeployDC,Basic Sanity post the changes
 
 
 Thanks,
 
 Santhosh Edukulla
 




Re: Review Request 16121: Added Fix for CLOUDSTACK-5269, CLOUDSTACK-5378

2013-12-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16121/#review30007
---


Commit 2597dad20af4620ac9338f24f1f9a262e8295dac in branch refs/heads/4.2 from 
Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2597dad ]

CLOUDSTACK-5269: Fix nose failures.


- ASF Subversion and Git Services


On Dec. 9, 2013, 7:03 a.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16121/
 ---
 
 (Updated Dec. 9, 2013, 7:03 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-5269 and CLOUDSTACK-5378
 https://issues.apache.org/jira/browse/CLOUDSTACK-5269
 https://issues.apache.org/jira/browse/CLOUDSTACK-5378
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Currently, post discovery other scripts away from python files are as well 
 pickedup for running which are available in a given package and 
 which follows nose default convention, though these files sometimes are not 
 tests. 
 
 Added explicit check to pickup only python tests for execution for now.
 
 Note: As of now python integration tests are only run using nose. If there 
 are any requirements that can be modified.
 
 
 Diffs
 -
 
   tools/marvin/marvin/marvinPlugin.py 852b84a 
 
 Diff: https://reviews.apache.org/r/16121/diff/
 
 
 Testing
 ---
 
 Tested DeployDC,Basic Sanity post the changes
 
 
 Thanks,
 
 Santhosh Edukulla
 




Re: Review Request 16127: Fixed CLOUDSTACK-5411

2013-12-09 Thread Girish Shilamkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16127/#review30009
---

Ship it!


COmmitted to 4.2, 4.3 and master.

- Girish Shilamkar


On Dec. 9, 2013, 11:17 a.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16127/
 ---
 
 (Updated Dec. 9, 2013, 11:17 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-5411
 https://issues.apache.org/jira/browse/CLOUDSTACK-5411
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 1. Currently, there was an issue with logging formatter under marvin. Proper 
 format messages are not getting printed. Fixed that.
 
 2. There were few references in existing cfg files for earlier used logger 
 node. Removed them and added new logger node as part of pending clean up.
 
 3. Added TC information started, flow and the result accordingly to runlog. 
 This will simplify to see the test case starting , sequence of steps and 
 final result including timestamps for test c
 
 4. Added few changes to dump the exception throwing tc's to the explicit 
 exception file.
 
 
 Diffs
 -
 
   setup/dev/advancedsg.cfg c6a1f59 
   setup/dev/basic.cfg e91c87a 
   tools/devcloud/devcloud.cfg e209b55 
   tools/marvin/marvin/codes.py 8f0f88d 
   tools/marvin/marvin/config/setup.cfg 216314f 
   tools/marvin/marvin/marvinInit.py d822a2b 
   tools/marvin/marvin/marvinLog.py ca4d600 
   tools/marvin/marvin/marvinPlugin.py f5b7a88 
 
 Diff: https://reviews.apache.org/r/16127/diff/
 
 
 Testing
 ---
 
 Tested running basic sanity post changes.
 
 
 Thanks,
 
 Santhosh Edukulla
 




Re: Review Request 15566: Remove the comparison between GuestOSCategoryVO.CATEGORY_NONE and guestOSCategory.getName() to make OS category of 'None' to be a valid option.

2013-12-09 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15566/#review30011
---

Ship it!


f194adb2ded586516f98e045bb318ca1af0730e5

- daan Hoogland


On Dec. 9, 2013, 1:32 p.m., Yichi Lu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/15566/
 ---
 
 (Updated Dec. 9, 2013, 1:32 p.m.)
 
 
 Review request for cloudstack and daan Hoogland.
 
 
 Bugs: CLOUDSTACK-4969
 https://issues.apache.org/jira/browse/CLOUDSTACK-4969
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CLOUDSTACK-4969
 In server/src/com/cloud/resource/ResourceManagerImpl.java near line 1264, 
 there is a line:  if (guestOSCategory != null  
 !GuestOSCategoryVO.CATEGORY_NONE.equalsIgnoreCase(guestOSCategory.getName())).
  But since GuestOSCategoryVO.CATEGORY_NONE = 'None' and 
 guestOSCategory.getName() = 'None', this would cause OS category of 'None' to 
 not be selected. Removing it does the job.
 Notice the OS category of 'None' at the top of the dropdown list does not 
 have a valid guestOSCategoryid (and would be null).
 
 
 Diffs
 -
 
   server/src/com/cloud/resource/ResourceManagerImpl.java 7579b8f 
 
 Diff: https://reviews.apache.org/r/15566/diff/
 
 
 Testing
 ---
 
 Tested against cloudstack GUI. Was able to change OS category to 'None', the 
 bottom one, and change it back to other OS categories. Selecting the top 
 'None' would have no effect.
 
 
 Thanks,
 
 Yichi Lu
 




Re: Master branch - can't run up systemvm with KVM hypervisor

2013-12-09 Thread Wido den Hollander



On 12/09/2013 02:52 PM, Nguyen Anh Tu wrote:

On Mon, Dec 9, 2013 at 2:56 PM, Wido den Hollander w...@widodh.nl wrote:


Hmm, that might be due to my patch from two weeks ago. Let me look into
this!


Yeah, Thanks Wido :-)



I think it's fixed with this patch: 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=088247b61b4ecea7bb757becd233e10c97a7a75a


Wido


--Tuna



Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-09 Thread David Nalley

 -re-architect the repo
 -create the proper cnames to be in accordance with trademark guidelines
 -we can decide what content to keep or not and convert what we keep.
 -decide how we organize the content
 -start accepting pull requests (noting that pages can be edited directly from 
 github)
 -make a first release of this new doc site at the same time than 4.3 release.


 Thoughts, flames ?




So I was the one that picked Publican for CloudStack in the pre-ACS
days. I like publican, it generally makes sense to me, seems to work
well, and despite the fact that it's DocBook XML with specialized
tools for generating finished documentation, it does the job very
well.

That said, I see a few problems with publican; namely:

* DocBook XML is something folks have to learn before being able to
contribute (e.g. the barrier to participate is higher)
* The build/publish process is difficult at best. Currently I think
that only Joe Brockmeier and I know how to do so. (we are SPOFs)

I actually looked (at Joe's suggestion) for something else many months
ago; and there didn't seem anything that was close to competent for
generation of PDFs and EPUBs. I reluctantly tried RTD when Sebastien
showed it to me - and was literally blown away - formatting/syntax is
simpler, publishing is dead easy; and not dependent on an individual.

 I am +1 for this change; I think it makes life simpler for anyone who
wants to work on docs, and changes next to nothing for the folks who
only consume them.

--David


RE: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-09 Thread Sateesh Chodapuneedi
+1 for .rst.
Its more developer friendly!

-Regards,
Sateesh

 -Original Message-
 From: sebgoa [mailto:run...@gmail.com]
 Sent: 09 December 2013 17:24
 To: dev@cloudstack.apache.org
 Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
 Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
 
 Hi,
 
 There has been lots of discussion about docs over the last 3/4 months, in 
 summary the issues are:
 
 -Difficult to maintain and keep website up to date (issues with lang and 
 issues with pdf formatting lately) -Difficult to contribute to easily,
 docbook is fine but tedious to work on.
 -Errors in the docs don't get properly fixed -Mix of OS information -Lack of 
 content for certain features -Docs release cycle. Docs have bugs
 that will never get fixed in that specific release (because we see it as code 
 release)
 
 To remedy some of those issues and work on a new release process specific to 
 docs we moved the docs to its own repo:
 
 https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git
 
 *I propose that we move away from docbook and use a more readable format: 
 restructuredtext*
 
 I have worked on a prototype that uses restructured text:
 http://docutils.sourceforge.net/rst.html
 
 This format makes it extremely easy to write docs. Existing docbook content 
 could be converted to .rst using a tool like pandoc:
 http://johnmacfarlane.net/pandoc/
 
 *In addition to changing the format I propose that we use readthedocs.org*
 
 This will help with the release and build of the docs. readthedocs grabs the 
 docs from a git repo, builds html, pdf and epub.
 It can also maintain several releases. We can apply a specific -theme- to our 
 docs.
 
 See a prototype here:
 
 http://cloudstack.readthedocs.org/en/latest/
 
 *I propose that we move to this as early as 4.3 documentation*
 
 Assuming this proposal passes, we would need to:
 
 -re-architect the repo
 -create the proper cnames to be in accordance with trademark guidelines -we 
 can decide what content to keep or not and convert what we
 keep.
 -decide how we organize the content
 -start accepting pull requests (noting that pages can be edited directly from 
 github) -make a first release of this new doc site at the same
 time than 4.3 release.
 
 
 Thoughts, flames ?
 
 
 -Sebastien


Re: Review Request 16122: CLOUDSTACK-4498 cherry picked from 4.2

2013-12-09 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16122/#review30027
---



plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
https://reviews.apache.org/r/16122/#comment57529

Why are you reserving if the flag is false ?


- Nitin Mehta


On Dec. 9, 2013, 10:39 a.m., bharat kumar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16122/
 ---
 
 (Updated Dec. 9, 2013, 10:39 a.m.)
 
 
 Review request for cloudstack and Jayapal Reddy.
 
 
 Bugs: CLOUDSTACK-4498
 https://issues.apache.org/jira/browse/CLOUDSTACK-4498
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
  CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the 
 vmware.reserve.cpu and vmware.reserve.mem are set to false.
 
 
 Diffs
 -
 
   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
 eb3cb6b 
   
 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
  d306b74 
   
 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
  69f1b74 
 
 Diff: https://reviews.apache.org/r/16122/diff/
 
 
 Testing
 ---
 
 tested on master.
 
 
 Thanks,
 
 bharat kumar
 




Re: How to register an event subscriber

2013-12-09 Thread Nitin Mehta
Alex - I think that interface doesn't contain any function definition. So
just create the interface yourself and use the example as given.
You will have to add in the configuration to instantiate this
implementation as well.

Thanks,
-Nitin

On 09/12/13 9:20 AM, Alex Ough alex.o...@sungard.com wrote:

Hi Muali,
Thanks for your information, but in the sample codes,
'EventNotificationSubscriberImpl' implements an interface,
'EventNotificationsSubscriber', but I can't find
'EventNotificationsSubscriber' in the project.
Can you show me where it is located?

Thanks again.
Alex Ough

On Mon, Dec 9, 2013 at 12:30 AM, Murali Reddy murali.re...@citrix.com
wrote:
 On 07/12/13 2:52 AM, Alex Ough alex.o...@sungard.com wrote:

All,

To support the new feature, CLOUDSTACK-4992, I'd like to create an
event subscriber that implements 'EventSubscriber' interface, but I'm
not sure how to register that subscriber to make it running.

 Alex,

 I pasted a subscriber example at [1]. You need to register the
subscriber
 with interested events. Subscriber should implement 'EventSubscriber'.



Do I need to specify it in any config file or load it from anywhere
when the management server is started?

 If your code is expected to run with management server, you can just
load
 the EventBus, and subscribe to it. HTH

 [1] http://pastebin.com/XhFdfa1U


Your reply will be very appreciated.
Thanks
Alex Ough







Re: How to register an event subscriber

2013-12-09 Thread Alex Ough
But I think there seems to be a missing package because I can't find
the package, 'utils', that includes these 2 classes either.

import com.cloud.utils.component.Adapters;
import com.cloud.utils.component.ComponentLocator;

FYI, I'm using the master.

Thanks
Alex Ough

On Mon, Dec 9, 2013 at 12:18 PM, Nitin Mehta nitin.me...@citrix.com wrote:
 Alex - I think that interface doesn't contain any function definition. So
 just create the interface yourself and use the example as given.
 You will have to add in the configuration to instantiate this
 implementation as well.

 Thanks,
 -Nitin

 On 09/12/13 9:20 AM, Alex Ough alex.o...@sungard.com wrote:

Hi Muali,
Thanks for your information, but in the sample codes,
'EventNotificationSubscriberImpl' implements an interface,
'EventNotificationsSubscriber', but I can't find
'EventNotificationsSubscriber' in the project.
Can you show me where it is located?

Thanks again.
Alex Ough

On Mon, Dec 9, 2013 at 12:30 AM, Murali Reddy murali.re...@citrix.com
wrote:
 On 07/12/13 2:52 AM, Alex Ough alex.o...@sungard.com wrote:

All,

To support the new feature, CLOUDSTACK-4992, I'd like to create an
event subscriber that implements 'EventSubscriber' interface, but I'm
not sure how to register that subscriber to make it running.

 Alex,

 I pasted a subscriber example at [1]. You need to register the
subscriber
 with interested events. Subscriber should implement 'EventSubscriber'.



Do I need to specify it in any config file or load it from anywhere
when the management server is started?

 If your code is expected to run with management server, you can just
load
 the EventBus, and subscribe to it. HTH

 [1] http://pastebin.com/XhFdfa1U


Your reply will be very appreciated.
Thanks
Alex Ough








RE: Isolated Network with no Services

2013-12-09 Thread Simon Murphy
works using the api. thanks.

Sent from my Android phone using TouchDown (www.nitrodesk.com)

-Original Message-
From: Murali Reddy [murali.re...@citrix.com]
Received: Tuesday, 10 Dec 2013, 12:42am
To: dev@cloudstack.apache.org [dev@cloudstack.apache.org]; 
us...@cloudstack.apache.org [us...@cloudstack.apache.org]
Subject: Re: Isolated Network with no Services


From the UI yes, you can try with API directly.

On 09/12/13 12:19 PM, Simon Murphy simon.mur...@vifx.co.nz wrote:

I can successfully create the network offering with no services, however
when I go to deploy it is not listed under the available network
offerings.Seems like only Isolated Networks with SourceNAT enabled are
displayedŠis this correct?


Simon Murphy
Solutions Architect

ViFX | Cloud Infrastructure
Level 7, 57 Fort Street, Auckland, New Zealand 1010
PO Box 106700, Auckland, New Zealand 1143
M +64 21 285 4519 | S simon_a_murphy
www.vifx.co.nzhttp://www.vifx.co.nz http://www.vifx.co.nz/ follow us on 
twitter
https://twitter.com/ViFX
Auckland | Wellington | Christchurch



experience. expertise. execution.

This email and any files transmitted with it are confidential, without
prejudice and may contain information that is subject to legal privilege.
It is intended solely for the use of the individual/s to whom it is
addressed in accordance with the provisions of the Privacy Act (1993). The
content contained in this email does not, necessarily, reflect the
official policy position of ViFX nor does ViFX have any responsibility for
any alterations to the contents of this email that may occur following
transmission. If you are not the addressee it may be unlawful for you to
read, copy, distribute, disclose or otherwise use the information
contained within this email. If you are not the intended recipient, please
notify the sender prior to deleting this email message from your system.
Please note ViFX reserves the right to monitor, from time to time, the
communications sent to and from its email network.






On 3/12/13 6:29 PM, Murali Reddy murali.re...@citrix.com wrote:

HTH

http://blog.remibergsma.com/2012/03/10/howto-create-a-network-in-cloudsta
c
k-without-a-virtual-router/

From: Simon Murphy
simon.mur...@vifx.co.nzmailto:simon.mur...@vifx.co.nz
Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Date: Tuesday, 3 December 2013 8:15 AM
To: us...@cloudstack.apache.orgmailto:us...@cloudstack.apache.org
us...@cloudstack.apache.orgmailto:us...@cloudstack.apache.org,
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Subject: Isolated Network with no Services

Is it possible to configure a network offering for an isolated network
that has no services? I would like to give the customer the option to
create a network that is totally isolated (no L3 connectivity) so that
they can bring their own software router/firewall. The isolated network
would be connected to other networks via the customers virtual router.

I can create the network offering however it is not listed as an
available service when I try to create the network.

Cheers,
Simon





Simon Murphy
Solutions Architect

ViFX | Cloud Infrastructure
Level 7, 57 Fort Street, Auckland, New Zealand 1010
PO Box 106700, Auckland, New Zealand 1143
M +64 21 285 4519 | S simon_a_murphy
www.vifx.co.nzhttp://www.vifx.co.nz/ follow us on
twitterhttps://twitter.com/ViFX
Auckland | Wellington | Christchurch

[cid:image003.jpg@01CDDF95.815BF160]

experience. expertise. execution.

This email and any files transmitted with it are confidential, without
prejudice and may contain information that is subject to legal privilege.
It is intended solely for the use of the individual/s to whom it is
addressed in accordance with the provisions of the Privacy Act (1993).
The content contained in this email does not, necessarily, reflect the
official policy position of ViFX nor does ViFX have any responsibility
for any alterations to the contents of this email that may occur
following transmission. If you are not the addressee it may be unlawful
for you to read, copy, distribute, disclose or otherwise use the
information contained within this email. If you are not the intended
recipient, please notify the sender prior to deleting this email message
from your system. Please note ViFX reserves the right to monitor, from
time to time, the communications sent to and from its email network.






Jetty running into an error

2013-12-09 Thread Usman Wyne
Hi all,
I am still new to this and trying to run jetty server i get the following 
errors. Can someone please take a look to see what I could be doing wrong. 
Regards
Usman

On http://localhost:8080/client I get
HTTP ERROR: 503
Problem accessing /client. Reason: 
SERVICE_UNAVAILABLE

Powered by Jetty://



and on http://localhost:8080/
I get
Error 404 - Not Found.No context on this server matched or handled this request.
Contexts known to this server are:
* /client --- 
org.mortbay.jetty.plugin.Jetty6PluginWebAppContext@2830b9bd{/client,C:\cygwin64\home\User\cloudstack\client\target\generated-webapp}

Issue in accessing Windows and Linux VM

2013-12-09 Thread jitendra shelar
Hi All,

Can someone please tell me how to add drivers to the windows VM created
from windows ISO?

Also please tell me how to configure this windows VM to make it accessible
via RDP.

And what all changes I need to make on linux vm to make it accessible via
putty?

Thanks in advance.

Regards,
Jitendra


[4.3 BUG] Egress rules in Palo Alto

2013-12-09 Thread Will Stevens
Hey all,
There is currently a bug in the implementation of egress firewall rules in
the Palo Alto plugin.

Here is the bug: https://issues.apache.org/jira/browse/CLOUDSTACK-5425

I have attached a patch for the 4.3 branch in the bug, but I don't think I
have commit access, so I will need someone else to apply it.

The patch 'should' work on both 4.3 and master, but if not, I will put
together a patch for master.

In this patch I have also addressed 'Issue 1' in this email thread:
http://markmail.org/message/32tspuyjppk4llmi?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Coverage+Analysis:+Few+Issues

Let me know if you have any questions...

Cheers,

Will


Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-09 Thread Hugo Trippaers
Looks good to me.  +1

The format is much more dev friendly so it might help with getting more people 
to write docs. 

Cheers,

Hugo


On 9 dec. 2013, at 18:08, Sateesh Chodapuneedi 
sateesh.chodapune...@citrix.com wrote:

 +1 for .rst.
 Its more developer friendly!
 
 -Regards,
 Sateesh
 
 -Original Message-
 From: sebgoa [mailto:run...@gmail.com]
 Sent: 09 December 2013 17:24
 To: dev@cloudstack.apache.org
 Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
 Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
 
 Hi,
 
 There has been lots of discussion about docs over the last 3/4 months, in 
 summary the issues are:
 
 -Difficult to maintain and keep website up to date (issues with lang and 
 issues with pdf formatting lately) -Difficult to contribute to easily,
 docbook is fine but tedious to work on.
 -Errors in the docs don't get properly fixed -Mix of OS information -Lack of 
 content for certain features -Docs release cycle. Docs have bugs
 that will never get fixed in that specific release (because we see it as 
 code release)
 
 To remedy some of those issues and work on a new release process specific to 
 docs we moved the docs to its own repo:
 
 https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git
 
 *I propose that we move away from docbook and use a more readable format: 
 restructuredtext*
 
 I have worked on a prototype that uses restructured text:
 http://docutils.sourceforge.net/rst.html
 
 This format makes it extremely easy to write docs. Existing docbook content 
 could be converted to .rst using a tool like pandoc:
 http://johnmacfarlane.net/pandoc/
 
 *In addition to changing the format I propose that we use readthedocs.org*
 
 This will help with the release and build of the docs. readthedocs grabs the 
 docs from a git repo, builds html, pdf and epub.
 It can also maintain several releases. We can apply a specific -theme- to 
 our docs.
 
 See a prototype here:
 
 http://cloudstack.readthedocs.org/en/latest/
 
 *I propose that we move to this as early as 4.3 documentation*
 
 Assuming this proposal passes, we would need to:
 
 -re-architect the repo
 -create the proper cnames to be in accordance with trademark guidelines -we 
 can decide what content to keep or not and convert what we
 keep.
 -decide how we organize the content
 -start accepting pull requests (noting that pages can be edited directly 
 from github) -make a first release of this new doc site at the same
 time than 4.3 release.
 
 
 Thoughts, flames ?
 
 
 -Sebastien



Re: 4.3 vmware automation blocker

2013-12-09 Thread Kelven Yang
This issue is caused by trying to solve a mysterious JVM incompatibility
issue in a wrong trying in commit
ed0fbcc81c1928062054190ffcfab8bb59969cc2. Min has already reverted the
commit and this should have fixed the memory issue.

Kelven

On 12/7/13, 5:07 PM, Sateesh Chodapuneedi
sateesh.chodapune...@citrix.com wrote:

 -Original Message-
 From: Rayees Namathponnan [mailto:rayees.namathpon...@citrix.com]
 Sent: 08 December 2013 04:32
 To: dev@cloudstack.apache.org
 Subject: 4.3 vmware automation blocker
 
 Vm deployment failing latest 4.3 build in Vmware environment;   below
defect created
 
 https://issues.apache.org/jira/browse/CLOUDSTACK-5408
 
 
 4.3 automation blocked due to this; someone possible to look this ?

I also observed this.
Upgrading SSVM's service offering to accommodate more memory (784MB
instead of default 256MB) has helped.

Regards,
Sateesh

 
 
 Regards,
 Rayees
 
 
 




RE: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-09 Thread Frank Zhang
+1. 
And suggest using Sphinx with the plugin http://bronto.github.io/javasphinx/

 -Original Message-
 From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
 Sent: Monday, December 09, 2013 2:19 PM
 To: dev@cloudstack.apache.org
 Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
 Subject: Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
 
 Looks good to me.  +1
 
 The format is much more dev friendly so it might help with getting more
 people to write docs.
 
 Cheers,
 
 Hugo
 
 
 On 9 dec. 2013, at 18:08, Sateesh Chodapuneedi
 sateesh.chodapune...@citrix.com wrote:
 
  +1 for .rst.
  Its more developer friendly!
 
  -Regards,
  Sateesh
 
  -Original Message-
  From: sebgoa [mailto:run...@gmail.com]
  Sent: 09 December 2013 17:24
  To: dev@cloudstack.apache.org
  Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
  Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
 
  Hi,
 
  There has been lots of discussion about docs over the last 3/4 months, in
 summary the issues are:
 
  -Difficult to maintain and keep website up to date (issues with lang
  and issues with pdf formatting lately) -Difficult to contribute to easily,
 docbook is fine but tedious to work on.
  -Errors in the docs don't get properly fixed -Mix of OS information
  -Lack of content for certain features -Docs release cycle. Docs have
  bugs that will never get fixed in that specific release (because we
  see it as code release)
 
  To remedy some of those issues and work on a new release process specific
 to docs we moved the docs to its own repo:
 
  https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git
 
  *I propose that we move away from docbook and use a more readable
  format: restructuredtext*
 
  I have worked on a prototype that uses restructured text:
  http://docutils.sourceforge.net/rst.html
 
  This format makes it extremely easy to write docs. Existing docbook content
 could be converted to .rst using a tool like pandoc:
  http://johnmacfarlane.net/pandoc/
 
  *In addition to changing the format I propose that we use
  readthedocs.org*
 
  This will help with the release and build of the docs. readthedocs grabs 
  the
 docs from a git repo, builds html, pdf and epub.
  It can also maintain several releases. We can apply a specific -theme- to 
  our
 docs.
 
  See a prototype here:
 
  http://cloudstack.readthedocs.org/en/latest/
 
  *I propose that we move to this as early as 4.3 documentation*
 
  Assuming this proposal passes, we would need to:
 
  -re-architect the repo
  -create the proper cnames to be in accordance with trademark
  guidelines -we can decide what content to keep or not and convert what we
 keep.
  -decide how we organize the content
  -start accepting pull requests (noting that pages can be edited
  directly from github) -make a first release of this new doc site at the 
  same
 time than 4.3 release.
 
 
  Thoughts, flames ?
 
 
  -Sebastien



SRX/ASA and ACS VPC

2013-12-09 Thread Simon Murphy
Is it possible to offload firewall, SourceNAT and inter-VLAN routing functions 
to hardware devices for VPC networks?


Simon Murphy
Solutions Architect

ViFX | Cloud Infrastructure
Level 7, 57 Fort Street, Auckland, New Zealand 1010
PO Box 106700, Auckland, New Zealand 1143
M +64 21 285 4519 | S simon_a_murphy
www.vifx.co.nzhttp://www.vifx.co.nz/ follow us on 
twitterhttps://twitter.com/ViFX
Auckland | Wellington | Christchurch

[cid:image003.jpg@01CDDF95.815BF160]

experience. expertise. execution.

This email and any files transmitted with it are confidential, without 
prejudice and may contain information that is subject to legal privilege. It is 
intended solely for the use of the individual/s to whom it is addressed in 
accordance with the provisions of the Privacy Act (1993). The content contained 
in this email does not, necessarily, reflect the official policy position of 
ViFX nor does ViFX have any responsibility for any alterations to the contents 
of this email that may occur following transmission. If you are not the 
addressee it may be unlawful for you to read, copy, distribute, disclose or 
otherwise use the information contained within this email. If you are not the 
intended recipient, please notify the sender prior to deleting this email 
message from your system. Please note ViFX reserves the right to monitor, from 
time to time, the communications sent to and from its email network.


Re: 4.3 vmware automation blocker

2013-12-09 Thread Kelven Yang
Oops, not the same problem. 5408 is out of system memory, different than
the one I mentioned about Min¹s fix which is about JVM heap

Kelven

On 12/9/13, 2:53 PM, Kelven Yang kelven.y...@citrix.com wrote:

This issue is caused by trying to solve a mysterious JVM incompatibility
issue in a wrong trying in commit
ed0fbcc81c1928062054190ffcfab8bb59969cc2. Min has already reverted the
commit and this should have fixed the memory issue.

Kelven

On 12/7/13, 5:07 PM, Sateesh Chodapuneedi
sateesh.chodapune...@citrix.com wrote:

 -Original Message-
 From: Rayees Namathponnan [mailto:rayees.namathpon...@citrix.com]
 Sent: 08 December 2013 04:32
 To: dev@cloudstack.apache.org
 Subject: 4.3 vmware automation blocker
 
 Vm deployment failing latest 4.3 build in Vmware environment;   below
defect created
 
 https://issues.apache.org/jira/browse/CLOUDSTACK-5408
 
 
 4.3 automation blocked due to this; someone possible to look this ?

I also observed this.
Upgrading SSVM's service offering to accommodate more memory (784MB
instead of default 256MB) has helped.

Regards,
Sateesh

 
 
 Regards,
 Rayees
 
 
 





Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-09 Thread Chiradeep Vittal
Nice. 
According to http://en.wikipedia.org/wiki/Lightweight_markup_language and
see that it is quite similar to Markdown.

On 12/9/13 2:18 PM, Hugo Trippaers h...@trippaers.nl wrote:

Looks good to me.  +1

The format is much more dev friendly so it might help with getting more
people to write docs.

Cheers,

Hugo


On 9 dec. 2013, at 18:08, Sateesh Chodapuneedi
sateesh.chodapune...@citrix.com wrote:

 +1 for .rst.
 Its more developer friendly!
 
 -Regards,
 Sateesh
 
 -Original Message-
 From: sebgoa [mailto:run...@gmail.com]
 Sent: 09 December 2013 17:24
 To: dev@cloudstack.apache.org
 Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
 Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
 
 Hi,
 
 There has been lots of discussion about docs over the last 3/4 months,
in summary the issues are:
 
 -Difficult to maintain and keep website up to date (issues with lang
and issues with pdf formatting lately) -Difficult to contribute to
easily,
 docbook is fine but tedious to work on.
 -Errors in the docs don't get properly fixed -Mix of OS information
-Lack of content for certain features -Docs release cycle. Docs have
bugs
 that will never get fixed in that specific release (because we see it
as code release)
 
 To remedy some of those issues and work on a new release process
specific to docs we moved the docs to its own repo:
 
 https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git
 
 *I propose that we move away from docbook and use a more readable
format: restructuredtext*
 
 I have worked on a prototype that uses restructured text:
 http://docutils.sourceforge.net/rst.html
 
 This format makes it extremely easy to write docs. Existing docbook
content could be converted to .rst using a tool like pandoc:
 http://johnmacfarlane.net/pandoc/
 
 *In addition to changing the format I propose that we use
readthedocs.org*
 
 This will help with the release and build of the docs. readthedocs
grabs the docs from a git repo, builds html, pdf and epub.
 It can also maintain several releases. We can apply a specific -theme-
to our docs.
 
 See a prototype here:
 
 http://cloudstack.readthedocs.org/en/latest/
 
 *I propose that we move to this as early as 4.3 documentation*
 
 Assuming this proposal passes, we would need to:
 
 -re-architect the repo
 -create the proper cnames to be in accordance with trademark
guidelines -we can decide what content to keep or not and convert what
we
 keep.
 -decide how we organize the content
 -start accepting pull requests (noting that pages can be edited
directly from github) -make a first release of this new doc site at the
same
 time than 4.3 release.
 
 
 Thoughts, flames ?
 
 
 -Sebastien




Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 4.3

2013-12-09 Thread Alena Prokharchyk
There is some regression bug on the latest 4.3 – volumes creation fails on xen 
6.2.0. Steps made:

1) Deployed CS code and redeployed the DB
2) Added xen host to the CS
3) VDI creation fails with generic error message


2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor] 
(DirectAgent-2:ctx-2d667640) can not create vdi in sr 
734481f8-fee3-59d9-20e8-dbe3b8124a78
2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor] 
(DirectAgent-2:ctx-2d667640) Catch Exception 
com.cloud.utils.exception.CloudRuntimeException for template +  due to 
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr 
734481f8-fee3-59d9-20e8-dbe3b8124a78
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr 
734481f8-fee3-59d9-20e8-dbe3b8124a78

Anthony, I wonder if it can be related to your latest changes. Can you please 
take a look as its a blocker.

-Alena.


Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 4.3

2013-12-09 Thread Min Chen
Is this happening in your ssvm startup? If so, go to your xen host,
/opt/cloud/bin folder, check if you have vhd-util there. Not sure why, it
seems that we have changed the directory from previous /opt/xensources to
/opt/cloud. I ran into a similar problem in starting up ssvm.

Thanks
-min

On 12/9/13 3:58 PM, Alena Prokharchyk alena.prokharc...@citrix.com
wrote:

There is some regression bug on the latest 4.3 ­ volumes creation fails
on xen 6.2.0. Steps made:

1) Deployed CS code and redeployed the DB
2) Added xen host to the CS
3) VDI creation fails with generic error message


2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
(DirectAgent-2:ctx-2d667640) can not create vdi in sr
734481f8-fee3-59d9-20e8-dbe3b8124a78
2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
(DirectAgent-2:ctx-2d667640) Catch Exception
com.cloud.utils.exception.CloudRuntimeException for template +  due to
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr
734481f8-fee3-59d9-20e8-dbe3b8124a78
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr
734481f8-fee3-59d9-20e8-dbe3b8124a78

Anthony, I wonder if it can be related to your latest changes. Can you
please take a look as its a blocker.

-Alena.



Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 4.3

2013-12-09 Thread SuichII, Christopher
Any chance this is a vhd-util issue? This is the generic error I generally see 
when vhd-util isn’t in place or can’t be executed.

-Chris
-- 
Chris Suich
chris.su...@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco  Red Hat

On Dec 9, 2013, at 6:58 PM, Alena Prokharchyk alena.prokharc...@citrix.com 
wrote:

 There is some regression bug on the latest 4.3 – volumes creation fails on 
 xen 6.2.0. Steps made:
 
 1) Deployed CS code and redeployed the DB
 2) Added xen host to the CS
 3) VDI creation fails with generic error message
 
 
 2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor] 
 (DirectAgent-2:ctx-2d667640) can not create vdi in sr 
 734481f8-fee3-59d9-20e8-dbe3b8124a78
 2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor] 
 (DirectAgent-2:ctx-2d667640) Catch Exception 
 com.cloud.utils.exception.CloudRuntimeException for template +  due to 
 com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr 
 734481f8-fee3-59d9-20e8-dbe3b8124a78
 com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr 
 734481f8-fee3-59d9-20e8-dbe3b8124a78
 
 Anthony, I wonder if it can be related to your latest changes. Can you please 
 take a look as its a blocker.
 
 -Alena.



Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 4.3

2013-12-09 Thread Alena Prokharchyk
That helped, thank you Min.

It would be nice to get a notification email next time from the person
making this kind of changes to save everybody else’s time on debugging.

-Alena.



On 12/9/13, 4:02 PM, Min Chen min.c...@citrix.com wrote:

Is this happening in your ssvm startup? If so, go to your xen host,
/opt/cloud/bin folder, check if you have vhd-util there. Not sure why, it
seems that we have changed the directory from previous /opt/xensources to
/opt/cloud. I ran into a similar problem in starting up ssvm.

Thanks
-min

On 12/9/13 3:58 PM, Alena Prokharchyk alena.prokharc...@citrix.com
wrote:

There is some regression bug on the latest 4.3 ­ volumes creation fails
on xen 6.2.0. Steps made:

1) Deployed CS code and redeployed the DB
2) Added xen host to the CS
3) VDI creation fails with generic error message


2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
(DirectAgent-2:ctx-2d667640) can not create vdi in sr
734481f8-fee3-59d9-20e8-dbe3b8124a78
2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
(DirectAgent-2:ctx-2d667640) Catch Exception
com.cloud.utils.exception.CloudRuntimeException for template +  due to
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr
734481f8-fee3-59d9-20e8-dbe3b8124a78
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr
734481f8-fee3-59d9-20e8-dbe3b8124a78

Anthony, I wonder if it can be related to your latest changes. Can you
please take a look as its a blocker.

-Alena.




Re: [4.3 BUG] Egress rules in Palo Alto

2013-12-09 Thread Sheng Yang
OK, I would take it.

Thanks!

--Sheng


On Mon, Dec 9, 2013 at 1:11 PM, Will Stevens wstev...@cloudops.com wrote:

 Hey all,
 There is currently a bug in the implementation of egress firewall rules in
 the Palo Alto plugin.

 Here is the bug: https://issues.apache.org/jira/browse/CLOUDSTACK-5425

 I have attached a patch for the 4.3 branch in the bug, but I don't think I
 have commit access, so I will need someone else to apply it.

 The patch 'should' work on both 4.3 and master, but if not, I will put
 together a patch for master.

 In this patch I have also addressed 'Issue 1' in this email thread:

 http://markmail.org/message/32tspuyjppk4llmi?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Coverage+Analysis:+Few+Issues

 Let me know if you have any questions...

 Cheers,

 Will



Re: [4.3 BUG] Egress rules in Palo Alto

2013-12-09 Thread Will Stevens
Thanks Sheng...

Will


On Mon, Dec 9, 2013 at 9:24 PM, Sheng Yang sh...@yasker.org wrote:

 OK, I would take it.

 Thanks!

 --Sheng


 On Mon, Dec 9, 2013 at 1:11 PM, Will Stevens wstev...@cloudops.com
 wrote:

  Hey all,
  There is currently a bug in the implementation of egress firewall rules
 in
  the Palo Alto plugin.
 
  Here is the bug: https://issues.apache.org/jira/browse/CLOUDSTACK-5425
 
  I have attached a patch for the 4.3 branch in the bug, but I don't think
 I
  have commit access, so I will need someone else to apply it.
 
  The patch 'should' work on both 4.3 and master, but if not, I will put
  together a patch for master.
 
  In this patch I have also addressed 'Issue 1' in this email thread:
 
 
 http://markmail.org/message/32tspuyjppk4llmi?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Coverage+Analysis:+Few+Issues
 
  Let me know if you have any questions...
 
  Cheers,
 
  Will
 



Re: [4.3 BUG] Egress rules in Palo Alto

2013-12-09 Thread Sheng Yang
Done, pushed to 4.3 and MASTER branch.

--Sheng


On Mon, Dec 9, 2013 at 6:26 PM, Will Stevens wstev...@cloudops.com wrote:

 Thanks Sheng...

 Will


 On Mon, Dec 9, 2013 at 9:24 PM, Sheng Yang sh...@yasker.org wrote:

  OK, I would take it.
 
  Thanks!
 
  --Sheng
 
 
  On Mon, Dec 9, 2013 at 1:11 PM, Will Stevens wstev...@cloudops.com
  wrote:
 
   Hey all,
   There is currently a bug in the implementation of egress firewall rules
  in
   the Palo Alto plugin.
  
   Here is the bug: https://issues.apache.org/jira/browse/CLOUDSTACK-5425
  
   I have attached a patch for the 4.3 branch in the bug, but I don't
 think
  I
   have commit access, so I will need someone else to apply it.
  
   The patch 'should' work on both 4.3 and master, but if not, I will put
   together a patch for master.
  
   In this patch I have also addressed 'Issue 1' in this email thread:
  
  
 
 http://markmail.org/message/32tspuyjppk4llmi?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Coverage+Analysis:+Few+Issues
  
   Let me know if you have any questions...
  
   Cheers,
  
   Will
  
 



Re: [4.3 BUG] Egress rules in Palo Alto

2013-12-09 Thread Will Stevens
Perfect.  Thank you...


On Mon, Dec 9, 2013 at 9:29 PM, Sheng Yang sh...@yasker.org wrote:

 Done, pushed to 4.3 and MASTER branch.

 --Sheng


 On Mon, Dec 9, 2013 at 6:26 PM, Will Stevens wstev...@cloudops.com
 wrote:

  Thanks Sheng...
 
  Will
 
 
  On Mon, Dec 9, 2013 at 9:24 PM, Sheng Yang sh...@yasker.org wrote:
 
   OK, I would take it.
  
   Thanks!
  
   --Sheng
  
  
   On Mon, Dec 9, 2013 at 1:11 PM, Will Stevens wstev...@cloudops.com
   wrote:
  
Hey all,
There is currently a bug in the implementation of egress firewall
 rules
   in
the Palo Alto plugin.
   
Here is the bug:
 https://issues.apache.org/jira/browse/CLOUDSTACK-5425
   
I have attached a patch for the 4.3 branch in the bug, but I don't
  think
   I
have commit access, so I will need someone else to apply it.
   
The patch 'should' work on both 4.3 and master, but if not, I will
 put
together a patch for master.
   
In this patch I have also addressed 'Issue 1' in this email thread:
   
   
  
 
 http://markmail.org/message/32tspuyjppk4llmi?q=list:org%2Eapache%2Eincubator%2Ecloudstack-%2A+Coverage+Analysis:+Few+Issues
   
Let me know if you have any questions...
   
Cheers,
   
Will
   
  
 



RE: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 4.3

2013-12-09 Thread Anthony Xu
Always put vhd-util in your cloudstack source tree, 
scripts/vm/hypervisor/xenserver/


Anthony

-Original Message-
From: Alena Prokharchyk 
Sent: Monday, December 09, 2013 4:49 PM
To: dev@cloudstack.apache.org; Anthony Xu
Subject: Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 
4.3

That helped, thank you Min.

It would be nice to get a notification email next time from the person making 
this kind of changes to save everybody else's time on debugging.

-Alena.



On 12/9/13, 4:02 PM, Min Chen min.c...@citrix.com wrote:

Is this happening in your ssvm startup? If so, go to your xen host, 
/opt/cloud/bin folder, check if you have vhd-util there. Not sure why, 
it seems that we have changed the directory from previous 
/opt/xensources to /opt/cloud. I ran into a similar problem in starting up 
ssvm.

Thanks
-min

On 12/9/13 3:58 PM, Alena Prokharchyk alena.prokharc...@citrix.com
wrote:

There is some regression bug on the latest 4.3  volumes creation 
fails on xen 6.2.0. Steps made:

1) Deployed CS code and redeployed the DB
2) Added xen host to the CS
3) VDI creation fails with generic error message


2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
(DirectAgent-2:ctx-2d667640) can not create vdi in sr
734481f8-fee3-59d9-20e8-dbe3b8124a78
2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
(DirectAgent-2:ctx-2d667640) Catch Exception 
com.cloud.utils.exception.CloudRuntimeException for template +  due to
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in 
sr
734481f8-fee3-59d9-20e8-dbe3b8124a78
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in 
sr
734481f8-fee3-59d9-20e8-dbe3b8124a78

Anthony, I wonder if it can be related to your latest changes. Can you 
please take a look as its a blocker.

-Alena.




RE: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-09 Thread Animesh Chaturvedi
I am +1 to make documentation easier but we just passed code freeze for 4.3 and 
I feel we need to do it after 4.3.  


Animesh

-Original Message-
From: sebgoa [mailto:run...@gmail.com] 
Sent: Monday, December 09, 2013 3:54 AM
To: dev@cloudstack.apache.org
Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

Hi,

There has been lots of discussion about docs over the last 3/4 months, in 
summary the issues are:

-Difficult to maintain and keep website up to date (issues with lang and issues 
with pdf formatting lately) -Difficult to contribute to easily, docbook is fine 
but tedious to work on.
-Errors in the docs don't get properly fixed -Mix of OS information -Lack of 
content for certain features -Docs release cycle. Docs have bugs that will 
never get fixed in that specific release (because we see it as code release)

To remedy some of those issues and work on a new release process specific to 
docs we moved the docs to its own repo:

https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git

*I propose that we move away from docbook and use a more readable format: 
restructuredtext*

I have worked on a prototype that uses restructured text:
http://docutils.sourceforge.net/rst.html

This format makes it extremely easy to write docs. Existing docbook content 
could be converted to .rst using a tool like pandoc:
http://johnmacfarlane.net/pandoc/

*In addition to changing the format I propose that we use readthedocs.org*

This will help with the release and build of the docs. readthedocs grabs the 
docs from a git repo, builds html, pdf and epub.
It can also maintain several releases. We can apply a specific -theme- to our 
docs. 

See a prototype here:

http://cloudstack.readthedocs.org/en/latest/

*I propose that we move to this as early as 4.3 documentation*

Assuming this proposal passes, we would need to:

-re-architect the repo
-create the proper cnames to be in accordance with trademark guidelines -we can 
decide what content to keep or not and convert what we keep.
-decide how we organize the content
-start accepting pull requests (noting that pages can be edited directly from 
github) -make a first release of this new doc site at the same time than 4.3 
release.


Thoughts, flames ?


-Sebastien


Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 4.3

2013-12-09 Thread Koushik Das
I see that for XS the location of script files in the host has changed from 
/opt/xensource/bin to /opt/cloud/bin. On latest master branch I see that the 
scripts are still getting placed in the old location while adding a host. Is 
there any commit missed out on master?

-Koushik

On 10-Dec-2013, at 8:06 AM, Anthony Xu xuefei...@citrix.com wrote:

 Always put vhd-util in your cloudstack source tree, 
 scripts/vm/hypervisor/xenserver/
 
 
 Anthony
 
 -Original Message-
 From: Alena Prokharchyk 
 Sent: Monday, December 09, 2013 4:49 PM
 To: dev@cloudstack.apache.org; Anthony Xu
 Subject: Re: Blocker bug: can't create the volumes on Xen 6.2.0 on the latest 
 4.3
 
 That helped, thank you Min.
 
 It would be nice to get a notification email next time from the person making 
 this kind of changes to save everybody else's time on debugging.
 
 -Alena.
 
 
 
 On 12/9/13, 4:02 PM, Min Chen min.c...@citrix.com wrote:
 
 Is this happening in your ssvm startup? If so, go to your xen host, 
 /opt/cloud/bin folder, check if you have vhd-util there. Not sure why, 
 it seems that we have changed the directory from previous 
 /opt/xensources to /opt/cloud. I ran into a similar problem in starting up 
 ssvm.
 
 Thanks
 -min
 
 On 12/9/13 3:58 PM, Alena Prokharchyk alena.prokharc...@citrix.com
 wrote:
 
 There is some regression bug on the latest 4.3  volumes creation 
 fails on xen 6.2.0. Steps made:
 
 1) Deployed CS code and redeployed the DB
 2) Added xen host to the CS
 3) VDI creation fails with generic error message
 
 
 2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
 (DirectAgent-2:ctx-2d667640) can not create vdi in sr
 734481f8-fee3-59d9-20e8-dbe3b8124a78
 2013-12-09 15:56:44,629 WARN  [c.c.h.x.r.XenServerStorageProcessor]
 (DirectAgent-2:ctx-2d667640) Catch Exception 
 com.cloud.utils.exception.CloudRuntimeException for template +  due to
 com.cloud.utils.exception.CloudRuntimeException: can not create vdi in 
 sr
 734481f8-fee3-59d9-20e8-dbe3b8124a78
 com.cloud.utils.exception.CloudRuntimeException: can not create vdi in 
 sr
 734481f8-fee3-59d9-20e8-dbe3b8124a78
 
 Anthony, I wonder if it can be related to your latest changes. Can you 
 please take a look as its a blocker.
 
 -Alena.
 
 



Re: Review Request 16122: CLOUDSTACK-4498 cherry picked from 4.2

2013-12-09 Thread bharat kumar


 On Dec. 9, 2013, 6:03 p.m., Nitin Mehta wrote:
  plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java,
   line 3007
  https://reviews.apache.org/r/16122/diff/2/?file=395664#file395664line3007
 
  Why are you reserving if the flag is false ?

Hi Nitin, 
this patch is not related to the https://reviews.apache.org/r/15349/. will 
upload it once this gets shipped.  


- bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16122/#review30027
---


On Dec. 9, 2013, 10:39 a.m., bharat kumar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16122/
 ---
 
 (Updated Dec. 9, 2013, 10:39 a.m.)
 
 
 Review request for cloudstack and Jayapal Reddy.
 
 
 Bugs: CLOUDSTACK-4498
 https://issues.apache.org/jira/browse/CLOUDSTACK-4498
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
  CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the 
 vmware.reserve.cpu and vmware.reserve.mem are set to false.
 
 
 Diffs
 -
 
   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
 eb3cb6b 
   
 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
  d306b74 
   
 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
  69f1b74 
 
 Diff: https://reviews.apache.org/r/16122/diff/
 
 
 Testing
 ---
 
 tested on master.
 
 
 Thanks,
 
 bharat kumar
 




Merge AutoScaling without NetScaler to MASTER

2013-12-09 Thread Nguyen Anh Tu
Dear guys,

I already merged two features AutoScaling without NetScaler and also
improving GRE source code to MASTER branch.

Ping me for any problem.

Cheers,

--Tuna


[PROPOSAL] Cloudstack network-element plugin to orchestrate Juniper's switches (for L2 services)

2013-12-09 Thread Pradeep Cloudstack
Hi,
my name is Pradeep HK and I am from Juniper Networks, Bangalore.

I have prepared a Design Document for the feature mentioned in the subject. It 
is being targetted for 4.4.

Pls review the Design document -
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+network-element+plugin+to+orchestrate+Juniper%27s+switches+%28for+L2+services%29

and send me your comments

-Pradeep

Re: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs

2013-12-09 Thread Sebastien Goasguen

On Dec 9, 2013, at 9:37 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com 
wrote:

 I am +1 to make documentation easier but we just passed code freeze for 4.3 
 and I feel we need to do it after 4.3.  
 

docs are not in the 4.3 code branch. it's different releases...

 
 Animesh
 
 -Original Message-
 From: sebgoa [mailto:run...@gmail.com] 
 Sent: Monday, December 09, 2013 3:54 AM
 To: dev@cloudstack.apache.org
 Cc: Radhika Puthiyetath; msweet@gmail.com; Mike Tutkowski
 Subject: [DISCUSS][PROPOSAL] Move docs to .rst format and readthedocs
 
 Hi,
 
 There has been lots of discussion about docs over the last 3/4 months, in 
 summary the issues are:
 
 -Difficult to maintain and keep website up to date (issues with lang and 
 issues with pdf formatting lately) -Difficult to contribute to easily, 
 docbook is fine but tedious to work on.
 -Errors in the docs don't get properly fixed -Mix of OS information -Lack of 
 content for certain features -Docs release cycle. Docs have bugs that will 
 never get fixed in that specific release (because we see it as code release)
 
 To remedy some of those issues and work on a new release process specific to 
 docs we moved the docs to its own repo:
 
 https://git-wip-us.apache.org/repos/asf?p=cloudstack-docs.git
 
 *I propose that we move away from docbook and use a more readable format: 
 restructuredtext*
 
 I have worked on a prototype that uses restructured text:
 http://docutils.sourceforge.net/rst.html
 
 This format makes it extremely easy to write docs. Existing docbook content 
 could be converted to .rst using a tool like pandoc:
 http://johnmacfarlane.net/pandoc/
 
 *In addition to changing the format I propose that we use readthedocs.org*
 
 This will help with the release and build of the docs. readthedocs grabs the 
 docs from a git repo, builds html, pdf and epub.
 It can also maintain several releases. We can apply a specific -theme- to our 
 docs. 
 
 See a prototype here:
 
 http://cloudstack.readthedocs.org/en/latest/
 
 *I propose that we move to this as early as 4.3 documentation*
 
 Assuming this proposal passes, we would need to:
 
 -re-architect the repo
 -create the proper cnames to be in accordance with trademark guidelines -we 
 can decide what content to keep or not and convert what we keep.
 -decide how we organize the content
 -start accepting pull requests (noting that pages can be edited directly from 
 github) -make a first release of this new doc site at the same time than 4.3 
 release.
 
 
 Thoughts, flames ?
 
 
 -Sebastien