Review Request 16465: fixed the listvirtualmachines API to show cpu, memory and cpucores when using custom compute offering
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16465/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-5472 https://issues.apache.org/jira/browse/CLOUDSTACK-5472 Repository: cloudstack-git Description --- CLOUDSTACK-5472 fixed the listvirtualmachines API to show cpu, memory and cpucores when using custom compute offering https://issues.apache.org/jira/browse/CLOUDSTACK-5472 Diffs - Diff: https://reviews.apache.org/r/16465/diff/ Testing --- Tested on 4.3 Thanks, bharat kumar
Review Request 16466: CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/ --- Review request for cloudstack and Min Chen. Bugs: CLOUDSTACK-5530 https://issues.apache.org/jira/browse/CLOUDSTACK-5530 Repository: cloudstack-git Description --- CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored Diffs - server/src/com/cloud/storage/StorageManagerImpl.java a96a4ee Diff: https://reviews.apache.org/r/16466/diff/ Testing --- Tested 4.3 Thanks, bharat kumar
Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30864 --- Commit d825b3dd141c76c0af8d02bac2147378a3506e96 in branch refs/heads/4.3 from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d825b3d ] CLOUDSTACK-4622:If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier Signed-off-by: Jayapal jaya...@apache.org - ASF Subversion and Git Services On Dec. 24, 2013, 9:20 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/ --- (Updated Dec. 24, 2013, 9:20 a.m.) Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-4622 https://issues.apache.org/jira/browse/CLOUDSTACK-4622 Repository: cloudstack-git Description --- Add a new utility method for comparing 2 CIDRs. The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP range is equal or a subset of cidrB's IP range. Diffs - utils/src/com/cloud/utils/net/NetUtils.java f6f6285 utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf Diff: https://reviews.apache.org/r/14124/diff/ Testing --- Added unit test for the utility. Tested locally. Build is successful. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30865 --- Ship it! Ship It! - Jayapal Reddy On Dec. 24, 2013, 9:20 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/ --- (Updated Dec. 24, 2013, 9:20 a.m.) Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-4622 https://issues.apache.org/jira/browse/CLOUDSTACK-4622 Repository: cloudstack-git Description --- Add a new utility method for comparing 2 CIDRs. The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP range is equal or a subset of cidrB's IP range. Diffs - utils/src/com/cloud/utils/net/NetUtils.java f6f6285 utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf Diff: https://reviews.apache.org/r/14124/diff/ Testing --- Added unit test for the utility. Tested locally. Build is successful. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30866 --- Commit ab4f095c68d4a4b4fb354b3d95096b193706987d in branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ab4f095 ] CLOUDSTACK-4622:If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier Signed-off-by: Jayapal jaya...@apache.org - ASF Subversion and Git Services On Dec. 24, 2013, 9:20 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/ --- (Updated Dec. 24, 2013, 9:20 a.m.) Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-4622 https://issues.apache.org/jira/browse/CLOUDSTACK-4622 Repository: cloudstack-git Description --- Add a new utility method for comparing 2 CIDRs. The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP range is equal or a subset of cidrB's IP range. Diffs - utils/src/com/cloud/utils/net/NetUtils.java f6f6285 utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf Diff: https://reviews.apache.org/r/14124/diff/ Testing --- Added unit test for the utility. Tested locally. Build is successful. Patch applies cleanly. Thanks, Saksham Srivastava
Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5638 https://issues.apache.org/jira/browse/CLOUDSTACK-5638 Repository: cloudstack-git Description --- test_02_NetworkGarbageCollection was failing on XenServer advances setup while checking the router state. Sometimes, it needs more time for router to come up in running state, so modified code to check the router state after definite time intervals, it will fail after timeout (180 Seconds for now). Diffs - test/integration/component/test_routers.py 5f1ebc6 Diff: https://reviews.apache.org/r/16467/diff/ Testing --- Tested locally: Log: Test advanced zone router services ... SKIP: Skip Test network garbage collection ... ok Test router start on VM deploy ... SKIP: Skip Test router stop create Firewall rule ... SKIP: Skip Test router stop create Load balancing ... SKIP: Skip Test router stop create port forwarding ... SKIP: Skip -- Ran 6 tests in 799.271s OK (SKIP=5) Thanks, Gaurav Aradhye
Re: Regarding contribution to CloudStack project
Hi Abhinav! On 12/23/2013 05:27 PM, Abhinav Koppula wrote: Hi all, I am Abhinav Koppula, a senior undergraduate student pursuing my Bachelors in India. I am interested in contributing towards the Apache CloudStack project. I would be really glad if anyone could guide me on how I can get started. Also, I wanted to know if there are any pre-requisites(in terms of computer science concepts) which I need to cover before starting off. Well, we don't require anything. You can start contributing right away if you want to. I am skilled in Java but however I do not have prior experience of working on cloud computing platforms. What books/resources should I refer which would help me in understanding the code-base easily? There are no real books on CloudStack and how to code for it. This is impossible to write at this moment since a lot changes in CloudStack. I recommend you start with cloning the source and you start to understand the code. Are there any particular things you want to work on? If so, we can point you in to the right direction to where to look. Wido Thanks, Abhinav Koppula
Re: Regarding contribution to CloudStack project
There is this book on Amazon (I read it when I started working on CloudStack, but - as Wido says - CloudStack development moves fast, so not all details in this book are still accurate, but the high-level areas generally still apply): http://www.amazon.com/Apache-CloudStack-Cloud-Computing-Sabharwal/dp/1782160108 On Thu, Dec 26, 2013 at 7:09 AM, Wido den Hollander w...@widodh.nl wrote: Hi Abhinav! On 12/23/2013 05:27 PM, Abhinav Koppula wrote: Hi all, I am Abhinav Koppula, a senior undergraduate student pursuing my Bachelors in India. I am interested in contributing towards the Apache CloudStack project. I would be really glad if anyone could guide me on how I can get started. Also, I wanted to know if there are any pre-requisites(in terms of computer science concepts) which I need to cover before starting off. Well, we don't require anything. You can start contributing right away if you want to. I am skilled in Java but however I do not have prior experience of working on cloud computing platforms. What books/resources should I refer which would help me in understanding the code-base easily? There are no real books on CloudStack and how to code for it. This is impossible to write at this moment since a lot changes in CloudStack. I recommend you start with cloning the source and you start to understand the code. Are there any particular things you want to work on? If so, we can point you in to the right direction to where to look. Wido Thanks, Abhinav Koppula -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Fwd: KVM - LibvirtDomainXMLParser did not support interface type='direct'
HI All
In this document
https://cwiki.apache.org/confluence/display/CLOUDSTACK/LXC+Support+in+Cloudstack,
CloudStack should support direct mode.
Direct Networking
Libvirt supports direct
attachmenthttp://libvirt.org/formatdomain.html#elementsNICSDirectof
the guest VM's network to a physical interface. To enable this mode,
add
the following to agent.properties:
libvirt.vif.driver=com.cloud.hypervisor.kvm.resource.DirectVifDriver
network.direct.source.mode=private (other values: bridge|vepa)
network.direct.device=eth0
But I found the following code may cause some problem, when the nic
interface type is direct
If type is direct , then this nic will be ignore.
Should I open a JIRA ticket ? and patch it ?
String type = nic.getAttribute(type);
String mac = getAttrValue(mac, address, nic);
String dev = getAttrValue(target, dev, nic);
String model = getAttrValue(model, type, nic);
InterfaceDef def = new InterfaceDef();
NodeList bandwidth = nic.getElementsByTagName(bandwidth);
Integer networkRateKBps = 0;
if ((bandwidth != null) (bandwidth.getLength() != 0)) {
Integer inbound =
Integer.valueOf(getAttrValue(inbound, average,
(Element)bandwidth.item(0)));
Integer outbound =
Integer.valueOf(getAttrValue(outbound, average,
(Element)bandwidth.item(0)));
if (inbound == outbound)
networkRateKBps = inbound;
}
if (type.equalsIgnoreCase(network)) {
String network = getAttrValue(source, network, nic);
def.defPrivateNet(network, dev, mac,
nicModel.valueOf(model.toUpperCase()), networkRateKBps);
} else if (type.equalsIgnoreCase(bridge)) {
String bridge = getAttrValue(source, bridge, nic);
def.defBridgeNet(bridge, dev, mac,
nicModel.valueOf(model.toUpperCase()), networkRateKBps);
} else if (type.equalsIgnoreCase(ethernet)) {
String scriptPath = getAttrValue(script, path, nic);
def.defEthernet(dev, mac,
nicModel.valueOf(model.toUpperCase()), scriptPath, networkRateKBps);
}
interfaces.add(def);
Howie
KVM - LibvirtDomainXMLParser did not support interface type='direct'
HI
In this document
https://cwiki.apache.org/confluence/display/CLOUDSTACK/LXC+Support+in+Cloudstack,
CloudStack should support direct mode.
Direct Networking
Libvirt supports direct
attachmenthttp://libvirt.org/formatdomain.html#elementsNICSDirectof
the guest VM's network to a physical interface. To enable this mode,
add
the following to agent.properties:
libvirt.vif.driver=com.cloud.hypervisor.kvm.resource.DirectVifDriver
network.direct.source.mode=private (other values: bridge|vepa)
network.direct.device=eth0
But I found the following code may cause some problem, when the nic
interface type is direct
If type is direct , then this nic will be ignore.
Should I open a JIRA ticket ? and patch it ?
String type = nic.getAttribute(type);
String mac = getAttrValue(mac, address, nic);
String dev = getAttrValue(target, dev, nic);
String model = getAttrValue(model, type, nic);
InterfaceDef def = new InterfaceDef();
NodeList bandwidth = nic.getElementsByTagName(bandwidth);
Integer networkRateKBps = 0;
if ((bandwidth != null) (bandwidth.getLength() != 0)) {
Integer inbound =
Integer.valueOf(getAttrValue(inbound, average,
(Element)bandwidth.item(0)));
Integer outbound =
Integer.valueOf(getAttrValue(outbound, average,
(Element)bandwidth.item(0)));
if (inbound == outbound)
networkRateKBps = inbound;
}
if (type.equalsIgnoreCase(network)) {
String network = getAttrValue(source, network, nic);
def.defPrivateNet(network, dev, mac,
nicModel.valueOf(model.toUpperCase()), networkRateKBps);
} else if (type.equalsIgnoreCase(bridge)) {
String bridge = getAttrValue(source, bridge, nic);
def.defBridgeNet(bridge, dev, mac,
nicModel.valueOf(model.toUpperCase()), networkRateKBps);
} else if (type.equalsIgnoreCase(ethernet)) {
String scriptPath = getAttrValue(script, path, nic);
def.defEthernet(dev, mac,
nicModel.valueOf(model.toUpperCase()), scriptPath, networkRateKBps);
}
interfaces.add(def);
Howie
Re: Issue in accessing Windows and Linux VM
Thanks Sanjeev,Kirk,Frankie, Daan. @Sanjeev, I have deployed VMs in isolated network. I will try with it. Regards, Jitendra On Thu, Dec 26, 2013 at 5:20 AM, Sanjeev Neelarapu sanjeev.neelar...@citrix.com wrote: Hi Jitendra, If you have deployed vms in an isolated networks , acquire one IP address in the network in which vms have been deployed and configure PF/Statick Nat rule and assign the guest vms you want to accesss. Also allow the ports on which you want to access windows vm via RDP or linux vm via putty in the Firewall. -Sanjeev -Original Message- From: Frankie Onuonga [mailto:frankie.onuo...@gmail.com] Sent: Wednesday, December 25, 2013 1:00 PM To: dev@cloudstack.apache.org Cc: issues-subscr...@cloudstack.apache.org; us...@cloudstack.apache.org Subject: Re: Issue in accessing Windows and Linux VM Hi, I do not know much about windows, but your linux issue is pretty simple, you just need to ensure you have ssh installed, thanks. On Mon, Dec 23, 2013 at 6:43 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Jitendra, I am not sure what you expect as an answer but it seems to me you want to configure those machines in the console and then create shapshots and then new templates from those. Correct? Otherwise I don't see how these are cloudstack questions, regards On Mon, Dec 9, 2013 at 8:48 PM, jitendra shelar jitendra.shelar...@gmail.com wrote: Hi All, Can someone please tell me how to add drivers to the windows VM created from windows ISO? Also please tell me how to configure this windows VM to make it accessible via RDP. And what all changes I need to make on linux vm to make it accessible via putty? Thanks in advance. Regards, Jitendra -- Skype: Frankie.Onuonga twitter: Frankieonuonga irc #freenode: Frankie.onuonga
Re: Regarding contribution to CloudStack project
Hi Abhinav, Nice that you have taken interest in cloudstack. It is really excellent. Free ebook is available at below link. http://it-ebooks.info/book/2930/ Thanks, Jitendra On Thu, Dec 26, 2013 at 5:33 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: There is this book on Amazon (I read it when I started working on CloudStack, but - as Wido says - CloudStack development moves fast, so not all details in this book are still accurate, but the high-level areas generally still apply): http://www.amazon.com/Apache-CloudStack-Cloud-Computing-Sabharwal/dp/1782160108 On Thu, Dec 26, 2013 at 7:09 AM, Wido den Hollander w...@widodh.nl wrote: Hi Abhinav! On 12/23/2013 05:27 PM, Abhinav Koppula wrote: Hi all, I am Abhinav Koppula, a senior undergraduate student pursuing my Bachelors in India. I am interested in contributing towards the Apache CloudStack project. I would be really glad if anyone could guide me on how I can get started. Also, I wanted to know if there are any pre-requisites(in terms of computer science concepts) which I need to cover before starting off. Well, we don't require anything. You can start contributing right away if you want to. I am skilled in Java but however I do not have prior experience of working on cloud computing platforms. What books/resources should I refer which would help me in understanding the code-base easily? There are no real books on CloudStack and how to code for it. This is impossible to write at this moment since a lot changes in CloudStack. I recommend you start with cloning the source and you start to understand the code. Are there any particular things you want to work on? If so, we can point you in to the right direction to where to look. Wido Thanks, Abhinav Koppula -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: [ACS43] Schedule Reminder : 4 weeks to RC
Vlan id is required when add ip range to the public network, does anyone know when that was decided? It used to be that you could just create a public bridge and go with it (vlan = 'untagged'), now cloudstack requires a tagged vlan? On Thu, Dec 19, 2013 at 6:44 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: Thursday, December 19, 2013 12:03 AM To: dev@cloudstack.apache.org Subject: Re: [ACS43] Schedule Reminder : 4 weeks to RC Animesh, One week before the RC, can we stop commit and have you as the only committer to that branch. I think it would help reduce the number of RC respins/vote if we have a stable branch ahead of the RC for testing. -sebastien [Animesh] That depends on the backlog at that time. If it is manageable I am fine with cherry-picking. On Dec 13, 2013, at 7:31 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Fixed one typo the branch is 4.3 not 4.2 -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Friday, December 13, 2013 10:29 AM To: dev@cloudstack.apache.org Subject: [ACS43] Schedule Reminder : 4 weeks to RC Folks we are now 4 weeks from ACS 43 targeted RC date of 1/10. Code changes are now limited to blockers and critical. I need help with doc and translations in preparation for RC. The issue resolution rate has picked up in last 2 weeks but we still have close to 100 blocker and critical, please help out in getting the issues resolved to bring the backlog to manageable number. Given the backlog we will follow what we did for ACS 4.1 and ACS 4.2. Up until when we cut the first RC on (2014-01-10) committers should continue to check in fixes to 4.3 branch for blocker and critical issues. Please do any fixes as cleanly as possible. For Contributors if you have a fix that needs to go into 4.3, please email the list with the subject tag [ACS43] and note the review that contains the patch. I'll pick whichever I can, but will also rely on others with commit rights to make it efficient. I will create a staging branch after first RC and will start cherry-pick then. RC re-spins are drain on everyone so I will request you to start playing with 4.3 and report issues early on. There are large number of issues that are resolved but not verified yet. Given that the number is huge with around 100 blocker and critical we need to prioritize and verify the ones that were returned by developers as ( Invalid,Incomplete, CanNotReproduce, Later, NotAProblem) first. I have created a filter[1] to facilitate identifying these issues. This is no way means not to verify other issues but it is to close on the ones that have the most likelihood of being reopened during verification. For up to date information on release please check out the release dashboard [2] 1] ResolvedButNotClosedFilter: https://issues.apache.org/jira/issues/#?filter=12324570 [2] Release Dashboard: http://s.apache.org/dFk Thanks Animesh
Re: Review Request 16466: CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/#review30880 --- Ship it! Ship It! - Min Chen On Dec. 26, 2013, 10:09 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/ --- (Updated Dec. 26, 2013, 10:09 a.m.) Review request for cloudstack and Min Chen. Bugs: CLOUDSTACK-5530 https://issues.apache.org/jira/browse/CLOUDSTACK-5530 Repository: cloudstack-git Description --- CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored Diffs - server/src/com/cloud/storage/StorageManagerImpl.java a96a4ee Diff: https://reviews.apache.org/r/16466/diff/ Testing --- Tested 4.3 Thanks, bharat kumar
Re: [ACS43] Schedule Reminder : 4 weeks to RC
Looks like it goes to aaf3979c on the 20th, I'll follow up there. It breaks my test suite, and probably how many others are used to deploying. CLOUDSTACK-5502: interpret vlan='untagged' as vlan == null On Thu, Dec 26, 2013 at 12:32 PM, Marcus Sorensen shadow...@gmail.com wrote: Vlan id is required when add ip range to the public network, does anyone know when that was decided? It used to be that you could just create a public bridge and go with it (vlan = 'untagged'), now cloudstack requires a tagged vlan? On Thu, Dec 19, 2013 at 6:44 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: Thursday, December 19, 2013 12:03 AM To: dev@cloudstack.apache.org Subject: Re: [ACS43] Schedule Reminder : 4 weeks to RC Animesh, One week before the RC, can we stop commit and have you as the only committer to that branch. I think it would help reduce the number of RC respins/vote if we have a stable branch ahead of the RC for testing. -sebastien [Animesh] That depends on the backlog at that time. If it is manageable I am fine with cherry-picking. On Dec 13, 2013, at 7:31 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Fixed one typo the branch is 4.3 not 4.2 -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Friday, December 13, 2013 10:29 AM To: dev@cloudstack.apache.org Subject: [ACS43] Schedule Reminder : 4 weeks to RC Folks we are now 4 weeks from ACS 43 targeted RC date of 1/10. Code changes are now limited to blockers and critical. I need help with doc and translations in preparation for RC. The issue resolution rate has picked up in last 2 weeks but we still have close to 100 blocker and critical, please help out in getting the issues resolved to bring the backlog to manageable number. Given the backlog we will follow what we did for ACS 4.1 and ACS 4.2. Up until when we cut the first RC on (2014-01-10) committers should continue to check in fixes to 4.3 branch for blocker and critical issues. Please do any fixes as cleanly as possible. For Contributors if you have a fix that needs to go into 4.3, please email the list with the subject tag [ACS43] and note the review that contains the patch. I'll pick whichever I can, but will also rely on others with commit rights to make it efficient. I will create a staging branch after first RC and will start cherry-pick then. RC re-spins are drain on everyone so I will request you to start playing with 4.3 and report issues early on. There are large number of issues that are resolved but not verified yet. Given that the number is huge with around 100 blocker and critical we need to prioritize and verify the ones that were returned by developers as ( Invalid,Incomplete, CanNotReproduce, Later, NotAProblem) first. I have created a filter[1] to facilitate identifying these issues. This is no way means not to verify other issues but it is to close on the ones that have the most likelihood of being reopened during verification. For up to date information on release please check out the release dashboard [2] 1] ResolvedButNotClosedFilter: https://issues.apache.org/jira/issues/#?filter=12324570 [2] Release Dashboard: http://s.apache.org/dFk Thanks Animesh
Re: Review Request 16466: CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/#review30881 --- Commit 69fb1d4ed04156b61ca7993516d6ca02e72d45a2 in branch refs/heads/4.3 from Bharat Kumar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=69fb1d4 ] CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored - ASF Subversion and Git Services On Dec. 26, 2013, 10:09 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/ --- (Updated Dec. 26, 2013, 10:09 a.m.) Review request for cloudstack and Min Chen. Bugs: CLOUDSTACK-5530 https://issues.apache.org/jira/browse/CLOUDSTACK-5530 Repository: cloudstack-git Description --- CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored Diffs - server/src/com/cloud/storage/StorageManagerImpl.java a96a4ee Diff: https://reviews.apache.org/r/16466/diff/ Testing --- Tested 4.3 Thanks, bharat kumar
Re: Review Request 16293: CLOUDSTACK-5264: Xenserver - Full Snapshots are not being created even after snapshot.delta.max is exceeded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16293/#review30882 --- Edison has fixed this bug, so this patch is not needed. - Min Chen On Dec. 16, 2013, 1:19 p.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16293/ --- (Updated Dec. 16, 2013, 1:19 p.m.) Review request for cloudstack and Min Chen. Bugs: CLOUDSTACK-5264 https://issues.apache.org/jira/browse/CLOUDSTACK-5264 Repository: cloudstack-git Description --- CLOUDSTACK-5264: Xenserver - Full Snapshots are not being created even after snapshot.delta.max is exceeded Fixed the code that decides whether to take full snapshot or not based on the configuration parameter snapshot.delta.max Diffs - core/src/org/apache/cloudstack/storage/to/SnapshotObjectTO.java 34e977c engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java 67cc324 engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java 69900af plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageProcessor.java 5a19aee server/src/com/cloud/storage/CreateSnapshotPayload.java 3bc571e Diff: https://reviews.apache.org/r/16293/diff/ Testing --- Tested locally by setting the value of snapshot.delta.max to 4 and checked for 4 delta snapshots. Thanks, Harikrishna Patnala
Re: Review Request 16466: CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/#review30887 --- Commit fead6706ff25f42b6185aa2c41856778f639cc76 in branch refs/heads/master from Bharat Kumar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fead670 ] CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored - ASF Subversion and Git Services On Dec. 26, 2013, 10:09 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/ --- (Updated Dec. 26, 2013, 10:09 a.m.) Review request for cloudstack and Min Chen. Bugs: CLOUDSTACK-5530 https://issues.apache.org/jira/browse/CLOUDSTACK-5530 Repository: cloudstack-git Description --- CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored Diffs - server/src/com/cloud/storage/StorageManagerImpl.java a96a4ee Diff: https://reviews.apache.org/r/16466/diff/ Testing --- Tested 4.3 Thanks, bharat kumar
custom_parameters in deployVm call
Bharat, I’ve noticed that you’ve added a new parameter to deployVm API -“customparameters”. The description of the parameter is very vague and generic “used to specify the custom parameters”. Is it just the metadata in form of value/key pairs? If so, please change the name to “details” - the generic name used when specify key/value metadata in other API commands. Also you need to save this information in the “user_vm_details” table, and return it in the UserVmResponse, “details” map parameter. I don’t see “custom parameters” key map being returned anywhere in the UserVmResponse. Its very confusing, because whatever is passed to the Create/Update call, should be returned in the response as well. It all has to be fixed in 4.3 branch. Thank you, Alena.
Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier
Could this be causing CLOUDSTACK-5652? I just see that it touches the isNetworkAWithinNetworkB, which now seems to return true for everything I try when deploying two networks in a vpc. On Thu, Dec 26, 2013 at 4:51 AM, ASF Subversion and Git Services asf...@urd.zones.apache.org wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30866 --- Commit ab4f095c68d4a4b4fb354b3d95096b193706987d in branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ab4f095 ] CLOUDSTACK-4622:If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier Signed-off-by: Jayapal jaya...@apache.org - ASF Subversion and Git Services On Dec. 24, 2013, 9:20 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/ --- (Updated Dec. 24, 2013, 9:20 a.m.) Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-4622 https://issues.apache.org/jira/browse/CLOUDSTACK-4622 Repository: cloudstack-git Description --- Add a new utility method for comparing 2 CIDRs. The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP range is equal or a subset of cidrB's IP range. Diffs - utils/src/com/cloud/utils/net/NetUtils.java f6f6285 utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf Diff: https://reviews.apache.org/r/14124/diff/ Testing --- Added unit test for the utility. Tested locally. Build is successful. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier
Yes, I verified that reverting the change on my local copy fixed the issue. On Thu, Dec 26, 2013 at 2:55 PM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: This is definitely the cause of the regression. Sateesh/Jaypal, please revert your change. It doesn¹t do the correct cidd validation. + if((startIpFirst = startIpSecond) (endIpFirst = endIpSecond)) + return true; You can¹t just compare CIDRs ip ranges as they may never cross. For example, 10.0.1.0/24 (10.0.1.0-10.0.1.255) and 10.0.2.0/24 (10.0.2.0-10.0.2.0) mentoned in the CLOUDSTACK-5652, with your code will be considered as overlapped. -Alena. On 12/26/13, 1:33 PM, Marcus Sorensen shadow...@gmail.com wrote: Could this be causing CLOUDSTACK-5652? I just see that it touches the isNetworkAWithinNetworkB, which now seems to return true for everything I try when deploying two networks in a vpc. On Thu, Dec 26, 2013 at 4:51 AM, ASF Subversion and Git Services asf...@urd.zones.apache.org wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30866 --- Commit ab4f095c68d4a4b4fb354b3d95096b193706987d in branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ab4f095 ] CLOUDSTACK-4622:If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier Signed-off-by: Jayapal jaya...@apache.org - ASF Subversion and Git Services On Dec. 24, 2013, 9:20 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/ --- (Updated Dec. 24, 2013, 9:20 a.m.) Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-4622 https://issues.apache.org/jira/browse/CLOUDSTACK-4622 Repository: cloudstack-git Description --- Add a new utility method for comparing 2 CIDRs. The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP range is equal or a subset of cidrB's IP range. Diffs - utils/src/com/cloud/utils/net/NetUtils.java f6f6285 utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf Diff: https://reviews.apache.org/r/14124/diff/ Testing --- Added unit test for the utility. Tested locally. Build is successful. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/#review30900 --- Commit ec8610f7566b74ea36399db020007fb878d013eb in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ec8610f ] CLOUDSTACK-5638: Fixed code to check router state - ASF Subversion and Git Services On Dec. 26, 2013, 2:06 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/ --- (Updated Dec. 26, 2013, 2:06 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5638 https://issues.apache.org/jira/browse/CLOUDSTACK-5638 Repository: cloudstack-git Description --- test_02_NetworkGarbageCollection was failing on XenServer advances setup while checking the router state. Sometimes, it needs more time for router to come up in running state, so modified code to check the router state after definite time intervals, it will fail after timeout (180 Seconds for now). Diffs - test/integration/component/test_routers.py 5f1ebc6 Diff: https://reviews.apache.org/r/16467/diff/ Testing --- Tested locally: Log: Test advanced zone router services ... SKIP: Skip Test network garbage collection ... ok Test router start on VM deploy ... SKIP: Skip Test router stop create Firewall rule ... SKIP: Skip Test router stop create Load balancing ... SKIP: Skip Test router stop create port forwarding ... SKIP: Skip -- Ran 6 tests in 799.271s OK (SKIP=5) Thanks, Gaurav Aradhye
Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/#review30902 --- Commit 53f0d35517ff717950120d2cb4206d50fbed13de in branch refs/heads/4.3 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53f0d35 ] CLOUDSTACK-5638: Fixed code to check router state - ASF Subversion and Git Services On Dec. 26, 2013, 2:06 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/ --- (Updated Dec. 26, 2013, 2:06 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5638 https://issues.apache.org/jira/browse/CLOUDSTACK-5638 Repository: cloudstack-git Description --- test_02_NetworkGarbageCollection was failing on XenServer advances setup while checking the router state. Sometimes, it needs more time for router to come up in running state, so modified code to check the router state after definite time intervals, it will fail after timeout (180 Seconds for now). Diffs - test/integration/component/test_routers.py 5f1ebc6 Diff: https://reviews.apache.org/r/16467/diff/ Testing --- Tested locally: Log: Test advanced zone router services ... SKIP: Skip Test network garbage collection ... ok Test router start on VM deploy ... SKIP: Skip Test router stop create Firewall rule ... SKIP: Skip Test router stop create Load balancing ... SKIP: Skip Test router stop create port forwarding ... SKIP: Skip -- Ran 6 tests in 799.271s OK (SKIP=5) Thanks, Gaurav Aradhye
Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/#review30901 --- Ship it! Committed to 4.3 and master. - Girish Shilamkar On Dec. 26, 2013, 2:06 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/ --- (Updated Dec. 26, 2013, 2:06 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5638 https://issues.apache.org/jira/browse/CLOUDSTACK-5638 Repository: cloudstack-git Description --- test_02_NetworkGarbageCollection was failing on XenServer advances setup while checking the router state. Sometimes, it needs more time for router to come up in running state, so modified code to check the router state after definite time intervals, it will fail after timeout (180 Seconds for now). Diffs - test/integration/component/test_routers.py 5f1ebc6 Diff: https://reviews.apache.org/r/16467/diff/ Testing --- Tested locally: Log: Test advanced zone router services ... SKIP: Skip Test network garbage collection ... ok Test router start on VM deploy ... SKIP: Skip Test router stop create Firewall rule ... SKIP: Skip Test router stop create Load balancing ... SKIP: Skip Test router stop create port forwarding ... SKIP: Skip -- Ran 6 tests in 799.271s OK (SKIP=5) Thanks, Gaurav Aradhye
Re: custom_parameters in deployVm call
Hi Alena, please find by comments inline. On 27-Dec-2013, at 2:40 am, Alena Prokharchyk alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com wrote: Bharat, I’ve noticed that you’ve added a new parameter to deployVm API -“customparameters”. The description of the parameter is very vague and generic “used to specify the custom parameters”. Is it just the metadata in form of value/key pairs? If so, please change the name to “details” - the generic name used when specify key/value metadata in other API commands. This parameter is used to pass the custom values for cpu, memory and cpucores when using custom compute offering. This not for the metadata. Also you need to save this information in the “user_vm_details” table, and return it in the UserVmResponse, “details” map parameter. I don’t see “custom parameters” key map being returned anywhere in the UserVmResponse. Its very confusing, because whatever is passed to the Create/Update call, should be returned in the response as well. There is a bug logged for this in jira. bug link https://issues.apache.org/jira/browse/CLOUDSTACK-5472 uploaded a patch in review board. link to the review request https://reviews.apache.org/r/16465/ It all has to be fixed in 4.3 branch. Thank you, Alena.
Re: why we delete prmary storage pool every time when stopping vm?
Yes, this should be a noop for LibvirtStorageAdaptor. I'm not sure why we decided to delete the pool. On Thu, Dec 19, 2013 at 6:05 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I updated the CRs and assigned them to Marcus. Since the issues are not related to the new iSCSI code specifically, I think Marcus will have a good idea what's going on there. In any event, if I can be of assistance, please let me know. Thanks On Thu, Dec 19, 2013 at 12:21 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Interesting...that commit was a combination of Marcus' and my code. We might want to bring him in on this conversation. I believe the idea is when a VM is stopped that we want to remove, for example, its iSCSI connections to its data disks (just using iSCSI as an example here). This is similar (but not the same of course) to how we disconnect a VBD from a VDI for a VM when the VM is stopped. When the VM is restarted, we create a new VBD and connect the VDI to the VM through it (and there is an analogous process that LibvirtStorageAdaptor does during VM start). On Thu, Dec 19, 2013 at 12:08 PM, Edison Su edison...@citrix.com wrote: Hi Mike, I looked at your commit: 858ce766659101eb731c83c806892dd5d9baa976, seems it will try to delete primary storage every time when stopping a VM ,which maybe the root cause a kvm blocker bug: CLOUDSTACK-5432, KVM guest vms are crashed during the automation test. From the agent log, I find a lot of “umount ” primary storage error. In 4.2, we never do that kind of operation. Do you know why we add it in 4.3? I am referring to the code in : disconnectPhysicalDiskByPath in LibvirtStorageAdaptor -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: why we delete prmary storage pool every time when stopping vm?
My notes from the initial version of the patch with instructions read: LibvirtStorageAdaptor: need to implement dummy connectPhysicalDisk/disconnectPhysicalDisk I must have missed during review that the final implementation actually did something. On Thu, Dec 26, 2013 at 10:47 PM, Marcus Sorensen shadow...@gmail.com wrote: Yes, this should be a noop for LibvirtStorageAdaptor. I'm not sure why we decided to delete the pool. On Thu, Dec 19, 2013 at 6:05 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I updated the CRs and assigned them to Marcus. Since the issues are not related to the new iSCSI code specifically, I think Marcus will have a good idea what's going on there. In any event, if I can be of assistance, please let me know. Thanks On Thu, Dec 19, 2013 at 12:21 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Interesting...that commit was a combination of Marcus' and my code. We might want to bring him in on this conversation. I believe the idea is when a VM is stopped that we want to remove, for example, its iSCSI connections to its data disks (just using iSCSI as an example here). This is similar (but not the same of course) to how we disconnect a VBD from a VDI for a VM when the VM is stopped. When the VM is restarted, we create a new VBD and connect the VDI to the VM through it (and there is an analogous process that LibvirtStorageAdaptor does during VM start). On Thu, Dec 19, 2013 at 12:08 PM, Edison Su edison...@citrix.com wrote: Hi Mike, I looked at your commit: 858ce766659101eb731c83c806892dd5d9baa976, seems it will try to delete primary storage every time when stopping a VM ,which maybe the root cause a kvm blocker bug: CLOUDSTACK-5432, KVM guest vms are crashed during the automation test. From the agent log, I find a lot of “umount ” primary storage error. In 4.2, we never do that kind of operation. Do you know why we add it in 4.3? I am referring to the code in : disconnectPhysicalDiskByPath in LibvirtStorageAdaptor -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: why we delete prmary storage pool every time when stopping vm?
Actually, I see why now. This code that deletes storage pool used to be in LibvirtComputingResource.java, named cleanupDisk. It was only ever called for isos, because we only had Libvirt Storage. Now, cleanupDisk is called for everything, so that other storage adaptors can do their cleanup, but LibvirtStorageAdaptor isn't filtering for isos like it should. The fix will be to detect iso in LibvirtStorageAdaptor's disconnectPhysicalDiskByPath and only execute on that. On Thu, Dec 26, 2013 at 10:49 PM, Marcus Sorensen shadow...@gmail.com wrote: My notes from the initial version of the patch with instructions read: LibvirtStorageAdaptor: need to implement dummy connectPhysicalDisk/disconnectPhysicalDisk I must have missed during review that the final implementation actually did something. On Thu, Dec 26, 2013 at 10:47 PM, Marcus Sorensen shadow...@gmail.com wrote: Yes, this should be a noop for LibvirtStorageAdaptor. I'm not sure why we decided to delete the pool. On Thu, Dec 19, 2013 at 6:05 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I updated the CRs and assigned them to Marcus. Since the issues are not related to the new iSCSI code specifically, I think Marcus will have a good idea what's going on there. In any event, if I can be of assistance, please let me know. Thanks On Thu, Dec 19, 2013 at 12:21 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Interesting...that commit was a combination of Marcus' and my code. We might want to bring him in on this conversation. I believe the idea is when a VM is stopped that we want to remove, for example, its iSCSI connections to its data disks (just using iSCSI as an example here). This is similar (but not the same of course) to how we disconnect a VBD from a VDI for a VM when the VM is stopped. When the VM is restarted, we create a new VBD and connect the VDI to the VM through it (and there is an analogous process that LibvirtStorageAdaptor does during VM start). On Thu, Dec 19, 2013 at 12:08 PM, Edison Su edison...@citrix.com wrote: Hi Mike, I looked at your commit: 858ce766659101eb731c83c806892dd5d9baa976, seems it will try to delete primary storage every time when stopping a VM ,which maybe the root cause a kvm blocker bug: CLOUDSTACK-5432, KVM guest vms are crashed during the automation test. From the agent log, I find a lot of “umount ” primary storage error. In 4.2, we never do that kind of operation. Do you know why we add it in 4.3? I am referring to the code in : disconnectPhysicalDiskByPath in LibvirtStorageAdaptor -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30903 --- Commit 0478aee78fe481e81eb4820cf181e4beb42ae22a in branch refs/heads/4.3 from Jayapal [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0478aee ] Revert CLOUDSTACK-4622:If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier Reverted the commit as it is breaking vpc CLOUDSTACK-5652 This reverts commit ab4f095c68d4a4b4fb354b3d95096b193706987d. - ASF Subversion and Git Services On Dec. 24, 2013, 9:20 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/ --- (Updated Dec. 24, 2013, 9:20 a.m.) Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-4622 https://issues.apache.org/jira/browse/CLOUDSTACK-4622 Repository: cloudstack-git Description --- Add a new utility method for comparing 2 CIDRs. The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP range is equal or a subset of cidrB's IP range. Diffs - utils/src/com/cloud/utils/net/NetUtils.java f6f6285 utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf Diff: https://reviews.apache.org/r/14124/diff/ Testing --- Added unit test for the utility. Tested locally. Build is successful. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30904 --- Commit 07de75191c487de980be795b202b0a8d8bbda4d6 in branch refs/heads/master from Jayapal [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=07de751 ] Revert CLOUDSTACK-4622:If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier Reverting this commit as it is breaking vpc deployment, CLOUDSTACK-5652 This reverts commit ab4f095c68d4a4b4fb354b3d95096b193706987d. - ASF Subversion and Git Services On Dec. 24, 2013, 9:20 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/ --- (Updated Dec. 24, 2013, 9:20 a.m.) Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-4622 https://issues.apache.org/jira/browse/CLOUDSTACK-4622 Repository: cloudstack-git Description --- Add a new utility method for comparing 2 CIDRs. The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP range is equal or a subset of cidrB's IP range. Diffs - utils/src/com/cloud/utils/net/NetUtils.java f6f6285 utils/test/com/cloud/utils/net/NetUtilsTest.java c7407bf Diff: https://reviews.apache.org/r/14124/diff/ Testing --- Added unit test for the utility. Tested locally. Build is successful. Patch applies cleanly. Thanks, Saksham Srivastava
VMware Question
Hi, I have a question about the initializeLocalStorage method in VmwareResource. When an ISO is downloaded from secondary storage to an ESX host, we create an NFS datastore on the host. When the host connects to a management server, initializeLocalStorage is run and this method sees the new NFS datastore as new local storage and this ends up being added as a new primary storage in CloudStack. I doubt this behavior is intended. I actually have a similar problem with how initializeLocalStorage treats iSCSI-based datastores that I dynamically create. In my case, a user executes a Disk Offering based on my plug-in. An iSCSI-based datastore (with a single VMDK file in it) is dynamically created and made accessible to all hosts in the cluster (although of course only a single host is running the VM that has the VMDK file attached as a data disk). Later on, if the host reconnects to a management server, initializeLocalStorage sees the new datastore as new local storage and tells the management server to add it to CloudStack as a new primary storage, which is not ideal. Any thoughts from people on a good way to stop this behavior? When I create a datastore, can I tag it a certain way and then look for that tag in initializeLocalStorage? Thanks! -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: VMware Question
I can see the problem is in HostMO.getLocalDatastoreOnHost. My datastore (as well as the NFS datastore that was automatically created to download an ISO) shows up as DatastoreSummary.isMultipleHostAccess == false (along with a couple other fields) and this qualifies it as local storage. I believe I've never seen this before because vCenter Server probably changes DatastoreSummary.isMultipleHostAccess to true when you have more than one host in the cluster that can access the datastore (I usually have more than one host in a VMware cluster, but don't right now). It seems DatastoreSummary.isMultipleHostAccess is not sufficient to use to declare if something is local storage. On Thu, Dec 26, 2013 at 11:18 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Hi, I have a question about the initializeLocalStorage method in VmwareResource. When an ISO is downloaded from secondary storage to an ESX host, we create an NFS datastore on the host. When the host connects to a management server, initializeLocalStorage is run and this method sees the new NFS datastore as new local storage and this ends up being added as a new primary storage in CloudStack. I doubt this behavior is intended. I actually have a similar problem with how initializeLocalStorage treats iSCSI-based datastores that I dynamically create. In my case, a user executes a Disk Offering based on my plug-in. An iSCSI-based datastore (with a single VMDK file in it) is dynamically created and made accessible to all hosts in the cluster (although of course only a single host is running the VM that has the VMDK file attached as a data disk). Later on, if the host reconnects to a management server, initializeLocalStorage sees the new datastore as new local storage and tells the management server to add it to CloudStack as a new primary storage, which is not ideal. Any thoughts from people on a good way to stop this behavior? When I create a datastore, can I tag it a certain way and then look for that tag in initializeLocalStorage? Thanks! -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
