Review Request 22717: refactor StoragePoolAllocator#filter logic

2014-06-18 Thread Yoshikazu Nojima

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22717/
---

Review request for cloudstack, Mike Tutkowski and Prachi Damle.


Repository: cloudstack-git


Description
---

refactor StoragePoolAllocator#filter logic to enable hypervisor type check, 
storage type check for root volume and avoid list check, and to support IOPS 
capacity control in a cluster wide storage pool and a local storage pool.


Diffs
-

  
engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
 ddbb5a4 
  
engine/storage/src/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java
 8fb9c8d 

Diff: https://reviews.apache.org/r/22717/diff/


Testing
---


Thanks,

Yoshikazu Nojima



Re: ZoneWideStoragePoolAllocator#filter seems weird for me

2014-06-18 Thread Yoshikazu Nojima
Prachi, Mike,
I appreciate your comments.

I think it is a bug that there is a difference between filter logic of
ClusterScopeStoragePoolAllocator and that of
ZoneWideStoragePoolAllocator
(ex. allocator skip iSCSI type storage pool or not when a volume is a RootDisk),
I will unify by implementing it in AbstractStoragePoolAllocator#filter method.

It is new information for me that managed storages only support zone
level. Thank you for let me know.
But when iopscapacity parameter is not set to a primary storage (i.e.
unmanaged storage), storageMgr.storagePoolHasEnoughIops always returns
true.
I suppose calling storageMgr.storagePoolHasEnoughIops from
AbstractStoragePoolAllocator will not cause a problem, and it will
simplify the code.

I created a patch to explain my thought. Could you review it?
https://reviews.apache.org/r/22717/

Regards,
Noji


2014-06-17 19:19 GMT-06:00 Mike Tutkowski mike.tutkow...@solidfire.com:
 I can comment on the IOPS part.

 The IOPS are currently only relevant when using managed storage (which is
 currently only applicable at the zone level). That being the case, no
 cluster (or local) storage takes advantage of counting IOPS that have been
 handed out.

 Of course this logic might be expanded in the future, but that's how it
 works today.


 On Tue, Jun 17, 2014 at 2:47 PM, Prachi Damle prachi.da...@citrix.com
 wrote:

 Why ZoneWideStoragePoolAllocator implements filter method (and doesn't
 call that of base class) rather than just using that of base class?
 ZoneWideStoragePoolAllocator#filter method seems doesn't care avoid
 parameter, doesn't skip iSCSI type storage pool even if a volume is a
 RootDisk.

 The first question seems like a bug to me.

 I am not sure about the IOPS

 Prachi

 -Original Message-
 From: ynoj...@ynojima.net [mailto:ynoj...@ynojima.net] On Behalf Of
 Yoshikazu Nojima
 Sent: Tuesday, June 17, 2014 1:07 PM
 To: dev@cloudstack.apache.org
 Subject: ZoneWideStoragePoolAllocator#filter seems weird for me

 Hi,

 ZoneWideStoragePoolAllocator#filter seems weird for me.

 ZoneWideStoragePoolAllocator and ClusterScopeStoragePoolAllocator are
 allocator classes to select storage pool.
 They extends AbstractStoragePoolAllocator class, which provides filter
 method to exclude unavailable storage pools.

 Why ZoneWideStoragePoolAllocator implements filter method (and doesn't
 call that of base class) rather than just using that of base class?

 ZoneWideStoragePoolAllocator#filter method seems doesn't care avoid
 parameter, doesn't skip iSCSI type storage pool even if a volume is a
 RootDisk.
 (These functions are implemented in
 AbstractStoragePoolAllocator#filter method, which used by
 ClusterScopeStoragePoolAllocator.)
 On the other hand, AbstractStoragePoolAllocator#filter doesn't call
 storageMgr.storagePoolHasEnoughIops, so a cluster wide primary storage
 would be allocated more volumes than its designated IOPS capacity.

 Is there any difference between a zone wide primary storage and a cluster
 wide primary storage except its scope?
 If it is a bug, I'll fix it.

 Regards,
 Noji




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud
 http://solidfire.com/solution/overview/?video=play*™*


Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-06-18 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review46043
---


Commit a0f19d4bd5d7bec6613aa8130b3da9ecffc71d0b in cloudstack's branch 
refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a0f19d4 ]

CLOUDSTACK-1466: Automation - Priamary Storage Limits


- ASF Subversion and Git Services


On June 18, 2014, 4:06 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20316/
 ---
 
 (Updated June 18, 2014, 4:06 a.m.)
 
 
 Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
 
 
 Bugs: CLOUDSTACK-1466
 https://issues.apache.org/jira/browse/CLOUDSTACK-1466
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Adding test suits in Primary Storage Limits test cases.
 1)Root/Domain admin limits
 2)Domain Limits
 3)Resize volume
 4)Project Limits
 5)Maximum Limits
 
 
 Diffs
 -
 
   test/integration/component/test_ps_domain_limits.py PRE-CREATION 
   test/integration/component/test_ps_limits.py PRE-CREATION 
   test/integration/component/test_ps_max_limits.py PRE-CREATION 
   test/integration/component/test_ps_project_limits.py PRE-CREATION 
   test/integration/component/test_ps_resize_volume.py PRE-CREATION 
   tools/marvin/marvin/codes.py ef49c0c 
   tools/marvin/marvin/lib/base.py 8b89087 
   tools/marvin/marvin/lib/common.py 7753385 
 
 Diff: https://reviews.apache.org/r/20316/diff/
 
 
 Testing
 ---
 
 Yes
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

2014-06-18 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22510/
---

(Updated June 18, 2014, 6:50 a.m.)


Review request for cloudstack, edison su, Koushik Das, and Min Chen.


Changes
---

Commit message changes to explicitly mention that changes are related to 
XenServer/NFS only.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636


Repository: cloudstack-git


Description
---

Due to File.separator on windows machine the template creation from snapshot is 
failing as it has mis-matched path separator which is windows path 
separator(\). Fixed the same by adding getPathSeparator() method to 
DataStoreTO.java and all it's implementations.


Diffs (updated)
-

  api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc 
  api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 
  api/src/com/cloud/agent/api/to/S3TO.java f64fe35 
  api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad 
  core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 
  core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 
  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
 e96ebf4 

Diff: https://reviews.apache.org/r/22510/diff/


Testing
---

Tested on Windows 2012 R2 server and on centos. Tested the following use cases.

1. Attach ISO
2. Detach ISO
3. Snapshot creation from root disk
4. Snapshot creation from data disk
5. volume creation from (3)
6. template creation from(3)
7. Launch a VM after registering new template.


Thanks,

Damodar Reddy Talakanti



Re: [GSOC 2014]Create GUI to add primary storage based on plug-ins

2014-06-18 Thread Punith S
hi seif,

may i know the status of the GSoC primary storage UI project you are
currently working on.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins
if you can loop me, i will be able to contribute.

thank you.


On Fri, Mar 21, 2014 at 7:47 PM, Mike Tutkowski 
mike.tutkow...@solidfire.com wrote:

 Thanks for the code, Punith!

 Seif is someone I met about a year ago. I plan to mentor his work for
 GSoC, but we'd definitely be happy for any input you or others have.


 On Fri, Mar 21, 2014 at 4:10 AM, Seif Eddine Jemli 
 seifeddineje...@gmail.com wrote:

 Thanks Punith!


 2014-03-21 10:38 GMT+01:00 Punith S punit...@cloudbyte.com:

  hi seif,
 
  its cool you took this up, this would make admins to create primary
  storage pool with respect to different storage vendors plugin using
  cloudstack UI.
 
  you can start off by looking at the createStoragepool api's parameters
 in
  4.4 and above,
 
  all you have to do is when user ticks the managed storage , list the
  storage providers and display the additional input for params of
  createStoragePool api , ie. capacityIops, capacityBytes and Details map.
 
  i have already tweaked the system.js script file in 4.2 for myself, i
 have
  attached it so you can refer it.
 
  thanks.
 
 
  On Fri, Mar 21, 2014 at 2:23 PM, Seif Eddine Jemli 
  seifeddineje...@gmail.com wrote:
 
  Hi everyone,
 
  I am Seif Eddine Jemli, a Tunisian student in a french computer science
  engineergin college (the ENSEIRB-MATMECA grande ecole).
 
  For GSOC 2014, I'm interested in looking at the JIRA Ticket
  CLOUDSTACK-6045
  :CreateGUI to add primary storage based on plug-in.
  https://issues.apache.org/jira/browse/CLOUDSTACK-6045
 
 
  My full proposal can be found on Google Melange at:
  *
 
 http://www.google-melange.com/gsoc/proposal/public/google/gsoc2014/sjemli/5629499534213120
  
 
 http://www.google-melange.com/gsoc/proposal/public/google/gsoc2014/sjemli/5629499534213120
  *
 
  I am relying on your advices and suggestions!
 
  Thanks,
  Seif
 
 
 
 
  --
  regards,
 
  punith s
  cloudbyte.com
 




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud
 http://solidfire.com/solution/overview/?video=play*™*




-- 
regards,

punith s
cloudbyte.com


[POLL] Who uses awsapi with CloudStack in production?

2014-06-18 Thread Rohit Yadav
Hi,

Who uses awsapi or any other EC2 compatible interface such as ec2stack
with CloudStack (or CloudStack distros such as Citrix CloudPlatform) in
production? And, if marketing and publicity are/were big motivation(s)?

In case you don't want to discuss on this thread, please take this
anonymous poll:
http://www.polljunkie.com/poll/fbyfdc/who-uses-awsapi-with-cloudstack-in-prouduction

# Some stats

I've been watching Collab14 videos and found references where many speakers
reference overall CloudStack codebase to be about 1.5M (million) lines of
Java code which is not exactly true. Let me share some findings;

- As of today, CloudStack master is about 1.7M lines of Java code [1]
- CloudStack awsapi artifact is 1.04M lines of Java code [2]
- Code excluding awsapi, tests and license/comment is about 590k lines of
Java code [3]
- The core excluding plugins, api and the above is about 300k lines of Java
code [4]

Why should  I care:
- some useful/fun stats to keep in mind
- it's not a giant mammoth that cannot be fixed or developed upon
- encouraging for new developers that if they try they can understand and
fix it

FYI, this started on twitter yesterday:
https://twitter.com/_bhaisaab/status/479007075414974465

[1] cd cloudstack-repo  find . | grep java$ | xargs cat | wc -l
[2] cd cloudstack-repo  find awsapi | grep java$ | xargs cat | wc -l
[3] cd cloudstack-repo  find . | grep -v awsapi | grep -v [tT]est | grep
java$ | xargs cat | grep -v '^//' | wc -l
[4] cd cloudstack-repo  find . | grep -v awsapi | grep -v [Tt]est | grep
-v plugins | grep -v api | grep java$ | xargs cat | grep -v '^//' | wc -l

Regards.


[GitHub] cloudstack-docs-install pull request: corrected the java version t...

2014-06-18 Thread runseb
Github user runseb commented on the pull request:


https://github.com/apache/cloudstack-docs-install/pull/15#issuecomment-46403171
  
thanks for the patch, I applied to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-install pull request: corrected the java version t...

2014-06-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-docs-install/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Review Request 22627: CLOUDSTACK-6906: Fixed volume resize BVT failure

2014-06-18 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22627/#review46044
---


Commit e65b746b346f33fc4f879479f7e45a081e06f90a in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e65b746 ]

 CLOUDSTACK-6906: Fixed volume resize BVT failure


- ASF Subversion and Git Services


On June 18, 2014, 3:22 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22627/
 ---
 
 (Updated June 18, 2014, 3:22 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-6906
 https://issues.apache.org/jira/browse/CLOUDSTACK-6906
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The disk offering used while resizing volume was not custom. Changed it to 
 custom disk offering so that resize is possible without creating new disk 
 offering.
 
 
 Diffs
 -
 
   test/integration/smoke/test_volumes.py 2e41aa7 
 
 Diff: https://reviews.apache.org/r/22627/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 22627: CLOUDSTACK-6906: Fixed volume resize BVT failure

2014-06-18 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22627/#review46045
---


Commit 8aea23a4e36559e8113d7bc0427aa950ae8082eb in cloudstack's branch 
refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8aea23a ]

 CLOUDSTACK-6906: Fixed volume resize BVT failure


- ASF Subversion and Git Services


On June 18, 2014, 3:22 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22627/
 ---
 
 (Updated June 18, 2014, 3:22 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-6906
 https://issues.apache.org/jira/browse/CLOUDSTACK-6906
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The disk offering used while resizing volume was not custom. Changed it to 
 custom disk offering so that resize is possible without creating new disk 
 offering.
 
 
 Diffs
 -
 
   test/integration/smoke/test_volumes.py 2e41aa7 
 
 Diff: https://reviews.apache.org/r/22627/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 22614: CLOUDSTACK-6887: Code enhancement to ensure better cleanup

2014-06-18 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22614/#review46046
---


Commit 588e3e37afdd5740816d1225d449164ed2024c03 in cloudstack's branch 
refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=588e3e3 ]

CLOUDSTACK-6887: Code enhancement to ensure better cleanup


- ASF Subversion and Git Services


On June 18, 2014, 3:22 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22614/
 ---
 
 (Updated June 18, 2014, 3:22 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-6887
 https://issues.apache.org/jira/browse/CLOUDSTACK-6887
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Adding patch fixing few more test suites for better cleanup.
 
 
 Diffs
 -
 
   test/integration/component/test_accounts.py f71dea5 
   test/integration/component/test_add_remove_network.py 7479cee 
   test/integration/component/test_affinity_groups.py d0fa2f7 
   test/integration/component/test_portable_ip.py 538318d 
   test/integration/component/test_vpc_network.py a449948 
 
 Diff: https://reviews.apache.org/r/22614/diff/
 
 
 Testing
 ---
 
 Tested with python command.
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 22614: CLOUDSTACK-6887: Code enhancement to ensure better cleanup

2014-06-18 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22614/#review46047
---


Commit 942fc98848855c5ff2f177b251a44b1f2b971a57 in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=942fc98 ]

CLOUDSTACK-6887: Code enhancement to ensure better cleanup


- ASF Subversion and Git Services


On June 18, 2014, 3:22 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22614/
 ---
 
 (Updated June 18, 2014, 3:22 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-6887
 https://issues.apache.org/jira/browse/CLOUDSTACK-6887
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Adding patch fixing few more test suites for better cleanup.
 
 
 Diffs
 -
 
   test/integration/component/test_accounts.py f71dea5 
   test/integration/component/test_add_remove_network.py 7479cee 
   test/integration/component/test_affinity_groups.py d0fa2f7 
   test/integration/component/test_portable_ip.py 538318d 
   test/integration/component/test_vpc_network.py a449948 
 
 Diff: https://reviews.apache.org/r/22614/diff/
 
 
 Testing
 ---
 
 Tested with python command.
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-06-18 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
---

(Updated June 18, 2014, 1:10 p.m.)


Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.


Changes
---

Adding Rebased patch for master.


Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466


Repository: cloudstack-git


Description
---

Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits


Diffs
-

  test/integration/component/test_ps_domain_limits.py PRE-CREATION 
  test/integration/component/test_ps_limits.py PRE-CREATION 
  test/integration/component/test_ps_max_limits.py PRE-CREATION 
  test/integration/component/test_ps_project_limits.py PRE-CREATION 
  test/integration/component/test_ps_resize_volume.py PRE-CREATION 
  tools/marvin/marvin/codes.py ef49c0c 
  tools/marvin/marvin/lib/base.py 8b89087 
  tools/marvin/marvin/lib/common.py 7753385 

Diff: https://reviews.apache.org/r/20316/diff/


Testing
---

Yes


File Attachments (updated)


Patch for master branch
  
https://reviews.apache.org/media/uploaded/files/2014/06/18/5fc8afc6-212b-49dd-a83f-20dc56008c39__0001-CLOUDSTACK-1466-Automatiion-Primary-Storage-Limits-t.patch


Thanks,

Gaurav Aradhye



Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-06-18 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
---

(Updated June 18, 2014, 1:12 p.m.)


Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.


Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466


Repository: cloudstack-git


Description
---

Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits


Diffs
-

  test/integration/component/test_ps_domain_limits.py PRE-CREATION 
  test/integration/component/test_ps_limits.py PRE-CREATION 
  test/integration/component/test_ps_max_limits.py PRE-CREATION 
  test/integration/component/test_ps_project_limits.py PRE-CREATION 
  test/integration/component/test_ps_resize_volume.py PRE-CREATION 
  tools/marvin/marvin/codes.py ef49c0c 
  tools/marvin/marvin/lib/base.py 8b89087 
  tools/marvin/marvin/lib/common.py 7753385 

Diff: https://reviews.apache.org/r/20316/diff/


Testing
---

Yes


File Attachments (updated)


Rebased patch for master
  
https://reviews.apache.org/media/uploaded/files/2014/06/18/fa7c2219-3cd8-49af-a8eb-2c8c7125ef34__0001-CLOUDSTACK-1466-Automatiion-Primary-Storage-Limits-t.patch


Thanks,

Gaurav Aradhye



Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-06-18 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review46049
---


Commit e7fe391be4076309a9dc9a0f9bf8ea58181dfa12 in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e7fe391 ]

CLOUDSTACK-1466: Automatiion - Primary Storage Limits test cases


- ASF Subversion and Git Services


On June 18, 2014, 7:42 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20316/
 ---
 
 (Updated June 18, 2014, 7:42 a.m.)
 
 
 Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
 
 
 Bugs: CLOUDSTACK-1466
 https://issues.apache.org/jira/browse/CLOUDSTACK-1466
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Adding test suits in Primary Storage Limits test cases.
 1)Root/Domain admin limits
 2)Domain Limits
 3)Resize volume
 4)Project Limits
 5)Maximum Limits
 
 
 Diffs
 -
 
   test/integration/component/test_ps_domain_limits.py PRE-CREATION 
   test/integration/component/test_ps_limits.py PRE-CREATION 
   test/integration/component/test_ps_max_limits.py PRE-CREATION 
   test/integration/component/test_ps_project_limits.py PRE-CREATION 
   test/integration/component/test_ps_resize_volume.py PRE-CREATION 
   tools/marvin/marvin/codes.py ef49c0c 
   tools/marvin/marvin/lib/base.py 8b89087 
   tools/marvin/marvin/lib/common.py 7753385 
 
 Diff: https://reviews.apache.org/r/20316/diff/
 
 
 Testing
 ---
 
 Yes
 
 
 File Attachments
 
 
 Rebased patch for master
   
 https://reviews.apache.org/media/uploaded/files/2014/06/18/fa7c2219-3cd8-49af-a8eb-2c8c7125ef34__0001-CLOUDSTACK-1466-Automatiion-Primary-Storage-Limits-t.patch
 
 
 Thanks,
 
 Gaurav Aradhye
 




Review Request 22718: Fixing identation issue in marvin

2014-06-18 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22718/
---

Review request for cloudstack and Girish Shilamkar.


Repository: cloudstack-git


Description
---

Fixing indentation issue introduced in patch: 
https://reviews.apache.org/r/20316/


Diffs
-

  tools/marvin/marvin/lib/common.py 42ffc51 

Diff: https://reviews.apache.org/r/22718/diff/


Testing
---


Thanks,

Gaurav Aradhye



Re: [ACS431][QUESTION] db upgrace

2014-06-18 Thread Daan Hoogland
So far it is the same as 4.3.0 - 4.4.0

On Wed, Jun 18, 2014 at 6:19 AM, Koushik Das koushik@citrix.com wrote:
 4.3.1 - 4.4.0 upgrade also needs to be handled.

 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Tuesday, 17 June 2014 9:16 PM
 To: dev
 Subject: [ACS431][QUESTION] db upgrace

 In my simple mind it seems we only need to create a Upgrade430to431.java file 
 and don't need any sql files. Is this going to fly? AFAICT the only thing to 
 go in there is the vlan fixup in the vlan table, which is a data migration 
 and not a schema change.

 Can anyone point out to me the error in my ways, please?

 thanks,
 --
 Daan



-- 
Daan


Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

2014-06-18 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22510/
---

(Updated June 18, 2014, 9:41 a.m.)


Review request for cloudstack, edison su, Koushik Das, and Min Chen.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636


Repository: cloudstack-git


Description
---

Due to File.separator on windows machine the template creation from snapshot is 
failing as it has mis-matched path separator which is windows path 
separator(\). Fixed the same by adding getPathSeparator() method to 
DataStoreTO.java and all it's implementations.


Diffs (updated)
-

  api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc 
  api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 
  api/src/com/cloud/agent/api/to/S3TO.java f64fe35 
  api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad 
  core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 
  core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 
  
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
 e96ebf4 

Diff: https://reviews.apache.org/r/22510/diff/


Testing
---

Tested on Windows 2012 R2 server and on centos. Tested the following use cases.

1. Attach ISO
2. Detach ISO
3. Snapshot creation from root disk
4. Snapshot creation from data disk
5. volume creation from (3)
6. template creation from(3)
7. Launch a VM after registering new template.


Thanks,

Damodar Reddy Talakanti



Review Request 22721: removed hard coded jdk_dirs in cloud-usage script

2014-06-18 Thread Rajani Karuturi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22721/
---

Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.


Bugs: CLOUDSTACK-6926
https://issues.apache.org/jira/browse/CLOUDSTACK-6926


Repository: cloudstack-git


Description
---

used to readlink -e and dirname to get the JAVA_HOME
if JAVA_HOME is not already defined, sets it to jdk home if javac is present 
else jre home if java is present.
if nothing is present, it exits with error


Diffs
-

  packaging/centos63/cloud-usage.rc 6170379 
  packaging/debian/init/cloud-usage 1cc75cc 

Diff: https://reviews.apache.org/r/22721/diff/


Testing
---


tested it when java is not installed, jre is installed, jdk installed or when a 
older version is installed on centos 6.4 and ubuntu 14.04 


Thanks,

Rajani Karuturi



Re: Xen Project support and state of APIs

2014-06-18 Thread Rohit Yadav
Hi Tim,

On Tue, Jun 17, 2014 at 11:09 PM, Tim Mackey tmac...@gmail.com wrote:

 On Tue, Jun 17, 2014 at 7:30 AM, Rohit Yadav bhais...@apache.org wrote:

  Tim,
 
  Thanks for replying, let me clean up everything and re-setup my test
 infra
  after my $dayjob hours and get back to you. The test cases in the design
  doc does not discuss Xen Project so I thought I should ask if ACS works
  with Xen Project 4.x.
 

 The longer term objective is to provide support for XenProject without
 XAPI, most notably with libvirt.  Effectively XenServer implies XAPI and
 XenProject would imply libvirt as the tooling.


Alright, that means we need to start working on a Xen Project hypervisor
plugin that would (re)use libvirt (or libxl) tooling, probably re-use/fix
the KVM agent too.


 
  The Xen/XenProject/XenServer/XAPI/XCP is confusing [1]. From what I
  understand, XCP was some sort of an opensource version of XenServer, but
  since XenServer distribution (which consists of Xen, XenCenter, XAPI,
 Linux
  etc.) is opensource, XCP has been discontinued since 1.6 release?
 

 XCP was rolled into XenServer as of XenServer 6.2 which means 1.6 was the
 last version of XCP.  I tried to sum it up in this blog:

 http://open.citrix.com/blog/342-knowing-what-you-ve-got-avoiding-the-xen-vs-xenserver-confusion.html


Thanks, this helps to understand what went in this transition.


  Now, on many Linux distro XAPI is still available as 'xcp-xapi' such as
 in
  Debian/Ubuntu, so what package(s) do you suggest one needs to install and
  configure so I can get DevCloud [2] work again? DevCloud is a VM that
 runs
  Xen (Xen Project) inside it and can be used as a virtual host to
  test/develop ACS against it.
 
 
 I see no reason why any other XAPI implementation wouldn't work, but it's
 entirely possible the version of xcp-xapi you have has issues with
 XenProject 4.4 due to normal versioning type issues.  There also was a
 different productization attempt called xenserver-core, but that looks to
 have died on the vine.  That being said, I could easily have broken
 something.  If I've broken something, I probably won't be able to test
 until next week due to travels.  The question of xapi inclusion in distros
 is one I'd need to check on.


Yes, that would be great. I'll attempt testing it again with fresh setup in
upcoming weekends.

Regards.





  [1] http://www.xenproject.org/developers/teams/xapi.html
  [2] http://bhaisaab.org/logs/devcloud
 
  Regards.
 
 
 
 
  On Tue, Jun 17, 2014 at 4:27 PM, Tim Mackey tmac...@gmail.com wrote:
 
   Rohit,
  
   We've only supported xapi so far, so I'm curious if you had Xen Project
  4.4
   working before with xapi and if that is now broken. Nothing I did
 should
   have impacted that, but it wasn't in my test suite so anything is
  possible
   On Jun 17, 2014 11:21 AM, Rohit Yadav bhais...@apache.org wrote:
  
Hi,
   
Xen Project (previously xen.org xenserver) is widely accessible in
   several
Linux distributions such as Arch, Fedora etc. Therefore, people may
  want
   to
use it instead of XenServer (6.2 or later). The ACS 4.5 design doc
 [1]
explains about XenServer and how it should be tested etc. but what
  about
using Xen Project?
   
Since the recent Xen plugin refactoring as xenserver plugin [1], I'm
   unable
to get ACS to work with Xen Project 4.4 (on a real host and on a new
   custom
DevCloud). Using the XenServer ACS plugin, it identifies a Xen
 Project
   host
as some version of Xen but then fails. Has anyone tried this with ACS
4.4/master? Are we going to test/support Xen Project (4.x) soon? If
 so,
   can
people involved share their plan/vision/roadmap on it?
   
Lastly, as the design doc [1] suggested XCP's development has
 stopped,
   are
we going to favour using XAPI [1] now or libVirt [2] or something
 else?
   
[1]
   
   
  
 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Convert+Xen+usage+to+XenServer
   
[2] http://blog.xen.org/index.php/2014/03/10/xen-4-4-released
   
Regards.
   
  
 



Re: Review Request 22554: CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage

2014-06-18 Thread John Dilley


 On June 17, 2014, 5:43 a.m., Santhosh Edukulla wrote:
  tools/marvin/marvin/deployDataCenter.py, line 240
  https://reviews.apache.org/r/22554/diff/2/?file=609404#file609404line240
 
  Why specifically this?

Because primary.details is a JSONLoader class and primarycmd needs a 
dictionary. This converts between them.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22554/#review45910
---


On June 13, 2014, 4:53 p.m., John Dilley wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22554/
 ---
 
 (Updated June 13, 2014, 4:53 p.m.)
 
 
 Review request for cloudstack.
 
 
 Bugs: CLOUDSTACK-6909
 https://issues.apache.org/jira/browse/CLOUDSTACK-6909
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Fix marvin's handling of details field for primary and secondary storage to 
 cope with SMB credentials. This allows Hyper-V to work.
 
 
 Diffs
 -
 
   tools/marvin/marvin/deployDataCenter.py 22b78ab 
 
 Diff: https://reviews.apache.org/r/22554/diff/
 
 
 Testing
 ---
 
 Tested deploydataCenter with this JSON:
 
 {
dbSvr:{
   dbSvr:10.220.137.39,
   passwd:cloud,
   db:cloud,
   port:3306,
   user:cloud
},
zones:[
   {
  name:XenRT-Zone-0,
  guestcidraddress:192.168.200.0/24,
  dns1:10.220.160.11,
  physical_networks:[
 {
XRT_VLANRangeSize:10,
name:AdvPhyNetwork,
providers:[
   {
  broadcastdomainrange:ZONE,
  name:VirtualRouter
   },
   {
  broadcastdomainrange:ZONE,
  name:VpcVirtualRouter
   },
   {
  broadcastdomainrange:ZONE,
  name:InternalLbVm
   }
],
broadcastdomainrange:Zone,
vlan:3000-3009,
traffictypes:[
   {
  typ:Guest
   },
   {
  typ:Management
   },
   {
  typ:Public
   }
],
isolationmethods:[
   VLAN
]
 }
  ],
  ipranges:[
 {
startip:10.220.164.0,
endip:10.220.164.9,
netmask:255.255.240.0,
XRT_GuestIPRangeSize:10,
gateway:10.220.160.1
 }
  ],
  networktype:Advanced,
  pods:[
 {
XRT_PodIPRangeSize:10,
name:XenRT-Zone-0-Pod-0,
endip:10.220.164.39,
startip:10.220.164.30,
netmask:255.255.240.0,
clusters:[
   {
  XRT_HyperVHostIds:0,
  clustername:XenRT-Zone-0-Pod-0-Cluster-0,
  hypervisor:hyperv,
  primaryStorages:[
 {
url:cifs://10.220.163.45/storage/primary,
name:XenRT-Zone-0-Pod-0-Primary-Store,
details:[
   {
  user:Administrator
   },
   {
  password:xenroot01T
   },
   {
  domain:XSQA
   }
]
 }
  ],
  clustertype:CloudManaged,
  hosts:[
 {
url:http://10.220.163.45;,
username:root,
password:xenroot
 }
  ],
  XRT_Hosts:1
   }
],
gateway:10.220.160.1
 }
  ],
  internaldns1:10.220.160.11,
  secondaryStorages:[
 {
url:cifs://10.220.163.45/storage/secondary,
details:{
   domain:XSQA,
   password:xenroot01T,
   user:Administrator
},
provider:SMB
 }
  ]
   }
],
mgtSvr:[
   {
  mgtSvrIp:10.220.137.39,
  passwd:xenroot,
  port:8096,
  user:root
   }
]
 }
 
 
 

[ACS4.4] Cherry-pick

2014-06-18 Thread Rajesh Battala
Daan,
Request to cherry-pick 21e452ff4f0459422f0612f2ddf7033a963b0a19

Thanks
Rajesh Battala


Reset VM and it's gone - how do I get rid of this button??

2014-06-18 Thread Nux!
Hi,

A colleague just wiped out a VM because he thought that buttong reboots the 
virtual machine...

Is there any way I can butcher the UI and remove that button or at least rename 
it to Reinstall VM or similar?

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro



Re: Xen Project support and state of APIs

2014-06-18 Thread sebgoa

On Jun 18, 2014, at 12:28 PM, Rohit Yadav bhais...@apache.org wrote:

 Hi Tim,
 
 On Tue, Jun 17, 2014 at 11:09 PM, Tim Mackey tmac...@gmail.com wrote:
 
 On Tue, Jun 17, 2014 at 7:30 AM, Rohit Yadav bhais...@apache.org wrote:
 
 Tim,
 
 Thanks for replying, let me clean up everything and re-setup my test
 infra
 after my $dayjob hours and get back to you. The test cases in the design
 doc does not discuss Xen Project so I thought I should ask if ACS works
 with Xen Project 4.x.
 
 
 The longer term objective is to provide support for XenProject without
 XAPI, most notably with libvirt.  Effectively XenServer implies XAPI and
 XenProject would imply libvirt as the tooling.
 
 
 Alright, that means we need to start working on a Xen Project hypervisor
 plugin that would (re)use libvirt (or libxl) tooling, probably re-use/fix
 the KVM agent too.

there is on-going work about this:
http://markmail.org/thread/sxezpziog2koewlt



 
 
 
 The Xen/XenProject/XenServer/XAPI/XCP is confusing [1]. From what I
 understand, XCP was some sort of an opensource version of XenServer, but
 since XenServer distribution (which consists of Xen, XenCenter, XAPI,
 Linux
 etc.) is opensource, XCP has been discontinued since 1.6 release?
 
 
 XCP was rolled into XenServer as of XenServer 6.2 which means 1.6 was the
 last version of XCP.  I tried to sum it up in this blog:
 
 http://open.citrix.com/blog/342-knowing-what-you-ve-got-avoiding-the-xen-vs-xenserver-confusion.html
 
 
 Thanks, this helps to understand what went in this transition.
 
 
 Now, on many Linux distro XAPI is still available as 'xcp-xapi' such as
 in
 Debian/Ubuntu, so what package(s) do you suggest one needs to install and
 configure so I can get DevCloud [2] work again? DevCloud is a VM that
 runs
 Xen (Xen Project) inside it and can be used as a virtual host to
 test/develop ACS against it.
 
 
 I see no reason why any other XAPI implementation wouldn't work, but it's
 entirely possible the version of xcp-xapi you have has issues with
 XenProject 4.4 due to normal versioning type issues.  There also was a
 different productization attempt called xenserver-core, but that looks to
 have died on the vine.  That being said, I could easily have broken
 something.  If I've broken something, I probably won't be able to test
 until next week due to travels.  The question of xapi inclusion in distros
 is one I'd need to check on.
 
 
 Yes, that would be great. I'll attempt testing it again with fresh setup in
 upcoming weekends.
 
 Regards.
 
 
 
 
 
 [1] http://www.xenproject.org/developers/teams/xapi.html
 [2] http://bhaisaab.org/logs/devcloud
 
 Regards.
 
 
 
 
 On Tue, Jun 17, 2014 at 4:27 PM, Tim Mackey tmac...@gmail.com wrote:
 
 Rohit,
 
 We've only supported xapi so far, so I'm curious if you had Xen Project
 4.4
 working before with xapi and if that is now broken. Nothing I did
 should
 have impacted that, but it wasn't in my test suite so anything is
 possible
 On Jun 17, 2014 11:21 AM, Rohit Yadav bhais...@apache.org wrote:
 
 Hi,
 
 Xen Project (previously xen.org xenserver) is widely accessible in
 several
 Linux distributions such as Arch, Fedora etc. Therefore, people may
 want
 to
 use it instead of XenServer (6.2 or later). The ACS 4.5 design doc
 [1]
 explains about XenServer and how it should be tested etc. but what
 about
 using Xen Project?
 
 Since the recent Xen plugin refactoring as xenserver plugin [1], I'm
 unable
 to get ACS to work with Xen Project 4.4 (on a real host and on a new
 custom
 DevCloud). Using the XenServer ACS plugin, it identifies a Xen
 Project
 host
 as some version of Xen but then fails. Has anyone tried this with ACS
 4.4/master? Are we going to test/support Xen Project (4.x) soon? If
 so,
 can
 people involved share their plan/vision/roadmap on it?
 
 Lastly, as the design doc [1] suggested XCP's development has
 stopped,
 are
 we going to favour using XAPI [1] now or libVirt [2] or something
 else?
 
 [1]
 
 
 
 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Convert+Xen+usage+to+XenServer
 
 [2] http://blog.xen.org/index.php/2014/03/10/xen-4-4-released
 
 Regards.
 
 
 
 



Review Request 22725: CLOUDSTACK-6932: Removing redundant file test_escalations.py

2014-06-18 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22725/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-6932
https://issues.apache.org/jira/browse/CLOUDSTACK-6932


Repository: cloudstack-git


Description
---


test_escalations.py file has already been divided into different test suites 
such as
test_escalations_instances.py
test_escalations_isos.py
test_escalations_snapshots.py
test_escalations_volumes.py
test_escalations_ipaddresses.py
test_escalations_networks.py
test_escalations_securitygroups.py
test_escalations_templates.py
test_escalations_vpncustomergateways.py

so the parent file needs to be removed from the repo.


Diffs
-

  test/integration/component/test_escalations.py 1b596a7 

Diff: https://reviews.apache.org/r/22725/diff/


Testing
---


Thanks,

Gaurav Aradhye



Re: Review Request 22725: CLOUDSTACK-6932: Removing redundant file test_escalations.py

2014-06-18 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22725/
---

(Updated June 18, 2014, 4:38 p.m.)


Review request for cloudstack and Girish Shilamkar.


Changes
---

Adding patch for master


Bugs: CLOUDSTACK-6932
https://issues.apache.org/jira/browse/CLOUDSTACK-6932


Repository: cloudstack-git


Description
---


test_escalations.py file has already been divided into different test suites 
such as
test_escalations_instances.py
test_escalations_isos.py
test_escalations_snapshots.py
test_escalations_volumes.py
test_escalations_ipaddresses.py
test_escalations_networks.py
test_escalations_securitygroups.py
test_escalations_templates.py
test_escalations_vpncustomergateways.py

so the parent file needs to be removed from the repo.


Diffs
-

  test/integration/component/test_escalations.py 1b596a7 

Diff: https://reviews.apache.org/r/22725/diff/


Testing
---


File Attachments (updated)


Patch for master
  
https://reviews.apache.org/media/uploaded/files/2014/06/18/a6eb3655-f839-4d1b-9387-152fc7949478__0001-CLOUDSTACK-6932-Removing-redundant-file-test_escalat.patch


Thanks,

Gaurav Aradhye



Re: Reset VM and it's gone - how do I get rid of this button??

2014-06-18 Thread Nux!
Grep said to replace this in webapps/client/scripts/instances.js and it seems 
to be working.
Is there anything else I need to watch out for?

Additionally, can we add this in 4.3.1/4.4/master?

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: Nux! n...@li.nux.ro
To: dev@cloudstack.apache.org
Sent: Wednesday, 18 June, 2014 11:56:52 AM
Subject: Reset VM and it's gone - how do I get rid of this button??

Hi,

A colleague just wiped out a VM because he thought that buttong reboots the 
virtual machine...

Is there any way I can butcher the UI and remove that button or at least rename 
it to Reinstall VM or similar?

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro



RE: Reset VM and it's gone - how do I get rid of this button??

2014-06-18 Thread Saksham Srivastava
Some changes came as part of this : 
https://issues.apache.org/jira/browse/CLOUDSTACK-6272

May give you some pointers. Brian/Jessica can be of help.

Thanks,
Saksham

-Original Message-
From: Nux! [mailto:n...@li.nux.ro] 
Sent: Wednesday, June 18, 2014 4:27 PM
To: dev@cloudstack.apache.org
Subject: Reset VM and it's gone - how do I get rid of this button??

Hi,

A colleague just wiped out a VM because he thought that buttong reboots the 
virtual machine...

Is there any way I can butcher the UI and remove that button or at least rename 
it to Reinstall VM or similar?

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro



Re: Xen Project support and state of APIs

2014-06-18 Thread Rohit Yadav
On Wed, Jun 18, 2014 at 4:32 PM, sebgoa run...@gmail.com wrote:


 there is on-going work about this:
 http://markmail.org/thread/sxezpziog2koewlt


Thanks for this Sebastien, re-reading them. I saw the emails but I could
not understand the email thread and had the Xen/XenServer/Xen Project
confusion at the time.

Regards.






 
 
 
  The Xen/XenProject/XenServer/XAPI/XCP is confusing [1]. From what I
  understand, XCP was some sort of an opensource version of XenServer,
 but
  since XenServer distribution (which consists of Xen, XenCenter, XAPI,
  Linux
  etc.) is opensource, XCP has been discontinued since 1.6 release?
 
 
  XCP was rolled into XenServer as of XenServer 6.2 which means 1.6 was
 the
  last version of XCP.  I tried to sum it up in this blog:
 
 
 http://open.citrix.com/blog/342-knowing-what-you-ve-got-avoiding-the-xen-vs-xenserver-confusion.html
 
 
  Thanks, this helps to understand what went in this transition.
 
 
  Now, on many Linux distro XAPI is still available as 'xcp-xapi' such as
  in
  Debian/Ubuntu, so what package(s) do you suggest one needs to install
 and
  configure so I can get DevCloud [2] work again? DevCloud is a VM that
  runs
  Xen (Xen Project) inside it and can be used as a virtual host to
  test/develop ACS against it.
 
 
  I see no reason why any other XAPI implementation wouldn't work, but
 it's
  entirely possible the version of xcp-xapi you have has issues with
  XenProject 4.4 due to normal versioning type issues.  There also was a
  different productization attempt called xenserver-core, but that
 looks to
  have died on the vine.  That being said, I could easily have broken
  something.  If I've broken something, I probably won't be able to test
  until next week due to travels.  The question of xapi inclusion in
 distros
  is one I'd need to check on.
 
 
  Yes, that would be great. I'll attempt testing it again with fresh setup
 in
  upcoming weekends.
 
  Regards.
 
 
 
 
 
  [1] http://www.xenproject.org/developers/teams/xapi.html
  [2] http://bhaisaab.org/logs/devcloud
 
  Regards.
 
 
 
 
  On Tue, Jun 17, 2014 at 4:27 PM, Tim Mackey tmac...@gmail.com wrote:
 
  Rohit,
 
  We've only supported xapi so far, so I'm curious if you had Xen
 Project
  4.4
  working before with xapi and if that is now broken. Nothing I did
  should
  have impacted that, but it wasn't in my test suite so anything is
  possible
  On Jun 17, 2014 11:21 AM, Rohit Yadav bhais...@apache.org wrote:
 
  Hi,
 
  Xen Project (previously xen.org xenserver) is widely accessible in
  several
  Linux distributions such as Arch, Fedora etc. Therefore, people may
  want
  to
  use it instead of XenServer (6.2 or later). The ACS 4.5 design doc
  [1]
  explains about XenServer and how it should be tested etc. but what
  about
  using Xen Project?
 
  Since the recent Xen plugin refactoring as xenserver plugin [1], I'm
  unable
  to get ACS to work with Xen Project 4.4 (on a real host and on a new
  custom
  DevCloud). Using the XenServer ACS plugin, it identifies a Xen
  Project
  host
  as some version of Xen but then fails. Has anyone tried this with ACS
  4.4/master? Are we going to test/support Xen Project (4.x) soon? If
  so,
  can
  people involved share their plan/vision/roadmap on it?
 
  Lastly, as the design doc [1] suggested XCP's development has
  stopped,
  are
  we going to favour using XAPI [1] now or libVirt [2] or something
  else?
 
  [1]
 
 
 
 
 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Convert+Xen+usage+to+XenServer
 
  [2] http://blog.xen.org/index.php/2014/03/10/xen-4-4-released
 
  Regards.
 
 
 
 




Re: Review Request 22725: CLOUDSTACK-6932: Removing redundant file test_escalations.py

2014-06-18 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22725/#review46063
---


Commit 7e4303821570d58ad962c85a1a3bd6dbf32f8d73 in cloudstack's branch 
refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7e43038 ]

CLOUDSTACK-6932: Removing redundant file test_escalations.py


- ASF Subversion and Git Services


On June 18, 2014, 11:08 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22725/
 ---
 
 (Updated June 18, 2014, 11:08 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-6932
 https://issues.apache.org/jira/browse/CLOUDSTACK-6932
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 
 test_escalations.py file has already been divided into different test suites 
 such as
 test_escalations_instances.py
 test_escalations_isos.py
 test_escalations_snapshots.py
 test_escalations_volumes.py
 test_escalations_ipaddresses.py
 test_escalations_networks.py
 test_escalations_securitygroups.py
 test_escalations_templates.py
 test_escalations_vpncustomergateways.py
 
 so the parent file needs to be removed from the repo.
 
 
 Diffs
 -
 
   test/integration/component/test_escalations.py 1b596a7 
 
 Diff: https://reviews.apache.org/r/22725/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 Patch for master
   
 https://reviews.apache.org/media/uploaded/files/2014/06/18/a6eb3655-f839-4d1b-9387-152fc7949478__0001-CLOUDSTACK-6932-Removing-redundant-file-test_escalat.patch
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 22725: CLOUDSTACK-6932: Removing redundant file test_escalations.py

2014-06-18 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22725/#review46064
---


Commit aa5572c0ee5efcc6431b7a48e342b157e5fd33ac in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=aa5572c ]

CLOUDSTACK-6932: Removing redundant file test_escalations.py


- ASF Subversion and Git Services


On June 18, 2014, 11:08 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22725/
 ---
 
 (Updated June 18, 2014, 11:08 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-6932
 https://issues.apache.org/jira/browse/CLOUDSTACK-6932
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 
 test_escalations.py file has already been divided into different test suites 
 such as
 test_escalations_instances.py
 test_escalations_isos.py
 test_escalations_snapshots.py
 test_escalations_volumes.py
 test_escalations_ipaddresses.py
 test_escalations_networks.py
 test_escalations_securitygroups.py
 test_escalations_templates.py
 test_escalations_vpncustomergateways.py
 
 so the parent file needs to be removed from the repo.
 
 
 Diffs
 -
 
   test/integration/component/test_escalations.py 1b596a7 
 
 Diff: https://reviews.apache.org/r/22725/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 Patch for master
   
 https://reviews.apache.org/media/uploaded/files/2014/06/18/a6eb3655-f839-4d1b-9387-152fc7949478__0001-CLOUDSTACK-6932-Removing-redundant-file-test_escalat.patch
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Reset VM and it's gone - how do I get rid of this button??

2014-06-18 Thread sebgoa

On Jun 18, 2014, at 1:05 PM, Nux! n...@li.nux.ro wrote:

 Grep said to replace this in webapps/client/scripts/instances.js and it seems 
 to be working.
 Is there anything else I need to watch out for?
 
 Additionally, can we add this in 4.3.1/4.4/master?

Looks like it's in 4.4 and master:

https://issues.apache.org/jira/browse/CLOUDSTACK-6272

I will cherry pick to 4.3

 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
 
 - Original Message -
 From: Nux! n...@li.nux.ro
 To: dev@cloudstack.apache.org
 Sent: Wednesday, 18 June, 2014 11:56:52 AM
 Subject: Reset VM and it's gone - how do I get rid of this button??
 
 Hi,
 
 A colleague just wiped out a VM because he thought that buttong reboots the 
 virtual machine...
 
 Is there any way I can butcher the UI and remove that button or at least 
 rename it to Reinstall VM or similar?
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 



Re: [ACS4.4] Cherry-pick

2014-06-18 Thread Daan Hoogland
On Wed, Jun 18, 2014 at 12:59 PM, Rajesh Battala
rajesh.batt...@citrix.com wrote:
 21e452ff4f0459422f0612f2ddf7033a963b0a19


there was a little conflict, which was easily resolved but please double check!

-- 
Daan


Build failed in Jenkins: cloudstack-4.4-maven-build #355

2014-06-18 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/355/changes

Changes:

[Daan Hoogland] CLOUDSTACK-6920 Support listing of LBHealthcheck policy with 
LBHealthcheck policy ID

--
[...truncated 1205 lines...]

Results :

Tests run: 33, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Jobs 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-framework-jobs 
---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/jobs/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/jobs
 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-jobs ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-jobs ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-jobs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-jobs ---
[INFO] Compiling 33 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/jobs/target/classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-jobs ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-jobs ---
[INFO] Compiling 4 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/jobs/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-framework-jobs ---
[INFO] Surefire report directory: 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/jobs/target/surefire-reports

---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Engine Internal Components API 
4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-engine-components-api ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/engine/components-api/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/engine/components-api
 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-engine-components-api ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-engine-components-api ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-engine-components-api ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-engine-components-api ---
[INFO] Compiling 31 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/engine/components-api/target/classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-engine-components-api ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/engine/components-api/test/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-engine-components-api ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-engine-components-api ---
[INFO] Surefire report directory: 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/engine/components-api/target/surefire-reports

---
 T E S T S

Re: Reset VM and it's gone - how do I get rid of this button??

2014-06-18 Thread sebgoa

On Jun 18, 2014, at 1:17 PM, sebgoa run...@gmail.com wrote:

 
 On Jun 18, 2014, at 1:05 PM, Nux! n...@li.nux.ro wrote:
 
 Grep said to replace this in webapps/client/scripts/instances.js and it 
 seems to be working.
 Is there anything else I need to watch out for?
 
 Additionally, can we add this in 4.3.1/4.4/master?
 
 Looks like it's in 4.4 and master:
 
 https://issues.apache.org/jira/browse/CLOUDSTACK-6272
 
 I will cherry pick to 4.3

Done, looks like 'reset' becomes 'reinstall'

 
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
 
 - Original Message -
 From: Nux! n...@li.nux.ro
 To: dev@cloudstack.apache.org
 Sent: Wednesday, 18 June, 2014 11:56:52 AM
 Subject: Reset VM and it's gone - how do I get rid of this button??
 
 Hi,
 
 A colleague just wiped out a VM because he thought that buttong reboots the 
 virtual machine...
 
 Is there any way I can butcher the UI and remove that button or at least 
 rename it to Reinstall VM or similar?
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
 



Re: [ACS4.4] Cherry-pick

2014-06-18 Thread Daan Hoogland
[ERROR] COMPILATION ERROR :
[INFO] --
---
[ERROR] 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java:[174,7]
error: LoadBalancingRulesManagerImpl is not abstract and does not
override abstract method findLbByStickinessId(long) in
LoadBalancingRulesService

I didn't run a test build :(

should I revert or do you have an implementation of the method laying around?

On Wed, Jun 18, 2014 at 1:22 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
 On Wed, Jun 18, 2014 at 12:59 PM, Rajesh Battala
 rajesh.batt...@citrix.com wrote:
 21e452ff4f0459422f0612f2ddf7033a963b0a19


 there was a little conflict, which was easily resolved but please double 
 check!

 --
 Daan



-- 
Daan


RE: [ACS4.4] Cherry-pick

2014-06-18 Thread Rajesh Battala
Am working on it. 

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Wednesday, June 18, 2014 5:01 PM
To: dev
Subject: Re: [ACS4.4] Cherry-pick

[ERROR] COMPILATION ERROR :
[INFO] --
---
[ERROR] 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java:[174,7]
error: LoadBalancingRulesManagerImpl is not abstract and does not override 
abstract method findLbByStickinessId(long) in LoadBalancingRulesService

I didn't run a test build :(

should I revert or do you have an implementation of the method laying around?

On Wed, Jun 18, 2014 at 1:22 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
 On Wed, Jun 18, 2014 at 12:59 PM, Rajesh Battala 
 rajesh.batt...@citrix.com wrote:
 21e452ff4f0459422f0612f2ddf7033a963b0a19


 there was a little conflict, which was easily resolved but please double 
 check!

 --
 Daan



--
Daan


cloud spec for mysql-ha connector (was: off list)

2014-06-18 Thread Daan Hoogland
H devs,

I had an offline discussion about a classloader problem [1] and an
analog discussion with Hugo. It seems we want to create an extra rpm
that must be installed when mysql ha is required. This will be
specified in the cloud.spec file and will result in an extra package
when -Dnoredist is used. On installation this would have to
specifically be installed along with the rest if so desired.

A similar construct has to be devised for debian and windows
installations. Can the respective gurus in those fields look at that?

thanks,

[1] https://issues.apache.org/jira/browse/CLOUDSTACK-6928

On Wed, Jun 18, 2014 at 11:50 AM, Damoder Reddy
damoder.re...@citrix.com wrote:
 Ok I forgot the DEB builds.

 To satisfy both, this should be included in catalina.properties.in.

 But only question I have is how do we change it for each version and taking 
 care of upgrades as well.

 Thanks  Regards
 Damodar/


 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Wednesday, June 18, 2014 3:10 PM
 To: Damoder Reddy
 Cc: sebgoa; Adrian Lewis
 Subject: Re: off list

 But only for the noredist version? and how about the deb version?

 On Wed, Jun 18, 2014 at 11:34 AM, Damoder Reddy damoder.re...@citrix.com 
 wrote:
 We can put this step as part of rpm creation in cloud.spec file.

 Thanks  Regards
 Damodar/


 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Wednesday, June 18, 2014 2:59 PM
 To: Damoder Reddy
 Cc: sebgoa; Adrian Lewis
 Subject: Re: off list

 The 'just' in 'Just put a symbolic link' implies a install instruction, does 
 it? Or can we automate this step?

 On Wed, Jun 18, 2014 at 11:16 AM, Damoder Reddy damoder.re...@citrix.com 
 wrote:
 Hi,

 There are 2 solutions.

 one either change the catalina.properties to include strategy in the
 common.loader as suggested in another thread mail

 OR

 Just put a symbolic link to the jar file inside
 /usr/share/tomcat6/lib as this path is already loaded by common.loader 
 (common.loader=${catalina.base}/lib,${catalina.base}/lib/*.jar,${catalina.home}/lib,${catalina.home}/lib/*.jar,/usr/share/java/mysql-connector-java.jar).

 I think 2nd option is better instead of 1st one.

 Thanks  Regards
 Damodar/

 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Wednesday, June 18, 2014 2:37 PM
 To: sebgoa
 Cc: Damoder Reddy; Adrian Lewis
 Subject: Re: off list

 had Adrians address wrong


 -- Forwarded message --
 From: Daan Hoogland daan.hoogl...@gmail.com
 Date: Wed, Jun 18, 2014 at 10:42 AM
 Subject: Re: off list
 To: sebgoa run...@gmail.com
 Cc: Damoder Reddy damoder.re...@citrix.com, Adrian Lewis
 adr...@alsiconsulting.co.uk


 I had a quick look. it doesn't seem a coding issue but a 
 configuration/packaging issue. the file catalina.properties.in must be 
 adjusted for this. There are two in the project. One for the ui, which I 
 think won't need to be touched and one for the server. Damoder Reddy helped 
 Adrien on this. cc'ing him and Adrien in now.

 @Damoder: can you confirm that we need to adjust the common.loader property 
 in catalina.properties.in for CLOUDSTACK-6892?

 This way we should be done according to Adrien. This should be done for 
 4.3, 4.4 and master!

 regards,

 On Wed, Jun 18, 2014 at 10:10 AM, sebgoa run...@gmail.com wrote:

 On Jun 18, 2014, at 10:06 AM, Daan Hoogland daan.hoogl...@gmail.com 
 wrote:

 it is not implemented/solved. not in 4.4 or master. Is work on it done 
 already?

 not clear from the ticket.

 I just don't know how to modify the catalina properties in the code.


 On Wed, Jun 18, 2014 at 10:04 AM, Daan Hoogland daan.hoogl...@gmail.com 
 wrote:
 on it

 On Wed, Jun 18, 2014 at 9:05 AM, Sebastien Goasguen run...@gmail.com 
 wrote:
 Hi Daan,

 Can you check this one:
 https://issues.apache.org/jira/browse/CLOUDSTACK-6892

 it might apply to 4.4 and 4.3 and I no squat in java



 --
 Daan



 --
 Daan




 --
 Daan


 --
 Daan



 --
 Daan



 --
 Daan



-- 
Daan


Re: cloud spec for mysql-ha connector (was: off list)

2014-06-18 Thread Daan Hoogland
My link to the issue is wrong*^%%(*(*@#$

it should be

[1] https://issues.apache.org/jira/browse/CLOUDSTACK-6892

On Wed, Jun 18, 2014 at 1:49 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
 H devs,

 I had an offline discussion about a classloader problem [1] and an
 analog discussion with Hugo. It seems we want to create an extra rpm
 that must be installed when mysql ha is required. This will be
 specified in the cloud.spec file and will result in an extra package
 when -Dnoredist is used. On installation this would have to
 specifically be installed along with the rest if so desired.

 A similar construct has to be devised for debian and windows
 installations. Can the respective gurus in those fields look at that?

 thanks,

 [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6928

 On Wed, Jun 18, 2014 at 11:50 AM, Damoder Reddy
 damoder.re...@citrix.com wrote:
 Ok I forgot the DEB builds.

 To satisfy both, this should be included in catalina.properties.in.

 But only question I have is how do we change it for each version and taking 
 care of upgrades as well.

 Thanks  Regards
 Damodar/


 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Wednesday, June 18, 2014 3:10 PM
 To: Damoder Reddy
 Cc: sebgoa; Adrian Lewis
 Subject: Re: off list

 But only for the noredist version? and how about the deb version?

 On Wed, Jun 18, 2014 at 11:34 AM, Damoder Reddy damoder.re...@citrix.com 
 wrote:
 We can put this step as part of rpm creation in cloud.spec file.

 Thanks  Regards
 Damodar/


 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Wednesday, June 18, 2014 2:59 PM
 To: Damoder Reddy
 Cc: sebgoa; Adrian Lewis
 Subject: Re: off list

 The 'just' in 'Just put a symbolic link' implies a install instruction, 
 does it? Or can we automate this step?

 On Wed, Jun 18, 2014 at 11:16 AM, Damoder Reddy damoder.re...@citrix.com 
 wrote:
 Hi,

 There are 2 solutions.

 one either change the catalina.properties to include strategy in the
 common.loader as suggested in another thread mail

 OR

 Just put a symbolic link to the jar file inside
 /usr/share/tomcat6/lib as this path is already loaded by common.loader 
 (common.loader=${catalina.base}/lib,${catalina.base}/lib/*.jar,${catalina.home}/lib,${catalina.home}/lib/*.jar,/usr/share/java/mysql-connector-java.jar).

 I think 2nd option is better instead of 1st one.

 Thanks  Regards
 Damodar/

 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Wednesday, June 18, 2014 2:37 PM
 To: sebgoa
 Cc: Damoder Reddy; Adrian Lewis
 Subject: Re: off list

 had Adrians address wrong


 -- Forwarded message --
 From: Daan Hoogland daan.hoogl...@gmail.com
 Date: Wed, Jun 18, 2014 at 10:42 AM
 Subject: Re: off list
 To: sebgoa run...@gmail.com
 Cc: Damoder Reddy damoder.re...@citrix.com, Adrian Lewis
 adr...@alsiconsulting.co.uk


 I had a quick look. it doesn't seem a coding issue but a 
 configuration/packaging issue. the file catalina.properties.in must be 
 adjusted for this. There are two in the project. One for the ui, which I 
 think won't need to be touched and one for the server. Damoder Reddy 
 helped Adrien on this. cc'ing him and Adrien in now.

 @Damoder: can you confirm that we need to adjust the common.loader 
 property in catalina.properties.in for CLOUDSTACK-6892?

 This way we should be done according to Adrien. This should be done for 
 4.3, 4.4 and master!

 regards,

 On Wed, Jun 18, 2014 at 10:10 AM, sebgoa run...@gmail.com wrote:

 On Jun 18, 2014, at 10:06 AM, Daan Hoogland daan.hoogl...@gmail.com 
 wrote:

 it is not implemented/solved. not in 4.4 or master. Is work on it done 
 already?

 not clear from the ticket.

 I just don't know how to modify the catalina properties in the code.


 On Wed, Jun 18, 2014 at 10:04 AM, Daan Hoogland 
 daan.hoogl...@gmail.com wrote:
 on it

 On Wed, Jun 18, 2014 at 9:05 AM, Sebastien Goasguen run...@gmail.com 
 wrote:
 Hi Daan,

 Can you check this one:
 https://issues.apache.org/jira/browse/CLOUDSTACK-6892

 it might apply to 4.4 and 4.3 and I no squat in java



 --
 Daan



 --
 Daan




 --
 Daan


 --
 Daan



 --
 Daan



 --
 Daan



 --
 Daan



-- 
Daan


RE: [ACS4.4] Cherry-pick

2014-06-18 Thread Rajesh Battala
Hi Daan, 
This commit is based on the commit 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=b0d726a872e2859a56ee677c15079cc3a59ab894;hp=a5415d93eb791bac52c40b9ede6a433a0d7f1dca
 

this commit (b0d726a872e2859a56ee677c15079cc3a59ab894) is in 4.4-forward and 
not in 4.4 which is committed by jaypal yesterday
when I have fixed my bug I have to rebase jaypal commit which is in 4.4-forward 
and build is successfully. 

When you have cherry-picked my commit to 4.4, this 
commit(b0d726a872e2859a56ee677c15079cc3a59ab894) is not cherry-picked. This 
commit is required as my changes are based on top of it. 

Please cherry-pick b0d726a872e2859a56ee677c15079cc3a59ab894 and then apply my 
commit on top of it which will resolve the issue.


Thanks
Rajesh Battala

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Wednesday, June 18, 2014 5:11 PM
To: dev@cloudstack.apache.org
Subject: RE: [ACS4.4] Cherry-pick

Am working on it. 

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, June 18, 2014 5:01 PM
To: dev
Subject: Re: [ACS4.4] Cherry-pick

[ERROR] COMPILATION ERROR :
[INFO] --
---
[ERROR] 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java:[174,7]
error: LoadBalancingRulesManagerImpl is not abstract and does not override 
abstract method findLbByStickinessId(long) in LoadBalancingRulesService

I didn't run a test build :(

should I revert or do you have an implementation of the method laying around?

On Wed, Jun 18, 2014 at 1:22 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
 On Wed, Jun 18, 2014 at 12:59 PM, Rajesh Battala 
 rajesh.batt...@citrix.com wrote:
 21e452ff4f0459422f0612f2ddf7033a963b0a19


 there was a little conflict, which was easily resolved but please double 
 check!

 --
 Daan



--
Daan


Re: [ACS4.4] Cherry-pick

2014-06-18 Thread Daan Hoogland
On Wed, Jun 18, 2014 at 2:07 PM, Rajesh Battala
rajesh.batt...@citrix.com wrote:
 b0d726a872e2859a56ee677c15079cc3a59ab894


This again gave me a simple conflict in the interface. another method
was added. It was indeed not there so I committed and pushed it.

-- 
Daan


MySQL Client dependency not installed with RPMs

2014-06-18 Thread Adrian Lewis
Afraid I’m not a dev of any sort but can we add the package ‘mysql’ (MySQL
client package) to the cloud.spec file. If you’re installing the
mysql-server package on the same host as the mgmt server it’s not a problem
but for those installing from the repo and using an external db host, it
doesn’t get installed. Just one little thing to help the ease of
installation.



Not sure about Debian/Ubuntu – anyone able to verify?



Is this worthy of a Jira issue?



Adrian


Jenkins build is back to normal : cloudstack-4.4-maven-build #356

2014-06-18 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/356/changes



Re: MySQL Client dependency not installed with RPMs

2014-06-18 Thread Daan Hoogland
Adrian, this is about
https://issues.apache.org/jira/browse/CLOUDSTACK-6892 isn't it?

I am afraid we are communicating along paralel lines here. The last
mail I sent you went to dev@ as well.

On Wed, Jun 18, 2014 at 2:26 PM, Adrian Lewis
adr...@alsiconsulting.co.uk wrote:
 Afraid I’m not a dev of any sort but can we add the package ‘mysql’ (MySQL
 client package) to the cloud.spec file. If you’re installing the
 mysql-server package on the same host as the mgmt server it’s not a problem
 but for those installing from the repo and using an external db host, it
 doesn’t get installed. Just one little thing to help the ease of
 installation.



 Not sure about Debian/Ubuntu – anyone able to verify?



 Is this worthy of a Jira issue?



 Adrian



-- 
Daan


RE: MySQL Client dependency not installed with RPMs

2014-06-18 Thread Adrian Lewis
Hi Daan,

No - separate issue. Just bringing it up as you mentioned making changes to
the cloud.spec file in a different email. This is independent of anyone
trying to implement DB HA and just anyone installing from packages and using
an external DB - HA or not.

Adrian

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: 18 June 2014 13:32
To: dev
Subject: Re: MySQL Client dependency not installed with RPMs

Adrian, this is about
https://issues.apache.org/jira/browse/CLOUDSTACK-6892 isn't it?

I am afraid we are communicating along paralel lines here. The last mail I
sent you went to dev@ as well.

On Wed, Jun 18, 2014 at 2:26 PM, Adrian Lewis adr...@alsiconsulting.co.uk
wrote:
 Afraid I’m not a dev of any sort but can we add the package ‘mysql’
 (MySQL client package) to the cloud.spec file. If you’re installing
 the mysql-server package on the same host as the mgmt server it’s not
 a problem but for those installing from the repo and using an external
 db host, it doesn’t get installed. Just one little thing to help the
 ease of installation.



 Not sure about Debian/Ubuntu – anyone able to verify?



 Is this worthy of a Jira issue?



 Adrian



--
Daan


Re: Reset VM and it's gone - how do I get rid of this button??

2014-06-18 Thread Nux!
That's great, thanks guys.

This should prevent future tragedies. :-)

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


- Original Message -
From: sebgoa run...@gmail.com
To: dev@cloudstack.apache.org
Sent: Wednesday, 18 June, 2014 12:27:48 PM
Subject: Re: Reset VM and it's gone - how do I get rid of this button??


On Jun 18, 2014, at 1:17 PM, sebgoa run...@gmail.com wrote:

 
 On Jun 18, 2014, at 1:05 PM, Nux! n...@li.nux.ro wrote:
 
 Grep said to replace this in webapps/client/scripts/instances.js and it 
 seems to be working.
 Is there anything else I need to watch out for?
 
 Additionally, can we add this in 4.3.1/4.4/master?
 
 Looks like it's in 4.4 and master:
 
 https://issues.apache.org/jira/browse/CLOUDSTACK-6272
 
 I will cherry pick to 4.3

Done, looks like 'reset' becomes 'reinstall'

 
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
 
 - Original Message -
 From: Nux! n...@li.nux.ro
 To: dev@cloudstack.apache.org
 Sent: Wednesday, 18 June, 2014 11:56:52 AM
 Subject: Reset VM and it's gone - how do I get rid of this button??
 
 Hi,
 
 A colleague just wiped out a VM because he thought that buttong reboots the 
 virtual machine...
 
 Is there any way I can butcher the UI and remove that button or at least 
 rename it to Reinstall VM or similar?
 
 --
 Sent from the Delta quadrant using Borg technology!
 
 Nux!
 www.nux.ro
 
 



Re: MySQL Client dependency not installed with RPMs

2014-06-18 Thread Daan Hoogland
ok, i see. That's a different issue indeed though the solutions are
related, obviously.

On Wed, Jun 18, 2014 at 2:37 PM, Adrian Lewis
adr...@alsiconsulting.co.uk wrote:
 Hi Daan,

 No - separate issue. Just bringing it up as you mentioned making changes to
 the cloud.spec file in a different email. This is independent of anyone
 trying to implement DB HA and just anyone installing from packages and using
 an external DB - HA or not.

 Adrian

 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: 18 June 2014 13:32
 To: dev
 Subject: Re: MySQL Client dependency not installed with RPMs

 Adrian, this is about
 https://issues.apache.org/jira/browse/CLOUDSTACK-6892 isn't it?

 I am afraid we are communicating along paralel lines here. The last mail I
 sent you went to dev@ as well.

 On Wed, Jun 18, 2014 at 2:26 PM, Adrian Lewis adr...@alsiconsulting.co.uk
 wrote:
 Afraid I’m not a dev of any sort but can we add the package ‘mysql’
 (MySQL client package) to the cloud.spec file. If you’re installing
 the mysql-server package on the same host as the mgmt server it’s not
 a problem but for those installing from the repo and using an external
 db host, it doesn’t get installed. Just one little thing to help the
 ease of installation.



 Not sure about Debian/Ubuntu – anyone able to verify?



 Is this worthy of a Jira issue?



 Adrian



 --
 Daan



-- 
Daan


[ACS-Master] Cannot load compute offerings: NPE

2014-06-18 Thread Wilder Rodrigues
Hi guys,

I'm facing a problem when loading service offerings on ACS Master branch. Is 
anyone aware of this? Is there any issue open?

2014-06-18 15:54:52,495 DEBUG [c.c.a.ApiServlet] 
(19418424@qtp-9894122-6:ctx-3a0f1094) ===START===  0:0:0:0:0:0:0:1 -- GET  
command=listServ
iceOfferingsresponse=jsonsessionkey=pzJwAgN95saj%2FfExWkezaytg7U4%3DlistAll=truepage=1pagesize=20issystem=false_=1403099692481
2014-06-18 15:54:52,608 WARN  [c.c.a.d.ParamGenericValidationWorker] 
(19418424@qtp-9894122-6:ctx-3a0f1094 ctx-226b1105) Received unknown par
ameters for command listServiceOfferings. Unknown parameters : listall
2014-06-18 15:54:52,710 ERROR [c.c.a.ApiServer] 
(19418424@qtp-9894122-6:ctx-3a0f1094 ctx-226b1105) unhandled exception 
executing api command
: [Ljava.lang.String;@fd06cb
java.lang.NullPointerException
at 
com.cloud.api.query.dao.ServiceOfferingJoinDaoImpl.newServiceOfferingResponse(ServiceOfferingJoinDaoImpl.java:62)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
at 
com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at 
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
at com.sun.proxy.$Proxy270.newServiceOfferingResponse(Unknown Source)
at 
com.cloud.api.ApiDBUtils.newServiceOfferingResponse(ApiDBUtils.java:1794)
at 
com.cloud.api.query.ViewResponseHelper.createServiceOfferingResponse(ViewResponseHelper.java:354)
at 
com.cloud.api.query.QueryManagerImpl.searchForServiceOfferings(QueryManagerImpl.java:2415)
at 
org.apache.cloudstack.api.command.user.offering.ListServiceOfferingsCmd.execute(ListServiceOfferingsCmd.java:106)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:141)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:689)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:512)
at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:317)
at com.cloud.api.ApiServlet$1.run(ApiServlet.java:118)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:115)
at com.cloud.api.ApiServlet.doGet(ApiServlet.java:77)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at 
org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at 
org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
at 
org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at 
org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at 
org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
at 
org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
at 
org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
at 
org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at 
org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at 
org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at 

RE: Managing individual ESXi instances

2014-06-18 Thread Alex Huang
IIRC, the reason is because the vCenter API is more powerful than the ESX API.  
At the time (before Apache), the features that requested needed vCenter. 
There's currently no proposal to use plain ESXi.  Would love to see one though.

--Alex

 -Original Message-
 From: Ivan Efremov [mailto:e...@yandex.ru]
 Sent: Tuesday, June 17, 2014 8:26 PM
 To: dev@cloudstack.apache.org
 Subject: Managing individual ESXi instances
 
 Hi all,
 
 I've sent this mail to the users list but this one looks as the better 
 destination.
 
 I'm new to the CloudStack platform and I'm wondering why the platform
 does need the vCenter API and can not use ESXi directly,
 
 Can anyone elaborate on this?
 Are there any proposals for adding ESXi integration to CloudStack?
 
 
 Thanks,
 Ivan


Re: Review Request 22692: Test Suite for Testing Remote Access VPN on VPC

2014-06-18 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22692/#review46072
---



test/integration/component/test_remotevpn_vpc.py
https://reviews.apache.org/r/22692/#comment81224

Check get_zone change requires one more argument, please check the bvt 
cases for example



test/integration/component/test_remotevpn_vpc.py
https://reviews.apache.org/r/22692/#comment81225

Do we want to clean the existing service offering if not created by us?



test/integration/component/test_remotevpn_vpc.py
https://reviews.apache.org/r/22692/#comment81226

Check is not None



test/integration/component/test_remotevpn_vpc.py
https://reviews.apache.org/r/22692/#comment81227

Message sleep for sleep



test/integration/component/test_remotevpn_vpc.py
https://reviews.apache.org/r/22692/#comment81228

Do we wanted to check the template stauts?



test/integration/component/test_remotevpn_vpc.py
https://reviews.apache.org/r/22692/#comment81229

As well add tags related to required_hardware=true or 
required_hardware=false. This signifies whether these are simulator based or 
not. Check bvt cases for example


- Santhosh Edukulla


On June 17, 2014, 7:24 p.m., Chandan Purushothama wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22692/
 ---
 
 (Updated June 17, 2014, 7:24 p.m.)
 
 
 Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha 
 hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, SrikanteswaraRao 
 Talluri, and Sheng Yang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Test Suite for Testing Remote Access VPN on VPC. 
 
 I successfully automated the following components:
 
 1.VPN Client Installation on Linux
 2.Component that efficiently verifies Remote VPN Access between client and 
 the Server.
 3.Developed a component that automates VPN Client Configuration and services.
 4.Test Cases of the Feature
 5.Tested the Code multiple times on XenServer and fixed the bugs.
 
 
 Diffs
 -
 
   test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
   tools/marvin/marvin/config/test_data.py d870c98 
 
 Diff: https://reviews.apache.org/r/22692/diff/
 
 
 Testing
 ---
 
 Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: 
 test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS ===
 ok
 Test case no : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser 
 | Status : SUCCESS ===
 ok
 Test case no : Add a Different VPN User and Test Access with already existing 
 VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS 
 ===
 ok
 Test case no : Add a Previously Removed VPN User from the VPC and Test the 
 VPN Connectivity ... === TestName: 
 test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS ===
 ok
 Test case no : Disable the VPN Service on the VPC ... === TestName: 
 test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS ===
 ok
 Test case no : Enabled Previously Dsiabled VPN Access to VPC. ... === 
 TestName: test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : 
 SUCCESS ===
 ok
 Test case no : Create Nine VPN Users to test the remote.vpn.user.limit=8 
 Configuration parameter ... === TestName: 
 test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS ===
 ok
 
 --
 Ran 7 tests in 1771.352s
 
 OK
 
 
 Thanks,
 
 Chandan Purushothama
 




Re: ZoneWideStoragePoolAllocator#filter seems weird for me

2014-06-18 Thread Mike Tutkowski
Yeah, storagePoolHasEnoughIops returns true in the traditional case (i.e.
non-managed storage) so we won't skip a storage pool when IOPS are not
really being taken into consideration.

Feel free to make enhancements and I can review your patch.

Thanks!


On Wed, Jun 18, 2014 at 12:14 AM, Yoshikazu Nojima m...@ynojima.net wrote:

 Prachi, Mike,
 I appreciate your comments.

 I think it is a bug that there is a difference between filter logic of
 ClusterScopeStoragePoolAllocator and that of
 ZoneWideStoragePoolAllocator
 (ex. allocator skip iSCSI type storage pool or not when a volume is a
 RootDisk),
 I will unify by implementing it in AbstractStoragePoolAllocator#filter
 method.

 It is new information for me that managed storages only support zone
 level. Thank you for let me know.
 But when iopscapacity parameter is not set to a primary storage (i.e.
 unmanaged storage), storageMgr.storagePoolHasEnoughIops always returns
 true.
 I suppose calling storageMgr.storagePoolHasEnoughIops from
 AbstractStoragePoolAllocator will not cause a problem, and it will
 simplify the code.

 I created a patch to explain my thought. Could you review it?
 https://reviews.apache.org/r/22717/

 Regards,
 Noji


 2014-06-17 19:19 GMT-06:00 Mike Tutkowski mike.tutkow...@solidfire.com:
  I can comment on the IOPS part.
 
  The IOPS are currently only relevant when using managed storage (which is
  currently only applicable at the zone level). That being the case, no
  cluster (or local) storage takes advantage of counting IOPS that have
 been
  handed out.
 
  Of course this logic might be expanded in the future, but that's how it
  works today.
 
 
  On Tue, Jun 17, 2014 at 2:47 PM, Prachi Damle prachi.da...@citrix.com
  wrote:
 
  Why ZoneWideStoragePoolAllocator implements filter method (and
 doesn't
  call that of base class) rather than just using that of base class?
  ZoneWideStoragePoolAllocator#filter method seems doesn't care avoid
  parameter, doesn't skip iSCSI type storage pool even if a volume is a
  RootDisk.
 
  The first question seems like a bug to me.
 
  I am not sure about the IOPS
 
  Prachi
 
  -Original Message-
  From: ynoj...@ynojima.net [mailto:ynoj...@ynojima.net] On Behalf Of
  Yoshikazu Nojima
  Sent: Tuesday, June 17, 2014 1:07 PM
  To: dev@cloudstack.apache.org
  Subject: ZoneWideStoragePoolAllocator#filter seems weird for me
 
  Hi,
 
  ZoneWideStoragePoolAllocator#filter seems weird for me.
 
  ZoneWideStoragePoolAllocator and ClusterScopeStoragePoolAllocator are
  allocator classes to select storage pool.
  They extends AbstractStoragePoolAllocator class, which provides filter
  method to exclude unavailable storage pools.
 
  Why ZoneWideStoragePoolAllocator implements filter method (and doesn't
  call that of base class) rather than just using that of base class?
 
  ZoneWideStoragePoolAllocator#filter method seems doesn't care avoid
  parameter, doesn't skip iSCSI type storage pool even if a volume is a
  RootDisk.
  (These functions are implemented in
  AbstractStoragePoolAllocator#filter method, which used by
  ClusterScopeStoragePoolAllocator.)
  On the other hand, AbstractStoragePoolAllocator#filter doesn't call
  storageMgr.storagePoolHasEnoughIops, so a cluster wide primary storage
  would be allocated more volumes than its designated IOPS capacity.
 
  Is there any difference between a zone wide primary storage and a
 cluster
  wide primary storage except its scope?
  If it is a bug, I'll fix it.
 
  Regards,
  Noji
 
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the cloud
  http://solidfire.com/solution/overview/?video=play*™*




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*


Re: ZoneWideStoragePoolAllocator#filter seems weird for me

2014-06-18 Thread Mike Tutkowski
Sorry...I didn't see until later in my e-mail that you had submitted code.

It looks good to me.

Is this something you'd like checked in right away or are you planning to
add to this patch?

Thanks!


On Wed, Jun 18, 2014 at 9:06 AM, Mike Tutkowski 
mike.tutkow...@solidfire.com wrote:

 Yeah, storagePoolHasEnoughIops returns true in the traditional case (i.e.
 non-managed storage) so we won't skip a storage pool when IOPS are not
 really being taken into consideration.

 Feel free to make enhancements and I can review your patch.

 Thanks!


 On Wed, Jun 18, 2014 at 12:14 AM, Yoshikazu Nojima m...@ynojima.net
 wrote:

 Prachi, Mike,
 I appreciate your comments.

 I think it is a bug that there is a difference between filter logic of
 ClusterScopeStoragePoolAllocator and that of
 ZoneWideStoragePoolAllocator
 (ex. allocator skip iSCSI type storage pool or not when a volume is a
 RootDisk),
 I will unify by implementing it in AbstractStoragePoolAllocator#filter
 method.

 It is new information for me that managed storages only support zone
 level. Thank you for let me know.
 But when iopscapacity parameter is not set to a primary storage (i.e.
 unmanaged storage), storageMgr.storagePoolHasEnoughIops always returns
 true.
 I suppose calling storageMgr.storagePoolHasEnoughIops from
 AbstractStoragePoolAllocator will not cause a problem, and it will
 simplify the code.

 I created a patch to explain my thought. Could you review it?
 https://reviews.apache.org/r/22717/

 Regards,
 Noji


 2014-06-17 19:19 GMT-06:00 Mike Tutkowski mike.tutkow...@solidfire.com:
  I can comment on the IOPS part.
 
  The IOPS are currently only relevant when using managed storage (which
 is
  currently only applicable at the zone level). That being the case, no
  cluster (or local) storage takes advantage of counting IOPS that have
 been
  handed out.
 
  Of course this logic might be expanded in the future, but that's how it
  works today.
 
 
  On Tue, Jun 17, 2014 at 2:47 PM, Prachi Damle prachi.da...@citrix.com
  wrote:
 
  Why ZoneWideStoragePoolAllocator implements filter method (and
 doesn't
  call that of base class) rather than just using that of base class?
  ZoneWideStoragePoolAllocator#filter method seems doesn't care avoid
  parameter, doesn't skip iSCSI type storage pool even if a volume is a
  RootDisk.
 
  The first question seems like a bug to me.
 
  I am not sure about the IOPS
 
  Prachi
 
  -Original Message-
  From: ynoj...@ynojima.net [mailto:ynoj...@ynojima.net] On Behalf Of
  Yoshikazu Nojima
  Sent: Tuesday, June 17, 2014 1:07 PM
  To: dev@cloudstack.apache.org
  Subject: ZoneWideStoragePoolAllocator#filter seems weird for me
 
  Hi,
 
  ZoneWideStoragePoolAllocator#filter seems weird for me.
 
  ZoneWideStoragePoolAllocator and ClusterScopeStoragePoolAllocator are
  allocator classes to select storage pool.
  They extends AbstractStoragePoolAllocator class, which provides
 filter
  method to exclude unavailable storage pools.
 
  Why ZoneWideStoragePoolAllocator implements filter method (and
 doesn't
  call that of base class) rather than just using that of base class?
 
  ZoneWideStoragePoolAllocator#filter method seems doesn't care avoid
  parameter, doesn't skip iSCSI type storage pool even if a volume is a
  RootDisk.
  (These functions are implemented in
  AbstractStoragePoolAllocator#filter method, which used by
  ClusterScopeStoragePoolAllocator.)
  On the other hand, AbstractStoragePoolAllocator#filter doesn't call
  storageMgr.storagePoolHasEnoughIops, so a cluster wide primary storage
  would be allocated more volumes than its designated IOPS capacity.
 
  Is there any difference between a zone wide primary storage and a
 cluster
  wide primary storage except its scope?
  If it is a bug, I'll fix it.
 
  Regards,
  Noji
 
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the cloud
  http://solidfire.com/solution/overview/?video=play*™*




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud
 http://solidfire.com/solution/overview/?video=play*™*




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*


Re: Review Request 22709: This test suite contains test cases relating to access checks for createNetwork(), deploying VM in an isolated network and restartNetwork() for Admin, domain admin and regula

2014-06-18 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22709/#review46074
---



test/integration/component/test_acl_isolatednetwork.py
https://reviews.apache.org/r/22709/#comment81240

Move this to test data under marvin/config directory, if possible.



test/integration/component/test_acl_isolatednetwork.py
https://reviews.apache.org/r/22709/#comment81235

Just check the way, we have changed get_zone in bvt, additional argument?



test/integration/component/test_acl_isolatednetwork.py
https://reviews.apache.org/r/22709/#comment81236

Lot of entities got created, is clean up happening for all of them? I mean 
can we double check post running the script from ms server that nothing was 
left out, either offerings, vms, accounts etc.



test/integration/component/test_acl_isolatednetwork.py
https://reviews.apache.org/r/22709/#comment81234

Please add test steps as doc strings, that way we can generate test steps 
for each test case. We can easily copy paste from your tes tplan as well?



test/integration/component/test_acl_isolatednetwork.py
https://reviews.apache.org/r/22709/#comment81232

Is it possible to define all exception entities in CloudStackException and 
check for them? Otherwise maintenance will be a bit difficult if we just search 
for message? As well, convert to lower() and search.



test/integration/component/test_acl_isolatednetwork.py
https://reviews.apache.org/r/22709/#comment81233

Better thing is to localize all these check in to a function and pass 
exception object and message to verify, define all your exception messages in 
class and verify by passing them. EX:

class ExampleExceptionsToVerify:
ABC=verify abc
BCD=verify bcd

verifyMsginException(e,ExampleExceptionsToVerify.ABC). This way, all 
messages can be handled in one single function and maintenance will be easy?



test/integration/component/test_acl_isolatednetwork.py
https://reviews.apache.org/r/22709/#comment81231

Is it as well a fail scenario if expected exception message is not in the 
response? Question: Is receiving an exception message is important or its 
content as well? 





test/integration/component/test_acl_isolatednetwork.py
https://reviews.apache.org/r/22709/#comment81230

Move this inside try block. As well, use self.fail instead of this,it looks 
neat to read.


- Santhosh Edukulla


On June 18, 2014, 1:28 a.m., sangeetha hariharan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22709/
 ---
 
 (Updated June 18, 2014, 1:28 a.m.)
 
 
 Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 This test suite contains test cases relating to access checks for 
 createNetwork(), deploying VM in an isolated network and restartNetwork() for 
 Admin, domain admin and regular users.
 
 
 Diffs
 -
 
   test/integration/component/test_acl_isolatednetwork.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/22709/diff/
 
 
 Testing
 ---
 
 test_01_createNetwork_admin 
 (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
 TestName: test_01_createNetwork_admin | Status : SUCCESS ===
 ok
 test_02_createNetwork_admin_foruserinsamedomain 
 (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
 TestName: test_02_createNetwork_admin_foruserinsamedomain | Status : SUCCESS 
 ===
 ok
 test_03_createNetwork_admin_foruserinotherdomain 
 (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
 TestName: test_03_createNetwork_admin_foruserinotherdomain | Status : SUCCESS 
 ===
 ok
 test_04_createNetwork_domaindmin 
 (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
 TestName: test_04_createNetwork_domaindmin | Status : SUCCESS ===
 ok
 test_05_createNetwork_domaindmin_foruserinsamedomain 
 (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
 TestName: test_05_createNetwork_domaindmin_foruserinsamedomain | Status : 
 SUCCESS ===
 ok
 test_06_createNetwork_domaindmin_foruserinsubdomain 
 (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
 TestName: test_06_createNetwork_domaindmin_foruserinsubdomain | Status : 
 SUCCESS ===
 ok
 test_07_createNetwork_domaindmin_forcrossdomainuser 
 (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
 TestName: test_07_createNetwork_domaindmin_forcrossdomainuser | Status : 
 SUCCESS ===
 ok
 test_08_createNetwork_user 
 (integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
 TestName: test_08_createNetwork_user | Status : 

Re: [ACS-Master] Cannot load compute offerings: NPE

2014-06-18 Thread Mike Tutkowski
I noticed a similar issue yesterday when trying to retrieve a list of
storage volumes.

I was planning on building everything up from scratch again (including the
DB) to repro the issue to see if it's gone now, but it looks like it might
be a more wide-spread problem than what I was just seeing.


On Wed, Jun 18, 2014 at 8:07 AM, Wilder Rodrigues 
wrodrig...@schubergphilis.com wrote:

 Hi guys,

 I'm facing a problem when loading service offerings on ACS Master branch.
 Is anyone aware of this? Is there any issue open?

 2014-06-18 15:54:52,495 DEBUG [c.c.a.ApiServlet] 
 (19418424@qtp-9894122-6:ctx-3a0f1094)
 ===START===  0:0:0:0:0:0:0:1 -- GET  command=listServ

 iceOfferingsresponse=jsonsessionkey=pzJwAgN95saj%2FfExWkezaytg7U4%3DlistAll=truepage=1pagesize=20issystem=false_=1403099692481
 2014-06-18 15:54:52,608 WARN  [c.c.a.d.ParamGenericValidationWorker]
 (19418424@qtp-9894122-6:ctx-3a0f1094 ctx-226b1105) Received unknown par
 ameters for command listServiceOfferings. Unknown parameters : listall
 2014-06-18 15:54:52,710 ERROR [c.c.a.ApiServer] 
 (19418424@qtp-9894122-6:ctx-3a0f1094
 ctx-226b1105) unhandled exception executing api command
 : [Ljava.lang.String;@fd06cb
 java.lang.NullPointerException
 at
 com.cloud.api.query.dao.ServiceOfferingJoinDaoImpl.newServiceOfferingResponse(ServiceOfferingJoinDaoImpl.java:62)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
 at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:606)
 at
 org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
 at
 org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
 at
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
 at
 com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34)
 at
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
 at
 org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
 at
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
 at
 org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
 at com.sun.proxy.$Proxy270.newServiceOfferingResponse(Unknown
 Source)
 at
 com.cloud.api.ApiDBUtils.newServiceOfferingResponse(ApiDBUtils.java:1794)
 at
 com.cloud.api.query.ViewResponseHelper.createServiceOfferingResponse(ViewResponseHelper.java:354)
 at
 com.cloud.api.query.QueryManagerImpl.searchForServiceOfferings(QueryManagerImpl.java:2415)
 at
 org.apache.cloudstack.api.command.user.offering.ListServiceOfferingsCmd.execute(ListServiceOfferingsCmd.java:106)
 at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:141)
 at com.cloud.api.ApiServer.queueCommand(ApiServer.java:689)
 at com.cloud.api.ApiServer.handleRequest(ApiServer.java:512)
 at
 com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:317)
 at com.cloud.api.ApiServlet$1.run(ApiServlet.java:118)
 at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
 at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
 at
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
 at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:115)
 at com.cloud.api.ApiServlet.doGet(ApiServlet.java:77)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
 at
 org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
 at
 org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
 at
 org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
 at
 org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
 at
 org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
 at
 org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
 at
 org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
 at
 org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
 at
 org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
 at org.mortbay.jetty.Server.handle(Server.java:326)
 at
 

Re: Managing individual ESXi instances

2014-06-18 Thread Mike Tutkowski
I know, for example, that I'd like to test out that managed storage works
with it.

I've added support for managed storage to XenServer, ESX/vCenter, and KVM
for CloudStack.

Another hypervisor type - to me personally - means I'd to verify managed
storage works with it.

Depending on how radical the changes for an ESX-only solution are, it may
or may not work out of the box for managed storage.


On Wed, Jun 18, 2014 at 9:30 AM, Ivan Efremov e...@yandex.ru wrote:

 Hi Alex,

 How do you think, what is the rough estimation of adding ESX API support
 to CloudStack?
 AFAIU the main point of integration of the new API is plugins/hypervisors.
 Are there any other major points that should be patched when adding a new
 hypervisor type?


 Thanks,
 Ivan

 18.06.2014, 18:24, Alex Huang alex.hu...@citrix.com:
  IIRC, the reason is because the vCenter API is more powerful than the
 ESX API.  At the time (before Apache), the features that requested needed
 vCenter. There's currently no proposal to use plain ESXi.  Would love to
 see one though.
 
  --Alex
   -Original Message-
   From: Ivan Efremov [mailto:e...@yandex.ru]
   Sent: Tuesday, June 17, 2014 8:26 PM
   To: dev@cloudstack.apache.org
   Subject: Managing individual ESXi instances
 
   Hi all,
 
   I've sent this mail to the users list but this one looks as the better
 destination.
 
   I'm new to the CloudStack platform and I'm wondering why the platform
   does need the vCenter API and can not use ESXi directly,
 
   Can anyone elaborate on this?
   Are there any proposals for adding ESXi integration to CloudStack?
 
   Thanks,
   Ivan




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*


Re: Managing individual ESXi instances

2014-06-18 Thread Mike Tutkowski
Or I'd like to know if it doesn't work (as is the case for Hyper-V until I
get time to add that kind of support for it).


On Wed, Jun 18, 2014 at 9:37 AM, Mike Tutkowski 
mike.tutkow...@solidfire.com wrote:

 I know, for example, that I'd like to test out that managed storage works
 with it.

 I've added support for managed storage to XenServer, ESX/vCenter, and KVM
 for CloudStack.

 Another hypervisor type - to me personally - means I'd to verify managed
 storage works with it.

 Depending on how radical the changes for an ESX-only solution are, it may
 or may not work out of the box for managed storage.


 On Wed, Jun 18, 2014 at 9:30 AM, Ivan Efremov e...@yandex.ru wrote:

 Hi Alex,

 How do you think, what is the rough estimation of adding ESX API support
 to CloudStack?
 AFAIU the main point of integration of the new API is
 plugins/hypervisors. Are there any other major points that should be
 patched when adding a new hypervisor type?


 Thanks,
 Ivan

 18.06.2014, 18:24, Alex Huang alex.hu...@citrix.com:
  IIRC, the reason is because the vCenter API is more powerful than the
 ESX API.  At the time (before Apache), the features that requested needed
 vCenter. There's currently no proposal to use plain ESXi.  Would love to
 see one though.
 
  --Alex
   -Original Message-
   From: Ivan Efremov [mailto:e...@yandex.ru]
   Sent: Tuesday, June 17, 2014 8:26 PM
   To: dev@cloudstack.apache.org
   Subject: Managing individual ESXi instances
 
   Hi all,
 
   I've sent this mail to the users list but this one looks as the
 better destination.
 
   I'm new to the CloudStack platform and I'm wondering why the platform
   does need the vCenter API and can not use ESXi directly,
 
   Can anyone elaborate on this?
   Are there any proposals for adding ESXi integration to CloudStack?
 
   Thanks,
   Ivan




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud
 http://solidfire.com/solution/overview/?video=play*™*




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*


Re: Managing individual ESXi instances

2014-06-18 Thread Ivan Efremov
Hi Alex,

How do you think, what is the rough estimation of adding ESX API support to 
CloudStack?
AFAIU the main point of integration of the new API is plugins/hypervisors. Are 
there any other major points that should be patched when adding a new 
hypervisor type?


Thanks,
Ivan

18.06.2014, 18:24, Alex Huang alex.hu...@citrix.com:
 IIRC, the reason is because the vCenter API is more powerful than the ESX 
 API.  At the time (before Apache), the features that requested needed 
 vCenter. There's currently no proposal to use plain ESXi.  Would love to see 
 one though.

 --Alex
  -Original Message-
  From: Ivan Efremov [mailto:e...@yandex.ru]
  Sent: Tuesday, June 17, 2014 8:26 PM
  To: dev@cloudstack.apache.org
  Subject: Managing individual ESXi instances

  Hi all,

  I've sent this mail to the users list but this one looks as the better 
 destination.

  I'm new to the CloudStack platform and I'm wondering why the platform
  does need the vCenter API and can not use ESXi directly,

  Can anyone elaborate on this?
  Are there any proposals for adding ESXi integration to CloudStack?

  Thanks,
  Ivan


Re: Managing individual ESXi instances

2014-06-18 Thread Tim Mackey
Mike,

I wouldn't expect things with the VMware Hypervisor (what they refer to
standalone ESXi) to work out of the box.  Since you can't cluster things,
I'd expect only raw iSCSI to work, but it's been years since I've worked
with raw ESXi.

-tim


On Wed, Jun 18, 2014 at 11:40 AM, Mike Tutkowski 
mike.tutkow...@solidfire.com wrote:

 Or I'd like to know if it doesn't work (as is the case for Hyper-V until I
 get time to add that kind of support for it).


 On Wed, Jun 18, 2014 at 9:37 AM, Mike Tutkowski 
 mike.tutkow...@solidfire.com wrote:

  I know, for example, that I'd like to test out that managed storage works
  with it.
 
  I've added support for managed storage to XenServer, ESX/vCenter, and KVM
  for CloudStack.
 
  Another hypervisor type - to me personally - means I'd to verify managed
  storage works with it.
 
  Depending on how radical the changes for an ESX-only solution are, it may
  or may not work out of the box for managed storage.
 
 
  On Wed, Jun 18, 2014 at 9:30 AM, Ivan Efremov e...@yandex.ru wrote:
 
  Hi Alex,
 
  How do you think, what is the rough estimation of adding ESX API support
  to CloudStack?
  AFAIU the main point of integration of the new API is
  plugins/hypervisors. Are there any other major points that should be
  patched when adding a new hypervisor type?
 
 
  Thanks,
  Ivan
 
  18.06.2014, 18:24, Alex Huang alex.hu...@citrix.com:
   IIRC, the reason is because the vCenter API is more powerful than the
  ESX API.  At the time (before Apache), the features that requested
 needed
  vCenter. There's currently no proposal to use plain ESXi.  Would love to
  see one though.
  
   --Alex
-Original Message-
From: Ivan Efremov [mailto:e...@yandex.ru]
Sent: Tuesday, June 17, 2014 8:26 PM
To: dev@cloudstack.apache.org
Subject: Managing individual ESXi instances
  
Hi all,
  
I've sent this mail to the users list but this one looks as the
  better destination.
  
I'm new to the CloudStack platform and I'm wondering why the
 platform
does need the vCenter API and can not use ESXi directly,
  
Can anyone elaborate on this?
Are there any proposals for adding ESXi integration to CloudStack?
  
Thanks,
Ivan
 
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the cloud
  http://solidfire.com/solution/overview/?video=play*™*
 



 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud
 http://solidfire.com/solution/overview/?video=play*™*



Re: Managing individual ESXi instances

2014-06-18 Thread Mike Tutkowski
Well, as long as the API to standalone ESX is similar to vCenter's API
(which much of it is, I think), it might not be a ton of work to get the
managed storage part to work, but it's hard to say.


On Wed, Jun 18, 2014 at 9:53 AM, Tim Mackey tmac...@gmail.com wrote:

 Mike,

 I wouldn't expect things with the VMware Hypervisor (what they refer to
 standalone ESXi) to work out of the box.  Since you can't cluster things,
 I'd expect only raw iSCSI to work, but it's been years since I've worked
 with raw ESXi.

 -tim


 On Wed, Jun 18, 2014 at 11:40 AM, Mike Tutkowski 
 mike.tutkow...@solidfire.com wrote:

  Or I'd like to know if it doesn't work (as is the case for Hyper-V until
 I
  get time to add that kind of support for it).
 
 
  On Wed, Jun 18, 2014 at 9:37 AM, Mike Tutkowski 
  mike.tutkow...@solidfire.com wrote:
 
   I know, for example, that I'd like to test out that managed storage
 works
   with it.
  
   I've added support for managed storage to XenServer, ESX/vCenter, and
 KVM
   for CloudStack.
  
   Another hypervisor type - to me personally - means I'd to verify
 managed
   storage works with it.
  
   Depending on how radical the changes for an ESX-only solution are, it
 may
   or may not work out of the box for managed storage.
  
  
   On Wed, Jun 18, 2014 at 9:30 AM, Ivan Efremov e...@yandex.ru wrote:
  
   Hi Alex,
  
   How do you think, what is the rough estimation of adding ESX API
 support
   to CloudStack?
   AFAIU the main point of integration of the new API is
   plugins/hypervisors. Are there any other major points that should be
   patched when adding a new hypervisor type?
  
  
   Thanks,
   Ivan
  
   18.06.2014, 18:24, Alex Huang alex.hu...@citrix.com:
IIRC, the reason is because the vCenter API is more powerful than
 the
   ESX API.  At the time (before Apache), the features that requested
  needed
   vCenter. There's currently no proposal to use plain ESXi.  Would love
 to
   see one though.
   
--Alex
 -Original Message-
 From: Ivan Efremov [mailto:e...@yandex.ru]
 Sent: Tuesday, June 17, 2014 8:26 PM
 To: dev@cloudstack.apache.org
 Subject: Managing individual ESXi instances
   
 Hi all,
   
 I've sent this mail to the users list but this one looks as the
   better destination.
   
 I'm new to the CloudStack platform and I'm wondering why the
  platform
 does need the vCenter API and can not use ESXi directly,
   
 Can anyone elaborate on this?
 Are there any proposals for adding ESXi integration to CloudStack?
   
 Thanks,
 Ivan
  
  
  
  
   --
   *Mike Tutkowski*
   *Senior CloudStack Developer, SolidFire Inc.*
   e: mike.tutkow...@solidfire.com
   o: 303.746.7302
   Advancing the way the world uses the cloud
   http://solidfire.com/solution/overview/?video=play*™*
  
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the cloud
  http://solidfire.com/solution/overview/?video=play*™*
 




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*


Re: ZoneWideStoragePoolAllocator#filter seems weird for me

2014-06-18 Thread Yoshikazu Nojima
Mike,

Thank you for your review.
This is a patch I would like to push.
I don't have anything to add regarding this issue.
I will push this patch in the next few hours.

Regards,
Noji




2014-06-18 9:15 GMT-06:00 Mike Tutkowski mike.tutkow...@solidfire.com:
 Sorry...I didn't see until later in my e-mail that you had submitted code.

 It looks good to me.

 Is this something you'd like checked in right away or are you planning to
 add to this patch?

 Thanks!


 On Wed, Jun 18, 2014 at 9:06 AM, Mike Tutkowski 
 mike.tutkow...@solidfire.com wrote:

 Yeah, storagePoolHasEnoughIops returns true in the traditional case (i.e.
 non-managed storage) so we won't skip a storage pool when IOPS are not
 really being taken into consideration.

 Feel free to make enhancements and I can review your patch.

 Thanks!


 On Wed, Jun 18, 2014 at 12:14 AM, Yoshikazu Nojima m...@ynojima.net
 wrote:

 Prachi, Mike,
 I appreciate your comments.

 I think it is a bug that there is a difference between filter logic of
 ClusterScopeStoragePoolAllocator and that of
 ZoneWideStoragePoolAllocator
 (ex. allocator skip iSCSI type storage pool or not when a volume is a
 RootDisk),
 I will unify by implementing it in AbstractStoragePoolAllocator#filter
 method.

 It is new information for me that managed storages only support zone
 level. Thank you for let me know.
 But when iopscapacity parameter is not set to a primary storage (i.e.
 unmanaged storage), storageMgr.storagePoolHasEnoughIops always returns
 true.
 I suppose calling storageMgr.storagePoolHasEnoughIops from
 AbstractStoragePoolAllocator will not cause a problem, and it will
 simplify the code.

 I created a patch to explain my thought. Could you review it?
 https://reviews.apache.org/r/22717/

 Regards,
 Noji


 2014-06-17 19:19 GMT-06:00 Mike Tutkowski mike.tutkow...@solidfire.com:
  I can comment on the IOPS part.
 
  The IOPS are currently only relevant when using managed storage (which
 is
  currently only applicable at the zone level). That being the case, no
  cluster (or local) storage takes advantage of counting IOPS that have
 been
  handed out.
 
  Of course this logic might be expanded in the future, but that's how it
  works today.
 
 
  On Tue, Jun 17, 2014 at 2:47 PM, Prachi Damle prachi.da...@citrix.com
  wrote:
 
  Why ZoneWideStoragePoolAllocator implements filter method (and
 doesn't
  call that of base class) rather than just using that of base class?
  ZoneWideStoragePoolAllocator#filter method seems doesn't care avoid
  parameter, doesn't skip iSCSI type storage pool even if a volume is a
  RootDisk.
 
  The first question seems like a bug to me.
 
  I am not sure about the IOPS
 
  Prachi
 
  -Original Message-
  From: ynoj...@ynojima.net [mailto:ynoj...@ynojima.net] On Behalf Of
  Yoshikazu Nojima
  Sent: Tuesday, June 17, 2014 1:07 PM
  To: dev@cloudstack.apache.org
  Subject: ZoneWideStoragePoolAllocator#filter seems weird for me
 
  Hi,
 
  ZoneWideStoragePoolAllocator#filter seems weird for me.
 
  ZoneWideStoragePoolAllocator and ClusterScopeStoragePoolAllocator are
  allocator classes to select storage pool.
  They extends AbstractStoragePoolAllocator class, which provides
 filter
  method to exclude unavailable storage pools.
 
  Why ZoneWideStoragePoolAllocator implements filter method (and
 doesn't
  call that of base class) rather than just using that of base class?
 
  ZoneWideStoragePoolAllocator#filter method seems doesn't care avoid
  parameter, doesn't skip iSCSI type storage pool even if a volume is a
  RootDisk.
  (These functions are implemented in
  AbstractStoragePoolAllocator#filter method, which used by
  ClusterScopeStoragePoolAllocator.)
  On the other hand, AbstractStoragePoolAllocator#filter doesn't call
  storageMgr.storagePoolHasEnoughIops, so a cluster wide primary storage
  would be allocated more volumes than its designated IOPS capacity.
 
  Is there any difference between a zone wide primary storage and a
 cluster
  wide primary storage except its scope?
  If it is a bug, I'll fix it.
 
  Regards,
  Noji
 
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the cloud
  http://solidfire.com/solution/overview/?video=play*™*




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud
 http://solidfire.com/solution/overview/?video=play*™*




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the cloud
 http://solidfire.com/solution/overview/?video=play*™*


Re: ZoneWideStoragePoolAllocator#filter seems weird for me

2014-06-18 Thread Mike Tutkowski
Sounds good - thanks!


On Wed, Jun 18, 2014 at 10:46 AM, Yoshikazu Nojima m...@ynojima.net wrote:

 Mike,

 Thank you for your review.
 This is a patch I would like to push.
 I don't have anything to add regarding this issue.
 I will push this patch in the next few hours.

 Regards,
 Noji




 2014-06-18 9:15 GMT-06:00 Mike Tutkowski mike.tutkow...@solidfire.com:
  Sorry...I didn't see until later in my e-mail that you had submitted
 code.
 
  It looks good to me.
 
  Is this something you'd like checked in right away or are you planning to
  add to this patch?
 
  Thanks!
 
 
  On Wed, Jun 18, 2014 at 9:06 AM, Mike Tutkowski 
  mike.tutkow...@solidfire.com wrote:
 
  Yeah, storagePoolHasEnoughIops returns true in the traditional case
 (i.e.
  non-managed storage) so we won't skip a storage pool when IOPS are not
  really being taken into consideration.
 
  Feel free to make enhancements and I can review your patch.
 
  Thanks!
 
 
  On Wed, Jun 18, 2014 at 12:14 AM, Yoshikazu Nojima m...@ynojima.net
  wrote:
 
  Prachi, Mike,
  I appreciate your comments.
 
  I think it is a bug that there is a difference between filter logic of
  ClusterScopeStoragePoolAllocator and that of
  ZoneWideStoragePoolAllocator
  (ex. allocator skip iSCSI type storage pool or not when a volume is a
  RootDisk),
  I will unify by implementing it in AbstractStoragePoolAllocator#filter
  method.
 
  It is new information for me that managed storages only support zone
  level. Thank you for let me know.
  But when iopscapacity parameter is not set to a primary storage (i.e.
  unmanaged storage), storageMgr.storagePoolHasEnoughIops always returns
  true.
  I suppose calling storageMgr.storagePoolHasEnoughIops from
  AbstractStoragePoolAllocator will not cause a problem, and it will
  simplify the code.
 
  I created a patch to explain my thought. Could you review it?
  https://reviews.apache.org/r/22717/
 
  Regards,
  Noji
 
 
  2014-06-17 19:19 GMT-06:00 Mike Tutkowski 
 mike.tutkow...@solidfire.com:
   I can comment on the IOPS part.
  
   The IOPS are currently only relevant when using managed storage
 (which
  is
   currently only applicable at the zone level). That being the case, no
   cluster (or local) storage takes advantage of counting IOPS that have
  been
   handed out.
  
   Of course this logic might be expanded in the future, but that's how
 it
   works today.
  
  
   On Tue, Jun 17, 2014 at 2:47 PM, Prachi Damle 
 prachi.da...@citrix.com
   wrote:
  
   Why ZoneWideStoragePoolAllocator implements filter method (and
  doesn't
   call that of base class) rather than just using that of base class?
   ZoneWideStoragePoolAllocator#filter method seems doesn't care
 avoid
   parameter, doesn't skip iSCSI type storage pool even if a volume is
 a
   RootDisk.
  
   The first question seems like a bug to me.
  
   I am not sure about the IOPS
  
   Prachi
  
   -Original Message-
   From: ynoj...@ynojima.net [mailto:ynoj...@ynojima.net] On Behalf Of
   Yoshikazu Nojima
   Sent: Tuesday, June 17, 2014 1:07 PM
   To: dev@cloudstack.apache.org
   Subject: ZoneWideStoragePoolAllocator#filter seems weird for me
  
   Hi,
  
   ZoneWideStoragePoolAllocator#filter seems weird for me.
  
   ZoneWideStoragePoolAllocator and ClusterScopeStoragePoolAllocator
 are
   allocator classes to select storage pool.
   They extends AbstractStoragePoolAllocator class, which provides
  filter
   method to exclude unavailable storage pools.
  
   Why ZoneWideStoragePoolAllocator implements filter method (and
  doesn't
   call that of base class) rather than just using that of base class?
  
   ZoneWideStoragePoolAllocator#filter method seems doesn't care
 avoid
   parameter, doesn't skip iSCSI type storage pool even if a volume is
 a
   RootDisk.
   (These functions are implemented in
   AbstractStoragePoolAllocator#filter method, which used by
   ClusterScopeStoragePoolAllocator.)
   On the other hand, AbstractStoragePoolAllocator#filter doesn't call
   storageMgr.storagePoolHasEnoughIops, so a cluster wide primary
 storage
   would be allocated more volumes than its designated IOPS capacity.
  
   Is there any difference between a zone wide primary storage and a
  cluster
   wide primary storage except its scope?
   If it is a bug, I'll fix it.
  
   Regards,
   Noji
  
  
  
  
   --
   *Mike Tutkowski*
   *Senior CloudStack Developer, SolidFire Inc.*
   e: mike.tutkow...@solidfire.com
   o: 303.746.7302
   Advancing the way the world uses the cloud
   http://solidfire.com/solution/overview/?video=play*™*
 
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the cloud
  http://solidfire.com/solution/overview/?video=play*™*
 
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the cloud
  

Build failed in Jenkins: build-master #984

2014-06-18 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master/984/changes

Changes:

[mail] CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic

--
[...truncated 1540 lines...]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-usage ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 8 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-usage ---
[INFO] Compiling 4 source files to 
http://jenkins.buildacloud.org/job/build-master/ws/usage/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-usage ---
[INFO] Surefire report directory: 
http://jenkins.buildacloud.org/job/build-master/ws/usage/target/surefire-reports

---
 T E S T S
---
Running com.cloud.usage.UsageSanityCheckerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.554 sec

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Engine Orchestration Component 
4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-engine-orchestration ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-engine-orchestration ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-engine-orchestration ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-engine-orchestration ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-engine-orchestration ---
[INFO] Compiling 68 source files to 
http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/target/classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-engine-orchestration ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/test/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-engine-orchestration ---
[INFO] Compiling 5 source files to 
http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-engine-orchestration ---
[INFO] Tests are skipped.
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Services 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloudstack-services 
---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/build-master/ws/services/target (includes 
= [**/*], excludes = [])
[INFO] Deleting http://jenkins.buildacloud.org/job/build-master/ws/services 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloudstack-services ---
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Secondary Storage 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloudstack-service-secondary-storage ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/build-master/ws/services/secondary-storage/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/build-master/ws/services/secondary-storage 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloudstack-service-secondary-storage ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 

RE: Managing individual ESXi instances

2014-06-18 Thread Alex Huang
Hi Ivan,

To introduce a new hypervisor, it's a matter of
- Adding a new Discoverer implementation to tell CloudStack which Resource best 
works with the new Hypervisor.
- Adding a new Resource implementation that deals with all of the hypervisor 
commands sent to it.  This is the big part due to the large set of commands we 
send to it.

For someone who understands CloudStack code and the hypervisor well, I think a 
prototype can be done in about two months or so.  For ESX, you have to figure 
out a how to map functions that CS supports but is not with ESX.  For example, 
I think migration and live storage migration.  You can decide not to support 
them in the prototype and just support simple vm/volume/network life cycle for 
now.

--Alex

 -Original Message-
 From: Ivan Efremov [mailto:e...@yandex.ru]
 Sent: Wednesday, June 18, 2014 8:31 AM
 To: dev@cloudstack.apache.org
 Subject: Re: Managing individual ESXi instances
 
 Hi Alex,
 
 How do you think, what is the rough estimation of adding ESX API support to
 CloudStack?
 AFAIU the main point of integration of the new API is plugins/hypervisors.
 Are there any other major points that should be patched when adding a new
 hypervisor type?
 
 
 Thanks,
 Ivan
 
 18.06.2014, 18:24, Alex Huang alex.hu...@citrix.com:
  IIRC, the reason is because the vCenter API is more powerful than the ESX
 API.  At the time (before Apache), the features that requested needed
 vCenter. There's currently no proposal to use plain ESXi.  Would love to see
 one though.
 
  --Alex
   -Original Message-
   From: Ivan Efremov [mailto:e...@yandex.ru]
   Sent: Tuesday, June 17, 2014 8:26 PM
   To: dev@cloudstack.apache.org
   Subject: Managing individual ESXi instances
 
   Hi all,
 
   I've sent this mail to the users list but this one looks as the better
 destination.
 
   I'm new to the CloudStack platform and I'm wondering why the platform
   does need the vCenter API and can not use ESXi directly,
 
   Can anyone elaborate on this?
   Are there any proposals for adding ESXi integration to CloudStack?
 
   Thanks,
   Ivan


[ACS 4.4] cherry-pick request for CLOUDSTACK-6935

2014-06-18 Thread Yoshikazu Nojima
Daan,

Could you cherry-pick the commit
cd414a0f56798ae801fc464be127e37daabef809 into 4.4?
This is a fix to the bug CLOUDSTACK-6935.

Bug description:
Some storage pool filtering logic like hypervisor type check, storage
type check for root volume and avoid list check is not enabled in
ZoneWideStoragePoolAllocator.

Regards,
Noji


Build failed in Jenkins: cloudstack-4.4-forward-build #261

2014-06-18 Thread jenkins
See 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/261/changes

Changes:

[mail] CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic

--
[...truncated 1493 lines...]
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ xapi ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/deps/XenServerJava/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ xapi ---
[INFO] Compiling 51 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/deps/XenServerJava/target/classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
xapi ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/deps/XenServerJava/test/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ xapi 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ xapi ---
[INFO] Surefire report directory: 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/deps/XenServerJava/target/surefire-reports

---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Engine Orchestration Component 
4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-engine-orchestration ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/engine/orchestration
 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-engine-orchestration ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-engine-orchestration ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-engine-orchestration ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-engine-orchestration ---
[INFO] Compiling 68 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/engine/orchestration/target/classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-engine-orchestration ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/engine/orchestration/test/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-engine-orchestration ---
[INFO] Compiling 5 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/engine/orchestration/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-engine-orchestration ---
[INFO] Tests are skipped.
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Services 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloudstack-services 
---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/services 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloudstack-services ---
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Secondary Storage 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloudstack-service-secondary-storage ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/ws/services/secondary-storage
 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- 

Re: [POLL] Who uses awsapi with CloudStack in production?

2014-06-18 Thread Carlos Reátegui
Hi Rohit,

The awsapi was one of the reasons we chose to use ACS.  We have developed some 
internal tools and apps to manage our deployments on AWS that we want to re-use 
on ACS.  We have not been able to use it yet because it was broken in 4.1.1.  
We tried to upgrade to 4.2 and were unsuccessful and are now waiting for 4.4 to 
finally upgrade and hopefully be able to use the awsapi.

We use ACS internally for development and testing of our applications that we 
push to AWS.

thanks,
Carlos


On Jun 18, 2014, at 12:11 AM, Rohit Yadav bhais...@apache.org wrote:

 Hi,
 
 Who uses awsapi or any other EC2 compatible interface such as ec2stack
 with CloudStack (or CloudStack distros such as Citrix CloudPlatform) in
 production? And, if marketing and publicity are/were big motivation(s)?
 
 In case you don't want to discuss on this thread, please take this
 anonymous poll:
 http://www.polljunkie.com/poll/fbyfdc/who-uses-awsapi-with-cloudstack-in-prouduction
 
 # Some stats
 
 I've been watching Collab14 videos and found references where many speakers
 reference overall CloudStack codebase to be about 1.5M (million) lines of
 Java code which is not exactly true. Let me share some findings;
 
 - As of today, CloudStack master is about 1.7M lines of Java code [1]
 - CloudStack awsapi artifact is 1.04M lines of Java code [2]
 - Code excluding awsapi, tests and license/comment is about 590k lines of
 Java code [3]
 - The core excluding plugins, api and the above is about 300k lines of Java
 code [4]
 
 Why should  I care:
 - some useful/fun stats to keep in mind
 - it's not a giant mammoth that cannot be fixed or developed upon
 - encouraging for new developers that if they try they can understand and
 fix it
 
 FYI, this started on twitter yesterday:
 https://twitter.com/_bhaisaab/status/479007075414974465
 
 [1] cd cloudstack-repo  find . | grep java$ | xargs cat | wc -l
 [2] cd cloudstack-repo  find awsapi | grep java$ | xargs cat | wc -l
 [3] cd cloudstack-repo  find . | grep -v awsapi | grep -v [tT]est | grep
 java$ | xargs cat | grep -v '^//' | wc -l
 [4] cd cloudstack-repo  find . | grep -v awsapi | grep -v [Tt]est | grep
 -v plugins | grep -v api | grep java$ | xargs cat | grep -v '^//' | wc -l
 
 Regards.



Build failed in Jenkins: build-master #985

2014-06-18 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master/985/changes

Changes:

[brian.federle] List view: Pass ID to action pre-filters

--
[...truncated 1540 lines...]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-usage ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 8 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-usage ---
[INFO] Compiling 4 source files to 
http://jenkins.buildacloud.org/job/build-master/ws/usage/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-usage ---
[INFO] Surefire report directory: 
http://jenkins.buildacloud.org/job/build-master/ws/usage/target/surefire-reports

---
 T E S T S
---
Running com.cloud.usage.UsageSanityCheckerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.545 sec

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Engine Orchestration Component 
4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-engine-orchestration ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-engine-orchestration ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-engine-orchestration ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-engine-orchestration ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-engine-orchestration ---
[INFO] Compiling 68 source files to 
http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/target/classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-engine-orchestration ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/test/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-engine-orchestration ---
[INFO] Compiling 5 source files to 
http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-engine-orchestration ---
[INFO] Tests are skipped.
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Services 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloudstack-services 
---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/build-master/ws/services/target (includes 
= [**/*], excludes = [])
[INFO] Deleting http://jenkins.buildacloud.org/job/build-master/ws/services 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloudstack-services ---
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Secondary Storage 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloudstack-service-secondary-storage ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/build-master/ws/services/secondary-storage/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/build-master/ws/services/secondary-storage 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloudstack-service-secondary-storage ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 

Re: Build failed in Jenkins: build-master #985

2014-06-18 Thread Daan Hoogland
please revert and resubmit in 4.4-forward don't care about how you fix
master(I didn't write that)

On Wed, Jun 18, 2014 at 9:02 PM, Yoshikazu Nojima m...@ynojima.net wrote:
 Sorry for this mess. I'll fix.

 2014-06-18 12:58 GMT-06:00  jenk...@cloudstack.org:
 See http://jenkins.buildacloud.org/job/build-master/985/changes

 Changes:

 [brian.federle] List view: Pass ID to action pre-filters

 --
 [...truncated 1540 lines...]
 [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) 
 @ cloud-usage ---
 [debug] execute contextualize
 [INFO] Using 'UTF-8' encoding to copy filtered resources.
 [INFO] Copying 8 resources
 [INFO] Copying 3 resources
 [INFO]
 [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
 cloud-usage ---
 [INFO] Compiling 4 source files to 
 http://jenkins.buildacloud.org/job/build-master/ws/usage/target/test-classes
 [INFO]
 [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-usage ---
 [INFO] Surefire report directory: 
 http://jenkins.buildacloud.org/job/build-master/ws/usage/target/surefire-reports

 ---
  T E S T S
 ---
 Running com.cloud.usage.UsageSanityCheckerTest
 Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.545 sec

 Results :

 Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

 [INFO]
 [INFO] 
 
 [INFO] Building Apache CloudStack Cloud Engine Orchestration Component 
 4.5.0-SNAPSHOT
 [INFO] 
 
 [INFO]
 [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
 cloud-engine-orchestration ---
 [INFO] Deleting 
 http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/target
  (includes = [**/*], excludes = [])
 [INFO] Deleting 
 http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration 
 (includes = [target, dist], excludes = [])
 [INFO]
 [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
 cloud-engine-orchestration ---
 [INFO] Starting audit...
 Audit done.

 [INFO]
 [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
 cloud-engine-orchestration ---
 [INFO]
 [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
 cloud-engine-orchestration ---
 [debug] execute contextualize
 [INFO] Using 'UTF-8' encoding to copy filtered resources.
 [INFO] Copying 1 resource
 [INFO] Copying 3 resources
 [INFO]
 [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
 cloud-engine-orchestration ---
 [INFO] Compiling 68 source files to 
 http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/target/classes
 [INFO]
 [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) 
 @ cloud-engine-orchestration ---
 [debug] execute contextualize
 [INFO] Using 'UTF-8' encoding to copy filtered resources.
 [INFO] skip non existing resourceDirectory 
 http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/test/resources
 [INFO] Copying 3 resources
 [INFO]
 [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
 cloud-engine-orchestration ---
 [INFO] Compiling 5 source files to 
 http://jenkins.buildacloud.org/job/build-master/ws/engine/orchestration/target/test-classes
 [INFO]
 [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
 cloud-engine-orchestration ---
 [INFO] Tests are skipped.
 [INFO]
 [INFO] 
 
 [INFO] Building Apache CloudStack Cloud Services 4.5.0-SNAPSHOT
 [INFO] 
 
 [INFO]
 [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
 cloudstack-services ---
 [INFO] Deleting 
 http://jenkins.buildacloud.org/job/build-master/ws/services/target 
 (includes = [**/*], excludes = [])
 [INFO] Deleting 
 http://jenkins.buildacloud.org/job/build-master/ws/services (includes = 
 [target, dist], excludes = [])
 [INFO]
 [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
 cloudstack-services ---
 [INFO]
 [INFO] 
 
 [INFO] Building Apache CloudStack Secondary Storage 4.5.0-SNAPSHOT
 [INFO] 
 
 [INFO]
 [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
 cloudstack-service-secondary-storage ---
 [INFO] Deleting 
 http://jenkins.buildacloud.org/job/build-master/ws/services/secondary-storage/target
  (includes = [**/*], excludes = [])
 [INFO] Deleting 
 http://jenkins.buildacloud.org/job/build-master/ws/services/secondary-storage
  (includes = [target, dist], excludes = [])
 [INFO]
 [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
 

Jenkins build is back to normal : build-master #986

2014-06-18 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master/986/changes



failed build on 4.3

2014-06-18 Thread sebgoa
Anyone seeing a build error like this:

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-remote-resources-plugin:1.3:process (default) on 
project cloud-client-ui: Error resolving project artifact: Could not transfer 
artifact net.juniper.contrail:juniper-contrail-api:pom:1.0-SNAPSHOT from/to 
apache.snapshots (http://repository.apache.org/snapshots): Failed to transfer 
file: 
http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contrail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom.
 Return code is: 503, ReasonPhrase:Service Temporarily Unavailable. for project 
net.juniper.contrail:juniper-contrail-api:jar:1.0-SNAPSHOT - [Help 1]
[ERROR] 






Re: failed build on 4.3

2014-06-18 Thread David Nalley
Look at what the error actually says.

It's getting a 503 from repository.a.o

--David


On Wed, Jun 18, 2014 at 3:21 PM, sebgoa run...@gmail.com wrote:
 Anyone seeing a build error like this:

 [ERROR] Failed to execute goal 
 org.apache.maven.plugins:maven-remote-resources-plugin:1.3:process (default) 
 on project cloud-client-ui: Error resolving project artifact: Could not 
 transfer artifact net.juniper.contrail:juniper-contrail-api:pom:1.0-SNAPSHOT 
 from/to apache.snapshots (http://repository.apache.org/snapshots): Failed to 
 transfer file: 
 http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contrail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom.
  Return code is: 503, ReasonPhrase:Service Temporarily Unavailable. for 
 project net.juniper.contrail:juniper-contrail-api:jar:1.0-SNAPSHOT - [Help 1]
 [ERROR]






Jenkins build is back to normal : cloudstack-4.4-forward-build #264

2014-06-18 Thread jenkins
See 
http://jenkins.buildacloud.org/job/cloudstack-4.4-forward-build/264/changes



Re: failed build on 4.3

2014-06-18 Thread Amogh Vasekar
I faced it for 4.4 on Monday. There was a thread running yesterday on this
too. Apparently an intermittent issue.

Thanks,
Amogh

On 6/18/14 12:45 PM, David Nalley da...@gnsa.us wrote:

Look at what the error actually says.

It's getting a 503 from repository.a.o

--David


On Wed, Jun 18, 2014 at 3:21 PM, sebgoa run...@gmail.com wrote:
 Anyone seeing a build error like this:

 [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.3:process
(default) on project cloud-client-ui: Error resolving project artifact:
Could not transfer artifact
net.juniper.contrail:juniper-contrail-api:pom:1.0-SNAPSHOT from/to
apache.snapshots (http://repository.apache.org/snapshots): Failed to
transfer file: 
http://repository.apache.org/snapshots/net/juniper/contrail/juniper-contr
ail-api/1.0-SNAPSHOT/juniper-contrail-api-1.0-SNAPSHOT.pom. Return code
is: 503, ReasonPhrase:Service Temporarily Unavailable. for project
net.juniper.contrail:juniper-contrail-api:jar:1.0-SNAPSHOT - [Help 1]
 [ERROR]







Re: [ACS 4.4] cherry-pick request for CLOUDSTACK-6935

2014-06-18 Thread Yoshikazu Nojima
Daan,

Could you cherry-pick 45f0c7367680f4bfbcee470139b708d69322be78 instead
of cd414a0f56798ae801fc464be127e37daabef809?

Regards,
Noji

2014-06-18 11:59 GMT-06:00 Yoshikazu Nojima m...@ynojima.net:
 Daan,

 Could you cherry-pick the commit
 cd414a0f56798ae801fc464be127e37daabef809 into 4.4?
 This is a fix to the bug CLOUDSTACK-6935.

 Bug description:
 Some storage pool filtering logic like hypervisor type check, storage
 type check for root volume and avoid list check is not enabled in
 ZoneWideStoragePoolAllocator.

 Regards,
 Noji


Re: Can we delete a template after a VM is instantiated from it?

2014-06-18 Thread Min Chen
This seems a bug to me, start vm should not rely on the template not
deleted. Please file a bug for that.

Thanks
-min

On 6/16/14 10:33 AM, Rafael Weingartner rafaelweingart...@gmail.com
wrote:

This way, it seems that you have a bug in CS 4.3.0 when starting a machine
that was created from a template that has been deleted.


There will happen a null pointer exception in:
³858 -if (volTemplateId != null  volTemplateId.longValue() !=
template.getId())²

The object, ³template² is going to be null, because in:

³811 -  VirtualMachineTemplate template =
_entityMgr.findById(VirtualMachineTemplate.class, vm.getTemplateId());²

The findById, will add a where clause, looking for template that have the
column removed that is null, therefore It will return a null object.



On Mon, Jun 16, 2014 at 4:41 AM, Nux! n...@li.nux.ro wrote:

 Hi,

 You can remove it from the UI, but not directly from the disk as it is
 used (in many cases) as a backing file for the VMs spawned from it.

 HTH
 Lucian

 --
 Sent from the Delta quadrant using Borg technology!

 Nux!
 www.nux.ro

 - Original Message -
 From: Sanjeev Neelarapu sanjeev.neelar...@citrix.com
 To: dev@cloudstack.apache.org
 Sent: Monday, 16 June, 2014 5:18:04 AM
 Subject: RE: Can we delete a template after a VM is instantiated from
it?

 We can delete template without any issues.

 -Sanjeev

 -Original Message-
 From: Rafael Weingartner [mailto:rafaelweingart...@gmail.com]
 Sent: Sunday, June 15, 2014 8:48 PM
 To: dev@cloudstack.apache.org
 Subject: Can we delete a template after a VM is instantiated from it?

  Hi,

 I was wondering if we can delete a template that has already been used
to
 instantiate some VMs.

 Would that cause any trouble?

 --
 Rafael Weingärtner




-- 
Rafael Weingärtner



Re: Can we delete a template after a VM is instantiated from it?

2014-06-18 Thread Rafael Weingartner
Sure, I can do that.
I also think that it is a bug.
sorry if it seems a dumb question, but, how can I file a bug report?


On Wed, Jun 18, 2014 at 8:24 PM, Min Chen min.c...@citrix.com wrote:

 This seems a bug to me, start vm should not rely on the template not
 deleted. Please file a bug for that.

 Thanks
 -min

 On 6/16/14 10:33 AM, Rafael Weingartner rafaelweingart...@gmail.com
 wrote:

 This way, it seems that you have a bug in CS 4.3.0 when starting a machine
 that was created from a template that has been deleted.
 
 
 There will happen a null pointer exception in:
 ³858 -if (volTemplateId != null  volTemplateId.longValue() !=
 template.getId())²
 
 The object, ³template² is going to be null, because in:
 
 ³811 -  VirtualMachineTemplate template =
 _entityMgr.findById(VirtualMachineTemplate.class, vm.getTemplateId());²
 
 The findById, will add a where clause, looking for template that have the
 column removed that is null, therefore It will return a null object.
 
 
 
 On Mon, Jun 16, 2014 at 4:41 AM, Nux! n...@li.nux.ro wrote:
 
  Hi,
 
  You can remove it from the UI, but not directly from the disk as it is
  used (in many cases) as a backing file for the VMs spawned from it.
 
  HTH
  Lucian
 
  --
  Sent from the Delta quadrant using Borg technology!
 
  Nux!
  www.nux.ro
 
  - Original Message -
  From: Sanjeev Neelarapu sanjeev.neelar...@citrix.com
  To: dev@cloudstack.apache.org
  Sent: Monday, 16 June, 2014 5:18:04 AM
  Subject: RE: Can we delete a template after a VM is instantiated from
 it?
 
  We can delete template without any issues.
 
  -Sanjeev
 
  -Original Message-
  From: Rafael Weingartner [mailto:rafaelweingart...@gmail.com]
  Sent: Sunday, June 15, 2014 8:48 PM
  To: dev@cloudstack.apache.org
  Subject: Can we delete a template after a VM is instantiated from it?
 
   Hi,
 
  I was wondering if we can delete a template that has already been used
 to
  instantiate some VMs.
 
  Would that cause any trouble?
 
  --
  Rafael Weingärtner
 
 
 
 
 --
 Rafael Weingärtner




-- 
Rafael Weingärtner


Re: Can we delete a template after a VM is instantiated from it?

2014-06-18 Thread Mike Tutkowski
Google CloudStack JIRA.

Create an account and you should be able to log a bug.

On Wednesday, June 18, 2014, Rafael Weingartner rafaelweingart...@gmail.com
wrote:

 Sure, I can do that.
 I also think that it is a bug.
 sorry if it seems a dumb question, but, how can I file a bug report?


 On Wed, Jun 18, 2014 at 8:24 PM, Min Chen min.c...@citrix.com
 javascript:; wrote:

  This seems a bug to me, start vm should not rely on the template not
  deleted. Please file a bug for that.
 
  Thanks
  -min
 
  On 6/16/14 10:33 AM, Rafael Weingartner rafaelweingart...@gmail.com
 javascript:;
  wrote:
 
  This way, it seems that you have a bug in CS 4.3.0 when starting a
 machine
  that was created from a template that has been deleted.
  
  
  There will happen a null pointer exception in:
  ³858 -if (volTemplateId != null  volTemplateId.longValue() !=
  template.getId())²
  
  The object, ³template² is going to be null, because in:
  
  ³811 -  VirtualMachineTemplate template =
  _entityMgr.findById(VirtualMachineTemplate.class, vm.getTemplateId());²
  
  The findById, will add a where clause, looking for template that have
 the
  column removed that is null, therefore It will return a null object.
  
  
  
  On Mon, Jun 16, 2014 at 4:41 AM, Nux! n...@li.nux.ro javascript:;
 wrote:
  
   Hi,
  
   You can remove it from the UI, but not directly from the disk as it is
   used (in many cases) as a backing file for the VMs spawned from it.
  
   HTH
   Lucian
  
   --
   Sent from the Delta quadrant using Borg technology!
  
   Nux!
   www.nux.ro
  
   - Original Message -
   From: Sanjeev Neelarapu sanjeev.neelar...@citrix.com
 javascript:;
   To: dev@cloudstack.apache.org javascript:;
   Sent: Monday, 16 June, 2014 5:18:04 AM
   Subject: RE: Can we delete a template after a VM is instantiated from
  it?
  
   We can delete template without any issues.
  
   -Sanjeev
  
   -Original Message-
   From: Rafael Weingartner [mailto:rafaelweingart...@gmail.com
 javascript:;]
   Sent: Sunday, June 15, 2014 8:48 PM
   To: dev@cloudstack.apache.org javascript:;
   Subject: Can we delete a template after a VM is instantiated from it?
  
Hi,
  
   I was wondering if we can delete a template that has already been used
  to
   instantiate some VMs.
  
   Would that cause any trouble?
  
   --
   Rafael Weingärtner
  
  
  
  
  --
  Rafael Weingärtner
 
 


 --
 Rafael Weingärtner



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*


Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

2014-06-18 Thread Alex Ough


 On June 17, 2014, 5:06 p.m., Alena Prokharchyk wrote:
  One more comment regarding spring-server-core-managers-context.xml. As your 
  code comes as a CS plugin, all the managers of your plugin should be 
  defined in your plugin's *-context.xml file, not 
  spring-server-core-managers-context.xml. These are the classes of your 
  plugin:
  
  bean id=fullSyncer 
  class=org.apache.cloudstack.mom.multiregion.FullSyncer /
  bean id=fullScanner 
  class=org.apache.cloudstack.mom.multiregion.service.FullScanner /
  bean id=autoGenerator 
  class=org.apache.cloudstack.mom.multiregion.simulator.SimulatorAutoGenerator
   /
  bean id=domainSubscriber 
  class=org.apache.cloudstack.mom.multiregion.subscriber.DomainSubscriber /
  bean id=accountSubscriber 
  class=org.apache.cloudstack.mom.multiregion.subscriber.AccountSubscriber 
  /
  bean id=userSubscriber 
  class=org.apache.cloudstack.mom.multiregion.subscriber.UserSubscriber /
  bean id=injectedCollection 
  class=org.apache.cloudstack.mom.multiregion.InjectedCollection / 
  bean id=syncQueryManagerImpl 
  class=org.apache.cloudstack.mom.multiregion.api.response.SyncQueryManagerImpl/
  bean id=apiSyncResponseHelper 
  class=org.apache.cloudstack.mom.multiregion.api.response.ApiSyncResponseHelper/
  bean id=syncAccountJoinDaoImpl 
  class=org.apache.cloudstack.mom.multiregion.api.dao.SyncAccountJoinDaoImpl
   /
  bean id=syncUserAccountJoinDaoImpl 
  class=org.apache.cloudstack.mom.multiregion.api.dao.SyncUserAccountJoinDaoImpl
   /
  
  
  
  If you want to look at the example, look at any CS plugin, for example 
  cloud-plugin-hypervisor-vmware (refer to spring-vmware-core-context.xml 
  file to see how the managers are defined there)

I moved to 
plugins/event-bus/multiregion/resources/META-INF/cloudstack/spring-plugin-multiregion-system-context.xml
 and have this error during starting the mgmt server.

org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'eventNotificationBus': Injection of autowired dependencies failed; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Could not autowire field: protected 
org.apache.cloudstack.mom.multiregion.subscriber.DomainSubscriber 
org.apache.cloudstack.mom.multiregion.MultiRegionEventBus.domainSubscriber; 
nested exception is 
org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying 
bean of type 
[org.apache.cloudstack.mom.multiregion.subscriber.DomainSubscriber] found for 
dependency: expected at least 1 bean which qualifies as autowire candidate for 
this dependency. Dependency annotations: {@javax.inject.Inject()}

Can you give me how to resolve this?


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20099/#review45955
---


On June 15, 2014, 9:40 p.m., Alex Ough wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20099/
 ---
 
 (Updated June 15, 2014, 9:40 p.m.)
 
 
 Review request for cloudstack.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 This is the review request for the core changes related with #17790 that has 
 only the new plugin codes.
 
 
 Diffs
 -
 
   api/src/com/cloud/event/EventTypes.java 39ef710 
   api/src/com/cloud/user/AccountService.java 7e37b38 
   api/src/com/cloud/user/DomainService.java 4c1f93d 
   api/src/org/apache/cloudstack/api/ApiConstants.java fdb4558 
   api/src/org/apache/cloudstack/api/BaseCmd.java f6f21ae 
   
 api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
 50d67d9 
   
 api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
 5754ec5 
   
 api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
  3e5e1d3 
   
 api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
 f30c985 
   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
 3c185e4 
   
 api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
 a7ce74a 
   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
 312c9ee 
   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
 a6d2b0b 
   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
 409a84d 
   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 
 f6743ba 
   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 
 b08cbbb 
   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 
 51e218d 
   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 
 08ba521 
   

Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java

2014-06-18 Thread Koushik Das

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22510/#review46187
---

Ship it!


master - 5cbb182c6d280a2d286d6b2443b235bcf87f2f17

- Koushik Das


On June 18, 2014, 9:41 a.m., Damodar Reddy Talakanti wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22510/
 ---
 
 (Updated June 18, 2014, 9:41 a.m.)
 
 
 Review request for cloudstack, edison su, Koushik Das, and Min Chen.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636
 
 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Due to File.separator on windows machine the template creation from snapshot 
 is failing as it has mis-matched path separator which is windows path 
 separator(\). Fixed the same by adding getPathSeparator() method to 
 DataStoreTO.java and all it's implementations.
 
 
 Diffs
 -
 
   api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc 
   api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 
   api/src/com/cloud/agent/api/to/S3TO.java f64fe35 
   api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad 
   core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 
   core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 
   
 plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
  e96ebf4 
 
 Diff: https://reviews.apache.org/r/22510/diff/
 
 
 Testing
 ---
 
 Tested on Windows 2012 R2 server and on centos. Tested the following use 
 cases.
 
 1. Attach ISO
 2. Detach ISO
 3. Snapshot creation from root disk
 4. Snapshot creation from data disk
 5. volume creation from (3)
 6. template creation from(3)
 7. Launch a VM after registering new template.
 
 
 Thanks,
 
 Damodar Reddy Talakanti
 




Build failed in Jenkins: build-master-noredist #2933

2014-06-18 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master-noredist/2933/

--
Started by upstream project build-master build number 990
originally caused by:
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on cloudstack-buildslave-centos6-bca 
(cloudstack-buildslave-centos6) in workspace 
http://jenkins.buildacloud.org/job/build-master-noredist/ws/
Fetching changes from the remote Git repository
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
ERROR: Timeout after 400 minutes
FATAL: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
hudson.plugins.git.GitException: Failed to fetch from 
https://git-wip-us.apache.org/repos/asf/cloudstack.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:625)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:847)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:872)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1320)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:609)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:518)
at hudson.model.Run.execute(Run.java:1688)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:231)
Caused by: hudson.plugins.git.GitException: Command git fetch --tags 
--progress https://git-wip-us.apache.org/repos/asf/cloudstack.git 
+refs/heads/*:refs/remotes/origin/* returned status code 128:
stdout: 
stderr: error: RPC failed; result=52, HTTP code = 100
error: fetch-pack died of signal 15

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1086)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:968)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$200(CliGitAPIImpl.java:71)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:197)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
at hudson.remoting.UserRequest.perform(UserRequest.java:118)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:328)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:701)


Review Request 22750: Removed load option and added required_hardware attribute to pom

2014-06-18 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22750/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-6914
https://issues.apache.org/jira/browse/CLOUDSTACK-6914


Repository: cloudstack-git


Description
---

1. As part of refactoring, we removed load option to nose marvin plugin, now 
removed it from pom and added required_hardware attribute to pom
2. simulator, selfservice, tags earlier added were redundant, at many places 
under test cases, these are same. Removed them as part of clean up from test 
cases. Removed them from pom file as well


Diffs
-

  tools/marvin/pom.xml f36f5e4 

Diff: https://reviews.apache.org/r/22750/diff/


Testing
---


Thanks,

Santhosh Edukulla



Jenkins build is back to normal : build-master-noredist #2934

2014-06-18 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master-noredist/2934/changes



Re: Review Request 22709: This test suite contains test cases relating to access checks for createNetwork(), deploying VM in an isolated network and restartNetwork() for Admin, domain admin and regula

2014-06-18 Thread sangeetha hariharan


 On June 18, 2014, 3:20 p.m., Santhosh Edukulla wrote:
  test/integration/component/test_acl_isolatednetwork.py, line 481
  https://reviews.apache.org/r/22709/diff/1/?file=612001#file612001line481
 
  Lot of entities got created, is clean up happening for all of them? I 
  mean can we double check post running the script from ms server that 
  nothing was left out, either offerings, vms, accounts etc.

All the resources like accounts,Vms are all created under 2 domains except for 
2 accounts created under ROOT domain which are included in the cleanup object 
that is sent to cleanup_resources method.
 
In tearDownClass, I am deleting both the domains that were created with clean 
option set to true which I have made sure as part of test execution cleans up 
all resources under this domain:
cls.cleanup = [
cls.account_root,
cls.account_roota,
cls.service_offering,
]
In tearDownClass()
cls.domain_1.delete(cls.apiclient,cleanup=true)
cls.domain_2.delete(cls.apiclient,cleanup=true)
cleanup_resources(cls.apiclient, cls.cleanup)


 On June 18, 2014, 3:20 p.m., Santhosh Edukulla wrote:
  test/integration/component/test_acl_isolatednetwork.py, line 938
  https://reviews.apache.org/r/22709/diff/1/?file=612001#file612001line938
 
  Is it as well a fail scenario if expected exception message is not in 
  the response? Question: Is receiving an exception message is important or 
  its content as well? 
  
 

This use case is to validate that Domain admin should not be able allowed to 
deploy vm for users not in his sub domain. We expect the API to error out with 
a specific error message relating to access check failure. So it is important 
that we receive an exception with a certain access check failure message.


 On June 18, 2014, 3:20 p.m., Santhosh Edukulla wrote:
  test/integration/component/test_acl_isolatednetwork.py, line 939
  https://reviews.apache.org/r/22709/diff/1/?file=612001#file612001line939
 
  Move this inside try block. As well, use self.fail instead of this,it 
  looks neat to read.

In this case , test case fails when exception is not raised. That is the reason 
why I have the raise AssertionError out side the try block. I will use 
self.fail instead of raising a AssertionError


 On June 18, 2014, 3:20 p.m., Santhosh Edukulla wrote:
  test/integration/component/test_acl_isolatednetwork.py, line 35
  https://reviews.apache.org/r/22709/diff/1/?file=612001#file612001line35
 
  Move this to test data under marvin/config directory, if possible.

The test data I am using for acl related suites are very large and does not 
overlap with any test data used by all other suites. So my thinking is that it 
would not be ideal to add it to the common file - test_data.py which is common 
to all test suites. 
Is there a way for me to create a test data file specific for acl test cases 
and have my test suite load this specific test data? For this patch I have kept 
the data within the test suite itself.


 On June 18, 2014, 3:20 p.m., Santhosh Edukulla wrote:
  test/integration/component/test_acl_isolatednetwork.py, line 935
  https://reviews.apache.org/r/22709/diff/1/?file=612001#file612001line935
 
  Is it possible to define all exception entities in CloudStackException 
  and check for them? Otherwise maintenance will be a bit difficult if we 
  just search for message? As well, convert to lower() and search.

I will define all the exception entities in codes.py and have a method 
verifyMsginException(exception,message) which will verify that the exception 
has the message.


 On June 18, 2014, 3:20 p.m., Santhosh Edukulla wrote:
  test/integration/component/test_acl_isolatednetwork.py, line 936
  https://reviews.apache.org/r/22709/diff/1/?file=612001#file612001line936
 
  Better thing is to localize all these check in to a function and pass 
  exception object and message to verify, define all your exception messages 
  in class and verify by passing them. EX:
  
  class ExampleExceptionsToVerify:
  ABC=verify abc
  BCD=verify bcd
  
  verifyMsginException(e,ExampleExceptionsToVerify.ABC). This way, all 
  messages can be handled in one single function and maintenance will be easy?

I will define all the exception entities in codes.py and have a method 
verifyMsginException(exception,message) which will verify that the exception 
has the message.


- sangeetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22709/#review46074
---


On June 18, 2014, 1:28 a.m., sangeetha hariharan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22709/
 

Re: Review Request 22709: This test suite contains test cases relating to access checks for createNetwork(), deploying VM in an isolated network and restartNetwork() for Admin, domain admin and regula

2014-06-18 Thread sangeetha hariharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22709/
---

(Updated June 19, 2014, 5:50 a.m.)


Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Changes
---

- Added error string constants in code.py
- Added verifyMsginException() to verify the presence of error string in 
exception string
- Used verifyMsginException() method and error string constants from code.py 
for validating error strings.
- Test steps added as doc strings
- changed get_zone() call to include zone name parameter 
- used self.fail instead of raise AssertionError


Repository: cloudstack-git


Description (updated)
---

This test suite contains test cases relating to access checks for 
createNetwork(), deploying VM in an isolated network and restartNetwork() for 
Admin, domain admin and regular users.


Added error string constants in code.py
Added verifyMsginException() to verify the presence of error string in 
exception string


Diffs
-

  test/integration/component/test_acl_isolatednetwork.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22709/diff/


Testing
---

test_01_createNetwork_admin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_01_createNetwork_admin | Status : SUCCESS ===
ok
test_02_createNetwork_admin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_02_createNetwork_admin_foruserinsamedomain | Status : SUCCESS ===
ok
test_03_createNetwork_admin_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_03_createNetwork_admin_foruserinotherdomain | Status : SUCCESS 
===
ok
test_04_createNetwork_domaindmin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_04_createNetwork_domaindmin | Status : SUCCESS ===
ok
test_05_createNetwork_domaindmin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_05_createNetwork_domaindmin_foruserinsamedomain | Status : 
SUCCESS ===
ok
test_06_createNetwork_domaindmin_foruserinsubdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_06_createNetwork_domaindmin_foruserinsubdomain | Status : 
SUCCESS ===
ok
test_07_createNetwork_domaindmin_forcrossdomainuser 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_07_createNetwork_domaindmin_forcrossdomainuser | Status : 
SUCCESS ===
ok
test_08_createNetwork_user 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_08_createNetwork_user | Status : SUCCESS ===
ok
test_09_createNetwork_user_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_09_createNetwork_user_foruserinsamedomain | Status : SUCCESS ===
ok
test_10_createNetwork_user_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_10_createNetwork_user_foruserinotherdomain | Status : SUCCESS ===
ok
test_11_deployvm_admin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_11_deployvm_admin | Status : SUCCESS ===
ok
test_12_deployvm_admin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_12_deployvm_admin_foruserinsamedomain | Status : SUCCESS ===
ok
test_13_1_deployvm_admin_foruserinotherdomain_crossnetwork 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_13_1_deployvm_admin_foruserinotherdomain_crossnetwork | Status : 
SUCCESS ===
ok
test_13_deployvm_admin_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_13_deployvm_admin_foruserinotherdomain | Status : SUCCESS ===
ok
test_14_deployvm_domaindmin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_14_deployvm_domaindmin | Status : SUCCESS ===
ok
test_15_deployvm_domaindmin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_15_deployvm_domaindmin_foruserinsamedomain | Status : SUCCESS ===
ok
test_16_deployvm_domaindmin_foruserinsubdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_16_deployvm_domaindmin_foruserinsubdomain | Status : SUCCESS ===
ok
test_17_1_deployvm_domainadmin_foruserinotherdomain_crossnetwork 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_17_1_deployvm_domainadmin_foruserinotherdomain_crossnetwork | 
Status : SUCCESS ===
ok
test_17_deployvm_domaindmin_forcrossdomainuser 

Re: Review Request 22709: This test suite contains test cases relating to access checks for createNetwork(), deploying VM in an isolated network and restartNetwork() for Admin, domain admin and regula

2014-06-18 Thread sangeetha hariharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22709/
---

(Updated June 19, 2014, 5:52 a.m.)


Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Changes
---

This test suite contains test cases relating to access checks for 
createNetwork(), deploying VM in an isolated network and restartNetwork() for 
Admin, domain admin and regular users.


Added error string constants in code.py
Added verifyMsginException() to verify the presence of error string in 
exception string


Repository: cloudstack-git


Description
---

This test suite contains test cases relating to access checks for 
createNetwork(), deploying VM in an isolated network and restartNetwork() for 
Admin, domain admin and regular users.


Added error string constants in code.py
Added verifyMsginException() to verify the presence of error string in 
exception string


Diffs (updated)
-

  test/integration/component/test_acl_isolatednetwork.py PRE-CREATION 
  tools/marvin/marvin/cloudstackException.py c2eb57a 
  tools/marvin/marvin/codes.py a1e7085 

Diff: https://reviews.apache.org/r/22709/diff/


Testing
---

test_01_createNetwork_admin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_01_createNetwork_admin | Status : SUCCESS ===
ok
test_02_createNetwork_admin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_02_createNetwork_admin_foruserinsamedomain | Status : SUCCESS ===
ok
test_03_createNetwork_admin_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_03_createNetwork_admin_foruserinotherdomain | Status : SUCCESS 
===
ok
test_04_createNetwork_domaindmin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_04_createNetwork_domaindmin | Status : SUCCESS ===
ok
test_05_createNetwork_domaindmin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_05_createNetwork_domaindmin_foruserinsamedomain | Status : 
SUCCESS ===
ok
test_06_createNetwork_domaindmin_foruserinsubdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_06_createNetwork_domaindmin_foruserinsubdomain | Status : 
SUCCESS ===
ok
test_07_createNetwork_domaindmin_forcrossdomainuser 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_07_createNetwork_domaindmin_forcrossdomainuser | Status : 
SUCCESS ===
ok
test_08_createNetwork_user 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_08_createNetwork_user | Status : SUCCESS ===
ok
test_09_createNetwork_user_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_09_createNetwork_user_foruserinsamedomain | Status : SUCCESS ===
ok
test_10_createNetwork_user_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_10_createNetwork_user_foruserinotherdomain | Status : SUCCESS ===
ok
test_11_deployvm_admin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_11_deployvm_admin | Status : SUCCESS ===
ok
test_12_deployvm_admin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_12_deployvm_admin_foruserinsamedomain | Status : SUCCESS ===
ok
test_13_1_deployvm_admin_foruserinotherdomain_crossnetwork 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_13_1_deployvm_admin_foruserinotherdomain_crossnetwork | Status : 
SUCCESS ===
ok
test_13_deployvm_admin_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_13_deployvm_admin_foruserinotherdomain | Status : SUCCESS ===
ok
test_14_deployvm_domaindmin 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_14_deployvm_domaindmin | Status : SUCCESS ===
ok
test_15_deployvm_domaindmin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_15_deployvm_domaindmin_foruserinsamedomain | Status : SUCCESS ===
ok
test_16_deployvm_domaindmin_foruserinsubdomain 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_16_deployvm_domaindmin_foruserinsubdomain | Status : SUCCESS ===
ok
test_17_1_deployvm_domainadmin_foruserinotherdomain_crossnetwork 
(integration.component.test_acl_isolatednetwork.TestIsolatedNetwork) ... === 
TestName: test_17_1_deployvm_domainadmin_foruserinotherdomain_crossnetwork | 
Status : SUCCESS ===
ok