Re: New Defects reported by Coverity Scan for cloudstack

2014-07-30 Thread Hugo Trippaers
Hey Ritu,

Thanks! Could you post the patch as a separate review? That way it will be a 
lot easier for me to merge the changes.

The easiest way to do it is to base the new patch on the current state of the 
master branch.

Cheers,

Hugo


On 29 jul. 2014, at 22:32, Ritu Sabharwal rsabh...@brocade.com wrote:

 Hi Hugo,
  
 I have fixed the reported findings and posted the patch on review board.
  
 Thanks  Regards,
 Ritu S.
  
 From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
 Sent: Tuesday, July 29, 2014 6:41 AM
 To: Ritu Sabharwal
 Cc: dev@cloudstack.apache.org; Santhosh Edukulla
 Subject: Fwd: New Defects reported by Coverity Scan for cloudstack
  
 Ritu,
  
 Coverity identified a number of issues with the brocade plugin. Could you 
 have a look at them and post the fixes on the review board? 
  
  
 If you need additional details on the findings you can request coverity 
 access here : https://scan.coverity.com/projects/943
  
 Cheers,
  
 Hugo
  
  
 Begin forwarded message:
 
 
 From: scan-ad...@coverity.com
 Subject: New Defects reported by Coverity Scan for cloudstack
 Date: 29 juli 2014 15:22:48 CEST
  
 
 Hi,
 
 
 Please find the latest report on new defect(s) introduced to cloudstack found 
 with Coverity Scan.
 
 Defect(s) Reported-by: Coverity Scan
 Showing 7 of 7 defect(s)
 
 
 ** CID 1229114:  Resource leak  (RESOURCE_LEAK)
 /plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
  509 in 
 com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
 /plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
  513 in 
 com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
 
 ** CID 1229113:  Resource leak  (RESOURCE_LEAK)
 /plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
  457 in 
 com.cloud.network.brocade.BrocadeVcsApi.executeRetreiveStatus(java.lang.String)()
 
 ** CID 1229115:  Dereference before null check  (REVERSE_INULL)
 /plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
  6299 in 
 com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.execute(com.cloud.agent.api.CreateVMSnapshotCommand)()
 
 ** CID 1229121:  UrF: Unread field  (FB.URF_UNREAD_FIELD)
 /plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
  67 in ()
 /plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
  71 in ()
 /plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
  55 in ()
 /plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
  59 in ()
 /plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
  63 in ()
 
 ** CID 1229120:  WMI: Inefficient Map Iterator  (FB.WMI_WRONG_MAP_ITERATOR)
 /engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java: 478 in 
 com.cloud.capacity.dao.CapacityDaoImpl.findCapacityBy(java.lang.Integer, 
 java.lang.Long, java.lang.Long, java.lang.Long)()
 
 ** CID 1229119:  DLS: Dead local store  (FB.DLS_DEAD_LOCAL_STORE)
 /plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
  4438 in 
 com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.initialize()()
 
 ** CID 1229116:  REC: RuntimeException capture  (FB.REC_CATCH_EXCEPTION)
 /engine/schema/src/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java: 189 in 
 com.cloud.storage.dao.VMTemplatePoolDaoImpl.listByTemplateStatus(long, long, 
 long, com.cloud.storage.VMTemplateStorageResourceAssoc$Status)()
 
 
 
 *** CID 1229114:  Resource leak  (RESOURCE_LEAK)
 /plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
  509 in 
 com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
 503 try {
 504 
 505 BufferedReader rd = new BufferedReader(new 
 InputStreamReader(response.getEntity().getContent(), 
 Charset.forName(UTF-8)));
 506 
 507 StringBuffer result = new StringBuffer();
 508 String line = ;
 
CID 1229114:  Resource leak  (RESOURCE_LEAK)
Variable rd going out of scope leaks the resource it refers to.
 509 while ((line = rd.readLine()) != null) {
 510 result.append(line);
 511 }
 512 
 513 return result.toString();
 514 } catch (IOException e) {
 /plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
  513 in 
 com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
 507 StringBuffer 

Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

2014-07-30 Thread Vetrivel Chinnasamy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

Externalized the hard-coded strings from JavaScript files to resource bundles. 
Updated the dictionary.jsp file accordingly. Also got the externalized strings 
translated in JA  SC.


Diffs
-

  client/WEB-INF/classes/resources/messages.properties a0205e1 
  client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc 
  tools/ngui/static/js/app/storage/storage.js af36167 
  ui/dictionary.jsp 10aeaf9 
  ui/lib/flot/jquery.flot.pie.js b46c03c 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3 
  ui/scripts/accounts.js 2ebfe82 
  ui/scripts/autoscaler.js c8963fd 
  ui/scripts/configuration.js 895f8e8 
  ui/scripts/domains.js 488382e 
  ui/scripts/events.js 2731cb6 
  ui/scripts/instances.js 93a40fc 
  ui/scripts/lbStickyPolicy.js 16995f6 
  ui/scripts/network.js b3a003d 
  ui/scripts/projects.js 53b7964 
  ui/scripts/regions.js 368c1bf 
  ui/scripts/sharedFunctions.js e8c4fcb 
  ui/scripts/storage.js f4ab6e1 
  ui/scripts/system.js 3b53df6 
  ui/scripts/templates.js 3e048cc 
  ui/scripts/ui-custom/autoscaler.js 0aa6c77 
  ui/scripts/ui-custom/healthCheck.js 4e10f1c 
  ui/scripts/ui-custom/physicalResources.js ac379b4 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui-custom/zoneWizard.js f3a1aae 
  ui/scripts/ui/dialog.js 0fddcf7 
  ui/scripts/ui/widgets/listView.js 22182c1 
  ui/scripts/ui/widgets/multiEdit.js 47e5f43 
  ui/scripts/vpc.js 83c5b83 
  ui/scripts/zoneWizard.js 0a84bdb 

Diff: https://reviews.apache.org/r/24090/diff/


Testing
---

Tested by replacing the modified javascript , dictionary.jsp and properties 
files.


Thanks,

Vetrivel Chinnasamy



Re:Re: Re: Use OVSTunnelxxx but not cloudbr1 result exception

2014-07-30 Thread Michael Li
Hi Nguyen,
Thanks for your reply. Did u mean when I create a gre network offering use ovs 
as service provider for connectity, and then create a guest isolated network 
use this offering, at this point a OvsTunnel bridge will be created ?

Regards









At 2014-07-25 10:17:08, Nguyen Anh Tu t...@apache.org wrote:
Michael,

OVSTunnelxxx is automatically created by Ovs controller. The xxx value is
generated between VLAN range you set in the beginning. For each guest
network you create, Ovs controller will add one OvsTunnel bridge.

Thanks,

--Tuna


On Fri, Jul 25, 2014 at 7:46 AM, Michael Li cloudcomp...@163.com wrote:

 Hi Nguyen,
 Should I create OVSTunnelxxx ahead like cloudbr0 and cloud0 ? But how to
 confirm the xxx in OVSTunnelxxx, because it's a dynamic value between the
 vm creatation.


 Regards




 At 2014-07-24 06:08:55, Nguyen Anh Tu t...@apache.org wrote:
 Hi Michael,
 
 The GRE feature on Cloudstack creates OVSTunnelxxx bridges with
 OpenvSwitch
 to serve tunnel between vms, not cloudbr. Please use ovs-vsctl utility to
 check if OVSTunnel460 is exist. Remember to blacklist module bridge.
 
 This might help:
 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/KVM+with+OpenVSwitch
 
 Thanks,
 
 --Tuna
 
 
 On Thu, Jul 24, 2014 at 8:43 AM, Michael Li cloudcomp...@163.com wrote:
 
  In 4.4, Can somebody explain, why use OVSTunnelxxx for GRE tunnel
  device, and not cloudbr1 ?
  When create VM,  this will result an exception:
 
  2014-07-23 21:03:35,886 WARN  [kvm.resource.LibvirtComputingResource]
  (agentRequest-Handler-5:null) LibvirtException
  org.libvirt.LibvirtException: Cannot get interface MTU on
 'OVSTunnel460':
  no such device
  at org.libvirt.ErrorHandler.processError(Unknown Source)
  at org.libvirt.Connect.processError(Unknown Source)
  at org.libvirt.Connect.processError(Unknown Source)
  at org.libvirt.Connect.domainCreateXML(Unknown Source)
  at
 
 com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.startVM(LibvirtComputingResource.java:1239)
  at
 
 com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.execute(LibvirtComputingResource.java:3798)
  at
 
 com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:133
  3)
  at com.cloud.agent.Agent.processRequest(Agent.java:501)
  at
 com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:808)
  at com.cloud.utils.nio.Task.run(Task.java:84)
  at
 
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
  at
 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
  at java.lang.Thread.run(Thread.java:722)
 
  I found code as below:
  public InterfaceDef plug(NicTO nic, String guestOsType)
  } else if (nic.getBroadcastType() ==
 Networks.BroadcastDomainType.Vswitch)
  {String vnetId =
  Networks.BroadcastDomainType.getValue(nic.getBroadcastUri());
  String brName = OVSTunnel + vnetId;
 



Re: building cloudstack

2014-07-30 Thread Daan Hoogland
did you run
$ git pull
$ mvn clean test install
before that?

if so you could try thowing away your ~/.m2/repositories dir.

On Wed, Jul 30, 2014 at 1:50 AM, Elapavuluri, Jaya
jaya.elapavul...@netapp.com wrote:
 So this is the screen shot of the error I am getting.



 This was after trying to start the management server mvn -pl
 :cloud-client-ui jetty:run -Dnoredist





 [INFO]
 

 [ERROR] Failed to execute goal on project cloud-client-ui: Could not resolve
 dependencies for project
 org.apache.cloudstack:cloud-client-ui:war:4.4.1-SNAPSHOT: The following
 artifacts could not be resolved:
 org.apache.cloudstack:cloud-plugin-netapp:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-network-f5:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-network-srx:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-hypervisor-vmware:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-vmware-base:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-network-cisco-vnmc:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-database-mysqlha:jar:4.4.1-SNAPSHOT:
 Failure to find org.apache.cloudstack:cloud-plugin-netapp:jar:4.4.1-SNAPSHOT
 in http://repository.apache.org/snapshots was cached in the local
 repository, resolution will not be reattempted until the update interval of
 apache.snapshots has elapsed or updates are forced - [Help 1]

 [ERROR]

 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
 switch.

 [ERROR] Re-run Maven using the -X switch to enable full debug logging.

 [ERROR]

 [ERROR] For more information about the errors and possible solutions, please
 read the following articles:

 [ERROR] [Help 1]
 http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException









 -Original Message-
 From: Elapavuluri, Jaya [mailto:jaya.elapavul...@netapp.com]
 Sent: Tuesday, July 29, 2014 2:44 PM
 To: dev@cloudstack.apache.org
 Subject: RE: building cloudstack



 So, is there any way the bug can be fixed??



 -Original Message-

 From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]

 Sent: Monday, July 28, 2014 5:10 PM

 To: dev@cloudstack.apache.org

 Subject: Re: building cloudstack



 Hi Jaya,



 Which branch are you on? It's a bug we'll fix it by placing an empty upgrade
 path for 4.4.1 version.



 The upgrade paths are available only between released versions only, so it
 fails as there is no upgrade path for 4.4.1-SNAPSHOT.



 Regards.



 Elapavuluri, Jaya wrote:

 Hello,







 I had setup cloudstack 4.4 environment which was running fine.



 I recently did a git pull to get the updates after which when I tried  to
 mvn -Pdeveloper -pl developer -Ddeploydb I was encountering with the
 following error.





 [ERROR] Failed to execute goal

 org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on

 project cloud-developer: An exception occured while executing the Java

 class. null: InvocationTargetException: The end upgrade version is

 actually at 4.4.0 but our management server code version is at

 4.4.1-SNAPSHOT -  [Help 1]



 However mvn -P developer,systemvm clean install gives a build success.



 Can someone share their knowledge on this?





 --

 Rohit Yadav

 Software Architect, ShapeBlue

 M. +41 779015219 | rohit.ya...@shapeblue.com

 Blog: bhaisaab.org | Twitter: @_bhaisaab





 Find out more about ShapeBlue and our range of CloudStack related services



 IaaS Cloud Design 
 Buildhttp://shapeblue.com/iaas-cloud-design-and-build//

 CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/

 CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/

 CloudStack Infrastructure
 Supporthttp://shapeblue.com/cloudstack-infrastructure-support/

 CloudStack Bootcamp Training
 Courseshttp://shapeblue.com/cloudstack-training/



 This email and any attachments to it may be confidential and are intended
 solely for the use of the individual to whom it is addressed. Any views or
 opinions expressed are solely those of the author and do not necessarily
 represent those of Shape Blue Ltd or related companies. If you are not the
 intended recipient of this email, you must neither take any action based
 upon its contents, nor copy or show it to anyone. Please contact the sender
 if you believe you have received this email in error. Shape Blue Ltd is a
 company incorporated in England  Wales. ShapeBlue Services India LLP is a
 company incorporated in India and is operated under license from Shape Blue
 Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
 and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a
 company registered by The Republic of South Africa and is traded under
 license from Shape Blue Ltd. ShapeBlue is a registered trademark.



-- 
Daan


Re: [DISCUSS] git commit proces

2014-07-30 Thread Sebastien Goasguen

On Jul 29, 2014, at 8:40 PM, Sheng Yang sh...@yasker.org wrote:

 And talking about to achieve good code quality, I think compulsive review
 and testing through some kind of automation system is much more helpful.
 
 --Sheng
 

This new git workflow is not directly about good code quality, as a wise man 
told me the other day crap gets in, crap gets out, not matter what you do with 
git.

IMHO, code quality will indeed be fixed with more reviews and a CI pipeline, 
but it will also mean accepting only patches that have tests with it.
So no unittests, no integration tests, no commit. But I think we are way far 
from this.

There is currently a BVT automatic testing infra proposal on the table from 
citrix, but this needs to be on ASF infra, and it seems no-one has wanted to 
push this proposal much further.

Starting with a better git workflow should bring us up to standard methods of 
developing with git.

x.y-forward has been a mess, calling for [MERGE] request for new features has 
been totally neglected by developers, folks fix a bug in master but don't care 
to check if it applies on other branches and don't fix it there. Or maybe they 
fix on a release branch and don't fix on master.

The end result of this bad practice is this:

-I have personally 0% confidence that a bug fixed somewhere is fixed everywhere 
(it gets even worse when you bring in bad JIRA practices with bugs being closed 
when they are not closed).
-We have quite a bit of regressions
-Our new releases are pretty much different/diverging products
-We don't know what's in a future release (exemplified by difficulty for RM to 
get list of new features)
-And more importantly we don't have a stable branch.

This proposed git workflow would give us:

-A stable branch (master). You checkout master get a shippable product. Very 
few commits to master are made, development is moved to 'develop' branch. Only 
hot fixes of current release get merged in master (which means it's still a 
shippable product). I am in favor of being draconian with this, and I am sure 
we would see a lot of reverts in the first weeks of adopting this workflow. But 
we need to stabilize master.

-Everyone works on branches and knows where to merge. Developers will know 
where they branched from and where they need to merge into. This will also mean 
that history, tracking, reverting  should also be easier. (personally I am not 
entirely against cherry-picks and I could live with some minimal amount done by 
the RM, but they problem with cherry picking right now is with the way we apply 
patches to various branches…untraceable).

-This will also mean that our release branches are clearly defined and a RM can 
actually pick features to merge into a release, but these release branches 
should/will be merged into master instead of being abandoned like we do now.

-Now about minor releases. Say we release 4.5, the tag is in master (not on a 
release branch), we have a few hot fixes that John Smith says are very 
important. Those hot fixes get merged into master (and into develop), we then 
call a vote on the latest master (e.g 4.5.1-tentative) if it passes tag it 
(4.5.1) and we have a new minor release without new features. Master is stable.

The big advantage I see with this is that our release process should be much 
easier and we will have one continuous shippable product, instead of real forks.

-sebastien


 
 On Tue, Jul 29, 2014 at 4:14 PM, Sheng Yang sh...@yasker.org wrote:
 
 Hi Leo,
 
 I am afraid the answer is too generic. We'd better look into details to
 see what's the exactly problem.
 
 So I am trying to sort it out.
 
 The first question we want to ask is:
 
 A. What's current develop process?
 
 I don't know where is it documented, but as I know, it works like
 this(please correct me if I am wrong)
 
 1. Development happen on MASTER first.
 
   - Can merge feature branch.
 
 
 2. Feature freeze, cut staging release branch. No major feature can be
 checked in.
 
   - Say we would release 4.4, then RM create branch 4.4.
   - All the major feature would be worked on MASTER.
   - All the fix for 4.4 need to be applied on 4.4, and MASTER.
 
 3. Code freeze. Branch out staging tree, try to enforce quality.
 
   - RM branch 4.4-forward from 4.4 branch.
   - 4.4 branch freezed, only allow to be checked in by RM.
   - Any 4.4 bug fix need to be applied on 4.4-forward, and after all the
   test and check, developer would ask RM to cherry-pick it to 4.4 branch. RM
   would be the gate keeper for 4.4 branch.
   - In the meanwhile, MASTER would still serve as unstable tree for next
   release.
 
 4. Release. Release branch would be release.
 
   - Release based on branch 4.4, then dropped branch 4.4
   - 4.4-forward branch would be rename to 4.4, and continue to serving
   as release base for 4.4.1 release.
 
 5. For release of 4.4.1 and after. Repeat step 3 and 4(probably not
 strictly in fact). For release of 4.5. Repeat steps 1-4.
 
 The issue with current 

Re: [DISCUSS] git commit proces

2014-07-30 Thread Leo Simons
On Jul 30, 2014, at 1:14 AM, Sheng Yang sh...@yasker.org wrote:
 The issue with current development process?
 1. Cherry-pick is needed for RM to choose stable fix commit after code
 freeze to enforce quality.
 2. Bug fix to current release branch need to be checked in both release
 branch and MASTER.
 3. I believe there would be more. Please comment.

4. where commits need to go is dependent on what phase of the release process 
you’re in, which requires sync. For example, if you’re working on a bug fix 
against 4.4 but then that is frozen you have to rebase against 4.4-forward. If 
you are doing this work on a public feature branch you have to re-cut your 
branch since you don’t want to rebase those.
5. requires using synchronous process (freezes) to keep track of what is going 
on. This is not very healthy for a distributed project with contributors across 
many continents and companies. In contrast if you branch early and often you 
don’t freeze, you just avoid merging things that could destabilize things.
6. does not allow looking into history to see what happened. I.e. if you were 
to cut a 4.5 branch from master, its code history is not at all the same or 
comparable (using git tools) to the code history of 4.4.
7. reliant on error-prone human checking of merge status (looking if all 
cherries have been picked properly) rather than tool support (git confirming 
for you all changes from branch A made it to branch B)
8. default/naive checkouts of cloudstack tree result in a very unstable and 
sometimes unbuildable master

The list goes on! But I don’t see why we should repeat all these things here 
when the internet is full of these kinds of discussions already, as are this 
mailing list’s archives…

 3. Code freeze: No such concept in the flow. Need to know how to guide the
 check in.

Mostly by discipline. Committers normally commit to develop and/or feature 
branches, and switch only to the release branch to commit very specific 
bugfixes. You can agree a policy (for example like Alena described) for how to 
make the decision what should and should not go on onto the release branch.

 5. The original post didn't mention minor release. I suppose it may work
 like this:
 
   1. Branch out MASTER to 4.4 release
   2. Any bug fixes happened on 4.4 need to be merge to MASTER.
   3. But, how to fix a 4.4 bug in 4.5's minor release? Seems what's needed
   is MASTER merged 4.5 which merged 4.4 which merged 4.3. And how can we fix
   it in develop branch(which meant for test)? I can't see how you can avoid
   cherry-pick or extra commit if you want to have a maintenance release.

There will be extra commits, but they will be merge commits. I.e.

master --4.3-4.4--x4.5
 |  \  /
release/4.4.1|   \——x--   /
 |\/ /
bugfix/CLOUDSTACK-1234   | \—x/ /
 |  \ \/
release/4.5  |   \—x—-/
 |  \ \
develop--y---x-

the commit x will always be there exactly once, it will get exactly one sha1 
checksum and one spot in the git index, and git will forever remember all the 
different branches that include x.

On some of those branches there may be merge commits (if you explicitly chose 
to have them, or if git decided they were needed) following x, to record the 
merges that were done.

You can basically always do this as long as you *start your fix on the oldest 
branch* that you want to fix. So if you want to fix a bug in 4.4.1, 4.5.0, and 
all future releases, you develop the fix against the 4.4.1 branch, and then 
merge from there to the 4.5 branch, and then merge from there to the develop 
branch.

This works very well with git because it remembers the complete history of 
everything (if you don’t cherry-pick). I.e. if commit y is the last commit that 
is in common between master and develop, when it becomes time
to merge x to develop, git will traverse the whole history of x until it finds 
y, then consider the situation from there. As long as you don’t cherry-pick, 
git can do this logic provably correctly looking mostly at sha1 commit ids.

 Before realizing the maintenance release issue, I was quite like this
 approach, which means no more duplicate work need to be done. But sadly the
 most usage for cherry-pick is due to we need to fix multiple versions.
 Current I can't see how utilize gitflow or git merge would solve the issue.
 Is there a better way to handle this?

I hope the above helps. If it doesn’t, what I recommend to you (and anyone else 
having these kinds of questions is) to just _try it_. These kinds of 
conversations are very hard, and the diagrams can be confusing, but, when 
you’re actually doing the work and typing in the commands, it is really much 
much easier to 

Re: Re: Re: Use OVSTunnelxxx but not cloudbr1 result exception

2014-07-30 Thread Nguyen Anh Tu
Hi,

It will be created when you run the first VM on that guest isolated network.

Thanks,

--Tuna


On Wed, Jul 30, 2014 at 2:21 PM, Michael Li cloudcomp...@163.com wrote:

 Hi Nguyen,
 Thanks for your reply. Did u mean when I create a gre network offering use
 ovs as service provider for connectity, and then create a guest isolated
 network use this offering, at this point a OvsTunnel bridge will be created
 ?

 Regards









 At 2014-07-25 10:17:08, Nguyen Anh Tu t...@apache.org wrote:
 Michael,
 
 OVSTunnelxxx is automatically created by Ovs controller. The xxx value is
 generated between VLAN range you set in the beginning. For each guest
 network you create, Ovs controller will add one OvsTunnel bridge.
 
 Thanks,
 
 --Tuna
 
 
 On Fri, Jul 25, 2014 at 7:46 AM, Michael Li cloudcomp...@163.com wrote:
 
  Hi Nguyen,
  Should I create OVSTunnelxxx ahead like cloudbr0 and cloud0 ? But how to
  confirm the xxx in OVSTunnelxxx, because it's a dynamic value between
 the
  vm creatation.
 
 
  Regards
 
 
 
 
  At 2014-07-24 06:08:55, Nguyen Anh Tu t...@apache.org wrote:
  Hi Michael,
  
  The GRE feature on Cloudstack creates OVSTunnelxxx bridges with
  OpenvSwitch
  to serve tunnel between vms, not cloudbr. Please use ovs-vsctl utility
 to
  check if OVSTunnel460 is exist. Remember to blacklist module bridge.
  
  This might help:
  
 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/KVM+with+OpenVSwitch
  
  Thanks,
  
  --Tuna
  
  
  On Thu, Jul 24, 2014 at 8:43 AM, Michael Li cloudcomp...@163.com
 wrote:
  
   In 4.4, Can somebody explain, why use OVSTunnelxxx for GRE tunnel
   device, and not cloudbr1 ?
   When create VM,  this will result an exception:
  
   2014-07-23 21:03:35,886 WARN  [kvm.resource.LibvirtComputingResource]
   (agentRequest-Handler-5:null) LibvirtException
   org.libvirt.LibvirtException: Cannot get interface MTU on
  'OVSTunnel460':
   no such device
   at org.libvirt.ErrorHandler.processError(Unknown Source)
   at org.libvirt.Connect.processError(Unknown Source)
   at org.libvirt.Connect.processError(Unknown Source)
   at org.libvirt.Connect.domainCreateXML(Unknown Source)
   at
  
 
 com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.startVM(LibvirtComputingResource.java:1239)
   at
  
 
 com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.execute(LibvirtComputingResource.java:3798)
   at
  
 
 com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:133
   3)
   at com.cloud.agent.Agent.processRequest(Agent.java:501)
   at
  com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:808)
   at com.cloud.utils.nio.Task.run(Task.java:84)
   at
  
 
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
   at
  
 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
   at java.lang.Thread.run(Thread.java:722)
  
   I found code as below:
   public InterfaceDef plug(NicTO nic, String guestOsType)
   } else if (nic.getBroadcastType() ==
  Networks.BroadcastDomainType.Vswitch)
   {String vnetId =
   Networks.BroadcastDomainType.getValue(nic.getBroadcastUri());
   String brName = OVSTunnel + vnetId;
  
 



Re: Review Request 23805: Added state parameter to the listPublicIpAddresses API call

2014-07-30 Thread Ilia Shakitko


 On July 29, 2014, 10:20 a.m., Rohit Yadav wrote:
  Looks fine, we still need to test it before we land it on master. I 
  unfortunately don't have my hardware (and some parts) setup will try with 
  DevCloud or hope someone else would review, test and ship it :)

Maybe we can add a reviewer who is currently working on master branch?


- Ilia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23805/#review48976
---


On July 28, 2014, 10:12 a.m., Ilia Shakitko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23805/
 ---
 
 (Updated July 28, 2014, 10:12 a.m.)
 
 
 Review request for cloudstack, Alena Prokharchyk, Alex Huang, Harikrishna 
 Patnala, Kishan Kavala, Prachi Damle, Rohit Yadav, Ilia Shakitko, Wei Zhou, 
 and Wido den Hollander.
 
 
 Bugs: CLOUDSTACK-7159
 https://issues.apache.org/jira/browse/CLOUDSTACK-7159
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 This improvement is introducing a new parameter for the 
 listPublicIpAddresses API call - state.
 
 Few times we've faced an impedemence of having a list of Free 
 publicIpAddresses. You have to go thru all the IPs with (allocatedonly = 
 false) and filter out the Free once. It's not a big deal, but it's an extra 
 time and traffic between CloudStack and an API consumer.
 
 I also moved few methods out of the 'API Implementation' and put them above 
 as a minor refactoring.
 Method getForLoadBalancing has been removed because it's not being used in 
 code anywhere else.
 
 This patch is done for master branch.
 
 
 Diffs
 -
 
   
 api/src/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
  07ccfe9 
   server/src/com/cloud/server/ManagementServerImpl.java 99b12732 
 
 Diff: https://reviews.apache.org/r/23805/diff/
 
 
 Testing
 ---
 
 1) Build successfull
 2) No tests broken
 3) Tested few different calls with cloudmonkey:
 
 list publicipaddresses forvirtualnetwork=false listall=true page=1 pagesize=0
 count = 10
 
 list publicipaddresses forvirtualnetwork=false listall=true 
 allocatedonly=false page=1 pagesize=0
 count = 100
 
 list publicipaddresses forvirtualnetwork=false listall=true state=free page=1 
 pagesize=0
 count = 90
 
 
 Thanks,
 
 Ilia Shakitko
 




Re: [ACS44][BUG] SystemVM not working on 4.4

2014-07-30 Thread Andrei Mikhailovsky
Hello guys, 

I am planning to upgrade my ACS from version 4.2.1 to version 4.4 this weekend. 
Following the last disastrous upgrade from 4.2.1 to 4.3.0, which also related 
to the system vm issues, I would like to verify the required steps to have a 
_working_ ACS following upgrade to 4.4? Reading this thread it seems that the 
documentation is wrong/misleading and that people are having issues with system 
vms. 

Could some one post a working set of instructions to fix the system vm issue 
that people are having? 

Thanks 

Andrei 



- Original Message -

From: Erik Weber terbol...@gmail.com 
To: dev dev@cloudstack.apache.org 
Sent: Tuesday, 29 July, 2014 8:08:21 PM 
Subject: Re: [ACS44][BUG] SystemVM not working on 4.4 

Frankly I don't know, I didn't focus much on the management server logs. 

It's easy to check if you're affected by checking the 
/var/log/cloud/cloud.out on either the ssvm or cpvm for the version error. 

Erik 


On Tue, Jul 29, 2014 at 8:34 PM, Tanner Danzey arkan...@gmail.com wrote: 

 Is the behavior you are describing here followed by a 
 com.cloud.exception.AgentUnavailableException: Resource [Host:13] is 
 unreachable: Host 13: Unable to start instance due to Unable to get answer 
 that is of class com.cloud.agent.api.StartAnswer? We upgraded from 4.3 and 
 found this fun little nugget. Would you be able to advise how to do a 
 manual MySQL template upgrade with 4.4 templates? 
 
 
 On Tue, Jul 29, 2014 at 9:05 AM, Erik Weber terbol...@gmail.com wrote: 
 
  Changing subject as it's not only KVM related. 
  
  Am I the only one concerned about the fact that potentially every ACS44 
  installation, if installed according to doc, is broken? 
  
  The last day there's been atleast three people on IRC with similar 
 symptoms 
  (system vms not working), one reverted to 4.3 before I could get him/her 
 to 
  verify it to be the same problem, but two confirmed the java error. 
  
  The last one on irc to confirm the issue was an upgrade btw, so it's not 
  only new installations that has the issue. 
  
  Manually updating java on the ssvm and cpvm is a temporarily fix, but 
 not a 
  good one in the long run. 
  
  Downloading the latest 4.4 template from jenkins and updating MySQL 
  manually seems to give good working system vms as far as I have tested. 
  
  
  
  Erik 
  
  On Tue, Jul 29, 2014 at 11:53 AM, Daan Hoogland daan.hoogl...@gmail.com 
  
  wrote: 
  
   given the move from java6 to j7; all 
   
   On Tue, Jul 29, 2014 at 11:49 AM, Erik Weber terbol...@gmail.com 
  wrote: 
On Tue, Jul 29, 2014 at 11:41 AM, Wido den Hollander w...@widodh.nl 
  
   wrote: 



On 07/29/2014 02:44 AM, Erik Weber wrote: 

Tried helping Soeren Malchow on irc today, with a new ACS44 
   installation. 

The docs referenced ACS43 system templates from January, but even 
 by 
   using 
the late June ones that got uploaded after the heartbleed incident 
 it 
still 
does not work. 


Have you tried the 4.4 templates found here: 
   http://cloudstack.apt-get.eu/ 
systemvm/4.4/ 



Not yet, as of the moment I'm more curious of which of our documentet 
systemvm templates that needs to be changed. 


Erik 
   
   
   
   -- 
   Daan 
   
  
 
 
 
 -- 
 *Tanner Danzey* 
 Systems Engineer 
 Northstar Technology Group 
 arkan...@gmail.com / tanner.dan...@northstar-tg.com 
 (701) 237-9096 x7122 
 



Re: Marvin Package?

2014-07-30 Thread Rohit Yadav


Santhosh Edukulla wrote:

please add me as well. username santhoshe


Done.

Regards.



Santhosh

From: Rohit Yadav [rohit.ya...@shapeblue.com]
Sent: Tuesday, July 29, 2014 5:28 PM
To: dev@cloudstack.apache.org
Subject: Re: Marvin Package?

Ian Duffy wrote:

Ian and other committers who may be interested, let me know your pypi

username I'll add you on the admin list as well.

Sure, imduffy15 is my pypi username.


Done, feel free to help release marvin in future.

Regards.



On 29 July 2014 22:08, Rohit Yadavrohit.ya...@shapeblue.com   wrote:


Hi Ian,

Thanks for the find, I think since sharing things on pypi does not need
to be officially voted I think we can go ahead and release marvin for
past CloudStack releases for at least 4.4.0

Hugo, PMC and other can comment on the releasing part?

I went ahead and added cloudmonkey pypi module owners to this:
https://pypi.python.org/pypi/cloudstack-marvin

Ian and other committers who may be interested, let me know your pypi
username I'll add you on the admin list as well.

Regards.


Ian Duffy wrote:


I see the pypi entry now goes to 404:
https://pypi.python.org/pypi/cloudstack-marvin/

Came we go ahead and set the version of marvin to 4.4 and do a release?

Thanks,
Ian


On 28 July 2014 18:50, Ian Duffyi...@ianduffy.iewrote:

   +1 on same version, makes sense to me.

On 28 July 2014 13:55, Hugo Trippaersh...@trippaers.nlwrote:

   Sounds good to me.

Cheers,

Hugo

On 28 jul. 2014, at 14:33, Rohit Yadavrohit.ya...@shapeblue.com
   wrote:

   Hi Hugo,

Does it make sense to simply use the same version as CloudStack from
next Marvin releases? This is because with each CloudStack release and
possible API changes, the Marvin cloudstackAPI python module will
change. Other than that there are couple of API
marshaling/unmarshaling,
signature logic and HTTP stuff but that too changes with CloudStack.

Regards.

Hugo Trippaers wrote:


Before we start with Marvin releases we should discuss versioning i


think.
At the moment all marvin packages are shipped with version 1.0, if we
want to take marvin releases serious we need to start with versions

whenever the something in marvin changes.


Cheers.

Hugo


On 28 jul. 2014, at 14:20, Rohit Yadavrohit.ya...@shapeblue.com


wrote:
Hi,

I think since the Marvin package tightly depends on CloudStack, it's
release can happen along with CloudStack release.

@Prasanna -- Can you add couple of people as owner/admins to the
cloudstack-marvin pypi package?

Regards.

David Nalley wrote:


I wonder if we need to move this to its own release as we did with


cloudmonkey?

--David

On Mon, Jul 28, 2014 at 8:05 AM, Ian Duffyi...@ianduffy.ie
   wrote:


I believe no, atleast the latest changes under master or
4.4-forward.

Alright, Thanks. I believe all changes for it within 4.4-forward

should now

be in 4.4?

@Prasanna since you hold the account on pypi holding the name
cloudstack-marvin can you make the upload?
Tar at:


http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-marvin/

Thanks,

Ian


On 28 July 2014 01:52, Santhosh Edukulla


santhosh.eduku...@citrix.com

wrote:

   I believe no, atleast the latest changes under master or
4.4-forward.

Santhosh


From: Ian Duffy [i...@ianduffy.ie]
Sent: Sunday, July 27, 2014 4:47 PM
To: CloudStack Dev; Santhosh Edukulla; Prasanna Santhanam
Subject: Marvin Package?

Hi,

Do we have a binary of marvin that users can download independent


to the

management server rpms? Other than grabbing the tar.gz from

jenkins.

I was hoping it would be published on pypi. Prasanna seems to have

a page

for it there but there are no uploads:

https://pypi.python.org/pypi/cloudstack-marvin/0.1.0

Ideally I want pip install cloudstack-marvin or easy_install
cloudstack-marvin.

Thanks,

Ian

   --

Rohit Yadav
Software Architect, ShapeBlue
M. +41 779015219 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab


Find out more about ShapeBlue and our range of CloudStack related


services

IaaS Cloud Design Build

http://shapeblue.com/iaas-cloud-design-and-build//

CSForge – rapid IaaS deployment framework

http://shapeblue.com/csforge/

CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/

CloudStack Infrastructure Support


http://shapeblue.com/cloudstack-infrastructure-support/

CloudStack Bootcamp Training Courses

http://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are

intended solely for the use of the individual to whom it is

addressed. Any
views or opinions expressed are solely those of the author and do not
necessarily represent those of Shape Blue Ltd or related companies. If
you
are not the intended recipient of this email, you must neither take any
action based upon its contents, nor copy or show it to anyone. Please
contact the sender if you believe you have received this email in error.
Shape Blue Ltd 

Re: [ACS44][BUG] SystemVM not working on 4.4

2014-07-30 Thread Erik Weber
This is work in progress for a guide to fixing broken system vm's, but
please note that this currently has seen limited testing yet, so take any
precautions you can.
https://gist.github.com/terbolous/102ae8edd1cda192561c


The best thing you can do before upgrading is to download the new system vm
template, that way you won't have to mess around inside the old one. You
would still have to change some database values, but that's far less work.

Erik

On Wed, Jul 30, 2014 at 11:27 AM, Andrei Mikhailovsky and...@arhont.com
wrote:

 Hello guys,

 I am planning to upgrade my ACS from version 4.2.1 to version 4.4 this
 weekend. Following the last disastrous upgrade from 4.2.1 to 4.3.0, which
 also related to the system vm issues, I would like to verify the required
 steps to have a _working_ ACS following upgrade to 4.4? Reading this thread
 it seems that the documentation is wrong/misleading and that people are
 having issues with system vms.

 Could some one post a working set of instructions to fix the system vm
 issue that people are having?

 Thanks

 Andrei



 - Original Message -

 From: Erik Weber terbol...@gmail.com
 To: dev dev@cloudstack.apache.org
 Sent: Tuesday, 29 July, 2014 8:08:21 PM
 Subject: Re: [ACS44][BUG] SystemVM not working on 4.4

 Frankly I don't know, I didn't focus much on the management server logs.

 It's easy to check if you're affected by checking the
 /var/log/cloud/cloud.out on either the ssvm or cpvm for the version error.

 Erik


 On Tue, Jul 29, 2014 at 8:34 PM, Tanner Danzey arkan...@gmail.com wrote:

  Is the behavior you are describing here followed by a
  com.cloud.exception.AgentUnavailableException: Resource [Host:13] is
  unreachable: Host 13: Unable to start instance due to Unable to get
 answer
  that is of class com.cloud.agent.api.StartAnswer? We upgraded from 4.3
 and
  found this fun little nugget. Would you be able to advise how to do a
  manual MySQL template upgrade with 4.4 templates?
 
 
  On Tue, Jul 29, 2014 at 9:05 AM, Erik Weber terbol...@gmail.com wrote:
 
   Changing subject as it's not only KVM related.
  
   Am I the only one concerned about the fact that potentially every ACS44
   installation, if installed according to doc, is broken?
  
   The last day there's been atleast three people on IRC with similar
  symptoms
   (system vms not working), one reverted to 4.3 before I could get
 him/her
  to
   verify it to be the same problem, but two confirmed the java error.
  
   The last one on irc to confirm the issue was an upgrade btw, so it's
 not
   only new installations that has the issue.
  
   Manually updating java on the ssvm and cpvm is a temporarily fix, but
  not a
   good one in the long run.
  
   Downloading the latest 4.4 template from jenkins and updating MySQL
   manually seems to give good working system vms as far as I have tested.
  
  
  
   Erik
  
   On Tue, Jul 29, 2014 at 11:53 AM, Daan Hoogland 
 daan.hoogl...@gmail.com
  
   wrote:
  
given the move from java6 to j7; all
   
On Tue, Jul 29, 2014 at 11:49 AM, Erik Weber terbol...@gmail.com
   wrote:
 On Tue, Jul 29, 2014 at 11:41 AM, Wido den Hollander 
 w...@widodh.nl
  
wrote:



 On 07/29/2014 02:44 AM, Erik Weber wrote:

 Tried helping Soeren Malchow on irc today, with a new ACS44
installation.

 The docs referenced ACS43 system templates from January, but even
  by
using
 the late June ones that got uploaded after the heartbleed
 incident
  it
 still
 does not work.


 Have you tried the 4.4 templates found here:
http://cloudstack.apt-get.eu/
 systemvm/4.4/



 Not yet, as of the moment I'm more curious of which of our
 documentet
 systemvm templates that needs to be changed.


 Erik
   
   
   
--
Daan
   
  
 
 
 
  --
  *Tanner Danzey*
  Systems Engineer
  Northstar Technology Group
  arkan...@gmail.com / tanner.dan...@northstar-tg.com
  (701) 237-9096 x7122
 




Re: building cloudstack

2014-07-30 Thread Rohit Yadav

Hi Jaya,

The database upgrade path issue was fixed.

This looks like mvn/dependency error. Just git pull the latest on 4.4
branch and do a mvn clean install. If problem persists, remove ~/.m2 and
start over.

Regards.

Elapavuluri, Jaya wrote:

So this is the screen shot of the error I am getting.

This was after trying to start the management server mvn -pl
:cloud-client-ui jetty:run -Dnoredist

[INFO]


[ERROR] Failed to execute goal on project cloud-client-ui: Could not
resolve dependencies for project
org.apache.cloudstack:cloud-client-ui:war:4.4.1-SNAPSHOT: The following
artifacts could not be resolved:
org.apache.cloudstack:cloud-plugin-netapp:jar:4.4.1-SNAPSHOT,
org.apache.cloudstack:cloud-plugin-network-f5:jar:4.4.1-SNAPSHOT,
org.apache.cloudstack:cloud-plugin-network-srx:jar:4.4.1-SNAPSHOT,
org.apache.cloudstack:cloud-plugin-hypervisor-vmware:jar:4.4.1-SNAPSHOT,
org.apache.cloudstack:cloud-vmware-base:jar:4.4.1-SNAPSHOT,
org.apache.cloudstack:cloud-plugin-network-cisco-vnmc:jar:4.4.1-SNAPSHOT, 
org.apache.cloudstack:cloud-plugin-database-mysqlha:jar:4.4.1-SNAPSHOT:
Failure to find
org.apache.cloudstack:cloud-plugin-netapp:jar:4.4.1-SNAPSHOT in
http://repository.apache.org/snapshots was cached in the local
repository, resolution will not be reattempted until the update interval
of apache.snapshots has elapsed or updates are forced - [Help 1]

[ERROR]

[ERROR] To see the full stack trace of the errors, re-run Maven with the
-e switch.

[ERROR] Re-run Maven using the -X switch to enable full debug logging.

[ERROR]

[ERROR] For more information about the errors and possible solutions,
please read the following articles:

[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException

-Original Message-
From: Elapavuluri, Jaya [mailto:jaya.elapavul...@netapp.com]
Sent: Tuesday, July 29, 2014 2:44 PM
To: dev@cloudstack.apache.org
Subject: RE: building cloudstack

So, is there any way the bug can be fixed??

-Original Message-

From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]

Sent: Monday, July 28, 2014 5:10 PM

To: dev@cloudstack.apache.org mailto:dev@cloudstack.apache.org

Subject: Re: building cloudstack

Hi Jaya,

Which branch are you on? It's a bug we'll fix it by placing an empty
upgrade path for 4.4.1 version.

The upgrade paths are available only between released versions only, so
it fails as there is no upgrade path for 4.4.1-SNAPSHOT.

Regards.

Elapavuluri, Jaya wrote:

  Hello,

 

 

 

  I had setup cloudstack 4.4 environment which was running fine.

 

  I recently did a git pull to get the updates after which when I tried
to mvn -Pdeveloper -pl developer -Ddeploydb I was encountering with the
following error.

 

 

  [ERROR] Failed to execute goal

  org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on

  project cloud-developer: An exception occured while executing the Java

  class. null: InvocationTargetException: The end upgrade version is

  actually at 4.4.0 but our management server code version is at

  4.4.1-SNAPSHOT - [Help 1]

 

  However mvn -P developer,systemvm clean install gives a build success.

 

  Can someone share their knowledge on this?

 

--

Rohit Yadav

Software Architect, ShapeBlue

M. +41 779015219 | rohit.ya...@shapeblue.com
mailto:rohit.ya...@shapeblue.com

Blog: bhaisaab.org | Twitter: @_bhaisaab

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design 
Buildhttp://shapeblue.com/iaas-cloud-design-and-build//
http://shapeblue.com/iaas-cloud-design-and-build/

CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/

CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/

CloudStack Infrastructure
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/

CloudStack Bootcamp Training
Courseshttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are
intended solely for the use of the individual to whom it is addressed.
Any views or opinions expressed are solely those of the author and do
not necessarily represent those of Shape Blue Ltd or related companies.
If you are not the intended recipient of this email, you must neither
take any action based upon its contents, nor copy or show it to anyone.
Please contact the sender if you believe you have received this email in
error. Shape Blue Ltd is a company incorporated in England  Wales.
ShapeBlue Services India LLP is a company incorporated in India and is
operated under license from Shape Blue Ltd. Shape Blue Brasil
Consultoria Ltda is a company incorporated in Brasil and is operated
under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company
registered by The Republic of South Africa and is traded under license
from Shape Blue Ltd. ShapeBlue is a registered trademark.



--
Rohit Yadav
Software Architect, ShapeBlue
M. +41 779015219 | 

Simulator on master is not building

2014-07-30 Thread Santhosh Edukulla
I believe for every check-in we decided to run sanity tests on simulator 
atleast, currently build for simulator is failing. 

 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation 
failure:
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations


Thanks!
Santhosh

RE: Simulator on master is not building

2014-07-30 Thread Koushik Das
The simulator code should be kept up to date with any changes done in the core 
product. If there are any interface changes, necessary changes should be made 
in simulator plugin as well along with other hypervisor plugins. To build 
simulator code use refer to [1].

-Koushik

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration

-Original Message-
From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com] 
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building

I believe for every check-in we decided to run sanity tests on simulator 
atleast, currently build for simulator is failing. 

 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation 
failure:
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations [ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations


Thanks!
Santhosh


Re: Review Request 21554: CLOUDSTACK-6657: Adding condition for checking error code 530 across test cases

2014-07-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21554/#review49093
---


Commit a40f2315fdc761309107cc5c88fbd44932edf7e3 in cloudstack's branch 
refs/heads/4.4 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a40f231 ]

CLOUDSTACK-6657: Adding condition for checking error code 530 across test cases

Signed-off-by: SrikanteswaraRao Talluri tall...@apache.org
(cherry picked from commit 8eca37056f5bb1eee10f0bedee785142d7c3437a)

Conflicts:
test/integration/smoke/test_network.py


- ASF Subversion and Git Services


On May 16, 2014, 2:03 p.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21554/
 ---
 
 (Updated May 16, 2014, 2:03 p.m.)
 
 
 Review request for cloudstack and Santhosh Edukulla.
 
 
 Bugs: CLOUDSTACK-6657
 https://issues.apache.org/jira/browse/CLOUDSTACK-6657
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Adding explicit check for error code 530 in the response received form the 
 server wherever applicable.
 I have made these changes in all those files which failed due to having wrong 
 assert (Build #348 KVM regression).
 
 Will add more of these changes in other files whenever found failing due to 
 above reason in the build logs.
 
 
 Diffs
 -
 
   test/integration/component/test_accounts.py cf5f2b6 
   test/integration/component/test_add_remove_network.py c17293d 
   test/integration/component/test_affinity_groups.py d0fa2f7 
   test/integration/component/test_assign_vm.py 24b63a6 
   test/integration/component/test_ip_reservation.py c84f63c 
   test/integration/component/test_non_contiguous_vlan.py 4609af9 
   test/integration/component/test_projects.py c593fb6 
   test/integration/component/test_volumes.py b5b08e2 
   test/integration/component/test_vpc.py e9d396e8 
   test/integration/component/test_vpc_network.py a449948 
   test/integration/component/test_vpc_network_lbrules.py a5625e7 
   test/integration/component/test_vpc_vms_deployment.py 1c1f93d 
   test/integration/smoke/test_network.py 6beb071 
   test/integration/smoke/test_nic.py 592a839 
   test/integration/smoke/test_primary_storage.py 3147d86 
   test/integration/smoke/test_volumes.py 5908e2b 
 
 Diff: https://reviews.apache.org/r/21554/diff/
 
 
 Testing
 ---
 
 Tested all test suites with python command.
 Tested only few test suites by running them, not all. Same working change has 
 been applied to all files.
 
 
 File Attachments
 
 
 Rebased patch against master
   
 https://reviews.apache.org/media/uploaded/files/2014/05/16/23566db1-7f6c-46bf-9444-878d9a6e7630__0001-CLOUDSTACK-6657-Adding-condition-for-checking-error-.patch
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

2014-07-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21858/#review49095
---


Commit 34f3a5fd44cd7af9f53f628b71f48d854d498eff in cloudstack's branch 
refs/heads/4.4 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=34f3a5f ]

CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

Signed-off-by: Abhinandan Prateek aprat...@apache.org
(cherry picked from commit d9066f8d2931acc44ae66fc33f9eaa87b572de6a)


- ASF Subversion and Git Services


On May 23, 2014, 12:31 p.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21858/
 ---
 
 (Updated May 23, 2014, 12:31 p.m.)
 
 
 Review request for cloudstack and Santhosh Edukulla.
 
 
 Bugs: CLOUDSTACK-6758
 https://issues.apache.org/jira/browse/CLOUDSTACK-6758
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Whenever API returns error message for failed job (not exception), in this 
 case it is returned to test cases as it is. Instead it should throw 
 exceptions for failed jobs.
 
 With this change, reverted changes done in the test cases (Checking for 
 ERROR_CODE_530) with commit 
 https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a
 
 
 Diffs
 -
 
   test/integration/component/test_accounts.py 9b9ae75 
   test/integration/component/test_add_remove_network.py 969d94c 
   test/integration/component/test_affinity_groups.py d31746a 
   test/integration/component/test_assign_vm.py 0b07e9f 
   test/integration/component/test_ip_reservation.py eb193d1 
   test/integration/component/test_non_contiguous_vlan.py 1f74252 
   test/integration/component/test_projects.py cf6cec8 
   test/integration/component/test_volumes.py 4a91e5d 
   test/integration/component/test_vpc.py 31b421c 
   test/integration/component/test_vpc_network.py 8d12ec6 
   test/integration/component/test_vpc_network_lbrules.py 47bdce5 
   test/integration/component/test_vpc_vms_deployment.py 19aa448 
   test/integration/smoke/test_network.py 7cd3973 
   test/integration/smoke/test_nic.py a76e858 
   test/integration/smoke/test_primary_storage.py 5b24b64 
   test/integration/smoke/test_volumes.py cc76e49 
   tools/marvin/marvin/cloudstackConnection.py 8044da7 
   tools/marvin/marvin/codes.py c72a6bd 
 
 Diff: https://reviews.apache.org/r/21858/diff/
 
 
 Testing
 ---
 
 Tested all the changed test cases on VMware.
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 20621: CLOUDSTACK-6529: Fixed adding hosts even if any host addition fails.

2014-07-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20621/#review49094
---


Commit 25a78acee127e7b195e4508bd8c1740d9fe227ed in cloudstack's branch 
refs/heads/4.4 from santhosh
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=25a78ac ]

Added fix for CLOUDSTACK-6529

Fixed to continue adding all hosts, even if any addition fails and remove
unused args from host class.

Signed-off-by: santhosh santhosh.eduku...@gmail.com
Signed-off-by: Abhinandan Prateek aprat...@apache.org
(cherry picked from commit 6f3ff068270f48e00531c462de4f7d76395658ff)

Conflicts:
tools/marvin/marvin/deployDataCenter.py


- ASF Subversion and Git Services


On May 23, 2014, 12:39 p.m., Santhosh Edukulla wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20621/
 ---
 
 (Updated May 23, 2014, 12:39 p.m.)
 
 
 Review request for cloudstack and Abhinandan Prateek.
 
 
 Bugs: CLOUDSTACK-6529
 https://issues.apache.org/jira/browse/CLOUDSTACK-6529
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 1. In deployDataCenter when a host addition fails, it is not continuing 
 further. Added a change, to continue adding all hosts, even if any addition 
 fails. Do a cleanup only when all host addition fails. Tested the changes on 
 local setup 
 
 2. Removed another unwanted arguments from class host which are not part of 
 addHost call.
 3. Added an exit check based upon correct input file path type.
 
 
 Diffs
 -
 
   tools/marvin/marvin/configGenerator.py 66609da 
   tools/marvin/marvin/deployDataCenter.py 4d8be58 
 
 Diff: https://reviews.apache.org/r/20621/diff/
 
 
 Testing
 ---
 
 Tested the changes that it is not breaking existing deployDataCenter.
 
 
 Thanks,
 
 Santhosh Edukulla
 




Build failed in Jenkins: cloudstack-4.4-maven-build #404

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/404/changes

Changes:

[Daan Hoogland] Fixing issues in regression test suite test_accounts.py

[Daan Hoogland] Fix for Marvin utils.py:checkVolumeSize Fix for 
test_01_create_volume to use the correct volume name for XenServer

[Daan Hoogland] Added fix for CLOUDSTACK-6529

[Daan Hoogland] CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

--
[...truncated 1317 lines...]
[INFO] Executing tasks

main:
 [copy] Copying 3 files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/server/target/conf
 [copy] Copying 1 file to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/server/target/conf
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 30 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-server 
---
[INFO] Compiling 360 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/server/target/classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 29 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-server ---
[INFO] Compiling 82 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/server/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-server ---
[INFO] Surefire report directory: 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/server/target/surefire-reports

---
 T E S T S
---
Running com.cloud.event.EventControlsUnitTest
log4j:WARN No appenders could be found for logger 
(com.cloud.event.EventControlsUnitTest).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.673 sec
Running com.cloud.keystore.KeystoreTest
org.apache.cloudstack.api.response.UserVmResponse/null/{id:3,securitygroup:[],nic:[],tags:[],affinitygroup:[]}
org.apache.cloudstack.api.response.AlertResponse/null/{id:100,description:Hello}
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.161 sec
Running com.cloud.alert.AlertControlsUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec
Running com.cloud.capacity.CapacityManagerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.124 sec
Running com.cloud.resourcelimit.ResourceLimitManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
Running com.cloud.network.firewall.FirewallManagerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.001 sec
Running com.cloud.network.UpdatePhysicalNetworkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.21 sec
Running com.cloud.network.CreatePrivateNetworkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.111 sec
Running com.cloud.network.NetworkModelTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.095 sec
Running com.cloud.network.security.SecurityGroupManagerImplTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.689 sec
Running com.cloud.network.security.SecurityGroupQueueTest
Total jobs dequeued = 10, num queued=1007 queue current size=997
Num Vms= 50 Queue size = 50
Num Vms= 2 Queue size = 2 time=247 ms
Num Vms= 5000 Queue size = 5000 time=1023 ms
Num Vms= 1 Queue size = 1 time=1 ms
Num Vms= 100 Queue size = 100 time=301 ms
Total jobs dequeued = 10, num queued=1010 queue current size=1000
Total jobs dequeued = 1, num queued=1001 queue current size=1000
Total jobs dequeued = 10, num queued=1000 queue current size=990
Total jobs dequeued = 10, num queued=10 queue current size=0
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.036 sec  
FAILURE!
Running com.cloud.network.vpc.VpcManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.04 sec
Running com.cloud.network.DedicateGuestVlanRangesTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.077 sec
Running com.cloud.network.lb.AssignLoadBalancerTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.116 sec
Running com.cloud.network.dao.NetworkDaoTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec
Running com.cloud.vm.DeploymentPlanningManagerImplTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time 

RE: Simulator on master is not building

2014-07-30 Thread Santhosh Edukulla
I just logged a bug for the same.

https://issues.apache.org/jira/browse/CLOUDSTACK-7204 

Santhosh

From: Santhosh Edukulla
Sent: Wednesday, July 30, 2014 5:56 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building

I believe for every check-in we decided to run sanity tests on simulator 
atleast, currently build for simulator is failing.

 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation 
failure:
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations


Thanks!
Santhosh

Build failed in Jenkins: cloudstack-4.4-maven-build #405

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/405/changes

Changes:

[Daan Hoogland] CLOUDSTACK-6597: Updatevm - root admin should be allowed to 
change instance name

[Daan Hoogland] CLOUDSTACK-6599: Add the column in Java upgrade path since 4.2 
already has the extract template/volume columns

--
[...truncated 528 lines...]
Tests run: 122, Failures: 0, Errors: 0, Skipped: 1

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework 4.4.1-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloudstack-framework 
---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloudstack-framework ---
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Event Notification 4.4.1-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-framework-db ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-db ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-db ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-db ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-db ---
[INFO] Compiling 43 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db/target/classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-db ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db/test/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-db ---
[INFO] Compiling 15 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-framework-db 
---
[INFO] Surefire report directory: 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db/target/surefire-reports

---
 T E S T S
---
Running com.cloud.utils.DbUtilTest
Failed to find db.properties
log4j:WARN No appenders could be found for logger 
(com.cloud.utils.db.DbProperties).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 15, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.984 sec

Results :

Tests run: 15, Failures: 0, Errors: 0, Skipped: 2

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Configuration 4.4.1-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-framework-config ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/config/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/config
 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-config ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-config ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources 

Build failed in Jenkins: cloudstack-4.4-maven-build #406

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/406/changes

Changes:

[Daan Hoogland] try-with-resource to prevent resource leaks

[Daan Hoogland] Fixed issues reported by coverity NPEs, unwritten field access 
and self assignment

[Daan Hoogland] Fix for test_01_create_volume to use the correct volume name 
for KVM

--
[...truncated 528 lines...]
Tests run: 122, Failures: 0, Errors: 0, Skipped: 1

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework 4.4.1-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloudstack-framework 
---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloudstack-framework ---
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Event Notification 4.4.1-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-framework-db ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-db ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-db ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-db ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-db ---
[INFO] Compiling 43 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db/target/classes
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-db ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db/test/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-db ---
[INFO] Compiling 15 source files to 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-framework-db 
---
[INFO] Surefire report directory: 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/db/target/surefire-reports

---
 T E S T S
---
Running com.cloud.utils.DbUtilTest
Failed to find db.properties
log4j:WARN No appenders could be found for logger 
(com.cloud.utils.db.DbProperties).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 15, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.713 sec

Results :

Tests run: 15, Failures: 0, Errors: 0, Skipped: 2

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Configuration 4.4.1-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-framework-config ---
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/config/target
 (includes = [**/*], excludes = [])
[INFO] Deleting 
http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/ws/framework/config
 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-config ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-config ---
[INFO] 
[INFO] --- 

Re: Review Request 22256: CLOUDSTACK-6830 :[hyper-v] fixed vm migration failing between different clusters if volumes are on zone wide primary store

2014-07-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22256/#review49098
---


Commit 8b9166ae0bf437f35bf51dfb8dcfda3e4835a8ee in cloudstack's branch 
refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8b9166a ]

CLOUDSTACK-6830: Fixed [hyper-v] during VM migration, volumes on zone wide 
primary
store requires storage migration resulting in failure of VM migration. This also
improves the hostsformigration api. Firstly we were trying to list all hosts and
then finding suitable storage pools for all volumes and then we were checking
whether vm migration requires storage migration to that host. Now the process is
updated. We are checking for only those volumes which are not in zone wide 
primary
store. We are verifying by comparing volumes-poolid-clusterid to host 
clusterid.
If it uses local or clusterids are different then verifying whether host has
suitable storage pools for the volume of the vm to be migrated too.

(cherry picked from commit 64153a43711420224655bfbe248b4b87474a1f23)


- ASF Subversion and Git Services


On June 20, 2014, 10:21 a.m., Anshul Gangwar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22256/
 ---
 
 (Updated June 20, 2014, 10:21 a.m.)
 
 
 Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh 
 Chodapuneedi.
 
 
 Bugs: CLOUDSTACK-6830
 https://issues.apache.org/jira/browse/CLOUDSTACK-6830
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 fixed vm migration failing between different clusters if volumes are on zone 
 primary store. During VM migration, volumes on zone wide primary store 
 requiring storage migration resulting in failure of VM migration
 
 This also improves the hostsformigration api. Firstly we were ttrying to 
 list all hosts and then finding suitable storage pools for all volumes
 and then we were checking for whether vm migration requires storage 
 migration
 Now the process is reversed, We are checking for only those volumes which 
 are not in zone wide primary store and only verifying
 that volumes-poolid-clusterid is different from host clusterid and 
 usesLocal then only it requires storage migration
 
 
 Diffs
 -
 
   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
 4502365 
   server/src/com/cloud/server/ManagementServerImpl.java dd4ce0f 
 
 Diff: https://reviews.apache.org/r/22256/diff/
 
 
 Testing
 ---
 
 tested following scenarios on my local setup.
 1. VM migration for volumes on zone wide primary store is working fine
 2. VM migration for volumes on cluster wide primary store is working fine
 3. VM migration for volumes on local storage is working fine
 
 
 Thanks,
 
 Anshul Gangwar
 




Jenkins build is back to normal : cloudstack-4.4-maven-build #407

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/407/changes



Review Request 24096: CLOUDSTACK-7205: Passing expunge=True while deleting VMs to speed up test case execution

2014-07-30 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24096/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7205
https://issues.apache.org/jira/browse/CLOUDSTACK-7205


Repository: cloudstack-git


Description
---

Passing expunge=True will ensure immediate expunging of VM, so that we don't 
have to wait till it gets expunged. This will increase the execution speed of 
test cases.


Diffs
-

  test/integration/component/test_brocade_vcs.py 556de28 
  test/integration/component/test_eip_elb.py 0613c4d 
  test/integration/component/test_escalations_networks.py 2bf5735 
  test/integration/component/test_multiple_ips_per_nic.py 570ddd2 
  test/integration/component/test_nuage_vsp.py 143fe39 
  test/integration/component/test_persistent_networks.py 016a391 
  test/integration/component/test_project_resources.py 4f61cb0 
  test/integration/component/test_project_usage.py e8ed1b1 
  test/integration/component/test_reset_ssh_keypair.py d0ddb18 
  test/integration/component/test_security_groups.py 6343613 
  test/integration/component/test_usage.py fe80da7 
  test/integration/component/test_vm_passwdenabled.py 2f68257 

Diff: https://reviews.apache.org/r/24096/diff/


Testing
---

Yes


Thanks,

Gaurav Aradhye



Re: 4.4-forward picked empty

2014-07-30 Thread Rajani Karuturi
Hi Daan,

commit 2ab7bcade2f37cb17e071a6154fdae1d80e4ff99
Author: Rajani Karuturi 
rajanikarut...@gmail.commailto:rajanikarut...@gmail.com
Date:   Fri May 23 15:50:06 2014 +0530

   Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in
deleted ip range


This is same as df42ce903d399cf30055e55bc24b84fbc0b563a9 on 4.4

commit d511847cfedad5478d1b4087c8f97be2c5bf3cc8
Author: Rajani Karuturi 
rajanikarut...@gmail.commailto:rajanikarut...@gmail.com
Date:   Tue Jun 3 16:11:01 2014 +0530

   Fixed Resource leak (RESOURCE_LEAK) 11. overwrite_var: Overwriting
pstmt in pstmt = conn.prepareStatement(INSERT INTO
`cloud`.`ldap_configuration`(hostname, po

   Signed-off-by: Koushik Das kous...@apache.orgmailto:kous...@apache.org

Can be ignored. Fixes are already there.

~ Rajani


Re: Review Request 24098: CLOUDSTACK-6873: Removing BugId from test cases to enable them

2014-07-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24098/#review49101
---


Commit e1be035870d6b40285166e0ae0633e39509662c0 in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e1be035 ]

CLOUDSTACK-6873: Removing BugId from tests


- ASF Subversion and Git Services


On July 30, 2014, 12:22 p.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/24098/
 ---
 
 (Updated July 30, 2014, 12:22 p.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-6873
 https://issues.apache.org/jira/browse/CLOUDSTACK-6873
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Removing BugId from test cases to monitor results in next run.
 
 
 Diffs
 -
 
   test/integration/smoke/test_deploy_vm.py 0810752 
 
 Diff: https://reviews.apache.org/r/24098/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Gaurav Aradhye
 




OVS with VLANS: migration impossible

2014-07-30 Thread Claus Kalle
Hi, I am testing a setup where OVS is in use with VLANs as separation
between isolated networks for guests.
Whene I try to migrate such a guest from one host to another (both share
the same VLAN set by the same trunk=.. list) I get the message:

Unable to migrate due to Unable to add port vnet0 to OVS bridge
cloudbr0: Operation not permitted

Seems that VLANs are no longer very useful with OVS installed in the KVM
hosts Am I right?

Best, Claus
-- 
Claus Kalle, Universitaet zu Koeln, RRZK   i   i
 Leiter Abteilung Systeme  I   I
 E-Mail: ka...@uni-koeln.deM   M
 Fon: 0221 470 89581  /I\
 Fax: 0221 470 89625  MiMiMiM
 Snail-Mail: Weyertal 121, 50931 KoelnMIMiMiM


Review Request 24102: Fixing missing attribute issue in test_stopped_vm.py

2014-07-30 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24102/
---

Review request for cloudstack and Girish Shilamkar.


Repository: cloudstack-git


Description
---

Fixing missing attribute error.


Diffs
-

  test/integration/component/test_stopped_vm.py 5eec405 

Diff: https://reviews.apache.org/r/24102/diff/


Testing
---

Yes.


Thanks,

Gaurav Aradhye



Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind (for 4.5)

2014-07-30 Thread Daniel Vega Simões
Hi guys,

Since nobody was opposed to the approach suggested in the last e-mail, we
went on and implemented the global option that authorizes the plugin to
override record entries when they already exist in the DNS server.

We also updated the name to GloboDNS and the functional spec to reflect
both changes. You can take a look at the table that summarizes the actions
for the GloboDNS plugin on the wiki
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Bind+and+PowerDNS+integration+by+Globo+DNSAPI.
Unit tests were implemented to make sure all of these cases behave as
expected.

Please let me know how we can move forward to integrate this in the
Cloudstack repository.


Cheers,

--
Daniel Simões
Time Evolução Infra - Globo.com
E-mail: daniel.sim...@corp.globo.com
Tel.: +55 21 2483-6977


2014-07-14 16:41 GMT-03:00 Daniel Vega Simões daniel.sim...@corp.globo.com
:

 Hi guys,

 @David
 As Silvano mentioned earlier, our cloud-related DNS have unique names
 (based on network info), so conflicts do not happen. As such, these domains
 are exclusive to our cloud infrastructure and we let Cloudstack have full
 authority over them. For that reason, whenever a network is deleted, the
 domain associated to it is removed, along with every record in it.


 @Chiradeep
 If a domain already exists when a network is created, the plugin takes
 over that domain, creating and removing records as needed. It does not
 handle any records created externally. The only exception is when the
 domain is removed, as explained just above.

 Secondary IPs are currently not handled by the plugin, since we understand
 that once that IP is reserved by Cloudstack, routing and name resolution
 should be done manually by the operator.

 As for the name, GloboDNS sounds about right :) We'll make the appropriate
 changes to avoid confusion.



 This is what makes sense for us in this first release. Implementing every
 option available to the operator might make the plugin configuration very
 confusing.

 A simpler approach would be to create one single global/zone option that
 allows Cloudstack to have full authority over domains/records or not. In
 the case where Cloudstack does not have authority, an error could be thrown
 if the domain/record already exists and domains are never removed by the
 plugin itself, so an operator would need to do it manually (or by means of
 another tool).


 What do you think?


  --
 Daniel Simões
 Time Evolução Infra - Globo.com
 E-mail: daniel.sim...@corp.globo.com
 Tel.: +55 21 2483-6977


 2014-07-14 14:20 GMT-03:00 Chiradeep Vittal chiradeep.vit...@citrix.com:

 I think the question is relevant to network creation as well. If I provide
 a domain that already exists, what is the result?

 A couple of other comments:
  - are we going to handle the case of secondary IP addresses?
  - DNSAPI sounds generic, but it actually refers to one specific API
 architected by Globo. To avoid confusion, would it make sense to rename it
 GloboDNSAPI? Alternately, give the DNSAPI project a less generic name
 (e.g., vincular)

 From: David Nalley da...@gnsa.usmailto:da...@gnsa.us
 Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
 Date: Friday, July 11, 2014 at 10:06 AM
 To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
 Subject: Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind
 (for 4.5)

 I tend to agree with Erik, flexibility solves the problem for more
 people, while solution 1 is likely the easiest to implement. I am not
 sure that it makes sense for most people though - and would really
 only work for greenfield deployments or clouds that had all of the DNS
 entries relating to instances in the cloud.

 First question; how are you intending on using it? Which of those
 solutions works for you?

 --David



 On Thu, Jul 3, 2014 at 3:49 PM, Erik Weber terbol...@gmail.commailto:
 terbol...@gmail.com wrote:
 To push that choice over to the operator you could add it as a
 global/zone/network option.

 As an operator i would prefer to have my own logic to handle cleanup, but
 this varies for everyone hence the option :-)

 Erik
 3. juli 2014 21:45 skrev Silvano Nogueira Buback 
 silv...@corp.globo.commailto:silv...@corp.globo.com
 følgende:

 Hi guys,

  I think you are busy because 4.4 release tasks, but I'm worried about
 the time to 4.5 feature freeze. I put the documentation of feature in wiki
 as requested and I hoped people read there and make some comments here.

 To help, I will put design issues that are in document, one by one, and we
 can discuss in this thread. After each discussion I will change the
 document.

 I have one question about removing DNS domain when network has been
 deleted. In my current implementation I remove DNS domain when network is
 removed. But if the DNS domain is shared with another network or maybe is
 a
 dns 

Review Request 24103: Fixed test_escalations_instances.py - Stop VM before detaching root volumes

2014-07-30 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24103/
---

Review request for cloudstack and Girish Shilamkar.


Repository: cloudstack-git


Description
---

VM was not stopped while detaching all volumes attached to it. This threw error 
while detaching the root volume.
Added step to stop the VM before detach operation.


Diffs
-

  test/integration/component/test_escalations_instances.py ef939f1 

Diff: https://reviews.apache.org/r/24103/diff/


Testing
---

Yes.


Thanks,

Gaurav Aradhye



Re: multiple primary storage

2014-07-30 Thread Mike Tutkowski
Clustered LVM is a set of clustering extensions to LVM. This allows a set
of compute nodes (in this case, XenServer hosts) to manage shared storage
using LVM.

LVM:

http://en.wikipedia.org/wiki/Logical_Volume_Manager_(Linux)

If you create a volume on a SAN that's accessible via iSCSI and create a
XenServer shared SR for it, XenServer will apply CLVM to the SAN volume
(you don't have to do anything in particular for this to happen when you
create a shared iSCSI SR).

I believe you should be able to migrate a CloudStack volume from an NFS SR
to an iSCSI SR.


On Tue, Jul 29, 2014 at 9:11 PM, Tejas Gadaria refond.g...@gmail.com
wrote:

 Hi,
 I am using ACS 4.3 with xenserver 6.2
 I have one primary storage as nfs, can i add another one as iscsi and
 migrate vms (storage migration) from one primary storage to another one. ?

 Also as per cloudstack Doc,  iscsi supports Clustered LVM  on Xenserver 
 What does it mean.

 Regards,
 Tejas




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*


Review Request 24104: Fixing test_escalations_ipaddresses.py - Passing type Isolated while listing Networks to avoid inclusion of shared networks in the list

2014-07-30 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24104/
---

Review request for cloudstack and Girish Shilamkar.


Repository: cloudstack-git


Description
---

Network.list was also listing the shared network already prese.t Hence it was 
failing while asserrting the number of networks in the accountdomain.
Passing netwoktype as Isolated to get the correct number of Networks as we are 
not creating any shared network through the test.


Diffs
-

  test/integration/component/test_escalations_ipaddresses.py 411dae0 

Diff: https://reviews.apache.org/r/24104/diff/


Testing
---

Yes.


Thanks,

Gaurav Aradhye



Re: 4.4-forward usage

2014-07-30 Thread Rohit Yadav
Hi Daan,


On 24-Jul-2014, at 6:20 pm, Daan Hoogland daan.hoogl...@gmail.com wrote:

 People (especially test developers),

 please stop using 4.4-forward and switch to 4.4

 If we do a code freeze for 4.4.1 make a new branch per fix, the model
 of a -forward branch is fundamentally broken and has cost me a few
 hours of merge trouble over the past two months.

Since we’re discussing about fixing our git based workflow can we conclude that 
we should be using the -forward branch in future from now onwards?

So, we work until a release is done (by a tag) and keep working on the same 
branch instead of a -forward and then cherry-pick, merge it back again to the 
parent release branch?

Regards.


 thanks,
 --
 Daan

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +41 779015219 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design  Buildhttp://shapeblue.com/iaas-cloud-design-and-build//
CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/
CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: Review Request 24104: Fixing test_escalations_ipaddresses.py - Passing type Isolated while listing Networks to avoid inclusion of shared networks in the list

2014-07-30 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24104/
---

(Updated July 30, 2014, 9:28 p.m.)


Review request for cloudstack and Girish Shilamkar.


Changes
---

updated patch with two more test suites requiring same changes.


Repository: cloudstack-git


Description
---

Network.list was also listing the shared network already prese.t Hence it was 
failing while asserrting the number of networks in the accountdomain.
Passing netwoktype as Isolated to get the correct number of Networks as we are 
not creating any shared network through the test.


Diffs (updated)
-

  test/integration/component/test_escalations_instances.py ef939f1 
  test/integration/component/test_escalations_ipaddresses.py 411dae0 
  test/integration/component/test_escalations_networks.py 2bf5735 

Diff: https://reviews.apache.org/r/24104/diff/


Testing
---

Yes.


Thanks,

Gaurav Aradhye



Re: 4.4-forward usage

2014-07-30 Thread Daan Hoogland
Well Rohit,

I was thinking we should not use 4.4-forward anymore at all (or create
a new one) Merging back from it at the moment costs to much conflicts.

I'd say we work on branches taken from 4.4 on a per fix basis and
merge those that are proven.

makes sense?

On Wed, Jul 30, 2014 at 5:37 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote:
 Hi Daan,


 On 24-Jul-2014, at 6:20 pm, Daan Hoogland daan.hoogl...@gmail.com wrote:

 People (especially test developers),

 please stop using 4.4-forward and switch to 4.4

 If we do a code freeze for 4.4.1 make a new branch per fix, the model
 of a -forward branch is fundamentally broken and has cost me a few
 hours of merge trouble over the past two months.

 Since we’re discussing about fixing our git based workflow can we conclude 
 that we should be using the -forward branch in future from now onwards?

 So, we work until a release is done (by a tag) and keep working on the same 
 branch instead of a -forward and then cherry-pick, merge it back again to the 
 parent release branch?

 Regards.


 thanks,
 --
 Daan

 Regards,
 Rohit Yadav
 Software Architect, ShapeBlue
 M. +41 779015219 | rohit.ya...@shapeblue.com
 Blog: bhaisaab.org | Twitter: @_bhaisaab




 Find out more about ShapeBlue and our range of CloudStack related services

 IaaS Cloud Design  Buildhttp://shapeblue.com/iaas-cloud-design-and-build//
 CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
 CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
 CloudStack Infrastructure 
 Supporthttp://shapeblue.com/cloudstack-infrastructure-support/
 CloudStack Bootcamp Training 
 Courseshttp://shapeblue.com/cloudstack-training/

 This email and any attachments to it may be confidential and are intended 
 solely for the use of the individual to whom it is addressed. Any views or 
 opinions expressed are solely those of the author and do not necessarily 
 represent those of Shape Blue Ltd or related companies. If you are not the 
 intended recipient of this email, you must neither take any action based upon 
 its contents, nor copy or show it to anyone. Please contact the sender if you 
 believe you have received this email in error. Shape Blue Ltd is a company 
 incorporated in England  Wales. ShapeBlue Services India LLP is a company 
 incorporated in India and is operated under license from Shape Blue Ltd. 
 Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
 operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
 registered by The Republic of South Africa and is traded under license from 
 Shape Blue Ltd. ShapeBlue is a registered trademark.



-- 
Daan


Re: Review Request 24096: CLOUDSTACK-7205: Passing expunge=True while deleting VMs to speed up test case execution

2014-07-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24096/#review49113
---


Commit 42a861e5908b110bbb41145b09394bd86ef318e1 in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=42a861e ]

CLOUDSTACK-7205: Adding expunge=True while deleting VM for test case execution 
speed improvement


- ASF Subversion and Git Services


On July 30, 2014, 11:34 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/24096/
 ---
 
 (Updated July 30, 2014, 11:34 a.m.)
 
 
 Review request for cloudstack and Girish Shilamkar.
 
 
 Bugs: CLOUDSTACK-7205
 https://issues.apache.org/jira/browse/CLOUDSTACK-7205
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Passing expunge=True will ensure immediate expunging of VM, so that we don't 
 have to wait till it gets expunged. This will increase the execution speed of 
 test cases.
 
 
 Diffs
 -
 
   test/integration/component/test_brocade_vcs.py 556de28 
   test/integration/component/test_eip_elb.py 0613c4d 
   test/integration/component/test_escalations_networks.py 2bf5735 
   test/integration/component/test_multiple_ips_per_nic.py 570ddd2 
   test/integration/component/test_nuage_vsp.py 143fe39 
   test/integration/component/test_persistent_networks.py 016a391 
   test/integration/component/test_project_resources.py 4f61cb0 
   test/integration/component/test_project_usage.py e8ed1b1 
   test/integration/component/test_reset_ssh_keypair.py d0ddb18 
   test/integration/component/test_security_groups.py 6343613 
   test/integration/component/test_usage.py fe80da7 
   test/integration/component/test_vm_passwdenabled.py 2f68257 
 
 Diff: https://reviews.apache.org/r/24096/diff/
 
 
 Testing
 ---
 
 Yes
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: 4.4-forward usage

2014-07-30 Thread Rohit Yadav

On 30-Jul-2014, at 6:11 pm, Daan Hoogland daan.hoogl...@gmail.com wrote:

 Well Rohit,

 I was thinking we should not use 4.4-forward anymore at all (or create
 a new one) Merging back from it at the moment costs to much conflicts.

 I'd say we work on branches taken from 4.4 on a per fix basis and
 merge those that are proven.

 makes sense?

Yes :)

I was asking if we’ll have future -forward branches such as 4.5-forward, 
5.0-forward etc or we will never see that kind of workflow again?

Regards.


 On Wed, Jul 30, 2014 at 5:37 PM, Rohit Yadav rohit.ya...@shapeblue.com 
 wrote:
 Hi Daan,


 On 24-Jul-2014, at 6:20 pm, Daan Hoogland daan.hoogl...@gmail.com wrote:

 People (especially test developers),

 please stop using 4.4-forward and switch to 4.4

 If we do a code freeze for 4.4.1 make a new branch per fix, the model
 of a -forward branch is fundamentally broken and has cost me a few
 hours of merge trouble over the past two months.

 Since we’re discussing about fixing our git based workflow can we conclude 
 that we should be using the -forward branch in future from now onwards?

 So, we work until a release is done (by a tag) and keep working on the same 
 branch instead of a -forward and then cherry-pick, merge it back again to 
 the parent release branch?

 Regards.


 thanks,
 --
 Daan

 Regards,
 Rohit Yadav
 Software Architect, ShapeBlue
 M. +41 779015219 | rohit.ya...@shapeblue.com
 Blog: bhaisaab.org | Twitter: @_bhaisaab




 Find out more about ShapeBlue and our range of CloudStack related services

 IaaS Cloud Design  Buildhttp://shapeblue.com/iaas-cloud-design-and-build//
 CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
 CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
 CloudStack Infrastructure 
 Supporthttp://shapeblue.com/cloudstack-infrastructure-support/
 CloudStack Bootcamp Training 
 Courseshttp://shapeblue.com/cloudstack-training/

 This email and any attachments to it may be confidential and are intended 
 solely for the use of the individual to whom it is addressed. Any views or 
 opinions expressed are solely those of the author and do not necessarily 
 represent those of Shape Blue Ltd or related companies. If you are not the 
 intended recipient of this email, you must neither take any action based 
 upon its contents, nor copy or show it to anyone. Please contact the sender 
 if you believe you have received this email in error. Shape Blue Ltd is a 
 company incorporated in England  Wales. ShapeBlue Services India LLP is a 
 company incorporated in India and is operated under license from Shape Blue 
 Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil 
 and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a 
 company registered by The Republic of South Africa and is traded under 
 license from Shape Blue Ltd. ShapeBlue is a registered trademark.



 --
 Daan

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +41 779015219 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design  Buildhttp://shapeblue.com/iaas-cloud-design-and-build//
CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
CloudStack Infrastructure 
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/
CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England  Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.


Build failed in Jenkins: build-master-noredist #3191

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master-noredist/3191/

--
[...truncated 1799 lines...]
log4j:WARN No appenders could be found for logger 
(com.cloud.event.EventControlsUnitTest).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.548 sec
Running com.cloud.keystore.KeystoreTest
org.apache.cloudstack.api.response.UserVmResponse/null/{id:3,securitygroup:[],nic:[],tags:[],affinitygroup:[]}
org.apache.cloudstack.api.response.AlertResponse/null/{id:100,description:Hello}
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.187 sec
Running com.cloud.alert.AlertControlsUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.041 sec
Running com.cloud.capacity.CapacityManagerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.127 sec
Running com.cloud.servlet.StaticResourceServletTest
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.148 sec
Running com.cloud.servlet.ConsoleProxyServletTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec
Running com.cloud.resourcelimit.ResourceLimitManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec
Running com.cloud.network.firewall.FirewallManagerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.001 sec
Running com.cloud.network.ExternalLoadBalancerDeviceManagerImplTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.589 sec
Running com.cloud.network.element.VirtualRouterElementTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.668 sec
Running com.cloud.network.UpdatePhysicalNetworkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.146 sec
Running com.cloud.network.CreatePrivateNetworkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec
Running com.cloud.network.NetworkModelTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.025 sec
Running com.cloud.network.router.VirtualNetworkApplianceManagerImplTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.052 sec
Running com.cloud.network.security.SecurityGroupManagerImplTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.832 sec
Running com.cloud.network.security.SecurityGroupQueueTest
Total jobs dequeued = 10, num queued=1002 queue current size=992
Num Vms= 50 Queue size = 50
Num Vms= 2 Queue size = 2 time=1067 ms
Num Vms= 5000 Queue size = 5000 time=638 ms
Num Vms= 1 Queue size = 1 time=0 ms
Num Vms= 100 Queue size = 100 time=1384 ms
Total jobs dequeued = 10, num queued=1010 queue current size=1000
Total jobs dequeued = 1, num queued=1001 queue current size=1000
Total jobs dequeued = 10, num queued=1000 queue current size=990
Total jobs dequeued = 10, num queued=10 queue current size=0
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.994 sec  
FAILURE!
Running com.cloud.network.vpc.VpcManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec
Running com.cloud.network.DedicateGuestVlanRangesTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.028 sec
Running com.cloud.network.lb.AssignLoadBalancerTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.072 sec
Running com.cloud.network.dao.NetworkDaoTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec
Running com.cloud.vm.DeploymentPlanningManagerImplTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.835 sec
Running com.cloud.vm.snapshot.VMSnapshotManagerTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.222 sec
Running com.cloud.vm.UserVmManagerTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.222 sec
Running com.cloud.configuration.ValidateIpRangeTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.029 sec
Running com.cloud.configuration.ConfigurationManagerTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
Running com.cloud.server.ConfigurationServerImplTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.028 sec
Running com.cloud.template.TemplateManagerImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec
Running com.cloud.vpc.Site2SiteVpnTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.039 sec
Running com.cloud.vpc.NetworkACLServiceTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.175 sec
Running com.cloud.vpc.NetworkACLManagerTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.217 sec
Running com.cloud.storage.VolumeApiServiceImplTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.114 sec
Running 

RE: building cloudstack

2014-07-30 Thread Elapavuluri, Jaya
I am getting the same error after throwing away the .m2 folder. 

It complains about resolving the dependencies for 4.4.1. Is there any other way 
I could go back? 

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Wednesday, July 30, 2014 3:28 AM
To: dev
Subject: Re: building cloudstack

did you run
$ git pull
$ mvn clean test install
before that?

if so you could try thowing away your ~/.m2/repositories dir.

On Wed, Jul 30, 2014 at 1:50 AM, Elapavuluri, Jaya 
jaya.elapavul...@netapp.com wrote:
 So this is the screen shot of the error I am getting.



 This was after trying to start the management server mvn -pl 
 :cloud-client-ui jetty:run -Dnoredist





 [INFO]
 --
 --

 [ERROR] Failed to execute goal on project cloud-client-ui: Could not 
 resolve dependencies for project
 org.apache.cloudstack:cloud-client-ui:war:4.4.1-SNAPSHOT: The 
 following artifacts could not be resolved:
 org.apache.cloudstack:cloud-plugin-netapp:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-network-f5:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-network-srx:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-hypervisor-vmware:jar:4.4.1-SNAPSHO
 T, org.apache.cloudstack:cloud-vmware-base:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-network-cisco-vnmc:jar:4.4.1-SNAPSH
 OT,
 org.apache.cloudstack:cloud-plugin-database-mysqlha:jar:4.4.1-SNAPSHOT:
 Failure to find 
 org.apache.cloudstack:cloud-plugin-netapp:jar:4.4.1-SNAPSHOT
 in http://repository.apache.org/snapshots was cached in the local 
 repository, resolution will not be reattempted until the update 
 interval of apache.snapshots has elapsed or updates are forced - 
 [Help 1]

 [ERROR]

 [ERROR] To see the full stack trace of the errors, re-run Maven with 
 the -e switch.

 [ERROR] Re-run Maven using the -X switch to enable full debug logging.

 [ERROR]

 [ERROR] For more information about the errors and possible solutions, 
 please read the following articles:

 [ERROR] [Help 1]
 http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionE
 xception









 -Original Message-
 From: Elapavuluri, Jaya [mailto:jaya.elapavul...@netapp.com]
 Sent: Tuesday, July 29, 2014 2:44 PM
 To: dev@cloudstack.apache.org
 Subject: RE: building cloudstack



 So, is there any way the bug can be fixed??



 -Original Message-

 From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]

 Sent: Monday, July 28, 2014 5:10 PM

 To: dev@cloudstack.apache.org

 Subject: Re: building cloudstack



 Hi Jaya,



 Which branch are you on? It's a bug we'll fix it by placing an empty 
 upgrade path for 4.4.1 version.



 The upgrade paths are available only between released versions only, 
 so it fails as there is no upgrade path for 4.4.1-SNAPSHOT.



 Regards.



 Elapavuluri, Jaya wrote:

 Hello,







 I had setup cloudstack 4.4 environment which was running fine.



 I recently did a git pull to get the updates after which when I tried  
 to mvn -Pdeveloper -pl developer -Ddeploydb I was encountering with 
 the following error.





 [ERROR] Failed to execute goal

 org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on

 project cloud-developer: An exception occured while executing the 
 Java

 class. null: InvocationTargetException: The end upgrade version is

 actually at 4.4.0 but our management server code version is at

 4.4.1-SNAPSHOT -  [Help 1]



 However mvn -P developer,systemvm clean install gives a build success.



 Can someone share their knowledge on this?





 --

 Rohit Yadav

 Software Architect, ShapeBlue

 M. +41 779015219 | rohit.ya...@shapeblue.com

 Blog: bhaisaab.org | Twitter: @_bhaisaab





 Find out more about ShapeBlue and our range of CloudStack related 
 services



 IaaS Cloud Design 
 Buildhttp://shapeblue.com/iaas-cloud-design-and-build//

 CSForge – rapid IaaS deployment 
 frameworkhttp://shapeblue.com/csforge/

 CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/

 CloudStack Infrastructure
 Supporthttp://shapeblue.com/cloudstack-infrastructure-support/

 CloudStack Bootcamp Training
 Courseshttp://shapeblue.com/cloudstack-training/



 This email and any attachments to it may be confidential and are 
 intended solely for the use of the individual to whom it is addressed. 
 Any views or opinions expressed are solely those of the author and do 
 not necessarily represent those of Shape Blue Ltd or related 
 companies. If you are not the intended recipient of this email, you 
 must neither take any action based upon its contents, nor copy or show 
 it to anyone. Please contact the sender if you believe you have 
 received this email in error. Shape Blue Ltd is a company incorporated 
 in England  Wales. ShapeBlue Services India LLP is a company 
 incorporated in India and is operated under license from Shape Blue 
 Ltd. Shape Blue Brasil Consultoria Ltda is a company 

RE: Simulator on master is not building

2014-07-30 Thread Anthony Xu
We used -Dsimulator to include simulator, it is very easy for developers to 
forget it.  Simulator should be built by default , we may use -Dnosimulator to 
exclude simulator.


Anthony

-Original Message-
From: Koushik Das 
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building

The simulator code should be kept up to date with any changes done in the core 
product. If there are any interface changes, necessary changes should be made 
in simulator plugin as well along with other hypervisor plugins. To build 
simulator code use refer to [1].

-Koushik

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration

-Original Message-
From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com] 
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building

I believe for every check-in we decided to run sanity tests on simulator 
atleast, currently build for simulator is failing. 

 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation 
failure:
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations [ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations


Thanks!
Santhosh


RE: Simulator on master is not building

2014-07-30 Thread Edison Su
+1, include simulator in the default build, exclude explicitly in the 
production build.

 -Original Message-
 From: Anthony Xu [mailto:xuefei...@citrix.com]
 Sent: Wednesday, July 30, 2014 10:28 AM
 To: Koushik Das; dev@cloudstack.apache.org
 Subject: RE: Simulator on master is not building
 
 We used -Dsimulator to include simulator, it is very easy for developers to
 forget it.  Simulator should be built by default , we may use -Dnosimulator to
 exclude simulator.
 
 
 Anthony
 
 -Original Message-
 From: Koushik Das
 Sent: Wednesday, July 30, 2014 3:03 AM
 To: dev@cloudstack.apache.org
 Cc: Anthony Xu
 Subject: RE: Simulator on master is not building
 
 The simulator code should be kept up to date with any changes done in the
 core product. If there are any interface changes, necessary changes should
 be made in simulator plugin as well along with other hypervisor plugins. To
 build simulator code use refer to [1].
 
 -Koushik
 
 [1]
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integr
 ation
 
 -Original Message-
 From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com]
 Sent: Wednesday, 30 July 2014 3:27 PM
 To: dev@cloudstack.apache.org
 Cc: Anthony Xu
 Subject: Simulator on master is not building
 
 I believe for every check-in we decided to run sanity tests on simulator
 atleast, currently build for simulator is failing.
 
  
 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-
 plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-
 simulator: Compilation failure: Compilation failure:
 [ERROR]
 /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
 s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations [ERROR]
 /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
 s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations
 
 
 Thanks!
 Santhosh


Jenkins build is back to normal : build-master-noredist #3192

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master-noredist/3192/changes



RE: Simulator on master is not building

2014-07-30 Thread Anthony Xu
Hi Koushik,

fixed the build for simulator.

I just found out Simulator use its own VOes for some VOes, it may not be easy 
for developer to add feature for simulator if the feature needs to change VO, 
for example, the new VMsync logic, I don't think simulator test the new VMsync 
logic. 

If we consider Simulator as a hypervisor, ideally it should use the same VOes 
as other hypersivors. Can you help us understand what's the reason behind this?

Thanks
Anthony







./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVMVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecStorageVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVolumeVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockStoragePoolVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockHostVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockConfigurationVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecurityRulesVO.java





-Original Message-
From: Anthony Xu 
Sent: Wednesday, July 30, 2014 10:28 AM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building

We used -Dsimulator to include simulator, it is very easy for developers to 
forget it.  Simulator should be built by default , we may use -Dnosimulator to 
exclude simulator.


Anthony

-Original Message-
From: Koushik Das 
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building

The simulator code should be kept up to date with any changes done in the core 
product. If there are any interface changes, necessary changes should be made 
in simulator plugin as well along with other hypervisor plugins. To build 
simulator code use refer to [1].

-Koushik

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration

-Original Message-
From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com] 
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building

I believe for every check-in we decided to run sanity tests on simulator 
atleast, currently build for simulator is failing. 

 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation 
failure:
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations [ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations


Thanks!
Santhosh


Re: 4.4-forward usage

2014-07-30 Thread Mike Tutkowski
My understanding is that the -forward concept goes away after 4.4.1.

On Wednesday, July 30, 2014, Rohit Yadav rohit.ya...@shapeblue.com wrote:


 On 30-Jul-2014, at 6:11 pm, Daan Hoogland daan.hoogl...@gmail.com
 javascript:; wrote:

  Well Rohit,
 
  I was thinking we should not use 4.4-forward anymore at all (or create
  a new one) Merging back from it at the moment costs to much conflicts.
 
  I'd say we work on branches taken from 4.4 on a per fix basis and
  merge those that are proven.
 
  makes sense?

 Yes :)

 I was asking if we’ll have future -forward branches such as 4.5-forward,
 5.0-forward etc or we will never see that kind of workflow again?

 Regards.

 
  On Wed, Jul 30, 2014 at 5:37 PM, Rohit Yadav rohit.ya...@shapeblue.com
 javascript:; wrote:
  Hi Daan,
 
 
  On 24-Jul-2014, at 6:20 pm, Daan Hoogland daan.hoogl...@gmail.com
 javascript:; wrote:
 
  People (especially test developers),
 
  please stop using 4.4-forward and switch to 4.4
 
  If we do a code freeze for 4.4.1 make a new branch per fix, the model
  of a -forward branch is fundamentally broken and has cost me a few
  hours of merge trouble over the past two months.
 
  Since we’re discussing about fixing our git based workflow can we
 conclude that we should be using the -forward branch in future from now
 onwards?
 
  So, we work until a release is done (by a tag) and keep working on the
 same branch instead of a -forward and then cherry-pick, merge it back again
 to the parent release branch?
 
  Regards.
 
 
  thanks,
  --
  Daan
 
  Regards,
  Rohit Yadav
  Software Architect, ShapeBlue
  M. +41 779015219 | rohit.ya...@shapeblue.com javascript:;
  Blog: bhaisaab.org | Twitter: @_bhaisaab
 
 
 
 
  Find out more about ShapeBlue and our range of CloudStack related
 services
 
  IaaS Cloud Design  Build
 http://shapeblue.com/iaas-cloud-design-and-build//
  CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
 
  CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
  CloudStack Infrastructure Support
 http://shapeblue.com/cloudstack-infrastructure-support/
  CloudStack Bootcamp Training Courses
 http://shapeblue.com/cloudstack-training/
 
  This email and any attachments to it may be confidential and are
 intended solely for the use of the individual to whom it is addressed. Any
 views or opinions expressed are solely those of the author and do not
 necessarily represent those of Shape Blue Ltd or related companies. If you
 are not the intended recipient of this email, you must neither take any
 action based upon its contents, nor copy or show it to anyone. Please
 contact the sender if you believe you have received this email in error.
 Shape Blue Ltd is a company incorporated in England  Wales. ShapeBlue
 Services India LLP is a company incorporated in India and is operated under
 license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a
 company incorporated in Brasil and is operated under license from Shape
 Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of
 South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is
 a registered trademark.
 
 
 
  --
  Daan

 Regards,
 Rohit Yadav
 Software Architect, ShapeBlue
 M. +41 779015219 | rohit.ya...@shapeblue.com javascript:;
 Blog: bhaisaab.org | Twitter: @_bhaisaab




 Find out more about ShapeBlue and our range of CloudStack related services

 IaaS Cloud Design  Build
 http://shapeblue.com/iaas-cloud-design-and-build//
 CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
 CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
 CloudStack Infrastructure Support
 http://shapeblue.com/cloudstack-infrastructure-support/
 CloudStack Bootcamp Training Courses
 http://shapeblue.com/cloudstack-training/

 This email and any attachments to it may be confidential and are intended
 solely for the use of the individual to whom it is addressed. Any views or
 opinions expressed are solely those of the author and do not necessarily
 represent those of Shape Blue Ltd or related companies. If you are not the
 intended recipient of this email, you must neither take any action based
 upon its contents, nor copy or show it to anyone. Please contact the sender
 if you believe you have received this email in error. Shape Blue Ltd is a
 company incorporated in England  Wales. ShapeBlue Services India LLP is a
 company incorporated in India and is operated under license from Shape Blue
 Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
 and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
 a company registered by The Republic of South Africa and is traded under
 license from Shape Blue Ltd. ShapeBlue is a registered trademark.



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
http://solidfire.com/solution/overview/?video=play*™*


[acs44] systemvm64template-4.4.0-6-{xenserver|kvm}: update

2014-07-30 Thread Pierre-Luc Dion
Daan,

We made few tests with version 6 of  4.4.0 system vms for xenserver and
kvm. So far so good! fresh install of 4.4 with those templates work fine so
far, not issues as earlier this week.

So, the install doc is updated to use those templates.

I'm validating the upgrade path from 4.2.1 then update the release-notes
soon.

thanks,


*Pierre-Luc DION*
Architecte de Solution Cloud | Cloud Solutions Architect
t 855.652.5683

*CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_


Review Request 24111: Coverity findings for brocade-plugin

2014-07-30 Thread Ritu Sabharwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24111/
---

Review request for cloudstack and Hugo Trippaers.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

Fixed Coverity findings for brocade-plugin


Diffs
-

  
plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
 60edbcf 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 d5f06f8 

Diff: https://reviews.apache.org/r/24111/diff/


Testing
---


Thanks,

Ritu  Sabharwal



RE: New Defects reported by Coverity Scan for cloudstack

2014-07-30 Thread Ritu Sabharwal
Hi Hugo,

I have created a separate review request based on current master.

The review request is: https://reviews.apache.org/r/24111/


Thanks  Regards,
Ritu S.

From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Tuesday, July 29, 2014 11:09 PM
To: Ritu Sabharwal
Cc: dev@cloudstack.apache.org; Santhosh Edukulla
Subject: Re: New Defects reported by Coverity Scan for cloudstack

Hey Ritu,

Thanks! Could you post the patch as a separate review? That way it will be a 
lot easier for me to merge the changes.

The easiest way to do it is to base the new patch on the current state of the 
master branch.

Cheers,

Hugo


On 29 jul. 2014, at 22:32, Ritu Sabharwal 
rsabh...@brocade.commailto:rsabh...@brocade.com wrote:


Hi Hugo,

I have fixed the reported findings and posted the patch on review board.

Thanks  Regards,
Ritu S.

From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Tuesday, July 29, 2014 6:41 AM
To: Ritu Sabharwal
Cc: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org; Santhosh 
Edukulla
Subject: Fwd: New Defects reported by Coverity Scan for cloudstack

Ritu,

Coverity identified a number of issues with the brocade plugin. Could you have 
a look at them and post the fixes on the review board?


If you need additional details on the findings you can request coverity access 
here : https://scan.coverity.com/projects/943

Cheers,

Hugo


Begin forwarded message:



From: scan-ad...@coverity.commailto:scan-ad...@coverity.com
Subject: New Defects reported by Coverity Scan for cloudstack
Date: 29 juli 2014 15:22:48 CEST


Hi,


Please find the latest report on new defect(s) introduced to cloudstack found 
with Coverity Scan.

Defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)


** CID 1229114:  Resource leak  (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 509 in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 513 in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()

** CID 1229113:  Resource leak  (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 457 in 
com.cloud.network.brocade.BrocadeVcsApi.executeRetreiveStatus(java.lang.String)()

** CID 1229115:  Dereference before null check  (REVERSE_INULL)
/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
 6299 in 
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.execute(com.cloud.agent.api.CreateVMSnapshotCommand)()

** CID 1229121:  UrF: Unread field  (FB.URF_UNREAD_FIELD)
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 67 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 71 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 55 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 59 in ()
/plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java:
 63 in ()

** CID 1229120:  WMI: Inefficient Map Iterator  (FB.WMI_WRONG_MAP_ITERATOR)
/engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java: 478 in 
com.cloud.capacity.dao.CapacityDaoImpl.findCapacityBy(java.lang.Integer, 
java.lang.Long, java.lang.Long, java.lang.Long)()

** CID 1229119:  DLS: Dead local store  (FB.DLS_DEAD_LOCAL_STORE)
/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
 4438 in 
com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.initialize()()

** CID 1229116:  REC: RuntimeException capture  (FB.REC_CATCH_EXCEPTION)
/engine/schema/src/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java: 189 in 
com.cloud.storage.dao.VMTemplatePoolDaoImpl.listByTemplateStatus(long, long, 
long, com.cloud.storage.VMTemplateStorageResourceAssoc$Status)()



*** CID 1229114:  Resource leak  (RESOURCE_LEAK)
/plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java:
 509 in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(org.apache.http.HttpResponse)()
503 try {
504
505 BufferedReader rd = new BufferedReader(new 
InputStreamReader(response.getEntity().getContent(), Charset.forName(UTF-8)));
506
507 StringBuffer result = new StringBuffer();
508 String line = ;


   CID 1229114:  Resource leak  (RESOURCE_LEAK)
   Variable rd going out of scope leaks the resource it refers to.
509 while ((line = rd.readLine()) != null) {
510 result.append(line);

Re: 4.4-forward usage

2014-07-30 Thread Sebastien Goasguen

On Jul 30, 2014, at 2:38 PM, Mike Tutkowski mike.tutkow...@solidfire.com 
wrote:

 My understanding is that the -forward concept goes away after 4.4.1.
 

yes +1

instead of asking for a cherry-pick from -forward, folks should ask the RM  to 
merge from their cloudstack-WXYZ branch
and merge it in other needed branches (master and develop)


 On Wednesday, July 30, 2014, Rohit Yadav rohit.ya...@shapeblue.com wrote:
 
 
 On 30-Jul-2014, at 6:11 pm, Daan Hoogland daan.hoogl...@gmail.com
 javascript:; wrote:
 
 Well Rohit,
 
 I was thinking we should not use 4.4-forward anymore at all (or create
 a new one) Merging back from it at the moment costs to much conflicts.
 
 I'd say we work on branches taken from 4.4 on a per fix basis and
 merge those that are proven.
 
 makes sense?
 
 Yes :)
 
 I was asking if we’ll have future -forward branches such as 4.5-forward,
 5.0-forward etc or we will never see that kind of workflow again?
 
 Regards.
 
 
 On Wed, Jul 30, 2014 at 5:37 PM, Rohit Yadav rohit.ya...@shapeblue.com
 javascript:; wrote:
 Hi Daan,
 
 
 On 24-Jul-2014, at 6:20 pm, Daan Hoogland daan.hoogl...@gmail.com
 javascript:; wrote:
 
 People (especially test developers),
 
 please stop using 4.4-forward and switch to 4.4
 
 If we do a code freeze for 4.4.1 make a new branch per fix, the model
 of a -forward branch is fundamentally broken and has cost me a few
 hours of merge trouble over the past two months.
 
 Since we’re discussing about fixing our git based workflow can we
 conclude that we should be using the -forward branch in future from now
 onwards?
 
 So, we work until a release is done (by a tag) and keep working on the
 same branch instead of a -forward and then cherry-pick, merge it back again
 to the parent release branch?
 
 Regards.
 
 
 thanks,
 --
 Daan
 
 Regards,
 Rohit Yadav
 Software Architect, ShapeBlue
 M. +41 779015219 | rohit.ya...@shapeblue.com javascript:;
 Blog: bhaisaab.org | Twitter: @_bhaisaab
 
 
 
 
 Find out more about ShapeBlue and our range of CloudStack related
 services
 
 IaaS Cloud Design  Build
 http://shapeblue.com/iaas-cloud-design-and-build//
 CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
 
 CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
 CloudStack Infrastructure Support
 http://shapeblue.com/cloudstack-infrastructure-support/
 CloudStack Bootcamp Training Courses
 http://shapeblue.com/cloudstack-training/
 
 This email and any attachments to it may be confidential and are
 intended solely for the use of the individual to whom it is addressed. Any
 views or opinions expressed are solely those of the author and do not
 necessarily represent those of Shape Blue Ltd or related companies. If you
 are not the intended recipient of this email, you must neither take any
 action based upon its contents, nor copy or show it to anyone. Please
 contact the sender if you believe you have received this email in error.
 Shape Blue Ltd is a company incorporated in England  Wales. ShapeBlue
 Services India LLP is a company incorporated in India and is operated under
 license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a
 company incorporated in Brasil and is operated under license from Shape
 Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of
 South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is
 a registered trademark.
 
 
 
 --
 Daan
 
 Regards,
 Rohit Yadav
 Software Architect, ShapeBlue
 M. +41 779015219 | rohit.ya...@shapeblue.com javascript:;
 Blog: bhaisaab.org | Twitter: @_bhaisaab
 
 
 
 
 Find out more about ShapeBlue and our range of CloudStack related services
 
 IaaS Cloud Design  Build
 http://shapeblue.com/iaas-cloud-design-and-build//
 CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/
 CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/
 CloudStack Infrastructure Support
 http://shapeblue.com/cloudstack-infrastructure-support/
 CloudStack Bootcamp Training Courses
 http://shapeblue.com/cloudstack-training/
 
 This email and any attachments to it may be confidential and are intended
 solely for the use of the individual to whom it is addressed. Any views or
 opinions expressed are solely those of the author and do not necessarily
 represent those of Shape Blue Ltd or related companies. If you are not the
 intended recipient of this email, you must neither take any action based
 upon its contents, nor copy or show it to anyone. Please contact the sender
 if you believe you have received this email in error. Shape Blue Ltd is a
 company incorporated in England  Wales. ShapeBlue Services India LLP is a
 company incorporated in India and is operated under license from Shape Blue
 Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
 and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
 a company registered by The Republic of South Africa and is traded under
 license from Shape Blue 

Re: 4.4-forward usage

2014-07-30 Thread Daan Hoogland
On Wed, Jul 30, 2014 at 10:15 PM, Sebastien Goasguen run...@gmail.com wrote:
 and merge it in other needed branches (master and develop)


that part will be hard as it will merge all commits (also hotfixes and
others) that aren't on the the ancestry of the branch to merge into.
So this is only possible if the 4.4 branch is relatively clean.

-- 
Daan


Re: building cloudstack

2014-07-30 Thread Daan Hoogland
Jaya,

You can go back to any commit id you want. I don't think you'll find
much going backwards but it is nice trouble shooting the code. In your
case my thoughts go to the build environment as you fail to build
versions that others have build successfully.

best do a git pull and try mvn clean test install again. next run the
jetty command to see what happens. If it fails all the output is
relevant. you best put it in a paste bin to share it. it will be to
much to mail.

regards,
Daan

On Wed, Jul 30, 2014 at 7:23 PM, Elapavuluri, Jaya
jaya.elapavul...@netapp.com wrote:
 I am getting the same error after throwing away the .m2 folder.

 It complains about resolving the dependencies for 4.4.1. Is there any other 
 way I could go back?

 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Wednesday, July 30, 2014 3:28 AM
 To: dev
 Subject: Re: building cloudstack

 did you run
 $ git pull
 $ mvn clean test install
 before that?

 if so you could try thowing away your ~/.m2/repositories dir.

 On Wed, Jul 30, 2014 at 1:50 AM, Elapavuluri, Jaya 
 jaya.elapavul...@netapp.com wrote:
 So this is the screen shot of the error I am getting.



 This was after trying to start the management server mvn -pl
 :cloud-client-ui jetty:run -Dnoredist





 [INFO]
 --
 --

 [ERROR] Failed to execute goal on project cloud-client-ui: Could not
 resolve dependencies for project
 org.apache.cloudstack:cloud-client-ui:war:4.4.1-SNAPSHOT: The
 following artifacts could not be resolved:
 org.apache.cloudstack:cloud-plugin-netapp:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-network-f5:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-network-srx:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-hypervisor-vmware:jar:4.4.1-SNAPSHO
 T, org.apache.cloudstack:cloud-vmware-base:jar:4.4.1-SNAPSHOT,
 org.apache.cloudstack:cloud-plugin-network-cisco-vnmc:jar:4.4.1-SNAPSH
 OT,
 org.apache.cloudstack:cloud-plugin-database-mysqlha:jar:4.4.1-SNAPSHOT:
 Failure to find
 org.apache.cloudstack:cloud-plugin-netapp:jar:4.4.1-SNAPSHOT
 in http://repository.apache.org/snapshots was cached in the local
 repository, resolution will not be reattempted until the update
 interval of apache.snapshots has elapsed or updates are forced -
 [Help 1]

 [ERROR]

 [ERROR] To see the full stack trace of the errors, re-run Maven with
 the -e switch.

 [ERROR] Re-run Maven using the -X switch to enable full debug logging.

 [ERROR]

 [ERROR] For more information about the errors and possible solutions,
 please read the following articles:

 [ERROR] [Help 1]
 http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionE
 xception









 -Original Message-
 From: Elapavuluri, Jaya [mailto:jaya.elapavul...@netapp.com]
 Sent: Tuesday, July 29, 2014 2:44 PM
 To: dev@cloudstack.apache.org
 Subject: RE: building cloudstack



 So, is there any way the bug can be fixed??



 -Original Message-

 From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]

 Sent: Monday, July 28, 2014 5:10 PM

 To: dev@cloudstack.apache.org

 Subject: Re: building cloudstack



 Hi Jaya,



 Which branch are you on? It's a bug we'll fix it by placing an empty
 upgrade path for 4.4.1 version.



 The upgrade paths are available only between released versions only,
 so it fails as there is no upgrade path for 4.4.1-SNAPSHOT.



 Regards.



 Elapavuluri, Jaya wrote:

 Hello,







 I had setup cloudstack 4.4 environment which was running fine.



 I recently did a git pull to get the updates after which when I tried
 to mvn -Pdeveloper -pl developer -Ddeploydb I was encountering with
 the following error.





 [ERROR] Failed to execute goal

 org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on

 project cloud-developer: An exception occured while executing the
 Java

 class. null: InvocationTargetException: The end upgrade version is

 actually at 4.4.0 but our management server code version is at

 4.4.1-SNAPSHOT -  [Help 1]



 However mvn -P developer,systemvm clean install gives a build success.



 Can someone share their knowledge on this?





 --

 Rohit Yadav

 Software Architect, ShapeBlue

 M. +41 779015219 | rohit.ya...@shapeblue.com

 Blog: bhaisaab.org | Twitter: @_bhaisaab





 Find out more about ShapeBlue and our range of CloudStack related
 services



 IaaS Cloud Design 
 Buildhttp://shapeblue.com/iaas-cloud-design-and-build//

 CSForge – rapid IaaS deployment
 frameworkhttp://shapeblue.com/csforge/

 CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/

 CloudStack Infrastructure
 Supporthttp://shapeblue.com/cloudstack-infrastructure-support/

 CloudStack Bootcamp Training
 Courseshttp://shapeblue.com/cloudstack-training/



 This email and any attachments to it may be confidential and are
 intended solely for the use of the individual to whom it is addressed.
 Any views or opinions expressed are 

Re: 4.4-forward usage

2014-07-30 Thread David Nalley
On Wed, Jul 30, 2014 at 4:26 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 On Wed, Jul 30, 2014 at 10:15 PM, Sebastien Goasguen run...@gmail.com
 wrote:
  and merge it in other needed branches (master and develop)


 that part will be hard as it will merge all commits (also hotfixes and
 others) that aren't on the the ancestry of the branch to merge into.
 So this is only possible if the 4.4 branch is relatively clean.



Agreed - in many respects the rate of change almost dictates that we'll end
up with multiple release branches. I worry it's a bit naive to think that
something as complicated and large as CloudStack, and moving at the
velocity we do, will end up with only one set of 'master and develop'

--David


Re: [DISCUSS] git commit proces

2014-07-30 Thread Sheng Yang
On Wed, Jul 30, 2014 at 12:37 AM, Sebastien Goasguen run...@gmail.com
wrote:


 On Jul 29, 2014, at 8:40 PM, Sheng Yang sh...@yasker.org wrote:

  And talking about to achieve good code quality, I think compulsive review
  and testing through some kind of automation system is much more helpful.
 
  --Sheng
 

 This new git workflow is not directly about good code quality, as a wise
 man told me the other day crap gets in, crap gets out, not matter what you
 do with git.

 IMHO, code quality will indeed be fixed with more reviews and a CI
 pipeline, but it will also mean accepting only patches that have tests with
 it.
 So no unittests, no integration tests, no commit. But I think we are way
 far from this.

 There is currently a BVT automatic testing infra proposal on the table
 from citrix, but this needs to be on ASF infra, and it seems no-one has
 wanted to push this proposal much further.


In Citrix, we're actively working on enforce review and testing during our
commit process, trying to close the gap. Inside our company, we're planning
to do exactly no review, no testing, no commit. And we're working on make
that process easy to developers. But last time when I brought up idea about
enforcing review and testing by using gerrit or other similar automation
tools, seems community didn't care much about it.

The testing is limited by resource so far, but at least mandatory reviewing
is something we should work on as I thought.



 Starting with a better git workflow should bring us up to standard methods
 of developing with git.

 x.y-forward has been a mess, calling for [MERGE] request for new features
 has been totally neglected by developers, folks fix a bug in master but
 don't care to check if it applies on other branches and don't fix it there.
 Or maybe they fix on a release branch and don't fix on master.


 The end result of this bad practice is this:

 -I have personally 0% confidence that a bug fixed somewhere is fixed
 everywhere (it gets even worse when you bring in bad JIRA practices with
 bugs being closed when they are not closed).


This is my biggest concern as well. I hate doing fix for all the branches
though I have to do it every time. I am more than willing to get this
solved. But I haven't clear how gitflow model would able to handle multiple
maintenance version issue. If this can be solved elegantly that would be
great.


 -We have quite a bit of regressions
 -Our new releases are pretty much different/diverging products
 -We don't know what's in a future release (exemplified by difficulty for
 RM to get list of new features)
 -And more importantly we don't have a stable branch.

 This proposed git workflow would give us:

 -A stable branch (master). You checkout master get a shippable product.
 Very few commits to master are made, development is moved to 'develop'
 branch. Only hot fixes of current release get merged in master (which means
 it's still a shippable product). I am in favor of being draconian with
 this, and I am sure we would see a lot of reverts in the first weeks of
 adopting this workflow. But we need to stabilize master.


I don't against a stable master idea. I think it's good to have, and anyway
we have stable previous release and relatively stable developing branch
now. So if we want to call it master or not, I don't think it's very
important.


 -Everyone works on branches and knows where to merge. Developers will know
 where they branched from and where they need to merge into. This will also
 mean that history, tracking, reverting  should also be easier. (personally
 I am not entirely against cherry-picks and I could live with some minimal
 amount done by the RM, but they problem with cherry picking right now is
 with the way we apply patches to various branches…untraceable).


Can't agree more on this, though I am still trying understand how this can
be achieved by the new model.


 -This will also mean that our release branches are clearly defined and a
 RM can actually pick features to merge into a release, but these release
 branches should/will be merged into master instead of being abandoned like
 we do now.


I think release branch would still needed if we want to release maintenance
release.


 -Now about minor releases. Say we release 4.5, the tag is in master (not
 on a release branch), we have a few hot fixes that John Smith says are very
 important. Those hot fixes get merged into master (and into develop), we
 then call a vote on the latest master (e.g 4.5.1-tentative) if it passes
 tag it (4.5.1) and we have a new minor release without new features. Master
 is stable.


Yes. But how about 4.4.1? Master only contained the latest release. What
about previous one?

--Sheng



 The big advantage I see with this is that our release process should be
 much easier and we will have one continuous shippable product, instead of
 real forks.

 -sebastien


 
  On Tue, Jul 29, 2014 at 4:14 PM, Sheng Yang sh...@yasker.org wrote:
 
  Hi Leo,
 
  I am 

Re: 4.4-forward picked empty

2014-07-30 Thread Min Chen
Daan,

That commit is already there in 4.4 branch. See
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=6ba541a
fb73475758a62a17dae1ec1be088da810.

Thanks
-min




On 7/30/14 5:33 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:

thanks Rajani

On Wed, Jul 30, 2014 at 2:20 PM, Rajani Karuturi
rajani.karut...@citrix.com wrote:
 Hi Daan,


 commit 2ab7bcade2f37cb17e071a6154fdae1d80e4ff99
 Author: Rajani Karuturi rajanikarut...@gmail.com
 Date:   Fri May 23 15:50:06 2014 +0530

Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in
 deleted ip range


 This is same as df42ce903d399cf30055e55bc24b84fbc0b563a9 on 4.4

 commit d511847cfedad5478d1b4087c8f97be2c5bf3cc8
 Author: Rajani Karuturi rajanikarut...@gmail.com
 Date:   Tue Jun 3 16:11:01 2014 +0530

Fixed Resource leak (RESOURCE_LEAK) 11. overwrite_var: Overwriting
 pstmt in pstmt = conn.prepareStatement(INSERT INTO
 `cloud`.`ldap_configuration`(hostname, po

Signed-off-by: Koushik Das kous...@apache.org


 Can be ignored. Fixes are already there.

 ~ Rajani



-- 
Daan



Re: [DISCUSS] git commit proces

2014-07-30 Thread Sheng Yang
On Wed, Jul 30, 2014 at 1:21 AM, Leo Simons lsim...@schubergphilis.com
wrote:

 On Jul 30, 2014, at 1:14 AM, Sheng Yang sh...@yasker.org wrote:
  The issue with current development process?
  1. Cherry-pick is needed for RM to choose stable fix commit after code
  freeze to enforce quality.
  2. Bug fix to current release branch need to be checked in both release
  branch and MASTER.
  3. I believe there would be more. Please comment.

 4. where commits need to go is dependent on what phase of the release
 process you’re in, which requires sync. For example, if you’re working on a
 bug fix against 4.4 but then that is frozen you have to rebase against
 4.4-forward. If you are doing this work on a public feature branch you have
 to re-cut your branch since you don’t want to rebase those.


In gitflow model, feature always branch out develop branch, not release
branch. In this case, 4.4 is release branch, 4.4-forward is develop
branch(for 4.4), both are descendence of old 4.4 branch the feature based
on, so I don't understand the difference here.


 5. requires using synchronous process (freezes) to keep track of what is
 going on. This is not very healthy for a distributed project with
 contributors across many continents and companies. In contrast if you
 branch early and often you don’t freeze, you just avoid merging things that
 could destabilize things.


In gitflow model, feature branch is coming from develop branch, which is
also not stable I think? You need to live with unstable sometime.


 6. does not allow looking into history to see what happened. I.e. if you
 were to cut a 4.5 branch from master, its code history is not at all the
 same or comparable (using git tools) to the code history of 4.4.


Yeah, this is an issue. In theory they should be the same, since every
fixes goes to where it should go.


 7. reliant on error-prone human checking of merge status (looking if all
 cherries have been picked properly) rather than tool support (git
 confirming for you all changes from branch A made it to branch B)


git cherry provide that ability in this case.


 8. default/naive checkouts of cloudstack tree result in a very unstable
 and sometimes unbuildable master


If we expect master to be stable, this is a problem. Though it's not
expected to be stable in our current model.



 The list goes on! But I don’t see why we should repeat all these things
 here when the internet is full of these kinds of discussions already, as
 are this mailing list’s archives…

  3. Code freeze: No such concept in the flow. Need to know how to guide
 the
  check in.

 Mostly by discipline. Committers normally commit to develop and/or feature
 branches, and switch only to the release branch to commit very specific
 bugfixes. You can agree a policy (for example like Alena described) for how
 to make the decision what should and should not go on onto the release
 branch.


I don't quite believe in this. I believe self-discipline is not enough when
we facing something like release. I even don't like only one RM working as
gatekeeper. We should have all set of tools support from mandatory review
to automatic testing, and probably QA specific testing. In Linux kernel,
every commit would pass at least two person: subsystem maintainer and
Linus, before enter RC. Of course there would be more people reviewing in
the mailing list as well. But I think even now we trusted too much on
self-discipline, result in issues in code quality.



  5. The original post didn't mention minor release. I suppose it may work
  like this:
 
1. Branch out MASTER to 4.4 release
2. Any bug fixes happened on 4.4 need to be merge to MASTER.
3. But, how to fix a 4.4 bug in 4.5's minor release? Seems what's
 needed
is MASTER merged 4.5 which merged 4.4 which merged 4.3. And how can we
 fix
it in develop branch(which meant for test)? I can't see how you can
 avoid
cherry-pick or extra commit if you want to have a maintenance release.

 There will be extra commits, but they will be merge commits. I.e.

 master --4.3-4.4--x4.5
|  \  /
 release/4.4.1|   \——x--   /
  |\/ /
 bugfix/CLOUDSTACK-1234   | \—x/ /
  |  \ \/
 release/4.5  |   \—x—-/
  |  \ \
 develop--y---x-

 the commit x will always be there exactly once, it will get exactly one
 sha1 checksum and one spot in the git index, and git will forever remember
 all the different branches that include x.

 On some of those branches there may be merge commits (if you explicitly
 chose to have them, or if git decided they were needed) following x, to
 record the merges that were done.

 You can basically always do this as long as you *start your 

Re: Review Request 24050: CLOUDSTACK-7173 Make getNewMinIops and getNewMaxIops return Longs

2014-07-30 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24050/#review49193
---


Commit b919da8a5c54ec0f7d0c370203ccfb058cbe1a54 in cloudstack's branch 
refs/heads/master from Mike Tutkowski
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b919da8 ]

CLOUDSTACK-7173

- ASF Subversion and Git Services


On July 29, 2014, 12:56 p.m., Alex Brett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/24050/
 ---
 
 (Updated July 29, 2014, 12:56 p.m.)
 
 
 Review request for cloudstack.
 
 
 Bugs: CLOUDSTACK-7173
 https://issues.apache.org/jira/browse/CLOUDSTACK-7173
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The functions getNewMinIops and getNewMaxIops were returning long primitives, 
 this can throw a NPE as the underlying Long objects could be null, which was 
 causing volume resizes to fail.
 
 The only place this getter is called is expecting a Long object, so changing 
 it to return a Long rather than long should be safe.
 
 
 Diffs
 -
 
   server/src/com/cloud/storage/VmWorkResizeVolume.java 1caab10 
 
 Diff: https://reviews.apache.org/r/24050/diff/
 
 
 Testing
 ---
 
 Verified cloudstack still builds
 
 
 Thanks,
 
 Alex Brett
 




RE: Simulator on master is not building

2014-07-30 Thread Santhosh Edukulla
If we build simulator by default, it may add to the build time, and there is a 
potential people forgetting to exclude some times.

Santhosh

From: Anthony Xu [xuefei...@citrix.com]
Sent: Wednesday, July 30, 2014 1:27 PM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building

We used -Dsimulator to include simulator, it is very easy for developers to 
forget it.  Simulator should be built by default , we may use -Dnosimulator to 
exclude simulator.


Anthony

-Original Message-
From: Koushik Das
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building

The simulator code should be kept up to date with any changes done in the core 
product. If there are any interface changes, necessary changes should be made 
in simulator plugin as well along with other hypervisor plugins. To build 
simulator code use refer to [1].

-Koushik

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration

-Original Message-
From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com]
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building

I believe for every check-in we decided to run sanity tests on simulator 
atleast, currently build for simulator is failing.

 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation 
failure:
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations [ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations


Thanks!
Santhosh


Re: [DISCUSS] git commit proces

2014-07-30 Thread Rajani Karuturi


4. Then, conflict would happen when you merge release/4.4. branch to
release/4.5. Since the version number changed to 4.4.1. You need to deal
with version number conflict every time when merge to upper release.


one empty merge with git merge -s ours after the version change and git would 
not complain again. git would assume that conflicts are resolved and that 
particular commit need not be merged again.
git merges are relative it won’t merge the entire tree each and every time.

~ Rajani


Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-30 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24111/#review49200
---



plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
https://reviews.apache.org/r/24111/#comment86076

Message info seems to be corrected.



plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
https://reviews.apache.org/r/24111/#comment86079

Missing try\catch here. But, there is a better way suggested by Daan to 
auto close resources using try-with-resource to avoid any of these usages.


- Santhosh Edukulla


On July 30, 2014, 7:44 p.m., Ritu  Sabharwal wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/24111/
 ---
 
 (Updated July 30, 2014, 7:44 p.m.)
 
 
 Review request for cloudstack and Hugo Trippaers.
 
 
 Bugs: CLOUDSTACK-6823
 https://issues.apache.org/jira/browse/CLOUDSTACK-6823
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Fixed Coverity findings for brocade-plugin
 
 
 Diffs
 -
 
   
 plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
  60edbcf 
   
 plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
  d5f06f8 
 
 Diff: https://reviews.apache.org/r/24111/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ritu  Sabharwal
 




[Summary] checkin process

2014-07-30 Thread Rajani Karuturi
For the git flow:
1. We agreed to follow git-flow explained here 
http://nvie.com/posts/a-successful-git-branching-model/
2. This is the proposal for first cut
2a. rename 'master' to 'develop’
2b. branch a new 'master' from ‘4.4’ and update tags with release/4.4.0
2c. branch ‘release/4.5' from the develop
2d. merge ‘release/4.5' to master once the release voting is done.
3. This would be the flow for a hot fix
3a. branch off from the release tag on master. in this case it would be 
release/4.4.0
3b. commit the fixes in hotfix/4.4.1
3c. do the release
3d. merge to develop
3e. merge to master and update tags
3f. delete hot fix branch
4. for any LTS release create a support branch when required using git-flow 
support
4a. http://stackoverflow.com/a/16866118/201514

using the git-flow git extension available at https://github.com/nvie/gitflow 
can reduce the number of commands/errors

In addition:
1. Every commit should have unit tests
2. every feature/merge request should have unit and marvin integration tests
3. A commit should not have check style or find bugs issues
4. any coverity issues reported in the new code should be addressed immediately
5. every developer should run the BVT on the simulator before doing a checkin 
(https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes%2C+using+Simulatorhttps://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes,+using+Simulator)
 (This I am not very sure. May be we should let jenkins handle it and report 
integration failures if any?)
Please add/amend if I missed anything.

Can we call for a vote on this and freeze this without further delay?


~Rajani





RE: Simulator on master is not building

2014-07-30 Thread Koushik Das
Simulator can be included in the default build but it needs to be tested 
whether simulator plugin can coexist with actual HV plugins in the same MS 
without any issues. Right now there is an issue which prevents it, refer to 
https://issues.apache.org/jira/browse/CLOUDSTACK-6623. Once this is fixed it 
needs to be tested again.

Also there needs to be a consensus to include it in default profile.

-Original Message-
From: Edison Su 
Sent: Wednesday, 30 July 2014 11:30 PM
To: dev@cloudstack.apache.org; Koushik Das
Subject: RE: Simulator on master is not building

+1, include simulator in the default build, exclude explicitly in the 
production build.

 -Original Message-
 From: Anthony Xu [mailto:xuefei...@citrix.com]
 Sent: Wednesday, July 30, 2014 10:28 AM
 To: Koushik Das; dev@cloudstack.apache.org
 Subject: RE: Simulator on master is not building
 
 We used -Dsimulator to include simulator, it is very easy for 
 developers to forget it.  Simulator should be built by default , we 
 may use -Dnosimulator to exclude simulator.
 
 
 Anthony
 
 -Original Message-
 From: Koushik Das
 Sent: Wednesday, July 30, 2014 3:03 AM
 To: dev@cloudstack.apache.org
 Cc: Anthony Xu
 Subject: RE: Simulator on master is not building
 
 The simulator code should be kept up to date with any changes done in 
 the core product. If there are any interface changes, necessary 
 changes should be made in simulator plugin as well along with other 
 hypervisor plugins. To build simulator code use refer to [1].
 
 -Koushik
 
 [1]
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integ
 r
 ation
 
 -Original Message-
 From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com]
 Sent: Wednesday, 30 July 2014 3:27 PM
 To: dev@cloudstack.apache.org
 Cc: Anthony Xu
 Subject: Simulator on master is not building
 
 I believe for every check-in we decided to run sanity tests on 
 simulator atleast, currently build for simulator is failing.
 
  
 --
 -- [ERROR] Failed to execute goal 
 org.apache.maven.plugins:maven-compiler-
 plugin:2.5.1:compile (default-compile) on project 
 cloud-plugin-hypervisor-
 simulator: Compilation failure: Compilation failure:
 [ERROR]
 /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
 s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations 
 [ERROR] 
 /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
 s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations
 
 
 Thanks!
 Santhosh


RE: Simulator on master is not building

2014-07-30 Thread Koushik Das
There is a separate simulator DB where all these VOs are used. These are only 
used in the 'Simulator' resource layer and are not part of core CS logic. Also 
I have written a sample test for new vmsync 
(test/integration/smoke/test_vm_sync.py). Please check it out and let me know 
if there are any issues.

-Koushik

-Original Message-
From: Anthony Xu 
Sent: Wednesday, 30 July 2014 11:37 PM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building

Hi Koushik,

fixed the build for simulator.

I just found out Simulator use its own VOes for some VOes, it may not be easy 
for developer to add feature for simulator if the feature needs to change VO, 
for example, the new VMsync logic, I don't think simulator test the new VMsync 
logic. 

If we consider Simulator as a hypervisor, ideally it should use the same VOes 
as other hypersivors. Can you help us understand what's the reason behind this?

Thanks
Anthony







./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVMVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecStorageVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVolumeVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockStoragePoolVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockHostVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockConfigurationVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecurityRulesVO.java





-Original Message-
From: Anthony Xu 
Sent: Wednesday, July 30, 2014 10:28 AM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building

We used -Dsimulator to include simulator, it is very easy for developers to 
forget it.  Simulator should be built by default , we may use -Dnosimulator to 
exclude simulator.


Anthony

-Original Message-
From: Koushik Das 
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building

The simulator code should be kept up to date with any changes done in the core 
product. If there are any interface changes, necessary changes should be made 
in simulator plugin as well along with other hypervisor plugins. To build 
simulator code use refer to [1].

-Koushik

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration

-Original Message-
From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com] 
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building

I believe for every check-in we decided to run sanity tests on simulator 
atleast, currently build for simulator is failing. 

 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation 
failure:
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations [ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations


Thanks!
Santhosh


RE: Simulator on master is not building

2014-07-30 Thread Santhosh Edukulla
AS well, the way we build simulator for deploying its db is different , all 
packaging scripts needs to be changed and a potential testing involved .

Santhosh

From: Santhosh Edukulla
Sent: Thursday, July 31, 2014 12:05 AM
To: dev@cloudstack.apache.org; Koushik Das
Subject: RE: Simulator on master is not building

If we build simulator by default, it may add to the build time, and there is a 
potential people forgetting to exclude some times.

Santhosh

From: Anthony Xu [xuefei...@citrix.com]
Sent: Wednesday, July 30, 2014 1:27 PM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building

We used -Dsimulator to include simulator, it is very easy for developers to 
forget it.  Simulator should be built by default , we may use -Dnosimulator to 
exclude simulator.


Anthony

-Original Message-
From: Koushik Das
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building

The simulator code should be kept up to date with any changes done in the core 
product. If there are any interface changes, necessary changes should be made 
in simulator plugin as well along with other hypervisor plugins. To build 
simulator code use refer to [1].

-Koushik

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration

-Original Message-
From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com]
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building

I believe for every check-in we decided to run sanity tests on simulator 
atleast, currently build for simulator is failing.

 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) 
on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation 
failure:
[ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
 error: 'try' without 'catch', 'finally' or resource declarations [ERROR] 
/home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
 error: 'try' without 'catch', 'finally' or resource declarations


Thanks!
Santhosh