Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Can you point to any reference/blog which justifies writing tests for this kind of scenario? What I can infer from these tests is that that there are two scenarios 1) Method will not change In that case it doesn’t make sense to put test for never changing method. 2) Method will change In that case you have to change test to make it pass and then also it doesn’t make sense as you have to change test to make it actually pass. Regards, Anshul On 19-Aug-2015, at 4:18 pm, Rafael Weingärtner rafaelweingart...@gmail.commailto:rafaelweingart...@gmail.com wrote: @anshul1886 I totally agree with you that tests are meant to test individual, and as you pointed the individual code that we want to test is “getPatchFilePath”. However, that method is abstract, and its “implementation” that is as simple as returning a constant, changes in few subclasses of CitrixResourceBase. I am not testing the constant per se; I am testing if each one of the implementation of that method is returning what I expect. In one hand, I agree with you that the method could have documentation. I just have not done that because I really do not know what that String that the method is returning is. On the other hand, documentation will not save us from future bugs, as a consequence of some change in those methods. Those tests can do that automatically. If that method had a conditional statement and it was coded into CitrixResourceBase would you think different? The point here is that object orientation removed those ifs. On Wed, Aug 19, 2015 at 7:26 AM, Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote: a unit can be defined at more then just the method level and in this case those paths have changed from under us in the past. I am not justifying testing any constant this way. I am justifying just this work. On Wed, Aug 19, 2015 at 9:03 AM, Anshul Gangwar anshul.gang...@citrix.commailto:anshul.gang...@citrix.com wrote: What I mean to say is that unit test are meant to test individual unit which here is getPatchFilePath and not meant to test hierarchy as you are pointing out here. By individual unit I mean it doesn’t matter for test that it is in class A or class B. This way you are kind of justifying that we should write test for any constant which you have defined has the value which you have given. Because constant under different classes can have different values. Can you point to any reference which justifies writing tests for this kind of scenario? Regards, Anshul On 19-Aug-2015, at 11:34 am, Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote: On Wed, Aug 19, 2015 at 5:56 AM, anshul1886 g...@git.apache.orgmailto:g...@git.apache.org wrote: If the purpose is to make sure that path is not modified by other developer then adding note/comment on top of that line makes more sense. Even adding note is kind of implicit as paths are kind of constants which any developer would think before changing. Tests are not meant for that purpose. Anshul, I hope I don't understand you when you say, 'tests are not meant for that pupose'. When the hierarchy is changed and this leads to the constants to be used in a different way in different classes, an error occurs due to this that will be caught by these tests. This is exactly what unit tests are for. class A has constant pth=/root. class B:A has constant pth=/root/bla. class C:B has no constant hence pth=/root/bla. now C is changed to C:A and its pth is there fore changed to /root. This is uninteded and a mistake that will be caught by such tests. -- Daan -- Daan -- Rafael Weingärtner
[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/665#issuecomment-132583048 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
@anshul1886 I agree that we disagree.
Folks I do not know what to do in this case, I will not looking for
references to support what I said and did. Whatever you guys decided I will
do (remove or let the test cases there).
On Wed, Aug 19, 2015 at 9:47 AM, Anshul Gangwar anshul.gang...@citrix.com
wrote:
Let me summarise the tests
class A {
x(){
return “d”; a constant
}
}
test
p=“d”
Assert( A.x() = p)
Which can be reduced to
class A {
q=“d;
}
Here q is replacement for x method as it is only returning a constant
now test is
p=“d
assert (p=q)
To me this basically proves that java assignment works and nothing more
than that.
Here A can be any class. But in this context it is subclass of something.
I can’t even figure out how super class coming into picture in tests which
you are trying to say.
Please explain in context of above example how it is testing more than
java assignment.
Regards,
Anshul
On 19-Aug-2015, at 5:16 pm, Anshul Gangwar anshul.gang...@citrix.com
wrote:
Can you point to any reference/blog which justifies writing tests for this
kind of scenario?
What I can infer from these tests is that that there are two scenarios
1) Method will not change
In that case it doesn’t make sense to put test for never changing
method.
2) Method will change
In that case you have to change test to make it pass and then also it
doesn’t make sense as you have to change test to make it actually pass.
Regards,
Anshul
On 19-Aug-2015, at 4:18 pm, Rafael Weingärtner
rafaelweingart...@gmail.commailto:rafaelweingart...@gmail.com
rafaelweingart...@gmail.com wrote:
@anshul1886 I totally agree with you that tests are meant to test
individual, and as you pointed the individual code that we want to test is
“getPatchFilePath”. However, that method is abstract, and its
“implementation” that is as simple as returning a constant, changes in few
subclasses of CitrixResourceBase. I am not testing the constant per se; I
am testing if each one of the implementation of that method is returning
what I expect.
In one hand, I agree with you that the method could have documentation. I
just have not done that because I really do not know what that String that
the method is returning is. On the other hand, documentation will not save
us from future bugs, as a consequence of some change in those methods.
Those tests can do that automatically.
If that method had a conditional statement and it was coded into
CitrixResourceBase would you think different? The point here is that object
orientation removed those ifs.
On Wed, Aug 19, 2015 at 7:26 AM, Daan Hoogland daan.hoogl...@gmail.com
mailto:daan.hoogl...@gmail.com daan.hoogl...@gmail.com wrote:
a unit can be defined at more then just the method level and in this case
those paths have changed from under us in the past. I am not justifying
testing any constant this way. I am justifying just this work.
On Wed, Aug 19, 2015 at 9:03 AM, Anshul Gangwar anshul.gang...@citrix.com
mailto:anshul.gang...@citrix.com anshul.gang...@citrix.com
wrote:
What I mean to say is that unit test are meant to test individual unit
which here is getPatchFilePath and not meant to test hierarchy as you are
pointing out here. By individual unit I mean it doesn’t matter for test
that it is in class A or class B. This way you are kind of justifying that
we should write test for any constant which you have defined has the value
which you have given. Because constant under different classes can have
different values.
Can you point to any reference which justifies writing tests for this kind
of scenario?
Regards,
Anshul
On 19-Aug-2015, at 11:34 am, Daan Hoogland daan.hoogl...@gmail.com
mailto:daan.hoogl...@gmail.com daan.hoogl...@gmail.com
wrote:
On Wed, Aug 19, 2015 at 5:56 AM, anshul1886 g...@git.apache.org
mailto:g...@git.apache.org g...@git.apache.org wrote:
If the purpose is to make sure that path is not modified by other
developer then adding note/comment on top of that line makes more sense.
Even adding note is kind of implicit as paths are kind of constants which
any developer would think before changing. Tests are not meant for that
purpose.
Anshul, I hope I don't understand you when you say, 'tests are not meant
for that pupose'. When the hierarchy is changed and this leads to the
constants to be used in a different way in different classes, an error
occurs due to this that will be caught by these tests. This is exactly what
unit tests are for.
class A has constant pth=/root.
class B:A has constant pth=/root/bla.
class C:B has no constant hence pth=/root/bla.
now C is changed to C:A and its pth is there fore changed to /root.
This is uninteded and a mistake that will be caught by such tests.
--
Daan
--
Daan
--
Rafael Weingärtner
--
Rafael Weingärtner
[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132550029 @rafaelweingartner I like it! For me it simply proves that the paths are still the same after your change. If the paths need to be changed, we'll update the tests and the code. As you'd do with any code you change that has tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Github user pedro-martins closed the pull request at: https://github.com/apache/cloudstack/pull/714 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/665#issuecomment-132573747 @nitt10prashant Can you please review this PR again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Let me summarise the tests
class A {
x(){
return “d”; a constant
}
}
test
p=“d”
Assert( A.x() = p)
Which can be reduced to
class A {
q=“d;
}
Here q is replacement for x method as it is only returning a constant
now test is
p=“d
assert (p=q)
To me this basically proves that java assignment works and nothing more than
that.
Here A can be any class. But in this context it is subclass of something.
I can’t even figure out how super class coming into picture in tests which you
are trying to say.
Please explain in context of above example how it is testing more than java
assignment.
Regards,
Anshul
On 19-Aug-2015, at 5:16 pm, Anshul Gangwar
anshul.gang...@citrix.commailto:anshul.gang...@citrix.com wrote:
Can you point to any reference/blog which justifies writing tests for this kind
of scenario?
What I can infer from these tests is that that there are two scenarios
1) Method will not change
In that case it doesn’t make sense to put test for never changing method.
2) Method will change
In that case you have to change test to make it pass and then also it
doesn’t make sense as you have to change test to make it actually pass.
Regards,
Anshul
On 19-Aug-2015, at 4:18 pm, Rafael Weingärtner
rafaelweingart...@gmail.commailto:rafaelweingart...@gmail.commailto:rafaelweingart...@gmail.com
wrote:
@anshul1886 I totally agree with you that tests are meant to test individual,
and as you pointed the individual code that we want to test is
“getPatchFilePath”. However, that method is abstract, and its “implementation”
that is as simple as returning a constant, changes in few subclasses of
CitrixResourceBase. I am not testing the constant per se; I am testing if each
one of the implementation of that method is returning what I expect.
In one hand, I agree with you that the method could have documentation. I just
have not done that because I really do not know what that String that the
method is returning is. On the other hand, documentation will not save us from
future bugs, as a consequence of some change in those methods. Those tests can
do that automatically.
If that method had a conditional statement and it was coded into
CitrixResourceBase would you think different? The point here is that object
orientation removed those ifs.
On Wed, Aug 19, 2015 at 7:26 AM, Daan Hoogland
daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com
wrote:
a unit can be defined at more then just the method level and in this case
those paths have changed from under us in the past. I am not justifying
testing any constant this way. I am justifying just this work.
On Wed, Aug 19, 2015 at 9:03 AM, Anshul Gangwar
anshul.gang...@citrix.commailto:anshul.gang...@citrix.commailto:anshul.gang...@citrix.com
wrote:
What I mean to say is that unit test are meant to test individual unit
which here is getPatchFilePath and not meant to test hierarchy as you are
pointing out here. By individual unit I mean it doesn’t matter for test
that it is in class A or class B. This way you are kind of justifying that
we should write test for any constant which you have defined has the value
which you have given. Because constant under different classes can have
different values.
Can you point to any reference which justifies writing tests for this kind
of scenario?
Regards,
Anshul
On 19-Aug-2015, at 11:34 am, Daan Hoogland
daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com
wrote:
On Wed, Aug 19, 2015 at 5:56 AM, anshul1886
g...@git.apache.orgmailto:g...@git.apache.orgmailto:g...@git.apache.org
wrote:
If the purpose is to make sure that path is not modified by other
developer then adding note/comment on top of that line makes more sense.
Even adding note is kind of implicit as paths are kind of constants which
any developer would think before changing. Tests are not meant for that
purpose.
Anshul, I hope I don't understand you when you say, 'tests are not meant
for that pupose'. When the hierarchy is changed and this leads to the
constants to be used in a different way in different classes, an error
occurs due to this that will be caught by these tests. This is exactly what
unit tests are for.
class A has constant pth=/root.
class B:A has constant pth=/root/bla.
class C:B has no constant hence pth=/root/bla.
now C is changed to C:A and its pth is there fore changed to /root.
This is uninteded and a mistake that will be caught by such tests.
--
Daan
--
Daan
--
Rafael Weingärtner
Merging Pull Requests
Hi all, As it is now, additions to CloudStack need to go through a GitHub PR and, if accepted, merged to the Apache remote (not in GitHub). This means that merging a PR for CloudStack is a bit more involved than merging a normal GitHub PR. To help with this, Miguel, Rajani, Daan and myself, have created some scripts. One is 'git-pr' to merge a PR, the second one is 'git-fwd-merge' used by RM to merge branches (starting 4.6). Links: [1] PR to add the scripts [2] Wiki I'd be great if we would all use these scripts to merge Pull Requests (instead of applying patches). Let me know if you need help! Thanks Regards, Remi [1] https://github.com/apache/cloudstack/pull/721 [2] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/716#issuecomment-132643862 @borisroman If I run this `grep -r Ip4 *` I see many references to `Ip4`. Isn't this going to be confusing to rename a part of it only? Or am I missing something? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Anshul,
I do not think a reference for the intricate problems we face with the
hierarchy of the CitrixResourceBase and descendants is fair to ask. I think
the burdon of proof is with you and not Rafael.
The tests do not just prove that the assignment works as in you example.
They prove that the fragile integrity of the class hierarchy that has been
meddled with so often is still intact. Rafael and Lucas had a problem at
hand and dealt with it according to circumstances. Your example to
discredit this is over simplified and does not include the essence of what
can go wrong with the way the xenserver resource hierarchy is set up. The
solution choosen works, solves a problem and is a reference in it self. If
you think it is bad practice, please provide with a reference as to why it
is bad.
On Wed, Aug 19, 2015 at 3:39 PM, Rafael Weingärtner
rafaelweingart...@gmail.com wrote:
@anshul1886 I agree that we disagree.
Folks I do not know what to do in this case, I will not looking for
references to support what I said and did. Whatever you guys decided I will
do (remove or let the test cases there).
On Wed, Aug 19, 2015 at 9:47 AM, Anshul Gangwar anshul.gang...@citrix.com
wrote:
Let me summarise the tests
class A {
x(){
return “d”; a constant
}
}
test
p=“d”
Assert( A.x() = p)
Which can be reduced to
class A {
q=“d;
}
Here q is replacement for x method as it is only returning a constant
now test is
p=“d
assert (p=q)
To me this basically proves that java assignment works and nothing more
than that.
Here A can be any class. But in this context it is subclass of something.
I can’t even figure out how super class coming into picture in tests
which you are trying to say.
Please explain in context of above example how it is testing more than
java assignment.
Regards,
Anshul
On 19-Aug-2015, at 5:16 pm, Anshul Gangwar anshul.gang...@citrix.com
wrote:
Can you point to any reference/blog which justifies writing tests for
this kind of scenario?
What I can infer from these tests is that that there are two scenarios
1) Method will not change
In that case it doesn’t make sense to put test for never changing
method.
2) Method will change
In that case you have to change test to make it pass and then also it
doesn’t make sense as you have to change test to make it actually pass.
Regards,
Anshul
On 19-Aug-2015, at 4:18 pm, Rafael Weingärtner
rafaelweingart...@gmail.commailto:rafaelweingart...@gmail.com
rafaelweingart...@gmail.com wrote:
@anshul1886 I totally agree with you that tests are meant to test
individual, and as you pointed the individual code that we want to test is
“getPatchFilePath”. However, that method is abstract, and its
“implementation” that is as simple as returning a constant, changes in few
subclasses of CitrixResourceBase. I am not testing the constant per se; I
am testing if each one of the implementation of that method is returning
what I expect.
In one hand, I agree with you that the method could have documentation. I
just have not done that because I really do not know what that String that
the method is returning is. On the other hand, documentation will not save
us from future bugs, as a consequence of some change in those methods.
Those tests can do that automatically.
If that method had a conditional statement and it was coded into
CitrixResourceBase would you think different? The point here is that object
orientation removed those ifs.
On Wed, Aug 19, 2015 at 7:26 AM, Daan Hoogland daan.hoogl...@gmail.com
mailto:daan.hoogl...@gmail.com daan.hoogl...@gmail.com wrote:
a unit can be defined at more then just the method level and in this case
those paths have changed from under us in the past. I am not justifying
testing any constant this way. I am justifying just this work.
On Wed, Aug 19, 2015 at 9:03 AM, Anshul Gangwar
anshul.gang...@citrix.commailto:anshul.gang...@citrix.com
anshul.gang...@citrix.com
wrote:
What I mean to say is that unit test are meant to test individual unit
which here is getPatchFilePath and not meant to test hierarchy as you are
pointing out here. By individual unit I mean it doesn’t matter for test
that it is in class A or class B. This way you are kind of justifying that
we should write test for any constant which you have defined has the value
which you have given. Because constant under different classes can have
different values.
Can you point to any reference which justifies writing tests for this kind
of scenario?
Regards,
Anshul
On 19-Aug-2015, at 11:34 am, Daan Hoogland daan.hoogl...@gmail.com
mailto:daan.hoogl...@gmail.com daan.hoogl...@gmail.com
wrote:
On Wed, Aug 19, 2015 at 5:56 AM, anshul1886 g...@git.apache.org
mailto:g...@git.apache.org g...@git.apache.org wrote:
If the purpose is to make sure that path is not modified by other
developer then adding note/comment on top of that line makes more sense.
Even adding note is kind of
[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/721 Add scripts to merge PRs and release fixes forward As it is now, additions to CloudStack need to go through a GitHub PR and, if accepted, merged to the Apache remote (not in GitHub). This means that merging a PR for CloudStack is a bit more involved than merging a normal GitHub PR. In addition to that, a PR that fixes something in an older release needs to be merged against a release branch, and then forward merged up to master (if applicable). To help with these two kinds of merges, @remibergsma, @karuturi, @DaanHoogland and myself, have created two scripts (contributed in this PR). One script (git-pr) helps in merging a PR from GitHub to the Apache remote. The script will read the PR info using GitHub's API and will create a merge commit that that contains the same commit message a normal PR merge commits has, plus, as extra info, a list of commits that are being merged. The other script (git-fwd-merge) will create a specific merge commit message that indicates a forward merge, and lists the commits being merged. This Apache wiki [page](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655) describes how to use these two scripts, and points to an even more detailed [page](https://github.com/schubergphilis/cloudstack-git-tree-manipulation/wiki) that explains the merge scenarios step-by-step. By the way, beacause both scripts follow the naming convention for git tools, as long as they are in your path you can execute them as simply as git pr and git fwd-merge. But be aware that, in order to use these scripts, you should make sure to remove any aliases that can cause a name clash. You can merge this pull request into a Git repository by running: $ git pull https://github.com/miguelaferreira/cloudstack git-merge-scripts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/721.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #721 commit 9211202babf8003eb8dba9b5ac337c7dc7810dc3 Author: Miguel Ferreira miguelferre...@me.com Date: 2015-08-19T15:22:45Z Add git merge scripts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-132647888 @kishankavala Thanks for the update! When you're ready, also be sure to ping @wido so he can have another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-132654938 @DaanHoogland I agree with your considerations. My first commit was not performed properly. Sadly, the eclipse ended up formatting classes I touched, and that is why the line number added was higher than the removed one. I do understand that âs_ somethingâ is a proper way to instantiate a static variable in ACS classes. However, in few of the subclasses of âcom.cloud.utils.component.ComponentLifecycleBaseâ it was used names such as âLOGGERâ (that is a proper name for static field as JAVA standards), log, status_logger and others. What we propose is to change the logger variable in âcom.cloud.utils.component.ComponentLifecycleBaseâ to protected and remove its static and final declaration. Therefore we did the following in ComponentLifecycleBase: protected Logger logger = Logger.getLogger(getClass()); This way, every single subclass of ComponentLifecycleBase, when instantiated would automatically have a logger instance for its proper class ready to be used. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/720#issuecomment-132630872 This closes #384. Squashed to commits into 1 as requested per comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/718#issuecomment-132642477 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-132662044 @pedro-martins your motivation makes sense to me, can you create a jira ticket and cp it there? then use that as a tag for any commits (including cleanup/autoformat). One concern remaining is (not knowing the entire hierarchy by head) whether instance level loggers will be any kind of overhead. I know there are a lot of singletons per management server instance but for for instance agents this is not true. Did you investigate this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/720 CLOUDSTACK-8308: Adding automation testcases for Delta Snapshot. CLOUDSTACK-8308: Updating automation testcases for Delta Snapshot testpath. Reference to #384 You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisroman/cloudstack pr/384 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/720.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #720 commit 82bfb665c9a42b229715fa825e2602db004a20d6 Author: Boris Schrijver bo...@pcextreme.nl Date: 2015-08-19T14:54:56Z CLOUDSTACK-8308: Adding automation testcases for Delta Snapshot. CLOUDSTACK-8308: Updating automation testcases for Delta Snapshot testpath. Reference to #384 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/716#issuecomment-132646596 @remibergsma You are correct. Those are all not related to the AddressFormat enum. Of course all should be renamed, but doing so in 1 time will also will not benefit the process of making the code more readable. I'll will stack up some commits before making a new pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132653773 @rafaelweingartner I think it's good that you wrote the unit tests, and I actually wished people were a bit more supportive. I strongly agree with @remibergsma. I think we should merge it... LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/384#issuecomment-132631777 See #720 - Resolved comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/720#issuecomment-132631927 @remibergsma @bhaisaab Any more comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Apply RHEL 7 fix for comounted cgroups to...
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/719#issuecomment-132636109 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Apply RHEL 7 fix for comounted cgroups to...
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/719 Apply RHEL 7 fix for comounted cgroups to CentOS 7 KVM hypervisors as well The RHEL 7 version string is hard coded and misses CentOS 7. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack centos7-cgroup-cmount Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/719.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #719 commit 14013d5d1b1e802ca06ef29028706cbb54d7af1a Author: Remi Bergsma git...@remi.nl Date: 2015-08-19T14:20:20Z fixing white space and formatting commit d1cb4c7d501eb7e37d04bc99b0482c28c8bec38b Author: Remi Bergsma git...@remi.nl Date: 2015-08-19T14:26:48Z RHEL 7 and CentOS 7 need the same fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/718#issuecomment-132639320 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/718#issuecomment-132644284 @bhaisaab Let's make sure this ends up in master as well! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Apply RHEL 7 fix for comounted cgroups to...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/719#issuecomment-132636564 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/720#issuecomment-132645009 @borisroman Can you add the test output please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Apply RHEL 7 fix for comounted cgroups to...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-132698414 Got your comments, sadly we have not analyzed which classes are singleton or not. We have opened a jira ticket to that: https://issues.apache.org/jira/browse/CLOUDSTACK-8750 If someone need a hand, just shoot an email. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132697192 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/718#discussion_r37437656
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
---
@@ -287,7 +287,7 @@ private void deleteExitingLinkLocalRouteTable(String
linkLocalBr) {
for (String line : lines) {
String[] tokens = line.split( );
if (!tokens[2].equalsIgnoreCase(linkLocalBr)) {
--- End diff --
For this PR we cannot make any changes now that it is merged already;
perhaps send a new PR or I can pick it up later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
Build failed in Jenkins: build-master-noredist #4547
See http://jenkins.buildacloud.org/job/build-master-noredist/4547/changes Changes: [github] CLOUDSTACK-8748: VM UUID accessible in CreateVMSnapshotCommand and RevertToVMSnapshotCommand -- [...truncated 10408 lines...] [INFO] [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ cloud-plugin-storage-volume-nexenta --- [INFO] Building jar: http://jenkins.buildacloud.org/job/build-master-noredist/ws/plugins/storage/volume/nexenta/target/cloud-plugin-storage-volume-nexenta-4.6.0-SNAPSHOT.jar [INFO] [INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ cloud-plugin-storage-volume-nexenta --- [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default) @ cloud-plugin-storage-volume-nexenta --- [INFO] Tests are skipped. [INFO] [INFO] --- maven-install-plugin:2.3.1:install (default-install) @ cloud-plugin-storage-volume-nexenta --- [INFO] Installing http://jenkins.buildacloud.org/job/build-master-noredist/ws/plugins/storage/volume/nexenta/target/cloud-plugin-storage-volume-nexenta-4.6.0-SNAPSHOT.jar to /home/jenkins/.m2/repository/org/apache/cloudstack/cloud-plugin-storage-volume-nexenta/4.6.0-SNAPSHOT/cloud-plugin-storage-volume-nexenta-4.6.0-SNAPSHOT.jar [INFO] Installing http://jenkins.buildacloud.org/job/build-master-noredist/ws/plugins/storage/volume/nexenta/pom.xml to /home/jenkins/.m2/repository/org/apache/cloudstack/cloud-plugin-storage-volume-nexenta/4.6.0-SNAPSHOT/cloud-plugin-storage-volume-nexenta-4.6.0-SNAPSHOT.pom [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-midonet --- [INFO] Surefire report directory: http://jenkins.buildacloud.org/job/build-master-noredist/ws/plugins/network-elements/midonet/target/surefire-reports --- T E S T S --- Running com.cloud.network.element.MidoNetElementTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.395 sec - in org.apache.cloudstack.storage.motion.VmwareStorageMotionStrategyTest Running com.cloud.hypervisor.vmware.resource.VmwareResourceTest log4j:WARN No appenders could be found for logger (com.cloud.network.element.MidoNetElement). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. [INFO] [INFO] --- license-maven-plugin:2.7:check (cloudstack-checklicence) @ cloud-plugin-storage-volume-cloudbyte --- [INFO] Checking licenses... [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-storage-volume-cloudbyte --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-noredist/ws/plugins/storage/volume/cloudbyte/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-storage-volume-cloudbyte --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-storage-volume-cloudbyte --- [INFO] Tests are skipped. [INFO] [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ cloud-plugin-storage-volume-cloudbyte --- Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.654 sec - in com.cloud.network.element.MidoNetElementTest [INFO] Building jar: http://jenkins.buildacloud.org/job/build-master-noredist/ws/plugins/storage/volume/cloudbyte/target/cloud-plugin-storage-volume-cloudbyte-4.6.0-SNAPSHOT.jar Results : Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ cloud-plugin-network-midonet --- [INFO] Building jar: http://jenkins.buildacloud.org/job/build-master-noredist/ws/plugins/network-elements/midonet/target/cloud-plugin-network-midonet-4.6.0-SNAPSHOT.jar [INFO] [INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ cloud-plugin-network-midonet --- [INFO] [INFO] --- maven-install-plugin:2.3.1:install (default-install) @ cloud-plugin-network-midonet --- [INFO] Installing http://jenkins.buildacloud.org/job/build-master-noredist/ws/plugins/network-elements/midonet/target/cloud-plugin-network-midonet-4.6.0-SNAPSHOT.jar to /home/jenkins/.m2/repository/org/apache/cloudstack/cloud-plugin-network-midonet/4.6.0-SNAPSHOT/cloud-plugin-network-midonet-4.6.0-SNAPSHOT.jar [INFO] Installing http://jenkins.buildacloud.org/job/build-master-noredist/ws/plugins/network-elements/midonet/pom.xml to /home/jenkins/.m2/repository/org/apache/cloudstack/cloud-plugin-network-midonet/4.6.0-SNAPSHOT/cloud-plugin-network-midonet-4.6.0-SNAPSHOT.pom [INFO] [INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ cloud-plugin-storage-volume-cloudbyte --- [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default) @
[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/721#issuecomment-132706089 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/718#discussion_r37435429
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
---
@@ -287,7 +287,7 @@ private void deleteExitingLinkLocalRouteTable(String
linkLocalBr) {
for (String line : lines) {
String[] tokens = line.split( );
if (!tokens[2].equalsIgnoreCase(linkLocalBr)) {
--- End diff --
Consider the following as a bit of extra safety in the event of malformed
input beginning at line 289:
```
if (tokens != null tokens.length 2) {
continue;
}
final String device = tokens[2];
if (!Strings.isNullOrEmpty(device)
!device.equalsIgnoreCase(linkLocalBr)) {
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Please mention lines in tests which is justifying your statement They prove
that the fragile integrity of the class hierarchy that has been meddled with so
often is still intact”
I have no problem with solution. I have problem with tests.
For reference see section Superficial Test Coverage @
http://www.exubero.com/junit/antipatterns.html#Manual_Assertions .
On 19-Aug-2015, at 7:59 PM, Daan Hoogland
daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote:
Anshul,
I do not think a reference for the intricate problems we face with the
hierarchy of the CitrixResourceBase and descendants is fair to ask. I think the
burdon of proof is with you and not Rafael.
The tests do not just prove that the assignment works as in you example. They
prove that the fragile integrity of the class hierarchy that has been meddled
with so often is still intact. Rafael and Lucas had a problem at hand and dealt
with it according to circumstances. Your example to discredit this is over
simplified and does not include the essence of what can go wrong with the way
the xenserver resource hierarchy is set up. The solution choosen works, solves
a problem and is a reference in it self. If you think it is bad practice,
please provide with a reference as to why it is bad.
On Wed, Aug 19, 2015 at 3:39 PM, Rafael Weingärtner
rafaelweingart...@gmail.commailto:rafaelweingart...@gmail.com wrote:
@anshul1886 I agree that we disagree.
Folks I do not know what to do in this case, I will not looking for references
to support what I said and did. Whatever you guys decided I will do (remove or
let the test cases there).
On Wed, Aug 19, 2015 at 9:47 AM, Anshul Gangwar
anshul.gang...@citrix.commailto:anshul.gang...@citrix.com wrote:
Let me summarise the tests
class A {
x(){
return “d”; a constant
}
}
test
p=“d”
Assert( A.x() = p)
Which can be reduced to
class A {
q=“d;
}
Here q is replacement for x method as it is only returning a constant
now test is
p=“d
assert (p=q)
To me this basically proves that java assignment works and nothing more than
that.
Here A can be any class. But in this context it is subclass of something.
I can’t even figure out how super class coming into picture in tests which you
are trying to say.
Please explain in context of above example how it is testing more than java
assignment.
Regards,
Anshul
On 19-Aug-2015, at 5:16 pm, Anshul Gangwar
anshul.gang...@citrix.commailto:anshul.gang...@citrix.com wrote:
Can you point to any reference/blog which justifies writing tests for this kind
of scenario?
What I can infer from these tests is that that there are two scenarios
1) Method will not change
In that case it doesn’t make sense to put test for never changing method.
2) Method will change
In that case you have to change test to make it pass and then also it
doesn’t make sense as you have to change test to make it actually pass.
Regards,
Anshul
On 19-Aug-2015, at 4:18 pm, Rafael Weingärtner
rafaelweingart...@gmail.commailto:rafaelweingart...@gmail.commailto:rafaelweingart...@gmail.com
wrote:
@anshul1886 I totally agree with you that tests are meant to test individual,
and as you pointed the individual code that we want to test is
“getPatchFilePath”. However, that method is abstract, and its “implementation”
that is as simple as returning a constant, changes in few subclasses of
CitrixResourceBase. I am not testing the constant per se; I am testing if each
one of the implementation of that method is returning what I expect.
In one hand, I agree with you that the method could have documentation. I just
have not done that because I really do not know what that String that the
method is returning is. On the other hand, documentation will not save us from
future bugs, as a consequence of some change in those methods. Those tests can
do that automatically.
If that method had a conditional statement and it was coded into
CitrixResourceBase would you think different? The point here is that object
orientation removed those ifs.
On Wed, Aug 19, 2015 at 7:26 AM, Daan Hoogland
daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com
wrote:
a unit can be defined at more then just the method level and in this case
those paths have changed from under us in the past. I am not justifying
testing any constant this way. I am justifying just this work.
On Wed, Aug 19, 2015 at 9:03 AM, Anshul Gangwar
anshul.gang...@citrix.commailto:anshul.gang...@citrix.commailto:anshul.gang...@citrix.com
wrote:
What I mean to say is that unit test are meant to test individual unit
which here is getPatchFilePath and not meant to test hierarchy as you are
pointing out here. By individual unit I mean it doesn’t matter for test
that it is in class A or class B. This way you are kind of justifying that
we should write test for any constant which you have defined has the value
which you have given. Because constant under different classes can have
different values.
Build failed in Jenkins: build-4.5 #513
See http://jenkins.buildacloud.org/job/build-4.5/513/changes Changes: [Rohit Yadav] CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names -- [...truncated 2792 lines...] [INFO] Compiling 7 source files to http://jenkins.buildacloud.org/job/build-4.5/ws/plugins/hypervisors/hyperv/target/classes Build timed out (after 10 minutes). Marking the build as failed. Build was aborted Recording test results [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - Network Elastic Load Balancer [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - Network Internal Load Balancer [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - Palo Alto [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - Network Netscaler [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - Network Nicira NVP [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - BigSwitch Virtual Network Segment [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - Network Brocade VCS [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - Stratosphere SSP [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - Network Opendaylight [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - User Authenticator LDAP [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - User Authenticator MD5 [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] [INFO] Skipping Apache CloudStack Plugin - User Authenticator PBKDF2-SHA-256 [INFO] This project has been banned from the build due to previous failures. [INFO]
Jenkins build is back to normal : build-4.5 #514
See http://jenkins.buildacloud.org/job/build-4.5/514/changes
Build failed in Jenkins: simulator-4.5-singlerun #262
See http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/262/ -- Started by upstream project build-4.5-simulator build number 317 originally caused by: Started by upstream project build-4.5 build number 514 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'.
Build failed in Jenkins: build-master-jdk18 #293
See http://jenkins.buildacloud.org/job/build-master-jdk18/293/changes Changes: [github] CLOUDSTACK-8748: VM UUID accessible in CreateVMSnapshotCommand and RevertToVMSnapshotCommand -- [...truncated 2601 lines...] Results : Tests run: 10, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Hypervisor OracleVM 4.6.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-hypervisor-ovm --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-jdk18/ws/plugins/hypervisors/ovm/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-jdk18/ws/plugins/hypervisors/ovm (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-hypervisor-ovm --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-hypervisor-ovm --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-hypervisor-ovm --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 4 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugin-hypervisor-ovm --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 18 source files to http://jenkins.buildacloud.org/job/build-master-jdk18/ws/plugins/hypervisors/ovm/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-hypervisor-ovm --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-jdk18/ws/plugins/hypervisors/ovm/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-hypervisor-ovm --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-hypervisor-ovm --- [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Open vSwitch 4.6.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-network-ovs --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-jdk18/ws/plugins/network-elements/ovs/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-jdk18/ws/plugins/network-elements/ovs (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-network-ovs --- [INFO] Starting audit... Audit done. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-network-ovs --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-network-ovs --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-plugin-network-ovs --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 33 source files to http://jenkins.buildacloud.org/job/build-master-jdk18/ws/plugins/network-elements/ovs/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-ovs --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-jdk18/ws/plugins/network-elements/ovs/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-ovs --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-ovs --- [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Hypervisor XenServer 4.6.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-hypervisor-xenserver --- [INFO] Deleting
Build failed in Jenkins: build-master-slowbuild #2099
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2099/changes Changes: [github] CLOUDSTACK-8748: VM UUID accessible in CreateVMSnapshotCommand and RevertToVMSnapshotCommand -- [...truncated 9974 lines...] [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-ovs --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/ovs/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-ovs --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-ovs --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-ovs [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-ovs --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/OvsElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/OvsNetworkTopologyGuru.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/OvsTunnelManager.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnel.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnelInterfaceDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnelNetworkDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/VpcDistributedRouterSeqNoDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 706ms [ERROR] Aug 19, 2015 7:45:15 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 49 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 680ms [ERROR] Aug 19, 2015 7:45:16 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 49 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Hypervisor XenServer 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-hypervisor-xenserver --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/hypervisors/xenserver/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/hypervisors/xenserver (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check
Re: [VOTE] Apache Cloudstack 4.5.2 (Round 2)
Hello, +1 (binding) * Building CloudStack ubuntu packages from Git 4.5.2 RC2 tag. * Tests migration from 4.4.4 - 4.5.2rc2 on Ubuntu 14.04.3 (1 mgr, 2 nodes, 1 nfs), basic install, NFS storage, KVM, SystemVM shapeblue, After migration: some tests on HA (crash node), some tests with templates, account management in webui, test localization french, and CS-cloud-init on debian. * Tests fresh install on Ubuntu 14.04.3 (1 mgr, 2 nodes, 1 nfs), advanced network install NFS storage, KVM, SystemVM shapeblue, some tests on HA (crash node), some tests with templates, and CS-cloud-init on debian. * Some tests (register template, create network, register ssh key, create instance, get IP) with Ansible + ansible-cloudstack module from @resmo Thanks for the RM. Milamber Please note this bug message in the last migration step (when I rebooted all systemvm/router). root@cs-mgr1:~# cloudstack-sysvmadm -d 127.0.0.1 -u cloud -p cloudPass -a /usr/bin/cloudstack-sysvmadm: line 21: /etc/rc.d/init.d/functions: No such file or directory Stopping and starting 1 secondary storage vm(s)... Done stopping and starting secondary storage vm(s) Stopping and starting 1 console proxy vm(s)... Done stopping and starting console proxy vm(s) . Stopping and starting 1 running routing vm(s)... Done restarting router(s). On 19/08/2015 10:22, Rohit Yadav wrote: Hi All, I've created a 4.5.2 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442 Commit: 7385441807ba3fde3d45c226df6b1bdd2f36ae26 Tag: 4.5.2-rc2 List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442 Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.5.2/ PGP release keys (signed using 0EE3D884): https://dist.apache.org/repos/dist/release/cloudstack/KEYS The vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Regards.
Build failed in Jenkins: simulator-4.5-singlerun #263
See http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/263/ -- Started by upstream project build-4.5-simulator build number 318 originally caused by: Started by upstream project build-4.5 build number 515 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit] [INFO] - There are errors
Build failed in Jenkins: build-master-slowbuild #2100
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2100/ -- [...truncated 9974 lines...] [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-ovs --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/ovs/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-ovs --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-ovs --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-ovs [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-ovs --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/OvsElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/OvsNetworkTopologyGuru.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/OvsTunnelManager.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnel.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnelInterfaceDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnelNetworkDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/VpcDistributedRouterSeqNoDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 709ms [ERROR] Aug 19, 2015 10:39:05 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 49 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 686ms [ERROR] Aug 19, 2015 10:39:06 PM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 49 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Hypervisor XenServer 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-hypervisor-xenserver --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/hypervisors/xenserver/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/hypervisors/xenserver (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-hypervisor-xenserver --- [INFO] Starting audit... Audit done. [INFO] [INFO] ---
[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/721#issuecomment-132813609 LGTM We've tested the git-pr script with #705 #709 #708. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-slowbuild #2101
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2101/ -- [...truncated 9974 lines...] [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-ovs --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/ovs/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-ovs --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-ovs --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-ovs [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-ovs --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/OvsElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/OvsNetworkTopologyGuru.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/OvsTunnelManager.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnel.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnelInterfaceDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnelNetworkDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/VpcDistributedRouterSeqNoDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 715ms [ERROR] Aug 20, 2015 1:45:07 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 49 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 682ms [ERROR] Aug 20, 2015 1:45:08 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 49 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Hypervisor XenServer 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-hypervisor-xenserver --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/hypervisors/xenserver/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/hypervisors/xenserver (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-hypervisor-xenserver --- [INFO] Starting audit... Audit done. [INFO] [INFO] ---
[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/718 CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names This tries to avoid cleaning by a device name. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack kvm-linklocal-cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/718.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #718 commit ee5638e460c3a6437d5f26764b4c6ec4226652c5 Author: Rohit Yadav rohit.ya...@shapeblue.com Date: 2015-08-19T10:08:31Z CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names This tries to avoid cleaning by a device name. Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/715#issuecomment-132532173 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
a unit can be defined at more then just the method level and in this case those paths have changed from under us in the past. I am not justifying testing any constant this way. I am justifying just this work. On Wed, Aug 19, 2015 at 9:03 AM, Anshul Gangwar anshul.gang...@citrix.com wrote: What I mean to say is that unit test are meant to test individual unit which here is getPatchFilePath and not meant to test hierarchy as you are pointing out here. By individual unit I mean it doesn’t matter for test that it is in class A or class B. This way you are kind of justifying that we should write test for any constant which you have defined has the value which you have given. Because constant under different classes can have different values. Can you point to any reference which justifies writing tests for this kind of scenario? Regards, Anshul On 19-Aug-2015, at 11:34 am, Daan Hoogland daan.hoogl...@gmail.com wrote: On Wed, Aug 19, 2015 at 5:56 AM, anshul1886 g...@git.apache.org wrote: If the purpose is to make sure that path is not modified by other developer then adding note/comment on top of that line makes more sense. Even adding note is kind of implicit as paths are kind of constants which any developer would think before changing. Tests are not meant for that purpose. Anshul, I hope I don't understand you when you say, 'tests are not meant for that pupose'. When the hierarchy is changed and this leads to the constants to be used in a different way in different classes, an error occurs due to this that will be caught by these tests. This is exactly what unit tests are for. class A has constant pth=/root. class B:A has constant pth=/root/bla. class C:B has no constant hence pth=/root/bla. now C is changed to C:A and its pth is there fore changed to /root. This is uninteded and a mistake that will be caught by such tests. -- Daan -- Daan
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[DISCUSS] apache builds vs reviews
LS, I have disabled cloudstack-pull-request on builds.apache.org as we now have cloudstack-pull-rat and cloudstack-pull-analysis and also still have jenkins.bac.o. I want to further unburdon the apache jenkins web by scheduling down other jobs to once a day. noticably this is the master build but also the rat-catcher. If we do so review on PRs for these issues become more important hence looking at the output of pull request jobs. Can we live with that? regards, -- Daan
Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
@anshul1886 I totally agree with you that tests are meant to test individual, and as you pointed the individual code that we want to test is “getPatchFilePath”. However, that method is abstract, and its “implementation” that is as simple as returning a constant, changes in few subclasses of CitrixResourceBase. I am not testing the constant per se; I am testing if each one of the implementation of that method is returning what I expect. In one hand, I agree with you that the method could have documentation. I just have not done that because I really do not know what that String that the method is returning is. On the other hand, documentation will not save us from future bugs, as a consequence of some change in those methods. Those tests can do that automatically. If that method had a conditional statement and it was coded into CitrixResourceBase would you think different? The point here is that object orientation removed those ifs. On Wed, Aug 19, 2015 at 7:26 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: a unit can be defined at more then just the method level and in this case those paths have changed from under us in the past. I am not justifying testing any constant this way. I am justifying just this work. On Wed, Aug 19, 2015 at 9:03 AM, Anshul Gangwar anshul.gang...@citrix.com wrote: What I mean to say is that unit test are meant to test individual unit which here is getPatchFilePath and not meant to test hierarchy as you are pointing out here. By individual unit I mean it doesn’t matter for test that it is in class A or class B. This way you are kind of justifying that we should write test for any constant which you have defined has the value which you have given. Because constant under different classes can have different values. Can you point to any reference which justifies writing tests for this kind of scenario? Regards, Anshul On 19-Aug-2015, at 11:34 am, Daan Hoogland daan.hoogl...@gmail.com wrote: On Wed, Aug 19, 2015 at 5:56 AM, anshul1886 g...@git.apache.org wrote: If the purpose is to make sure that path is not modified by other developer then adding note/comment on top of that line makes more sense. Even adding note is kind of implicit as paths are kind of constants which any developer would think before changing. Tests are not meant for that purpose. Anshul, I hope I don't understand you when you say, 'tests are not meant for that pupose'. When the hierarchy is changed and this leads to the constants to be used in a different way in different classes, an error occurs due to this that will be caught by these tests. This is exactly what unit tests are for. class A has constant pth=/root. class B:A has constant pth=/root/bla. class C:B has no constant hence pth=/root/bla. now C is changed to C:A and its pth is there fore changed to /root. This is uninteded and a mistake that will be caught by such tests. -- Daan -- Daan -- Rafael Weingärtner
[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/715#issuecomment-132530052 travis builds, awaiting analysis build but LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132540113 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132897134 @karuturi I reverted the commit to master (044e685c92ef98d08771f04c766ec42d97fe5c35) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/721#issuecomment-132898937 LGTM, I used it to merge this PR ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/721 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132899406 Thanks @remibergsma --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Jenkins build is back to normal : build-master-noredist #4548
See http://jenkins.buildacloud.org/job/build-master-noredist/4548/changes
Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
On Wed, Aug 19, 2015 at 5:56 AM, anshul1886 g...@git.apache.org wrote: If the purpose is to make sure that path is not modified by other developer then adding note/comment on top of that line makes more sense. Even adding note is kind of implicit as paths are kind of constants which any developer would think before changing. Tests are not meant for that purpose. Anshul, I hope I don't understand you when you say, 'tests are not meant for that pupose'. When the hierarchy is changed and this leads to the constants to be used in a different way in different classes, an error occurs due to this that will be caught by these tests. This is exactly what unit tests are for. class A has constant pth=/root. class B:A has constant pth=/root/bla. class C:B has no constant hence pth=/root/bla. now C is changed to C:A and its pth is there fore changed to /root. This is uninteded and a mistake that will be caught by such tests. -- Daan
[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/625#issuecomment-132472682 @runseb Yes, indeed. But the PR is not ready to merge yet, it's blocked by a GSON issue which I don't know how to resolve. This is what @DaanHoogland found out: the gson issue is with primitive types. support was explicitely dropped and these are used in the tests. We should make sure they are not used in the real code and adjust the test. (ref PR625 and CLOUDSTACK-8708) But yes, this should go on the ML and very, very clearly in the Release Notes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
What I mean to say is that unit test are meant to test individual unit which here is getPatchFilePath and not meant to test hierarchy as you are pointing out here. By individual unit I mean it doesn’t matter for test that it is in class A or class B. This way you are kind of justifying that we should write test for any constant which you have defined has the value which you have given. Because constant under different classes can have different values. Can you point to any reference which justifies writing tests for this kind of scenario? Regards, Anshul On 19-Aug-2015, at 11:34 am, Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote: On Wed, Aug 19, 2015 at 5:56 AM, anshul1886 g...@git.apache.orgmailto:g...@git.apache.org wrote: If the purpose is to make sure that path is not modified by other developer then adding note/comment on top of that line makes more sense. Even adding note is kind of implicit as paths are kind of constants which any developer would think before changing. Tests are not meant for that purpose. Anshul, I hope I don't understand you when you say, 'tests are not meant for that pupose'. When the hierarchy is changed and this leads to the constants to be used in a different way in different classes, an error occurs due to this that will be caught by these tests. This is exactly what unit tests are for. class A has constant pth=/root. class B:A has constant pth=/root/bla. class C:B has no constant hence pth=/root/bla. now C is changed to C:A and its pth is there fore changed to /root. This is uninteded and a mistake that will be caught by such tests. -- Daan
Re: Review PRs: please help!
Hi, Understood :) I'm trying, but most PRs are VMWare or Xen and I personally don't know anything about that code, so I don't feel good in giving in LGTM on such a PR. This is from my personal view, but I only want to give a LGTM on code I understand. KVM and RBD storage PRs? Happy to review them! Wido On 18-08-15 17:29, Remi Bergsma wrote: Hi all, Could you please have a look at the PRs we have waiting [1] and review them? Test it, look at the code or otherwise review them. Add comments, or add a LGTM when you think it’s OK. Even if you review just one PR per day it already helps :-) I’ll keep an eye on them as well and will merge when the requirements are met. Thanks, Remi [1] https://github.com/apache/cloudstack/pulls
[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-132515960 Thanks for the merge. yes not necessary, the PR #699 make the works for master branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/717 CLOUDSTACK-8748: VM UUID accessible in CreateVMSnapshotCommand and Re⦠â¦vertToVMSnapshotCommand This patch makes it possible to expose VM UUID to subsystems, this can be useful for implementing VM Snapshots for KVM in future. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack vm-snapshots-uuid-expose Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/717.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #717 commit 0062ff2672e257f2a4290e054e23ef4333a34983 Author: Rohit Yadav rohit.ya...@shapeblue.com Date: 2015-08-19T10:01:37Z CLOUDSTACK-8748: VM UUID accessible in CreateVMSnapshotCommand and RevertToVMSnapshotCommand This patch makes it possible to expose VM UUID to subsystems, this can be useful for implementing VM Snapshots for KVM in future. Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-132476722 test result of enough storage is not available to perform test put storage in maintenance mode and start ha vm and check usage ... SKIP: sufficient storage not available in any cluster for zone 90d85d89-01c4-4a91-b76e-eedf947b40f6 -- Ran 1 test in 4.059s OK (SKIP=1) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Review PRs: please help!
Hello Wido, PR from me are on the localization and web UI, easy to review ;-) https://github.com/apache/cloudstack/pull/697 https://github.com/apache/cloudstack/pull/699 https://github.com/apache/cloudstack/pull/712 Milamber On 19/08/2015 08:22, Wido den Hollander wrote: Hi, Understood :) I'm trying, but most PRs are VMWare or Xen and I personally don't know anything about that code, so I don't feel good in giving in LGTM on such a PR. This is from my personal view, but I only want to give a LGTM on code I understand. KVM and RBD storage PRs? Happy to review them! Wido On 18-08-15 17:29, Remi Bergsma wrote: Hi all, Could you please have a look at the PRs we have waiting [1] and review them? Test it, look at the code or otherwise review them. Add comments, or add a LGTM when you think it’s OK. Even if you review just one PR per day it already helps :-) I’ll keep an eye on them as well and will merge when the requirements are met. Thanks, Remi [1] https://github.com/apache/cloudstack/pulls
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/699#discussion_r37389129 --- Diff: client/WEB-INF/classes/resources/messages_es.properties --- @@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, saltar esta gu\u00eda label.snapshot=Instant\u00c3\u00a1nea label.snapshot.limits=instant\u00c3\u00a1neas L\u00c3\u00admites label.snapshot.name=Nombre de instant\u00c3\u00a1neas -label.snapshot.schedule=Lista de instant\u00c3\u00a1neas +label.snapshot.s=instant\u00c3\u00a1neas --- End diff -- Another commit from Mike (Setup != Set up) https://git1-us-west.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=client/WEB-INF/classes/resources/messages.properties;h=f81a196cf711d709af6a399a6f5e6d275dd7e951;hp=dcbf6c83a24a4cfd6977659d4f531c64c1786edb;hb=e640e0cf;hpb=c0230273cdbdf2558f4a0802d177bd5757de34fd = New value for a key on the source language file means remove the old translation (key/value) until a translator (re)translate the new value --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-132488846 @kishankavala @DaanHoogland Can any of you review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Jenkins build is back to normal : build-master-slowbuild #2095
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2095/changes
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/699 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/697 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [VOTE] Apache Cloudstack 4.5.2 (Round 2)
+1 (binding) Tested against KVM (Ubuntu 14.04, Ubuntu 14.10 and CentOS 6.5 based hosts), tested local storage, VM migrations and basic network (with/without SG) and adv network (pf and firewall rules). Upgraded to 4.5.2-rc2, running a local cloudstack/KVM deployment with 4.5.2-rc1 since last 5 days (all good :)). On 19-Aug-2015, at 2:52 pm, Rohit Yadav bhais...@apache.orgmailto:bhais...@apache.org wrote: Hi All, I've created a 4.5.2 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442 Commit: 7385441807ba3fde3d45c226df6b1bdd2f36ae26 Tag: 4.5.2-rc2 List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442 Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.5.2/ PGP release keys (signed using 0EE3D884): https://dist.apache.org/repos/dist/release/cloudstack/KEYS The vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Regards. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge - rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [VOTE] Release Apache CloudStack CloudMonkey 5.3.2
-1 (binding) Based on a recent PR discussion, found that a regression in CM 5.3.2 RC1 where public keys etc were double encoded. That commit is reverted now. Due to this and also the end of the voting window, I’m calling off this round and starting a new round. On 14-Aug-2015, at 5:00 pm, Rajani Karuturi raj...@apache.orgmailto:raj...@apache.org wrote: +1(binding) installed latest from master, did some basic testing. Everything working as expected. ~Rajani On Fri, Aug 14, 2015 at 4:44 PM, Rohit Yadav rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com wrote: +1 (binding) Tested by deploying a KVM zone using a cloudmonkey/bash automation script, worked for me. On 14-Aug-2015, at 4:25 pm, Remi Bergsma rberg...@schubergphilis.commailto:rberg...@schubergphilis.com wrote: +1 (binding) Compiled, installed and did some basic testing. Then run some dev/test scripts to deploy test infra with cloudmonkey and that all works fine. On 14 Aug 2015, at 11:08, Rohit Yadav bhais...@apache.orgmailto:bhais...@apache.org wrote: Hi All, I've created a 5.3.2 release of CloudMonkey, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack- cloudmonkey.git;a=shortlog;h=refs/heads/master Commit: 1bc53d20349b6bae4ae4432e7cb6c6261c1dd290 List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=blob_plain;f=CHANGES.md;hb=master Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-5.3.2/ PGP release keys (signed using 0EE3D884): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Due to upcoming weekends, the vote will be open for 120 hours (or 5 days). For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Regards. Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Build http://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment framework http://shapeblue.com/csforge/ CloudStack Consulting http://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineering http://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Support http://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courses http://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India
Build failed in Jenkins: simulator-4.5-singlerun #261
See http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/261/ -- Started by upstream project build-4.5-simulator build number 316 originally caused by: Started by upstream project build-4.5 build number 512 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on simulator in workspace http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/ /usr/bin/git rev-parse --is-inside-work-tree # timeout=400 Fetching changes from the remote Git repository /usr/bin/git config remote.origin.url https://git-wip-us.apache.org/repos/asf/cloudstack.git # timeout=400 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/cloudstack.git /usr/bin/git --version # timeout=400 /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/cloudstack.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016) at hudson.scm.SCM.checkout(SCM.java:484) at hudson.model.AbstractProject.checkout(AbstractProject.java:1258) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:622) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:528) at hudson.model.Run.execute(Run.java:1759) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240) Caused by: hudson.plugins.git.GitException: Command /usr/bin/git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/cloudstack.git +refs/heads/*:refs/remotes/origin/* returned status code 128: stdout: stderr: error: while accessing https://git-wip-us.apache.org/repos/asf/cloudstack.git/info/refs fatal: HTTP request failed at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) at ..remote call to simulator(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356) at hudson.remoting.UserResponse.retrieve(UserRequest.java:221) at hudson.remoting.Channel.call(Channel.java:752) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor375.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at sun.proxy.$Proxy46.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733) ... 11 more ERROR: Error fetching remote repo 'origin' [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing JUnit [xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'xunit.xml' relative to 'http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/ws/' for the testing framework 'JUnit'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'JUnit'? [xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'xunit.xml'. Configuration error?. [xUnit] [INFO] - Failing BUILD. [xUnit] [INFO] - There are errors
[VOTE] Release Apache CloudStack CloudMonkey 5.3.2 (Round 2)
Hi All, I've created a 5.3.2 release of CloudMonkey, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=shortlog;h=refs/heads/master Commit: 653dcca9e008e20fee83f0b40f388611ad931d15 List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=blob_plain;f=CHANGES.md;hb=master Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-5.3.2/ PGP release keys (signed using 0EE3D884): https://dist.apache.org/repos/dist/release/cloudstack/KEYS The vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Regards.
Re: [VOTE] Apache Cloudstack 4.5.2
Due to not enough votes and testing efforts for this RC to be passed, and a recent useful commits on 4.5 (translations and router migration related: https://github.com/apache/cloudstack/commit/b655104b77286889cc849a5bad4fcceb38234606) I’m calling this round off. Will start a new round now. On 14-Aug-2015, at 1:49 pm, Rohit Yadav bhais...@apache.orgmailto:bhais...@apache.org wrote: Hi All, I've created a 4.5.2 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150814T1334 Commit: caa411305a76bb9aac66600853a8193294874a1b Tag: 4.5.2-rc1 List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150814T1334 Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.5.2/ PGP release keys (signed using 0EE3D884): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Due to upcoming weekends, the vote will be open for 120 hours (or 5 days). For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Regards. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge – rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
[VOTE] Apache Cloudstack 4.5.2 (Round 2)
Hi All, I've created a 4.5.2 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442 Commit: 7385441807ba3fde3d45c226df6b1bdd2f36ae26 Tag: 4.5.2-rc2 List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442 Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.5.2/ PGP release keys (signed using 0EE3D884): https://dist.apache.org/repos/dist/release/cloudstack/KEYS The vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Regards.
Re: [VOTE] Release Apache CloudStack CloudMonkey 5.3.2 (Round 2)
+1 (binding) Tested to deploy KVM zones using an existing cloudmonkey/bash script, and tested to register ssh public keys. On 19-Aug-2015, at 2:39 pm, Rohit Yadav rohityada...@gmail.commailto:rohityada...@gmail.com wrote: Hi All, I've created a 5.3.2 release of CloudMonkey, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=shortlog;h=refs/heads/master Commit: 653dcca9e008e20fee83f0b40f388611ad931d15 List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=blob_plain;f=CHANGES.md;hb=master Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-5.3.2/ PGP release keys (signed using 0EE3D884): https://dist.apache.org/repos/dist/release/cloudstack/KEYS The vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Regards. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com Blog: bhaisaab.orghttp://bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design Buildhttp://shapeblue.com/iaas-cloud-design-and-build// CSForge - rapid IaaS deployment frameworkhttp://shapeblue.com/csforge/ CloudStack Consultinghttp://shapeblue.com/cloudstack-consultancy/ CloudStack Software Engineeringhttp://shapeblue.com/cloudstack-software-engineering/ CloudStack Infrastructure Supporthttp://shapeblue.com/cloudstack-infrastructure-support/ CloudStack Bootcamp Training Courseshttp://shapeblue.com/cloudstack-training/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [VOTE] Apache Cloudstack 4.5.2 (Round 2)
+1 again We are running 4.5.2 build from Git in production and it is working properly. On 19-08-15 11:22, Rohit Yadav wrote: Hi All, I've created a 4.5.2 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442 Commit: 7385441807ba3fde3d45c226df6b1bdd2f36ae26 Tag: 4.5.2-rc2 List of changes: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150819T1442 Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.5.2/ PGP release keys (signed using 0EE3D884): https://dist.apache.org/repos/dist/release/cloudstack/KEYS The vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Regards.
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/716 Changed AddressFormat elements to reflect changes in IPv4 and IPv6 refactor. See issue CLOUDSTACK-8736 for ongoing effort to clean up network code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8736 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/716.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #716 commit 070083af0dd1d95e7c5e30fd41f46c3e6541e2cc Author: Boris Schrijver bo...@pcextreme.nl Date: 2015-08-17T20:51:57Z Changed AddressFormat elements to reflect changes in IPv4 and IPv6 refactor. See issue CLOUDSTACK-8736 for ongoing effort to clean up network code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/699#discussion_r37388778 --- Diff: client/WEB-INF/classes/resources/messages_es.properties --- @@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, saltar esta gu\u00eda label.snapshot=Instant\u00c3\u00a1nea label.snapshot.limits=instant\u00c3\u00a1neas L\u00c3\u00admites label.snapshot.name=Nombre de instant\u00c3\u00a1neas -label.snapshot.schedule=Lista de instant\u00c3\u00a1neas +label.snapshot.s=instant\u00c3\u00a1neas --- End diff -- you are removing label.snapshot.schedule as well, that was not changed in the commit from Mike, is that intended? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8744 Add missing localization ...
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/712#issuecomment-132484500 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-132484646 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/699#discussion_r37389322 --- Diff: client/WEB-INF/classes/resources/messages_es.properties --- @@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, saltar esta gu\u00eda label.snapshot=Instant\u00c3\u00a1nea label.snapshot.limits=instant\u00c3\u00a1neas L\u00c3\u00admites label.snapshot.name=Nombre de instant\u00c3\u00a1neas -label.snapshot.schedule=Lista de instant\u00c3\u00a1neas +label.snapshot.s=instant\u00c3\u00a1neas --- End diff -- Got it :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/699#issuecomment-132485606 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8744 Add missing localization ...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/712 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/716#issuecomment-132497888 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-132482850 @DaanHoogland @kishankavala Have made changes regarding allowing the duplicate keys for different accounts. DB checks are additional checks and API level checks are done separately. Please review!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-132494328 I merged this only to 4.5. I though merge to master is not required based on #699. Let me know if this needs to go to master as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add scripts to merge PRs and release fixe...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/721#issuecomment-132877083 Thanks for the scripts @miguelaferreira and @remibergsma. It makes merging( and closing) PRs very easy. I also used this script to merge doc prs at [apache/cloudstack-docs-rn](https://github.com/apache/cloudstack-docs-rn) etc. :). Once 4.6 is out, fwd-merge will also be very useful. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132879424 master build broken with the below error http://jenkins.buildacloud.org/job/build-master-slowbuild/2101/consoleText ``` [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /home/jenkins/acs/workspace/build-master-slowbuild/plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java:[1581,51] error: constructor CreateVMSnapshotCommand in class CreateVMSnapshotCommand cannot be applied to given types; [ERROR] required: String,String,VMSnapshotTO,ListVolumeObjectTO,String found: String,VMSnapshotTO,ListVolumeObjectTO,String reason: actual and formal argument lists differ in length /home/jenkins/acs/workspace/build-master-slowbuild/plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java:[1623,53] error: no suitable constructor found for RevertToVMSnapshotCommand(String,VMSnapshotTO,ListVolumeObjectTO,String) [INFO] 2 errors [INFO] - ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build failed in Jenkins: build-master-slowbuild #2102
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2102/ -- [...truncated 9974 lines...] [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-network-ovs --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/network-elements/ovs/test/resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ cloud-plugin-network-ovs --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-plugin-network-ovs --- [INFO] [INFO] cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-ovs [INFO] [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-plugin-network-ovs --- [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/element/OvsElementService.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/OvsNetworkTopologyGuru.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/OvsTunnelManager.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnel.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnelInterfaceDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/OvsTunnelNetworkDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. [cobertura] INFO [main] net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not contain instrumentation information for the file com/cloud/network/ovs/dao/VpcDistributedRouterSeqNoDao.java. Ensure this class was instrumented, and this data file contains the instrumentation information. Report time: 710ms [ERROR] Aug 20, 2015 4:44:53 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 49 classes. [INFO] Cobertura Report generation was successful. [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Report time: 681ms [ERROR] Aug 20, 2015 4:44:54 AM net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler loadCoverageData INFO: Cobertura: Loaded information on 49 classes. [INFO] Cobertura Report generation was successful. [INFO] [INFO] [INFO] Building Apache CloudStack Plugin - Hypervisor XenServer 4.6.0-SNAPSHOT [INFO] [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-plugin-hypervisor-xenserver --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/hypervisors/xenserver/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master-slowbuild/ws/plugins/hypervisors/xenserver (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-plugin-hypervisor-xenserver --- [INFO] Starting audit... Audit done. [INFO] [INFO] ---
