[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
Great. You have done a lot of work already; but, just to make sure things 
do not get lost. What about opening a Jira ticket to expose that customization 
through the ACS API? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@rafaelweingartner That's correct. At this point advanced VM details and 
advanced template details have no UI exposure. At some point we can bring in PR 
to show this in UI and allow API based changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
Great.I am ok with the code. I give my LGTM here.
I have one extra question, though.  How do you intend to change that 
parameter (NESTED_VIRTUALIZATION_FLAG) to tell which VM should have the nested 
virtualization enabled? I am assuming that there is no option through the ACS 
API, is that right? If so, you are going to change the parameter directly in 
the database, right?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1542: CLOUDSTACK-9379: Support nested virtualizatio...

2016-08-12 Thread nvazquez
Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1542#discussion_r74667063
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2184,7 +2184,7 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new Pair(vmInternalCSName, vmNameOnVcenter);
 }
 
-private static void configNestedHVSupport(VirtualMachineMO vmMo, 
VirtualMachineTO vmSpec, VirtualMachineConfigSpec vmConfigSpec) throws 
Exception {
+protected static void configNestedHVSupport(VirtualMachineMO vmMo, 
VirtualMachineTO vmSpec, VirtualMachineConfigSpec vmConfigSpec) throws 
Exception {
--- End diff --

Thanks, done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
I had removed it, I saw your comment in that file and I included it in last 
refactor, I forgot to mention it in my last comment :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
There is still one point I would like to highlight. The method 
VmwareResource.configNestedHVSupport does not need to be static.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
Sure, done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@nvazquez, it seems that there was a problem with the Jenkins Job. Can you 
force another build?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1542: CLOUDSTACK-9379: Support nested virtualizatio...

2016-08-12 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1542#discussion_r74655041
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2184,7 +2184,7 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new Pair(vmInternalCSName, vmNameOnVcenter);
 }
 
-private static void configNestedHVSupport(VirtualMachineMO vmMo, 
VirtualMachineTO vmSpec, VirtualMachineConfigSpec vmConfigSpec) throws 
Exception {
+protected static void configNestedHVSupport(VirtualMachineMO vmMo, 
VirtualMachineTO vmSpec, VirtualMachineConfigSpec vmConfigSpec) throws 
Exception {
--- End diff --

This method does not need to be static.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[ANNOUNCE] Apache CloudStack 4.9.0 Released!

2016-08-12 Thread Will Stevens
Hello Everyone,
I am happy to announce the 4.9.0 release of Apache CloudStack.

As the release manager for 4.9.0, I would like to say a big Thank You to
the community for supporting this release.  We were able to merge over 180
PRs and fixed more than 75 bugs with this version.

We had a period without a release manager earlier this year which impacted
our release cadence, but I am happy to report that this is being addressed
in the community.  You can expect a more active release cycle going forward
as well as the introduction of LTS releases.  If you would like more
information, please come join us on the dev@ list.

Release Download: https://cloudstack.apache.org/downloads.html

Release Notes:
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.9.0/

Cheers,

Will


Re: CLOUDSTACK-8682 StrongSwan

2016-08-12 Thread Pierre-Luc Dion
Link done in Jira as comment in case we end up with some other PR related
the strongswan.




On Fri, Aug 12, 2016 at 9:10 AM, Matthew Smart 
wrote:

> Can someone with a little more knowledge or access update Jira for this
> ticket so that it links to the existing PR in some way? Should I just put a
> comment in the ticket linking to it?
>
> It seems, but correct me if I am wrong, that work on Strongswan has
> stalled (last comment by original submitter was May 10th). Assuming that is
> the case I am willing to pick it back up but would be very grateful for any
> help people are willing to provide especially in interacting with your
> testing rigs.
>
> I succeeded in getting the dev environment setup and working to the point
> where I can successfully build the systemvm images yesterday and am reading
> through the testing info on the website today with the goal of getting my
> local environment capable of running tests against my builds.
>
> After reading through the PR comment thread my proposed plan is to use
> that PR as a starting point but follow the advice in the thread by moving
> to strongswan 5.x and altering the configs necessary to make that switch.
> Once there, we see how NAT behaves and deal with the issues that arise.
> Thoughts?
>
> Thanks,
>
> Matthew Smart
> President
> Smart Software Solutions Inc.
> 108 S Pierre St.
> Pierre, SD 57501
>
> Phone: (605) 280-0383
> Skype: msmart13
> Email: msm...@smartsoftwareinc.com
>
> On 08/12/2016 07:22 AM, Pierre-Luc Dion wrote:
>
>> We are also keeping an eye on the remote management VPN.  Last time I've
>> tested the StrongSwan PR, it was not working for the remote MGT vpn,
>>   site-to-site was working.
>>
>> Look like some config would be missing in strongswan configuration. I'm
>> willing to test/provide configuration needed in strongswan.
>>
>> I think it would be ideal to keep jira updated on for this issue since
>> multiple persons might work on it and also are impacted by it.
>>
>> Cheers,
>>
>> PL
>>
>>
>>
>>
>> On Thu, Aug 11, 2016 at 2:56 PM, Matthew Smart <
>> msm...@smartsoftwareinc.com>
>> wrote:
>>
>> Thanks. Been years since I touched Jira/Confluence.
>>>
>>> Matthew Smart
>>> President
>>> Smart Software Solutions Inc.
>>> 108 S Pierre St.
>>> Pierre, SD 57501
>>>
>>> Phone: (605) 280-0383
>>> Skype: msmart13
>>> Email: msm...@smartsoftwareinc.com
>>>
>>> On 08/11/2016 01:50 PM, Simon Weller wrote:
>>>
>>> Matthew,


 If the PR has the jira issue in the PR subject, any updates to the PR
 will be added to the Jira issue.


 See this one for an example:


 
 From: Matthew Smart 
 Sent: Thursday, August 11, 2016 1:40 PM
 To: dev@cloudstack.apache.org
 Subject: Re: CLOUDSTACK-8682 StrongSwan

 Thanks. I figured I was looking in the wrong place. For my future
 reference did you just find this by searching strongswan in the git
 repo? Is there any direct link between a Jira ticket and a git PR?

 Matthew Smart
 President
 Smart Software Solutions Inc.
 108 S Pierre St.
 Pierre, SD 57501

 Phone: (605) 280-0383
 Skype: msmart13
 Email: msm...@smartsoftwareinc.com

 On 08/11/2016 12:15 PM, Simon Weller wrote:

 Matthew,
>
>
> There is an open PR for Strongswan here:
> https://github.com/apache/clou
> dstack/pull/872
>
> [https://avatars3.githubusercontent.com/u/3789214?v=3=400]<
 https://github.com/apache/cloudstack/pull/872>

 Strongswan vpn feature by jayapalu · Pull Request #872 ·
 apache/cloudstack
 github.com
 This features is replacing the openswan ipsec with strongswan ipsec.
 There are template changes for this features and changes are included in
 this PR as well. Tested the s2s vpn functionality usi...



 [https://avatars3.githubusercontent.com/u/3789214?v=3=400]<

> https://github.com/apache/cloudstack/pull/872>
>
> Strongswan vpn feature by jayapalu · Pull Request #872 ·
> apache/cloudstack
> github.com
> This features is replacing the openswan ipsec with strongswan ipsec.
> There are template changes for this features and changes are included
> in
> this PR as well. Tested the s2s vpn functionality usi...
>
> - Si
>
>
>
>
> 
> From: Matthew Smart 
> Sent: Thursday, August 11, 2016 11:48 AM
> To: dev@cloudstack.apache.org
> Subject: CLOUDSTACK-8682 StrongSwan
>
> Hey guys,
>
> I have been banging my head against VPN for awhile now on 4.8.0. I am
> testing on OSX which according to bug Cloudstack-7821 is a won't fix
> until the Virtual Router is altered to use StronSwan instead of

[GitHub] cloudstack issue #872: Strongswan vpn feature

2016-08-12 Thread pdion891
Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/872
  
JIRA reference: https://issues.apache.org/jira/browse/CLOUDSTACK-8682



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
Thanks @rafaelweingartner, I agree with you, I refactored it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-08-12 Thread romain-dartigues
Github user romain-dartigues commented on the issue:

https://github.com/apache/cloudstack/pull/1603
  
Done.
Le me know what you think about it (I don't think Jenkins failed because of 
my edits?).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
I understand the need to create a test. And I agree that it deserves a 
test. What I meant was the following.

IMHO, you could simply remove the final keyword of the variable 
declaration. Sometimes in the ACS code, I have seen people using some 
design/ways of coding without having a good and well-thought explanation for 
them (the use of final is one good example). For instance, variables 
“VmwareEnableNestedVirtualization” and 
“VmwareEnableNestedVirtualizationPerVM” are only used in the 
“VMwareGuru” class. They do not need to be either static or public. 
Moreover, there is no need for those variables to be final. 

If those variables were protected (only), it would be much easier to write 
test cases.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread marcaurele
Github user marcaurele commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1638#discussion_r74588212
  
--- Diff: pom.xml ---
@@ -92,22 +85,22 @@
 1.5.1
 1.2.8
 2.0.4
-2.5
+3.1.0
 1.2
 1.2.1
 
1.0-20081010.060147
 6.0
-
3.2.16.RELEASE
+
4.2.7.RELEASE
--- End diff --

I'll have a look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CLOUDSTACK-8682 StrongSwan

2016-08-12 Thread Matthew Smart
Can someone with a little more knowledge or access update Jira for this 
ticket so that it links to the existing PR in some way? Should I just 
put a comment in the ticket linking to it?


It seems, but correct me if I am wrong, that work on Strongswan has 
stalled (last comment by original submitter was May 10th). Assuming that 
is the case I am willing to pick it back up but would be very grateful 
for any help people are willing to provide especially in interacting 
with your testing rigs.


I succeeded in getting the dev environment setup and working to the 
point where I can successfully build the systemvm images yesterday and 
am reading through the testing info on the website today with the goal 
of getting my local environment capable of running tests against my builds.


After reading through the PR comment thread my proposed plan is to use 
that PR as a starting point but follow the advice in the thread by 
moving to strongswan 5.x and altering the configs necessary to make that 
switch. Once there, we see how NAT behaves and deal with the issues that 
arise. Thoughts?


Thanks,

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com

On 08/12/2016 07:22 AM, Pierre-Luc Dion wrote:

We are also keeping an eye on the remote management VPN.  Last time I've
tested the StrongSwan PR, it was not working for the remote MGT vpn,
  site-to-site was working.

Look like some config would be missing in strongswan configuration. I'm
willing to test/provide configuration needed in strongswan.

I think it would be ideal to keep jira updated on for this issue since
multiple persons might work on it and also are impacted by it.

Cheers,

PL




On Thu, Aug 11, 2016 at 2:56 PM, Matthew Smart 
wrote:


Thanks. Been years since I touched Jira/Confluence.

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com

On 08/11/2016 01:50 PM, Simon Weller wrote:


Matthew,


If the PR has the jira issue in the PR subject, any updates to the PR
will be added to the Jira issue.


See this one for an example:



From: Matthew Smart 
Sent: Thursday, August 11, 2016 1:40 PM
To: dev@cloudstack.apache.org
Subject: Re: CLOUDSTACK-8682 StrongSwan

Thanks. I figured I was looking in the wrong place. For my future
reference did you just find this by searching strongswan in the git
repo? Is there any direct link between a Jira ticket and a git PR?

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com

On 08/11/2016 12:15 PM, Simon Weller wrote:


Matthew,


There is an open PR for Strongswan here: https://github.com/apache/clou
dstack/pull/872


[https://avatars3.githubusercontent.com/u/3789214?v=3=400]<
https://github.com/apache/cloudstack/pull/872>

Strongswan vpn feature by jayapalu · Pull Request #872 ·
apache/cloudstack
github.com
This features is replacing the openswan ipsec with strongswan ipsec.
There are template changes for this features and changes are included in
this PR as well. Tested the s2s vpn functionality usi...



[https://avatars3.githubusercontent.com/u/3789214?v=3=400]<

https://github.com/apache/cloudstack/pull/872>

Strongswan vpn feature by jayapalu · Pull Request #872 ·
apache/cloudstack
github.com
This features is replacing the openswan ipsec with strongswan ipsec.
There are template changes for this features and changes are included in
this PR as well. Tested the s2s vpn functionality usi...

- Si





From: Matthew Smart 
Sent: Thursday, August 11, 2016 11:48 AM
To: dev@cloudstack.apache.org
Subject: CLOUDSTACK-8682 StrongSwan

Hey guys,

I have been banging my head against VPN for awhile now on 4.8.0. I am
testing on OSX which according to bug Cloudstack-7821 is a won't fix
until the Virtual Router is altered to use StronSwan instead of
OpenSwan. I am looking to make the auth system for VPN more
sophisticated but before I look into that it seems prudent to ensure
that the VPN is actually working on the platforms I intend to use.

So I have been looking at Cloudstack-8682 and the associated confluence
entry (
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Repla
cing+openswan+ipsec+with+strongswan+ipsec
). Does anyone know if someone is actively working on this ticket? I
cannot locate any updates in Jira about it after August of 2015 (unless
I am missing something due to inexperience with Jira).

If someone is working on it I would like to know who so I can offer to
help. I will tackle this one if no one is working on it. Just need to
know so 

CLOUDSTACK-7982 - KVM live migration

2016-08-12 Thread ma...@exoscale.ch
Need some Jira love... Can someone give me the rights to assign myself to this 
JIRA issue, or to assign myself directly. Thanks

https://issues.apache.org/jira/browse/CLOUDSTACK-7982

There are new configuration items and some explainations to be documented. I 
thought to write it in the documentation project. Is it required to write 
something in the wiki too?

Marc-Aurèle

--
Exoscale
Av de Provence 4
1007 Lausanne
+41 78 622 42 31
www.exoscale.ch



[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
Packaging result: ✔centos6 ✔centos7 ✔debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1638
Job ID-85


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CLOUDSTACK-8682 StrongSwan

2016-08-12 Thread Pierre-Luc Dion
We are also keeping an eye on the remote management VPN.  Last time I've
tested the StrongSwan PR, it was not working for the remote MGT vpn,
 site-to-site was working.

Look like some config would be missing in strongswan configuration. I'm
willing to test/provide configuration needed in strongswan.

I think it would be ideal to keep jira updated on for this issue since
multiple persons might work on it and also are impacted by it.

Cheers,

PL




On Thu, Aug 11, 2016 at 2:56 PM, Matthew Smart 
wrote:

> Thanks. Been years since I touched Jira/Confluence.
>
> Matthew Smart
> President
> Smart Software Solutions Inc.
> 108 S Pierre St.
> Pierre, SD 57501
>
> Phone: (605) 280-0383
> Skype: msmart13
> Email: msm...@smartsoftwareinc.com
>
> On 08/11/2016 01:50 PM, Simon Weller wrote:
>
>> Matthew,
>>
>>
>> If the PR has the jira issue in the PR subject, any updates to the PR
>> will be added to the Jira issue.
>>
>>
>> See this one for an example:
>>
>>
>> 
>> From: Matthew Smart 
>> Sent: Thursday, August 11, 2016 1:40 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: CLOUDSTACK-8682 StrongSwan
>>
>> Thanks. I figured I was looking in the wrong place. For my future
>> reference did you just find this by searching strongswan in the git
>> repo? Is there any direct link between a Jira ticket and a git PR?
>>
>> Matthew Smart
>> President
>> Smart Software Solutions Inc.
>> 108 S Pierre St.
>> Pierre, SD 57501
>>
>> Phone: (605) 280-0383
>> Skype: msmart13
>> Email: msm...@smartsoftwareinc.com
>>
>> On 08/11/2016 12:15 PM, Simon Weller wrote:
>>
>>> Matthew,
>>>
>>>
>>> There is an open PR for Strongswan here: https://github.com/apache/clou
>>> dstack/pull/872
>>>
>> [https://avatars3.githubusercontent.com/u/3789214?v=3=400]<
>> https://github.com/apache/cloudstack/pull/872>
>>
>> Strongswan vpn feature by jayapalu · Pull Request #872 ·
>> apache/cloudstack
>> github.com
>> This features is replacing the openswan ipsec with strongswan ipsec.
>> There are template changes for this features and changes are included in
>> this PR as well. Tested the s2s vpn functionality usi...
>>
>>
>>
>> [https://avatars3.githubusercontent.com/u/3789214?v=3=400]<
>>> https://github.com/apache/cloudstack/pull/872>
>>>
>>> Strongswan vpn feature by jayapalu · Pull Request #872 ·
>>> apache/cloudstack
>>> github.com
>>> This features is replacing the openswan ipsec with strongswan ipsec.
>>> There are template changes for this features and changes are included in
>>> this PR as well. Tested the s2s vpn functionality usi...
>>>
>>> - Si
>>>
>>>
>>>
>>>
>>> 
>>> From: Matthew Smart 
>>> Sent: Thursday, August 11, 2016 11:48 AM
>>> To: dev@cloudstack.apache.org
>>> Subject: CLOUDSTACK-8682 StrongSwan
>>>
>>> Hey guys,
>>>
>>> I have been banging my head against VPN for awhile now on 4.8.0. I am
>>> testing on OSX which according to bug Cloudstack-7821 is a won't fix
>>> until the Virtual Router is altered to use StronSwan instead of
>>> OpenSwan. I am looking to make the auth system for VPN more
>>> sophisticated but before I look into that it seems prudent to ensure
>>> that the VPN is actually working on the platforms I intend to use.
>>>
>>> So I have been looking at Cloudstack-8682 and the associated confluence
>>> entry (
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Repla
>>> cing+openswan+ipsec+with+strongswan+ipsec
>>> ). Does anyone know if someone is actively working on this ticket? I
>>> cannot locate any updates in Jira about it after August of 2015 (unless
>>> I am missing something due to inexperience with Jira).
>>>
>>> If someone is working on it I would like to know who so I can offer to
>>> help. I will tackle this one if no one is working on it. Just need to
>>> know so I know where to begin.
>>>
>>> Thanks,
>>>
>>>
>>> --
>>> Matthew Smart
>>> President
>>> Smart Software Solutions Inc.
>>> 108 S Pierre St.
>>> Pierre, SD 57501
>>>
>>> Phone: (605) 280-0383
>>> Skype: msmart13
>>> Email: msm...@smartsoftwareinc.com
>>>
>>>
>>>
>>
>


Request for comments: Moving to Spring 4 and Java 8

2016-08-12 Thread Rohit Yadav
All,


It's about time to migrate master to Java 8 JDK and Spring 4. Please help 
review the following PRs:

https://github.com/apache/cloudstack/pull/1638


There are three outstanding issues that I need help and feedback on:


1. F5 plugin fails to build due to issue likely in the axis dependency library, 
I've disabled it from the build now. Do we have a F5 developer/maintainer who 
can look at it.


2. Two unit tests failures due to Spring 4 migration:

com/cloud/vm/DeploymentPlanningManagerImplTest.java

com/globo/globodns/cloudstack/resource/GloboDnsResourceTest.java


Do we have anyone who can help fix the above tests? Deployment planner 
developers, or globo-dns plugin maintainers?


3. In general, the end-to-end testing of plugins. There may be plugins which 
are not maintained or used anymore, we need discuss how to deal with them 
moving forward. As a first step we may want to start disable them from the 
build, especially those failing builds.


Comments, feedback? Thanks.


Regards.

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1638#discussion_r74580238
  
--- Diff: pom.xml ---
@@ -92,22 +85,22 @@
 1.5.1
 1.2.8
 2.0.4
-2.5
+3.1.0
 1.2
 1.2.1
 
1.0-20081010.060147
 6.0
-
3.2.16.RELEASE
+
4.2.7.RELEASE
--- End diff --

I've bumped the version to 4.3.2 now, there are two failing unit tests now 
that need fixing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread marcaurele
Github user marcaurele commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1638#discussion_r74575182
  
--- Diff: pom.xml ---
@@ -92,22 +85,22 @@
 1.5.1
 1.2.8
 2.0.4
-2.5
+3.1.0
 1.2
 1.2.1
 
1.0-20081010.060147
 6.0
-
3.2.16.RELEASE
+
4.2.7.RELEASE
--- End diff --

Ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1638#discussion_r74574871
  
--- Diff: pom.xml ---
@@ -92,22 +85,22 @@
 1.5.1
 1.2.8
 2.0.4
-2.5
+3.1.0
 1.2
 1.2.1
 
1.0-20081010.060147
 6.0
-
3.2.16.RELEASE
+
4.2.7.RELEASE
--- End diff --

@marcaurele 4.3 is slightly different than 4.2; there were several unit 
test failures with 4.3 so for now I've avoided switching to 4.3.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
Packaging result: ✔centos6 ✖centos7 ✖debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1638
Job ID-83


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread marcaurele
Github user marcaurele commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1638#discussion_r74574588
  
--- Diff: pom.xml ---
@@ -92,22 +85,22 @@
 1.5.1
 1.2.8
 2.0.4
-2.5
+3.1.0
 1.2
 1.2.1
 
1.0-20081010.060147
 6.0
-
3.2.16.RELEASE
+
4.2.7.RELEASE
--- End diff --

Any particular reason to not use the version 4.3.2 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1638


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1638

CLOUDSTACK-9456: Use Spring 4 and Java 8

This changes makes CloudStack use spring 4 and Java 8:

- Bumps jdk version to 1.8
- Use jdk8 for Travis CI
- Bump spring-framework version to 4.x and Jetty to version that runs 
with JDK8
- Bump servet dependency version
- Migrates various xmls to use version independent schema uris

Outstanding issues:
- F5 plugin as it fails to build due to issue in axis/library 
dependency (Stub not accessible), it is commented/disabled for now
- A unit test in server that fails which I could not fix so I've 
disabled it for now:
  com/cloud/vm/DeploymentPlanningManagerImplTest.java
- Testing of various non-standard plugins such as network and storage 
plugins etc.

Since, this is a big change pinging for review -- @jburwell @karuturi @wido 
@murali-reddy @abhinandanprateek @DaanHoogland @GaborApatiNagy @JayapalUradi 
@kishankavala @K0zka @nvazquez @rafaelweingartner @pyr and others

@blueorangutan package

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack spring4-java8-only

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1638


commit 8ed1f0187aa92203ae8f58a4cfacec26191b3419
Author: Rohit Yadav 
Date:   2016-05-13T10:26:48Z

CLOUDSTACK-9456: Update Spring version in maven poms and use Java 8

- Bumps jdk version to 1.8
- Use jdk8 for Travis CI
- Bump spring-framework version to 4.x and Jetty to version that runs with 
JDK8
- Bump servet dependency version

Outstanding issues:
- Disables F5 plugin as it fails to build
- Disable a unit test in server that fails:
  com/cloud/vm/DeploymentPlanningManagerImplTest.java

Signed-off-by: Rohit Yadav 

commit 4a0d5c000be8767bf75fb0668df227c3bd92dee3
Author: Rohit Yadav 
Date:   2016-05-13T10:46:15Z

CLOUDSTACK-9456: Migrate spring xmls to version 4

Fixes schema locations that are 3.0 dependent in various xmls.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
Packaging result: ✖centos6 ✖centos7 ✖debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1638
Job ID-82


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@rafaelweingartner I agree it wasn't the best solution but I meant to 
include it for the sake of testing `configureNestedVirtualization` method. 
Which approach can I take to test this method, as it uses configuration final 
variables to determinate enabling/desabling nested virtualization?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
@blueorangutan I see, slaves need Java8 installed. Fixing that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
Packaging result: ✖centos6 ✖centos7 ✖debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1638
Job ID-81


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1638

CLOUDSTACK-9456: Use Spring 4 and Java 8

This changes makes CloudStack use spring 4 and Java 8:

- Bumps jdk version to 1.8
- Use jdk8 for Travis CI
- Bump spring-framework version to 4.x and Jetty to version that runs 
with JDK8
- Bump servet dependency version
- Migrates various xmls to use version independent schema uris

Outstanding issues:
- F5 plugin as it fails to build due to issue in axis/library 
dependency (Stub not accessible), it is commented/disabled for now
- A unit test in server that fails which I could not fix so I've 
disabled it for now:
  com/cloud/vm/DeploymentPlanningManagerImplTest.java
- Testing of various non-standard plugins such as network and storage 
plugins etc.

Since, this is a big change pinging for review -- @jburwell @karuturi @wido 
@murali-reddy @abhinandanprateek @DaanHoogland @GaborApatiNagy @JayapalUradi 
@kishankavala @K0zka @nvazquez @rafaelweingartner @pyr and others

@blueorangutan package

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack spring4-java8-only

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1638


commit c0f1890665d02ce2ddf3ca0318b289c609b51b90
Author: Rohit Yadav 
Date:   2016-05-13T10:26:48Z

CLOUDSTACK-9456: Update Spring version in maven poms and use Java 8

- Bumps jdk version to 1.8
- Use jdk8 for Travis CI
- Bump spring-framework version to 4.x and Jetty to version that runs with 
JDK8
- Bump servet dependency version

Outstanding issues:
- Disables F5 plugin as it fails to build
- Disable a unit test in server that fails:
  com/cloud/vm/DeploymentPlanningManagerImplTest.java

Signed-off-by: Rohit Yadav 

commit c1716cd0473ad874a78279a23e9fe3c09dda3c3b
Author: Rohit Yadav 
Date:   2016-05-13T10:46:15Z

CLOUDSTACK-9456: Migrate spring xmls to version 4

Fixes schema locations that are 3.0 dependent in various xmls.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1546: [WIP][4.10+/long-term] Moving towards Java8 and Spri...

2016-08-12 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1546
  
I'll split this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1637: Command route not available on CentOS 7

2016-08-12 Thread lmrv
GitHub user lmrv opened a pull request:

https://github.com/apache/cloudstack/pull/1637

Command route not available on CentOS 7

Hi guys,

The command route is not available on a fresh install of CentOS 7.
This one should be replace by ip route.

Command route make crash cloudstack-setup-agent on CentOS 7.
Another way is to make the net-tools paquet as dependencies of 
cloudstack-setup-agent.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lmrv/cloudstack master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1637.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1637


commit 1d99de86ab692b779476ec9a7e57c4fdf1be8668
Author: lmrv 
Date:   2016-08-12T08:11:35Z

Command route

The command route is not available by default on CentOS7.

This one should be replace by the command "ip route".

commit 95faab74fa9109647fb1a128a12174d244db2a17
Author: lmrv 
Date:   2016-08-12T08:19:11Z

Merge pull request #1 from lmrv/lmrv-patch-1

Command route




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-install pull request #28: corrected -d value while building ...

2016-08-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-docs-install/pull/28


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [VOTE] Apache Cloudstack 4.8.1 RC2

2016-08-12 Thread Milamber

Hello,

My vote +1 (binding)

Tests are passed on a virtual topology of servers  (CS over CS) 
(1mgr+2nodes+1nfs) :


1/ Fresh install of 4.8.1RC2 (adv net) on Ubuntu 14.04.5 + KVM + NFS : OK
Some standard tests with success (create vm, migration, HA, create 
networks, create user, create ssh key, destroy vm, register template, 
create snapshot, restore snapshot, create template, ip association, ip 
release, static nat, firewall rule)
Some tests with cloudstack ansible module with success too (create 
network, register templates, create vm, ip, firewall rule)


2/ Test upgrade from 4.8.0 to 4.8.1RC2 : OK

3/ Tests of all localization Web UI for 4.8.1RC2:
Localization works well except Spanish: the Web UI won't display due of 
2 localization strings with a escaped quote (from Transifex). This is 
the same issue that the 4.9.0RC1.

Fixed in the PR1636 (not a blocker to release)
https://github.com/apache/cloudstack/pull/1636


Perhaps add in the Release notes this Spanish l10n issue.

Thanks to the RM.

Milamber



On 08/08/2016 15:29, Will Stevens wrote:

Hi All,

Sorry for the version mix up with RC1.  This will be the 4.8.1 release, not
the 4.8.2 release.

I've created a 4.8.1 release, with the following artifacts up for a vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=
shortlog;h=refs/heads/4.8.1-RC20160808T1006
Commit: a63db21d16072821a1e27473813fddf36accfdd4

List of changes will be produced with the release notes once the RC passes.

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.8.1/


PGP release keys (signed using CB818F64):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)





[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...

2016-08-12 Thread milamberspace
GitHub user milamberspace opened a pull request:

https://github.com/apache/cloudstack/pull/1636

Fix a quote issue with Spanish L10N (from transifex translation)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/milamberspace/cloudstack 
L10N-update-4.8-20160812-fix-spanish-quote

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1636


commit 47f458698de2f998d4f8e57cad31dcbf900d78f5
Author: Milamber <milam...@apache.org>
Date:   2016-08-12T06:13:44Z

Fix a quote issue with Spanish L10N (from transifex translation)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---