[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76496565
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76496527
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76494735
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76494274
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76494135
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76493975
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76493886
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
@jburwell some of them skipped due to missing hardware or conditions (as 
tests ran on KVM which has no gpu support etc), the failed tests are failing in 
general on master. I'll review and investigate them once the 
BlueOrangutan/Trillian setup starts to work again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76484499
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76484431
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76484318
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76482524
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if template == FAILED:
+assert False, "get_template() failed to return template with 
description %s" % cls.services[
+"ostype"]
+
+# Create an account, network, VM and IP addresses
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+cls.services["publiciprange"]["zoneid"] = cls.zone.id
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+  

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76482410
  
--- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
@@ -0,0 +1,887 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for network services on public IP's from different public IP
+  range than that of associated source NAT IP of the network. Each IP 
associated
+  with network from a different public IP range results in a new public
+  interface on VR (eth3, eth4 etc) and iptable
+"""
+# Import Local Modules
+from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
+  NAT_RULE, PASS)
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.cloudstackAPI import rebootRouter
+from marvin.sshClient import SshClient
+from marvin.lib.utils import cleanup_resources, get_process_status
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ NATRule,
+ PublicIPAddress,
+ StaticNATRule,
+ FireWallRule,
+ Network,
+ NetworkOffering,
+ LoadBalancerRule,
+ PublicIpRange,
+ Router,
+ VpcOffering,
+ VPC,
+ NetworkACL)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_hosts,
+   list_publicIP,
+   list_nat_rules,
+   list_routers,
+   list_virtual_machines,
+   list_lb_rules,
+   list_configurations,
+   verifyGuestTrafficPortGroups)
+from nose.plugins.attrib import attr
+from ddt import ddt, data
+# Import System modules
+import socket
+import time
+import logging
+
+_multiprocess_shared_ = True
+
+logger = logging.getLogger('TestNetworkOps')
+stream_handler = logging.StreamHandler()
+logger.setLevel(logging.DEBUG)
+logger.addHandler(stream_handler)
+
+class TestPortForwarding(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+
+testClient = super(TestPortForwarding, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["zoneid"] = cls.zone.id
+template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
--- End diff --

@abhinandanprateek is this the best way to determine the default template 
for VMs in a Marvin test suite?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1659#discussion_r76481464
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -884,6 +884,13 @@ def processStaticNatRule(self, rule):
 device = self.getDeviceByIp(rule["public_ip"])
 if device is None:
 raise Exception("Ip address %s has no device in the ips 
databag" % rule["public_ip"])
+
+self.fw.append(["mangle", "",
+"-A PREROUTING -s %s/32 -m state --state NEW -j 
MARK --set-xmark 0x%s/0x" % \
+(rule["internal_ip"], device[len("eth"):])])
+self.fw.append(["mangle", "",
+"-A PREROUTING -s %s/32 -m state --state NEW -j 
CONNMARK --save-mark --nfmask 0x --ctmask 0x" % \
--- End diff --

Is there value in extracting the ``0x`` to a constant?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
@nvazquez the Jenkins build failed.  Could you please investigate and fix 
any issues?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1660#discussion_r76476168
  
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -195,6 +195,15 @@ public static void scpTo(String host, int port, String 
user, File pemKeyFile, St
 }
 
 String result = sbResult.toString();
+if (result == null || (result != null && result.isEmpty())){
--- End diff --

Consider using ``StringUtils.isBlank`` which will not only make the code 
more expressive, but also covers the case where the string is composed only of 
whitespace.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
@rhtyd have you had a chance to review the test cases with errors and skips?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1660#discussion_r76477326
  
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -195,6 +195,15 @@ public static void scpTo(String host, int port, String 
user, File pemKeyFile, St
 }
 
 String result = sbResult.toString();
+if (result == null || (result != null && result.isEmpty())){
+int stdOutAvailable = stdout.available();
+while (stdOutAvailable != 0){
+currentReadBytes = stdout.read(buffer);
+sbResult.append(new String(buffer, 0, 
currentReadBytes));
+stdOutAvailable = stdout.available();
+}
+result = sbResult.toString();
--- End diff --

Consider replacing lines 199-205 with the following:
```
 result = IOUtils.toString(buffer, Charset.defaultCharset());
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
I looked at the class, while it can have further refactoring improvements, 
fwiw LGTM. /cc @jburwell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[nvazquez]

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
Done, thanks @rhtyd for your help, it was really useful!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CS 4.9 NIO Selector wait time PR-1601

[Rohit Yadav]

Hi Martin,


I checked my openssl connect output and my management server on port 8250 was 
indeed returning valid certificates. On further investigation, when connections 
to management server (NioServer, handled by Link class that reads 
/etc/cloudstack/management/cloudmanagementserver.keystore) are received it uses 
a keystore file (/etc/cloudstack/management/cloudmanagementserver.keystore). 
Please check if that's valid, or backup your keystore file and do what Simon 
has suggested.



For reference, here the output from my 4.9.0 mgmt server running on Ubuntu 
14.04.4:


$ openssl s_client -tls1 -connect 192.168.1.11:8250
CONNECTED(0003)
depth=0 C = Unknown, O = bluebox, OU = bluebox, CN = Cloudstack User
verify error:num=18:self signed certificate
verify return:1
depth=0 C = Unknown, O = bluebox, OU = bluebox, CN = Cloudstack User
verify return:1
---
Certificate chain
 0 s:/C=Unknown/O=bluebox/OU=bluebox/CN=Cloudstack User
   i:/C=Unknown/O=bluebox/OU=bluebox/CN=Cloudstack User
---
Server certificate
-BEGIN CERTIFICATE-
MIIDPzCCAiegAwIBAgIEFHHX2DANBgkqhkiG9w0BAQsFADBQMRAwDgYDVQQGEwdV
bmtub3duMRAwDgYDVQQKEwdibHVlYm94MRAwDgYDVQQLEwdibHVlYm94MRgwFgYD
VQQDEw9DbG91ZHN0YWNrIFVzZXIwHhcNMTUwNTA2MTM0MjMzWhcNMjUwNTAzMTM0
MjMzWjBQMRAwDgYDVQQGEwdVbmtub3duMRAwDgYDVQQKEwdibHVlYm94MRAwDgYD
VQQLEwdibHVlYm94MRgwFgYDVQQDEw9DbG91ZHN0YWNrIFVzZXIwggEiMA0GCSqG
SIb3DQEBAQUAA4IBDwAwggEKAoIBAQC0wN8kfOJMzwlbrOnBj/jjvjjIwDVpYLtH
WoKkNB+rzzKEUxaYwaQxe6E3M536ZuqcaJBIqcYPwTIkWyulvuHuJpSQak4VbuDV
f7dqt5RacLFT0jUciqTvL5QDCrk0uNugKkWgEvNtokVGSBwLPVEcdcGWpku1EpeH
vMYmpOkcWgbC8Z9D7QTlVw6oEWbPAtKr+gDrXdOFnpPPI45rteatIIgKm1Q6JjZM
qrUKfqt7s8ts6ZgdAN2WmtieSsnUX1su9SJMYg2J8LK7UJeGqiNtE+g944GPqtnW
aDldjharq54e79ug2ktxw29I3ulpRD/vgxwZmcPJrePUKwY91KEjAgMBAAGjITAf
MB0GA1UdDgQWBBSUJvLY8RL/1fTVqj1rT8136da4yzANBgkqhkiG9w0BAQsFAAOC
AQEAgDdFIgLvOH/UgRp2nnFUVcMp+uchSLj8CbCkukJBrUwrmJHp3Os+H1ggk8Vt
j3conj06zJBNN/E0J8pcpagE1aR+l4R8WxF3g/Oc7bNyrUlkGSQ82vavg9sEkwHY
eQY/4wj8CprICs9JilgZ6keeWNWgAW1goLZSzGVwz5eE0lPuc2Dg3laR5RsuTxie
dgQhpbOx3UZun+dhuP5NUHc+KWyrNvSZNN8FruO602KWZwm0Hndl7RVbkNEd0kxq
FhFK4Scc2HBrKMUrPTzO1nGCgR1gA015C2MFfmjeW49VTi95WnY8DDG2euUYAtpl
lLVuNxJxq7eDJfP/M9kxSIKgrQ==
-END CERTIFICATE-
subject=/C=Unknown/O=bluebox/OU=bluebox/CN=Cloudstack User
issuer=/C=Unknown/O=bluebox/OU=bluebox/CN=Cloudstack User
---
No client certificate CA names sent
Server Temp Key: ECDH, P-256, 256 bits
---
SSL handshake has read 1325 bytes and written 331 bytes
---
New, TLSv1/SSLv3, Cipher is ECDHE-RSA-AES256-SHA
Server public key is 2048 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
SSL-Session:
Protocol  : TLSv1
Cipher: ECDHE-RSA-AES256-SHA
Session-ID: 57C08E5D841D9B74AB533ABDBE4275424640B5B7D1985D438B275598436F
Session-ID-ctx:
Master-Key: 
E1DE7D7464766DCECD82088561A7D928519CA20BA91FDF4AA38BB2E51AB7C27D3F1ABA5788ADED2AD49FE8597EC4A344
Key-Arg   : None
PSK identity: None
PSK identity hint: None
SRP username: None
Start Time: 1472237149
Timeout   : 7200 (sec)
Verify return code: 18 (self signed certificate)
---




Regards.


From: martin kolly 
Sent: 26 August 2016 20:36:02
To: dev@cloudstack.apache.org
Subject: Re: CS 4.9 NIO Selector wait time PR-1601


good point, thanks Simon! with openssl we receive a response on port 8250.

# telnet 10.100.12.10 8250
Trying 10.100.12.10...
Connected to 10.100.12.10.
Escape character is '^]'.
Connection closed by foreign host.

# nc -zv 10.100.12.10 8250
Connection to 10.100.12.10 8250 port [tcp/*] succeeded!

# openssl   s_client -tls1  -connect 10.100.12.10:8250
CONNECTED(0003)
write:errno=104
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 0 bytes and written 0 bytes
---
New, (NONE), Cipher is (NONE)
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
SSL-Session:
Protocol  : TLSv1
Cipher: 
Session-ID:
Session-ID-ctx:
Master-Key:
Key-Arg   : None
PSK identity: None
PSK identity hint: None
SRP username: None
Start Time: 1472223447
Timeout   : 7200 (sec)
Verify return code: 0 (ok)
---


On 08/26/2016 04:49 PM, Simon Weller wrote:
> Martin,
>
>
> Are you able to actually telnet to 8250 from the host to the mgmt server?
>
>
> - Si
>
>
> 
> From: martin kolly 
> Sent: Friday, August 26, 2016 9:41 AM
> To: dev@cloudstack.apache.org
> Subject: Re: CS 4.9 NIO Selector wait time PR-1601
>
> Hi Rohit
>
> We highly appreciate your efforts! Unfortunately it still does not work.
> - ulimit is increased on mgmt server
> - jar file replaced
> - we confirm that cloudstack-agent 4.9.0 is installed
>
> MGMT Server
> # wget 
> https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
>  -O cloud-utils-4.9.0.jar.patch
> # md5sum 

Re: CS 4.9 NIO Selector wait time PR-1601

[Rohit Yadav]

Hi Martin,


Alright based on the logs, the error 'possible truncation attack?' along with 
openssl connect output hints at SSL keystore/encryption issue. Can you try what 
Simon suggests?


Alternatively, while searching for this error some people have reported that 
their error went away when they switched to Oracle JRE -- maybe you can try to 
switch to Oracle JRE 1.7 on your management server and KVM hosts and see if 
that helps?


Regards.


From: martin kolly 
Sent: 26 August 2016 20:11:06
To: dev@cloudstack.apache.org
Subject: Re: CS 4.9 NIO Selector wait time PR-1601

Hi Rohit

We highly appreciate your efforts! Unfortunately it still does not work.
- ulimit is increased on mgmt server
- jar file replaced
- we confirm that cloudstack-agent 4.9.0 is installed

MGMT Server
# wget 
https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
 -O cloud-utils-4.9.0.jar.patch
# md5sum cloud-utils-4.9.0.jar.patch
c4496f42cc6741f562ac645c3a3d8a0c  cloud-utils-4.9.0.jar.patch
# md5sum 
/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar
c4496f42cc6741f562ac645c3a3d8a0c  
/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar

# ulimit -a
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 64109
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 10240
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 64109
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited

KVM Server
# wget 
https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
 -O cloud-utils-4.9.0.jar.patch
# md5sum cloud-utils-4.9.0.jar.patch
c4496f42cc6741f562ac645c3a3d8a0c  cloud-utils-4.9.0.jar.patch
# md5sum /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
c4496f42cc6741f562ac645c3a3d8a0c  
/usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar

# apt-cache policy cloudstack-agent
cloudstack-agent:
  Installed: 4.9.0
  Candidate: 4.9.0
  Version table:
 *** 4.9.0 0
500 http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ 
Packages
100 /var/lib/dpkg/status

The logs are attached. By the way: the error message "Caught the Exception in 
VmIpFetchTask" was already there with 4.8 release.

Thanks
Martin

On 08/25/2016 07:44 PM, Rohit Yadav wrote:

Hi Martin,


Thanks for sharing. Alright, I'm not sure what's causing issue but based on the 
logs seems like only KVM agents are having issues while connecting to mgmt 
server as I don't see any Nio related exceptions in the management server logs.


I could not see the cloudstack-agent version in the logs, I'm assuming that 
they were all upgraded to 4.9.0, and there are no conflicting jars at 
/usr/share/cloudstack-agent/lib.


First, can you make sure mgmt server has enough ulimit. I found that 
Ubuntu/Debian's init.d script don't override this while CentOS initd/systemd 
script sets ulimit. On your mgmt server, edit /etc/init.d/cloudstack-management 
and add ulimit -n 10240 just before the mgmt server is started in the 'state' 
section (for me it was at around line #147 where it logs a message that it's 
starting the cloudstack-management server).


Next, if this still does not solve the issue -- I created a special 
cloud-utils.jar for you that you need to place on your mgmt server and on the 
KVM agents and restart the mgmt server. This will increase verbosity of the 
error while reduce the Nio polling loop timeout (from 100ms to 10ms). On KVM 
agents, the error from the logs is that during SSL handshake inbound 
connection/stream gets closed, and we want to know the exception message. 
Please get the jar from here:

https://github.com/rhtyd/cloudstack/releases/tag/4.9.0-nioinbound and place 
them at:

/usr/share/cloudstack-agent/lib/ (on kvm host)

/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/ (on mgmt server 
host)


Let me know what worked for you, and if it still failed can you share the mgmt 
server and agent logs once again. Thanks.


Regards.


From: martin kolly 
Sent: 25 August 2016 20:50:08
To: dev@cloudstack.apache.org
Subject: Re: CS 4.9 NIO Selector wait time PR-1601

Hi Rohit

We are running java version 1.7.0.111 on KVM and management server.
mgmt# java -version
java version "1.7.0_111"
kvm# java -version
java version "1.7.0_111"

We get the same error message. Attached are 

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1647


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
Alright, given the reviews and that all changes have been incorporated with 
exhaustive testing with Ubuntu and CentOS I'll proceed with merging this 
without blocking 4.9.1.0 RC much further.

Any more improvements and changes should be sent in future PRs for example 
support for cloudstack-management/systemd on Ubuntu 16.04 is yet to be done. 
Thanks @vincentbernat and @wido for your review and feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1663: CLOUDSTACK-6432: Prevent DNS reflection attac...

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1663


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1663: CLOUDSTACK-6432: Prevent DNS reflection attac...

[rhtyd]

GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1663

CLOUDSTACK-6432: Prevent DNS reflection attacks

CLOUDSTACK-6432: Prevent DNS reflection attacks

DNS on VR should not be publically accessible as it may be prone to DNS
amplification/reflection attacks. This fixes the issue by only allowing 
VR
DNS (port 53) to be accessible from guest network cidr, as per the fix 
in:
https://issues.apache.org/jira/browse/CLOUDSTACK-6432

- Only allows guest network cidrs to query VR DNS on port 53.
- Includes marvin smoke test that checks the VR DNS accessibility 
checks from
  guest and non-guest network.
- Fixes Marvin sshClient to avoid using ssh agent when password is 
provided,
  previous some environments may have seen 'No existing session' 
exception without
  this fix.
- Adds a new dnspython dependency that is used to perform dns 
resolutions in the
  tests.

Due to repository commit issues I've created this PR, based on #1653 .

/cc @jburwell @karuturi @NuxRo @ustcweizhou @wido  and others

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.9-dnsreflection-attack

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1663.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1663


commit 3f588c3f85c64d89cd3e071854655ae475826ad5
Author: Rohit Yadav 
Date:   2016-08-22T09:31:41Z

CLOUDSTACK-6432: Prevent DNS reflection attacks

DNS on VR should not be publically accessible as it may be prone to DNS
amplification/reflection attacks. This fixes the issue by only allowing VR
DNS (port 53) to be accessible from guest network cidr, as per the fix in:
https://issues.apache.org/jira/browse/CLOUDSTACK-6432

- Only allows guest network cidrs to query VR DNS on port 53.
- Includes marvin smoke test that checks the VR DNS accessibility checks 
from
  guest and non-guest network.
- Fixes Marvin sshClient to avoid using ssh agent when password is provided,
  previous some environments may have seen 'No existing session' exception 
without
  this fix.
- Adds a new dnspython dependency that is used to perform dns resolutions 
in the
  tests.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
@nvazquez okay, there are many ways to do this. Here's how you can do it 
fairly easily without merge conflicts:

git checkout 
git format-patch -1 # this will create a .patch file of your commit
git fetch origin # note origin points to asf or apache/cloudstack 
github remote
git reset --hard origin/4.9 # this will move your branch's HEAD to 
origin/4.9 i.e. your branch is now exactly origin/4.9
git am 
git push  sshhelperissue -fv 
# this will force push and update your remote branch and the commit on this PR

Hope this helps :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CS 4.9 NIO Selector wait time PR-1601

[Simon Weller]

I wonder whether your ssl keystore is corrupt or just missing.


Does /etc/cloudstack/management/cloudmanagementserver.keystore exist?


If I remember correctly, you can remove this and also remove ssl.keystore from 
the configuration table and restart the management to have them regenerated.


I haven't had to fix this in a while, so someone who is more familiar with it, 
please feel free to chime in here, as I don't want to mislead Martin.


- Si





From: martin kolly 
Sent: Friday, August 26, 2016 10:06 AM
To: dev@cloudstack.apache.org
Subject: Re: CS 4.9 NIO Selector wait time PR-1601


good point, thanks Simon! with openssl we receive a response on port 8250.

# telnet 10.100.12.10 8250
Trying 10.100.12.10...
Connected to 10.100.12.10.
Escape character is '^]'.
Connection closed by foreign host.

# nc -zv 10.100.12.10 8250
Connection to 10.100.12.10 8250 port [tcp/*] succeeded!

# openssl   s_client -tls1  -connect 10.100.12.10:8250
CONNECTED(0003)
write:errno=104
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 0 bytes and written 0 bytes
---
New, (NONE), Cipher is (NONE)
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
SSL-Session:
Protocol  : TLSv1
Cipher: 
Session-ID:
Session-ID-ctx:
Master-Key:
Key-Arg   : None
PSK identity: None
PSK identity hint: None
SRP username: None
Start Time: 1472223447
Timeout   : 7200 (sec)
Verify return code: 0 (ok)
---


On 08/26/2016 04:49 PM, Simon Weller wrote:
> Martin,
>
>
> Are you able to actually telnet to 8250 from the host to the mgmt server?
>
>
> - Si
>
>
> 
> From: martin kolly 
> Sent: Friday, August 26, 2016 9:41 AM
> To: dev@cloudstack.apache.org
> Subject: Re: CS 4.9 NIO Selector wait time PR-1601
>
> Hi Rohit
>
> We highly appreciate your efforts! Unfortunately it still does not work.
> - ulimit is increased on mgmt server
> - jar file replaced
> - we confirm that cloudstack-agent 4.9.0 is installed
>
> MGMT Server
> # wget 
> https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
>  -O cloud-utils-4.9.0.jar.patch
> # md5sum cloud-utils-4.9.0.jar.patch
> c4496f42cc6741f562ac645c3a3d8a0c  cloud-utils-4.9.0.jar.patch
> # md5sum 
> /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar
> c4496f42cc6741f562ac645c3a3d8a0c  
> /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar
>
> # ulimit -a
> core file size  (blocks, -c) 0
> data seg size   (kbytes, -d) unlimited
> scheduling priority (-e) 0
> file size   (blocks, -f) unlimited
> pending signals (-i) 64109
> max locked memory   (kbytes, -l) 64
> max memory size (kbytes, -m) unlimited
> open files  (-n) 10240
> pipe size(512 bytes, -p) 8
> POSIX message queues (bytes, -q) 819200
> real-time priority  (-r) 0
> stack size  (kbytes, -s) 8192
> cpu time   (seconds, -t) unlimited
> max user processes  (-u) 64109
> virtual memory  (kbytes, -v) unlimited
> file locks  (-x) unlimited
>
> KVM Server
> # wget 
> https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
>  -O cloud-utils-4.9.0.jar.patch
> # md5sum cloud-utils-4.9.0.jar.patch
> c4496f42cc6741f562ac645c3a3d8a0c  cloud-utils-4.9.0.jar.patch
> # md5sum /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
> c4496f42cc6741f562ac645c3a3d8a0c  
> /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
>
> # apt-cache policy cloudstack-agent
> cloudstack-agent:
>   Installed: 4.9.0
>   Candidate: 4.9.0
>   Version table:
>  *** 4.9.0 0
> 500 http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ 
> Packages
> 100 /var/lib/dpkg/status
>
> The logs are attached. By the way: the error message "Caught the Exception in 
> VmIpFetchTask" was already there with 4.8 release.
>
> Thanks
> Martin
>
> On 08/25/2016 07:44 PM, Rohit Yadav wrote:
>
> Hi Martin,
>
>
> Thanks for sharing. Alright, I'm not sure what's causing issue but based on 
> the logs seems like only KVM agents are having issues while connecting to 
> mgmt server as I don't see any Nio related exceptions in the management 
> server logs.
>
>
> I could not see the cloudstack-agent version in the logs, I'm assuming that 
> they were all upgraded to 4.9.0, and there are no conflicting jars at 
> /usr/share/cloudstack-agent/lib.
>
>
> First, can you make sure mgmt server has enough ulimit. I found that 
> Ubuntu/Debian's init.d script don't override this while CentOS initd/systemd 
> script sets ulimit. On your mgmt server, edit 
> /etc/init.d/cloudstack-management and add ulimit -n 10240 just before the 
> mgmt server is 

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[nvazquez]

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
Hi @rhtyd, it would be nice to include it in 4.9. I tried rebasing branch 
4.9 but it tries to update poms to 4.10 version, what do you suggest me to do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Virtual Router : Marvin test gap analysis

[Murali Reddy]

Raja,

Thanks for sharing insightful automation analysis. We are trying to figure out 
how to convert our efforts in to actionable items. As community we can work on 
them to get good automated test suite for VR.



Will be sharing details early next week.

Thanks.

On 19/08/16, 2:25 PM, "Raja Pullela"  wrote:

>Hi Murali, 
>
>Great initiative… and VR is one area that could help greatly if we have more 
>automation.   we have done high-level analysis on VR functionality/automation 
>recently and have posted our findings to the wiki under “high-level Automation 
>analysis” section.  Please take a look, 
>
>[1] 
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router%3A+Smoke+and+Integration+tests+gap+analysis
>
>Best,
>Raja
>Senior Manager, Product Development
>Accelerite, www.accelerite.com, @accelerite
>2055, Laurelwood Road,  Santa Clara, CA 95054, USA
>Phone: 1-408-216-7010
>
>On 8/19/16, 12:33 PM, "Murali Reddy"  wrote:
>
>All,
>
>We (at ShapeBlue) did a gap analysis to figure if current set of smoke and 
>component tests sufficiently test the VR functionality for the regressions. I 
>have posted the analysis at [1]. I went through the test suites, and listed 
>down all the tests that touch virtual router functionality. There is listing 
>of general observations on grey areas.
>
>One particular area where there were no tests, was related multiple public 
>IP’s from different public IP ranges associated with a network. From 4.6, all 
>the way to master only IP’s from one public IP range (eth2 on the VR) is 
>working, any network services  on the public IP’s on eth3, eth4 etc on VR are 
>not functional. This is a common use case and is broken for last few releases. 
>Bug in this area are reported [2] and PR is yet to be merged [3]. I will be 
>work on the patch to get this fixed in LTS. I have also added Marvin tests [4] 
>cover multiple public IP scenarios. 
>
>Given the flexibility and rich set of network functionality is CloudStack, we 
>could catch regression only if we have good test suite. If there are any other 
>areas related to virtual router functionality that you see there are 
>significant gaps, please chime in share your thoughts or add the the wiki.
>
>[1] 
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router%3A+Smoke+and+Integration+tests+gap+analysis
>[2] https://issues.apache.org/jira/browse/CLOUDSTACK-9339
>[3] https://github.com/apache/cloudstack/pull/1519
>[4] 
>https://github.com/murali-reddy/cloudstack/commit/0b6fbc29fcadb39b08d0050ca473680a614dfab4
>
>
>
>
>
>
>
>DISCLAIMER
>==
>This e-mail may contain privileged and confidential information which is the 
>property of Accelerite, a Persistent Systems business. It is intended only for 
>the use of the individual or entity to which it is addressed. If you are not 
>the intended recipient, you are not authorized to read, retain, copy, print, 
>distribute or use this message. If you have received this communication in 
>error, please notify the sender and delete all copies of this message. 
>Accelerite, a Persistent Systems business does not accept any liability for 
>virus infected mails.

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1651
  
LGTM for testing
Before 
sshClient: DEBUG: {Cmd: ping -c 3 8.8.8.8 via Host: 10.140.12.103} 
{returns: [u'PING 8.8.8.8 (8.8.8.8) 56(84) bytes of data.', u'64 bytes from 
8.8.8.8: icmp_seq=1 ttl=54 time=4.
72 ms', u'64 bytes from 8.8.8.8: icmp_seq=2 ttl=54 time=4.66 ms', u'64 
bytes from 8.8.8.8: icmp_seq=3 ttl=54 time=4.61 ms', u'', u'--- 8.8.8.8 ping 
statistics ---', u'3 packets transmitted, 3 received, 0% packet loss, time 
2001ms', u'rtt min/avg/max/mdev = 4.611/4.666/4.723/0.091 ms']}
TestRouterDHCPHosts: DEBUG: SSH result: [u'PING 8.8.8.8 (8.8.8.8) 56(84) 
bytes of data.', u'64 bytes from 8.8.8.8: icmp_seq=1 ttl=54 time=4.72 ms', u'64 
bytes from 8.8.8.8: icmp_seq=2 ttl=54 time=4.66 ms', u'64 bytes from 8.8.8.8: 
icmp_seq=3 ttl=54 time=4.61 ms', u'', u'--- 8.8.8.8 ping statistics ---', u'3 
packets transmitted, 3 received, 0% packet loss, time 2001ms', u'rtt 
min/avg/max/mdev = 4.611/4.666/4.723/0.091 ms']; COUNT is ==> 0
test_router_dhcphosts 
(integration.smoke.test_router_dhcphosts.TestRouterDHCPHosts): CRITICAL: 
FAILED: test_router_dhcphosts: ['Traceback (most recent call last):\n', '  File 
"/usr/local/lib/python2.7/unittest/case.py", line 331, in run\n
testMethod()\n', '  File 
"/home/t_vazqnadmin/cloudstack/test/integration/smoke/test_router_dhcphosts.py",
 line 356, in test_router_dhcphosts\nself.test_ssh_command(self.vm_1, 
nat_rule1, "natrule1")\n', '  File 
"/home/t_vazqnadmin/cloudstack/test/integration/smoke/test_router_dhcphosts.py",
 line 201, in test_ssh_command\n"Ping to outside world from VM should be 
successful"\n', '  File "/usr/local/lib/python2.7/unittest/case.py", line 515, 
in assertEqual\nassertion_func(first, second, msg=msg)\n', '  File 
"/usr/local/lib/python2.7/unittest/case.py", line 508, in _baseAssertEqual\n
raise self.failureException(msg)\n', 'AssertionError: **## Ping to outside 
world from VM should be successful**\n']

After
sshClient: DEBUG: Trying SSH Connection: Host:10.144.31.41 User:root
   Port:22 RetryCnt:60===
paramiko.transport: DEBUG: starting thread (client mode): 0x4206310L
paramiko.transport: INFO: Connected (version 2.0, client OpenSSH_5.3)
paramiko.transport: DEBUG: kex 
algos:[u'diffie-hellman-group-exchange-sha256', 
u'diffie-hellman-group-exchange-sha1', u'diffie-hellman-group14-sha1', 
u'diffie-hellman-group1-sha1'] server key:[u'ssh-rsa', u'ssh-dss'] client 
encrypt:[u'aes128-ctr', u'aes192-ctr', u'aes256-ctr', u'arcfour256', 
u'arcfour128', u'aes128-cbc', u'3des-cbc', u'blowfish-cbc', u'cast128-cbc', 
u'aes192-cbc', u'aes256-cbc', u'arcfour', u'rijndael-...@lysator.liu.se'] 
server encrypt:[u'aes128-ctr', u'aes192-ctr', u'aes256-ctr', u'arcfour256', 
u'arcfour128', u'aes128-cbc', u'3des-cbc', u'blowfish-cbc', u'cast128-cbc', 
u'aes192-cbc', u'aes256-cbc', u'arcfour', u'rijndael-...@lysator.liu.se'] 
client mac:[u'hmac-md5', u'hmac-sha1', u'umac...@openssh.com', 
u'hmac-sha2-256', u'hmac-sha2-512', u'hmac-ripemd160', 
u'hmac-ripemd...@openssh.com', u'hmac-sha1-96', u'hmac-md5-96'] server 
mac:[u'hmac-md5', u'hmac-sha1', u'umac...@openssh.com', u'hmac-sha2-256', 
u'hmac-sha2-512', u'hmac-ripemd160', u'hmac-ripemd160@openssh.
 com', u'hmac-sha1-96', u'hmac-md5-96'] client compress:[u'none', 
u'z...@openssh.com'] server compress:[u'none', u'z...@openssh.com'] client 
lang:[u''] server lang:[u''] kex follows?False
paramiko.transport: DEBUG: Ciphers agreed: local=aes128-ctr, 
remote=aes128-ctr
paramiko.transport: DEBUG: using kex diffie-hellman-group14-sha1; server 
key type ssh-rsa; cipher: local aes128-ctr, remote aes128-ctr; mac: local 
hmac-sha1, remote hmac-sha1; compression: local none, remote none
paramiko.transport: DEBUG: Switch to new keys ...
paramiko.transport: DEBUG: Adding ssh-rsa host key for 10.144.31.41: 
f662631595339bcea0d93948261bf655
paramiko.transport: DEBUG: Trying SSH agent key 
9523f82115a1b2102b669b21e8a1084f
paramiko.transport: DEBUG: userauth is OK
paramiko.transport: INFO: Authentication (publickey) failed.
paramiko.transport: DEBUG: userauth is OK
paramiko.transport: INFO: Authentication (password) successful!
sshClient: DEBUG: ===SSH to Host 10.144.31.41 port : 22 SUCCESSFUL===


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CS 4.9 NIO Selector wait time PR-1601

[martin kolly]

good point, thanks Simon! with openssl we receive a response on port 8250.

# telnet 10.100.12.10 8250
Trying 10.100.12.10...
Connected to 10.100.12.10.
Escape character is '^]'.
Connection closed by foreign host.

# nc -zv 10.100.12.10 8250
Connection to 10.100.12.10 8250 port [tcp/*] succeeded!

# openssl   s_client -tls1  -connect 10.100.12.10:8250
CONNECTED(0003)
write:errno=104
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 0 bytes and written 0 bytes
---
New, (NONE), Cipher is (NONE)
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
SSL-Session:
Protocol  : TLSv1
Cipher: 
Session-ID:
Session-ID-ctx:
Master-Key:
Key-Arg   : None
PSK identity: None
PSK identity hint: None
SRP username: None
Start Time: 1472223447
Timeout   : 7200 (sec)
Verify return code: 0 (ok)
---


On 08/26/2016 04:49 PM, Simon Weller wrote:
> Martin,
>
>
> Are you able to actually telnet to 8250 from the host to the mgmt server?
>
>
> - Si
>
>
> 
> From: martin kolly 
> Sent: Friday, August 26, 2016 9:41 AM
> To: dev@cloudstack.apache.org
> Subject: Re: CS 4.9 NIO Selector wait time PR-1601
>
> Hi Rohit
>
> We highly appreciate your efforts! Unfortunately it still does not work.
> - ulimit is increased on mgmt server
> - jar file replaced
> - we confirm that cloudstack-agent 4.9.0 is installed
>
> MGMT Server
> # wget 
> https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
>  -O cloud-utils-4.9.0.jar.patch
> # md5sum cloud-utils-4.9.0.jar.patch
> c4496f42cc6741f562ac645c3a3d8a0c  cloud-utils-4.9.0.jar.patch
> # md5sum 
> /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar
> c4496f42cc6741f562ac645c3a3d8a0c  
> /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar
>
> # ulimit -a
> core file size  (blocks, -c) 0
> data seg size   (kbytes, -d) unlimited
> scheduling priority (-e) 0
> file size   (blocks, -f) unlimited
> pending signals (-i) 64109
> max locked memory   (kbytes, -l) 64
> max memory size (kbytes, -m) unlimited
> open files  (-n) 10240
> pipe size(512 bytes, -p) 8
> POSIX message queues (bytes, -q) 819200
> real-time priority  (-r) 0
> stack size  (kbytes, -s) 8192
> cpu time   (seconds, -t) unlimited
> max user processes  (-u) 64109
> virtual memory  (kbytes, -v) unlimited
> file locks  (-x) unlimited
>
> KVM Server
> # wget 
> https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
>  -O cloud-utils-4.9.0.jar.patch
> # md5sum cloud-utils-4.9.0.jar.patch
> c4496f42cc6741f562ac645c3a3d8a0c  cloud-utils-4.9.0.jar.patch
> # md5sum /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
> c4496f42cc6741f562ac645c3a3d8a0c  
> /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
>
> # apt-cache policy cloudstack-agent
> cloudstack-agent:
>   Installed: 4.9.0
>   Candidate: 4.9.0
>   Version table:
>  *** 4.9.0 0
> 500 http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ 
> Packages
> 100 /var/lib/dpkg/status
>
> The logs are attached. By the way: the error message "Caught the Exception in 
> VmIpFetchTask" was already there with 4.8 release.
>
> Thanks
> Martin
>
> On 08/25/2016 07:44 PM, Rohit Yadav wrote:
>
> Hi Martin,
>
>
> Thanks for sharing. Alright, I'm not sure what's causing issue but based on 
> the logs seems like only KVM agents are having issues while connecting to 
> mgmt server as I don't see any Nio related exceptions in the management 
> server logs.
>
>
> I could not see the cloudstack-agent version in the logs, I'm assuming that 
> they were all upgraded to 4.9.0, and there are no conflicting jars at 
> /usr/share/cloudstack-agent/lib.
>
>
> First, can you make sure mgmt server has enough ulimit. I found that 
> Ubuntu/Debian's init.d script don't override this while CentOS initd/systemd 
> script sets ulimit. On your mgmt server, edit 
> /etc/init.d/cloudstack-management and add ulimit -n 10240 just before the 
> mgmt server is started in the 'state' section (for me it was at around line 
> #147 where it logs a message that it's starting the cloudstack-management 
> server).
>
>
> Next, if this still does not solve the issue -- I created a special 
> cloud-utils.jar for you that you need to place on your mgmt server and on the 
> KVM agents and restart the mgmt server. This will increase verbosity of the 
> error while reduce the Nio polling loop timeout (from 100ms to 10ms). On KVM 
> agents, the error from the logs is that during SSL handshake inbound 
> connection/stream gets closed, and we want to know the exception message. 
> Please get the jar from here:
>
> 

Re: CS 4.9 NIO Selector wait time PR-1601

[Simon Weller]

Martin,


Are you able to actually telnet to 8250 from the host to the mgmt server?


- Si



From: martin kolly 
Sent: Friday, August 26, 2016 9:41 AM
To: dev@cloudstack.apache.org
Subject: Re: CS 4.9 NIO Selector wait time PR-1601

Hi Rohit

We highly appreciate your efforts! Unfortunately it still does not work.
- ulimit is increased on mgmt server
- jar file replaced
- we confirm that cloudstack-agent 4.9.0 is installed

MGMT Server
# wget 
https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
 -O cloud-utils-4.9.0.jar.patch
# md5sum cloud-utils-4.9.0.jar.patch
c4496f42cc6741f562ac645c3a3d8a0c  cloud-utils-4.9.0.jar.patch
# md5sum 
/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar
c4496f42cc6741f562ac645c3a3d8a0c  
/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar

# ulimit -a
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 64109
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 10240
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 64109
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited

KVM Server
# wget 
https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
 -O cloud-utils-4.9.0.jar.patch
# md5sum cloud-utils-4.9.0.jar.patch
c4496f42cc6741f562ac645c3a3d8a0c  cloud-utils-4.9.0.jar.patch
# md5sum /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
c4496f42cc6741f562ac645c3a3d8a0c  
/usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar

# apt-cache policy cloudstack-agent
cloudstack-agent:
  Installed: 4.9.0
  Candidate: 4.9.0
  Version table:
 *** 4.9.0 0
500 http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ 
Packages
100 /var/lib/dpkg/status

The logs are attached. By the way: the error message "Caught the Exception in 
VmIpFetchTask" was already there with 4.8 release.

Thanks
Martin

On 08/25/2016 07:44 PM, Rohit Yadav wrote:

Hi Martin,


Thanks for sharing. Alright, I'm not sure what's causing issue but based on the 
logs seems like only KVM agents are having issues while connecting to mgmt 
server as I don't see any Nio related exceptions in the management server logs.


I could not see the cloudstack-agent version in the logs, I'm assuming that 
they were all upgraded to 4.9.0, and there are no conflicting jars at 
/usr/share/cloudstack-agent/lib.


First, can you make sure mgmt server has enough ulimit. I found that 
Ubuntu/Debian's init.d script don't override this while CentOS initd/systemd 
script sets ulimit. On your mgmt server, edit /etc/init.d/cloudstack-management 
and add ulimit -n 10240 just before the mgmt server is started in the 'state' 
section (for me it was at around line #147 where it logs a message that it's 
starting the cloudstack-management server).


Next, if this still does not solve the issue -- I created a special 
cloud-utils.jar for you that you need to place on your mgmt server and on the 
KVM agents and restart the mgmt server. This will increase verbosity of the 
error while reduce the Nio polling loop timeout (from 100ms to 10ms). On KVM 
agents, the error from the logs is that during SSL handshake inbound 
connection/stream gets closed, and we want to know the exception message. 
Please get the jar from here:

https://github.com/rhtyd/cloudstack/releases/tag/4.9.0-nioinbound and place 
them at:

/usr/share/cloudstack-agent/lib/ (on kvm host)

/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/ (on mgmt server 
host)


Let me know what worked for you, and if it still failed can you share the mgmt 
server and agent logs once again. Thanks.


Regards.


From: martin kolly 
Sent: 25 August 2016 20:50:08
To: dev@cloudstack.apache.org
Subject: Re: CS 4.9 NIO Selector wait time PR-1601

Hi Rohit

We are running java version 1.7.0.111 on KVM and management server.
mgmt# java -version
java version "1.7.0_111"
kvm# java -version
java version "1.7.0_111"

We get the same error message. Attached are the logs with TRACE enabled.

"success consists of going from failure to failure without loss of enthusiasm."

regards
martin

On 08/25/2016 02:02 PM, Rohit Yadav wrote:

Hi Martin,


Thanks for sharing, on the surface there does not seem to be any issue in 
configuration causing the failures. I'm personally running KVM and Ubuntu hosts 
based env 

Re: CS 4.9 NIO Selector wait time PR-1601

[martin kolly]

Hi Rohit

We highly appreciate your efforts! Unfortunately it still does not work.
- ulimit is increased on mgmt server
- jar file replaced
- we confirm that cloudstack-agent 4.9.0 is installed

*MGMT Server*
# wget
https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
-O cloud-utils-4.9.0.jar.patch
# md5sum cloud-utils-4.9.0.jar.patch
c4496f42cc6741f562ac645c3a3d8a0c  cloud-utils-4.9.0.jar.patch
# md5sum
/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar
c4496f42cc6741f562ac645c3a3d8a0c 
/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar

# ulimit -a
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 64109
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 10240
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 64109
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited

*KVM Server*
# wget
https://github.com/rhtyd/cloudstack/releases/download/4.9.0-nioinbound/cloud-utils-4.9.0.jar
-O cloud-utils-4.9.0.jar.patch
# md5sum cloud-utils-4.9.0.jar.patch
c4496f42cc6741f562ac645c3a3d8a0c  cloud-utils-4.9.0.jar.patch
# md5sum /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
c4496f42cc6741f562ac645c3a3d8a0c 
/usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar

# apt-cache policy cloudstack-agent
cloudstack-agent:
  Installed: 4.9.0
  Candidate: 4.9.0
  Version table:
 *** 4.9.0 0
500
http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ Packages
100 /var/lib/dpkg/status

The logs are attached. By the way: the error message "Caught the
Exception in VmIpFetchTask" was already there with 4.8 release.

Thanks
Martin

On 08/25/2016 07:44 PM, Rohit Yadav wrote:
> Hi Martin,
>
>
> Thanks for sharing. Alright, I'm not sure what's causing issue but based on 
> the logs seems like only KVM agents are having issues while connecting to 
> mgmt server as I don't see any Nio related exceptions in the management 
> server logs.
>
>
> I could not see the cloudstack-agent version in the logs, I'm assuming that 
> they were all upgraded to 4.9.0, and there are no conflicting jars at 
> /usr/share/cloudstack-agent/lib.
>
>
> First, can you make sure mgmt server has enough ulimit. I found that 
> Ubuntu/Debian's init.d script don't override this while CentOS initd/systemd 
> script sets ulimit. On your mgmt server, edit 
> /etc/init.d/cloudstack-management and add ulimit -n 10240 just before the 
> mgmt server is started in the 'state' section (for me it was at around line 
> #147 where it logs a message that it's starting the cloudstack-management 
> server).
>
>
> Next, if this still does not solve the issue -- I created a special 
> cloud-utils.jar for you that you need to place on your mgmt server and on the 
> KVM agents and restart the mgmt server. This will increase verbosity of the 
> error while reduce the Nio polling loop timeout (from 100ms to 10ms). On KVM 
> agents, the error from the logs is that during SSL handshake inbound 
> connection/stream gets closed, and we want to know the exception message. 
> Please get the jar from here:
>
> https://github.com/rhtyd/cloudstack/releases/tag/4.9.0-nioinbound and place 
> them at:
>
> /usr/share/cloudstack-agent/lib/ (on kvm host)
>
> /usr/share/cloudstack-management/webapps/client/WEB-INF/lib/ (on mgmt server 
> host)
>
>
> Let me know what worked for you, and if it still failed can you share the 
> mgmt server and agent logs once again. Thanks.
>
>
> Regards.
>
> 
> From: martin kolly 
> Sent: 25 August 2016 20:50:08
> To: dev@cloudstack.apache.org
> Subject: Re: CS 4.9 NIO Selector wait time PR-1601
>
> Hi Rohit
>
> We are running java version 1.7.0.111 on KVM and management server.
> mgmt# java -version
> java version "1.7.0_111"
> kvm# java -version
> java version "1.7.0_111"
>
> We get the same error message. Attached are the logs with TRACE enabled.
>
> "success consists of going from failure to failure without loss of 
> enthusiasm."
>
> regards
> martin
>
> On 08/25/2016 02:02 PM, Rohit Yadav wrote:
>
> Hi Martin,
>
>
> Thanks for sharing, on the surface there does not seem to be any issue in 
> configuration causing the failures. I'm personally running KVM and Ubuntu 
> hosts based env without issues, I'm on Ubuntu 14.04.4 (Linux bluebox 
> 3.16.0-45-generic #60~14.04.1-Ubuntu) and java 1.7.0_79. Can you try 
> upgrading your JRE7 to latest (openjdk-7-jre, 7u111-2.6.7-0ubuntu0.14.04.3) 
> on all mgmt server and kvm 

[GitHub] cloudstack issue #1663: CLOUDSTACK-6432: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1663
  
New smoke test result:

$ nosetests --with-xunit --xunit-file=integration-test-results.xml 
--with-marvin --marvin-config=/home/bhaisaab/Lab/apache/marvin-cfgs/adv-kvm.cfg 
-s -a tags=advanced,required_hardware=true --zone=KVM-advzone --hypervisor=KVM  
test_router_dns.py

 Marvin Init Started 

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

 Log Folder Path: /tmp//MarvinLogs//Aug_26_2016_19_25_30_U977TH. All 
logs will be available here 

=== Marvin Init Logging Successful===

 Marvin Init Successful 
Creating Admin Account for domain db10a868-6b7a-11e6-863f-a434d91cd37e on 
zone d7eb01c3-f5e4-4643-ae8a-14372778ffb4
Creating Service Offering on zone d7eb01c3-f5e4-4643-ae8a-14372778ffb4
Creating Network Offering on zone d7eb01c3-f5e4-4643-ae8a-14372778ffb4
Creating Network for Account test-a-TestRouterDns-64PRTV using offering 
4a0b3e7e-c585-4b96-8040-736161597b62
Creating guest VM for Account test-a-TestRouterDns-64PRTV using offering 
1e1db335-c2e0-48b2-a288-9adf88a10adb
Starting test_router_dns_externalips...
Querying VR DNS IP: 192.168.20.18
VR DNS query failed from non-guest network IP as expected
=== TestName: test_router_dns_externalipquery | Status : SUCCESS ===

Starting test_router_dns_guestipquery...
Creating Firewall rule for VM ID: b00b68b8-9445-4925-a631-f4bbd54bc6b9
Creating NAT rule for VM ID: b00b68b8-9445-4925-a631-f4bbd54bc6b9
SSH into guest VM with IP: 192.168.20.18
Trying SSH Connection: Host:192.168.20.18 User:root 
  Port:22 RetryCnt:8===
SshClient: Exception under createConnection: ['Traceback (most recent call 
last):\n', '  File 
"/usr/local/lib/python2.7/dist-packages/marvin/sshClient.py", line 122, in 
createConnection\nallow_agent=False)\n', '  File 
"/usr/local/lib/python2.7/dist-packages/paramiko/client.py", line 324, in 
connect\nraise NoValidConnectionsError(errors)\n', 
'NoValidConnectionsError: [Errno None] Unable to connect to port 22 on 
192.168.20.18\n']
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/marvin/sshClient.py", line 
122, in createConnection
allow_agent=False)
  File "/usr/local/lib/python2.7/dist-packages/paramiko/client.py", line 
324, in connect
raise NoValidConnectionsError(errors)
NoValidConnectionsError: [Errno None] Unable to connect to port 22 on 
192.168.20.18
Trying SSH Connection: Host:192.168.20.18 User:root 
  Port:22 RetryCnt:7===
SshClient: Exception under createConnection: ['Traceback (most recent call 
last):\n', '  File 
"/usr/local/lib/python2.7/dist-packages/marvin/sshClient.py", line 122, in 
createConnection\nallow_agent=False)\n', '  File 
"/usr/local/lib/python2.7/dist-packages/paramiko/client.py", line 324, in 
connect\nraise NoValidConnectionsError(errors)\n', 
'NoValidConnectionsError: [Errno None] Unable to connect to port 22 on 
192.168.20.18\n']
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/marvin/sshClient.py", line 
122, in createConnection
allow_agent=False)
  File "/usr/local/lib/python2.7/dist-packages/paramiko/client.py", line 
324, in connect
raise NoValidConnectionsError(errors)
NoValidConnectionsError: [Errno None] Unable to connect to port 22 on 
192.168.20.18
Trying SSH Connection: Host:192.168.20.18 User:root 
  Port:22 RetryCnt:6===
SshClient: Exception under createConnection: ['Traceback (most recent call 
last):\n', '  File 
"/usr/local/lib/python2.7/dist-packages/marvin/sshClient.py", line 122, in 
createConnection\nallow_agent=False)\n', '  File 
"/usr/local/lib/python2.7/dist-packages/paramiko/client.py", line 324, in 
connect\nraise NoValidConnectionsError(errors)\n', 
'NoValidConnectionsError: [Errno None] Unable to connect to port 22 on 
192.168.20.18\n']
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/marvin/sshClient.py", line 
122, in createConnection
allow_agent=False)
  File "/usr/local/lib/python2.7/dist-packages/paramiko/client.py", line 
324, in connect
raise NoValidConnectionsError(errors)
NoValidConnectionsError: [Errno None] Unable to connect to port 22 on 
192.168.20.18

Trying SSH Connection: Host:192.168.20.18 User:root 
  Port:22 RetryCnt:5===
===SSH to Host 192.168.20.18 port : 22 SUCCESSFUL===
{Cmd: nslookup google.com via Host: 192.168.20.18} {returns: 
[u'Server:\t\t10.1.1.1', u'Address:\t10.1.1.1#53', u'', u'Non-authoritative 
answer:', u'Name:\tgoogle.com', u'Address: 216.58.199.142', u'']}
SSH nslookup result: 

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

[nathanejohnson]

Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@jburwell @si @wido 

Here are the results of the nosetests.  One test did throw an exception 
during teardown, but I am not sure that this is anything to be concerned about. 
 I'll post the logs and see what you guys thing:

Test snapshot cleanup after account deletion ... === TestName: 
test_02_accountSnapshotClean | Status : SUCCESS ===
ok
Test snapshot limit in snapshot policies ... === TestName: 
test_04_snapshot_limit | Status : SUCCESS ===
ok
Test create VM, Snapshot and Template ... === TestName: 
test_01_createVM_snapshotTemplate | Status : SUCCESS ===
ok
Test snapshot events ... === TestName: test_05_snapshot_events | Status : 
SUCCESS ===
ok
Test Creating snapshot from volume having spaces in name(KVM) ... === 
TestName: test_01_volume_from_snapshot | Status : SUCCESS ===
ok
Test Snapshot Data Disk ... === TestName: test_02_snapshot_data_disk | 
Status : SUCCESS ===
ok
Test snapshot from detached disk ... === TestName: 
test_03_snapshot_detachedDisk | Status : SUCCESS ===
ok
Test Delete Snapshot ... === TestName: test_04_delete_snapshot | Status : 
SUCCESS ===
ok
Create Template from snapshot ... === TestName: 
test_07_template_from_snapshot | Status : SUCCESS ===
ok
Test perform concurrent snapshots and migrate the vm from one host ... === 
TestName: test_01_concurrent_snapshots_live_migrate | Status : SUCCESS ===
ok
Test stop running VM while performing concurrent snapshot on volume ... === 
TestName: test_02_stop_vm_concurrent_snapshots | Status : SUCCESS ===
ok
Test while parent concurrent snapshot job in progress,create ... === 
TestName: test_03_concurrent_snapshots_create_template | Status : SUCCESS ===
ok
Test while parent concurrent snapshot job in progress,create volume ... === 
TestName: test_04_concurrent_snapshots_create_volume | Status : SUCCESS ===
ok
Test create VM with default cent os template and create snapshot ... === 
TestName: test_01_snapshot_on_rootVolume | Status : EXCEPTION ===
ERROR

... 

Ran 14 tests in 11936.921s

FAILED (errors=1)
(END)

And in the failed plus exceptions:

[njohn...@dkrlab01.dev test_snapshots_improvement_FE4IW5]$ cat 
failed_plus_exceptions.txt 
2016-08-26 03:26:10,082 - CRITICAL - EXCEPTION: 
test_01_snapshot_on_rootVolume: ['Traceback (most recent call last):\n', '  
File "/usr/lib64/python2.7/unittest/case.py", line 398, in run\n
self.tearDown()\n', '  File 
"/home/njohnson/cloudstack-ena/test/integration/component/test_snapshots_improvement.py",
 line 195, in tearDown\nraise Exception("Warning: Exception during cleanup 
: %s" % e)\n', "Exception: Warning: Exception during cleanup : Job failed: 
{jobprocstatus : 0, created : u'2016-08-26T03:20:58-0500', jobresult : 
{errorcode : 530, errortext : u'Failed to delete snapshot'}, cmd : 
u'org.apache.cloudstack.api.command.user.snapshot.DeleteSnapshotCmd', userid : 
u'f1d1ed88-4fb7-11e6-986a-000c29b79f06', jobstatus : 2, jobid : 
u'26b7de07-d293-445f-8e60-fb2089aad844', jobresultcode : 530, jobinstanceid : 
u'a23db950-4035-4906-b6a6-2d1d50437450', jobresulttype : u'object', 
jobinstancetype : u'Snapshot', accountid : 
u'f1d12b61-4fb7-11e6-986a-000c29b79f06'}\n"]
[njohn...@dkrlab01.dev test_snapshots_improvement_FE4IW5]$ 


I can paste full logs in a gist if anyone is interested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1663: CLOUDSTACK-6432: Prevent DNS reflection attac...

[rhtyd]

GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1663

CLOUDSTACK-6432: Prevent DNS reflection attacks

At least in SG zones DNS on the VR is publicly accessible and as such
susceptible to DNS amplification/reflection attacks. This fixes it as per
https://issues.apache.org/jira/browse/CLOUDSTACK-6432 to only allow IPs
from the guest cidr to send DNS requests on port 53.

Due to repository commit issues I've created this PR, based on #1653 .

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.9-dnsreflection-attack

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1663.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1663


commit 5adacc9b6f1b7b9ae53d35aa78fc8f7cd0d2273e
Author: NuxRo 
Date:   2016-08-22T09:31:41Z

CLOUDSTACK-6432: Prevent DNS reflection attacks

At least in SG zones DNS on the VR is publicly accessible and as such
susceptible to DNS amplification/reflection attacks. This fixes it as per
https://issues.apache.org/jira/browse/CLOUDSTACK-6432 to only allow IPs
from the guest cidr to send DNS requests on port 53.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
@nvazquez @serg38 does this also affect 4.9, if so please edit the base 
branch to 4.9. We should have this in 4.9/lts release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1643
  
Thanks @abhinandanprateek LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76393992
  
--- Diff: packaging/systemd/cloudstack-agent.default ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+JAVA_HOME=/usr/lib/jvm/jre
+if [ ! -f "$JAVA_HOME"/bin/java ] ; then
+JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
+fi
--- End diff --

Thanks @vincentbernat that's a nice idea. I've removed usage of JAVA_HOME, 
I checked and indeed all we want was path to java which I checked by default is 
at /usr/bin/java on most distros including the ones I tested - Ubuntu 12.04, 
14.04, 16.04 and on CentOS 7(.2). Are we good to merge with the new change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1643
  
@rhtyd rebased with 4.9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

[vincentbernat]

Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76392345
  
--- Diff: packaging/systemd/cloudstack-agent.default ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+JAVA_HOME=/usr/lib/jvm/jre
+if [ ! -f "$JAVA_HOME"/bin/java ] ; then
+JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
+fi
--- End diff --

I think the result is quite fragile. systemd just reads the first 
JAVA_HOME, then the second one, ignoring the condition. You could just have 
(without the condition):

```
JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
```

The only use of JAVA_HOME seems to be to choose a Java vesion. Why not 
just, in `/etc/default/...`:

```
JAVA=/usr/bin/java
```

And in the service file:

```
ExecStart=/bin/sh -ec '\
 export ACP=`ls /usr/share/cloudstack-agent/lib/*.jar 
/usr/share/cloudstack-agent/plugins/*.jar 2>/dev/null|tr "\\n" ":"`; \
 export 
CLASSPATH="$ACP:/etc/cloudstack/agent:/usr/share/cloudstack-common/scripts"; \
${JAVA} -Xms${JAVA_HEAP_INITIAL} -Xmx${JAVA_HEAP_MAX} -cp "$CLASSPATH" 
$JAVA_CLASS'
```

People could still overload the version of Java used by changing the JAVA 
variable.

If you are uncomfortable with this, at least, just remove the condition and 
simplify the default file to be:

```
JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
JAVA_HEAP_INITIAL=256m
JAVA_HEAP_MAX=2048m
JAVA_CLASS=com.cloud.agent.AgentShell
```

From your tests, it works both on Ubuntu and CentOS.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...

[milamberspace]

GitHub user milamberspace reopened a pull request:

https://github.com/apache/cloudstack/pull/1636

Fix a quote issue with Spanish L10N (from transifex translation)

This fix is for the 4.8 branch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/milamberspace/cloudstack 
L10N-update-4.8-20160812-fix-spanish-quote

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1636


commit 6df5df569423182fc62bf378dd32166a0ab55c9d
Author: Milamber 
Date:   2016-08-12T06:13:44Z

Fix a quote issue with Spanish L10N (from transifex translation)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...

[milamberspace]

Github user milamberspace closed the pull request at:

https://github.com/apache/cloudstack/pull/1636


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@wido @vincentbernat and others -- any objections, this is good to merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1643
  
@abhinandanprateek please edit the base branch to 4.9.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---