[GitHub] [cloudstack-primate] vladimirpetrov opened a new pull request #503: Update test_full_plan.md

2020-07-06 Thread GitBox


vladimirpetrov opened a new pull request #503:
URL: https://github.com/apache/cloudstack-primate/pull/503


   Removed unnecessary tests, added new areas, slight adjustments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


blueorangutan commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654624010


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-2231)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


Pearl1594 commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654621085


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


blueorangutan commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654621296


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


rhtyd commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654618481


   Did a quick test LGTM, did not test for all possible cases; if there are 
issues we can restrict the quick view limited to only user facing views such as 
compute, storage, network, image etc.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 opened a new issue #502: [BUG] Detail settings (for templates and instances) lets you create settings with null values

2020-07-06 Thread GitBox


Pearl1594 opened a new issue #502:
URL: https://github.com/apache/cloudstack-primate/issues/502


   **Describe the bug**
   Detail settings (for templates and instances) lets you create settings with 
null values.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   Goto the templates / Compute > Instances > Specific VM > Settings Tab
   Add settings lets you add a key without a value - no checks done / fields 
need to be set to mandatory
   
   **Expected behavior**
   Legacy UI sets these fields to mandatory
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


rhtyd commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r450625787



##
File path: src/views/AutogenView.vue
##
@@ -686,6 +687,8 @@ export default {
   }
   this.currentAction = action
   this.currentAction.params = 
store.getters.apis[this.currentAction.api].params
+  this.resource = action.resource
+  this.$emit('change-resource', this.resource)

Review comment:
   I'm not sure we'll have to explore/test





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #454: autogenview: store API parameters as router query for history

2020-07-06 Thread GitBox


rhtyd commented on pull request #454:
URL: 
https://github.com/apache/cloudstack-primate/pull/454#issuecomment-654618048


   Please review/test @davidjumani @Pearl1594 thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


rhtyd commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654617919


   @Pearl1594 are you testing as well, if so I'll merge if you're LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed

2020-07-06 Thread GitBox


rhtyd commented on a change in pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501#discussion_r450622935



##
File path: src/components/view/ListApiView.vue
##
@@ -0,0 +1,116 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+

Review comment:
   Minor nit - can we can call this something like ListResourceTab ?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #499: Simplifying Deploy VM Wizard

2020-07-06 Thread GitBox


rhtyd commented on pull request #499:
URL: 
https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654611424


   @davidjumani on the override root disk side can you remove the slider; so 
just the input and are we checking that size input is great than the size of 
template?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani opened a new pull request #501: Changing VM Snapshots and Backups to their own tabs if allowed

2020-07-06 Thread GitBox


davidjumani opened a new pull request #501:
URL: https://github.com/apache/cloudstack-primate/pull/501


   Fixes #487 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


blueorangutan commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654598111


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2230)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


blueorangutan commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654595742


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


Pearl1594 commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654595594


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] nvazquez commented on pull request #484: WIP: Spanish translations

2020-07-06 Thread GitBox


nvazquez commented on pull request #484:
URL: 
https://github.com/apache/cloudstack-primate/pull/484#issuecomment-654588807


   Copy that - thanks @rhtyd. I'm creating separate PRs for parts that were 
missing translation keys and leaving this PR to Spanish translations only



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


blueorangutan commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654569026


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-2229)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


blueorangutan commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654566816


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


davidjumani commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654566560


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


blueorangutan commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654563554


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2228)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


blueorangutan commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654561394


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


davidjumani commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654560966


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani removed a comment on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


davidjumani removed a comment on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654270354


   NOTE: Any action which uses a custom view is broken. It picks up the first 
item in the list. Adding a `this.resource = action.resource` in execAction, 
AutogenView fixes it but have to look at potential side effects



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


davidjumani commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r450577211



##
File path: src/views/AutogenView.vue
##
@@ -686,6 +687,8 @@ export default {
   }
   this.currentAction = action
   this.currentAction.params = 
store.getters.apis[this.currentAction.api].params
+  this.resource = action.resource
+  this.$emit('change-resource', this.resource)

Review comment:
   @rhtyd Is there a better way to ensure the right resource gets passed to 
the action form? The other changes made in 
b02a796c10780c1d63430ae7c1ff381dcdf0e539 only apprear to work for autogenerated 
forms





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #454: autogenview: store API parameters as router query for history

2020-07-06 Thread GitBox


blueorangutan commented on pull request #454:
URL: 
https://github.com/apache/cloudstack-primate/pull/454#issuecomment-654408918


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/454 (JID-2227)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #454: autogenview: store API parameters as router query for history

2020-07-06 Thread GitBox


blueorangutan commented on pull request #454:
URL: 
https://github.com/apache/cloudstack-primate/pull/454#issuecomment-654404991


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd removed a comment on pull request #454: autogenview: store API parameters as router query for history

2020-07-06 Thread GitBox


rhtyd removed a comment on pull request #454:
URL: 
https://github.com/apache/cloudstack-primate/pull/454#issuecomment-653733068


   Hold-on merging this, we may need more tests.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #454: autogenview: store API parameters as router query for history

2020-07-06 Thread GitBox


rhtyd commented on pull request #454:
URL: 
https://github.com/apache/cloudstack-primate/pull/454#issuecomment-654404624


   Ready for review and testing @davidjumani 
   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #326: Form to Migrate data between Image stores

2020-07-06 Thread GitBox


blueorangutan commented on pull request #326:
URL: 
https://github.com/apache/cloudstack-primate/pull/326#issuecomment-654379376


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/326 (JID-2226)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #326: Form to Migrate data between Image stores

2020-07-06 Thread GitBox


blueorangutan commented on pull request #326:
URL: 
https://github.com/apache/cloudstack-primate/pull/326#issuecomment-654375745


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #326: Form to Migrate data between Image stores

2020-07-06 Thread GitBox


Pearl1594 commented on pull request #326:
URL: 
https://github.com/apache/cloudstack-primate/pull/326#issuecomment-654375150


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 closed pull request #326: Form to Migrate data between Image stores

2020-07-06 Thread GitBox


Pearl1594 closed pull request #326:
URL: https://github.com/apache/cloudstack-primate/pull/326


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #500: [BUG] Unable to view project tags in the project details for User account

2020-07-06 Thread GitBox


rhtyd commented on issue #500:
URL: 
https://github.com/apache/cloudstack-primate/issues/500#issuecomment-654359919


   @sureshanaparti were you an account added to the project, I couldn't 
reproduce the error. For project where you've access you'll be able to 
add/remove/list tags.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


davidjumani edited a comment on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654270354


   NOTE: Any action which uses a custom view is broken. It picks up the first 
item in the list. Adding a `this.resource = action.resource` in execAction, 
AutogenView fixes it but have to look at potential side effects



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


davidjumani edited a comment on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654270354


   NOTE: Any action which uses a custom view is broken. It picks up the first 
item in the list. Adding a `this.resource = action.resource` fixes it but have 
to look at potential side effects



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


blueorangutan commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654294786


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2225)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


blueorangutan commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654290144


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


Pearl1594 commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654289564


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


davidjumani commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654270354


   NOTE: Destory VM is broken as it destorys the first vm in the list and not 
the one to be destroyed



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: Simplifying Deploy VM Wizard

2020-07-06 Thread GitBox


blueorangutan commented on pull request #499:
URL: 
https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654270299


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/499 (JID-2224)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: Simplifying Deploy VM Wizard

2020-07-06 Thread GitBox


blueorangutan commented on pull request #499:
URL: 
https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654265649


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #499: Simplifying Deploy VM Wizard

2020-07-06 Thread GitBox


davidjumani commented on pull request #499:
URL: 
https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654265279


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] sureshanaparti opened a new issue #500: [BUG] Unable to view project tags in the project details for User account

2020-07-06 Thread GitBox


sureshanaparti opened a new issue #500:
URL: https://github.com/apache/cloudstack-primate/issues/500


   **Describe the bug**
   Unable to view project tags in the project details for User account. In Old 
UI, can view and add tags for the project, the same is not available for the 
same account in Primate.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   
   1. Log in as a User
   2. Go to 'Projects'
   3. Click on any project and check tags.
   
   
   **Expected behavior**
   Project tags should be shown and provision to add tags based on the 
permission.
   
   **Desktop (please complete the following information):**
- OS: Mac
- Browser: Safari
- Version 13.1.1
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #499: Simplifying Deploy VM Wizard

2020-07-06 Thread GitBox


davidjumani commented on pull request #499:
URL: 
https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654257238


   @PaulAngus Looks good ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: Simplifying Deploy VM Wizard

2020-07-06 Thread GitBox


blueorangutan commented on pull request #499:
URL: 
https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654252304


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/499 (JID-2223)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: Simplifying Deploy VM Wizard

2020-07-06 Thread GitBox


blueorangutan commented on pull request #499:
URL: 
https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654247324


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #499: Simplifying Deploy VM Wizard

2020-07-06 Thread GitBox


davidjumani commented on pull request #499:
URL: 
https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654246706


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani opened a new pull request #499: Simplifying Deploy VM Wizard

2020-07-06 Thread GitBox


davidjumani opened a new pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499


   Fixes #490
   Fixes #491 

   - Moves Affinity Group selection to Details
   - Sets the minimum of the root disk size sider to the template size
   - Adds a switch to show / hide details
   - Adds a switch to show / hide root disk size slider
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #498: [TESTPLAN] Full Test Plan for Primate GA 1.0 - VMWare hypervisor

2020-07-06 Thread GitBox


vladimirpetrov opened a new issue #498:
URL: https://github.com/apache/cloudstack-primate/issues/498


   | Feature | Tester | Result | Related Issues |
   |---||||
   | **Common** | | | |
   | Project selector | | | |
   | Language selector | | | |
   | Notifications / clear notifications | | | |
   | Paginations | | | |
   | Profile | | | |
   | Help | | | |
   | Logout | | | |
   | | | | |
   | **Dashboard** | | | |
   | Fetch latest | | | |
   | View hosts in alert state | || |
   | View alerts | | | |
   | View events | | | |
   | | | | |
   | **Compute > Instances** | | | |
   | Basic search | | | |
   | Extended search | | | |
   | Sort | | | |
   | Links | | | |
   | Filter by | | | |
   | Create new instance | || |
   | | | | |
   | **Compute > Kubernetes** | | | |
   | Sort | | | |
   | Links | | | |
   |Sub menus | | | |
   | | | | |
   | **Compute > Instances > selected instance** | | | |
   | View console | | | |
   | Reboot instance | | | |
   | Update instance | | | |
   | Start/Stop instance | | | |
   | Reinstall instance | | | |
   | Take snapshot | | | |
   | Assign VM to backup offering | | | |
   | Attach ISO | | | |
   | Scale VM | | | |
   | Migrate instance to another host | | | |
   | Change affinity | | | |
   | Change service offering | | | |
   | Reset Instance Password | | | |
   | Assign Instance to Another Account | | | |
   | Network adapters | | | |
   |- Add network to VM | | | |
   |- Set default NIC | | | |
   |- Add/delete secondary IP address | | | |
   |- Delete VM network | | | |
   | Settings | | | |
   |- Add setting | | | |
   |- Update setting | | | |
   |- Delete setting | | | |
   | Add / delete comment | | | |
   | Add / delete tags | | | |
   | Links | | | |
   | | | | |
   | **Compute > Instance groups** | | | |
   | Search | | | |
   | Sort | | | |
   | Links | | | |
   | New instance group | | | |
   | | | | |
   | **Compute > Instance groups > selected instance group** | | | |
   | Links | | | |
   | Update instance group | | | |
   | Delete instance group | | | |
   | | | | |
   | **Compute > SSH Key Pairs** | | | |
   | Search | | | |
   | Sorting | | | |
   | Links | | | |
   | New SSH key pair | | | |
   | | | | |
   | **Compute > SSH Key Pairs > selected SSH key pair** | | | |
   | Links | | | |
   | Delete SSH key pair | | | |
   | | | | |
   | **Compute > Affinity Groups** | | | |
   | Search | | | |
   | Sort | | | |
   | Links | | | |
   | New affinity group | | | |
   | | | | |
   | **Compute > Affinity Groups > selected affinity group** | | | |
   | Links | | | |
   | Delete affinity group | | | |
   | | | | |
   | **Storage > Volumes** | | | |
   | Basic earch | | | |
   | Extended search | | | |
   | Sort | | | |
   | Links | | | |
   | Create volume | | | |
   | Upload local volume | | | |
   | Upload volume from URL | | | |
   | | | | |
   | **Storage > Volumes > selected volume** | | | |
   | Detach volume | | | |
   | Take snapshot | | | |
   | Recurring snapshot | | | |
   | Resize volume | | | |
   | Migrate volume | | | |
   | Download volume | | | |
   | Delete volume | | | |
   | Links | | | |
   | Add/delete tags | | | |
   | | | | |
   | **Storage > Snapshots** | | | |
   | Basic search | | | |
   | Extended search | | | |
   | Sort | | | |
   | Links | | | |
   | | | | |
   | **Storage > Snapshots > selected snapshot** | | | |
   | Links | | | |
   | Add/delete tags | | | |
   | Create template | |||
   | Create volume | | | |
   | Revert snapshot | | | |
   | Delete snapshot | | | |
   | | | | |
   | **Storage > VM Snapshots** | | | |
   | Basic search | | | |
   | Extended search | | | |
   | Sort | | | |
   | Links | | | |
   | | | | |
   | **Storage > VM Snapshots > selected snapshot** | | | |
   | Links | | | |
   | Add/delete tags | | | |
   | Revert VM snapshot | | | |
   | Delete VM snapshot | | | |
   | | | | |
   | **Storage > VM Snapshots** | | | |
   | | | | |
   | **Network > Guest networks** | | | |
   | Basic search | | | |
   | Extended search | | | |
   | Sort | | | |
   | Links | | | |
   | Add network | | | |
   | | | | |
   | **Network > Guest networks > selected network** | | | |
   | Links | | | |
   | Add/delete tags | | | |
   | Update network | | | |
   | Restart network | | | |
   | Delete network | | | |
   | Acquire new IP (only for isolated networks) | | | |
   | Replace ACL list(only for isolated networks) | | | |
   | Delete public IP address (only for isolated networks) | | | |
   | Add/delete egress rule (only for isolated networks) | | | |
   | Add/delete egress tags (only for isolated networks) | | | |
   | | | | |
   | **Network > VPC ** | | | |
   | Basic search | | | |
   | Extended search | | | |
   | Sort | | | |
   | Links | | | |
   | Add VPC | | | |
   | | | | |
   | **Network > VPC > selected VPC** 
   | Links | | | |
   | Update VPC | | | |
   | Restart VPC | | | |
   | Delete VPC | | | |
   | Networks | | | |
   

[GitHub] [cloudstack-primate] borisstoyanov opened a new issue #497: [TESTPLAN] Root admin for Primate GA

2020-07-06 Thread GitBox


borisstoyanov opened a new issue #497:
URL: https://github.com/apache/cloudstack-primate/issues/497


   
   The following plan focuses on 3 hypervisors, in priority: VMware, Xen and 
KVM. Since KVM has been the most tested on until now it's with lower priority. 
Please use advanced zone and basic zone with SG for covering the cases
   
   
   | Feature | Vmware results / tester | Vmware results / tester | Vmware 
results / tester |
   |---||||
   | **Instances** | | | |
   | Create instance using template | | | |
   | Create instance using ISO image and different parameters than the previous 
one | | | |
   | Test all VM actions - Start/Stop/Reboot/Reinstall/Update, etc | | | |
   | Add/modify/delete VM setting | | | |
   | Add network to VM, change IP address, make it default, delete | | | |
   | Add/delete secondary IP address | | | |
   | | | | |
   | **Add Instance groups** | | | |
   | Add/modify/delete instance group| | | |
   | | | | |
   | **SSH Key Pairs**| | | |
   | Add/delete SSH key pair| | | |
   | | | | |
   | **Affinity Groups**| | | |
   | Add/delete host affinity group | | | |
   | Add/delete host anti-affinity group | | | |
   | | | | |
   | **Volumes** | | | |
   | Create volume | | | |
   | Upload local volume | | | |
   | Upload volume from URL | | | |
   | Volume actions - snapshots, resize, migrate, download, create template | | 
| |
   | | | | |
   | **Snapshots** | | | |
   | Snapshot actions - create template/volume, revert, delete | | | |
   | | | | |
   | **VM Snapshots** | | | |
   | VM Snapshot actions - revert, delete | | | |
   | | | | |
   | **Backups** | | | |
   | | | | |
   | **Guest networks** | | | |
   | Add isolated network | | | |
   | Add L2 network | | | |
   | Add shared network | | | |
   | Network actions - update, restart, replace ACL list, delete | | | |
   | Add/delete egress rules | | | |
   | Acquire IP address | | | |
   | | | | |
   | **VPC**| | | |
   | Add VPC | | | |
   | VPC actions - updat, restart, delete | | | |
   | Add security group | | | |
   | Add/delete ingress/egress rule | | | |
   | | | | |
   | **Public IP Addresses** | | | |
   | Acquire new IP | | | |
   | Actions - enable static NAT, release IP, enable VPN | | | |
   | | | | |
   | **Templates**| | | |
   | Register template | | | |
   | Upload local template | | | |
   | Template actions - edit, download, update permissions, copy, delete | | | |
   | | | | |
   | **ISOs**| | | |
   | Register ISO | | | |
   | Upload local ISO | | | |
   | ISO actions - edit, download update permissions, copy, delete | | | |
   | | | | |
   | **Events**| | | |
   | Search, archive, delete | | | |
   | | | | |
   | **Projects** | | | |
   | Add project | | | |
   | Project actions - edit, suspend, add account, delete | | | |
   | Different projects with different permission | | | |
   | | | | |
   | **Accounts, users, roles** | | | |
   | Create/modify/check role/delete regular user account | | | |
   | Create/modify/check role/delete resource admin account | | | |
   | Create/modify/check role/delete domain admin account | | | |
   | Create/modify/check role/delete admin user | | | |
   | Account actions - edit, disable, lock, delete | | | |
   | | | | |
   | **Domains** | | | |
   | Create new domain | | | |
   | Create subdomain in the new domain | | | |
   | Delete the first domain (2nd, not 3rd level) | | | |
   | Edit/delete domain | | | |
   | Modify domain limits/settings | | | |
   | | | | |
   | **Roles** | | | |
   | Add new role | | | |
   | Role actions - edit, delete | | | |
   | | | | |
   | **Infrastructure summary**| | | |
   | | | | |
   | **Zones**| | | |
   | Add zone | | | |
   | Zone actions - edit, enable/disable, enable/disable HA, delete, etc. | | | 
|
   | Modify settings | | | |
   | | | | |
   | **Pods** | | | |
   | Add pod | | | |
   | Pod actions - edit, enable/disable, delete | | | |
   | | | | |
   | **Clusters** | | | |
   | Add cluster | | | |
   | Cluster actions - enable/disable, unmanage, enable/disable HA, delete, 
etc| | | |
   | | | | |
   | **Hosts** | | | |
   | Add host | | | |
   | Host actions - edit, enable/disable, maintenance mode, 
enable/disable/configure HA, etc. | | | |
   | | | | |
   | **Primary storage** | | | |
   | Add primary storage | | | |
   | Primary storage actions - edit, enable/disable maintenance mode | | | |
   | Settings - modify | | | |
   | | | | |
   | **Secondary storage** | | | |
   | Add secondary storage | | | |
   | Delete secondary storage | | | |
   | Settings - modify | | | |
   | | | | |
   | **Compute offering** | | | |
   | Add shared thin compute offering | | | |
   | Add local fat compute offering | | | |
   | Offering actions - edit, access, delete | | | |
   | | | | |
   | **System offering** | | | |
   | Add shared thin system offering for VR | | | |
   | Add local sparse system offering for console proxy | | | |
   | Offering actions - edit, delete | | | |
   | | | | 

[GitHub] [cloudstack-primate] borisstoyanov opened a new issue #496: [Testplan] Domain admin testing for primate GA

2020-07-06 Thread GitBox


borisstoyanov opened a new issue #496:
URL: https://github.com/apache/cloudstack-primate/issues/496


   
   This is a high-level plan for Primate GA using the role Domain admin, some 
of the actions might not be available, please mark as N/A. 
   
   The following plan focuses on 3 hypervisors, in priority: VMware, Xen and 
KVM. Since KVM has been the most tested on until now it's with lower priority. 
Please use advanced zone for all deployments
   
   
   | Feature | Vmware results / tester | Vmware results / tester | Vmware 
results / tester |
   |---||||
   | **Instances** | | | |
   | Create instance using template | | | |
   | Create instance using ISO image and different parameters than the previous 
one | | | |
   | Test all VM actions - Start/Stop/Reboot/Reinstall/Update, etc | | | |
   | Add/modify/delete VM setting | | | |
   | Add network to VM, change IP address, make it default, delete | | | |
   | Add/delete secondary IP address | | | |
   | | | | |
   | **Add Instance groups** | | | |
   | Add/modify/delete instance group| | | |
   | | | | |
   | **SSH Key Pairs**| | | |
   | Add/delete SSH key pair| | | |
   | | | | |
   | **Affinity Groups**| | | |
   | Add/delete host affinity group | | | |
   | Add/delete host anti-affinity group | | | |
   | | | | |
   | **Volumes** | | | |
   | Create volume | | | |
   | Upload local volume | | | |
   | Upload volume from URL | | | |
   | Volume actions - snapshots, resize, migrate, download, create template | | 
| |
   | | | | |
   | **Snapshots** | | | |
   | Snapshot actions - create template/volume, revert, delete | | | |
   | | | | |
   | **VM Snapshots** | | | |
   | VM Snapshot actions - revert, delete | | | |
   | | | | |
   | **Backups** | | | |
   | | | | |
   | **Guest networks** | | | |
   | Add isolated network | | | |
   | Add L2 network | | | |
   | Add shared network | | | |
   | Network actions - update, restart, replace ACL list, delete | | | |
   | Add/delete egress rules | | | |
   | Acquire IP address | | | |
   | | | | |
   | **VPC**| | | |
   | Add VPC | | | |
   | VPC actions - updat, restart, delete | | | |
   | Add security group | | | |
   | Add/delete ingress/egress rule | | | |
   | | | | |
   | **Public IP Addresses** | | | |
   | Acquire new IP | | | |
   | Actions - enable static NAT, release IP, enable VPN | | | |
   | | | | |
   | **Templates**| | | |
   | Register template | | | |
   | Upload local template | | | |
   | Template actions - edit, download, update permissions, copy, delete | | | |
   | | | | |
   | **ISOs**| | | |
   | Register ISO | | | |
   | Upload local ISO | | | |
   | ISO actions - edit, download update permissions, copy, delete | | | |
   | | | | |
   | **Events**| | | |
   | Search, archive, delete | | | |
   | | | | |
   | **Projects** | | | |
   | Add project | | | |
   | Project actions - edit, suspend, add account, delete | | | |
   | Different projects with different permission | | | |
   | | | | |
   | **Accounts, users, roles** | | | |
   | Create/modify/check role/delete regular user account | | | |
   | Create/modify/check role/delete resource admin account | | | |
   | Create/modify/check role/delete domain admin account | | | |
   | Create/modify/check role/delete admin user | | | |
   | Account actions - edit, disable, lock, delete | | | |
   | | | | |
   | **Domains** | | | |
   | Create new domain | | | |
   | Create subdomain in the new domain | | | |
   | Delete the first domain (2nd, not 3rd level) | | | |
   | Edit/delete domain | | | |
   | Modify domain limits/settings | | | |
   | | | | |
   | **Roles** | | | |
   | Add new role | | | |
   | Role actions - edit, delete | | | |
   | | | | |
   | **Infrastructure summary**| | | |
   | | | | |
   | **Zones**| | | |
   | Add zone | | | |
   | Zone actions - edit, enable/disable, enable/disable HA, delete, etc. | | | 
|
   | Modify settings | | | |
   | | | | |
   | **Pods** | | | |
   | Add pod | | | |
   | Pod actions - edit, enable/disable, delete | | | |
   | | | | |
   | **Clusters** | | | |
   | Add cluster | | | |
   | Cluster actions - enable/disable, unmanage, enable/disable HA, delete, 
etc| | | |
   | | | | |
   | **Hosts** | | | |
   | Add host | | | |
   | Host actions - edit, enable/disable, maintenance mode, 
enable/disable/configure HA, etc. | | | |
   | | | | |
   | **Primary storage** | | | |
   | Add primary storage | | | |
   | Primary storage actions - edit, enable/disable maintenance mode | | | |
   | Settings - modify | | | |
   | | | | |
   | **Secondary storage** | | | |
   | Add secondary storage | | | |
   | Delete secondary storage | | | |
   | Settings - modify | | | |
   | | | | |
   | **Compute offering** | | | |
   | Add shared thin compute offering | | | |
   | Add local fat compute offering | | | |
   | Offering actions - edit, access, delete | | | |
   | | | | |
   | **System offering** | | | |
   | Add shared thin system offering for VR | | | |
   

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


blueorangutan commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654190854


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/472 (JID-)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


blueorangutan commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654189817


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2221)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


blueorangutan commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654187002


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


davidjumani commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654186464


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


blueorangutan commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654186086


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


davidjumani commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654185821


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


blueorangutan commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654184730


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2220)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


blueorangutan commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654180901


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


Pearl1594 commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654180486


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 closed pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


Pearl1594 closed pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus commented on issue #491: [BUG] The Create Instance wizard should have an 'Advanced section' to make requirements clear

2020-07-06 Thread GitBox


PaulAngus commented on issue #491:
URL: 
https://github.com/apache/cloudstack-primate/issues/491#issuecomment-654120586


   My thoughts:
   We are past the point that simply being able to see a parameter in the UI is 
enough.  At GA, the new UI needs to be 'great/good/acceptable' in its own 
right.  Part of Primate's purpose is to improve the user's experience; And in 
some cases (the create VM instance wizard) it makes the experience worse.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #491: [BUG] The Create Instance wizard should have an 'Advanced section' to make requirements clear

2020-07-06 Thread GitBox


rhtyd commented on issue #491:
URL: 
https://github.com/apache/cloudstack-primate/issues/491#issuecomment-654119576


   With @davidjumani 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #490: [BUG] Create VM Form - root disk size dialog is misleading

2020-07-06 Thread GitBox


rhtyd commented on issue #490:
URL: 
https://github.com/apache/cloudstack-primate/issues/490#issuecomment-654119031


   With @davidjumani 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled

2020-07-06 Thread GitBox


rhtyd commented on issue #487:
URL: 
https://github.com/apache/cloudstack-primate/issues/487#issuecomment-654118182


   With @davidjumani 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #485: [BUG] Actions for projects visible to users

2020-07-06 Thread GitBox


rhtyd commented on issue #485:
URL: 
https://github.com/apache/cloudstack-primate/issues/485#issuecomment-654114133


   With @Pearl1594 - as discussed please embed the two components and use 
`this.$set` see the Instance Tab component for example 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled

2020-07-06 Thread GitBox


rhtyd commented on issue #487:
URL: 
https://github.com/apache/cloudstack-primate/issues/487#issuecomment-654106248


   Legacy UI also show the backups view and offering even when the feature is 
disabled globally and for all zones
   ![Screenshot from 2020-07-06 
14-09-25](https://user-images.githubusercontent.com/95203/86573648-53c87d00-bf92-11ea-9548-7c72a7d7a54d.png)
   
   Using 
http://docs.cloudstack.apache.org/en/latest/adminguide/backup_and_recovery.html 
as a reference, if the feature is not globally enabled 
(backup.framework.enabled) then it must not be considered enabled; therefore 
the feature is considered enabled for a zone when it's globally enabled and 
enabled for a zone https://github.com/apache/cloudstack/pull/4202
   This will fix exporting the APIs, if feature is disabled it won't export 
APIs and clients such as cmk, Primate won't show APIs or views.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #495: Resource update isnt working

2020-07-06 Thread GitBox


rhtyd edited a comment on issue #495:
URL: 
https://github.com/apache/cloudstack-primate/issues/495#issuecomment-654095773


   Hi @gaaray2k thanks for reporting, but I'm unable to reproduce.
   - Which CloudStack version were you testing this against?
   - For the specific account (non-admin), did you try to change as which user 
role type (root admin or domain admin?)?
   - Can you try with latest 4.14 version or branch build and with latest 
Primate master?
   
   I tried changing the snapshot max limit to 2 as root admin:
   
   ![Screenshot from 2020-07-06 
14-02-12](https://user-images.githubusercontent.com/95203/86573100-845be700-bf91-11ea-903c-a59cecc34483.png)
   
   ![Screenshot from 2020-07-06 
14-02-25](https://user-images.githubusercontent.com/95203/86573103-86be4100-bf91-11ea-8838-4086aebc653f.png)
   
   I see resources count to be OK:
   ![Screenshot from 2020-07-06 
14-03-00](https://user-images.githubusercontent.com/95203/86573105-8756d780-bf91-11ea-9de6-75bd8c7fb321.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #495: Resource update isnt working

2020-07-06 Thread GitBox


rhtyd edited a comment on issue #495:
URL: 
https://github.com/apache/cloudstack-primate/issues/495#issuecomment-654095773


   Hi @gaaray2k thanks for reporting, but I'm unable to reproduce.
   - Which CloudStack version were you testing this against?
   - For the specific account (non-admin), did you try to change as which user 
role type (root admin or domain admin?)?
   - Can you try with latest 4.14 version or branch build and with latest 
Primate master?
   
   I tried changing the snapshot max limit to 2 and 0 for a normal user account 
as root admin:
   
   ![Screenshot from 2020-07-06 
14-02-25](https://user-images.githubusercontent.com/95203/86573103-86be4100-bf91-11ea-8838-4086aebc653f.png)
   
   ![Screenshot from 2020-07-06 
14-03-00](https://user-images.githubusercontent.com/95203/86573105-8756d780-bf91-11ea-9de6-75bd8c7fb321.png)
   
   I see resources count to be OK:
   
   ![Screenshot from 2020-07-06 
14-02-12](https://user-images.githubusercontent.com/95203/86573100-845be700-bf91-11ea-903c-a59cecc34483.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #495: Resource update isnt working

2020-07-06 Thread GitBox


rhtyd commented on issue #495:
URL: 
https://github.com/apache/cloudstack-primate/issues/495#issuecomment-654095773


   Hi @gaaray2k thanks for reporting, but I'm unable to reproduce. Which 
CloudStack version were you testing this against? Can you try with latest 4.14 
version or branch build and with latest Primate master?
   
   ![Screenshot from 2020-07-06 
14-02-12](https://user-images.githubusercontent.com/95203/86573100-845be700-bf91-11ea-903c-a59cecc34483.png)
   ![Screenshot from 2020-07-06 
14-02-25](https://user-images.githubusercontent.com/95203/86573103-86be4100-bf91-11ea-8838-4086aebc653f.png)
   ![Screenshot from 2020-07-06 
14-03-00](https://user-images.githubusercontent.com/95203/86573105-8756d780-bf91-11ea-9de6-75bd8c7fb321.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #483: add form element info tooltips

2020-07-06 Thread GitBox


rhtyd commented on pull request #483:
URL: 
https://github.com/apache/cloudstack-primate/pull/483#issuecomment-654093570


   @shwstppr is this ready for review? Please merge latest master.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-06 Thread GitBox


rhtyd commented on pull request #481:
URL: 
https://github.com/apache/cloudstack-primate/pull/481#issuecomment-654093276







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view

2020-07-06 Thread GitBox


rhtyd commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654093174


   Please merge latest master and fix any conflicts? Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #436: feature: template ovf properties

2020-07-06 Thread GitBox


rhtyd commented on pull request #436:
URL: 
https://github.com/apache/cloudstack-primate/pull/436#issuecomment-654093019


   Please merge latest master and fix any conflicts? Thanks.
   @davidjumani please take over and discuss with @DaanHoogland for any changes 
in the API/response done in backend.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #472: Fixing permission issues

2020-07-06 Thread GitBox


rhtyd commented on pull request #472:
URL: 
https://github.com/apache/cloudstack-primate/pull/472#issuecomment-654093239


   Please merge latest master and fix any conflicts? Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects

2020-07-06 Thread GitBox


rhtyd commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654092809


   Please merge latest master and fix any conflicts? Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #326: Form to Migrate data between Image stores

2020-07-06 Thread GitBox


rhtyd commented on pull request #326:
URL: 
https://github.com/apache/cloudstack-primate/pull/326#issuecomment-654092759


   Please merge latest master and fix any conflicts? Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #484: WIP: Spanish translations

2020-07-06 Thread GitBox


rhtyd commented on pull request #484:
URL: 
https://github.com/apache/cloudstack-primate/pull/484#issuecomment-654092250


   @nvazquez please follow 
https://github.com/apache/cloudstack-primate/pull/481 you or the other PR may 
cause conflicts for each other. Also please merge latest master, the drafts 
does not show if a PR has conflicts, until you click ready for review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #493: Internationalize state output

2020-07-06 Thread GitBox


rhtyd merged pull request #493:
URL: https://github.com/apache/cloudstack-primate/pull/493


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #494: Add internationalization for the login, projects top bar, documentation and report errors

2020-07-06 Thread GitBox


rhtyd merged pull request #494:
URL: https://github.com/apache/cloudstack-primate/pull/494


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org