Re: Review Request 28640: CLOUDSTACK-8010: [UI] Fixed unlocalized string label.add.private.gateway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28640/#review63908 --- Ship it! Ship It! - Brian Federle On Dec. 3, 2014, 9:44 a.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28640/ --- (Updated Dec. 3, 2014, 9:44 a.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-8010 https://issues.apache.org/jira/browse/CLOUDSTACK-8010 Repository: cloudstack-git Description --- Added label.add.private.gateway to the dictionary and messages Diffs - client/WEB-INF/classes/resources/messages.properties 3228578 ui/dictionary2.jsp c61e841 Diff: https://reviews.apache.org/r/28640/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 28043: CLOUDSTACK 7915: Remove hard-coded values for Load Balancer algorithms in UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28043/#review61817 --- I am getting conflicts in the properties file applying to the latest master (my HEAD is @ eba7cc78da751cc25994a5a736a87ce2e83c394e). There were a lot of changes lately to the localization strings, which is probably why it is conflicting; could you try updating the patch? Applying: CLOUDSTACK-7915: Remove hard-coded values for Load Balancer algorithms in UI error: patch failed: client/WEB-INF/classes/resources/messages_fr_FR.properties:1160 error: client/WEB-INF/classes/resources/messages_fr_FR.properties: patch does not apply error: patch failed: client/WEB-INF/classes/resources/messages_ja_JP.properties:740 error: client/WEB-INF/classes/resources/messages_ja_JP.properties: patch does not apply error: patch failed: client/WEB-INF/classes/resources/messages_zh_CN.properties:740 error: client/WEB-INF/classes/resources/messages_zh_CN.properties: patch does not apply Patch failed at 0001 CLOUDSTACK-7915: Remove hard-coded values for Load Balancer algorithms in UI - Brian Federle On Nov. 17, 2014, 6:26 p.m., Daniel Vega Simoes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28043/ --- (Updated Nov. 17, 2014, 6:26 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- JIRA: CLOUDSTACK 7915 Removed hard-coded values for Load Balancer algorithms in UI. Instead, now UI sets values loaded dynamically through load balancer provider capabilities. Also updated internationalization messages. Diffs - client/WEB-INF/classes/resources/messages.properties 86eb5c2 client/WEB-INF/classes/resources/messages_ar.properties 4f65118 client/WEB-INF/classes/resources/messages_es.properties f2d754e client/WEB-INF/classes/resources/messages_fr_FR.properties 004187f client/WEB-INF/classes/resources/messages_it_IT.properties e2f3f0b client/WEB-INF/classes/resources/messages_ja_JP.properties 7bc90b5 client/WEB-INF/classes/resources/messages_ko_KR.properties ce79d2e client/WEB-INF/classes/resources/messages_nb_NO.properties c169112 client/WEB-INF/classes/resources/messages_nl_NL.properties 89ef828 client/WEB-INF/classes/resources/messages_pl.properties 06d5ec2 client/WEB-INF/classes/resources/messages_pt_BR.properties 8ee08ba client/WEB-INF/classes/resources/messages_ru_RU.properties ff68668 client/WEB-INF/classes/resources/messages_zh_CN.properties ebba5e0 ui/dictionary.jsp 671f48f ui/scripts/network.js c27b999 ui/scripts/vpc.js af19d87 Diff: https://reviews.apache.org/r/28043/diff/ Testing --- Tests performed: - create new isolated network with DefaultIsolatedNetworkOffering, acquire new IP, list load balancer algorithms (UI) - create new shared network with DefaultSharedNetworkWithSourceNat, acquire new IP, list load balancer algorithms (UI) It should work correctly as long as network offering is configured with LB provider/capabilities. Otherwise, list of algorithms is empty in UI. Thanks, Daniel Vega Simoes
Re: Review Request 27991: CLOUDSTACK-7645: Use the localization function _l() instead of dictionary directly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27991/#review61491 --- Ship it! Ship It! - Brian Federle On Nov. 13, 2014, 2:55 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27991/ --- (Updated Nov. 13, 2014, 2:55 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Removed instances of dictionary[...], since all localization strings should go through the localization function _l(...) Diffs - ui/scripts/configuration.js 2a9829d ui/scripts/installWizard.js 85eaff0 ui/scripts/instances.js 0caaa39 ui/scripts/system.js c341db9 ui/scripts/ui-custom/zoneWizard.js 2c17f60 ui/scripts/zoneWizard.js 9fccb8b Diff: https://reviews.apache.org/r/27991/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 27863: CLOUDSTACK-7875: [UI] Wrong format check is being made on Create VPC box - DNS domain Information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27863/#review60817 --- Ship it! Ship It! - Brian Federle On Nov. 11, 2014, 11:33 a.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27863/ --- (Updated Nov. 11, 2014, 11:33 a.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7875 https://issues.apache.org/jira/browse/CLOUDSTACK-7875 Repository: cloudstack-git Description --- Fixing regression caused by CLOUDSTACK-7765. Removing IPv4 validation from the DNS field, the original behavior is restored. (The API validates this field.) Diffs - ui/scripts/network.js 501fb50c99c2e6c611d56f30325e6208cd06b4ac Diff: https://reviews.apache.org/r/27863/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 27878: CLOUDSTACK-7645: [UI] Fixed incorrect label issues caused the dictionary split
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27878/#review60821 --- Ship it! Ship It! - Brian Federle On Nov. 11, 2014, 5:37 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27878/ --- (Updated Nov. 11, 2014, 5:37 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7645 https://issues.apache.org/jira/browse/CLOUDSTACK-7645 Repository: cloudstack-git Description --- In some cases the UI does not display the correct text, displaying 'label.xyz' instead of the localized string. This appears to be due to the dictionary split: entries in dictionary2.jsp are not found because the dictionary has not been extended with dictionary2 as expected. In this fix: - Instead of extending the dictionary, we leave it as it is and change the localization function to look in the dictionary first and, if the item is not found there, then look in dictionary2. - This way we are not depending on the extent() function to be called at the 'right' time; In turn, the localization function will be aware of both dictionaries. - In the future, when we add another dictionary, we will have to modify this function only. Diffs - ui/scripts/cloudStack.js c5aa89c ui/scripts/sharedFunctions.js d463381 Diff: https://reviews.apache.org/r/27878/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 27683: CLOUDSTACK-7318: [UI] Add error handler for VM snapshot creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27683/#review60828 --- Ship it! Ship It! - Brian Federle On Nov. 6, 2014, 5:07 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27683/ --- (Updated Nov. 6, 2014, 5:07 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7318 https://issues.apache.org/jira/browse/CLOUDSTACK-7318 Repository: cloudstack-git Description --- Fixes the issue where processing wheel continue to spin even after error message is displayed during VM snapshot creation Diffs - ui/scripts/instances.js 3d5f9b8 Diff: https://reviews.apache.org/r/27683/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 27526: CLOUDSTACK-7831: Fixed unlocalized string on Advanced Network - Network tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27526/#review60823 --- Ship it! Ship It! - Brian Federle On Nov. 3, 2014, 4:11 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27526/ --- (Updated Nov. 3, 2014, 4:11 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Replaced 'label.ipv6.cidr' with 'label.ipv6.CIDR' Diffs - ui/scripts/system.js fd4df48 Diff: https://reviews.apache.org/r/27526/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 27727: CLOUDSTACK-3528: [UI]list calls are in the processing state forever with invalid name provided with Account name search filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27727/#review60842 --- Ship it! Ship It! - Brian Federle On Nov. 7, 2014, 2:29 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27727/ --- (Updated Nov. 7, 2014, 2:29 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-3528 https://issues.apache.org/jira/browse/CLOUDSTACK-3528 Repository: cloudstack-git Description --- Added error handling for Events, Instances, Network, Projects, Storage pages where an advanced search by an invalid account name was making the UI to show in progress state forever. Diffs - ui/scripts/events.js ea4b940b3036ca5010ccedc16ade28c62b800d96 ui/scripts/instances.js 838e4d56b4fb72ee694e3b811bfff1b4e324753e ui/scripts/network.js 278545bff59d247c528283d136eb5b8ec831892c ui/scripts/projects.js 7453b535c0df9a02cc1b97fb437b7f74f6004f27 ui/scripts/storage.js 90720ac991470c6b8efef2a24c53b9595b88de79 Diff: https://reviews.apache.org/r/27727/diff/ Testing --- Tested all the affected Advanced Search features. Thanks, Gabor Apati-Nagy
Re: Review Request 27527: Fixing previous commit CLOUDSTACK-7720: No IP Address Validation for Acquire new secondary IP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27527/#review59824 --- Ship it! Ship It! - Brian Federle On Nov. 3, 2014, 4:28 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27527/ --- (Updated Nov. 3, 2014, 4:28 p.m.) Review request for cloudstack, Brian Federle, Jayapal Reddy, and Jessica Wang. Bugs: CLOUDSTACK-7720 https://issues.apache.org/jira/browse/CLOUDSTACK-7720 Repository: cloudstack-git Description --- Fixing Jayapal's finding (see https://issues.apache.org/jira/browse/CLOUDSTACK-7720 ) Removed required constraint from the IP address field (this is an optional field) Diffs - ui/scripts/network.js 278545bff59d247c528283d136eb5b8ec831892c Diff: https://reviews.apache.org/r/27527/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 27581: CLOUDSTACK-7838: UI - Update category names on Resources tab of a Zone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27581/#review59827 --- Ship it! Ship It! - Brian Federle On Nov. 4, 2014, 7 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27581/ --- (Updated Nov. 4, 2014, 7 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7838 https://issues.apache.org/jira/browse/CLOUDSTACK-7838 Repository: cloudstack-git Description --- Make the wordings better on the Resources tab of a Zone. Storage - Primary Storage Used CPU - CPU allocated Memory - Memory Allocated Diffs - ui/scripts/ui-custom/zoneChart.js ac3c0e475a5f2edf951adba20aeb06429107ed73 Diff: https://reviews.apache.org/r/27581/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 27583: CLOUDSTACK-7840: UI control tip for 'Add Primary Storage' - 'Provider' seems wrong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27583/#review59829 --- Ship it! Ship It! - Brian Federle On Nov. 4, 2014, 7 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27583/ --- (Updated Nov. 4, 2014, 7 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7840 https://issues.apache.org/jira/browse/CLOUDSTACK-7840 Repository: cloudstack-git Description --- Removed the invalid help text. Diffs - ui/scripts/system.js 7b25c818bf863cacbaae5c70abf60d98f153dbc4 Diff: https://reviews.apache.org/r/27583/diff/ Testing --- Thanks, Gabor Apati-Nagy
RE: UI: where has Acquire new IP button disappeared?
I just cherry-picked and verified that commit in 4.4. -Brian -Original Message- From: Gabor Apati-Nagy Sent: Thursday, October 30, 2014 9:48 AM To: Brian Federle; dev@cloudstack.apache.org Subject: RE: UI: where has Acquire new IP button disappeared? Could someone cherry-pick this to 4.4? That would fix CLOUDSTACK-7782. Cheers, Gabor -Original Message- From: Brian Federle Sent: 27 October 2014 17:58 To: Gabor Apati-Nagy; dev@cloudstack.apache.org Subject: RE: UI: where has Acquire new IP button disappeared? Gabor, yes, that shouldn't be a problem to cherry-pick it into 4.4. -Brian From: Gabor Apati-Nagy Sent: Monday, October 27, 2014 9:26 AM To: dev@cloudstack.apache.org Cc: Brian Federle Subject: RE: UI: where has Acquire new IP button disappeared? It seems that this fix for Critical bug CLOUDSTACK-6590 (commit d9fcb877309ce176d5458e63bfd1a174344b5fce) is only in master, but not in 4.4. In order to fix this in 4.4 as well, I would suggest it to be cherry-picked to 4.4. Brian, is this feasible? Thanks, Gabor -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: 27 October 2014 10:45 To: dev@cloudstack.apache.org Subject: Re: UI: where has Acquire new IP button disappeared? Thanks for that, the new javascript file fixed the issue. https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=ui/scripts/ui/widgets/detailView.js;h=9c73911f3dcaecd8327f76c84043c115fdb184d9;hb=d9fcb87 -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Jayapal Reddy Uradi jayapalreddy.ur...@citrix.com To: dev@cloudstack.apache.org dev@cloudstack.apache.org Sent: Monday, 27 October, 2014 10:24:14 Subject: Re: UI: where has Acquire new IP button disappeared? Please check similar bug fix https://issues.apache.org/jira/browse/CLOUDSTACK-6590 -Jayapal On 27-Oct-2014, at 3:40 PM, Gabor Apati-Nagy gabor.apati-n...@citrix.com wrote: I mean gridview is the table that the page displays. This has a row with the IP Address, that should display the button, but I see it is not there... Let me look into this later. Thanks Gabor -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: 24 October 2014 16:42 To: dev@cloudstack.apache.org Subject: Re: UI: where has Acquire new IP button disappeared? Hello, This might sound stupid, but what is this gridview you are talking of? This is what I am seeing http://imgur.com/9fl6ERD -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Gabor Apati-Nagy gabor.apati-n...@citrix.com To: dev@cloudstack.apache.org Sent: Friday, 24 October, 2014 14:26:40 Subject: RE: UI: where has Acquire new IP button disappeared? Hi Lucian, The View secondary IP button should be displayed next to the IP Address in the gridview. Clicking on that this page should display the Acquire new secondary IP button. I have tested this in master and we seem to have the same code in 4.4. Could you double check this? It could be confusing that the first button is not in the heading, but is located in the grid. Cheers, Gabor -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: 24 October 2014 09:44 To: dev@cloudstack.apache.org Subject: Re: UI: where has Acquire new IP button disappeared? Opened https://issues.apache.org/jira/browse/CLOUDSTACK-7782 for this. Anyone knows who we can bug for a fix? -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Nux! n...@li.nux.ro To: dev@cloudstack.apache.org Sent: Friday, 24 October, 2014 00:32:55 Subject: UI: where has Acquire new IP button disappeared? Hi, Only now I notice that the option in the NIC tab of a VM (Basic/Adv+SG) no longer has the Acquire secondary button, nor does it list the Secondary IPs. I can set and see the extra IPs in cloudmonkey though if I run: add iptonic nicid=XXX list nics nicid=XXX virtualmachineid=XXX This is not OK ... alas I notice it too late. Promise to test more next release. Any way I can get that back? I have people using the UI who rely on this feature. Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro
Re: Review Request 27297: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27297/#review59007 --- Ship it! Ship It! - Brian Federle On Oct. 29, 2014, 3:17 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27297/ --- (Updated Oct. 29, 2014, 3:17 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7765 https://issues.apache.org/jira/browse/CLOUDSTACK-7765 Repository: cloudstack-git Description --- Validation on the super CIDR and DNS domain fields Diffs - ui/scripts/network.js fb293ed0b3a3ace8dd0fdbeaea00dd7896af6d32 ui/scripts/sharedFunctions.js e044d24fc8221aec23e9f140b6c391bf85c88f3a Diff: https://reviews.apache.org/r/27297/diff/ Testing --- Checked validation on the super CIDR and DNS domain fields Thanks, Gabor Apati-Nagy
Re: Review Request 27300: CLOUDSTACK-7766: Field Validations Missing for Ingress and Egress Rules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27300/#review59012 --- Ship it! Ship It! - Brian Federle On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27300/ --- (Updated Oct. 28, 2014, 7:16 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7766 https://issues.apache.org/jira/browse/CLOUDSTACK-7766 Repository: cloudstack-git Description --- Field Validations for the Start Port, End Port and CIDR fields Ingress and Egress rules. NOTE: In order for this patch to work it needs [CLOUDSTACK-7765: Field Validations Missing for VPC IP Address] applied before. Diffs - ui/scripts/network.js 9d79d3fa8b391ce0ad652ae35d9c3f52bae477a3 ui/scripts/ui/widgets/multiEdit.js c4de8cecbe296607dac90a2c1eb6d362e33b1033 Diff: https://reviews.apache.org/r/27300/diff/ Testing --- Tested validation on these fields Thanks, Gabor Apati-Nagy
Re: Review Request 26703: CLOUDSTACK-7720: No IP Address Validation for Acquire new secondary IP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26703/#review58871 --- Ship it! Ship It! - Brian Federle On Oct. 14, 2014, 6:12 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26703/ --- (Updated Oct. 14, 2014, 6:12 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7720 https://issues.apache.org/jira/browse/CLOUDSTACK-7720 Repository: cloudstack-git Description --- Added validation for the secondary IP address field. Diffs - ui/scripts/network.js 9d79d3fa8b391ce0ad652ae35d9c3f52bae477a3 Diff: https://reviews.apache.org/r/26703/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 26693: CLOUDSTACK-7718: No Field Validations on Zone Form
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26693/#review58873 --- Ship it! Ship It! - Brian Federle On Oct. 14, 2014, 6:12 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26693/ --- (Updated Oct. 14, 2014, 6:12 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7718 https://issues.apache.org/jira/browse/CLOUDSTACK-7718 Repository: cloudstack-git Description --- Added validation This patch depends on CLOUDSTACK-7659 (UI: Upgrade jquery-validate lib to the latest 1.13.0 version with the additional-methods included.) Diffs - ui/scripts/zoneWizard.js 2c90f2b084e914debd128110fca09f26ffdfcbac Diff: https://reviews.apache.org/r/26693/diff/ Testing --- Tested fields with modified validation on them having applied commit[1] for CLOUDSTACK-7659 before [1] https://reviews.apache.org/r/26053/ Thanks, Gabor Apati-Nagy
Re: Review Request 27296: CLOUDSTACK-7764: No IP Address Validations when Adding Networks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27296/#review58875 --- Ship it! Ship It! - Brian Federle On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27296/ --- (Updated Oct. 28, 2014, 7:16 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7764 https://issues.apache.org/jira/browse/CLOUDSTACK-7764 Repository: cloudstack-git Description --- Networks Added validations for Add Network form on IPv4 Gateway, IPv4 Netmask, IPv4 Start IP, IPv4 End IP, IPv6 Gateway, IPv6 CIDR, IPv6 Start IP, IPv6 End IP fields. Diffs - ui/scripts/sharedFunctions.js 8ec88b392eefd35c1d0b133097d17c82c3d65549 Diff: https://reviews.apache.org/r/27296/diff/ Testing --- Tested validation on these fields. Thanks, Gabor Apati-Nagy
Re: Review Request 27297: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27297/#review58880 --- Gabor, I am getting a conflict on the latest master: bfederle$ git am ~/Downloads/0001-CLOUDSTACK-7765-Field-Validations-Missing-for-VPC-IP.patch Applying: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields error: patch failed: ui/scripts/sharedFunctions.js:2224 error: ui/scripts/sharedFunctions.js: patch does not apply Patch failed at 0001 CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields - Brian Federle On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27297/ --- (Updated Oct. 28, 2014, 7:16 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7765 https://issues.apache.org/jira/browse/CLOUDSTACK-7765 Repository: cloudstack-git Description --- Validation on the super CIDR and DNS domain fields Diffs - ui/scripts/network.js 9d79d3fa8b391ce0ad652ae35d9c3f52bae477a3 ui/scripts/sharedFunctions.js 8ec88b392eefd35c1d0b133097d17c82c3d65549 Diff: https://reviews.apache.org/r/27297/diff/ Testing --- Checked validation on the super CIDR and DNS domain fields Thanks, Gabor Apati-Nagy
Re: Review Request 27300: CLOUDSTACK-7766: Field Validations Missing for Ingress and Egress Rules
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27300/#review58881
---
Gabor, I am getting an error from this on the add VPC dialog, for the new
validation present on the network domain field:
networkdomain: {
docID: 'helpVPCDomain',
-label:
'label.DNS.domain.for.guest.networks'
+label:
'label.DNS.domain.for.guest.networks',
+validation: {
+ipv4: true
+}
},
Uncaught TypeError: Cannot read property 'call' of undefined
-- I think this might be because your other patch for CLOUDSTACK-7765 wasn't
applied yet (due to conflicts), but can you confirm if you are able to
reproduce this issue or not, once fixing the other patch?
- Brian Federle
On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27300/
---
(Updated Oct. 28, 2014, 7:16 p.m.)
Review request for cloudstack, Brian Federle and Jessica Wang.
Bugs: CLOUDSTACK-7766
https://issues.apache.org/jira/browse/CLOUDSTACK-7766
Repository: cloudstack-git
Description
---
Field Validations for the Start Port, End Port and CIDR fields
Ingress and Egress rules.
NOTE: In order for this patch to work it needs [CLOUDSTACK-7765: Field
Validations Missing for VPC IP Address] applied before.
Diffs
-
ui/scripts/network.js 9d79d3fa8b391ce0ad652ae35d9c3f52bae477a3
ui/scripts/ui/widgets/multiEdit.js c4de8cecbe296607dac90a2c1eb6d362e33b1033
Diff: https://reviews.apache.org/r/27300/diff/
Testing
---
Tested validation on these fields
Thanks,
Gabor Apati-Nagy
Re: Review Request 27302: CLOUDSTACK-7808: Typo in Zone Creation Wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27302/#review58883 --- Ship it! Ship It! - Brian Federle On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27302/ --- (Updated Oct. 28, 2014, 7:16 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7808 https://issues.apache.org/jira/browse/CLOUDSTACK-7808 Repository: cloudstack-git Description --- fixed typo in the text: CloudStack\'s is shown instead of CloudStack's. Diffs - client/WEB-INF/classes/resources/messages.properties a76855f763e0659066977afa1bea844f7ba36014 Diff: https://reviews.apache.org/r/27302/diff/ Testing --- Thanks, Gabor Apati-Nagy
RE: UI: where has Acquire new IP button disappeared?
Gabor, yes, that shouldn't be a problem to cherry-pick it into 4.4. -Brian From: Gabor Apati-Nagy Sent: Monday, October 27, 2014 9:26 AM To: dev@cloudstack.apache.org Cc: Brian Federle Subject: RE: UI: where has Acquire new IP button disappeared? It seems that this fix for Critical bug CLOUDSTACK-6590 (commit d9fcb877309ce176d5458e63bfd1a174344b5fce) is only in master, but not in 4.4. In order to fix this in 4.4 as well, I would suggest it to be cherry-picked to 4.4. Brian, is this feasible? Thanks, Gabor -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: 27 October 2014 10:45 To: dev@cloudstack.apache.org Subject: Re: UI: where has Acquire new IP button disappeared? Thanks for that, the new javascript file fixed the issue. https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=ui/scripts/ui/widgets/detailView.js;h=9c73911f3dcaecd8327f76c84043c115fdb184d9;hb=d9fcb87 -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Jayapal Reddy Uradi jayapalreddy.ur...@citrix.com To: dev@cloudstack.apache.org dev@cloudstack.apache.org Sent: Monday, 27 October, 2014 10:24:14 Subject: Re: UI: where has Acquire new IP button disappeared? Please check similar bug fix https://issues.apache.org/jira/browse/CLOUDSTACK-6590 -Jayapal On 27-Oct-2014, at 3:40 PM, Gabor Apati-Nagy gabor.apati-n...@citrix.com wrote: I mean gridview is the table that the page displays. This has a row with the IP Address, that should display the button, but I see it is not there... Let me look into this later. Thanks Gabor -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: 24 October 2014 16:42 To: dev@cloudstack.apache.org Subject: Re: UI: where has Acquire new IP button disappeared? Hello, This might sound stupid, but what is this gridview you are talking of? This is what I am seeing http://imgur.com/9fl6ERD -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Gabor Apati-Nagy gabor.apati-n...@citrix.com To: dev@cloudstack.apache.org Sent: Friday, 24 October, 2014 14:26:40 Subject: RE: UI: where has Acquire new IP button disappeared? Hi Lucian, The View secondary IP button should be displayed next to the IP Address in the gridview. Clicking on that this page should display the Acquire new secondary IP button. I have tested this in master and we seem to have the same code in 4.4. Could you double check this? It could be confusing that the first button is not in the heading, but is located in the grid. Cheers, Gabor -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: 24 October 2014 09:44 To: dev@cloudstack.apache.org Subject: Re: UI: where has Acquire new IP button disappeared? Opened https://issues.apache.org/jira/browse/CLOUDSTACK-7782 for this. Anyone knows who we can bug for a fix? -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Nux! n...@li.nux.ro To: dev@cloudstack.apache.org Sent: Friday, 24 October, 2014 00:32:55 Subject: UI: where has Acquire new IP button disappeared? Hi, Only now I notice that the option in the NIC tab of a VM (Basic/Adv+SG) no longer has the Acquire secondary button, nor does it list the Secondary IPs. I can set and see the extra IPs in cloudmonkey though if I run: add iptonic nicid=XXX list nics nicid=XXX virtualmachineid=XXX This is not OK ... alas I notice it too late. Promise to test more next release. Any way I can get that back? I have people using the UI who rely on this feature. Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro
Re: Review Request 26053: UI: Upgrade jquery-validate lib to the latest 1.13.0 version with the additional-methods included.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26053/#review58680 --- Ship it! Ship It! - Brian Federle On Oct. 27, 2014, 5:10 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26053/ --- (Updated Oct. 27, 2014, 5:10 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7659 https://issues.apache.org/jira/browse/CLOUDSTACK-7659 Repository: cloudstack-git Description --- This patch upgrades jquery-validation library and also adds the additional-methods.js extension that offers additional validation options (same license applies, same publisher). I also updated the LICENSE file to show the added file as well. Diffs - LICENSE 497323bffce2b2afab28c187cfdafa960944ed94 ui/index.jsp 42973f70855d0ef00391cf69ddd895d0b832aa8a ui/lib/jquery.validate.additional-methods.js PRE-CREATION ui/lib/jquery.validate.js 72296a61f208298f2e54ac7b54b70557f41e0f84 ui/scripts/ui/core.js add7d06dedb1101b152fee53caa300d0104ab2cc Diff: https://reviews.apache.org/r/26053/diff/ Testing --- Tested that the validation is still working as expected. Thanks, Gabor Apati-Nagy
Re: Review Request 26220: CLOUDSTACK-7645: [UI] Fixing incorrect labels, including instances of ???label.*???
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26220/#review55222 --- Ship it! Ship It! - Brian Federle On Oct. 1, 2014, 9:25 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26220/ --- (Updated Oct. 1, 2014, 9:25 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7596, CLOUDSTACK-7597, CLOUDSTACK-7606, CLOUDSTACK-7607, CLOUDSTACK-7608, and CLOUDSTACK-7645 https://issues.apache.org/jira/browse/CLOUDSTACK-7596 https://issues.apache.org/jira/browse/CLOUDSTACK-7597 https://issues.apache.org/jira/browse/CLOUDSTACK-7606 https://issues.apache.org/jira/browse/CLOUDSTACK-7607 https://issues.apache.org/jira/browse/CLOUDSTACK-7608 https://issues.apache.org/jira/browse/CLOUDSTACK-7645 Repository: cloudstack-git Description --- - removed duplicate entries in dictionary - added dictionary entries that have been missed during the dictionary split - added missing entries in messages.properties - fixed other localization issues Diffs - client/WEB-INF/classes/resources/messages.properties c9eb7ae ui/dictionary.jsp c03ad67 ui/dictionary2.jsp 39299b3 ui/scripts/configuration.js b6c94f8 ui/scripts/storage.js 783633c ui/scripts/templates.js 9665ffd ui/scripts/ui-custom/physicalResources.js 7dd5380 Diff: https://reviews.apache.org/r/26220/diff/ Testing --- I've checked all the issues that have been reported, and they are all fixed. Thanks, Mihaela Stoica
Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24090/#review53742 --- Ship it! Ship It! - Brian Federle On Sept. 12, 2014, 9:53 a.m., Vetrivel Chinnasamy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24090/ --- (Updated Sept. 12, 2014, 9:53 a.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Externalized the hard-coded strings from JavaScript files to resource bundles. Updated the dictionary.jsp file accordingly. Also got the externalized strings translated in JA SC. Diffs - client/WEB-INF/classes/resources/messages.properties 4655973 client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1 client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc ui/dictionary.jsp 0102144 ui/dictionary2.jsp PRE-CREATION ui/index.jsp 48afa6a ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3 ui/scripts/accounts.js cc4624a ui/scripts/autoscaler.js c8963fd ui/scripts/cloudStack.js 38cf501 ui/scripts/configuration.js a70c672 ui/scripts/domains.js 488382e ui/scripts/events.js 2731cb6 ui/scripts/instances.js 4d536e3 ui/scripts/lbStickyPolicy.js 16995f6 ui/scripts/network.js 02dd269 ui/scripts/projects.js 53b7964 ui/scripts/regions.js 368c1bf ui/scripts/sharedFunctions.js 41f5d3a ui/scripts/storage.js f4ab6e1 ui/scripts/system.js 54aafe2 ui/scripts/templates.js 6dcd6da ui/scripts/ui-custom/autoscaler.js 0aa6c77 ui/scripts/ui-custom/healthCheck.js 4e10f1c ui/scripts/ui-custom/physicalResources.js 110945e ui/scripts/ui-custom/regions.js 986e009 ui/scripts/ui-custom/zoneWizard.js f3a1aae ui/scripts/ui/dialog.js 6c77924 ui/scripts/ui/widgets/listView.js c7b4a4d ui/scripts/ui/widgets/multiEdit.js 47e5f43 ui/scripts/vpc.js 786cb26 ui/scripts/zoneWizard.js 4498534 Diff: https://reviews.apache.org/r/24090/diff/ Testing --- Tested by replacing the modified javascript , dictionary.jsp and properties files. Thanks, Vetrivel Chinnasamy
Re: Review Request 22147: CLOUDSTACK-6722: Fix: [OVS][UI] Network created with StretchedL2Subnet is not available for vm deployement in other zones
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22147/#review53085 --- Ship it! Ship It! - Brian Federle On June 2, 2014, 5:10 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22147/ --- (Updated June 2, 2014, 5:10 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6722 https://issues.apache.org/jira/browse/CLOUDSTACK-6722 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-6722: [OVS][UI] Network created with StretchedL2Subnet is not available for vm deployement in other zones Diffs - ui/scripts/instanceWizard.js 9df6ecc Diff: https://reviews.apache.org/r/22147/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 22143: CLOUDSTACK-6725: Fix: [OVS][UI] vm deployment wizard does not show all available zones in a region while deploying vm in a Regionlevel vpc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22143/#review53091 --- Ship it! Ship It! - Brian Federle On June 2, 2014, 5:07 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22143/ --- (Updated June 2, 2014, 5:07 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6725 https://issues.apache.org/jira/browse/CLOUDSTACK-6725 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-6725 [OVS][UI] vm deployment wizard does not show all available zones in a region while deploying vm in a Regionlevel vpc Diffs - ui/scripts/instanceWizard.js 9df6ecc Diff: https://reviews.apache.org/r/22143/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24090/#review52917 --- Vetri, I have a conflict in vpc.js...please rebase changes to the latest master and regenerate patch. Thanks. error: patch failed: ui/scripts/vpc.js:698 error: ui/scripts/vpc.js: patch does not apply Patch failed at 0001 Fixes: Externalized hardcoded strings and splitted up dictionary file - Brian Federle On Sept. 8, 2014, 11:43 a.m., Vetrivel Chinnasamy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24090/ --- (Updated Sept. 8, 2014, 11:43 a.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Externalized the hard-coded strings from JavaScript files to resource bundles. Updated the dictionary.jsp file accordingly. Also got the externalized strings translated in JA SC. Diffs - client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1 client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc ui/dictionary.jsp 0102144 ui/dictionary2.jsp PRE-CREATION ui/index.jsp 48afa6a ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3 ui/scripts/accounts.js cc4624a ui/scripts/autoscaler.js c8963fd ui/scripts/cloudStack.js 38cf501 ui/scripts/configuration.js a70c672 ui/scripts/domains.js 488382e ui/scripts/events.js 2731cb6 ui/scripts/instances.js 4d536e3 ui/scripts/lbStickyPolicy.js 16995f6 ui/scripts/network.js 8a758c8 ui/scripts/projects.js 53b7964 ui/scripts/regions.js 368c1bf ui/scripts/sharedFunctions.js bb2d596 ui/scripts/storage.js f4ab6e1 ui/scripts/system.js cf3b9dc ui/scripts/templates.js 6dcd6da ui/scripts/ui-custom/autoscaler.js 0aa6c77 ui/scripts/ui-custom/healthCheck.js 4e10f1c ui/scripts/ui-custom/physicalResources.js 110945e ui/scripts/ui-custom/regions.js 986e009 ui/scripts/ui-custom/zoneWizard.js f3a1aae ui/scripts/ui/dialog.js 6c77924 ui/scripts/ui/widgets/listView.js 22182c1 ui/scripts/ui/widgets/multiEdit.js 47e5f43 ui/scripts/vpc.js d3602fc ui/scripts/zoneWizard.js 4498534 Diff: https://reviews.apache.org/r/24090/diff/ Testing --- Tested by replacing the modified javascript , dictionary.jsp and properties files. Thanks, Vetrivel Chinnasamy
Re: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25029/#review51576 --- Ship it! Ship It! - Brian Federle On Aug. 25, 2014, 8:42 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25029/ --- (Updated Aug. 25, 2014, 8:42 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Replaced jquery.js file. Diffs - ui/lib/jquery.js 5d5a1d58ee5148d010b2029c419356440e679941 Diff: https://reviews.apache.org/r/25029/diff/ Testing --- I have done smoke test on the UI. Thanks, Gabor Apati-Nagy
RE: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4
Hi David, I just updated NOTICE. I verified that the content in LICENSE is still the same from the prior version. -Brian 182a0786bdab96b2bc582bce7b8e0fee685d8fd4 HEAD asf/master master Author: Brian Federle brian.fede...@citrix.com Date: Tue Aug 26 13:13:29 2014 -0700 Update NOTICE to account for updated jQuery version 1 file changed, 2 insertions(+), 2 deletions(-) NOTICE | 4 ++-- Modified NOTICE diff --git a/NOTICE b/NOTICE index a74c0dc..b19e4a4 100644 --- a/NOTICE +++ b/NOTICE @@ -29,7 +29,7 @@ Copyright 2014 The Apache Software Foundation jquery.js -jQuery JavaScript Library v1.6.1 +jQuery JavaScript Library v1.6.4 http://jquery.com/ Copyright 2011, John Resig @@ -41,7 +41,7 @@ Copyright 2014 The Apache Software Foundation Copyright 2011, The Dojo Foundation Released under the MIT, BSD, and GPL Licenses. -Date: Thu May 12 15:04:36 2011 -0400 +Date: Mon Sep 12 18:54:48 2011 -0400 -Original Message- From: David Nalley [mailto:da...@gnsa.us] Sent: Tuesday, August 26, 2014 1:05 PM To: dev@cloudstack.apache.org; Gabor Apati-Nagy Cc: Jessica Wang; Brian Federle Subject: Re: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4 This has implications for LICENSE and NOTICE. Please ensure they get updated as well. --David On Mon, Aug 25, 2014 at 4:42 PM, Gabor Apati-Nagy gabor.apati-n...@citrix.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25029/ --- Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Replaced jquery.js file. Diffs - ui/lib/jquery.js 5d5a1d58ee5148d010b2029c419356440e679941 Diff: https://reviews.apache.org/r/25029/diff/ Testing --- I have done smoke test on the UI. Thanks, Gabor Apati-Nagy
Re: Review Request 24504: CLOUDSTACK-7293: UI: Fixed localization issues on the login page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24504/#review50749 --- Ship it! Ship It! - Brian Federle On Aug. 8, 2014, 2:27 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24504/ --- (Updated Aug. 8, 2014, 2:27 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- - Reverted the validator.messages to the original values (jquery.validator.js). - Added a function to localize validator.messages which is called before login. Diffs - ui/lib/jquery.validate.js 2ee3961 ui/scripts/cloudStack.js 2285276 ui/scripts/ui/utils.js 769aea7 Diff: https://reviews.apache.org/r/24504/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 19675: [CLOUDSTACK-6228] Added the ability to show warning (exclamation mark) icon on confirmation dialogs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19675/#review50638 --- Ship it! Ship It! - Brian Federle On March 26, 2014, 10:47 a.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19675/ --- (Updated March 26, 2014, 10:47 a.m.) Review request for cloudstack and Brian Federle. Repository: cloudstack-git Description --- Added the ability to display a warning icon on confirmation dialogs, rendered via both dialog.createForm() and dialog.confirm(): dialog.js: confirm() and createForm() functions: – added isWarning parameter. – when used with isWarning: true, will show the warning icon in title bar (see .ui-dialog.warning .ui-dialog-title in cloudstack3.css). detailView.js: - passing isWarning argument to dialog.confirm(). cloudstack3.css: - added .ui-dialog.warning .ui-dialog-title for the title bar with warning (white exclamation mark on orange circle) icon. instances.js: - using isWarning for destroy instance action. network.js: - using isWarning for delete network action. My intention is to change all ‘delete’ confirmation dialogs to display the warning icon. Maybe other dialogs could use this as well, especially disruptive actions , like for example ‘restart network’. Diffs - ui/css/cloudstack3.css f5582b6 ui/scripts/instances.js d219e6d ui/scripts/network.js f82a295 ui/scripts/ui/dialog.js 82e7fd4 ui/scripts/ui/widgets/detailView.js 4c5aeea Diff: https://reviews.apache.org/r/19675/diff/ Testing --- Thanks, Mihaela Stoica
RE: [ACS4.5] GUI Question
I think the main area to look in is dialog.js, which handles rendering the form dialogs. One possible approach: - Edit the dialog.js - ‘createForm’ widget function, find the each loop where the fields are iterated - Here, you can check for a new type param of your choosing (such as field.type === ‘tagger’). The ‘type’ is determined by a bunch of if-else statements -- nothing fancy ☺ - If the field matches this type, there is already a ‘tagger’ widget that you can use to render a comma-delimited tag list. You can see the code in ui/widgets/tagger.js for how it can be implemented. It uses the jQuery widget model, like the rest of the CS UI components. - You’ll probably have to tweak the CSS styles to fit the tagger widget into the dialog properly (since right now it is only used in some detail views). - Edit createForm’s ‘complete’ function, which is triggered after pressing OK and before passing the data to whatever action needs it. Here, you can parse the tag fields and append stuff to the ‘data’ object, which contains the other serialized form data. The ‘data’ object will finally be passed to the action’s API calls. - You can then add more fields to the existing dialog(s), and edit their AJAX calls to read your new tag-type fields. Hope that helps. -Brian From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Monday, July 28, 2014 6:49 PM To: dev@cloudstack.apache.org Cc: Brian Federle; Jessica Wang; Alena Prokharchyk; Seif Eddine Jemli Subject: Re: [ACS4.5] GUI Question Just to add a bit more detail: Seif is looking to create a new dialog that can utilize this control. One could access this new dialog - perhaps - by clicking on a new button to the right of the Storage Tags text field (ex. in the Add Primary Storage dialog). This new dialog would utilize the new control to show the admin all existing storage tags, allow for tags to be selected, and provide hints when a user types in a new tag. When this dialog is OKed, the storage tags can be listed in a comma-separated fashion in the, say, Add Primary Storage dialog. This way the admin doesn't have to guess at storage tags when entering them in a manual fashion. On Mon, Jul 28, 2014 at 7:43 PM, Mike Tutkowski mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com wrote: Hi, My student for GSoC, Seif, was interested in adding this control to CloudStack's GUI codebase: http://loopj.com/jquery-tokeninput/ He's already written a new API command that retrieves a list of storage tags (in addition to other work for GSoC). Ideally he would be able to augment a couple dialogs that use storage tags to make use of this control so that admins could more easily input storage tags (ex. they could see existing storage tags in a list and be assisted by suggestions when typing in a storage tag). Would anyone (I've CCed some people who often work on the CS GUI) be able to provide Seif insight into where he should start with this task? It might make sense for him to extend this control and then utilize this extension in multiple places in the GUI. It would be great if he had a bit of guidance with regards to how this might fit into the existing CS GUI architecture. Thanks! -- Mike Tutkowski Senior CloudStack Developer, SolidFire Inc. e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302tel:303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play™ -- Mike Tutkowski Senior CloudStack Developer, SolidFire Inc. e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play™
RE: [ACS4.5] GUI Question
I think that would be doable. One idea is to extend that 'tagger' widget, or a plain text field if that is all you need, to bind a 'change' event to the text field, which would trigger an AJAX call to the listStorageTags and display a popup box of results generated via jQuery (i.e., generate a new div with a ul list inside). The only concern would be triggering too many API calls at once. You might have to only request during a regular interval (i.e., every second) to prevent a 'too many API calls' error. However, the approach you described is pretty much how the rest of UI handles API data -- parsing a JSON response and formatting for the user. -Brian -Original Message- From: Seif Eddine Jemli [mailto:seifeddineje...@gmail.com] Sent: Tuesday, July 29, 2014 3:15 PM To: Mike Tutkowski; Brian Federle; Alena Prokharchyk; dev@cloudstack.apache.org Subject: Re: [ACS4.5] GUI Question Hi Brian, Actually what we want exactly to do is adding autocompletion to the Storage Tags field in the Create Primary Storage dialog. Ideally, it will look like this :* http://i.imgur.com/2ypzmGN.png http://i.imgur.com/2ypzmGN.png* So, suggestions of existing storage tags that match the typed letters will be listed to the user on the fly. I created an API call : *listStorageTags* that will be called by the frontend when we write letters (the letters will be sent as a GET param). The frontend will then get a *JSON list* from the backend (the list of the matching storage tags, result of the listStorageTags call) to display them as suggestions to the user. Is this doable with the current UI code architecture? thanks
RE: Accounts - Add Account UI Question
Yes, from looking at the code, the ui-custom/accountsWizard.js needs to also
have a success function. Not sure why it was omitted.
A fix to add a notification could be:
response: {
success: function() {
$(window).trigger('cloudStack.addNotification', { ... });\
}
}
Then add the correct options to trigger a notification. I don't remember the
exact options for addNotification, but looking through the code you can find
other examples as reference.
-Brian
From: Ian Duffy [i...@ianduffy.ie]
Sent: Tuesday, May 13, 2014 2:11 PM
To: CloudStack Dev
Cc: Brian Federle; Jessica Wang; Stephen Turner
Subject: Re: Accounts - Add Account UI Question
Hi Thomas,
Looks like a possible bug.
CCing the UI team. They may be able to offer more info.
On 13 May 2014 04:00, Thomas O'Dowd
tpod...@cloudian.commailto:tpod...@cloudian.com wrote:
When I delete an account, I get a notification. Should the same not work
for adding an account? I'm using 4.3.
I've never really played with javascript, jquery or ajax before but just
looking the the code in the debugger I'm wondering if the following is
not a problem. Maybe something obvious that I don't quite understand :-)
In accountsWizard.js
} else {
$.ajax({
url: createURL('createAccount' + array1.join()),
dataType: json,
async: false,
success: function(json) {
var item = json.createaccountresponse.account;
args.response.success({
data: item
});
},
error: function(XMLHttpResponse) {
args.response.error(parseXMLHttpResponse(XMLHttpResponse));
}
});
}
The code calls the function args.response.success() but looking at the
debugger args.response has no success function. It has
args.response.error() though.
In ui-custom/accountsWizard.js
} else {
args.action({
context: context,
data: data,
isLdap: isLdap,
username: username,
response: {
error: function(message) {
if (message) {
cloudStack.dialog.notice({
message: message
});
}
}
}
});
}
It doesn't setup a response.success... Only response.error.
However, I would have expected that the call to the missing function
would cause some kind of javascript error on the console but nothing is
logged.
Tom.
--
Cloudian KK - http://www.cloudian.com/get-started.html
Fancy 10TB of full featured S3 Storage?
Checkout the Cloudian® Community Edition!
RE: old review https://reviews.apache.org/r/16002
Yes, it looks like it indeed is still an issue in some cases. I'll take a look at it. Thanks, Brian -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Monday, May 05, 2014 11:19 AM To: Brian Federle; Jessica Wang Cc: dev Subject: old review https://reviews.apache.org/r/16002 Brian, Jessica, Can you please judge and apply or discard this review request? it is quite old. -- Daan
Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in secondary storage URL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16002/#review42188 --- Ship it! Ship It! - Brian Federle On Dec. 6, 2013, 5:08 p.m., Dariusz Nejbauer wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16002/ --- (Updated Dec. 6, 2013, 5:08 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-3932 https://issues.apache.org/jira/browse/CLOUDSTACK-3932 Repository: cloudstack-git Description --- Wrong layout format in Secondary Storage QuickView: https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg Problem with layout occurs when quick-view displays details field from json data. In table body, row has the same class as the parent div. Diffs - ui/scripts/ui/widgets/detailView.js b0ebaa9b27947f3720e2068471361004bce02f7a Diff: https://reviews.apache.org/r/16002/diff/ Testing --- Tested locally on: 1. DevCloud setup 2. Win 7-Chrome 3. Win 7-Firefox 22.0 4. Win 7-IE9 5. Ubuntu 12.04-Firefox 25.0.1 QuickView after change: https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing Thanks, Dariusz Nejbauer
RE: git commit: updated refs/heads/4.4-forward to 259ce3b
It's a minor but easy fix, so it wouldn't hurt :) Also, can you please cherry pick in 4d84970ddc91c2269807708e722942e9bc758185? This is a fix for a Firefox incompatibility for CLOUDSTACK-6342, where Firefox wasn't rendering the changes correctly (I was just going to make a separate request for that). Thanks Daan. -Brian -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Monday, May 05, 2014 12:23 PM To: dev; Brian Federle Subject: Re: git commit: updated refs/heads/4.4-forward to 259ce3b On Mon, May 5, 2014 at 9:17 PM, bfede...@apache.org wrote: 259ce3b59c6a8633fc77a7eac88fbefd915107e2 so I guessed you'd want it cherry-picked ;) -- Daan
[ACS4.4] Cherry pick for CLOUDSTACK-6483
Please cherry-pick 4.4-forward commits for CLOUDSTACK-6483 (in this order): 0b03609c45ecb5b4525e6a7b5216c70032d94a39 7daabf6515509dc276b968c6ca042cf964a328da 430d14b67608039159403036dae3dc7af1e590f5 Thank you, Brian
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
On April 22, 2014, 5:55 p.m., Brian Federle wrote: Gabor, for the most part the UI is good. However, I did notice the 'provider' fields on 'add VPC offering' are just simple text fields, instead of dropdowns -- is this intentional? Gabor Apati-Nagy wrote: Thanks for reviewing. Yes this is intentional. On that screen, we allow only VpcVirtualRouter for all services except Connectivity that has 3 providers available. Thanks Gabor. The only modification to make then is to add the readonly=readonly attribute to the input box, assuming the user cannot change this value. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41038 --- On April 15, 2014, 10:41 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 15, 2014, 10:41 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties bfa9600 ui/dictionary.jsp f4d380c ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 6494704 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 50e12f9 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41400 --- Ship it! Ship It! - Brian Federle On April 24, 2014, 9:47 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 24, 2014, 9:47 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties 8abe874 ui/dictionary.jsp ebe71b6 ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 0276684 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 82e7fd4 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41038 --- Gabor, for the most part the UI is good. However, I did notice the 'provider' fields on 'add VPC offering' are just simple text fields, instead of dropdowns -- is this intentional? - Brian Federle On April 15, 2014, 10:41 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/ --- (Updated April 15, 2014, 10:41 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6255 https://issues.apache.org/jira/browse/CLOUDSTACK-6255 Repository: cloudstack-git Description --- CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN) (UI for SDN) Diffs - client/WEB-INF/classes/resources/messages.properties bfa9600 ui/dictionary.jsp f4d380c ui/scripts/configuration.js ba6bdce ui/scripts/docs.js df4bcf0 ui/scripts/network.js 6494704 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 50e12f9 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy
RE: Best practice: Do not use innerHtml() property or it's equivalent jQuery .html() method
Yes, though the ASF security team is responsible for committing and reviewing the code, so it probably won't make it in for a while. This is probably a general announcement to other UI devs on the list. From: Stephen Turner Sent: Thursday, April 17, 2014 2:16 AM To: dev@cloudstack.apache.org Cc: Brian Federle Subject: RE: Best practice: Do not use innerHtml() property or it's equivalent jQuery .html() method Brian, didn't you fix most of these already? -- Stephen Turner -Original Message- From: Demetrius Tsitrelis [mailto:demetrius.tsitre...@citrix.com] Sent: 17 April 2014 00:07 To: dev@cloudstack.apache.org Subject: Best practice: Do not use innerHtml() property or it's equivalent jQuery .html() method This property is used to dynamically insert HTML into the UI. Unfortunately, it is easily abused because it accepts input such as SCRIPT tags. There are about 150 instances of the .html() method in our UI. It turns out that in the vast majority of the uses are for text; in those cases the .text() method provides a safe replacement for .html(). For those instances where HTML is needed it is safer to use a sequence of calls to createElement(), appendChild(), and setAttribute() to construct and insert the new element into the DOM.
Re: Review Request 12228: static resource compression
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12228/#review39322 --- Lazlo, I just tested your changes and everything looks good to me. - Brian Federle On March 30, 2014, 8:08 p.m., Laszlo Hornyak wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12228/ --- (Updated March 30, 2014, 8:08 p.m.) Review request for cloudstack, Brian Federle, Darren Shepherd, Jessica Wang, and Prasanna Santhanam. Repository: cloudstack-git Description --- CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB. This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching. Diffs - client/WEB-INF/web.xml 1af38e1 client/pom.xml d8dbde7 server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/12228/diff/ Testing --- yes, tested with firefox and chrome Thanks, Laszlo Hornyak
Re: Review Request 19751: Fixed [CLOUDSTACK-5962]: Value of Global parameter custom.diskoffering.size.min is not reflected in UI during new instance creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19751/#review39178 --- Ship it! Ship It! - Brian Federle On March 28, 2014, 2:45 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19751/ --- (Updated March 28, 2014, 2:45 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-5962 https://issues.apache.org/jira/browse/CLOUDSTACK-5962 Repository: cloudstack-git Description --- Fix for [CLOUDSTACK-5962]: Value of Global parameter custom.diskoffering.size.min is not reflected in UI during new instance creation. Added fields to /api and /server classes for CustomDiskOfferingMinSize to be available in CapabilitiesResponse. Fixed UI code in Instance Wizard to have this config value as the minimum selectable option when we are in custom disk size mode. Diffs - api/src/org/apache/cloudstack/api/ApiConstants.java 87fa8ee api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java d47645b api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c8de587 server/src/com/cloud/server/ManagementServerImpl.java 7431891 ui/index.jsp dce2aa8 ui/scripts/instanceWizard.js 03ee344 ui/scripts/ui-custom/instanceWizard.js c5e0ddb Diff: https://reviews.apache.org/r/19751/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail view fields)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19695/#review38912 --- Ship it! Ship It! - Brian Federle On March 28, 2014, 2:29 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19695/ --- (Updated March 28, 2014, 2:29 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6227 https://issues.apache.org/jira/browse/CLOUDSTACK-6227 Repository: cloudstack-git Description --- CLOUDSTACK-6227 (Add copy-paste support for detail view fields): DetailView widget now supports bool isCopyPaste property that can be set for fields. If this is set to true, the text of this field is displayed using ellipsis formatting* and a copy-paste icon is available right next to it. On clicking this icon, the full text is displayed and auto-selected in scrollable control so the user can use Ctrl-C or can view the original value. *: tooltip is also enabled showing the original non-ellipsed value Diffs - ui/css/cloudstack3.css 9789eda ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b ui/scripts/accounts.js aff780e ui/scripts/ui/widgets/detailView.js 4c5aeea Diff: https://reviews.apache.org/r/19695/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 19722: UI: Fixed truncated icon on confirmation dialog
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19722/#review38817 --- Ship it! Ship It! - Brian Federle On March 27, 2014, 2:03 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19722/ --- (Updated March 27, 2014, 2:03 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Adjusted the position of the icon background for confirm dialogs. Diffs - ui/css/cloudstack3.css f5582b6 Diff: https://reviews.apache.org/r/19722/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail view fields)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19695/#review38824 --- Hey Gabor, for some reason I don't see the icon next to the fields you added isCopyPaste to (api/secret key). I think the diff is missing sprites.png. Can you try creating the patch via git-format-patch -1 your commit id)? I think it may have been an issue because it was a binary file. - Brian Federle On March 26, 2014, 6:47 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19695/ --- (Updated March 26, 2014, 6:47 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-6227 https://issues.apache.org/jira/browse/CLOUDSTACK-6227 Repository: cloudstack-git Description --- CLOUDSTACK-6227 (Add copy-paste support for detail view fields): DetailView widget now supports bool isCopyPaste property that can be set for fields. If this is set to true, the text of this field is displayed using ellipsis formatting* and a copy-paste icon is available right next to it. On clicking this icon, the full text is displayed and auto-selected in scrollable control so the user can use Ctrl-C or can view the original value. *: tooltip is also enabled showing the original non-ellipsed value Diffs - ui/css/cloudstack3.css 4aab13b ui/images/sprites.png ee640476efab85e6ec91fd9b09a0ac179f4d259b ui/scripts/accounts.js aff780e ui/scripts/ui/widgets/detailView.js 4c5aeea Diff: https://reviews.apache.org/r/19695/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Resetting a VM is broken?
the Reset Vm option is presented as a button unlike the icons I think this was because all the other icons we tried to represent this with were too confusing to users — they were clicking on 'reset VM' thinking it was ‘reboot VM’ — then as a last minute fix the decision was to just to show a text label. Any ideas from anyone on what would be a good icon representation? -Brian On Mar 19, 2014, at 3:02 PM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: 1) Didn’t notice “the elephant” - that the Reset Vm option is presented as a button unlike the icons for other options. UI folks - Brian/Jessica- why we decided to represent this option differently in the UI? 2) Mike, I’ve looked at the code and the history. We've always allocated a new volume during the vm restore call. Hari, can you please confirm that this feature you wrote, was designed to work this way -Alena. On 3/19/14, 2:41 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: To clarify: Reboot VM seemed to keep the VM running and just reboot the OS. Reset VM seemed to shut the VM down and then re-start it (with the same root disk for the OS). On Wed, Mar 19, 2014 at 3:40 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I could be wrong, but I thought as recently as 4.3 that Reset VM essentially stopped and then re-started the VM with the same root disk. It seemed to differ from Reboot VM only in the sense that the VM was never technically stopped (the OS inside the VM was just rebooted). On Wed, Mar 19, 2014 at 3:38 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I'm using XenServer 6.1 hosts (two of them) in this case. On Wed, Mar 19, 2014 at 3:37 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Yeah, stopping and restarting works fine...as does, I believe, rebooting the VM. Right below Reboot VM, there is a Reset VM option. If that means re-install, then we probably should clean up the old root disk. On Wed, Mar 19, 2014 at 3:30 PM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: don¹t see ³Reset Vm² option in UI; do you mean ³Reboot instance²? I¹ve just tried that, as well as calling stop/startVM from the UI. The Vm boots up with its original disk. I¹m having Xen/Nfs, not sure it matters -Alena. On 3/19/14, 2:19 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I didn't look into what the GUI calls, but I invoked the Reset VM option in the GUI. Thanks On Wed, Mar 19, 2014 at 3:17 PM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: Mike, just to confirm - did you call stopVirtualMachine/startVirtualMachine apis? -alena. On 3/19/14, 1:55 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Hi, I noticed today while running through some test cases for 4.4 that resetting a VM does not work as expected. Instead of the typical stop and re-start behavior where the VM is booted back up using the same root disk, the VM gets a new root disk when it is booted back up. Can anyone confirm this finding for me with his or her setup? Thanks! -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)*
Re: Review Request 19463: UI: Applied localization function to labels on Zone Chart page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19463/#review37920 --- Ship it! Ship It! - Brian Federle On March 20, 2014, 2:11 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19463/ --- (Updated March 20, 2014, 2:11 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- This fixes the following issue: Some labels on the Zone Chart page display the wrong text, e.g. 'label.view.all' instead of 'View all', 'label.pods' instead of 'Pods'. Diffs - ui/scripts/ui-custom/zoneChart.js bc30d51 Diff: https://reviews.apache.org/r/19463/diff/ Testing --- Yes Thanks, Mihaela Stoica
Re: Resetting a VM is broken?
Those suggestions sound good. Here are the changes I will make in the UI: - Change icon to use a ‘recycle’ symbol, to avoid confusion w/ reboot VM - Rename action(s) to reflect the name of the API calls. - Update the confirm dialog to say, “This action will restore the VM to a fresh root disk. After this action, the current root disk will be attached to the VM.” -Brian On Mar 20, 2014, at 11:46 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I think with the addition of detailed confirmation info that that is a good solution. Thanks! On Thu, Mar 20, 2014 at 12:44 PM, Jessica Wang jessica.w...@citrix.comwrote: And also provide detailed info in confirmation dialog when clicking the icon that fires restoreVirtualMachine API. e.g. This action will restore the VM to a fresh new root disk. After this action, the current root disk wll be destroyed and a new root disk will be attached to the VM. Harikrishna, do you any suggestion for the text in confirmation dialog? -Original Message- From: Jessica Wang [mailto:jessica.w...@citrix.com] Sent: Thursday, March 20, 2014 11:32 AM To: Mike Tutkowski Cc: Brian Federle; Harikrishna Patnala; Alena Prokharchyk; dev@cloudstack.apache.org; Stephen Turner Subject: RE: Resetting a VM is broken? How about we just match text with API name? i. Label the icon that fires recoverVirtualMachine API as Recover. ii. Label the icon that fires restoreVirtualMachine API as Restore. From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Thursday, March 20, 2014 11:29 AM To: Jessica Wang Cc: Brian Federle; Harikrishna Patnala; Alena Prokharchyk; dev@cloudstack.apache.org; Stephen Turner Subject: Re: Resetting a VM is broken? OK, thanks for the history there. What about the text we're using? Are we OK with Reset VM, for example? Thanks! On Thu, Mar 20, 2014 at 12:26 PM, Jessica Wang jessica.w...@citrix.com mailto:jessica.w...@citrix.com wrote: Mike, Right. The history is recoverVirtualMachine API was created several years ago, restoreVirtualMachine didn't exist yet at that time. So, the icon that fires recoverVirtualMachine API was labeled as Restore at that time. restoreVirtualMachine API came along several years later. Then, since label Restore has already taken, the icon that fires restoreVirtualMachine API was therefore labeled as Reset. The result is indeed weird. We'll fix the label to match API name. Jessica From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.commailto: mike.tutkow...@solidfire.com] Sent: Thursday, March 20, 2014 11:03 AM To: Jessica Wang Cc: Brian Federle; Harikrishna Patnala; Alena Prokharchyk; dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org; Stephen Turner Subject: Re: Resetting a VM is broken? Thanks, Jessica The even weirder part, though, is that the text Restore maps to the recoverVirtualMachine API and the text Reset VM maps to the restoreVirtualMachine. On Thu, Mar 20, 2014 at 11:58 AM, Jessica Wang jessica.w...@citrix.com mailto:jessica.w...@citrix.com wrote: [Mike Tutkowski] Unless I'm reading this incorrectly, it looks like label.action.restore.instance (Restore Instance) maps to recoverVirtualMachine and label.resetVM (Reset VM) maps to restoreVirtualMachine Yes, this is confusing. I'll file an UI bug to match icon label with API name. i.e. The icon that fires recoverVirtualMachine API will be labeled as Recover and the icon that fires restoreVirtualMachine API will be labeled as Restore -Original Message- From: Brian Federle Sent: Thursday, March 20, 2014 10:29 AM To: Alena Prokharchyk Cc: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org; Brian Federle; Jessica Wang; Mike Tutkowski; Harikrishna Patnala Subject: Re: Resetting a VM is broken? the Reset Vm option is presented as a button unlike the icons I think this was because all the other icons we tried to represent this with were too confusing to users - they were clicking on 'reset VM' thinking it was 'reboot VM' - then as a last minute fix the decision was to just to show a text label. Any ideas from anyone on what would be a good icon representation? -Brian On Mar 19, 2014, at 3:02 PM, Alena Prokharchyk alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com wrote: 1) Didn't notice the elephant - that the Reset Vm option is presented as a button unlike the icons for other options. UI folks - Brian/Jessica- why we decided to represent this option differently in the UI? 2) Mike, I've looked at the code and the history. We've always allocated a new volume during the vm restore call. Hari, can you please confirm that this feature you wrote, was designed to work this way -Alena. On 3/19/14, 2:41 PM, Mike Tutkowski mike.tutkow...@solidfire.com mailto:mike.tutkow...@solidfire.com wrote: To clarify: Reboot VM seemed to keep the VM running and just reboot the OS
Re: Resetting a VM is broken?
I was just using what was suggested earlier in the thread (I’m not really familiar with the feature); if that is incorrect then I can change it to say, “Warning: this action is irreversible. If you continue you may lose data. Please confirm that you would like to proceed.” -Brian On Mar 20, 2014, at 12:08 PM, Nux! n...@li.nux.ro wrote: On 20.03.2014 18:55, Brian Federle wrote: Those suggestions sound good. Here are the changes I will make in the UI: - Change icon to use a ‘recycle’ symbol, to avoid confusion w/ reboot VM - Rename action(s) to reflect the name of the API calls. - Update the confirm dialog to say, “This action will restore the VM to a fresh root disk. After this action, the current root disk will be attached to the VM.” After this action, the current root disk will be attached to the VM. - What does this mean? To me it sounds like the VM gets re-instantiated from template and the current root disk will be attached as a volume, in addition to a _new_ root disk. This is not what is happening. People need to be aware that this action is irreversible and THEY WILL LOSE DATA, the message should say this. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro
Re: Resetting a VM is broken?
OK, sounds good :) On Mar 20, 2014, at 12:21 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Personally I prefer something more along these lines: This action will restore the VM to a fresh root disk. After this action, the current root disk will be destroyed. On Thu, Mar 20, 2014 at 1:19 PM, Brian Federle brian.fede...@citrix.comwrote: I was just using what was suggested earlier in the thread (I'm not really familiar with the feature); if that is incorrect then I can change it to say, Warning: this action is irreversible. If you continue you may lose data. Please confirm that you would like to proceed. -Brian On Mar 20, 2014, at 12:08 PM, Nux! n...@li.nux.ro wrote: On 20.03.2014 18:55, Brian Federle wrote: Those suggestions sound good. Here are the changes I will make in the UI: - Change icon to use a 'recycle' symbol, to avoid confusion w/ reboot VM - Rename action(s) to reflect the name of the API calls. - Update the confirm dialog to say, This action will restore the VM to a fresh root disk. After this action, the current root disk will be attached to the VM. After this action, the current root disk will be attached to the VM. - What does this mean? To me it sounds like the VM gets re-instantiated from template and the current root disk will be attached as a volume, in addition to a _new_ root disk. This is not what is happening. People need to be aware that this action is irreversible and THEY WILL LOSE DATA, the message should say this. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)*
Re: Review Request 19037: Corrected the value of label.no.grouping in the resource files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19037/#review36824 --- Ship it! Ship It! - Brian Federle On March 11, 2014, 2:52 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19037/ --- (Updated March 11, 2014, 2:52 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Corrected the value of label.no.grouping in the resource files. An extra backspace at the end of the string caused incorrect text to be shown in the Select view dropdown on Virtual Routers page: (no grouping)\label.create.nfs.secondary.staging.storage=Create NFS Secondary Staging Store instead of (no grouping) Diffs - client/WEB-INF/classes/resources/messages.properties cb4d292 client/WEB-INF/classes/resources/messages_ja_JP.properties da4851a client/WEB-INF/classes/resources/messages_zh_CN.properties bb3e50c Diff: https://reviews.apache.org/r/19037/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 18194: G11N: Fixed the Hardcoding Issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18194/#review36277 --- Ship it! Ship It! - Brian Federle On March 5, 2014, 9:01 a.m., Vetrivel Chinnasamy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18194/ --- (Updated March 5, 2014, 9:01 a.m.) Review request for cloudstack and Brian Federle. Repository: cloudstack-git Description --- Externalized the hard coded strings by adding reference ID and label to the resource files. Also updated the dictionary.jsp file. Diffs - client/WEB-INF/classes/resources/messages.properties 82ac499 client/WEB-INF/classes/resources/messages_ja_JP.properties 828cf54 client/WEB-INF/classes/resources/messages_zh_CN.properties f4c206b tools/ngui/static/js/app/accounts/accounts.js eae5070 tools/ngui/static/js/app/storage/storage.js e562a95 ui/dictionary.jsp 11dbeb5 ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js d618b23 ui/scripts/configuration.js 869b876 ui/scripts/installWizard.js 25de4aa ui/scripts/instances.js 53c9e98 ui/scripts/network.js 6ce66e8 ui/scripts/sharedFunctions.js f0afea5 ui/scripts/storage.js 1cd8d2e ui/scripts/system.js c21e277 ui/scripts/templates.js 3551613 ui/scripts/ui-custom/zoneChart.js e847a19 ui/scripts/ui/core.js 06be12b ui/scripts/ui/widgets/tagger.js 673bd43 ui/scripts/vpc.js 770ee9b ui/scripts/zoneWizard.js 1de3646 Diff: https://reviews.apache.org/r/18194/diff/ Testing --- Local unit testing done by replacing the java-script, dictionary.jsp and properties files. Thanks, Vetrivel Chinnasamy
Re: Review Request 18689: CS-19420: [UI] Fixed invalid field name (label.dynamically.scalable) on instance details.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18689/#review35989 --- Ship it! Ship It! - Brian Federle On March 3, 2014, 4:27 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18689/ --- (Updated March 3, 2014, 4:27 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- CS-19420: [UI] Fixed invalid field name (label.dynamically.scalable) on instance details. Diffs - ui/dictionary.jsp bf48417 Diff: https://reviews.apache.org/r/18689/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 18689: CS-19420: [UI] Fixed invalid field name (label.dynamically.scalable) on instance details.
On March 3, 2014, 6:07 p.m., Brian Federle wrote: Ship It! Also, note for next time: 'CS-19420' is an invalid bug ID. Please provide a bug that was created in the Apache JIRA. I created one for this and will ref the ID in the commit. Thanks. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18689/#review35989 --- On March 3, 2014, 4:27 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18689/ --- (Updated March 3, 2014, 4:27 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- CS-19420: [UI] Fixed invalid field name (label.dynamically.scalable) on instance details. Diffs - ui/dictionary.jsp bf48417 Diff: https://reviews.apache.org/r/18689/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 18695: Fix for CLOUDSTACK-4563: Initial zone wizard UI label issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18695/#review35993 --- Ship it! Ship It! - Brian Federle On March 3, 2014, 4:44 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18695/ --- (Updated March 3, 2014, 4:44 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- This patch fixes CLOUDSTACK-4563, so that the 'Provider' label will use localized text instead of wired-in 'Provider' text. Diffs - client/WEB-INF/classes/resources/messages.properties f1c166b ui/dictionary.jsp 16ecbab ui/scripts/zoneWizard.js 13630c1 Diff: https://reviews.apache.org/r/18695/diff/ Testing --- Thanks, Gabor Apati-Nagy
Re: Review Request 18432: Fixed some resource files issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18432/#review35476 --- Ship it! Ship It! - Brian Federle On Feb. 24, 2014, 5:47 p.m., Konstantina Chremmou wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18432/ --- (Updated Feb. 24, 2014, 5:47 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Fixed some resource files issues, namely 1) invalid text and duplicate keys resulting from bad merge and 2) trailing spaces which can potentially cause UI issues. Diffs - client/WEB-INF/classes/resources/messages.properties bd4a27d client/WEB-INF/classes/resources/messages_es.properties 31a9c93 client/WEB-INF/classes/resources/messages_ja_JP.properties 7dd5bd1 client/WEB-INF/classes/resources/messages_nl_NL.properties b1bfadb client/WEB-INF/classes/resources/messages_pl.properties 9024030 client/WEB-INF/classes/resources/messages_pt_BR.properties 07fd3f4 client/WEB-INF/classes/resources/messages_zh_CN.properties 88b13a1 Diff: https://reviews.apache.org/r/18432/diff/ Testing --- Thanks, Konstantina Chremmou
Re: Review Request 17541: Externalized the hard coded strings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17541/#review34496 --- Ship it! Ship It! - Brian Federle On Feb. 11, 2014, 8:29 a.m., Vetrivel Chinnasamy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17541/ --- (Updated Feb. 11, 2014, 8:29 a.m.) Review request for cloudstack and Brian Federle. Repository: cloudstack-git Description --- Externalized hard coded strings Diffs - client/WEB-INF/classes/resources/messages.properties f1c166b client/WEB-INF/classes/resources/messages_ja_JP.properties 4232449 client/WEB-INF/classes/resources/messages_zh_CN.properties 7cb65d3 ui/dictionary.jsp 16ecbab ui/lib/jquery.validate.js 72296a6 ui/scripts/accounts.js a15cc87 ui/scripts/autoscaler.js ab1b459 ui/scripts/domains.js 5d8fd68 ui/scripts/installWizard.js dbea34e ui/scripts/instances.js 3b1931b ui/scripts/regions.js ac573b7 ui/scripts/system.js 11dd0ba ui/scripts/templates.js 8c63ce2 Diff: https://reviews.apache.org/r/17541/diff/ Testing --- Local unit testing done by replacing the javascript, dictionary.jsp and properties files. Thanks, Vetrivel Chinnasamy
RE: UI blocker
Sorry, but cosmetic issues are not blockers :) It would only be a blockers if the functionality were NOT usable in any shape or form, for both testing and end use. i.e. -- if the fields were completely missing or garbled in some way, I would agree that we can classify the bug as blocking release. Looking 'ugly', no -- I implemented the scrollbars because most times API keys, etc. are usually very long strings, causing overflow on some browsers and in most usability cases people are mainly needing to just copy/paste the values into other fields. It's not the most elegant solution I understand, but this is also a small facet of the whole UI experience. I am going to ask everyone to PLEASE respect this when determining priority on UI bugs -- I know things like this are somewhat ugly, but there are only a small handful of full-time UI developers working on CloudStack and it makes our lives harder if everyone is marking trivial stuff as show-stoppers. At any rate, if you still think this is a blocker, you can feel free to look into it yourself, in which case write a review request and I'll take a look at it. -Brian -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 11:56 AM To: Brian Federle Cc: dev@cloudstack.apache.org; Jessica Wang Subject: Re: UI blocker On Jan 16, 2014, at 2:48 PM, Brian Federle brian.fede...@citrix.com wrote: Did you happen to check the View Users page ? the api/secret keys display is being truncated. Yes, though to fix that I'll have to rework a bit of the detail view layout to allow more flexible sizing for long strings. File that as a separate bug for the next release and I'll take a look at it. No, I will keep that as a blocker. it's worse than the previous UI, feel free to comment in the bug and grab it. -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 11:17 AM To: Brian Federle Cc: dev@cloudstack.apache.org; Jessica Wang Subject: Re: UI blocker On Jan 16, 2014, at 1:39 PM, Brian Federle brian.fede...@citrix.com wrote: Don't see any issues in the screenshot you posted. The variation in font size and weight, color, etc. are used to show contrast between content and titles. Sorry but I do not see this as a blocker issue :) Though feel free to tweak the fonts yourself. It looks strange to me, maybe that's just me. I see too many variations and it's disturbing. Did you happen to check the View Users page ? the api/secret keys display is being truncated. -Brian -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 1:43 AM To: dev@cloudstack.apache.org Cc: Jessica Wang; Brian Federle Subject: UI blocker Hi, after testing 4.3 I entered a blocker due to UI issues: https://issues.apache.org/jira/browse/CLOUDSTACK-5882 It would be good to discuss, thanks, -Sebastien
RE: UI blocker
OK, I'm dropping this subject after this, but one more thing -- the new UI has been up for months now. There was plenty of time to make feedback and improve the UI. I don't appreciate the fact that these issues are being mentioned so late into release, when there isn't much we can do about it. Also, we are working on other deliverables for future releases, so the fact that our bug count is low for 4.3 doesn't mean we aren't doing any work :) -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Friday, January 17, 2014 11:53 AM To: dev@cloudstack.apache.org; Brian Federle Cc: Jessica Wang; Sonny Chhen Subject: Re: UI blocker On Jan 17, 2014, at 1:41 PM, Brian Federle brian.fede...@citrix.com wrote: Sorry, but cosmetic issues are not blockers :) It would only be a blockers if the functionality were NOT usable in any shape or form, for both testing and end use. I disagree, cosmetics i.e look and feel of a new major revision of a software are as important as critical backend features. Because users will look at it, managers, execs...etc, it will be displayed in demos, printed on booths etcanything that does not look top notch reflects badly on the project and the software. i.e. -- if the fields were completely missing or garbled in some way, I would agree that we can classify the bug as blocking release. Looking 'ugly', no -- I implemented the scrollbars because most times API keys, etc. are usually very long strings, causing overflow on some browsers and in most usability cases people are mainly needing to just copy/paste the values into other fields. It's not the most elegant solution I understand, but this is also a small facet of the whole UI experience. Attention to details is important. Personally the new UI is distracting to me, the variation in fonts/font sizes is distracting instead of putting emphasis and focus. There are other things, like 'ovm' still showing up in the add cluster drop down when OVM is not supported in CloudStack, but you are right it's a detail who cares. I am going to ask everyone to PLEASE respect this when determining priority on UI bugs -- I know things like this are somewhat ugly, but there are only a small handful of full-time UI developers working on CloudStack and it makes our lives harder if everyone is marking trivial stuff as show-stoppers. This is great, so it can look like crap, as long as it works we release on the first iteration of a major revision. In any case you can remove this as a blocker, it seems I am in minority here, at least I got you to respond on the list and share your thoughts on the subject. As a parting thought though, I don't think that 'everyone is making trivial stuff as show-stoppers', I did not hear many UI blocker bugs lately At any rate, if you still think this is a blocker, you can feel free to look into it yourself, in which case write a review request and I'll take a look at it. -Brian -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 11:56 AM To: Brian Federle Cc: dev@cloudstack.apache.org; Jessica Wang Subject: Re: UI blocker On Jan 16, 2014, at 2:48 PM, Brian Federle brian.fede...@citrix.com wrote: Did you happen to check the View Users page ? the api/secret keys display is being truncated. Yes, though to fix that I'll have to rework a bit of the detail view layout to allow more flexible sizing for long strings. File that as a separate bug for the next release and I'll take a look at it. No, I will keep that as a blocker. it's worse than the previous UI, feel free to comment in the bug and grab it. -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 11:17 AM To: Brian Federle Cc: dev@cloudstack.apache.org; Jessica Wang Subject: Re: UI blocker On Jan 16, 2014, at 1:39 PM, Brian Federle brian.fede...@citrix.com wrote: Don't see any issues in the screenshot you posted. The variation in font size and weight, color, etc. are used to show contrast between content and titles. Sorry but I do not see this as a blocker issue :) Though feel free to tweak the fonts yourself. It looks strange to me, maybe that's just me. I see too many variations and it's disturbing. Did you happen to check the View Users page ? the api/secret keys display is being truncated. -Brian -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 1:43 AM To: dev@cloudstack.apache.org Cc: Jessica Wang; Brian Federle Subject: UI blocker Hi, after testing 4.3 I entered a blocker due to UI issues: https://issues.apache.org/jira/browse/CLOUDSTACK-5882 It would be good to discuss, thanks, -Sebastien
RE: UI blocker
Don't see any issues in the screenshot you posted. The variation in font size and weight, color, etc. are used to show contrast between content and titles. Sorry but I do not see this as a blocker issue :) Though feel free to tweak the fonts yourself. -Brian -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 1:43 AM To: dev@cloudstack.apache.org Cc: Jessica Wang; Brian Federle Subject: UI blocker Hi, after testing 4.3 I entered a blocker due to UI issues: https://issues.apache.org/jira/browse/CLOUDSTACK-5882 It would be good to discuss, thanks, -Sebastien
RE: UI blocker
Did you happen to check the View Users page ? the api/secret keys display is being truncated. Yes, though to fix that I'll have to rework a bit of the detail view layout to allow more flexible sizing for long strings. File that as a separate bug for the next release and I'll take a look at it. -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 11:17 AM To: Brian Federle Cc: dev@cloudstack.apache.org; Jessica Wang Subject: Re: UI blocker On Jan 16, 2014, at 1:39 PM, Brian Federle brian.fede...@citrix.com wrote: Don't see any issues in the screenshot you posted. The variation in font size and weight, color, etc. are used to show contrast between content and titles. Sorry but I do not see this as a blocker issue :) Though feel free to tweak the fonts yourself. It looks strange to me, maybe that's just me. I see too many variations and it's disturbing. Did you happen to check the View Users page ? the api/secret keys display is being truncated. -Brian -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 1:43 AM To: dev@cloudstack.apache.org Cc: Jessica Wang; Brian Federle Subject: UI blocker Hi, after testing 4.3 I entered a blocker due to UI issues: https://issues.apache.org/jira/browse/CLOUDSTACK-5882 It would be good to discuss, thanks, -Sebastien
RE: Committer license for IntelliJ set to expire
I'm using the committer license. -Brian -Original Message- From: Chip Childers [mailto:chipchild...@apache.org] Sent: Tuesday, January 07, 2014 7:18 AM To: dev@cloudstack.apache.org Subject: Committer license for IntelliJ set to expire Hey folks, The free license we have for IntelliJ for committers is set to expire in Feb. I've been in contact with them, and can request a new license when it gets closer to that time. For those of you (committers) using the license, please reply to this so that I can get you the renewed license off list when the time comes. -chip
Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16044/#review29910 --- Ship it! Ship It! - Brian Federle On Dec. 5, 2013, 9:28 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16044/ --- (Updated Dec. 5, 2013, 9:28 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Volume Snapshot UI does not provide option of adding quiesce vm parameter when the underlying storage does support the option. Diffs - ui/scripts/storage.js 4875662 Diff: https://reviews.apache.org/r/16044/diff/ Testing --- Thanks, Chris Suich
Re: Review Request 16041: CLOUDSTACK-5384 UI dataProviders are unable to differentiate between load and refresh context
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16041/#review29825 --- Ship it! Ship It! - Brian Federle On Dec. 5, 2013, 6:44 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16041/ --- (Updated Dec. 5, 2013, 6:44 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Added load vs refresh context/indicator for dataProviders for CLOUDSTACK-5384 Diffs - ui/scripts/ui/widgets/detailView.js 3a3cd79 Diff: https://reviews.apache.org/r/16041/diff/ Testing --- Thanks, Chris Suich
Re: Review Request 16001: ListViews marked with 'needsRefresh' do not have loading overlay removed on error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16001/#review29737 --- Ship it! Ship It! - Brian Federle On Dec. 4, 2013, 3:11 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16001/ --- (Updated Dec. 4, 2013, 3:11 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- ListView actions marked with 'needsRefresh' add a loading overlay before the action is performed. If the operation succeeds, the overlay is properly removed. If it fails, the overlay is NOT removed. I fixed this issue by adding the appropriate JS to remove the overlay when an error occurs during the operation. This is for JIRA-5368. If accepted, please apply to 4.3 branch as well. Diffs - ui/scripts/ui/widgets/listView.js 53b37f1 Diff: https://reviews.apache.org/r/16001/diff/ Testing --- Thanks, Chris Suich
Re: Review Request 15362: Fixed issue with detail view fields marked as 'isPassword' not being obfuscated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15362/#review28893 --- Ship it! Ship It! - Brian Federle On Nov. 8, 2013, 8:33 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15362/ --- (Updated Nov. 8, 2013, 8:33 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Form fields marked with 'isPassword' are created as input fields with type 'password' so that the value is obfuscated. However, detail view fields (when editing) are not obfuscated. Additionally, if a value is entered and the edit form is submitted, the password is still visible in plain text. This patch fixes the issue by respecting the 'isPassword' attribute on detail view fields. Diffs - ui/scripts/ui/widgets/detailView.js 65f71b3 Diff: https://reviews.apache.org/r/15362/diff/ Testing --- Thanks, Chris Suich
RE: ui styling
Hi Frankie, unfortunately that would be hard to do, since they were just incremental changes applied on master. I would have to cherry pick all the commits I did over time, which would take a while :). What you can try is copying the updated CSS files (/css), images (/images) and all scripts under ui/widgets to your local build (in the same respective folders). Note that this would contain some work-in-progress UI functionality for 4.3 that may or may not be working. -Brian -Original Message- From: Frankie Onuonga [mailto:frankie.onuo...@gmail.com] Sent: Tuesday, October 29, 2013 10:11 PM To: dev@cloudstack.apache.org Subject: Re: ui styling I also wish this was the case. I am still trying to get in touch with the team to assist them with this. Hope someone gets back to me. I think I can commit a week to get this done. thanks On Wed, Oct 30, 2013 at 4:35 AM, Marcus Sorensen shadow...@gmail.comwrote: I'm digging the UI styling changes! It makes me wish they were all merged in from a branch as a squashed commit so I could pull them out and apply them to our local 4.2 build. -- Skype: Frankie Onuonga twitter: Frankie.onuonga irc #freenode: Frankie.onuonga
RE: Little GUI Issue
Hey Mike, for some reason I can't reproduce w/ the latest master, but I have noticed that in the past, if you accidentally double click on an item. Is that happening here, where repeated clicking is causing the overlay to load a bunch of times? Also, what browser did you reproduce on? -Brian From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Monday, October 28, 2013 1:29 PM To: Brian Federle; dev@cloudstack.apache.org Subject: Little GUI Issue Hey Brian, I could log a JIRA ticket for this, if you'd like, but I believe I had logged one a while ago and it was fixed (and is now broken again). The problem is the semi-transparent background when a dialog is displayed can get darker and darker if certain actions are taken. Here's a simple example: Click on the Notifications button at the top of the GUI a few times. The background gets darker and darker. I think the new visuals of the GUI are looking really good, though! Talk to you later, Mike -- Mike Tutkowski Senior CloudStack Developer, SolidFire Inc. e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play(tm)
Re: Review Request 14782: [CLOUDSTACK-4910] Take VM snapshot instantly returns success regardless of actual result
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14782/#review27252 --- Ship it! Ship It! - Brian Federle On Oct. 21, 2013, 3:27 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14782/ --- (Updated Oct. 21, 2013, 3:27 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Fixed a typo causing vm snapshot requests to always instantly return successful in the CloudStack UI. Diffs - ui/scripts/instances.js 41d1772 Diff: https://reviews.apache.org/r/14782/diff/ Testing --- Thanks, Chris Suich
RE: UI accounts wizard broken
Your code snippet looks correct. I just tested the issue today, and the password confirm is working again. Can you double-check if it works on your setup (on the latest master)? If so, I’ll assume it’s fixed. Thanks, Brian From: Ian Duffy [mailto:i...@ianduffy.ie] Sent: Saturday, October 12, 2013 5:25 AM To: Brian Federle Cc: Jessica Wang; Abhinandan Prateek; Pranav Saxena; dev@cloudstack.apache.org; Animesh Chaturvedi; Sonny Chhen Subject: Re: UI accounts wizard broken Generally, I'm thinking writing in a custom widget should only be for if a special layout or visual flow is needed -- i.e., like a dashboard or wizard with a unique layout, so moving forward if the standard process needs more checks or conditionals, we can first see if the UI toolkit can be expanded easily to support it. That sounds like a much nicer/cleaner solution. I'll file a bug for the password confirm not working... Is there a reason why the following snippet of code doesn't provide equality between the two password fields? https://gist.github.com/imduffy15/6949448 On 11 October 2013 18:21, Brian Federle brian.fede...@citrix.commailto:brian.fede...@citrix.com wrote: No worries, I must have missed the original discussion. Probably an easier way would be to add support for passing a closure to the createForm: and/or add: action block, so you can conditionally check context and return the appropriate form. We can modify the account form to use this in the future, but for now as long as the dialog works then it is OK, I was able to hack around the styling issues. Generally, I'm thinking writing in a custom widget should only be for if a special layout or visual flow is needed -- i.e., like a dashboard or wizard with a unique layout, so moving forward if the standard process needs more checks or conditionals, we can first see if the UI toolkit can be expanded easily to support it. I'll file a bug for the password confirm not working... Thanks, Brian From: Ian Duffy [i...@ianduffy.iemailto:i...@ianduffy.ie] Sent: Thursday, October 10, 2013 7:23 PM To: Jessica Wang; Abhinandan Prateek; Pranav Saxena Cc: Brian Federle; dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org; Animesh Chaturvedi; Sonny Chhen Subject: Re: UI accounts wizard broken Hi Brian, I noticed that the 'add account' dialog was changed substantially, and converted to a custom UI widget. Additionally, the password confirm field validation is broken, so I am unable to add a new account The change was made in order to allow the wizard to change to include a list of users grabbed from LDAP when LDAP is enabled. This was done in order to aid ease of user provisioning. The change was discussed some time ago on the mailing list: Switch dialog actions based on result from API call. - http://markmail.org/thread/ebtm2iqzvz3sm3ne UI Query: Create Form - http://markmail.org/thread/kcngmhlgxeukvscb Based on the replies from Jessica and Pranav the only way to go about implementing this was via the custom widget. This doesn't seem to really need something custom from the looks of it Is there a way we can use createForm and still implement the custom dialog ( http://ianduffy.ie/cloudstack/screen1.png ) when Ldap is enabled? Very sorry about this! Wasn't aware such issue was present. Thanks, Ian On 10 October 2013 21:03, Jessica Wang jessica.w...@citrix.commailto:jessica.w...@citrix.com wrote: +1 -Original Message- From: Brian Federle Sent: Thursday, October 10, 2013 12:55 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Cc: Animesh Chaturvedi; Jessica Wang; Sonny Chhen Subject: RE: UI accounts wizard broken Also, I am referring to this commit. I do not remember any active UI comitters including myself receiving a review request for this... commit eaa41433715ba1a1137ad9f346ea8569e31e4560 Author: Ian Duffy i...@ianduffy.iemailto:i...@ianduffy.ie Date: Thu Jul 25 10:24:13 2013 +0100 Merge LDAPPlugin Signed-off-by: Abhinandan Prateek aprat...@apache.orgmailto:aprat...@apache.org -Original Message- From: Brian Federle [mailto:brian.fede...@citrix.commailto:brian.fede...@citrix.com] Sent: Thursday, October 10, 2013 12:46 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Cc: Animesh Chaturvedi; Jessica Wang; Sonny Chhen Subject: UI accounts wizard broken After reviewing the UI on the latest master, I noticed that the 'add account' dialog was changed substantially, and converted to a custom UI widget. Additionally, the password confirm field validation is broken, so I am unable to add a new account. Can I know the reason this was converted to a custom widget, instead of using the standard createForm? This doesn't seem to really need something custom from the looks of it. I am mainly concerned since it is causing validation bugs as well as some display glitches, which could be avoided by using
RE: UI accounts wizard broken
No worries, I must have missed the original discussion. Probably an easier way would be to add support for passing a closure to the createForm: and/or add: action block, so you can conditionally check context and return the appropriate form. We can modify the account form to use this in the future, but for now as long as the dialog works then it is OK, I was able to hack around the styling issues. Generally, I'm thinking writing in a custom widget should only be for if a special layout or visual flow is needed -- i.e., like a dashboard or wizard with a unique layout, so moving forward if the standard process needs more checks or conditionals, we can first see if the UI toolkit can be expanded easily to support it. I'll file a bug for the password confirm not working... Thanks, Brian From: Ian Duffy [i...@ianduffy.ie] Sent: Thursday, October 10, 2013 7:23 PM To: Jessica Wang; Abhinandan Prateek; Pranav Saxena Cc: Brian Federle; dev@cloudstack.apache.org; Animesh Chaturvedi; Sonny Chhen Subject: Re: UI accounts wizard broken Hi Brian, I noticed that the 'add account' dialog was changed substantially, and converted to a custom UI widget. Additionally, the password confirm field validation is broken, so I am unable to add a new account The change was made in order to allow the wizard to change to include a list of users grabbed from LDAP when LDAP is enabled. This was done in order to aid ease of user provisioning. The change was discussed some time ago on the mailing list: Switch dialog actions based on result from API call. - http://markmail.org/thread/ebtm2iqzvz3sm3ne UI Query: Create Form - http://markmail.org/thread/kcngmhlgxeukvscb Based on the replies from Jessica and Pranav the only way to go about implementing this was via the custom widget. This doesn't seem to really need something custom from the looks of it Is there a way we can use createForm and still implement the custom dialog ( http://ianduffy.ie/cloudstack/screen1.png ) when Ldap is enabled? Very sorry about this! Wasn't aware such issue was present. Thanks, Ian On 10 October 2013 21:03, Jessica Wang jessica.w...@citrix.com wrote: +1 -Original Message- From: Brian Federle Sent: Thursday, October 10, 2013 12:55 PM To: dev@cloudstack.apache.org Cc: Animesh Chaturvedi; Jessica Wang; Sonny Chhen Subject: RE: UI accounts wizard broken Also, I am referring to this commit. I do not remember any active UI comitters including myself receiving a review request for this... commit eaa41433715ba1a1137ad9f346ea8569e31e4560 Author: Ian Duffy i...@ianduffy.ie Date: Thu Jul 25 10:24:13 2013 +0100 Merge LDAPPlugin Signed-off-by: Abhinandan Prateek aprat...@apache.org -Original Message- From: Brian Federle [mailto:brian.fede...@citrix.com] Sent: Thursday, October 10, 2013 12:46 PM To: dev@cloudstack.apache.org Cc: Animesh Chaturvedi; Jessica Wang; Sonny Chhen Subject: UI accounts wizard broken After reviewing the UI on the latest master, I noticed that the 'add account' dialog was changed substantially, and converted to a custom UI widget. Additionally, the password confirm field validation is broken, so I am unable to add a new account. Can I know the reason this was converted to a custom widget, instead of using the standard createForm? This doesn't seem to really need something custom from the looks of it. I am mainly concerned since it is causing validation bugs as well as some display glitches, which could be avoided by using the standard widget toolkit. Thanks, Brian
UI accounts wizard broken
After reviewing the UI on the latest master, I noticed that the 'add account' dialog was changed substantially, and converted to a custom UI widget. Additionally, the password confirm field validation is broken, so I am unable to add a new account. Can I know the reason this was converted to a custom widget, instead of using the standard createForm? This doesn't seem to really need something custom from the looks of it. I am mainly concerned since it is causing validation bugs as well as some display glitches, which could be avoided by using the standard widget toolkit. Thanks, Brian
Re: Review Request 12228: wip: static resource compression
On Oct. 4, 2013, 6:52 p.m., Darren Shepherd wrote: I would prefer not to do this. From a technical perspective the code uses getRealPath and Files which are not compatible across all serlvet containers and this implementation forces a lot of file system stat() calls, but that isn't my real complaint. This change adds yet another step to the already long ACS build and I don't think it address the root issue. The root issue, if one was to really care about performance is that the js is not cachable or consolidated. ts=$now is added to every js file, meaning it must be downloaded every time. Additionally to load the login screen there are 66 requests for JS files. Even if you compress 2mb to 800k, on a slow connection it won't matter that much because you are going to get killed regardless by the round trip latency of making 66 requests. Laszlo Hornyak wrote: Hi Darren, I share your concerns about the build process and I do not want to further increase that. What I had in my mind is an optional step (possibly in a profile) acivated only for making releases and by default not in a developement environment. Not that much to save 2 mb of bandwidth, but to save the time the user have to wait. The difficulties with the non cacheable js files is indeed a problem, and I believe that should be addressed separately. (I do not quite understand yet what is that for) Also, the dynamic informations can be compressed if it makes sense, e.g. over a given size. I added the wip prefix to this to make it clear that this patch is preview version and more discussion is needed. re: caching of JS files, I believe the reason ts=$now is appended to the JS files was because of issues during upgrade testing, where the old JS files would not be cleared from the browser cache. If we can consolidate into 1 JS file then we don't need that functionality anymore, as it was more a problem due to the large # of scripts being loaded at once. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12228/#review26690 --- On Oct. 4, 2013, 8:19 p.m., Laszlo Hornyak wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12228/ --- (Updated Oct. 4, 2013, 8:19 p.m.) Review request for cloudstack, Brian Federle and Prasanna Santhanam. Repository: cloudstack-git Description --- CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB. This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching. Diffs - client/WEB-INF/web.xml e5c05d3 client/pom.xml 119c96e server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/12228/diff/ Testing --- Thanks, Laszlo Hornyak
RE: [DISCUSS] UI: New look and feel
Yeah, I am definitely planning on JS cleanup, though not for 4.3. That will be a much more complex project, and needs to be a more iterative refactor since we have innumerable lines of complex business logic to take account for in there. I've been learning about AngularJS as well, and it would definitely solve a lot of problems in the architecture. I wish a library like that existed 2 1/2 years ago when I started writing the UI :) For JS cleanup, I'm thinking of it in this order right now: 1.) Add unit tests for existing widget functionality 2.) Add full documentation for UI 'API' (i.e., all options supported for widget). This is to cater to both plugin writers and CloudStack UI devs 3.) Start refactoring widget code (in /ui/scripts/ui/widgets). Ideally I would like to use AngularJS for this, but it depends on how well it will integrate with our existing jQuery-based interface. It seems flexible enough, though I'll need to get much more adept at the library than I am right now. 4.) Refactor implementation code in /ui/scripts. This wouldn't be migrated to AngluarJS nor be rewritten since there is simply too much code, but a good start would be reducing redundancy by centralizing common API calls into reusable libraries, etc. -Brian From: Ian Duffy [i...@ianduffy.ie] Sent: Thursday, September 26, 2013 8:58 PM To: CloudStack Dev Cc: Sonny Chhen; Animesh Chaturvedi; Jessica Wang Subject: Re: [DISCUSS] UI: New look and feel Looks good. Moving away from design and more into front-end functionality. Is there any talks about cleaning up the javascript behind the UI? I recall it being messy and hard to follow from what I recall of looking at it. The idea single page app with no URL defining a view and a broken browser back button is quite annoying. I think so implementation of AngularJS like the way Shiva did it for his GSoC project would be good. On 27 September 2013 02:09, Chip Childers chip.child...@sungard.com wrote: Looks great Brian! One request actually. I'm working on a proposed cloudstack.apache.org site redesign right now, and I'd actually love to get the relevant CSS you used for the header area (faded blue). It might be nice to have some relationship between the cs.a.o branding and the product itself. ;-) (watch the marketing list for my site redesign proposal shortly) On Thu, Sep 26, 2013 at 10:11:07PM +, Brian Federle wrote: Hi all, In addition to the CSS code cleanup I'm working on, I am planning a 'reskin' of the current UI to give a better user experience and look and feel. This will utilize SASS and a grid system as I have discussed in the previous thread. I created a task in JIRA and wiki functional spec, which has screenshots of what I've done so far and what I plan to do: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Update+UI+visual+appearance https://issues.apache.org/jira/browse/CLOUDSTACK-4748 You can also checkout the ui-restyle branch on git, if you are able to manually compile the cloudstack.scss file via SASS (that will be automated in the future). I can send over instructions on how to compile SASS manually; it's pretty easy to setup. Let me know what you think so far :) I'll of course up and post more screenshots as I get more done. This reskin is only changing the CSS mainly, with minimal changes to actual usage or JS code, so it is basically a drop-in replacement for the current styling. I'm hoping to get this in by 4.3, so please give me feedback on anything from the current UI you don't like or want changed, and I can see about improving it. Thanks! Brian
RE: [DISCUSS] UI: New look and feel
Right now the plan was to remove the icons, though if people think that they are important to usability then we can definitely put them back in. I'm thinking flat icons though, which would look better with the new design. I'll play around with it and maybe post a screenshot with icons included. The action icons on the detail pages will still be there, and of course if plugins supply their own icons they will be displayed. -Brian From: SuichII, Christopher [chris.su...@netapp.com] Sent: Friday, September 27, 2013 5:14 AM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] UI: New look and feel Brian - The new style looks great, but I'd like to repeat someone else's question: Are we getting rid of the icons on the nav bar? As a plugin dev, it would be really nice to keep our company logo by our UI plugin. Shiva Sebastien - What impact would this angular.js project have on UI plugins? -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Cloud Solutions Citrix, Cisco Red Hat On Sep 27, 2013, at 2:44 AM, sebgoa run...@gmail.com wrote: On Sep 27, 2013, at 6:52 AM, Shiva Teja shivate...@gmail.com wrote: On Fri, Sep 27, 2013 at 9:28 AM, Ian Duffy i...@ianduffy.ie wrote: I think so implementation of AngularJS like the way Shiva did it for his GSoC project would be good. I'm trying to setup a demo for my project. This should give an idea about the code. https://github.com/shivateja/cloudstack-ui/blob/angular-rawapi/static/js/common/resources/virtualmachines.js https://github.com/shivateja/cloudstack-ui/blob/angular-rawapi/static/js/app/instances/instances.js https://github.com/shivateja/cloudstack-ui/blob/angular-rawapi/static/js/app/instances/instances.tpl.html Thanks, Shiva Teja Thanks Shiva, I was going to mention it. Shiva has worked on an angular.js app for a cloudstack frontend. All the code has been contributed in tools/ngui This could easily be used with Brian new CSS and it would clean up all the javascript. -Sebastien
RE: [DISCUSS] UI: New look and feel
I can definitely look into that...and it wouldn't require Photoshopping a large sprite sheet, so much easier for maintenance :) -Brian From: Tracy Phillips [tracp...@mantoso.com] Sent: Friday, September 27, 2013 11:01 AM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] UI: New look and feel If you could use font icons, that would be really nice.. (MIT License) http://fortawesome.github.io/Font-Awesome/icons/ (Apache License) http://getbootstrap.com/components/#glyphicons On Fri, Sep 27, 2013 at 1:53 PM, Brian Federle brian.fede...@citrix.comwrote: Right now the plan was to remove the icons, though if people think that they are important to usability then we can definitely put them back in. I'm thinking flat icons though, which would look better with the new design. I'll play around with it and maybe post a screenshot with icons included. The action icons on the detail pages will still be there, and of course if plugins supply their own icons they will be displayed. -Brian From: SuichII, Christopher [chris.su...@netapp.com] Sent: Friday, September 27, 2013 5:14 AM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] UI: New look and feel Brian - The new style looks great, but I'd like to repeat someone else's question: Are we getting rid of the icons on the nav bar? As a plugin dev, it would be really nice to keep our company logo by our UI plugin. Shiva Sebastien - What impact would this angular.js project have on UI plugins? -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Cloud Solutions Citrix, Cisco Red Hat On Sep 27, 2013, at 2:44 AM, sebgoa run...@gmail.com wrote: On Sep 27, 2013, at 6:52 AM, Shiva Teja shivate...@gmail.com wrote: On Fri, Sep 27, 2013 at 9:28 AM, Ian Duffy i...@ianduffy.ie wrote: I think so implementation of AngularJS like the way Shiva did it for his GSoC project would be good. I'm trying to setup a demo for my project. This should give an idea about the code. https://github.com/shivateja/cloudstack-ui/blob/angular-rawapi/static/js/common/resources/virtualmachines.js https://github.com/shivateja/cloudstack-ui/blob/angular-rawapi/static/js/app/instances/instances.js https://github.com/shivateja/cloudstack-ui/blob/angular-rawapi/static/js/app/instances/instances.tpl.html Thanks, Shiva Teja Thanks Shiva, I was going to mention it. Shiva has worked on an angular.js app for a cloudstack frontend. All the code has been contributed in tools/ngui This could easily be used with Brian new CSS and it would clean up all the javascript. -Sebastien
RE: [DISCUSS] UI: New look and feel
Hey Chip, the BG is basically a layered background with a gradient and overlay pattern on top. I can send along the PNGs I used for those and a snippet of CSS, and you can apply them to the site. I'm also using Noto Sans for the font (ASF 2.0 licensed), if you want to use that as well. What I can do is either attach the bitmap assets I'm using (BG images, logos, font, etc.) to the wiki page, so anyone can grab them there for use in other materials, or else they are all in the ui-restyle git branch, under /ui/stylesheets/csui/ -Brian From: Chip Childers [chip.child...@sungard.com] Sent: Thursday, September 26, 2013 6:09 PM To: dev@cloudstack.apache.org Cc: Sonny Chhen; Animesh Chaturvedi; Jessica Wang Subject: Re: [DISCUSS] UI: New look and feel Looks great Brian! One request actually. I'm working on a proposed cloudstack.apache.org site redesign right now, and I'd actually love to get the relevant CSS you used for the header area (faded blue). It might be nice to have some relationship between the cs.a.o branding and the product itself. ;-) (watch the marketing list for my site redesign proposal shortly) On Thu, Sep 26, 2013 at 10:11:07PM +, Brian Federle wrote: Hi all, In addition to the CSS code cleanup I'm working on, I am planning a 'reskin' of the current UI to give a better user experience and look and feel. This will utilize SASS and a grid system as I have discussed in the previous thread. I created a task in JIRA and wiki functional spec, which has screenshots of what I've done so far and what I plan to do: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Update+UI+visual+appearance https://issues.apache.org/jira/browse/CLOUDSTACK-4748 You can also checkout the ui-restyle branch on git, if you are able to manually compile the cloudstack.scss file via SASS (that will be automated in the future). I can send over instructions on how to compile SASS manually; it's pretty easy to setup. Let me know what you think so far :) I'll of course up and post more screenshots as I get more done. This reskin is only changing the CSS mainly, with minimal changes to actual usage or JS code, so it is basically a drop-in replacement for the current styling. I'm hoping to get this in by 4.3, so please give me feedback on anything from the current UI you don't like or want changed, and I can see about improving it. Thanks! Brian
Re: Review Request 12228: static resource compression
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12228/#review26435 --- For the next release I'm planning to refactor the stylesheets to use the SASS compiler. Will this effect integration of a SASS compiler in any way? FYI The one I'm considering is https://github.com/Jasig/sass-maven-plugin. This hasn't been integrated yet and I am looking for someone with mvn build experience to work on it, though you are welcome to give this a try as well if you want :) - Brian Federle On Sept. 24, 2013, 6:57 a.m., Laszlo Hornyak wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12228/ --- (Updated Sept. 24, 2013, 6:57 a.m.) Review request for cloudstack, Brian Federle and Prasanna Santhanam. Repository: cloudstack-git Description --- CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB. This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching. Diffs - client/WEB-INF/web.xml e5c05d3 client/pom.xml 119c96e server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/12228/diff/ Testing --- Thanks, Laszlo Hornyak
Re: Review Request 13770: CLOUDSTACK-3363 UI fix list Events/Alerts screen is in processing state forever with Delete Events/Alerts request having no filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13770/#review26441 --- Ship it! Ship It! - Brian Federle On Aug. 28, 2013, 7:46 a.m., bo wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13770/ --- (Updated Aug. 28, 2013, 7:46 a.m.) Review request for cloudstack, Brian Federle and bharat kumar. Bugs: CLOUDSTACK-3363 Repository: cloudstack-git Description --- 1.The loading screen won't disappear when delete the events or alerts with incorrect parameters ,Because there is no handling for exception in the js code. 2.Error messages are not completely correct, it should be Either type or enddate must be specified. Diffs - ui/scripts/events.js 46d45c0 Diff: https://reviews.apache.org/r/13770/diff/ Testing --- 1.The loading screen will disappear when close the error message dialog. 2.The error message will be Either type or enddate must be specified. Thanks, bo wang
Re: Review Request 14285: Add multi-row action support to UI list views (CLOUDSTACK-1579)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14285/#review26456 --- Ship it! Ship It! - Brian Federle On Sept. 27, 2013, 8:34 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14285/ --- (Updated Sept. 27, 2013, 8:34 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- See https://issues.apache.org/jira/browse/CLOUDSTACK-1579 I have added the logic and hooks for allowing list views to indicate they support multiselect rows and added hooks for list view actions to indicate they are a multiselect action. The data for the selected rows is stored and passed to callbacks in the same 'context' variable as with non-multiselect callbacks, so implementing multiselect should remain consistent. This is purely a functional update and there is cosmetic work to be done shortly by someone other than myself (likely Brian Federle). Some notes for those interested: - $.remove() vs $.detach(): remove will delete the DOM element while detach simply removes it from view, allowing it to be added later and re-used - List views can indicate they support multi-select with 'multiSelect: true' - Actions can indicate they are a multi-select action with 'isMultiSelectAction: true' and 'isHeader: true' - This patch also includes a new list view flag called 'noActionCol' which intentional hides the 'Quickview' on rows which can be handy when the rows become too wide and look weird - Currently, when one or more multi-select rows are selected, non-multi-select actions (such as Add) are hidden and replaced with the multi-select actions, however the idea was proposed to add another row of buttons below the non-multi-select buttons when this is the case - this is still open for discussion as there was no consensus Diffs - ui/plugins/netapp PRE-CREATION ui/scripts/ui/widgets/dataTable.js 66d7095 ui/scripts/ui/widgets/listView.js 076b3ab Diff: https://reviews.apache.org/r/14285/diff/ Testing --- Testing has been done in conjunction with a UI plugin I am developing. Additional testing will be performed as this is integrated into existing parts of the UI. Thanks, Chris Suich
[DISCUSS] UI: New look and feel
Hi all, In addition to the CSS code cleanup I'm working on, I am planning a 'reskin' of the current UI to give a better user experience and look and feel. This will utilize SASS and a grid system as I have discussed in the previous thread. I created a task in JIRA and wiki functional spec, which has screenshots of what I've done so far and what I plan to do: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Update+UI+visual+appearance https://issues.apache.org/jira/browse/CLOUDSTACK-4748 You can also checkout the ui-restyle branch on git, if you are able to manually compile the cloudstack.scss file via SASS (that will be automated in the future). I can send over instructions on how to compile SASS manually; it's pretty easy to setup. Let me know what you think so far :) I'll of course up and post more screenshots as I get more done. This reskin is only changing the CSS mainly, with minimal changes to actual usage or JS code, so it is basically a drop-in replacement for the current styling. I'm hoping to get this in by 4.3, so please give me feedback on anything from the current UI you don't like or want changed, and I can see about improving it. Thanks! Brian
RE: [DISCUSS] CSS framework for CloudStack UI
Yeah, that would be a great idea...it would drastically reduce initial load time for the UI. OK, I've created a new branch called ui-css-framework. Right now all it does is rename cloudstack3.css - cloudstack3.scss. This of course will make the UI have no style if running right now, but once a SASS compiler is working then it should compile cloudstack3.css in the same folder. Feel free to use this branch to test out any build modifications for SASS/Grunt...let me know if any code changes are necessary. Thanks! Brian -Original Message- From: Shiva Teja [mailto:shivate...@gmail.com] Sent: Wednesday, September 18, 2013 9:32 AM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] CSS framework for CloudStack UI Another positive side of using grunt would be to minimize and package javascript. Currently, we load a huge number of javascript files separately. It'd be great if we can minimize them into a single file during build. Also, if we were to add any UI tests using libraries like jasmine, grunt makes it easy automate them. Shiva Teja On Wed, Sep 18, 2013 at 9:49 PM, Brian Federle brian.fede...@citrix.comwrote: Yeah, I'm definitely thinking the newer spec, which is better for us anyway since it is backwards-compatible with existing CSS. What I'll do is setup a dummy branch, which basically renames cloudstack3.css to cloudstack.scss or something like that, without much modification right now, and then see if it can be converted to the .css. Re: NPM, -- that is actually why I suggested the SASS plugin instead of the vanilla version of sass (installed via gem), since it would prevent people from having to install yet another dependency on their system, since I believe all required libs (including jRuby) are packaged in the jar, which may eliminate the need for Grunt for now? -Brian From: Chip Childers [chip.child...@sungard.com] Sent: Wednesday, September 18, 2013 6:01 AM To: dev@cloudstack.apache.org Cc: Rayees Namathponnan; Frank Zhang; Animesh Chaturvedi Subject: Re: [DISCUSS] CSS framework for CloudStack UI On Wed, Sep 18, 2013 at 11:53:18AM +0530, Amit Das wrote: Hi Brian, I agree with Edison on usage of grunt using maven-exec to call grunt. Will wait for your repository that has your experiments. I believe setting up the Maven tasks will be a one-time setting should work without issues. IIRC, Grunt is installed via NPM. So does that pull in a bunch of new developer requirements to build the project? Is there a standalone installation for Grunt to lighten the build dependency chain? How about using SassC? [1] Let's be sure to use the scss spec, not the sass older style (HAML inspired)! That appears to be Hampton's focus these days [2]. -chip [1] https://github.com/hcatlin/sassc [2] Per intro on http://sass-lang.com/
RE: [DISCUSS] CSS framework for CloudStack UI
Yeah, I'm definitely thinking the newer spec, which is better for us anyway since it is backwards-compatible with existing CSS. What I'll do is setup a dummy branch, which basically renames cloudstack3.css to cloudstack.scss or something like that, without much modification right now, and then see if it can be converted to the .css. Re: NPM, -- that is actually why I suggested the SASS plugin instead of the vanilla version of sass (installed via gem), since it would prevent people from having to install yet another dependency on their system, since I believe all required libs (including jRuby) are packaged in the jar, which may eliminate the need for Grunt for now? -Brian From: Chip Childers [chip.child...@sungard.com] Sent: Wednesday, September 18, 2013 6:01 AM To: dev@cloudstack.apache.org Cc: Rayees Namathponnan; Frank Zhang; Animesh Chaturvedi Subject: Re: [DISCUSS] CSS framework for CloudStack UI On Wed, Sep 18, 2013 at 11:53:18AM +0530, Amit Das wrote: Hi Brian, I agree with Edison on usage of grunt using maven-exec to call grunt. Will wait for your repository that has your experiments. I believe setting up the Maven tasks will be a one-time setting should work without issues. IIRC, Grunt is installed via NPM. So does that pull in a bunch of new developer requirements to build the project? Is there a standalone installation for Grunt to lighten the build dependency chain? How about using SassC? [1] Let's be sure to use the scss spec, not the sass older style (HAML inspired)! That appears to be Hampton's focus these days [2]. -chip [1] https://github.com/hcatlin/sassc [2] Per intro on http://sass-lang.com/
RE: [DISCUSS] CSS framework for CloudStack UI
Following up with this thread I started last month. For the first step (hopefully ready by 4.3), I'm planning on getting the SCSS/SASS compiler working with the UI build - https://github.com/Jasig/sass-maven-plugin. I've experimented with it using the existing CSS in our UI, and it will be pretty easy to use right away, then will gradually refactor over time into a more robust framework. Hopefully I can set up a work-in-progress branch up soon once I've got something tangible. Amit/Rayees/Frank/anyone else, let me know if you are able to find out if this is fairly easy to setup; I'm not familiar at all with Maven, so will need a fellow expert to help out here :) -Brian -Original Message- From: Amit Das [mailto:amit@cloudbyte.com] Sent: Monday, August 12, 2013 10:11 PM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] CSS framework for CloudStack UI Hi Brian, I should be able to help on the build tools part. However, I am new to ACS ACS UI. So I might take some time to understand the existing build process of ACS UI. We can surely coordinate on this. Regards, Amit *CloudByte Inc.* http://www.cloudbyte.com/ On Thu, Aug 8, 2013 at 11:11 PM, Brian Federle brian.fede...@citrix.comwrote: That sounds awesome, though I'm not too much of a guru with either maven or grunt -- I would be glad to coordinate with anyone who wants to take that on. -Brian -Original Message- From: Amit Das [mailto:amit@cloudbyte.com] Sent: Tuesday, August 06, 2013 10:16 PM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] CSS framework for CloudStack UI This is definitely a great idea. Will it be feasible to decouple the front-end build from server-side build as mentioned in the following link: http://addyosmani.com/blog/making-maven-grunt/ Regards, Amit Kumar Das *CloudByte Inc.* http://www.cloudbyte.com/ On Wed, Aug 7, 2013 at 5:48 AM, Ian Duffy i...@ianduffy.ie wrote: +1 to that definitely! The only problem I cannot handle is integrating the SASS compiler (which converts .scss-.css) into the UI build phase. I've found a maven plugin at https://github.com/Jasig/sass-maven-plugin, so if anyone wants to tackle that it would be awesome. Below is a meer suggestion, I've only read about it and never done it. I believe you are able to chain grunt into the maven life cycle. This would allow us to do various things with the front end code. This includes but is not limited to: - JSHint - Unit tests via xyz(suggesting QUnit or Jasmine) framework - Static analysis of the javascript with Plato - Compiling SASS + LESS - Uglifying/Minifying - Optimise images(png crush etc.) - Dependency management of 3rd party js libs It would supply us with a bunch nicer build process for the UI elements of Cloudstack. However it would add a dependency of nodejs to the build process.
RE: [VOTE] Apache Cloudstack 4.2.0
Probably something just got messed up during the rebase, I see this commit below yours: commit ae68c841f668768118bbff07f07060416fb16d48 Author: Jessica Wang jessicaw...@apache.org Date: Mon Aug 26 14:24:22 2013 -0700 CLOUDSTACK-4089: UI zone wizard hypervisor VMware configure physical network edit traffic type label split Which modifies system.js -- probably committed at the same time as you. I only think this because I've definitely screwed stuff up in git myself in the past when I forget to rebase :D -Brian From: Animesh Chaturvedi Sent: Monday, August 26, 2013 3:56 PM To: Mike Tutkowski Cc: dev@cloudstack.apache.org; Brian Federle; Jessica Wang Subject: RE: [VOTE] Apache Cloudstack 4.2.0 Mike the commit message shows it is a merge Merge remote-tracking branch 'upstream/4.2-forward' into 4.2-forward Adding Brian and Jessica to the thread. From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Monday, August 26, 2013 3:45 PM To: Animesh Chaturvedi Cc: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org; Brian Federle Subject: Re: [VOTE] Apache Cloudstack 4.2.0 I don't understand how those got in there. I think they were merged into my code from Jessica's earlier checkin. They are not related to my fix. On Mon, Aug 26, 2013 at 4:41 PM, Animesh Chaturvedi animesh.chaturv...@citrix.commailto:animesh.chaturv...@citrix.com wrote: Mike with your commit 6a2f15f94ae74b563a2d4df6da38e7f6ff44c8ac I see a few changes to Ui\scripts\ui-custom\zoneWizard.js Ui\scripts\zoneWizard.js Are they needed for your CHAP changes? These seems unrelated to me. Animesh -Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com] Sent: Monday, August 26, 2013 2:44 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: [VOTE] Apache Cloudstack 4.2.0 OK, Animesh. My changes are in 4.2-forward now. Thanks! On Mon, Aug 26, 2013 at 3:18 PM, Mike Tutkowski mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com wrote: No problem - I'll let you know when it's there. On Mon, Aug 26, 2013 at 2:54 PM, Animesh Chaturvedi animesh.chaturv...@citrix.commailto:animesh.chaturv...@citrix.com wrote: -Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com] Sent: Monday, August 26, 2013 1:48 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: [VOTE] Apache Cloudstack 4.2.0 Hi Animesh, It is related to adding an iSCSI target to ESX(i). The 4.2 code assumes you will want to use Mutual CHAP. This fix allows the user to not have to use Mutual CHAP. It's only a small number of changes, pretty low risk, and should only impact the SolidFire plug-in as no other plug-in code has been written to date that uses the logic in the VMware code that I would need to modify. I've written and tested the code, as well. Talk to you later, [Animesh] Can you put your fix in 4.2-forward ASAP -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302tel:303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302tel:303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- Mike Tutkowski Senior CloudStack Developer, SolidFire Inc. e: mike.tutkow...@solidfire.commailto:mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play(tm)
RE: Git repo down error: no DAV locking support
Same here. I've tried pushing to both master and 4.2-forward. I can git pull fine, but it just hangs forever when I try to git push. Maybe something up with the authentication system? -Brian -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Thursday, August 22, 2013 2:25 PM To: dev@cloudstack.apache.org Subject: Git repo down error: no DAV locking support I am cherry-picking few fixes for the RC build and just when I am ready to push to the repo it fails with following error $ git push origin 4.2 Password for 'https://anim...@git-wip-us.apache.org': error: no DAV locking support on https://anim...@git-wip-us.apache.org/repos/asf/cloudstack.git/ fatal: git-http-push failed Pull is working fine. Kelven tried and got the same error. Animesh
Re: Review Request 13128: Zone Chart Extension
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13128/#review25435 --- Ship it! Ship It! - Brian Federle On Aug. 2, 2013, 1:37 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13128/ --- (Updated Aug. 2, 2013, 1:37 p.m.) Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena. Repository: cloudstack-git Description --- I have extended some functions in zoneChart.js to allow plugins to create charts by simply defining their own function which assembles the chart itself rather than having to define the chart in zoneChart.js Diffs - ui/scripts/ui-custom/zoneChart.js 1a5fb59 Diff: https://reviews.apache.org/r/13128/diff/ Testing --- Thanks, Chris Suich
RE: 404 on some .css files
Good catch, yeah the 404s are caused because those plugins do not have any .css file associated with them. I can probably just add a few blank .css files to silence the errors, though otherwise they are harmless. -Brian -Original Message- From: La Motta, David [mailto:david.lamo...@netapp.com] Sent: Wednesday, August 14, 2013 8:43 AM To: dev@cloudstack.apache.org Subject: 404 on some .css files Not sure if anybody has seen this, but I just noticed today after my nonoss build ;-) Could've been there before, though. GET http://nimbus:8080/client/api?command=listCapabilitiesresponse=jsonsessio nkey=DGLyurBUgoy5E6VuOTdDdxIIV5o%3D_=1376494740700 401 (Unauthorized) jquery.js:7829 http://nimbus:8080/client/lib/jquery.js GET http://nimbus:8080/client/modules/infrastructure/infrastructure.css 404 (Not Found) jquery.js:5569 http://nimbus:8080/client/lib/jquery.js GET http://nimbus:8080/client/modules/vnmcNetworkProvider/vnmcNetworkProvider.c ss 404 (Not Found) jquery.js:5569 http://nimbus:8080/client/lib/jquery.js GET http://nimbus:8080/client/modules/vnmcAsa1000v/vnmcAsa1000v.css 404 (Not Found) jquery.js:5569 http://nimbus:8080/client/lib/jquery.js Just a heads up. -- David La Motta Technical Marketing Engineer - Citrix Solutions | NetApp david.lamo...@netapp.com
Re: Review Request 13132: Field default value functions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13132/#review25152 --- Ship it! Ship It! - Brian Federle On Aug. 2, 2013, 1:37 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13132/ --- (Updated Aug. 2, 2013, 1:37 p.m.) Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena. Repository: cloudstack-git Description --- Currently, the default value for a UI field must be a constant. I have extended the dialog forms to allow default value functions which are given the standard 'args' allowing default values to be determined at run time. Diffs - ui/scripts/sharedFunctions.js 8ddaeaf ui/scripts/ui/dialog.js 1ff5401 Diff: https://reviews.apache.org/r/13132/diff/ Testing --- Thanks, Chris Suich
Re: Review Request 13131: Default field identifier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13131/#review25155 --- Ship it! Ship It! - Brian Federle On Aug. 2, 2013, 1:38 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13131/ --- (Updated Aug. 2, 2013, 1:38 p.m.) Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena. Repository: cloudstack-git Description --- Currently, the identifying value of json objects is assumed to be 'id' or 'name' (if 'id' doesn't exist). I have added the option of allowing fields to specify which json property should be the identifying value of an object. For some reason, it says that ui/scripts/ui/dialog.js can not be found in the repository, so I have added the patch file manually. Please let me know if there is some way to fix this. Diffs - Diff: https://reviews.apache.org/r/13131/diff/ Testing --- File Attachments https://reviews.apache.org/media/uploaded/files/2013/07/31/field-identify-value.patch Thanks, Chris Suich
Re: Review Request 13127: UI Plugin Internationalization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13127/#review25094 --- Ship it! Ship It! - Brian Federle On Aug. 2, 2013, 1:36 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13127/ --- (Updated Aug. 2, 2013, 1:36 p.m.) Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena. Repository: cloudstack-git Description --- This allows UI Plugins to contribute their own internationalized strings to the global js dictionary. Each plugin would define a dictionary.js and several dictionary_locale.js files. As each plugin is loaded, the appropriate plugin dictionary is loaded into the global js dictionary (with the global dictionary taking precedence in the event of a conflict). Diffs - ui/scripts/plugins.js 96ed229 Diff: https://reviews.apache.org/r/13127/diff/ Testing --- Thanks, Chris Suich
RE: [DISCUSS] CSS framework for CloudStack UI
That sounds awesome, though I'm not too much of a guru with either maven or grunt -- I would be glad to coordinate with anyone who wants to take that on. -Brian -Original Message- From: Amit Das [mailto:amit@cloudbyte.com] Sent: Tuesday, August 06, 2013 10:16 PM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] CSS framework for CloudStack UI This is definitely a great idea. Will it be feasible to decouple the front-end build from server-side build as mentioned in the following link: http://addyosmani.com/blog/making-maven-grunt/ Regards, Amit Kumar Das *CloudByte Inc.* http://www.cloudbyte.com/ On Wed, Aug 7, 2013 at 5:48 AM, Ian Duffy i...@ianduffy.ie wrote: +1 to that definitely! The only problem I cannot handle is integrating the SASS compiler (which converts .scss-.css) into the UI build phase. I've found a maven plugin at https://github.com/Jasig/sass-maven-plugin, so if anyone wants to tackle that it would be awesome. Below is a meer suggestion, I've only read about it and never done it. I believe you are able to chain grunt into the maven life cycle. This would allow us to do various things with the front end code. This includes but is not limited to: - JSHint - Unit tests via xyz(suggesting QUnit or Jasmine) framework - Static analysis of the javascript with Plato - Compiling SASS + LESS - Uglifying/Minifying - Optimise images(png crush etc.) - Dependency management of 3rd party js libs It would supply us with a bunch nicer build process for the UI elements of Cloudstack. However it would add a dependency of nodejs to the build process.
[DISCUSS] CSS framework for CloudStack UI
Hey all, As part of the next release, I'm planning on doing a lot of cleanup of our massive heap of CSS code. As part of this, I want to start using SASS/SCSS (http://sass-lang.com/) to improve organization and maintainability. Particularly, this would allow: - Splitting CSS into multiple files (by feature), instead of one large 3000+ line CSS. This is then compiled into one CSS during the build, so the browser doesn't have to make multiple requests. - Hierarchical organization, to reduce redundant selectors - Can easily utilize great helper libraries (i.e., http://bourbon.io,) and a semantic grid system for cleaner + responsive layout (i.e., http://neat.bourbon.io/) Since it supports all standard CSS syntax, our UI code can be gradually converted feature-by-feature, and we can still retain any legacy CSS for certain functionality, if necessary. The only problem I cannot handle is integrating the SASS compiler (which converts .scss-.css) into the UI build phase. I've found a maven plugin at https://github.com/Jasig/sass-maven-plugin, so if anyone wants to tackle that it would be awesome. Any other thoughts? -Brian
RE: [DISCUSS] Selectable UI list view rows
Hey Chris, I've actually created a ticket for this, which I'm planning to implement in a future release (hopefully the next one if I have the bandwidth). See https://issues.apache.org/jira/browse/CLOUDSTACK-1579 This will require a good deal of refactoring of existing code to support though, so to start it will probably be implemented on 1-2 sections; most likely instances and events/alerts which is where it is requested the most. -Brian From: SuichII, Christopher [mailto:chris.su...@netapp.com] Sent: Tuesday, August 06, 2013 10:57 AM To: dev@cloudstack.apache.org Subject: [DISCUSS] Selectable UI list view rows One feature I'd like to look in to is allowing list views to have 'selectable' rows. With this, users could check individual rows of a list view to perform some action on a subset of the list. When one or more row is selected, the list of actions at the top of the list view would be filtered to only those which can be performed on the selected rows. Additionally, there would be a checkbox in the header of the list view which would allow the user to quickly select/unselect all items in the list. Maybe a quick mockup will help make this more clear: [cid:71D4FE5A-8C45-47C4-9675-7BA66FB22F05@hq.netapp.com] Any thoughts, concerns, feedback or existing plans for something like this? Thanks, Chris
Re: Review Request 13190: CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate parameter rather than olderthan parameter in the archive/delete alerts/events API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13190/#review24538 --- Ship it! Ship It! - Brian Federle On Aug. 1, 2013, 11:05 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13190/ --- (Updated Aug. 1, 2013, 11:05 a.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-4010 Repository: cloudstack-git Description --- CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate parameter rather than olderthan parameter in the archive/delete alerts/events API. Diffs - ui/scripts/events.js 873998e Diff: https://reviews.apache.org/r/13190/diff/ Testing --- Veirified the fix and functionality locally on cloudstack setup. Thanks, Sanjay Tripathi
Reformatting UI code
Hello, Recently I discovered that all JS and UI code have been reformatted to 4 spaces: commit ad69bc8da3244b783dd003ddf3184fca2762c514 Author: Ian Duffy i...@ianduffy.ie Date: Thu Jul 18 15:39:28 2013 +0100 Format JS While I do appreciate people coming in to help clean up the UI code, and don't mind if we change the indent level to be consistent with the rest of the code base, this commit is causing a lot of git conflicts with various development branches I'm working on. Please give a bit more heads up in the future about this, try to CC the main UI developers about it first before committing - right now myself and Jessica Wang (jessica.w...@citrix.com) do the majority of UI development. Thanks, Brian
RE: Reformatting UI code
In this case it was fine, I could resolve the conflicts by git's -Xignore-space-change and reformatting accordingly. The main issue was that I didn't see any indication that this was being committed from reading the discussion thread. Since we're doing a lot of bugfixing right now for 4.2, a large sweeping commit like this should at least be posted as part of thread, so that there is heads-up so that we can prepare any pending changes we have to avoid being blocked. -Brian -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Monday, July 22, 2013 3:26 PM To: Jessica Wang Cc: Pranav Saxena; Ian Duffy (i...@ianduffy.ie); dev@cloudstack.apache.org; Brian Federle Subject: Re: Reformatting UI code Hi jessica, Sorry this is causing you trouble. Ian us developing his ldap plugin in a feature branch . This was a UI cosmetic code change, i saw that pranav shipped it in RB but did not apply the patch. Since the three if us work in more or less the same time zone i applied the patch quickly to master. I did think about other UI work but since 4.2 is in feature freeze i did not think committing to master would be a problem. Moreover i did not know u were working on UI feature branches. Where can we look at the feature descriptions ? I suppose u could revert the patch . But for features for 4.3 i think it should be rebase of your feature branches . I dont think this change should be impacting 4.2 not sure why u say thats the case. Thoughts ? -Sebastien On 23 Jul 2013, at 00:07, Jessica Wang jessica.w...@citrix.com wrote: Pranav, Ian, Sebastien, The problem is the duration between the time Ian brought it up on the mailing list and the time Ian/Sebastien checked in the change to master branch is too short (less than 4 hours). Ian brought it up on the mailing list at Thu 7/18/2013 5:44 AM (email subject is Auto format javascript). Sebastien checked in Ian's change to master branch at 7/18/2013 9:34 AM (Commit hash: ad69bc8da3244b783dd003ddf3184fca2762c514). This is a big change of UI code. In GIT's view, every line in JS files has been changed (If you look at code difference in GIT's history). GIT sees it as delete all lines and add new different lines. I was unable to merge my check-in from master branch to 4.2 branch (or any other branch) since GIT sees JS files in master branch and other branches are totally different. Shouldn't this kind of big change be checked in to a different branch (not master branch) first? Then, submit a merge request to community, wait for 72 hours, then merge to master branch eventually? Jessica -Original Message- From: Pranav Saxena [mailto:psb...@gmail.com] Sent: Monday, July 22, 2013 12:18 PM To: dev@cloudstack.apache.org; Brian Federle Cc: Ian Duffy (i...@ianduffy.ie) Subject: Re: Reformatting UI code Hey Brian, Sorry to hear that it caused merge conflicts for you . But Ian did bring it up on the mailing list and I suggested him to use the js beautifier tool for reformatting the js code which I guess you missed probably because of the heavy traffic on the dev list and thereafter Sebastien merged the code when the discussion and the reviews ended. Anyways, I'll also try to ping you personally on such occasions in the future to let you know if any major changes are being committed. Now , probably you would need to do a lot of rebasing , sorry for that !! Thanks, Pranav On Tue, Jul 23, 2013 at 12:29 AM, Jessica Wang jessica.w...@citrix.comwrote: +1 -Original Message- From: Brian Federle [mailto:brian.fede...@citrix.com] Sent: Monday, July 22, 2013 11:33 AM To: dev@cloudstack.apache.org Cc: Ian Duffy (i...@ianduffy.ie) Subject: Reformatting UI code Hello, Recently I discovered that all JS and UI code have been reformatted to 4 spaces: commit ad69bc8da3244b783dd003ddf3184fca2762c514 Author: Ian Duffy i...@ianduffy.ie Date: Thu Jul 18 15:39:28 2013 +0100 Format JS While I do appreciate people coming in to help clean up the UI code, and don't mind if we change the indent level to be consistent with the rest of the code base, this commit is causing a lot of git conflicts with various development branches I'm working on. Please give a bit more heads up in the future about this, try to CC the main UI developers about it first before committing - right now myself and Jessica Wang (jessica.w...@citrix.com) do the majority of UI development. Thanks, Brian
RE: Reformatting UI code
suppose u could revert the patch . But for features for 4.3 i think it should be rebase of your feature branches . I dont think this change should be impacting 4.2 not sure why u say thats the case. It's OK, I've got the conflicts sorted out now. I don't have a problem with the new formatting conventions, so no need to revert in this case. -Brian -Original Message- From: Brian Federle Sent: Monday, July 22, 2013 3:34 PM To: 'Sebastien Goasguen'; Jessica Wang Cc: Pranav Saxena; Ian Duffy (i...@ianduffy.ie); dev@cloudstack.apache.org Subject: RE: Reformatting UI code In this case it was fine, I could resolve the conflicts by git's -Xignore-space-change and reformatting accordingly. The main issue was that I didn't see any indication that this was being committed from reading the discussion thread. Since we're doing a lot of bugfixing right now for 4.2, a large sweeping commit like this should at least be posted as part of thread, so that there is heads-up so that we can prepare any pending changes we have to avoid being blocked. -Brian -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Monday, July 22, 2013 3:26 PM To: Jessica Wang Cc: Pranav Saxena; Ian Duffy (i...@ianduffy.ie); dev@cloudstack.apache.org; Brian Federle Subject: Re: Reformatting UI code Hi jessica, Sorry this is causing you trouble. Ian us developing his ldap plugin in a feature branch . This was a UI cosmetic code change, i saw that pranav shipped it in RB but did not apply the patch. Since the three if us work in more or less the same time zone i applied the patch quickly to master. I did think about other UI work but since 4.2 is in feature freeze i did not think committing to master would be a problem. Moreover i did not know u were working on UI feature branches. Where can we look at the feature descriptions ? I suppose u could revert the patch . But for features for 4.3 i think it should be rebase of your feature branches . I dont think this change should be impacting 4.2 not sure why u say thats the case. Thoughts ? -Sebastien On 23 Jul 2013, at 00:07, Jessica Wang jessica.w...@citrix.com wrote: Pranav, Ian, Sebastien, The problem is the duration between the time Ian brought it up on the mailing list and the time Ian/Sebastien checked in the change to master branch is too short (less than 4 hours). Ian brought it up on the mailing list at Thu 7/18/2013 5:44 AM (email subject is Auto format javascript). Sebastien checked in Ian's change to master branch at 7/18/2013 9:34 AM (Commit hash: ad69bc8da3244b783dd003ddf3184fca2762c514). This is a big change of UI code. In GIT's view, every line in JS files has been changed (If you look at code difference in GIT's history). GIT sees it as delete all lines and add new different lines. I was unable to merge my check-in from master branch to 4.2 branch (or any other branch) since GIT sees JS files in master branch and other branches are totally different. Shouldn't this kind of big change be checked in to a different branch (not master branch) first? Then, submit a merge request to community, wait for 72 hours, then merge to master branch eventually? Jessica -Original Message- From: Pranav Saxena [mailto:psb...@gmail.com] Sent: Monday, July 22, 2013 12:18 PM To: dev@cloudstack.apache.org; Brian Federle Cc: Ian Duffy (i...@ianduffy.ie) Subject: Re: Reformatting UI code Hey Brian, Sorry to hear that it caused merge conflicts for you . But Ian did bring it up on the mailing list and I suggested him to use the js beautifier tool for reformatting the js code which I guess you missed probably because of the heavy traffic on the dev list and thereafter Sebastien merged the code when the discussion and the reviews ended. Anyways, I'll also try to ping you personally on such occasions in the future to let you know if any major changes are being committed. Now , probably you would need to do a lot of rebasing , sorry for that !! Thanks, Pranav On Tue, Jul 23, 2013 at 12:29 AM, Jessica Wang jessica.w...@citrix.comwrote: +1 -Original Message- From: Brian Federle [mailto:brian.fede...@citrix.com] Sent: Monday, July 22, 2013 11:33 AM To: dev@cloudstack.apache.org Cc: Ian Duffy (i...@ianduffy.ie) Subject: Reformatting UI code Hello, Recently I discovered that all JS and UI code have been reformatted to 4 spaces: commit ad69bc8da3244b783dd003ddf3184fca2762c514 Author: Ian Duffy i...@ianduffy.ie Date: Thu Jul 18 15:39:28 2013 +0100 Format JS While I do appreciate people coming in to help clean up the UI code, and don't mind if we change the indent level to be consistent with the rest of the code base, this commit is causing a lot of git conflicts with various development branches I'm working on. Please give a bit more heads up in the future about this, try to CC the main UI developers about it first
