Review Request 28691: Cloudstack records ids into events table instead of UUIDs for create snapshot command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28691/ --- Review request for cloudstack and Kishan Kavala. Repository: cloudstack-git Description --- Currently when create a snaphost it logs 3 events(scheduled, started, completed) into event table. Out of these 3 started and completed events has IDs in the descripton insted of UUIDs in event tbale. Diffs - api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java df7fe82 Diff: https://reviews.apache.org/r/28691/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Review Request 28700: Attach volume events are not correctly shown in events.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28700/ --- Review request for cloudstack and Koushik Das. Repository: cloudstack-git Description --- When we call AttachVolume API, Cloudstack is not recording all events into event table. It should generate Scheduled, Started and Completed evetns. But it was generating only Schduled one. Diffs - server/src/com/cloud/storage/VolumeApiServiceImpl.java 785a95e Diff: https://reviews.apache.org/r/28700/diff/ Testing --- Tested by attaching volume to a VM Thanks, Damodar Reddy Talakanti
Re: Review Request 28691: Cloudstack records ids into events table instead of UUIDs for create snapshot command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28691/ --- (Updated Dec. 4, 2014, 10:08 a.m.) Review request for cloudstack and Kishan Kavala. Changes --- updated patch with missed changes Repository: cloudstack-git Description --- Currently when create a snaphost it logs 3 events(scheduled, started, completed) into event table. Out of these 3 started and completed events has IDs in the descripton insted of UUIDs in event tbale. Diffs (updated) - api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java df7fe82 Diff: https://reviews.apache.org/r/28691/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Review Request 28325: Two VOLUME.DELETE Events are being registered instead of one - On Destroying a User VM belonging to a Project
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28325/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-7948 https://issues.apache.org/jira/browse/CLOUDSTACK-7948 Repository: cloudstack-git Description --- When we destroy a VM it is publishing two VOLUME DELETE events into usage events for ROOT VOLUME. Diffs - server/src/com/cloud/storage/listener/VolumeStateListener.java 9fd1423 Diff: https://reviews.apache.org/r/28325/diff/ Testing --- Tested as a normal user Tested as a admin (With and with out pasing expunge flag) Tested by attaching Data disks Thanks, Damodar Reddy Talakanti
Review Request 28168: public_ip type resource count for an account is not decremented upon IP range deletion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28168/ --- Review request for cloudstack, bharat kumar and Kishan Kavala. Repository: cloudstack-git Description --- When deleting the IP range which is associated to an account the resource count for public_ip is not decremented accordingly which is causing not to add any new ranges to that account further once we reach max limit. Repro Steps. - 1. Add an IP range and associate it to a particular account. This will increment your resource count for public_ip to that range count. 2. Now try to delete this range and check the resource count for public_ip of that account. it will not be decreased. Diffs - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 2cb4203 Diff: https://reviews.apache.org/r/28168/diff/ Testing --- Tested on latest master with Xen Hypervisor. Tested with acquiring atleast an IP from that account and with out acquiring any IPs from that account. Thanks, Damodar Reddy Talakanti
Review Request 28114: RabbitMQ integration, make SSL protocol configurable rather than hard coded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28114/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-7923 https://issues.apache.org/jira/browse/CLOUDSTACK-7923 Repository: cloudstack-git Description --- In the current RabbitMQ integration implementation we are using default SSL Context which uses SSLv3 by default. Make it configurable so that let the users decide which protocol to be used. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java 2d389f2 Diff: https://reviews.apache.org/r/28114/diff/ Testing --- Tested against RabbitMQ server 3.3.5 Thanks, Damodar Reddy Talakanti
Review Request 27904: cloudstackoperations like deployvm, deleteNW are failing if CS fail to contact rabbit mq server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27904/ --- Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-7886 https://issues.apache.org/jira/browse/CLOUDSTACK-7886 Repository: cloudstack-git Description --- If RabbitMQ configuration is enabled and Management server is not able to talk to the RabbitMQ server while deploying a VM or deleting a NW it wil fail the operations. Diffs - server/src/com/cloud/api/ApiServer.java e29ddd3 Diff: https://reviews.apache.org/r/27904/diff/ Testing --- Tested against Xen for operations like deployVM and delete a network. Thanks, Damodar Reddy Talakanti
Re: Review Request 27520: Usage Job fails with Data too long for column 'user_name'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27520/ --- (Updated Nov. 10, 2014, 9:14 a.m.) Review request for cloudstack and Kishan Kavala. Changes --- Updated the patch as it is failing to apply on master Bugs: CLOUDSTACK-7830 https://issues.apache.org/jira/browse/CLOUDSTACK-7830 Repository: cloudstack-git Description --- While inserting into the cloud_usage database it is getting the following exception. INSERT INTO usage_vpn_user (usage_vpn_user.zone_id, usage_vpn_user.account_id, usage_vpn_user.domain_id, usage_vpn_user.user_id, usage_vpn_user.user_name, usage_vpn_user.created, usage_vpn_user.deleted) VALUES (0, 13, 14, 4, _binary'timothy.lother...@dcxclouddemo.co.za', '2014-03-11 14:36:50', null) Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'user_name' at row 1 at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:4072) Diffs (updated) - setup/db/db/schema-441to450.sql d9bc8e0 Diff: https://reviews.apache.org/r/27520/diff/ Testing --- Tested on 4.5.0 by upgrading from 4.3.0 Thanks, Damodar Reddy Talakanti
Re: Review Request 27222: Usage Events to be captured based on Volume State Machine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27222/ --- (Updated Nov. 10, 2014, 9:45 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Changes --- Updating the patch as it is not getting applied on the master Bugs: CLOUDSTACK-7792 https://issues.apache.org/jira/browse/CLOUDSTACK-7792 Repository: cloudstack-git Description --- Currently in CloudStack the Usage Events for Volume related actions are captured directly at various places. But actually Volume has a State Machine which can be used to capture Usage Events for volume similar to VM Usage Events Diffs (updated) - api/src/com/cloud/storage/Volume.java 91ad955 api/src/com/cloud/vm/VirtualMachine.java 99152d6 engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java b21616a engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 826e2ee engine/schema/src/com/cloud/storage/VolumeVO.java e328253 engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java f2b4c95 engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 9c45cb8 server/src/com/cloud/storage/StorageManagerImpl.java 153c25a server/src/com/cloud/storage/VolumeApiServiceImpl.java 088f054 server/src/com/cloud/storage/listener/VolumeStateListener.java 0ba2969 Diff: https://reviews.apache.org/r/27222/diff/ Testing --- Tested on Simulator. Also tested on XenServer for the following use cases 1. Add Volume (Migrate, Destroy) 2. Attach Volume (Live Migration and normal Migration) 3. Upload Volume (Attach also) 4. Delete Volume 5. Deploy VM (With Data Disk and with out Data Disk) 6. Destroy VM (With Data Disk and with out Data Disk) 7. Recover VM 8. Restore VM 9. Resize Volume Thanks, Damodar Reddy Talakanti
Review Request 27856: The NET.IPRELEASE events are not added to usage_event on IP range deletion from Physical Networks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27856/ --- Review request for cloudstack, Jayapal Reddy and Kishan Kavala. Bugs: CLOUDSTACK-7877 https://issues.apache.org/jira/browse/CLOUDSTACK-7877 Repository: cloudstack-git Description --- Once you create a IP range and tie to an account and try to delete the range before allocating any IP it will not stop metering usage even after deletion of the range. Diffs - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1f71c0f Diff: https://reviews.apache.org/r/27856/diff/ Testing --- Tested on Xen against the above use case and some other use cases. Thanks, Damodar Reddy Talakanti
Review Request 27613: sync Job Failures always reported as success on Event Bus
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27613/ --- Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-7843 https://issues.apache.org/jira/browse/CLOUDSTACK-7843 Repository: cloudstack-git Description --- As complete async job event gets published before saving the job status to the database. so it is not putting correct job status into event bus while publishing. Diffs - framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java 548182a Diff: https://reviews.apache.org/r/27613/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Review Request 27671: MS does not start after the VM it is running on is rebooted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27671/ --- Review request for cloudstack, Kishan Kavala and Santhosh Edukulla. Bugs: CLOUDSTACK-7851 https://issues.apache.org/jira/browse/CLOUDSTACK-7851 Repository: cloudstack-git Description --- After installing management server on centos and try to reboot the machine. It will not start the management server automatically. Diffs - packaging/centos63/cloud-management.rc eaabd30 Diff: https://reviews.apache.org/r/27671/diff/ Testing --- Tested on Centos 6.x and RHEL 7 Thanks, Damodar Reddy Talakanti
Review Request 27520: Usage Job fails with Data too long for column 'user_name'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27520/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-7830 https://issues.apache.org/jira/browse/CLOUDSTACK-7830 Repository: cloudstack-git Description --- While inserting into the cloud_usage database it is getting the following exception. INSERT INTO usage_vpn_user (usage_vpn_user.zone_id, usage_vpn_user.account_id, usage_vpn_user.domain_id, usage_vpn_user.user_id, usage_vpn_user.user_name, usage_vpn_user.created, usage_vpn_user.deleted) VALUES (0, 13, 14, 4, _binary'timothy.lother...@dcxclouddemo.co.za', '2014-03-11 14:36:50', null) Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'user_name' at row 1 at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:4072) Diffs - setup/db/db/schema-441to450.sql 3deb8ad Diff: https://reviews.apache.org/r/27520/diff/ Testing --- Tested on 4.5.0 by upgrading from 4.3.0 Thanks, Damodar Reddy Talakanti
Review Request 27222: Usage Events to be captured based on Volume State Machine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27222/ --- Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-7792 https://issues.apache.org/jira/browse/CLOUDSTACK-7792 Repository: cloudstack-git Description --- Currently in CloudStack the Usage Events for Volume related actions are captured directly at various places. But actually Volume has a State Machine which can be used to capture Usage Events for volume similar to VM Usage Events Diffs - api/src/com/cloud/storage/Volume.java b67a395 api/src/com/cloud/vm/VirtualMachine.java 99152d6 engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java b21616a engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 4b40d5a engine/schema/src/com/cloud/storage/VolumeVO.java e328253 engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java f2b4c95 engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 9174d89 server/src/com/cloud/storage/StorageManagerImpl.java 153c25a server/src/com/cloud/storage/VolumeApiServiceImpl.java b70d753 server/src/com/cloud/storage/listener/VolumeStateListener.java 0ba2969 Diff: https://reviews.apache.org/r/27222/diff/ Testing --- Tested on Simulator. Also tested on XenServer for the following use cases 1. Add Volume (Migrate, Destroy) 2. Attach Volume (Live Migration and normal Migration) 3. Upload Volume (Attach also) 4. Delete Volume 5. Deploy VM (With Data Disk and with out Data Disk) 6. Destroy VM (With Data Disk and with out Data Disk) 7. Recover VM 8. Restore VM Thanks, Damodar Reddy Talakanti
Re: Review Request 27222: Usage Events to be captured based on Volume State Machine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27222/ --- (Updated Oct. 27, 2014, 11:53 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Changes --- Handled the Resize Case Bugs: CLOUDSTACK-7792 https://issues.apache.org/jira/browse/CLOUDSTACK-7792 Repository: cloudstack-git Description --- Currently in CloudStack the Usage Events for Volume related actions are captured directly at various places. But actually Volume has a State Machine which can be used to capture Usage Events for volume similar to VM Usage Events Diffs (updated) - api/src/com/cloud/storage/Volume.java b67a395 api/src/com/cloud/vm/VirtualMachine.java 99152d6 engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java b21616a engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 4b40d5a engine/schema/src/com/cloud/storage/VolumeVO.java e328253 engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java f2b4c95 engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 9174d89 server/src/com/cloud/storage/StorageManagerImpl.java 153c25a server/src/com/cloud/storage/VolumeApiServiceImpl.java b70d753 server/src/com/cloud/storage/listener/VolumeStateListener.java 0ba2969 Diff: https://reviews.apache.org/r/27222/diff/ Testing (updated) --- Tested on Simulator. Also tested on XenServer for the following use cases 1. Add Volume (Migrate, Destroy) 2. Attach Volume (Live Migration and normal Migration) 3. Upload Volume (Attach also) 4. Delete Volume 5. Deploy VM (With Data Disk and with out Data Disk) 6. Destroy VM (With Data Disk and with out Data Disk) 7. Recover VM 8. Restore VM 9. Resize Volume Thanks, Damodar Reddy Talakanti
Review Request 26738: listVMSnapshot API is not returning parent id in response
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26738/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-7729 https://issues.apache.org/jira/browse/CLOUDSTACK-7729 Repository: cloudstack-git Description --- Currently listVMSnapshot API is not returning parent id in response if parent exists for a given snapshot (It displays only parent Name). Diffs - api/src/org/apache/cloudstack/api/response/VMSnapshotResponse.java 168c548 server/src/com/cloud/api/ApiResponseHelper.java 50376d2 Diff: https://reviews.apache.org/r/26738/diff/ Testing --- Tested on latest Master with XenServer Hypervisor. Thanks, Damodar Reddy Talakanti
Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26168/ --- (Updated Oct. 9, 2014, 6:26 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Changes --- removed TODO tags which are added during fix Bugs: CLOUDSTACK-7648 https://issues.apache.org/jira/browse/CLOUDSTACK-7648 Repository: cloudstack-git Description --- There are new VM State Machine changes introduced while adding VM Sync changes and these were missed to capture the usage events. This is causing to get wrong usage statistics for a VM who's state is changed by VM sync Diffs (updated) - api/src/com/cloud/vm/VirtualMachine.java 34387eb engine/components-api/src/com/cloud/network/NetworkStateListener.java c86f782 plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java 92163ea plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java c998e3b server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19 server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 968c538 server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746 server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6 server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48 server/src/com/cloud/vm/UserVmStateListener.java a0088b8 server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 8e606ca utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645 utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb Diff: https://reviews.apache.org/r/26168/diff/ Testing (updated) --- Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions. Ran Simulator for VM lifecycle realted tests. Currenly there is no API call listUsageEvents to verify that events are generated. Ran Simulator and used smoke tests against simulator to test it. Thanks, Damodar Reddy Talakanti
Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26168/ --- (Updated Oct. 9, 2014, 5:37 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-7648 https://issues.apache.org/jira/browse/CLOUDSTACK-7648 Repository: cloudstack-git Description --- There are new VM State Machine changes introduced while adding VM Sync changes and these were missed to capture the usage events. This is causing to get wrong usage statistics for a VM who's state is changed by VM sync Diffs - api/src/com/cloud/vm/VirtualMachine.java 34387eb engine/components-api/src/com/cloud/network/NetworkStateListener.java c86f782 plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java 92163ea plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java c998e3b server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19 server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 968c538 server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746 server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6 server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48 server/src/com/cloud/vm/UserVmStateListener.java a0088b8 server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 8e606ca utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645 utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb Diff: https://reviews.apache.org/r/26168/diff/ Testing --- Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions. Ran Simulator for VM lifecycle realted tests. Currenly there is no API call listUsageEvents to verify that events are generated. Thanks, Damodar Reddy Talakanti
Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26168/ --- (Updated Oct. 9, 2014, 5:36 a.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Changes --- Incorporated comments from Koushik Bugs: CLOUDSTACK-7648 https://issues.apache.org/jira/browse/CLOUDSTACK-7648 Repository: cloudstack-git Description --- There are new VM State Machine changes introduced while adding VM Sync changes and these were missed to capture the usage events. This is causing to get wrong usage statistics for a VM who's state is changed by VM sync Diffs (updated) - api/src/com/cloud/vm/VirtualMachine.java 34387eb engine/components-api/src/com/cloud/network/NetworkStateListener.java c86f782 plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java 92163ea plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java c998e3b server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19 server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 968c538 server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746 server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6 server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48 server/src/com/cloud/vm/UserVmStateListener.java a0088b8 server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 8e606ca utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645 utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb Diff: https://reviews.apache.org/r/26168/diff/ Testing --- Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions. Ran Simulator for VM lifecycle realted tests. Currenly there is no API call listUsageEvents to verify that events are generated. Thanks, Damodar Reddy Talakanti
Review Request 26356: [RHEL7] management server failed to start once machine is rebooted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26356/ --- Review request for cloudstack and Rayees Namathponnan. Bugs: CLOUDSTACK-7671 https://issues.apache.org/jira/browse/CLOUDSTACK-7671 Repository: cloudstack-git Description --- After you install management server on rhel 7 and start the server. Now try to reboot the machine and start management server then it will fail to start as pid file is not able to create as cloud user. Diffs - packaging/centos63/cloud.spec 7306d1f packaging/centos63/default/macros.spec f3c937c packaging/centos63/rhel7/cloudstack-management.conf PRE-CREATION packaging/centos63/rhel7/macros.spec 4b71092 Diff: https://reviews.apache.org/r/26356/diff/ Testing --- Tested on RHEL-7 and RHEL 6.2 servers. Installed and re booted the machines.. Thanks, Damodar Reddy Talakanti
Re: Review Request 26356: [RHEL7] management server failed to start once machine is rebooted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26356/ --- (Updated Oct. 6, 2014, 9:45 a.m.) Review request for cloudstack, Kishan Kavala and Rayees Namathponnan. Changes --- Adding Kishan Bugs: CLOUDSTACK-7671 https://issues.apache.org/jira/browse/CLOUDSTACK-7671 Repository: cloudstack-git Description --- After you install management server on rhel 7 and start the server. Now try to reboot the machine and start management server then it will fail to start as pid file is not able to create as cloud user. Diffs - packaging/centos63/cloud.spec 7306d1f packaging/centos63/default/macros.spec f3c937c packaging/centos63/rhel7/cloudstack-management.conf PRE-CREATION packaging/centos63/rhel7/macros.spec 4b71092 Diff: https://reviews.apache.org/r/26356/diff/ Testing --- Tested on RHEL-7 and RHEL 6.2 servers. Installed and re booted the machines.. Thanks, Damodar Reddy Talakanti
Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26168/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-7648 https://issues.apache.org/jira/browse/CLOUDSTACK-7648 Repository: cloudstack-git Description --- There are new VM State Machine changes introduced while adding VM Sync changes and these were missed to capture the usage events. This is causing to get wrong usage statistics for a VM who's state is changed by VM sync Diffs - api/src/com/cloud/vm/VirtualMachine.java 34387eb engine/components-api/src/com/cloud/network/NetworkStateListener.java c86f782 plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java 92163ea plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java c998e3b server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19 server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 1c80fea server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746 server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6 server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48 server/src/com/cloud/vm/UserVmStateListener.java a0088b8 server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 8e606ca utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645 utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb Diff: https://reviews.apache.org/r/26168/diff/ Testing --- Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions. Ran Simulator for VM lifecycle realted tests. Currenly there is no API call listUsageEvents to verify that events are generated. Thanks, Damodar Reddy Talakanti
Review Request 25240: Management Server setup doesn't proceed to completion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25240/ --- Review request for cloudstack and Kishan Kavala. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7464 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7464 Repository: cloudstack-git Description --- The commit c730bc3491f8b684c5ae51e0bff54cf7577cc246 caused the issue to not start the management server as it is having an empty context file to load. Diffs - server/resources/META-INF/cloudstack/core/spring-event-bus-context.xml 3e1a8ed Diff: https://reviews.apache.org/r/25240/diff/ Testing --- Tested by starting management server after this fix whether it is starting up or not. Thanks, Damodar Reddy Talakanti
Review Request 25228: hitting java.lang.reflect.InvocationTargetException while starting usage server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25228/ --- Review request for cloudstack, Frank Zhang and Rayees Namathponnan. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7316 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7316 Repository: cloudstack-git Description --- Usage server is failing to start when we install Usage server on the management server with DB encryption enabled. Usage is server is unable to get key file from the classpath. Diffs - packaging/centos63/cloud.spec 790f57b Diff: https://reviews.apache.org/r/25228/diff/ Testing --- Tested on centos 6.3 and rhel 7 Thanks, Damodar Reddy Talakanti
Re: Review Request 25228: hitting java.lang.reflect.InvocationTargetException while starting usage server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25228/ --- (Updated Sept. 2, 2014, 4:08 a.m.) Review request for cloudstack, Kishan Kavala and Rayees Namathponnan. Changes --- Added kishan to the list Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7316 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7316 Repository: cloudstack-git Description --- Usage server is failing to start when we install Usage server on the management server with DB encryption enabled. Usage is server is unable to get key file from the classpath. Diffs - packaging/centos63/cloud.spec 790f57b Diff: https://reviews.apache.org/r/25228/diff/ Testing --- Tested on centos 6.3 and rhel 7 Thanks, Damodar Reddy Talakanti
Review Request 25057: package.sh was failing if we don to pass -o option but pass -p option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25057/ --- Review request for cloudstack and Santhosh Edukulla. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7106 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7106 Repository: cloudstack-git Description --- In earlier patch for rhle7 build I missed out to combine another patch which was fixing the package.sh failure due to not passing -o patch but passing -p option Diffs - packaging/centos63/package.sh d239d2e Diff: https://reviews.apache.org/r/25057/diff/ Testing --- Tested on cetnos6.3 and rhel7 with noredist mode and default mode. Thanks, Damodar Reddy Talakanti
Re: Review Request 24936: RPM build failing with RHEL7
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24936/ --- (Updated Aug. 26, 2014, 5:31 a.m.) Review request for cloudstack, Rayees Namathponnan and Hugo Trippaers. Changes --- Removed extra white space that was coming in new file. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7106 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7106 Repository: cloudstack-git Description --- RPM Build was failing on RHEL7 due to the packages changed in RHEL7. Refactored the cloud.spec to make it specific to OS builds. Diffs (updated) - client/tomcatconf/server7-nonssl.xml.in PRE-CREATION client/tomcatconf/server7-ssl.xml.in PRE-CREATION packaging/centos63/cloud-management.rc 2f04793 packaging/centos63/cloud.spec 7565f95 packaging/centos63/default/macros.spec PRE-CREATION packaging/centos63/default/tomcat.sh PRE-CREATION packaging/centos63/package.sh 07f95fc packaging/centos63/rhel7/cloud-management.service PRE-CREATION packaging/centos63/rhel7/macros.spec PRE-CREATION packaging/centos63/rhel7/tomcat.sh PRE-CREATION python/lib/cloudutils/serviceConfigServer.py 2c19d7e Diff: https://reviews.apache.org/r/24936/diff/ Testing --- Tested on RHEL7 and Centos 6.3 Thanks, Damodar Reddy Talakanti
Re: Review Request 24936: RPM build failing with RHEL7
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24936/ --- (Updated Aug. 22, 2014, 11:03 a.m.) Review request for cloudstack, Rayees Namathponnan and Hugo Trippaers. Changes --- incorporated Rajani Comments to make 2 separate files for tomcat6 and tomcat7. Will remove one when we move to tomcat7 permanently. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7106 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7106 Repository: cloudstack-git Description --- RPM Build was failing on RHEL7 due to the packages changed in RHEL7. Refactored the cloud.spec to make it specific to OS builds. Diffs (updated) - client/tomcatconf/server7-nonssl.xml.in PRE-CREATION client/tomcatconf/server7-ssl.xml.in PRE-CREATION packaging/centos63/cloud-management.rc 2f04793 packaging/centos63/cloud.spec 7565f95 packaging/centos63/default/macros.spec PRE-CREATION packaging/centos63/default/tomcat.sh PRE-CREATION packaging/centos63/package.sh 07f95fc packaging/centos63/rhel7/cloud-management.service PRE-CREATION packaging/centos63/rhel7/macros.spec PRE-CREATION packaging/centos63/rhel7/tomcat.sh PRE-CREATION python/lib/cloudutils/serviceConfigServer.py 2c19d7e Diff: https://reviews.apache.org/r/24936/diff/ Testing --- Tested on RHEL7 and Centos 6.3 Thanks, Damodar Reddy Talakanti
Review Request 24936: RPM build failing with RHEL7
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24936/ --- Review request for cloudstack, Rayees Namathponnan and Hugo Trippaers. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7106 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7106 Repository: cloudstack-git Description --- RPM Build was failing on RHEL7 due to the packages changed in RHEL7. Refactored the cloud.spec to make it specific to OS builds. Diffs - client/tomcatconf/server-nonssl.xml.in 847197c client/tomcatconf/server-ssl.xml.in 37bc53d packaging/centos63/cloud-management.rc 2f04793 packaging/centos63/cloud.spec 7565f95 packaging/centos63/default/macros.spec PRE-CREATION packaging/centos63/default/tomcat.sh PRE-CREATION packaging/centos63/package.sh 07f95fc packaging/centos63/rhel7/cloud-management.service PRE-CREATION packaging/centos63/rhel7/macros.spec PRE-CREATION packaging/centos63/rhel7/tomcat.sh PRE-CREATION python/lib/cloudutils/serviceConfigServer.py 2c19d7e Diff: https://reviews.apache.org/r/24936/diff/ Testing --- Tested on RHEL7 and Centos 6.3 Thanks, Damodar Reddy Talakanti
Re: Review Request 24936: RPM build failing with RHEL7
On Aug. 22, 2014, 4:39 a.m., Rajani Karuturi wrote: client/tomcatconf/server-nonssl.xml.in, line 29 https://reviews.apache.org/r/24936/diff/1/?file=666191#file666191line29 Aren't we loosing the jmx support on tomcat6 by commenting this? As of my understanding it is to manage tomcat server(MBeans related to tomcat server) via JMX but does not eleminate JMX completely. That is why I raised the same in the community for confirmation. http://tomcat.apache.org/tomcat-6.0-doc/config/listeners.html#Server_Lifecycle_Listener_-_org.apache.catalina.mbeans.ServerLifecycleListener On Aug. 22, 2014, 4:39 a.m., Rajani Karuturi wrote: client/tomcatconf/server-nonssl.xml.in, line 143 https://reviews.apache.org/r/24936/diff/1/?file=666191#file666191line143 Was there any performance impact on tomcat6 due to this change? Dont we need separate files for tomcat6 and 7? Did not see any response delay impact. Probably my server is not heavily loaded so could not differentiate the response delays.. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24936/#review51250 --- On Aug. 21, 2014, 4:15 p.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24936/ --- (Updated Aug. 21, 2014, 4:15 p.m.) Review request for cloudstack, Rayees Namathponnan and Hugo Trippaers. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7106 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7106 Repository: cloudstack-git Description --- RPM Build was failing on RHEL7 due to the packages changed in RHEL7. Refactored the cloud.spec to make it specific to OS builds. Diffs - client/tomcatconf/server-nonssl.xml.in 847197c client/tomcatconf/server-ssl.xml.in 37bc53d packaging/centos63/cloud-management.rc 2f04793 packaging/centos63/cloud.spec 7565f95 packaging/centos63/default/macros.spec PRE-CREATION packaging/centos63/default/tomcat.sh PRE-CREATION packaging/centos63/package.sh 07f95fc packaging/centos63/rhel7/cloud-management.service PRE-CREATION packaging/centos63/rhel7/macros.spec PRE-CREATION packaging/centos63/rhel7/tomcat.sh PRE-CREATION python/lib/cloudutils/serviceConfigServer.py 2c19d7e Diff: https://reviews.apache.org/r/24936/diff/ Testing --- Tested on RHEL7 and Centos 6.3 Thanks, Damodar Reddy Talakanti
Re: Review Request 24936: RPM build failing with RHEL7
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24936/ --- (Updated Aug. 22, 2014, 5:37 a.m.) Review request for cloudstack, Rayees Namathponnan and Hugo Trippaers. Changes --- incorporated Santosh comments Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7106 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7106 Repository: cloudstack-git Description --- RPM Build was failing on RHEL7 due to the packages changed in RHEL7. Refactored the cloud.spec to make it specific to OS builds. Diffs (updated) - client/tomcatconf/server-nonssl.xml.in 847197c client/tomcatconf/server-ssl.xml.in 37bc53d packaging/centos63/cloud-management.rc 2f04793 packaging/centos63/cloud.spec 7565f95 packaging/centos63/default/macros.spec PRE-CREATION packaging/centos63/default/tomcat.sh PRE-CREATION packaging/centos63/package.sh 07f95fc packaging/centos63/rhel7/cloud-management.service PRE-CREATION packaging/centos63/rhel7/macros.spec PRE-CREATION packaging/centos63/rhel7/tomcat.sh PRE-CREATION python/lib/cloudutils/serviceConfigServer.py 2c19d7e Diff: https://reviews.apache.org/r/24936/diff/ Testing --- Tested on RHEL7 and Centos 6.3 Thanks, Damodar Reddy Talakanti
Review Request 24300: listIsos call does not return isdynamicallyscalable in the response attributes as mentioned in API docs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24300/ --- Review request for cloudstack and Kishan Kavala. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7245 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7245 Repository: cloudstack-git Description --- listIsos call does not return isdynamicallyscalable in the response attributes as mentioned in API docs Diffs - server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 4c8ada1 Diff: https://reviews.apache.org/r/24300/diff/ Testing --- Tested by calling listIsos as admin and normal user on master branch Thanks, Damodar Reddy Talakanti
Review Request 24308: Enable Password Strength check for all users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24308/ --- Review request for cloudstack and Darren Shepherd. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7249 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7249 Repository: cloudstack-git Description --- Currently Cloudstack will not return any parameter related to password strength during account/user creation. This patch will try to enable this for the end user while setting his password to know the strength of his password. The FS link for this enhancement is at : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Password+Strength+Checker+For+a+User Diffs - api/src/com/cloud/user/User.java 36e9028 api/src/com/cloud/user/UserAccount.java c5a0637 api/src/org/apache/cloudstack/api/response/AccountResponse.java 2e50c51 api/src/org/apache/cloudstack/api/response/UserResponse.java 40e1561 client/pom.xml fcd8317 core/resources/META-INF/cloudstack/core/spring-core-lifecycle-core-context-inheritable.xml 515249d core/resources/META-INF/cloudstack/core/spring-core-registry-core-context.xml 02034d6 engine/schema/src/com/cloud/user/UserAccountVO.java cef9239 engine/schema/src/com/cloud/user/UserVO.java 8ab450d plugins/pom.xml b3890c0 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java afba272 plugins/user-authenticators/md5/resources/META-INF/cloudstack/md5/spring-md5-context.xml 4a8e64d plugins/user-authenticators/md5/src/com/cloud/server/auth/MD5UserAuthenticator.java d478df6 plugins/user-authenticators/md5/test/com/cloud/server/auth/MD5UserAuthenticatorTest.java a0189e1 plugins/user-authenticators/plain-text/resources/META-INF/cloudstack/plaintext/spring-plaintext-context.xml 639411a plugins/user-authenticators/plain-text/src/com/cloud/server/auth/PlainTextUserAuthenticator.java 0afbbfc plugins/user-authenticators/sha256salted/resources/META-INF/cloudstack/sha256salted/spring-sha256salted-context.xml e379718 plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java 36305f1 plugins/user-authenticators/sha256salted/test/src/com/cloud/server/auth/test/AuthenticatorTest.java 0a9bd2f server/src/com/cloud/api/ApiResponseHelper.java 70ed47d server/src/com/cloud/server/ManagementServerImpl.java 1413272 server/src/com/cloud/server/auth/DefaultUserAuthenticator.java ea8e87b server/src/com/cloud/server/auth/UserAuthenticator.java 895c3c0 server/src/com/cloud/user/AccountManagerImpl.java 11876fa Diff: https://reviews.apache.org/r/24308/diff/ Testing --- Tested on the master branch. Tested the following scenarios 1. Enable the password checker 2. Enable the password enforce 3. Not enabled both above parameters. 4. Not putting the plugin into the deployment. Thanks, Damodar Reddy Talakanti
Re: Review Request 24308: Enable Password Strength check for all users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24308/ --- (Updated Aug. 6, 2014, 4:58 a.m.) Review request for cloudstack and Darren Shepherd. Changes --- Forgot to git add newly added files. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7249 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7249 Repository: cloudstack-git Description --- Currently Cloudstack will not return any parameter related to password strength during account/user creation. This patch will try to enable this for the end user while setting his password to know the strength of his password. The FS link for this enhancement is at : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Password+Strength+Checker+For+a+User Diffs (updated) - api/src/com/cloud/user/User.java 36e9028 api/src/com/cloud/user/UserAccount.java c5a0637 api/src/org/apache/cloudstack/api/response/AccountResponse.java 2e50c51 api/src/org/apache/cloudstack/api/response/UserResponse.java 40e1561 client/pom.xml fcd8317 core/resources/META-INF/cloudstack/core/spring-core-lifecycle-core-context-inheritable.xml 515249d core/resources/META-INF/cloudstack/core/spring-core-registry-core-context.xml 02034d6 engine/schema/src/com/cloud/user/UserAccountVO.java cef9239 engine/schema/src/com/cloud/user/UserVO.java 8ab450d plugins/pom.xml b3890c0 plugins/security/password-checker/pom.xml PRE-CREATION plugins/security/password-checker/resources/META-INF/cloudstack/password-checker/module.properties PRE-CREATION plugins/security/password-checker/resources/META-INF/cloudstack/password-checker/spring-password-checker-context.xml PRE-CREATION plugins/security/password-checker/resources/password-checker.properties PRE-CREATION plugins/security/password-checker/src/org/apache/cloudstack/security/password/PasswordCheckerImpl.java PRE-CREATION plugins/security/password-checker/test/org/apache/cloudstack/security/password/PasswordCheckerTest.java PRE-CREATION plugins/security/password-checker/test/org/apache/cloudstack/security/password/PasswordCheckerTest2.java PRE-CREATION plugins/security/password-checker/test/resources/password-checker2.properties PRE-CREATION plugins/security/password-checker/test/resources/passwordChecker2.xml PRE-CREATION plugins/security/password-checker/test/resources/spring-password-checker-context.xml PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java afba272 plugins/user-authenticators/md5/resources/META-INF/cloudstack/md5/spring-md5-context.xml 4a8e64d plugins/user-authenticators/md5/src/com/cloud/server/auth/MD5UserAuthenticator.java d478df6 plugins/user-authenticators/md5/test/com/cloud/server/auth/MD5UserAuthenticatorTest.java a0189e1 plugins/user-authenticators/plain-text/resources/META-INF/cloudstack/plaintext/spring-plaintext-context.xml 639411a plugins/user-authenticators/plain-text/src/com/cloud/server/auth/PlainTextUserAuthenticator.java 0afbbfc plugins/user-authenticators/sha256salted/resources/META-INF/cloudstack/sha256salted/spring-sha256salted-context.xml e379718 plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java 36305f1 plugins/user-authenticators/sha256salted/test/src/com/cloud/server/auth/test/AuthenticatorTest.java 0a9bd2f pom.xml 2186f83 server/src/com/cloud/api/ApiResponseHelper.java 221e266 server/src/com/cloud/server/ManagementServerImpl.java 7b5422e server/src/com/cloud/server/auth/DefaultUserAuthenticator.java ea8e87b server/src/com/cloud/server/auth/Password.java PRE-CREATION server/src/com/cloud/server/auth/UserAuthenticator.java 895c3c0 server/src/com/cloud/user/AccountManagerImpl.java 11876fa server/src/org/apache/cloudstack/security/password/PasswordChecker.java PRE-CREATION Diff: https://reviews.apache.org/r/24308/diff/ Testing --- Tested on the master branch. Tested the following scenarios 1. Enable the password checker 2. Enable the password enforce 3. Not enabled both above parameters. 4. Not putting the plugin into the deployment. Thanks, Damodar Reddy Talakanti
Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23924/ --- (Updated Aug. 4, 2014, 11:42 a.m.) Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh Edukulla. Changes --- Incorporated Murali Comments and added few more fixes from COverity scan. Repository: cloudstack-git Description --- Fixed some more Coverity reported issues in CitrixResourceBase.java. Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180 Diffs (updated) - plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 775f5455 Diff: https://reviews.apache.org/r/23924/diff/ Testing (updated) --- Ran against marvin BVT. Thanks, Damodar Reddy Talakanti
Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23924/ --- (Updated Aug. 4, 2014, 11:56 a.m.) Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Santhosh Edukulla. Changes --- Incorporated Santhosh comments Repository: cloudstack-git Description --- Fixed some more Coverity reported issues in CitrixResourceBase.java. Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180 Diffs (updated) - plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 775f5455 Diff: https://reviews.apache.org/r/23924/diff/ Testing --- Ran against marvin BVT. Thanks, Damodar Reddy Talakanti
Review Request 23915: Fixing some coverity reported issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23915/ --- Review request for cloudstack and Rajani Karuturi. Repository: cloudstack-git Description --- Fixing some coverity reported issues in CitrixResourceBase.java Diffs - plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e Diff: https://reviews.apache.org/r/23915/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Re: Review Request 23915: Fixing some coverity reported issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23915/ --- (Updated July 25, 2014, 6:10 a.m.) Review request for cloudstack, Rajani Karuturi and Santhosh Kumar. Changes --- Adding Santhosh to reviewers list Repository: cloudstack-git Description --- Fixing some coverity reported issues in CitrixResourceBase.java Diffs - plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e Diff: https://reviews.apache.org/r/23915/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Re: Review Request 23915: Fixing some coverity reported issues
On July 25, 2014, 7:05 a.m., daan Hoogland wrote: Looks ok, did you verify whether the called functions at all return null? If they don't this would seem a false positive. Your change wouldn't hurt anyhow. I checked the xen code base they are returning null values as well. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23915/#review48713 --- On July 25, 2014, 6:10 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23915/ --- (Updated July 25, 2014, 6:10 a.m.) Review request for cloudstack, Rajani Karuturi and Santhosh Kumar. Repository: cloudstack-git Description --- Fixing some coverity reported issues in CitrixResourceBase.java Diffs - plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e Diff: https://reviews.apache.org/r/23915/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Re: Review Request 23915: Fixing some coverity reported issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23915/ --- (Updated July 25, 2014, 9:12 a.m.) Review request for cloudstack, Rajani Karuturi and Santhosh Kumar. Changes --- incorporated Rajain's comments Repository: cloudstack-git Description --- Fixing some coverity reported issues in CitrixResourceBase.java Diffs (updated) - plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e Diff: https://reviews.apache.org/r/23915/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23924/ --- Review request for cloudstack, Jayapal Reddy and Rajani Karuturi. Repository: cloudstack-git Description --- Fixed some more Coverity reported issues in CitrixResourceBase.java. Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180 Diffs - plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java e961250 Diff: https://reviews.apache.org/r/23924/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Re: Review Request 23924: Fixed some more Coverity issues in CitrixResourceBase.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23924/ --- (Updated July 25, 2014, 11:21 a.m.) Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Rajani Karuturi. Changes --- Adding Murali to the reviewers Repository: cloudstack-git Description --- Fixed some more Coverity reported issues in CitrixResourceBase.java. Coverity issue ids are : 1222191, 1222186, 1222185, 1222181, 1222180 Diffs - plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java e961250 Diff: https://reviews.apache.org/r/23924/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/ --- (Updated July 22, 2014, 9:15 a.m.) Review request for cloudstack and Nitin Mehta. Changes --- Incorporated changes suggested by Nitin. Adding Kishan to the reviewers list Repository: cloudstack-git Description --- Putting the create event into event bus for addNicToVirutalMachine command explicitly as we can not use BaseAsyncCreateCommand.We can not extend this with BaseAsyncCreateCmd due to the checks we do before creating the nic. Diffs (updated) - api/src/com/cloud/event/EventTypes.java 411f620 server/src/com/cloud/vm/UserVmManagerImpl.java 90f37ef Diff: https://reviews.apache.org/r/23617/diff/ Testing --- Tested against the following setup: 1. XenServer 6.2 2. Master Branch Thanks, Damodar Reddy Talakanti
Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic
On July 17, 2014, 4:55 p.m., Nitin Mehta wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 960 https://reviews.apache.org/r/23617/diff/1/?file=634289#file634289line960 Why is it made create=true when it is not a BaseAyncCreate cmd ? create=true should be added only when its invoked through the create() method of a BaseAyncCreate cmd Damodar Reddy Talakanti wrote: We can not extend AddNicToVMCmd by BaseAsyncCreate cmd as it is doing many checks before creating the entry NIC. As it is creating entity did made create=true there. Nitin Mehta wrote: Many checks is not a problem as long as they are DB checks. Do note we make a command async generally because it is contacting the resource and can take time. If it is just DB checks I would think we can make the command BaseAsyncCreate. Also best that you review with Kishan if create=true will generate all the events (scheduled, started, completed) an async command generates Damodar Reddy Talakanti wrote: I already verified, it is generating all the above events (scheduled,started and created in the DB). It is not only issue of DB checks it is creating the entity some where deep in the flow. To bring that up we need to pull all that business logic into API create method which I though not a good idea. So just made it create=true. Nitin Mehta wrote: I understand but I guess we should do that. Giving a half baked solution will be a problem in the future. Dont you agree ? Ok Agreed, will do the changes - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/#review48016 --- On July 22, 2014, 9:15 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/ --- (Updated July 22, 2014, 9:15 a.m.) Review request for cloudstack and Nitin Mehta. Repository: cloudstack-git Description --- Putting the create event into event bus for addNicToVirutalMachine command explicitly as we can not use BaseAsyncCreateCommand.We can not extend this with BaseAsyncCreateCmd due to the checks we do before creating the nic. Diffs - api/src/com/cloud/event/EventTypes.java 411f620 server/src/com/cloud/vm/UserVmManagerImpl.java 90f37ef Diff: https://reviews.apache.org/r/23617/diff/ Testing --- Tested against the following setup: 1. XenServer 6.2 2. Master Branch Thanks, Damodar Reddy Talakanti
Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/ --- (Updated July 22, 2014, 9:16 a.m.) Review request for cloudstack, Kishan Kavala and Nitin Mehta. Repository: cloudstack-git Description --- Putting the create event into event bus for addNicToVirutalMachine command explicitly as we can not use BaseAsyncCreateCommand.We can not extend this with BaseAsyncCreateCmd due to the checks we do before creating the nic. Diffs - api/src/com/cloud/event/EventTypes.java 411f620 server/src/com/cloud/vm/UserVmManagerImpl.java 90f37ef Diff: https://reviews.apache.org/r/23617/diff/ Testing --- Tested against the following setup: 1. XenServer 6.2 2. Master Branch Thanks, Damodar Reddy Talakanti
Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/ --- (Updated July 22, 2014, 12:35 p.m.) Review request for cloudstack, Kishan Kavala and Nitin Mehta. Repository: cloudstack-git Description --- Putting the create event into event bus for addNicToVirutalMachine command explicitly as we can not use BaseAsyncCreateCommand.We can not extend this with BaseAsyncCreateCmd due to the checks we do before creating the nic. Diffs (updated) - api/src/com/cloud/event/EventTypes.java 411f620 server/src/com/cloud/vm/UserVmManagerImpl.java 90f37ef Diff: https://reviews.apache.org/r/23617/diff/ Testing --- Tested against the following setup: 1. XenServer 6.2 2. Master Branch Thanks, Damodar Reddy Talakanti
Review Request 23723: Added the extra space in the error message which was having readability issue.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23723/ --- Review request for cloudstack and Santhosh Edukulla. Repository: cloudstack-git Description --- Added the extra space in the error message which was having readability issue. Diffs - api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java 90aed5e Diff: https://reviews.apache.org/r/23723/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Re: Review Request 23723: Added the extra space in the error message which was having readability issue.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23723/ --- (Updated July 21, 2014, 4:59 a.m.) Review request for cloudstack and Santhosh Edukulla. Changes --- added defect id Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7142 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7142 Repository: cloudstack-git Description --- Added the extra space in the error message which was having readability issue. Diffs - api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java 90aed5e Diff: https://reviews.apache.org/r/23723/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Re: Review Request 23723: Added the extra space in the error message which was having readability issue.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23723/ --- (Updated July 21, 2014, 5 a.m.) Review request for cloudstack and Santhosh Edukulla. Changes --- added defect id Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7142 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7142 Repository: cloudstack-git Description --- Added the extra space in the error message which was having readability issue. Diffs - api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java 90aed5e Diff: https://reviews.apache.org/r/23723/diff/ Testing --- Thanks, Damodar Reddy Talakanti
Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic
On July 17, 2014, 4:55 p.m., Nitin Mehta wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 960 https://reviews.apache.org/r/23617/diff/1/?file=634289#file634289line960 Why is it made create=true when it is not a BaseAyncCreate cmd ? create=true should be added only when its invoked through the create() method of a BaseAyncCreate cmd Damodar Reddy Talakanti wrote: We can not extend AddNicToVMCmd by BaseAsyncCreate cmd as it is doing many checks before creating the entry NIC. As it is creating entity did made create=true there. Nitin Mehta wrote: Many checks is not a problem as long as they are DB checks. Do note we make a command async generally because it is contacting the resource and can take time. If it is just DB checks I would think we can make the command BaseAsyncCreate. Also best that you review with Kishan if create=true will generate all the events (scheduled, started, completed) an async command generates I already verified, it is generating all the above events (scheduled,started and created in the DB). It is not only issue of DB checks it is creating the entity some where deep in the flow. To bring that up we need to pull all that business logic into API create method which I though not a good idea. So just made it create=true. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/#review48016 --- On July 17, 2014, 4:43 p.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/ --- (Updated July 17, 2014, 4:43 p.m.) Review request for cloudstack and Nitin Mehta. Repository: cloudstack-git Description --- Putting the create event into event bus for addNicToVirutalMachine command explicitly as we can not use BaseAsyncCreateCommand.We can not extend this with BaseAsyncCreateCmd due to the checks we do before creating the nic. Diffs - api/src/com/cloud/event/EventTypes.java 71bfdb6 server/src/com/cloud/vm/UserVmManagerImpl.java d0bc186 Diff: https://reviews.apache.org/r/23617/diff/ Testing --- Tested against the following setup: 1. XenServer 6.2 2. Master Branch Thanks, Damodar Reddy Talakanti
Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic
On July 17, 2014, 4:55 p.m., Nitin Mehta wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 960 https://reviews.apache.org/r/23617/diff/1/?file=634289#file634289line960 Why is it made create=true when it is not a BaseAyncCreate cmd ? create=true should be added only when its invoked through the create() method of a BaseAyncCreate cmd We can not extend AddNicToVMCmd by BaseAsyncCreate cmd as it is doing many checks before creating the entry NIC. As it is creating entity did made create=true there. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/#review48016 --- On July 17, 2014, 4:43 p.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/ --- (Updated July 17, 2014, 4:43 p.m.) Review request for cloudstack and Nitin Mehta. Repository: cloudstack-git Description --- Putting the create event into event bus for addNicToVirutalMachine command explicitly as we can not use BaseAsyncCreateCommand.We can not extend this with BaseAsyncCreateCmd due to the checks we do before creating the nic. Diffs - api/src/com/cloud/event/EventTypes.java 71bfdb6 server/src/com/cloud/vm/UserVmManagerImpl.java d0bc186 Diff: https://reviews.apache.org/r/23617/diff/ Testing --- Tested against the following setup: 1. XenServer 6.2 2. Master Branch Thanks, Damodar Reddy Talakanti
Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- (Updated July 3, 2014, 10:22 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Changes --- Ignored readme.txt from rat build Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 Repository: cloudstack-git Description --- Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc.. Diffs (updated) - client/pom.xml 29fef4f pom.xml 0b3b56e scripts/installer/windows/ExitDialog.wxs PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs 0282d8a scripts/installer/windows/acs.wxs bf09afc scripts/installer/windows/dependencies.wxs 987c561 scripts/installer/windows/en-us.wxl 2f34575 scripts/installer/windows/optionstheme_en-us.wxl c822929 scripts/installer/windows/readme.txt PRE-CREATION Diff: https://reviews.apache.org/r/23192/diff/ Testing --- Tested on Windows 2012 Server Thanks, Damodar Reddy Talakanti
Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- (Updated July 3, 2014, 11:58 a.m.) Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 Repository: cloudstack-git Description --- Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc.. Diffs - client/pom.xml 29fef4f pom.xml 0b3b56e scripts/installer/windows/ExitDialog.wxs PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs 0282d8a scripts/installer/windows/acs.wxs bf09afc scripts/installer/windows/dependencies.wxs 987c561 scripts/installer/windows/en-us.wxl 2f34575 scripts/installer/windows/optionstheme_en-us.wxl c822929 scripts/installer/windows/readme.txt PRE-CREATION Diff: https://reviews.apache.org/r/23192/diff/ Testing --- Tested on Windows 2012 Server Thanks, Damodar Reddy Talakanti
Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote: I'm not sure we can actually have a dependency on the mysql connector like this because of it's GPL license. I'll check this and get back on this before we can accept this patch. Koushik Das wrote: Hugo, I committed this patch (on master ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this comment from you. If there is going to be a license issue then please feel free to revert. Hugo, We are not packaging the connector with MSI, indeed we are downloading it from the Internet during installation similar to Linux environments. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/#review47289 --- On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- (Updated July 3, 2014, 11:58 a.m.) Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 Repository: cloudstack-git Description --- Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc.. Diffs - client/pom.xml 29fef4f pom.xml 0b3b56e scripts/installer/windows/ExitDialog.wxs PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs 0282d8a scripts/installer/windows/acs.wxs bf09afc scripts/installer/windows/dependencies.wxs 987c561 scripts/installer/windows/en-us.wxl 2f34575 scripts/installer/windows/optionstheme_en-us.wxl c822929 scripts/installer/windows/readme.txt PRE-CREATION Diff: https://reviews.apache.org/r/23192/diff/ Testing --- Tested on Windows 2012 Server Thanks, Damodar Reddy Talakanti
Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- (Updated July 2, 2014, 12:29 p.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 Repository: cloudstack-git Description (updated) --- Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc.. Diffs - client/pom.xml 29fef4f scripts/installer/windows/ExitDialog.wxs PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs 0282d8a scripts/installer/windows/acs.wxs bf09afc scripts/installer/windows/dependencies.wxs 987c561 scripts/installer/windows/en-us.wxl 2f34575 scripts/installer/windows/optionstheme_en-us.wxl c822929 scripts/installer/windows/readme.txt PRE-CREATION Diff: https://reviews.apache.org/r/23192/diff/ Testing --- Tested on Windows 2012 Server Thanks, Damodar Reddy Talakanti
Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 Repository: cloudstack-git Description --- Incorporated some feed back items. Diffs - client/pom.xml 29fef4f scripts/installer/windows/ExitDialog.wxs PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs 0282d8a scripts/installer/windows/acs.wxs bf09afc scripts/installer/windows/dependencies.wxs 987c561 scripts/installer/windows/en-us.wxl 2f34575 scripts/installer/windows/optionstheme_en-us.wxl c822929 scripts/installer/windows/readme.txt PRE-CREATION Diff: https://reviews.apache.org/r/23192/diff/ Testing --- Tested on Windows 2012 Server Thanks, Damodar Reddy Talakanti
Review Request 22865: [Automation] test_01_primary_storage_iscsi failed on test_primary_storage.py - Wrong iscsi path format - it should be /targetIQN/LUN
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22865/ --- Review request for cloudstack, daan Hoogland and Koushik Das. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6444 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6444 Repository: cloudstack-git Description --- Due to the changes done to fix the findbug tool issues, we introduced the iSCSI path format issue by replacing the first / with empty string. Fixed the same by removing the replacement string part. Diffs - plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java 3c1b76a Diff: https://reviews.apache.org/r/22865/diff/ Testing --- Tested with iSCSI primary storage with XenServer Thanks, Damodar Reddy Talakanti
Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/ --- (Updated June 18, 2014, 6:50 a.m.) Review request for cloudstack, edison su, Koushik Das, and Min Chen. Changes --- Commit message changes to explicitly mention that changes are related to XenServer/NFS only. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636 Repository: cloudstack-git Description --- Due to File.separator on windows machine the template creation from snapshot is failing as it has mis-matched path separator which is windows path separator(\). Fixed the same by adding getPathSeparator() method to DataStoreTO.java and all it's implementations. Diffs (updated) - api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 api/src/com/cloud/agent/api/to/S3TO.java f64fe35 api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java e96ebf4 Diff: https://reviews.apache.org/r/22510/diff/ Testing --- Tested on Windows 2012 R2 server and on centos. Tested the following use cases. 1. Attach ISO 2. Detach ISO 3. Snapshot creation from root disk 4. Snapshot creation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti
Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/ --- (Updated June 18, 2014, 9:41 a.m.) Review request for cloudstack, edison su, Koushik Das, and Min Chen. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636 Repository: cloudstack-git Description --- Due to File.separator on windows machine the template creation from snapshot is failing as it has mis-matched path separator which is windows path separator(\). Fixed the same by adding getPathSeparator() method to DataStoreTO.java and all it's implementations. Diffs (updated) - api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 api/src/com/cloud/agent/api/to/S3TO.java f64fe35 api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java e96ebf4 Diff: https://reviews.apache.org/r/22510/diff/ Testing --- Tested on Windows 2012 R2 server and on centos. Tested the following use cases. 1. Attach ISO 2. Detach ISO 3. Snapshot creation from root disk 4. Snapshot creation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti
Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/ --- (Updated June 17, 2014, 6:34 a.m.) Review request for cloudstack, edison su, Koushik Das, and Min Chen. Changes --- Incorporated review comments from Koushik Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636 Repository: cloudstack-git Description --- Due to File.separator on windows machine the template creation from snapshot is failing as it has mis-matched path separator which is windows path separator(\). Fixed the same by adding getPathSeparator() method to DataStoreTO.java and all it's implementations. Diffs (updated) - api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 api/src/com/cloud/agent/api/to/S3TO.java f64fe35 api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java 9c86fbe Diff: https://reviews.apache.org/r/22510/diff/ Testing --- Tested on Windows 2012 R2 server and on centos. Tested the following use cases. 1. Attach ISO 2. Detach ISO 3. Snapshot creation from root disk 4. Snapshot creation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti
Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java
On June 16, 2014, 6:04 a.m., Koushik Das wrote: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java, line 296 https://reviews.apache.org/r/22510/diff/1/?file=608108#file608108line296 Will data.getPath() return a path with proper separator? Yes what ever we store in the install_path column of *_store_ref tables. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/#review45720 --- On June 17, 2014, 6:34 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/ --- (Updated June 17, 2014, 6:34 a.m.) Review request for cloudstack, edison su, Koushik Das, and Min Chen. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636 Repository: cloudstack-git Description --- Due to File.separator on windows machine the template creation from snapshot is failing as it has mis-matched path separator which is windows path separator(\). Fixed the same by adding getPathSeparator() method to DataStoreTO.java and all it's implementations. Diffs - api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 api/src/com/cloud/agent/api/to/S3TO.java f64fe35 api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java 9c86fbe Diff: https://reviews.apache.org/r/22510/diff/ Testing --- Tested on Windows 2012 R2 server and on centos. Tested the following use cases. 1. Attach ISO 2. Detach ISO 3. Snapshot creation from root disk 4. Snapshot creation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti
Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java
On June 16, 2014, 6:04 a.m., Koushik Das wrote: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java, line 1407 https://reviews.apache.org/r/22510/diff/1/?file=608108#file608108line1407 Is the intent to replace all occurrences of File.Separator? I still see this one left out. Also please open a bug to track changes to other HVs. Yes intention is to remove all File.separator. Did not change that because that is related to Swift storage which I did not touch. These changes are for NFS only. Will fix this when doing changes for Swift. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/#review45720 --- On June 12, 2014, 12:32 p.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/ --- (Updated June 12, 2014, 12:32 p.m.) Review request for cloudstack, edison su, Koushik Das, and Min Chen. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636 Repository: cloudstack-git Description --- Due to File.separator on windows machine the template creation from snapshot is failing as it has mis-matched path separator which is windows path separator(\). Fixed the same by adding getPathSeparator() method to DataStoreTO.java and all it's implementations. Diffs - api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 api/src/com/cloud/agent/api/to/S3TO.java f64fe35 api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java 9c86fbe Diff: https://reviews.apache.org/r/22510/diff/ Testing --- Tested on Windows 2012 R2 server and on centos. Tested the following use cases. 1. Attach ISO 2. Detach ISO 3. Snapshot creation from root disk 4. Snapshot creation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti
Re: Review Request 22453: [windows]Adding prot fields to the database creation wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22453/ --- (Updated June 12, 2014, 6:58 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 Repository: cloudstack-git Description --- We also need to collect port information from the admin while collecting database information from the admin as part of windows installer.Changes are done to fix this. Diffs - scripts/installer/windows/Setup_Databases.wxs 0254c61 scripts/installer/windows/acs.wxs 83bac54 scripts/installer/windows/en-us.wxl b5a98ec Diff: https://reviews.apache.org/r/22453/diff/ Testing --- Tested it on windows 2012 R2 Server as well as Centos server Thanks, Damodar Reddy Talakanti
Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/ --- Review request for cloudstack, edison su, Koushik Das, and Min Chen. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636 Repository: cloudstack-git Description --- Due to File.separator on windows machine the template creation from snapshot is failing as it has mis-matched path separator which is windows path separator(\). Fixed the same by adding getPathSeparator() method to DataStoreTO.java and all it's implementations. Diffs - api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 api/src/com/cloud/agent/api/to/S3TO.java f64fe35 api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java 9c86fbe Diff: https://reviews.apache.org/r/22510/diff/ Testing --- Tested on Windows 2012 R2 server and on centos. Tested the following use cases. 1. Attach ISO 2. Detach ISO 3. Snapshot creation from root disk 4. Snapshot creation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti
Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/#review45488 --- These changes are only for Xenserver. For Remaining hypervisors the fix will be done when we touch them. - Damodar Reddy Talakanti On June 12, 2014, 12:32 p.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22510/ --- (Updated June 12, 2014, 12:32 p.m.) Review request for cloudstack, edison su, Koushik Das, and Min Chen. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636 Repository: cloudstack-git Description --- Due to File.separator on windows machine the template creation from snapshot is failing as it has mis-matched path separator which is windows path separator(\). Fixed the same by adding getPathSeparator() method to DataStoreTO.java and all it's implementations. Diffs - api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 api/src/com/cloud/agent/api/to/S3TO.java f64fe35 api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java 9c86fbe Diff: https://reviews.apache.org/r/22510/diff/ Testing --- Tested on Windows 2012 R2 server and on centos. Tested the following use cases. 1. Attach ISO 2. Detach ISO 3. Snapshot creation from root disk 4. Snapshot creation from data disk 5. volume creation from (3) 6. template creation from(3) 7. Launch a VM after registering new template. Thanks, Damodar Reddy Talakanti
Review Request 22453: [windows]Adding prot fields to the database creation wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22453/ --- Review request for cloudstack, Abhinandan Prateek and Murali Reddy. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834 Repository: cloudstack-git Description --- We also need to collect port information from the admin while collecting database information from the admin as part of windows installer.Changes are done to fix this. Diffs - scripts/installer/windows/Setup_Databases.wxs 0254c61 scripts/installer/windows/acs.wxs 83bac54 scripts/installer/windows/en-us.wxl b5a98ec Diff: https://reviews.apache.org/r/22453/diff/ Testing --- Tested it on windows 2012 R2 Server as well as Centos server Thanks, Damodar Reddy Talakanti
Review Request 22260: [Windows] Due to progress bar changes mysql bin path was not getting read from the Path environment variable, fixing the same
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22260/ --- Review request for cloudstack, Abhinandan Prateek and Murali Reddy. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6702 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6702 Repository: cloudstack-git Description --- While doing changes to enable progress bar messages during msi installation, we changed the Action Execute to deferred mode which will not read the latest changes done to environment variables. this was causing not to execute mysql files. Fixed the same issue Diffs - scripts/installer/windows/acs.wxs 58af650 setup/bindir/cloud-setup-databases.in d9dc54f Diff: https://reviews.apache.org/r/22260/diff/ Testing --- Testing is done on Windows R2 Server as well as Linux environments. Thanks, Damodar Reddy Talakanti
Review Request 22126: [Windows]Integrate SystemSeed Template into installer and add progress bar messages to the installer so that admin can aware of changes happening to the system
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22126/ --- Review request for cloudstack, Abhinandan Prateek and Murali Reddy. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6701 and https://issues.apache.org/jira/browse/CLOUDSTACK-6702 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6701 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6702 Repository: cloudstack-git Description --- 1. Integrate System Seed Template into MSI Installer 2. Give necessary progress bar messages to admin before changing the system properties like environment varibales, firewall rules etc.. 3. Move all titles and descriptions to a property file or move to build properties Diffs - client/pom.xml c55d5b7 scripts/installer/windows/WixInstallerDialog.wxs b0f510b scripts/installer/windows/acs.wxs 8206afa scripts/installer/windows/en-us.wxl b43393c scripts/storage/secondary/cloud-install-sys-tmplt.py PRE-CREATION Diff: https://reviews.apache.org/r/22126/diff/ Testing --- Tested On Windows 2012 R2 Server Thanks, Damodar Reddy Talakanti
Review Request 21900: [Windows] Move all titles and descriptions to a property file or move to build properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21900/ --- Review request for cloudstack, Abhinandan Prateek and Murali Reddy. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6702 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6702 Repository: cloudstack-git Description --- Move all text that is getting displayed on the installation wizard to a wix language files so that we can change texts later Diffs - client/pom.xml 6d895ce scripts/installer/windows/Setup_Databases.wxs f4e8fa1 scripts/installer/windows/acs.wxs 84045c5 scripts/installer/windows/dependencies.wxs 82fcd27 scripts/installer/windows/en-us.wxl PRE-CREATION scripts/installer/windows/optionstheme.xml 527309f scripts/installer/windows/optionstheme_en-us.wxl PRE-CREATION Diff: https://reviews.apache.org/r/21900/diff/ Testing --- Tested on windows 2012 R2 server Thanks, Damodar Reddy Talakanti
Review Request 21763: [Windows]Give Option to install or not MySql Server along with Main Installer on the same server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21763/ --- Review request for cloudstack, Abhinandan Prateek and Murali Reddy. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6700 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6700 Repository: cloudstack-git Description --- Currently we are installing mysql server on the same host where management server was getting installed. And there is no choice to install the database server on the other machine. We are enabling an option to choose, whether mysql server to be installed locally to management server or not. Diffs - client/pom.xml b3d857d scripts/installer/windows/acs.wxs 411d026 scripts/installer/windows/dependencies.wxs 56ea2a4 Diff: https://reviews.apache.org/r/21763/diff/ Testing --- Tested on windows 2012 R2 server Thanks, Damodar Reddy Talakanti
Review Request 21621: Adding Setup tools for Python is integrated into Windows msi isntaller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21621/ --- Review request for cloudstack, Abhinandan Prateek and Murali Reddy. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6563 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6563 Repository: cloudstack-git Description --- Earlier Setup tools need to install separately onto python after Cloud stack installation on windows. To avoid this we integrated setup tools integration into windows msi installer Diffs - client/pom.xml a77c70b scripts/installer/windows/acs.wxs 1c100e8 Diff: https://reviews.apache.org/r/21621/diff/ Testing --- testing is done on windwos 2012 R2 server Thanks, Damodar Reddy Talakanti
Review Request 21155: [Windows]Integrate dependencies into MSI Windows installer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21155/ --- Review request for cloudstack, Abhinandan Prateek and Murali Reddy. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6563 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6563 Repository: cloudstack-git Description --- Trying to add dependencies installation along with Cloud Stack installation as part of EXE. This will install needed dependencies for cloud stack like tomcat, python, cdrtools etc... Diffs - client/pom.xml e30d97b pom.xml ecae71a scripts/common/keys/ssl-keys.py 4ef50b0 scripts/installer/windows/acs.wxs 150c472 scripts/installer/windows/acs_license.rtf PRE-CREATION scripts/installer/windows/dependencies.wxs PRE-CREATION Diff: https://reviews.apache.org/r/21155/diff/ Testing --- These changes are specific windows files so tested on windows 2012 R2 server Thanks, Damodar Reddy Talakanti
Review Request 20774: Fixing some minor issues in cloud-setup-databases script and acs.wxs scripts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20774/ --- Review request for cloudstack, Abhinandan Prateek, Frank Zhang, and Murali Reddy. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271 Repository: cloudstack-git Description --- Especially on windows When you install cloud stack at the patch where your path contains white spaces in it then cloud-setup-databases is failing due to the white spaces in the path. Fixed this issue. Also missed copying python lib to Python install path/Lib/site-packages. Fixed this issue as well. Diffs - client/pom.xml 5038e66 scripts/installer/windows/acs.wxs f959f1c setup/bindir/cloud-setup-databases.in dd22e56 Diff: https://reviews.apache.org/r/20774/diff/ Testing --- Tested it on windows 2012 R2 server. Tested python script on linux environment as well for the following 2 cases 1. Having spaces in the path 2. not having spaces in the path. Thanks, Damodar Reddy Talakanti
Re: Review Request 20443: Integrate Deploy DB Into windows msi installer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20443/ --- (Updated April 24, 2014, 4:35 p.m.) Review request for cloudstack, Abhinandan Prateek, Frank Zhang, and Koushik Das. Changes --- Added Frank to the reviewer's list Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271 Repository: cloudstack-git Description --- Currently MSI Installer assumes that the back end DB is already created. But going further deploy db should be part of installation instead of assumption. of existence Diffs - Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 9bfe382 client/pom.xml aee2672 scripts/installer/windows/Setup_Databases.wxs PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs PRE-CREATION scripts/installer/windows/acs.wxs 0e7dea7 Diff: https://reviews.apache.org/r/20443/diff/ Testing --- Tested against Windows 2008 R2 server as changes are related to build process. Thanks, Damodar Reddy Talakanti
Re: Review Request 20445: Add new Command line options to setup/bindir/cloud-setup-databases.in and remove OS specific commands
On April 18, 2014, 7:33 p.m., Frank Zhang wrote: This script is very old it really needs some improvement, thanks for the patch. Here are some my thoughts: 1. instead of calling socket.gethostbyname, can we handle the case where the machine has multiple nics? the ip will be used as node ip in multiple management server nodes environment, it would be nice to have an option that admin can specify the ip, if they don't, by default the script should automatically find ip of nic for default route. Yes the old code doesn't handle this, as you are improving it we should take this chance to make it further. 2. I see there are some new options, but it seems they are not used in code? For (1) I can add a command line option right now but to handle multiple nics case I can file a defect and will track it further as I can not finish that currently. For (2) I in case of new options I have over ridden existing variables which has default values, if those options are passed. These are not completely new options. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20445/#review40804 --- On April 17, 2014, 9:41 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20445/ --- (Updated April 17, 2014, 9:41 a.m.) Review request for cloudstack, Alex Huang, Frank Zhang, and Hugo Trippaers. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6435 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6435 Repository: cloudstack-git Description --- Currently the python script setup/bindir/cloud-setup-databases.in for setup databases uses template based parameters which will get replaced during rpm build. Along with this also enable new command line options to over ride those template based parameters if the same get passed as command line options. Accept the following options: 1. db-conf-path 2. db-files-path 3. encryption-jar-path 4. encryption-key-file Also replace code that calls OS specific commands with python specific libraries. Diffs - setup/bindir/cloud-setup-databases.in 2ba7d51 Diff: https://reviews.apache.org/r/20445/diff/ Testing --- Tested the script on both windows and linux environment Tested for the following scenarios 1. With out passing new options on linux environment 2. With passing new options on linux environment 3. With passing new options on windows environment 4. With out passing new options on windows environment (Script fails here as there are no replacements happened for template parameters during build) Thanks, Damodar Reddy Talakanti
Review Request 20445: Add new Command line options to setup/bindir/cloud-setup-databases.in and remove OS specific commands
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20445/ --- Review request for cloudstack, Alex Huang, Frank Zhang, and Hugo Trippaers. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6435 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6435 Repository: cloudstack-git Description --- Currently the python script setup/bindir/cloud-setup-databases.in for setup databases uses template based parameters which will get replaced during rpm build. Along with this also enable new command line options to over ride those template based parameters if the same get passed as command line options. Accept the following options: 1. db-conf-path 2. db-files-path 3. encryption-jar-path 4. encryption-key-file Also replace code that calls OS specific commands with python specific libraries. Diffs - setup/bindir/cloud-setup-databases.in 2ba7d51 Diff: https://reviews.apache.org/r/20445/diff/ Testing --- Tested the script on both windows and linux environment Tested for the following scenarios 1. With out passing new options on linux environment 2. With passing new options on linux environment 3. With passing new options on windows environment 4. With out passing new options on windows environment (Script fails here as there are no replacements happened for template parameters during build) Thanks, Damodar Reddy Talakanti
Re: Review Request 20443: Integrate Deploy DB Into windows msi installer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20443/ --- (Updated April 18, 2014, 4:48 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Changes --- Moved changes to cloud-setup-databases to a separate defect Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271 Repository: cloudstack-git Description --- Currently MSI Installer assumes that the back end DB is already created. But going further deploy db should be part of installation instead of assumption. of existence Diffs (updated) - Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 9bfe382 client/pom.xml aee2672 scripts/installer/windows/Setup_Databases.wxs PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs PRE-CREATION scripts/installer/windows/acs.wxs 0e7dea7 Diff: https://reviews.apache.org/r/20443/diff/ Testing --- Tested against Windows 2008 R2 server as changes are related to build process. Thanks, Damodar Reddy Talakanti
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated April 16, 2014, 9:52 a.m.) Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan Hoogland, and Donal Lafferty. Changes --- License headers were missing added the same. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs (updated) - Wix-cloudstack-maven-plugin/pom.xml e5b9bd1 Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 4724d76 Diff: https://reviews.apache.org/r/18964/diff/ Testing --- Tested in Linux environment after changes Also tested in Windows environment(For now tested on windows-8) to make sure it is getting installed and management service is running. Able to add zones, able to register templates, able to launch a VM when it is running on windows. Currently though it is getting added as a windows service, not able to start the service through windows service control manager which I am looking into currently. When run .exe file which is installed then server is getting up and able to access cloud stack UI. For now The following assumptions are made: 1. SSH keys are already installed 2. JAVA is already installed 3. tomcat is already installed This patch contains the following new files related to WiX tool (To compile and run we need this tool) 1. acs.wxs The following command will be used to compile Path To WiX Tool\bin\candle.exe acs.wxs 2. client.wxs The following command will be used to generate the above file Path To WiX Tool\bin\heat dir client -gg -cg Test -ke -sfrag -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS The following command will be used to compile the above generated file Path To WiX Tool\bin\candle.exe client.wxs 3. The following command will be used to generate .msi file Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi -ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti
Re: Review Request 20366: Integrating Windows wix tool to maven
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20366/ --- (Updated April 16, 2014, 9:57 a.m.) Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Changes --- Added missing license header files Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6410 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6410 Repository: cloudstack-git Description --- Integrated Wix tool set with maven build process so that no manual steps are required to create windows msi installer file. Diffs (updated) - Wix-cloudstack-maven-plugin/pom.xml e5b9bd1 Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 4724d76 Diff: https://reviews.apache.org/r/20366/diff/ Testing --- Build process has been Tested on Windows server. Regular profile Builds are tested Tested new profile buildw and verified msi file is getting created in target. Thanks, Damodar Reddy Talakanti
Re: Review Request 20366: Integrating Windows wix tool to maven
On April 15, 2014, 11:39 a.m., daan Hoogland wrote: please test on other platforms to make sure it doesn't break non-windows builds Sure Daan will do that - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20366/#review40380 --- On April 16, 2014, 9:57 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20366/ --- (Updated April 16, 2014, 9:57 a.m.) Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6410 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6410 Repository: cloudstack-git Description --- Integrated Wix tool set with maven build process so that no manual steps are required to create windows msi installer file. Diffs - Wix-cloudstack-maven-plugin/pom.xml e5b9bd1 Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 4724d76 Diff: https://reviews.apache.org/r/20366/diff/ Testing --- Build process has been Tested on Windows server. Regular profile Builds are tested Tested new profile buildw and verified msi file is getting created in target. Thanks, Damodar Reddy Talakanti
Review Request 20443: Integrate Deploy DB Into windows msi installer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20443/ --- Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271 Repository: cloudstack-git Description --- Currently MSI Installer assumes that the back end DB is already created. But going further deploy db should be part of installation instead of assumption. of existence Diffs - Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 9bfe382 client/pom.xml aee2672 scripts/database/cloudstack-setup-databases PRE-CREATION scripts/installer/windows/Setup_Databases.wxs PRE-CREATION scripts/installer/windows/WixInstallerDialog.wxs PRE-CREATION scripts/installer/windows/acs.wxs 0e7dea7 Diff: https://reviews.apache.org/r/20443/diff/ Testing --- Tested against Windows 2008 R2 server as changes are related to build process. Thanks, Damodar Reddy Talakanti
Review Request 20366: Integrating Windows wix tool to maven
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20366/ --- Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6410 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6410 Repository: cloudstack-git Description --- Integrated Wix tool set with maven build process so that no manual steps are required to create windows msi installer file. Diffs - Wix-cloudstack-maven-plugin/pom.xml PRE-CREATION Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java PRE-CREATION client/pom.xml d8dbde7 Diff: https://reviews.apache.org/r/20366/diff/ Testing --- Build process has been Tested on Windows server. Regular profile Builds are tested Tested new profile buildw and verified msi file is getting created in target. Thanks, Damodar Reddy Talakanti
Review Request 20367: If already tmp directory exist inject Keys is failing while starting management server on windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20367/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6298 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6298 Repository: cloudstack-git Description --- For any reason if tmp directory present on windows users home directory the inject keys into system vm is failing on management server start up. Diffs - scripts/vm/systemvm/injectkeys.py bd840f9 Diff: https://reviews.apache.org/r/20367/diff/ Testing --- Tested on windows 2008 server on fresh setup Thanks, Damodar Reddy Talakanti
Review Request 20152: In com.cloud.utils.crypt.EncryptionSecretKeyChecker the key file paths are hard coded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20152/ --- Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6354 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6354 Repository: cloudstack-git Description --- In com.cloud.utils.crypt.EncryptionSecretKeyChecker the key file paths are hard coded to /etc/cloudstack/management/key which will cause issue if key generation path gets changes during installation time. Diffs - utils/src/com/cloud/utils/crypt/EncryptionSecretKeyChecker.java 0e995c4 utils/test/com/cloud/utils/crypto/EncryptionSecretKeyCheckerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/20152/diff/ Testing --- Tested with enabling ecnryption. Thanks, Damodar Reddy Talakanti
Review Request 19780: [Windows] Check dependencies are installed or not through registry instead of environment variables
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19780/ --- Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6291 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6291 Repository: cloudstack-git Description --- Previously we were checking environment variables to decide the needed dependencies are installed or not. This will some extra effort to the admin to set them before start installation of ACS. So removed that dependency and checking through registry to verify the same. Diffs - scripts/installer/windows/acs.wxs 9456a5a Diff: https://reviews.apache.org/r/19780/diff/ Testing --- Tested on windows 2008R2 instance. Tested for the following use cases 1. Java is not installed 2. tomcat is not installed 3. 7z is not installed. Thanks, Damodar Reddy Talakanti
Review Request 19717: [Windows] enabled the SSL key generation part in windows installer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19717/ --- Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6290 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6290 Repository: cloudstack-git Description --- Added the functionality to the installer to be able to generate SSL keys for the first time when we are installing on windows. Diffs - scripts/common/keys/ssl-keys.py PRE-CREATION scripts/installer/windows/acs.wxs adb2b6c Diff: https://reviews.apache.org/r/19717/diff/ Testing --- Tested on windows 2008R2 server environment to make sure cloud.keystore is getting generated at desired place. Thanks, Damodar Reddy Talakanti
Re: Review Request 19604: [Windowsfication] fixing log issues on windows
On March 26, 2014, 5:59 a.m., Rajani Karuturi wrote: scripts/installer/windows/acs.wxs, line 202 https://reviews.apache.org/r/19604/diff/1/?file=535170#file535170line202 a mix of '//' and '\' is used. If possible, use one //US/Tomcat6 is not the file path.It is the type of argument expected by tomcat6.exe to update the service parameters. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19604/#review38578 --- On March 25, 2014, 11:33 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19604/ --- (Updated March 25, 2014, 11:33 a.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- After Windowsfication logs were not getting generated properly on windows. Fixed the same by updating tomcat's properties in MSI installer Diffs - scripts/installer/windows/acs.wxs 7967478 Diff: https://reviews.apache.org/r/19604/diff/ Testing --- As changes are related to windows tested whether log files are getting generated or not in windows. Thanks, Damodar Reddy Talakanti
Re: Review Request 19717: [Windows] enabled the SSL key generation part in windows installer
On March 27, 2014, 10:23 a.m., Abhinandan Prateek wrote: It depends on pre-installed Java. DO we check early on in the installer if java SDK is installed ? Yes if JAVA_HOME is not set the installation will fail. Probably later, if possible I will check registry instead of relying on JAVA_HOME environment variable. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19717/#review38712 --- On March 27, 2014, 6:55 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19717/ --- (Updated March 27, 2014, 6:55 a.m.) Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6290 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6290 Repository: cloudstack-git Description --- Added the functionality to the installer to be able to generate SSL keys for the first time when we are installing on windows. Diffs - scripts/common/keys/ssl-keys.py PRE-CREATION scripts/installer/windows/acs.wxs adb2b6c Diff: https://reviews.apache.org/r/19717/diff/ Testing --- Tested on windows 2008R2 server environment to make sure cloud.keystore is getting generated at desired place. Thanks, Damodar Reddy Talakanti
Re: Review Request 19717: [Windows] enabled the SSL key generation part in windows installer
On March 27, 2014, 10:23 a.m., Abhinandan Prateek wrote: It depends on pre-installed Java. DO we check early on in the installer if java SDK is installed ? Damodar Reddy Talakanti wrote: Yes if JAVA_HOME is not set the installation will fail. Probably later, if possible I will check registry instead of relying on JAVA_HOME environment variable. Abhinandan Prateek wrote: Please, file a bug for that. created a defect for this at https://issues.apache.org/jira/browse/CLOUDSTACK-6291 - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19717/#review38712 --- On March 27, 2014, 6:55 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19717/ --- (Updated March 27, 2014, 6:55 a.m.) Review request for cloudstack, Abhinandan Prateek and daan Hoogland. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6290 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6290 Repository: cloudstack-git Description --- Added the functionality to the installer to be able to generate SSL keys for the first time when we are installing on windows. Diffs - scripts/common/keys/ssl-keys.py PRE-CREATION scripts/installer/windows/acs.wxs adb2b6c Diff: https://reviews.apache.org/r/19717/diff/ Testing --- Tested on windows 2008R2 server environment to make sure cloud.keystore is getting generated at desired place. Thanks, Damodar Reddy Talakanti
Review Request 19604: [Windowsfication] fixing log issues on windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19604/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- After Windowsfication logs were not getting generated properly on windows. Fixed the same by updating tomcat's properties in MSI installer Diffs - scripts/installer/windows/acs.wxs 7967478 Diff: https://reviews.apache.org/r/19604/diff/ Testing --- As changes are related to windows tested whether log files are getting generated or not in windows. Thanks, Damodar Reddy Talakanti
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
On March 19, 2014, 11:09 a.m., daan Hoogland wrote: Damoder, You introduced some trailing whitespace in this version of the diff. As far as I can judge it it looks alright. One remark I have: scripts/installer/windows/client.wxs looks like it is generated by some tool from some source. Is it? Can we include that source instead? Hi Daan, Yes client.wxs is generated by Wix Tool. Actually it is a command line command to generate that source file. At the max I can put a readme file to include those commands to geenerate this file. I already posted these commands on FS. What do you suggest? Shall we remove that file and simply put a readme - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37703 --- On March 18, 2014, 1:46 p.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 18, 2014, 1:46 p.m.) Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan Hoogland, and Donal Lafferty. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs - scripts/installer/windows/acs.wxs PRE-CREATION scripts/installer/windows/client.wxs PRE-CREATION scripts/installer/windows/start.bat PRE-CREATION scripts/vm/systemvm/injectkeys.py PRE-CREATION server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 server/test/com/cloud/server/ConfigurationServerImplTest.java 08a2097 Diff: https://reviews.apache.org/r/18964/diff/ Testing --- Tested in Linux environment after changes Also tested in Windows environment(For now tested on windows-8) to make sure it is getting installed and management service is running. Able to add zones, able to register templates, able to launch a VM when it is running on windows. Currently though it is getting added as a windows service, not able to start the service through windows service control manager which I am looking into currently. When run .exe file which is installed then server is getting up and able to access cloud stack UI. For now The following assumptions are made: 1. SSH keys are already installed 2. JAVA is already installed 3. tomcat is already installed This patch contains the following new files related to WiX tool (To compile and run we need this tool) 1. acs.wxs The following command will be used to compile Path To WiX Tool\bin\candle.exe acs.wxs 2. client.wxs The following command will be used to generate the above file Path To WiX Tool\bin\heat dir client -gg -cg Test -ke -sfrag -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS The following command will be used to compile the above generated file Path To WiX Tool\bin\candle.exe client.wxs 3. The following command will be used to generate .msi file Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi -ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 20, 2014, 5:47 p.m.) Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan Hoogland, and Donal Lafferty. Changes --- Fixed extra spaces Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs (updated) - scripts/installer/windows/acs.wxs PRE-CREATION scripts/installer/windows/client.wxs PRE-CREATION scripts/installer/windows/start.bat PRE-CREATION scripts/vm/systemvm/injectkeys.py PRE-CREATION server/src/com/cloud/server/ConfigurationServerImpl.java 4781010 server/test/com/cloud/server/ConfigurationServerImplTest.java 08a2097 Diff: https://reviews.apache.org/r/18964/diff/ Testing --- Tested in Linux environment after changes Also tested in Windows environment(For now tested on windows-8) to make sure it is getting installed and management service is running. Able to add zones, able to register templates, able to launch a VM when it is running on windows. Currently though it is getting added as a windows service, not able to start the service through windows service control manager which I am looking into currently. When run .exe file which is installed then server is getting up and able to access cloud stack UI. For now The following assumptions are made: 1. SSH keys are already installed 2. JAVA is already installed 3. tomcat is already installed This patch contains the following new files related to WiX tool (To compile and run we need this tool) 1. acs.wxs The following command will be used to compile Path To WiX Tool\bin\candle.exe acs.wxs 2. client.wxs The following command will be used to generate the above file Path To WiX Tool\bin\heat dir client -gg -cg Test -ke -sfrag -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS The following command will be used to compile the above generated file Path To WiX Tool\bin\candle.exe client.wxs 3. The following command will be used to generate .msi file Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi -ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 18, 2014, 1:46 p.m.) Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan Hoogland, and Donal Lafferty. Changes --- Added test case to verify the right scripts are returned based on OS name. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs (updated) - scripts/installer/windows/acs.wxs PRE-CREATION scripts/installer/windows/client.wxs PRE-CREATION scripts/installer/windows/start.bat PRE-CREATION scripts/vm/systemvm/injectkeys.py PRE-CREATION server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 server/test/com/cloud/server/ConfigurationServerImplTest.java 08a2097 Diff: https://reviews.apache.org/r/18964/diff/ Testing --- Tested in Linux environment after changes Also tested in Windows environment(For now tested on windows-8) to make sure it is getting installed and management service is running. Able to add zones, able to register templates, able to launch a VM when it is running on windows. Currently though it is getting added as a windows service, not able to start the service through windows service control manager which I am looking into currently. When run .exe file which is installed then server is getting up and able to access cloud stack UI. For now The following assumptions are made: 1. SSH keys are already installed 2. JAVA is already installed 3. tomcat is already installed This patch contains the following new files related to WiX tool (To compile and run we need this tool) 1. acs.wxs The following command will be used to compile Path To WiX Tool\bin\candle.exe acs.wxs 2. client.wxs The following command will be used to generate the above file Path To WiX Tool\bin\heat dir client -gg -cg Test -ke -sfrag -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS The following command will be used to compile the above generated file Path To WiX Tool\bin\candle.exe client.wxs 3. The following command will be used to generate .msi file Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi -ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
On March 14, 2014, 12:14 p.m., Damodar Reddy Talakanti wrote: Hi Daan I have updated the FS in wiki regarding how to build and install using this code. The link to FS is https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication#CloudstackWindowsfication-Installer Donal Lafferty wrote: Hi Damodar, Other reviews may differ in opinion, but IMHO manual setup steps have to be documented precisely and in a form that other contributors can improve. An excellent example is at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Setting+up+a+CloudStack+dev+environment+on+Windows An example of where this level of detail is required is the Seed SystemTemplate. WRT testing, if would be highly unusual to claim Windows 2k12 R2 support without having tried it in that environment. Have you tried reaching to the community for help verify your install steps on a Win2K12 R2? WRT accepting the code in this review, why not narrow the scope of the submission. The code above seems only to relate to Windows install for the management server, but the title implies that all details of Windows support will be covered. Rather than commit a half-finished feature, why not break windowsfication into a series of narrowly defined features. You can then make incremental submissions. DL Hi Donal, We planned to do this in 2 phases. In the first phase we put changes to be able to start and use management server on windows. We will pick up seed template part and VMware related stuff in the second phase. I had tested on windows 2008 server. I will put a mail in the community to get tested on the 2012 server. Till that time I will change the FS probably. Definitely I will try to improve the FS to cover as much as possible in detail. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37192 --- On March 18, 2014, 1:46 p.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 18, 2014, 1:46 p.m.) Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan Hoogland, and Donal Lafferty. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs - scripts/installer/windows/acs.wxs PRE-CREATION scripts/installer/windows/client.wxs PRE-CREATION scripts/installer/windows/start.bat PRE-CREATION scripts/vm/systemvm/injectkeys.py PRE-CREATION server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 server/test/com/cloud/server/ConfigurationServerImplTest.java 08a2097 Diff: https://reviews.apache.org/r/18964/diff/ Testing --- Tested in Linux environment after changes Also tested in Windows environment(For now tested on windows-8) to make sure it is getting installed and management service is running. Able to add zones, able to register templates, able to launch a VM when it is running on windows. Currently though it is getting added as a windows service, not able to start the service through windows service control manager which I am looking into currently. When run .exe file which is installed then server is getting up and able to access cloud stack UI. For now The following assumptions are made: 1. SSH keys are already installed 2. JAVA is already installed 3. tomcat is already installed This patch contains the following new files related to WiX tool (To compile and run we need this tool) 1. acs.wxs The following command will be used to compile Path To WiX Tool\bin\candle.exe acs.wxs 2. client.wxs The following command will be used to generate the above file Path To WiX Tool\bin\heat dir client -gg -cg Test -ke -sfrag -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS The following command will be used to compile the above generated file Path To WiX Tool\bin\candle.exe client.wxs 3. The following command will be used to generate .msi file Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi -ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
On March 11, 2014, 12:28 p.m., Donal Lafferty wrote: 1. How do you guarantee that 'sudo' is never added to scripts created by the Script class? See (utils/src/com/cloud/utils/script/Script.java) 2. How do you version control the .exe? 3. WiX can be run on Linux in a WINE environment. Could the Windowsfication team check whether it would be reasonable to call WiX from a Maven POM that does uses WINE if in a Linux environment? This might avoid having to checkin a .exe Damodar Reddy Talakanti wrote: 1. The final thing we wanted to do is to convert all shell scripts which are getting called inside management server(This does not include Agents as always they run on Linux Environments) to python scripts. For now I identified the shell scripts those are getting called in side management server and written python script(s) for them (Still need to write for seed system template) and calling for only windows environemnt. In the next phase I will remove OS checks inside the code and will call python scripts only. 2. start.exe is generated out of start.bat so version control is on start.bar actually. 3. We will check on this. Donal Lafferty wrote: Hi Damodar, WRT #2, I don't mean source version control. I was thinking of the version reported by the .exe E.g windows .exe's often use the pattern Major.Minor.Build.Revision I want to understand where the version information on start.exe is coming from. Could you point me to the source for start.exe? Damodar Reddy Talakanti wrote: Hi Donal, I was also looking into the specific format of .exe but I could not get much on that. If you can point me to some link that is good for me. Actually we have used Quick Batch Compiler to convert to .exe format. Donal Lafferty wrote: Hi Damodar, If I understand correctly, start.exe is generated from the most recent start.bat using Quick Batch Compiler. In that case, it would not be appropriate to check in start.exe, because it would be like checking in .class files. Would it be possible to create a Maven task to carry these instructions out, and document setup at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication ? WRT running as a Windows Service, you will not see Start/Stop functionality if you register start.exe as a service. The batch file does not expose the hooks that Windows Service Control Manager (SCM) uses to control a service DLL. You start the underlying TomCat as a Windows Service instead, e.g. http://tomcat.apache.org/tomcat-6.0-doc/windows-service-howto.html. Note that the Hyper-V agent implements SCM hooks by subtyping ServiceBase, see http://msdn.microsoft.com/en-us/library/System.ServiceProcess(v=vs.110).aspx Java equivalents are discussed here: http://stackoverflow.com/questions/68113/how-to-create-a-windows-service-from-java-app WRT testing, the feature spec says you are targeting Win2K12R2, which is not the same as Windows8. I would strongly recommend you test the target platform. To save time, why don't you ask if any community members are able to do the checks for you. WRT scripting, how did you seed the systemVM templates? Is there a work around until a python script is available? Hi Donal, I will remove start.exe from the patch and will update it. I will take a look into starting a tomcat exe instead of writing our own exe. For now I am assuming systemVM templates are installed on Secondary Storage. I will convert those scripts into python soon. Also I will update the wiki with all these information. - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review36773 --- On March 11, 2014, 12:45 p.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 11, 2014, 12:45 p.m.) Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs - scripts/installer/windows/acs.wxs PRE-CREATION scripts/installer/windows/client.wxs PRE-CREATION scripts/installer/windows/start.bat PRE-CREATION scripts/installer/windows/start.exe PRE-CREATION scripts/vm/systemvm/injectkeys.py PRE-CREATION server/src/com/cloud/server
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 14, 2014, 9:16 a.m.) Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal. Changes --- Removed start.exe from the patch. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs (updated) - scripts/installer/windows/acs.wxs PRE-CREATION scripts/installer/windows/client.wxs PRE-CREATION scripts/installer/windows/start.bat PRE-CREATION scripts/vm/systemvm/injectkeys.py PRE-CREATION server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 Diff: https://reviews.apache.org/r/18964/diff/ Testing --- Tested in Linux environment after changes Also tested in Windows environment(For now tested on windows-8) to make sure it is getting installed and management service is running. Able to add zones, able to register templates, able to launch a VM when it is running on windows. Currently though it is getting added as a windows service, not able to start the service through windows service control manager which I am looking into currently. When run .exe file which is installed then server is getting up and able to access cloud stack UI. For now The following assumptions are made: 1. SSH keys are already installed 2. JAVA is already installed 3. tomcat is already installed This patch contains the following new files related to WiX tool (To compile and run we need this tool) 1. acs.wxs The following command will be used to compile Path To WiX Tool\bin\candle.exe acs.wxs 2. client.wxs The following command will be used to generate the above file Path To WiX Tool\bin\heat dir client -gg -cg Test -ke -sfrag -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS The following command will be used to compile the above generated file Path To WiX Tool\bin\candle.exe client.wxs 3. The following command will be used to generate .msi file Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi -ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
On March 11, 2014, 12:28 p.m., Donal Lafferty wrote: 1. How do you guarantee that 'sudo' is never added to scripts created by the Script class? See (utils/src/com/cloud/utils/script/Script.java) 2. How do you version control the .exe? 3. WiX can be run on Linux in a WINE environment. Could the Windowsfication team check whether it would be reasonable to call WiX from a Maven POM that does uses WINE if in a Linux environment? This might avoid having to checkin a .exe Damodar Reddy Talakanti wrote: 1. The final thing we wanted to do is to convert all shell scripts which are getting called inside management server(This does not include Agents as always they run on Linux Environments) to python scripts. For now I identified the shell scripts those are getting called in side management server and written python script(s) for them (Still need to write for seed system template) and calling for only windows environemnt. In the next phase I will remove OS checks inside the code and will call python scripts only. 2. start.exe is generated out of start.bat so version control is on start.bar actually. 3. We will check on this. Donal Lafferty wrote: Hi Damodar, WRT #2, I don't mean source version control. I was thinking of the version reported by the .exe E.g windows .exe's often use the pattern Major.Minor.Build.Revision I want to understand where the version information on start.exe is coming from. Could you point me to the source for start.exe? Damodar Reddy Talakanti wrote: Hi Donal, I was also looking into the specific format of .exe but I could not get much on that. If you can point me to some link that is good for me. Actually we have used Quick Batch Compiler to convert to .exe format. Donal Lafferty wrote: Hi Damodar, If I understand correctly, start.exe is generated from the most recent start.bat using Quick Batch Compiler. In that case, it would not be appropriate to check in start.exe, because it would be like checking in .class files. Would it be possible to create a Maven task to carry these instructions out, and document setup at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication ? WRT running as a Windows Service, you will not see Start/Stop functionality if you register start.exe as a service. The batch file does not expose the hooks that Windows Service Control Manager (SCM) uses to control a service DLL. You start the underlying TomCat as a Windows Service instead, e.g. http://tomcat.apache.org/tomcat-6.0-doc/windows-service-howto.html. Note that the Hyper-V agent implements SCM hooks by subtyping ServiceBase, see http://msdn.microsoft.com/en-us/library/System.ServiceProcess(v=vs.110).aspx Java equivalents are discussed here: http://stackoverflow.com/questions/68113/how-to-create-a-windows-service-from-java-app WRT testing, the feature spec says you are targeting Win2K12R2, which is not the same as Windows8. I would strongly recommend you test the target platform. To save time, why don't you ask if any community members are able to do the checks for you. WRT scripting, how did you seed the systemVM templates? Is there a work around until a python script is available? Damodar Reddy Talakanti wrote: Hi Donal, I will remove start.exe from the patch and will update it. I will take a look into starting a tomcat exe instead of writing our own exe. For now I am assuming systemVM templates are installed on Secondary Storage. I will convert those scripts into python soon. Also I will update the wiki with all these information. For now I think it is ok to install systemVM locally on windows and do a scp to the secondary storage path. I tested it on windows 2008 server other than windows8 - Damodar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review36773 --- On March 14, 2014, 9:16 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 14, 2014, 9:16 a.m.) Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs - scripts/installer/windows/acs.wxs PRE-CREATION scripts/installer/windows
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37185 --- The exe which was a major issue for this patch has been removed. There are two options now one is to generate service from batch file or to just use tomcat’s service. I have spent quite a lot of time figuring out how to add a new service. At this point I think we can always go with the assumption that the cloudstack on windows will start when you start the tomcat. I will document it in the FS for now and request the reviewers to submit the patch so that I can ask for further help on this from community. - Damodar Reddy Talakanti On March 14, 2014, 9:16 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 14, 2014, 9:16 a.m.) Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs - scripts/installer/windows/acs.wxs PRE-CREATION scripts/installer/windows/client.wxs PRE-CREATION scripts/installer/windows/start.bat PRE-CREATION scripts/vm/systemvm/injectkeys.py PRE-CREATION server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 Diff: https://reviews.apache.org/r/18964/diff/ Testing --- Tested in Linux environment after changes Also tested in Windows environment(For now tested on windows-8) to make sure it is getting installed and management service is running. Able to add zones, able to register templates, able to launch a VM when it is running on windows. Currently though it is getting added as a windows service, not able to start the service through windows service control manager which I am looking into currently. When run .exe file which is installed then server is getting up and able to access cloud stack UI. For now The following assumptions are made: 1. SSH keys are already installed 2. JAVA is already installed 3. tomcat is already installed This patch contains the following new files related to WiX tool (To compile and run we need this tool) 1. acs.wxs The following command will be used to compile Path To WiX Tool\bin\candle.exe acs.wxs 2. client.wxs The following command will be used to generate the above file Path To WiX Tool\bin\heat dir client -gg -cg Test -ke -sfrag -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS The following command will be used to compile the above generated file Path To WiX Tool\bin\candle.exe client.wxs 3. The following command will be used to generate .msi file Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi -ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 14, 2014, 9:42 a.m.) Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan Hoogland, and Donal Lafferty. Changes --- Added donal and daan to reviewers list Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs - scripts/installer/windows/acs.wxs PRE-CREATION scripts/installer/windows/client.wxs PRE-CREATION scripts/installer/windows/start.bat PRE-CREATION scripts/vm/systemvm/injectkeys.py PRE-CREATION server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 Diff: https://reviews.apache.org/r/18964/diff/ Testing --- Tested in Linux environment after changes Also tested in Windows environment(For now tested on windows-8) to make sure it is getting installed and management service is running. Able to add zones, able to register templates, able to launch a VM when it is running on windows. Currently though it is getting added as a windows service, not able to start the service through windows service control manager which I am looking into currently. When run .exe file which is installed then server is getting up and able to access cloud stack UI. For now The following assumptions are made: 1. SSH keys are already installed 2. JAVA is already installed 3. tomcat is already installed This patch contains the following new files related to WiX tool (To compile and run we need this tool) 1. acs.wxs The following command will be used to compile Path To WiX Tool\bin\candle.exe acs.wxs 2. client.wxs The following command will be used to generate the above file Path To WiX Tool\bin\heat dir client -gg -cg Test -ke -sfrag -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS The following command will be used to compile the above generated file Path To WiX Tool\bin\candle.exe client.wxs 3. The following command will be used to generate .msi file Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi -ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti
Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 14, 2014, 12:10 p.m.) Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan Hoogland, and Donal Lafferty. Changes --- Incorporating the comments given by daan Hoogland. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 Repository: cloudstack-git Description --- Windowsfication of CloudStack Management Server Diffs (updated) - scripts/installer/windows/acs.wxs PRE-CREATION scripts/installer/windows/client.wxs PRE-CREATION scripts/installer/windows/start.bat PRE-CREATION scripts/vm/systemvm/injectkeys.py PRE-CREATION server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 Diff: https://reviews.apache.org/r/18964/diff/ Testing --- Tested in Linux environment after changes Also tested in Windows environment(For now tested on windows-8) to make sure it is getting installed and management service is running. Able to add zones, able to register templates, able to launch a VM when it is running on windows. Currently though it is getting added as a windows service, not able to start the service through windows service control manager which I am looking into currently. When run .exe file which is installed then server is getting up and able to access cloud stack UI. For now The following assumptions are made: 1. SSH keys are already installed 2. JAVA is already installed 3. tomcat is already installed This patch contains the following new files related to WiX tool (To compile and run we need this tool) 1. acs.wxs The following command will be used to compile Path To WiX Tool\bin\candle.exe acs.wxs 2. client.wxs The following command will be used to generate the above file Path To WiX Tool\bin\heat dir client -gg -cg Test -ke -sfrag -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS The following command will be used to compile the above generated file Path To WiX Tool\bin\candle.exe client.wxs 3. The following command will be used to generate .msi file Path To WiX Tool\bin\light.exe acs.wixobj client.wixobj -out acs.msi -ext C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll -dSourceClient=SourceDir\client Thanks, Damodar Reddy Talakanti
