[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on issue #29: Registry 404 error - failed to │ retrieve authentication checksums for provider

[GitBox]

rohityadavcloud commented on issue #29:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/29#issuecomment-1018282836


   @synergiator @kimselius there's an on-going vote thread on v0.4.0 RC1, you 
can participate on the dev ML: https://markmail.org/message/tu66esszwftrg566


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala edited a comment on issue #29: Registry 404 error - failed to │ retrieve authentication checksums for provider

[GitBox]

harikrishna-patnala edited a comment on issue #29:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/29#issuecomment-1018124525


   @kimselius @synergiator can you please try with new RC version with which we 
have new release "0.4.0-RC1"
   
   terraform {
 required_providers {
   cloudstack = {
 source = "cloudstack/cloudstack"
 version = "0.4.0-RC1"
   }
 }
   }
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #29: Registry 404 error - failed to │ retrieve authentication checksums for provider

[GitBox]

harikrishna-patnala commented on issue #29:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/29#issuecomment-1018124525


   @kimselius @synergiator can you please try with new RC version with which we 
have new release "0.4.0-RC1"
   
   terraform {
 required_providers {
   cloudstack = {
 source = "cloudstack/cloudstack"
 version = "0.4.0-RC1"
   }
 }
   }
   
   provider "cloudstack" {
 # Configuration options
   }


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] lukasmrtvy opened a new issue #37: feat: Cluster API support

[GitBox]

lukasmrtvy opened a new issue #37:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/37


   Would be superb to support also Cluster API 
https://github.com/kubernetes-sigs/cluster-api
   OpenStack is already supported 
https://github.com/kubernetes-sigs/cluster-api-provider-openstack
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tetra12 commented on a change in pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

[GitBox]

tetra12 commented on a change in pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#discussion_r788773686



##
File path: cloudstack/VPCService.go
##
@@ -2855,7 +2855,7 @@ type VPC struct {
JobIDstring   `json:"jobid"`
Jobstatusint  `json:"jobstatus"`
Name string   `json:"name"`
-   Network  []string `json:"network"`
+   Network  []Network`json:"network"`

Review comment:
   Hi @Pearl1594 
   Thanks for your hint. I updated the generator code as per your advice. Pls 
check it up again




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on issue #29: Registry 404 error - failed to │ retrieve authentication checksums for provider

[GitBox]

rohityadavcloud commented on issue #29:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/29#issuecomment-1016186906


   @harikrishna-patnala it's because the old rc-1 tag has no Github release 
now; once you upload this it will be fixed. It's possible in your local env the 
rc-1 TF binaries are cached so you're not hitting this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala merged pull request #30: Fix ip address deletion during "terraform destory" command

[GitBox]

harikrishna-patnala merged pull request #30:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/30


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] Pearl1594 commented on a change in pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

[GitBox]

Pearl1594 commented on a change in pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#discussion_r783633640



##
File path: cloudstack/VPCService.go
##
@@ -2855,7 +2855,7 @@ type VPC struct {
JobIDstring   `json:"jobid"`
Jobstatusint  `json:"jobstatus"`
Name string   `json:"name"`
-   Network  []string `json:"network"`
+   Network  []Network`json:"network"`

Review comment:
   @tetra12 - the change LGTM, but I believe this change would also 
probably be required at `CreateVPCResponse` 
(https://github.com/apache/cloudstack-go/blob/main/cloudstack/VPCService.go#L721)
 and `UpdateVPCResponse` 
(https://github.com/apache/cloudstack-go/blob/main/cloudstack/VPCService.go#L3172).
 You could probably add a check in the function named `mapType` 
(https://github.com/apache/cloudstack-go/blob/main/generate/generate.go#L1849) 
- to handle this change via the code generator. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] kimselius edited a comment on issue #29: Registry 404 error - failed to │ retrieve authentication checksums for provider

[GitBox]

kimselius edited a comment on issue #29:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/29#issuecomment-1011554542


   Seems like the files are missing?
   
   > 2022-01-13T00:41:42.615+0100 [DEBUG] GET 
https://registry.terraform.io/v1/providers/cloudstack/cloudstack/0.4.0-rc1/download/linux/amd64
   2022-01-13T00:41:42.615+0100 [TRACE] HTTP client GET request to 
https://registry.terraform.io/v1/providers/cloudstack/cloudstack/0.4.0-rc1/download/linux/amd64
   2022-01-13T00:41:42.659+0100 [DEBUG] GET 
https://github.com/cloudstack/terraform-provider-cloudstack/releases/download/v0.4.0-rc1/terraform-provider-cloudstack_0.4.0-rc1_SHA256SUMS
   2022-01-13T00:41:42.659+0100 [TRACE] HTTP client GET request to 
https://github.com/cloudstack/terraform-provider-cloudstack/releases/download/v0.4.0-rc1/terraform-provider-cloudstack_0.4.0-rc1_SHA256SUMS
   ╷
   │ Error: Failed to install provider
   │
   │ Error while installing cloudstack/cloudstack v0.4.0-rc1: could not query 
provider registry for registry.terraform.io/cloudstack/cloudstack: failed to 
retrieve authentication checksums for provider: 404 Not Found
   ╵
   
   
   Check 
https://registry.terraform.io/v1/providers/cloudstack/cloudstack/0.4.0-rc1/download/linux/amd64
   Neither 
https://github.com/cloudstack/terraform-provider-cloudstack/releases/download/v0.4.0-rc1/terraform-provider-cloudstack_0.4.0-rc1_linux_amd64.zip
 or 
https://github.com/cloudstack/terraform-provider-cloudstack/releases/download/v0.4.0-rc1/terraform-provider-cloudstack_0.4.0-rc1_SHA256SUMS
 seems available?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] kimselius commented on issue #29: Registry 404 error - failed to │ retrieve authentication checksums for provider

[GitBox]

kimselius commented on issue #29:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/29#issuecomment-1011554542


   Seems like the SHA256 checksums are missing?
   
   > 2022-01-13T00:41:42.615+0100 [DEBUG] GET 
https://registry.terraform.io/v1/providers/cloudstack/cloudstack/0.4.0-rc1/download/linux/amd64
   2022-01-13T00:41:42.615+0100 [TRACE] HTTP client GET request to 
https://registry.terraform.io/v1/providers/cloudstack/cloudstack/0.4.0-rc1/download/linux/amd64
   2022-01-13T00:41:42.659+0100 [DEBUG] GET 
https://github.com/cloudstack/terraform-provider-cloudstack/releases/download/v0.4.0-rc1/terraform-provider-cloudstack_0.4.0-rc1_SHA256SUMS
   2022-01-13T00:41:42.659+0100 [TRACE] HTTP client GET request to 
https://github.com/cloudstack/terraform-provider-cloudstack/releases/download/v0.4.0-rc1/terraform-provider-cloudstack_0.4.0-rc1_SHA256SUMS
   ╷
   │ Error: Failed to install provider
   │
   │ Error while installing cloudstack/cloudstack v0.4.0-rc1: could not query 
provider registry for registry.terraform.io/cloudstack/cloudstack: failed to 
retrieve authentication checksums for provider: 404 Not Found
   ╵
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tetra12 edited a comment on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

[GitBox]

tetra12 edited a comment on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010989619


   @rohityadavcloud Hi Rohit :clap: . Is there anyone in charge of maintaining 
this project? I'd like to contribute but see noone to be engaged after the the 
project transfer. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] rohityadavcloud commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

[GitBox]

rohityadavcloud commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010990717


   Hi @tetra12 yes, all of ACS committers and PMCs are here to help maintain 
it; esp. @davidjumani @Pearl1594 (if you see their recent commit/PR activity).
   - Rohit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tetra12 commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

[GitBox]

tetra12 commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010989619


   @rohityadavcloud Hi Rohid :clap: . Is there anyone in charge of maintaining 
this project? I'd like to contribute but see noone to be engaged after the the 
project transfer. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] svanharmelen commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

[GitBox]

svanharmelen commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010935657


   Hi @tetra12, thanks for reaching out but I'm not actively involved in this 
project anymore (hence the reason I transferred it). So I guess you need to be 
patient and wait for someone from the team to pick this up and respond... Sorry!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tetra12 commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

[GitBox]

tetra12 commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010927289


   @svanharmelen It looks like the scheme has diverged in 4.16. Definitely need 
to update the generator code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tetra12 commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

[GitBox]

tetra12 commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010926268


   @svanharmelen Hello :clap:
   Could you pls review my PR? It seems like devs are not active here. Probably 
due to the knowledge gap in this project


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #29: Registry 404 error - failed to │ retrieve authentication checksums for provider

[GitBox]

harikrishna-patnala commented on issue #29:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/29#issuecomment-1010630478


   As far as I remember I've not seen this error before.
   @synergiator I've tried the same steps by deleting .terraform folder and 
terraform init, worked fine.
   May I know if you trying with local changes or development environment, if 
yes, can you please follow these steps again from the beginning 
https://github.com/apache/cloudstack-terraform-provider#developing-the-provider.
 This is to make sure we have not missed any step along these. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala opened a new pull request #30: Fix ip address deletion during "terraform destory" command

[GitBox]

harikrishna-patnala opened a new pull request #30:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/30


   When we try to destroy network/ip resource or complete setup destroy through 
terraform, the operation fails with following error
   
   cloudstack_instance.web: Destruction complete after 11s
   ╷
   │ Error: Error disassociating IP address 
b4b3aca3-57b6-4469-9a8a-19b896898845: Undefined error: 
{"errorcode":530,"errortext":"ip address is used for source nat purposes and 
can not be disassociated."}
   │ 
   
   Problem statement:
   As part of the IP resource destroy, provider tries to dissociate, which is 
not required when the source nat is enabled.
   
   Solution:
   To skip disassociation if source nat is enabled on the IP. As part of this 
sourcenat property has to be added to the terraform state


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] GabrielBrascher opened a new pull request #257: [Merge only if #5832 is merged] Fix endpointe typo

[GitBox]

GabrielBrascher opened a new pull request #257:
URL: https://github.com/apache/cloudstack-documentation/pull/257


   Updates documentation references of global settings parameter 
`endpointe.url` to `endpoint.url`.
   :warning: This PR depends on https://github.com/apache/cloudstack/pull/5832 
being merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-cloudmonkey] synergiator commented on issue #110: How to download cmk in scripts?

[GitBox]

synergiator commented on issue #110:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/110#issuecomment-1009708262


   ok I see :-) this one works:
   
   
https://github.com/apache/cloudstack-cloudmonkey/releases/download/6.2.0/cmk.linux.x86-64
   
   Sorry!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-cloudmonkey] synergiator closed issue #110: How to download cmk in scripts?

[GitBox]

synergiator closed issue #110:
URL: https://github.com/apache/cloudstack-cloudmonkey/issues/110


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-cloudmonkey] synergiator commented on issue #110: How to download cmk in scripts?

[GitBox]

synergiator commented on issue #110:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/110#issuecomment-1009706195


   @rohityadavcloud  thx for the workaround
   
   @weizhouapache what I do:
   
   ```
   wget https://github.com/apache/cloudstack-cloudmonkey/releases/tag/6.2.0
   ls -alh 6.2.0
   -rw-rw-r-- 1 user user 155K Jan 11 09:24 6.2.0
   tail 6.2.0
   
 
   
 
   
   
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] soreana commented on pull request #256: db load averages explained

[GitBox]

soreana commented on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1008779370


   > @soreana this is part of 
[apache/cloudstack#5588](https://github.com/apache/cloudstack/pull/5588)
   > It is not merged yet, we are still doing internal QA for it.
   
   @DaanHoogland Thanks a lot. I will keep an eye on that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #256: db load averages explained

[GitBox]

DaanHoogland commented on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1008777162


   @soreana this is part of https://github.com/apache/cloudstack/pull/5588
   It is not merged yet, we are still doing internal QA for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] soreana edited a comment on pull request #256: db load averages explained

[GitBox]

soreana edited a comment on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1008775037


   @DaanHoogland Where I can see these values? In my setup, I don't have the 
DB/Usage Server page under the infrastructure menu.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] soreana commented on pull request #256: db load averages explained

[GitBox]

soreana commented on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1008775037


   @DaanHoogland Where I can see these values. In my setup, I don't have the 
DB/Usage Server page under the infrastructure menu.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] synergiator opened a new issue #29: Registry 404 error

[GitBox]

synergiator opened a new issue #29:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/29


   Anybody has got this as well?
   
   ```
   │ Error: Failed to install provider
   │ 
   │ Error while installing cloudstack/cloudstack v0.4.0-rc1: could not query
   │ provider registry for registry.terraform.io/cloudstack/cloudstack: failed 
to
   │ retrieve authentication checksums for provider: 404 Not Found
   ╵
   
   ```
   
   First I thought it would be a GitLab error, but have got same locally after 
deleting .terraform folder and terraform init on a project without changing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] jbunner commented on pull request #224: Adding docs for SUSE / RHEL8 variants support

[GitBox]

jbunner commented on pull request #224:
URL: 
https://github.com/apache/cloudstack-documentation/pull/224#issuecomment-1006481065


   There seems to be an issue in the documentation with the path for the CentOS 
repo, missing a / before $releasever


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #251: Add a document to config footer text

[GitBox]

blueorangutan commented on pull request #251:
URL: 
https://github.com/apache/cloudstack-documentation/pull/251#issuecomment-1006415585


   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/251. 
(SL-JID 177)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #251: Add a document to config footer text

[GitBox]

blueorangutan commented on pull request #251:
URL: 
https://github.com/apache/cloudstack-documentation/pull/251#issuecomment-1006401499


   @sureshanaparti a Jenkins job has been kicked to build the document. I'll 
keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] sureshanaparti commented on pull request #251: Add a document to config footer text

[GitBox]

sureshanaparti commented on pull request #251:
URL: 
https://github.com/apache/cloudstack-documentation/pull/251#issuecomment-1006400858


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #256: db load averages explained

[GitBox]

blueorangutan commented on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1004055623


   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/256. 
(SL-JID 176)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #256: db load averages explained

[GitBox]

blueorangutan commented on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1004054927


   @DaanHoogland a Jenkins job has been kicked to build the document. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #256: db load averages explained

[GitBox]

DaanHoogland commented on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1004054580


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] DaanHoogland removed a comment on pull request #256: db load averages explained

[GitBox]

DaanHoogland removed a comment on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1004044838


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] blueorangutan removed a comment on pull request #256: db load averages explained

[GitBox]

blueorangutan removed a comment on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1004031263






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] DaanHoogland removed a comment on pull request #256: db load averages explained

[GitBox]

DaanHoogland removed a comment on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1004030949


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #256: db load averages explained

[GitBox]

DaanHoogland commented on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1004044838


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #256: db load averages explained

[GitBox]

sureshanaparti commented on a change in pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#discussion_r777424852



##
File path: source/adminguide/tuning.rst
##
@@ -91,6 +91,24 @@ at `MySQL Reference
 Manual `_.
 
 
+Monitor the DataBase Load
+-
+
+The load of the DB is monitorred. By default the queries for each
+minute are calculated in queries per second. Ten values are retaint by
+default. In the UI these are visible under the DB/Usage Server page
+under the infrastructure menu.
+
+.. |dbLoadAverages.png| image:: /_static/images/dbLoadAverages.png
+   :alt: load averages as displayed in the UI
+
+The configuration variable 'database.server.stats.interval' can be set
+to change the interval, which is 60 seconds by default.
+
+The value of 'database.server.stats.retention' can be changed to tweek

Review comment:
   ```suggestion
   The value of 'database.server.stats.retention' can be changed to tweak
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #256: db load averages explained

[GitBox]

sureshanaparti commented on a change in pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#discussion_r777424573



##
File path: source/adminguide/tuning.rst
##
@@ -91,6 +91,24 @@ at `MySQL Reference
 Manual `_.
 
 
+Monitor the DataBase Load
+-
+
+The load of the DB is monitorred. By default the queries for each

Review comment:
   typo
   
   ```suggestion
   The load of the DB is monitored. By default the queries for each
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #256: db load averages explained

[GitBox]

blueorangutan commented on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1004031917


   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/256. 
(SL-JID 175)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #256: db load averages explained

[GitBox]

blueorangutan commented on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1004031263


   @DaanHoogland a Jenkins job has been kicked to build the document. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #256: db load averages explained

[GitBox]

DaanHoogland commented on pull request #256:
URL: 
https://github.com/apache/cloudstack-documentation/pull/256#issuecomment-1004030949


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-docs] marcaurele closed pull request #25: default response is now JSON

[GitBox]

marcaurele closed pull request #25:
URL: https://github.com/apache/cloudstack-docs/pull/25


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-cloudmonkey] rohityadavcloud commented on issue #110: How to download cmk in scripts?

[GitBox]

rohityadavcloud commented on issue #110:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/110#issuecomment-1002747802


   @synergiator you can ofcourse wget the link, which will handle the 
redirection. There is a mirror here you can use too: https://dl.yadav.cloud/cmk


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] synergiator commented on issue #18: API backward compatibility problem while deploying virtual machines using human readable template reference name

[GitBox]

synergiator commented on issue #18:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/18#issuecomment-1001599772


   depends on https://github.com/apache/cloudstack-go/issues/15?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] synergiator opened a new issue #28: Allow connecting network ACL to a (VPC) network according API specs

[GitBox]

synergiator opened a new issue #28:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/28


   As per Apache CloudStack API, method `createNetworkACL`  [supports a network 
ID as 
parameter](https://cloudstack.apache.org/api/apidocs-4.16/apis/createNetworkACL.html).
   
   According to this provider's documentation, it offers [linking network ACL 
to a VPC 
ID](https://registry.terraform.io/providers/cloudstack/cloudstack/latest/docs/resources/network_acl),
 but not to a given network ID.
   
   Currently, running the call through provider indeed links the network ACL to 
the VPC (possibly by the VPC's API parameter), but the application of the 
network ACL to a network can be as I assume done only from the [network 
side](https://cloudstack.apache.org/api/apidocs-4.16/apis/createNetwork.html).
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] synergiator commented on issue #15: Error retrieving ID of template: json: cannot unmarshal object into Go struct field alias.childtemplates of type []interface {}

[GitBox]

synergiator commented on issue #15:
URL: https://github.com/apache/cloudstack-go/issues/15#issuecomment-1001541205


   In the [test 
asset](https://github.com/apache/cloudstack-go/blob/v2.11.0/cloudstack/TemplateService_test.go),
 there is no method to test listing templates.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] synergiator edited a comment on issue #27: CI/CD support

[GitBox]

synergiator edited a comment on issue #27:
URL: https://github.com/apache/cloudstack-go/issues/27#issuecomment-1001538751


   agreed! in some GitHub projects, before GitHub Actions appeared, I had seen 
integrations with up to 3 CIs simultaneously, choices being those times 
Circle-CI and Travis. Vote is a good idea I think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] synergiator edited a comment on issue #27: CI/CD support

[GitBox]

synergiator edited a comment on issue #27:
URL: https://github.com/apache/cloudstack-go/issues/27#issuecomment-1001538751


   agreed! in some GitHub projects, before GitHub Actions appeared, I had seen 
integrations with up to 3 CIs simultaneously, choices being those times 
Circle-CI and Travis. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] synergiator commented on issue #27: CI/CD support

[GitBox]

synergiator commented on issue #27:
URL: https://github.com/apache/cloudstack-go/issues/27#issuecomment-1001538751


   agreed! in some GitHub projects, before GitHub Actions appeared, I had seen 
integrations with up to 3 CIs simultaneously, choices being those times 
Circle-CI, and Travis. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tampler opened a new issue #27: CI/CD support

[GitBox]

tampler opened a new issue #27:
URL: https://github.com/apache/cloudstack-go/issues/27


   Discussion
   
   It's a good time to add a CI/CD to this project. Which one to pick? Our 
options are
   - gitlab
   - github actions
   - circle-ci
   - travis
   - teamcity
   - etc
   
   Should we vote before picking up one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tetra12 commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

[GitBox]

tetra12 commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1001517586


   This is actually a quick and dirty fix, since I'm fixing schema in a 
generated file :roll_eyes: . I'll be looking :eyes: into this how to properly 
change the generator code to get a valid generated schema


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tetra12 opened a new pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

[GitBox]

tetra12 opened a new pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26


   This is the fix for #25 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tampler opened a new issue #25: Fail to list VPCs due to invalid json schema

[GitBox]

tampler opened a new issue #25:
URL: https://github.com/apache/cloudstack-go/issues/25


   Environment:
   
   ACS: 4.16.0
   OS: Ubuntu 21.10
   SDK: v.2.12.0 
   
   Issue:
   SDK fails to unmarshall `listVPCs` result when there are network tiers 
attached to a VPC. Here's my output:
   `VPCService_test.go:69: Failed to list VPCs due to: json: cannot unmarshal 
object into Go struct field VPC.vpc.network of type string`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tampler commented on issue #22: Missing API support

[GitBox]

tampler commented on issue #22:
URL: https://github.com/apache/cloudstack-go/issues/22#issuecomment-1001385344


   Hi @Pearl1594 
   Yes, the last issue with codegen was due to missing `goimports`. I'll update 
docs on this soon. Thanks for your hint!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] Pearl1594 commented on issue #22: Missing API support

[GitBox]

Pearl1594 commented on issue #22:
URL: https://github.com/apache/cloudstack-go/issues/22#issuecomment-1001333932


   @tampler based on the error, it seems like goimports may not be present in 
$PATH. If goimports has been installed and is present in $GOPATH/bin, can you 
please try adding `$GOPATH/bin` to `$PATH` and verify if it fixes the error you 
observe during code regeneration. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-go] tampler commented on issue #22: Missing API support

[GitBox]

tampler commented on issue #22:
URL: https://github.com/apache/cloudstack-go/issues/22#issuecomment-1001210600


   Hello let me summarize the problem :bulb:
   
   1. This GO SDK API is a bit outdated, since I'm getting JSON Unmarshal 
errors for ACS 4.16.0 like this: ` json: cannot unmarshal object into Go struct 
field VPC.vpc.network of type string` :x:
   2. All SDK API files are auto generated from templates `layout.go` and 
`generate.go` :heavy_check_mark:
   3. SDK API generator input is  `listApis.json` :heavy_check_mark:
   4. `listApis.json` is in turn just the output of the `listApis` command, 
which is the ACS API auto discovery plugin as per 
[this](https://cloudstack.apache.org/api/apidocs-4.16/apis/listApis.html) 
:heavy_check_mark: 
   5. Currently, API auto generator is broken :x: giving me this 
:raised_eyebrow: :
   ```bash
   go run generate/generate.go generate/layout.go --api=generate/listApis.json
   2021/12/26 19:25:22 1 API(s) failed to generate:
   2021/12/26 19:25:22 GoImport failed to format:
   exit status 1
   ```
   
   Thus need to fix the generator to regenerate the SDK APIs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-cloudmonkey] synergiator commented on issue #110: How to download cmk in scripts?

[GitBox]

synergiator commented on issue #110:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/110#issuecomment-999788329


   @weizhouapache hi - these links are redirects and not working for me. I have 
adjusted the issue description to emphasize the problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-cloudmonkey] weizhouapache commented on issue #110: How to download cmk in scripts?

[GitBox]

weizhouapache commented on issue #110:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/110#issuecomment-999745097


   @synergiator 
   Does the links in following URL work for you ?
   https://github.com/apache/cloudstack-cloudmonkey/releases/tag/6.2.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-cloudmonkey] synergiator opened a new issue #110: How to download cmk in scripts?

[GitBox]

synergiator opened a new issue #110:
URL: https://github.com/apache/cloudstack-cloudmonkey/issues/110


   To distribute the Cloud Monkey binary, I would prefer an URL which makes 
sense - or maybe it's time for a distribution via Linux OS package managers?
   
   Copy-pasting release link from this project's page is a redirect to 
something like this:
   
   ```
   
https://objects.githubusercontent.com/github-production-release-asset-2e65be/13641478/f6fab181-7336-4d6b-98a8-d75056b61755?X-Amz-Algorithm=AWS4-HMAC-SHA256=AKIAIWNJYAX4CSVEH53A%2F20211222%2Fus-east-1%2Fs3%2Faws4_request=20211222T165227Z=300=50f6cf068658d484709c589c5b45d51baf99ff17ee96802301e24433155f82e4=host_id=1834666_id=0_id=13641478=attachment%3B%20filename%3Dcmk.linux.x86-64=application%2Foctet-stream
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-www] rhtyd commented on a change in pull request #88: Survey layout

[GitBox]

rhtyd commented on a change in pull request #88:
URL: https://github.com/apache/cloudstack-www/pull/88#discussion_r772324456



##
File path: source/survey.html.markdown
##
@@ -16,6 +16,6 @@ title: Apache CloudStack Survey
 
 
 
-https://docs.google.com/forms/d/e/1FAIpQLScPHIRetdt-pxPT62IesXMoQUmhQ8ATGKcYZa507mB9uwzn-Q/viewform?embedded=true;
 width="640" height="6194" frameborder="0" marginheight="0" marginwidth="0">
+https://docs.google.com/forms/d/e/1FAIpQLScPHIRetdt-pxPT62IesXMoQUmhQ8ATGKcYZa507mB9uwzn-Q/viewform?embedded=true;
 width="100%" height="6194" frameborder="0" marginheight="0" marginwidth="0">

Review comment:
   I tested it doesn't work, and adds v/h scroll bars if width is not set 
to 100%




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-www] rhtyd merged pull request #88: Survey layout

[GitBox]

rhtyd merged pull request #88:
URL: https://github.com/apache/cloudstack-www/pull/88


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-www] rhtyd merged pull request #87: the new survey

[GitBox]

rhtyd merged pull request #87:
URL: https://github.com/apache/cloudstack-www/pull/87


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-www] rhtyd commented on a change in pull request #87: the new survey

[GitBox]

rhtyd commented on a change in pull request #87:
URL: https://github.com/apache/cloudstack-www/pull/87#discussion_r772258030



##
File path: source/index.html.erb
##
@@ -143,6 +143,16 @@ title: Welcome to CloudStack
 
   
 
+
+
+  
+Take the Apache CloudStack user survey!
+  
+  
+Participate in the Apache CloudStack User Survey and help us build 
the Ainnual State of CloudStack Report.

Review comment:
   Typo on Annual and space in ``




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-www] rhtyd commented on a change in pull request #87: the new survey

[GitBox]

rhtyd commented on a change in pull request #87:
URL: https://github.com/apache/cloudstack-www/pull/87#discussion_r772257758



##
File path: source/survey.html.markdown
##
@@ -16,7 +16,6 @@ title: Apache CloudStack Survey
 
 
 
-https://www.formwize.com/run/survey3.cfm?idx=505d040e080008;>
+https://docs.google.com/forms/d/e/1FAIpQLScPHIRetdt-pxPT62IesXMoQUmhQ8ATGKcYZa507mB9uwzn-Q/viewform?embedded=true”
 width=“640" height=“6194” frameborder=“0" marginheight=“0” marginwidth=“0">

Review comment:
   @DaanHoogland can you fix the unicode quotes with ascii quotes `"`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] vladimirpetrov commented on issue #24: Instance cannot be expunged, only destroyed

[GitBox]

vladimirpetrov commented on issue #24:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/24#issuecomment-997773356


   This parameter fixes the problem, closing the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] vladimirpetrov closed issue #24: Instance cannot be expunged, only destroyed

[GitBox]

vladimirpetrov closed issue #24:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/24


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] DaanHoogland edited a comment on pull request #215: Modernizing "Create linux template" guide + Cloud-init integration steps

[GitBox]

DaanHoogland edited a comment on pull request #215:
URL: 
https://github.com/apache/cloudstack-documentation/pull/215#issuecomment-996623494


   @dredknight @rhtyd It seems to me (at first sight that not the "\\" but the 
space behind it should be removed. just FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] dredknight commented on pull request #215: Modernizing "Create linux template" guide + Cloud-init integration steps

[GitBox]

dredknight commented on pull request #215:
URL: 
https://github.com/apache/cloudstack-documentation/pull/215#issuecomment-996648698


   Agreed! it has already been removed in the latest changes!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #215: Modernizing "Create linux template" guide + Cloud-init integration steps

[GitBox]

DaanHoogland commented on pull request #215:
URL: 
https://github.com/apache/cloudstack-documentation/pull/215#issuecomment-996623494


   @dredknight @rhtyd It seems to me (at first sight that not the "\" but the 
space behind it should be removed. just FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] dredknight commented on pull request #215: Modernizing "Create linux template" guide + Cloud-init integration steps

[GitBox]

dredknight commented on pull request #215:
URL: 
https://github.com/apache/cloudstack-documentation/pull/215#issuecomment-996616816


   Thanks Rohit!
   
   I will test next week and update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] synergiator commented on issue #20: Understanding implications of the legacy SDK notification

[GitBox]

synergiator commented on issue #20:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/20#issuecomment-995502466


   thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] synergiator closed issue #20: Understanding implications of the legacy SDK notification

[GitBox]

synergiator closed issue #20:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/20


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #20: Understanding implications of the legacy SDK notification

[GitBox]

harikrishna-patnala commented on issue #20:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/20#issuecomment-995429312


   @synergiator can you please let me know if anything else we need here or we 
can close this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] vladimirpetrov commented on issue #25: cloudstack_template does not wait until the template is ready for use

[GitBox]

vladimirpetrov commented on issue #25:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/25#issuecomment-994467098


   This trick works, thanks @harikrishna-patnala, closing the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] vladimirpetrov closed issue #25: cloudstack_template does not wait until the template is ready for use

[GitBox]

vladimirpetrov closed issue #25:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/25


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #24: Instance cannot be expunged, only destroyed

[GitBox]

harikrishna-patnala commented on issue #24:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/24#issuecomment-994303472


   @vladimirpetrov I see that there is "expunge" param that we can set in 
terraform VM resource configuration.resource 
   "cloudstack_instance" "VM1" {
   name = "VM1"
   service_offering = "Small Instance"
   template = cloudstack_template.Template.id
   network_id = cloudstack_network.N1.id
   zone = "${var.zoneId}"
   **expunge = true**
   }
   
   I tried this with destroy command and it expunged the VM. can you please try 
that as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala edited a comment on issue #17: Removing an ACL list from a network corrupts state file

[GitBox]

harikrishna-patnala edited a comment on issue #17:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/17#issuecomment-994301150


   Hi @synergiator, to test any bug fixes before the RC is cut or before the 
terraform registry is updated, you have to build the binaries locally and use 
it and that is straight forward. We have documented this here 
https://github.com/apache/cloudstack-terraform-provider#developing-the-provider
   
   Please let me know if you are facing issues with that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #17: Removing an ACL list from a network corrupts state file

[GitBox]

harikrishna-patnala commented on issue #17:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/17#issuecomment-994301150


   Hi @synergiator, to test any bug fixes before the RC is cut or before the 
terraform registry is not updated, you have to build the binaries locally and 
use it and that is straight forward. We have documented this here 
https://github.com/apache/cloudstack-terraform-provider#developing-the-provider
   
   Please let me know if you are facing issues with that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #25: cloudstack_template does not wait until the template is ready for use

[GitBox]

harikrishna-patnala commented on issue #25:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/25#issuecomment-994299483


   @vladimirpetrov dependency for template in VM resource will be created only 
if use template's terraform resource name in VM resource config like below 
   
   resource "cloudstack_instance" "VM1" {
 name = "VM1"
 service_offering = "Small Instance"
 **template = cloudstack_template.Template.id**
 network_id   = cloudstack_network.N1.id
 zone = "${var.zoneId}"
   }
   
   If we use the template uuid or name directly in the VM resource 
configuration then terraform won't create the dependency. Can you please try as 
I mentioned before. I've tried the same observed VM waits till template gets 
registered and download complete.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] vladimirpetrov closed issue #23: cloudstack_egress_firewall resource triggers a modification even when there is no change

[GitBox]

vladimirpetrov closed issue #23:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/23


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] vladimirpetrov commented on issue #23: cloudstack_egress_firewall resource triggers a modification even when there is no change

[GitBox]

vladimirpetrov commented on issue #23:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/23#issuecomment-994117388


   I double-checked and you're right @harikrishna-patnala, closing the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] vladimirpetrov commented on issue #22: cloudstack_disk: custom size volume triggers modification even when there's no change

[GitBox]

vladimirpetrov commented on issue #22:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/22#issuecomment-994117214


   I double-checked and you're right @harikrishna-patnala, closing the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] vladimirpetrov closed issue #22: cloudstack_disk: custom size volume triggers modification even when there's no change

[GitBox]

vladimirpetrov closed issue #22:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/22


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] synergiator commented on issue #17: Removing an ACL list from a network corrupts state file

[GitBox]

synergiator commented on issue #17:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/17#issuecomment-993703877


   ok thank you for retesting @harikrishna-patnala  - not sure how to 
reproduce, closing.
   
   Side question - is there a (simple) possibility to test a build between 
releases? While not sure when the next RC will be available, the fix for port 
forward setting problem should be valuable alone!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] synergiator closed issue #17: Removing an ACL list from a network corrupts state file

[GitBox]

synergiator closed issue #17:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/17


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #22: cloudstack_disk: custom size volume triggers modification even when there's no change

[GitBox]

harikrishna-patnala commented on issue #22:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/22#issuecomment-993286630


   @vladimirpetrov we need use case sensitive names for the resources. Here we 
have used "custom" to fetch the disk offering.
   The name in CloudStack is "Custom" so try using the CloudStack name, TF 
won't reapply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #23: cloudstack_egress_firewall resource triggers a modification even when there is no change

[GitBox]

harikrishna-patnala commented on issue #23:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/23#issuecomment-993266396


   @vladimirpetrov I see that the cidr list you are providing is "cidr_list = 
["0.0.0.0/0"]" but when the actual API runs Cloudstack create rules against the 
cidr of the network since the provided one is generic.
   
   So after the rule is created the TF state is filled with the cidr which got 
from the API response. When terraform apply sees this difference it is trying 
to reapply the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #17: Removing an ACL list from a network corrupts state file

[GitBox]

harikrishna-patnala commented on issue #17:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/17#issuecomment-993246719


   @synergiator, may I know what is the exact configuration that you are using. 
 When I tried creating VPC and tier in it having ACL ID and then removing ACL 
ID from that tier, these steps worked fine.
   
   ```
   -/+ resource "cloudstack_network" "tier1" {
 ~ acl_id   = "59d048bb-8329-4817-9124-972a91743778" -> "none" 
# forces replacement
   
   ```
   upon removing acl_id from the resource or setting "acl_id = null", both 
resulted in above operation and they are successful.
   
   May I know what configuration and what change in the configuration triggered 
your error.
   ```
   
   module.vpc.cloudstack_network.private[0] will be updated in-place
 ~ resource "cloudstack_network" "private" {
 - acl_id   = "none" -> null
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala closed issue #21: Can't create port forwarding rule

[GitBox]

harikrishna-patnala closed issue #21:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/21


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #21: Can't create port forwarding rule

[GitBox]

harikrishna-patnala commented on issue #21:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/21#issuecomment-987779393


   Closing this issue as the related PR is merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala merged pull request #27: Fix port forwarding to update state only if there are no errors

[GitBox]

harikrishna-patnala merged pull request #27:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/27


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on pull request #27: Fix port forwarding to update state only if there are no errors

[GitBox]

harikrishna-patnala commented on pull request #27:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/27#issuecomment-987778350


   Fixed the indentation. Thanks all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] rhtyd commented on pull request #27: Fix port forwarding to update state only if there are no errors

[GitBox]

rhtyd commented on pull request #27:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/27#issuecomment-987765073


   @harikrishna-patnala pl fix your editor to run `gofmt` or use tabs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] sureshanaparti commented on a change in pull request #27: Fix port forwarding to update state only if there are no errors

[GitBox]

sureshanaparti commented on a change in pull request #27:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/27#discussion_r763822209



##
File path: cloudstack/resource_cloudstack_port_forward.go
##
@@ -109,13 +109,12 @@ func resourceCloudStackPortForwardCreate(d 
*schema.ResourceData, meta interface{
forwards := 
resourceCloudStackPortForward().Schema["forward"].ZeroValue().(*schema.Set)
 
err := createPortForwards(d, meta, forwards, nrs)
-
-   // We need to update this first to preserve the correct state
-   d.Set("forward", forwards)
-
-   if err != nil {
+   if err != nil {
return err
}
+
+// We need to update this first to preserve the correct state
+d.Set("forward", forwards)

Review comment:
   seems indentation is missed here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala opened a new pull request #27: Fix port forwarding to update state only if there are no errors

[GitBox]

harikrishna-patnala opened a new pull request #27:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/27


   This PR fixes the issue 
https://github.com/apache/cloudstack-terraform-provider/issues/21, where PF 
state is not updated properly in Terraform.
   
   Verified steps:
   1. Create VM and a new network
   2. Acquire an IP
   3. Create PF rule => successfully created
   4. Make another attempt such that PF rule creation should fail
   5. Retry with correct steps to get succeeded => successfully created
   
   4 and 5 steps are the actual steps which got failed in the issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala closed issue #16: How to get the source nat ip address from a network?

[GitBox]

harikrishna-patnala closed issue #16:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/16


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on issue #16: How to get the source nat ip address from a network?

[GitBox]

harikrishna-patnala commented on issue #16:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/16#issuecomment-987622642


   Great, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-terraform-provider] hrak commented on issue #16: How to get the source nat ip address from a network?

[GitBox]

hrak commented on issue #16:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/16#issuecomment-987617391


   Yes, it can be closed, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org