Re: Management of Transifex resources

[Laszlo Hornyak]

HI Rafael,

David Nalley (CC) is the project admin at transifex.

On Wed, Apr 18, 2018 at 2:00 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> Hello Folks,
> Today I was going to upload new keys to transifex and translate some
> strings proposed in [1]. It looks a little messy the Transifex resources.
> As I user, when I get there, I have no idea where I should work. Can we
> have/use a single resource file there? If we only use the
> “4.10_messages.json” now, can we delete others?
>
> BTW: Do we know who has the admin account for the CloudStack organization
> there?
>
> [1] https://github.com/apache/cloudstack/pull/2571
>
> --
> Rafael Weingärtner
>



-- 

EOF

Re: Adding VirtIO SCSI to KVM hypervisors

[Laszlo Hornyak]

Hi Wido,

If I understand correctly from the documentation and your examples, virtio
provides virtio interface to the guest while virtio-scsi provides scsi
interface, therefore an IaaS service should not replace it without user
request / approval. It would be probably better to let the user set what
kind of IO interface the VM needs.

Best regards,
Laszlo

On Fri, Jan 20, 2017 at 10:21 PM, Wido den Hollander  wrote:

> Hi,
>
> VirtIO SCSI [0] has been supported a while now by Linux and all kernels,
> but inside CloudStack we are not using it. There is a issue for this [1].
>
> It would bring more (theoretical) performance to VMs, but one of the
> motivators (for me) is that we can support TRIM/DISCARD [2].
>
> This would allow for RBD images on Ceph to shrink, but it can also give
> back free space on QCOW2 images if quests run fstrim. Something all modern
> distributions all do weekly in a CRON.
>
> Now, it is simple to swap VirtIO for VirtIO SCSI. This would however mean
> that disks inside VMs are then called /dev/sdX instead of /dev/vdX.
>
> For GRUB and such this is no problems. This usually work on UUIDs and/or
> labels, but for static mounts on /dev/vdb1 for example things break.
>
> We currently don't have any configuration method on how we want to present
> a disk to a guest, so when attaching a volume we can't say that we want to
> use a different driver. If we think that a Operating System supports VirtIO
> we use that driver in KVM.
>
> Any suggestion on how to add VirtIO SCSI support?
>
> Wido
>
>
> [0]: http://wiki.qemu.org/Features/VirtioSCSI
> [1]: https://issues.apache.org/jira/browse/CLOUDSTACK-8239
> [2]: https://issues.apache.org/jira/browse/CLOUDSTACK-8104
>



-- 

EOF

Re: CloudStack Logo Font

[Laszlo Hornyak]

Hi Will,

That is a good question and I do not know the answer, but why don't you
just copy-paste the shape from the svg?

On Fri, Jun 17, 2016 at 5:12 PM, Will Stevens 
wrote:

> Does anyone know what the font is that was used to create the
> apachecloudstack logo as well as the font used for the tagline?
>
> I have not been able to find those details.  Anyone???
>
> Thanks,
>
> Will
>



-- 

EOF

Re: Spannish translation mangled

[Laszlo Hornyak]

Looks good now, thank you!

On Wed, Feb 10, 2016 at 9:37 PM, Milamber  wrote:

> Hello,
>
> Issue fixed, I re-upload the localization files on transifex from the 4.8
> branch.
>
> The issue is become because the /tools/transifex/.tx/config don't include
> the 4.8 config (the 4.8.0 release has been release without the updates from
> transifex).
> To fix them, I had just re-upload the source file (en) to update my config
> file.
>
> This PR 1375 will fix this issue (and update the l10n files).
> https://github.com/apache/cloudstack/pull/1375
>
> Milamber
>
>
>
>
> On 10/02/2016 13:45, Marco Sinhoreli wrote:
>
>> Hi folks,
>>
>> Any issue in transifex? It’s showing 5% complete. Before Brazilian
>> Portuguese was 100%. Many others languages are only 5% complete.
>>
>> Best regards,
>>
>> Marco Sinhoreli
>> Consultant Manager
>> marco.sinhor...@shapeblue.com
>> mobile: +55 21 98276 3636
>>
>> Praia de Botafogo 501, bloco 1 - sala 101 – Botafogo
>> Rio de Janeiro, RJ - Brazil - CEP 22250-040
>> office: + 55 21 2586 6390 | fax: +55 21 2586 6002
>> http://www.shapeblue.com/ | twitter: @shapeblue
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> Em [DATE], "[NAME]" <[ADDRESS]> escreveu:
>>
>> Hi Milamber,
>>>
>>> Thanks, and sorry for the extra-trouble...
>>> I did the push with: tx push -s -t
>>> .. after linking the source, resource was 48xmessagesproperties.
>>>
>>> I'm not sure if I did something wrong.. didn't check that branch before,
>>> but it's showing only 5% of strings in "translated state", while the other
>>> branches are ~60%...
>>> Shouldn't Transifex catchup on the already translated strings?
>>>
>>> I also updated the PR, btw.
>>>
>>> -NT
>>>
>>> Kind regards,
>>>
>>> Nuno Tavares
>>> Senior DevOps Infra Specialist
>>> LeaseWeb Technologies B.V.
>>>
>>> T: +31 20 316 0235
>>> M:
>>> E: n.tava...@tech.leaseweb.com
>>> W: http://www.leaseweb.com
>>>
>>> Luttenbergweg 8, 1101 EC Amsterdam, Netherlands
>>>
>>>
>>> 
>>> From: Milamber [milam...@apache.org]
>>> Sent: Wednesday, February 10, 2016 8:14 AM
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: Spannish translation mangled
>>>
>>> Nuno, you are now Mainteners in the Web UI project. You can upload the
>>> resources files to fix this charset issue.
>>>
>>> On 10/02/2016 06:58, Nuno Tavares wrote:
>>>
 Hi Milamber,

 Not sure where I find my ID... but I'm this guys over here:
 https://www.transifex.com/user/profile/ntavares/
 :)

 -NT

 Kind regards,

 Nuno Tavares
 Senior DevOps Infra Specialist
 LeaseWeb Technologies B.V.

 T: +31 20 316 0235
 M:
 E: n.tava...@tech.leaseweb.com
 W: http://www.leaseweb.com

 Luttenbergweg 8, 1101 EC Amsterdam, Netherlands


 
 From: Milamber [milam...@apache.org]
 Sent: Wednesday, February 10, 2016 12:13 AM
 To: dev@cloudstack.apache.org
 Subject: Re: Spannish translation mangled

 Hum/Oups! Provide me your transifex account id to allow me to add to the
 maintainers team.


 On 09/02/2016 22:56, Nuno Tavares wrote:

> Hi Milamber, thanks for the pointers... but apparently:
>
> $ tx push -s -t
> Pushing translations for resource CloudStack_UI.48xmessagesproperties:
> Exception: Only maintainers are allowed to update the source file.
>
> -NT
>
>
> Kind regards,
>
> Nuno Tavares
> Senior DevOps Infra Specialist
> LeaseWeb Technologies B.V.
>
> T: +31 20 316 0235
> M:
> E: n.tava...@tech.leaseweb.com
> W: http://www.leaseweb.com
>
> Luttenbergweg 8, 1101 EC Amsterdam, Netherlands
>
>
> 
> From: Milamber [milam...@apache.org]
> Sent: Tuesday, February 9, 2016 1:49 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Spannish translation mangled
>
> Thanks
>
> Your can update the localization files on transifex using the little
> utility on tools/transifex folder in source tree
>
> Requirement: Transifex client installed
>
> (go to the 4.8 branch)
>
> cd ./tools/transifex/
> ./sync-transifex-ui.sh upload-l10n-languages
> CloudStack_UI.48xmessagesproperties
>
> (all languages will be update from repo to transifex, you can reduce to
> ES only if you editing the sync-transifex-ui.sh and change the
> LIST_LANG
> value)
>
>
>
> On 09/02/2016 11:23, Nuno Tavares wrote:
>
>> Hi all,
>>
>> I checked this issue yesterday with Daan, the problem is double
>> UNICODE encoding, and it's the source in Transifex that is broken. There
>> are ~250 broken characters, so fixing one by one in Transifex is a bit 
>> of a
>> waste of time. I could fix this with a script, but I'm still wondering 
>> how
>> the file received patches and remain in this state 

Re: Spannish translation mangled

[Laszlo Hornyak]

Hi,

Might be a related issue, but looks like now I am translating either from
Spanish or from Portuguese, but anyway it is a nice challenge... Can you
give me back the original English?

[image: Inline image 1]


Thank you,
Laszlo

On Wed, Feb 10, 2016 at 2:45 PM, Marco Sinhoreli <
marco.sinhor...@shapeblue.com> wrote:

> Hi folks,
>
> Any issue in transifex? It’s showing 5% complete. Before Brazilian
> Portuguese was 100%. Many others languages are only 5% complete.
>
> Best regards,
>
> Marco Sinhoreli
> Consultant Manager
> marco.sinhor...@shapeblue.com
> mobile: +55 21 98276 3636
>
> Praia de Botafogo 501, bloco 1 - sala 101 – Botafogo
> Rio de Janeiro, RJ - Brazil - CEP 22250-040
> office: + 55 21 2586 6390 | fax: +55 21 2586 6002
> http://www.shapeblue.com/ | twitter: @shapeblue
>
>
>
>
>
>
>
>
>
> Em [DATE], "[NAME]" <[ADDRESS]> escreveu:
>
> >Hi Milamber,
> >
> >Thanks, and sorry for the extra-trouble...
> >I did the push with: tx push -s -t
> >.. after linking the source, resource was 48xmessagesproperties.
> >
> >I'm not sure if I did something wrong.. didn't check that branch before,
> but it's showing only 5% of strings in "translated state", while the other
> branches are ~60%...
> >Shouldn't Transifex catchup on the already translated strings?
> >
> >I also updated the PR, btw.
> >
> >-NT
> >
> >Kind regards,
> >
> >Nuno Tavares
> >Senior DevOps Infra Specialist
> >LeaseWeb Technologies B.V.
> >
> >T: +31 20 316 0235
> >M:
> >E: n.tava...@tech.leaseweb.com
> >W: http://www.leaseweb.com
> >
> >Luttenbergweg 8, 1101 EC Amsterdam, Netherlands
> >
> >
> >
> >From: Milamber [milam...@apache.org]
> >Sent: Wednesday, February 10, 2016 8:14 AM
> >To: dev@cloudstack.apache.org
> >Subject: Re: Spannish translation mangled
> >
> >Nuno, you are now Mainteners in the Web UI project. You can upload the
> >resources files to fix this charset issue.
> >
> >On 10/02/2016 06:58, Nuno Tavares wrote:
> >> Hi Milamber,
> >>
> >> Not sure where I find my ID... but I'm this guys over here:
> >> https://www.transifex.com/user/profile/ntavares/
> >> :)
> >>
> >> -NT
> >>
> >> Kind regards,
> >>
> >> Nuno Tavares
> >> Senior DevOps Infra Specialist
> >> LeaseWeb Technologies B.V.
> >>
> >> T: +31 20 316 0235
> >> M:
> >> E: n.tava...@tech.leaseweb.com
> >> W: http://www.leaseweb.com
> >>
> >> Luttenbergweg 8, 1101 EC Amsterdam, Netherlands
> >>
> >>
> >> 
> >> From: Milamber [milam...@apache.org]
> >> Sent: Wednesday, February 10, 2016 12:13 AM
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: Spannish translation mangled
> >>
> >> Hum/Oups! Provide me your transifex account id to allow me to add to the
> >> maintainers team.
> >>
> >>
> >> On 09/02/2016 22:56, Nuno Tavares wrote:
> >>> Hi Milamber, thanks for the pointers... but apparently:
> >>>
> >>> $ tx push -s -t
> >>> Pushing translations for resource CloudStack_UI.48xmessagesproperties:
> >>> Exception: Only maintainers are allowed to update the source file.
> >>>
> >>> -NT
> >>>
> >>>
> >>> Kind regards,
> >>>
> >>> Nuno Tavares
> >>> Senior DevOps Infra Specialist
> >>> LeaseWeb Technologies B.V.
> >>>
> >>> T: +31 20 316 0235
> >>> M:
> >>> E: n.tava...@tech.leaseweb.com
> >>> W: http://www.leaseweb.com
> >>>
> >>> Luttenbergweg 8, 1101 EC Amsterdam, Netherlands
> >>>
> >>>
> >>> 
> >>> From: Milamber [milam...@apache.org]
> >>> Sent: Tuesday, February 9, 2016 1:49 PM
> >>> To: dev@cloudstack.apache.org
> >>> Subject: Re: Spannish translation mangled
> >>>
> >>> Thanks
> >>>
> >>> Your can update the localization files on transifex using the little
> >>> utility on tools/transifex folder in source tree
> >>>
> >>> Requirement: Transifex client installed
> >>>
> >>> (go to the 4.8 branch)
> >>>
> >>> cd ./tools/transifex/
> >>> ./sync-transifex-ui.sh upload-l10n-languages
> >>> CloudStack_UI.48xmessagesproperties
> >>>
> >>> (all languages will be update from repo to transifex, you can reduce to
> >>> ES only if you editing the sync-transifex-ui.sh and change the
> LIST_LANG
> >>> value)
> >>>
> >>>
> >>>
> >>> On 09/02/2016 11:23, Nuno Tavares wrote:
>  Hi all,
> 
>  I checked this issue yesterday with Daan, the problem is double
> UNICODE encoding, and it's the source in Transifex that is broken. There
> are ~250 broken characters, so fixing one by one in Transifex is a bit of a
> waste of time. I could fix this with a script, but I'm still wondering how
> the file received patches and remain in this state (as in: is there any
> other scenario where this double encoding shows up correct?)
> 
>  I've created a PR based on the tag 4.8.0 (#1407)
> 
>  -NT
> 
>  Kind regards,
> 
>  Nuno Tavares
>  Senior DevOps Infra Specialist
>  LeaseWeb Technologies B.V.
> 
>  T: +31 20 316 0235
>  M:
>  E: n.tava...@tech.leaseweb.com
>  W: http://www.leaseweb.com
> 
>  

cloudstack devs at fosdem?

[Laszlo Hornyak]

Hi List,

Anyone planing to visit fosdem this year? It would be great to meet there.

Best regards,
Laszlo

-- 

EOF

Re: UI translation for 4.6

[Laszlo Hornyak]

Hi,

Thank you for the reminder!
I can not promise it will ever be 100%, but I will review and cleanup the
translation.

Best regards,
Laszlo

On Fri, Oct 23, 2015 at 6:11 PM, Milamber  wrote:

> Hello,
>
> The new stats for the translations of Web UI 4.6 (languages over 50%):
>
> French (France) 100%
> Portuguese (Brazil) 99%
> Japanese (Japan)99%
> Chinese (China) 99%
> Norwegian Bokmål (Norway)   99%
> Hungarian   98%
> Dutch (Netherlands) 94%
> German (Germany)76%
> Russian (Russia)75%
> Korean (Korea)  66%
> Spanish 53%
>
> Thanks for the translators! (especially to the Norwegian 70%->99%, 655 new
> translated strings!)
>
> I will integrate all this new strings in a new PR the next week around the
> 30/31st October.
>
> Hungarian / Dutch (@dahn), just a small work to go to 100%!
>
> The transifex project to translate the Web UI:
> https://www.transifex.com/ke4qqq/CloudStack_UI/
>
> That would be great to have a lot of localization Web UI for CloudStack
> 4.6!
>
> Thanks
>
> Milamber
>
> PS. All languages stats for 4.6:
> https://www.transifex.com/ke4qqq/CloudStack_UI/46xmessagesproperties/
>
>
>
> On 09/10/2015 09:49, Sebastien Goasguen wrote:
>
>> Milamber reminded me that before releasing 4.6 we should include the
>> latest translated strings for the UI.
>> If you care about translation, you might be interested to work on it in
>> the coming days.
>>
>> Here is where we stand:
>>
>> Portuguese (Brazil) 100%
>> French (France) 100%
>>
>> Japanese (Japan)99%
>> Hungarian   98%
>> Chinese (China) 93%
>> Dutch (Netherlands) 89%
>> Russian (Russia)75%
>> German (Germany)71%
>> Norwegian Bokmål (Norway)   70%
>> Korean (Korea)  66%
>> Spanish 53%
>>
>>
>> Italian (Italy) 36%
>> Polish  21%
>> Catalan 13%
>> Arabic  12%
>> Persian 11%
>> Romanian (Romania)  9%
>> Chinese (Taiwan)7%
>> Georgian5%
>> Thai (Thailand) 5%
>> Turkish (Turkey)2%
>> Tatar   2%
>> Indonesian  1%
>>
>> you can see that Japanese, Hungarian, Chinese and Dutch are really close
>> to 100%:
>>
>> https://www.transifex.com/ke4qqq/CloudStack_UI/
>>
>>
>> -sebastien
>>
>
>


-- 

EOF

Re: CloudStack 4.5.2 with tomcat6 out of memory

[Laszlo Hornyak]

Hi,

I think the reason is that the cloudstack UI index.jsp creates a session
(which is the default behavior of a JSP page unfortunately) and if the
container keeps the session data wthout overflowing to disk then you can
use it to OOM the server very easily.


curl http://localhost:8080/client/ -v > /dev/null
  % Total% Received % Xferd  Average Speed   TimeTime Time
 Current
 Dload  Upload   Total   SpentLeft
 Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:--
  0*   Trying ::1...
* Connected to localhost (::1) port 8080 (#0)
> GET /client/ HTTP/1.1
> User-Agent: curl/7.40.0
> Host: localhost:8080
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Type: text/html; charset=utf-8
< Expires: Thu, 01-Jan-1970 00:00:00 GMT
< Set-Cookie: JSESSIONID=vzv1rka5gdo2r607ujza192x;Path=/client
< Transfer-Encoding: chunked
< Server: Jetty(6.1.26)
<


I send a PR on this and will see what the guys think, but this might be
something to consider if you have a public cloudstack server.

Best regards,
Laszlo

On Thu, Oct 15, 2015 at 10:01 AM, Qian Shaohua  wrote:

> Hi all,
>
>
>
> Our CloudStack 4.5.2 with tomcat6 was constantly running out of memory in a
> few days.
>
> We changed JAVA_OPS to "-Xmx4g" in tomcat6.conf. But it didn't help.
>
> We used apache benchmark to send 10 http requests to a fresh installed
> CloudStack 4.5.2 with no zone setup.
>
>ab -n 10 -c 1 http://localhost:8080/client/
>
> The CS always run out of memory after 35,000 requests.
>
> The same to a fresh CloudStack 4.3.0.
>
> A clean tomcat6 on another CentOS host passed the ab test.
>
> Finally, we installed tomcat7 and change CS to use tomcat7. Both CS 4.5.2
> and CS 4.3.0 passed ab test.
>
> We suppose it is a serious issue.
>
> Is there any idea?
>
>
>
> Our setup:
>
> CS 4.5.2/Centos 6.5/Tomcat 6.0.24
>
> Tomcat 7.0.33
>
>
>
> --
>
> Qian
>
>


-- 

EOF

Re: analysis.apache.org

[Laszlo Hornyak]

I believe the problem was that sonar was outdated and the code analysis
plugins could not handle some java 1.7 syntax (like resource blocks). With
5.1 even java 1.8 should not be a problem.

The 26 new are actually the old ones plus the javascript, javascript was
not analysed so far. And hmmm... only the minor issues got less?

On Tue, May 19, 2015 at 9:42 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 H fellow devs,

 It has come to my attentions that after more then eight months the sonar
 install at apache now does a daily analysis of cloudstack again.:) There
 are 26 issues stamped 'Blocker' and a lot more fun in the lower categories.

 Shal I make issues per sonar 'Blocker'? I propose to make them critical and
 not blocker.




-- 

EOF

Re: Cloudstack Repackaging / Distro support

[Laszlo Hornyak]

Hi Rafael,

There is a ticket for fedora packaging: CLOUDSTACK-8163 I have sent patches
with that issue ID. There are quite a lot of things to do...
Are you working on the management server packaging?
Why does the management service have to start as a separate service? It
could be just a webapp under tomcat.

Basically what are the advantages of having a reverse proxy in front of
tomcat? Is httpd/nginx more secure than tomcat?

Best regards,
Laszlo

On Tue, May 12, 2015 at 10:59 AM, Rafael Fonseca rsafons...@gmail.com
wrote:

 Hi all,

 I'm reworking the packaging system in cloudstack, and would like to gather
 your opinion on the following:

 - Fedora 2x runs systemd's cockpit on port 9090 by default
   This is a deal breaker for the cluster servlet port on this OS, the two
 possibilities would be to either pack changes to fedora's config on rpm
 install or simply change the servlet port to another one that does not
 clash on any distro.. any comments/suggestions?

 - Tomcat is not listening on port 80
Tomcat is using port 8080, which makes the user have to specify that in
 the browser.. should we change it? In ubuntu it's already running under
 jsvc, so it shouldn't be a problem.. same can be arranged for centos/other
 distros.

 - No link on the tomcat root (http://management-server/ can link
 internally
 to http://management-server/client , this makes it easier for new users
 who
 don't know the URL for the UI :)

 Thanks for your input :)




-- 

EOF

Re: [GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

[Laszlo Hornyak]

Nice! I will bookmark this site...
No KVM? :-)

On Tue, May 12, 2015 at 10:47 PM, Carlos Reátegui create...@gmail.com
wrote:

 
 I have no IE righ here, but the 'never' setting seems to be a
 problem. I would love to see it going away but if that creates bugreports
 or confusion for users then it is no fun. Would you agree in having that
 'now' thing only for IE for safety?
 
 Here you go: http://dev.modern.ie/tools/vms/ 
 http://dev.modern.ie/tools/vms/
 As far back as IE6 on XP to IE11 on Windows 10




-- 

EOF

dictionary*.jsp simplification

[Laszlo Hornyak]

Hi,

Just an idea on how to get rid of dictionary2.jsp...

https://github.com/K0zka/cloudstack/commit/6172562791c1b08491e0485a47c4fe86ee0a65d8

Unfortunately the lengthy list of i18n keys to export into the dictionary
js object is still needed because only some of the keys from the
resourcebundle should go to the dictionary, some others directly to the
html.

-- 

EOF

Re: [ANNOUNCE] New committer: Remi Bergsma

[Laszlo Hornyak]

Congrats Remi! And happy Friday! :)

On Fri, May 1, 2015 at 8:45 AM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 The Project Management Committee (PMC) for Apache CloudStack
 has asked Remi Bergsma to become a committer and we are pleased to
 announce that he has accepted.

 Remi has reported and helped in investigating and solving many bugs. He has
 given talks on managing clouds on several occasions.

 Being a committer allows many contributors to contribute more
 autonomously. For developers, it makes it easier to submit changes and
 eliminates the need to have contributions reviewed via the patch
 submission process. Whether contributions are development-related or
 otherwise, it is a recognition of a contributor's participation in the
 project and commitment to the project and the Apache Way.

 Please join me in congratulating Remi

 --Daan Hoogland
 on behalf of the CloudStack PMC




-- 

EOF

Re: jenkins jobs

[Laszlo Hornyak]

Hi Daan,

I tried to dig into the problem, but I have no access to the agents. If you
can give me an account, I'd really like to help!

Best regards,
Laszlo

On Fri, May 1, 2015 at 1:27 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 LS,

 For anybody looking for a pastime; Our jenkins jobs are far from clean at
 the moment. I spent far to much time on them the past few weeks and am far
 from done. Please feel free to chip in.

 thanks
 Daan




-- 

EOF

Re: getting rid of 3rd party repositories (ceph, libvirt)

[Laszlo Hornyak]

Thank you Wido!
Should work now...

On Wed, Apr 29, 2015 at 4:46 PM, Wido den Hollander w...@widodh.nl wrote:

 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1



 On 04/22/2015 12:31 PM, Laszlo Hornyak wrote:
  Hi Wido,
 
  I should have read the git log first :-)
 
  No license issues and no code change needed. All I want to have is
  rados-java in the central maven repository for two reasons: -
  central is the most reliable service - we can not upload our
  artifacts to central until we have a dependency on other
  repositories, and therefore users and developers are not able to
  reuse
 
  I will send you a PR for the pom file. This is needed in order to
  compliy central repository upload policy, no functional changes,
  only meta-data.
 

 Got it! I merged the PR.

  And then, let's see.. do you own the repository in central repo?
  Basically either you can upload or I can upload for you if you give
  me permission, in any case I will try to help.
 

 No, I don't have one. You have my permission to upload rados-java to
 your repo so that it can get into maven central.

 Wido

  Best regards, Laszlo
 
  On Wed, Apr 22, 2015 at 9:20 AM, Wido den Hollander
  w...@widodh.nl wrote:
 
 
 
  On 04/21/2015 09:12 PM, Laszlo Hornyak wrote:
  Hi,
 
  I have uploaded the libvirt dependency to maven central and
  you should never get the maven failure if the libvirt.org
  server goes down, it will be downloaded from central. I have
  sent a PR (#180) to remove the libvirt.org repository from
  the build.
 
  With ceph.org the situation: - I have requested permission
  to publish like with libvirt, my request was rejected since
  the ceph.com team holds ownership - The only solution from
  here is to change the groupId of the dependency. -
  org.apache.* is very likely no go, it is owned by apache,
  artifacts are synchonrized to central through the apache
  repository, which is for apache artifacts only. - we can
  upload with a new groupId - suggestions are welcome
 
 
  I wrote the rados-java bindings and licensed it under the Apache
  License .
 
  I choose com.ceph as a package since that was the easiest way. It
  would be changed but I don't want to break all the existing code
  for users.
 
  Any ideas?
 
  Wido
 
  Regards, Laszlo
 
 
 
 
 
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1

 iQIcBAEBAgAGBQJVQO7PAAoJEAGbWC3bPspCyoYP/0EOa/J73wT9jXHqWuy3Pp7i
 SeJKPYsKOUbE2lYbjbLmpOF0SB837YPkbwlZr8PT/XLPxojhpc+XxIe0RYlBcqmj
 sGdlxMI9yMyRg4kj4WlUdgWI68kNM1y/OZty4eSmlmpfzsXcyoo9JjvAd++Q0hr6
 WB7/+Yq9OzNMJg50Ky935NfgQ75wRwKuANfpmowjixR93tPo0rMEFjFhZsyVdSG1
 IlgzCWAyD7KOwPuB5KFPwsh7A0FfTNvuNUgcxFsPIjrJfJecBfUVXDppCXWBH+qS
 0Zy6udsaCYSVFitGXCJS5kqd20IXlA040d9+l91AlOqCg+R6hWCo9u12Bgl26EiQ
 KunUA+t8qTvx2VQKoRyBOgeFn3tzsR5WtZ9pVgulOJJFQggShLDRdtKtkUC193MV
 vrBsPxmpM3By6NywfEt0N3JfPZ0t/aP2WVNxSMG+8kEL+tQhE1a6DucS/ZxJLYdu
 z3IFjioMz15+lDkUIs2WQcxZoXrzxGgh+2de4MXMsRO6/DmoGFiDrb+bO82NRliK
 HJQNckpMSEq/M6hSs4pyXR/zGpVE9qgt26ZqCqxGLenYIJwglNM+2Txm5exo0P4q
 knUmIBhQoirDecl7Uqpm0c0lh302GmvgNVVcKu9+0MKr/ObRG2KO3GKGWlbRkWtu
 VLF9PnlOu0sKoxIPwv3R
 =SbBH
 -END PGP SIGNATURE-




-- 

EOF

Re: [DISCUSS] Moving to Java 8

[Laszlo Hornyak]

Is java 1.8 on the roadmap for ubuntu 14?
It does not seem to make sense to have a LTS supported until 2019 with a
JDK no longer supported.


On Wed, Apr 22, 2015 at 2:43 PM, Wido den Hollander w...@widodh.nl wrote:

 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1



 On 04/22/2015 02:13 PM, Wilder Rodrigues wrote:
  Hi Wido,
 
  Thanks for the reply and making a good point concerning Ubuntu
  14.04.
 
  Besides the difficulty in writing testes without increasing even
  more out technical dept, another point on the Java 8 platform is
  the EOL (end of this month) of Java 1.7.
 

 Yes, I'm aware of that. So that makes this situation difficult.

 There is a bug open for backporting OpenJDK 8 to Ubuntu 14.04:
 https://bugs.launchpad.net/ubuntu/+source/openjdk-8/+bug/1341628

 More votes there would really help.

  For now I created a ticket on Apache Jira to keep track of it:
  https://issues.apache.org/jira/browse/CLOUDSTACK-8397. Could you
  please have a look and let me know if the content of the ticket is
  appropriate?
 
  We will start a new sprint in 1 week and will take some time to
  discuss what to do and when. Will keep the community updated on
  that matter.
 
  Thanks a gain.
 
  Cheers, Wilder
 
 
  On 21 Apr 2015, at 15:49, Wido den Hollander
  w...@widodh.nlmailto:w...@widodh.nl wrote:
 
 
 
  On 04/21/2015 03:27 PM, Wilder Rodrigues wrote: Hi all,
 
  Yesterday I started working on the LibvirtComputingResource class
  in order to apply the same patterns I used in the
  CitrixResourceBase + add more unit tests to it After 10 hours of
  work I got a bit stuck with the 1st test, which would cover the
  refactored LibvirtStopCommandWrapper. Why did I get stuck? The
  class used a few static methods that call native libraries, which
  I would like to mock. However, when writing the tests I faced
  problems with the current Mockito/PowerMock we are using: they are
  simply not enough for the task.
 
  What did I do then? I added a dependency to EasyMock and
  PowerMock-EasyMock API. It worked almost fine, but I had to add a
  “-noverify” to both my Eclipse Runtime configuration and also to
  the cloud-plugin-hypervisor-kvm/pom.xml file. I agree that’s not
  nice, but was my first attempt of getting it to work. After trying
  to first full build I faced more problems related to
  ClassDefNotFoundExpcetion which were complaining about Mockito
  classes. I then found out that adding the PowerMockRunner to all
  the tests classes was going to be a heavy burden and would also
  mess up future changes (e.g. the -noverify flag was removed from
  Java 8, thus adding it now would be a problem soon).
 
  Now that the first 2 paragraphs explain a bit about the problem,
  let’s get to the solution: Java 8
 
  The VerifyError that I was getting was due to the use of the
  latest EasyMock  release (3.3.1). I tried to downgrade it to
  3.1/3.2 but it also did not work. My decision: do not refactor if
  the proper tests cannot be added. This left me with one action:
  migrate to Java 8.
 
  There were mentions about Java 8 in february[1] and now I will put
  some energy in making it happen.
 
  What is your opinion on it?
 
 
  I'm not against it technically, but practically I am.
 
  Ubuntu 14.04 does not ship a Java 8 JRE in the repositories.
 
  CentOS 7 has java-1.8.0-openjdk.x86_64 available, so it would work
  there. But Ubuntu is also widely used with CloudStack, so those
  users couldn't use CloudStack without any additional repositories.
 
  Since that isn't easy I would vote -1 on this if it came that far.
 
  Wido
 
  Thanks in advance.
 
  Cheers, Wilder
 
  http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201502.mbox/%3
 
 
 c54eef6be.5040...@shapeblue.commailto:c54eef6be.5040...@shapeblue.com%
 3Ehttp://mail-archives.apache.org/mod_m
  box/cloudstack-dev/201502.mbox/54eef6be.5040...@shapeblue.commailto:
 54eef6be.5040...@shapeblue.com
 
 
 
 
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1

 iQIcBAEBAgAGBQJVN5dgAAoJEAGbWC3bPspCzX8P/0o8V8ZZPF+mOiXwfvZxOoqn
 Xtb084SajpLvB4KFT207FecJ6rKJyJiSXZSW6esj1F5OBzoDzF30vWHityvvatCA
 LsY5zCj2LF01itmjK8SVXuuwK8sSINycJPu2jJVotYr4ooPM1pHJjv/UnQfrUgp3
 yv8vT3VKhrPLkGOIIcRR8zmIPH6qtgTf/ILBsc9hUrkvYgfmReH1dkeQY4gid3TZ
 sHGrnYHby2SgW+9KbuEfdvOrHvItYbJpRWz6W3R6l+DQeZxMt/pMbZRXEM4LXkuL
 /t450iwybpMZzwwnPYqu0TjTjSI0AFZp9gq+obygEnbDsbCXMuUKRHNymCdUZH3r
 hldfP1dmAwPEjJ0Z9PgybvmitaAqvUg80BeS7iS/6SPulGx6hFiafrdCgjdQ7bxM
 qN4nGcFIwxmzphhljnLARxRxl2/50KuZTYmC3XmyfbrUYX+BiDW8FoMbCd5qJJyC
 r48w2gPQW52HyVckM532PFpMWah7If8Q0Ee9w0JrTEF3RRkMQ7NySUvK0Y9er8ay
 D6fmw5szuWWNF7bSC6wNx5bY7EyNGp7rDa1Ki4f4G7chh6m16yhYSQ0fLBjro6fw
 sFbs7EKAa9iCsyHbPQBpz3IoqkSbCknnHbXAInQOyybLKendwZ2f9LVA8K0GFlHH
 uMsBvF/FH1bnVg+oX8N3
 =oFqF
 -END PGP SIGNATURE-




-- 

EOF

Re: getting rid of 3rd party repositories (ceph, libvirt)

[Laszlo Hornyak]

Hi Wido,

I should have read the git log first :-)

No license issues and no code change needed. All I want to have is
rados-java in the central maven repository for two reasons:
- central is the most reliable service
- we can not upload our artifacts to central until we have a dependency on
other repositories, and therefore users and developers are not able to reuse

I will send you a PR for the pom file. This is needed in order to compliy
central repository upload policy, no functional changes, only meta-data.

And then, let's see.. do you own the repository in central repo? Basically
either you can upload or I can upload for you if you give me permission, in
any case I will try to help.

Best regards,
Laszlo

On Wed, Apr 22, 2015 at 9:20 AM, Wido den Hollander w...@widodh.nl wrote:

 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1



 On 04/21/2015 09:12 PM, Laszlo Hornyak wrote:
  Hi,
 
  I have uploaded the libvirt dependency to maven central and you
  should never get the maven failure if the libvirt.org server goes
  down, it will be downloaded from central. I have sent a PR (#180)
  to remove the libvirt.org repository from the build.
 
  With ceph.org the situation: - I have requested permission to
  publish like with libvirt, my request was rejected since the
  ceph.com team holds ownership - The only solution from here is to
  change the groupId of the dependency. - org.apache.* is very likely
  no go, it is owned by apache, artifacts are synchonrized to central
  through the apache repository, which is for apache artifacts only.
  - we can upload with a new groupId - suggestions are welcome
 

 I wrote the rados-java bindings and licensed it under the Apache License
 .

 I choose com.ceph as a package since that was the easiest way. It
 would be changed but I don't want to break all the existing code for
 users.

 Any ideas?

 Wido

  Regards, Laszlo
 
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1

 iQIcBAEBAgAGBQJVN0unAAoJEAGbWC3bPspCKbAP/1d8gAmu+//zR/uhFAju+gEI
 TGLvXhFv4uX9IKwGwMS9oiNDxYDQ9GPY17zShf41B271Ft9F8HZ8ovEfj8uauwaV
 sr/2jHhI14Hb7d09vSBc1DmXzJ3iYyrQFYno/z7rVRTHJmJ67xrJPT7+ZjPOxI7E
 aXoZMIBSuKPEJKwJl2vY8AsdFeU1LnPaKPC/vqUqqh94eIw1jk67ZgoCLctKOIig
 43b0eZiRCrsGsiXYURH8pihlxDKY5ipz5utRY0ngb64xJRx2u/XSBDPFGtiwNR2O
 dWTVACqgqnSKdDdr3cqZ6eDEaxKmViupi672fOTjZjgpnQojWKvLti4DVdcqMFle
 BYGguzVcJZQpt8MSiiS9ATtm4WJkaePQsTS3T4BiqrxIpUfeYhhrCeE3Q+dykIYn
 BdtsMBhAdM930Lv+6Zk/W6mmcxKmeXXU6ImOV95nYnvN53Q2+DEya06fZHsH80nR
 eEO8uzS/Rz2GcumPClVV9Hv+g+nt6gYw+8w+OuVQIsU4YdQ0coOhsOYRleTeurBY
 3JSZ8q4XX+PCZVpwLOZ6myKgNZFqGjk0CWi6DD3RssCQiZo5yWAJyENfVrX8GjO+
 8pEQup2ACn/WR/A3o4q4Zq0m4B4u0wYXFmRgQ/kvOxSSeqhMhQlGZPsdrYLbM4P9
 WeH67OGvyb+F/83N5ezx
 =W4ry
 -END PGP SIGNATURE-




-- 

EOF

getting rid of 3rd party repositories (ceph, libvirt)

[Laszlo Hornyak]

Hi,

I have uploaded the libvirt dependency to maven central and you should
never get the maven failure if the libvirt.org server goes down, it will be
downloaded from central. I have sent a PR (#180) to remove the libvirt.org
repository from the build.

With ceph.org the situation:
- I have requested permission to publish like with libvirt, my request was
rejected since the ceph.com team holds ownership
- The only solution from here is to change the groupId of the dependency.
- org.apache.* is very likely no go, it is owned by apache, artifacts are
synchonrized to central through the apache repository, which is for apache
artifacts only.
- we can upload with a new groupId - suggestions are welcome

Regards,
Laszlo
-- 

EOF

Re: Cloudstack modules on maven repository

[Laszlo Hornyak]

Hi,

As far asI know, there is no such repsoitory. It would be great to use the
central repository, but first we have to get rid of extra maven
repositories. (libvirt and ceph for example)
I registered a jira issue:
https://issues.apache.org/jira/browse/CLOUDSTACK-8335


On Wed, Mar 18, 2015 at 9:15 PM, Rafael Weingartner 
rafaelweingart...@gmail.com wrote:

 Hi devs,

 I just started extending Cloustack, I have spent almost a whole day
 configuring and building everything on eclipse. I noticed that CS modules
 are not in maven central repository, therefore, I have to download,
 configure, compile and build everything in order to work in one or other
 module. I was wondering is there any repository out there on the Internet,
 maybe an apache dev repository, with all of those modules ready to use that
 I can point as an extra repository in maven?

 --
 Rafael Weingärtner




-- 

EOF

Re: jenkins

[Laszlo Hornyak]

Can I help in any way?

On Tue, Mar 17, 2015 at 6:43 AM, Rajani Karuturi raj...@apache.org wrote:

 jenkins server

 ~Rajani

 On Tue, Mar 17, 2015 at 11:09 AM, Laszlo Hornyak laszlo.horn...@gmail.com
 
 wrote:

  Is this a problem with the agents or the jenkins server itself fails?
 
  On Tue, Mar 17, 2015 at 6:10 AM, Rajani Karuturi raj...@apache.org
  wrote:
 
   There was genuine build failure which was masked by the system
 failures.
  
   We are not getting any value from the current jenkins setup. I thinks
 it
   would be better to reset everything and start from scratch with
 jenkins.
  
  
   ~Rajani
  
   On Mon, Mar 16, 2015 at 10:55 PM, Laszlo Hornyak 
  laszlo.horn...@gmail.com
   
   wrote:
  
Hi,
   
What's wrong with the jenkins jobs? I am getting various errors for a
   good
while, while the build anyway seems to work fine and tests pass.
 Anyone
working on this?
   
--
   
EOF
   
  
 
 
 
  --
 
  EOF
 




-- 

EOF

Re: jenkins

[Laszlo Hornyak]

I will configure the jobs not to spam the list because we only learn to
ignore the emails then. Let's try to fix the problems and add the dev list
again to the notifications when the service is reliable. I hope this will
not take a big lot of time.


On Tue, Mar 17, 2015 at 7:11 AM, Rajani Karuturi raj...@apache.org wrote:

 I am also willing to put in some effort on jenkins. But, I couldnt get
 access to server and with my poor jenkins knowledge, couldnt proceed any
 further.

 ~Rajani

 On Tue, Mar 17, 2015 at 11:28 AM, Laszlo Hornyak laszlo.horn...@gmail.com
 
 wrote:

  Can I help in any way?
 
  On Tue, Mar 17, 2015 at 6:43 AM, Rajani Karuturi raj...@apache.org
  wrote:
 
   jenkins server
  
   ~Rajani
  
   On Tue, Mar 17, 2015 at 11:09 AM, Laszlo Hornyak 
  laszlo.horn...@gmail.com
   
   wrote:
  
Is this a problem with the agents or the jenkins server itself fails?
   
On Tue, Mar 17, 2015 at 6:10 AM, Rajani Karuturi raj...@apache.org
wrote:
   
 There was genuine build failure which was masked by the system
   failures.

 We are not getting any value from the current jenkins setup. I
 thinks
   it
 would be better to reset everything and start from scratch with
   jenkins.


 ~Rajani

 On Mon, Mar 16, 2015 at 10:55 PM, Laszlo Hornyak 
laszlo.horn...@gmail.com
 
 wrote:

  Hi,
 
  What's wrong with the jenkins jobs? I am getting various errors
  for a
 good
  while, while the build anyway seems to work fine and tests pass.
   Anyone
  working on this?
 
  --
 
  EOF
 

   
   
   
--
   
EOF
   
  
 
 
 
  --
 
  EOF
 




-- 

EOF

Re: junkins

[Laszlo Hornyak]

jobs in the apache jenkins fail because of the old sonarqube version does
not handle java 1.7 properly
registered infra bug: https://issues.apache.org/jira/browse/INFRA-9289

On Tue, Mar 17, 2015 at 6:37 PM, Laszlo Hornyak laszlo.horn...@gmail.com
wrote:

 Yes, we the sonar job in the apache jenkins is a bit stuck as well, there
 was no successful analysis for several months. :-( We need a bit more focus
 on the infrastructure.

 On Tue, Mar 17, 2015 at 12:23 PM, Daan Hoogland daan.hoogl...@gmail.com
 wrote:

 Laszlo, I don't think anyone is working on this. Jenkins output is
 largely ignored in this community. The fact that the present cause is
 a resource problem is worrying. I think these are SBP hosted slaves
 and will have a look (not in the office now). If I fix this the
 slowbuild will not work at least. The last time I saw it passing by it
 had 6 new unattended issues from the findbugs output. Coverity
 complained about new issues as well, i noticed just now.

 regards,
 Daan

 On Mon, Mar 16, 2015 at 6:25 PM, Laszlo Hornyak
 laszlo.horn...@gmail.com wrote:
  Hi,
 
  What's wrong with the jenkins jobs? I am getting various errors for a
 good
  while, while the build anyway seems to work fine and tests pass. Anyone
  working on this?
 
  --
 
  EOF



 --
 Daan




 --

 EOF




-- 

EOF

Re: junkins

[Laszlo Hornyak]

Yes, we the sonar job in the apache jenkins is a bit stuck as well, there
was no successful analysis for several months. :-( We need a bit more focus
on the infrastructure.

On Tue, Mar 17, 2015 at 12:23 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 Laszlo, I don't think anyone is working on this. Jenkins output is
 largely ignored in this community. The fact that the present cause is
 a resource problem is worrying. I think these are SBP hosted slaves
 and will have a look (not in the office now). If I fix this the
 slowbuild will not work at least. The last time I saw it passing by it
 had 6 new unattended issues from the findbugs output. Coverity
 complained about new issues as well, i noticed just now.

 regards,
 Daan

 On Mon, Mar 16, 2015 at 6:25 PM, Laszlo Hornyak
 laszlo.horn...@gmail.com wrote:
  Hi,
 
  What's wrong with the jenkins jobs? I am getting various errors for a
 good
  while, while the build anyway seems to work fine and tests pass. Anyone
  working on this?
 
  --
 
  EOF



 --
 Daan




-- 

EOF

Re: [URGENT - HELP NEEDED]

[Laszlo Hornyak]

Btw, just in order to avoid the same problem... maybe we could make this
query smarter and if no nic marked as default, but there is only one, then
that single NIC could be returned as default.

On Mon, Mar 16, 2015 at 5:19 PM, Andrija Panic andrija.pa...@gmail.com
wrote:

 FIXED !!!

 Thanks a lot Marcus, this is the second time you saved me from the deep
 $$it..

 Only 1 VM that had only 1 NIC and not set to default in DB - so just after
 changing that default_nic=1, destroyed the VR, and new one was recreated.

 Thanks a lot for help !


 On 16 March 2015 at 16:52, Andrija Panic andrija.pa...@gmail.com wrote:

  I will thanks a lot Marcus for hints...
 
  On 16 March 2015 at 16:49, Marcus shadow...@gmail.com wrote:
 
  Ok, just watch for those createdhcpentry mgmt server logs. Perhaps
  they're just triggered by you trying to fix the situation by
  migrating, but the original issue was something else entirely.
 
  On Mon, Mar 16, 2015 at 8:44 AM, Andrija Panic andrija.pa...@gmail.com
 
  wrote:
   I did migrate and also changed accounts, unsucessfully, so some bugs
   definitively or my specific setup...
  
   Thanks, I' fixing this now and will let you know.
  
   On 16 March 2015 at 16:42, Marcus shadow...@gmail.com wrote:
  
   Yes, each VM should have at least one default nic, so if there's only
   one nic it should be set to default. Take a db backup first, of
   course, before messing with it. Any idea how it may have happened? Do
   you migrate VMs between networks ever?
  
   On Mon, Mar 16, 2015 at 8:39 AM, Andrija Panic 
  andrija.pa...@gmail.com
   wrote:
Ok, so if the VM has only 1 VM - and default_nic=0, then I need to
  change
all of them to default_nic=1... ?
   
   
On 16 March 2015 at 16:38, Marcus shadow...@gmail.com wrote:
   
VMs can have multiple nics and be on multiple networks. If you
 set a
nic as default, it becomes the network that the vm has its default
route on. Every VM should have a default nic, and if it doesn't I
wonder how it might have happened (maybe a specific combination of
add/delete nic triggered a bug?). You should set a default nic for
every VM that might be missing one, and see if that gets your
 router
up.
   
On Mon, Mar 16, 2015 at 8:34 AM, Andrija Panic 
  andrija.pa...@gmail.com
   
wrote:
 Hi Marcus,

 Thanks a lot fot hint

 True, I have the 0 as the value for some reason in database, for
   couple
of
 NICs
 select * from nics where ip4_address like 46.232% and
  broadcast_uri
   =
 vlan://500 and default_nic = 0;

 results: http://pastebin.com/rDAe2RY9

 or down there...

 This Techvee-FileServer server is already running (still not
 dead)
   and I
 can see 1 NIC from UI...

 Should I reset all of these to 1 ?
 What is the purpose of this field default_nic = 0.

 vlan://500 in my case limits results only to the network for
 this
  VR
   that
 is having problems...

 Any suggestions ?

 id uuid instance_id mac_address ip4_address netmask
   gateway
 ip_type broadcast_uri network_id mode state strategy
 reserver_name reservation_id device_id update_time
isolation_uri
 ip6_address default_nic vm_type created removed
   ip6_gateway
 ip6_cidr secondary_ip display_nic
 2816 5066bc3a-dbec-4789-aa42-3b9eb8f50bb4 1795
   06:70:0a:00:00:ac
 46.232.180.101 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 1
  2015-02-04
 23:06:23 vlan://500 \N 0 User 2015-02-04 20:41:05
  2015-02-04
 22:06:23 \N \N 0 1
 3132 c8a5f98e-5663-40e3-ac03-1ac3545eaa83 1958
   06:fc:c2:00:00:ad
 46.232.180.102 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 1
  2015-03-03
 15:45:47 vlan://500 \N 0 User 2015-02-18 15:50:35
  2015-03-03
 14:45:47 \N \N 0 1
 3139 f5a41229-2267-4615-9128-63fbce69bb01 1962
   06:d7:ac:00:00:ae
 46.232.180.103 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 1
  2015-02-19
 03:10:45 vlan://500 \N 0 User 2015-02-19 00:09:02
  2015-02-19
 02:10:45 \N \N 0 1
 707 99afa70a-39d5-4685-8fc0-9857fdc77c90 511
  06:b5:72:00:00:72
 46.232.180.144 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 0
  2014-01-27
 14:38:52 vlan://500 \N 0 User 2014-01-27 11:29:08
  2014-01-27
 13:38:52 \N \N 0 1
 1580 bf56315e-b4c3-4338-88d9-3013ab2e2c37 1088
   06:1d:90:00:00:72
 46.232.180.144 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 1
  2014-07-23
 10:15:18 vlan://500 \N 0 User 2014-07-17 19:14:06
  2014-07-23
 08:15:18 \N \N 0 1
 3799 712cbcb6-097f-4555-a73b-e8c2a5bd557f 2306
   06:33:ac:00:00:77
 46.232.180.149 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 

junkins

[Laszlo Hornyak]

Hi,

What's wrong with the jenkins jobs? I am getting various errors for a good
while, while the build anyway seems to work fine and tests pass. Anyone
working on this?

-- 

EOF

Re: [URGENT - HELP NEEDED]

[Laszlo Hornyak]

Cool, congrats! :-)

On Mon, Mar 16, 2015 at 5:19 PM, Andrija Panic andrija.pa...@gmail.com
wrote:

 FIXED !!!

 Thanks a lot Marcus, this is the second time you saved me from the deep
 $$it..

 Only 1 VM that had only 1 NIC and not set to default in DB - so just after
 changing that default_nic=1, destroyed the VR, and new one was recreated.

 Thanks a lot for help !


 On 16 March 2015 at 16:52, Andrija Panic andrija.pa...@gmail.com wrote:

  I will thanks a lot Marcus for hints...
 
  On 16 March 2015 at 16:49, Marcus shadow...@gmail.com wrote:
 
  Ok, just watch for those createdhcpentry mgmt server logs. Perhaps
  they're just triggered by you trying to fix the situation by
  migrating, but the original issue was something else entirely.
 
  On Mon, Mar 16, 2015 at 8:44 AM, Andrija Panic andrija.pa...@gmail.com
 
  wrote:
   I did migrate and also changed accounts, unsucessfully, so some bugs
   definitively or my specific setup...
  
   Thanks, I' fixing this now and will let you know.
  
   On 16 March 2015 at 16:42, Marcus shadow...@gmail.com wrote:
  
   Yes, each VM should have at least one default nic, so if there's only
   one nic it should be set to default. Take a db backup first, of
   course, before messing with it. Any idea how it may have happened? Do
   you migrate VMs between networks ever?
  
   On Mon, Mar 16, 2015 at 8:39 AM, Andrija Panic 
  andrija.pa...@gmail.com
   wrote:
Ok, so if the VM has only 1 VM - and default_nic=0, then I need to
  change
all of them to default_nic=1... ?
   
   
On 16 March 2015 at 16:38, Marcus shadow...@gmail.com wrote:
   
VMs can have multiple nics and be on multiple networks. If you
 set a
nic as default, it becomes the network that the vm has its default
route on. Every VM should have a default nic, and if it doesn't I
wonder how it might have happened (maybe a specific combination of
add/delete nic triggered a bug?). You should set a default nic for
every VM that might be missing one, and see if that gets your
 router
up.
   
On Mon, Mar 16, 2015 at 8:34 AM, Andrija Panic 
  andrija.pa...@gmail.com
   
wrote:
 Hi Marcus,

 Thanks a lot fot hint

 True, I have the 0 as the value for some reason in database, for
   couple
of
 NICs
 select * from nics where ip4_address like 46.232% and
  broadcast_uri
   =
 vlan://500 and default_nic = 0;

 results: http://pastebin.com/rDAe2RY9

 or down there...

 This Techvee-FileServer server is already running (still not
 dead)
   and I
 can see 1 NIC from UI...

 Should I reset all of these to 1 ?
 What is the purpose of this field default_nic = 0.

 vlan://500 in my case limits results only to the network for
 this
  VR
   that
 is having problems...

 Any suggestions ?

 id uuid instance_id mac_address ip4_address netmask
   gateway
 ip_type broadcast_uri network_id mode state strategy
 reserver_name reservation_id device_id update_time
isolation_uri
 ip6_address default_nic vm_type created removed
   ip6_gateway
 ip6_cidr secondary_ip display_nic
 2816 5066bc3a-dbec-4789-aa42-3b9eb8f50bb4 1795
   06:70:0a:00:00:ac
 46.232.180.101 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 1
  2015-02-04
 23:06:23 vlan://500 \N 0 User 2015-02-04 20:41:05
  2015-02-04
 22:06:23 \N \N 0 1
 3132 c8a5f98e-5663-40e3-ac03-1ac3545eaa83 1958
   06:fc:c2:00:00:ad
 46.232.180.102 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 1
  2015-03-03
 15:45:47 vlan://500 \N 0 User 2015-02-18 15:50:35
  2015-03-03
 14:45:47 \N \N 0 1
 3139 f5a41229-2267-4615-9128-63fbce69bb01 1962
   06:d7:ac:00:00:ae
 46.232.180.103 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 1
  2015-02-19
 03:10:45 vlan://500 \N 0 User 2015-02-19 00:09:02
  2015-02-19
 02:10:45 \N \N 0 1
 707 99afa70a-39d5-4685-8fc0-9857fdc77c90 511
  06:b5:72:00:00:72
 46.232.180.144 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 0
  2014-01-27
 14:38:52 vlan://500 \N 0 User 2014-01-27 11:29:08
  2014-01-27
 13:38:52 \N \N 0 1
 1580 bf56315e-b4c3-4338-88d9-3013ab2e2c37 1088
   06:1d:90:00:00:72
 46.232.180.144 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 1
  2014-07-23
 10:15:18 vlan://500 \N 0 User 2014-07-17 19:14:06
  2014-07-23
 08:15:18 \N \N 0 1
 3799 712cbcb6-097f-4555-a73b-e8c2a5bd557f 2306
   06:33:ac:00:00:77
 46.232.180.149 255.255.255.0 46.232.180.1 Ip4
 vlan://500
   212
 Dhcp Deallocating Create DirectNetworkGuru \N 1
  2015-03-16
 12:41:11 vlan://500 \N 0 User 2015-03-16 09:50:25
  2015-03-16
 11:41:11 \N \N 0 1
 3817 

Re: jenkins

[Laszlo Hornyak]

Is this a problem with the agents or the jenkins server itself fails?

On Tue, Mar 17, 2015 at 6:10 AM, Rajani Karuturi raj...@apache.org wrote:

 There was genuine build failure which was masked by the system failures.

 We are not getting any value from the current jenkins setup. I thinks it
 would be better to reset everything and start from scratch with jenkins.


 ~Rajani

 On Mon, Mar 16, 2015 at 10:55 PM, Laszlo Hornyak laszlo.horn...@gmail.com
 
 wrote:

  Hi,
 
  What's wrong with the jenkins jobs? I am getting various errors for a
 good
  while, while the build anyway seems to work fine and tests pass. Anyone
  working on this?
 
  --
 
  EOF
 




-- 

EOF

Re: [URGENT - HELP NEEDED]

[Laszlo Hornyak]

Hi Andrija,

Could you also share management server logs?


On Sun, Mar 15, 2015 at 5:19 PM, Andrija Panic andrija.pa...@gmail.com
wrote:

 Hi guys,

 we have updated the cloudstack from 4.3.0 to 4.3.2 (OS updated right before
 that, from CentOS 6.5 to CentOS 6.6)

 And now I can not start SYSTEM VR - that is used for SHARED GUEST network
 anymore.
 And some VMs are down - and cant be started because they depend on this
 VR...

 VPC VRs are created fine, so new VR for VPC are created fine, but this one
 fro Guest network fails to start:

 Here you can see, after agent copies template from secondary storage, to
 primary local storage, it created base image, and backing file - so storage
 setup seems completed.

 Than all out of sudden we have errors:

 can't find connection: KVM, for vm: r-2281-VM, continue
 2015-03-15 16:52:45,677 DEBUG [kvm.resource.LibvirtConnection]
 (agentRequest-Handler-3:null) can't find connection: LXC, for vm:
 r-2281-VM, continue
 2015-03-15 16:52:45,677 DEBUG [kvm.resource.LibvirtConnection]
 (agentRequest-Handler-3:null) can't find which hypervisor the vm used ,
 then use the default hypervisor
 2015-03-15 16:52:45,678 DEBUG [kvm.resource.LibvirtComputingResource]
 (agentRequest-Handler-3:null) Failed to get dom xml:
 org.libvirt.LibvirtException: Domain not found: no domain with matching
 name 'r-2281-VM'

  - and BTW - absolutely NOTHING in the libvirt log !


 Here is the full log, with all the steps, on the host that doesnt host any
 other VMs (except one - so log is easy to read) - you can notice after 1st
 fail, agent copies new image/backing file, and tries again with new
 image...

 And BTW, same template is of course used for both System VR and VPC VRs...

 2015-03-15 16:52:30,405 DEBUG [cloud.agent.Agent]
 (agentRequest-Handler-4:null) Request:Seq 1-1823670284:  { Cmd , MgmtId:
 161344838950, via: 1, Ver: v1, Flags: 100011,

 [{org.apache.cloudstack.storage.command.CopyCommand:{srcTO:{org.apache.cloudstack.storage.to.TemplateObjectTO:{path:template/tmpl/2/615/7b06d463-eb70-3e6f-9b12-a5f19ac76b20.qcow2,origUrl:
 http://www.admintweets.com/systemvm64template-4.3-kvm.qcow2.bz2

 ,uuid:66db63ef-7e8d-4d49-9b8a-365babd88732,id:615,format:QCOW2,accountId:2,checksum:70c17810202eb89e0a7e998c38acdf0c,hvm:true,displayText:systemvm-kvm-4.3-ghost,imageDataStore:{com.cloud.agent.api.to.NfsTO:{_url:nfs://
 10.44.253.13/var/lib/libvirt/SECONDARY

 ,_role:Image}},name:615-2-a26a3970-a877-37c4-b74a-16e63206ba60,hypervisorType:KVM}},destTO:{org.apache.cloudstack.storage.to.TemplateObjectTO:{origUrl:
 http://www.admintweets.com/systemvm64template-4.3-kvm.qcow2.bz2

 ,uuid:66db63ef-7e8d-4d49-9b8a-365babd88732,id:615,format:QCOW2,accountId:2,checksum:70c17810202eb89e0a7e998c38acdf0c,hvm:true,displayText:systemvm-kvm-4.3-ghost,imageDataStore:{org.apache.cloudstack.storage.to.PrimaryDataStoreTO:{uuid:1b469c9e-5617-445e-983f-0885a744cab7,id:200,poolType:Filesystem,host:10.44.253.10,path:/var/lib/libvirt/images,port:0,url:Filesystem://

 10.44.253.10//var/lib/libvirt/images/?ROLE=PrimarySTOREUUID=1b469c9e-5617-445e-983f-0885a744cab7
 }},name:615-2-a26a3970-a877-37c4-b74a-16e63206ba60,hypervisorType:KVM}},executeInSequence:false,options:{},wait:10800}}]
 }
 2015-03-15 16:52:30,405 DEBUG [cloud.agent.Agent]
 (agentRequest-Handler-4:null) Processing command:
 org.apache.cloudstack.storage.command.CopyCommand
 2015-03-15 16:52:30,406 DEBUG [kvm.storage.LibvirtStorageAdaptor]
 (agentRequest-Handler-4:null) createStoragePool didn't find existing
 running pool: org.libvirt.LibvirtException: Storage pool not found: no
 storage pool with matching uuid 'M2��N0΁�e���,�, need to create it
 2015-03-15 16:52:30,407 DEBUG [kvm.storage.LibvirtStorageAdaptor]
 (agentRequest-Handler-4:null) Didn't find an existing storage pool
 274d3297-d74e-30ce-81d7-65a3ffe52cfc by UUID, checking for pools with
 duplicate paths
 2015-03-15 16:52:30,407 DEBUG [kvm.storage.LibvirtStorageAdaptor]
 (agentRequest-Handler-4:null) Checking path of existing pool
 1b469c9e-5617-445e-983f-0885a744cab7 against pool we want to create
 2015-03-15 16:52:30,409 DEBUG [kvm.storage.LibvirtStorageAdaptor]
 (agentRequest-Handler-4:null) Checking path of existing pool
 93655746-a9ef-394d-95e9-6e62471dd39f against pool we want to create
 2015-03-15 16:52:30,410 DEBUG [kvm.storage.LibvirtStorageAdaptor]
 (agentRequest-Handler-4:null) Checking path of existing pool
 5b93422e-1a66-353d-88a8-2203f79b1dc6 against pool we want to create
 2015-03-15 16:52:30,412 DEBUG [kvm.storage.LibvirtStorageAdaptor]
 (agentRequest-Handler-4:null) Attempting to create storage pool
 274d3297-d74e-30ce-81d7-65a3ffe52cfc
 2015-03-15 16:52:30,427 DEBUG [kvm.storage.LibvirtStorageAdaptor]
 (agentRequest-Handler-4:null) pool type='netfs'
 name274d3297-d74e-30ce-81d7-65a3ffe52cfc/name
 uuid274d3297-d74e-30ce-81d7-65a3ffe52cfc/uuid
 source
 host name='10.44.253.13'/
 dir path='/var/lib/libvirt/SECONDARY/template/tmpl/2/615'/
 /source
 target
 

Re: db.properties confused

[Laszlo Hornyak]

Hi Daan,

No, I installed a clean environment.



On Sat, Mar 7, 2015 at 6:37 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 Laszlo, I didn't think twice about this but we had that in a prior
 version as well. It is not specific to 4.6. Did you upgrade this
 environment?

 On Fri, Mar 6, 2015 at 6:28 AM, Laszlo Hornyak laszlo.horn...@gmail.com
 wrote:
  Hi,
 
  After cloudstack-setup (4.6, latest) I looked into the db.properties file
  and I have found that the comment lines got mixed into the actual
 content.
  Anyone met this problem?
 
  
 
  # Licensed to the Apache Software Foundation (ASF) under one
  db.usage.maxActive=100
  # or more contributor license agreements.  See the NOTICE file
 
  # distributed with this work for additional information
 
 
  db.cloud.name=cloud
  # with the License.  You may obtain a copy of the License at
  db.cloud.password=ENC(let's skip this part..., but anyways)
  # software distributed under the License is distributed on an
 
  #   http://www.apache.org/licenses/LICENSE-2.0
  # to you under the Apache License, Version 2.0 (the
 
 
 
  # Unless required by applicable law or agreed to in writing,
  # specific language governing permissions and limitations
 
  # License); you may not use this file except in compliance
 
 
  # KIND, either express or implied.  See the License for the
  db.usage.maxWait=1
  # High Availability And Cluster Properties
  db.usage.maxIdle=30
  # CloudStack database settings
  db.cloud.autoReconnectForPools=true
  db.cloud.trustStore=
  db.awsapi.host=localhost
  # in which the management server(Tomcat) is running
  db.usage.name=cloud_usage
  # regarding copyright ownership.  The ASF licenses this file
  # usage database tuning parameters
  db.cloud.poolPreparedStatements=false
 
 
  --
 
  EOF



 --
 Daan




-- 

EOF

Re: Compile CloudStack 4.4.2

[Laszlo Hornyak]

I too ran into this a couple of days before. libvirt.org server is
misbehaving and while the only artifact hosted there is the libvirt jar.
The snapshots should be disabled.

CLOUDSTACK-8304

Changing to releases-only will not 100% solve the problem, but after a
single succesful download it will not fail the build when it is down, so
most likely you will not see it again.
On longer term it would be great to resolve all dependencies from the
central repository. That would more likely be a solution.


On Fri, Mar 6, 2015 at 6:56 AM, Star Guo st...@ceph.me wrote:

 Hi,

 When I compile CloudStack 4.4.2 on CentOS 6.6 x86_64, and the log show as
 below and waiting for long time:

 ###
 [INFO]
 [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @
 cloud-plugin-hypervisor-xenserver ---
 [INFO] Building jar:

 /root/.hudson/jobs/cloudstack-master/workspace/plugins/hypervisors/xenserver
 /target/cloud-plugin-hypervisor-xenserver-4.6.0-SNAPSHOT.jar
 [INFO]
 [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @
 cloud-plugin-hypervisor-xenserver ---
 [INFO]

 [INFO]
 
 [INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.6.0-SNAPSHOT
 [INFO]
 
 Downloading:
 http://libvirt.org/maven2/joda-time/joda-time/maven-metadata.xml
 Mar 06, 2015 1:47:47 PM

 org.apache.maven.wagon.providers.http.httpclient.impl.client.DefaultRequestD
 irector tryExecute
 INFO: I/O exception (java.net.SocketException) caught when processing
 request: Connection reset
 Mar 06, 2015 1:47:47 PM

 org.apache.maven.wagon.providers.http.httpclient.impl.client.DefaultRequestD
 irector tryExecute
 INFO: Retrying request

 Downloading:
 http://libvirt.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom

 Downloading:
 http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom

 ###

 I find
 http://libvirt.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
 is not found, and http://libvirt.org/maven2/org/libvirt/libvirt/0.5.1/ is
 OK.
 And http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom is
 not
 found.

 How to fix this problem ? Thanks.

 Best Regards
 Star Guo





-- 

EOF

db.properties confused

[Laszlo Hornyak]

Hi,

After cloudstack-setup (4.6, latest) I looked into the db.properties file
and I have found that the comment lines got mixed into the actual content.
Anyone met this problem?



# Licensed to the Apache Software Foundation (ASF) under one
db.usage.maxActive=100
# or more contributor license agreements.  See the NOTICE file

# distributed with this work for additional information


db.cloud.name=cloud
# with the License.  You may obtain a copy of the License at
db.cloud.password=ENC(let's skip this part..., but anyways)
# software distributed under the License is distributed on an

#   http://www.apache.org/licenses/LICENSE-2.0
# to you under the Apache License, Version 2.0 (the



# Unless required by applicable law or agreed to in writing,
# specific language governing permissions and limitations

# License); you may not use this file except in compliance


# KIND, either express or implied.  See the License for the
db.usage.maxWait=1
# High Availability And Cluster Properties
db.usage.maxIdle=30
# CloudStack database settings
db.cloud.autoReconnectForPools=true
db.cloud.trustStore=
db.awsapi.host=localhost
# in which the management server(Tomcat) is running
db.usage.name=cloud_usage
# regarding copyright ownership.  The ASF licenses this file
# usage database tuning parameters
db.cloud.poolPreparedStatements=false


-- 

EOF

Re: Build CloudStack 4.4.3-SNAPSHOT Error

[Laszlo Hornyak]

Hi,

Just curious, if you run into that issue again, could you share the full
build log?
The ceph repo seems to be all right, simply the libvirt 0.5.1 artifact is
not hosted there and maybe it shouldn't since it is not really related to
ceph. That version is hosted only in libvirt's own repo:
http://www.libvirt.org/maven2/ and that repo link is there in the pom so
the problem is that this repo was not used, or it was unavailable at the
moment.


On Tue, Mar 3, 2015 at 11:26 AM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 Star Guo,

 I am getting this error as well. Will try to build another version now.

 On Tue, Mar 3, 2015 at 2:59 AM, Star Guo st...@ceph.me wrote:
  Hi, all,
 
 
 
  When I git clone form github, and run command mvn -Pawsapi,systemvm
  -Dnoredist package, and hold on this for long time:
 
 
 
  [INFO]
 
  [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @
  cloud-plugin-hypervisor-xen ---
 
  [INFO] Building jar:
 
 /root/release/gci-cloud-apple-2015-03-03/plugins/hypervisors/xen/target/clou
  d-plugin-hypervisor-xen-4.4.3-SNAPSHOT.jar
 
  [INFO]
 
  [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @
  cloud-plugin-hypervisor-xen ---
 
  [INFO]
 
 
  [INFO]
  
 
  [INFO] Building Apache CloudStack Plugin - Hypervisor KVM 4.4.3-SNAPSHOT
 
  [INFO]
  
 
  Downloading:
  http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
 
 
 
  Is the pom removed form ceph.com ? I get 404 stat while access the url.
 Can
  I change other mirrors ? Thanks.
 
 
 
 
 
  Best Regards,
 
  Star Guo
 



 --
 Daan




-- 

EOF

Re: [ANNOUNCE] New committer: Wilder Rodrigues

[Laszlo Hornyak]

Congratulations Wilder!

On Sun, Mar 1, 2015 at 11:14 AM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 The Project Management Committee (PMC) for Apache CloudStack
 has asked Wilder Rodrigues to become a committer and we are pleased to
 announce that he has accepted.

 Keep up the good work and your contagious good spirit Wilder.

 Being a committer allows many contributors to contribute more
 autonomously. For developers, it makes it easier to submit changes and
 eliminates the need to have contributions reviewed via the patch
 submission process. Whether contributions are development-related or
 otherwise, it is a recognition of a contributor's participation in the
 project and commitment to the project and the Apache Way.

 Please join me in congratulating Wilder.

 --
 on behalf of the CloudStack PMC,
 Daan




-- 

EOF

Re: java 1.8?

[Laszlo Hornyak]

Hi Daan,

Ok, that's good news, consistent behaviour :-)
I will try to solve the java8 issues, it is needed to finish fedora21
packaging anyway.


On Tue, Feb 24, 2015 at 9:43 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 Laszlo, I didn't try recently but unit tests failed when I first
 tried. we should be rather fine, though. unless I missed a
 deprecation.

 On Tue, Feb 24, 2015 at 9:37 PM, Laszlo Hornyak
 laszlo.horn...@gmail.com wrote:
  Hi,
 
  Oracle published a warning on java 1.7 EOL a few months ago and just
  recently I noticed that there is no java 1.7 in Fedora 21 at all.
  At the same time I have some problems building CS on Fedora 21 + OpenJDK
  1.8 (CLOUDSTACK-8279)
 
  What are the plans from the JDK-compatibility perspective?
  Anyone having the same problems with the tests in java 1.8?
 
  Regards,
  Laszlo
 
  --
 
  EOF



 --
 Daan




-- 

EOF

java 1.8?

[Laszlo Hornyak]

Hi,

Oracle published a warning on java 1.7 EOL a few months ago and just
recently I noticed that there is no java 1.7 in Fedora 21 at all.
At the same time I have some problems building CS on Fedora 21 + OpenJDK
1.8 (CLOUDSTACK-8279)

What are the plans from the JDK-compatibility perspective?
Anyone having the same problems with the tests in java 1.8?

Regards,
Laszlo

-- 

EOF

Re: Christmas gifts

[Laszlo Hornyak]

Nice idea, Santa Cloud will surely appreciate :-)
I have sent mine already, comments are welcome.


On Fri, Dec 19, 2014 at 10:24 AM, Sebastien Goasguen run...@gmail.com
wrote:

 It's christmas folks…

 Let's all send a pull request to cloudstack :)

 -seb




-- 

EOF

Re: KVM - VM snapshot (round 2)

[Laszlo Hornyak]

It is still doing the same, I suspect that this is an intentional behavior
of qemu, it keeps the disk space for future use. However I haven't found
any documentation on how users should free the space.



On Mon, Dec 8, 2014 at 12:32 PM, Wei ZHOU ustcweiz...@gmail.com wrote:

 As far as I know, KVM does support memory snapshot.
 The shortcoming is libvirt-java supports only internal snapshot (not
 external snapshots) for now.
 In this case, the memory snapshot will be attached to the qcow2 file, and
 the qcow2 will grow even after we remove the memory snapshot.

 I've changed and tested on 4.2 before, but not pushed into production.

 An email from the Mice, the developer of this functionality:
 http://cloudstack.markmail.org/message/c3hkpxbad6ul4mza

 -Wei

 2014-12-08 12:11 GMT+01:00 Vadim Kimlaychuk vadim.kimlayc...@elion.ee:

  CS does not support memory snapshots for XenServer. Disk snapshots are
  working. Not sure about VmWare, but I guess it should be the same. I
  thought the reachest feature-set is developed for KVM. But if it does not
  support memory snapshots - I wonder wich hypervisor does it ? This option
  at user interface exists, but I didn't see it worked.
 
  Vadim.
 
 
  -Original Message-
  From: Andrija Panic [mailto:andrija.pa...@gmail.com]
  Sent: Monday, December 08, 2014 12:51 PM
  To: dev@cloudstack.apache.org; us...@cloudstack.apache.org
  Subject: KVM - VM snapshot (round 2)
 
  Hi guys,
 
  still wondering is there any interest into imlementing the VM snapshoot
  for KVM ?
 
  We desperately need it, so will try to contribute anyway we can (not me
  obviosuly, not a developer, but my colegues will).
 
  Can you give some guidance on this subject - I'm aware of the design
  documents here
  https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots but
  any more input would be very much appriciated.
 
  I understand, that VMware/Xen natively support this, and that it might
  have bigger user-base for Xen VS KVM - but this is one of the major KVM
  missing features...
 
  Any input greatly appreciated...
 
  --
 
  Andrija Panić
 




-- 

EOF

Re: Review Request 20343: WIP: Force reload of the JS files only in MSIE

[Laszlo Hornyak]

 On Dec. 5, 2014, 6:03 p.m., Rohit Yadav wrote:
  Hey Laszlo, that's a nice feature please advise if you want to submit a 
  tested patch that applies on master or you want to close it?
  Thanks.

Hi Rohit,

I plan to finish all tests in the next few weeks/days and send a fully tested 
version, however we can use github for the reviews, so I will just close this 
for now.

Thank you,
Laszlo


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/#review64025
---


On April 15, 2014, 6:13 a.m., Laszlo Hornyak wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20343/
 ---
 
 (Updated April 15, 2014, 6:13 a.m.)
 
 
 Review request for cloudstack.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
  - use the User-Agent header to get the client type
  - only use the cache workaround if the browser is MSIE, use standard cache 
 control headers anyway
 
 
 Diffs
 -
 
   ui/index.jsp 5840e71 
   utils/pom.xml cc6de3b 
   utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION 
   utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/20343/diff/
 
 
 Testing
 ---
 
 -unit testing
 -tests with firefox
 - tests with IE
 - tests with modified files
 
 
 Thanks,
 
 Laszlo Hornyak
 

Re: NPE while adding a host

[Laszlo Hornyak]

Hi,

Indeed that patch should not have been sent upstream, I am reverting it,
sorry for the inconvenience.

On Wed, Dec 3, 2014 at 12:38 PM, Wei ZHOU ustcweiz...@gmail.com wrote:

 It looks related to commit 31db58f7204ac8bb434599ff51d794640718845c

 2014-12-03 9:47 GMT+01:00 Kuang-Ching Wang kuangching.w...@gmail.com:

  Hi, with the latest master, while adding the first host I saw the
  following NPE in ApiDBUtils.java.  Any insight what might I have missed?
 
  2014-12-03 00:32:41,694 DEBUG [c.c.a.ApiServlet]
  (catalina-exec-4:ctx-8caaed15) ===START===  10.1.13.69 -- GET
 
 command=listHostsresponse=jsonsessionkey=S6b4kjRLRd6vYcUU4uR8xqH%2F0lo%3Dtype=routingpage=1pagesize=1_=1417595569129
  2014-12-03 00:32:41,696 DEBUG [c.c.a.q.QueryManagerImpl]
  (catalina-exec-4:ctx-8caaed15 ctx-a7bc81da) Searching for hosts
  2014-12-03 00:32:41,701 DEBUG [c.c.a.q.QueryManagerImpl]
  (catalina-exec-4:ctx-8caaed15 ctx-a7bc81da) Generating Response
  2014-12-03 00:32:41,702 ERROR [c.c.a.ApiServer]
  (catalina-exec-4:ctx-8caaed15 ctx-a7bc81da) unhandled exception executing
  api command: [Ljava.lang.String;@7bb3621
  java.lang.NullPointerException
  at
 com.cloud.api.ApiDBUtils.getHostStatistics(ApiDBUtils.java:892)
  at
 
 com.cloud.api.query.dao.HostJoinDaoImpl.newHostResponse(HostJoinDaoImpl.java:179)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at
 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
  at
 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:606)
  at
 
 org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
  at
 
 org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
  at
 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
  at
 
 com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34)
  at
 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
  at
 
 org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
  at
 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
  at
 
 org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
  at com.sun.proxy.$Proxy274.newHostResponse(Unknown Source)
  at com.cloud.api.ApiDBUtils.newHostResponse(ApiDBUtils.java:1738)
  at
 
 com.cloud.api.query.ViewResponseHelper.createHostResponse(ViewResponseHelper.java:236)
  at
 
 com.cloud.api.query.QueryManagerImpl.searchForServers(QueryManagerImpl.java:1551)
  at
 
 org.apache.cloudstack.api.command.admin.host.ListHostsCmd.execute(ListHostsCmd.java:186)
  at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:141)
  at com.cloud.api.ApiServer.queueCommand(ApiServer.java:698)
  at com.cloud.api.ApiServer.handleRequest(ApiServer.java:523)
  at
  com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:283)
  at com.cloud.api.ApiServlet$1.run(ApiServlet.java:127)
  at
 
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
  at
 
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
  at
 
 org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
  at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:124)
  at com.cloud.api.ApiServlet.doGet(ApiServlet.java:86)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
  at
 
 org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
  at
 
 org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
  at
 
 org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
  at
 
 org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
  at
 
 org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
  at
 
 org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
  at
  org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:615)
  at
 
 org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
  at
 
 org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
  at
 
 

Re: [QUESTION] @ReflectionUse

[Laszlo Hornyak]

Hi,

How about declaring those methods package protected? With that it is
still not considered a public api, but findbugs does not detect it as a bug.

Also, it would be nice to have some javadoc on these methods on how they
are used, what calls them, etc...

On Fri, Nov 28, 2014 at 10:14 AM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 Are we going to (and can we) add functionality to make the code
 quality tools recognise it? (or is it just there to ignore?

 On Fri, Nov 28, 2014 at 5:00 AM, Rajani Karuturi raj...@apache.org
 wrote:
  It came in through the discussion on this thread
  http://markmail.org/message/j7ird7yzb3pvszbw
 
 
  ~Rajani
 
  On Thu, Nov 27, 2014 at 11:28 PM, Min Chen min.c...@citrix.com wrote:
 
  If I understand this clearly, this annotation was introduced by Kelven
 to
  prevent people from mistakenly removing those annotated methods if they
  find from IDE that those methods are not explicitly called anywhere.
 These
  methods are actually invoked through reflection.
 
  Thanks
  -min
 
 
 
   On Nov 27, 2014, at 3:21 AM, Daan Hoogland daan.hoogl...@gmail.com
 
  wrote:
  
   H Kelven (or others),
  
   What are the plans with this annotation, ReflectionUse. Is there to be
   an implementation or folow up or is it maybe just there to ignore?
  
   --
   Daan
 



 --
 Daan




-- 

EOF

Re: unit tests not working from eclipse

[Laszlo Hornyak]

Hi Daan,

It works for me on master, but it happens that eclipse messes up
things.Clean and rebuild? Possibly the project descriptors are not in sync
with maven pom files?


On Tue, Jul 15, 2014 at 4:18 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 H,

 a silly mistake probably: none of the unit tests I try to run from
 eclipse work. they all report (test-) class not found. I have tried
 several from server and utils so far. The target/test-classes is
 configured in both projects. tests are passing beyond server on the
 cli with mvn test.

 Anyone that can show me the err of my ways?

 thanks,
 --
 Daan




-- 

EOF

Re: hackathon CCCEU14

[Laszlo Hornyak]

Whatever I find company for, because sitting and working alone is what I
can do anytime :-)


On Fri, Jun 13, 2014 at 10:04 AM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 kocka, go ahead and edit (though you can't work on all of those
 subjects during the hackathon, hope you realize that)

 On Thu, Jun 12, 2014 at 7:46 PM, Laszlo Hornyak
 laszlo.horn...@gmail.com wrote:
  Hi,
 
  Could you give me write permission to the wiki? Or you can just add me to
  the wikipage, I will want to work a little bit on all of those :)
 
  Thank you,
  Laszlo
 
 
  On Tue, Jun 10, 2014 at 2:35 PM, Daan Hoogland daan.hoogl...@gmail.com
  wrote:
 
  Hello everybody,
 
  Do we still want to have a Hackathon next CCC? we need to plan for the
  resources (noticably the room) pretty soon.
 
  On Thu, Jun 5, 2014 at 12:01 PM, Daan Hoogland
  dhoogl...@schubergphilis.com wrote:
   People,
  
   I added two more hackathon subjects at
 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Collaboration+Conference+EU
   In doing so I saw no moderators on the hackathons that were already
  announced. We need moderators to have successful hackathons. If  you
 feel a
  hackathon subject is important enough to go through, please add your
 name
  in the wiki. Only hackathons with enough attendance will have resources
  assigned at the conference.
  
   \DaanH
  
 
 
 
  --
  Daan
 
 
 
 
  --
 
  EOF



 --
 Daan




-- 

EOF

Re: hackathon CCCEU14

[Laszlo Hornyak]

Hi,

Could you give me write permission to the wiki? Or you can just add me to
the wikipage, I will want to work a little bit on all of those :)

Thank you,
Laszlo


On Tue, Jun 10, 2014 at 2:35 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 Hello everybody,

 Do we still want to have a Hackathon next CCC? we need to plan for the
 resources (noticably the room) pretty soon.

 On Thu, Jun 5, 2014 at 12:01 PM, Daan Hoogland
 dhoogl...@schubergphilis.com wrote:
  People,
 
  I added two more hackathon subjects at
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Collaboration+Conference+EU
  In doing so I saw no moderators on the hackathons that were already
 announced. We need moderators to have successful hackathons. If  you feel a
 hackathon subject is important enough to go through, please add your name
 in the wiki. Only hackathons with enough attendance will have resources
 assigned at the conference.
 
  \DaanH
 



 --
 Daan




-- 

EOF

[PROPOSAL] KSM support for KVM hosts

[Laszlo Hornyak]

Hi All,

Currently Cloudstack does not manage the Linux Kernel SamePage Merger [1].
A KSM support would allow the operator of the cloud to gain high VM
densities in the cloudstack environment by merging the redundant memory
pages.

1. Add new configuration setting for KSM feature
- Ignore: Instructs agent to ignore KSM setting, this allows the cloud
operator to manage KSM and good for backward compatibility
- On: Instructs agents to turn on KSM without further dealing with it
- Off: Instructs agents to turn off KSM
- Dynamic: Instructs the agent to track KSM activity periodically, turn on
or off if needed and fine-tune runtime parameters based on its performance.

2. Build decision logic into cloudstack agent:
- Only enable KSM if running on Linux and KSM is built into kernel
- Dynamic KSM configuration decision logic:
  - Configure and tune KSM based on number of VM's, their operating
systems, the available and free processors and memory of the host.
  - The configuration and status of ksm needs to be checked periodically.

In comparison to ksmtuned, the agent logic will build on information
specific to cloud computing
 - build on expectations based on the OS/template of the VM
 - scale dynamically with the VM loads
 - activate on VM migrations/start/stop
 - respect CPU over-allocation, run ksm only when low CPU-load

[1] https://www.kernel.org/doc/Documentation/vm/ksm.txt

-- 

EOF

Re: [PROPOSAL] KSM support for KVM hosts

[Laszlo Hornyak]

Hi David,

The ksmd process takes quite some CPU time and keeps it at a constant level
even when it is no longer able to find new pages to merge. The trick the
dynamic configuration would do is to decide when is it safe to take some
CPU-time and spend it on decreasing memory usage. Since in the agent
(unlike in the linux kernel) we have access to information about this, I
have reason to believe that it is possible to avoid conflict between
household tasks and VM tasks in CPU.

A logical next step would be to modify the scheduler/orchestration to take
VM attributes in consideration and prefer similar VMs on the same host to
better operate with ksm.

Probably VMs could also gain from the same page merging, for example the
CPU cache misses could be less frequent if their pages are merged.

On Sun, Apr 27, 2014 at 5:08 PM, David Nalley da...@gnsa.us wrote:

 On Sun, Apr 27, 2014 at 3:48 AM, Laszlo Hornyak
 laszlo.horn...@gmail.com wrote:
  Hi All,
 
  Currently Cloudstack does not manage the Linux Kernel SamePage Merger
 [1].
  A KSM support would allow the operator of the cloud to gain high VM
  densities in the cloudstack environment by merging the redundant memory
  pages.
 
  1. Add new configuration setting for KSM feature
  - Ignore: Instructs agent to ignore KSM setting, this allows the cloud
  operator to manage KSM and good for backward compatibility
  - On: Instructs agents to turn on KSM without further dealing with it
  - Off: Instructs agents to turn off KSM
  - Dynamic: Instructs the agent to track KSM activity periodically, turn
 on
  or off if needed and fine-tune runtime parameters based on its
 performance.
 
  2. Build decision logic into cloudstack agent:
  - Only enable KSM if running on Linux and KSM is built into kernel
  - Dynamic KSM configuration decision logic:
- Configure and tune KSM based on number of VM's, their operating
  systems, the available and free processors and memory of the host.
- The configuration and status of ksm needs to be checked periodically.
 
  In comparison to ksmtuned, the agent logic will build on information
  specific to cloud computing
   - build on expectations based on the OS/template of the VM
   - scale dynamically with the VM loads
   - activate on VM migrations/start/stop
   - respect CPU over-allocation, run ksm only when low CPU-load
 
  [1] https://www.kernel.org/doc/Documentation/vm/ksm.txt
 
  --
 
  EOF


 Hi Laszlo;

 KSM has always seemed to have a high CPU overhead when I've used it in
 the real world. I am curious what you think the effect will be with
 dynamically turning it on/off and particularly how it might impact
 other VM operations as well as allocation decisions.

 --David




-- 

EOF

Re: HypervisorType - possible feature idea

[Laszlo Hornyak]

Hi Sam,

I think it would take a big lot of work but the direction is nice.
A lot of classes would have to be modified to be plugable, and possibly the
Hypervisor interface would grow big to support all these cases.

There are 1097 references to HypervisorType according to eclipse.


On Thu, Apr 24, 2014 at 10:57 PM, Sam Schmit sam.sch...@appcore.com wrote:

 Hello everyone,

 I've recently started working with Cloudstack, and was going through the
 codebase and had a question about a possible feature for future versions -
 making the HypervisorType more dynamic.  Right now, it seems there are
 several places where specific types are referenced.  I would like to make
 it more dynamic - have hypervisors be a pluggable type so that any
 hypervisor can be added using the Cloudstack plugin architecture.

 I've taken a look at the existing code, and it seems as though the enum is
 used not just by the hypervisor's discoverer class, but also by other
 classes/methods to say which hypervisors they work with or are looking for.

 Is there a reason it's done this way, instead of generating a dynamic list
 of hypervisors that are supported at run-time?  Have there been attempts to
 make this change in the past?  Has anyone begun work on this feature
 already?  Anyone have thoughts on where the easy/difficult areas for such
 an undertaking would reside?

 Thanks for any thoughts on this, and I look forward to working with
 everyone in the near future.

 Sam Schmit




-- 

EOF

Re: Review Request 12228: static resource compression

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review41058
---


ping?

- Laszlo Hornyak


On April 18, 2014, 11:08 p.m., Laszlo Hornyak wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12228/
 ---
 
 (Updated April 18, 2014, 11:08 p.m.)
 
 
 Review request for cloudstack, Brian Federle, Darren Shepherd, Jessica Wang, 
 and Prasanna Santhanam.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CloudStack at first use downloads some 3.5 MB of css and javascript to the 
 client. With a weak internet connection, this might take a long time. With 
 gzip compression content can be compressed to 850 KB.
 
 This version of the patch uses a custom plugin to compress static resources, 
 so that no dynamic compression is needed at runtime. When the static resource 
 servlet notices that there is gzipped version of the resource and the client 
 accepts gzipped content, then it is going to send the gziped version, while 
 still respects http caching.
 
 
 Diffs
 -
 
   client/WEB-INF/web.xml 1af38e1 
   client/pom.xml aee2672 
   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/12228/diff/
 
 
 Testing
 ---
 
 yes, tested with firefox and chrome
 
 
 Thanks,
 
 Laszlo Hornyak
 

Re: Anybody experienced test failure on master?

[Laszlo Hornyak]

Hi Min,

Can you send details, stack traces?

Thank you,
Laszlo


On Fri, Apr 18, 2014 at 2:33 AM, Min Chen min.c...@citrix.com wrote:

 Hi there,

 Did anybody experience test failure on master branch? I got this:


  T E S T S
 ---
 Running com.cloud.utils.DbUtilTest
 log4j:WARN No appenders could be found for logger
 (com.cloud.utils.crypt.EncryptionSecretKeyChecker).
 log4j:WARN Please initialize the log4j system properly.
 log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
 more info.
 Tests run: 28, Failures: 0, Errors: 26, Skipped: 2, Time elapsed: 0.525
 sec  FAILURE!

 Results :

 Tests in error:
   getTableName(com.cloud.utils.DbUtilTest)
   getTableName(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   closeStatement(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   closeStatement(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   closeStatementFail(com.cloud.utils.DbUtilTest): Could not initialize
 class com.cloud.utils.db.TransactionLegacy
   closeStatementFail(com.cloud.

 Thanks
 -min




-- 

EOF

Re: Upgraded from 4.2.1 to 4.3.0 getting a http 404 error

[Laszlo Hornyak]

Hi,

The mysql driver is not available for CS, that is the trouble. Please check
that the mysql jar files are in classpath.


On Fri, Apr 18, 2014 at 8:06 PM, Michael Phillips
mphilli7...@hotmail.comwrote:

 Did an upgrade from 4.2.1 to 4.3.0 on ubuntu, and now I am getting the
 following error.
 http://imgur.com/PonNMYL
 Any advise?
 Logs show a few errors:Mgmt server log error = java.sql.SQLException: No
 suitable driver found for
 jdbc:mysql://mysqldbserver:3306/cloud?autoReconnect=trueprepStmtCacheSize=517cachePrepStmts=truecatalina
 log = INFO:
 validateJarFile(/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/servlet-api-2.5-20081211.jar)
 - jar not loaded. See Servlet Spec 2.3, section 9.7.2. Offending class:
 javax/servlet/Servlet.classcatalina log = INFO:
 validateJarFile(/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/tomcat-embed-core-7.0.30.jar)
 - jar not loaded. See Servlet Spec 2.3, section 9.7.2. Offending class:
 javax/servlet/Servlet.class





-- 

EOF

Re: Build failed in Jenkins: build-master-slowbuild #630

[Laszlo Hornyak]

Something wrong with jenkins, it breaks the build because of a new high
priority findbugs warning, but it can not tell which one is that.


On Fri, Apr 18, 2014 at 11:57 PM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 Min,

 Can you have a look at these comits? The slowbuild has been failing since
 these.

 On Fri, Apr 18, 2014 at 7:02 AM,  jenk...@cloudstack.org wrote:
  See 
 http://jenkins.buildacloud.org/job/build-master-slowbuild/630/changes
 
  Changes:
 
  [min.chen] Handle listAll flag in IAM buildAclSearchParameters.
 
  [min.chen] Fix RoleBasedQuerySelector to handle new listAll semantics. If
 
  [min.chen] CLOUDSTACK-6350: IAM - Listing of VM using uuid when owner
 account of
 
  [min.chen] CLOUDSTACK-5960: Remove another check preventing Domain admin
 and
 
  [min.chen] CLOUDSTACK-6428:IAM - Domain Admin - When his sub-domainId is
 passed to
 
  [min.chen] CLOUDSTACK-6429:distinguish the case where caller can see
 everything and
 
  [min.chen] Fix IAM list api implementation based on agreed
 interpretation for
 
  --
  [...truncated 18172 lines...]
 
  Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
 
  [INFO]
  [INFO]  cobertura-maven-plugin:2.6:cobertura (default-cli) @
 cloud-awsapi 
  [INFO]
  [INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @
 cloud-awsapi ---
  [INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT
 file
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/amazon/ec2/AmazonEC2SkeletonInterface.java.  Ensure this class was
 instrumented, and this data file contains the instrumentation information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/amazon/s3/AmazonS3SkeletonInterface.java.  Ensure this class was
 instrumented, and this data file contains the instrumentation information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/cloud/bridge/model/SAcl.java.  Ensure this class was instrumented, and
 this data file contains the instrumentation information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/cloud/bridge/model/SBucket.java.  Ensure this class was instrumented,
 and this data file contains the instrumentation information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/cloud/bridge/model/SHost.java.  Ensure this class was instrumented, and
 this data file contains the instrumentation information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/cloud/bridge/persist/dao/BucketPolicyDao.java.  Ensure this class was
 instrumented, and this data file contains the instrumentation information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/cloud/bridge/persist/dao/CloudStackAccountDao.java.  Ensure this class
 was instrumented, and this data file contains the instrumentation
 information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java.  Ensure this
 class was instrumented, and this data file contains the instrumentation
 information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java.  Ensure this
 class was instrumented, and this data file contains the instrumentation
 information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/cloud/bridge/persist/dao/CloudStackUserDao.java.  Ensure this class was
 instrumented, and this data file contains the instrumentation information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/cloud/bridge/persist/dao/MHostDao.java.  Ensure this class was
 instrumented, and this data file contains the instrumentation information.
  [cobertura] INFO  [main]
 net.sourceforge.cobertura.reporting.html.HTMLReport - Data file does not
 contain instrumentation information for the file
 com/cloud/bridge/persist/dao/MHostMountDao.java.  Ensure this class was
 instrumented, and this data file contains the 

Re: Review Request 12228: static resource compression

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
---

(Updated April 18, 2014, 11:08 p.m.)


Review request for cloudstack, Brian Federle, Darren Shepherd, Jessica Wang, 
and Prasanna Santhanam.


Changes
---

removed a pair of critical trailing white spaces


Repository: cloudstack-git


Description
---

CloudStack at first use downloads some 3.5 MB of css and javascript to the 
client. With a weak internet connection, this might take a long time. With gzip 
compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so 
that no dynamic compression is needed at runtime. When the static resource 
servlet notices that there is gzipped version of the resource and the client 
accepts gzipped content, then it is going to send the gziped version, while 
still respects http caching.


Diffs (updated)
-

  client/WEB-INF/web.xml 1af38e1 
  client/pom.xml aee2672 
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12228/diff/


Testing
---

yes, tested with firefox and chrome


Thanks,

Laszlo Hornyak

Re: Review Request 17335: cleanup around seemingly impossible cast

[Laszlo Hornyak]

 On April 17, 2014, 2:08 p.m., daan Hoogland wrote:
  Lazslo, you still want this reviewed/applied?

Yes a review would be nice


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/#review40645
---


On Feb. 2, 2014, 5:03 p.m., Laszlo Hornyak wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/17335/
 ---
 
 (Updated Feb. 2, 2014, 5:03 p.m.)
 
 
 Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
  - changed type parameters on details map in CreateSecondaryStagingStoreCmd - 
 String, String was misleading since the it can not work with a string value 
 and it is never a string
  - introducing the type parameters allowed some simplifications in 
 getDetails()
  - added unit test
 
 
 Diffs
 -
 
   
 api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java
  1480e75 
   
 api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java
  PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/17335/diff/
 
 
 Testing
 ---
 
 - all unit tests passed
 - checked all references and usage of the details field, injection with the 
 @Parameter annotation
 
 
 Thanks,
 
 Laszlo Hornyak
 

Re: Review Request 20343: WIP: Force reload of the JS files only in MSIE

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/
---

(Updated April 15, 2014, 6:13 a.m.)


Review request for cloudstack.


Repository: cloudstack-git


Description
---

 - use the User-Agent header to get the client type
 - only use the cache workaround if the browser is MSIE, use standard cache 
control headers anyway


Diffs
-

  ui/index.jsp 5840e71 
  utils/pom.xml cc6de3b 
  utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION 
  utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/20343/diff/


Testing (updated)
---

-unit testing
-tests with firefox
- tests with IE
- tests with modified files


Thanks,

Laszlo Hornyak

Re: Review Request 20343: WIP: Force reload of the JS files only in MSIE

[Laszlo Hornyak]

 On April 15, 2014, 5:11 a.m., Rajani Karuturi wrote:
  utils/src/com/cloud/utils/servlet/CacheControlUtil.java, line 24
  https://reviews.apache.org/r/20343/diff/1/?file=557372#file557372line24
 
  Hi Laszlo,
  Is there any reason to disable browser caching for IE?
  I think we should just remove the t param for all the js files and let 
  browsers cache them.

Hi Rajani,

I will check that again but I believe IE might be the reason why that t param 
is there. Actually I have ran into a couple of situations in other projects 
where IE did not send another request for the resource when only sending 
Last-Modified and ETag headers, so these resources remained outdated after page 
refresh.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/#review40348
---


On April 15, 2014, 6:13 a.m., Laszlo Hornyak wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20343/
 ---
 
 (Updated April 15, 2014, 6:13 a.m.)
 
 
 Review request for cloudstack.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
  - use the User-Agent header to get the client type
  - only use the cache workaround if the browser is MSIE, use standard cache 
 control headers anyway
 
 
 Diffs
 -
 
   ui/index.jsp 5840e71 
   utils/pom.xml cc6de3b 
   utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION 
   utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/20343/diff/
 
 
 Testing
 ---
 
 -unit testing
 -tests with firefox
 - tests with IE
 - tests with modified files
 
 
 Thanks,
 
 Laszlo Hornyak
 

Review Request 20343: WIP: Force reload of the JS files only in MSIE

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

 - use the User-Agent header to get the client type
 - only use the cache workaround if the browser is MSIE, use standard cache 
control headers anyway


Diffs
-

  ui/index.jsp 5840e71 
  utils/pom.xml cc6de3b 
  utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION 
  utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/20343/diff/


Testing
---

-unit testing
-tests with firefox

TODO:
- tests with IE
- tests with modified files


Thanks,

Laszlo Hornyak

Re: [Proposal] Integrating Apache Stratos with Apache CloudStack.

[Laszlo Hornyak]

This would be a nice combination, I believe I would find it quite useful.


On Tue, Apr 8, 2014 at 9:41 PM, Nguyen Anh Tu t...@apache.org wrote:

 Dear guys,

 It's not really a full proposal right now, I just wanna bump a thread to
 discuss about working on integrating Stratos to CloudStack. Chris Snow and
 I are working on the design process. Keep update soon!

 Chris, could you keep update on this thread?

 Thanks,
 --Tuna




-- 

EOF

Re: Review Request 19917: Improvements on exception handlers (JIRA-6242)

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19917/#review39320
---


+1
nice work!

- Laszlo Hornyak


On April 2, 2014, 1:55 p.m., Ding Yuan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19917/
 ---
 
 (Updated April 2, 2014, 1:55 p.m.)
 
 
 Review request for cloudstack.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 This is the patch for JIRA-6242. See 
 https://issues.apache.org/jira/browse/CLOUDSTACK-6242 for more details. 
 Thanks!
 
 
 Diffs
 -
 
   engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java 
 0d41bc1 
   
 engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
  01508a4 
   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
 3e088db 
   
 engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineDataCenterDaoImpl.java
  4b6818e 
   engine/schema/src/com/cloud/dc/dao/DataCenterDaoImpl.java ea5039f 
   engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 426c90d 
   engine/schema/src/com/cloud/storage/dao/StoragePoolHostDaoImpl.java e42eaf4 
   engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 34fdca5 
   engine/schema/src/com/cloud/upgrade/dao/Upgrade2214to30.java 58dd916 
   engine/schema/src/com/cloud/vm/dao/ConsoleProxyDaoImpl.java 5e9c2f0 
   engine/schema/src/com/cloud/vm/dao/SecondaryStorageVmDaoImpl.java 1f382d6 
   
 engine/storage/src/org/apache/cloudstack/storage/datastore/DataObjectManagerImpl.java
  6ed1274 
   
 framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
  83c8a42 
   
 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
  0ad6dc4 
   
 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java
  b779085 
   
 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageProcessor.java
  e512046 
   
 plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/lifecycle/SolidFirePrimaryDataStoreLifeCycle.java
  af6a77a 
   server/src/com/cloud/resource/ResourceManagerImpl.java f9a59ba 
   server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 
   
 services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyThumbnailHandler.java
  06f21d3 
   utils/src/com/cloud/utils/net/NetUtils.java 6350986 
 
 Diff: https://reviews.apache.org/r/19917/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ding Yuan
 

Re: [4.4] build failing at awsapi

[Laszlo Hornyak]

ok, trying to reproduce...
meanwhile... do you have some extra repository, proxy, etc defined in
~/.m2/settings.xml?


On Tue, Apr 1, 2014 at 10:11 PM, Paul Angus paul.an...@shapeblue.comwrote:

 Thanks Laszlo,

 I cleared ~.m2/repository, but the maven still goes back to that repo when
 I build cloudstack.

 Regards

 Paul Angus
 Cloud Architect
 S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
 paul.an...@shapeblue.com

 -Original Message-
 From: Laszlo Hornyak [mailto:laszlo.horn...@gmail.com]
 Sent: 01 April 2014 20:49
 To: dev@cloudstack.apache.org
 Subject: Re: [4.4] build failing at awsapi

 Hi Paul,

 I just checked it and looks like I too had some dependencies resolved from
 there, but apparently they were not from cloudstack.
 This shibboleth repo was moved last year and it broke quite a lot of
 things. Today the maven central repo maintainers do not allow uploading
 artifacts depending on other repositories than maven central.

 fix:
 cd ~.m2/repository
 grep shibboleth . -r
 and rm -rf all that matches

 A complete rm ~/.m2/repository may also solve the problems, and after that
 it should work.


 On Tue, Apr 1, 2014 at 5:40 PM, Paul Angus paul.an...@shapeblue.com
 wrote:

   Hi I'm getting the following errors when building 4.4 noredist:
 
 
 
  [ERROR] Failed to execute goal
  org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
  (default-compile) on project cloud-awsapi: Compilation failure:
  Compilation
  failure:
 
  [ERROR] error: error reading
  /root/.m2/repository/org/codehaus/woodstox/wstx-asl/3.2.4/wstx-asl-3.2
  .4.jar;
  error in opening zip file
 
  [ERROR] error: error reading
  /root/.m2/repository/org/apache/axis2/mex/1.5.4/mex-1.5.4-impl.jar;
  error in opening zip file
 
  [ERROR] error: error reading
  /root/.m2/repository/org/apache/axis2/axis2-mtompolicy/1.5.4/axis2-mto
  mpolicy-1.5.4.jar;
  error in opening zip file
 
  [ERROR] error: error reading
  /root/.m2/repository/org/apache/ws/commons/axiom/axiom-dom/1.2.10/axio
  m-dom-1.2.10.jar;
  error in opening zip file
 
  [ERROR] error: error reading
  /root/.m2/repository/commons-lang/commons-lang/2.3/commons-lang-2.3.ja
  r;
  error in opening zip file
 
 
 
  It seems to be being caused by one repo:  shibboleth.internet2.edu
  which has moved/removed its maven repo, so returns a webpage instead
  of a pom or a jar.
 
 
 
  I can't find a way to blacklist shibboleth.internet2.edu
 
 
 
  Any ideas anyone?
 
 
 
  Regards
 
 
 
  Paul Angus
 
  *Senior Consultant / Cloud Architect*
 
 
 
  [image: cid:image002.png@01CE1071.C6CC9C10]
 
 
 
  S: +44 20 3603 0540 +442036030540 | M: +4 +44796816158147711418784
  |
  T: @CloudyAngus
 
  paul.an...@shapeblue.com | www.shapeblue.com |
  Twitter:@shapebluehttps://twitter.com/
 
  ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS
 
 
   Need Enterprise Grade Support for Apache CloudStack?
  Our CloudStack Infrastructure Support
 http://shapeblue.com/cloudstack-infrastructure-support/offers the best
 24/7 SLA for CloudStack Environments.
 
  Apache CloudStack Bootcamp training courses
 
  **NEW!** CloudStack 4.2.1
  traininghttp://shapeblue.com/cloudstack-training/
  18th-19th February 2014, Brazil.
  Classroomhttp://shapeblue.com/cloudstack-training/
  17th-23rd March 2014, Region A. Instructor led,
  On-linehttp://shapeblue.com/cloudstack-training/
  24th-28th March 2014, Region B. Instructor led,
  On-linehttp://shapeblue.com/cloudstack-training/
  16th-20th June 2014, Region A. Instructor led,
  On-linehttp://shapeblue.com/cloudstack-training/
  23rd-27th June 2014, Region B. Instructor led,
  On-linehttp://shapeblue.com/cloudstack-training/
 
  This email and any attachments to it may be confidential and are
  intended solely for the use of the individual to whom it is addressed.
  Any views or opinions expressed are solely those of the author and do
  not necessarily represent those of Shape Blue Ltd or related
  companies. If you are not the intended recipient of this email, you
  must neither take any action based upon its contents, nor copy or show
  it to anyone. Please contact the sender if you believe you have
  received this email in error. Shape Blue Ltd is a company incorporated
  in England  Wales. ShapeBlue Services India LLP is a company
  incorporated in India and is operated under license from Shape Blue
  Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in
  Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a
 registered trademark.
 



 --

 EOF
 This email and any attachments to it may be confidential and are intended
 solely for the use of the individual to whom it is addressed. Any views or
 opinions expressed are solely those of the author and do not necessarily
 represent those of Shape Blue Ltd or related companies. If you are not the
 intended recipient of this email, you must neither take any action based
 upon its contents, nor copy or show it to anyone. Please contact

Re: [4.4] build failing at awsapi

[Laszlo Hornyak]

Works for me. It may be something in your environment settings


On Tue, Apr 1, 2014 at 10:11 PM, Paul Angus paul.an...@shapeblue.comwrote:

 Thanks Laszlo,

 I cleared ~.m2/repository, but the maven still goes back to that repo when
 I build cloudstack.

 Regards

 Paul Angus
 Cloud Architect
 S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
 paul.an...@shapeblue.com

 -Original Message-
 From: Laszlo Hornyak [mailto:laszlo.horn...@gmail.com]
 Sent: 01 April 2014 20:49
 To: dev@cloudstack.apache.org
 Subject: Re: [4.4] build failing at awsapi

 Hi Paul,

 I just checked it and looks like I too had some dependencies resolved from
 there, but apparently they were not from cloudstack.
 This shibboleth repo was moved last year and it broke quite a lot of
 things. Today the maven central repo maintainers do not allow uploading
 artifacts depending on other repositories than maven central.

 fix:
 cd ~.m2/repository
 grep shibboleth . -r
 and rm -rf all that matches

 A complete rm ~/.m2/repository may also solve the problems, and after that
 it should work.


 On Tue, Apr 1, 2014 at 5:40 PM, Paul Angus paul.an...@shapeblue.com
 wrote:

   Hi I'm getting the following errors when building 4.4 noredist:
 
 
 
  [ERROR] Failed to execute goal
  org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
  (default-compile) on project cloud-awsapi: Compilation failure:
  Compilation
  failure:
 
  [ERROR] error: error reading
  /root/.m2/repository/org/codehaus/woodstox/wstx-asl/3.2.4/wstx-asl-3.2
  .4.jar;
  error in opening zip file
 
  [ERROR] error: error reading
  /root/.m2/repository/org/apache/axis2/mex/1.5.4/mex-1.5.4-impl.jar;
  error in opening zip file
 
  [ERROR] error: error reading
  /root/.m2/repository/org/apache/axis2/axis2-mtompolicy/1.5.4/axis2-mto
  mpolicy-1.5.4.jar;
  error in opening zip file
 
  [ERROR] error: error reading
  /root/.m2/repository/org/apache/ws/commons/axiom/axiom-dom/1.2.10/axio
  m-dom-1.2.10.jar;
  error in opening zip file
 
  [ERROR] error: error reading
  /root/.m2/repository/commons-lang/commons-lang/2.3/commons-lang-2.3.ja
  r;
  error in opening zip file
 
 
 
  It seems to be being caused by one repo:  shibboleth.internet2.edu
  which has moved/removed its maven repo, so returns a webpage instead
  of a pom or a jar.
 
 
 
  I can't find a way to blacklist shibboleth.internet2.edu
 
 
 
  Any ideas anyone?
 
 
 
  Regards
 
 
 
  Paul Angus
 
  *Senior Consultant / Cloud Architect*
 
 
 
  [image: cid:image002.png@01CE1071.C6CC9C10]
 
 
 
  S: +44 20 3603 0540 +442036030540 | M: +4 +44796816158147711418784
  |
  T: @CloudyAngus
 
  paul.an...@shapeblue.com | www.shapeblue.com |
  Twitter:@shapebluehttps://twitter.com/
 
  ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS
 
 
   Need Enterprise Grade Support for Apache CloudStack?
  Our CloudStack Infrastructure Support
 http://shapeblue.com/cloudstack-infrastructure-support/offers the best
 24/7 SLA for CloudStack Environments.
 
  Apache CloudStack Bootcamp training courses
 
  **NEW!** CloudStack 4.2.1
  traininghttp://shapeblue.com/cloudstack-training/
  18th-19th February 2014, Brazil.
  Classroomhttp://shapeblue.com/cloudstack-training/
  17th-23rd March 2014, Region A. Instructor led,
  On-linehttp://shapeblue.com/cloudstack-training/
  24th-28th March 2014, Region B. Instructor led,
  On-linehttp://shapeblue.com/cloudstack-training/
  16th-20th June 2014, Region A. Instructor led,
  On-linehttp://shapeblue.com/cloudstack-training/
  23rd-27th June 2014, Region B. Instructor led,
  On-linehttp://shapeblue.com/cloudstack-training/
 
  This email and any attachments to it may be confidential and are
  intended solely for the use of the individual to whom it is addressed.
  Any views or opinions expressed are solely those of the author and do
  not necessarily represent those of Shape Blue Ltd or related
  companies. If you are not the intended recipient of this email, you
  must neither take any action based upon its contents, nor copy or show
  it to anyone. Please contact the sender if you believe you have
  received this email in error. Shape Blue Ltd is a company incorporated
  in England  Wales. ShapeBlue Services India LLP is a company
  incorporated in India and is operated under license from Shape Blue
  Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in
  Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a
 registered trademark.
 



 --

 EOF
 This email and any attachments to it may be confidential and are intended
 solely for the use of the individual to whom it is addressed. Any views or
 opinions expressed are solely those of the author and do not necessarily
 represent those of Shape Blue Ltd or related companies. If you are not the
 intended recipient of this email, you must neither take any action based
 upon its contents, nor copy or show it to anyone. Please contact the sender
 if you believe you have received this email

Re: spring unittests

[Laszlo Hornyak]

Hi Rajani,

I had a short investigation into the problem and that test context is quite
exciting. (which means I would need a lot more time to find all the
details) For a short solution I would recommend you to write another rather
than trying to reuse.



On Sat, Mar 29, 2014 at 11:30 AM, Rajani Karuturi 
rajani.karut...@citrix.com wrote:

 any help?


 ~Rajani



 On 28-Mar-2014, at 9:48 am, Rajani Karuturi rajani.karut...@citrix.com
 wrote:

  Its the testContext.xml we have at server/test/resouces
 
  As the async job dispatcher also comes under server/, i used the same
 test context file.
 
  ~Rajani
 
 
 
  On 28-Mar-2014, at 1:23 am, Laszlo Hornyak laszlo.horn...@gmail.com
 wrote:
 
  Hi Rajani,
 
  Can you share your spring context file?
 
 
  On Thu, Mar 27, 2014 at 10:50 AM, Rajani Karuturi 
  rajani.karut...@citrix.com wrote:
 
  Hi All,
 
  I am trying to write unit tests for ApiAsyncJobDispatcher. This is how
 I
  defined by Test class @ server/test/com/cloud/api
 
  @RunWith(SpringJUnit4ClassRunner.class)
  @ContextConfiguration(locations = classpath:/testContext.xml)
  public class ApiAsyncJobDispatcherTest {
@Mock
private ApiDispatcher _dispatcher;
 
@Mock
private AsyncJobManager _asyncJobMgr;
 
@Mock
private EntityManager _entityMgr;
 
@InjectMocks
private ApiAsyncJobDispatcher apiAsyncJobDispatcher = new
  ApiAsyncJobDispatcher();
 
@Before
public void setUp() throws Exception {
MockitoAnnotations.initMocks(this);
ComponentContext.initComponentsLifeCycle();
}
 
@Test
public void testRunJob() throws Exception {
AsyncJob asyncJob = new AsyncJobVO(, User.UID_SYSTEM, 1,
  DetachVolumeCmdByAdmin.class.getCanonicalName(), null, null, null);
apiAsyncJobDispatcher.runJob(asyncJob);
}
  }
 
 
  I am getting failed to load ApplicationContext error. The exact error
  message is
  java.lang.ClassNotFoundException:
  org.apache.cloudstack.framework.eventbus.EventBusBase
 
  I think, that class is moved to
  org.apache.cloudstack.framework.events.EventBus. Once I make that
 change in
  the application context file, I am getting
  Caused by:
  org.springframework.beans.factory.NoUniqueBeanDefinitionException: No
  qualifying bean of type [com.cloud.user.AccountService] is defined:
  expected single matching bean but found 4:
  mockAccountManagerImpl,accountService,accountManager,acctMgr
 
 
  Am I miss something?
 
  I did go through
 
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Unit+Testing+with+JUnit+and+SpringBut,
 didn't understand Note: #4 of it.
 
 
  ~Rajani
 
 
 
 
 
 
  --
 
  EOF
 




-- 

EOF

Re: Review Request 12228: static resource compression

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
---

(Updated March 30, 2014, 8:08 p.m.)


Review request for cloudstack, Brian Federle, Darren Shepherd, Jessica Wang, 
and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

CloudStack at first use downloads some 3.5 MB of css and javascript to the 
client. With a weak internet connection, this might take a long time. With gzip 
compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so 
that no dynamic compression is needed at runtime. When the static resource 
servlet notices that there is gzipped version of the resource and the client 
accepts gzipped content, then it is going to send the gziped version, while 
still respects http caching.


Diffs
-

  client/WEB-INF/web.xml 1af38e1 
  client/pom.xml d8dbde7 
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12228/diff/


Testing
---

yes, tested with firefox and chrome


Thanks,

Laszlo Hornyak

Re: spring unittests

[Laszlo Hornyak]

Hi Rajani,

Can you share your spring context file?


On Thu, Mar 27, 2014 at 10:50 AM, Rajani Karuturi 
rajani.karut...@citrix.com wrote:

 Hi All,

 I am trying to write unit tests for ApiAsyncJobDispatcher. This is how I
 defined by Test class @ server/test/com/cloud/api

 @RunWith(SpringJUnit4ClassRunner.class)
 @ContextConfiguration(locations = classpath:/testContext.xml)
 public class ApiAsyncJobDispatcherTest {
 @Mock
 private ApiDispatcher _dispatcher;

 @Mock
 private AsyncJobManager _asyncJobMgr;

 @Mock
 private EntityManager _entityMgr;

 @InjectMocks
 private ApiAsyncJobDispatcher apiAsyncJobDispatcher = new
 ApiAsyncJobDispatcher();

 @Before
 public void setUp() throws Exception {
 MockitoAnnotations.initMocks(this);
 ComponentContext.initComponentsLifeCycle();
 }

 @Test
 public void testRunJob() throws Exception {
 AsyncJob asyncJob = new AsyncJobVO(, User.UID_SYSTEM, 1,
 DetachVolumeCmdByAdmin.class.getCanonicalName(), null, null, null);
 apiAsyncJobDispatcher.runJob(asyncJob);
 }
 }


 I am getting failed to load ApplicationContext error. The exact error
 message is
 java.lang.ClassNotFoundException:
 org.apache.cloudstack.framework.eventbus.EventBusBase

 I think, that class is moved to
 org.apache.cloudstack.framework.events.EventBus. Once I make that change in
 the application context file, I am getting
 Caused by:
 org.springframework.beans.factory.NoUniqueBeanDefinitionException: No
 qualifying bean of type [com.cloud.user.AccountService] is defined:
 expected single matching bean but found 4:
 mockAccountManagerImpl,accountService,accountManager,acctMgr


 Am I miss something?

 I did go through
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Unit+Testing+with+JUnit+and+SpringBut,
  didn't understand Note: #4 of it.


 ~Rajani






-- 

EOF

Re: Review Request 12228: static resource compression

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review38181
---


https://docs.google.com/spreadsheet/ccc?key=0ApMkIX1Ygx8zdHhqV2RETy05SDU1WER3Z2JEN3ktZHcusp=sharing

Comparison of 3 configurations, the dynamic compression solution is the last 
one. This test was conducted in a VM with 2 vCPU and 4 GB RAM on a 
AMD E2-1800.


- Laszlo Hornyak


On March 20, 2014, 7:53 p.m., Laszlo Hornyak wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12228/
 ---
 
 (Updated March 20, 2014, 7:53 p.m.)
 
 
 Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna 
 Santhanam.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CloudStack at first use downloads some 3.5 MB of css and javascript to the 
 client. With a weak internet connection, this might take a long time. With 
 gzip compression content can be compressed to 850 KB.
 
 This version of the patch uses a custom plugin to compress static resources, 
 so that no dynamic compression is needed at runtime. When the static resource 
 servlet notices that there is gzipped version of the resource and the client 
 accepts gzipped content, then it is going to send the gziped version, while 
 still respects http caching.
 
 
 Diffs
 -
 
   client/WEB-INF/web.xml 1af38e1 
   client/pom.xml d8dbde7 
   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/12228/diff/
 
 
 Testing
 ---
 
 yes, tested with firefox and chrome
 
 
 Thanks,
 
 Laszlo Hornyak
 

Re: Review Request 12228: static resource compression

[Laszlo Hornyak]

Hi John,

I used simple apache benchmark with a random selected css.
ab -n 2000 -H Accept-Encoding: gzip, deflate
http://172.17.10.10/client/css/cloudstack3.css

This looks big enough, it is about 200 K uncompressed.

I used the configuration you published in your blog and I disabled the
static resource compression by commenting the servlet out from the web.xml,
I verified the configurations by examining the headers and message body.
Since the tested VM is a local VM, the network latency is really close to
zero.

Please share your results! I was surprised first about the low performance
of dynamic compression, I expected it to be somewhat slower and I believe
the resource size or maybe even the content itself can alter the results.
But theoretically it can never be as fast as static compression since that
is just plain IO.

Some other comparisons done by others
http://www.webperformance.com/library/reports/moddeflate/
http://www.webperformance.com/library/reports/iis7_compression/ - ISS too

As I wrote, I believe the best solution would be combining both static and
dynamic.


On Fri, Mar 21, 2014 at 10:03 PM, John Kinsella j...@stratosec.co wrote:

  Canya tell us a little more about the test you're doing? What URL are you
 fetching, how many times etc. Just curious to tinker myself this weekend if
 I have some time. :)

  On Mar 21, 2014, at 1:07 PM, Laszlo Hornyak laszlo.horn...@gmail.com
 wrote:


 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12228/#review38181
 ---



 https://docs.google.com/spreadsheet/ccc?key=0ApMkIX1Ygx8zdHhqV2RETy05SDU1WER3Z2JEN3ktZHcusp=sharing

 Comparison of 3 configurations, the dynamic compression solution is the
 last one. This test was conducted in a VM with 2 vCPU and 4 GB RAM on a
 AMD E2-1800.


 - Laszlo Hornyak


 On March 20, 2014, 7:53 p.m., Laszlo Hornyak wrote:


 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12228/
 ---

 (Updated March 20, 2014, 7:53 p.m.)


 Review request for cloudstack, Brian Federle, Darren Shepherd, and
 Prasanna Santhanam.


 Repository: cloudstack-git


 Description
 ---

 CloudStack at first use downloads some 3.5 MB of css and javascript to the
 client. With a weak internet connection, this might take a long time. With
 gzip compression content can be compressed to 850 KB.

 This version of the patch uses a custom plugin to compress static
 resources, so that no dynamic compression is needed at runtime. When the
 static resource servlet notices that there is gzipped version of the
 resource and the client accepts gzipped content, then it is going to send
 the gziped version, while still respects http caching.


 Diffs
 -

  client/WEB-INF/web.xml 1af38e1
  client/pom.xml d8dbde7
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION

 Diff: https://reviews.apache.org/r/12228/diff/


 Testing
 ---

 yes, tested with firefox and chrome


 Thanks,

 Laszlo Hornyak




  Stratosec http://stratosec.co/ - Compliance as a Service
 o: 415.315.9385
 @johnlkinsella http://twitter.com/johnlkinsella




-- 

EOF

Re: Errors building master

[Laszlo Hornyak]

Hi Alex,

It should be OK if you recompile, the required module is in the module tree.
Btw I am getting a compile error:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:[1502,12]
error: unreported exception ResourceAllocationException; must be caught or
declared to be thrown




On Thu, Mar 20, 2014 at 12:40 PM, Alex Hitchins alex.hitch...@shapeblue.com
 wrote:


 Anyone else seing this?

 [ERROR] Failed to execute goal on project cloud-client-ui: Could not
 resolve dependencies for project
 org.apache.cloudstack:cloud-client-ui:war:4.5.0-SNAPSHOT:
 Could not find artifact
 org.apache.cloudstack:cloud-plugin-storage-volume-cloudbyte:jar:4.5.0-SNAPSHOT
 in apache.snapshots (http://repository.apache.org/snapshots) - [Help 1]

 Is there somewhere I can manually download the cloudbyte dependency?

 Alex

 .
 Need Enterprise Grade Support for Apache CloudStack?
 Our CloudStack Infrastructure Support
 http://shapeblue.com/cloudstack-infrastructure-support/ offers the best
 24/7 SLA for CloudStack Environments.

 Apache CloudStack Bootcamp training courses

 **NEW!** CloudStack 4.2.1 training
 http://shapeblue.com/cloudstack-training/
 18th-19th February 2014, Brazil. Classroom
 http://shapeblue.com/cloudstack-training/
 17th-23rd March 2014, Region A. Instructor led, On-line
 http://shapeblue.com/cloudstack-training/
 24th-28th March 2014, Region B. Instructor led, On-line
 http://shapeblue.com/cloudstack-training/
 16th-20th June 2014, Region A. Instructor led, On-line
 http://shapeblue.com/cloudstack-training/
 23rd-27th June 2014, Region B. Instructor led, On-line
 http://shapeblue.com/cloudstack-training/

 This email and any attachments to it may be confidential and are intended
 solely for the use of the individual to whom it is addressed. Any views or
 opinions expressed are solely those of the author and do not necessarily
 represent those of Shape Blue Ltd or related companies. If you are not the
 intended recipient of this email, you must neither take any action based
 upon its contents, nor copy or show it to anyone. Please contact the sender
 if you believe you have received this email in error. Shape Blue Ltd is a
 company incorporated in England  Wales. ShapeBlue Services India LLP is a
 company incorporated in India and is operated under license from Shape Blue
 Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
 and is operated under license from Shape Blue Ltd. ShapeBlue is a
 registered trademark.




-- 

EOF

Re: Review Request 12228: static resource compression

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
---

(Updated March 20, 2014, 7:53 p.m.)


Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna 
Santhanam.


Changes
---

spaces


Repository: cloudstack-git


Description
---

CloudStack at first use downloads some 3.5 MB of css and javascript to the 
client. With a weak internet connection, this might take a long time. With gzip 
compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so 
that no dynamic compression is needed at runtime. When the static resource 
servlet notices that there is gzipped version of the resource and the client 
accepts gzipped content, then it is going to send the gziped version, while 
still respects http caching.


Diffs (updated)
-

  client/WEB-INF/web.xml 1af38e1 
  client/pom.xml d8dbde7 
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12228/diff/


Testing
---

yes, tested with firefox and chrome


Thanks,

Laszlo Hornyak

Re: Review Request 12228: static resource compression

[Laszlo Hornyak]

Hi John,

Jetty gives this functionality by default without a filter/servlet, simply
it is not available in tomcat. I used this functionality a lot in jetty and
that plus the massive size of the UI gave me the idea.
My approach to the problem was motivated by that I don't like to see
anything wasted, but let's make a measurement and see what the impact is.
This is what could be interesting in comparison with dynamic compression:
- request/sec and average delay for static resoures in different sizes
- time taken by full page reload




On Thu, Mar 20, 2014 at 11:19 PM, John Kinsella j...@stratosec.co wrote:

  Laszlo, can you reference any other open source projects that have
 similar solutions to this issue? Anything I've read states dynamic
 compression in tomcat/httpd/nginx does not add significant CPU overhead.

  On Mar 20, 2014, at 12:53 PM, Laszlo Hornyak laszlo.horn...@gmail.com
 wrote:


 ---

 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12228/
 ---

 (Updated March 20, 2014, 7:53 p.m.)



 Review request for cloudstack, Brian Federle, Darren Shepherd, and
 Prasanna Santhanam.


 Changes
 ---

 spaces


 Repository: cloudstack-git


 Description
 ---


 CloudStack at first use downloads some 3.5 MB of css and javascript to the
 client. With a weak internet connection, this might take a long time. With
 gzip compression content can be compressed to 850 KB.

 This version of the patch uses a custom plugin to compress static
 resources, so that no dynamic compression is needed at runtime. When the
 static resource servlet notices that there is gzipped version of the
 resource and the client accepts gzipped content, then it is going to send
 the gziped version, while still respects http caching.


 Diffs (updated)
 -

  client/WEB-INF/web.xml 1af38e1
  client/pom.xml d8dbde7
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION

 Diff: https://reviews.apache.org/r/12228/diff/


 Testing
 ---


 yes, tested with firefox and chrome


 Thanks,

 Laszlo Hornyak


  Stratosec http://stratosec.co/ - Compliance as a Service
 o: 415.315.9385
 @johnlkinsella http://twitter.com/johnlkinsella




-- 

EOF

Re: Review Request 12228: static resource compression

[Laszlo Hornyak]

url: https://wiki.eclipse.org/Jetty/Feature/GZIP_Compression#Static_Content


On Thu, Mar 20, 2014 at 11:19 PM, John Kinsella j...@stratosec.co wrote:

  Laszlo, can you reference any other open source projects that have
 similar solutions to this issue? Anything I've read states dynamic
 compression in tomcat/httpd/nginx does not add significant CPU overhead.

  On Mar 20, 2014, at 12:53 PM, Laszlo Hornyak laszlo.horn...@gmail.com
 wrote:


 ---

 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12228/
 ---

 (Updated March 20, 2014, 7:53 p.m.)



 Review request for cloudstack, Brian Federle, Darren Shepherd, and
 Prasanna Santhanam.


 Changes
 ---

 spaces


 Repository: cloudstack-git


 Description
 ---


 CloudStack at first use downloads some 3.5 MB of css and javascript to the
 client. With a weak internet connection, this might take a long time. With
 gzip compression content can be compressed to 850 KB.

 This version of the patch uses a custom plugin to compress static
 resources, so that no dynamic compression is needed at runtime. When the
 static resource servlet notices that there is gzipped version of the
 resource and the client accepts gzipped content, then it is going to send
 the gziped version, while still respects http caching.


 Diffs (updated)
 -

  client/WEB-INF/web.xml 1af38e1
  client/pom.xml d8dbde7
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION

 Diff: https://reviews.apache.org/r/12228/diff/


 Testing
 ---


 yes, tested with firefox and chrome


 Thanks,

 Laszlo Hornyak


  Stratosec http://stratosec.co/ - Compliance as a Service
 o: 415.315.9385
 @johnlkinsella http://twitter.com/johnlkinsella




-- 

EOF

Re: Review Request 12228: static resource compression

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
---

(Updated March 19, 2014, 8:13 p.m.)


Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna 
Santhanam.


Changes
---

-updated to use plugin from central repo
-fixed spaces/tabs
-license header added


Summary (updated)
-

static resource compression


Repository: cloudstack-git


Description
---

CloudStack at first use downloads some 3.5 MB of css and javascript to the 
client. With a weak internet connection, this might take a long time. With gzip 
compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so 
that no dynamic compression is needed at runtime. When the static resource 
servlet notices that there is gzipped version of the resource and the client 
accepts gzipped content, then it is going to send the gziped version, while 
still respects http caching.


Diffs (updated)
-

  client/WEB-INF/web.xml 1af38e1 
  client/pom.xml 615d244 
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12228/diff/


Testing (updated)
---

yes, tested with firefox and chrome


Thanks,

Laszlo Hornyak

Re: Review Request 12228: static resource compression

[Laszlo Hornyak]

 On Feb. 2, 2014, 6:03 p.m., daan Hoogland wrote:
  client/WEB-INF/web.xml, line 63
  https://reviews.apache.org/r/12228/diff/2/?file=354637#file354637line63
 
  can you use tabs instead of spaces (and while you are at it remove 
  trailing spaces from this file)?

trailing white spaces: ok
spaces to tabs: all this file is tabed with spaces, so this would be the first 
thing with tabs.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review33400
---


On March 19, 2014, 8:13 p.m., Laszlo Hornyak wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12228/
 ---
 
 (Updated March 19, 2014, 8:13 p.m.)
 
 
 Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna 
 Santhanam.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CloudStack at first use downloads some 3.5 MB of css and javascript to the 
 client. With a weak internet connection, this might take a long time. With 
 gzip compression content can be compressed to 850 KB.
 
 This version of the patch uses a custom plugin to compress static resources, 
 so that no dynamic compression is needed at runtime. When the static resource 
 servlet notices that there is gzipped version of the resource and the client 
 accepts gzipped content, then it is going to send the gziped version, while 
 still respects http caching.
 
 
 Diffs
 -
 
   client/WEB-INF/web.xml 1af38e1 
   client/pom.xml 615d244 
   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/12228/diff/
 
 
 Testing
 ---
 
 yes, tested with firefox and chrome
 
 
 Thanks,
 
 Laszlo Hornyak
 

Re: Anyone else see these errors in Eclipse?

[Laszlo Hornyak]

you are not alone :)


On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski 
mike.tutkow...@solidfire.com wrote:

 display cannot be resolved to a variable

 http://i.imgur.com/Jz2swFS.png

 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *(tm)*




-- 

EOF

Re: Anyone else see these errors in Eclipse?

[Laszlo Hornyak]

The project is only compiled if both integration-test and vmware profiles
are activated. but for vmware I need some jars that vmware allows to
download only if I work for a partner company - which I don't. Anyone know
another source?


On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski 
mike.tutkow...@solidfire.com wrote:

 display cannot be resolved to a variable

 http://i.imgur.com/Jz2swFS.png

 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *(tm)*




-- 

EOF

Re: Anyone else see these errors in Eclipse?

[Laszlo Hornyak]

No, it is really broken, 'display' should be replaced with a boolean
expression. I believe it was something left behind after a refactoring.


On Sat, Mar 15, 2014 at 3:17 PM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 so, is eclipse wrong?

 On Sat, Mar 15, 2014 at 11:02 AM, Laszlo Hornyak
 laszlo.horn...@gmail.com wrote:
  you are not alone :)
 
 
  On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski 
  mike.tutkow...@solidfire.com wrote:
 
  display cannot be resolved to a variable
 
  http://i.imgur.com/Jz2swFS.png
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the
  cloudhttp://solidfire.com/solution/overview/?video=play
  *(tm)*
 
 
 
 
  --
 
  EOF



 --
 Daan




-- 

EOF

Re: Anyone else see these errors in Eclipse?

[Laszlo Hornyak]

The commiter may not have realized that this profile must be activated to
compile the module, also there are no jenkins builds configured to compile
this module and this is broken for about a month. No one noticed until Mike
told about it. Maybe the build-master-noredist could be a good candidate...


On Sat, Mar 15, 2014 at 3:51 PM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 someone hastily checked in some code without running unit tests!
 Unforgivable, especially if it was a refactoring. I am kind of lenient
 on quick bug fixes so i say this with some restraint. (excuse my
 Dutch)

 Do we have a merge conflict between two features or refactorings here?

 On Sat, Mar 15, 2014 at 3:37 PM, Laszlo Hornyak
 laszlo.horn...@gmail.com wrote:
  No, it is really broken, 'display' should be replaced with a boolean
  expression. I believe it was something left behind after a refactoring.
 
 
  On Sat, Mar 15, 2014 at 3:17 PM, Daan Hoogland daan.hoogl...@gmail.com
 wrote:
 
  so, is eclipse wrong?
 
  On Sat, Mar 15, 2014 at 11:02 AM, Laszlo Hornyak
  laszlo.horn...@gmail.com wrote:
   you are not alone :)
  
  
   On Sat, Mar 15, 2014 at 7:38 AM, Mike Tutkowski 
   mike.tutkow...@solidfire.com wrote:
  
   display cannot be resolved to a variable
  
   http://i.imgur.com/Jz2swFS.png
  
   --
   *Mike Tutkowski*
   *Senior CloudStack Developer, SolidFire Inc.*
   e: mike.tutkow...@solidfire.com
   o: 303.746.7302
   Advancing the way the world uses the
   cloudhttp://solidfire.com/solution/overview/?video=play
   *(tm)*
  
  
  
  
   --
  
   EOF
 
 
 
  --
  Daan
 
 
 
 
  --
 
  EOF



 --
 Daan




-- 

EOF

Re: apache jenkins

[Laszlo Hornyak]

A jenkins bug maybe? But fortunately it generates the rat report before it
fails.

Caused by: java.lang.ClassNotFoundException:
org.apache.http.client.CredentialsProvider
at 
org.apache.tools.ant.AntClassLoader.findClassInComponents(AntClassLoader.java:1365)
at 
org.apache.tools.ant.AntClassLoader.findClass(AntClassLoader.java:1315)
at 
org.apache.tools.ant.AntClassLoader.loadClass(AntClassLoader.java:1068)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
at 
hudson.remoting.RemoteClassLoader$ClassLoaderProxy.fetch4(RemoteClassLoader.java:742)
at 
hudson.remoting.RemoteClassLoader$ClassLoaderProxy.fetch3(RemoteClassLoader.java:784)




On Thu, Mar 13, 2014 at 8:59 PM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 H,

 Anybody have any idea what's eating the rat test?

 --
 Daan




-- 

EOF

Re: JRE 1.7

[Laszlo Hornyak]

Hi,

Now the default java source and target are both 1.7. If you update the
configuration of the imported projects, eclipse should pick up the change
and use java 1.7. Unfortunately it does not do that by default after a git
rebase. But you should check that your default JDK in eclipse is 1.7


On Wed, Mar 5, 2014 at 6:23 PM, Alex Hitchins
alex.hitch...@shapeblue.comwrote:

 Hi all,

 Just wanted to double check something. I'm getting a lot of errors in
 Eclipse saying that  operator isn't allowed for source level below 1.7.

 Am I ok to change the compliance and JRE to 1.7?

 I have seen some discussion around changing of the JRE, I just want to
 make sure!


 Regards,

 Alex Hitchins
 VP Software Engineering

 D: +44 1892 523 587 | S: +44 20 3603 0540tel:+442036030540 | M: +44tel:
 +447968161581 7788 423 969

 ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

 Need Enterprise Grade Support for Apache CloudStack?
 Our CloudStack Infrastructure Support
 http://shapeblue.com/cloudstack-infrastructure-support/ offers the best
 24/7 SLA for CloudStack Environments.

 Apache CloudStack Bootcamp training courses

 **NEW!** CloudStack 4.2.1 training
 http://shapeblue.com/cloudstack-training/
 18th-19th February 2014, Brazil. Classroom
 http://shapeblue.com/cloudstack-training/
 17th-23rd March 2014, Region A. Instructor led, On-line
 http://shapeblue.com/cloudstack-training/
 24th-28th March 2014, Region B. Instructor led, On-line
 http://shapeblue.com/cloudstack-training/
 16th-20th June 2014, Region A. Instructor led, On-line
 http://shapeblue.com/cloudstack-training/
 23rd-27th June 2014, Region B. Instructor led, On-line
 http://shapeblue.com/cloudstack-training/

 This email and any attachments to it may be confidential and are intended
 solely for the use of the individual to whom it is addressed. Any views or
 opinions expressed are solely those of the author and do not necessarily
 represent those of Shape Blue Ltd or related companies. If you are not the
 intended recipient of this email, you must neither take any action based
 upon its contents, nor copy or show it to anyone. Please contact the sender
 if you believe you have received this email in error. Shape Blue Ltd is a
 company incorporated in England  Wales. ShapeBlue Services India LLP is a
 company incorporated in India and is operated under license from Shape Blue
 Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
 and is operated under license from Shape Blue Ltd. ShapeBlue is a
 registered trademark.




-- 

EOF

Re: Review Request 18568: Fix for returning null when expected is boolean; comparing objects with == instead of equals()

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18568/#review35862
---


I looked into it, the FenceBuilder.fenceOff() method is called from only one 
place (HighAvailablityManagerImpl) and right under it checks if the return is 
null, the returned null is handled as if it was false. Therefore this change is 
safe and also changing the return value to boolean type would be safe as well.

- Laszlo Hornyak


On Feb. 27, 2014, 8:03 a.m., Wilder Rodrigues wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18568/
 ---
 
 (Updated Feb. 27, 2014, 8:03 a.m.)
 
 
 Review request for cloudstack, daan Hoogland and Hugo Trippaers.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Fix for Find Bugs findings on troubling issues: returning null when expected 
 is boolean; adding 6 unit tests and fix 1 in the KVMFencer; comparing objects 
 with == instead of equals()
 
 
 Diffs
 -
 
   plugins/hypervisors/xen/src/com/cloud/ha/XenServerFencer.java 28cba2b 
   
 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
  48ae3ea 
   plugins/hypervisors/xen/test/com/cloud/ha/XenServerFencerTest.java bd1d8f8 
   server/src/com/cloud/ha/KVMFencer.java 516a579 
   server/test/com/cloud/ha/KVMFencerTest.java cdd13b6 
 
 Diff: https://reviews.apache.org/r/18568/diff/
 
 
 Testing
 ---
 
 Added 6 unit tests for XenServerFencer (removed an useless one which was 
 testing get/set methods)
 Build completed successfully
 
 Tested also on DevCloud + XenServer the following:
 
 Create Zone + Network + Pod + cluster + Pri/Sec Storage + Console Proxy and 
 System VMS
 Create 1 instance (tiny Linux) + Guest Network + 1 SourceNAT + 1 extra pub ip
 Set up firewall for port 22 + ICMP + port forwarding 22 == instance
 SSH into the instance
 
 
 Thanks,
 
 Wilder Rodrigues
 

Re: Review Request 18568: Fix for returning null when expected is boolean; comparing objects with == instead of equals()

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18568/#review35618
---


In general I believe it makes sense to return false in this case, since it is 
clear that the host was not fenced.

At the same time the reviewers dislike havig formating (finals) in the patches, 
it might be easier to push it through the process if you could separate the 
cleanup from the fix. Also, is there a bug url that should be included?

- Laszlo Hornyak


On Feb. 27, 2014, 8:03 a.m., Wilder Rodrigues wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18568/
 ---
 
 (Updated Feb. 27, 2014, 8:03 a.m.)
 
 
 Review request for cloudstack, daan Hoogland and Hugo Trippaers.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Fix for Find Bugs findings on troubling issues: returning null when expected 
 is boolean; adding 6 unit tests and fix 1 in the KVMFencer; comparing objects 
 with == instead of equals()
 
 
 Diffs
 -
 
   plugins/hypervisors/xen/src/com/cloud/ha/XenServerFencer.java 28cba2b 
   
 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
  48ae3ea 
   plugins/hypervisors/xen/test/com/cloud/ha/XenServerFencerTest.java bd1d8f8 
   server/src/com/cloud/ha/KVMFencer.java 516a579 
   server/test/com/cloud/ha/KVMFencerTest.java cdd13b6 
 
 Diff: https://reviews.apache.org/r/18568/diff/
 
 
 Testing
 ---
 
 Added 6 unit tests for XenServerFencer (removed an useless one which was 
 testing get/set methods)
 Build completed successfully
 
 Tested also on DevCloud + XenServer the following:
 
 Create Zone + Network + Pod + cluster + Pri/Sec Storage + Console Proxy and 
 System VMS
 Create 1 instance (tiny Linux) + Guest Network + 1 SourceNAT + 1 extra pub ip
 Set up firewall for port 22 + ICMP + port forwarding 22 == instance
 SSH into the instance
 
 
 Thanks,
 
 Wilder Rodrigues
 

Re: Review Request 18358: NetUtils unit testing

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18358/#review35430
---

Ship it!


Ship It!

- Laszlo Hornyak


On Feb. 22, 2014, 1:41 p.m., Miguel Ferreira wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18358/
 ---
 
 (Updated Feb. 22, 2014, 1:41 p.m.)
 
 
 Review request for cloudstack, daan Hoogland and Hugo Trippaers.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 - Refactor tests:
   - Upgrade tests to use jUnit4
   - Break big tests in small unit tests
   - Replace assertTrue/False with complex conditions by assertThat with
 specific matchers
 - Remove dead code:
   - Private static method never called locally
 - Add test for method that validates CIDRs
 
 
 Diffs
 -
 
   pom.xml 1e9e8d8 
   utils/src/com/cloud/utils/net/NetUtils.java c22e39a 
   utils/test/com/cloud/utils/net/NetUtilsTest.java d3e283c 
 
 Diff: https://reviews.apache.org/r/18358/diff/
 
 
 Testing
 ---
 
 Ran all the tests in the test class before and after refactoring.
 
 
 Thanks,
 
 Miguel Ferreira
 

Re: Review Request 18432: Fixed some resource files issues

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18432/#review35443
---


Checked, looks good. Ok to merge?

- Laszlo Hornyak


On Feb. 24, 2014, 5:47 p.m., Konstantina Chremmou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18432/
 ---
 
 (Updated Feb. 24, 2014, 5:47 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Fixed some resource files issues, namely 1) invalid text and duplicate keys 
 resulting from bad merge and 2) trailing spaces which can potentially cause 
 UI issues.
 
 
 Diffs
 -
 
   client/WEB-INF/classes/resources/messages.properties bd4a27d 
   client/WEB-INF/classes/resources/messages_es.properties 31a9c93 
   client/WEB-INF/classes/resources/messages_ja_JP.properties 7dd5bd1 
   client/WEB-INF/classes/resources/messages_nl_NL.properties b1bfadb 
   client/WEB-INF/classes/resources/messages_pl.properties 9024030 
   client/WEB-INF/classes/resources/messages_pt_BR.properties 07fd3f4 
   client/WEB-INF/classes/resources/messages_zh_CN.properties 88b13a1 
 
 Diff: https://reviews.apache.org/r/18432/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Konstantina Chremmou
 

Re: Review Request 18432: Fixed some resource files issues

[Laszlo Hornyak]

Sure, just wanted to give time to module owners to take a look.


On Tue, Feb 25, 2014 at 9:50 PM, David Nalley da...@gnsa.us wrote:

This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18432/

 On February 25th, 2014, 7:42 p.m. UTC, *Laszlo Hornyak* wrote:

 Checked, looks good. Ok to merge?

  You are a committer, Laszlo - if it looks good to you, you have the karma to 
 push.


 - David

 On February 24th, 2014, 5:47 p.m. UTC, Konstantina Chremmou wrote:
   Review request for cloudstack, Brian Federle and Jessica Wang.
 By Konstantina Chremmou.

 *Updated Feb. 24, 2014, 5:47 p.m.*
  *Repository: * cloudstack-git
 Description

 Fixed some resource files issues, namely 1) invalid text and duplicate keys 
 resulting from bad merge and 2) trailing spaces which can potentially cause 
 UI issues.

   Diffs

- client/WEB-INF/classes/resources/messages.properties (bd4a27d)
- client/WEB-INF/classes/resources/messages_es.properties (31a9c93)
- client/WEB-INF/classes/resources/messages_ja_JP.properties (7dd5bd1)
- client/WEB-INF/classes/resources/messages_nl_NL.properties (b1bfadb)
- client/WEB-INF/classes/resources/messages_pl.properties (9024030)
- client/WEB-INF/classes/resources/messages_pt_BR.properties (07fd3f4)
- client/WEB-INF/classes/resources/messages_zh_CN.properties (88b13a1)

 View Diff https://reviews.apache.org/r/18432/diff/




-- 

EOF

Re: Yet another mail on code quality

[Laszlo Hornyak]

Hi,

Guys if you feel like, look around in sonar sometimes, it registers and
tracks tons of such issues (and the app is cool, nice and super-trendy)

https://analysis.apache.org/dashboard/index/100206

For incorrect use of == operator, sonar knows 14 more cases in ACS, There
are some that not nice but works, but quite a few seem to be a positive.

https://analysis.apache.org/drilldown/issues/100206?rule=pmd%3ACompareObjectsWithEqualsrule_sev=MAJORseverity=MAJOR

Regards,
Laszlo


On Mon, Feb 24, 2014 at 5:14 PM, Hugo Trippaers h...@trippaers.nl wrote:

 Guys,

 Please pay attention to the code you are committing. Today i fixed a
 number of issues that were introduced in recent code, these are bugs that
 could have been prevented from entering master by either testing or running
 the findbugs checks. One was committed directly, the other one through a
 reviewed patch.


 @@ -116,7 +116,7 @@ public class Upgrade430to440 implements DbUpgrade {
  if (networkRs.next()) {
  String guesttype = networkRs.getString(1);

 -if (guesttype ==
 Network.GuestType.Shared.toString()) {
 +if
 (guesttype.equals(Network.GuestType.Shared.toString())) {
  pstmtUpdate =
 conn.prepareStatement(UPDATE `cloud`.`user_ip_address` SET account_id = ?,
 domain_id= ? WHERE public_ip_address = ?);
  pstmtUpdate.setLong(1,vmAccountId);
  pstmtUpdate.setLong(2,vmDomainId);



 @@ -80,11 +80,11 @@ public class LibvirtStoragePoolXMLParser {
  String targetPath = getTagValue(path, target);

  String portValue = getAttrValue(host, port, source);
 -if (portValue != )
 +if (portValue != null  !portValue.isEmpty())
  port = Integer.parseInt(portValue);

  return new
 LibvirtStoragePoolDef(LibvirtStoragePoolDef.poolType.valueOf(format.toUpperCase()),


 To help, i've configured the slowbuild to alert if the number of high
 priority findings from findbugs differs from the previous run. It will
 notify all developers that had changes during this period (slowbuild runs
 every 4 hours).

 Cheers,

 Hugo




-- 

EOF

Re: Review Request 18358: NetUtils unit testing

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18358/#review35319
---


 Verified, looks good. Daan, ok to merge?

- Laszlo Hornyak


On Feb. 22, 2014, 1:41 p.m., Miguel Ferreira wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18358/
 ---
 
 (Updated Feb. 22, 2014, 1:41 p.m.)
 
 
 Review request for cloudstack, daan Hoogland and Hugo Trippaers.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 - Refactor tests:
   - Upgrade tests to use jUnit4
   - Break big tests in small unit tests
   - Replace assertTrue/False with complex conditions by assertThat with
 specific matchers
 - Remove dead code:
   - Private static method never called locally
 - Add test for method that validates CIDRs
 
 
 Diffs
 -
 
   pom.xml 1e9e8d8 
   utils/src/com/cloud/utils/net/NetUtils.java c22e39a 
   utils/test/com/cloud/utils/net/NetUtilsTest.java d3e283c 
 
 Diff: https://reviews.apache.org/r/18358/diff/
 
 
 Testing
 ---
 
 Ran all the tests in the test class before and after refactoring.
 
 
 Thanks,
 
 Miguel Ferreira
 

Re: Review Request 18432: Fixed some resource files issues

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18432/#review35320
---


looks great

- Laszlo Hornyak


On Feb. 24, 2014, 5:47 p.m., Konstantina Chremmou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18432/
 ---
 
 (Updated Feb. 24, 2014, 5:47 p.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Fixed some resource files issues, namely 1) invalid text and duplicate keys 
 resulting from bad merge and 2) trailing spaces which can potentially cause 
 UI issues.
 
 
 Diffs
 -
 
   client/WEB-INF/classes/resources/messages.properties bd4a27d 
   client/WEB-INF/classes/resources/messages_es.properties 31a9c93 
   client/WEB-INF/classes/resources/messages_ja_JP.properties 7dd5bd1 
   client/WEB-INF/classes/resources/messages_nl_NL.properties b1bfadb 
   client/WEB-INF/classes/resources/messages_pl.properties 9024030 
   client/WEB-INF/classes/resources/messages_pt_BR.properties 07fd3f4 
   client/WEB-INF/classes/resources/messages_zh_CN.properties 88b13a1 
 
 Diff: https://reviews.apache.org/r/18432/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Konstantina Chremmou
 

Re: Review Request 18358: NetUtils unit testing

[Laszlo Hornyak]

Miguel, here is my patch that for me fixed the dependency problems. Other
than that, it looks good.

Thank you,
Laszlo


On Fri, Feb 21, 2014 at 7:54 PM, Laszlo Hornyak laszlo.horn...@gmail.comwrote:

This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/18358/

 Hi Miguel,

 I started working on verification and I ran into some dependency problem. 
 hamcrest-library is needed as dependency and junit 4.10 needs to be upgraded 
 to 4.11



 - Laszlo Hornyak

 On February 21st, 2014, 4:43 p.m. UTC, Miguel Ferreira wrote:
   Review request for cloudstack, daan Hoogland and Hugo Trippaers.
 By Miguel Ferreira.

 *Updated Feb. 21, 2014, 4:43 p.m.*
  *Repository: * cloudstack-git
 Description

 - Refactor tests:
   - Upgrade tests to use jUnit4
   - Break big tests in small unit tests
   - Replace assertTrue/False with complex conditions by assertThat with
 specific matchers
 - Remove dead code:
   - Private static method never called locally
 - Add test for method that validates CIDRs

   Testing

 Ran all the tests in the test class before and after refactoring.

   Diffs

- utils/src/com/cloud/utils/net/NetUtils.java (c22e39a)
- utils/test/com/cloud/utils/net/NetUtilsTest.java (d3e283c)

 View Diff https://reviews.apache.org/r/18358/diff/




-- 

EOF
From 728239ddabef9b9775df74df47fd58a117e1515a Mon Sep 17 00:00:00 2001
From: Laszlo Hornyak laszlo.horn...@gmail.com
Date: Fri, 21 Feb 2014 19:58:12 +0100
Subject: [PATCH 2/2] Fixes for 1c4bf5f163bd721daa0b53e3d43d3de13a3b05d9

- upgraded junit to 4.11
- added hamcrest-library 1.3 dependency, test are building on it

Signed-off-by: Laszlo Hornyak laszlo.horn...@gmail.com
---
 pom.xml | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 1e9e8d8..4532679 100644
--- a/pom.xml
+++ b/pom.xml
@@ -49,7 +49,8 @@
 cs.logging.version1.1.1/cs.logging.version
 cs.discovery.version0.5/cs.discovery.version
 cs.ejb.version3.0/cs.ejb.version
-cs.junit.version4.10/cs.junit.version
+!-- do not forget to also upgrade hamcrest library with junit --
+cs.junit.version4.11/cs.junit.version
 cs.bcprov.version1.46/cs.bcprov.version
 cs.jsch.version0.1.42/cs.jsch.version
 cs.jpa.version2.0.0/cs.jpa.version
@@ -414,6 +415,12 @@
   scopetest/scope
 /dependency
 dependency
+  groupIdorg.hamcrest/groupId
+  artifactIdhamcrest-library/artifactId
+  version1.3/version
+  scopetest/scope
+/dependency
+dependency
   groupIdorg.mockito/groupId
   artifactIdmockito-all/artifactId
   version1.9.5/version
-- 
1.8.3.1

Re: UI Latency

[Laszlo Hornyak]

The tomcat/apache configuration is good for dynamic compression. At the
same time, dynamic compression of static content is takes quite significant
CPU-time on the server, and it will have to do it for each client. Also,
since it happens when you download (by then it should have been
compressed), it repays only with really slow network connections and
relatively underutilized servers. With static compression, we can have
static content compressed only once, it will be ok as long as the server
works.


On Fri, Feb 14, 2014 at 5:59 AM, Rajani Karuturi rajani.karut...@citrix.com
 wrote:

 I agree with John. We should enable gzip compression on tomcat/apache and
 let it handle.
 What we should be doing in the application is minification of CSS/JS and
 trying to reduce the number of static files/static get requests..

 Thanks,
 ~Rajani



 On 14-Feb-2014, at 2:50 am, John Kinsella j...@stratosec.comailto:
 j...@stratosec.co wrote:

 Seems a bit like wheel-reinventing, no? Wouldn't it be cleaner to get
 Tomcat's built-in compression[1] working? What I don't see in your code is
 any ability to negotiate if the end-client supports gzip compression...

 John
 1:http://viralpatel.net/blogs/enable-gzip-compression-in-tomcat/

 On Feb 13, 2014, at 12:09 PM, Laszlo Hornyak laszlo.horn...@gmail.com
 mailto:laszlo.horn...@gmail.commailto:laszlo.horn...@gmail.com wrote:

 Ah yes we are playing space-wars, I will fix it as soon as I get there. I
 was not that much interested in space/tabs but what it already does:
 - at build time it generates .gz files from static resources, like css,
 html and js files
 - during runtime it checks if there is a gz file for the resource and
 silently serves the gz file and sets the headers, only if the client
 browser accepts gz of course
 - respects Etag since you do not want to download even just 500 Kb each
 time you hit ctrl-r.

 TODO other than the space-war:
 - it uses a maven plugin I have built for home use, it is in my maven repo
 and it would not be great to give my unreliable repository to everyone, so
 it should be either moved to the ACS source or uploaded to the central repo
 - Some a would not like to make the build even longer. It is quite short
 compared to the full time of the build, but for a CI build it is completely
 useless. So it must be moved to a profile and profile should be active
 during release process, maybe not anyway unless you manually enable it.




 On Thu, Feb 13, 2014 at 7:23 PM, John Kinsella j...@stratosec.comailto:
 j...@stratosec.comailto:j...@stratosec.co wrote:

 Looks like Daan had a few issues with the patch for you to resolve
 regarding tabs and headers...

 On Feb 13, 2014, at 10:14 AM, Laszlo Hornyak laszlo.horn...@gmail.com
 mailto:laszlo.horn...@gmail.commailto:laszlo.horn...@gmail.com
 mailto:laszlo.horn...@gmail.com wrote:

 Hi,

 I have a patch for the UI compression, it is on review for a while...
 But I hope I will be able to resolve the comments in...days.

 I measured the download size dropped from 3.5 MB to somewhere around 0.5 MB

 https://reviews.apache.org/r/12228/

 Adding javascript compression could also help a lot.

 That 3.5 M is a lot even on LAN :-)



 On Thu, Feb 13, 2014 at 7:04 PM, John Kinsella j...@stratosec.co wrote:

 Just posted
 http://theresnomon.co/2014/improving-cloudstack-ui-performance/ - open to
 any comments.

 John

 On Feb 10, 2014, at 12:47 AM, Alex Hitchins alex.hitch...@shapeblue.com
 mailto:alex.hitch...@shapeblue.com wrote:

 Sounds interesting, I look forward to your write-up.



 Regards

 Alex Hitchins

 D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

 alex.hitch...@shapeblue.commailto:alex.hitch...@shapeblue.com

 -Original Message-
 From: John Kinsella [mailto:j...@stratosec.co]
 Sent: 10 February 2014 01:05
 To: dev@cloudstack.apache.org
 Subject: Re: UI Latency

 I've been tinkering with httpd proxying the UI via mod_proxy_ajp, then
 using mod_deflate to compress on the httpd side. That gets me about a 2.5x
 decrease in loading the login screen. system.js, which is the largest item
 downloaded by default is around 980k, with gzip that drops to 68k.

 I wanna see if I can squeeze a little more performance out by caching the
 static stuff...once I get some stats out of that I'll turn it into a blog
 post later this week.

 John

 On Feb 9, 2014, at 3:27 PM, Alex Hitchins alex.hitch...@shapeblue.com
 wrote:

 One of the things that I want to look in to is generating a Gruntfile so
 we can 'uglify' and reduce the size of css, js and image sprites. This
 should help reduce the initial payload and make a big difference to VPN/low
 b/w connections.


 Regards

 Alex Hitchins

 D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

 alex.hitch...@shapeblue.com

 -Original Message-
 From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
 Sent: 09 February 2014 19:51
 To: dev@cloudstack.apache.org
 Subject: Re: UI Latency

 I could be wrong, but I believe

Re: UI Latency

[Laszlo Hornyak]

Hi,

I have a patch for the UI compression, it is on review for a while...
But I hope I will be able to resolve the comments in...days.

I measured the download size dropped from 3.5 MB to somewhere around 0.5 MB

https://reviews.apache.org/r/12228/

Adding javascript compression could also help a lot.

That 3.5 M is a lot even on LAN :-)



On Thu, Feb 13, 2014 at 7:04 PM, John Kinsella j...@stratosec.co wrote:

 Just posted
 http://theresnomon.co/2014/improving-cloudstack-ui-performance/ - open to
 any comments.

 John

 On Feb 10, 2014, at 12:47 AM, Alex Hitchins alex.hitch...@shapeblue.com
 mailto:alex.hitch...@shapeblue.com wrote:

 Sounds interesting, I look forward to your write-up.



 Regards

 Alex Hitchins

 D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

 alex.hitch...@shapeblue.commailto:alex.hitch...@shapeblue.com

 -Original Message-
 From: John Kinsella [mailto:j...@stratosec.co]
 Sent: 10 February 2014 01:05
 To: dev@cloudstack.apache.org
 Subject: Re: UI Latency

 I've been tinkering with httpd proxying the UI via mod_proxy_ajp, then
 using mod_deflate to compress on the httpd side. That gets me about a 2.5x
 decrease in loading the login screen. system.js, which is the largest item
 downloaded by default is around 980k, with gzip that drops to 68k.

 I wanna see if I can squeeze a little more performance out by caching the
 static stuff...once I get some stats out of that I'll turn it into a blog
 post later this week.

 John

 On Feb 9, 2014, at 3:27 PM, Alex Hitchins alex.hitch...@shapeblue.com
 wrote:

 One of the things that I want to look in to is generating a Gruntfile so
 we can 'uglify' and reduce the size of css, js and image sprites. This
 should help reduce the initial payload and make a big difference to VPN/low
 b/w connections.


 Regards

 Alex Hitchins

 D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

 alex.hitch...@shapeblue.com

 -Original Message-
 From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
 Sent: 09 February 2014 19:51
 To: dev@cloudstack.apache.org
 Subject: Re: UI Latency

 I could be wrong, but I believe the idea of zipping the content for the UI
 start page was discussed, but has not yet been implemented.

 As far as I know (and have experienced), every time you go to the start
 page, it does seem to take a while to load if you are not over a
 particularly fast connection (if I'm in the office, it loads quickly; if
 I'm over a VPN connection from, say, home, it tends to be noticeably
 slower).


 On Sun, Feb 9, 2014 at 8:46 AM, Mo m...@daoenix.com wrote:

 Hello,

 From my understanding going to the UI at first start-up takes awhile
 to load due to the way it is configured, I believe I was previously
 told it was gzip for the website. However, I thought this would a one
 time thing; it seems to take quite awhile to load UI each time I
 visit, unlike versions gone by.

 Any advice? Suggestions?

 - Maurice




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *(tm)*
 Need Enterprise Grade Support for Apache CloudStack?
 Our CloudStack Infrastructure Support
 http://shapeblue.com/cloudstack-infrastructure-support/ offers the best
 24/7 SLA for CloudStack Environments.

 Apache CloudStack Bootcamp training courses

 **NEW!** CloudStack 4.2.1
 traininghttp://shapeblue.com/cloudstack-training/
 18th-19th February 2014, Brazil.
 Classroomhttp://shapeblue.com/cloudstack-training/
 17th-23rd March 2014, Region A. Instructor led,
 On-linehttp://shapeblue.com/cloudstack-training/
 24th-28th March 2014, Region B. Instructor led,
 On-linehttp://shapeblue.com/cloudstack-training/
 16th-20th June 2014, Region A. Instructor led,
 On-linehttp://shapeblue.com/cloudstack-training/
 23rd-27th June 2014, Region B. Instructor led,
 On-linehttp://shapeblue.com/cloudstack-training/

 This email and any attachments to it may be confidential and are intended
 solely for the use of the individual to whom it is addressed. Any views or
 opinions expressed are solely those of the author and do not necessarily
 represent those of Shape Blue Ltd or related companies. If you are not the
 intended recipient of this email, you must neither take any action based
 upon its contents, nor copy or show it to anyone. Please contact the sender
 if you believe you have received this email in error. Shape Blue Ltd is a
 company incorporated in England  Wales. ShapeBlue Services India LLP is a
 company incorporated in India and is operated under license from Shape Blue
 Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
 and is operated under license from Shape Blue Ltd. ShapeBlue is a
 registered trademark.


 This email and any attachments to it may be confidential and are intended
 solely for the use of the individual to whom it is addressed. Any views 

Re: UI Latency

[Laszlo Hornyak]

Ah yes we are playing space-wars, I will fix it as soon as I get there. I
was not that much interested in space/tabs but what it already does:
- at build time it generates .gz files from static resources, like css,
html and js files
- during runtime it checks if there is a gz file for the resource and
silently serves the gz file and sets the headers, only if the client
browser accepts gz of course
- respects Etag since you do not want to download even just 500 Kb each
time you hit ctrl-r.

TODO other than the space-war:
- it uses a maven plugin I have built for home use, it is in my maven repo
and it would not be great to give my unreliable repository to everyone, so
it should be either moved to the ACS source or uploaded to the central repo
- Some a would not like to make the build even longer. It is quite short
compared to the full time of the build, but for a CI build it is completely
useless. So it must be moved to a profile and profile should be active
during release process, maybe not anyway unless you manually enable it.




On Thu, Feb 13, 2014 at 7:23 PM, John Kinsella j...@stratosec.co wrote:

 Looks like Daan had a few issues with the patch for you to resolve
 regarding tabs and headers...

 On Feb 13, 2014, at 10:14 AM, Laszlo Hornyak laszlo.horn...@gmail.com
 mailto:laszlo.horn...@gmail.com wrote:

 Hi,

 I have a patch for the UI compression, it is on review for a while...
 But I hope I will be able to resolve the comments in...days.

 I measured the download size dropped from 3.5 MB to somewhere around 0.5 MB

 https://reviews.apache.org/r/12228/

 Adding javascript compression could also help a lot.

 That 3.5 M is a lot even on LAN :-)



 On Thu, Feb 13, 2014 at 7:04 PM, John Kinsella j...@stratosec.co wrote:

 Just posted
 http://theresnomon.co/2014/improving-cloudstack-ui-performance/ - open to
 any comments.

 John

 On Feb 10, 2014, at 12:47 AM, Alex Hitchins alex.hitch...@shapeblue.com
 mailto:alex.hitch...@shapeblue.com wrote:

 Sounds interesting, I look forward to your write-up.



 Regards

 Alex Hitchins

 D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

 alex.hitch...@shapeblue.commailto:alex.hitch...@shapeblue.com

 -Original Message-
 From: John Kinsella [mailto:j...@stratosec.co]
 Sent: 10 February 2014 01:05
 To: dev@cloudstack.apache.org
 Subject: Re: UI Latency

 I've been tinkering with httpd proxying the UI via mod_proxy_ajp, then
 using mod_deflate to compress on the httpd side. That gets me about a 2.5x
 decrease in loading the login screen. system.js, which is the largest item
 downloaded by default is around 980k, with gzip that drops to 68k.

 I wanna see if I can squeeze a little more performance out by caching the
 static stuff...once I get some stats out of that I'll turn it into a blog
 post later this week.

 John

 On Feb 9, 2014, at 3:27 PM, Alex Hitchins alex.hitch...@shapeblue.com
 wrote:

 One of the things that I want to look in to is generating a Gruntfile so
 we can 'uglify' and reduce the size of css, js and image sprites. This
 should help reduce the initial payload and make a big difference to VPN/low
 b/w connections.


 Regards

 Alex Hitchins

 D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969

 alex.hitch...@shapeblue.com

 -Original Message-
 From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
 Sent: 09 February 2014 19:51
 To: dev@cloudstack.apache.org
 Subject: Re: UI Latency

 I could be wrong, but I believe the idea of zipping the content for the UI
 start page was discussed, but has not yet been implemented.

 As far as I know (and have experienced), every time you go to the start
 page, it does seem to take a while to load if you are not over a
 particularly fast connection (if I'm in the office, it loads quickly; if
 I'm over a VPN connection from, say, home, it tends to be noticeably
 slower).


 On Sun, Feb 9, 2014 at 8:46 AM, Mo m...@daoenix.com wrote:

 Hello,

 From my understanding going to the UI at first start-up takes awhile
 to load due to the way it is configured, I believe I was previously
 told it was gzip for the website. However, I thought this would a one
 time thing; it seems to take quite awhile to load UI each time I
 visit, unlike versions gone by.

 Any advice? Suggestions?

 - Maurice




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *(tm)*
 Need Enterprise Grade Support for Apache CloudStack?
 Our CloudStack Infrastructure Support
 http://shapeblue.com/cloudstack-infrastructure-support/ offers the best
 24/7 SLA for CloudStack Environments.

 Apache CloudStack Bootcamp training courses

 **NEW!** CloudStack 4.2.1
 traininghttp://shapeblue.com/cloudstack-training/
 18th-19th February 2014, Brazil.
 Classroomhttp://shapeblue.com/cloudstack-training/
 17th-23rd March 2014, Region A. Instructor led

Re: Review Request 17335: cleanup around seemingly impossible cast

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/#review34060
---


License header!

- Laszlo Hornyak


On Feb. 2, 2014, 5:03 p.m., Laszlo Hornyak wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/17335/
 ---
 
 (Updated Feb. 2, 2014, 5:03 p.m.)
 
 
 Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
  - changed type parameters on details map in CreateSecondaryStagingStoreCmd - 
 String, String was misleading since the it can not work with a string value 
 and it is never a string
  - introducing the type parameters allowed some simplifications in 
 getDetails()
  - added unit test
 
 
 Diffs
 -
 
   
 api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java
  1480e75 
   
 api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java
  PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/17335/diff/
 
 
 Testing
 ---
 
 - all unit tests passed
 - checked all references and usage of the details field, injection with the 
 @Parameter annotation
 
 
 Thanks,
 
 Laszlo Hornyak
 

Re: code-sprint at Schuberg Philis'

[Laszlo Hornyak]

I can not join you in Netherlands, but in my free time I will work on unit
tests.


On Sat, Feb 8, 2014 at 9:46 PM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 H,

 We are going to have a week of close quarter code bashing starting
 this monday. We will have a focus on reducing findbugs hits and
 increasing unit test coverage. At the moment there are eight of us but
 we would love to see more people at our site in Schiphol-Rijk. If any
 of you want to join in please contact me or Hugo and we'll get you
 through the gates. ;)

 I hope this notice isn't too short on the event.

 regards,
 --
 Daan




-- 

EOF

Re: Build failed in Jenkins: build-master #262

[Laszlo Hornyak]

Guys, why is jenkins asking for authentication when I want to view the
surefire reports? Unfortunately I do not have a user in this instance, so I
disabled this test for now.

If someone could create a user for me, that would also solve the problem...

Thank you,
Laszlo


On Sun, Feb 9, 2014 at 10:50 PM, jenk...@cloudstack.org wrote:

 See http://jenkins.buildacloud.org/job/build-master/262/changes

 Changes:

 [laszlo.hornyak] cleanup in LibvirtComputingResource

 [laszlo.hornyak] removed unused variables

 [laszlo.hornyak] safely close resource with java 1.7 resource block

 [laszlo.hornyak] replaced Integer reference comparsion with .equals

 [laszlo.hornyak] removed self-assignment

 [laszlo.hornyak] String concatenation cleanup

 [laszlo.hornyak] Minor Boolean expression simplification

 [laszlo.hornyak] Boolean expression simplification

 [laszlo.hornyak] Replaced String concatenation in loop

 [laszlo.hornyak] Cleanup in UriUtils.encodeURIComponent

 --
 [...truncated 20040 lines...]
 624/894 KB
 628/894 KB
 632/894 KB
 636/894 KB
 640/894 KB
 644/894 KB
 648/894 KB
 652/894 KB
 656/894 KB
 660/894 KB
 664/894 KB
 668/894 KB
 672/894 KB
 676/894 KB
 680/894 KB
 684/894 KB
 688/894 KB
 692/894 KB
 696/894 KB
 700/894 KB
 704/894 KB
 708/894 KB
 712/894 KB
 716/894 KB
 720/894 KB
 724/894 KB
 728/894 KB
 732/894 KB
 736/894 KB
 740/894 KB
 744/894 KB
 748/894 KB
 752/894 KB
 756/894 KB
 760/894 KB
 764/894 KB
 768/894 KB
 772/894 KB
 776/894 KB
 780/894 KB
 784/894 KB
 788/894 KB
 792/894 KB
 796/894 KB
 800/894 KB
 804/894 KB
 808/894 KB
 812/894 KB
 816/894 KB
 820/894 KB
 824/894 KB
 828/894 KB
 832/894 KB
 836/894 KB
 840/894 KB
 844/894 KB
 848/894 KB
 852/894 KB
 856/894 KB
 860/894 KB
 864/894 KB
 868/894 KB
 872/894 KB
 876/894 KB
 880/894 KB
 884/894 KB
 888/894 KB
 892/894 KB
 894/894 KB

 Downloaded:
 http://repo.maven.apache.org/maven2/net/java/dev/jna/jna/4.0.0/jna-4.0.0.jar(894
  KB at 16240.0 KB/sec)
 [INFO]
 [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
 cloud-plugin-hypervisor-kvm ---
 [INFO] Deleting 
 http://jenkins.buildacloud.org/job/build-master/ws/plugins/hypervisors/kvm
 (includes = [target, dist], excludes = [])
 [INFO]
 [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @
 cloud-plugin-hypervisor-kvm ---
 [INFO] Starting audit...
 Audit done.

 [INFO]
 [INFO] --- maven-remote-resources-plugin:1.3:process (default) @
 cloud-plugin-hypervisor-kvm ---
 [WARNING] Missing POM for org.libvirt:libvirt:jar:0.5.1
 [INFO]
 [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @
 cloud-plugin-hypervisor-kvm ---
 [debug] execute contextualize
 [INFO] Using 'UTF-8' encoding to copy filtered resources.
 [INFO] Copying 2 resources
 [INFO] Copying 3 resources
 [INFO]
 [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @
 cloud-plugin-hypervisor-kvm ---
 [INFO] Compiling 36 source files to 
 http://jenkins.buildacloud.org/job/build-master/ws/plugins/hypervisors/kvm/target/classes
 
 [INFO]
 [INFO] --- maven-resources-plugin:2.5:testResources
 (default-testResources) @ cloud-plugin-hypervisor-kvm ---
 [debug] execute contextualize
 [INFO] Using 'UTF-8' encoding to copy filtered resources.
 [INFO] skip non existing resourceDirectory 
 http://jenkins.buildacloud.org/job/build-master/ws/plugins/hypervisors/kvm/test/resources
 
 [INFO] Copying 3 resources
 [INFO]
 [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @
 cloud-plugin-hypervisor-kvm ---
 [INFO] Compiling 9 source files to 
 http://jenkins.buildacloud.org/job/build-master/ws/plugins/hypervisors/kvm/target/test-classes
 
 [INFO]
 [INFO] --- maven-surefire-plugin:2.12:test (default-test) @
 cloud-plugin-hypervisor-kvm ---
 [INFO] Surefire report directory: 
 http://jenkins.buildacloud.org/job/build-master/ws/plugins/hypervisors/kvm/target/surefire-reports
 

 ---
  T E S T S
 ---
 Running com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
 log4j:WARN No appenders could be found for logger
 (com.cloud.hypervisor.kvm.resource.LibvirtComputingResource).
 log4j:WARN Please initialize the log4j system properly.
 log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
 more info.
 Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.6 sec
  FAILURE!
 Running com.cloud.hypervisor.kvm.resource.LibvirtSecretDefTest
 Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec
 Running com.cloud.hypervisor.kvm.resource.LibvirtStoragePoolDefTest
 Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec
 Running com.cloud.hypervisor.kvm.resource.LibvirtDomainXMLParserTest
 Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.194 sec
 Running com.cloud.hypervisor.kvm.resource.LibvirtVifDriverTest
 Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, 

Re: Code quality, QA, etc

[Laszlo Hornyak]

Hi,

I used to work with gerrit in OS projects and I think the tool is great,
the integration with jenkins is cool.
One problem could be when jenkins infrastructure problems are frequent and
developers start to ignore warnings from jenkins.
With my particular project we were also frequently hit by gerrit outages. I
do not know the reason since I did not operate the infrastructure, but
having 1-2 outages per week was normal.

This is the technical part and I am sure you can make a more reliable
service.

We also had Review-then-commit process, and in general I had a bad
experience with the process. I do believe the code review is necessary in
an open source project and it can improve quality, but at the same time the
costs (in time and lost braincells) are very high and the existence of a
process does not guarantee that the quality will improve. No process
replaced thinking so far.
Once I complained about having the 30th version of a patch that in my
opinion was quite simple and then someone answered that he is already over
the 40th review. It took several months to push something through the
process. And those numbers just kept growing. We collected some of the top
reasons with my team:
- the review was not really a review, the reviewer only looked at the code
in firefox. Never checked out, never ran the tests.
- reviewer expectations were various even in the same language and module
between reviewers, unfortunately this was not documented, so you had to use
the try-and-fail process to learn individual reviewer preferences, it took
quite a lot of time since the team was huge
- one had to wait for review sometimes for several weeks. Meanwhile the
patch got outdated and had to be rewritten, and then the whole process
started over again.
- Also, reviewers blocked at the first issue found in the patch. This was
usually in the commit comment, they did not like it. So you change the
commit comment and hope that next time the guy will read some actual code.
Maybe he will block on something like he does not like your variable name.
This is especially annoying when you send an urgent fix.
- The typical reason for merging a patch was the release deadline. Just a
few days before the deadline they merged everything. So we have spent
several months and still only the developer tested the code.

In my opinion a review tool is not enough to make the review process
productive, you need good reviewers.

Regards,
Laszlo

On Fri, Feb 7, 2014 at 4:50 AM, David Nalley da...@gnsa.us wrote:

 Hi folks,

 We continue to break things large and small in the codebase, and after
 a number of different conversations; I thought I'd bring that
 discussion here.

 First - coding quality is only one factor that the PMC considers when
 making someone a committer.

 Second - CloudStack is a huge codebase; has a ton of inter-related
 pieces, and unintended consequences are easy.

 We also have an pretty heady commit velocity - 20+ commits today alone.

 Some communities have Review-then-commit - which would slow us down,
 and presumably help us increase quality. However, I am not personally
 convinced that it will do so measurably because even the most
 experienced CloudStack developers occasionally break a build or worse.

 We could have an automated pipeline that verifies a number of
 different tests pass - before a patch/commit makes it into a mainline
 branch. That is difficult with our current tooling; but perhaps
 something worth considering.

 At FOSDEM, Hugo and I were discussing his experiences with Gerrit and
 OpenDaylight, and he thinks thats a viable option. I think it would
 certainly be a step in the right direction.

 Separately, Jake Farrell and I were discussing our git-related
 proposal for ApacheCon, and broached the subject of Gerrit. Jake is
 the current person bearing most of the load for git at the ASF, and
 he's also run Gerrit in other contexts. He points out a number of
 difficulties. (And I'd love for him to weigh in on this conversation,
 hence the CC) He wants to expand RB significantly, including
 pre-commit testing.

 So - thoughts, comments, flames? How do we improve code quality, stop
 needless breakage? Much of this is going to be cultural I think, and I
 personally think we struggle with that. Many folks have voiced an
 opinion about stopping continued commits when the build is broken; but
 we haven't been able to do that.

 --David




-- 

EOF

Re: Add reviewer to Review requests (was: ReviewBoard)

[Laszlo Hornyak]

Bookmarked, thank you!

This developer guide I worked with so far is seriously misleading.


On Sun, Feb 2, 2014 at 4:27 PM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 It should be on the wiki :

 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Current+Maintainers+Per+Component

 On Sun, Feb 2, 2014 at 4:19 PM, Laszlo Hornyak laszlo.horn...@gmail.com
 wrote:
  Hi Daan,
 
  I would start doing so right now, but I have never heard of a list of
  component maintainers and google didn't find one for me either. Ideally,
  such list should be here: http://cloudstack.apache.org/developers.htmlor
  it should be at least linked from this page.
 
  Thank you,
  Laszlo
 
 
  On Sun, Feb 2, 2014 at 11:26 AM, Daan Hoogland daan.hoogl...@gmail.com
 wrote:
 
  LS,
 
  I would like to see contributers add reviewers to their submissions. I
  noticed quite soe old review requests that don't have anyone's
  attention. There are component 'owners' for everything and I have easy
  speach as I am not listed as contact for any component but I wouldn't
  mind being assinged and then calling in who I considder the expert on
  a subject. It will prevent these long standing review requests in my
  opinion.
 
  thoughts, counters, rants?
 
  Daan
 
  On Sun, Feb 2, 2014 at 10:38 AM, David Nalley da...@gnsa.us wrote:
   I have not. Yesterday RB went down for some period of time, though
   AFAIK, infra restored it.
  
   --David
  
   On Sat, Feb 1, 2014 at 4:11 PM, Daan Hoogland 
 daan.hoogl...@gmail.com
  wrote:
   H David,
  
   have you started on this yet?
   I can't reach the review board at the moment.
  
   On Mon, Jan 27, 2014 at 8:59 PM, David Nalley da...@gnsa.us wrote:
   Hi folks:
  
   ReviewBoard is pretty bloated. There are currently 93 reviews that
 are
  open.
  
   Some of those haven't been updated in 7 months old.
  
   Unless someone objects (and promptly begins reviewing and applying
   patches) I will close any patch that hasn't been updated in 2
 months.
  
   Please take a few minutes to go look through ReviewBoard and update
   things as appropriate.
  
   --David
 
 
 
 
  --
 
  EOF




-- 

EOF

Re: Review Request 17335: cleanup around seemingly impossible cast

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/
---

(Updated Feb. 2, 2014, 5:03 p.m.)


Review request for cloudstack, Alena Prokharchyk, Alex Huang, and Min Chen.


Changes
---

Added Alena Prokharchyk API component owner as reviewer


Repository: cloudstack-git


Description
---

 - changed type parameters on details map in CreateSecondaryStagingStoreCmd - 
String, String was misleading since the it can not work with a string value 
and it is never a string
 - introducing the type parameters allowed some simplifications in getDetails()
 - added unit test


Diffs
-

  
api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java
 1480e75 
  
api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/17335/diff/


Testing
---

- all unit tests passed
- checked all references and usage of the details field, injection with the 
@Parameter annotation


Thanks,

Laszlo Hornyak

Re: Review Request 12228: wip: static resource compression

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
---

(Updated Feb. 2, 2014, 5:04 p.m.)


Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna 
Santhanam.


Repository: cloudstack-git


Description
---

CloudStack at first use downloads some 3.5 MB of css and javascript to the 
client. With a weak internet connection, this might take a long time. With gzip 
compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so 
that no dynamic compression is needed at runtime. When the static resource 
servlet notices that there is gzipped version of the resource and the client 
accepts gzipped content, then it is going to send the gziped version, while 
still respects http caching.


Diffs
-

  client/WEB-INF/web.xml e5c05d3 
  client/pom.xml 119c96e 
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12228/diff/


Testing
---


Thanks,

Laszlo Hornyak

Review Request 17335: cleanup around seemingly impossible cast

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17335/
---

Review request for cloudstack, Alex Huang and Min Chen.


Repository: cloudstack-git


Description
---

 - changed type parameters on details map in CreateSecondaryStagingStoreCmd - 
String, String was misleading since the it can not work with a string value 
and it is never a string
 - introducing the type parameters allowed some simplifications in getDetails()
 - added unit test


Diffs
-

  
api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java
 1480e75 
  
api/test/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmdTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/17335/diff/


Testing
---

- all unit tests passed
- checked all references and usage of the details field, injection with the 
@Parameter annotation


Thanks,

Laszlo Hornyak

Re: [Proposal] Switch to Java 7

[Laszlo Hornyak]

+1 for java 1.7 and resource blocks, it will help to simplify


On Tue, Jan 7, 2014 at 11:50 PM, Hugo Trippaers trip...@gmail.com wrote:

 I would be in favor as well. In addition to the already discussed reasons,
 I think it would be good to try to get our users to a well maintained
 version of Java. From a security point of view 1.6 is not a smart choice
 any more.

 Upgrading to Jdk 7 could also trigger an upgrade to tomcat 7. Best
 practice indicates that t6 should be used with Jdk 16 and T7 with Jdk 17. I
 didn't check yet if t7 is available in our supported distros atm.

 Anyway I would propose to bump the version of CS to 5 when we do this, so
 we clearly indicate to our users that something serious has changed. Some
 of our users will have to upgrade components outside the CS scope (Jdk) and
 I think that warrants a major version bump.

 Cheers,

 Hugo

 Verstuurd vanaf mijn iPad

  Op 7 jan. 2014 om 23:38 heeft Kelven Yang kelven.y...@citrix.com het
 volgende geschreven:
 
  +1 for switching to Java 7 in CloudStack 4.4.
 
  Kelven
 
  On 1/6/14, 10:27 PM, Wido den Hollander w...@widodh.nl wrote:
 
  Just to repeat what has been discussed some time ago.
 
  All the current Long Term Support distributions have Java 7 available.
 
  RHEL6, RHEL7, Ubuntu 12.04, Ubuntu 14.04 (due in April) will all have
  Java 7 available.
 
  I don't see a problem in switching to Java 7 with CloudStack 4.4 or 4.5
 
  Wido
 
  On 01/07/2014 12:18 AM, Kelven Yang wrote:
  Java 7 has been around for some time now. I strongly suggest CloudStack
  to adopt Java 7 as early as possible, the reason I feel like to raise
  the issue is from the some of practicing with the new DB transaction
  pattern, as following example shows.  The new Transaction pattern uses
  anonymous class to beautify the code structure, but in the mean time,
 it
  will introduce a couple runtime costs
 
1.  Anonymous class introduces a ³captured context², information
  exchange between the containing context and the anonymous class
  implementation context has either to go through with mutable passed-in
  parameter or returned result object, in the following example, without
  changing basic Transaction framework, I have to exchange through
  returned result with an un-typed array. This has a few implications at
  run time, basically with each call of the method, it will generate two
  objects to the heap. Depends on how frequently the involved method will
  be called, it may introduce quite a burden to java GC process
2.  Anonymous class captured context also means that there will be
  more hidden classes be generated, since each appearance of the
 anonymous
  class implementation will have a distance copy of its own as hidden
  class, it will generally increase our permanent heap usage, which is
  already pretty huge with current CloudStack code base.
 
  Java 7 has a language level support to address the issues in a cheaper
  way that our current DB Transaction code pattern is trying to solve.
 
 http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceCl
  ose.html.   So, time to adopt Java 7?
 
  public OutcomeVirtualMachine startVmThroughJobQueue(final String
  vmUuid,
  final MapVirtualMachineProfile.Param, Object params,
  final DeploymentPlan planToDeploy) {
 
  final CallContext context = CallContext.current();
  final User callingUser = context.getCallingUser();
  final Account callingAccount = context.getCallingAccount();
 
  final VMInstanceVO vm = _vmDao.findByUuid(vmUuid);
 
 
  Object[] result = Transaction.execute(new
  TransactionCallbackObject[]() {
  @Override
  public Object[] doInTransaction(TransactionStatus status) {
  VmWorkJobVO workJob = null;
 
 _vmDao.lockRow(vm.getId(), true);
 ListVmWorkJobVO pendingWorkJobs =
  _workJobDao.listPendingWorkJobs(VirtualMachine.Type.Instance,
  vm.getId(), VmWorkStart.class.getName());
 
 if (pendingWorkJobs.size()  0) {
 assert (pendingWorkJobs.size() == 1);
 workJob = pendingWorkJobs.get(0);
 } else {
 workJob = new VmWorkJobVO(context.getContextId());
 
 
  workJob.setDispatcher(VmWorkConstants.VM_WORK_JOB_DISPATCHER);
 workJob.setCmd(VmWorkStart.class.getName());
 
 workJob.setAccountId(callingAccount.getId());
 workJob.setUserId(callingUser.getId());
 workJob.setStep(VmWorkJobVO.Step.Starting);
 workJob.setVmType(vm.getType());
 workJob.setVmInstanceId(vm.getId());
 
  workJob.setRelated(AsyncJobExecutionContext.getOriginJobContextId());
 
 // save work context info (there are some duplications)
  VmWorkStart workInfo = new
  VmWorkStart(callingUser.getId(), callingAccount.getId(), vm.getId(),
  VirtualMachineManagerImpl.VM_WORK_JOB_HANDLER);
 

Re: Request: Help designing a 'powered by' logo for CloudStack

[Laszlo Hornyak]

I want to avoid having an overlay on the image, so I will return to my
previous design and fix that. Guys if you want the monkey, now you have a
very easy job :-)


On Thu, Dec 5, 2013 at 10:37 AM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 Yes Kirk, that would help. That or a scale down of the cloud and
 monkey in comparison to the letters. (I have no problem with any of
 our fellow primates)

 On Thu, Dec 5, 2013 at 12:11 AM, Kirk Jantzer kirk.jant...@gmail.com
 wrote:
  Daan - agreed about the balance, however disagree about the monkey. I
 think
  if the text was a layer over the cloud, it might be more balanced, like
  this: http://i.imgur.com/WTNAIoG.png (not the same font or text, but the
  idea)
 
 
  Regards,
 
  Kirk Jantzer
  http://about.me/kirkjantzer
 
 
  On Wed, Dec 4, 2013 at 4:34 PM, Daan Hoogland daan.hoogl...@gmail.com
 wrote:
 
  I actually don't like the cute creature in there. from a graphical
  stance; it ruins the balance in the logo, hanging out on the top
  right. maybe because of the form factor. maybe you can try one without
  the monkey and one cut in which the centre of the picture is between
  the base of the monkey tail and the start of the cloud.
 
  sorry to nag,
  Daan
 
  On Wed, Dec 4, 2013 at 10:00 PM, Laszlo Hornyak
  laszlo.horn...@gmail.com wrote:
   Hi,
  
   Sending version 0.0.3:
   - Complete monkey added
   - Apache added
   - Clouds more like the original logo
   This also comes with some cons:
   - 4 colors
   - lots of text, at least compared to 0.0.1
   but if you look at it scaled down to very small, it is still readable,
  even
   the monkey is so-so.
  
   Just in case someone feels like experimenting, I also attached the up
 to
   date version of my reverse engineered cloudstack monkey with cloud.
  
   steroidmonkey is just a bit different from the poweredbycloudstack
 svg,
  spot
   the difference :-)
  
   Your feedback is welcome!
  
   Thank you,
   Laszlo
  
  
   On Tue, Dec 3, 2013 at 11:31 AM, Daan Hoogland 
 daan.hoogl...@gmail.com
   wrote:
  
   I like,
   2. But I agree with Rbyn about the word apache. I should be in there.
   I think it must even.
   1. It looks streched on my preview in finder as well
  
   On Mon, Dec 2, 2013 at 9:47 PM, Robyn Bergeron rberg...@redhat.com
   wrote:
   
   
- Original Message -
From: Laszlo Hornyak laszlo.horn...@gmail.com
To: dev@cloudstack.apache.org
Cc: market...@cloudstack.apache.org
Sent: Sunday, December 1, 2013 10:31:11 AM
Subject: Re: Request: Help designing a 'powered by' logo for
  CloudStack
   
Hi,
   
Here is my version:
 - SVG format as you requested
 - Only two colors, exactly the same as for the original logo. I
  prefer
few
colors for such pictures
 - Unfortunately the monkey could not make it, the whole thing
 needs
  to
fit
into a very small area and the monkey would be too little detail
 (the
monkey is übercool anyway)
 - if no monkey, then cloud
 - only powered by cloudstack, no extra text because it make
 make
difficult to read in such a small place
 - see attached file :)
   
Hi,
   
I like the cloud idea/placement. (And totally get that it's going
 to
  be
hard to see the monkey in such a small space. Even though he's so
  cute.)
   
Two things -
   
1) The lettering in the word cloudstack looks stretched as
 compared
with the normal look of the font - I'm not sure if that's
  intentional, not
intentional, something really weird in how it's rendering on my
  screen... :)
2) I realize the problem around no extra text but ... do we want
 to
add in the word apache? (or conversely, is there any reason why it
  shouldn't
be added in... legal, etc)?
   
-robyn
   
   
   
   
On Fri, Nov 15, 2013 at 6:56 PM, David Nalley da...@gnsa.us
 wrote:
   
 Hi folks:

 If you happen to have some graphical design talent (I have
 none) I
 have a great opportunity for you :)

 CloudStack needs a 'powered by' logo that is easy to consume,
 and
  is
 also attractive.

 A couple examples of powered by logos:

 http://tomcat.apache.org/images/tomcat-power.gif



 
 https://cwiki.apache.org/confluence/download/attachments/80899/mahout-logo-poweredby-100.png?version=1modificationDate=1312880703000



 
 https://netbeans.org/images_www/screenshots/6.0/baseIDE_ant_powered_150px.png

 A couple of constraints:
 * Please don't use the Apache feather. (we could, but lets not;
 it
 will make life simpler)
 * Please try and produce a vector format as source (this allows
 us
  to
 scale/etc)
 * Because this will become a trademark (which is vastly
 different
 that
 copyright) - we will likely need some explicit email agreement
  around
 trademarks rights for the image. (I promise, it isn't as scary
 as
 that
 sentence makes it out to be.)

 Anyone

Re: test failures

[Laszlo Hornyak]

Hi,

I wrote those tests a few weeks ago, it may be my mistake. It works for me
after git rebase. Could you send me a full log from the build + testcase
output txt/xml file?

Thank you,
Laszlo


On Wed, Dec 4, 2013 at 2:07 AM, Min Chen min.c...@citrix.com wrote:

 I am encountering the same.

 Thanks
 -min

 On 12/3/13 4:41 PM, Alena Prokharchyk alena.prokharc...@citrix.com
 wrote:

 Does anybody experience this test failure on the latest master?
 
 Results :
 
 Tests in error:
   getColumnName(com.cloud.utils.DbUtilTest)
   getColumnName(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   isPersistable(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   isPersistable(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   getTableName(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   getTableName(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   getGlobalLock(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   getGlobalLock(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   getGlobalLockTimeout(com.cloud.utils.DbUtilTest): Could not initialize
 class com.cloud.utils.db.TransactionLegacy
   getGlobalLockTimeout(com.cloud.utils.DbUtilTest): Could not initialize
 class com.cloud.utils.db.TransactionLegacy
   closeNull(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
   closeNull(com.cloud.utils.DbUtilTest): Could not initialize class
 com.cloud.utils.db.TransactionLegacy
 




-- 

EOF

Re: Request: Help designing a 'powered by' logo for CloudStack

[Laszlo Hornyak]

Hi,

Thank you all for the feedback!
- stretching: yes, that is true and it does not look good
- apache: If I have to put the apache there, then I will have to completely
rearrange the design. Are you sure it is a must-have? Wikipedia displays a
logo without the apache.
http://en.wikipedia.org/wiki/Apache_CloudStack
- etc: the powered by font type does not go well with the cloudstack

I go back to my drawing board and see what I can do for v0.0.2


On Tue, Dec 3, 2013 at 11:31 AM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 I like,
 2. But I agree with Rbyn about the word apache. I should be in there.
 I think it must even.
 1. It looks streched on my preview in finder as well

 On Mon, Dec 2, 2013 at 9:47 PM, Robyn Bergeron rberg...@redhat.com
 wrote:
 
 
  - Original Message -
  From: Laszlo Hornyak laszlo.horn...@gmail.com
  To: dev@cloudstack.apache.org
  Cc: market...@cloudstack.apache.org
  Sent: Sunday, December 1, 2013 10:31:11 AM
  Subject: Re: Request: Help designing a 'powered by' logo for CloudStack
 
  Hi,
 
  Here is my version:
   - SVG format as you requested
   - Only two colors, exactly the same as for the original logo. I prefer
 few
  colors for such pictures
   - Unfortunately the monkey could not make it, the whole thing needs to
 fit
  into a very small area and the monkey would be too little detail (the
  monkey is übercool anyway)
   - if no monkey, then cloud
   - only powered by cloudstack, no extra text because it make make
  difficult to read in such a small place
   - see attached file :)
 
  Hi,
 
  I like the cloud idea/placement. (And totally get that it's going to be
 hard to see the monkey in such a small space. Even though he's so cute.)
 
  Two things -
 
  1) The lettering in the word cloudstack looks stretched as compared
 with the normal look of the font - I'm not sure if that's intentional, not
 intentional, something really weird in how it's rendering on my screen... :)
  2) I realize the problem around no extra text but ... do we want to
 add in the word apache? (or conversely, is there any reason why it
 shouldn't be added in... legal, etc)?
 
  -robyn
 
 
 
 
  On Fri, Nov 15, 2013 at 6:56 PM, David Nalley da...@gnsa.us wrote:
 
   Hi folks:
  
   If you happen to have some graphical design talent (I have none) I
   have a great opportunity for you :)
  
   CloudStack needs a 'powered by' logo that is easy to consume, and is
   also attractive.
  
   A couple examples of powered by logos:
  
   http://tomcat.apache.org/images/tomcat-power.gif
  
  
 https://cwiki.apache.org/confluence/download/attachments/80899/mahout-logo-poweredby-100.png?version=1modificationDate=1312880703000
  
  
 https://netbeans.org/images_www/screenshots/6.0/baseIDE_ant_powered_150px.png
  
   A couple of constraints:
   * Please don't use the Apache feather. (we could, but lets not; it
   will make life simpler)
   * Please try and produce a vector format as source (this allows us to
   scale/etc)
   * Because this will become a trademark (which is vastly different that
   copyright) - we will likely need some explicit email agreement around
   trademarks rights for the image. (I promise, it isn't as scary as that
   sentence makes it out to be.)
  
   Anyone interested?
  
   --David
  
 
 
 
  --
 
  EOF
 




-- 

EOF