Re: [ANNOUNCE] new committer: Suresh Anaparti

2020-11-17 Thread Nitin Maharana 
Congratulations, Suresh!

Thanks,
Nitin

On Wed, Nov 18, 2020 at 11:22 AM Harikrishna Patnala <
harikrishna.patn...@shapeblue.com> wrote:

> Congratulations Suresh 🙂
> 
> From: Sven Vogel 
> Sent: Wednesday, November 18, 2020 4:17 AM
> To: dev@cloudstack.apache.org ;
> us...@cloudstack.apache.org 
> Cc: Suresh Anaparti 
> Subject: [ANNOUNCE] new committer: Suresh Anaparti
>
> Hi everyone,
>
>
>  The Project Management Committee (PMC) for Apache CloudStack
> has invited Suresh Anaparti to become a committer and we are pleased
> to announce that he has accepted.
>
> Please join me in congratulating Suresh on this accomplishment.
>
>
> Being a committer enables easier contribution to the
> project since there is no need to go via the patch
> submission process. This should enable better productivity.
>
>
> Thanks and Cheers,
>
>
>
> Sven Vogel
> Apache CloudStack PMC member
>
> harikrishna.patn...@shapeblue.com
> www.shapeblue.com
> 3 London Bridge Street,  3rd floor, News Building, London  SE1 9SG
> @shapeblue
>
>
>
>

Prime Minister of India: Commit To Ensuring A Healthy Work-Life Balance For Working Indians #RightToDisconnect

2020-03-04 Thread nitin . maharana 
Hey,

I just signed the petition "Prime Minister of India: Commit To Ensuring A
Healthy Work-Life Balance For Working Indians #RightToDisconnect" and
wanted to see if you could help by adding your name.

Our goal is to reach 150,000 signatures and we need more support. You can
read more and sign the petition here:

http://chng.it/9wdKGQQrNf

Thanks!
Nitin Kumar

Re: [VOTE] Primate as modern UI for CloudStack

2019-10-07 Thread Nitin Maharana 
+1

On Mon, 7 Oct 2019 at 8:39 PM, Sven Vogel  wrote:

> +1 (binding)
>
>
> __
>
> Sven Vogel
> Teamlead Platform
>
> EWERK DIGITAL GmbH
> BrĂŒhl 24, D-04109 Leipzig
> 
> P +49 341 42649 - 99
> F +49 341 42649 - 98
> s.vo...@ewerk.com
> www.ewerk.com
>
> GeschĂ€ftsfĂŒhrer:
> Dr. Erik Wende, Hendrik Schubert, Frank Richter
> Registergericht: Leipzig HRB 9065
>
> Zertifiziert nach:
> ISO/IEC 27001:2013
> DIN EN ISO 9001:2015
> DIN ISO/IEC 2-1:2011
>
> EWERK-Blog | LinkedIn | Xing | Twitter | Facebook
>
> AuskĂŒnfte und Angebote per Mail sind freibleibend und unverbindlich.
>
> Disclaimer Privacy:
> Der Inhalt dieser E-Mail (einschließlich etwaiger beigefĂŒgter Dateien) ist
> vertraulich und nur fĂŒr den EmpfĂ€nger bestimmt. Sollten Sie nicht der
> bestimmungsgemĂ€ĂŸe EmpfĂ€nger sein, ist Ihnen jegliche Offenlegung,
> VervielfÀltigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte
> informieren Sie in diesem Fall unverzĂŒglich den Absender und löschen Sie
> die E-Mail (einschließlich etwaiger beigefĂŒgter Dateien) von Ihrem System.
> Vielen Dank.
>
> The contents of this e-mail (including any attachments) are confidential
> and may be legally privileged. If you are not the intended recipient of
> this e-mail, any disclosure, copying, distribution or use of its contents
> is strictly prohibited, and you should please notify the sender immediately
> and then delete it (including any attachments) from your system. Thank you.
> > Am 07.10.2019 um 16:18 schrieb Nicolas Vazquez <
> nicolas.vazq...@shapeblue.com>:
> >
> > +1
> >
> >
> > Regards,
> >
> > Nicolas Vazquez
> >
> > 
> > From: Andrija Panic 
> > Sent: Monday, October 7, 2019 11:16 AM
> > To: users 
> > Cc: dev@cloudstack.apache.org ;
> priv...@cloudstack.apache.org 
> > Subject: Re: [VOTE] Primate as modern UI for CloudStack
> >
> > +1 (binding)
> >
> >
> > nicolas.vazq...@shapeblue.com
> > www.shapeblue.com
> > Amadeus House, Floral Street, London  WC2E 9DPUK
> > @shapeblue
> >
> >
> >
> > On Mon, 7 Oct 2019 at 15:53, Simon Weller 
> wrote:
> >
> >>
> >> +1 (binding)
> >> 
> >> From: Rohit Yadav 
> >> Sent: Monday, October 7, 2019 6:31 AM
> >> To: dev@cloudstack.apache.org ;
> >> us...@cloudstack.apache.org ;
> >> priv...@cloudstack.apache.org 
> >> Subject: [VOTE] Primate as modern UI for CloudStack
> >>
> >> All,
> >>
> >> The feedback and response has been positive on the proposal to use
> Primate
> >> as the modern UI for CloudStack [1] [2]. Thank you all.
> >>
> >> I'm starting this vote (to):
> >>
> >>  *   Accept Primate codebase [3] as a project under Apache CloudStack
> >> project
> >>  *   Create and host a new repository (cloudstack-primate) and follow
> >> Github based development workflow (issues, pull requests etc) as we do
> with
> >> CloudStack
> >>  *   Given this is a new project, to encourage cadence until its feature
> >> completeness the merge criteria is proposed as:
> >> *   Manual testing against each PR and/or with screenshots from the
> >> author or testing contributor, integration with Travis is possible once
> we
> >> get JS/UI tests
> >> *   At least 1 LGTM from any of the active contributors, we'll move
> >> this to 2 LGTMs when the codebase reaches feature parity wrt the
> >> existing/old CloudStack UI
> >> *   Squash and merge PRs
> >>  *   Accept the proposed timeline [1][2] (subject to achievement of
> goals
> >> wrt Primate technical release and GA)
> >> *   the first technical preview targetted with the winter 2019 LTS
> >> release (~Q1 2020) and release to serve a deprecation notice wrt the
> older
> >> UI
> >> *   define a release approach before winter LTS
> >> *   stop taking feature FRs for old/existing UI after winter 2019
> LTS
> >> release, work on upgrade path/documentation from old UI to Primate
> >> *   the first Primate GA targetted wrt summer LTS 2020 (~H2 2019),
> >> but still ship old UI with a final deprecation notice
> >> *   old UI codebase removed from codebase in winter 2020 LTS release
> >>
> >> The vote will be up for the next two weeks to give enough time for PMC
> and
> >> the community to gather consensus and still have room for questions,
> >> feedback and discussions. The results to be shared on/after 21th October
> >> 2019.
> >>
> >> For sanity in tallying the vote, can PMC members please be sure to
> >> indicate "(binding)" with their vote?
> >>
> >> [ ] +1  approve
> >> [ ] +0  no opinion
> >> [ ] -1  disapprove (and reason why)
> >>
> >> [1] Primate Proposal:
> >>
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Proposal%3A+CloudStack+Primate+UI
> >>
> >> [2] Email thread reference:
> >> https://markmail.org/message/z6fuvw4regig7aqb
> >>
> >> [3] Primate repo current location: https://github.com/shapeblue/primate
> >>
> >>
> >> Regards,
> >>
> >> Rohit Yadav
> >>
> >> Software Architect, ShapeBlu

Re: Community opinion regarding Apache events banner in CloudStack's website

2018-04-17 Thread Nitin Maharana 
+1 for the third option. I think It would even look good if we adjust the
vertical alignment of the word "Apache CloudStack" to center.

On Wed, Apr 18, 2018 at 12:12 AM, Rafael WeingÀrtner <
rafaelweingart...@gmail.com> wrote:

> Third option (suggested by Dag) -
> https://drive.google.com/open?id=16FEu9tD1HZqwxLp2lrnUBmsuRJNLpDqU
>
> On Tue, Apr 17, 2018 at 3:39 PM, Dag Sonstebo 
> wrote:
>
> > Hi Rafael – in my opinion you need it fairly prominent so people notice
> it
> > – so option 1, but maybe put it underneath the CloudMonkey logo on the
> > right hand side?
> >
> > Regards,
> > Dag Sonstebo
> > Cloud Architect
> > ShapeBlue
> >
> > On 17/04/2018, 19:35, "Rafael WeingÀrtner" 
> > wrote:
> >
> > Ah damm.. I forgot about the file stripping in our mailing list.
> > Sorry guys. Here they go.
> >
> > - first one:
> > https://drive.google.com/open?id=1vSqni_GEj3YJjuGehxe-_dnrNqQP7x8y
> >
> > - second one:
> > https://drive.google.com/open?id=1LEmt9g5ceAUeTuc2a1Cb4uctOwyz5eQ8
> >
> > On Tue, Apr 17, 2018 at 3:31 PM, Dag Sonstebo <
> > dag.sonst...@shapeblue.com>
> > wrote:
> >
> > > The white one is quite nice â˜ș
> > >
> > > Joking aside – looks like they got stripped from your email Rafael.
> > >
> > > Regards,
> > > Dag Sonstebo
> > > Cloud Architect
> > > ShapeBlue
> > >
> > > From: Rafael WeingÀrtner 
> > > Reply-To: "dev@cloudstack.apache.org" 
> > > Date: Tuesday, 17 April 2018 at 19:13
> > > To: users , dev <
> > dev@cloudstack.apache.org>
> > > Subject: Community opinion regarding Apache events banner in
> > CloudStack's
> > > website
> > >
> > > Hello folks,
> > > I am trying to work out something to put Apache events banner on
> our
> > > website. So far I came up with two proposals. Which one of them do
> > you guys
> > > prefer?
> > > First one:
> > > [cid:ii_jg3zjco00_162d4ce7db0cd3da]
> > >
> > >
> > > Second:
> > > [cid:ii_jg3zk0e01_162d4cefaef3a1ce]
> > >
> > > --
> > > Rafael WeingÀrtner
> > >
> > > dag.sonst...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > @shapeblue
> > >
> > >
> > >
> > >
> >
> >
> > --
> > Rafael WeingÀrtner
> >
> >
> >
> > dag.sonst...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
>
>
> --
> Rafael WeingÀrtner
>

Re: Remove 'md5Hashed' variable from Javascript

2018-04-12 Thread Nitin Maharana 
+1

On Mon, Apr 9, 2018 at 11:01 PM, Rafael WeingÀrtner <
rafaelweingart...@gmail.com> wrote:

> Hello fellow CloudStackers,
>
> Today I was working on CLOUDSTACK-5235, which is a security issue, and I
> noticed a variable ‘md5Hashed’ in the javascript that does not seem to be
> useful at all. This variable was used to control if we hash or not the
> password of users in the user side (browser). However, we no longer hash
> the password on the user side. All of the password processing is executed
> in the server side according to the priority of hashing mechanism defined
> by the administrator.
>
> I am addressing this cleanup with this PR
> https://github.com/apache/cloudstack/pull/2555.
>
> If you have any objections regarding this variable and its relate code
> removal, please do so. Otherwise, we will proceed to remove it.
>
> --
> Rafael WeingÀrtner
>

Re: Notice that Gabriel BrÀscher now works at PCextreme

2018-03-20 Thread Nitin Maharana 
Congratulations, Gabriel!!!

On Tue, Mar 20, 2018 at 10:14 PM, Sateesh Chodapuneedi <
sateesh.chodapune...@accelerite.com> wrote:

> Congrats Gabriel.
>
> Regards,
> Sateesh
>
> ï»ż-Original Message-
> From: Wido den Hollander 
> Reply-To: "dev@cloudstack.apache.org" 
> Date: Tuesday, 20 March 2018 at 7:21 PM
> To: "dev@cloudstack.apache.org" 
> Cc: "gabrasc...@gmail.com" 
> Subject: Notice that Gabriel BrÀscher now works at PCextreme
>
> Hi,
>
> Just wanted to let you know that Gabriel BrÀscher started working at
> PCextreme this week.
>
> He'll be committing and developing on CloudStack for PCextreme and the
> community.
>
> Just so everybody knows that we are colleagues now.
>
> Let's make CloudStack even better!
>
> Wido
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>

Re: New committer: Dag Sonstebo

2018-03-20 Thread Nitin Maharana 
Congratulations, Dag!!

On Tue, Mar 20, 2018 at 7:34 PM, Paul Angus 
wrote:

> Congratulations, well deserved!
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Nicolas Vazquez 
> Sent: 20 March 2018 14:02
> To:  
> Subject: Re: New committer: Dag Sonstebo
>
> Good news, congratulations Dag!
>
> 
> From: John Kinsella 
> Sent: Tuesday, March 20, 2018 10:58:22 AM
> To: 
> Subject: New committer: Dag Sonstebo
>
> The Project Management Committee (PMC) for Apache CloudStack has invited
> Dag Sonsteboto become a committer and we are pleased to announce that he
> has accepted.
>
> I'll take a moment here to remind folks that being an ASF committer isn't
> purely about code - Dag has been helping out for quite a while on users@,
> and seems to have a strong interest around ACS and the community. We
> welcome this activity, and encourage others to help out as they can - it
> doesn't necessarily have to be purely code-related.
>
> Being a committer enables easier contribution to the project since there
> is no need to go via the patch submission process. This should enable
> better productivity.
>
> Please join me in welcoming Dag!
>
> John
>
> nicolas.vazq...@shapeblue.com
> www.shapeblue.com
> ,
> @shapeblue
>
>
>
>

[GitHub] cloudstack pull request #2031: CLOUDSTACK - 8672 : Test PR

2017-04-06 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/2031

CLOUDSTACK - 8672 : Test PR

Currently running with few commit. Please don't review this PR.
According to the result of this PR, I will update in original PR(1859).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8672-TEST

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2031


commit 58aec81013b44a2e83052adc2a9f9c802210e7db
Author: Rajesh Battala 
Date:   2015-07-23T08:44:07Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.

commit 2ce10b7d97b63edfb24465dfd22a525f99ee1b90
Author: Priyank Parihar 
Date:   2015-08-07T11:10:00Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.

commit b0b1914985320f62ca3f8c0838ea8e10dd28
Author: Nitin Kumar Maharana 
Date:   2015-08-07T11:40:13Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.

commit 29e4f70742ce0a9b91cb3111bac282b5a0cd8331
Author: Sowmya Krishnan 
Date:   2017-01-25T11:47:43Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.
Marvin Integration Tests for Shared and Dedicated Workflow.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-13 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@rafaelweingartner : As there are multiple contributors to this feature, If 
I squash it to one commit, then others are going to lose their part of 
contributions. Initially, we thought of making it to one commit, but this is 
the main reason we pushed with multiple commits. Let's wait for others to 
comment on this, after that we will decide. Thanks, @rafaelweingartner for 
pitching in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-13 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
It has already two LGTMs and contains all successful test results. This is 
a big change, as time passes there are more chances of conflicts 
appearance(Already resolved once). If anyone wants to review, please do it else 
we should consider merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1870: CLOUDSTACK-9708: Router deployment failed due to two...

2017-03-08 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1870
  
@remibergsma : Can you please review it again. Fixed the test failures.

ping @jayapalu @rajesh-battala 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-03-08 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-03-08 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1771#discussion_r104902049
  
--- Diff: ui/scripts/system.js ---
@@ -2090,27 +2090,57 @@
 fields: {
 vlanrange: {
 label: 
'label.vlan.vni.range',
-/*  select: 
function(args) {
-var items = [];
-
if(args.context.physicalNetworks[0].vlan != null && 
args.context.physicalNetworks[0].vlan.length > 0) {
-var vlanranges = 
args.context.physicalNetworks[0].vlan.split(";");
-for(var i = 0; i < 
vlanranges.length ; i++) {
-items.push({id: 
vlanranges[i], description: vlanranges[i]});
-}
-}
-
args.response.success({data: items});
-},*/
 validation: {
 required: true
 }
 },
-account: {
-label: 
'label.account',
-validation: {
-required: true
+scope: {
+label: 
'label.scope',
+docID: 
'helpGuestNetworkZoneScope',
+select: 
function(args) {
+var array1 = 
[];
+
+array1.push({
+id: 
'account-specific',
+
description: 'label.account'
+});
+array1.push({
+id: 
'project-specific',
+
description: 'label.project'
+});
+
+
args.response.success({
+data: 
array1
+});
+
+
args.$select.change(function() {
+var $form 
= $(this).closest('form');
+
+if 
($(this).val() == "account-specific") {
+
$form.find('.form-item[rel=domainId]').css('display', 'inline-block');
+
$form.find('.form-item[rel=account]').css('display', 'inline-block');
+
$form.find('.form-item[rel=projectId]').hide();
+} else if 
($(this).val() == "project-specific") {
+
$form.find('.form-item[rel=domainId]').css('display', 'inline-block');
+
$form.find('.form-item[rel=account]').hide();
+
$form.find('.form-item[rel=projectId]').css('display', 'inline-block');
+

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-03-08 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : In case of project view, the projectId is always passed. 
Also we consider it as project scope but we won't have any option to choose 
projects from a list because we are already under a project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Ping @sowmyakrishn @jayapalu 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-03-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
ping @rhtyd @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-03-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : Please verify, I have changed according to your suggestion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-03-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : The createProject API allows to created a project under a 
domain but no idea if there is any support from UI. Whenever I create a 
project, it always goes to ROOT domain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@rajesh-battala : Currently running, will post once completes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-03-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : Yes, if domain changes, the project list should change. 
As per my understanding, a project is similar to an account. When we create 
a project, by default it is always created in ROOT domain. But an account can 
be created in a specific domain. I am still not clear what is the need of 
project.

As all the projects are under ROOT domain, if we select any domain other 
than ROOT, the project list would be empty. So I think we needn't use the 
domain list in project scope and instead we should list all projects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-06 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Please find the test plan executed from below link(Updated in wiki page).

https://cwiki.apache.org/confluence/display/CLOUDSTACK/NCC+Integration+with+CloudStack+Test+Plan



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-06 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@rajesh-battala : Will update the same in wiki page. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-06 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-06 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
@karuturi : Currently running. Will post once completes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-06 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
@cloudmonger


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-04 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
ping @rajesh-battala @sowmyakrishn 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-03-02 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
@koushik-das : No failure now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-03-01 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : I have modified the code, can you review it one more time. 
Please see the below snapshot.

https://cloud.githubusercontent.com/assets/12583725/23455743/b4d7be00-fe96-11e6-8a41-398c41f6d019.png";>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-03-01 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : You are correct. We have to remove the domain scope. If we 
support the domain scope, we need more changes on the logic. In that case we 
can create a new ticket for that. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-03-01 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou : Passing project with domain won't create any issue but not 
passing any account details when we call the API from default view creates an 
issue. Because the internal logic expects account owner of VLAN when dedicated 
from the default view. In the case of project view, it gets the account detail 
from selected project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-02-28 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou @koushik-das : I implemented the way @ustcweizhou's suggested. 
It was purely an UI change. But I found an issue while testing.

On API side, the entire logic uses VLAN owner account details, they find it 
from the account given by the user. So, they made account field as mandatory. 
But that contradicts when it is accessed from a project view(This issue). 

The current logic works in a default view because we don't add projectid 
details while accessing the API. But when it is accessed from a particular 
project view, by default the projectid parameter is added with the API call, So 
this issue arises. 

Now, if we go with the change suggested by @ustcweizhou, once we select the 
scope as domain, we don't pass any account details, so the logic can't able to 
find the owner hence gives an error.

According to my suggestion, On API side, we should make the account field 
as optional and on UI front, we should make it mandatory and the account field 
will appear only in case of default view, which will fix the issue. Please give 
your input on this. Accordingly, I will proceed.

Please see the current change(I pushed it here)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-28 Thread nitin-maharana 
GitHub user nitin-maharana reopened a pull request:

https://github.com/apache/cloudstack/pull/1771

CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work.

Description:
=

Trying to dedicate a guest VLAN range to an account fails. Either API 
documentation is wrong or code path needs to be corrected. If we pass both 
account and projectId parameters to the dedicateGuestVlanRange (which are not 
mentioned as mutually exclusive in API description) the API layer throws error 
saying both are mutually exclusive.

Steps to Reproduce:
===
Create an account. Create a project in that account.

Go to Admin account and change the view to the above project.

Navigate to Infrastructure -> Zone -> Physical Network -> Guest -> Dedicate 
Guest VLAN range.

Try to dedicate the guest VLAN range from the project view for the account 
associated with the project.

It fails with error saying "accountName and projectId are mutually 
exclusive".


![image](https://cloud.githubusercontent.com/assets/12583725/20559763/15fe55d8-b19c-11e6-9996-62602d269f10.png)


![image](https://cloud.githubusercontent.com/assets/12583725/20559765/1957af36-b19c-11e6-938f-e9c7c9eee987.png)

Expected:
===
The VLAN range should get dedicated to the project account.


![image](https://cloud.githubusercontent.com/assets/12583725/20559787/33ef67b2-b19c-11e6-90fd-41c9c583efd9.png)


![image](https://cloud.githubusercontent.com/assets/12583725/20559789/376cae22-b19c-11e6-9755-ff1e7237fb21.png)

Resolution:

Changed the account field of API to optional.
Even if the account name is passed while adding from a particular project 
view, then it is ignored in API.

Notes:
=
If we do the dedication from default view then it works fine as no 
projectId is associated over there.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1771.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1771


commit f56961392662f4b45e3e4cb989203f918ec19916
Author: Nitin Kumar Maharana 
Date:   2017-02-28T10:57:38Z

CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-28 Thread nitin-maharana 
Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1771


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #:

2017-02-27 Thread nitin-maharana 
Github user nitin-maharana commented on the pull request:


https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21082376
  
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java on line 295:
Build is failing due to this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-22 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1771#discussion_r102453548
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan 
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
 // Verify account is valid
 Account vlanOwner = null;
 if (projectId != null) {
-if (accountName != null) {
-throw new InvalidParameterValueException("accountName and 
projectId are mutually exclusive");
-}
+//accountName and projectId are mutually exclusive
--- End diff --

@koushik-das : If we go with the scope field, we have to revert that change 
and have to make required depending on the scope we select. Like shown in the 
below snapshot.

https://cloud.githubusercontent.com/assets/12583725/23212092/1ba1cd22-f92b-11e6-83ba-72dab04dc497.png";>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-21 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1771#discussion_r102173991
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan 
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
 // Verify account is valid
 Account vlanOwner = null;
 if (projectId != null) {
-if (accountName != null) {
-throw new InvalidParameterValueException("accountName and 
projectId are mutually exclusive");
-}
+//accountName and projectId are mutually exclusive
--- End diff --

@koushik-das @rajesh-battala : Do you agree with @ustcweizhou suggestion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-16 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1771#discussion_r101491925
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan 
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
 // Verify account is valid
 Account vlanOwner = null;
 if (projectId != null) {
-if (accountName != null) {
-throw new InvalidParameterValueException("accountName and 
projectId are mutually exclusive");
-}
+//accountName and projectId are mutually exclusive
--- End diff --

@koushik-das : Yes, We give priority to the project, if not specified then 
checking the account. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-16 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1771#discussion_r101470562
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan 
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
 // Verify account is valid
 Account vlanOwner = null;
 if (projectId != null) {
-if (accountName != null) {
-throw new InvalidParameterValueException("accountName and 
projectId are mutually exclusive");
-}
+//accountName and projectId are mutually exclusive
--- End diff --

@koushik-das : As I mentioned in resolution part, Even if the account name 
is passed while adding from a particular project view, then it is 
ignored(Removal part) in API. If we don't remove that validation check, then 
the same issue will happen again. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2017-02-14 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
ping @sateesh-chodapuneedi @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1786: CLOUDSTACK-9618: Load Balancer configuration page do...

2017-02-14 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1786
  
ping @sateesh-chodapuneedi @rajesh-battala @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-02-14 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
ping @karuturi @sateesh-chodapuneedi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

2017-02-14 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1758
  
ping @rajesh-battala @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-01-26 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Sure @rajesh-battala, will look at that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2016-12-31 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Hi @rajesh-battala, I have modified the code. Please review it once and let 
me know if any improvement required. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK-8672 : NCC Integration with CloudS...

2016-12-31 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r94272083
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/api/commands/DeployNetscalerVpxCmd.java
 ---
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.cloud.api.commands;
+
+import java.util.List;
+import java.util.Map;
+
+import javax.inject.Inject;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.NetworkResponse;
+import org.apache.cloudstack.api.response.ServiceOfferingResponse;
+import org.apache.cloudstack.api.response.SystemVmResponse;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.api.response.NetscalerLoadBalancerResponse;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.element.NetscalerLoadBalancerElementService;
+import com.cloud.user.Account;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.vm.VirtualMachine;
+
+@APICommand(name = "deployNetscalerVpx", responseObject = 
NetscalerLoadBalancerResponse.class, description = "Creates new NS Vpx",
+requestHasSensitiveInfo = true, responseHasSensitiveInfo = false)
+public class DeployNetscalerVpxCmd extends BaseAsyncCmd {
+
+public static final Logger s_logger = 
Logger.getLogger(DeployNetscalerVpxCmd.class.getName());
+private static final String s_name = "deployNetscalerVpx";
+@Inject
+NetscalerLoadBalancerElementService _netsclarLbService;
+
+/
+ API parameters /
+/
+
+@Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID, 
entityType = ZoneResponse.class, required = true, description = "availability 
zone for the virtual machine")
+private Long zoneId;
+
+@ACL
+@Parameter(name = ApiConstants.SERVICE_OFFERING_ID, type = 
CommandType.UUID, entityType = ServiceOfferingResponse.class, required = true, 
description = "the ID of the service offering for the virtual machine")
+private Long serviceOfferingId;
+
+@ACL
+@Parameter(name = ApiConstants.TEMPLATE_ID, type = CommandType.UUID, 
entityType = TemplateResponse.class, required = true, description = "the ID of 
the template for the virtual machine")
+private Long templateId;
+
+@Parameter(name = ApiConstants.NETWORK_ID,
+type = CommandType.UUID,
+entityType = NetworkResponse.class, required=false,
+description = "The network this ip address should be 
associated to.")
+private Long networkId;
+/
+/// Accessors ///
+/
+
+
+
+/
+/// API Implementation///
+/

[GitHub] cloudstack pull request #1859: CLOUDSTACK-8672 : NCC Integration with CloudS...

2016-12-31 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r94271338
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/vm/NetScalerVMManager.java
 ---
@@ -0,0 +1,86 @@
+//Licensed to the Apache Software Foundation (ASF) under one
+//or more contributor license agreements.  See the NOTICE file
+//distributed with this work for additional information
+//regarding copyright ownership.  The ASF licenses this file
+//to you under the Apache License, Version 2.0 (the
+//"License"); you may not use this file except in compliance
+//with the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+//Unless required by applicable law or agreed to in writing,
+//software distributed under the License is distributed on an
+//"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+//KIND, either express or implied.  See the License for the
+//specific language governing permissions and limitations
+//under the License.
+package com.cloud.network.vm;
+import java.util.Map;
+
+import com.cloud.api.commands.DeployNetscalerVpxCmd;
+import com.cloud.deploy.DeployDestination;
+import com.cloud.deploy.DeploymentPlan;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.router.VirtualRouter;
+import com.cloud.user.Account;
+
+public interface NetScalerVMManager {
+
+//RAM/CPU for the system offering used by Internal LB VMs
+ public static final int DEFAULT_NETSCALER_VM_RAMSIZE = 2048;
// 2048 MB
+ public static final int DEFAULT_NETSCALER_VM_CPU_MHZ = 1024;
// 1024 MHz
+
+/* *//**
+  * Destroys Internal LB vm instance
+  * @param vmId
+  * @param caller
+  * @param callerUserId
+  * @return
+  * @throws ResourceUnavailableException
+  * @throws ConcurrentOperationException
+  *//*
+ boolean destroyInternalLbVm(long vmId, Account caller, Long callerUserId) 
throws ResourceUnavailableException, ConcurrentOperationException;
+
+ *//**
+  * Deploys internal lb vm
+  * @param guestNetwork
+  * @param requestedGuestIp
+  * @param dest
+  * @param owner
+  * @param params
+  * @return
+  * @throws InsufficientCapacityException
+  * @throws ConcurrentOperationException
+  * @throws ResourceUnavailableException
+  *//*
+ List deployInternalLbVm(Network guestNetwork, Ip 
requestedGuestIp, DeployDestination dest, Account owner, Map 
params)
+ throws InsufficientCapacityException, ConcurrentOperationException, 
ResourceUnavailableException;
+
+ *//**
+  *
+  * @param network
+  * @param rules
+  * @param internalLbVms
+  * @return
+  * @throws ResourceUnavailableException
+  *//*
+ boolean applyLoadBalancingRules(Network network, List 
rules, List internalLbVms) throws 
ResourceUnavailableException;
+
+ *//**
+  * Returns existing Internal Load Balancer elements based on 
guestNetworkId (required) and requestedIp (optional)
+  * @param guestNetworkId
+  * @param requestedGuestIp
+  * @return
+  *//*
+ List findInternalLbVms(long guestNetworkId, Ip 
requestedGuestIp);
+*/
+
+ public Map deployNetscalerServiceVm(DeployNetscalerVpxCmd 
cmd);
+
+ public VirtualRouter stopNetscalerServiceVm(Long id, boolean forced, 
Account callingAccount, long callingUserId) throws 
ConcurrentOperationException, ResourceUnavailableException;
+ public Map deployNsVpx(Account owner, DeployDestination 
dest, DeploymentPlan plan, long svcOffId, long templateId) throws 
InsufficientCapacityException;
+
+public VirtualRouter stopNetScalerVm(Long id, boolean forced, Account 
callingAccount, long callingUserId);
+}
--- End diff --

@rajesh-battala : There is no such character. It just says there is no new 
line at the end of the file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

2016-12-29 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1758
  
@sateesh-chodapuneedi @karuturi : Can you please review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1786: CLOUDSTACK-9618: Load Balancer configuration page do...

2016-12-29 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1786
  
@jburwell : As this is Netscaler specific. Yes, you need a Netscaler to 
verify.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #775: CLOUDSTACK-8805: Domains become inactive automaticall...

2016-12-27 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/775
  
Any update on this. This is a very old PR pending for a long time. Rebased 
the branch with latest 4.9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1870: CLOUDSTACK-9708: Router deployment filed due ...

2016-12-26 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1870

CLOUDSTACK-9708: Router deployment filed due to two threads start VR 
simultaneously.

Description:
=
Please see the description in 
https://issues.apache.org/jira/browse/CLOUDSTACK-9708

Resolution:

- The  SearchBuilder instance is a class scope variable that should be 
instantiated in the constructor.
- Since it was being instantiated in the scope of the method, parallel 
calls to the method will overwrite the class variable.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9708

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1870.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1870


commit 5092beaf0630efa89188be84f4334d7482c55ae7
Author: Nitin Kumar Maharana 
Date:   2016-12-26T13:21:46Z

CLOUDSTACK-9708: Router deployment filed due to two threads start VR 
simultaneosuly

Resolution:
- The  SearchBuilder instance is a class scope variable that should be 
instantiated in the constructor.
- Since it was being instantiated in the scope of the method, parallel 
calls to the method will overwrite the class variable.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1859#discussion_r93749580
  
--- Diff: ui/scripts/configuration.js ---
@@ -2640,12 +2640,30 @@
 }
 
 //show LB Isolation dropdown only 
when (1)LB Service is checked (2)Service Provider is Netscaler OR F5
-if 
((args.$form.find('.form-item[rel=\"service.Lb.isEnabled\"]').find('input[type=checkbox]').is(':checked')
 == true) && 
(args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val()
 == 'Netscaler' || 
args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val() 
== 'F5BigIp')) {
+/*if 
((args.$form.find('.form-item[rel=\"service.Lb.isEnabled\"]').find('input[type=checkbox]').is(':checked')
 == true) && 
(args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val()
 == 'Netscaler' || 
args.$form.find('.form-item[rel=\"service.Lb.provider\"]').find('select').val() 
== 'F5BigIp')) {
--- End diff --

@rajesh-battala : I will make required changes. Thanks for quick reivew.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1859

CLOUDSTACK - 8672 : NCC Integration with CloudStack 

Feature Specification Link :


https://cwiki.apache.org/confluence/display/CLOUDSTACK/NCC+Integration+With+Auto+Provision+VPX+in+CloudStack

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8672

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1859


commit 73ece624c2595f8c9cd7ba75fd8fa978e80c0ecf
Author: Rajesh Battala 
Date:   2015-07-23T08:44:07Z

Schema changes for NCC support. 1. netscaler service pacages, netscaler 
control center tables.Modified network offering table to hold service package

commit 8062e3dcdbf346ef3fca2d3642a6bd2113a982a2
Author: Rajesh Battala 
Date:   2015-07-23T08:45:24Z

Added Support for Adding/Registering Netscaler Control Center Service 
Packages to CloudStack

commit ee0587994862178069ee33290f888e5c0f26cd4c
Author: Rajesh Battala 
Date:   2015-07-23T08:49:45Z

Added Support for the Registering Netscaler Control Center, Added 
associated VO's Dao's DaoImpl's

commit 85fd68ebd7304665d7c45a18902f3c7b1becbb1b
Author: Rajesh Battala 
Date:   2015-07-23T08:52:48Z

Modified Network offering to include the Netscaler Service pacakge

commit 57db30f948c982a51ea3b5fb32f21b70767eccdb
Author: Rajesh Battala 
Date:   2015-07-23T08:54:39Z

Modified Netscaler Plugin to support Netscaler Control Center Changes

commit 9bfb98aa2fb4b29edd3fed102b4e631687d01b0a
Author: Rajesh Battala 
Date:   2015-07-23T08:57:08Z

Added NetscalerControlCenter Resource supporte and Change State Support

commit 1ebb6eda7e8bce9208ffd88ef380e0b4623901f6
Author: Rajesh Battala 
Date:   2015-07-23T08:58:20Z

Added json libaray mvn dependency in the Netscaler Plugin

commit ef06739713766027c05c004fcd9e421743808ad0
Author: Rajesh Battala 
Date:   2015-07-31T08:44:33Z

CLOUDSTACK-8673: Created NCC CommandTimeout param which is configurable to 
poll the AsyncJobs send to NCC

commit 053ec527e0ef585a8df6fcf277fa1a781cfe67c1
Author: Rajesh Battala 
Date:   2015-08-06T16:13:31Z

 CLOUDSTACK-8672: Implemented, implement the network with NCC as Service 
Provider.
 NCC will allocate the device to network, configures guest vlan and SNIP in 
the NS Device

commit 06a943cb4ed998fb51e69e05277879bf0e9baa93
Author: Rajesh Battala 
Date:   2015-08-06T16:16:56Z

CLOUDSTACK-8672: Implemented NetscalerControlResource to manage and 
delegate the calls to NCC Device

commit db202b7a682b0580a61373dcd542457eeff38c28
Author: Rajesh Battala 
Date:   2015-08-06T16:18:31Z

CLOUDSTACK-8672 Modified LoadBalancerTO to hold network id and public ip 
Vlan

commit 4f081bd5d9eb2743b7c74845099ac4083f1161c0
Author: Priyank Parihar 
Date:   2015-08-07T11:10:00Z

CLOUDSTACK-8672: Added ListRegisteredServicePackage Command.

commit 1b72dbed1d033dd51891a78fc3398b5bb25d4f5b
Author: Priyank Parihar 
Date:   2015-08-07T11:29:54Z

CLOUDSTACK-8672: Added DeleteServicePackageOffering Command.

commit 9a600ce63bfc5311ceb5974870529cad94306795
Author: Nitin Kumar Maharana 
Date:   2015-08-07T11:40:13Z

CLOUDSTACK-8672: Added ListNetscalerControlCenter command.

commit d68ee0ebf27da2cd50ae0534ab147ed05cf33fd7
Author: Priyank Parihar 
Date:   2015-08-07T11:42:26Z

CLOUDSTACK-8672: Added DeleteNetscalerControlCenter Command.

commit 7be6fab98c146a1f548a90307c8c08b70f53a900
Author: Nitin Kumar Maharana 
Date:   2016-12-18T18:13:23Z

LOUDSTACK-8672: Modified NCC Controlcenter Table

commit 6c583c20424f8d240010f8f126d98e4cad5fdcfa
Author: Nitin Kumar Maharana 
Date:   2015-08-24T11:15:49Z

CLOUDSTACK-8672 Added UI Support for the SSL Termination

1. UI Support for account to upload SSL Certificate.
2. UI Support for assigning SSL Certificate to a LB Rule.
3. Modified LB Rule creation UI to show LB Protocol and to show SSL based 
on LB Service provider capability.

commit 9c32d7ca4b30b1d47a57c5badda25258daeb819f
Author: Nitin Kumar Maharana 
Date:   2015-08-24T11:31:46Z

CLOUDSTACK-8672 New Dialog to assign a SSL certificate to LB Rule.

commit e0735fdc79d4abb3d8ac572f089bfa636d489f29
Author: Nitin Kumar Maharana 
Date:   2015-08-25T10:55:30Z

CLOUDSTACK-8672 Added UI Support for selecting Netscaler service packages 
when creating network offering with LB provier as Netscaler.

commit b5a868b60a27a24d270a1a1806152e75413f9702
Author: Priyank Parihar 
Date:   2015-08-26T11:18:14Z

CLOUDSTACK-8672: Added Acquire Pod Ip Command.

commit f76efa274c8ae36bf67e10bcd1e2ff5853771d78
Author: Priyank Parihar 
Date:   2015-08-26T11:20:31Z

CLOUDSTACK-8672: Added

[GitHub] cloudstack issue #1786: CLOUDSTACK-9618: Load Balancer configuration page do...

2016-12-11 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1786
  
Changed the base branch to 4.9.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

2016-12-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1758
  
@rajesh-battala : I went through the video but couldn't observe working on 
the add load balancer part. He touched the egress rules part. BTW, the tab was 
added in this commit 
https://github.com/apache/cloudstack/commit/196e36d194274067d16ee7dec037e2dd5721b839.
 I looked at the code change as well, which is very similar to what we do in 
case of load balancing section with an IP address.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #775: CLOUDSTACK-8805: Domains become inactive automaticall...

2016-12-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/775
  
Updated base branch to 4.9.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1333: CLOUDSTACK-9228: Network update with mistmatch in se...

2016-12-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1333
  
Updated base branch to 4.9.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1396: CLOUDSTACK-9269: Missing field for Switch type for M...

2016-12-07 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1396
  
Changed the base branch to 4.9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

2016-12-06 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1758
  
@rajesh-battala : Thanks for giving the details. I will go through the 
video. If i find a case where it is really required then I will modify the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

2016-12-06 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1758
  
@rajesh-battala : From my observation, I found whatever we can do in Add 
Load Balancer tab, the same can be performed in load balancing section after 
selecting any IP. Do you think any scenario where we cannot add rules by using 
the later one but can be done in Add load balancer tab? Can you please give the 
pointer to that video. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2016-12-06 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@rhtyd : Changed PR's base branch to 4.9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

2016-12-06 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1792
  
@jburwell : Switched the base branch to 4.9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1804: CLOUDSTACK-9639: Unable to create shared network wit...

2016-12-06 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1804
  
@rhtyd : Changed the base branch to 4.9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1804: CLOUDSTACK-9639: Unable to create shared netw...

2016-12-01 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1804#discussion_r90584766
  
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java 
---
@@ -3092,8 +3092,12 @@ public Vlan createVlanAndPublicIpRange(final long 
zoneId, final long networkId,
 final String guestNetworkCidr = zone.getGuestNetworkCidr();
 if (guestNetworkCidr != null) {
 if (NetUtils.isNetworksOverlap(newCidr, guestNetworkCidr)) 
{
-throw new InvalidParameterValueException("The new IP 
range you have specified has  overlapped with the guest network in zone: " + 
zone.getName()
-+ ". Please specify a different 
gateway/netmask.");
+// when adding shared network with same cidr of zone 
guest cidr,
+// if the specified vlan is not present in zone, 
physical network, allow to create the network as the isolation is based on VLAN.
+if (_zoneDao.findVnet(zoneId, physicalNetworkId, 
vlanId).size() > 0) {
--- End diff --

@jburwell : Thanks for your suggestion. I will consider this change. The 
effect would be same if we put all the conditions with && operator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1804: CLOUDSTACK-9639: Unable to create shared netw...

2016-11-30 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1804

CLOUDSTACK-9639: Unable to create shared network with vLan isolation

Description:
=
Create shared network fails with Error.
While creating a shared network it fails to create with Error "The new IP 
range you have specified has overlapped with the guest network in the zone: 
XYZ. Please specify a different gateway/netmask"

Steps to Reproduce:
===
1. Create an isolated network with a subnet eg: 10.1.1.0.24
2. Create a shared network with the same subnet but different VLAN, we 
should observe this issue.

Expected Behaviour:
===
It shouldn't restrict the creation of the guest network with the same 
subnet as long as they are segmented by VLAN.

ACTUAL BEHAVIOR:
===
It doesn't allow the creation of shared guest networks if there is any 
isolated guest network using the same subnet although it allows using the same 
subnet in multiple shared networks.

Cause:
=
The issue is happening because, when Shared network is getting created we 
are checking if there is any guest network already implemented with the same 
CIDR and throwing the error without checking if they are having same VLAN also. 
Creating the same CIDR shared network with different VLAN should be allowed.

Fix:
===
When creating a shared network, if there is any existing guest network with 
the same CIDR, we check if they are having the same VLAN, if they are in same 
VLAN, then we don't allow creating it. If they are in the same CIDR with 
different VLAN then we allowing to create the network.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9639

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1804


commit fc4434846433f8df64998614deb6c1b4b40992da
Author: Nitin Kumar Maharana 
Date:   2016-12-01T07:13:49Z

CLOUDSTACK-9639: Unable to create shared network with vLan isolation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1803: CLOUDSTACK-9636: The host alerts box should be named...

2016-11-30 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1803
  

![image](https://cloud.githubusercontent.com/assets/12583725/20781994/b9ddd9e6-b7ad-11e6-86b6-c80d347cc2ac.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1803: CLOUDSTACK-9636: The host alerts box should b...

2016-11-30 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1803

CLOUDSTACK-9636: The host alerts box should be named as hosts in Alerts.

The host Alerts box shows hosts in Alerts. The name host Alerts is 
misleading, 
it should be changed to hosts in alerts.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin6

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1803.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1803


commit 572b5dcc00a2694e7a27dd48765367b0c652eb1c
Author: Nitin Kumar Maharana 
Date:   2016-11-30T19:49:44Z

CLOUDSTACK-9636: The host alerts box should be named as hosts in Alerts.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1320: CLOUDSTACK-8968: UI icon over VM snapshot to deploy ...

2016-11-30 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1320
  
Hi @rhtyd, I observed there is a change in the way we were maintaining the 
dictionary. The messages*.properties and dictioanry*.jsp file was removed and 
the content was moved to the l10n folder. How the change in l10n files reflect 
in the browser. Do we need to modify any other file to reflect the change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1792: CLOUDSTACK-9623: Deploying virtual machine fa...

2016-11-27 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1792

CLOUDSTACK-9623: Deploying virtual machine fails due to "Couldn't find 
vlanId" in Basic Zone

In Basic zone, while deploying a VM it fails with an unexpected exception.
This is reproducible only when java asserts are enabled.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1792.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1792


commit f01778a1ddc9c2daeaf0f0a3c1eed7194d696ea4
Author: Nitin Kumar Maharana 
Date:   2016-11-28T06:41:41Z

CLOUDSTACK-9623: Deploying virtual machine fails due to "Couldn't find 
vlanId" in Basic Zone




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1778: CLOUDSTACK-9613: Unable to set NAT rules on a...

2016-11-27 Thread nitin-maharana 
Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1778


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1320: CLOUDSTACK-8968: UI icon over VM snapshot to deploy ...

2016-11-26 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1320
  
This change will come with #1664. Hence closing this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1320: CLOUDSTACK-8968: UI icon over VM snapshot to ...

2016-11-26 Thread nitin-maharana 
Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1320


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1778: CLOUDSTACK-9613: Unable to set NAT rules on any inte...

2016-11-26 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1778
  
@ustcweizhou : I made the changes. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1786: CLOUDSTACK-9618: Load Balancer configuration ...

2016-11-25 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1786

CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" 
method in the drop down list.

If we create an isolated network with NetScaler published service offering 
for Load balancing service, then the load balancing configuration UI does not 
show "Source" as one of the supported LB methods in the drop down list. It only 
shows "Round-Robin" and "LeastConnection" methods in the list. However, It 
successfully creates LB rule with "Source" as the LB method using API.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1786.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1786


commit 709343a0abf9ee00ef7c5ad6ebc70ff7cf1df57a
Author: Nitin Kumar Maharana 
Date:   2016-11-25T12:37:17Z

CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" 
method in the drop down list

Added the source method to supported algorithm list in Netscaler element.
Added a validation check.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1778: CLOUDSTACK-9613: Unable to set NAT rules on any inte...

2016-11-24 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1778
  
@ustcweizhou : Yes, we can directly pass networkid instead nicId. They 
handled the same way in case of multiple vm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1778: CLOUDSTACK-9613: Unable to set NAT rules on a...

2016-11-24 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1778

CLOUDSTACK-9613: Unable to set NAT rules on any interfaces except first 
interface of VM.

Description:
=
VMs have multiple network interfaces.
It is not possible to set a NAT rule on any of the interfaces except the 
first interface of the VM from UI. Because the UI only lists the IPs of the 
first interface.

The rules can only be set on the "default" interface but even after setting 
the secondary as the default interface the outcome is still the same. Only the 
first interface is listed in the UI as available for setting NAT rules.

Steps to Reproduce:
===
1. Create two networks.
2. Create a VM.
3. Attach both the networks to the VM.
4. Create NAT rules using both the networks.
5. Observe the add VM section while creating the rule.
6. The same IPs appear for both the case.

Please see the below snaps to observe the issue clearly.

VM NIC1

![image](https://cloud.githubusercontent.com/assets/12583725/20597703/4a1df876-b26b-11e6-9f49-5488f587315f.png)

VM NIC2

![image](https://cloud.githubusercontent.com/assets/12583725/20597724/64447ce8-b26b-11e6-8504-7c1e1723eeea.png)

Creating NAT rule from Network-1

![image](https://cloud.githubusercontent.com/assets/12583725/20597740/7a49b440-b26b-11e6-8127-948f547adb01.png)

Add VMs section

![image](https://cloud.githubusercontent.com/assets/12583725/20597766/94e1164a-b26b-11e6-95f0-cd9cd361ba4d.png)

Creating NAT rule from Network-2

![image](https://cloud.githubusercontent.com/assets/12583725/20597775/a11af656-b26b-11e6-93c5-0b55e434d788.png)

Add VMs section

![image](https://cloud.githubusercontent.com/assets/12583725/20597779/a6684992-b26b-11e6-9671-743870a096e6.png)

Expected:


Add VMs section from Network-1

![image](https://cloud.githubusercontent.com/assets/12583725/20597858/1c31d120-b26c-11e6-9d77-396177c66999.png)


Add VMs section from Network-2

![image](https://cloud.githubusercontent.com/assets/12583725/20597850/0dcc5a1a-b26c-11e6-9b42-67fc6a3e19c1.png)

Resolution:

Instead of always passing the id of the first nic, passing the id of
the nic which is on the same network as the IP address of which
we are enabling port-forwarding/load-balancing.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1778


commit 83f4cb1598a4786dafbee3a975a88918f8f7381f
Author: Nitin Kumar Maharana 
Date:   2016-11-24T11:45:40Z

CLOUDSTACK-9613: Unable to set NAT rules on any interfaces except first 
interface of VM.

Instead of always passing the id of the first nic, passing the id of
the nic which is on the same network as the IP address on which
we are enabling port-fprwarding/load-balancing.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1320: CLOUDSTACK-8968: UI icon over VM snapshot to deploy ...

2016-11-24 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1320
  
@rhtyd : I discussed with @sateesh-chodapuneedi regarding this. I will give 
my changes to him. He will include my commit in his PR. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1320: CLOUDSTACK-8968: UI icon over VM snapshot to deploy ...

2016-11-24 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1320
  
@rhtyd: This is dependent on #1664, Once #1664 gets merged, I will make a 
new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2016-11-23 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1771

CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work.

Description:
=

Trying to dedicate a guest VLAN range to an account fails. Either API 
documentation is wrong or code path needs to be corrected. If we pass both 
account and projectId parameters to the dedicateGuestVlanRange (which are not 
mentioned as mutually exclusive in API description) the API layer throws error 
saying both are mutually exclusive.

Steps to Reproduce:
===
Create an account. Create a project in that account.

Go to Admin account and change the view to the above project.

Navigate to Infrastructure -> Zone -> Physical Network -> Guest -> Dedicate 
Guest VLAN range.

Try to dedicate the guest VLAN range from the project view for the account 
associated with the project.

It fails with error saying "accountName and projectId are mutually 
exclusive".


![image](https://cloud.githubusercontent.com/assets/12583725/20559763/15fe55d8-b19c-11e6-9996-62602d269f10.png)


![image](https://cloud.githubusercontent.com/assets/12583725/20559765/1957af36-b19c-11e6-938f-e9c7c9eee987.png)

Expected:
===
The VLAN range should get dedicated to the project account.


![image](https://cloud.githubusercontent.com/assets/12583725/20559787/33ef67b2-b19c-11e6-90fd-41c9c583efd9.png)


![image](https://cloud.githubusercontent.com/assets/12583725/20559789/376cae22-b19c-11e6-9755-ff1e7237fb21.png)

Resolution:

Changed the account field of API to optional.
Even if the account name is passed while adding from a particular project 
view, then it is ignored in API.

Notes:
=
If we do the dedication from default view then it works fine as no 
projectId is associated over there.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1771.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1771


commit ef85dfd041858aeaee9aecfdc6bddabe1e21739d
Author: Nitin Kumar Maharana 
Date:   2016-11-23T11:07:20Z

CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work

Changed the account field of API to optional.
Even if the account name is passed while adding from a particular project 
view, then it is ignored in API.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

2016-11-14 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1758
  
The Add Load Balancer tab was removed.


![image](https://cloud.githubusercontent.com/assets/12583725/20293745/f1a66b9a-ab1e-11e6-9707-40af38637447.png)

The same functionality is done by Load Balancing tab.

https://cloud.githubusercontent.com/assets/12583725/20293902/26cd3f1e-ab20-11e6-9b59-05ac6ec8194b.png";>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1758: CLOUDSTACK-9588: Add Load Balancer functional...

2016-11-10 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1758

CLOUDSTACK-9588: Add Load Balancer functionality in Network page is 
Redundant.

Steps to Reproduce:
Network -> Select any network -> Observer Add Load Balancer tab
The "Add Load Balancer" functionality is redundant.
The above is used to create LB rule without any public IP.


Resolution:
There exist similar functionality in Network -> Any Network -> Details Tab 
-> View IP Addresses -> Any public IP -> Configuration Tab -> Observe Load 
Balancing.
The above is used to create LB rule with a public IP. This is a more 
convenient way of creating LB rule as the IP is involved.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin-4.9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1758.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1758


commit 49844e626bdf5788508186b7f037c46442e3a5b4
Author: Nitin Kumar Maharana 
Date:   2016-11-10T09:57:52Z

CLOUDSTACK-9588: Add Load Balancer functionality in Network page is 
redundant.
The "Add Load Balancer" functionality is redundant.
The above is used to create LB rule without any public IP.
This commit removes the tab from network page.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #786: CLOUDSTACK-8821: UI Change

2016-07-28 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/786
  
Hi @GabrielAnca,

Generally we show some information in notification field(Top-Right side 
corner), which disappears after one or two seconds. But that is used in case of 
any event occurs. I don't think other than that any field exists UI which will 
disappear without user interaction. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #775: CLOUDSTACK-8805: Domains become inactive automaticall...

2016-06-04 Thread nitin-maharana 
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/775
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 131
 Hypervisor xenserver
 NetworkType Advanced
 Passed=73
 Failed=0
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-04-25 Thread nitin-maharana 
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1333#issuecomment-214306315
  
@koushik-das : I will check it. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

2016-04-21 Thread nitin-maharana 
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1321#issuecomment-212898459
  
@koushik-das : I also think the same. Yes, that would be better. I will 
raise another PR with removing the existing implementation. pinging @agneya2001 
@remibergsma @DaanHoogland @bhaisaab 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2016-04-21 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1255#discussion_r60544689
  
--- Diff: ui/scripts/network.js ---
@@ -6517,7 +6445,192 @@
 }
 }
 }
-}
+},
+vpnuser: {
+type: 'select',
+title: 'VPN Users',
+
+listView: {
+id: 'vpnUsers',
+fields: {
+username: { label: 'label.name' },
+domain: { label: 'label.domain' },
+state: { label: 'label.state',
+indicator: {
+'Active': 'on',
+}
+}
+},
+dataProvider: function(args) {
+var data = {};
+listViewDataProvider(args, data);
+$.ajax({
+url: createURL('listVpnUsers'),
+data: data,
+dataType: 'json',
+async: true,
+success: function(data) {
+args.response.success({
+data: 
data.listvpnusersresponse.vpnuser
+});
+}
+});
+},
+actions:{
+destroy: {
+label: 'label.action.delete.user',
+messages: {
+confirm: function(args) { return 'Are 
you sure you want to delete the VPN user'},
--- End diff --

Here also you can replace this line ('Are you sure you want to delete the 
VPN user') with a localization key.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2016-04-21 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1255#discussion_r60544256
  
--- Diff: ui/scripts/network.js ---
@@ -4508,99 +4524,11 @@
 
$('').addClass('psk').html(_l('message.enabled.vpn.ip.sec') + ' ')
 
.append($('').html(psk))
 )
-).multiEdit({
-context: args.context,
-noSelect: true,
-fields: {
-'username': {
-edit: true,
-label: 'label.username'
-},
-'password': {
-edit: true,
-isPassword: true,
-label: 'label.password'
-},
-'add-user': {
-addButton: true,
-label: 'label.add.user'
-}
-},
-add: {
-label: 'label.add.user',
-action: function(args) {
-$.ajax({
-url: 
createURL('addVpnUser'),
-data: 
$.extend(args.data, {
-domainid: 
args.context.ipAddresses[0].domainid,
-account: 
args.context.ipAddresses[0].account
-}),
-dataType: 'json',
-type: "POST",
-success: 
function(data) {
-
args.response.success({
-_custom: {
-jobId: 
data.addvpnuserresponse.jobid
-},
-notification: {
-label: 
'label.add.vpn.user',
-poll: 
pollAsyncJobResult
-}
-});
-},
-error: function(data) {
-
args.response.error(parseXMLHttpResponse(data));
-}
-});
-}
-},
-actions: {
-destroy: {
-label: 
'label.action.delete.user',
-action: function(args) {
-$.ajax({
-url: 
createURL('removeVpnUser'),
-data: {
-domainid: 
args.context.multiRule[0].domainid,
-account: 
args.context.multiRule[0].account,
-username: 
args.context.multiRule[0].username
-},
-dataType: 'json',
-

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2016-04-21 Thread nitin-maharana 
Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1255#discussion_r60544347
  
--- Diff: ui/scripts/network.js ---
@@ -6517,7 +6445,192 @@
 }
 }
 }
-}
+},
+vpnuser: {
+type: 'select',
+title: 'VPN Users',
--- End diff --

Here also you can replace this with localization key.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-04-21 Thread nitin-maharana 
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1333#issuecomment-212799750
  
@koushik-das: Actually this dialog appears after the first CIDR unchanged 
confirmation dialog. If its an admin account, Even if we select yes/no, it will 
be redirected to second dialog asking for forced update. According to the 
input, it will execute the updateNetwork API with/without forced=true option.

For user account, It won't be redirected to the second dialog asking for 
forced update, it will directly execute updateNetwork API.

Can you please share some snapshots of what error you are getting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

2016-02-24 Thread nitin-maharana 
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1390#issuecomment-188609151
  
@rafaelweingartner : I have tested all changes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] New committer: Rafael Weingartner

2016-02-23 Thread Nitin Maharana 
Congrats Rafael.

On Tue, Feb 23, 2016 at 10:13 PM, Ahmad  wrote:

> Congrats Rafael!
>
> > On Feb 23, 2016, at 12:19 AM, Daan Hoogland 
> wrote:
> >
> > The Project Management Committee (PMC) for Apache CloudStack
> > has asked Rafael Weingartner to become a committer and we are pleased to
> > announce that they have accepted.
> >
> > Rafael is part a hacking group in the south of Brasil and has been active
> > as contributor of code and as reviewer. He had been accepted a few months
> > ago but I totally forgot to make this announcement. My apologies to both
> > him and the community for the tardiness of this announcement.
> >
> > Being a committer allows many contributors to contribute more
> > autonomously. For developers, it makes it easier to submit changes and
> > eliminates the need to have contributions reviewed via the patch
> > submission process. Whether contributions are development-related or
> > otherwise, it is a recognition of a contributor's participation in the
> > project and commitment to the project and the Apache Way.
> >
> > Please join me in congratulating Rafael
> >
> > --Daan Hoogland
> > on behalf of the CloudStack PMC
>

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

2016-02-14 Thread nitin-maharana 
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1390#issuecomment-184053093
  
@rafaelweingartner : Its already present in our code. It translates the 
dictionary keys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9272: No option in UI to add G...

2016-02-02 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1399

CLOUDSTACK-9272: No option in UI to add GSLB with service type "HTTP"

Steps to Repro:

Go to Regions -> Local -> View GSLB -> Add GSLB
Click on the service type dropdown
Observe http is missing. Please see the attached snapshot.

Expected Behaviour:

As it supports http also, So http should be in the list.

Actual Behaviour:
==
http is missing from the list.

Fix:
===
It supports http also. Added http to the list.

Snapshot:

https://cloud.githubusercontent.com/assets/12583725/12772818/21513dc0-ca5b-11e5-822e-e2dd2426da65.png";>


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin21_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1399


commit 990e42f61b5408d1da2937bff5e67220633f3c16
Author: Nitin Kumar Maharana 
Date:   2016-02-03T04:22:13Z

CLOUDSTACK-9272: No option in UI to add GSLB with service type "HTTP"

It supports http also. Added http to the list.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9270: UI alignment gone bad in...

2016-02-02 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1398

CLOUDSTACK-9270: UI alignment gone bad in multiple places - VM Instance, 
Network, Egress rules

Steps to Repro:

Please see the snapshots attached. 

Fix:
===
Now it breaks into two lines once the word goes out of the box.
Fixed the advanced search field issue.

Network Section:
=

![network-section-nitin](https://cloud.githubusercontent.com/assets/12583725/12762032/66f27d32-ca13-11e5-8d0a-9c8f99a12a99.png)

Adding VM to LB Rule:
==

![adding-vm-to-lb-rule-nitin](https://cloud.githubusercontent.com/assets/12583725/12762050/76083cd0-ca13-11e5-873d-0037bc13a444.png)

Affinity Group Section:
==

![affinity-group-section-nitin](https://cloud.githubusercontent.com/assets/12583725/12762066/881c2a1c-ca13-11e5-8905-f72676151130.png)

Fixed Affinity Group Section:
==

![fix-affinity-group-section-nitin](https://cloud.githubusercontent.com/assets/12583725/12762083/990a673a-ca13-11e5-9d63-f895f9a1875c.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin23_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1398.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1398


commit 7c7bee8bbaab58aab6d0f9eaf3b8c60cf45866a1
Author: Nitin Kumar Maharana 
Date:   2016-02-02T19:39:36Z

CLOUDSTACK-9270: UI alignment gone bad in multiple places - VM Instance, 
Network, Egress rules

Now it breaks into two lines once the word goes out of the box.
Fixed the advanced search field issue.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9269: Missing field for Switch...

2016-02-02 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1396

CLOUDSTACK-9269: Missing field for Switch type for Management and Storage 
traffic types

Repro Steps:
===
Create an Advanced zone(VMware).
Configure physical network.
Edit traffic type (Management or Storage)
Observe the switch type dropdown list is missing.

If we choose Guest or Public the dropdown is visible. See the below 
snapshots.

Expected Result:
==
The list should be shown in case of Management and storage.

Actual Result:
===
The list is missing in case of management and storage.

Fix:
===
Showing vswitchtype for all traffic types in case of VMware.

Traffic Type - Guest:
=

![public-nitin](https://cloud.githubusercontent.com/assets/12583725/12759158/aec4d38e-ca05-11e5-911f-d8aa8cb995b7.jpg)

Traffic Type - Management (Issue):
=

![management-nitin](https://cloud.githubusercontent.com/assets/12583725/12759171/bff00e08-ca05-11e5-8051-c24f0952a321.jpg)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin26_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1396


commit 85f93b6f96dde24dfc47d1bbf77e0c44e02455ff
Author: Nitin Kumar Maharana 
Date:   2016-02-02T17:53:42Z

CLOUDSTACK-9269: Missing field for Switch type for Management and Storage 
traffic types

Showing vswitchtype for all traffic types in case of VMware.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-02-02 Thread nitin-maharana 
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1394#issuecomment-178716448
  
Before Fix:
=
![before fix - 
nitin](https://cloud.githubusercontent.com/assets/12583725/12758734/c3c0a486-ca03-11e5-9a87-23556d249aaa.jpg)

After Fix:
===
![after fix - 
nitin](https://cloud.githubusercontent.com/assets/12583725/12758745/cf8ef5ec-ca03-11e5-9324-426e3aade6dd.jpg)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9268: Display VM in Load balan...

2016-02-02 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1394

CLOUDSTACK-9268: Display VM in Load balancing rule in UI

Steps of Repro:
=
1:Create VMs 
2:Make LoadBalancing rule in GUI 
　Name:WWW 
　PrivatePort:80 
　PublicPort:80 
　Add VMs:some VMs

Expected Result:
==
The VMs which has been already assigned is should not be listed when you 
add the VM to an existing rule.

Actual Result:
===
The VMs which has been already assigned is still being listed when you add 
the VM to an existing rule.

Fix:
===
Added jsonObj to newly created row in multiedit.js to stop listing the same 
VM again.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin25_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1394


commit a68918fef7746823f79e096a70d136d2b4f31921
Author: Nitin Kumar Maharana 
Date:   2016-02-02T17:24:53Z

CLOUDSTACK-9268: Display VM in Load balancing rule in UI

Added jsonObj to newly created row in multiedit.js to stop listing the same 
VM again.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

2016-02-02 Thread nitin-maharana 
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1390#issuecomment-178526046
  
There is one more localised issue in the project page, So instead of 
creating a new one adding it to this PR only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

2016-02-02 Thread nitin-maharana 
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1390#issuecomment-178522940
  
I thought of making a small explanation. But I follow this template while 
making a PR so that it would be easy for committer to review very fast. Anyway 
Thanks @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9267: String is not localized ...

2016-02-02 Thread nitin-maharana 
GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/1390

CLOUDSTACK-9267: String is not localized on create instance wizards.

Repro Steps: 
==
1. Setup basic environments as normal.
2. Open a browser, go to Web Console.
3. Upload a iso template.
4. Go to "Instances" page and add new instance.
5. Check the strings on create instance wizards.

Expected Result:
=
All the strings should be localized on create instance wizards.

Actual Result:
===
Some strings are not localized on create instance wizards.

Language:

JA -> Fail
SC -> Fail

Fix:
===
Fixed the hard coded string.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin 
CloudStack-Nitin24_4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1390


commit ff10bdc2bf6fb2620feb68f5f232b04bc89cd707
Author: Nitin Kumar Maharana 
Date:   2016-02-02T10:58:49Z

CLOUDSTACK-9267: String is not localized on create instance wizards.

Fixed the hard coded string.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

  1   2   3   >