[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
>I'm happy that you agree with my comments, as far as resizing root disk 
for runnign VM, I think checking both full.clone and root.disk.controller 
global settings puts us in a good position to make the option available or not. 
By any chance if the user has made a change and changed the RootDiskController, 
he would be notified with exception and that would ring a bell to him. I think 
Cloudstack brings an abstraction when using hypervisors and it's generally good 
for the product when users use more CloudStack features instead of relying on 
the Hypervisor to get work done.

@serg38, @pdube  and @sateesh-chodapuneedi. Should i write additional API 
for extracting all these details in case of running VM or is there any 
alternative to achieve this functionality ?  What is your opinion ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
Hi @borisstoyanov,
>Here are some recommendations that would make user experience better. What 
I'm suggesting is to implement 2 standalone checks.
Check if vmware.create.full.clone is true.
Check if vmware.root.disk.controller is true.

>These checks should be performed 
>When adding instance
This could be done, soon UI will be updated.


>when resizing a running instance
I think for this we should rely on Hypervisor. Because currently, we do not 
have API  for extracting certain details (like root disk controller of running 
VM's Disk).

What is your opinion ? 





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Hi @rhtyd,
>From my experience RM-ing for 4.3, 4.5, 4.9 -- the git history is pretty 
messed-up and it becomes far too difficult to track changes.

I think everything has its own + and -. Multiple commits  provide more 
insight and clarity on history. Could you please provide some more advantages 
of squashing with proper proof. 

>From my experience

This statement seems very loose. I think it needs some improvement. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@borisstoyanov and @syed Please take a look. Test case is added. If now 
everything looks ok then please provide your LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@serg38 and @borisstoyanov Thanks for giving your precious time.

@sadhugit is looking for test cases related suggestions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@borisstoyanov 
> If the global settings are not available and user goes and add a custom 
value in that field, he'll get a non-meaningful message.


What about primary storage pool level setting ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@sadhugit 
>if you run the test on vmware ,you need to use iscsi  protocol.

***scsi** (modified)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r105532534
  
--- Diff: test/integration/component/test_rootvolume_resize.py ---
@@ -0,0 +1,1140 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" P1 tests for testing resize of  root volume functionality
+
+Test Plan: https://cwiki.apache.org/confluence/display/CLOUDSTACK/
+Root+Resize+Support
+
+Issue Link: https://issues.apache.org/jira/browse/CLOUDSTACK-9829
+"""
+# Import Local Modules
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ Resources,
+ Domain,
+ Volume,
+ Snapshot,
+ Template,
+ VmSnapshot,
+ Host,
+ Configurations,
+ StoragePool)
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   matchResourceCount,
+   list_snapshots,
+   list_hosts,
+   list_configurations,
+   list_storage_pools)
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.codes import (PASS,
+  FAIL,
+  FAILED,
+  RESOURCE_PRIMARY_STORAGE,
+  INVALID_INPUT)
+from marvin.lib.utils import checkVolumeSize
+import time
+from marvin.sshClient import SshClient
+
+
+class TestResizeVolume(cloudstackTestCase):
+@classmethod
+def setUpClass(cls):
+cls.testClient = super(TestResizeVolume, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.hypervisor = (cls.testClient.getHypervisorInfo()).lower()
+cls.storageID = None
+# Fill services from the external config file
+cls.services = cls.testClient.getParsedTestDataConfig()
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(
+cls.api_client,
+cls.testClient.getZoneForTests())
+cls.services["mode"] = cls.zone.networktype
+cls._cleanup = []
+cls.unsupportedStorageType = False
+cls.unsupportedHypervisorType = False
+cls.updateclone = False
+if cls.hypervisor not in ['xenserver',"kvm","vmware"]:
+cls.unsupportedHypervisorType=True
+return
+cls.template = get_template(
+cls.api_client,
+cls.zone.id
+)
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["virtual_machine"]["template"] = cls.template.id
+cls.services["volume"]["zoneid"] = cls.zone.id
+try:
+cls.parent_domain = Domain.create(cls.api_client,
+  services=cls.services[
+  "domain"],
+  parentdomainid=cls.domain.id)
+cls.parentd_admin = Account.create(cls.api_client,
+   cls.services["account"],
+   admin=True,
+   

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@borisstoyanov apology for typo. It should be 'scsi'.

>I think it'll be best if those are set before executing the test and 
revert back in cleanup.

Yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@borisstoyanov ,
Please change your root disk controller to ISCSI. It could be specified in 
global configuration. For IDE it is not supported.

@sadhugit do you want to add something ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
Hi,
Thanks to @sadhugit. @serg38 and @borisstoyanov tests are updated. If 
anything is still not proper please notify otherwise please provide your LGTM 
comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
Hi @serg38 and @ramkatru sir, Now, if anything is not proper then notify 
otherwise please provide your LGTM comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1779
  
tag:mergeready

PS: Hujur code ka tohfa kabool kijiye.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1779
  
@abhinandanprateek ji,  If now everything LGTY then please provide your 
LGTM kind of blessing.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1779#discussion_r104616622
  
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2488,6 +2488,22 @@ public boolean maintenanceFailed(final long hostId) {
 }
 
 @Override
+public List listAllHosts(Type type, Long clusterId, Long 
podId, long dcId) {
--- End diff --

Modified. Thank you for your careful observation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
Hi, @serg38 and @borisstoyanov soon test_00_deploy_vm_root_resize will be 
updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1779
  
Hi @DaanHoogland code is modified. Now we are not hiding. It will be shown 
in Disconnected state. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy t...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1894#discussion_r104114043
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/user/template/CopyTemplateCmd.java ---
@@ -51,25 +52,46 @@
 @Parameter(name = ApiConstants.DESTINATION_ZONE_ID,
type = CommandType.UUID,
entityType = ZoneResponse.class,
-   required = true,
+   required = false,
description = "ID of the zone the template is being copied 
to.")
-private Long destZoneId;
+protected Long destZoneId;
 
-@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType 
= TemplateResponse.class, required = true, description = "Template ID.")
+@Parameter(name = ApiConstants.ID, type = CommandType.UUID,
+entityType = TemplateResponse.class, required = true, 
description = "Template ID.")
 private Long id;
 
 @Parameter(name = ApiConstants.SOURCE_ZONE_ID,
type = CommandType.UUID,
entityType = ZoneResponse.class,
-description = "ID of the zone the template is currently hosted 
on. If not specified and template is cross-zone, then we will sync this 
template to region wide image store.")
+description = "ID of the zone the template is currently hosted 
on. " +
+"If not specified and template is cross-zone, " +
+"then we will sync this template to region wide image 
store.")
--- End diff --

This change is not required. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy template...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1894
  
@rashmidixit can you run internal CI and post @cloudmonger test results?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy t...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1894#discussion_r104106536
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/template/RegisterTemplateCmdByAdmin.java
 ---
@@ -40,10 +40,23 @@
 @Override
 public void execute() throws ResourceAllocationException{
 try {
+if ((zoneId != null) && (zoneIds != null && 
!zoneIds.isEmpty()))
--- End diff --

Unnecessary brackets should be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy t...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1894#discussion_r104105564
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/template/CopyTemplateCmdByAdmin.java
 ---
@@ -40,11 +40,20 @@
 @Override
 public void execute() throws ResourceAllocationException{
 try {
+if (destZoneId == null && (destZoneIds == null || 
destZoneIds.size() == 0))
+throw new ServerApiException(ApiErrorCode.PARAM_ERROR,
+"Either destzoneid or destzoneids parameters have 
to be specified.");
+
--- End diff --

Error statement and conditional statement logic are not conveying same 
message. Some correction is required.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy t...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1894#discussion_r104105003
  
--- Diff: api/src/org/apache/cloudstack/api/ResponseGenerator.java ---
@@ -307,7 +307,11 @@
 
 TemplateResponse createTemplateUpdateResponse(ResponseView view, 
VirtualMachineTemplate result);
 
-List createTemplateResponses(ResponseView view, 
VirtualMachineTemplate result, Long zoneId, boolean readyOnly);
+List createTemplateResponses(ResponseView view, 
VirtualMachineTemplate result,
+   Long zoneId, boolean 
readyOnly);
--- End diff --

what is difference between line 310 and 311 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@karuturi This seems to be ready for merge (tag:mergeready).
It has 3 LGTMs and tests are passed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
Hi @mike-tutkowski sir,
You have done enough work in storage area. Please review this PR. Your one 
LGTM comment is enough to lift this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r103931610
  
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3614,6 +3604,26 @@ public UserVmVO doInTransaction(TransactionStatus 
status) throws InsufficientCap
 });
 }
 
+public void validateRootDiskResize(final HypervisorType 
hypervisorType, Long rootDiskSize, VMTemplateVO templateVO, UserVmVO vm, final 
Map<String, String> customParameters) throws InvalidParameterValueException
+{
+// rootdisksize must be larger than template.
+if ((rootDiskSize << 30) < templateVO.getSize()) {
+Long templateVOSizeGB = templateVO.getSize() / 1024 / 1024 / 
1024;
+s_logger.error("unsupported: rootdisksize override is smaller 
than template size " + templateVO.getSize() + "B (" + templateVOSizeGB + "GB)");
+throw new InvalidParameterValueException("unsupported: 
rootdisksize override is smaller than template size " + templateVO.getSize() + 
"B (" + templateVOSizeGB + "GB)");
+} else if ((rootDiskSize << 30) > templateVO.getSize()){
+if (hypervisorType == HypervisorType.VMware && 
!vm.getDetails().get("rootDiskController").toLowerCase().contains("scsi")) {
+s_logger.error("Found unsupported root disk controller : " 
+ vm.getDetails().get("rootDiskController"));
--- End diff --

 @borisstoyanov @serg38 Thanks for giving your valuable time. Code is 
modified. Now if everything looks ok to you then please provide your LGTM 
comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103892827
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) 
{
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec != null)
+{
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag == true && vmSpec.getType() == 
VirtualMachine.Type.User) {
+String[] tokens = vmInternalCSName.split("-");
+if(tokens.length<3) throw new 
InvalidParameterValueException("Invalid vmInternalCSName format: 
"+vmInternalCSName+" expected format : *-*-* (e.g -> i-x-y)"); // 
vmInternalCSName has format i-x-y-
+vmNameOnVcenter = String.format("%s-%s-%s-%s", tokens[0], 
tokens[1], tokens[2], vmSpec.getHostName());
+}
+
 }
 return new Pair<String, String>(vmInternalCSName, vmNameOnVcenter);
 }
 
-protected void configNestedHVSupport(VirtualMachineMO vmMo, 
VirtualMachineTO vmSpec, VirtualMachineConfigSpec vmConfigSpec) throws 
Exception {
+protected static void configNestedHVSupport(VirtualMachineMO vmMo, 
VirtualMachineTO vmSpec, VirtualMachineConfigSpec vmConfigSpec) throws 
Exception {
--- End diff --

Removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1302
  
@rhtyd I think now all of your questions are answered. Please provide your 
LGTM comment. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103880795
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) 
{
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec != null)
+{
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag == true && vmSpec.getType() == 
VirtualMachine.Type.User) {
+String[] tokens = vmInternalCSName.split("-");
+if(tokens.length<3) throw new 
InvalidParameterValueException("Invalid vmInternalCSName format: 
"+vmInternalCSName+" expected format : *-*-* (e.g -> i-x-y)"); // 
vmInternalCSName has format i-x-y-
+vmNameOnVcenter = String.format("%s-%s-%s-%s", tokens[0], 
tokens[1], tokens[2], vmSpec.getHostName());
--- End diff --

>As per previous code, vmNameOnVcenter = vmSpec.getHostName(), which will 
introduce backward compatibility issues for older 4.3 environments. Is there 
any code that handles for such old VMs.

Yes, vm.instancename.flag will handle backward compatibility issue. 

Case (vm.instancename.flag = True):
User can create the VM with same name form different account. 
Case (vm.instancename.flag = False):
User can not create the VM with same name form different account.
Note - But in both the cases, VM with same name are not allowed on a 
particular network. And only for the User VM's name format will be like 
"I--" if "vm.instancename.flag = True". It will not 
cause any impact on other VM names( like Router VM).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
@borisstoyanov Could you please provide management server log for analyzing 
this failure ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1877: CLOUDSTACK-9716: Change of network to rvr for...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1877#discussion_r103611552
  
--- Diff: systemvm/patches/debian/config/etc/rc.local ---
@@ -42,11 +42,12 @@ then
echo 100 > /proc/sys/net/nf_conntrack_max
 fi
 
-if [ "$router" != "" ]
-then
-python /opt/cloud/bin/baremetal-vr.py &
+
+if [ "$router" != "" ]; then
+  python /opt/cloud/bin/baremetal-vr.py &
--- End diff --

@rashmidixit what is the purpose of introducing this change ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @koushik-das, @borisroman,  @serg38,  @jburwell and @ustcweizhou
Things are modified and added according to your suggestions. I think, Now 
LGTM comment should be provided.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103427642
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) 
{
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec != null)
+{
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag == true && vmSpec.getType() == 
VirtualMachine.Type.User) {
--- End diff --

@rhtyd Good point. Code will be modified. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103427150
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) 
{
+
--- End diff --

>Why is the method attribute changed from private to protected?

Otherwise Unit testing will be difficult. 

>If vmspec is null, this method should throw an exception, to avoid a 
situation where empty vmnames are returned.

In CS vmspec can not be null. But still code will be  modified according 
your suggestion.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103423690
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) 
{
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec != null)
+{
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag == true && vmSpec.getType() == 
VirtualMachine.Type.User) {
+String[] tokens = vmInternalCSName.split("-");
+if(tokens.length<3) throw new 
InvalidParameterValueException("Invalid vmInternalCSName format: 
"+vmInternalCSName+" expected format : *-*-* (e.g -> i-x-y)"); // 
vmInternalCSName has format i-x-y-
+vmNameOnVcenter = String.format("%s-%s-%s-%s", tokens[0], 
tokens[1], tokens[2], vmSpec.getHostName());
--- End diff --

@sateesh-chodapuneedi what is your opinion ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1779
  
>can you run internal CI and post @cloudmonger test results?

@karuturi running.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
Hi @ramkatru,
These failures/errors  are not related to this code change(  like  in 
'test_03_delete_template' template deletion is failing but we are not 
disturbing delete template API code path). 

If everything LGT you then please provide your LGTM comment.   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
@borisstoyanov please trigger smoke test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1779
  
@rhtyd and @syed. If everything looks good. Please provide your precious 
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@borisstoyanov as far as i can see test failures are not happening because 
of this change. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r103154553
  
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus 
status) throws InsufficientCap
 }
 rootDiskSize = 
Long.parseLong(customParameters.get("rootdisksize"));
 
-// only KVM supports rootdisksize override
-if (hypervisorType != HypervisorType.KVM) {
-throw new 
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not 
support rootdisksize override");
+// only KVM, XenServer and VMware  supports 
rootdisksize override
+if (!(hypervisorType == HypervisorType.KVM || 
hypervisorType == HypervisorType.XenServer || hypervisorType == 
HypervisorType.VMware)) {
+throw new 
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not 
support  rootdisksize override");
--- End diff --

@sureshanaparti both are serving different purpose. Yes, It is intentional. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
HI @borisroman, I have checked few of them but this change is not reason 
for ERROR/FAILURE.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@borisroman and @serg38 Sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1774: CLOUDSTACK-9608: Errored State and Abandoned ...

[priyankparihar]

GitHub user priyankparihar reopened a pull request:

https://github.com/apache/cloudstack/pull/1774

CLOUDSTACK-9608: Errored State and Abandoned state Templates are not …

Errored and Abandoned Templates should also be displayed on UI so that user 
has the accessibility to delete the template even before the clean up thread is 
run. Refer - 
[CLOUDSTACK-9608](https://issues.apache.org/jira/browse/CLOUDSTACK-9608)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9608

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1774


commit ca4088ded68a5b1e09960396683cf746cfe993ee
Author: Priyank Parihar <priyank.pari...@accelerite.com>
Date:   2016-05-05T09:54:40Z

CLOUDSTACK-9608: Errored State and Abandoned state Templates are not 
displayed on UI.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
Hi @borisstoyanov Please check. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1302
  
Hi @borisstoyanov Please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1774: CLOUDSTACK-9608: Errored State and Abandoned ...

[priyankparihar]

Github user priyankparihar closed the pull request at:

https://github.com/apache/cloudstack/pull/1774


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
Hi @borisstoyanov Please check. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@serg38  
 
>A part is still missing that will use forced option in UI but give a user 
option to cancel deletion if active VMs exist.

I think it will be good to take all additional changes in separate PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @serg38 @ustcweizhou @koushik-das @jburwell @borisstoyanov ,
Thanks for valuable insight. Code is modified according to your suggestion. 
:)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @koushik-das  @rajesh-battala ,

>The default value of forced is false, might cause issue on backwards 
compatibility.

Should i make changes according to @serg38 and @ustcweizhou suggestion ? ( 
or current code LGT you, Please notify. )   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1779
  
Hi Bhai Sahab @rhtyd,
Integration test 'test_04_disable_host_unmanage_cluster_check_hosts_status' 
is validating this behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @ustcweizhou,
By default enabling force option(force=true) will be very risky, same is 
mentioned by @borisstoyanov.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @ustcweizhou @serg38 and @borisroman,
Thanks for your valuable suggestions. 

> @ustcweizhou  the default value of forced is false, might cause issue on 
backwards compatibility.

If the force option is enabled by default API call will go and delete the 
all selected templates without any warning so default value of forced is kept 
'false'.

> @ustcweizhou In the vm installation, as the template is still in use , so 
we can find it in the storage pool where the root disk is located. We need to 
improve it by using the existing template image on storage pool, or copying the 
template from storage pool where the root disk is located to another new 
storage pool (pool of allocated new root disk).

I think it will be good to take it in separate PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @jburwell , 
Would like to add something on @ustcweizhou comment ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @jburwell ,
Thanks for teaching me something new. Test is also added. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
Hi @borisstoyanov and @serg38 ,
Test code is modified. Please take a look. I think now it will not fail. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
Hi @borisstoyanov and @serg38 ,
Test case is fixed. Please check. If anything is improper please notify. 

--
Thanks :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
Hi @pdion891, @borisstoyanov, @anshul1886 and @pdube,
Thanks for your valuable suggestion and help. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
Hi @ustcweizhou,
>We had an issue in deleting template in UploadAbandoned

Could you please update what issue are you facing and how can i reproduce 
it ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1813

CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.

For complete description please refer -> 
[CLOUDSTACK-9604](https://issues.apache.org/jira/browse/CLOUDSTACK-9604)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9604

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1813.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1813


commit 53382f5171aeb5c671007a89f7264438e3dca3e6
Author: Anshul And Priyank <priyank.pari...@accelerite.com>
Date:   2016-12-02T16:16:49Z

CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1779
  
Hi @syed,
I hope modified description, answers your question. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
Hi @ustcweizhou,
>If the templates are displayed on UI, is there any action we can do on 
them? eg, delete template.

I hope modified description, answers your question.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
Hi @rajesh-battala, 
Changes are included. Thanks for your careful syntax observation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1775: CLOUDSTACK-9606: While IP address is released, tag a...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1775
  
Hi @syed,
>can you please provide a description and steps to reproduce

Please check 
[CLOUDSTACK-9606](https://issues.apache.org/jira/browse/CLOUDSTACK-9606). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1776: 'concurrent.snapshots.threshold.perhost' parameter s...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1776
  
Thanks @rajesh-battala and @jburwell  
>You can modify the description and which can reflect the fix or the check 
you are doing in the code.
Modified.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1777: clearCLOUDSTACK-9133: Two volume.delete usage...

[priyankparihar]

Github user priyankparihar closed the pull request at:

https://github.com/apache/cloudstack/pull/1777


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1779

CLOUDSTACK-9610: Disabled Host Keeps Being up status after unmanaging …

Disabled Host Keeps Being up status after unmanaging cluster.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9610

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1779.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1779


commit 2b9e46a293950db7c13bc49c952a0c856bd99c90
Author: Priyank Parihar <priyank.pari...@accelerite.com>
Date:   2016-05-05T10:00:09Z

CLOUDSTACK-9610: Disabled Host Keeps Being up status after unmanging 
cluster.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1777: clearCLOUDSTACK-9133: Two volume.delete usage...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1777

clearCLOUDSTACK-9133: Two volume.delete usage events are getting 
generated…

… for destoy vm.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9133

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1777


commit a3d56c6e5564c3f7a35b8796ff27ca28aff5406d
Author: Priyank Parihar <priyank.pari...@citrix.com>
Date:   2015-12-14T06:44:42Z

CLOUDSTACK-9133: Two volume.delete usage events are getting generated for 
destoy vm.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1776: CLOUDSTACK-9603: concurrent.snapshots.thresho...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1776

CLOUDSTACK-9603: concurrent.snapshots.threshold.perhost does not vali…

concurrent.snapshots.threshold.perhost does not validate value given

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9603

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1776.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1776


commit 141926b1439c2fe99621c9c56114e948066f17c3
Author: Priyank Parihar <priyank.pari...@accelerite.com>
Date:   2016-09-06T17:41:06Z

CLOUDSTACK-9603: concurrent.snapshots.threshold.perhost does not validate 
value given.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1775: CLOUDSTACK-9606: While IP address is released...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1775

CLOUDSTACK-9606: While IP address is released, tag are not deleted.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9606

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1775


commit 428f9c6acf8eeddca8fc137e7187bef2d773f7f8
Author: Priyank Parihar <priyank.pari...@accelerite.com>
Date:   2016-11-24T11:40:08Z

CLOUDSTACK-9606: While IP address is released, tag are not deleted.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1774: CLOUDSTACK-9608: Errored State and Abandoned ...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1774

CLOUDSTACK-9608: Errored State and Abandoned state Templates are not …

Errored State and Abandoned state Templates are not displayed on UI.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9608

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1774


commit ca4088ded68a5b1e09960396683cf746cfe993ee
Author: Priyank Parihar <priyank.pari...@accelerite.com>
Date:   2016-05-05T09:54:40Z

CLOUDSTACK-9608: Errored State and Abandoned state Templates are not 
displayed on UI.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1773: CLOUDSTACK-9607: Preventing template deletion...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1773

CLOUDSTACK-9607: Preventing template deletion when template is in use.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9607

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1773.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1773


commit cd367dc46a2edc9732b08b0117320252394fd33d
Author: Priyank Parihar <priyank.pari...@accelerite.com>
Date:   2016-09-27T04:03:58Z

CLOUDSTACK-9607: Preventing template deletion when template is in use.
Reviewed-by: Koushik Das




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1302
  
Hi @rhtyd and @sateesh-chodapuneedi,
I have made modification, according to your suggestion. Please take a look. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

[priyankparihar]

Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
>it is best to prevent them with appropriate checks rather than some 
failure in the HV.
@koushik-das  We can define ordering between the existing HV versions. But 
it is not a good thing to do, because we have no idea about naming convention 
of future versions( of hypervisors). so whenever Hypervisor naming convention 
changes. It again requires a code change. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

[priyankparihar]

Github user priyankparihar commented on the pull request:

https://github.com/apache/cloudstack/pull/815#issuecomment-219637824
  
@rhtyd  
>please rebase against latest master and push -f.
Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

[priyankparihar]

Github user priyankparihar commented on the pull request:

https://github.com/apache/cloudstack/pull/815#issuecomment-214146326
  
@koushik-das 
Currently UI does not allow migration between different versions, and 
changing UI for this change is not elegant. Purpose of doing this change is if 
some user **intentionally** want to do migration from lower to higher then he 
can do it via API(from UI he can not do this). Other way around Hypervisor will 
not allow him.

@agneya2001 @sateesh-chodapuneedi @koushik-das 
Your point looks good, but  How ordering could be defined ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

[priyankparihar]

Github user priyankparihar commented on the pull request:

https://github.com/apache/cloudstack/pull/815#issuecomment-212846127
  
@sateesh-chodapuneedi @koushik-das  I will get back to you soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r60372700
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2030,12 +2030,29 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+
+/**
+ * This method gemerate VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
--- End diff --

Hi  @alexandrelimassantana,
Now, i think there is no typo.

--
Thanks for your careful observation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

[priyankparihar]

Github user priyankparihar commented on the pull request:

https://github.com/apache/cloudstack/pull/1302#issuecomment-179028659
  
Hi, 
@alexandrelimassantana thanks for notifying. I have made modification,  
according to your suggestion. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

[priyankparihar]

Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r49171092
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2032,11 +2032,20 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 
 // Pair
 private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+
+String vmInternalCSName = null;
+String vmNameOnVcenter  = null;
+if(vmSpec != null)
--- End diff --

@rafaelweingartner Currently. it is not possible. Because user does not 
generate it. Cloud stack generates it only if it has all required info. 
otherwise it does not call this function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

[priyankparihar]

Github user priyankparihar closed the pull request at:

https://github.com/apache/cloudstack/pull/1165


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1302

CLOUDSTACK-9104: VM naming convention in case vmware is used

I have reverted all the changes. Now functionality is same as it was in 
earlier version. 
ACS  Bug Link is as follow ==>
https://issues.apache.org/jira/browse/CLOUDSTACK-9104




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9104

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1302


commit fd2cba99b354d54f1a101591455b39f78bab2e3f
Author: Priyank Parihar <priyank.pari...@citrix.com>
Date:   2015-11-05T15:18:00Z

CLOUDSTACK-9104: VM naming convention in case vmware is used




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...

[priyankparihar]

Github user priyankparihar closed the pull request at:

https://github.com/apache/cloudstack/pull/1207


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...

[priyankparihar]

Github user priyankparihar commented on the pull request:

https://github.com/apache/cloudstack/pull/1207#issuecomment-163912073
  
@DaanHoogland 

Prior  Behaviour
| 127 | VOLUME.DELETE   |  2 | 2015-12-08 09:30:18 |   
1 |  25 | ROOT-14 |NULL |   
 NULL |   NULL | NULL   | 0 | NULL |
| 128 | VOLUME.DELETE   |  2 | 2015-12-08 09:30:20 |   
1 |  25 | ROOT-14 |NULL |   
 NULL |   NULL | NULL   | 0 | NULL |

New  Behaviour
| 127 | VOLUME.DELETE   |  2 | 2015-12-08 09:30:18 |   
1 |  25 | ROOT-14 |NULL |   
 NULL |   NULL | NULL   | 0 | NULL |



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

[priyankparihar]

Github user priyankparihar commented on the pull request:

https://github.com/apache/cloudstack/pull/815#issuecomment-163542539
  
@DaanHoogland I did this change because UI does not allow  migration 
between different versions of hyper-visors of  but sometimes user wants to do 
migration from  Lower to Higher Version. So now he can do it via API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1207

CLOUDSTACK-9133: Two volume.delete usage events are getting generated…

It was happening because event triggering  was happening in 
UserVmManagerImpl.java and VolumeStateListener.java respectively. So i have 
removed it from UserVmManagerImpl.java.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9133

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1207


commit 5af3fd1987e797358e9bc99232202225850ed2c1
Author: Priyank Parihar <priyank.pari...@citrix.com>
Date:   2015-12-10T07:14:06Z

CLOUDSTACK-9133: Two volume.delete usage events are getting generated for 
destoy vm.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1165

CLOUDSTACK-9104: VM naming convention in case vmware is used

I have reverted all the changes. Now functionality is same as it was  in 
earlier version. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9104

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1165.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1165


commit 2588925e9c82a9914b76e06204a04f4a5ff1ddb1
Author: Priyank Parihar <priyank.pari...@citrix.com>
Date:   2015-11-05T15:18:00Z

CLOUDSTACK-9104: VM naming convention in case vmware is used




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/815

CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS 6.5 fails.

Removed Host version check in API. Because 
Case 1:(Lower to Higher  Version)
Storage XenMotion from lower version to higher version is valid.
Case 2:(Higher to Lower Version)
In this case system(Host) will not allow.

So no need to check version in API. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CS-43756

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/815.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #815


commit 2fc9e973b11fc644f1027e93ba52ced5dda4f408
Author: Priyank Parihar <priyank.pari...@citrix.com>
Date:   2015-09-14T05:42:28Z

CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS 6.5 fails.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---