[GitHub] cloudstack issue #555: CLOUDSTACK-8608. System VM's failed to start due to p...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/555 Continuing with the code changes here in a new PR #1875. This PR will be closed when PR #1875 is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1953 Changes in the PR #2019. Maximum data volumes supported field, in the _hypervisor_capabilities_ table, should be the attachable data volumes to the VM. This excludes the ROOT disk and CD-ROM. So, the hypervisor has to support max devices = maximum data volumes supported + 2 (ROOT and CD-ROM). 0(zero) index is considered in `getDeviceId()` for ROOT disk as the ROOT disk attach cmd uses this method. This has to be refactored. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @karuturi Can you merge this PR. Current base branch is 4.9. Is that OK or Shall I change to master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @rhtyd This PR has 2 LGTMs, is targeted to 4.9. Can you merge this PR to 4.9 or Shall I change the base branch to master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1880 The above tests failure are not related to this PR. These are failing most for the other PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @rhtyd Please kick off VMware tests on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @nvazquez Updated the code for the issue reported. Can you please re-test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1953 @karuturi I'm working on the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @nvazquez Thanks for testing. I'll check and update accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/837 Code changes LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105888712
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -1049,7 +1044,13 @@ public boolean executeUserRequest(final long hostId,
final Event event) throws A
}
return true;
} else if (event == Event.ShutdownRequested) {
-return reconnect(hostId);
+//should throw a exception here as well.instead of eating this
up.
+ try {
+ reconnect(hostId);
+ } catch (CloudRuntimeException e) {
--- End diff --
@bvbharatk Thanks for the clarification.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @rafaelweingartner Thanks for reviewing, will work on the changes suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105722036
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -1049,7 +1044,13 @@ public boolean executeUserRequest(final long hostId,
final Event event) throws A
}
return true;
} else if (event == Event.ShutdownRequested) {
-return reconnect(hostId);
+//should throw a exception here as well.instead of eating this
up.
+ try {
+ reconnect(hostId);
+ } catch (CloudRuntimeException e) {
--- End diff --
@bvbharatk Is it possible to take the failure reason forward?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 @rhtyd @karuturi Could see vSphere 4.1 in the latest installation guide. Please note that this documentation needs to be updated at some point later. > vSphere and vCenter, versions 4.1, 5.0, 5.1 or 5.5. > VMware vCenter Standard Edition 4.1, 5.0, 5.1 or 5.5 must be installed and available to manage the vSphere hosts. > CloudStack requires VMware vSphere 4.1, 5.0, 5.1 or 5.5. VMware vSphere 4.0 is not supported. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 @serg38 Copying port groups from the oldest host in the cluster to the new host for DRS compatible. I'll check this with the hosts returning from Maintenance. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 @rhtyd @karuturi Is this documented in any of the earlier release notes. Can we remove the config param "vmware.ports.per.dvportgroup" if vSphere 4.x is not supported? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 @nvazquez @serg38 Please review the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 @nvazquez @serg38 Can you please review this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 @resmo You have already reviewed the PR# 1248. This was the clean PR raised out of the same. Can you please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1875#discussion_r105573382
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
@@ -707,6 +709,23 @@ private String setupMountPoint(String parent) {
return mountPoint;
}
+@Override
+public synchronized void setSystemVmTmpltPermission(String mountPoint)
{
+if (!s_isSystemVmTmpltPermissionSet) {
+s_logger.debug("Set permissions for " + mountPoint);
+String result = null;
+final String systemVmTmpltPermissions = "0777";
+Script script = new Script(true, "chmod", _timeout, s_logger);
+script.add("-R", systemVmTmpltPermissions, mountPoint);
--- End diff --
@SudharmaJain Moved to TemplateConstants.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105573097
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2071,6 +2120,14 @@ protected StartAnswer execute(StartCommand cmd) {
}
}
+private void replaceNicsMacSequenceInBootArgs(String oldMacSequence,
String newMacSequence, VirtualMachineTO vmSpec) {
+String bootArgs = vmSpec.getBootArgs();
+if (!StringUtils.isEmpty(bootArgs) &&
!StringUtils.isEmpty(oldMacSequence) && !StringUtils.isEmpty(newMacSequence)) {
+//Update boot args with the new nic mac addresses
--- End diff --
@rafaelweingartner Moved the comment to the method documentation part.
Testcase added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @PaulAngus What was the error shown for duplicate MAC in vCenter. Can you post the log snippet with the error. These changes were tested in vCenter 5.5 and 6.0, didn't observe any issues in vCenter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @rhtyd Retargeted this PR to 4.9. Please re-run the tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @nvazquez can you please re-verify? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @nvazquez Thanks for testing the changes. Tested these changes in ESXi 6.0.0, Build 3620759 on vCenter 60U2. I had already looked at the link you provided while fixing this. I observed the same error on vSphere while testing the changes and fixed this. This is because the VR instance already exists in the vCenter. Below code fixes that issue: `clusterDasVmConfigSpec.setOperation(vmAlreadyExists ? ArrayUpdateOperation.EDIT : ArrayUpdateOperation.ADD); ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @rhtyd thanks for running tests. The intermittent failures reported above are not related to this PR. These tests are also failing most of the time in other PRs as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1880 @borisstoyanov @rhtyd Can you please run VMware tests of this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1891 @borisstoyanov Can you please kick off tests for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1891 @borisstoyanov the existing tests with space in the host name should work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1891 @jburwell Thanks for the recommendation. Not changing the visibility for now. Couldn't find any tests for VmwareServerDiscoverer to update. Will try to add. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @nvazquez @serg38 I tested this fix on VMware vSphere 5.5 and 6.0. I'll re-verify this on 6.0. Can you please share the build# of ESXi 6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1875#discussion_r104373535
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
@@ -707,6 +709,23 @@ private String setupMountPoint(String parent) {
return mountPoint;
}
+@Override
+public synchronized void setSystemVmTmpltPermission(String mountPoint)
{
+if (!s_isSystemVmTmpltPermissionSet) {
+s_logger.debug("Set permissions for " + mountPoint);
+String result = null;
+final String systemVmTmpltPermissions = "0777";
+Script script = new Script(true, "chmod", _timeout, s_logger);
+script.add("-R", systemVmTmpltPermissions, mountPoint);
--- End diff --
@SudharmaJain Used the string as suggested instead of hardcoded value for
permissions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @nvazquez @serg38 Please review the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 @rhtyd Above failures in the test results are not related to the changes in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 @rhtyd @borisroman can you kick off vmware tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1253
@sateesh-chodapuneedi These two test failures are due to the ssh failure to
the router VM, are not related to this PR changes.
_test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed_
> Failed to SSH into the Virtual Machine: SSH connection has Failed. Waited
150s. Error is SSH Connection Failed
> === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true |
Status : FAILED ===
>
"/automation/virtenv/00-16-3e-17-43-25/396/test/integration/smoke/test_routers_network_ops.py",
line 338, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true\n
result = check_router_command(virtual_machine, nat_rule.ipaddress, ssh_command,
check_string, self)\n', ' File
"/automation/virtenv/00-16-3e-17-43-25/396/test/integration/smoke/test_routers_network_ops.py",
line 64, in check_router_command\ntest_case.fail("Failed to SSH into the
Virtual Machine: %s" % e)\n', ' File
"/usr/local/lib/python2.7/unittest/case.py", line 412, in fail\nraise
self.failureException(msg)\n', 'AssertionError: Failed to SSH into the Virtual
Machine: SSH connection has Failed. Waited 150s. Error is SSH Connection
Failed\n']
_test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed_
> Failed to SSH into the Virtual Machine: SSH connection has Failed. Waited
150s. Error is SSH Connection Failed
> === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false |
Status : FAILED ===
>
>
"/automation/virtenv/00-16-3e-17-43-25/396/test/integration/smoke/test_routers_network_ops.py",
line 502, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false\\n
result = check_router_command(virtual_machine, nat_rule.ipaddress, ssh_command,
check_string, self)\\n\', \' File
"/automation/virtenv/00-16-3e-17-43-25/396/test/integration/smoke/test_routers_network_ops.py",
line 64, in check_router_command\\ntest_case.fail("Failed to SSH into the
Virtual Machine: %s" % e)\\n\', \' File
"/usr/local/lib/python2.7/unittest/case.py", line 412, in fail\\nraise
self.failureException(msg)\\n\', \'AssertionError: Failed to SSH into the
Virtual Machine: SSH connection has Failed. Waited 150s. Error is SSH
Connection Failed\\n\']
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 Please ignore the above BVT test results from @cloudmonger. These tests were executed on xenserver instead of VMware. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 Please ignore the above BVT test results from @cloudmonger. These tests were executed on xenserver instead of VMware. VMware tests has been kicked off in @blueorangutan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar Perfect. Code changes LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r103409558
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws InsufficientCap
}
rootDiskSize =
Long.parseLong(customParameters.get("rootdisksize"));
-// only KVM supports rootdisksize override
-if (hypervisorType != HypervisorType.KVM) {
-throw new
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not
support rootdisksize override");
+// only KVM, XenServer and VMware supports
rootdisksize override
+if (!(hypervisorType == HypervisorType.KVM ||
hypervisorType == HypervisorType.XenServer || hypervisorType ==
HypervisorType.VMware)) {
+throw new
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not
support rootdisksize override");
--- End diff --
@priyankparihar Ok. thanks for the confirmation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/669 Tested manually. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1880 @rhtyd Can you please kick off the tests again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1897 The failed test cases above are not related to this PR changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r102651816
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws InsufficientCap
}
rootDiskSize =
Long.parseLong(customParameters.get("rootdisksize"));
-// only KVM supports rootdisksize override
-if (hypervisorType != HypervisorType.KVM) {
-throw new
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not
support rootdisksize override");
+// only KVM, XenServer and VMware supports
rootdisksize override
+if (!(hypervisorType == HypervisorType.KVM ||
hypervisorType == HypervisorType.XenServer || hypervisorType ==
HypervisorType.VMware)) {
+throw new
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not
support rootdisksize override");
--- End diff --
The condition in VolumeApiServiceImpl.java at line# 1029 above and this
doesn't match. You skipped None and Any. Is that intentional?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r102650751
--- Diff:
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java
---
@@ -436,7 +436,7 @@ public void testResizeVolumeCommand() {
final Answer answer = wrapper.execute(resizeCommand,
citrixResourceBase);
verify(citrixResourceBase, times(1)).getConnection();
-assertFalse(answer.getResult());
+//assertFalse(answer.getResult());
--- End diff --
@priyankparihar @anshul1886 Is this commented statement required for future
reference? If not, better to remove this line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r102650370
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2073,6 +2089,43 @@ protected StartAnswer execute(StartCommand cmd) {
}
}
+private void resizeRootDisk(VirtualMachineMO vmMo, DiskTO rootDiskTO,
VmwareHypervisorHost hyperHost, VmwareContext context) throws Exception
+{
+Pair<VirtualDisk, String> vdisk = getVirtualDiskInfo(vmMo,
rootDiskTO.getPath() + ".vmdk");
+assert(vdisk != null);
+
+Long reqSize=((VolumeObjectTO)rootDiskTO.getData()).getSize()/1024;
+VirtualDisk disk = vdisk.first();
+if(reqSize > disk.getCapacityInKB())
+{
+VirtualMachineDiskInfo diskInfo =
getMatchingExistingDisk(vmMo.getDiskInfoBuilder(), rootDiskTO, hyperHost,
context);
+assert (diskInfo != null);
+String[] diskChain = diskInfo.getDiskChain();
+
+if(diskChain!=null && diskChain.length>1)
+{
+s_logger.error("Unsupported Disk chain length "+
diskChain.length);
+throw new Exception("Unsupported Disk chain length "+
diskChain.length);
+}
+if(diskInfo.getDiskDeviceBusName()==null ||
!diskInfo.getDiskDeviceBusName().toLowerCase().contains("scsi"))
--- End diff --
startsWith("scsi") ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r102649977
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -703,6 +703,16 @@ private Answer execute(ResizeVolumeCommand cmd) {
}
VirtualDisk disk = vdisk.first();
+if(vdisk.second()!=null &&
!vdisk.second().toLowerCase().contains("scsi"))
--- End diff --
@priyankparihar _vdisk.second()_ here holds the disk bus name, that would
ide0:0,... (or) scsi0:0,...
I think startsWith("scsi") check would be more precise.
Move "_VirtualDisk disk = vdisk.first();_" stmt below this if check. For
all non-scsi disks, the _disk_ var is unnecessarily stacked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/669 @anshul1886 Please address the open questions and rebase. Post the latest test results. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 @rhtyd Can you please run trillian tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 Moved the schema changes to 4920-41000 upgrade path. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 @rhtyd Can you kick off VMware CI on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102539843
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -584,18 +584,36 @@ public void defFileBasedDisk(String filePath, String
diskLabel, DiskBus bus, Dis
/* skip iso label */
private String getDevLabel(int devId, DiskBus bus) {
--- End diff --
@HrWiggles Will add unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102539356
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
return maxDataVolumesSupported.intValue();
}
-private Long getDeviceId(long vmId, Long deviceId) {
+private Long getDeviceId(UserVmVO vm, Long deviceId) {
// allocate deviceId
-List vols = _volsDao.findByInstance(vmId);
+int maxDataVolumesSupported = getMaxDataVolumesSupported(vm);
+List vols = _volsDao.findByInstance(vm.getId());
if (deviceId != null) {
-if (deviceId.longValue() > 15 || deviceId.longValue() == 3) {
-throw new RuntimeException("deviceId should be 1,2,4-15");
+if (deviceId.longValue() > maxDataVolumesSupported ||
deviceId.longValue() == 3) {
+throw new RuntimeException("deviceId should be 1,2,4-" +
maxDataVolumesSupported);
}
for (VolumeVO vol : vols) {
if (vol.getDeviceId().equals(deviceId)) {
-throw new RuntimeException("deviceId " + deviceId + "
is used by vm" + vmId);
+throw new RuntimeException("deviceId " + deviceId + "
is used by vm" + vm.getId());
}
}
} else {
// allocate deviceId here
List devIds = new ArrayList();
-for (int i = 1; i < 15; i++) {
+for (int i = 1; i < maxDataVolumesSupported; i++) {
--- End diff --
@HrWiggles Correct. I've updated the code. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1875 @sateesh-chodapuneedi @rhtyd Please review the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1875 @rhtyd Thanks for running tests. The test failures/errors above are failing in other PRs as well, not related to the changes in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @remibergsma Same MAC for RVR has been re-introducted as part of [CLOUDSTACK-985](https://issues.apache.org/jira/browse/CLOUDSTACK-985). It confirms that peer NICs of RVRs should have same MAC addresses. Only default public NIC was configured with same MAC. For VMware, there exists additional public NICs which were not configured with same MAC addresses. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @sateesh-chodapuneedi @rhtyd Please review the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @rhtyd Thanks for running these test. The failures/errors are not related to this PR changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1897 @koushik-das @kishankavala Please review the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1897 @ramkatru Checked and addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1953 @borisstoyanov Can you kick off Jenkins job on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102311697
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -716,11 +734,6 @@ public DiskFmtType getDiskFormatType() {
return _diskFmtType;
}
--- End diff --
Removed unused method _getDiskSeq()_.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1953 @remibergsma @borisstoyanov Updated the KVM code to generate the valid device name above id 25. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102309898
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
return maxDataVolumesSupported.intValue();
}
-private Long getDeviceId(long vmId, Long deviceId) {
+private Long getDeviceId(UserVmVO vm, Long deviceId) {
// allocate deviceId
-List vols = _volsDao.findByInstance(vmId);
+int maxDataVolumesSupported = getMaxDataVolumesSupported(vm);
--- End diff --
@rafaelweingartner when configuring getMaxDataVolumesSupported(vm) with 6
for the hypervisor of the VM, the VM can have max 6 devices. 1 root (id 0), 1
CD-ROM (id 3) and other 4 for extra disks/volumes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303566
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
return maxDataVolumesSupported.intValue();
}
-private Long getDeviceId(long vmId, Long deviceId) {
+private Long getDeviceId(UserVmVO vm, Long deviceId) {
// allocate deviceId
-List vols = _volsDao.findByInstance(vmId);
+int maxDataVolumesSupported = getMaxDataVolumesSupported(vm);
+List vols = _volsDao.findByInstance(vm.getId());
if (deviceId != null) {
-if (deviceId.longValue() > 15 || deviceId.longValue() == 3) {
-throw new RuntimeException("deviceId should be 1,2,4-15");
+if (deviceId.longValue() > maxDataVolumesSupported ||
deviceId.longValue() == 3) {
+throw new RuntimeException("deviceId should be 1,2,4-" +
maxDataVolumesSupported);
}
for (VolumeVO vol : vols) {
if (vol.getDeviceId().equals(deviceId)) {
-throw new RuntimeException("deviceId " + deviceId + "
is used by vm" + vmId);
+throw new RuntimeException("deviceId " + deviceId + "
is used by vm" + vm.getId());
}
}
} else {
// allocate deviceId here
List devIds = new ArrayList();
-for (int i = 1; i < 15; i++) {
+for (int i = 1; i < maxDataVolumesSupported; i++) {
devIds.add(String.valueOf(i));
}
devIds.remove("3");
--- End diff --
Thanks. Added this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303488
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
return maxDataVolumesSupported.intValue();
}
-private Long getDeviceId(long vmId, Long deviceId) {
+private Long getDeviceId(UserVmVO vm, Long deviceId) {
// allocate deviceId
-List vols = _volsDao.findByInstance(vmId);
+int maxDataVolumesSupported = getMaxDataVolumesSupported(vm);
+List vols = _volsDao.findByInstance(vm.getId());
if (deviceId != null) {
-if (deviceId.longValue() > 15 || deviceId.longValue() == 3) {
-throw new RuntimeException("deviceId should be 1,2,4-15");
+if (deviceId.longValue() > maxDataVolumesSupported ||
deviceId.longValue() == 3) {
+throw new RuntimeException("deviceId should be 1,2,4-" +
maxDataVolumesSupported);
}
for (VolumeVO vol : vols) {
if (vol.getDeviceId().equals(deviceId)) {
-throw new RuntimeException("deviceId " + deviceId + "
is used by vm" + vmId);
+throw new RuntimeException("deviceId " + deviceId + "
is used by vm" + vm.getId());
}
}
} else {
// allocate deviceId here
List devIds = new ArrayList();
--- End diff --
@HrWiggles. Noted, not considering it for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303229
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
return maxDataVolumesSupported.intValue();
}
-private Long getDeviceId(long vmId, Long deviceId) {
+private Long getDeviceId(UserVmVO vm, Long deviceId) {
// allocate deviceId
-List vols = _volsDao.findByInstance(vmId);
+int maxDataVolumesSupported = getMaxDataVolumesSupported(vm);
+List vols = _volsDao.findByInstance(vm.getId());
if (deviceId != null) {
-if (deviceId.longValue() > 15 || deviceId.longValue() == 3) {
-throw new RuntimeException("deviceId should be 1,2,4-15");
+if (deviceId.longValue() > maxDataVolumesSupported ||
deviceId.longValue() == 3) {
+throw new RuntimeException("deviceId should be 1,2,4-" +
maxDataVolumesSupported);
}
for (VolumeVO vol : vols) {
if (vol.getDeviceId().equals(deviceId)) {
-throw new RuntimeException("deviceId " + deviceId + "
is used by vm" + vmId);
+throw new RuntimeException("deviceId " + deviceId + "
is used by vm" + vm.getId());
}
}
} else {
// allocate deviceId here
List devIds = new ArrayList();
-for (int i = 1; i < 15; i++) {
+for (int i = 1; i < maxDataVolumesSupported; i++) {
--- End diff --
@HrWiggles Thanks for pointing this. Addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102302052
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
return maxDataVolumesSupported.intValue();
}
-private Long getDeviceId(long vmId, Long deviceId) {
+private Long getDeviceId(UserVmVO vm, Long deviceId) {
// allocate deviceId
-List vols = _volsDao.findByInstance(vmId);
+int maxDataVolumesSupported = getMaxDataVolumesSupported(vm);
+List vols = _volsDao.findByInstance(vm.getId());
if (deviceId != null) {
-if (deviceId.longValue() > 15 || deviceId.longValue() == 3) {
-throw new RuntimeException("deviceId should be 1,2,4-15");
+if (deviceId.longValue() > maxDataVolumesSupported ||
deviceId.longValue() == 3) {
--- End diff --
@HrWiggles Addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102301869
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
return maxDataVolumesSupported.intValue();
}
-private Long getDeviceId(long vmId, Long deviceId) {
+private Long getDeviceId(UserVmVO vm, Long deviceId) {
--- End diff --
@HrWiggles Will check if I can write a test for the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102301645
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
return maxDataVolumesSupported.intValue();
}
-private Long getDeviceId(long vmId, Long deviceId) {
+private Long getDeviceId(UserVmVO vm, Long deviceId) {
// allocate deviceId
-List vols = _volsDao.findByInstance(vmId);
+int maxDataVolumesSupported = getMaxDataVolumesSupported(vm);
--- End diff --
@HrWiggles Thanks for the review. The max data volumes here is the actual
hypervisor capability (which is posted in the db). The device id 3 is being
reserved for something since long and I don't want that to be effected.
When _getMaxDataVolumesSupported()_ returns 6, max 5 volumes can be
attached to the VM and one device reserved (might be for virtual tools/CDROM).
_maxDataVolumesSupported_ specifies the data volumes limit supported by
hypervisor, nothing related to _maxDeviceId_.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @borisstoyanov Can you please run trillian tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @rafaelweingartner Updated the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @rafaelweingartner Sure. I'll move these lines to a method and push the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1953 @remibergsma The KVM support for max data volumes 32 was updated in the DB as part of CLOUDSTACK-8992 (PR #980). CloudStack supports till device Id 15, without this changes. Might be the limit 32 was tested manually in the VM. As you pointed, in KVM, I see there is a problem with the device name after device id 25. As soon as the device name ends with suffix 'z' for device id 25, it should take the next suffix 'aa', 'ab',...so on. I think it is better to improve the code to generate a valid device name suffix with the given device id. As this is specific to KVM, I'll create a separate PR with these changes. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @rhtyd Can you kick off VMware CI on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1875 @rhtyd Can you run VMware CI on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1880 @rhtyd Can you run VMware CI on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1891 @rhtyd Can you kick off VMware CI on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1953 CLOUDSTACK-9794: Unable to attach more than 14 devices to a VM Updated hardcoded value with max data volumes limit from hypervisor capabilities. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9794 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1953.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1953 commit cdf50c1e0f69297beb335f852ae82663bbc87fb4 Author: Suresh Kumar Anaparti <suresh.anapa...@accelerite.com> Date: 2017-02-18T20:22:30Z CLOUDSTACK-9794: Unable to attach more than 14 devices to a VM Updated hardcoded value with max data volumes limit from hypervisor capabilities. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1818: CLOUDSTACK-9655 The template which is registered in ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1818 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/927 Code changes looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1892: CLOUDSTACK-9731: Hardcoded label appears on the Add ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1892 @koushik-das, UI screenshots of hardcoded label on the Add zone wizard and the UI fix for it are attached. Please check.   --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1897: CLOUDSTACK-9733: Concurrent volume snapshots ...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1897 CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration parameter "concurrent.snapshots.threshold.perhost". - User can take snapshots of the volumes attached to a VM simultaneously (when the underlying hypervisor supports). Only subsequent snapshot operations are in parallel. - User wants to take snapshots of the same volume at the same time (either recurring mode or manually). Only subsequent snapshot operations are in parallel. - User wants to limit the no. of concurrent snapshots per host in the cluster/cloud using the config paramter "concurrent.snapshots.threshold.perhost" (at the cluster level). You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9733 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1897.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1897 commit 46d79f1678399cbd884973358504a2773a61abaf Author: Suresh Kumar Anaparti <suresh.anapa...@accelerite.com> Date: 2017-01-09T11:59:48Z CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration parameter "concurrent.snapshots.threshold.perhost". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1892: CLOUDSTACK-9731: Hardcoded label appears on t...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1892 CLOUDSTACK-9731: Hardcoded label appears on the Add zone wizard Hardcoded label (label.remove.this.physical.network) appears on the Add zone wizard You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9731 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1892.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1892 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1891: CLOUDSTACK-9730: [VMware] Unable to add a hos...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1891 CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster Issue: Unable to add a host with space in its name to existing VMware cluster Root Cause: Previously cluster url from API used to be inserted into DB after validation of inventory url. White spaces in url would be encoded as '+' during creation of URI object which are being inserted into database. Further references of the cluster's data center name would see '+' symbols instead of white space which is incorrect. Fix: Skip update of encoded cluster url path in cluster_details table while adding host to existing cluster. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9730 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1891.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1891 commit 9b5b3aa30a04589be843c66dd8173a2b94a92d4d Author: Suresh Kumar Anaparti <suresh.anapa...@accelerite.com> Date: 2017-01-05T23:12:14Z CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to Cluster Skip update of encoded cluster url path in cluster_details table while adding host to existing cluster. Previously cluster url from API used to be inserted into DB after validation of inventory url. White spaces in url would be encoded as '+' during creation of URI object which are being inserted into database. Further references of the cluster's data center name would see '+' symbols instead of white space which is incorrect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1882: CLOUDSTACK-8737: Removed the missed out-of-ba...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1882 CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8737_CodeCleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1882.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1882 commit bda20dec181b490fc0d2e0712fb72fb0608699df Author: Suresh Kumar Anaparti <suresh.anapa...@accelerite.com> Date: 2016-12-30T10:08:08Z CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1862: CLOUDSTACK-9704 Remove dependency on VmwareContext o...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1862 @sateesh-chodapuneedi Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1841 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1862: CLOUDSTACK-9704 Remove dependency on VmwareCo...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1862#discussion_r94206268
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -5620,4 +5623,39 @@ private String getAbsoluteVmdkFile(VirtualDisk disk)
{
}
return vmdkAbsFile;
}
+
+protected File getSystemVmKeyFile() {
+if (s_systemVmKeyFile == null) {
+syncFetchSystemVmKeyFile();
+}
+return s_systemVmKeyFile;
+}
+
+private static void syncFetchSystemVmKeyFile() {
+synchronized (s_syncLockObjectFetchKeyFile) {
+if (s_systemVmKeyFile == null) {
+s_systemVmKeyFile = fetchSystemVmKeyFile();
+}
+}
+}
+
+private static File fetchSystemVmKeyFile() {
+String filePath = s_relativePathSystemVmKeyFileInstallDir;
+s_logger.debug("Looking for file [" + filePath + "] in the
classpath.");
+URL url = Script.class.getClassLoader().getResource(filePath);
+File keyFile = null;
+if (url != null) {
+keyFile = new File(url.getPath());
+}
+if (keyFile == null || !keyFile.exists()) {
+filePath = s_defaultPathSystemVmKeyFile;
+keyFile = new File(filePath);
+s_logger.debug("Looking for file [" + filePath + "] in the
classpath.");
+}
+assert (keyFile != null);
--- End diff --
This assert statement is always true. Not needed here.
Rest code changes LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1880 Validated that the template_size is getting updated correctly in template_spool_ref table. Prior to the fix, the size was logged as 0 => mysql> select id,template_id,template_size from template_spool_ref; - id template_id template_size - 1 8 0 2 202 0 3 7 0 7 8 0 10 8 0 15 8 0 23 202 0 25 202 0 - After the fix correct size is getting updated=> mysql> select id,template_id,template_size from template_spool_ref; - id template_id template_size - 1 8 262144 2 202 3145728000 3 7 2147483648 - 3 rows in set (0.00 sec) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1881: CLOUDSTACK-9721: Remove deprecated/unused glo...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1881 CLOUDSTACK-9721: Remove deprecated/unused global configuration parameter - consoleproxy.loadscan.interval You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9721 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1881.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1881 commit 119456349c730bbfef9c81bf989265f8d984a875 Author: Suresh Kumar Anaparti <suresh.anapa...@accelerite.com> Date: 2016-12-29T22:02:27Z CLOUDSTACK-9721: Remove deprecated/unused global configuration parameter - consoleproxy.loadscan.interval --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1880: CLOUDSTACK-9720: [VMware] template_spool_ref ...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1880 CLOUDSTACK-9720: [VMware] template_spool_ref table is not getting updated with correct template physical size in template_size column. Updated the template_spool_ref table with the correct template (VMware - OVA file) size. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9720 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1880.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1880 commit 84995b6ffbae565606ef050c0569815e7a87a8e1 Author: Suresh Kumar Anaparti <suresh.anapa...@accelerite.com> Date: 2016-12-29T21:31:12Z CLOUDSTACK-9720: [VMware] template_spool_ref table is not getting updated with correct template physical size in template_size column. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP setti...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1879 CLOUDSTACK-9719: [VMware] VR loses DHCP settings and VMs cannot obtain IP after HA recovery - Set high restart priority for the VR. [VMware] VR loses DHCP settings and VMs cannot obtain IP after HA recovery. Fix: Set high restart priority for the VR. Test scenarios: - Enable cluster HA after VR is created. Now stop and start VR and check its restart priority, should be High. - Enable cluster HA before VR is created. Now create some VM and verify that VR created must have High restart priority. Issue validation steps: - Create a VMware setup with a cluster having 2 ESXi hosts and Enable HA at cluster level in vCenter. - Creat a Network offering with DHCP and source NAT - Create few VMs using network created above and Ensure that router VM is created with restart priority set to High. - Make the ESXi host (where router VM is running) unreachable. - Verified that router VM is first migrated to other host and VMs acquire IP via DHCP. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9719 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1879.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1879 commit afa642974b19c35bd60c5271b1388c0958a0a653 Author: Suresh Kumar Anaparti <suresh.anapa...@accelerite.com> Date: 2016-12-29T20:27:02Z CLOUDSTACK-9719: [VMware] VR loses DHCP settings and VMs cannot obtain IP after HA recovery - Set high restart priority for the VR. Test scenarios: - Enable cluster HA after VR is created. Now stop and start VR and check its restart priority, should be High. - Enable cluster HA before VR is created. Now create some VM and verify that VR created must have High restart priority. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1878 CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs. Problem: [VMware] RVRs have mismatching MAC addresses for extra public NICs. Root Cause: MAC addresses for extra public NICs were assigned randomly for the routers. Network Orchestrator is unaware of the extra NICs info of the peer router as they are not persisted in the cloud database and so peer router MAC addresses info is not at all considered in case of RVR when assigning MAC addresses for extra public NICs. Solution: When RVR is enabled and Peer Router is available, get the MAC addresses of the extra public NICs from the Peer Router and set them to the router. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9717 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1878.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1878 commit 3da9416ecfea0e8177b3985dec7dce686dc8c9c9 Author: Suresh Kumar Anaparti <suresh.anapa...@accelerite.com> Date: 2016-12-29T11:54:42Z CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs. Fix: When RVR is enabled and Peer Router is available, get the MAC addresses of the extra public NICs from the Peer Router and set them to the router. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1875 CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management server. [VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management server. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8608 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1875.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1875 commit c1c77a9d7cdc472962050c7eeea0ea51ddc16bda Author: Suresh Kumar Anaparti <suresh.anapa...@accelerite.com> Date: 2016-12-29T09:10:01Z CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management server. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1794: added more guest os
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1794 @rhtyd Added more guest OS mappings and rebased against latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 @rhtyd Changed base branch to 4.9 and rebased against 4.9. This would be useful for 4.9. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1252 @rhtyd no existing marvin test for this. will add the test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1252 @rhtyd Rebased against 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1252: CLOUDSTACK-9182: Some running VMs turned off ...
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1252#discussion_r90602385
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -4468,6 +4472,16 @@ private boolean checkIfHostIsDedicated(HostVO host) {
}
}
+private void checkIfHostOfVMIsInPrepareForMaintenanceState(Long
hostId, Long vmId, String operation) {
--- End diff --
@alexandrelimassantana Added javadoc for the method
"checkIfHostOfVMIsInPrepareForMaintenanceState"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
