[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 Tests LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-468) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34374 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1710-t468-xenserver-65sp1.zip Test completed. 46 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 592.04 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 1387.60 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 583.98 | test_vpc_redundant.py test_router_dhcp_opts | `Failure` | 31.05 | test_router_dhcphosts.py test_01_vpc_site2site_vpn | Success | 431.71 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 197.20 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 653.52 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 459.21 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 851.36 | test_vpc_router_nics.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 996.05 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 1094.06 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 15.81 | test_volumes.py test_08_resize_volume | Success | 96.12 | test_volumes.py test_07_resize_fail | Success | 105.95 | test_volumes.py test_06_download_detached_volume | Success | 30.40 | test_volumes.py test_05_detach_volume | Success | 100.70 | test_volumes.py test_04_delete_attached_volume | Success | 10.20 | test_volumes.py test_03_download_attached_volume | Success | 15.27 | test_volumes.py test_02_attach_volume | Success | 10.88 | test_volumes.py test_01_create_volume | Success | 392.49 | test_volumes.py test_03_delete_vm_snapshots | Success | 280.32 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 211.55 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 100.69 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 253.58 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.71 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.16 | test_vm_life_cycle.py test_08_migrate_vm | Success | 66.11 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py test_06_destroy_vm | Success | 10.14 | test_vm_life_cycle.py test_03_reboot_vm | Success | 15.21 | test_vm_life_cycle.py test_02_start_vm | Success | 25.27 | test_vm_life_cycle.py test_01_stop_vm | Success | 30.26 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 141.16 | test_templates.py test_08_list_system_templates | Success | 0.04 | test_templates.py test_07_list_public_templates | Success | 0.06 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.15 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.16 | test_templates.py test_01_create_template | Success | 75.62 | test_templates.py test_10_destroy_cpvm | Success | 231.81 | test_ssvm.py test_09_destroy_ssvm | Success | 234.72 | test_ssvm.py test_08_reboot_cpvm | Success | 121.59 | test_ssvm.py test_07_reboot_ssvm | Success | 153.85 | test_ssvm.py test_06_stop_cpvm | Success | 136.69 | test_ssvm.py test_05_stop_ssvm | Success | 174.05 | test_ssvm.py test_04_cpvm_internals | Success | 1.15 | test_ssvm.py test_03_ssvm_internals | Success | 3.47 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py test_01_snapshot_root_disk | Success | 31.41 | test_snapshots.py test_04_change_offering_small | Success | 119.02 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py test_01_create_service_offering | Success | 0.08 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py test_01_scale_vm | Success | 5.19 | test_scale_vm.py test_09_reboot_router | Success | 55.42 | test_routers.py test_08_start_router | Success | 45.38 | test_routers.py test_07_stop_router | Success | 15.20 | test_routers.py test_06_router_advanced | Success | 0.06 | test_routers.py test_05_router_basic | Success | 0.07 |
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-462) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26823 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1710-t462-kvm-centos7.zip Test completed. 46 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_redundant_VPC_default_routes | `Failure` | 873.43 | test_vpc_redundant.py test_router_dhcp_opts | `Failure` | 20.89 | test_router_dhcphosts.py test_01_vpc_site2site_vpn | Success | 144.25 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 65.83 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 229.84 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 278.50 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 542.32 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 499.58 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1400.05 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 532.40 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1273.02 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 10.36 | test_volumes.py test_08_resize_volume | Success | 15.30 | test_volumes.py test_07_resize_fail | Success | 20.35 | test_volumes.py test_06_download_detached_volume | Success | 15.34 | test_volumes.py test_05_detach_volume | Success | 100.26 | test_volumes.py test_04_delete_attached_volume | Success | 10.16 | test_volumes.py test_03_download_attached_volume | Success | 15.26 | test_volumes.py test_02_attach_volume | Success | 73.79 | test_volumes.py test_01_create_volume | Success | 651.67 | test_volumes.py test_deploy_vm_multiple | Success | 282.83 | test_vm_life_cycle.py test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.70 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.17 | test_vm_life_cycle.py test_08_migrate_vm | Success | 30.62 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.68 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.69 | test_vm_life_cycle.py test_02_start_vm | Success | 10.15 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.27 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 110.75 | test_templates.py test_08_list_system_templates | Success | 0.02 | test_templates.py test_07_list_public_templates | Success | 0.03 | test_templates.py test_05_template_permissions | Success | 0.04 | test_templates.py test_04_extract_template | Success | 5.22 | test_templates.py test_03_delete_template | Success | 5.08 | test_templates.py test_02_edit_template | Success | 90.16 | test_templates.py test_01_create_template | Success | 45.34 | test_templates.py test_10_destroy_cpvm | Success | 161.56 | test_ssvm.py test_09_destroy_ssvm | Success | 163.55 | test_ssvm.py test_08_reboot_cpvm | Success | 101.51 | test_ssvm.py test_07_reboot_ssvm | Success | 133.00 | test_ssvm.py test_06_stop_cpvm | Success | 106.78 | test_ssvm.py test_05_stop_ssvm | Success | 133.15 | test_ssvm.py test_04_cpvm_internals | Success | 1.20 | test_ssvm.py test_03_ssvm_internals | Success | 2.92 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py test_01_snapshot_root_disk | Success | 16.05 | test_snapshots.py test_04_change_offering_small | Success | 239.42 | test_service_offerings.py test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py test_01_create_service_offering | Success | 0.08 | test_service_offerings.py test_02_sys_template_ready | Success | 0.11 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.13 | test_secondary_storage.py test_09_reboot_router | Success | 40.27 | test_routers.py test_08_start_router | Success | 30.22 | test_routers.py test_07_stop_router | Success | 10.13 | test_routers.py test_06_router_advanced | Success | 0.04 | test_routers.py test_05_router_basic | Success | 0.03 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.67 | test_routers.py test_03_restart_network_cleanup | Success | 60.39 | test_routers.py test_02_router_internal_adv | Success | 0.85 | test_routers.py test_01_router_internal_basic | Success | 0.49 | test_routers.py
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 Failure wrt debian pkg was due to an env issue. @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Packaging result: âcentos6 âcentos7 âdebian. JID-262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-438) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34149 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1710-t438-kvm-centos7.zip Test completed. 35 look ok, 13 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_VPC_default_routes | `Failure` | 797.63 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | `Failure` | 797.52 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | `Failure` | 349.40 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 287.55 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 323.23 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Failure` | 860.28 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 380.03 | test_vpc_redundant.py test_02_attach_volume | `Failure` | 668.60 | test_volumes.py test_01_create_volume | `Failure` | 684.03 | test_volumes.py test_10_attachAndDetach_iso | `Failure` | 698.83 | test_vm_life_cycle.py test_04_change_offering_small | `Failure` | 794.89 | test_service_offerings.py test_router_dns_guestipquery | `Failure` | 277.55 | test_router_dns.py test_router_dhcphosts | `Failure` | 188.81 | test_router_dhcphosts.py test_router_dhcp_opts | `Failure` | 21.25 | test_router_dhcphosts.py test_04_rvpc_privategw_static_routes | `Failure` | 1045.68 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 899.94 | test_privategw_acl.py test_02_vpc_privategw_static_routes | `Failure` | 924.67 | test_privategw_acl.py test_isolate_network_password_server | `Failure` | 188.92 | test_password_server.py test_reboot_router | `Failure` | 426.89 | test_network.py test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Failure` | 831.83 | test_network.py test_network_rules_acquired_public_ip_2_nat_rule | `Failure` | 679.49 | test_network.py test_network_rules_acquired_public_ip_1_static_nat_rule | `Failure` | 675.67 | test_network.py test_02_port_fwd_on_non_src_nat | `Failure` | 678.76 | test_network.py test_01_port_fwd_on_src_nat | `Failure` | 673.86 | test_network.py test_assign_and_removal_lb | `Failure` | 110.42 | test_loadbalance.py test_02_create_lb_rule_non_nat | `Failure` | 110.41 | test_loadbalance.py test_01_create_lb_rule_src_nat | `Failure` | 110.63 | test_loadbalance.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 280.18 | test_internal_lb.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 225.12 | test_internal_lb.py test_01_vpc_site2site_vpn | `Error` | 290.79 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | `Error` | 381.59 | test_vpc_vpn.py test_05_rvpc_multi_tiers | `Error` | 410.40 | test_vpc_redundant.py ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 239.26 | test_router_dhcphosts.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 230.23 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 220.37 | test_internal_lb.py test_01_vpc_remote_access_vpn | Success | 66.23 | test_vpc_vpn.py test_09_delete_detached_volume | Success | 15.50 | test_volumes.py test_08_resize_volume | Success | 15.44 | test_volumes.py test_07_resize_fail | Success | 20.55 | test_volumes.py test_06_download_detached_volume | Success | 15.33 | test_volumes.py test_05_detach_volume | Success | 100.28 | test_volumes.py test_04_delete_attached_volume | Success | 10.20 | test_volumes.py test_03_download_attached_volume | Success | 15.27 | test_volumes.py test_deploy_vm_multiple | Success | 289.25 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.23 | test_vm_life_cycle.py test_08_migrate_vm | Success | 81.46 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.84 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.86 | test_vm_life_cycle.py test_02_start_vm | Success | 5.15 | test_vm_life_cycle.py test_01_stop_vm | Success | 125.89 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 105.88 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.09 | test_templates.py test_04_extract_template | Success | 5.33 |
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 There were some intermittent errors seen, I'll re-kick tests. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @ustcweizhou @ozhanrk can you check snapshot and volume related errors in the last test runs above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-418) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36313 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1710-t418-xenserver-65sp1.zip Test completed. 45 look ok, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 580.53 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 1376.08 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 627.27 | test_vpc_redundant.py test_01_VPC_nics_after_destroy | `Error` | 121.73 | test_vpc_router_nics.py test_04_extract_template | `Error` | 0.05 | test_templates.py test_03_delete_template | `Error` | 5.07 | test_templates.py test_01_vpc_site2site_vpn | Success | 341.80 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 166.24 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 536.75 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 424.37 | test_vpc_router_nics.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 883.50 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 1121.38 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 15.72 | test_volumes.py test_08_resize_volume | Success | 95.98 | test_volumes.py test_07_resize_fail | Success | 100.70 | test_volumes.py test_06_download_detached_volume | Success | 20.28 | test_volumes.py test_05_detach_volume | Success | 100.24 | test_volumes.py test_04_delete_attached_volume | Success | 10.14 | test_volumes.py test_03_download_attached_volume | Success | 15.20 | test_volumes.py test_02_attach_volume | Success | 11.48 | test_volumes.py test_01_create_volume | Success | 392.57 | test_volumes.py test_03_delete_vm_snapshots | Success | 280.37 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 196.78 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 100.81 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 302.72 | test_vm_life_cycle.py test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 97.00 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.17 | test_vm_life_cycle.py test_08_migrate_vm | Success | 65.76 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.07 | test_vm_life_cycle.py test_06_destroy_vm | Success | 5.09 | test_vm_life_cycle.py test_03_reboot_vm | Success | 10.12 | test_vm_life_cycle.py test_02_start_vm | Success | 20.17 | test_vm_life_cycle.py test_01_stop_vm | Success | 30.20 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 166.24 | test_templates.py test_08_list_system_templates | Success | 0.02 | test_templates.py test_07_list_public_templates | Success | 0.03 | test_templates.py test_05_template_permissions | Success | 0.04 | test_templates.py test_02_edit_template | Success | 90.12 | test_templates.py test_01_create_template | Success | 95.57 | test_templates.py test_10_destroy_cpvm | Success | 196.65 | test_ssvm.py test_09_destroy_ssvm | Success | 199.10 | test_ssvm.py test_08_reboot_cpvm | Success | 171.42 | test_ssvm.py test_07_reboot_ssvm | Success | 144.80 | test_ssvm.py test_06_stop_cpvm | Success | 166.47 | test_ssvm.py test_05_stop_ssvm | Success | 139.29 | test_ssvm.py test_04_cpvm_internals | Success | 1.26 | test_ssvm.py test_03_ssvm_internals | Success | 3.77 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py test_01_snapshot_root_disk | Success | 21.06 | test_snapshots.py test_04_change_offering_small | Success | 134.16 | test_service_offerings.py test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py test_01_create_service_offering | Success | 0.09 | test_service_offerings.py test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py test_01_scale_vm | Success | 5.14 | test_scale_vm.py test_09_reboot_router | Success | 90.50 | test_routers.py test_08_start_router | Success | 70.43 | test_routers.py test_07_stop_router | Success | 20.29 | test_routers.py test_06_router_advanced | Success | 0.04 | test_routers.py test_05_router_basic | Success | 0.03 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.50 |
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-419) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32311 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1710-t419-kvm-centos7.zip Test completed. 43 look ok, 5 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_06_download_detached_volume | `Failure` | 15.34 | test_volumes.py test_02_create_lb_rule_non_nat | `Failure` | 252.00 | test_loadbalance.py test_04_extract_Iso | `Failure` | 5.12 | test_iso.py ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py test_01_create_volume | `Error` | 955.72 | test_volumes.py ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py test_02_VPC_default_routes | Success | 272.95 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 559.93 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 503.58 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1326.56 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 589.09 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 796.84 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1312.55 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 15.57 | test_volumes.py test_08_resize_volume | Success | 15.41 | test_volumes.py test_07_resize_fail | Success | 20.47 | test_volumes.py test_05_detach_volume | Success | 100.29 | test_volumes.py test_04_delete_attached_volume | Success | 10.21 | test_volumes.py test_03_download_attached_volume | Success | 15.28 | test_volumes.py test_02_attach_volume | Success | 104.14 | test_volumes.py test_deploy_vm_multiple | Success | 294.34 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 27.42 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py test_08_migrate_vm | Success | 41.06 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py test_06_destroy_vm | Success | 130.91 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.87 | test_vm_life_cycle.py test_02_start_vm | Success | 10.19 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.34 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 166.44 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.32 | test_templates.py test_03_delete_template | Success | 5.10 | test_templates.py test_02_edit_template | Success | 90.18 | test_templates.py test_01_create_template | Success | 65.58 | test_templates.py test_10_destroy_cpvm | Success | 166.47 | test_ssvm.py test_09_destroy_ssvm | Success | 194.73 | test_ssvm.py test_08_reboot_cpvm | Success | 131.97 | test_ssvm.py test_07_reboot_ssvm | Success | 133.68 | test_ssvm.py test_06_stop_cpvm | Success | 131.78 | test_ssvm.py test_05_stop_ssvm | Success | 133.47 | test_ssvm.py test_04_cpvm_internals | Success | 1.22 | test_ssvm.py test_03_ssvm_internals | Success | 3.06 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py test_01_snapshot_root_disk | Success | 16.34 | test_snapshots.py test_04_change_offering_small | Success | 239.67 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py test_01_create_service_offering | Success | 0.12 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py test_09_reboot_router | Success | 50.45 | test_routers.py test_08_start_router | Success | 35.35 | test_routers.py test_07_stop_router | Success | 10.17 | test_routers.py test_06_router_advanced | Success | 0.07 | test_routers.py test_05_router_basic | Success | 0.04 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.71 | test_routers.py
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 Thanks @ozhanrk I'll kick a final test round with xenserver and merge this. @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @rhtyd we have got the required LGTM's now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1710 This code LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1710 LGTM! We're running it in our labs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @kiwiflyer @nathanejohnson i saw that you are merged this fix and using it on your ENA CloudStack branch, when you have time could you check the code for possible LGTM's please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 Do we have LGTMs on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-377) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27282 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1710-t377-kvm-centos7.zip Test completed. 47 look ok, 1 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_redundant_VPC_default_routes | `Failure` | 870.27 | test_vpc_redundant.py ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 518.77 | test_vpc_redundant.py test_01_vpc_site2site_vpn | Success | 185.42 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 66.14 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 271.58 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 309.46 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 656.73 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 513.66 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1286.92 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 554.96 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1303.03 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 15.51 | test_volumes.py test_08_resize_volume | Success | 15.43 | test_volumes.py test_07_resize_fail | Success | 20.52 | test_volumes.py test_06_download_detached_volume | Success | 15.31 | test_volumes.py test_05_detach_volume | Success | 100.30 | test_volumes.py test_04_delete_attached_volume | Success | 10.20 | test_volumes.py test_03_download_attached_volume | Success | 15.41 | test_volumes.py test_02_attach_volume | Success | 44.99 | test_volumes.py test_01_create_volume | Success | 719.77 | test_volumes.py test_deploy_vm_multiple | Success | 253.60 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.70 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py test_08_migrate_vm | Success | 42.44 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.92 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.82 | test_vm_life_cycle.py test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.33 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 131.03 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.18 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.18 | test_templates.py test_01_create_template | Success | 50.52 | test_templates.py test_10_destroy_cpvm | Success | 161.65 | test_ssvm.py test_09_destroy_ssvm | Success | 168.70 | test_ssvm.py test_08_reboot_cpvm | Success | 131.69 | test_ssvm.py test_07_reboot_ssvm | Success | 133.64 | test_ssvm.py test_06_stop_cpvm | Success | 131.78 | test_ssvm.py test_05_stop_ssvm | Success | 163.84 | test_ssvm.py test_04_cpvm_internals | Success | 1.23 | test_ssvm.py test_03_ssvm_internals | Success | 3.37 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py test_01_snapshot_root_disk | Success | 16.34 | test_snapshots.py test_04_change_offering_small | Success | 239.69 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.09 | test_service_offerings.py test_01_create_service_offering | Success | 0.11 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py test_09_reboot_router | Success | 40.33 | test_routers.py test_08_start_router | Success | 30.40 | test_routers.py test_07_stop_router | Success | 10.16 | test_routers.py test_06_router_advanced | Success | 0.06 | test_routers.py test_05_router_basic | Success | 0.04 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.72 | test_routers.py test_03_restart_network_cleanup | Success | 60.54 | test_routers.py test_02_router_internal_adv | Success | 1.05 | test_routers.py test_01_router_internal_basic | Success | 0.59 |
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Packaging result: âcentos6 âcentos7 âdebian. JID-191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 hi @jburwell this pr does not delete any kind of snapshots, this patch only prevents, solves a kind of timeout issue on code thats all, nothing more. This is a 4 lines of small fix where delete snapshot code could not find already deleted snapshots ids so it waits till timeout reached, with this patch it understands they are already deleted so it did not wait and continue the process. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1710 @ozhanrk @ustcweizhou I asked a [functionality question](https://github.com/apache/cloudstack/pull/1710#issuecomment-257697031) regarding this functionality to which I cannot find an answer. Namely, that this patch is deleting snapshots in a circumstance where not all users want them deleted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1710 @ustcweizhou @ozhanrk this feels like a relatively narrow case (RBD on KVM), and we are extremely late for 4.9.1.0. We have numerous "small" fixes that could be included that would further delay significant fixes that affect nearly users. I am sorry, but this fix will have to wait until 4.9.2.0/4.10.1.0/4.11.0.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @rhtyd @jburwell, With the comments of @ustcweizhou, could we start required tests and if its all ok, could we merge this pr to upcoming 4.9.1.0 release please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1710 @jburwell John, this is a small bug fix for issue: failed to delete snapshot on RBD if the original volume is removed. It will not impact other scenario and bring other issues. I think it can be merged into LTS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @jburwell , i am so sorry but i do not understand, what you mean by combining fixes under a single pr because this is a only single fix with a 4 lines of code change which only effects rbd storage users for primary storage. The previous tickets which mentioned above was both fixed and currently in 4.9.0.0 code. So this is the only remaining part of that fixes for rbd users. @ustcweizhou i am not a developer, if i am wrong could you explain our current status in more technical way, i am very new to ACS community, so maybe i could not express pr's current status :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1710 @ozhanrk I recommend combining the fixes into a single PR for review cohesion and to ensure that the merge maintains the stability of the release branches. You could either amend this PR with the necessary commits or create a new PR and close this one -- whichever approach is easier for you. Ultimately, the PR should have one commit per JIRA ticket fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @jburwell , this is a missing 3 line of code fix which was occured because of the fixes done in CLOUDSTACK-8302, CLOUDSTACK-9297. Those fixed bug's are already in 4.9.0 release so the codes which @ustcweizhou fixed are the required, remaining parts for the complete functional fix of CLOUDSTACK-9297 ticket. Also this fix only effects RBD users, other storage users does not effect. So if possible please lets include this fix for upcoming 4.9 lts release and if we like to add a new enhancement lets plan it for 4.10 or later upcoming. We are trying to fix this problem nearly from 4.8 release like 6-9 months or more. Currently we using this pr on our 4.9 production environment by compiling this code over 4.9.0 code, so we really need this fix on upcoming lts code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1710 @ozhanrk Reading the ticket and the patch, this behavior seems like a common request across storage implementations. Some users want snapshots to be automatically removed and others do not. Given the variability of use cases, I think choosing one approach over another would be inappropriate. It feels like we should step back and evaluate a global-setting with a VM-level override that specifies whether or not snapshots should be removed when a VM is destroyed. Does this reasoning make sense or am I misunderstanding the goal? Also, this feels like a minor enhancement rather than a defect fix. Therefore, I think we should move the target of the work to ``master`` rather LTS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1710 @jburwell Could you please review this PR ? Thanks, @ozhanrk wants to make it in 4.9.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi, @ustcweizhou do we need to take any more action or inform some people from ACS to take this PR to upcoming releases? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---