[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1677
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1677
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
Invalid params were provided, the hypervisor to be passed was vmware-55u3. 
I'll fix this in blueorangutan as it currently does not check/validate the 
hypervisor name properly. Kicked a new job manually from Jenkins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1680
  
The job failed due to systemvms failed to come up, I'll re-kick this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1710
  
@jburwell Could you please review this PR ? Thanks, @ozhanrk wants to make 
it in 4.9.1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1706: CLOUDSTACK-9500: remove the IP from the databag if i...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1706
  
this is our change for similar issue
```
diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py 
b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
index 9f9513d..fc2b639 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
@@ -118,6 +118,16 @@ class CsAddress(CsDataBag):
 if CsDevice(dev, self.config).waitfordevice():
 ip.configure(address)

+def delete(self, addr):
+for dev in self.dbag:
+if dev == "id":
+continue
+for address in self.dbag[dev]:
+if address['public_ip'] == addr:
+self.dbag[dev].remove(address)
+self.save()
+break
+

 class CsInterface:

@@ -537,6 +547,8 @@ class CsIP:
 route.copy_routes_from_main(devs, [self.dev])

 elif method == "delete":
+logging.info("delete %s from /etc/cloudstack/ips.json" % 
self.address['public_ip'])
+self.config.address().delete(self.address['public_ip'])
 logging.warn("delete route not implemented")

 self.fw_router()
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1676: CLOUDSTACK-9502: DS template copies don’t get dele...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1676
  
@rhtyd I understand these words: "help", "hello", "thanks", "package", 
"test"
Test run usage: test (mgmt server, one of: centos6, centos7, ubuntu) 
(hypervisor, one of: kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-65sp1, 
xenserver-62sp1, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1)
Authorized contributors for kicking Trillian Jenkins test jobs are: 
['rhtyd', 'jburwell', 'murali-reddy', 'abhinandanprateek', 'PaulAngus', 
'borisstoyanov', 'karuturi']


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1677
  
@blueorangutan centos7 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1714: CLOUDSTACK-9553 Usage event is not getting recorded ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1714
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
LGTM. I'll re-kick tests.
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1701
  
Since this is a pure UI change, merging based on manual test LGTMs and code 
review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1701


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1712: CLOUDSTACK-9550: Use context to filter items ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1712


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1745: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1745
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1743
  
LGTM, not sure if this can lead to any side-effects.
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1745: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1745
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-116


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1677
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareContextPo...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1729
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1719: [RC][Testing] Dummy PR for kicking tests on 4...

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1719


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1717: [RC][Testing] Dummy PR for kicking tests on 4...

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1717


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareContextPo...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1729
  
Thanks @murali-reddy 
I've rebase against latest base branch, kicking one final round of tests.
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1718: [RC][Testing] Dummy PR for kicking tests on 4...

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1718


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1701
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-117


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1712: CLOUDSTACK-9550: Use context to filter items in a me...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1712
  
Merging this since it's a pure UI change, validated with manual test LGTMs 
and code review LGTMs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@wido I can help run tests if you can rebase/fix-conflicts on this PR, 
thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1577
  
@nlivens I can help run tests on this if you can squash your changes, 
thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
@nlivens I can run tests on this PR if you can rebase, fix conflicts and 
squash your changes. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Outstanding Review/Testing for 4.8.2.0/4.9.1.0/4.10.0.0 RCs

[Rohit Yadav]

There are some PRs whose author need to fix merge conflicts, or squash their 
commits, or participate in the discussion:


1545

1577
1578
1579
1580


Due to issues at the backend, I've manually kicked Trillian tests on following 
PRs:


1673

1676

1680

1681

1732


The following PRs in the queue, being packaged right now and I'll kick tests on 
them shortly:

1542

1600

1674

1677

1745


Following PRs have enough test results, but needs one or more code review LGTMs:


1694


I've merged two UI related PRs, in general I've pinged people to rebase and fix 
merge-conflicts on several PRs.


Regards.


From: John Burwell 
Sent: 01 November 2016 08:53:35
To: dev@cloudstack.apache.org
Subject: Outstanding Review/Testing for 4.8.2.0/4.9.1.0/4.10.0.0 RCs

All,

Since we have stabilized the smoke tests, we have made good progress merging 
PRs.  Currently, the following open PRs are being targeted for these releases:

* 4.10.0.0 (+ all 4.8.2.0 and 4.9.1.0 PRs)
 * 1542
 * 1545
 * 1577
 * 1578
 * 1579
 * 1580
* 1600
* 1732
* 4.9.1.0 (+ all 4.8.2.0 PRs)
 * 1676
 * 1677
 * 1678
 * 1680
 * 1681
 * 1684
* 4.8.2.0
 * 1673
 * 1674
 * 1694

Are there any other open PRs that folks feel should be included in these 
releases?  I have updated each of these PRs with next steps, and, where 
possible, kicked off regression tests.

I would like to get the 4.8.2.0, 4.9.1.0, and 4.10.0.0 RCs out by COB, next 
Wednesday (5 Wednesday 2016).  Any assistance people can provide 
reviewing/testing these PRs to get them merged would be much appreciated.

Thanks,
-John
john.burw...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue




rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareContextPo...

[murali-reddy]

Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1729
  
LGTM from code change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #977: [4.9] CLOUDSTACK-8746: VM Snapshotting implementation...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/977
  
@ustcweizhou can you rebase against latest master, fix and merge conflicts 
and squash your changes, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re:Outstanding Review/Testing for 4.8.2.0/4.9.1.0/4.10.0.0 RCs

[Haijiao]

Hi, John



Is that possible to include these 2 PRs in 4.10 since 4.10 is supposed to be a 
release with new features.


#1711  XenServer 7 Supporthttps://github.com/apache/cloudstack/pull/1711
#977   VM Snapshotting implementation for KVM  
https://github.com/apache/cloudstack/pull/977


thanks !


在2016年11月01 11时23分, "John Burwell"写道:

All,

Since we have stabilized the smoke tests, we have made good progress merging 
PRs.  Currently, the following open PRs are being targeted for these releases:

* 4.10.0.0 (+ all 4.8.2.0 and 4.9.1.0 PRs)
 * 1542
 * 1545
 * 1577
 * 1578
 * 1579
 * 1580
* 1600
* 1732
* 4.9.1.0 (+ all 4.8.2.0 PRs)
 * 1676
 * 1677
 * 1678
 * 1680
 * 1681
 * 1684
* 4.8.2.0
 * 1673
 * 1674
 * 1694

Are there any other open PRs that folks feel should be included in these 
releases?  I have updated each of these PRs with next steps, and, where 
possible, kicked off regression tests.

I would like to get the 4.8.2.0, 4.9.1.0, and 4.10.0.0 RCs out by COB, next 
Wednesday (5 Wednesday 2016).  Any assistance people can provide 
reviewing/testing these PRs to get them merged would be much appreciated.

Thanks,
-John
john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
 

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 133
 Hypervisor xenserver
 NetworkType Advanced
 Passed=98
 Failed=5
 Skipped=6

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failed

* test_deploy_vm_iso.py

 * test_deploy_vm_from_iso Failing since 17 runs

* test_list_ids_parameter.py

 * ContextSuite context=TestListIdsParams>:setup Failing since 6 runs

* test_vm_life_cycle.py

 * test_10_attachAndDetach_iso Failing since 18 runs

* test_routers_network_ops.py

 * test_01_isolate_network_FW_PF_default_routes_egress_true Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1701
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1743
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1676: CLOUDSTACK-9502: DS template copies don’t get dele...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1676
  
Tests have been manually kicked on this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1743
  
in 4.9, ALL iptables rules will be saved in /tmp/rules.save
I think it is better to add the rules in 
systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py

```
+self.fw.append(["mangle", "front",
+"-A POSTROUTING " +
+"-p udp -m udp --dport 68 -j CHECKSUM 
--checksum-fill"])
```

in fw_router and fw_vpcrouter


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1714: CLOUDSTACK-9553 Usage event is not getting recorded ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1714
  
LGTM. @jburwell we can pick this for 4.8+ releases.
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1718: [RC][Testing] Dummy PR for kicking tests on 4.9.1.0

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1718
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1719: [RC][Testing] Dummy PR for kicking tests on 4.10.0.0

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1719
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1713: CLOUDSTACK-9552: Allow egress TCP/53 implicitly in B...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1713
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1713: CLOUDSTACK-9552: Allow egress TCP/53 implicitly in B...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1713
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1717: [RC][Testing] Dummy PR for kicking tests on 4.8.2.1

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1717
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

[prashanthvarma]

Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
@jburwell @rhtyd Ok, we will rebase the PR, and let you know here. 
Moreover, we can re-run the added Marvin tests and share the results after the 
re-base.

This PR has dependency from our other open PR #1578 . Thus, we included 
that PR commits in this PR.

Generally, we have two commits in a PR, one for dev and one for test 
(Marvin). 

Let me know, if you want us to do this in a different way.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...

[prashanthvarma]

Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1580
  
@jburwell @rhtyd Ok, we will rebase the PR, and let you know here. 
Moreover, we can re-run the added Marvin tests and share the results after the 
re-base.

This PR has dependency from our other open PR #1578 . Thus, we included 
that PR commits in this PR.

Generally, we have two commits in a PR, one for dev and one for test 
(Marvin). 

Let me know, if you want us to do this in a different way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareCo...

[abhinandanprateek]

Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1729#discussion_r85904768
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContextPool.java ---
@@ -45,76 +43,74 @@ public VmwareContextPool() {
 this(DEFAULT_IDLE_QUEUE_LENGTH, DEFAULT_CHECK_INTERVAL);
 }
 
-public VmwareContextPool(int maxIdleQueueLength) {
-this(maxIdleQueueLength, DEFAULT_CHECK_INTERVAL);
-}
-
 public VmwareContextPool(int maxIdleQueueLength, long 
idleCheckIntervalMs) {
-_pool = new HashMap();
+_pool = new HashMap();
 
 _maxIdleQueueLength = maxIdleQueueLength;
 _idleCheckIntervalMs = idleCheckIntervalMs;
 
 _timer.scheduleAtFixedRate(getTimerTask(), _idleCheckIntervalMs, 
_idleCheckIntervalMs);
 }
 
-public void registerOutstandingContext(VmwareContext context) {
-assert (context != null);
-synchronized (this) {
-_outstandingRegistry.add(context);
-}
-}
-
-public void unregisterOutstandingContext(VmwareContext context) {
-assert (context != null);
-synchronized (this) {
-_outstandingRegistry.remove(context);
+public VmwareContext getContext(final String vCenterAddress, final 
String vCenterUserName) {
+final String poolKey = composePoolKey(vCenterAddress, 
vCenterUserName);
+if (Strings.isNullOrEmpty(poolKey)) {
+return null;
 }
-}
-
-public VmwareContext getContext(String vCenterAddress, String 
vCenterUserName) {
-String poolKey = composePoolKey(vCenterAddress, vCenterUserName);
 synchronized (this) {
-List l = _pool.get(poolKey);
-if (l == null)
-return null;
-
-if (l.size() > 0) {
-VmwareContext context = l.remove(0);
-context.setPoolInfo(this, poolKey);
-
-if (s_logger.isTraceEnabled())
-s_logger.trace("Return a VmwareContext from the idle 
pool: " + poolKey + ". current pool size: " + l.size() + ", outstanding count: 
" +
-VmwareContext.getOutstandingContextCount());
+final Queue ctxList = _pool.get(poolKey);
+if (ctxList != null && ctxList.size() > 0) {
+final VmwareContext context = ctxList.remove();
+if (context != null) {
+context.setPoolInfo(this, poolKey);
+}
+if (s_logger.isTraceEnabled()) {
+s_logger.trace("Return a VmwareContext from the idle 
pool: " + poolKey + ". current pool size: " + ctxList.size() + ", outstanding 
count: " +
+VmwareContext.getOutstandingContextCount());
+}
 return context;
 }
-
-// TODO, we need to control the maximum number of outstanding 
VmwareContext object in the future
 return null;
 }
 }
 
-public void returnContext(VmwareContext context) {
+public void registerContext(final VmwareContext context) {
 assert (context.getPool() == this);
 assert (context.getPoolKey() != null);
 synchronized (this) {
-List l = _pool.get(context.getPoolKey());
-if (l == null) {
-l = new ArrayList();
-_pool.put(context.getPoolKey(), l);
+Queue ctxList = _pool.get(context.getPoolKey());
+if (ctxList == null) {
+ctxList = EvictingQueue.create(_maxIdleQueueLength);
--- End diff --

Since all access is in synchronized blocks this is not required. But a 
synchronised evictingqueue could have let you avoid some of synchronised blocks.

Again, this is not required as it is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1607: SSVM downloader now handles redirects properl...

[ProjectMoon]

Github user ProjectMoon closed the pull request at:

https://github.com/apache/cloudstack/pull/1607


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

[ProjectMoon]

Github user ProjectMoon commented on the issue:

https://github.com/apache/cloudstack/pull/1607
  
Closed in favor of #1746.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1713: CLOUDSTACK-9552: Allow egress TCP/53 implicitly in B...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1713
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-123


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1718: [RC][Testing] Dummy PR for kicking tests on 4.9.1.0

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1718
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1717: [RC][Testing] Dummy PR for kicking tests on 4.8.2.1

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1717
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-124


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1673
  
Trillian test result (tid-230)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26194 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1673-t230-kvm-centos7.zip
Test completed. 41 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 853.48 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 358.79 
| test_vpc_redundant.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
test_01_vpc_site2site_vpn | Success | 159.81 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 297.63 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 580.58 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 523.76 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1418.20 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 537.63 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.67 | test_volumes.py
test_08_resize_volume | Success | 15.33 | test_volumes.py
test_07_resize_fail | Success | 20.46 | test_volumes.py
test_06_download_detached_volume | Success | 15.27 | test_volumes.py
test_05_detach_volume | Success | 100.23 | test_volumes.py
test_04_delete_attached_volume | Success | 10.30 | test_volumes.py
test_03_download_attached_volume | Success | 15.24 | test_volumes.py
test_02_attach_volume | Success | 43.61 | test_volumes.py
test_01_create_volume | Success | 620.83 | test_volumes.py
test_deploy_vm_multiple | Success | 272.90 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.01 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.81 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 185.26 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.82 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.08 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.69 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.71 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.15 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.25 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 106.03 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 5.14 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 40.71 | test_templates.py
test_10_destroy_cpvm | Success | 161.34 | test_ssvm.py
test_09_destroy_ssvm | Success | 132.99 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.25 | test_ssvm.py
test_07_reboot_ssvm | Success | 103.08 | test_ssvm.py
test_06_stop_cpvm | Success | 131.37 | test_ssvm.py
test_05_stop_ssvm | Success | 143.15 | test_ssvm.py
test_04_cpvm_internals | Success | 1.31 | test_ssvm.py
test_03_ssvm_internals | Success | 6.71 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.10 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.00 | test_snapshots.py
test_04_change_offering_small | Success | 209.51 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
test_01_create_service_offering | Success | 0.07 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py
test_09_reboot_router | Success | 35.27 | test_routers.py
test_08_start_router | Success | 25.20 | test_routers.py
test_07_stop_router | Success | 10.14 | test_routers.py
test_06_router_advanced | Success | 0.04 | test_routers.py
test_05_router_basic | Success | 0.03 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.51 | test_routers.py
test_03_restart_network_cleanup | Success | 50.35 | test_routers.py
test_02_router_internal_adv | Success | 0.83 | test_routers.py
test_01_router_internal_basic | Success | 0.49 | test_routers.py
test_router_dhcphosts | Success | 276.10 | 

[GitHub] cloudstack pull request #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareCo...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1729#discussion_r85902083
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContextPool.java ---
@@ -45,76 +43,74 @@ public VmwareContextPool() {
 this(DEFAULT_IDLE_QUEUE_LENGTH, DEFAULT_CHECK_INTERVAL);
 }
 
-public VmwareContextPool(int maxIdleQueueLength) {
-this(maxIdleQueueLength, DEFAULT_CHECK_INTERVAL);
-}
-
 public VmwareContextPool(int maxIdleQueueLength, long 
idleCheckIntervalMs) {
-_pool = new HashMap();
+_pool = new HashMap();
 
 _maxIdleQueueLength = maxIdleQueueLength;
 _idleCheckIntervalMs = idleCheckIntervalMs;
 
 _timer.scheduleAtFixedRate(getTimerTask(), _idleCheckIntervalMs, 
_idleCheckIntervalMs);
 }
 
-public void registerOutstandingContext(VmwareContext context) {
-assert (context != null);
-synchronized (this) {
-_outstandingRegistry.add(context);
-}
-}
-
-public void unregisterOutstandingContext(VmwareContext context) {
-assert (context != null);
-synchronized (this) {
-_outstandingRegistry.remove(context);
+public VmwareContext getContext(final String vCenterAddress, final 
String vCenterUserName) {
+final String poolKey = composePoolKey(vCenterAddress, 
vCenterUserName);
+if (Strings.isNullOrEmpty(poolKey)) {
+return null;
 }
-}
-
-public VmwareContext getContext(String vCenterAddress, String 
vCenterUserName) {
-String poolKey = composePoolKey(vCenterAddress, vCenterUserName);
 synchronized (this) {
-List l = _pool.get(poolKey);
-if (l == null)
-return null;
-
-if (l.size() > 0) {
-VmwareContext context = l.remove(0);
-context.setPoolInfo(this, poolKey);
-
-if (s_logger.isTraceEnabled())
-s_logger.trace("Return a VmwareContext from the idle 
pool: " + poolKey + ". current pool size: " + l.size() + ", outstanding count: 
" +
-VmwareContext.getOutstandingContextCount());
+final Queue ctxList = _pool.get(poolKey);
+if (ctxList != null && ctxList.size() > 0) {
+final VmwareContext context = ctxList.remove();
+if (context != null) {
+context.setPoolInfo(this, poolKey);
+}
+if (s_logger.isTraceEnabled()) {
+s_logger.trace("Return a VmwareContext from the idle 
pool: " + poolKey + ". current pool size: " + ctxList.size() + ", outstanding 
count: " +
+VmwareContext.getOutstandingContextCount());
+}
 return context;
 }
-
-// TODO, we need to control the maximum number of outstanding 
VmwareContext object in the future
 return null;
 }
 }
 
-public void returnContext(VmwareContext context) {
+public void registerContext(final VmwareContext context) {
 assert (context.getPool() == this);
 assert (context.getPoolKey() != null);
 synchronized (this) {
-List l = _pool.get(context.getPoolKey());
-if (l == null) {
-l = new ArrayList();
-_pool.put(context.getPoolKey(), l);
+Queue ctxList = _pool.get(context.getPoolKey());
+if (ctxList == null) {
+ctxList = EvictingQueue.create(_maxIdleQueueLength);
--- End diff --

Yes. There may be a case, where two threads may be trying to create 
evicting queue for a poolKey.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareCo...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1729#discussion_r85903435
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContextPool.java ---
@@ -45,76 +43,74 @@ public VmwareContextPool() {
 this(DEFAULT_IDLE_QUEUE_LENGTH, DEFAULT_CHECK_INTERVAL);
 }
 
-public VmwareContextPool(int maxIdleQueueLength) {
-this(maxIdleQueueLength, DEFAULT_CHECK_INTERVAL);
-}
-
 public VmwareContextPool(int maxIdleQueueLength, long 
idleCheckIntervalMs) {
-_pool = new HashMap();
+_pool = new HashMap();
 
 _maxIdleQueueLength = maxIdleQueueLength;
 _idleCheckIntervalMs = idleCheckIntervalMs;
 
 _timer.scheduleAtFixedRate(getTimerTask(), _idleCheckIntervalMs, 
_idleCheckIntervalMs);
 }
 
-public void registerOutstandingContext(VmwareContext context) {
-assert (context != null);
-synchronized (this) {
-_outstandingRegistry.add(context);
-}
-}
-
-public void unregisterOutstandingContext(VmwareContext context) {
-assert (context != null);
-synchronized (this) {
-_outstandingRegistry.remove(context);
+public VmwareContext getContext(final String vCenterAddress, final 
String vCenterUserName) {
+final String poolKey = composePoolKey(vCenterAddress, 
vCenterUserName);
+if (Strings.isNullOrEmpty(poolKey)) {
+return null;
 }
-}
-
-public VmwareContext getContext(String vCenterAddress, String 
vCenterUserName) {
-String poolKey = composePoolKey(vCenterAddress, vCenterUserName);
 synchronized (this) {
-List l = _pool.get(poolKey);
-if (l == null)
-return null;
-
-if (l.size() > 0) {
-VmwareContext context = l.remove(0);
-context.setPoolInfo(this, poolKey);
-
-if (s_logger.isTraceEnabled())
-s_logger.trace("Return a VmwareContext from the idle 
pool: " + poolKey + ". current pool size: " + l.size() + ", outstanding count: 
" +
-VmwareContext.getOutstandingContextCount());
+final Queue ctxList = _pool.get(poolKey);
+if (ctxList != null && ctxList.size() > 0) {
+final VmwareContext context = ctxList.remove();
+if (context != null) {
+context.setPoolInfo(this, poolKey);
+}
+if (s_logger.isTraceEnabled()) {
+s_logger.trace("Return a VmwareContext from the idle 
pool: " + poolKey + ". current pool size: " + ctxList.size() + ", outstanding 
count: " +
+VmwareContext.getOutstandingContextCount());
+}
 return context;
 }
-
-// TODO, we need to control the maximum number of outstanding 
VmwareContext object in the future
 return null;
 }
 }
 
-public void returnContext(VmwareContext context) {
+public void registerContext(final VmwareContext context) {
 assert (context.getPool() == this);
 assert (context.getPoolKey() != null);
 synchronized (this) {
-List l = _pool.get(context.getPoolKey());
-if (l == null) {
-l = new ArrayList();
-_pool.put(context.getPoolKey(), l);
+Queue ctxList = _pool.get(context.getPoolKey());
+if (ctxList == null) {
+ctxList = EvictingQueue.create(_maxIdleQueueLength);
+_pool.put(context.getPoolKey(), ctxList);
 }
 
-if (l.size() < _maxIdleQueueLength) {
-context.clearStockObjects();
-l.add(context);
+if (ctxList.size() >= _maxIdleQueueLength) {
+final VmwareContext oldestContext = ctxList.remove();
+if (oldestContext != null) {
+try {
+oldestContext.close();
+} catch (Throwable t) {
--- End diff --

@abhinandanprateek ^^ here we close oldest context, before adding a new 
one. The queue provided the FIFO semantics to purge old contexts and keep new 
ones around, which is why I switched from previously used arraylist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-121


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareContextPo...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1729
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-122


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
The debian pkg failed due to an intermittent unit test failure (ignorable, 
env issue).
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...

[prashanthvarma]

Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1578
  
@jburwell @rhtyd Ok, we will rebase the PR and squash our changes/commits, 
and let you know here. Moreover, we can re-run the added Marvin tests and share 
the results after the re-base.

Generally, we have two commits in a PR, one for dev and one for test 
(Marvin). Is it fine to have this two commits per PR, and squash the other 
commits ?

Our open PRs #1579 and #1580 have dependencies on this PR. Thus, we 
included this PR commits in those PRs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1745: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1745
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-118


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareContextPo...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1729
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareContextPo...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1729
  
@blueorangutan test centos7 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1745: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1745
  
@jburwell The reason is ""ERROR: Step ‘Archive the artifacts’ failed: 
no workspace for cloudstack-pr-analysis #2184""
I will force push again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1745: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1745
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1745: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1745
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareCo...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1729#discussion_r85902494
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContextPool.java ---
@@ -45,76 +43,74 @@ public VmwareContextPool() {
 this(DEFAULT_IDLE_QUEUE_LENGTH, DEFAULT_CHECK_INTERVAL);
 }
 
-public VmwareContextPool(int maxIdleQueueLength) {
-this(maxIdleQueueLength, DEFAULT_CHECK_INTERVAL);
-}
-
 public VmwareContextPool(int maxIdleQueueLength, long 
idleCheckIntervalMs) {
-_pool = new HashMap();
+_pool = new HashMap();
 
 _maxIdleQueueLength = maxIdleQueueLength;
 _idleCheckIntervalMs = idleCheckIntervalMs;
 
 _timer.scheduleAtFixedRate(getTimerTask(), _idleCheckIntervalMs, 
_idleCheckIntervalMs);
 }
 
-public void registerOutstandingContext(VmwareContext context) {
-assert (context != null);
-synchronized (this) {
-_outstandingRegistry.add(context);
-}
-}
-
-public void unregisterOutstandingContext(VmwareContext context) {
-assert (context != null);
-synchronized (this) {
-_outstandingRegistry.remove(context);
+public VmwareContext getContext(final String vCenterAddress, final 
String vCenterUserName) {
+final String poolKey = composePoolKey(vCenterAddress, 
vCenterUserName);
+if (Strings.isNullOrEmpty(poolKey)) {
+return null;
 }
-}
-
-public VmwareContext getContext(String vCenterAddress, String 
vCenterUserName) {
-String poolKey = composePoolKey(vCenterAddress, vCenterUserName);
 synchronized (this) {
-List l = _pool.get(poolKey);
-if (l == null)
-return null;
-
-if (l.size() > 0) {
-VmwareContext context = l.remove(0);
-context.setPoolInfo(this, poolKey);
-
-if (s_logger.isTraceEnabled())
-s_logger.trace("Return a VmwareContext from the idle 
pool: " + poolKey + ". current pool size: " + l.size() + ", outstanding count: 
" +
-VmwareContext.getOutstandingContextCount());
+final Queue ctxList = _pool.get(poolKey);
+if (ctxList != null && ctxList.size() > 0) {
+final VmwareContext context = ctxList.remove();
+if (context != null) {
+context.setPoolInfo(this, poolKey);
+}
+if (s_logger.isTraceEnabled()) {
+s_logger.trace("Return a VmwareContext from the idle 
pool: " + poolKey + ". current pool size: " + ctxList.size() + ", outstanding 
count: " +
+VmwareContext.getOutstandingContextCount());
+}
 return context;
 }
-
-// TODO, we need to control the maximum number of outstanding 
VmwareContext object in the future
 return null;
 }
 }
 
-public void returnContext(VmwareContext context) {
+public void registerContext(final VmwareContext context) {
 assert (context.getPool() == this);
 assert (context.getPoolKey() != null);
 synchronized (this) {
-List l = _pool.get(context.getPoolKey());
-if (l == null) {
-l = new ArrayList();
-_pool.put(context.getPoolKey(), l);
+Queue ctxList = _pool.get(context.getPoolKey());
+if (ctxList == null) {
+ctxList = EvictingQueue.create(_maxIdleQueueLength);
+_pool.put(context.getPoolKey(), ctxList);
 }
 
-if (l.size() < _maxIdleQueueLength) {
-context.clearStockObjects();
-l.add(context);
+if (ctxList.size() > _maxIdleQueueLength) {
+final VmwareContext oldestContext = ctxList.remove();
+if (oldestContext != null) {
+try {
+oldestContext.close();
+} catch (Throwable t) {
+s_logger.error("Unexpected exception caught while 
trying to purge oldest VmwareContext", t);
+}
--- End diff --

In the `registerContext` method we check if the queue is full; in case it 
is full, we remove the oldest element and close it properly. I'll ping you on 
the lines where it happens.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your 

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
Thanks @wido can you also squash them?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareCo...

[abhinandanprateek]

Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1729#discussion_r85901583
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContextPool.java ---
@@ -45,76 +43,74 @@ public VmwareContextPool() {
 this(DEFAULT_IDLE_QUEUE_LENGTH, DEFAULT_CHECK_INTERVAL);
 }
 
-public VmwareContextPool(int maxIdleQueueLength) {
-this(maxIdleQueueLength, DEFAULT_CHECK_INTERVAL);
-}
-
 public VmwareContextPool(int maxIdleQueueLength, long 
idleCheckIntervalMs) {
-_pool = new HashMap();
+_pool = new HashMap();
 
 _maxIdleQueueLength = maxIdleQueueLength;
 _idleCheckIntervalMs = idleCheckIntervalMs;
 
 _timer.scheduleAtFixedRate(getTimerTask(), _idleCheckIntervalMs, 
_idleCheckIntervalMs);
 }
 
-public void registerOutstandingContext(VmwareContext context) {
-assert (context != null);
-synchronized (this) {
-_outstandingRegistry.add(context);
-}
-}
-
-public void unregisterOutstandingContext(VmwareContext context) {
-assert (context != null);
-synchronized (this) {
-_outstandingRegistry.remove(context);
+public VmwareContext getContext(final String vCenterAddress, final 
String vCenterUserName) {
+final String poolKey = composePoolKey(vCenterAddress, 
vCenterUserName);
+if (Strings.isNullOrEmpty(poolKey)) {
+return null;
 }
-}
-
-public VmwareContext getContext(String vCenterAddress, String 
vCenterUserName) {
-String poolKey = composePoolKey(vCenterAddress, vCenterUserName);
 synchronized (this) {
-List l = _pool.get(poolKey);
-if (l == null)
-return null;
-
-if (l.size() > 0) {
-VmwareContext context = l.remove(0);
-context.setPoolInfo(this, poolKey);
-
-if (s_logger.isTraceEnabled())
-s_logger.trace("Return a VmwareContext from the idle 
pool: " + poolKey + ". current pool size: " + l.size() + ", outstanding count: 
" +
-VmwareContext.getOutstandingContextCount());
+final Queue ctxList = _pool.get(poolKey);
+if (ctxList != null && ctxList.size() > 0) {
+final VmwareContext context = ctxList.remove();
+if (context != null) {
+context.setPoolInfo(this, poolKey);
+}
+if (s_logger.isTraceEnabled()) {
+s_logger.trace("Return a VmwareContext from the idle 
pool: " + poolKey + ". current pool size: " + ctxList.size() + ", outstanding 
count: " +
+VmwareContext.getOutstandingContextCount());
+}
 return context;
 }
-
-// TODO, we need to control the maximum number of outstanding 
VmwareContext object in the future
 return null;
 }
 }
 
-public void returnContext(VmwareContext context) {
+public void registerContext(final VmwareContext context) {
 assert (context.getPool() == this);
 assert (context.getPoolKey() != null);
 synchronized (this) {
-List l = _pool.get(context.getPoolKey());
-if (l == null) {
-l = new ArrayList();
-_pool.put(context.getPoolKey(), l);
+Queue ctxList = _pool.get(context.getPoolKey());
+if (ctxList == null) {
+ctxList = EvictingQueue.create(_maxIdleQueueLength);
+_pool.put(context.getPoolKey(), ctxList);
 }
 
-if (l.size() < _maxIdleQueueLength) {
-context.clearStockObjects();
-l.add(context);
+if (ctxList.size() > _maxIdleQueueLength) {
+final VmwareContext oldestContext = ctxList.remove();
+if (oldestContext != null) {
+try {
+oldestContext.close();
+} catch (Throwable t) {
+s_logger.error("Unexpected exception caught while 
trying to purge oldest VmwareContext", t);
+}
--- End diff --

Although we are using a bounded queue now and that will prevent memory 
leaks, do we know why it should be throwing old elements -or- why the contexts 
are not cleaned up programmatically instead of forcefully restricting the size ?


---
If your project is set up for it, you can reply to this 

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-120


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1743
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-119


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1600
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1694
  
@murali-reddy @jburwell can we have lgtm/review on this, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1714: CLOUDSTACK-9553 Usage event is not getting recorded ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1714
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-127


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1746: SSVM downloader now handles redirects properly.

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1746
  
LGTM.
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1746: SSVM downloader now handles redirects properly.

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1746
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1746: SSVM downloader now handles redirects properly.

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1746
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-128


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1746: SSVM downloader now handles redirects properly.

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1746
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1746: SSVM downloader now handles redirects properly.

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1746
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...

[prashanthvarma]

Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1577
  
@jburwell @rhtyd Ok, we will rebase the PR, and let you know here. 
Moreover, we can re-run the added Marvin tests and share the results after the 
re-base.

Generally, we have two commits in a PR, one for dev and one for test 
(Marvin). 

Let me know, if you want us to do this in a different way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1745: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1745
  
@abhinandanprateek the Jenkins build failed.  Could you please investigate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1746: SSVM downloader now handles redirects properl...

[ProjectMoon]

GitHub user ProjectMoon opened a pull request:

https://github.com/apache/cloudstack/pull/1746

SSVM downloader now handles redirects properly.

New version of #1607, opened against 4.9 so it can be forward merged.

**Original Description**
Previously it was using the HttpClient to make an initial request to an 
ISO. This would follow redirects. Then it would make another request using 
built-in Java URL and InputStream, which doesn't follow redirects. This results 
in the ISO getting stuck at 0% forever and also causing DOS effects.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack 
pr-iso-follow-redirects-4.9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1746.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1746


commit 7a4220f17252d54a1b990c776d1378400652b0ab
Author: jeff 
Date:   2016-07-08T09:59:08Z

SSVM downloader now handles redirects properly.

Previously it was using the HttpClient to make an initial request
to an ISO. This would follow redirects. Then it would make
another request using built-in Java URL and InputStream, which
doesn't follow redirects. This results in the ISO getting stuck
at 0% forever and also causing DOS effects.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1673
  
The test results have some intermittent failures around VPC VR related 
tests. The PR does not break anything, LGTM on both tests and code review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1743
  
Thanks @ustcweizhou for the pointer. It was already fixed in fw_router, but 
not in fw_vpcrouter there.

How does this look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@jburwell and @rhtyd: Done, conflicts have been resolved!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

[nvazquez]

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1542
  
Thanks @jburwell! Rebased


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

[The-Loeki]

Github user The-Loeki commented on the issue:

https://github.com/apache/cloudstack/pull/1743
  
See https://bugzilla.redhat.com/show_bug.cgi?id=910619 for what's actually 
going on (and what actually should be going on) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...

[prashanthvarma]

Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/1577
  
@jburwell @rhtyd I have rebased this PR with latest master, and squashed 
the Marvin test commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1743
  
@wido maybe the guy who made the change forgot to add it in fw_vpcrouter.
In fw_router, it should be moved out from "if self.get_type() in 
["public"]", because the network type is 'guest' not 'public' for shared 
networks (in Basic zone or Advanced zone with SG)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1545
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1674
  
Tests LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1743: CLOUDSTACK-8326: Always fill UDP checksums in DHCP r...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1743
  
Good feedback @ustcweizhou, addressed that.

Thanks @The-Loeki for the report, this is indeed a upstream issue somewhere 
else, but if we can mitigate in the meantime that would be great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1732: Switched to the official SolidFire SDK for Java

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1732
  
The single failure is env related, we can ignore that. Given regression 
tests have all passed, LGTM on tests. Single all of the changes are related to 
vendor (solidfire) specific codebase/lib, LGTM on changes as well. Based on 
this, I'll move forward and merge this. Thanks Mike.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---