[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @jburwell That was default behavior for few years to allow deletion of the template even if active VMs exist. Deletion of the template on secondary doesn't remove the template copy on primary storage so all existing VM function work just fine. From my prospective if we allow forced deletion from the UI I am fine with switching default to forced=no and documenting it in Release Notes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar A part is still missing that will use forced option in UI but give a user option to cancel deletion if active VMs exist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar Well. API use cases can be recoded but not UI. Presently we can delete templates in UI even with active VMs. With your changes there will be no recourse. An easy option will be to add a checkbox 'Forced' into Delete template confirmation dialog. I am -1 until UI supports deletion of templates with active VMs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi @anshul1886 Can we tweak line 278 of test_snaphsot.py from self.services["nfs"], to self.services["nfs2"], and re-merge this PR so it doesn't conflict with other tests using "nfs" test data. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 @karuturi I agree with @nvazquez . This PR can be safely merged and then B.O. runtime environment needs to be adjusted to define nfs2 mountpoint in test_data.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @borisstoyanov @rhtyd Can we re-test this with B.O. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...
Github user serg38 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1958#discussion_r102753237
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -508,7 +507,7 @@ public String updateConfiguration(final long userId,
final String name, final St
throw new InvalidParameterValueException("unable to
find storage pool by id " + resourceId);
}
if(name.equals(CapacityManager.StorageOverprovisioningFactor.key())) {
-if(pool.getPoolType() !=
StoragePoolType.NetworkFilesystem && pool.getPoolType() !=
StoragePoolType.VMFS) {
+if(pool.getPoolType().supportsOverProvisioning() ) {
--- End diff --
I believe it should be negated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner Can you review latest updates from @nvazquez . Since tests are passing this PR will be ready for merging to 4.10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rhtyd @karuturi To fix errors in B.O in test_02_list_snapshots_with_removed_data_store we need to merge PR1961 and then adjust test_data on B.O side to have correct mapping for nfs2 label --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 Thanks @priyankparihar . We verified in our environment that all is working fine including UI part. LGTM I think this one is tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @rhtyd @borisstoyanov @DaanHoogland Can we get B.O. management server log to check why exception is generated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user serg38 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r103719599
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3614,6 +3604,26 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws InsufficientCap
});
}
+public void validateRootDiskResize(final HypervisorType
hypervisorType, Long rootDiskSize, VMTemplateVO templateVO, UserVmVO vm, final
Map customParameters) throws InvalidParameterValueException
+{
+// rootdisksize must be larger than template.
+if ((rootDiskSize << 30) < templateVO.getSize()) {
+Long templateVOSizeGB = templateVO.getSize() / 1024 / 1024 /
1024;
+s_logger.error("unsupported: rootdisksize override is smaller
than template size " + templateVO.getSize() + "B (" + templateVOSizeGB + "GB)");
+throw new InvalidParameterValueException("unsupported:
rootdisksize override is smaller than template size " + templateVO.getSize() +
"B (" + templateVOSizeGB + "GB)");
+} else if ((rootDiskSize << 30) > templateVO.getSize()){
+if (hypervisorType == HypervisorType.VMware &&
!vm.getDetails().get("rootDiskController").toLowerCase().contains("scsi")) {
+s_logger.error("Found unsupported root disk controller : "
+ vm.getDetails().get("rootDiskController"));
--- End diff --
I think NPE on line 3615 is due to rootdiskcontroller might be not set for
VM. If template is imported without explicitly specifying root disk controller
than a global setting will be in effect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1774 @borisstoyanov That would be awesome . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Can you kick off B.O for Vmware again? Hopefully it will pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 @rhtyd @borisstoyanov did you have a chance to add nfs2 test data in B.O. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1813
Still fails but error is different now
Exception: Job failed: {jobprocstatus : 0, created :
u'2017-03-03T09:20:53+', jobresult : {errorcode : 530, errortext : u'Unable
to start a VM due to insufficient capacity'}, cmd :
u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid :
u'83ba8c54-ffed-11e6-b1e4-067b8a010729', jobstatus : 2, jobid :
u'2d7de855-e6d8-4b06-83c4-c880e75c6fb1', jobresultcode : 530, jobinstanceid :
@borisstoyanov It would be awesome if we can get management server log
around the exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Thanks. Can you check in B.O. what is value of global configuration 'vmware.create.full.clone', if the same configuration is set for the primary storage pool and if so what is the value ? @priyankparihar Based on the exception it looks like B.O. Is set to use link clones but test doesn't handle it intended way. How about you temporary alter 'vmware.create.full.clone' to make it true for the PS pool used during the test and then revert it back to the original value. You can use similar to below to alter flag just for the PS pool: updateConfigurationCmd = updateConfiguration.updateConfigurationCmd() updateConfigurationCmd.name = "vmware.create.full.clone" updateConfigurationCmd.value = "true" updateConfigurationCmd.storageid = pool.id updateConfigurationResponse = self.apiClient.updateConfiguration(updateConfigurationCmd) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 LGTM tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1989 @abhinandanprateek I am curious if this PR will allow deploying VM with Data disk attached? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1879 LGTM @nvazquez Can we test it with shared networking? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1774 LGTM tag: mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in trans...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/793 @anshul1886 I am curious if there is a way to cancel stuck vmsnapshot jobs without restarting management server. E.g. VM deployment go to error start upon any failure in the process. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @mike-tutkowski @karuturi @koushik-das @rafaelweingartner Please review the fix for 4.10 blocker --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Should we simply replace storage_tag_view instead of switching queries over to another view? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Is storage_tag_view still in use after this change that reference old way of retrieving the tags? If not should we remove it? E.g. host tags don't have a separate view. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov @rhtyd Can you kick off new round of tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @rhtyd @borisstoyanov Can you kick off new tests for this release blocker? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r105409367 --- Diff: test/integration/component/test_rootvolume_resize.py --- @@ -0,0 +1,1140 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" P1 tests for testing resize of root volume functionality + +Test Plan: https://cwiki.apache.org/confluence/display/CLOUDSTACK/ +Root+Resize+Support + +Issue Link: https://issues.apache.org/jira/browse/CLOUDSTACK-9829 +""" +# Import Local Modules +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase, unittest +from marvin.lib.base import (Account, + ServiceOffering, + VirtualMachine, + Resources, + Domain, + Volume, + Snapshot, + Template, + VmSnapshot, + Host, + Configurations, + StoragePool) +from marvin.lib.common import (get_domain, + get_zone, + get_template, + matchResourceCount, + list_snapshots, + list_hosts, + list_configurations, + list_storage_pools) +from marvin.lib.utils import (cleanup_resources, + validateList) +from marvin.codes import (PASS, + FAIL, + FAILED, + RESOURCE_PRIMARY_STORAGE, + INVALID_INPUT) +from marvin.lib.utils import checkVolumeSize +import time +from marvin.sshClient import SshClient + + +class TestResizeVolume(cloudstackTestCase): +@classmethod +def setUpClass(cls): +cls.testClient = super(TestResizeVolume, cls).getClsTestClient() +cls.api_client = cls.testClient.getApiClient() +cls.hypervisor = (cls.testClient.getHypervisorInfo()).lower() +cls.storageID = None +# Fill services from the external config file +cls.services = cls.testClient.getParsedTestDataConfig() +# Get Zone, Domain and templates +cls.domain = get_domain(cls.api_client) +cls.zone = get_zone( +cls.api_client, +cls.testClient.getZoneForTests()) +cls.services["mode"] = cls.zone.networktype +cls._cleanup = [] +cls.unsupportedStorageType = False +cls.unsupportedHypervisorType = False +cls.updateclone = False +if cls.hypervisor not in ['xenserver',"kvm","vmware"]: +cls.unsupportedHypervisorType=True +return +cls.template = get_template( +cls.api_client, +cls.zone.id +) +cls.services["virtual_machine"]["zoneid"] = cls.zone.id +cls.services["virtual_machine"]["template"] = cls.template.id +cls.services["volume"]["zoneid"] = cls.zone.id +try: +cls.parent_domain = Domain.create(cls.api_client, + services=cls.services[ + "domain"], + parentdomainid=cls.domain.id) +cls.parentd_admin = Account.create(cls.api_client, + cls.services["account"], + admin=True, +
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar I think we need to improve smoke test test_deploy_vm_root_resize.py and introduce the logic you implemented in component test test_rootvolume_resize.py. We would want smoke test to be independent of testing environment and also not to skip tests for as much as we could and so for this test we can: 1. Make setting vmware.create.full.clone=true for the PS before resizing 2. Deploy VM with rootdiskcontroller=scsi 3. Support NFS the same way as VMFS Other than that everything else looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @mike-tutkowski Can you test this fix in your environment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @sadhugit NFS supports root disk resize with full clones. I don't see any restriction in the code and it actually works on Vmware no matter what kind of underlying storage technology is used for PS mapping to the hypervisor @priyankparihar @borisstoyanov vmware.create.full.clone is a ConfigKey with a scope of StoragePool so global setting may be overwritten on a particular storage pool. This info won't be available until the volume is tried to get created and resized. Root disk controller can be now extracted for each template ( part of details response as per PR 1767) and combined with global setting to make 'New Root disk size' box either grayed out or not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1257 @sureshanaparti I've been thinking if there is better way to re-sync all portgroups and I couldn't come up with easy alternative. With that said if we are copying portgroups for newly added host I propose to do the same for host returning from Maintenance (CancelMaintenance). It is very possible that host failed or was rebuild so it might not have all original portgroups and DRS will be failing for it as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1253 @sureshanaparti Why don't we just remove Config for this setting and leave default to be 8? Your logic to handle v4.1 will take care of old installations. As of May 2016 Vsphere 4.X is not longer supported so we technically shouldn't even worry about it. @rhtyd @karuturi At some point we should remove vSphere 4.1 from a list of supported hypervisors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in th...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2002 @sudhansu7 Shouldn't we update POD id upon a successful migration? If migration fails we will have wrong POD id in the DB. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user serg38 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r105932339
--- Diff: test/integration/smoke/test_deploy_vm_root_resize.py ---
@@ -114,7 +114,13 @@ def test_00_deploy_vm_root_resize(self):
# 2. root disk has new size per listVolumes
# 3. Rejects non-supported hypervisor types
"""
-if(self.hypervisor.lower() == 'kvm'):
+full_clone_config = Configurations.list(self.apiclient,
+name="vmware.create.full.clone")[0].value
+if full_clone_config == 'false' and self.hypervisor.lower() ==
'vmware':
+self.skipTest("root disk resize is not supported "+
+"when vmware.create.full.clone is %s" % full_clone_config)
+
--- End diff --
@priyankparihar @cloudsadhu test_rootvolume_resize.py test looks good. Can
we add exactly the same logic of adding full clone config for smoke test
test_deploy_vm_root_resize.py so that it is not skipped if a global setting is
to use link clones?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@nvazquez Looks like Travis cant SSH into management server during the test
.
2017-03-17 19:26:58,672 - DEBUG - mount -t nfs
nfs:/export/automation/1/testprimary
/mnt/marvin-1b4190cb-b9f5-4441-9bdc-bd89e9b7567b
2017-03-17 19:27:13,468 - CRITICAL - EXCEPTION:
test_03_migration_options_storage_tags: ['Traceback (most recent call
last):\n', ' File "/opt/python/2.7.12/lib/python2.7/unittest/case.py", line
329, in run\ntestMethod()\n', ' File
"/home/travis/.local/lib/python2.7/site-packages/marvin/lib/decoratorGenerators.py",
line 30, in test_wrapper\nreturn test(self, *args, **kwargs)\n', ' File
"/home/travis/build/apache/cloudstack/test/integration/smoke/test_primary_storage.py",
line 559, in test_03_migration_options_storage_tags\n
log_lvl=logging.INFO\n', ' File
"/home/travis/.local/lib/python2.7/site-packages/marvin/sshClient.py", line 81,
in __init__\nraise internalError("SSH Connection Failed")\n',
'internalError: SSH Connection Failed\n']
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2017: CLOUDSTACK-9847 vm_network_map is not getting cleane...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2017 @SudharmaJain Isn't it duplicate to PR1613 that is already merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2019 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @cloudsadhu Thanks for the changes. LGTM on the code review. @borisstoyanov @rhtyd @DaanHoogland Can you kick off another round of test for vmware and Xen for this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Can you also kick off vmware test in parallel? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r108580807 --- Diff: test/integration/smoke/test_deploy_vm_root_resize.py --- @@ -114,36 +134,46 @@ def test_00_deploy_vm_root_resize(self): # 2. root disk has new size per listVolumes # 3. Rejects non-supported hypervisor types """ -if(self.hypervisor.lower() == 'kvm'): -newrootsize = (self.template.size >> 30) + 2 -self.virtual_machine = VirtualMachine.create( -self.apiclient, -self.testdata["virtual_machine"], -accountid=self.account.name, -zoneid=self.zone.id, -domainid=self.account.domainid, -serviceofferingid=self.service_offering.id, -templateid=self.template.id, -rootdisksize=newrootsize + + +newrootsize = (self.template.size >> 30) + 2 +if(self.hypervisor.lower() == 'kvm' or self.hypervisor.lower() == +'xenserver'or self.hypervisor.lower() == 'vmware' ): + +if self.hypervisor=="vmware": +self.virtual_machine = VirtualMachine.create( +self.apiclient, self.services["virtual_machine"], +zoneid=self.zone.id, +accountid=self.account.name, +domainid=self.domain.id, +serviceofferingid=self.services_offering_vmware.id, +templateid=self.template.id +) + --- End diff -- B.O. tests are failing because for vmware you don't specify rootdisksize=newrootsize. You probably better to remove if-else entirely. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar Fortunately those API are already written. As per PR1767 you can get VM details including rootdiskcontroller using listVirtualMachines API and listTemplates. So if we are talking about resizing a root disk on existing VM we can obtain all the details upfront for 1. vmware.root.disk.controller global setting 2. vmware.root.disk.controller if it is set on VM level 3.vmware.create.full.clone global setting 4. vmware.create.full.clone if ti s set on the storage pool where root disk resides After that UI can make a determination if resizing should be allowed or not For the case of new VM deployment with variable root disk size all options above can be obtaine except #4 since storage pool will be determine only during volume allocation. I think for that case we just use items #1-3 to determine if we allow variable root disk size in UI or not (for #3 we obtain rootdiskcontroller setting if it is set on Template level) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in th...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2002 LGTM on the code review. @borisstoyanov @rhtyd Can you kick off tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Let's re-run vmware B.O test for this PR now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1836 @rhtyd @karuturi This is a new improvement introduced in PR1941 that allows volume and VM snapshots to coexist. Now, test test_01_test_vm_volume_snapshot in test_vm_snapshots.py needs to be reversed @Desc: Test that Volume snapshot for root volume is not allowed when VM snapshot is present for the VM @Steps: 1: Deploy a VM and create a VM snapshot for VM 2: Try to create snapshot for the root volume of the VM, It should expect Exception """ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2043: CLOUDSTACK-9876: Removed test test_01_test_vm_volume...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2043 LGTM on the code change. @borisstoyanov @rhtyd @DaanHoogland Can we re-kick vmware test for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @yvsubhash Please, take this up. So far this PR hasn't moved forward. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2044 @DaanHoogland Can you clarify few questions/concerns 1. This change will likely to break restoreVirtualMachine functions. At the very least users should be able to turn off new behavior with a global setting that will enable/disable such cleanup. 2. Does this affect a normal template cleanup that will delete both full and linked clone templates from PS when all VMs that use them are gone? 3. You introduce vmware.full.clone.template.cleanup.period as vmware specific setting. Is this only applicable to vmware? 4. Some changes are done to Vmware-Host-Scan task that seems to be unrelated to scope of this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2044 @DaanHoogland Thanks. But for #1 the requirement for the code changes is that the template is deleted from cloudstack. In this condition restoreVirtualMachines when template ID is not specified will use a local template copy on PS for either full or link clone. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2044 @DaanHoogland Not for us since we still use link clones but I am sure tons of other might be affected. Interestingly enough that with PR 1773 merged the default behavior in API is not to allow template deletion if there are active VMs and only if 'forced' flag is used it will be executed # c is an option already but I suggest one of the following #d introduce another global config with default value = false e.g. vmware.cleanup.fullclonedtemplate that would be a switch old/new behaviur in combination with storage.template.cleanup.enabled #e make 0 as a default value for vmware.full.clone.template.cleanup.period and when you interpret 0 it means that full clone cleanup thread thread never #e seems to be a good compromise that doesn't require too many changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-174554271 Unfortunately NFS version negotiation doesn't work properly with all storage vendors. Some vendors e.g. Tintri require that vers=3 is supplied in mount command likely due to the fact they don't support negotiations on the server side. When such NFS secondary storages tries to get mounted in SSVM an exception in mount is generated 'mount.nfs: Protocol family not supported' The same happens when trying to mount in shell so mount command needs to be told a specific version. If done so mount succeeds in both management server as well as in SSVM. Supporting nfs.version in image_store_details gives the best option to support great variety of NFS storage vendors without bluntly relying on version negotiation in nfs.mount. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-174746870 I believe the main reason is to provide the most of backward compatibility. image_store_details doesn't have NFS version in existing installations so after the upgrade to this code it will continue working without any additional changes. However if particular NFS secondary datastore requires explicit version users simply populate table and restart SSVM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-184799968 Hi committers, Can someone perform a second review and merge it at the earliest? We would like this to be part of 4.9? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-185256350 If requirements to use particular NFS version is known beforehand it can be specified during the image store creation using details argument details[0].key=nfs.version&details[0].value=3 e.g. api?command=addImageStore&response=json&name=test1&provider=NFS&zoneid=0d074f25-ed31-482f-8bc5-44c9314fc417&url=nfs%3A%2F%2F10.1.1.1%2Fnfs&details%5B0%5D.key=nfs.version&details%5B0%5D.value=3" Unfortunately updateImageStore is not yet implemented so for an existing image store it needs to be inserted to the table manaully. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-162319994 Since you are testing L3 connectivity existing switch patch to router shouldn't overlap an ip range used by the new subnet. Cidr #1 should work fine . You might also try disconnect existing switch from router to see if test passes. For test #4 we tested we lrouter patched over to l3 gateway without existing switch . For test# 3 you need to have l2 gateway to match the one specified for nvp device. The issue we observed was if any of the test fail for any reason the cleanup on nsx side doesn't work so a manual cleanup might require to remove existing router port left over from previous tests that has overlapping cidr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-162532791 This index comes from schema-40to410.sql: CREATE TABLE `cloud`.`nicira_nvp_router_map` ( `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id', `logicalrouter_uuid` varchar(255) NOT NULL UNIQUE COMMENT 'nicira uuid of logical router', `network_id` bigint unsigned NOT NULL UNIQUE COMMENT 'cloudstack id of the network', PRIMARY KEY (`id`), CONSTRAINT `fk_nicira_nvp_router_map__network_id` FOREIGN KEY (`network_id`) REFERENCES `networks`(`id`) ON DELETE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8; There might be variation how UNIQUE attribute is enforced in different versions of MySQL. In 5.5 it generate unique index `logicalrouter_uuid` To take it out the correct statement is ALTER TABLE `cloud`.`nicira_nvp_router_map` DROP INDEX `logicalrouter_uuid` ; Can you check if schema-40to410.sql got applied in your environment? What version of MySQL do you use? The drop index logicalrouter_uuid should come from schema-470to471.sql (or later upgrade script)but not from schema-410to420-cleanup.sql. From: Remi Bergsma Reply-To: apache/cloudstack Date: Sunday, December 6, 2015 at 11:59 AM To: apache/cloudstack Cc: Sergey Levitskiy Subject: Re: [cloudstack] CLOUDSTACK-9074: Support shared networking in NiciraNVP Plugin (#1094) Guys, I cannot build a cloud from this branch any more. The build itself works, but the database deployment gives an SQL error: Can't DROP 'logicalrouter_uuid'; check that column/key exists Details: [INFO] --- exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer --- log4j:WARN No appenders could be found for logger (org.springframework.core.env.StandardEnvironment). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. > WARNING: Provided file does not exist: /data/git/cs1/cloudstack/developer/../utils/conf/db.properties.override > WARNING: Provided file does not exist: /data/git/cs1/cloudstack/developer/developer-prefill.sql.override > Initializing database=cloud with host=localhost port=3306 username=cloud password=cloud > Running query: drop database if exists `cloud` > Running query: create database `cloud` > Running query: GRANT ALL ON cloud.* to 'cloud'@`localhost` identified by 'cloud' > Running query: GRANT ALL ON cloud.* to 'cloud'@`%` identified by 'cloud' > Initializing database=cloud_usage with host=localhost port=3306 username=cloud password=cloud > Running query: drop database if exists `cloud_usage` > Running query: create database `cloud_usage` > Running query: GRANT ALL ON cloud_usage.* to 'cloud'@`localhost` identified by 'cloud' > Running query: GRANT ALL ON cloud_usage.* to 'cloud'@`%` identified by 'cloud' > Processing SQL file at /data/git/cs1/cloudstack/developer/target/db/create-schema.sql > Processing SQL file at /data/git/cs1/cloudstack/developer/target/db/create-schema-premium.sql > Processing SQL file at /data/git/cs1/cloudstack/developer/target/db/templates.sql > Processing SQL file at /data/git/cs1/cloudstack/developer/developer-prefill.sql > Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker [WARNING] java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:297) at java.lang.Thread.run(Thread.java:745) Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to execute upgrade script: /data/git/cs1/cloudstack/developer/target/db/db/schema-410to420-cleanup.sql at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:290) at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:425) at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:474) at com.cloud.upgrade.DatabaseCreator.main(DatabaseCreator.java:217
[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-163684761 Assuming everything else is ready e.g. service controllers, transport zone, management server, STT tunnels in-between then to create L2 gateway (page 89 of the User guide): 1. Create new gateway transport node 1.1. Download and install either OVA or ISO for your hypervisor (available on Vmware site). You need at least 2 separate vSwitches. If tunneling traffic follows a different path, then 3 interface might be needed for the appliance 1.2 Login with admin/admin 1.3 Configure set hostname add network dns-server add network ntp-server 0.pool.ntp.org set network interface breth1 ip config static .it could be breth0 in some cases and in some cases more than one bridge add switch manager 1.4. Obtain gateway certificate show switch certificate 1.5 Add gateway node to NSX Transport Node->Add->Gateway->Display Name->Admin Status Enabled->Security Credentials - Certificate. Paste from section 1.4->Connection->Add->STT->IP of the bridge used for tunneling traffic 1.6. Create L2 Gateway Service and publish it on created Gateway transport node --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218466672 @swill Last Travis run for this PR was a success for test_list_ids_parameter. Which PR gives an issue? Marvin Init Successful === TestName: test_01_list_volumes | Status : SUCCESS === === TestName: test_02_list_templates | Status : SUCCESS === === TestName: test_03_list_snapshots | Status : SUCCESS === ===final results are now copied to: /tmp//MarvinLogs/test_list_ids_parameter_IPS7T4=== --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218480013 The issue that it couldn't find a snaphsot because it is already cleaned by account cleanup. +cls._cleanup = [ +cls.disk_offering, +cls.account, +cls.service_offering, +cls.snapshot_1, +cls.snapshot_2, +cls.snapshot_3 +] + Snapshot cleanup can be safely removed since account cleanup will remove them automatically. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218543261 @swill PR1539 passed Jenkins and Travis. After you merge it should resolve the issue in other PRs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8830 - [Vmware] VM snapshot fa...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/798#issuecomment-219067011 It would be nice if this is resolved. The issue still exists in 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-219154273 This doesn't seem to be related to this PR.Can you post managment-server.log extract around the failure time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219468957 @remibergsma In some private cloud environments nested virtualization is not a good fit so it is generally disabled. That's fine but we found that it would be very nice to have a way to support exceptions e.g. to support users to run Android emulators that as it turned out needs nested virtualization. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219473209 @remibergsma, @DaanHoogland Current global support for nested virtualization is only vmware specific and done in VmwareGuru. Are you proposing to move the logic up to the HypervisorGuru and change vmware.nested.virtualization to just nested.virtualization ? Then the implementation can be done in respective Resources. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220652018 @swill Travis passed. Looks like it is ready to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1593#discussion_r67618240 --- Diff: usage/conf/log4j-cloud_usage.xml.in --- @@ -48,7 +48,7 @@ under the License. - + --- End diff -- @jburwell. RPM Conflict resolution will create .rpmnew log4j config (at least in case of RHEL/Centos). Existing installations will not be affected and if needed the change has to be manually merged to active log4j config. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell If no sanity-check-last-id is present it will run Sanity on the whole cloud_usage data set and then create a new sanity-check-last-id file. The whole part of sanity checking related to sanity-check-last-id has been broken for a while since the part to update sanity-check-last-id wasn't in the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular VMware vms creation as ful...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. On Vmware using link cloned was a default behavior. The primary use cases are: - storage saving if underlying arrays don't support deduplication - speed of the deployment if underlying arrays don't leverage VAAI or vStorage API to speed up cloning of the base templates --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. The default behavior won't change. The proposed enhancement will add an ability to control link/full clone deployment of a primary storage level. If it is not defined there a current value of a global setting will be applied. A global configuration setting vmware.create.full.clone is already in ACS starting from version 4.2 if I am not mistaken. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. Absolutely it can although the effort seems to be well beyond and scope of this PR. @nvazquez and I have only access to vmware hypervisors at this point. If there is an interest to expand it let's open another PR focusing just on that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1615 Ping for second review -- @GabrielBrascher, @rhtyd, @wido, @rafaelweingartner --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 Ping for review -- @sateesh-chodapuneedi, @rhtyd, @koushik-das --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1542 @rafaelweingartner That's correct. At this point advanced VM details and advanced template details have no UI exposure. At some point we can bring in PR to show this in UI and allow API based changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1615 @jburwell Are there any outstanding issues with this PR? It is waiting for second LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 @rafaelweingartner @swill Will you be able to review this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @jburwell Are there any outstanding issues with this PR? It is waiting for second LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @karuturi @jburwell There are 2 LGTM in this PR. Packaging, Travis and Jenkins all passed. Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 @rafaelweingartner @jburwell @rhtyd @koushik-das Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1542 @jburwell @rhtyd @koushik-das Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell LGTM for the test part. This PR was extensively tested on Environment: RHEL 6 management servers, Vmware ESX5.5 and 6.0 with advanced networking --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1615 @jburwell Support for NFS version for Secondary storage is already merged via PR 1361. Since there were integration tests developed and executed over there we seem to be needed tests only for new API behavior. Do you agree? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1651 Debian returns: 1 packets transmitted, 1 packets received, 0% packet loss CentOs returns: 1 packets transmitted, 1 received, 0% packet loss, time 4ms Between those 2 we could be simply checking for 0% loss: check_string = ", 0% packet loss" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #:
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/commit/db854a35790c77099e9f82a4e2dd77edd5be3eed#commitcomment-18732552 Don't you need to put a space in from of 0 to exclude e.g 100% packet loss ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...
Github user serg38 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1605#discussion_r75796954
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2042,49 +2043,46 @@ protected void
postVideoCardMemoryConfigBeforeStart(VirtualMachineMO vmMo, Virtu
* Search for vm video card iterating through vm device list
* @param vmMo virtual machine mo
* @param svgaVmramSize new svga vram size (in KB)
+ * @param vmConfigSpec virtual machine config spec
*/
-private void setNewVRamSizeVmVideoCard(VirtualMachineMO vmMo, long
svgaVmramSize) throws Exception {
+protected void setNewVRamSizeVmVideoCard(VirtualMachineMO vmMo, long
svgaVmramSize, VirtualMachineConfigSpec vmConfigSpec) throws Exception {
for (VirtualDevice device : vmMo.getAllDeviceList()){
if (device instanceof VirtualMachineVideoCard){
VirtualMachineVideoCard videoCard =
(VirtualMachineVideoCard) device;
-modifyVmVideoCardVRamSize(videoCard, vmMo, svgaVmramSize);
+modifyVmVideoCardVRamSize(videoCard, vmMo, svgaVmramSize,
vmConfigSpec);
}
}
}
/**
- * Modifies vm vram size if it was set to a different size to the one
provided in svga.vramSize (user_vm_details or template_vm_details)
+ * Modifies vm vram size if it was set to a different size to the one
provided in svga.vramSize (user_vm_details or template_vm_details) on {@code
vmConfigSpec}
* @param videoCard vm's video card device
* @param vmMo virtual machine mo
* @param svgaVmramSize new svga vram size (in KB)
+ * @param vmConfigSpec virtual machine config spec
*/
-private void modifyVmVideoCardVRamSize(VirtualMachineVideoCard
videoCard, VirtualMachineMO vmMo, long svgaVmramSize) throws Exception {
+private void modifyVmVideoCardVRamSize(VirtualMachineVideoCard
videoCard, VirtualMachineMO vmMo, long svgaVmramSize, VirtualMachineConfigSpec
vmConfigSpec) throws Exception {
if (videoCard.getVideoRamSizeInKB().longValue() != svgaVmramSize){
s_logger.info("Video card memory was set " +
videoCard.getVideoRamSizeInKB().longValue() + "kb instead of " + svgaVmramSize
+ "kb");
-VirtualMachineConfigSpec newSizeSpecs =
configSpecVideoCardNewVRamSize(videoCard, svgaVmramSize);
-boolean res = vmMo.configureVm(newSizeSpecs);
-if (res) {
-s_logger.info("Video card memory successfully updated to "
+ svgaVmramSize + "kb");
-}
+configSpecVideoCardNewVRamSize(videoCard, svgaVmramSize,
vmConfigSpec);
}
}
/**
- * Returns a VirtualMachineConfigSpec to edit its svga vram size
+ * Add edit spec on {@code vmConfigSpec} to modify svga vram size
* @param videoCard video card device to edit providing the svga vram
size
* @param svgaVmramSize new svga vram size (in KB)
+ * @param vmConfigSpec virtual machine spec
*/
-private VirtualMachineConfigSpec
configSpecVideoCardNewVRamSize(VirtualMachineVideoCard videoCard, long
svgaVmramSize){
+private void configSpecVideoCardNewVRamSize(VirtualMachineVideoCard
videoCard, long svgaVmramSize, VirtualMachineConfigSpec vmConfigSpec){
videoCard.setVideoRamSizeInKB(svgaVmramSize);
videoCard.setUseAutoDetect(false);
VirtualDeviceConfigSpec arrayVideoCardConfigSpecs = new
VirtualDeviceConfigSpec();
arrayVideoCardConfigSpecs.setDevice(videoCard);
arrayVideoCardConfigSpecs.setOperation(VirtualDeviceConfigSpecOperation.EDIT);
-VirtualMachineConfigSpec changeVideoCardSpecs = new
VirtualMachineConfigSpec();
-
changeVideoCardSpecs.getDeviceChange().add(arrayVideoCardConfigSpecs);
-return changeVideoCardSpecs;
+vmConfigSpec.getDeviceChange().add(arrayVideoCardConfigSpecs);
--- End diff --
I don't think so. Device change done in the structure locally and
exception occurs during the VM reconfiguration on the hypervisor if anything
in the config is wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 @jburwell The support for passing vGPU parameters is already implemented via PR1310 which has a test case. This PR is only performance optimization by reducing an extra reconfgtask which save about 5 sec during VM startup. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1650 We tried macchinina template during test cases on ESX with E1000 adapter and VMs doesn't come with eth0 causing test_internal_lb.py and test_vpc_vpn.py to fail on a real hypervisor test. Has anyone actually tried it running on Vmware? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1656 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1657 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd Confirming. No issues on usage and management servers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Fix for test_network_acl,...
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1660
LGTM for the test.
Exception in network_acl_test **before the fix**
[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//NB313W/results.txt
Test network ACL lists and items in VPC ... === TestName: test_network_acl
| Status : EXCEPTION ===
ERROR
==
ERROR: Test network ACL lists and items in VPC
--
Traceback (most recent call last):
File
"/home/t_vazqnadmin/cloudstack/test/integration/smoke/exclude/test_network_acl.py",
line 81, in test_network_acl
domainid=self.domain.id
File "/usr/local/lib/python2.7/site-packages/marvin/lib/base.py", line
4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File
"/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py",
line 2210, in createVPC
response = self.connection.marvinRequest(command,
response_type=response, method=method)
File
"/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line
379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created :
u'2016-08-24T05:52:23-0700', jobresult : {errorcode : 530, errortext : u'Failed
to create VPC'}, cmd :
u'org.apache.cloudstack.api.command.admin.vpc.CreateVPCCmdByAdmin', userid :
u'd557133a-3fcc-11e5-9c45-005056ad45b7', jobstatus : 2, jobid :
u'bc8fb5de-94de-43bf-befd-a2b450ab571c', jobresultcode : 530, jobresulttype :
u'object', jobinstancetype : u'None', accountid :
u'd556f1dc-3fcc-11e5-9c45-005056ad45b7'}
>> begin captured stdout << -
=== TestName: test_network_acl | Status : EXCEPTION ===
- >> end captured stdout << --
. (NOT INCLUDED)
>> begin captured logging <<
- >> end captured logging << -
--
Ran 1 test in 115.185s
FAILED (errors=1)
**After fix is deployed:**
[root@ussarlabcsmgt41 Aug_23_2016_16_49_32_8HYYKG]# tail results.txt
Test network ACL lists and items in VPC ... === TestName: test_network_acl
| Status : SUCCESS ===
ok
--
Ran 1 test in 211.968s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Fix for test_network_acl,...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 Also we wrote a tester for SshHelper.sshExecute method. It was returning output of SSHexecute command as it gets received by sshExecute. Here they are 100 sequential runs (success if result is 100) : Before the fix: [root@ussarlabcsmgt41 t_vazqnadmin]# for i in `seq 1 100`;do curl "http://10.144.31.41:8096/client/api?command=testNicoSSHCommand&hostip=10.140.32.220&sshcommand=echo%20success"; 2>/dev/null|head -1|grep success;done|wc -l ## **58** [root@ussarlabcsmgt41 t_vazqnadmin]# for i in `seq 1 100`;do curl "http://10.144.31.41:8096/client/api?command=testNicoSSHCommand&hostip=10.140.32.220&sshcommand=pwd"; 2>/dev/null|head -1|grep '/root';done|wc -l ## **49** [root@ussarlabcsmgt41 t_vazqnadmin]# for i in `seq 1 100`;do curl "http://10.144.31.41:8096/client/api?command=testNicoSSHCommand&hostip=10.140.32.220&sshcommand=ls%20/proc/sys/net/ipv4/conf"; 2>/dev/null|grep eth;done|wc -l ## **0** After the fix: [root@ussarlabcsmgt41 t_vazqnadmin]# for i in `seq 1 100`;do curl "http://10.144.31.41:8096/client/api?command=testNicoSSHCommand&hostip=10.140.32.220&sshcommand=echo%20success"; 2>/dev/null|head -1|grep success;done|wc -l ## **100** [levitssadmin@ussclpdadubh001 ~]$ for i in `seq 1 100`;do curl "http://10.144.31.41:8096/client/api?command=testNicoSSHCommand&hostip=10.140.32.220&sshcommand=pwd"; 2>/dev/null|head -1|grep '/root';done|wc -l ## **100** [root@ussarlabcsmgt41 t_vazqnadmin]# for i in `seq 1 100`;do curl "http://10.144.31.41:8096/client/api?command=testNicoSSHCommand&hostip=10.140.32.220&sshcommand=ls%20/proc/sys/net/ipv4/conf"; 2>/dev/null|grep eth0;done|wc -l ## **100** --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 LGTM for testing. Vmware ESX 5.5 and 6.0 hypervisors, advanced networking, RHEL 6 management servers [root@ussarlabcsmgt41 ~]# cat /tmp//MarvinLogs/test_volumes_930LZ3/results.txt|grep -v ok test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS === test DeployVM in anti-affinity groups ... === TestName: test_DeployVmAntiAffinityGroup | Status : SUCCESS === Test Deploy Virtual Machine ... SKIP: Skipping test because suitable hypervisor/host notpresent Test Deploy Virtual Machine from ISO ... === TestName: test_deploy_vm_from_iso | Status : SUCCESS === Test deploy virtual machine with root resize ... === TestName: test_00_deploy_vm_root_resize | Status : SUCCESS === Test proper failure to deploy virtual machine with rootdisksize of 0 ... === TestName: test_01_deploy_vm_root_resize | Status : SUCCESS === Test proper failure to deploy virtual machine with rootdisksize less than template size ... === TestName: test_02_deploy_vm_root_resize | Status : SUCCESS === Test to deploy vm with a first fit offering ... === TestName: test_deployvm_firstfit | Status : SUCCESS === Test deploy VMs using user concentrated planner ... === TestName: test_deployvm_userconcentrated | Status : SUCCESS === Test deploy VMs using user dispersion planner ... === TestName: test_deployvm_userdispersing | Status : SUCCESS === Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | Status : SUCCESS === Test userdata as POST, size > 2k ... === TestName: test_deployvm_userdata_post | Status : SUCCESS === Test to create disk offering ... === TestName: test_01_create_disk_offering | Status : SUCCESS === Test to create a sparse type disk offering ... === TestName: test_02_create_sparse_type_disk_offering | Status : SUCCESS === Test to create a sparse type disk offering ... === TestName: test_04_create_fat_type_disk_offering | Status : SUCCESS === Test to update existing disk offering ... === TestName: test_02_edit_disk_offering | Status : SUCCESS === Test to delete disk offering ... === TestName: test_03_delete_disk_offering | Status : SUCCESS === Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to check role, role permissions and account life cycles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests that default four roles exist ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update when role is in use by an account ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests concurrent order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests creation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests listing of default role's permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test test update configuration setting at zone level scope ... === TestName: test_UpdateConfigParamWithScope | Status : SUCCESS === Test guest vlan range dedication ... === TestName: test_dedicateGuestVlanRange | Status : SUCCESS === Test create public & private ISO ... === TestName: test_01_create_iso | Status : SUCCESS === Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS === Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS === Test for extract ISO ... === TestName: test_04_extract_Iso | Status : SUCCESS === Update & Test for ISO permissions ... === TestName: test_05_iso_permissions | Status : SUCCESS === Test for copy ISO from one zone to another ... SKIP: Not enough zones available to perform copy template Test delete ISO ... === TestName: test_07_list_default_iso | Status : SUCCESS === Test listing Volumes using 'ids' parameter ... === TestName: test_01_list_volumes | Status : SUCCESS ===
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 LGTM with smoke testing. RHEL 6 management servers, advanced networking, Vmware 5.5 .and 6 hypervisors [root@ussarlabcsmgt41 smoke]# cat /tmp//MarvinLogs/test_volumes_340FH1/results.txt|grep -v ok test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS === test DeployVM in anti-affinity groups ... === TestName: test_DeployVmAntiAffinityGroup | Status : SUCCESS === Test Deploy Virtual Machine ... SKIP: Skipping test because suitable hypervisor/host notpresent Test Deploy Virtual Machine from ISO ... === TestName: test_deploy_vm_from_iso | Status : SUCCESS === Test deploy virtual machine with root resize ... === TestName: test_00_deploy_vm_root_resize | Status : SUCCESS === Test proper failure to deploy virtual machine with rootdisksize of 0 ... === TestName: test_01_deploy_vm_root_resize | Status : SUCCESS === Test proper failure to deploy virtual machine with rootdisksize less than template size ... === TestName: test_02_deploy_vm_root_resize | Status : SUCCESS === Test to deploy vm with a first fit offering ... === TestName: test_deployvm_firstfit | Status : SUCCESS === Test deploy VMs using user concentrated planner ... === TestName: test_deployvm_userconcentrated | Status : SUCCESS === Test deploy VMs using user dispersion planner ... === TestName: test_deployvm_userdispersing | Status : SUCCESS === Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | Status : SUCCESS === Test userdata as POST, size > 2k ... === TestName: test_deployvm_userdata_post | Status : SUCCESS === Test to create disk offering ... === TestName: test_01_create_disk_offering | Status : SUCCESS === Test to create a sparse type disk offering ... === TestName: test_02_create_sparse_type_disk_offering | Status : SUCCESS === Test to create a sparse type disk offering ... === TestName: test_04_create_fat_type_disk_offering | Status : SUCCESS === Test to update existing disk offering ... === TestName: test_02_edit_disk_offering | Status : SUCCESS === Test to delete disk offering ... === TestName: test_03_delete_disk_offering | Status : SUCCESS === Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to check role, role permissions and account life cycles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests that default four roles exist ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update when role is in use by an account ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests concurrent order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests creation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests listing of default role's permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test test update configuration setting at zone level scope ... === TestName: test_UpdateConfigParamWithScope | Status : SUCCESS === Test guest vlan range dedication ... === TestName: test_dedicateGuestVlanRange | Status : SUCCESS === Test create public & private ISO ... === TestName: test_01_create_iso | Status : SUCCESS === Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS === Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS === Test for extract ISO ... === TestName: test_04_extract_Iso | Status : SUCCESS === Update & Test for ISO permissions ... === TestName: test_05_iso_permissions | Status : SUCCESS === Test for copy ISO from one zone to another ... SKIP: Not enough zones available to perform copy template Test delete ISO ... === TestName: test_07_list_default_iso | Status : SUCCESS === Test listing Volumes using 'ids' parameter ... === TestName: test_01_list_volumes | Status :
[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1651
LGTM for testing
Before
sshClient: DEBUG: {Cmd: ping -c 3 8.8.8.8 via Host: 10.140.12.103}
{returns: [u'PING 8.8.8.8 (8.8.8.8) 56(84) bytes of data.', u'64 bytes from
8.8.8.8: icmp_seq=1 ttl=54 time=4.
72 ms', u'64 bytes from 8.8.8.8: icmp_seq=2 ttl=54 time=4.66 ms', u'64
bytes from 8.8.8.8: icmp_seq=3 ttl=54 time=4.61 ms', u'', u'--- 8.8.8.8 ping
statistics ---', u'3 packets transmitted, 3 received, 0% packet loss, time
2001ms', u'rtt min/avg/max/mdev = 4.611/4.666/4.723/0.091 ms']}
TestRouterDHCPHosts: DEBUG: SSH result: [u'PING 8.8.8.8 (8.8.8.8) 56(84)
bytes of data.', u'64 bytes from 8.8.8.8: icmp_seq=1 ttl=54 time=4.72 ms', u'64
bytes from 8.8.8.8: icmp_seq=2 ttl=54 time=4.66 ms', u'64 bytes from 8.8.8.8:
icmp_seq=3 ttl=54 time=4.61 ms', u'', u'--- 8.8.8.8 ping statistics ---', u'3
packets transmitted, 3 received, 0% packet loss, time 2001ms', u'rtt
min/avg/max/mdev = 4.611/4.666/4.723/0.091 ms']; COUNT is ==> 0
test_router_dhcphosts
(integration.smoke.test_router_dhcphosts.TestRouterDHCPHosts): CRITICAL:
FAILED: test_router_dhcphosts: ['Traceback (most recent call last):\n', ' File
"/usr/local/lib/python2.7/unittest/case.py", line 331, in run\n
testMethod()\n', ' File
"/home/t_vazqnadmin/cloudstack/test/integration/smoke/test_router_dhcphosts.py",
line 356, in test_router_dhcphosts\nself.test_ssh_command(self.vm_1,
nat_rule1, "natrule1")\n', ' File
"/home/t_vazqnadmin/cloudstack/test/integration/smoke/test_router_dhcphosts.py",
line 201, in test_ssh_command\n"Ping to outside world from VM should be
successful"\n', ' File "/usr/local/lib/python2.7/unittest/case.py", line 515,
in assertEqual\nassertion_func(first, second, msg=msg)\n', ' File
"/usr/local/lib/python2.7/unittest/case.py", line 508, in _baseAssertEqual\n
raise self.failureException(msg)\n', 'AssertionError: **## Ping to outside
world from VM should be successful**\n']
After
sshClient: DEBUG: Trying SSH Connection: Host:10.144.31.41 User:root
Port:22 RetryCnt:60===
paramiko.transport: DEBUG: starting thread (client mode): 0x4206310L
paramiko.transport: INFO: Connected (version 2.0, client OpenSSH_5.3)
paramiko.transport: DEBUG: kex
algos:[u'diffie-hellman-group-exchange-sha256',
u'diffie-hellman-group-exchange-sha1', u'diffie-hellman-group14-sha1',
u'diffie-hellman-group1-sha1'] server key:[u'ssh-rsa', u'ssh-dss'] client
encrypt:[u'aes128-ctr', u'aes192-ctr', u'aes256-ctr', u'arcfour256',
u'arcfour128', u'aes128-cbc', u'3des-cbc', u'blowfish-cbc', u'cast128-cbc',
u'aes192-cbc', u'aes256-cbc', u'arcfour', u'rijndael-...@lysator.liu.se']
server encrypt:[u'aes128-ctr', u'aes192-ctr', u'aes256-ctr', u'arcfour256',
u'arcfour128', u'aes128-cbc', u'3des-cbc', u'blowfish-cbc', u'cast128-cbc',
u'aes192-cbc', u'aes256-cbc', u'arcfour', u'rijndael-...@lysator.liu.se']
client mac:[u'hmac-md5', u'hmac-sha1', u'umac...@openssh.com',
u'hmac-sha2-256', u'hmac-sha2-512', u'hmac-ripemd160',
u'hmac-ripemd...@openssh.com', u'hmac-sha1-96', u'hmac-md5-96'] server
mac:[u'hmac-md5', u'hmac-sha1', u'umac...@openssh.com', u'hmac-sha2-256',
u'hmac-sha2-512', u'hmac-ripemd160', u'hmac-ripemd160@openssh.
com', u'hmac-sha1-96', u'hmac-md5-96'] client compress:[u'none',
u'z...@openssh.com'] server compress:[u'none', u'z...@openssh.com'] client
lang:[u''] server lang:[u''] kex follows?False
paramiko.transport: DEBUG: Ciphers agreed: local=aes128-ctr,
remote=aes128-ctr
paramiko.transport: DEBUG: using kex diffie-hellman-group14-sha1; server
key type ssh-rsa; cipher: local aes128-ctr, remote aes128-ctr; mac: local
hmac-sha1, remote hmac-sha1; compression: local none, remote none
paramiko.transport: DEBUG: Switch to new keys ...
paramiko.transport: DEBUG: Adding ssh-rsa host key for 10.144.31.41:
f662631595339bcea0d93948261bf655
paramiko.transport: DEBUG: Trying SSH agent key
9523f82115a1b2102b669b21e8a1084f
paramiko.transport: DEBUG: userauth is OK
paramiko.transport: INFO: Authentication (publickey) failed.
paramiko.transport: DEBUG: userauth is OK
paramiko.transport: INFO: Authentication (password) successful!
sshClient: DEBUG: ===SSH to Host 10.144.31.41 port : 22 SUCCESSFUL===
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 @jburwell With this PR test_network_acl is successfull [root@ussarlabcsmgt41 Aug_23_2016_16_49_32_8HYYKG]# tail results.txt Test network ACL lists and items in VPC ... === TestName: test_network_acl | Status : SUCCESS === ok Ran 1 test in 211.968s OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
