[CANCEL][VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Rob Tompkins 
This vote is cancelled. 

Many thanks for the eyes,
-Rob

> On Jul 25, 2018, at 8:38 PM, Rob Tompkins  wrote:
> 
> I’ll take the suggestions and get them into RC4.
> 
>> On Jul 25, 2018, at 8:56 AM, Rob Tompkins  wrote:
>> 
>> We have added some significant enhancements since Apache Commons RNG (full 
>> distribution) 1.0 was released, so I would like to release Apache Commons 
>> RNG (full distribution) 1.1.
>> 
>> Apache Commons RNG (full distribution) 1.1 RC3 is available for review here:
>>   https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3 (svn revision 
>> 28335, site added at 28336)
>> 
>> The Git tag RNG_1_1_RC3 commit for this RC is available for review here: 
>>   
>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_1_RC3
>> 
>> Maven artifacts are here:
>>   https://repository.apache.org/content/repositories/orgapachecommons-1357
>> 
>> These are the Maven artifacts and their hashes in Nexus:
>> 
>> #Nexus SHA-1s
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.pom
>> (SHA1: a3f7a09914ba4b7dfc2a28fec5d7a40f3f1ea962)
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-test-sources.jar
>> (SHA1: 9e8216ee90a537c5c884d7993f31a08571d37a65)
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-javadoc.jar
>> (SHA1: ceb66adfa6d665bbfdb9be1e7e28f9febf01214a)
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-tests.jar
>> (SHA1: e1430499f6fcf341f342fd9f9960daacd08c9635)
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.jar
>> (SHA1: 22ec28d4a80034502bcda89fa7f55f332269f874)
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-sources.jar
>> (SHA1: 2cf4cda85ee44cf0e17ce5a14cc176939613d79b)
>> /org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1.pom
>> (SHA1: 3f7ea1a87752477a10e62bdbf991acc86791b0a9)
>> /org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1-site.xml
>> (SHA1: 6e1df36b720e14eed524396107481e509ff42c7c)
>> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.jar
>> (SHA1: 004f4e3ba04b662c1ccbcbadad01f0a7dac4c6df)
>> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-sources.jar
>> (SHA1: d24f113fc5192d769be65b937356bd05d7fe59ef)
>> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-tests.jar
>> (SHA1: 5549762e88fd2505caeae712636066f956bc0465)
>> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-test-sources.jar
>> (SHA1: 641105db090f267b46b73d56b8741fff2805800b)
>> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.pom
>> (SHA1: 26ec84056b9a4526bc5e05ecf4ece8d9c3d57aad)
>> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-javadoc.jar
>> (SHA1: 75712250264765649948fa589beb3ac883e492d4)
>> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-javadoc.jar
>> (SHA1: 26046b6582982748cf912130c1b047b0fa0554ae)
>> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-sources.jar
>> (SHA1: 32b694cc43e9ae7e9f41a519c08b300a35cdbc95)
>> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-tests.jar
>> (SHA1: 03e5baff332fe16f8279d5800782af1cabcdf57d)
>> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1.jar
>> (SHA1: 4b9a38a5abf0118811a599472ffd06f666ddf7dd)
>> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-test-sources.jar
>> (SHA1: 2f71531f4aa2b590561e378dbd31d04dc467e3f7)
>> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1.pom
>> (SHA1: 04c2a060613758d5ca233f4bbc2b6fd947693207)
>> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-javadoc.jar
>> (SHA1: 863a507e373ee5c6c9d3bcc64fe950562a044cd1)
>> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-sources.jar
>> (SHA1: 296007f2657ae0d162f45da84a727ba967a691f7)
>> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1.pom
>> (SHA1: 6af16fa13e06fbba809d64803fae689bd40e2679)
>> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-tests.jar
>> (SHA1: 6fb83e23389388133bc4840f9feb9412800567fe)
>> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-test-sources.jar
>> (SHA1: c8ebe6da223727039e41938765533b60ac1e5308)
>> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1.jar
>> (SHA1: 12c795044794f698c9d14c5df66e7cc3a0743c05)
>> /org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1.jar
>> (SHA1: 7d2b707dfb680393de55ea79f1a781a3c604bdb6)
>> /org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1-javadoc.jar
>> (SHA1: 885cfe9f3d90b3d6210b4b2880973605f60ad807)

Re: [CANCEL][VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Gary Gregory 
On Wed, Jul 25, 2018 at 6:38 PM Rob Tompkins  wrote:

> I’ll take the suggestions and get them into RC4.
>

OK, cool. Don't forget to [CANCEL] this vote ;-)

Gary

>
> > On Jul 25, 2018, at 8:56 AM, Rob Tompkins  wrote:
> >
> > We have added some significant enhancements since Apache Commons RNG
> (full distribution) 1.0 was released, so I would like to release Apache
> Commons RNG (full distribution) 1.1.
> >
> > Apache Commons RNG (full distribution) 1.1 RC3 is available for review
> here:
> >https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3 (svn
> revision 28335, site added at 28336)
> >
> > The Git tag RNG_1_1_RC3 commit for this RC is available for review here:
> >
> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_1_RC3
> >
> > Maven artifacts are here:
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1357
> >
> > These are the Maven artifacts and their hashes in Nexus:
> >
> > #Nexus SHA-1s
> > /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.pom
> > (SHA1: a3f7a09914ba4b7dfc2a28fec5d7a40f3f1ea962)
> >
> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-test-sources.jar
> > (SHA1: 9e8216ee90a537c5c884d7993f31a08571d37a65)
> >
> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-javadoc.jar
> > (SHA1: ceb66adfa6d665bbfdb9be1e7e28f9febf01214a)
> >
> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-tests.jar
> > (SHA1: e1430499f6fcf341f342fd9f9960daacd08c9635)
> > /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.jar
> > (SHA1: 22ec28d4a80034502bcda89fa7f55f332269f874)
> >
> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-sources.jar
> > (SHA1: 2cf4cda85ee44cf0e17ce5a14cc176939613d79b)
> > /org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1.pom
> > (SHA1: 3f7ea1a87752477a10e62bdbf991acc86791b0a9)
> >
> /org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1-site.xml
> > (SHA1: 6e1df36b720e14eed524396107481e509ff42c7c)
> >
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.jar
> > (SHA1: 004f4e3ba04b662c1ccbcbadad01f0a7dac4c6df)
> >
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-sources.jar
> > (SHA1: d24f113fc5192d769be65b937356bd05d7fe59ef)
> >
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-tests.jar
> > (SHA1: 5549762e88fd2505caeae712636066f956bc0465)
> >
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-test-sources.jar
> > (SHA1: 641105db090f267b46b73d56b8741fff2805800b)
> >
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.pom
> > (SHA1: 26ec84056b9a4526bc5e05ecf4ece8d9c3d57aad)
> >
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-javadoc.jar
> > (SHA1: 75712250264765649948fa589beb3ac883e492d4)
> >
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-javadoc.jar
> > (SHA1: 26046b6582982748cf912130c1b047b0fa0554ae)
> >
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-sources.jar
> > (SHA1: 32b694cc43e9ae7e9f41a519c08b300a35cdbc95)
> >
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-tests.jar
> > (SHA1: 03e5baff332fe16f8279d5800782af1cabcdf57d)
> >
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1.jar
> > (SHA1: 4b9a38a5abf0118811a599472ffd06f666ddf7dd)
> >
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-test-sources.jar
> > (SHA1: 2f71531f4aa2b590561e378dbd31d04dc467e3f7)
> >
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1.pom
> > (SHA1: 04c2a060613758d5ca233f4bbc2b6fd947693207)
> >
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-javadoc.jar
> > (SHA1: 863a507e373ee5c6c9d3bcc64fe950562a044cd1)
> >
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-sources.jar
> > (SHA1: 296007f2657ae0d162f45da84a727ba967a691f7)
> >
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1.pom
> > (SHA1: 6af16fa13e06fbba809d64803fae689bd40e2679)
> >
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-tests.jar
> > (SHA1: 6fb83e23389388133bc4840f9feb9412800567fe)
> >
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-test-sources.jar
> > (SHA1: c8ebe6da223727039e41938765533b60ac1e5308)
> >
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1.jar
> > (SHA1: 12c795044794f698c9d14c5df66e7cc3a0743c05)
> >
> /org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1.jar
> > (SHA1: 7d2b707dfb680393de55ea79f1a781a3c604bdb6)
> >
>

Re: commons-rng git commit: accommodate for up to 4 re-runs of a failing test

2018-07-25 Thread Gilles 

Hello Rob.

On Thu, 26 Jul 2018 01:44:59 + (UTC), chtom...@apache.org wrote:

[...]



http://git-wip-us.apache.org/repos/asf/commons-rng/blob/1eb7ea49/commons-rng-sampling/pom.xml

--
diff --git a/commons-rng-sampling/pom.xml 
b/commons-rng-sampling/pom.xml

index bd1fb0d..6d0a80a 100644
--- a/commons-rng-sampling/pom.xml
+++ b/commons-rng-sampling/pom.xml
@@ -66,4 +66,16 @@
 
   

+  
+
+  
+maven-surefire-plugin
+2.22.0
+
+  4
+
+  
+
+  
+
 


Nice! [IIUC the number of "flakes" is per test, so allowing 2
is already good as it's unlikely that the same sampler will
fail twice in a row.]

Thanks for thinking about it and finding the workaround.

Regards,
Gilles



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [rng] Tests in -sampling

2018-07-25 Thread Gilles 

On Wed, 25 Jul 2018 21:08:57 -0400, Rob Tompkins wrote:
On Jul 24, 2018, at 9:13 PM, Rob Tompkins  
wrote:




On Jul 24, 2018, at 7:04 PM, Gilles  
wrote:


Hi Rob.

On Tue, 24 Jul 2018 18:33:40 -0400, Rob Tompkins wrote:
I know that the tests will be necessarily non-deterministic, but 
we
can at least get closer to having determinism by running the same 
test
1000 times and expecting some reasonable number of passes right? 
Could

we use the underlying distribution that we are testing to sort out
this value?


This *is* what the test is doing, although it repeats 50 times
(takes quite some time already) instead of 1000.
As I've reported on this list, it is quite possible that the
failure probabilities are underestimated; (first) review welcome:
the tests are fairly well documented as to what they are doing
but I might have committed some bugs wrt the statistics involved.


Once I get the release out, I’ll have a look.


So the curiosity here is a standard probability problem. It seems
that we have N tests each with some probability of failing P_N. For
some arbitrary test T, P_T is fairly inconsequential, but when
aggregated together with in with P_1, P_2, … , P_{T-1}, P_{T}, …., 
P_N

the probability of failure of test approaches something between 10%
and 50% which is indeed consequential.


If p is the probability that the test will fail, 1-p is
the probability that it'll succeed. The probability that
all N tests succeed is (1-p)^N.

Example from empirical runs: Overall failure is ~25% (3/12 as
per previous post); there ~35 such tests, thus p is ~1%.
We'd have to look for how to reduce this latter value.

Gilles


I’m going to have to think
about this some. If I recall correctly, we could use the central 
limit

theorem here about overall test failure, right? Could we apply the
same characteristic to the over all number of tests in the project? I
don’t think we can avoid it. Does surefire accommodate a percentage 
of

test failures for passing the build?

-Rob



Cheers,
-Rob



Regards,
Gilles



-Rob



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [rng] Tests in -sampling

2018-07-25 Thread Rob Tompkins 



> On Jul 24, 2018, at 9:13 PM, Rob Tompkins  wrote:
> 
> 
> 
>> On Jul 24, 2018, at 7:04 PM, Gilles  wrote:
>> 
>> Hi Rob.
>> 
>> On Tue, 24 Jul 2018 18:33:40 -0400, Rob Tompkins wrote:
>>> I know that the tests will be necessarily non-deterministic, but we
>>> can at least get closer to having determinism by running the same test
>>> 1000 times and expecting some reasonable number of passes right? Could
>>> we use the underlying distribution that we are testing to sort out
>>> this value?
>> 
>> This *is* what the test is doing, although it repeats 50 times
>> (takes quite some time already) instead of 1000.
>> As I've reported on this list, it is quite possible that the
>> failure probabilities are underestimated; (first) review welcome:
>> the tests are fairly well documented as to what they are doing
>> but I might have committed some bugs wrt the statistics involved.
> 
> Once I get the release out, I’ll have a look.

So the curiosity here is a standard probability problem. It seems that we have 
N tests each with some probability of failing P_N. For some arbitrary test T, 
P_T is fairly inconsequential, but when aggregated together with in with P_1, 
P_2, … , P_{T-1}, P_{T}, …., P_N the probability of failure of test approaches 
something between 10% and 50% which is indeed consequential. I’m going to have 
to think about this some. If I recall correctly, we could use the central limit 
theorem here about overall test failure, right? Could we apply the same 
characteristic to the over all number of tests in the project? I don’t think we 
can avoid it. Does surefire accommodate a percentage of test failures for 
passing the build?

-Rob

> 
> Cheers,
> -Rob
> 
>> 
>> Regards,
>> Gilles
>> 
>>> 
>>> -Rob
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[CANCEL][VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Rob Tompkins 
I’ll take the suggestions and get them into RC4.

> On Jul 25, 2018, at 8:56 AM, Rob Tompkins  wrote:
> 
> We have added some significant enhancements since Apache Commons RNG (full 
> distribution) 1.0 was released, so I would like to release Apache Commons RNG 
> (full distribution) 1.1.
> 
> Apache Commons RNG (full distribution) 1.1 RC3 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3 (svn revision 
> 28335, site added at 28336)
> 
> The Git tag RNG_1_1_RC3 commit for this RC is available for review here: 
>
> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_1_RC3
> 
> Maven artifacts are here:
>https://repository.apache.org/content/repositories/orgapachecommons-1357
> 
> These are the Maven artifacts and their hashes in Nexus:
> 
> #Nexus SHA-1s
> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.pom
> (SHA1: a3f7a09914ba4b7dfc2a28fec5d7a40f3f1ea962)
> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-test-sources.jar
> (SHA1: 9e8216ee90a537c5c884d7993f31a08571d37a65)
> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-javadoc.jar
> (SHA1: ceb66adfa6d665bbfdb9be1e7e28f9febf01214a)
> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-tests.jar
> (SHA1: e1430499f6fcf341f342fd9f9960daacd08c9635)
> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.jar
> (SHA1: 22ec28d4a80034502bcda89fa7f55f332269f874)
> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-sources.jar
> (SHA1: 2cf4cda85ee44cf0e17ce5a14cc176939613d79b)
> /org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1.pom
> (SHA1: 3f7ea1a87752477a10e62bdbf991acc86791b0a9)
> /org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1-site.xml
> (SHA1: 6e1df36b720e14eed524396107481e509ff42c7c)
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.jar
> (SHA1: 004f4e3ba04b662c1ccbcbadad01f0a7dac4c6df)
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-sources.jar
> (SHA1: d24f113fc5192d769be65b937356bd05d7fe59ef)
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-tests.jar
> (SHA1: 5549762e88fd2505caeae712636066f956bc0465)
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-test-sources.jar
> (SHA1: 641105db090f267b46b73d56b8741fff2805800b)
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.pom
> (SHA1: 26ec84056b9a4526bc5e05ecf4ece8d9c3d57aad)
> /org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-javadoc.jar
> (SHA1: 75712250264765649948fa589beb3ac883e492d4)
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-javadoc.jar
> (SHA1: 26046b6582982748cf912130c1b047b0fa0554ae)
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-sources.jar
> (SHA1: 32b694cc43e9ae7e9f41a519c08b300a35cdbc95)
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-tests.jar
> (SHA1: 03e5baff332fe16f8279d5800782af1cabcdf57d)
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1.jar
> (SHA1: 4b9a38a5abf0118811a599472ffd06f666ddf7dd)
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-test-sources.jar
> (SHA1: 2f71531f4aa2b590561e378dbd31d04dc467e3f7)
> /org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1.pom
> (SHA1: 04c2a060613758d5ca233f4bbc2b6fd947693207)
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-javadoc.jar
> (SHA1: 863a507e373ee5c6c9d3bcc64fe950562a044cd1)
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-sources.jar
> (SHA1: 296007f2657ae0d162f45da84a727ba967a691f7)
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1.pom
> (SHA1: 6af16fa13e06fbba809d64803fae689bd40e2679)
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-tests.jar
> (SHA1: 6fb83e23389388133bc4840f9feb9412800567fe)
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-test-sources.jar
> (SHA1: c8ebe6da223727039e41938765533b60ac1e5308)
> /org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1.jar
> (SHA1: 12c795044794f698c9d14c5df66e7cc3a0743c05)
> /org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1.jar
> (SHA1: 7d2b707dfb680393de55ea79f1a781a3c604bdb6)
> /org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1-javadoc.jar
> (SHA1: 885cfe9f3d90b3d6210b4b2880973605f60ad807)
> /org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1.pom
> (SHA1: cd4b2d45949778e8fbee15eda94faac1d0a4b460)
>

Re: [configuration] Release with Java 7 compatibility

2018-07-25 Thread Gary Gregory 
Go for it.

Gary

On Wed, Jul 25, 2018, 14:27 Oliver Heger 
wrote:

> Hi,
>
> the current codebase for [configuration] has been updated to require
> Java 8. However, no Java 8 feature is used so far.
>
> I would therefore like to go back to Java 7 and get a release out.
> Afterwards we can switch to Java 8.
>
> Thoughts?
> Oliver
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: commons-dbcp git commit: [DBCP-517] Make defensive copies of char[] passwords.

2018-07-25 Thread Gary Gregory 
I'd we do not already have that, the name does not need "defensive".
Commons Collections would be where to put collections related code.

Gary

On Wed, Jul 25, 2018, 14:00 Oliver Heger 
wrote:

> +1, Thank you.
>
> I had planned to create a patch for this issue, but did not find the
> time so far.
>
> BTW, I have quite often the need to create defensive copies of arrays or
> collections in some variants (e.g. null safe, with wrapping to an
> unmodifiable collection, etc.). Could this be an addition to [lang]? A
> new utility class like DefensiveCopyUtils?
>
> Oliver
>
> Am 25.07.2018 um 00:34 schrieb ggreg...@apache.org:
> > Repository: commons-dbcp
> > Updated Branches:
> >   refs/heads/master 70822f11d -> d7969ac93
> >
> >
> > [DBCP-517] Make defensive copies of char[] passwords.
> >
> > Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/d7969ac9
> > Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/d7969ac9
> > Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/d7969ac9
> >
> > Branch: refs/heads/master
> > Commit: d7969ac934e752e7a7b258fa5a5af9a563c40a13
> > Parents: 70822f1
> > Author: Gary Gregory 
> > Authored: Tue Jul 24 16:34:43 2018 -0600
> > Committer: Gary Gregory 
> > Committed: Tue Jul 24 16:34:43 2018 -0600
> >
> > --
> >  src/changes/changes.xml |  5 -
> >  src/main/java/org/apache/commons/dbcp2/Utils.java   | 12
> 
> >  .../commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java|  4 ++--
> >  .../dbcp2/datasources/CPDSConnectionFactory.java| 11 ++-
> >  .../dbcp2/cpdsadapter/TestDriverAdapterCPDS.java|  9 +
> >  .../dbcp2/datasources/TestCPDSConnectionFactory.java| 10 ++
> >  6 files changed, 47 insertions(+), 4 deletions(-)
> > --
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/d7969ac9/src/changes/changes.xml
> > --
> > diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> > index c924411..8f1de55 100644
> > --- a/src/changes/changes.xml
> > +++ b/src/changes/changes.xml
> > @@ -61,9 +61,12 @@ The  type attribute can be
> add,update,fix,remove.
> >
> >
> >  
> > -  
> > +  
> >  Allow DBCP to register with a
> TransactionSynchronizationRegistry for XA cases.
> >
> > +   due-to="Gary Gregory">
> > +Make defensive copies of char[] passwords.
> > +  
> >  
> >  
> > due-to="Gary Gregory">
> >
> >
> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/d7969ac9/src/main/java/org/apache/commons/dbcp2/Utils.java
> > --
> > diff --git a/src/main/java/org/apache/commons/dbcp2/Utils.java
> b/src/main/java/org/apache/commons/dbcp2/Utils.java
> > index 8e798c4..244b51b 100644
> > --- a/src/main/java/org/apache/commons/dbcp2/Utils.java
> > +++ b/src/main/java/org/apache/commons/dbcp2/Utils.java
> > @@ -72,6 +72,17 @@ public final class Utils {
> >  }
> >
> >  /**
> > + * Clones the given char[] if not null.
> > + *
> > + * @param value
> > + *may be null.
> > + * @return a cloned char[] or null.
> > + */
> > +public static char[] clone(final char[] value) {
> > +return value == null ? null : value.clone();
> > +}
> > +
> > +/**
> >   * Closes the ResultSet (which may be null).
> >   *
> >   * @param resultSet
> > @@ -169,4 +180,5 @@ public final class Utils {
> >  public static String toString(final char[] value) {
> >  return value == null ? null : String.valueOf(value);
> >  }
> > +
> >  }
> >
> >
> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/d7969ac9/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java
> > --
> > diff --git
> a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java
> b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java
> > index bbc8831..0844c9b 100644
> > ---
> a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java
> > +++
> b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java
> > @@ -423,8 +423,8 @@ public class DriverAdapterCPDS implements
> ConnectionPoolDataSource, Referenceabl
> >   */
> >  public void setPassword(final char[] userPassword) {
> >  assertInitializationAllowed();
> > -this.userPassword = userPassword;
> > -update(connectionProperties, KEY_PASSWORD,
> Utils.toString(userPassword));
> > +this.userPassword = Utils.clone(userPassword);
> > +update(connectionProperties,

[configuration] Release with Java 7 compatibility

2018-07-25 Thread Oliver Heger 
Hi,

the current codebase for [configuration] has been updated to require
Java 8. However, no Java 8 feature is used so far.

I would therefore like to go back to Java 7 and get a release out.
Afterwards we can switch to Java 8.

Thoughts?
Oliver

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: commons-dbcp git commit: [DBCP-517] Make defensive copies of char[] passwords.

2018-07-25 Thread Oliver Heger 
+1, Thank you.

I had planned to create a patch for this issue, but did not find the
time so far.

BTW, I have quite often the need to create defensive copies of arrays or
collections in some variants (e.g. null safe, with wrapping to an
unmodifiable collection, etc.). Could this be an addition to [lang]? A
new utility class like DefensiveCopyUtils?

Oliver

Am 25.07.2018 um 00:34 schrieb ggreg...@apache.org:
> Repository: commons-dbcp
> Updated Branches:
>   refs/heads/master 70822f11d -> d7969ac93
> 
> 
> [DBCP-517] Make defensive copies of char[] passwords.
> 
> Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/d7969ac9
> Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/d7969ac9
> Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/d7969ac9
> 
> Branch: refs/heads/master
> Commit: d7969ac934e752e7a7b258fa5a5af9a563c40a13
> Parents: 70822f1
> Author: Gary Gregory 
> Authored: Tue Jul 24 16:34:43 2018 -0600
> Committer: Gary Gregory 
> Committed: Tue Jul 24 16:34:43 2018 -0600
> 
> --
>  src/changes/changes.xml |  5 -
>  src/main/java/org/apache/commons/dbcp2/Utils.java   | 12 
>  .../commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java|  4 ++--
>  .../dbcp2/datasources/CPDSConnectionFactory.java| 11 ++-
>  .../dbcp2/cpdsadapter/TestDriverAdapterCPDS.java|  9 +
>  .../dbcp2/datasources/TestCPDSConnectionFactory.java| 10 ++
>  6 files changed, 47 insertions(+), 4 deletions(-)
> --
> 
> 
> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/d7969ac9/src/changes/changes.xml
> --
> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> index c924411..8f1de55 100644
> --- a/src/changes/changes.xml
> +++ b/src/changes/changes.xml
> @@ -61,9 +61,12 @@ The  type attribute can be add,update,fix,remove.
>  
>
>  
> -  
> +  
>  Allow DBCP to register with a TransactionSynchronizationRegistry for 
> XA cases.
>
> +  
> +Make defensive copies of char[] passwords.
> +  
>  
>  
>
> 
> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/d7969ac9/src/main/java/org/apache/commons/dbcp2/Utils.java
> --
> diff --git a/src/main/java/org/apache/commons/dbcp2/Utils.java 
> b/src/main/java/org/apache/commons/dbcp2/Utils.java
> index 8e798c4..244b51b 100644
> --- a/src/main/java/org/apache/commons/dbcp2/Utils.java
> +++ b/src/main/java/org/apache/commons/dbcp2/Utils.java
> @@ -72,6 +72,17 @@ public final class Utils {
>  }
>  
>  /**
> + * Clones the given char[] if not null.
> + *
> + * @param value
> + *may be null.
> + * @return a cloned char[] or null.
> + */
> +public static char[] clone(final char[] value) {
> +return value == null ? null : value.clone();
> +}
> +
> +/**
>   * Closes the ResultSet (which may be null).
>   *
>   * @param resultSet
> @@ -169,4 +180,5 @@ public final class Utils {
>  public static String toString(final char[] value) {
>  return value == null ? null : String.valueOf(value);
>  }
> +
>  }
> 
> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/d7969ac9/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java
> --
> diff --git 
> a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java 
> b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java
> index bbc8831..0844c9b 100644
> --- 
> a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java
> +++ 
> b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java
> @@ -423,8 +423,8 @@ public class DriverAdapterCPDS implements 
> ConnectionPoolDataSource, Referenceabl
>   */
>  public void setPassword(final char[] userPassword) {
>  assertInitializationAllowed();
> -this.userPassword = userPassword;
> -update(connectionProperties, KEY_PASSWORD, 
> Utils.toString(userPassword));
> +this.userPassword = Utils.clone(userPassword);
> +update(connectionProperties, KEY_PASSWORD, 
> Utils.toString(this.userPassword));
>  }
>  
>  /**
> 
> http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/d7969ac9/src/main/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java
> --
> diff --git 
> a/src/main/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java
>  
>

Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Gilles 

Hi.

On Wed, 25 Jul 2018 11:52:31 -0400, Rob Tompkins wrote:

Thanks. Quite reasonable. I’m going to let @Gilles have a look and
then will likely re-roll with better docs on the way the tests work.
Thanks for the eyes.

@Gilles - any thoughts or help on getting things buttoned up would be
appreciated at this point.


With all this top-posting[1] and delayed mail delivery, I don't
know which follow-ups you've read before asking.

The non-deterministic failures will always be there (perhaps
less frequent if the correct threshold is 4 -- cf. previous
post).
See e.g. the 3rd column of the table here:
  
http://commons.apache.org/proper/commons-rng/userguide/rng.html#a5._Quality

If those were implemented in Java and not so time-consuming,
they would be unit tests; the ideal value is 0 (no failure)
but for some weaker RNGs, the expected value is higher; it
is however *not* constant.
Whether the varying number of unit test failures ("3 out
of 50 tests failed") is of the same origin is what needs
be assessed (at some point) but it's not something that
should prevent a release: I'd expect a buggy *code* to
produce the inverted ratio (something rather like "47 out
of 50 tests failed").

In a sequence of 12 consecutive "mvn test" just performed,
the build failed 3 times.  IMHO, it is acceptable for a once
a year release (and definitely not the most time consuming
part of this release).  However if this annoyance is deemed
unbearable for the RM and the reviewers, I'd suggest setting
the relevant unit tests to @Ignore (in the release branch).

Regards,
Gilles

[1] A plague that's unfortunately spreading.



Cheers,
-Rob

On Jul 25, 2018, at 10:56 AM, Gary Gregory  
wrote:


-0:

- Don't forget to set the date in

https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/changes-report.html
and changes.xml, I try to remember to do this in an RC, not after.
- When I've recently emailed an announcement for a release, the 
email
bounced because I did not have a link to the download page. So I 
added that

to the RELEASE NOTES file which is what I use as the content of the
announcement email.
- There is no Jacoco report, it is empty:

https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/jacoco-aggregate/index.html
-

https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/rat-report.html:
It is OK to include old release notes IMO, it shows history in one 
place.

In fact, I keep all RNs in the one file.

From src zip: ASC, SHA1, SHA256 all OK.

Running 'mvn clean package' I get:

[INFO] Running

org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time 
elapsed:

6.799 s - in

org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
[INFO] Running org.apache.commons.rng.sampling.ListSamplerTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time 
elapsed:

0.008 s - in org.apache.commons.rng.sampling.ListSamplerTest
[INFO] Running 
org.apache.commons.rng.sampling.PermutationSamplerTest
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time 
elapsed:

0.002 s - in org.apache.commons.rng.sampling.PermutationSamplerTest
[INFO] Running org.apache.commons.rng.sampling.UnitSphereSamplerTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time 
elapsed:

0.536 s - in org.apache.commons.rng.sampling.UnitSphereSamplerTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   ContinuousSamplerParametricTest.testSampling:53->check:127
Box-Muller Gaussian deviate
[rng=org.apache.commons.rng.core.source32.MersenneTwister]: Too many
failures for sample size = 2 (4 out of 50 tests failed, 
chi2=[22.72,

25.762, 22.699, 27.3680002]
[ERROR]   ContinuousSamplerParametricTest.testSampling:53->check:127
org.apache.commons.math3.distribution.LevyDistribution@9635fa 
(inverse

method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres:
[0xedce446814d3b3d9L, 33, 330658535] + Cmres: [0xc5b3cf786c806df7L, 
33,
331932042])]: Too many failures for sample size = 2 (3 out of 50 
tests

failed, chi2=[25.3120005, 26.64, 24.3489997]
[INFO]
[ERROR] Tests run: 77, Failures: 2, Errors: 0, Skipped: 0
[INFO]
[INFO]


[INFO] Reactor Summary:
[INFO]
[INFO] Apache Commons RNG 1.1 . SUCCESS 
[

9.260 s]
[INFO] Apache Commons RNG Client API .. SUCCESS 
[

3.074 s]
[INFO] Apache Commons RNG Core  SUCCESS 
[

17.107 s]
[INFO] Apache Commons RNG Simple .. SUCCESS 
[

11.149 s]
[INFO] Apache Commons RNG Sampling  FAILURE 
[01:21

min]
[INFO] Apache Commons RNG Examples  SKIPPED
[INFO] Stress test example  SKIPPED
[INFO] Sampling example ... SKIPPED
[INFO] Quadrature example

Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Rob Tompkins 


> On Jul 25, 2018, at 12:37 PM, Rob Tompkins  wrote:
> 
> Can you try that from the tag?

It happens on the tag. I’ll move the dist dependencies into the release profile 
so that module doesn’t break the package run.

-Rob

> 
> -Rob
> 
>> On Jul 25, 2018, at 11:10 AM, Gilles > > wrote:
>> 
>> [Mail seems to have been lost.]
>> 
>>  Original Message 
>> Subject: Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 based 
>> on RC3
>> Date: Wed, 25 Jul 2018 16:18:39 +0200
>> From: Gilles > >
>> To: mailto:dev@commons.apache.org>>
>> 
>> Rob,
>> 
>> I still can't build the project: Running
>>  $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn -Pcommons-rng-examples 
>> clean package
>> leads to the same error as with the previous RC, i.e.
>> [...]
>> [INFO] 
>> 
>> [INFO] Reactor Summary:
>> [INFO]
>> [INFO] Apache Commons RNG . SUCCESS [  3.834 
>> s]
>> [INFO] Apache Commons RNG Client API .. SUCCESS [  1.527 
>> s]
>> [INFO] Apache Commons RNG Core  SUCCESS [ 10.841 
>> s]
>> [INFO] Apache Commons RNG Simple .. SUCCESS [  6.062 
>> s]
>> [INFO] Apache Commons RNG Sampling  SUCCESS [ 55.954 
>> s]
>> [INFO] Apache Commons RNG Examples  SUCCESS [  0.568 
>> s]
>> [INFO] Stress test example  SUCCESS [  0.569 
>> s]
>> [INFO] Sampling example ... SUCCESS [  0.525 
>> s]
>> [INFO] Quadrature example . SUCCESS [  0.520 
>> s]
>> [INFO] JMH Benchmark .. SUCCESS [  1.392 
>> s]
>> [INFO] JPMS Integration test .. SUCCESS [  0.302 
>> s]
>> [INFO] JPMS module example (library) .. SUCCESS [  0.645 
>> s]
>> [INFO] JPMS module example (application) .. SUCCESS [  0.632 
>> s]
>> [INFO] Apache Commons RNG (full distribution) . FAILURE [ 10.509 
>> s]
>> [INFO] 
>> 
>> [INFO] BUILD FAILURE
>> [INFO] 
>> 
>> [INFO] Total time: 01:34 min
>> [INFO] Finished at: 2018-07-25T15:34:44+02:00
>> [INFO] Final Memory: 48M/162M
>> [INFO] 
>> 
>> [ERROR] Failed to execute goal on project commons-rng: Could not resolve 
>> dependencies for project org.apache.commons:commons-rng:pom:1.1: The 
>> following artifacts could not be resolved: 
>> org.apache.commons:commons-rng-examples-jpms-app:jar:javadoc:1.1, 
>> org.apache.commons:commons-rng-examples-jpms-lib:jar:javadoc:1.1: Could not 
>> find artifact 
>> org.apache.commons:commons-rng-examples-jpms-app:jar:javadoc:1.1 in central 
>> (https://repo.maven.apache.org/maven2 
>> ) [...]
>> 
>> Environment:
>> $ /usr/lib/jvm/java-9-openjdk-amd64/bin/java -version
>> openjdk version "9-Debian"
>> OpenJDK Runtime Environment (build 9-Debian+0-9b181-4bpo91)
>> OpenJDK 64-Bit Server VM (build 9-Debian+0-9b181-4bpo91, mixed mode)
>> 
>> $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn -v
>> Apache Maven 3.5.2
>> Maven home: /usr/share/maven
>> Java version: 9-Debian, vendor: Oracle Corporation
>> Java home: /usr/lib/jvm/java-9-openjdk-amd64
>> Default locale: en_US, platform encoding: UTF-8
>> OS name: "linux", version: "4.9.0-4-amd64", arch: "amd64", family: "unix"
>> 
>> On Wed, 25 Jul 2018 08:56:42 -0400, Rob Tompkins wrote:
>>> We have added some significant enhancements since Apache Commons RNG
>>> (full distribution) 1.0 was released, so I would like to release
>>> Apache Commons RNG (full distribution) 1.1.
>>> 
>>> Apache Commons RNG (full distribution) 1.1 RC3 is available for review here:
>>>https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3 
>>>  (svn
>>> revision 28335, site added at 28336)
>>> 
>>> The Git tag RNG_1_1_RC3 commit for this RC is available for review here:
>>> 
>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_1_RC3
>>>  
>>> 
>>> 
>>> Maven artifacts are here:
>>>https://repository.apache.org/content/repositories/orgapachecommons-1357
>>> 
>>> These are the Maven artifacts and their hashes in Nexus:
>>> 
>>> #Nexus SHA-1s
>>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.pom
>>> (SHA1: a3f7a09914ba4b7dfc2a28fec5d7a40f3f1ea962)
>>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-test-sources.jar
>>> (SHA1: 9e8216ee90a537c5c884d7993f31a08571d37a65)
>>>

Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Gilles 

Hi.

On Wed, 25 Jul 2018 08:56:23 -0600, Gary Gregory wrote:

-0:

- Don't forget to set the date in

https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/changes-report.html
and changes.xml, I try to remember to do this in an RC, not after.


It's in
  doc/release/release.howto.txt
;-)


- When I've recently emailed an announcement for a release, the email
bounced because I did not have a link to the download page. So I 
added that

to the RELEASE NOTES file which is what I use as the content of the
announcement email.
- There is no Jacoco report, it is empty:

https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/jacoco-aggregate/index.html


Jacoco reports are per module.


-

https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/rat-report.html:
It is OK to include old release notes IMO, it shows history in one 
place.

In fact, I keep all RNs in the one file.

From src zip: ASC, SHA1, SHA256 all OK.

Running 'mvn clean package' I get:

[INFO] Running

org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time 
elapsed:

6.799 s - in

org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
[INFO] Running org.apache.commons.rng.sampling.ListSamplerTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time 
elapsed:

0.008 s - in org.apache.commons.rng.sampling.ListSamplerTest
[INFO] Running org.apache.commons.rng.sampling.PermutationSamplerTest
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time 
elapsed:

0.002 s - in org.apache.commons.rng.sampling.PermutationSamplerTest
[INFO] Running org.apache.commons.rng.sampling.UnitSphereSamplerTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time 
elapsed:

0.536 s - in org.apache.commons.rng.sampling.UnitSphereSamplerTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   ContinuousSamplerParametricTest.testSampling:53->check:127
Box-Muller Gaussian deviate
[rng=org.apache.commons.rng.core.source32.MersenneTwister]: Too many
failures for sample size = 2 (4 out of 50 tests failed, 
chi2=[22.72,

25.762, 22.699, 27.3680002]
[ERROR]   ContinuousSamplerParametricTest.testSampling:53->check:127
org.apache.commons.math3.distribution.LevyDistribution@9635fa 
(inverse

method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres:
[0xedce446814d3b3d9L, 33, 330658535] + Cmres: [0xc5b3cf786c806df7L, 
33,
331932042])]: Too many failures for sample size = 2 (3 out of 50 
tests

failed, chi2=[25.3120005, 26.64, 24.3489997]
[INFO]
[ERROR] Tests run: 77, Failures: 2, Errors: 0, Skipped: 0
[INFO]
[INFO]


[INFO] Reactor Summary:
[INFO]
[INFO] Apache Commons RNG 1.1 . SUCCESS [
9.260 s]
[INFO] Apache Commons RNG Client API .. SUCCESS [
3.074 s]
[INFO] Apache Commons RNG Core  SUCCESS [
17.107 s]
[INFO] Apache Commons RNG Simple .. SUCCESS [
11.149 s]
[INFO] Apache Commons RNG Sampling  FAILURE 
[01:21

min]
[INFO] Apache Commons RNG Examples  SKIPPED
[INFO] Stress test example  SKIPPED
[INFO] Sampling example ... SKIPPED
[INFO] Quadrature example . SKIPPED
[INFO] JMH Benchmark .. SKIPPED
[INFO] JPMS Integration test .. SKIPPED
[INFO] JPMS module example (library) .. SKIPPED
[INFO] JPMS module example (application) .. SKIPPED
[INFO] Apache Commons RNG (full distribution) 1.1 . SKIPPED
[INFO]


[INFO] BUILD FAILURE
[INFO]


[INFO] Total time: 02:03 min
[INFO] Finished at: 2018-07-25T08:51:16-06:00
[INFO]



Using:

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..
Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: 
C:\Program

Files\Java\jdk1.8.0_181\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: 
"windows"


I do not think we can ship unless we give clear instructions in the 
readme

and release notes, set expectations, and provide instructions (Maven
commands.)

One of the items we should document is: The build the jars while 
skipping

the tests, run 'mvn clean package -DskipTests'


I don't think that this is good advice.
Better let people inquire here about why it sometimes fails.
[They might contribute improvement to the unit test suite,
or the sampling code if it turns out that

Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Gilles 

Rob,

I still can't build the project: Running
  $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn 
-Pcommons-rng-examples clean package

leads to the same error as with the previous RC, i.e.
[...]
[INFO] 


[INFO] Reactor Summary:
[INFO]
[INFO] Apache Commons RNG . SUCCESS [  
3.834 s]
[INFO] Apache Commons RNG Client API .. SUCCESS [  
1.527 s]
[INFO] Apache Commons RNG Core  SUCCESS [ 
10.841 s]
[INFO] Apache Commons RNG Simple .. SUCCESS [  
6.062 s]
[INFO] Apache Commons RNG Sampling  SUCCESS [ 
55.954 s]
[INFO] Apache Commons RNG Examples  SUCCESS [  
0.568 s]
[INFO] Stress test example  SUCCESS [  
0.569 s]
[INFO] Sampling example ... SUCCESS [  
0.525 s]
[INFO] Quadrature example . SUCCESS [  
0.520 s]
[INFO] JMH Benchmark .. SUCCESS [  
1.392 s]
[INFO] JPMS Integration test .. SUCCESS [  
0.302 s]
[INFO] JPMS module example (library) .. SUCCESS [  
0.645 s]
[INFO] JPMS module example (application) .. SUCCESS [  
0.632 s]
[INFO] Apache Commons RNG (full distribution) . FAILURE [ 
10.509 s]
[INFO] 


[INFO] BUILD FAILURE
[INFO] 


[INFO] Total time: 01:34 min
[INFO] Finished at: 2018-07-25T15:34:44+02:00
[INFO] Final Memory: 48M/162M
[INFO] 

[ERROR] Failed to execute goal on project commons-rng: Could not 
resolve dependencies for project org.apache.commons:commons-rng:pom:1.1: 
The following artifacts could not be resolved: 
org.apache.commons:commons-rng-examples-jpms-app:jar:javadoc:1.1, 
org.apache.commons:commons-rng-examples-jpms-lib:jar:javadoc:1.1: Could 
not find artifact 
org.apache.commons:commons-rng-examples-jpms-app:jar:javadoc:1.1 in 
central (https://repo.maven.apache.org/maven2) [...]


Environment:
$ /usr/lib/jvm/java-9-openjdk-amd64/bin/java -version
openjdk version "9-Debian"
OpenJDK Runtime Environment (build 9-Debian+0-9b181-4bpo91)
OpenJDK 64-Bit Server VM (build 9-Debian+0-9b181-4bpo91, mixed mode)

$ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn -v
Apache Maven 3.5.2
Maven home: /usr/share/maven
Java version: 9-Debian, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-9-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.0-4-amd64", arch: "amd64", family: 
"unix"


On Wed, 25 Jul 2018 08:56:42 -0400, Rob Tompkins wrote:

We have added some significant enhancements since Apache Commons RNG
(full distribution) 1.0 was released, so I would like to release
Apache Commons RNG (full distribution) 1.1.

Apache Commons RNG (full distribution) 1.1 RC3 is available for 
review here:

https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3 (svn
revision 28335, site added at 28336)

The Git tag RNG_1_1_RC3 commit for this RC is available for review 
here:



https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_1_RC3

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1357


These are the Maven artifacts and their hashes in Nexus:

#Nexus SHA-1s
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.pom
(SHA1: a3f7a09914ba4b7dfc2a28fec5d7a40f3f1ea962)

/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-test-sources.jar
(SHA1: 9e8216ee90a537c5c884d7993f31a08571d37a65)

/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-javadoc.jar
(SHA1: ceb66adfa6d665bbfdb9be1e7e28f9febf01214a)

/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-tests.jar
(SHA1: e1430499f6fcf341f342fd9f9960daacd08c9635)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.jar
(SHA1: 22ec28d4a80034502bcda89fa7f55f332269f874)

/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-sources.jar
(SHA1: 2cf4cda85ee44cf0e17ce5a14cc176939613d79b)
/org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1.pom
(SHA1: 3f7ea1a87752477a10e62bdbf991acc86791b0a9)

/org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1-site.xml
(SHA1: 6e1df36b720e14eed524396107481e509ff42c7c)

/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.jar
(SHA1: 004f4e3ba04b662c1ccbcbadad01f0a7dac4c6df)

/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-sources.jar
(SHA1: d24f113fc5192d769be65b937356bd05d7fe59ef)

/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-tests.jar
(SHA1: 5549762e88fd2505caeae712636066f956bc0465)

Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Rob Tompkins 
Can you try that from the tag?

-Rob

> On Jul 25, 2018, at 11:10 AM, Gilles  wrote:
> 
> [Mail seems to have been lost.]
> 
>  Original Message 
> Subject: Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 based 
> on RC3
> Date: Wed, 25 Jul 2018 16:18:39 +0200
> From: Gilles  >
> To: mailto:dev@commons.apache.org>>
> 
> Rob,
> 
> I still can't build the project: Running
>  $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn -Pcommons-rng-examples 
> clean package
> leads to the same error as with the previous RC, i.e.
> [...]
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Commons RNG . SUCCESS [  3.834 
> s]
> [INFO] Apache Commons RNG Client API .. SUCCESS [  1.527 
> s]
> [INFO] Apache Commons RNG Core  SUCCESS [ 10.841 
> s]
> [INFO] Apache Commons RNG Simple .. SUCCESS [  6.062 
> s]
> [INFO] Apache Commons RNG Sampling  SUCCESS [ 55.954 
> s]
> [INFO] Apache Commons RNG Examples  SUCCESS [  0.568 
> s]
> [INFO] Stress test example  SUCCESS [  0.569 
> s]
> [INFO] Sampling example ... SUCCESS [  0.525 
> s]
> [INFO] Quadrature example . SUCCESS [  0.520 
> s]
> [INFO] JMH Benchmark .. SUCCESS [  1.392 
> s]
> [INFO] JPMS Integration test .. SUCCESS [  0.302 
> s]
> [INFO] JPMS module example (library) .. SUCCESS [  0.645 
> s]
> [INFO] JPMS module example (application) .. SUCCESS [  0.632 
> s]
> [INFO] Apache Commons RNG (full distribution) . FAILURE [ 10.509 
> s]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 01:34 min
> [INFO] Finished at: 2018-07-25T15:34:44+02:00
> [INFO] Final Memory: 48M/162M
> [INFO] 
> 
> [ERROR] Failed to execute goal on project commons-rng: Could not resolve 
> dependencies for project org.apache.commons:commons-rng:pom:1.1: The 
> following artifacts could not be resolved: 
> org.apache.commons:commons-rng-examples-jpms-app:jar:javadoc:1.1, 
> org.apache.commons:commons-rng-examples-jpms-lib:jar:javadoc:1.1: Could not 
> find artifact 
> org.apache.commons:commons-rng-examples-jpms-app:jar:javadoc:1.1 in central 
> (https://repo.maven.apache.org/maven2 ) 
> [...]
> 
> Environment:
> $ /usr/lib/jvm/java-9-openjdk-amd64/bin/java -version
> openjdk version "9-Debian"
> OpenJDK Runtime Environment (build 9-Debian+0-9b181-4bpo91)
> OpenJDK 64-Bit Server VM (build 9-Debian+0-9b181-4bpo91, mixed mode)
> 
> $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn -v
> Apache Maven 3.5.2
> Maven home: /usr/share/maven
> Java version: 9-Debian, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-9-openjdk-amd64
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.9.0-4-amd64", arch: "amd64", family: "unix"
> 
> On Wed, 25 Jul 2018 08:56:42 -0400, Rob Tompkins wrote:
>> We have added some significant enhancements since Apache Commons RNG
>> (full distribution) 1.0 was released, so I would like to release
>> Apache Commons RNG (full distribution) 1.1.
>> 
>> Apache Commons RNG (full distribution) 1.1 RC3 is available for review here:
>>https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3 (svn
>> revision 28335, site added at 28336)
>> 
>> The Git tag RNG_1_1_RC3 commit for this RC is available for review here:
>> 
>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_1_RC3
>> 
>> Maven artifacts are here:
>>https://repository.apache.org/content/repositories/orgapachecommons-1357
>> 
>> These are the Maven artifacts and their hashes in Nexus:
>> 
>> #Nexus SHA-1s
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.pom
>> (SHA1: a3f7a09914ba4b7dfc2a28fec5d7a40f3f1ea962)
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-test-sources.jar
>> (SHA1: 9e8216ee90a537c5c884d7993f31a08571d37a65)
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-javadoc.jar
>> (SHA1: ceb66adfa6d665bbfdb9be1e7e28f9febf01214a)
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-tests.jar
>> (SHA1: e1430499f6fcf341f342fd9f9960daacd08c9635)
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.jar
>> (SHA1: 22ec28d4a80034502bcda89fa7f55f332269f874)
>> /org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-sources.jar
>> (SHA1: 2cf4cda85ee44cf0e17ce5a14cc176939613d79b)
>>

Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Rob Tompkins 
Thanks. Quite reasonable. I’m going to let @Gilles have a look and then will 
likely re-roll with better docs on the way the tests work. Thanks for the eyes.

@Gilles - any thoughts or help on getting things buttoned up would be 
appreciated at this point.

Cheers,
-Rob

> On Jul 25, 2018, at 10:56 AM, Gary Gregory  wrote:
> 
> -0:
> 
> - Don't forget to set the date in
> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/changes-report.html
> and changes.xml, I try to remember to do this in an RC, not after.
> - When I've recently emailed an announcement for a release, the email
> bounced because I did not have a link to the download page. So I added that
> to the RELEASE NOTES file which is what I use as the content of the
> announcement email.
> - There is no Jacoco report, it is empty:
> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/jacoco-aggregate/index.html
> -
> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/rat-report.html:
> It is OK to include old release notes IMO, it shows history in one place.
> In fact, I keep all RNs in the one file.
> 
> From src zip: ASC, SHA1, SHA256 all OK.
> 
> Running 'mvn clean package' I get:
> 
> [INFO] Running
> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
> [INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 6.799 s - in
> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
> [INFO] Running org.apache.commons.rng.sampling.ListSamplerTest
> [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 0.008 s - in org.apache.commons.rng.sampling.ListSamplerTest
> [INFO] Running org.apache.commons.rng.sampling.PermutationSamplerTest
> [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 0.002 s - in org.apache.commons.rng.sampling.PermutationSamplerTest
> [INFO] Running org.apache.commons.rng.sampling.UnitSphereSamplerTest
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 0.536 s - in org.apache.commons.rng.sampling.UnitSphereSamplerTest
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR]   ContinuousSamplerParametricTest.testSampling:53->check:127
> Box-Muller Gaussian deviate
> [rng=org.apache.commons.rng.core.source32.MersenneTwister]: Too many
> failures for sample size = 2 (4 out of 50 tests failed, chi2=[22.72,
> 25.762, 22.699, 27.3680002]
> [ERROR]   ContinuousSamplerParametricTest.testSampling:53->check:127
> org.apache.commons.math3.distribution.LevyDistribution@9635fa (inverse
> method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres:
> [0xedce446814d3b3d9L, 33, 330658535] + Cmres: [0xc5b3cf786c806df7L, 33,
> 331932042])]: Too many failures for sample size = 2 (3 out of 50 tests
> failed, chi2=[25.3120005, 26.64, 24.3489997]
> [INFO]
> [ERROR] Tests run: 77, Failures: 2, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Commons RNG 1.1 . SUCCESS [
> 9.260 s]
> [INFO] Apache Commons RNG Client API .. SUCCESS [
> 3.074 s]
> [INFO] Apache Commons RNG Core  SUCCESS [
> 17.107 s]
> [INFO] Apache Commons RNG Simple .. SUCCESS [
> 11.149 s]
> [INFO] Apache Commons RNG Sampling  FAILURE [01:21
> min]
> [INFO] Apache Commons RNG Examples  SKIPPED
> [INFO] Stress test example  SKIPPED
> [INFO] Sampling example ... SKIPPED
> [INFO] Quadrature example . SKIPPED
> [INFO] JMH Benchmark .. SKIPPED
> [INFO] JPMS Integration test .. SKIPPED
> [INFO] JPMS module example (library) .. SKIPPED
> [INFO] JPMS module example (application) .. SKIPPED
> [INFO] Apache Commons RNG (full distribution) 1.1 . SKIPPED
> [INFO]
> 
> [INFO] BUILD FAILURE
> [INFO]
> 
> [INFO] Total time: 02:03 min
> [INFO] Finished at: 2018-07-25T08:51:16-06:00
> [INFO]
> 
> 
> Using:
> 
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T12:33:14-06:00)
> Maven home: C:\Java\apache-maven-3.5.4\bin\..
> Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_181\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> 
> I do not think we can ship unless we give clear instructions in the readme
> and release notes, set expectations, and provide instructions (Maven
>

Fwd: Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Gilles 

[Mail seems to have been lost.]

 Original Message 
Subject: Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 
based on RC3

Date: Wed, 25 Jul 2018 16:18:39 +0200
From: Gilles 
To: 

Rob,

I still can't build the project: Running
  $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn 
-Pcommons-rng-examples clean package

leads to the same error as with the previous RC, i.e.
[...]
[INFO] 


[INFO] Reactor Summary:
[INFO]
[INFO] Apache Commons RNG . SUCCESS [  
3.834 s]
[INFO] Apache Commons RNG Client API .. SUCCESS [  
1.527 s]
[INFO] Apache Commons RNG Core  SUCCESS [ 
10.841 s]
[INFO] Apache Commons RNG Simple .. SUCCESS [  
6.062 s]
[INFO] Apache Commons RNG Sampling  SUCCESS [ 
55.954 s]
[INFO] Apache Commons RNG Examples  SUCCESS [  
0.568 s]
[INFO] Stress test example  SUCCESS [  
0.569 s]
[INFO] Sampling example ... SUCCESS [  
0.525 s]
[INFO] Quadrature example . SUCCESS [  
0.520 s]
[INFO] JMH Benchmark .. SUCCESS [  
1.392 s]
[INFO] JPMS Integration test .. SUCCESS [  
0.302 s]
[INFO] JPMS module example (library) .. SUCCESS [  
0.645 s]
[INFO] JPMS module example (application) .. SUCCESS [  
0.632 s]
[INFO] Apache Commons RNG (full distribution) . FAILURE [ 
10.509 s]
[INFO] 


[INFO] BUILD FAILURE
[INFO] 


[INFO] Total time: 01:34 min
[INFO] Finished at: 2018-07-25T15:34:44+02:00
[INFO] Final Memory: 48M/162M
[INFO] 

[ERROR] Failed to execute goal on project commons-rng: Could not 
resolve dependencies for project org.apache.commons:commons-rng:pom:1.1: 
The following artifacts could not be resolved: 
org.apache.commons:commons-rng-examples-jpms-app:jar:javadoc:1.1, 
org.apache.commons:commons-rng-examples-jpms-lib:jar:javadoc:1.1: Could 
not find artifact 
org.apache.commons:commons-rng-examples-jpms-app:jar:javadoc:1.1 in 
central (https://repo.maven.apache.org/maven2) [...]


Environment:
$ /usr/lib/jvm/java-9-openjdk-amd64/bin/java -version
openjdk version "9-Debian"
OpenJDK Runtime Environment (build 9-Debian+0-9b181-4bpo91)
OpenJDK 64-Bit Server VM (build 9-Debian+0-9b181-4bpo91, mixed mode)

$ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn -v
Apache Maven 3.5.2
Maven home: /usr/share/maven
Java version: 9-Debian, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-9-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.0-4-amd64", arch: "amd64", family: 
"unix"


On Wed, 25 Jul 2018 08:56:42 -0400, Rob Tompkins wrote:

We have added some significant enhancements since Apache Commons RNG
(full distribution) 1.0 was released, so I would like to release
Apache Commons RNG (full distribution) 1.1.

Apache Commons RNG (full distribution) 1.1 RC3 is available for 
review here:

https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3 (svn
revision 28335, site added at 28336)

The Git tag RNG_1_1_RC3 commit for this RC is available for review 
here:



https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_1_RC3

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1357


These are the Maven artifacts and their hashes in Nexus:

#Nexus SHA-1s
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.pom
(SHA1: a3f7a09914ba4b7dfc2a28fec5d7a40f3f1ea962)

/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-test-sources.jar
(SHA1: 9e8216ee90a537c5c884d7993f31a08571d37a65)

/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-javadoc.jar
(SHA1: ceb66adfa6d665bbfdb9be1e7e28f9febf01214a)

/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-tests.jar
(SHA1: e1430499f6fcf341f342fd9f9960daacd08c9635)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.jar
(SHA1: 22ec28d4a80034502bcda89fa7f55f332269f874)

/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-sources.jar
(SHA1: 2cf4cda85ee44cf0e17ce5a14cc176939613d79b)
/org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1.pom
(SHA1: 3f7ea1a87752477a10e62bdbf991acc86791b0a9)

/org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1-site.xml
(SHA1: 6e1df36b720e14eed524396107481e509ff42c7c)

/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.jar
(SHA1: 004f4e3ba04b662c1ccbcbadad01f0a7dac4c6df)

Re: [VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Gary Gregory 
-0:

- Don't forget to set the date in
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/changes-report.html
and changes.xml, I try to remember to do this in an RC, not after.
- When I've recently emailed an announcement for a release, the email
bounced because I did not have a link to the download page. So I added that
to the RELEASE NOTES file which is what I use as the content of the
announcement email.
- There is no Jacoco report, it is empty:
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/jacoco-aggregate/index.html
-
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/rat-report.html:
It is OK to include old release notes IMO, it shows history in one place.
In fact, I keep all RNs in the one file.

>From src zip: ASC, SHA1, SHA256 all OK.

Running 'mvn clean package' I get:

[INFO] Running
org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
6.799 s - in
org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
[INFO] Running org.apache.commons.rng.sampling.ListSamplerTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.008 s - in org.apache.commons.rng.sampling.ListSamplerTest
[INFO] Running org.apache.commons.rng.sampling.PermutationSamplerTest
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.002 s - in org.apache.commons.rng.sampling.PermutationSamplerTest
[INFO] Running org.apache.commons.rng.sampling.UnitSphereSamplerTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.536 s - in org.apache.commons.rng.sampling.UnitSphereSamplerTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   ContinuousSamplerParametricTest.testSampling:53->check:127
Box-Muller Gaussian deviate
[rng=org.apache.commons.rng.core.source32.MersenneTwister]: Too many
failures for sample size = 2 (4 out of 50 tests failed, chi2=[22.72,
25.762, 22.699, 27.3680002]
[ERROR]   ContinuousSamplerParametricTest.testSampling:53->check:127
org.apache.commons.math3.distribution.LevyDistribution@9635fa (inverse
method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres:
[0xedce446814d3b3d9L, 33, 330658535] + Cmres: [0xc5b3cf786c806df7L, 33,
331932042])]: Too many failures for sample size = 2 (3 out of 50 tests
failed, chi2=[25.3120005, 26.64, 24.3489997]
[INFO]
[ERROR] Tests run: 77, Failures: 2, Errors: 0, Skipped: 0
[INFO]
[INFO]

[INFO] Reactor Summary:
[INFO]
[INFO] Apache Commons RNG 1.1 . SUCCESS [
9.260 s]
[INFO] Apache Commons RNG Client API .. SUCCESS [
3.074 s]
[INFO] Apache Commons RNG Core  SUCCESS [
17.107 s]
[INFO] Apache Commons RNG Simple .. SUCCESS [
11.149 s]
[INFO] Apache Commons RNG Sampling  FAILURE [01:21
min]
[INFO] Apache Commons RNG Examples  SKIPPED
[INFO] Stress test example  SKIPPED
[INFO] Sampling example ... SKIPPED
[INFO] Quadrature example . SKIPPED
[INFO] JMH Benchmark .. SKIPPED
[INFO] JPMS Integration test .. SKIPPED
[INFO] JPMS module example (library) .. SKIPPED
[INFO] JPMS module example (application) .. SKIPPED
[INFO] Apache Commons RNG (full distribution) 1.1 . SKIPPED
[INFO]

[INFO] BUILD FAILURE
[INFO]

[INFO] Total time: 02:03 min
[INFO] Finished at: 2018-07-25T08:51:16-06:00
[INFO]


Using:

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..
Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_181\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

I do not think we can ship unless we give clear instructions in the readme
and release notes, set expectations, and provide instructions (Maven
commands.)

One of the items we should document is: The build the jars while skipping
the tests, run 'mvn clean package -DskipTests'

In the above case, we clearly do not expect the failure since we give a
nice and simple message 'Too many failures for sample size'. So either this
is a bug in the main code or in the test code. You tell me.

Gary






On Wed, Jul 25, 2018 at 7:17 AM Rob Tompkins  wrote:

> We have added some significant enhancements since Apache Commons RNG (full
> distribution) 1.0 was released, so

[VOTE] Release Apache Commons RNG (full distribution) 1.1 based on RC3

2018-07-25 Thread Rob Tompkins 
We have added some significant enhancements since Apache Commons RNG (full 
distribution) 1.0 was released, so I would like to release Apache Commons RNG 
(full distribution) 1.1.

Apache Commons RNG (full distribution) 1.1 RC3 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3 (svn revision 
28335, site added at 28336)

The Git tag RNG_1_1_RC3 commit for this RC is available for review here: 

https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_1_RC3

Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1357

These are the Maven artifacts and their hashes in Nexus:

#Nexus SHA-1s
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.pom
(SHA1: a3f7a09914ba4b7dfc2a28fec5d7a40f3f1ea962)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-test-sources.jar
(SHA1: 9e8216ee90a537c5c884d7993f31a08571d37a65)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-javadoc.jar
(SHA1: ceb66adfa6d665bbfdb9be1e7e28f9febf01214a)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-tests.jar
(SHA1: e1430499f6fcf341f342fd9f9960daacd08c9635)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.jar
(SHA1: 22ec28d4a80034502bcda89fa7f55f332269f874)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-sources.jar
(SHA1: 2cf4cda85ee44cf0e17ce5a14cc176939613d79b)
/org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1.pom
(SHA1: 3f7ea1a87752477a10e62bdbf991acc86791b0a9)
/org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1-site.xml
(SHA1: 6e1df36b720e14eed524396107481e509ff42c7c)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.jar
(SHA1: 004f4e3ba04b662c1ccbcbadad01f0a7dac4c6df)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-sources.jar
(SHA1: d24f113fc5192d769be65b937356bd05d7fe59ef)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-tests.jar
(SHA1: 5549762e88fd2505caeae712636066f956bc0465)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-test-sources.jar
(SHA1: 641105db090f267b46b73d56b8741fff2805800b)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.pom
(SHA1: 26ec84056b9a4526bc5e05ecf4ece8d9c3d57aad)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-javadoc.jar
(SHA1: 75712250264765649948fa589beb3ac883e492d4)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-javadoc.jar
(SHA1: 26046b6582982748cf912130c1b047b0fa0554ae)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-sources.jar
(SHA1: 32b694cc43e9ae7e9f41a519c08b300a35cdbc95)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-tests.jar
(SHA1: 03e5baff332fe16f8279d5800782af1cabcdf57d)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1.jar
(SHA1: 4b9a38a5abf0118811a599472ffd06f666ddf7dd)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-test-sources.jar
(SHA1: 2f71531f4aa2b590561e378dbd31d04dc467e3f7)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1.pom
(SHA1: 04c2a060613758d5ca233f4bbc2b6fd947693207)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-javadoc.jar
(SHA1: 863a507e373ee5c6c9d3bcc64fe950562a044cd1)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-sources.jar
(SHA1: 296007f2657ae0d162f45da84a727ba967a691f7)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1.pom
(SHA1: 6af16fa13e06fbba809d64803fae689bd40e2679)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-tests.jar
(SHA1: 6fb83e23389388133bc4840f9feb9412800567fe)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-test-sources.jar
(SHA1: c8ebe6da223727039e41938765533b60ac1e5308)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1.jar
(SHA1: 12c795044794f698c9d14c5df66e7cc3a0743c05)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1.jar
(SHA1: 7d2b707dfb680393de55ea79f1a781a3c604bdb6)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1-javadoc.jar
(SHA1: 885cfe9f3d90b3d6210b4b2880973605f60ad807)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1.pom
(SHA1: cd4b2d45949778e8fbee15eda94faac1d0a4b460)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1-test-sources.jar
(SHA1: 2f4ef16a825ebda770398604ecd3c53e3d77f543)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1-sources.jar
(SHA1:

[GitHub] commons-collections issue #45: [COLLECTIONS-691] Use boolean operator for bo...

2018-07-25 Thread kinow 
Github user kinow commented on the issue:

https://github.com/apache/commons-collections/pull/45
  
Merged. Thanks again @grimreaper !


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #45: [COLLECTIONS-691] Use boolean operator...

2018-07-25 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/45


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #45: [COLLECTIONS-691] Use boolean operator...

2018-07-25 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/45


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Writing 16 Bits Per Sample To Tiff File

2018-07-25 Thread Juergen Stumpe 
Hi,

I tried it with BufferedImage TYPE_USHORT_GRAY, and I think from the
BufferedImage point of view it seems to be OK.
raster = ShortInterleavedRaster
dataBuffer = DataBufferShort
imageType = 11
I'm just not sure about the colorModel = ComponentColorModel?

I write this BufferedImage to disc with the following code:
File targetFile = new File(targetTIFF);
ImageFormat format = ImageFormats.TIFF;
Map params = new HashMap<>();
try {
Imaging.writeImage(bufferedImage, targetFile, format, params);
} catch (ImageWriteException | IOException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}

But when I read the file that's been written with the code above, it has
BitsPerSample: 8, 8, 8 (3 short) instead of BitsPerSample: 16 (1 short).

What needs to be changed to get 16 BitsPerSample in one short written?
Is something wrong with the BufferedImage, or must be additional
parameters set for Imaging.writeImage(bufferedImage, targetFile,
format, params)?

Thanks

Juergen
On Tue, Jun 5, 2018 at 12:04 PM Damjan Jovanovic  wrote:
>
> You can make a BufferedImage with TYPE_USHORT_GRAY for 16 bits per sample.
>
> Damjan
>
>
>
> On Tue, Jun 5, 2018 at 11:15 AM Juergen Stumpe  wrote:
>
> > Hello,
> >
> > I need to write grayscale pixels with 16 bits per sample into a Tiff file.
> >
> > In the provided Apache examples the Imaging.writeImage() method is
> > used to write image data into a file. But the image data source has
> > always to be a BufferedImage, however BufferedImage handles only 8
> > bits per sample, not 16 bits.
> >
> > Is there an alternative class/method to write image data to a Tiff
> > file, supporting 16 bits per sample? Or how can it be done with
> > BufferedImage?
> >
> > Thanks
> >
> > Juergen
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org