[GitHub] darkma773r opened a new pull request #15: GEOMETRY-23: Remove Point?D
darkma773r opened a new pull request #15: GEOMETRY-23: Remove Point?D URL: https://github.com/apache/commons-geometry/pull/15 Removing Euclidean point classes and making Vector?D implement Point. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[ANNOUNCE] Apache Commons Text 1.6 Released
The Apache Commons Team is pleased to announce the release of Apache Commons Text 1.6. The Apache Commons Text open source software library provides a host of algorithms focused on working with strings and blocks of text. Source and binary distributions are available for download from the Apache Commons download site: http://commons.apache.org/proper/commons-text/download_text.cgi When downloading, please verify signatures using the KEYS file available at the above location when downloading the release. Alternatively the release can be pulled via maven: org.apache.commons commons-text 1.6 The release notes can be reviewed at: http://www.apache.org/dist/commons/text/RELEASE-NOTES.txt For complete information on Commons Text, including instructions on how to submit bug reports, patches, or suggestions for improvement, see the Apache Commons Text website: http://commons.apache.org/proper/commons-text/ Best regards, Rob Tompkins on behalf of the Apache Commons community
Re: [git] pushing through github - permission denied
The github mirror is one way. I am not sure if GitBox changes that. Gary On Wed, Oct 17, 2018 at 5:50 PM Eric Barnhill wrote: > I tried something new for my latest changes - pushing through Apache's > github site rather than apache.org . I have committer status in commons > and > Apache shows up in my github "Organizations". It would be great to start > committing that way so that there is a public record of my activity on > GitHub in the contributions data there. > > I have never had a problem pushing directly to apache.org . Pushing > through > github this way, however, I get the error: > > remote: Permission to access apache/commons-numbers.git denied to > ericbarnhill > > Does someone need to authorize me anew, to push via > github/apache/commons-numbers.git ? >
[git] pushing through github - permission denied
I tried something new for my latest changes - pushing through Apache's github site rather than apache.org . I have committer status in commons and Apache shows up in my github "Organizations". It would be great to start committing that way so that there is a public record of my activity on GitHub in the contributions data there. I have never had a problem pushing directly to apache.org . Pushing through github this way, however, I get the error: remote: Permission to access apache/commons-numbers.git denied to ericbarnhill Does someone need to authorize me anew, to push via github/apache/commons-numbers.git ?
Re: [numbers] Making fractions VALJOs
Oh right, that is the convention. I knew there was something off. As far as you understand, is to within VALJO standards to overload factory methods, so long as they are not private constructors? All that is specified on the page is that VALJOs must have all constructors private. So I am not sure whether it is in the spirit of VALJOs to overload, but coming up with elaborate names for each constructor doesn't seem like a very streamlined coding practice. On Tue, Oct 16, 2018 at 5:56 PM Gilles wrote: > On Tue, 16 Oct 2018 16:55:02 -0700, Eric Barnhill wrote: > > The Fraction class is IMO looking good (in better shape than Complex > > was > > in) and is already quite close to fulfilling the standards for a > > VALJO. > > Equals() and CompareTo() are well designed and consistent. I see two > > missing steps. The easy one is a parse() method which mirrors the > > toString() method. The harder one is the wide range of public > > constructors. > > > > To be a VALJO all constructors must be private and accessed with > > static > > factory methods. If these factory methods themselves can be > > overloaded, I > > think a decent schema emerges: > > > > current constructor -> proposed factory method > > > > public Fraction(double value) -> public fromDouble(double value) > > public Fraction(double value, double epsilon, int maxIterations) -> > > public > > fromDouble(double value, double epsilon, int maxIterations) > > public Fraction(double value,int maxDenominator) -> public > > fromDouble > > (double value,int maxDenominator) > > public Fraction(int value) -> public fromInt(int value) > > public Fraction(int num, int denom) -> public fromInt(int num, int > > denom) > > Why not call them all "of(...)" ? > > Gilles > > > > > so this is what I propose to go with. > > > > If disambiguation in the double cases is still a problem, the second > > and > > third of the double constructors could be fromDoubleEpsMaxInt and > > fromDoubleMaxDenom . > > > > Eric > > > > > > On Thu, Oct 11, 2018 at 7:00 AM Gilles > > wrote: > > > >> On Wed, 10 Oct 2018 16:18:50 -0700, Eric Barnhill wrote: > >> > I am interested in moving forward on making the Fraction classes > >> > VALJOs > >> > [NUMBERS-75]. > >> > > >> > Just a preliminary question for now, are we otherwise happy with > >> the > >> > Fraction class in the context of commons-numbers? Or should I look > >> > around > >> > for any odd behaviors leftover from commons-math (Complex had a > >> lot > >> > of > >> > those) that might also be improved? > >> > >> AFAIK, there was no in-depth review as was done for "Complex". > >> So it would indeed be quite useful to check what the Javadoc > >> states, whether it seems acceptable (wrt what other libraries > >> do), and whether the unit tests validate everything. > >> > >> Side note: Unless I'm overlooking something, completing this > >> task will result in getting rid of all the formatting and > >> "Locale"-related classes (as for "Complex"). > >> > >> Best, > >> Gilles > >> > >> > > >> > Eric > >> > > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [pool] support JMX Notifications for NumActive and NumIdle
I think it would be nice to see a PR so we can tell what it is exactly we are getting ourselves into... ;-) Gary On Wed, Oct 17, 2018 at 4:43 PM Paul wrote: > hi, > > Not sure I should post this here first or on the user list or in Jira, > but I'd like to see JMX Notifications support for at least for NumActive > and NumIdle. > > I had already created a case for it in Jira, see > https://issues.apache.org/jira/browse/POOL-351 > > I'm willing to provide a patch, but need to know if such an addition has > any change of getting accepted > > Paul > > --- > This email has been checked for viruses by AVG. > https://www.avg.com > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [ALL] Spaces in paths - change Jenkins jobs to use spaces?
On Wed, 17 Oct 2018 at 17:06, Matt Sicker wrote: > > Can you make a folder like "Apache Commons" and then put all the Commons > jobs there? All of them will have a space in the name because of the parent > item name. Nice idea. "Apache Commons" will go against the existing convention. But it might be acceptable to use "Commons components". > On Wed, 17 Oct 2018 at 03:47, sebb wrote: > > > On Wed, 17 Oct 2018 at 01:05, Gary Gregory wrote: > > > > > > Sounds reasonable but we need unit tests that also include spaces so that > > > we do rely on the build location as a test. > > > > Ideally, but I don't think that's possible in general. > > > > For example, the IO-589 error happened because the classpath contained a > > space. > > In this case, I guess it would have been possible to use a test file > > whose name contained a space, but there may be other places where only > > the classpath affects the result. I think that would be very difficult > > to achieve without using a base path with a space in it. > > > > Besides, one does not know in advance which tests are going to fail, > > and therefore which tests need to be adjusted. > > > > > Gary > > > > > > On Tue, Oct 16, 2018, 17:39 sebb wrote: > > > > > > > IO-589 was accidentally found by trying to test in a path which > > > > happened to contain a space. > > > > This revealed a bug (in test code) which did not properly convert from > > > > URL path to file system path. > > > > > > > > I think it would make sense to rename the Jenkins jobs to ensure all > > > > the tests have a space in the path. > > > > > > > > Possibly go further and try to introduce other special characters such > > > > as $&+,:;=?@. > > > > > > > > I've made a start with NET, which has built and tested OK. > > > > > > > > WDYT? > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > -- > Matt Sicker - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[pool] support JMX Notifications for NumActive and NumIdle
hi, Not sure I should post this here first or on the user list or in Jira, but I'd like to see JMX Notifications support for at least for NumActive and NumIdle. I had already created a case for it in Jira, see https://issues.apache.org/jira/browse/POOL-351 I'm willing to provide a patch, but need to know if such an addition has any change of getting accepted Paul --- This email has been checked for viruses by AVG. https://www.avg.com - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[configuration] release soon
Hi All: Now that we have Commons Text 1.6 done, I'd like to see Commons Configuration released next to integrate the few new features in Text 1.6. If you have anything you want done in Configuration, now is great time :-) Gary
Re: commons-io Java version
Hi, We are all volunteers here, so it's up to a PMC member to step up and volunteer. Gary On Wed, Oct 17, 2018 at 11:01 AM Aleksander Ściborek < aleksanderscibo...@gmail.com> wrote: > Hi, i see that java version commons-io is 1.7. Is there any plan to bump > it to 1.8? > Recently the version of commons-lang was updated > Aleksander >
commons-io Java version
Hi, i see that java version commons-io is 1.7. Is there any plan to bump it to 1.8? Recently the version of commons-lang was updated Aleksander
Re: [ALL] Spaces in paths - change Jenkins jobs to use spaces?
Can you make a folder like "Apache Commons" and then put all the Commons jobs there? All of them will have a space in the name because of the parent item name. On Wed, 17 Oct 2018 at 03:47, sebb wrote: > On Wed, 17 Oct 2018 at 01:05, Gary Gregory wrote: > > > > Sounds reasonable but we need unit tests that also include spaces so that > > we do rely on the build location as a test. > > Ideally, but I don't think that's possible in general. > > For example, the IO-589 error happened because the classpath contained a > space. > In this case, I guess it would have been possible to use a test file > whose name contained a space, but there may be other places where only > the classpath affects the result. I think that would be very difficult > to achieve without using a base path with a space in it. > > Besides, one does not know in advance which tests are going to fail, > and therefore which tests need to be adjusted. > > > Gary > > > > On Tue, Oct 16, 2018, 17:39 sebb wrote: > > > > > IO-589 was accidentally found by trying to test in a path which > > > happened to contain a space. > > > This revealed a bug (in test code) which did not properly convert from > > > URL path to file system path. > > > > > > I think it would make sense to rename the Jenkins jobs to ensure all > > > the tests have a space in the path. > > > > > > Possibly go further and try to introduce other special characters such > > > as $&+,:;=?@. > > > > > > I've made a start with NET, which has built and tested OK. > > > > > > WDYT? > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- Matt Sicker
Re: [ALL] Spaces in paths - change Jenkins jobs to use spaces?
On Wed, 17 Oct 2018 at 01:05, Gary Gregory wrote: > > Sounds reasonable but we need unit tests that also include spaces so that > we do rely on the build location as a test. Ideally, but I don't think that's possible in general. For example, the IO-589 error happened because the classpath contained a space. In this case, I guess it would have been possible to use a test file whose name contained a space, but there may be other places where only the classpath affects the result. I think that would be very difficult to achieve without using a base path with a space in it. Besides, one does not know in advance which tests are going to fail, and therefore which tests need to be adjusted. > Gary > > On Tue, Oct 16, 2018, 17:39 sebb wrote: > > > IO-589 was accidentally found by trying to test in a path which > > happened to contain a space. > > This revealed a bug (in test code) which did not properly convert from > > URL path to file system path. > > > > I think it would make sense to rename the Jenkins jobs to ensure all > > the tests have a space in the path. > > > > Possibly go further and try to introduce other special characters such > > as $&+,:;=?@. > > > > I've made a start with NET, which has built and tested OK. > > > > WDYT? > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
