[GitHub] luyseyal commented on issue #39: [CSV-234] Enable escaping of quotes in CLOBs

[GitBox]

luyseyal commented on issue #39: [CSV-234] Enable escaping of quotes in CLOBs
URL: https://github.com/apache/commons-csv/pull/39#issuecomment-464970117
 
 
   @garydgregory 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] luyseyal opened a new pull request #39: [CSV-234] Enable escaping of quotes in CLOBs

[GitBox]

luyseyal opened a new pull request #39: [CSV-234] Enable escaping of quotes in 
CLOBs
URL: https://github.com/apache/commons-csv/pull/39
 
 
   This fixes Excel output.
   
   Given a CLOB like:
   ```
   Choose either
   "Y" or "N"
   ```
   The patch will transform it to:
   ```
   Choose either
   "'Y"" or ""N""
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Rng] README.md and broken javadoc link

[Alex Herbert]

Hi Gilles,

I was just drafting an e-mail stating I had found my mistake.

> On 18 Feb 2019, at 22:18, Gilles Sadowski  wrote:
> 
> Hi.
> 
> Le lun. 18 févr. 2019 à 16:22, Alex Herbert  a 
> écrit :
>> 
 [...]
>>> 
>>> Command
>>> $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64/ mvn
>>> -Pcommons-rng-examples -Pjdk8-javadoc clean package site site:stage
>>> works on
>>> $ /usr/lib/jvm/java-9-openjdk-amd64/bin/java -version
>>> openjdk version "9-Debian"
>>> OpenJDK Runtime Environment (build 9-Debian+0-9b181-4bpo91)
>>> OpenJDK 64-Bit Server VM (build 9-Debian+0-9b181-4bpo91, mixed mode)
>>> 
>>> I missed when the "jdk8-javadoc" profile became mandatory.  Is there a
>>> way to have it activated automatically when necessary (e.g. when compiling
>>> with a JKD >= 8)?
>>> 
>>> Gilles
>> 
>> I’ve removed the linux distribution version of OpenJDK 9 and manually 
>> installed OpenJDK 9, 10 and 11.
>> 
>> I confirm these versions all require the --allow-script-in-comments option 
>> for 'mvn javadoc:javadoc'. So I’ve reverted the pom.xml to put this back in 
>> the profile for JDK 1.8+.
>> 
>> I get a module error when building on OpenJDK 9:
>> 
>> mvn -v
>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 
>> 2018-06-17T19:33:14+01:00)
>> Maven home: /usr/local/apache-maven-3.5.4
>> Java version: 9, vendor: Oracle Corporation, runtime: /usr/lib/jvm/jdk-9
>> Default locale: en_GB, platform encoding: UTF-8
>> OS name: "linux", version: "4.4.0-142-generic", arch: "amd64", family: “unix"
>> 
>> mvn clean site site:stage -Pcommons-rng-exampless
>> 
>> [INFO] Reactor Summary:
>> [INFO]
>> [INFO] Apache Commons RNG 1.3-SNAPSHOT  SUCCESS [ 13.143 
>> s]
>> [INFO] Apache Commons RNG Client API .. SUCCESS [  8.144 
>> s]
>> [INFO] Apache Commons RNG Core  SUCCESS [ 19.623 
>> s]
>> [INFO] Apache Commons RNG Simple .. SUCCESS [ 13.773 
>> s]
>> [INFO] Apache Commons RNG Sampling  SUCCESS [01:07 
>> min]
>> [INFO] Apache Commons RNG Examples  SUCCESS [  3.871 
>> s]
>> [INFO] Stress test example  SUCCESS [  6.715 
>> s]
>> [INFO] Sampling example ... SUCCESS [  6.155 
>> s]
>> [INFO] Quadrature example . SUCCESS [  5.808 
>> s]
>> [INFO] JMH Benchmark .. SUCCESS [ 22.310 
>> s]
>> [INFO] JPMS Integration test .. SUCCESS [  1.895 
>> s]
>> [INFO] JPMS module example (library) .. FAILURE [  0.559 
>> s]
>> [INFO] JPMS module example (application) 1.3-SNAPSHOT . SKIPPED
>> [INFO] 
>> 
>> [INFO] BUILD FAILURE
>> [INFO] 
>> 
>> [INFO] Total time: 02:49 min
>> [INFO] Finished at: 2019-02-18T13:54:01Z
>> [INFO] 
>> 
>> [ERROR] Failed to execute goal 
>> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on 
>> project commons-rng-examples-jpms-lib: failed to get report for 
>> org.apache.maven.plugins:maven-surefire-report-plugin: Failed to execute 
>> goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile 
>> (default-compile) on project commons-rng-examples-jpms-lib: Compilation 
>> failure: Compilation failure:
>> [ERROR] 
>> /home/ah403/git/commons-rng/commons-rng-examples/examples-jpms/jpms-lib/src/main/java/module-info.java:[18,36]
>>  module not found: org.apache.commons.rng.api
>> [ERROR] 
>> /home/ah403/git/commons-rng/commons-rng-examples/examples-jpms/jpms-lib/src/main/java/module-info.java:[19,36]
>>  module not found: org.apache.commons.rng.sampling
>> 
>> 
>> I tried mvn 3.5.4 and 3.6.0.
>> 
>> This can be reduced to just running:
>> 
>> mvn compile in commons-rng-examples/examples-jpms
> 
> Works here (maven downloads the "1.3-SNAPSHOT" artefacts from the
> Apache repository).
> 
>> 
>> Something about this machine setup does not like the modules setup. I had a 
>> dig around and thought updating this module definition would work:
>> 
>> module org.apache.commons.rng.examples.jpms.lib {
>>requires org.apache.commons.rng;
>>requires org.apache.commons.rng.sampling.distribution;
>>exports org.apache.commons.rng.examples.jpms.lib;
>> }
>> 
>> The module currently requires ‘o.a.c.rng.api’ which doesn’t exist and 
>> ‘o.a.c.rng.sampling’ which needs .distribution added to the end. But that 
>> made no difference.
>> 
>> I am going to try on another machine to get the modules built.
> 
> Try building from the top-level and adding the "package" goal:
> 
> $ mvn -Pcommons-rng examples clean package

Correct.

Somehow in repeat attempts at doing this I dropped the packaging of the code, 
so obviously it cannot find the module-info when 

Re: [Rng] README.md and broken javadoc link

[Gilles Sadowski]

Hi.

Le lun. 18 févr. 2019 à 16:22, Alex Herbert  a écrit :
>
>>> [...]
> >
> > Command
> >  $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64/ mvn
> > -Pcommons-rng-examples -Pjdk8-javadoc clean package site site:stage
> > works on
> > $ /usr/lib/jvm/java-9-openjdk-amd64/bin/java -version
> > openjdk version "9-Debian"
> > OpenJDK Runtime Environment (build 9-Debian+0-9b181-4bpo91)
> > OpenJDK 64-Bit Server VM (build 9-Debian+0-9b181-4bpo91, mixed mode)
> >
> > I missed when the "jdk8-javadoc" profile became mandatory.  Is there a
> > way to have it activated automatically when necessary (e.g. when compiling
> > with a JKD >= 8)?
> >
> > Gilles
>
> I’ve removed the linux distribution version of OpenJDK 9 and manually 
> installed OpenJDK 9, 10 and 11.
>
> I confirm these versions all require the --allow-script-in-comments option 
> for 'mvn javadoc:javadoc'. So I’ve reverted the pom.xml to put this back in 
> the profile for JDK 1.8+.
>
> I get a module error when building on OpenJDK 9:
>
> mvn -v
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 
> 2018-06-17T19:33:14+01:00)
> Maven home: /usr/local/apache-maven-3.5.4
> Java version: 9, vendor: Oracle Corporation, runtime: /usr/lib/jvm/jdk-9
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-142-generic", arch: "amd64", family: “unix"
>
> mvn clean site site:stage -Pcommons-rng-exampless
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Commons RNG 1.3-SNAPSHOT  SUCCESS [ 13.143 
> s]
> [INFO] Apache Commons RNG Client API .. SUCCESS [  8.144 
> s]
> [INFO] Apache Commons RNG Core  SUCCESS [ 19.623 
> s]
> [INFO] Apache Commons RNG Simple .. SUCCESS [ 13.773 
> s]
> [INFO] Apache Commons RNG Sampling  SUCCESS [01:07 
> min]
> [INFO] Apache Commons RNG Examples  SUCCESS [  3.871 
> s]
> [INFO] Stress test example  SUCCESS [  6.715 
> s]
> [INFO] Sampling example ... SUCCESS [  6.155 
> s]
> [INFO] Quadrature example . SUCCESS [  5.808 
> s]
> [INFO] JMH Benchmark .. SUCCESS [ 22.310 
> s]
> [INFO] JPMS Integration test .. SUCCESS [  1.895 
> s]
> [INFO] JPMS module example (library) .. FAILURE [  0.559 
> s]
> [INFO] JPMS module example (application) 1.3-SNAPSHOT . SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 02:49 min
> [INFO] Finished at: 2019-02-18T13:54:01Z
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on 
> project commons-rng-examples-jpms-lib: failed to get report for 
> org.apache.maven.plugins:maven-surefire-report-plugin: Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile 
> (default-compile) on project commons-rng-examples-jpms-lib: Compilation 
> failure: Compilation failure:
> [ERROR] 
> /home/ah403/git/commons-rng/commons-rng-examples/examples-jpms/jpms-lib/src/main/java/module-info.java:[18,36]
>  module not found: org.apache.commons.rng.api
> [ERROR] 
> /home/ah403/git/commons-rng/commons-rng-examples/examples-jpms/jpms-lib/src/main/java/module-info.java:[19,36]
>  module not found: org.apache.commons.rng.sampling
>
>
> I tried mvn 3.5.4 and 3.6.0.
>
> This can be reduced to just running:
>
> mvn compile in commons-rng-examples/examples-jpms

Works here (maven downloads the "1.3-SNAPSHOT" artefacts from the
Apache repository).

>
> Something about this machine setup does not like the modules setup. I had a 
> dig around and thought updating this module definition would work:
>
> module org.apache.commons.rng.examples.jpms.lib {
> requires org.apache.commons.rng;
> requires org.apache.commons.rng.sampling.distribution;
> exports org.apache.commons.rng.examples.jpms.lib;
> }
>
> The module currently requires ‘o.a.c.rng.api’ which doesn’t exist and 
> ‘o.a.c.rng.sampling’ which needs .distribution added to the end. But that 
> made no difference.
>
> I am going to try on another machine to get the modules built.

Try building from the top-level and adding the "package" goal:

$ mvn -Pcommons-rng examples clean package

Gilles

>>> [...]

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [LANG] Jenkins Pipeline DSL

[Matt Sicker]

The DSL allows you to break out into parallel stages or sequential
ones (or both). The log4net Jenkinsfile has an example of building
across multiple agents:

https://github.com/apache/logging-log4net/blob/feature/cd-pipeline/Jenkinsfile

On Mon, 18 Feb 2019 at 12:44, sebb  wrote:
>
> Seems worth trying.
>
> I suggest start with one project (i.e. Lang) and see how well it works.
>
> I assume there will need to be a once-off change to Jenkins to switch
> to using the DSL.
>
> Note that some components have multiple jobs, e.g. for different OSes and 
> JVMs.
> Does the DSL support such jobs? Or is that still done through the GUI?
>
> S.
>
> On Mon, 18 Feb 2019 at 18:05, Matt Sicker  wrote:
> >
> > +1. You could also make a shared library for reuse in commons projects.
> >
> > On Sun, 17 Feb 2019 at 14:41, Pascal Schumacher
> >  wrote:
> > >
> > > +1 to using a pipeline
> > >
> > > Am 17.02.2019 um 18:35 schrieb Benedikt Ritter:
> > > > Hi all,
> > > >
> > > > I feel like maintaining separate build descriptions on Jenkins is a 
> > > > PITA.
> > > > Any objections against adopting Jenkins Pipeline DSL for Lang?
> > > >
> > > > Regards,
> > > > Benedikt
> > > >
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: dev-h...@commons.apache.org
> > >
> >
> >
> > --
> > Matt Sicker 
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>


-- 
Matt Sicker 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [vfs] webdav4 extending http4 provider?

[Woonsan Ko]

On Mon, Feb 18, 2019 at 1:45 PM Gary Gregory  wrote:
>
> Hi Woonsan,
>
> Why disable existing tests?

I think the new Jackrabbit dependency 2.19.x would conflict with the
old one, 1.6.5.
Jackrabbit upgraded httpclient dependency to 4.x since 2.16.0 with no
changes in maven coordinates nor package names.
If we want to keep the existing tests for the webdav (based on
httpclient v3), perhaps we can introduce a new maven submodule (e.g,
commons-vfs2-webdav-tests) while keeping only the new tests for
webdav4 enabled in the main submodule. Or any better ideas?

Regards,

Woonsan

>
> Gary
>
> On Mon, Feb 18, 2019, 13:19 Woonsan Ko 
> > Hi,
> >
> > I'm trying to create a PR as a fix to VFS-686.
> > At first, I've tried to fix those in
> > org.apache.commons.vfs2.provider.webdav package, but realized that the
> > changes will break API compatibility. For example,
> > WebdavFileSystemConfigBuilder#getInstance() can't be supported as-is
> > obviously.
> >
> > So, I think we should do the following instead:
> > - Introduce org.apache.commons.vfs2.provider.webdav4 package like we
> > did for http4 FS provider in org.apache.commons.vfs2.provider.http4
> > package.
> > - Provide equivalent unit tests for the webdav4 provider, depending on
> > Jackrabbit 2.19.x+. (Also, see JCR-4401.)
> > - Disable the old unit tests for
> > org.apache.commons.vfs2.provider.webdav package, which is based on
> > http client v3, by default.
> >
> > How does it sound?
> >
> > Regards,
> >
> > Woonsan
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [vfs] webdav4 extending http4 provider?

[Gary Gregory]

Hi Woonsan,

Why disable existing tests?

Gary

On Mon, Feb 18, 2019, 13:19 Woonsan Ko  Hi,
>
> I'm trying to create a PR as a fix to VFS-686.
> At first, I've tried to fix those in
> org.apache.commons.vfs2.provider.webdav package, but realized that the
> changes will break API compatibility. For example,
> WebdavFileSystemConfigBuilder#getInstance() can't be supported as-is
> obviously.
>
> So, I think we should do the following instead:
> - Introduce org.apache.commons.vfs2.provider.webdav4 package like we
> did for http4 FS provider in org.apache.commons.vfs2.provider.http4
> package.
> - Provide equivalent unit tests for the webdav4 provider, depending on
> Jackrabbit 2.19.x+. (Also, see JCR-4401.)
> - Disable the old unit tests for
> org.apache.commons.vfs2.provider.webdav package, which is based on
> http client v3, by default.
>
> How does it sound?
>
> Regards,
>
> Woonsan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [LANG] Jenkins Pipeline DSL

[sebb]

Seems worth trying.

I suggest start with one project (i.e. Lang) and see how well it works.

I assume there will need to be a once-off change to Jenkins to switch
to using the DSL.

Note that some components have multiple jobs, e.g. for different OSes and JVMs.
Does the DSL support such jobs? Or is that still done through the GUI?

S.

On Mon, 18 Feb 2019 at 18:05, Matt Sicker  wrote:
>
> +1. You could also make a shared library for reuse in commons projects.
>
> On Sun, 17 Feb 2019 at 14:41, Pascal Schumacher
>  wrote:
> >
> > +1 to using a pipeline
> >
> > Am 17.02.2019 um 18:35 schrieb Benedikt Ritter:
> > > Hi all,
> > >
> > > I feel like maintaining separate build descriptions on Jenkins is a PITA.
> > > Any objections against adopting Jenkins Pipeline DSL for Lang?
> > >
> > > Regards,
> > > Benedikt
> > >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
>
> --
> Matt Sicker 
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[vfs] webdav4 extending http4 provider?

[Woonsan Ko]

Hi,

I'm trying to create a PR as a fix to VFS-686.
At first, I've tried to fix those in
org.apache.commons.vfs2.provider.webdav package, but realized that the
changes will break API compatibility. For example,
WebdavFileSystemConfigBuilder#getInstance() can't be supported as-is
obviously.

So, I think we should do the following instead:
- Introduce org.apache.commons.vfs2.provider.webdav4 package like we
did for http4 FS provider in org.apache.commons.vfs2.provider.http4
package.
- Provide equivalent unit tests for the webdav4 provider, depending on
Jackrabbit 2.19.x+. (Also, see JCR-4401.)
- Disable the old unit tests for
org.apache.commons.vfs2.provider.webdav package, which is based on
http client v3, by default.

How does it sound?

Regards,

Woonsan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [LANG] Jenkins Pipeline DSL

[Matt Sicker]

+1. You could also make a shared library for reuse in commons projects.

On Sun, 17 Feb 2019 at 14:41, Pascal Schumacher
 wrote:
>
> +1 to using a pipeline
>
> Am 17.02.2019 um 18:35 schrieb Benedikt Ritter:
> > Hi all,
> >
> > I feel like maintaining separate build descriptions on Jenkins is a PITA.
> > Any objections against adopting Jenkins Pipeline DSL for Lang?
> >
> > Regards,
> > Benedikt
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>


-- 
Matt Sicker 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] namannigam edited a comment on issue #65: Performance Enhancement: Call toArray with Zero Array Size

[GitBox]

namannigam edited a comment on issue #65: Performance Enhancement: Call toArray 
with Zero Array Size
URL: https://github.com/apache/commons-io/pull/65#issuecomment-464826047
 
 
   @kinow In Java-11, there has been an introduction to an API `default  T[] 
toArray(IntFunction generator)` which does internally calls the same 0 
sized array initialisation. 
   The construct for example in that case would be 
`list.toArray(String[]::new)` instead of `list.toArray(new String[0])`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] namannigam edited a comment on issue #65: Performance Enhancement: Call toArray with Zero Array Size

[GitBox]

namannigam edited a comment on issue #65: Performance Enhancement: Call toArray 
with Zero Array Size
URL: https://github.com/apache/commons-io/pull/65#issuecomment-464826047
 
 
   @kinow In Java-11, there has been an introduction to an API `default  T[] 
toArray(IntFunction generator)` which does internally calls the same 0 
sized array initialisation. 
   The construct for example in that case would be 
`list.toArray(String[]::new)` instead of `list.toArray(new String[0])`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] namannigam commented on issue #65: Performance Enhancement: Call toArray with Zero Array Size

[GitBox]

namannigam commented on issue #65: Performance Enhancement: Call toArray with 
Zero Array Size
URL: https://github.com/apache/commons-io/pull/65#issuecomment-464826047
 
 
   @kinow In Java-11, there has been an introduction to an API `default  T[] 
toArray(IntFunction generator)` which does internally calls the same 0 
sized array initialisation. 
   The construct for example would in that case be:
   `list.toArray(String[]::new)`
   instead of 
   `list.toArray(new String[0])`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] saschaszott commented on issue #100: TEXT-104: Jaro Winkler Distance refers to similarity

[GitBox]

saschaszott commented on issue #100: TEXT-104: Jaro Winkler Distance refers to 
similarity
URL: https://github.com/apache/commons-text/pull/100#issuecomment-464822954
 
 
   Hi @kinow , would you like to check if this PR can be merged. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity

[GitBox]

saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler 
Distance refers to similarity
URL: https://github.com/apache/commons-text/pull/100#discussion_r257781951
 
 

 ##
 File path: src/main/java/org/apache/commons/text/similarity/package-info.java
 ##
 @@ -29,6 +29,7 @@
  * {@link org.apache.commons.text.similarity.FuzzyScore Fuzzy Score}
  * {@link org.apache.commons.text.similarity.HammingDistance Hamming 
Distance}
  * {@link org.apache.commons.text.similarity.JaroWinklerDistance 
Jaro-Winkler Distance}
+ * {@link org.apache.commons.text.similarity.JaroWinklerSimilarity 
Jaro-Winkler Similarity}
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity

[GitBox]

saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler 
Distance refers to similarity
URL: https://github.com/apache/commons-text/pull/100#discussion_r257781239
 
 

 ##
 File path: 
src/main/java/org/apache/commons/text/similarity/JaroWinklerSimilarity.java
 ##
 @@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text.similarity;
+
+import java.util.Arrays;
+
+/**
+ * A similarity algorithm indicating the percentage of matched characters 
between two character sequences.
+ *
+ * 
+ * The Jaro measure is the weighted sum of percentage of matched characters
+ * from each file and transposed characters. Winkler increased this measure
+ * for matching initial characters.
+ * 
+ *
+ * 
+ * This implementation is based on the Jaro Winkler similarity algorithm
+ * from http://en.wikipedia.org/wiki/Jaro%E2%80%93Winkler_distance;>
+ * http://en.wikipedia.org/wiki/Jaro%E2%80%93Winkler_distance.
+ * 
+ *
+ * 
+ * This code has been adapted from Apache Commons Lang 3.3.
+ * 
+ *
+ * @since 1.7
+ */
+public class JaroWinklerSimilarity implements SimilarityScore {
+
+/**
+ * Computes the Jaro Winkler Similarity between two character sequences.
+ *
+ * 
+ * sim.apply(null, null)  = IllegalArgumentException
+ * sim.apply("foo", null) = IllegalArgumentException
+ * sim.apply(null, "foo") = IllegalArgumentException
+ * sim.apply("", "")  = 1.0
+ * sim.apply("foo", "foo")= 1.0
+ * sim.apply("foo", "foo ")   = 0.94
+ * sim.apply("foo", "foo  ")  = 0.91
+ * sim.apply("foo", " foo ")  = 0.87
+ * sim.apply("foo", "  foo")  = 0.51
+ * sim.apply("", "a") = 0.0
+ * sim.apply("aaa", "")   = 0.0
+ * sim.apply("frog", "fog")   = 0.93
+ * sim.apply("fly", "ant")= 0.0
+ * sim.apply("elephant", "hippo") = 0.44
+ * sim.apply("hippo", "elephant") = 0.44
+ * sim.apply("hippo", "") = 0.0
+ * sim.apply("hello", "hallo")= 0.88
+ * sim.apply("ABC Corporation", "ABC Corp") = 0.93
+ * sim.apply("D N H Enterprises Inc", "D  H Enterprises, Inc.") = 0.95
+ * sim.apply("My Gym Children's Fitness Center", "My Gym. Childrens 
Fitness") = 0.92
+ * sim.apply("PENNSYLVANIA", "PENNCISYLVNIA") = 0.88
+ * 
+ *
+ * @param left the first CharSequence, must not be null
+ * @param right the second CharSequence, must not be null
+ * @return result similarity
+ * @throws IllegalArgumentException if either CharSequence input is {@code 
null}
+ */
+@Override
+public Double apply(final CharSequence left, final CharSequence right) {
+final double defaultScalingFactor = 0.1;
+
+if (left == null || right == null) {
+throw new IllegalArgumentException("CharSequences must not be 
null");
+}
+
+if (left.equals(right)) {
+return 1D;
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity

[GitBox]

saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler 
Distance refers to similarity
URL: https://github.com/apache/commons-text/pull/100#discussion_r257780047
 
 

 ##
 File path: 
src/main/java/org/apache/commons/text/similarity/JaroWinklerDistance.java
 ##
 @@ -73,84 +57,13 @@
  * @throws IllegalArgumentException if either CharSequence input is {@code 
null}
  */
 @Override
-public Double apply(final CharSequence left, final CharSequence right) {
-final double defaultScalingFactor = 0.1;
+public Double apply(CharSequence left, CharSequence right) {
 
 if (left == null || right == null) {
 throw new IllegalArgumentException("CharSequences must not be 
null");
 }
 
-final int[] mtp = matches(left, right);
-final double m = mtp[0];
-if (m == 0) {
-return 0D;
-}
-final double j = ((m / left.length() + m / right.length() + (m - 
(double) mtp[1] / 2) / m)) / 3;
-final double jw = j < 0.7D ? j : j + defaultScalingFactor * mtp[2] * 
(1D - j);
-return jw;
-}
-
-/**
- * This method returns the Jaro-Winkler string matches, half 
transpositions, prefix array.
- *
- * @param first the first string to be matched
- * @param second the second string to be matched
- * @return mtp array containing: matches, half transpositions, and prefix
- */
-protected static int[] matches(final CharSequence first, final 
CharSequence second) {
-CharSequence max, min;
-if (first.length() > second.length()) {
-max = first;
-min = second;
-} else {
-max = second;
-min = first;
-}
-final int range = Math.max(max.length() / 2 - 1, 0);
-final int[] matchIndexes = new int[min.length()];
-Arrays.fill(matchIndexes, -1);
-final boolean[] matchFlags = new boolean[max.length()];
-int matches = 0;
-for (int mi = 0; mi < min.length(); mi++) {
-final char c1 = min.charAt(mi);
-for (int xi = Math.max(mi - range, 0), xn = Math.min(mi + range + 
1, max.length()); xi < xn; xi++) {
-if (!matchFlags[xi] && c1 == max.charAt(xi)) {
-matchIndexes[mi] = xi;
-matchFlags[xi] = true;
-matches++;
-break;
-}
-}
-}
-final char[] ms1 = new char[matches];
-final char[] ms2 = new char[matches];
-for (int i = 0, si = 0; i < min.length(); i++) {
-if (matchIndexes[i] != -1) {
-ms1[si] = min.charAt(i);
-si++;
-}
-}
-for (int i = 0, si = 0; i < max.length(); i++) {
-if (matchFlags[i]) {
-ms2[si] = max.charAt(i);
-si++;
-}
-}
-int halfTranspositions = 0;
-for (int mi = 0; mi < ms1.length; mi++) {
-if (ms1[mi] != ms2[mi]) {
-halfTranspositions++;
-}
-}
-int prefix = 0;
-for (int mi = 0; mi < Math.min(4, min.length()); mi++) {
-if (first.charAt(mi) == second.charAt(mi)) {
-prefix++;
-} else {
-break;
-}
-}
-return new int[] {matches, halfTranspositions, prefix};
+JaroWinklerSimilarity jwSim = new JaroWinklerSimilarity();
 
 Review comment:
   changed name to `similarity`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Jakarta EE TCKs and compatibility logo

[Rob Tompkins]

I’m uncertain here.

-Rob

> On Feb 18, 2019, at 10:42 AM, Benedikt Ritter  wrote:
> 
> Hi,
> 
> Which of our components implement Java EE APIs? I see:
> 
> - BSF: not sure anybody is actively working on this
> - JCS: I've seen some activity
> 
> Anything else?
> 
> Benedikt
> 
> Am So., 17. Feb. 2019 um 20:01 Uhr schrieb Mark Thomas :
> 
>> Ping.
>> 
>> Just a gentle reminder as I haven't seen any emails to jcp-open@ as yet.
>> 
>> Mark
>> 
>> PS If you don't want to build from source, there are nightly TCK builds
>> available here:
>> https://download.eclipse.org/ee4j/jakartaee-tck/8.0.1/nightly/
>> 
>> 
>> On 21/01/2019 10:46, Mark Thomas wrote:
>>> Apologies for the noise.
>>> 
>>> The correct link for [3] is:
>>> 
>>> https://jakarta.ee/legal/trademark_guidelines/
>>> 
>>> I've also corrected a handful of the project BCCs.
>>> 
>>> Mark
>>> 
>>> 
>>> On 18/01/2019 22:53, Mark Thomas wrote:
 Hi all,
 
 I am writing to your dev@ lists (on BCC) as your project has, in the
 past, requested access to the Java EE TCKs while they were controlled by
 Sun and then Oracle.
 
 As I am sure you are aware, Java EE has moved to Eclipse and is now
 Jakarta EE. The good news is that the TCKs have been open sourced.
 
 https://github.com/eclipse-ee4j/jakartaee-tck
 
 (I haven't tried to build the latest TCK from source yet but it is on my
 TODO list.)
 
 Shipping compatible implementations of the Jakarta EE specs (and being
 able to make public statements to that effect) will be subject only to
 the spec [1] and TCK [2] licenses. There will no longer be a TCK
 agreement or NDA to sign. However...
 
 The question has arisen whether or not any ASF projects will want to use
 the Jakarta EE compatible logo [3]. If a project wants to be able to do
 this, there are some organisational hoops to jump through. Before the
 ASF starts down that path the board has asked me to see if there are any
 projects that want to use the Jakarta EE compatible logo. After all,
 there is no point jumping through the hoops if no-one wants to use the
>> logo.
 
 With the above in mind can you please discuss this amongst your project
 community and reply back to jcp-o...@apache.org whether or not your
 project is interested in being able to use the Jakarta EE compatible
 logo. I ask that you complete this no later than the next board meeting
 (20th February 2019).
 
 If you have any questions about any of the above, please also use
 jcp-o...@apache.org to ask them.
 
 Thanks,
 
 Mark
 
 
 [1] https://www.eclipse.org/legal/efsl.php
 [2] https://www.eclipse.org/legal/tck.php
 [3] https://www.eclipse.org/legal/tck.php
 
>>> 
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Jakarta EE TCKs and compatibility logo

[Benedikt Ritter]

Hi,

Which of our components implement Java EE APIs? I see:

- BSF: not sure anybody is actively working on this
- JCS: I've seen some activity

Anything else?

Benedikt

Am So., 17. Feb. 2019 um 20:01 Uhr schrieb Mark Thomas :

> Ping.
>
> Just a gentle reminder as I haven't seen any emails to jcp-open@ as yet.
>
> Mark
>
> PS If you don't want to build from source, there are nightly TCK builds
> available here:
> https://download.eclipse.org/ee4j/jakartaee-tck/8.0.1/nightly/
>
>
> On 21/01/2019 10:46, Mark Thomas wrote:
> > Apologies for the noise.
> >
> > The correct link for [3] is:
> >
> > https://jakarta.ee/legal/trademark_guidelines/
> >
> > I've also corrected a handful of the project BCCs.
> >
> > Mark
> >
> >
> > On 18/01/2019 22:53, Mark Thomas wrote:
> >> Hi all,
> >>
> >> I am writing to your dev@ lists (on BCC) as your project has, in the
> >> past, requested access to the Java EE TCKs while they were controlled by
> >> Sun and then Oracle.
> >>
> >> As I am sure you are aware, Java EE has moved to Eclipse and is now
> >> Jakarta EE. The good news is that the TCKs have been open sourced.
> >>
> >> https://github.com/eclipse-ee4j/jakartaee-tck
> >>
> >> (I haven't tried to build the latest TCK from source yet but it is on my
> >> TODO list.)
> >>
> >> Shipping compatible implementations of the Jakarta EE specs (and being
> >> able to make public statements to that effect) will be subject only to
> >> the spec [1] and TCK [2] licenses. There will no longer be a TCK
> >> agreement or NDA to sign. However...
> >>
> >> The question has arisen whether or not any ASF projects will want to use
> >> the Jakarta EE compatible logo [3]. If a project wants to be able to do
> >> this, there are some organisational hoops to jump through. Before the
> >> ASF starts down that path the board has asked me to see if there are any
> >> projects that want to use the Jakarta EE compatible logo. After all,
> >> there is no point jumping through the hoops if no-one wants to use the
> logo.
> >>
> >> With the above in mind can you please discuss this amongst your project
> >> community and reply back to jcp-o...@apache.org whether or not your
> >> project is interested in being able to use the Jakarta EE compatible
> >> logo. I ask that you complete this no later than the next board meeting
> >> (20th February 2019).
> >>
> >> If you have any questions about any of the above, please also use
> >> jcp-o...@apache.org to ask them.
> >>
> >> Thanks,
> >>
> >> Mark
> >>
> >>
> >> [1] https://www.eclipse.org/legal/efsl.php
> >> [2] https://www.eclipse.org/legal/tck.php
> >> [3] https://www.eclipse.org/legal/tck.php
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [Rng] README.md and broken javadoc link

[Alex Herbert]

> On 17 Feb 2019, at 23:25, Gilles Sadowski  wrote:
> 
> Hello.
> 
> Le dim. 17 févr. 2019 à 23:57, Alex Herbert  > a écrit :
>> 
>> Hi Gilles,
>> 
>> This is related to the fix I made for MathJax. It apparently is not as 
>> simple as I thought, i.e. this was a hidden tag only for JDK 8. This tag is 
>> not officially documented so there is no official solution, only what you 
>> can find on the web.
>> 
>> I had installed openJDK 9 on my linux machine to test building the JMS 
>> modules. I had to remove the --allow-script-in-comments tag to get it to 
>> build the javadocs. So I changed the latest pom.xml for commons-rng-parent 
>> to only add the tag on JDK 1.8. I found that if I had that tag on open JDK 9 
>> the following fails:
>> 
>> mvn -v
>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 
>> 2018-06-17T19:33:14+01:00)
>> Maven home: /usr/local/apache-maven-3.5.4
>> Java version: 9-internal, vendor: Oracle Corporation, runtime: 
>> /usr/lib/jvm/java-9-openjdk-amd64
>> Default locale: en_GB, platform encoding: UTF-8
>> OS name: "linux", version: "4.4.0-142-generic", arch: "amd64", family: "unix"
>> 
>> java -version
>> openjdk version "9-internal"
>> OpenJDK Runtime Environment (build 9-internal+0-2016-04-14-195246.buildd.src)
>> OpenJDK 64-Bit Server VM (build 9-internal+0-2016-04-14-195246.buildd.src, 
>> mixed mode)
>> 
>> mvn javadoc:javadoc
>> 
>> Is OK.
>> 
>> mvn javadoc:javadoc -Pjdk8-javadoc
>> 
>> Does NOT work.
>> 
>> I have just tried:
>> 
>> mvn clean site site:stage -Pcommons-rng-examples
>> 
>> This is fails on the client-api module with this weird error running the 
>> findbugs report:
>> 
>> [INFO] Fork Value is true
>> [java] Exception in thread "main" java.io.IOException: IOException while 
>> scanning codebases
>> [java] at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:282)
>> [java] at edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:401)
>> [java] at edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1187)
>> [java] Caused by: 
>> edu.umd.cs.findbugs.classfile.ResourceNotFoundException: Resource not found: 
>> java/lang/Object.class
>> [java] at 
>> edu.umd.cs.findbugs.classfile.impl.ClassPathImpl.lookupResource(ClassPathImpl.java:164)
>> [java] at 
>> edu.umd.cs.findbugs.classfile.impl.ClassPathBuilder.build(ClassPathBuilder.java:282)
>> [java] at 
>> edu.umd.cs.findbugs.FindBugs2.buildClassPath(FindBugs2.java:674)
>> [java] at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:215)
>> [java] ... 2 more
>> 
>> So the I am thinking the jdk9 install I am using is broken and probably too 
>> old to have the hidden --allow-script-in-comments option for javadoc.
>> 
>> You could try running with the 'jdk8-javadoc’ profile on your java 9 and see 
>> if that fixes the problem for you.
>> 
>> Can you let me know what version of java 9 you are using?
> 
> Command
>  $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64/ mvn
> -Pcommons-rng-examples -Pjdk8-javadoc clean package site site:stage
> works on
> $ /usr/lib/jvm/java-9-openjdk-amd64/bin/java -version
> openjdk version "9-Debian"
> OpenJDK Runtime Environment (build 9-Debian+0-9b181-4bpo91)
> OpenJDK 64-Bit Server VM (build 9-Debian+0-9b181-4bpo91, mixed mode)
> 
> I missed when the "jdk8-javadoc" profile became mandatory.  Is there a
> way to have it activated automatically when necessary (e.g. when compiling
> with a JKD >= 8)?
> 
> Gilles

I’ve removed the linux distribution version of OpenJDK 9 and manually installed 
OpenJDK 9, 10 and 11.

I confirm these versions all require the --allow-script-in-comments option for 
'mvn javadoc:javadoc'. So I’ve reverted the pom.xml to put this back in the 
profile for JDK 1.8+. 

I get a module error when building on OpenJDK 9:

mvn -v
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 
2018-06-17T19:33:14+01:00)
Maven home: /usr/local/apache-maven-3.5.4
Java version: 9, vendor: Oracle Corporation, runtime: /usr/lib/jvm/jdk-9
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-142-generic", arch: "amd64", family: “unix"

mvn clean site site:stage -Pcommons-rng-exampless

[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Commons RNG 1.3-SNAPSHOT  SUCCESS [ 13.143 s]
[INFO] Apache Commons RNG Client API .. SUCCESS [  8.144 s]
[INFO] Apache Commons RNG Core  SUCCESS [ 19.623 s]
[INFO] Apache Commons RNG Simple .. SUCCESS [ 13.773 s]
[INFO] Apache Commons RNG Sampling  SUCCESS [01:07 min]
[INFO] Apache Commons RNG Examples  SUCCESS [  3.871 s]
[INFO] Stress test example  SUCCESS [  6.715 s]
[INFO] Sampling example ... SUCCESS [  6.155 s]
[INFO] Quadrature example . SUCCESS [  5.808 s]
[INFO] JMH 

Re: [VOTE] Release Apache Commons DBCP 2.6.0 based on RC1

[Gary Gregory]

My +1

Gary

On Fri, Feb 15, 2019 at 11:01 AM Gary Gregory  wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons DBCP 2.5.0 was released, so I would like to release
> Apache Commons DBCP 2.6.0.
>
> Apache Commons DBCP 2.6.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1 (svn
> revision 32518)
>
> The Git tag commons-dbcp-2.6.0-RC1 commit for this RC is
> 3e7fca08d3585aa7cf70045ee3ed607cbaf04baa which you can browse here:
>
> https://github.com/apache/commons-dbcp/releases/tag/commons-dbcp-2.6.0-RC1
>
> Maven artifacts are here:
>
> https://gitbox.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.6.0-RC1
>
> https://repository.apache.org/content/repositories/orgapachecommons-1425/org/apache/commons/commons-dbcp2/2.6.0/
>
> These are the Maven artifacts and their hashes in Nexus:
>
> #Release SHA-512s
> #Fri Feb 15 10:46:39 EST 2019
>
> commons-dbcp2-2.6.0-src-tar.gz=edf28b1a7fecaa8149a00f796e1116f72ee502ab24853c623b397ea07fc4c63408f31930e24a9abd43edbdfcd4c17b16559a5ffcba01c954f5161c96eb860f74
>
> commons-dbcp2-2.6.0-src-tar.gz.asc=d991126ab89f8b594da690e12cdb5ef05dde4e78f575f35284cc195349d3b438a47c7648d0e3189ff37d1cfdeac48f3d929fd0af46ad146911a25207ab36301b
>
> commons-dbcp2-2.6.0-tests-test-jar=ee304fd225d3a850c96b88d84195d26fd11370e529b9699b554e38dcef87be1006695bf818cb44ea7cd90e5ac65db59a1e656869e711fb1cd11d95727886d265
>
> commons-dbcp2-2.6.0-test-sources-java-source=fe3c9367446ed44e06f2328e890517ad1818bbc6f8a53cbde8410c2d6308937f889bb164a2d76ff90837befcdccdff410a1c4de17e92a05b1a395c79b1f84325
>
> commons-dbcp2-2.6.0-bin-tar.gz=3231c0431ed683bd99cb5b24ad6fa18a2693e39a23f22f6d36e30e54ec3b2dd2f7320c98e345577385443d30bf9d6d857e9b768107ba353048cce3651e6f4c9e
>
> commons-dbcp2-2.6.0-bin-tar.gz.asc=26e7f73436db583d6cdfe8037d5afeb43fdd67c0712bd915806427aa291921b39868614f16fb900a6d7266c541be3eae63bc5f152661fbe3341615a6bffa503e
>
> commons-dbcp2-2.6.0-javadoc-javadoc=31d7af557c41adfcd6fce58282ae2b5f045f278a5f829ad5661e31c80137f9b32e3eb29a5088c542a5664de882a6de816ed5daa4ebae233fed16d2688f66b016
>
> commons-dbcp2-2.6.0-src-zip.asc=98434d9d165a85f4bd7f2cdaaa776204bd274dd919d22e7542ee9b98a84323236f05946e01dcd31c430b3fb028b3c8b30be733d49e4f0bc9324bd27782f3c1e3
>
> commons-dbcp2-2.6.0-test-sources-jar.asc=668b378078ea24407a9ccd2e76479bec54db722408276fc343f25df7b3679f84ccf2548b843a57f49a5e73e542d70f1b16306838c18b123a005e0055a5e2f5dc
>
> commons-dbcp2-2.6.0-src-zip=955514067b4e774e53aecc906d3497f4e966b0abf76d61d2abc600957d42c5151e0c21c660ebc6d86a35ae78e41d710819ba9dbd67bc39b701004239c89c34e8
>
> commons-dbcp2-2.6.0-tests-jar.asc=99efeb6ae0c576389270655967484fde298b59a1da62f25e6b308e867cdc9f7ecc0a8281820a7d070776acf3d2be6f7d445bc1a7cd2270883d6a05684c8519f1
>
> commons-dbcp2-2.6.0-jar.asc=c88950da16bd1ed5ff6f7eb06eead26dff3fe864f5a4830537d49f61d99afc46491cba5c1af6b09815bbe5b33001f6ccaec0bf9f30d29ea25684aa81f0ae7267
>
> commons-dbcp2-2.6.0-sources-java-source=971ff6b43e91d4350d14ec4fbb25da5c4a3e73469fa1834b26c2cdda9b2ddf4037370a73e9b51abed61f4e59f43e0600409082ae85e88f598418249cd5d227e9
>
> commons-dbcp2-2.6.0-sources-jar.asc=0f12bab2270e5569ed6260f646f3bd5d830b35d517363578f842232842fa48e62c579f8ae44ef2b7dc82fadb38191c346bf1f4e512358768c23259fca42d96d8
>
> commons-dbcp2-2.6.0-bin-zip=d115146bea6026ed26a5944e99448427c31d89a147b85a4fcf6e24fc8c42a26d0afa5b1485a64b67243493f2cb4f183b636ff35f7576757d079d7c18502c1761
>
> commons-dbcp2-2.6.0-bin-zip.asc=3ac3e77075134175daaf015d98bcd259a4db8330d0985614f015f5a273c32ef2d12dd673485c73239e8f5b3ce55a7b944cfdcdff599a9b2c5e9ec793c13091cd
>
> commons-dbcp2-2.6.0-pom.asc=b567be342c4736663f170f00abdaf399ec6020115288710aaa611ebbecfe4d1680b2c5ca48e09e0228b2b9122491e47b52b78858a1c91ac21cdd569444eca3a1
>
> commons-dbcp2-2.6.0-javadoc-jar.asc=ac4930c222543406378dd2a83ee58d4b39985b974dfaee5489e2af7d6a3d555be5e6d30a81ed6414235abb1c7031e9981e1164cf5807ac1d7f303421d7017cd8
>
>
> (no need for .asc hashes!)
>
> I have tested this with 'mvn clean install site' using:
>
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
> 2018-10-24T14:41:47-04:00)
> Maven home: C:\Java\apache-maven-3.6.0\bin\..
> Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_202\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> and the 'mvn test -Dcommons.jacoco.version=0.8.3' using:
>
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
> 2018-10-24T14:41:47-04:00)
> Maven home: C:\Java\apache-maven-3.6.0\bin\..
> Java version: 11.0.2, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk-11.0.2
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 2.5.0 are in the release notes:
>
> 

JDK 12: First Release Candidate available

[Rory O'Donnell]

  Hi Benedikt,

**OpenJDK builds *- JDK 12 Early Access build 32 **is now available **at 
: - jdk.java.net/12/*

**JDK 12:  First Release Candidate [1]**

 * Per the JDK 12 schedule [2], we are now in Release Candidate Phase.
 * The stabilization repository, jdk/jdk12, is open for P1 bug fixes
   per the JDK Release Process (JEP 3) [3].
 * All changes require approval via the Fix-Request Process [4].
 *
   Release note additions since last email

 o
   Build 31 - can_pop_frame and can_force_early_return capabilities
   are disabled if JVMCI compiler is used (JDK-8218025
   ) The JVMTI
   |can_pop_frame| and |can_force_early_return| capabilities are
   disabled if a JVMCI compiler (like Graal) is used. As a result
   the corresponding functionality (|PopFrame| and
   |ForceEarlyReturnXXX| functions) is not available to JVMTI
   agents. This issue is being fixed via JDK-8218885
   
   [https://bugs.openjdk.java.net/browse/JDK-8218885
   ].

 o Build 28: JDK-8212233
    : javadoc
   fails on jdk12 with "The code being documented uses modules but
   the packages defined in $URL are in the unnamed module."
 * Changes in this build.
   


**OpenJDK builds *- JDK 13 Early Access build 8 is **now available **at 
: - jdk.java.net/13/*


 * These early-access, open-source builds are provided under the
 o GNU General Public License, version 2, with the Classpath
   Exception .
 * Release Notes updates
 * Build 8
 o GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds()
   are unified across the platforms (JDK-8214918
   )
 o The experimental FIPS 140 compliant mode has been removed from
   the SunJSSE provider. (JDK-8217835
   )
 * Build 7
 o Change DOM parser to not resolve EntityReference and add Text
   node with
   DocumentBuilderFactory.setExpandEntityReferences(false)
   (JDK-8206132 )
 * Build 6
 o Base64.Encoder and Base64.Decoder methods can throw
   OutOfMemoryError (JDK-8210583
   )
 * Changes in this build
   

 * FOSS Bugs fixed in recent builds
 o Build 6 : JDK-8216970
    : condy
   causes JVM crash
 o Build 7: JDK-8215577
    : Remove
   javadoc support for HTML 4


Rgds,Rory

[1] 
https://mail.openjdk.java.net/pipermail/jdk-dev/2019-February/002623.html

[2] http://openjdk.java.net/projects/jdk/12/#Schedule
[3] http://openjdk.java.net/jeps/3
[4] http://openjdk.java.net/jeps/3#Fix-Request-Process

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland

Re: [Rng] README.md and broken javadoc link

[Alex Herbert]

Hi Gilles,

> On 17 Feb 2019, at 23:25, Gilles Sadowski  wrote:
> 
> Hello.
> 
>> Le dim. 17 févr. 2019 à 23:57, Alex Herbert  a 
>> écrit :
>> 
>> Hi Gilles,
>> 
>> This is related to the fix I made for MathJax. It apparently is not as 
>> simple as I thought, i.e. this was a hidden tag only for JDK 8. This tag is 
>> not officially documented so there is no official solution, only what you 
>> can find on the web.
>> 
>> I had installed openJDK 9 on my linux machine to test building the JMS 
>> modules. I had to remove the --allow-script-in-comments tag to get it to 
>> build the javadocs. So I changed the latest pom.xml for commons-rng-parent 
>> to only add the tag on JDK 1.8. I found that if I had that tag on open JDK 9 
>> the following fails:
>> 
>> mvn -v
>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 
>> 2018-06-17T19:33:14+01:00)
>> Maven home: /usr/local/apache-maven-3.5.4
>> Java version: 9-internal, vendor: Oracle Corporation, runtime: 
>> /usr/lib/jvm/java-9-openjdk-amd64
>> Default locale: en_GB, platform encoding: UTF-8
>> OS name: "linux", version: "4.4.0-142-generic", arch: "amd64", family: "unix"
>> 
>> java -version
>> openjdk version "9-internal"
>> OpenJDK Runtime Environment (build 9-internal+0-2016-04-14-195246.buildd.src)
>> OpenJDK 64-Bit Server VM (build 9-internal+0-2016-04-14-195246.buildd.src, 
>> mixed mode)
>> 
>> mvn javadoc:javadoc
>> 
>> Is OK.
>> 
>> mvn javadoc:javadoc -Pjdk8-javadoc
>> 
>> Does NOT work.
>> 
>> I have just tried:
>> 
>> mvn clean site site:stage -Pcommons-rng-examples
>> 
>> This is fails on the client-api module with this weird error running the 
>> findbugs report:
>> 
>> [INFO] Fork Value is true
>> [java] Exception in thread "main" java.io.IOException: IOException while 
>> scanning codebases
>> [java] at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:282)
>> [java] at edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:401)
>> [java] at edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1187)
>> [java] Caused by: 
>> edu.umd.cs.findbugs.classfile.ResourceNotFoundException: Resource not found: 
>> java/lang/Object.class
>> [java] at 
>> edu.umd.cs.findbugs.classfile.impl.ClassPathImpl.lookupResource(ClassPathImpl.java:164)
>> [java] at 
>> edu.umd.cs.findbugs.classfile.impl.ClassPathBuilder.build(ClassPathBuilder.java:282)
>> [java] at 
>> edu.umd.cs.findbugs.FindBugs2.buildClassPath(FindBugs2.java:674)
>> [java] at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:215)
>> [java] ... 2 more
>> 
>> So the I am thinking the jdk9 install I am using is broken and probably too 
>> old to have the hidden --allow-script-in-comments option for javadoc.
>> 
>> You could try running with the 'jdk8-javadoc’ profile on your java 9 and see 
>> if that fixes the problem for you.
>> 
>> Can you let me know what version of java 9 you are using?
> 
> Command
>  $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64/ mvn
> -Pcommons-rng-examples -Pjdk8-javadoc clean package site site:stage
> works on
> $ /usr/lib/jvm/java-9-openjdk-amd64/bin/java -version
> openjdk version "9-Debian"
> OpenJDK Runtime Environment (build 9-Debian+0-9b181-4bpo91)
> OpenJDK 64-Bit Server VM (build 9-Debian+0-9b181-4bpo91, mixed mode)
> 
> I missed when the "jdk8-javadoc" profile became mandatory.  Is there a
> way to have it activated automatically when necessary (e.g. when compiling
> with a JKD >= 8)?

Yes, it was originally put in the profile with the checkstyle configuration for 
any JDK from 8 onwards. I made the new profile because it worked on my machine 
that way with java 9. It would appear that my version of Java 9 is old and is 
missing the requirement for the --allow-script-in-comments tag.

I’ll update my JDK 9, verify I can do the full build and revert the parent 
Pom.xml.

Alex

> 
> Gilles
> 
>> 
>> Alex
>> 
>> 
>>> On 17 Feb 2019, at 22:03, Gilles Sadowski  wrote:
>>> 
>>> Hi Alex.
>>> 
>>> I tried to regenerate the site but the build fails:
>>> ---CUT---
>>> [INFO] Reactor Summary:
>>> [INFO]
>>> [INFO] Apache Commons RNG . SUCCESS [ 
>>> 21.050 s]
>>> [INFO] Apache Commons RNG Client API .. FAILURE [  
>>> 7.723 s]
>>> [INFO] Apache Commons RNG Core  SKIPPED
>>> [INFO] Apache Commons RNG Simple .. SKIPPED
>>> [INFO] Apache Commons RNG Sampling  SKIPPED
>>> [INFO] Apache Commons RNG Examples  SKIPPED
>>> [INFO] Stress test example  SKIPPED
>>> [INFO] Sampling example ... SKIPPED
>>> [INFO] Quadrature example . SKIPPED
>>> [INFO] JMH Benchmark .. SKIPPED
>>> [INFO] JPMS Integration test .. SKIPPED
>>> [INFO] JPMS module example (library) .. SKIPPED
>>>