Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"
Hello. Le lun. 14 juin 2021 à 00:37, John Patrick a écrit : > > So I want to start using Java 11 and take advantage of Java Modules. But > with a bug in Java Multi-Jar not supporting 1.8 as base and 11 upon that, > and most dependencies I want to upgrade eventually get stuck on a commons > project holding a pure JPMS solution. > > Potentially someone raise an enhancement to drop support for Java 1.8 which > isn't happening for Java 17, but for Java 18 which is only 8 month away it > could happen. So at that point it might be a shock for commons projects as > you might be blocking open source projects, or they roll off commons > projects... just a thought. > > I've tried to do a seamless upgrade, or suggest a roadmap, but haven't got > anywhere, but think I might just raise a JEP to drop 1.8 in Java 18... I'm not sure I don't understand what you mean. If it's about the possiblity to use JPMS: "Commons RNG" project has an example[1] showing that it seems to work when the code is used within a Java 9+ environment, even though the component itself is still targetted at Java 1.6. Regards, Gilles [1] https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=tree;f=commons-rng-examples/examples-jpms;h=64999d7bd370e374fbe801d8bc376ba17ea55970;hb=HEAD >>> [...] - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"
On Sun, 13 Jun 2021 at 23:37, John Patrick wrote: > > So I want to start using Java 11 and take advantage of Java Modules. But > with a bug in Java Multi-Jar not supporting 1.8 as base and 11 upon that, > and most dependencies I want to upgrade eventually get stuck on a commons > project holding a pure JPMS solution. > > Potentially someone raise an enhancement to drop support for Java 1.8 which > isn't happening for Java 17, but for Java 18 which is only 8 month away it > could happen. So at that point it might be a shock for commons projects as > you might be blocking open source projects, or they roll off commons > projects... just a thought. > > I've tried to do a seamless upgrade, or suggest a roadmap, but haven't got > anywhere, but think I might just raise a JEP to drop 1.8 in Java 18... So Java is no longer always upwards compatible? I thought it was supposed to be "Write once, run anywhere". ? > John > > > On Thu, 10 Jun 2021 at 14:07, Gilles Sadowski wrote: > > > Le jeu. 10 juin 2021 à 14:42, John Patrick a > > écrit : > > > > > > If the tests are valid and useful once post Java 1.8, what about > > > starting the next release branch where the min version bumps to Java > > > 11. > > > > [Numbers] and related components were meant to replace and > > improve some functionalities provided in [Math] v3.6.1 whose > > target was Java 5 (!). > > A few years ago, the bump to Java 8 was considered a bold move > > (for "Commons"). :-} > > > > If we are sure that Java 11 is no problem for anyone who'd go > > through the upgrade effort, then indeed why not? > > > > Gilles > > > > > As Java 17 starting ramp down starts today I believe so in 3 months we > > > will have 3 LTS (1.8, 11 and 17) releases. So technically Java 18 > > > development starts tomorrow and I expect 1.8 will be dropped shortly > > > from backwards support as they want to get off the classpath fully and > > > onto the modules path. > > > > > > Anyway, just a thought. > > > > > > John > > > > > > On Thu, 10 Jun 2021 at 12:05, sebb wrote: > > > > > > > > Thanks. > > > > > > > > I've updated the RELEASE-NOTES accordingly (feel free to tweak the > > text) > > > > > > > > On Thu, 10 Jun 2021 at 00:58, Alex Herbert > > wrote: > > > > > > > > > > I have removed the requirement for Java 9 from the build. It is > > still used > > > > > in the performance testing module. > > > > > > > > > > Alex > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"
So I want to start using Java 11 and take advantage of Java Modules. But with a bug in Java Multi-Jar not supporting 1.8 as base and 11 upon that, and most dependencies I want to upgrade eventually get stuck on a commons project holding a pure JPMS solution. Potentially someone raise an enhancement to drop support for Java 1.8 which isn't happening for Java 17, but for Java 18 which is only 8 month away it could happen. So at that point it might be a shock for commons projects as you might be blocking open source projects, or they roll off commons projects... just a thought. I've tried to do a seamless upgrade, or suggest a roadmap, but haven't got anywhere, but think I might just raise a JEP to drop 1.8 in Java 18... John On Thu, 10 Jun 2021 at 14:07, Gilles Sadowski wrote: > Le jeu. 10 juin 2021 à 14:42, John Patrick a > écrit : > > > > If the tests are valid and useful once post Java 1.8, what about > > starting the next release branch where the min version bumps to Java > > 11. > > [Numbers] and related components were meant to replace and > improve some functionalities provided in [Math] v3.6.1 whose > target was Java 5 (!). > A few years ago, the bump to Java 8 was considered a bold move > (for "Commons"). :-} > > If we are sure that Java 11 is no problem for anyone who'd go > through the upgrade effort, then indeed why not? > > Gilles > > > As Java 17 starting ramp down starts today I believe so in 3 months we > > will have 3 LTS (1.8, 11 and 17) releases. So technically Java 18 > > development starts tomorrow and I expect 1.8 will be dropped shortly > > from backwards support as they want to get off the classpath fully and > > onto the modules path. > > > > Anyway, just a thought. > > > > John > > > > On Thu, 10 Jun 2021 at 12:05, sebb wrote: > > > > > > Thanks. > > > > > > I've updated the RELEASE-NOTES accordingly (feel free to tweak the > text) > > > > > > On Thu, 10 Jun 2021 at 00:58, Alex Herbert > wrote: > > > > > > > > I have removed the requirement for Java 9 from the build. It is > still used > > > > in the performance testing module. > > > > > > > > Alex > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"
Le jeu. 10 juin 2021 à 14:42, John Patrick a écrit : > > If the tests are valid and useful once post Java 1.8, what about > starting the next release branch where the min version bumps to Java > 11. [Numbers] and related components were meant to replace and improve some functionalities provided in [Math] v3.6.1 whose target was Java 5 (!). A few years ago, the bump to Java 8 was considered a bold move (for "Commons"). :-} If we are sure that Java 11 is no problem for anyone who'd go through the upgrade effort, then indeed why not? Gilles > As Java 17 starting ramp down starts today I believe so in 3 months we > will have 3 LTS (1.8, 11 and 17) releases. So technically Java 18 > development starts tomorrow and I expect 1.8 will be dropped shortly > from backwards support as they want to get off the classpath fully and > onto the modules path. > > Anyway, just a thought. > > John > > On Thu, 10 Jun 2021 at 12:05, sebb wrote: > > > > Thanks. > > > > I've updated the RELEASE-NOTES accordingly (feel free to tweak the text) > > > > On Thu, 10 Jun 2021 at 00:58, Alex Herbert wrote: > > > > > > I have removed the requirement for Java 9 from the build. It is still used > > > in the performance testing module. > > > > > > Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"
If the tests are valid and useful once post Java 1.8, what about starting the next release branch where the min version bumps to Java 11. As Java 17 starting ramp down starts today I believe so in 3 months we will have 3 LTS (1.8, 11 and 17) releases. So technically Java 18 development starts tomorrow and I expect 1.8 will be dropped shortly from backwards support as they want to get off the classpath fully and onto the modules path. Anyway, just a thought. John On Thu, 10 Jun 2021 at 12:05, sebb wrote: > > Thanks. > > I've updated the RELEASE-NOTES accordingly (feel free to tweak the text) > > On Thu, 10 Jun 2021 at 00:58, Alex Herbert wrote: > > > > I have removed the requirement for Java 9 from the build. It is still used > > in the performance testing module. > > > > Alex > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"
Le jeu. 10 juin 2021 à 13:05, sebb a écrit : > > Thanks. > > I've updated the RELEASE-NOTES accordingly (feel free to tweak the text) AFAIK, this is an auto-generated file (from changes.xml). Gilles > > On Thu, 10 Jun 2021 at 00:58, Alex Herbert wrote: > > > > I have removed the requirement for Java 9 from the build. It is still used > > in the performance testing module. > > > > Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"
Thanks. I've updated the RELEASE-NOTES accordingly (feel free to tweak the text) On Thu, 10 Jun 2021 at 00:58, Alex Herbert wrote: > > I have removed the requirement for Java 9 from the build. It is still used > in the performance testing module. > > Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"
I have removed the requirement for Java 9 from the build. It is still used in the performance testing module. Alex
Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"
Note that the test could inspect the java version, or use reflection to see if the method BigDecimal.sqrt() exists... -r Randy Strauss, cell: 650-861-1537 On 6/9/21, 2:57 PM, "sebb" wrote: On Wed, 9 Jun 2021 at 19:58, Alex Herbert wrote: > > On Wed, 9 Jun 2021 at 17:56, sebb wrote: > > > On Wed, 9 Jun 2021 at 17:26, Alex Herbert > > wrote: > > > > > > On Wed, 9 Jun 2021 at 17:03, John Patrick > > wrote: > > > > > > > Have you tried "9" instead of "1.9"? > > > > > > > > > > I've corrected that in the pom, thanks. > > > > > > I think the issue is that Gilles used JDK 8 to try and build it. You can > > > run using the project's main artifacts using JDK 8, but the build now > > > requires JDK 9 for the tests and JMH performance tests. > > > > That seems wrong. If the code targets Java 8, it must be possible to > > test it using Java 8. > > > > It's possibly OK to require JDK 9 for performance tests. > > > > The test is using JDK 9 for the BigDecimal sqrt method. This is used to > compute the exact answer for a Euclidean norm on random input. Since the > input is random the answers cannot be hard-coded into the test. So this > test is not possible on JDK 8. The alternative is if the exact computation > is done using BigDecimal, converted to double, and then a sqrt computed. We > could change to that instead if there are strong objections here against > java 9. I certainly object. > > The issue with requiring a higher JDK than the target is similar to using > JDK 8 so that JUnit 5 can be used for the test suite to test code that > targets a level lower than 1.8. IMO that would be wrong as well. Someone wanting to use the source on its minimum supported version must be able to run the tests using that same version. > Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
