[GitHub] cordova-medic pull request: CB-8936 Gathering logs for Android
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-medic/pull/53#issuecomment-100157491 @dblotsky thanks for the review, I've addressed your comments and updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Stop object has no method...
GitHub user Gillardo opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25 Stop object has no method errors on windows If you called show or hide, you would get an object has no method error as getViewStatusBar would return null. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Gillardo/cordova-plugin-statusbar master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit 4d35d60d709cfa80ecf7efb3027cb6334b3ab14b Author: Gillardo darren.gillar...@gmail.com Date: 2015-05-08T11:08:43Z Added support check If you called show or hide, you would get an object has no method error as getViewStatusBar would return null. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...
Github user ktop commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100264782 Can someone take a look at this? I think it should be a simple merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova 5.0 user feedback - move to npm whitelist plugin
On Thu, May 7, 2015 at 8:16 PM, Steven Gill stevengil...@gmail.com wrote: (2) It is a fairly recent change. Any new app made with cordova-cli 5+ will auto include the whitelist plugin due to the hello world config.xml including it as a dependency. I think we need to document it more and make more noise within the community about it. iOS 4.0 will also require the whitelist plugin when it gets released. The more prepared we are, the better. Oh wow, didn't know iOS would also need this. I'll make some noise (via blog) today. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-7667 iOS8: Handle case wher...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-100305930 Thanks for the PR Dan -- I'm away, will take a look Monday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8988: Fix rotation on...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/46#issuecomment-100305790 Thanks for the PR Dan -- I'm away, will take a look Monday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: No Readme for plugin packages on npm
Thanks, Steve. Let me know if you run into headwind with fixing this - I'll be happy to help out removing the problematic comments. Though that would require another plugin release to get it out. From Shaz's previous reference to Apache policy, it might be fine for the .md files to not have the Apache license header. Thanks, Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, May 7, 2015 6:18 PM To: dev@cordova.apache.org Subject: Re: No Readme for plugin packages on npm https://github.com/npm/marky-markdown/issues/42 I will try to see if I can fix marky-markdown myself. If it isn't easy, we could just update our readme's and republish. On Wed, May 6, 2015 at 10:39 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Thanks, Steven! Do you have a pointer to the issue? In case they can't get do this soon - perhaps we should explore a workaround. -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, April 23, 2015 6:34 PM To: dev@cordova.apache.org Subject: Re: No Readme for plugin packages on npm I filed the issue a few days ago with npm. They are working on fixing it. The parser is struggling with html comments On Apr 23, 2015 6:14 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: It looks like npm cannot find the readme for plugin packages: https://www.npmjs.com/package/cordova-plugin-battery-status Github can find it just fine though: https://github.com/apache/cordova-plugin-battery-status Thanks, Nikhil - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3562: Disable screen ...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/47#issuecomment-100306319 Thanks for the PR Dan -- I'm away, will take a look Monday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: No Readme for plugin packages on npm
alright finee On Fri, May 8, 2015 at 11:41 AM, Shazron shaz...@gmail.com wrote: It's a new release - so in short, yes in regards to a vote (you'll need to up the ver# to publish to npm correct? So it's a new release). On Friday, May 8, 2015, Steven Gill stevengil...@gmail.com wrote: Not sure if we need to do a release if all we change is the readme. Shaz, any thoughts? On Fri, May 8, 2015 at 10:02 AM, Nikhil Khandelwal nikhi...@microsoft.com javascript:; wrote: Thanks, Steve. Let me know if you run into headwind with fixing this - I'll be happy to help out removing the problematic comments. Though that would require another plugin release to get it out. From Shaz's previous reference to Apache policy, it might be fine for the .md files to not have the Apache license header. Thanks, Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com javascript:;] Sent: Thursday, May 7, 2015 6:18 PM To: dev@cordova.apache.org javascript:; Subject: Re: No Readme for plugin packages on npm https://github.com/npm/marky-markdown/issues/42 I will try to see if I can fix marky-markdown myself. If it isn't easy, we could just update our readme's and republish. On Wed, May 6, 2015 at 10:39 PM, Nikhil Khandelwal nikhi...@microsoft.com javascript:; wrote: Thanks, Steven! Do you have a pointer to the issue? In case they can't get do this soon - perhaps we should explore a workaround. -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com javascript:;] Sent: Thursday, April 23, 2015 6:34 PM To: dev@cordova.apache.org javascript:; Subject: Re: No Readme for plugin packages on npm I filed the issue a few days ago with npm. They are working on fixing it. The parser is struggling with html comments On Apr 23, 2015 6:14 PM, Nikhil Khandelwal nikhi...@microsoft.com javascript:; wrote: It looks like npm cannot find the readme for plugin packages: https://www.npmjs.com/package/cordova-plugin-battery-status Github can find it just fine though: https://github.com/apache/cordova-plugin-battery-status Thanks, Nikhil - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org javascript:; For additional commands, e-mail: dev-h...@cordova.apache.org javascript:; - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org javascript:; For additional commands, e-mail: dev-h...@cordova.apache.org javascript:;
Re: No Readme for plugin packages on npm
Not sure if we need to do a release if all we change is the readme. Shaz, any thoughts? On Fri, May 8, 2015 at 10:02 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Thanks, Steve. Let me know if you run into headwind with fixing this - I'll be happy to help out removing the problematic comments. Though that would require another plugin release to get it out. From Shaz's previous reference to Apache policy, it might be fine for the .md files to not have the Apache license header. Thanks, Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, May 7, 2015 6:18 PM To: dev@cordova.apache.org Subject: Re: No Readme for plugin packages on npm https://github.com/npm/marky-markdown/issues/42 I will try to see if I can fix marky-markdown myself. If it isn't easy, we could just update our readme's and republish. On Wed, May 6, 2015 at 10:39 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Thanks, Steven! Do you have a pointer to the issue? In case they can't get do this soon - perhaps we should explore a workaround. -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, April 23, 2015 6:34 PM To: dev@cordova.apache.org Subject: Re: No Readme for plugin packages on npm I filed the issue a few days ago with npm. They are working on fixing it. The parser is struggling with html comments On Apr 23, 2015 6:14 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: It looks like npm cannot find the readme for plugin packages: https://www.npmjs.com/package/cordova-plugin-battery-status Github can find it just fine though: https://github.com/apache/cordova-plugin-battery-status Thanks, Nikhil - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100322451 What was the purpose of the call before? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100330631 Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100320977 Why not install the mobilespec tests when the plugin is installed? Why is this undesired behaviour? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Handles the playAudioWhenScree...
GitHub user romedius opened a pull request: https://github.com/apache/cordova-plugin-media/pull/54 Handles the playAudioWhenScreenIsLocked similar to the iOS behaviour. If the Flag is not set the media will be played (standard behaviour up to now. If the Flag is set to false, active playing sounds are paused on the Activitys onPause event and resumed after onResume is fired. The functionality is implemented similarly to the pausedForPhone functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/romedius/cordova-plugin-media master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit ec05d456757afd43b17f51508758f027f3b38e05 Author: Romedius Weiss romedius.we...@gmail.com Date: 2015-05-08T17:55:17Z Handles the playAudioWhenScreenIsLocked similar to the iOS behaviour. If the Flag is not set the media will be played (standard behaviour up to now. If the Flag is set to false, active playing sounds are paused on the Activitys onPause event and resumed after onResume is fired. The functionality is implemented similarly to the pausedForPhone functionality. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100326111 yes. I believe that was the intent, although it obviously failed. This is an easy merge. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: No Readme for plugin packages on npm
It's a new release - so in short, yes in regards to a vote (you'll need to up the ver# to publish to npm correct? So it's a new release). On Friday, May 8, 2015, Steven Gill stevengil...@gmail.com wrote: Not sure if we need to do a release if all we change is the readme. Shaz, any thoughts? On Fri, May 8, 2015 at 10:02 AM, Nikhil Khandelwal nikhi...@microsoft.com javascript:; wrote: Thanks, Steve. Let me know if you run into headwind with fixing this - I'll be happy to help out removing the problematic comments. Though that would require another plugin release to get it out. From Shaz's previous reference to Apache policy, it might be fine for the .md files to not have the Apache license header. Thanks, Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com javascript:;] Sent: Thursday, May 7, 2015 6:18 PM To: dev@cordova.apache.org javascript:; Subject: Re: No Readme for plugin packages on npm https://github.com/npm/marky-markdown/issues/42 I will try to see if I can fix marky-markdown myself. If it isn't easy, we could just update our readme's and republish. On Wed, May 6, 2015 at 10:39 PM, Nikhil Khandelwal nikhi...@microsoft.com javascript:; wrote: Thanks, Steven! Do you have a pointer to the issue? In case they can't get do this soon - perhaps we should explore a workaround. -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com javascript:;] Sent: Thursday, April 23, 2015 6:34 PM To: dev@cordova.apache.org javascript:; Subject: Re: No Readme for plugin packages on npm I filed the issue a few days ago with npm. They are working on fixing it. The parser is struggling with html comments On Apr 23, 2015 6:14 PM, Nikhil Khandelwal nikhi...@microsoft.com javascript:; wrote: It looks like npm cannot find the readme for plugin packages: https://www.npmjs.com/package/cordova-plugin-battery-status Github can find it just fine though: https://github.com/apache/cordova-plugin-battery-status Thanks, Nikhil - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org javascript:; For additional commands, e-mail: dev-h...@cordova.apache.org javascript:; - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org javascript:; For additional commands, e-mail: dev-h...@cordova.apache.org javascript:;
[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100325757 Oh, so it's mostly a convenience for a human tester? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100331095 I done goofed and forgot to say This closes #124. Merged though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100323303 I think it was to make sure the most recent additions were seen. Seems someone magically assumed it would always be less than 2 lines. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Buildbot: buildslave cordova-ios-slave was lost
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-ios-slave went away It last disconnected at Fri May 8 19:04:55 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky dblot...@microsoft.com '. Sincerely, The Buildbot http://ci.apache.org/ http://ci.apache.org/buildslaves/cordova-ios-slave - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Plugins release prep: Cherry-picking plugin updates
Steven, thanks so much for all your help getting the plugins released. -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Wednesday, May 6, 2015 1:42 PM To: dev@cordova.apache.org Subject: RE: Plugins release prep: Cherry-picking plugin updates Hey, took me a while but we're good to go with: Camera, device-motion, dialogs and vibration. Thanks! -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, May 6, 2015 12:16 PM To: dev@cordova.apache.org Subject: Re: Plugins release prep: Cherry-picking plugin updates Sounds good. Thanks Rob On Wed, May 6, 2015 at 12:04 PM, Rob Paveza rob.pav...@microsoft.com wrote: Murat is still working on the merge to master for the Camera plugin. I'll let you know when we're all squared away. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, May 6, 2015 11:57 AM To: dev@cordova.apache.org Subject: Re: Plugins release prep: Cherry-picking plugin updates I haven't heard back. Should I move forward with those 5 plugins? file-transfer, device-motion, dialogs, vibration, and camera. I will update the process to support specific plugins release (instead of all plugins) as I work through it. On Tue, May 5, 2015 at 12:29 PM, Jesse purplecabb...@gmail.com wrote: + file-transfer so we can resolve CB-8951 @purplecabbage risingj.com On Tue, May 5, 2015 at 12:19 PM, Steven Gill stevengil...@gmail.com wrote: Hey guys, I can help you out. The process is designed for all plugins but it is pretty easy to do it for just a few. I've done it many times. If changes are on master, they shouldn't be incomplete. Any known problem with release the master branch of those plugins? We could cherry-pick, but it is just more work than probably required. Since we don't have release branches for plugins, just tags. If you guys merge changes into master, I can take over the release or at least tell you the parts to modify in the release process to make it work. -Steve On Tue, May 5, 2015 at 11:44 AM, Rob Paveza rob.pav...@microsoft.com wrote: Hi all - I started a [discuss] thread about plugin updates last week, effectively saying that we wanted to take four JIRA items which are causing problems for Windows 10: CB-8926, CB-8928, CB-8930, and CB-8943. Since Murat is a committer, he's actually trying to do the release. We're looking at device-motion, dialogs, vibration, and camera. However, as we go through the [release process]( https://github.com/apache/cordova-coho/blob/master/docs/plugins-rele as e-process.md ), there are a lot of things that give us pause, specifically that we're going to end up tagging each plugin rather than just the four. We're also concerned that we'll bring in unstable or not-yet-completed changes from 'master' in some of the plugins. Instead, we're trying to cherry-pick. So, we know that where the final state is supposed to be: - Each plugin that we're updating gets a new tag with a build-version bump - The branch that we submitted as the PR should become the new tag (since it was based on the previous release tag) - Then we'll go on with the rest of the publish-to-NPM work, etc. Since all of the steps are automated, is there a straightforward way to cherry-pick the individual pieces that is known and has been used before? Or are we in new territory? Thanks! -Rob and Murat -- --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100331390 If I explicitly specify list of plugins to be tested I don't want to run org.apache.cordova.mobilespec.tests (they represent some extra tests not related to our plugins like iframe, XHR, etc) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/62 CB-8987: Support for save and remove for Windows 10 This change adds save and remove support to the contacts plugin when running on Windows 10. When the functionality isn't available on older platforms, the original behavior is retained. The remove function is noteworthy because of the architectural way that Windows returns aggregate contacts when going through the global contacts list; it means the app has to find the app's part of the contact. If the contact doesn't belong to the app, it can't be deleted. This also adds a manual test to remove the contact which is added (Dooney Evans) in the manual adding test. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-8987 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 959fffad4a1e7c27b16478b24cdc628200d718d4 Author: Rob Paveza rob.pav...@microsoft.com Date: 2015-05-08T20:19:25Z CB-8987: Support for save and remove for Windows 10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#discussion_r29981882
--- Diff: createmobilespec/createmobilespec.js ---
@@ -56,7 +56,8 @@ function popd(dir) {
}
function pluginAdd(pluginName, searchPath, extraFlags) {
-var command = cli + ' plugin add ' + pluginName + ' --searchpath ' +
searchPath;
+var sp = SEARCH_PATHS.hasOwnProperty(pluginName) ?
SEARCH_PATHS[pluginName] : searchPath;
--- End diff --
It's clearer to put this logic outside of the function, on [line 568]
(https://github.com/apache/cordova-mobile-spec/pull/128/files#diff-ad19d116ad56f7b3ae8ee9fdc8733f69R568).
That way pluginAdd is only concerned with adding a plugin from a given path,
not with extra logic regarding the path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#discussion_r29981911
--- Diff: createmobilespec/createmobilespec.js ---
@@ -546,11 +547,12 @@ function installPlugins() {
console.log(Installing local test framework plugins...);
var linkPluginsFlag = (argv.link || argv.linkplugins) ? ' --link'
: '';
-pluginAdd('org.apache.cordova.mobilespec.tests',
mobile_spec_git_dir, linkPluginsFlag + browserifyFlag);
+if (!argv.plugins) {
--- End diff --
Please comment why this check is here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-8950 Add NSP to travis
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Buildbot: buildslave cordova-ios-slave was lost
Booted the machine to resolve a strange emulator bug, and machine took over 10 minutes to boot. -Original Message- From: build...@apache.org [mailto:build...@apache.org] Sent: Friday, May 8, 2015 12:10 PM To: dev@cordova.apache.org Subject: Buildbot: buildslave cordova-ios-slave was lost The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-ios-slave went away It last disconnected at Fri May 8 19:04:55 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky dblot...@microsoft.com '. Sincerely, The Buildbot http://ci.apache.org/ http://ci.apache.org/buildslaves/cordova-ios-slave - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100384365 Ok. Sounds reasonable. I left some comments in review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release
Release issue: https://issues.apache.org/jira/browse/CB-8997 Going to get this out today. I think the pinned platform discussion should get its own thread. If I recall correctly, it was done so it would be easier to identify which platforms are working with which tool versions. If we are staying true to semver though, having the patch version be variable seems fine to me. On Wed, May 6, 2015 at 3:28 PM, Tim Barham tim.bar...@microsoft.com wrote: Sounds good to me. Once this is done, will we need to do a tools release to update pinned platforms (which makes me wonder - should we set the version of pinned platforms to something like 4.0.x so we don't need to update tools when we do a platform patch release)? From: Steven Gill stevengil...@gmail.com Sent: Thursday, May 7, 2015 5:00 AM To: dev@cordova.apache.org Subject: [DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release Need to do patch releases for these three platforms with updated cordova.js files due to bug with ripple https://issues.apache.org/jira/browse/RIPPLE-82 . I will do it on the respective release branches and not master so new changes won't make it into these releases. Thoughts? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82#issuecomment-100380328 Gotcha. That JIRA seems enough. I was concerned that we might forget to do the correct fix, but my concerns were largely unfounded; seems like the work is already being tracked. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/62#issuecomment-100388932 Will run tests on medic, since Travis doesn't run the tests on Windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/128 CB-8992 Do not install mobilespec tests when --plugins specified https://issues.apache.org/jira/browse/CB-8992 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-mobile-spec CB-8992 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #128 commit aeb5e30a063d775744098e99b3c03d82c84af46d Author: alsorokin alexander.soro...@akvelon.com Date: 2015-05-08T12:26:22Z CB-8992 Do not install mobilespec tests when --plugins specified --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100219011 :1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [BUG] Mobilespec hangs on Windows
Correction: the commit time range is 10PM to 6AM. -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Friday, May 8, 2015 6:06 PM To: dev@cordova.apache.org Subject: [BUG] Mobilespec hangs on Windows Hi list, From some point between 10PM May 7th and 2AM May 8th, mobilespec on Windows has started hanging upon loading of the automated tests page. I've tried to list the commits in that time, but got nowhere. Is anyone else seeing this? If you have any idea on the cause, or a fix, please share. JIRA is here: https://issues.apache.org/jira/browse/CB-8999/ Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[BUG] Mobilespec hangs on Windows
Hi list, From some point between 10PM May 7th and 2AM May 8th, mobilespec on Windows has started hanging upon loading of the automated tests page. I've tried to list the commits in that time, but got nowhere. Is anyone else seeing this? If you have any idea on the cause, or a fix, please share. JIRA is here: https://issues.apache.org/jira/browse/CB-8999/ Kindly, Dmitry
[Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases
Please review and vote on these releases by replying to this email (and keep discussion on the DISCUSS thread) These releases are just including an updated snapshot of cordova.js so it works with ripple again. Release issue: https://issues.apache.org/jira/browse/CB-8997 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8997 The package was published from its corresponding git tag: cordova-android: 4.0.1 (6b7eaf2386) cordova-wp8: 3.8.1 (0a099394ab) cordova-windows: 3.8.2 (eb4e7125e0) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-android#4.0.1cordova platform add https://github.com/apache/cordova-wp8#3.8.1cordova platform add https://github.com/apache/cordova-windows#3.8.2 Upon a successful vote I will upload the archive to dist/ and publish it to NPM Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
