[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user galexandrov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/219#discussion_r31506402 --- Diff: cordova-lib/package.json --- @@ -42,7 +42,7 @@ underscore: 1.7.0, unorm: 1.3.3, valid-identifier: 0.0.1, -xcode: 0.6.7 +xcode: https://github.com/ogoguel/node-xcode/tarball/17926117b388d08f05ec2db1e1ad8262f67a2a8d; --- End diff -- You should create PR with your changes to [node-xcode](https://github.com/alunny/node-xcode) instead of using tarball dependency --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user galexandrov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/219#discussion_r31507207
--- Diff: cordova-lib/src/plugman/platforms/ios.js ---
@@ -184,13 +192,76 @@ module.exports = {
var xcBuildConfiguration =
xcodeproj.pbxXCBuildConfigurationSection();
-var plist_file_entry = _.find(xcBuildConfiguration, function
(entry) { return entry.buildSettings entry.buildSettings.INFOPLIST_FILE; });
-var plist_file = path.join(project_dir,
plist_file_entry.buildSettings.INFOPLIST_FILE.replace(/^(.*)$/g,
'$1').replace(/\\/g, ''));
-var config_file = path.join(path.dirname(plist_file),
'config.xml');
-if (!fs.existsSync(plist_file) || !fs.existsSync(config_file)) {
+// CB-9033
+var plist_file_index;
+var plist_file_entry = _.find(xcBuildConfiguration, function
(entry,index) {
+if (entry.buildSettings entry.buildSettings.INFOPLIST_FILE)
{
+
+var plist_file = path.join(project_dir,
entry.buildSettings.INFOPLIST_FILE.replace(/^(.*)$/g, '$1').replace(/\\/g,
''));
+ if (!fs.existsSync(plist_file))
+return false;
+
+var config_file = path.join(path.dirname(plist_file),
'config.xml');
+ if (!fs.existsSync(config_file))
+return false;
+
+// only return project that contains both a plist and a
config.xml (especially to discard apple watch extension/app)
+plist_file_index = index;
--- End diff --
Instead of checking for config.xml can we check for SKIP_INSTALL property
in BuildSettings. SKIP_INSTALL property should be missing or equals to NO for
the iPhone app target and should equals to YES for WatchKit Extension and
WatchKit App.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: npm info cordova returning version 5.1.0
Yeah, 5.1.0 was published as RC so we could test it.
On Tue, Jun 2, 2015 at 8:10 AM, Shazron shaz...@gmail.com wrote:
I see the 'latest' tag as 5.0.0? That is what is associated with the dist
tarball you see.
On Tue, Jun 2, 2015 at 7:25 AM, Nikhil Khandelwal nikhi...@microsoft.com
wrote:
Why does npm info cordova - give me 5.1.0 version which points to cordova
5.0.0 tgz? See the lines below in asterisk.
{ name: 'cordova',
description: 'Cordova command line interface tool',
'dist-tags':
{ latest: '5.0.0',
rc: '5.1.0',
'3.6.0-0.2.8': '3.6.0-0.2.8',
nightly: '4.1.3-nightly.2014.10.21' },
versions:
[ '0.0.0-fake',
'0.0.1',
'5.0.0',
*** '5.1.0' ],
time:
{ modified: '2015-06-02T02:55:19.592Z',
created: '2012-07-14T22:05:40.306Z',
'5.0.0': '2015-04-16T20:16:51.255Z',
*** '5.1.0': '2015-05-27T23:54:43.677Z' },
preferGlobal: 'true',
main: 'cordova',
engines: { node: '=0.9.9' },
engineStrict: true,
bin: { cordova: './bin/cordova' },
scripts:
{ test: 'node node_modules/jasmine-node/bin/jasmine-node
--captureExceptions --color spec',
cover: 'node node_modules/istanbul/lib/cli.js cover --root src
--print detail node_modules/jasmine-node/bin/jasmine-node -- spec' },
dependencies:
{ 'cordova-lib': '5.0.0',
q: '1.0.1',
nopt: '3.0.1',
underscore: '1.7.0' },
devDependencies:
{ istanbul: '^0.3.4',
grunt: '0.4.5',
'grunt-retire': '0.3.7',
'jasmine-node': '1.14.5' },
dist:
{ shasum: '696907aff7c889beea4422b6c80e57558a905c05',
tarball: 'http://registry.npmjs.org/cordova/-/cordova-5.0.0.tgz
'
},
directories: {} }
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Fix NoSuchMethodExcepti...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Plugins Release
Thanks Darryl! Merged. On Tue, Jun 2, 2015 at 10:57 AM, Darryl Pogue dar...@dpogue.ca wrote: https://github.com/apache/cordova-plugin-file-transfer/pull/68 This bug is causing app crashes on older OS versions for anyone using FileTransfer on Android with Crosswalk. On 2 June 2015 at 10:50, Steven Gill stevengil...@gmail.com wrote: Going to start a plugins release tomorrow. If you have PRs you want me to review, please bring them up in this thread. -Steve - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: npm info cordova returning version 5.1.0
Thanks for the explanation. I was not familiar with npm and our release process
and this confused me. It makes sense now.
-Nikhil
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Tuesday, June 2, 2015 10:52 AM
To: dev@cordova.apache.org
Subject: Re: npm info cordova returning version 5.1.0
Yeah, 5.1.0 was published as RC so we could test it.
On Tue, Jun 2, 2015 at 8:10 AM, Shazron shaz...@gmail.com wrote:
I see the 'latest' tag as 5.0.0? That is what is associated with the
dist tarball you see.
On Tue, Jun 2, 2015 at 7:25 AM, Nikhil Khandelwal
nikhi...@microsoft.com
wrote:
Why does npm info cordova - give me 5.1.0 version which points to
cordova
5.0.0 tgz? See the lines below in asterisk.
{ name: 'cordova',
description: 'Cordova command line interface tool',
'dist-tags':
{ latest: '5.0.0',
rc: '5.1.0',
'3.6.0-0.2.8': '3.6.0-0.2.8',
nightly: '4.1.3-nightly.2014.10.21' },
versions:
[ '0.0.0-fake',
'0.0.1',
'5.0.0',
*** '5.1.0' ],
time:
{ modified: '2015-06-02T02:55:19.592Z',
created: '2012-07-14T22:05:40.306Z',
'5.0.0': '2015-04-16T20:16:51.255Z',
*** '5.1.0': '2015-05-27T23:54:43.677Z' },
preferGlobal: 'true',
main: 'cordova',
engines: { node: '=0.9.9' },
engineStrict: true,
bin: { cordova: './bin/cordova' },
scripts:
{ test: 'node node_modules/jasmine-node/bin/jasmine-node
--captureExceptions --color spec',
cover: 'node node_modules/istanbul/lib/cli.js cover --root src
--print detail node_modules/jasmine-node/bin/jasmine-node -- spec' },
dependencies:
{ 'cordova-lib': '5.0.0',
q: '1.0.1',
nopt: '3.0.1',
underscore: '1.7.0' },
devDependencies:
{ istanbul: '^0.3.4',
grunt: '0.4.5',
'grunt-retire': '0.3.7',
'jasmine-node': '1.14.5' },
dist:
{ shasum: '696907aff7c889beea4422b6c80e57558a905c05',
tarball: 'http://registry.npmjs.org/cordova/-/cordova-5.0.0.tgz
'
},
directories: {} }
- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Android plugin crash on resume when activity destroyed
On Android, when using plugins that launch other intents, e.g. the Camera
plugin, I'm now seeing reliable crashes when the cordova activity is resumed -
if it was destroyed when the intent launched. The reliable way to reproduce
this is to enable the Don't keep activities setting in Android's Developer
options. Based on the Google Play crash reports, this just started when we
updated our app to use the new
cordova-android@4.0.0mailto:cordova-android@4.0.0 runtime.
In the Camera plugin, the issue is that the
CameraLauncher.processResultFromCamera method uses an instance variable,
imageUri, which is set prior to launching the intent, but null when the
activity is resumed. Presumably, this is because the plugin isn't aware that it
needs to save state? Here's the full stack trace:
java.lang.RuntimeException: Unable to resume activity {app}:
java.lang.RuntimeException: Failure delivering result ResultInfo{who=null,
request=34, result=-1, data=null} to activity {app}:
java.lang.NullPointerException: Attempt to invoke virtual method
'java.lang.String android.net.Uri.toString()' on a null object reference
at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3349)
at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3380)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2731)
at android.app.ActivityThread.access$900(ActivityThread.java:172)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1421)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:145)
at android.app.ActivityThread.main(ActivityThread.java:5835)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1388)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1183)
Caused by: java.lang.RuntimeException: Failure delivering result
ResultInfo{who=null, request=34, result=-1, data=null} to activity {app}:
java.lang.NullPointerException: Attempt to invoke virtual method
'java.lang.String android.net.Uri.toString()' on a null object reference
at android.app.ActivityThread.deliverResults(ActivityThread.java:3977)
at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3335)
... 11 more
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method
'java.lang.String android.net.Uri.toString()' on a null object reference
at
org.apache.cordova.camera.CameraLauncher.processResultFromCamera(CameraLauncher.java:445)
at
org.apache.cordova.camera.CameraLauncher.onActivityResult(CameraLauncher.java:674)
at
org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:120)
at org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:321)
at android.app.Activity.dispatchActivityResult(Activity.java:6475)
at android.app.ActivityThread.deliverResults(ActivityThread.java:3973)
... 12 more
I've been looking at this for a bit, and am wondering whether this can even be
supported with the current plugin architecture. I see that onStart and onStop
are now part of the plugin interface, but not
onSaveInstanceState/onRestoreInstanceState. It seems like a fairly common
pattern for plugins to save the CallbackContext, so this will impact more than
just the Camera plugin.
Has any thought gone into supporting this scenario? Is it possible to do with
the current plugin interface, or would it need to be extended to add the
instance state handlers to allow plugins to preserve necessary state? I'm happy
to take a stab at addressing this, but would appreciate insight from the
android native devs on the right way to approach this issue. (I haven't yet
filed a JIRA issue on this, but will shortly.)
Thanks,
Dan
Re: [DISCUSS] Plugins Release
https://github.com/apache/cordova-plugin-file-transfer/pull/68 This bug is causing app crashes on older OS versions for anyone using FileTransfer on Android with Crosswalk. On 2 June 2015 at 10:50, Steven Gill stevengil...@gmail.com wrote: Going to start a plugins release tomorrow. If you have PRs you want me to review, please bring them up in this thread. -Steve - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] Tools Release May 27th
This vote has failed. I will start another vote thread after I fix the --usegit regression. On Fri, May 29, 2015 at 6:02 PM, Dmitry Blotsky dblot...@microsoft.com wrote: I vote +1: * Ran 'coho verify-tags', and it passed * Ran 'coho audit-license-headers', and got some files reported as non-compliant, but I've been convinced by Nikhil Khandelwal and Tim Barham that they should be in ratExcludes * Installed the code and ran NPM tests using Medic: * OSX: http://cdv-ms-buildbot.cloudapp.net/builders/cordova-tools-release-osx/builds/8 * Windows: http://cdv-ms-buildbot.cloudapp.net/builders/cordova-tools-release-win/builds/8 * Observed some failures on Windows, but it seems that they're expected Kindly, Dmitry On May 29, 2015, at 2:07 PM, Steven Gill stevengil...@gmail.com wrote: bump On Wed, May 27, 2015 at 4:58 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9087 Both tools have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9087/ The packages were published from their corresponding git tags: cordova-js: 4.0.0 (706c4a8936) cordova-lib: 5.1.0 (d57d70bbc9) cordova-plugman: 0.23.2 (d02fcbc8d1) cordova-cli: 5.1.0 (98fece9a55) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran unit tests and saw that they were all building * Build a cordova project for ios and android and added a plugin. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-108063507 Added SKIP_INSTALL to improve plist detection Using node-xcode 0.7.0 (which includes the required modification) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] Plugins Release
Going to start a plugins release tomorrow. If you have PRs you want me to review, please bring them up in this thread. -Steve
Re: [DISCUSS] Plugins Release
Is there a test attached to that PR? This seems like something that would break again. On Tue, Jun 2, 2015 at 11:11 AM Steven Gill stevengil...@gmail.com wrote: Thanks Darryl! Merged. On Tue, Jun 2, 2015 at 10:57 AM, Darryl Pogue dar...@dpogue.ca wrote: https://github.com/apache/cordova-plugin-file-transfer/pull/68 This bug is causing app crashes on older OS versions for anyone using FileTransfer on Android with Crosswalk. On 2 June 2015 at 10:50, Steven Gill stevengil...@gmail.com wrote: Going to start a plugins release tomorrow. If you have PRs you want me to review, please bring them up in this thread. -Steve - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-blackberry pull request: Fixes CB-9072
GitHub user timwindsor opened a pull request: https://github.com/apache/cordova-blackberry/pull/184 Fixes CB-9072 You can merge this pull request into a Git repository by running: $ git pull https://github.com/timwindsor/cordova-blackberry CB-9072 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-blackberry/pull/184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #184 commit 650e665cc4baf80aa85075ddf2ee3bc1d566544e Author: Tim Windsor timothy.wind...@gmail.com Date: 2015-06-02T19:54:46Z Fixes CB-9072 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108136533 Sure. I'll get to it later today On Jun 2, 2015 4:59 PM, Tim Barham notificati...@github.com wrote: Hey @stevengill https://github.com/stevengill ... could you take a look at this? Thanks! -- Reply to this email directly or view it on GitHub https://github.com/apache/cordova-lib/pull/232#issuecomment-108135207. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix four failing tests on Windows.
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/233#issuecomment-108146207 Yeah, gotta love the 'weird error' when it happens. This does resolve the other errors I had. I think we can still pull this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9097 fail with a more descriptive...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/89#issuecomment-108130162 wfm! Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108135207 Hey @stevengill ... could you take a look at this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix four failing tests on Windows.
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/233#issuecomment-108145177 Awesome, I was just looking into this, waiting for appveyor now ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix four failing tests on Windows.
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/233#issuecomment-108146017 Bummer... AppVeyor is still broken (which I pretty much expected since its failure is different from what I was seeing - but it would have been nice :smile:). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9097 fail with a more descriptive...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix four failing tests on Windows.
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/233 Fix four failing tests on Windows. Two tests fail on Windows in a non-admin command window because they rely on creating symlinks. Since creating the symlinks isn't the purpose of the test but just setup for the test, if that fails and the platform is `win32`, we now just bail on the test. Another test failed because a folder unexpectedly exists when run from a non-admin prompt. I'm not 100% sure why the folder exists, but the test was bogus... the test actually ends up testing that we throw if `src` does not exist, which is something that we verify in an earlier test, while the intent of the test was to verify we throw if `dest` *already* exists. Since it is `copyNewFile()` that is supposed to throw in that scenario, so I updated the test to check for that. Finally, a fourth test failed on Windows (admin or non-admin) because of different line endings. Changed that to handle either line ending. Verified all tests now pass on Windows and still pass on OS X. Note: I don't believe this is the cause of the AppVeyor failures we are seeing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib tb-fix-win-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #233 commit 0b103f16c4d301611a3cfd6fea967effe880f652 Author: Tim Barham tim.bar...@microsoft.com Date: 2015-06-02T23:22:11Z Fix four failing tests on Windows. Two tests fail in a non-admin command window because they rely on creating symlinks. Since creating the symlinks isn't the purpose of the test but just setup for the test, if that fails and the platform is win32, we now just bail on the test. Another test failed because a folder unexpectedly exists when run from a non-admin prompt. I'm not 100% sure why the folder exists, but the test was actually bogus... the test was actually ends up testing that we throw if src does not exist (something that we verify in an earlier test), while the intent was to verify we throw if dest *already* exists. It is copyNewFile() that throws in that scenario, so I updated the test to check for that. Finally, a fourth test failed on Windows (admin or non-admin) because of different line endings. Changed that to handle any line ending. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix four failing tests on Windows.
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108146590 I spent some time reviewing this, it looks good to me even though I think the --usegit flag should be eliminated (some time in the future) now that we have the capability to add platforms using git-urls : `cordova platform add https://github.com/apache/cordova-android.git` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/232 CB-9108 Handle version ranges when add platform with --usegit. Adding a platform using a version range didn't work with `--usegit`, since it would try to use that version range as a git tag. This was a problem if you added the platform using `platform add platform@range`, and also because our pinned platforms now use tilde versions (which are shorthand for a version range). Fix is to use `npm view` to find the most recent version that matches the range, and use that. We need to do the same when installing from npm, when we do our check to see if the requested version has previously been downloaded using git. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-9108 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/232.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #232 commit 884340739b9c289f1acf12bfd63696d45e03482e Author: Tim Barham tim.bar...@microsoft.com Date: 2015-06-02T21:14:57Z CB-9108 Handle version ranges when add platform with --usegit. Adding a platform using a version range didn't work with --usegit, since it would try to use that version range as a git tag. This was a problem if you added the platform using 'platform add platform@range', and also because our pinned platforms now use tilde versions (which are shorthand for a version range). Fix is to use npm to find the most recent version that matches the range, and use that. We need to do the same when installing from npm, when we do our check to see if the requested version has previously been downloaded using git. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9097 fail with a more descriptive...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/89#issuecomment-108119813 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...
Github user uareurapid commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-107903213 Any feedback? seems a clear bug... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: plugins framework on Android
We want plugman to always work, even if you don't have the android sdk installed. So, plugman calling android update project is not allowed. As of cordova-5.0, this line will be re-written by the build script to its Gradle equivalent, where no android update project call is necessary (this was an ANT thing) One issue we have seen with gradle though, is that people haven't installed the Support Repository into their SDK. We could consider having the android build script detect whether the requisite directories exist on the machine, and show an error earlier in this case. On Mon, Jun 1, 2015 at 2:40 PM, Axel Nennker ignisvul...@gmail.com wrote: Hi, the documentation here https://cordova.apache.org/docs/en/4.0.0/plugin_ref_spec.md.html#Plugin%20Specification_info_element says that some tasks needed by framework ... are not done by plugman. framework src=extras/android/support/v7/appcompat custom=false But it seems quite easy to do this by calling this command e.g. for Google Play Services: $ android update project --path . --library /home/ignisvulpis/Android/Sdk/extras/google/google_play_services/libproject/google-play-services_lib/ --target android-21 Cordova has all the information that is needed, right?! Or doesn't this work in all cases? My latest custom plugin can not be added to my project because plugman's android.js calls the property-parser which tries to determine the androidSdkDir which fails because it tries to open local.properties which was not created (by cordova). Why doesn't plugman try ANDROID_HOME (too)? I think that using android update project ... would always work instead of plugman editing project file directly. Axel ps: There are several unanswered stackoverflow questions regarding Google Play Services and Cordova http://stackoverflow.com/questions/22002424/admob-with-cordova-3-and-google-play-services http://stackoverflow.com/questions/30399421/cordova-testing-google-play-game-services http://stackoverflow.com/questions/25872707/how-to-link-google-play-services-to-cordova-project
npm info cordova returning version 5.1.0
Why does npm info cordova - give me 5.1.0 version which points to cordova 5.0.0
tgz? See the lines below in asterisk.
{ name: 'cordova',
description: 'Cordova command line interface tool',
'dist-tags':
{ latest: '5.0.0',
rc: '5.1.0',
'3.6.0-0.2.8': '3.6.0-0.2.8',
nightly: '4.1.3-nightly.2014.10.21' },
versions:
[ '0.0.0-fake',
'0.0.1',
'5.0.0',
*** '5.1.0' ],
time:
{ modified: '2015-06-02T02:55:19.592Z',
created: '2012-07-14T22:05:40.306Z',
'5.0.0': '2015-04-16T20:16:51.255Z',
*** '5.1.0': '2015-05-27T23:54:43.677Z' },
preferGlobal: 'true',
main: 'cordova',
engines: { node: '=0.9.9' },
engineStrict: true,
bin: { cordova: './bin/cordova' },
scripts:
{ test: 'node node_modules/jasmine-node/bin/jasmine-node --captureExceptions
--color spec',
cover: 'node node_modules/istanbul/lib/cli.js cover --root src --print
detail node_modules/jasmine-node/bin/jasmine-node -- spec' },
dependencies:
{ 'cordova-lib': '5.0.0',
q: '1.0.1',
nopt: '3.0.1',
underscore: '1.7.0' },
devDependencies:
{ istanbul: '^0.3.4',
grunt: '0.4.5',
'grunt-retire': '0.3.7',
'jasmine-node': '1.14.5' },
dist:
{ shasum: '696907aff7c889beea4422b6c80e57558a905c05',
tarball: 'http://registry.npmjs.org/cordova/-/cordova-5.0.0.tgz' },
directories: {} }
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: plugins framework on Android
If a developer writes a plugin that adds a framework in the platform name=android .. section then the android sdk needs to be installed anyways to build the app later, right? But OK. Still plugman tries to read project_dir/local.properties to get sdk.dir which fails because local.properties does not exist https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/android.js#L36 Called from here https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/android.js#L138 where the framework is handled. How can this ever have worked? Couldn't Cordova tell plugman which sdk to use? -Axel 2015-06-02 15:58 GMT+02:00 Andrew Grieve agri...@chromium.org: We want plugman to always work, even if you don't have the android sdk installed. So, plugman calling android update project is not allowed. As of cordova-5.0, this line will be re-written by the build script to its Gradle equivalent, where no android update project call is necessary (this was an ANT thing) One issue we have seen with gradle though, is that people haven't installed the Support Repository into their SDK. We could consider having the android build script detect whether the requisite directories exist on the machine, and show an error earlier in this case. On Mon, Jun 1, 2015 at 2:40 PM, Axel Nennker ignisvul...@gmail.com wrote: Hi, the documentation here https://cordova.apache.org/docs/en/4.0.0/plugin_ref_spec.md.html#Plugin%20Specification_info_element says that some tasks needed by framework ... are not done by plugman. framework src=extras/android/support/v7/appcompat custom=false But it seems quite easy to do this by calling this command e.g. for Google Play Services: $ android update project --path . --library /home/ignisvulpis/Android/Sdk/extras/google/google_play_services/libproject/google-play-services_lib/ --target android-21 Cordova has all the information that is needed, right?! Or doesn't this work in all cases? My latest custom plugin can not be added to my project because plugman's android.js calls the property-parser which tries to determine the androidSdkDir which fails because it tries to open local.properties which was not created (by cordova). Why doesn't plugman try ANDROID_HOME (too)? I think that using android update project ... would always work instead of plugman editing project file directly. Axel ps: There are several unanswered stackoverflow questions regarding Google Play Services and Cordova http://stackoverflow.com/questions/22002424/admob-with-cordova-3-and-google-play-services http://stackoverflow.com/questions/30399421/cordova-testing-google-play-game-services http://stackoverflow.com/questions/25872707/how-to-link-google-play-services-to-cordova-project
[GitHub] cordova-plugin-file-transfer pull request: Added support for PATCH...
GitHub user alvaromb opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/86 Added support for PATCH request uploads Adds support to PATCH request uploads. Keeps POST as default fallback. You can merge this pull request into a Git repository by running: $ git pull https://github.com/APSL/cordova-plugin-file-transfer master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/86.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #86 commit aca2e5ea75b91848ce26b336bb9408d4e3851f93 Author: alvaro m...@alvaromb.com Date: 2015-06-02T10:28:52Z Added support to PATCH request uploads --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Github user danielreuterwall commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-107930682 Shouldn't the `SYSTEM_UI_FLAG_FULLSCREEN` flag be based on the `SplashHideStatusBar` preference instead of `SplashHideNavigationBar`? Like this on line 267: `(isHideNavigationBar() ? View.SYSTEM_UI_FLAG_HIDE_NAVIGATION : 0) | (isHideStatusBar() ? View.SYSTEM_UI_FLAG_FULLSCREEN : 0));` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Best place to browse plugins
So adding a # in front of each line makes it compile. Here is a Gist showing the change - since the ASF is *incredibly* particular about stuff, do the # marks 'break' something for them? https://gist.github.com/cfjedimaster/a236919daea219e4c5d2 And here is the rendered HTML: http://static.raymondcamden.com/README.html Does this seem ok for folks? On Mon, Jun 1, 2015 at 10:38 PM, Shazron shaz...@gmail.com wrote: Please send an email to dev-unsubscr...@cordova.apache.org On Monday, June 1, 2015, Great Courses ttccour...@gmail.com wrote: plz can you all remove me from the list. you all are doing great work, am not that smart or deserve to be in this intelligent group. Thanks, On Sat, May 30, 2015 at 2:46 PM, Joerg Holz h...@hamburg.de javascript:_e(%7B%7D,'cvml','h...@hamburg.de'); wrote: I’m a cordova developer. The idea to move the plugins to npm was a very bad one. No professional description, no professional searching. From a developer view, there is a need to have an overview off all plugins - just for inspiration There is a need to have a filter for platforms, the maintainer, last update, … and the most important and complicated one: Is the plugin checked, checked for platform, checked for version? Have you ever tried to bring a three wheel selector in a cordova application? That is a great job. Sorry for posting a screenshot, but this simple wheeler took me one week for working on iOS, Android and Windows. I tried every plugin, every modification of every plugin, I split the platforms … in the end I used mobiscroll and rewrote it for my needs. Just for selecting a timespan. Cordova is great, the most important job for the future is: Let give the people the power of cordova by good plugins. Jörg Am 29.05.2015 um 02:55 schrieb Gorkem Ercan gorkem.er...@gmail.com javascript:_e(%7B%7D,'cvml','gorkem.er...@gmail.com');: On 28 May 2015, at 19:41, Murat Sutunc wrote: I had some free time today and started working on a plugin search prototype. Currently it doesn't offer much but it's very similar to what Gulp has. GH: https://github.com/muratsu/cordova-plugin-search Imgur (can't add images to mails :( ): http://imgur.com/sX8oFcJ One problem I've run into is discoverability. Currently we're using the keyword `ecosystem:cordova` with all of the plugins. Ecosystem is a wider term than plugins and will most likely contain irrelevant search results. It does, I use it and at least all the cordova-platforms appear on the results. I was hoping that we switch to using `cordova-plugin` or `cordovaplugin` keyword going forward for better discoverability. Also for comparison, yeoman uses `yeoman-generator`, gulp uses `gulpplugin` and grunt uses `gruntplugin`. Thoughts? +1. I guess there is no way to add them for all the existing plugins though. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com javascript:_e(%7B%7D,'cvml','stevengil...@gmail.com');] Sent: Thursday, May 28, 2015 3:35 PM To: dev@cordova.apache.org javascript:_e(%7B%7D,'cvml','dev@cordova.apache.org'); Cc: Tommy-Carlos Williams Subject: Re: Best place to browse plugins npm does have a plan to improve their ecosystem + communities later this year. We will essentially get a portal for cordova on npmjs. I also agree in turning plugins.cordova.io into a Gulp Yeoman style search page. Probably won't be doing that until our current registry is shut down I imagine. On Wed, May 27, 2015 at 7:42 AM, Kerri Shotts kerrisho...@gmail.com javascript:_e(%7B%7D,'cvml','kerrisho...@gmail.com'); wrote: +1 I've used both Gulp Yeoman's search, and prefer both to NPM (although it's not difficult to be better than NPM's search). I also think close association with the brand and site are important. For those users who don't know about Node NPM yet, it's quickly apparent that there's a large community creating plugins for Cordova, and for everyone else, we have a URL that helps reinforce the Cordova name. NPM would still be canonical, of course. (Now if NPM improved their search and did some nice work around ecosystems, perhaps the above wouldn't be necessary. But I'm not going to hold my breath...) On May 27, 2015 at 8:19:35 AM, Tommy-Carlos Williams (to...@devgeeks.org javascript:_e(%7B%7D,'cvml','to...@devgeeks.org');) wrote: +1 On 26 May 2015, at 21:44, Carlos Santana csantan...@gmail.com javascript:_e(%7B%7D,'cvml','csantan...@gmail.com'); wrote: I would like to see plugin.cordova.io be a page easy to search and filter cordova plugins just like gulp [1], grunt [2], yeoman [3] and bower [4] [1]: http://gulpjs.com/plugins [2]: http://gruntjs.com/plugins [3]: http://yeoman.io/generators [4]: http://bower.io/search On Sat, May 2, 2015 at 3:57 PM Michael Brooks mich...@michaelbrooks.ca javascript:_e(%7B%7D,'cvml','mich...@michaelbrooks.ca'); wrote: The mirroring may not help for search, but my worry is
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/219#discussion_r31520090
--- Diff: cordova-lib/src/plugman/platforms/ios.js ---
@@ -184,13 +192,76 @@ module.exports = {
var xcBuildConfiguration =
xcodeproj.pbxXCBuildConfigurationSection();
-var plist_file_entry = _.find(xcBuildConfiguration, function
(entry) { return entry.buildSettings entry.buildSettings.INFOPLIST_FILE; });
-var plist_file = path.join(project_dir,
plist_file_entry.buildSettings.INFOPLIST_FILE.replace(/^(.*)$/g,
'$1').replace(/\\/g, ''));
-var config_file = path.join(path.dirname(plist_file),
'config.xml');
-if (!fs.existsSync(plist_file) || !fs.existsSync(config_file)) {
+// CB-9033
+var plist_file_index;
+var plist_file_entry = _.find(xcBuildConfiguration, function
(entry,index) {
+if (entry.buildSettings entry.buildSettings.INFOPLIST_FILE)
{
+
+var plist_file = path.join(project_dir,
entry.buildSettings.INFOPLIST_FILE.replace(/^(.*)$/g, '$1').replace(/\\/g,
''));
+ if (!fs.existsSync(plist_file))
+return false;
+
+var config_file = path.join(path.dirname(plist_file),
'config.xml');
+ if (!fs.existsSync(config_file))
+return false;
+
+// only return project that contains both a plist and a
config.xml (especially to discard apple watch extension/app)
+plist_file_index = index;
--- End diff --
I did not know about the SKIP_INSTALL but that would be a good additional
check : thanks for the pointer.
Nevertheless, you still need to check that both the .PLIST and the
CONFIG.XML files exist eventually, so it won't totally replace the test.
I will upgrade my code anyway
Olivier
2015-06-02 11:49 GMT+02:00 Georgi Alexandrov notificati...@github.com:
In cordova-lib/src/plugman/platforms/ios.js
https://github.com/apache/cordova-lib/pull/219#discussion_r31507207:
-if (!fs.existsSync(plist_file) || !fs.existsSync(config_file))
{
+// CB-9033
+var plist_file_index;
+var plist_file_entry = _.find(xcBuildConfiguration, function
(entry,index) {
+if (entry.buildSettings
entry.buildSettings.INFOPLIST_FILE) {
+
+var plist_file = path.join(project_dir,
entry.buildSettings.INFOPLIST_FILE.replace(/^(.*)$/g, '$1').replace(/\\/g,
''));
+ if (!fs.existsSync(plist_file))
+return false;
+
+var config_file = path.join(path.dirname(plist_file),
'config.xml');
+ if (!fs.existsSync(config_file))
+return false;
+
+// only return project that contains both a plist and
a config.xml (especially to discard apple watch extension/app)
+plist_file_index = index;
Instead of checking for config.xml can we check for SKIP_INSTALL property
in BuildSettings. SKIP_INSTALL property should be missing or equals to NO
for the iPhone app target and should equals to YES for WatchKit Extension
and WatchKit App.
â
Reply to this email directly or view it on GitHub
https://github.com/apache/cordova-lib/pull/219/files#r31507207.
--
ıllıllı ɹÇ!Ê!×o ıllıllı
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/219#discussion_r31519205 --- Diff: cordova-lib/package.json --- @@ -42,7 +42,7 @@ underscore: 1.7.0, unorm: 1.3.3, valid-identifier: 0.0.1, -xcode: 0.6.7 +xcode: https://github.com/ogoguel/node-xcode/tarball/17926117b388d08f05ec2db1e1ad8262f67a2a8d; --- End diff -- A pull request has been sent to node-xcode ( https://github.com/alunny/node-xcode/pull/47), but in the meantime, I was using a tarball reference to have a working version Actually, my pull request has just been merged into node-xcode master, but the version not yet updated into the npm repository : what should I put into the package.json in the meantime ? https://github.com/alunny/node-xcode.git ? Thanks for your pointer Cheers Olivier 2015-06-02 11:38 GMT+02:00 Georgi Alexandrov notificati...@github.com: In cordova-lib/package.json https://github.com/apache/cordova-lib/pull/219#discussion_r31506402: @@ -42,7 +42,7 @@ underscore: 1.7.0, unorm: 1.3.3, valid-identifier: 0.0.1, -xcode: 0.6.7 +xcode: https://github.com/ogoguel/node-xcode/tarball/17926117b388d08f05ec2db1e1ad8262f67a2a8d; You should create PR with your changes to node-xcode https://github.com/alunny/node-xcode instead of using tarball dependency â Reply to this email directly or view it on GitHub https://github.com/apache/cordova-lib/pull/219/files#r31506402. -- ıllıllı ɹÇ!Ê!×o ıllıllı --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[Android] VERSION_CODE generation
I just fixed CB-9080 by removing the fix for CB-8834, since I consider VERSION_DOWNGRADE to be easily worked around while not launching the application on older devices is an unacceptable fail state. The thing is why is VERSION_DOWNGRADE happening in the first place, and why are we generating the versionCode? This code should be linear every time you actually release something to the play store, and otherwise should stay the same. I know there was a bunch of messing around with it to sync it to whatever Apple does, but I don't know if that's the right approach here. See this form more info on versioning: http://developer.android.com/tools/publishing/versioning.html Can anyone explain more about why we're generating the versionCode the way we are right now?
Re: [Android] VERSION_CODE generation
I can shed some light. The code for it is here: https://github.com/apache/cordova-android/blob/master/bin/templates/project/build.gradle#L178 There are two times we fiddle with it: 1 - When building multiple architectures (cough crosswalk cough) 2 - When a minSdkVersion is set. Play store requires that each architecture-dependent .apk has a unique versionCode, so that's why we do that. Play store also requires that when using multiple apks, apks with a higher minSdkVersion have higher versionCodes. https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview outlines instructions for building multiple apks: Install xwalk and run: cordova build --release Uninstall xwalk and run: cordova build --release -- --minSdkVersion=21 This gives three apks where versionCode is bigger in the right cases. The reason to not want xwalk for 21 is that it has an updating webview anyways. So, where I was seeing downgrade happen a lot was when going back and forth between xwalk and system webview. Sad that adb can't just deal with it on older devices :S. I think it's fine to just remove the -d flag as you've done. On Tue, Jun 2, 2015 at 11:01 AM, Joe Bowser bows...@gmail.com wrote: I just fixed CB-9080 by removing the fix for CB-8834, since I consider VERSION_DOWNGRADE to be easily worked around while not launching the application on older devices is an unacceptable fail state. The thing is why is VERSION_DOWNGRADE happening in the first place, and why are we generating the versionCode? This code should be linear every time you actually release something to the play store, and otherwise should stay the same. I know there was a bunch of messing around with it to sync it to whatever Apple does, but I don't know if that's the right approach here. See this form more info on versioning: http://developer.android.com/tools/publishing/versioning.html Can anyone explain more about why we're generating the versionCode the way we are right now?
Re: Best place to browse plugins
Looks ok to me. Not sure if Apache RAT passes it, but I think it would. If it doesn't its easily worked around since we would have manually verified that it passes (and put it in the ignore file for RAT) On Tue, Jun 2, 2015 at 6:18 AM, Raymond Camden raymondcam...@gmail.com wrote: So adding a # in front of each line makes it compile. Here is a Gist showing the change - since the ASF is *incredibly* particular about stuff, do the # marks 'break' something for them? https://gist.github.com/cfjedimaster/a236919daea219e4c5d2 And here is the rendered HTML: http://static.raymondcamden.com/README.html Does this seem ok for folks? On Mon, Jun 1, 2015 at 10:38 PM, Shazron shaz...@gmail.com wrote: Please send an email to dev-unsubscr...@cordova.apache.org On Monday, June 1, 2015, Great Courses ttccour...@gmail.com wrote: plz can you all remove me from the list. you all are doing great work, am not that smart or deserve to be in this intelligent group. Thanks, On Sat, May 30, 2015 at 2:46 PM, Joerg Holz h...@hamburg.de javascript:_e(%7B%7D,'cvml','h...@hamburg.de'); wrote: I’m a cordova developer. The idea to move the plugins to npm was a very bad one. No professional description, no professional searching. From a developer view, there is a need to have an overview off all plugins - just for inspiration There is a need to have a filter for platforms, the maintainer, last update, … and the most important and complicated one: Is the plugin checked, checked for platform, checked for version? Have you ever tried to bring a three wheel selector in a cordova application? That is a great job. Sorry for posting a screenshot, but this simple wheeler took me one week for working on iOS, Android and Windows. I tried every plugin, every modification of every plugin, I split the platforms … in the end I used mobiscroll and rewrote it for my needs. Just for selecting a timespan. Cordova is great, the most important job for the future is: Let give the people the power of cordova by good plugins. Jörg Am 29.05.2015 um 02:55 schrieb Gorkem Ercan gorkem.er...@gmail.com javascript:_e(%7B%7D,'cvml','gorkem.er...@gmail.com');: On 28 May 2015, at 19:41, Murat Sutunc wrote: I had some free time today and started working on a plugin search prototype. Currently it doesn't offer much but it's very similar to what Gulp has. GH: https://github.com/muratsu/cordova-plugin-search Imgur (can't add images to mails :( ): http://imgur.com/sX8oFcJ One problem I've run into is discoverability. Currently we're using the keyword `ecosystem:cordova` with all of the plugins. Ecosystem is a wider term than plugins and will most likely contain irrelevant search results. It does, I use it and at least all the cordova-platforms appear on the results. I was hoping that we switch to using `cordova-plugin` or `cordovaplugin` keyword going forward for better discoverability. Also for comparison, yeoman uses `yeoman-generator`, gulp uses `gulpplugin` and grunt uses `gruntplugin`. Thoughts? +1. I guess there is no way to add them for all the existing plugins though. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com javascript:_e(%7B%7D,'cvml','stevengil...@gmail.com');] Sent: Thursday, May 28, 2015 3:35 PM To: dev@cordova.apache.org javascript:_e(%7B%7D,'cvml','dev@cordova.apache.org'); Cc: Tommy-Carlos Williams Subject: Re: Best place to browse plugins npm does have a plan to improve their ecosystem + communities later this year. We will essentially get a portal for cordova on npmjs. I also agree in turning plugins.cordova.io into a Gulp Yeoman style search page. Probably won't be doing that until our current registry is shut down I imagine. On Wed, May 27, 2015 at 7:42 AM, Kerri Shotts kerrisho...@gmail.com javascript:_e(%7B%7D,'cvml','kerrisho...@gmail.com'); wrote: +1 I've used both Gulp Yeoman's search, and prefer both to NPM (although it's not difficult to be better than NPM's search). I also think close association with the brand and site are important. For those users who don't know about Node NPM yet, it's quickly apparent that there's a large community creating plugins for Cordova, and for everyone else, we have a URL that helps reinforce the Cordova name. NPM would still be canonical, of course. (Now if NPM improved their search and did some nice work around ecosystems, perhaps the above wouldn't be necessary. But I'm not going to hold my breath...) On May 27, 2015 at 8:19:35 AM, Tommy-Carlos Williams (to...@devgeeks.org javascript:_e(%7B%7D,'cvml','to...@devgeeks.org ');) wrote: +1 On 26 May 2015, at 21:44, Carlos Santana csantan...@gmail.com javascript:_e(%7B%7D,'cvml','csantan...@gmail.com'); wrote: I would like to see plugin.cordova.io be a page
Re: Best place to browse plugins
Ok. So... this is my first time. I commit to the repo and... in theory npm will just pick it up. Here goes nothing. On Tue, Jun 2, 2015 at 10:08 AM, Shazron shaz...@gmail.com wrote: Looks ok to me. Not sure if Apache RAT passes it, but I think it would. If it doesn't its easily worked around since we would have manually verified that it passes (and put it in the ignore file for RAT) On Tue, Jun 2, 2015 at 6:18 AM, Raymond Camden raymondcam...@gmail.com wrote: So adding a # in front of each line makes it compile. Here is a Gist showing the change - since the ASF is *incredibly* particular about stuff, do the # marks 'break' something for them? https://gist.github.com/cfjedimaster/a236919daea219e4c5d2 And here is the rendered HTML: http://static.raymondcamden.com/README.html Does this seem ok for folks? On Mon, Jun 1, 2015 at 10:38 PM, Shazron shaz...@gmail.com wrote: Please send an email to dev-unsubscr...@cordova.apache.org On Monday, June 1, 2015, Great Courses ttccour...@gmail.com wrote: plz can you all remove me from the list. you all are doing great work, am not that smart or deserve to be in this intelligent group. Thanks, On Sat, May 30, 2015 at 2:46 PM, Joerg Holz h...@hamburg.de javascript:_e(%7B%7D,'cvml','h...@hamburg.de'); wrote: I’m a cordova developer. The idea to move the plugins to npm was a very bad one. No professional description, no professional searching. From a developer view, there is a need to have an overview off all plugins - just for inspiration There is a need to have a filter for platforms, the maintainer, last update, … and the most important and complicated one: Is the plugin checked, checked for platform, checked for version? Have you ever tried to bring a three wheel selector in a cordova application? That is a great job. Sorry for posting a screenshot, but this simple wheeler took me one week for working on iOS, Android and Windows. I tried every plugin, every modification of every plugin, I split the platforms … in the end I used mobiscroll and rewrote it for my needs. Just for selecting a timespan. Cordova is great, the most important job for the future is: Let give the people the power of cordova by good plugins. Jörg Am 29.05.2015 um 02:55 schrieb Gorkem Ercan gorkem.er...@gmail.com javascript:_e(%7B%7D,'cvml','gorkem.er...@gmail.com');: On 28 May 2015, at 19:41, Murat Sutunc wrote: I had some free time today and started working on a plugin search prototype. Currently it doesn't offer much but it's very similar to what Gulp has. GH: https://github.com/muratsu/cordova-plugin-search Imgur (can't add images to mails :( ): http://imgur.com/sX8oFcJ One problem I've run into is discoverability. Currently we're using the keyword `ecosystem:cordova` with all of the plugins. Ecosystem is a wider term than plugins and will most likely contain irrelevant search results. It does, I use it and at least all the cordova-platforms appear on the results. I was hoping that we switch to using `cordova-plugin` or `cordovaplugin` keyword going forward for better discoverability. Also for comparison, yeoman uses `yeoman-generator`, gulp uses `gulpplugin` and grunt uses `gruntplugin`. Thoughts? +1. I guess there is no way to add them for all the existing plugins though. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com javascript:_e(%7B%7D,'cvml','stevengil...@gmail.com');] Sent: Thursday, May 28, 2015 3:35 PM To: dev@cordova.apache.org javascript:_e(%7B%7D,'cvml','dev@cordova.apache.org'); Cc: Tommy-Carlos Williams Subject: Re: Best place to browse plugins npm does have a plan to improve their ecosystem + communities later this year. We will essentially get a portal for cordova on npmjs. I also agree in turning plugins.cordova.io into a Gulp Yeoman style search page. Probably won't be doing that until our current registry is shut down I imagine. On Wed, May 27, 2015 at 7:42 AM, Kerri Shotts kerrisho...@gmail.com javascript:_e(%7B%7D,'cvml','kerrisho...@gmail.com'); wrote: +1 I've used both Gulp Yeoman's search, and prefer both to NPM (although it's not difficult to be better than NPM's search). I also think close association with the brand and site are important. For those users who don't know about Node NPM yet, it's quickly apparent that there's a large community creating plugins for Cordova, and for everyone else, we have a URL that helps reinforce the Cordova name. NPM would still be canonical, of course. (Now if NPM improved their search and did some nice work around ecosystems, perhaps the above wouldn't be necessary. But I'm not going to hold my breath...) On May 27, 2015 at 8:19:35 AM, Tommy-Carlos Williams (to...@devgeeks.org javascript:_e(%7B%7D,'cvml','to...@devgeeks.org ');) wrote:
Re: Best place to browse plugins
Done - so how soon will npm pick up on the change so I can see? On Tue, Jun 2, 2015 at 10:17 AM, Raymond Camden raymondcam...@gmail.com wrote: Ok. So... this is my first time. I commit to the repo and... in theory npm will just pick it up. Here goes nothing. On Tue, Jun 2, 2015 at 10:08 AM, Shazron shaz...@gmail.com wrote: Looks ok to me. Not sure if Apache RAT passes it, but I think it would. If it doesn't its easily worked around since we would have manually verified that it passes (and put it in the ignore file for RAT) -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: npm info cordova returning version 5.1.0
I see the 'latest' tag as 5.0.0? That is what is associated with the dist
tarball you see.
On Tue, Jun 2, 2015 at 7:25 AM, Nikhil Khandelwal nikhi...@microsoft.com
wrote:
Why does npm info cordova - give me 5.1.0 version which points to cordova
5.0.0 tgz? See the lines below in asterisk.
{ name: 'cordova',
description: 'Cordova command line interface tool',
'dist-tags':
{ latest: '5.0.0',
rc: '5.1.0',
'3.6.0-0.2.8': '3.6.0-0.2.8',
nightly: '4.1.3-nightly.2014.10.21' },
versions:
[ '0.0.0-fake',
'0.0.1',
'5.0.0',
*** '5.1.0' ],
time:
{ modified: '2015-06-02T02:55:19.592Z',
created: '2012-07-14T22:05:40.306Z',
'5.0.0': '2015-04-16T20:16:51.255Z',
*** '5.1.0': '2015-05-27T23:54:43.677Z' },
preferGlobal: 'true',
main: 'cordova',
engines: { node: '=0.9.9' },
engineStrict: true,
bin: { cordova: './bin/cordova' },
scripts:
{ test: 'node node_modules/jasmine-node/bin/jasmine-node
--captureExceptions --color spec',
cover: 'node node_modules/istanbul/lib/cli.js cover --root src
--print detail node_modules/jasmine-node/bin/jasmine-node -- spec' },
dependencies:
{ 'cordova-lib': '5.0.0',
q: '1.0.1',
nopt: '3.0.1',
underscore: '1.7.0' },
devDependencies:
{ istanbul: '^0.3.4',
grunt: '0.4.5',
'grunt-retire': '0.3.7',
'jasmine-node': '1.14.5' },
dist:
{ shasum: '696907aff7c889beea4422b6c80e57558a905c05',
tarball: 'http://registry.npmjs.org/cordova/-/cordova-5.0.0.tgz'
},
directories: {} }
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] 4.0.0 Windows Release
+1 -verified platform could be added, built and run on windows8.1 and windows10 -verified windows10 target support Thx! Sergey -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, June 2, 2015 8:01 AM To: dev@cordova.apache.org Subject: Re: [VOTE] 4.0.0 Windows Release +1 - ran coho verify-archive - created an app and add windows#4.0.0 as a platform, installed device plugin, and verified passing tests. - manually reviewed licenses @purplecabbage risingj.com On Fri, May 29, 2015 at 1:15 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Please review and vote on this Windows Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9064 Cordova-windows have been published to: dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9064/ The packages were published from their corresponding git tags: cordova-windows:4.0.0 (95060fc) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-windows#4.0.0 Upon a successful vote I will upload the archive to dist/. I'll need someone to publish it to NPM, and post the blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting .md Thanks, Nikhil
Re: Best place to browse plugins
I've gone through about half of them but I'll just keep going. If we can just remove them completely, then next time we mod the docs they can be killed then too. On Tue, Jun 2, 2015 at 10:49 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Don't we have to publish the plugin to npm for this to be picked up? I think npm does not look at the git repo itself. Also, we might as well remove the license, ASF does not require docs to have the license header - only sources. .md files should ideally be part of RAT excludes. Thanks, Nikhil -Original Message- From: Raymond Camden [mailto:raymondcam...@gmail.com] Sent: Tuesday, June 2, 2015 8:28 AM To: dev@cordova.apache.org Subject: Re: Best place to browse plugins Done - so how soon will npm pick up on the change so I can see? On Tue, Jun 2, 2015 at 10:17 AM, Raymond Camden raymondcam...@gmail.com wrote: Ok. So... this is my first time. I commit to the repo and... in theory npm will just pick it up. Here goes nothing. On Tue, Jun 2, 2015 at 10:08 AM, Shazron shaz...@gmail.com wrote: Looks ok to me. Not sure if Apache RAT passes it, but I think it would. If it doesn't its easily worked around since we would have manually verified that it passes (and put it in the ignore file for RAT) -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Best place to browse plugins
Once you are done we can start a discuss for a plugins release. Thanks Ray! On Jun 2, 2015 8:53 AM, Raymond Camden raymondcam...@gmail.com wrote: I've gone through about half of them but I'll just keep going. If we can just remove them completely, then next time we mod the docs they can be killed then too. On Tue, Jun 2, 2015 at 10:49 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Don't we have to publish the plugin to npm for this to be picked up? I think npm does not look at the git repo itself. Also, we might as well remove the license, ASF does not require docs to have the license header - only sources. .md files should ideally be part of RAT excludes. Thanks, Nikhil -Original Message- From: Raymond Camden [mailto:raymondcam...@gmail.com] Sent: Tuesday, June 2, 2015 8:28 AM To: dev@cordova.apache.org Subject: Re: Best place to browse plugins Done - so how soon will npm pick up on the change so I can see? On Tue, Jun 2, 2015 at 10:17 AM, Raymond Camden raymondcam...@gmail.com wrote: Ok. So... this is my first time. I commit to the repo and... in theory npm will just pick it up. Here goes nothing. On Tue, Jun 2, 2015 at 10:08 AM, Shazron shaz...@gmail.com wrote: Looks ok to me. Not sure if Apache RAT passes it, but I think it would. If it doesn't its easily worked around since we would have manually verified that it passes (and put it in the ignore file for RAT) -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[VOTE] Partial Tools Release June 1, 2015
Please review and vote on this partial Tools Release (lib and cli only) by replying to this email (and keep discussion on the DISCUSS thread) This release is to provide a 4.3.1 patch that pins Android 3.7.2 (a security release). Release issue: https://issues.apache.org/jira/browse/CB-9103 The packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9103/ The packages were published from their corresponding git tags: cordova-lib: 4.3.1 (0f244f6dca) cordova-cli: 4.3.1 (327357a560) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Verified install from npm * Added and built for android and windows platforms (verified patched version of android platform was installed) Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Best place to browse plugins
Don't we have to publish the plugin to npm for this to be picked up? I think npm does not look at the git repo itself. Also, we might as well remove the license, ASF does not require docs to have the license header - only sources. .md files should ideally be part of RAT excludes. Thanks, Nikhil -Original Message- From: Raymond Camden [mailto:raymondcam...@gmail.com] Sent: Tuesday, June 2, 2015 8:28 AM To: dev@cordova.apache.org Subject: Re: Best place to browse plugins Done - so how soon will npm pick up on the change so I can see? On Tue, Jun 2, 2015 at 10:17 AM, Raymond Camden raymondcam...@gmail.com wrote: Ok. So... this is my first time. I commit to the repo and... in theory npm will just pick it up. Here goes nothing. On Tue, Jun 2, 2015 at 10:08 AM, Shazron shaz...@gmail.com wrote: Looks ok to me. Not sure if Apache RAT passes it, but I think it would. If it doesn't its easily worked around since we would have manually verified that it passes (and put it in the ignore file for RAT) -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] 4.0.0 Windows Release
I vote +1 * ran coho verify-archive * Verified tags manually * Verified blank app creates correctly with platform * Verified blank app can be successfully ran and built * Ran smoke testing of mobilespec app (ran autotests) Thanks, Nikhil -Original Message- From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] Sent: Tuesday, June 2, 2015 8:31 AM To: dev@cordova.apache.org Subject: RE: [VOTE] 4.0.0 Windows Release +1 -verified platform could be added, built and run on windows8.1 and windows10 -verified windows10 target support Thx! Sergey -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, June 2, 2015 8:01 AM To: dev@cordova.apache.org Subject: Re: [VOTE] 4.0.0 Windows Release +1 - ran coho verify-archive - created an app and add windows#4.0.0 as a platform, installed device plugin, and verified passing tests. - manually reviewed licenses @purplecabbage risingj.com On Fri, May 29, 2015 at 1:15 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Please review and vote on this Windows Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9064 Cordova-windows have been published to: dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9064/ The packages were published from their corresponding git tags: cordova-windows:4.0.0 (95060fc) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-windows#4.0.0 Upon a successful vote I will upload the archive to dist/. I'll need someone to publish it to NPM, and post the blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting .md Thanks, Nikhil B CB [ X ܚX KK[XZ[ ] ][ X ܚX P ܙݘK \X K ܙ B ܈Y][ۘ[ [X[ K[XZ[ ] Z[ ܙݘK \X K ܙ B - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Best place to browse plugins
I updated every plugin listed here (http://cordova.apache.org/docs/en/5.0.0/cordova_plugins_pluginapis.md.html#Plugin%20APIs) I ran marky-markdown on the README to ensure it spit out HTML. I've pushed up everything. If I need to do anything else to 'officially' start the process, just let me know. On Tue, Jun 2, 2015 at 10:57 AM, Steven Gill stevengil...@gmail.com wrote: Once you are done we can start a discuss for a plugins release. Thanks Ray! On Jun 2, 2015 8:53 AM, Raymond Camden raymondcam...@gmail.com wrote: I've gone through about half of them but I'll just keep going. If we can just remove them completely, then next time we mod the docs they can be killed then too. On Tue, Jun 2, 2015 at 10:49 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Don't we have to publish the plugin to npm for this to be picked up? I think npm does not look at the git repo itself. Also, we might as well remove the license, ASF does not require docs to have the license header - only sources. .md files should ideally be part of RAT excludes. Thanks, Nikhil -Original Message- From: Raymond Camden [mailto:raymondcam...@gmail.com] Sent: Tuesday, June 2, 2015 8:28 AM To: dev@cordova.apache.org Subject: Re: Best place to browse plugins Done - so how soon will npm pick up on the change so I can see? On Tue, Jun 2, 2015 at 10:17 AM, Raymond Camden raymondcam...@gmail.com wrote: Ok. So... this is my first time. I commit to the repo and... in theory npm will just pick it up. Here goes nothing. On Tue, Jun 2, 2015 at 10:08 AM, Shazron shaz...@gmail.com wrote: Looks ok to me. Not sure if Apache RAT passes it, but I think it would. If it doesn't its easily worked around since we would have manually verified that it passes (and put it in the ignore file for RAT) -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Github user TheBosZ commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-107997719 Thanks Daniel! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
