[GitHub] cordova-plugin-file-transfer pull request: Gzip support for wp8.x ...

2015-10-26 Thread daserge
Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/85#issuecomment-151058822
  
Ping, @sviluppatoribk


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

2015-10-26 Thread daserge
Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-151060275
  
Thanks, @shazron.
So do we still need this PR or can it be closed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

2015-10-26 Thread daserge
Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42972214
  
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -552,6 +552,8 @@ - 
(void)connectionDidFinishLoading:(NSURLConnection*)connection
 
 if (self.direction == CDV_TRANSFER_UPLOAD) {
 uploadResponse = [[NSString alloc] initWithData:self.responseData 
encoding:NSUTF8StringEncoding];
+if (uploadResponse == nil)
+uploadResponse = [[NSString alloc] initWithData: 
self.responseData encoding:NSISOLatin1StringEncoding];
--- End diff --

`windows-1252` results in the same error on Windows.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-inappbrowser pull request: CB-9274 Adds missing met...

2015-10-26 Thread dennisexozet
Github user dennisexozet commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/107#issuecomment-151105586
  
Hello contributors,

when will this fix be part of the current branch? It's older than 3 month 
and has not yet been merged.

Generally I'm no friend of these "+1" posts but maybe this will speed up 
the merge process:

+1

Thanks in advance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

2015-10-26 Thread daserge
Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42969855
  
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -552,6 +552,8 @@ - 
(void)connectionDidFinishLoading:(NSURLConnection*)connection
 
 if (self.direction == CDV_TRANSFER_UPLOAD) {
 uploadResponse = [[NSString alloc] initWithData:self.responseData 
encoding:NSUTF8StringEncoding];
+if (uploadResponse == nil)
+uploadResponse = [[NSString alloc] initWithData: 
self.responseData encoding:NSISOLatin1StringEncoding];
--- End diff --

@codable, I want to remind you to sign ICLA - please do it so that your 
code could be pulled in:
http://www.apache.org/dev/new-committers-guide.html#cla

You can use 
[cordova-plugin-test-framework](https://github.com/apache/cordova-plugin-test-framework)
 for testing; please find the workflow described in [this 
comment](https://github.com/apache/cordova-wp8/pull/79#issuecomment-99734573).

I used the following extra test for this PR (its the same as 
`filetransfer.spec.18` just with updated url):
```javascript
it("filetransfer.spec.18b should be able to upload a file 
and handle non-UTF8 encoded response", function (done) {

  
var fileURL = SERVER + '/upload_non_utf';   
  

  
var uploadWin = function (uploadResult) {   
  

  
verifyUpload(uploadResult); 
  

  
if (cordova.platformId === 'ios') { 
  

expect(uploadResult.headers).toBeDefined('Expected headers to be defined.');
  

expect(uploadResult.headers['Content-Type']).toBeDefined('Expected content-type 
header to be defined.');  
}   
  

  
done(); 
  
};  
  

  
// NOTE: removing uploadOptions cause Android to 
timeout  
transfer.upload(localFilePath, fileURL, uploadWin, 
unexpectedCallbacks.httpFail, uploadOptions);  
}, UPLOAD_TIMEOUT); 
  
```

To test the custom [file-transfer 
endpoint](https://github.com/apache/cordova-labs/blob/cordova-filetransfer/server.js)
 I used Heroku (probably a local node server could also be used).
To point the tests to another endpoint change [these 
lines](https://github.com/apache/cordova-plugin-file-transfer/blob/65d28795a6fb31a6eeae866ae5cfd02bfafdb28e/tests/tests.js#L42-L43).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

2015-10-26 Thread daserge
Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/107#discussion_r42970796
  
--- Diff: plugin.xml ---
@@ -20,8 +20,8 @@
 
 http://apache.org/cordova/ns/plugins/1.0;
 xmlns:android="http://schemas.android.com/apk/res/android;
-id="cordova-plugin-file-transfer"
-version="1.3.1-dev">
+id="checkroom-plugin-file-transfer"
--- End diff --

Looks like there are extra unrelated things in the PR, please remove them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[DISCUSS] Copying node_modules during platform install

2015-10-26 Thread Dmitry Blotsky
Hey folks,

I’ve come across a bug with symlinks and platform installation recently. The 
point of interest is this line: 
https://github.com/apache/cordova-ios/blob/4039aeb6f87c6803df5814b8cdefb8c2058504a0/bin/lib/create.js#L93.

Is copying node_modules a safe operation? In my case there was a relative 
symlink inside it when it was copied and as a result some dependencies broke. 
The symlink was created by a previous invocation of “npm link”.

Kindly,
Dmitry


[GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...

2015-10-26 Thread shazron
Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/174#issuecomment-151308616
  
The only thing new is 371c136315b0c4f481ee479242dd769c4280b932 correct?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9565 with logic tweak

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/130


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9565 with logic tweak

2015-10-26 Thread purplecabbage
GitHub user purplecabbage opened a pull request:

https://github.com/apache/cordova-windows/pull/130

CB-9565 with logic tweak

Fixes a small oversight in the previous pull request.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/purplecabbage/cordova-windows CB-9565

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #130


commit 8ea8a719848e296e2cd54b2c5479160a9467046c
Author: Rob Paveza 
Date:   2015-09-22T17:39:19Z

CB-9565: Build failure for Windows 10.  This error is a result of using
x64 Node and an incompatibility with x64 msbuild; the .NET Native compiler
is x86 only (for where it can run).  As a result, when msbuild-x64 tries
to use it, it fails.  This works around the issue by running x86 instead.

commit c36052ba44c412b3927940361aae04dd7ddf124b
Author: Jesse MacFadyen 
Date:   2015-10-26T21:34:19Z

Merge branch 'CB-9565' of https://github.com/MSOpenTech/cordova-windows 
into CB-9565

commit bd87ef2ef95fcc54e669141db8572935a47eb403
Author: Jesse MacFadyen 
Date:   2015-10-26T21:37:31Z

fix logic error




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] cordova-ios 4.0.0 release

2015-10-26 Thread Shazron
Thanks guys!
I've commented on the PR, there is one more commit to add.

Created the board:
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=96
(based off the label you created)

On Mon, Oct 26, 2015 at 8:42 AM, Vladimir Kotikov (Akvelon)
 wrote:
> Hi, guys.
>
> We've cherry-picked all the commits related to iOS9 / Xcode 7 issues into 
> 3.9.x and send corresponding PR to 3.9.x branch [1]. Shazrov, Steve please 
> review when possible.
>
> Regarding new board for 3.9.2 release - neither Sergey nor me don't have a 
> permissions to create a shared queries, so we just tagged issues with 
>  label. You can find all tagged issues using a query [2].
>
> ---
> [1] https://github.com/apache/cordova-ios/pull/175
> [2] 
> https://issues.apache.org/jira/browse/CB-9729?jql=labels%20%3D%20cordova-ios-3.9.2
>
>
> -Original Message-
> From: Shazron [mailto:shaz...@gmail.com]
> Sent: Friday, October 23, 2015 3:29 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] cordova-ios 4.0.0 release
>
> Sorry for the late reply -- took a sick day.
>
> I'd really like to just get cordova-ios 4.x out without a patch release in 
> between, since there are just a few more issues left before we can clear the 
> board (I'll triage it again), and a 4.x release would follow closely a 3.9.2 
> release.
>
> After mulling it over -- what I want and what is needed is of course two 
> things. I really don't want the headache of third-party plugin breakage 
> issues on the first day of release, which will happen. The API removals 
> (although our prerogative) never had a deprecation warning. In a perfect 
> world, after blogging about it and communicating it to plugin authors, they 
> would update their plugins in a backwards compatible way immediately (which I 
> plan to write a howto included in the platform and/or blog post -- there's a 
> jira issue for it)
>
> No plugin author updates things without encountering a breakage after hearing 
> from their users -- blog posts just don't have the impact that code breakage 
> does :) So -- here's a plan:
>
> A cordova-ios-3.9.2 release, there should be two goals:
> 1. iOS 9 / Xcode 7 fixes (scan the 4.x kanban board for all fixed issues) 2. 
> Add deprecation/removal warnings through the macro 
> (https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-ios%2fblob%2fmaster%2fCordovaLib%2fClasses%2fPublic%2fCDVAvailabilityDeprecated.h%23L23=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7cd6ed60025678403e0fd008d2dba59f1b%7c72f988bf86f141af91ab2d7cd011db47%7c1=7p9BQz45eR6YUHUjiySQolzVCT9bNmqidrTQTVkn8OM%3d).
> Not a deprecation, but a removal since that is our prerogative for major 
> version bumps.
>
> For #2, for the API items that have been removed (through the macros)
> -- we include strong language and pointers on how to fix it, and/or 
> instructions for users to contact the plugin author to fix. Not sure how hard 
> -- we could have some introspection in the plugin to actually print out the 
> plugin id responsible.
>
> For cordova-ios-3.9.2 I would create a kanban board "cordova-ios-3.9.2" 
> (linked to label 'cordova-ios-3.9.2'), then go through the cordova-ios-4.x 
> board, see what issues apply, then add the label "cordova-ios-3.9.2" which 
> would automatically appear on the new board. Go through the items in the new 
> board, and cherry-pick the patches into the 3.9.x branch.
>
> Can Microsoft take on this 3.9.2 release while I continue to get the 4.x 
> release out?
>
> FYI -- ATS is handled by the CLI (should be in the next cli release) and is 
> not dependent on the cordova-ios platform.
>
> Thoughts?
>
>
> On Wed, Oct 21, 2015 at 10:24 AM, Nikhil Khandelwal  
> wrote:
>> Sent the message before completing it.
>>
>> What are good tasks to be poached on cordova-ios-4.x? In particular, my team 
>> can help out with cordova-lib related ios tasks. Also, fixing plugins or 
>> filing issues for upcoming breakages are great areas we can help out. ios 
>> 4.x has critical fixes for XCode 7 usage which people need sooner rather 
>> than later [1]. Could you mark them with a tag 'poachable'? We can follow up 
>> on slack as well if this requires back and forth. I'll ping you later today.
>>
>> As for breaking change below, I've not been keeping up ios-4.x as closely - 
>> I must've missed the communication on it. I understand there is a 
>> possibility of breaking because of how "categories" work in Objective-C (I 
>> just read up on it - it's a nifty feature). I also understand that they were 
>> not *intended* to be used. AFAIK we do not document our platform APIs and 
>> even our core plugins (camera) was using this particular API. As we 
>> discussed in cordova F2F, developers do not have high confidence with the 
>> version of plugins (particularly third party) to pick and choose and 
>> anything we could do in how we version our API/manage breaking changes - 
>> will make 

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

2015-10-26 Thread Shazron
This case has been covered by the  tag itself -- the
specifications say there is a "platform" attribute. The engine
requirement will not be checked if you are not on the specified
platform(s).


On Fri, Oct 23, 2015 at 7:21 PM, Carlos Santana  wrote:
> I mean is that I should be allow to add a plugin from a windows/linux
> machine where cocoapod client is not present, then compile on a Mac where
> the pod client is available and "pod install" can run
>
> Will  need to work out the details with engine, I just want to make sure
> that engine tag doesn't stop the whole plugin from being added on a
> windows/linux machine.
>
> On Fri, Oct 23, 2015 at 8:33 PM Shazron  wrote:
>
>> Send PR's or comment on a line in a commit. I think.
>>
>> Not sure what you mean -- the purpose of Cocoapods is to
>> install/uninstall a pod. It is thus a plugin add/install step.
>>
>> On Fri, Oct 23, 2015 at 5:12 PM, Carlos Santana 
>> wrote:
>> > How does this discussion repo works again?
>> > Do we create a github issue pointing to the proposal  to have the
>> > discussion there with comments?
>> >
>> > One thing I notice is that engine the way they work today this will not
>> > work, since we want to allow the plugin to be installed, and cocoapod is
>> > only need it on compile step not plugin add/install step.
>> >
>> >
>> >
>> > On Tue, Oct 20, 2015 at 6:05 AM Vladimir Kotikov (Akvelon) <
>> > v-vlk...@microsoft.com> wrote:
>> >
>> >> Hey, guys.
>> >>
>> >> After ios refactoring the  handling definitely will be a part
>> >> of platform. As for  tag, I guess it make sense to keep this
>> logic
>> >> in LIB and let cordova itself check availability of cocoapods/nuget.
>> >>
>> >> -
>> >> Best regards, Vladimir
>> >>
>> >> -Original Message-
>> >> From: Steven Gill [mailto:stevengil...@gmail.com]
>> >> Sent: Tuesday, October 20, 2015 2:36 AM
>> >> To: dev@cordova.apache.org
>> >> Subject: Re: [DISCUSS] CocoaPods dependencies for iOS plugins
>> >>
>> >> Sweet! Yeah lets see where this lands after the refactor. Dependencies
>> are
>> >> still handled by lib as far as I know. Not sure about framework but I
>> >> assume the same. Vladimir would know about where that code will live
>> after
>> >> the refactor.
>> >>
>> >> Engine + framework tag looks good. Engine tag will have to be extended
>> to
>> >> actually fetch cocoapods + nuget I imagine.
>> >>
>> >> On Mon, Oct 19, 2015 at 4:23 PM, Shazron  wrote:
>> >>
>> >> > This is not a platform specific issue, at least for cordova-ios, and
>> >> > is the domain of the cordova-lib/cli currently (I think the
>> >> > cordova-lib re-factor changes this?)
>> >> >
>> >> > There will be a cordova-discuss doc, but the gist of it is:
>> >> >
>> >> > 
>> >> > 
>> >> > 
>> >> > 
>> >> >
>> >> >  > >> > src="path/to/mynu.nuspec" type="nuspec" />
>> >> >
>> >> > The above use existing documented attributes for both the  and
>> >> >  tags:
>> >> >
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcordo
>> >> > va.apache.org
>> %2fdocs%2fen%2f5.1.1%2fplugin_ref%2fspec.html=01%7c0
>> >> > 1%7cv-vlkoti%40064d.mgd.microsoft.com
>> %7c5e3acbf36e3e43b1eb4d08d2d8de29
>> >> > 40%7c72f988bf86f141af91ab2d7cd011db47%7c1=MVFyYNFESBtyyUxn2mvK5%
>> >> > 2bnOxizyDMAP2WIaCWxJwUM%3d
>> >> >
>> >> >
>> >> > On Sat, Oct 17, 2015 at 11:56 PM, Steven Gill > >
>> >> > wrote:
>> >> > > At the Cordova F2F, everyone seemed to agree that we should bring
>> >> > CocoaPods
>> >> > > support to plugins as dependencies for iOS.
>> >> > >
>> >> > > Cordova-android currently uses Gradle as a way to enable external
>> >> > > dependency resolution for plugins using the framework tag.
>> >> > >
>> >> > > A suggestion about using the engine tag to fetch cocoapods-cli (mac)
>> >> > > & NuGet (windows) followed by using the framework tag was discussed.
>> >> > >
>> >> > > The minutes[1] show Carlos, Shaz and Raghav as looking into the
>> design.
>> >> > > Someone should write up a proposal on cordova-discuss[2] and create
>> >> > > the issues. Post them in this thread.
>> >> > >
>> >> > > This shouldn't take priority over cordova-ios 4 issues.
>> >> > >
>> >> > > [1]
>> >> > >
>> >> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdocs
>> .
>> >> > google.com
>> %2fdocument%2fd%2f1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCk
>> >> > bU%2fedit%3fusp%3dsharing=01%7c01%7cv-vlkoti%40064d.mgd.microsoft
>> >> > .com%7c5e3acbf36e3e43b1eb4d08d2d8de2940%7c72f988bf86f141af91ab2d7cd011
>> >> > db47%7c1=GPpiC70BVEDo4gvljKi6OqXsdGUOLPHmhaDKXH6P7kQ%3d
>> >> > > [2]
>> >> > >
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit
>> >> > > hub.com
>> %2fcordova%2fcordova-discuss=01%7c01%7cv-vlkoti%40064d.m
>> >> > > gd.microsoft.com
>> %7c5e3acbf36e3e43b1eb4d08d2d8de2940%7c72f988bf86f141
>> >> > > af91ab2d7cd011db47%7c1=t4gpBVojZ3H94gCLRboa%2fvkHlBCoVxZsWuiCH
>> >> > > TVkylo%3d
>> 

[GitHub] cordova-windows pull request: CB-9565: Build failure for Windows 1...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/123


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: Prepare cordova-ios 3.9.2 release

2015-10-26 Thread shazron
Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/175#issuecomment-151285278
  
This should make it in as well: 
https://issues.apache.org/jira/browse/CB-9721




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] CocoaPods dependencies for iOS plugins

2015-10-26 Thread Carlos Santana
Great !
So in other words you are telling me RTFM :-p
On Mon, Oct 26, 2015 at 5:56 PM Shazron  wrote:

> This case has been covered by the  tag itself -- the
> specifications say there is a "platform" attribute. The engine
> requirement will not be checked if you are not on the specified
> platform(s).
>
>
> On Fri, Oct 23, 2015 at 7:21 PM, Carlos Santana 
> wrote:
> > I mean is that I should be allow to add a plugin from a windows/linux
> > machine where cocoapod client is not present, then compile on a Mac where
> > the pod client is available and "pod install" can run
> >
> > Will  need to work out the details with engine, I just want to make sure
> > that engine tag doesn't stop the whole plugin from being added on a
> > windows/linux machine.
> >
> > On Fri, Oct 23, 2015 at 8:33 PM Shazron  wrote:
> >
> >> Send PR's or comment on a line in a commit. I think.
> >>
> >> Not sure what you mean -- the purpose of Cocoapods is to
> >> install/uninstall a pod. It is thus a plugin add/install step.
> >>
> >> On Fri, Oct 23, 2015 at 5:12 PM, Carlos Santana 
> >> wrote:
> >> > How does this discussion repo works again?
> >> > Do we create a github issue pointing to the proposal  to have the
> >> > discussion there with comments?
> >> >
> >> > One thing I notice is that engine the way they work today this will
> not
> >> > work, since we want to allow the plugin to be installed, and cocoapod
> is
> >> > only need it on compile step not plugin add/install step.
> >> >
> >> >
> >> >
> >> > On Tue, Oct 20, 2015 at 6:05 AM Vladimir Kotikov (Akvelon) <
> >> > v-vlk...@microsoft.com> wrote:
> >> >
> >> >> Hey, guys.
> >> >>
> >> >> After ios refactoring the  handling definitely will be a
> part
> >> >> of platform. As for  tag, I guess it make sense to keep this
> >> logic
> >> >> in LIB and let cordova itself check availability of cocoapods/nuget.
> >> >>
> >> >> -
> >> >> Best regards, Vladimir
> >> >>
> >> >> -Original Message-
> >> >> From: Steven Gill [mailto:stevengil...@gmail.com]
> >> >> Sent: Tuesday, October 20, 2015 2:36 AM
> >> >> To: dev@cordova.apache.org
> >> >> Subject: Re: [DISCUSS] CocoaPods dependencies for iOS plugins
> >> >>
> >> >> Sweet! Yeah lets see where this lands after the refactor.
> Dependencies
> >> are
> >> >> still handled by lib as far as I know. Not sure about framework but I
> >> >> assume the same. Vladimir would know about where that code will live
> >> after
> >> >> the refactor.
> >> >>
> >> >> Engine + framework tag looks good. Engine tag will have to be
> extended
> >> to
> >> >> actually fetch cocoapods + nuget I imagine.
> >> >>
> >> >> On Mon, Oct 19, 2015 at 4:23 PM, Shazron  wrote:
> >> >>
> >> >> > This is not a platform specific issue, at least for cordova-ios,
> and
> >> >> > is the domain of the cordova-lib/cli currently (I think the
> >> >> > cordova-lib re-factor changes this?)
> >> >> >
> >> >> > There will be a cordova-discuss doc, but the gist of it is:
> >> >> >
> >> >> > 
> >> >> > 
> >> >> > 
> >> >> > 
> >> >> >
> >> >> >   >> >> > src="path/to/mynu.nuspec" type="nuspec" />
> >> >> >
> >> >> > The above use existing documented attributes for both the 
> and
> >> >> >  tags:
> >> >> >
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcordo
> >> >> > va.apache.org
> >> %2fdocs%2fen%2f5.1.1%2fplugin_ref%2fspec.html=01%7c0
> >> >> > 1%7cv-vlkoti%40064d.mgd.microsoft.com
> >> %7c5e3acbf36e3e43b1eb4d08d2d8de29
> >> >> >
> 40%7c72f988bf86f141af91ab2d7cd011db47%7c1=MVFyYNFESBtyyUxn2mvK5%
> >> >> > 2bnOxizyDMAP2WIaCWxJwUM%3d
> >> >> >
> >> >> >
> >> >> > On Sat, Oct 17, 2015 at 11:56 PM, Steven Gill <
> stevengil...@gmail.com
> >> >
> >> >> > wrote:
> >> >> > > At the Cordova F2F, everyone seemed to agree that we should bring
> >> >> > CocoaPods
> >> >> > > support to plugins as dependencies for iOS.
> >> >> > >
> >> >> > > Cordova-android currently uses Gradle as a way to enable external
> >> >> > > dependency resolution for plugins using the framework tag.
> >> >> > >
> >> >> > > A suggestion about using the engine tag to fetch cocoapods-cli
> (mac)
> >> >> > > & NuGet (windows) followed by using the framework tag was
> discussed.
> >> >> > >
> >> >> > > The minutes[1] show Carlos, Shaz and Raghav as looking into the
> >> design.
> >> >> > > Someone should write up a proposal on cordova-discuss[2] and
> create
> >> >> > > the issues. Post them in this thread.
> >> >> > >
> >> >> > > This shouldn't take priority over cordova-ios 4 issues.
> >> >> > >
> >> >> > > [1]
> >> >> > >
> >> >> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdocs
> >> .
> >> >> > google.com
> >> %2fdocument%2fd%2f1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCk
> >> >> >
> bU%2fedit%3fusp%3dsharing=01%7c01%7cv-vlkoti%40064d.mgd.microsoft
> >> >> >
> .com%7c5e3acbf36e3e43b1eb4d08d2d8de2940%7c72f988bf86f141af91ab2d7cd011
> >> >> > 

[GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...

2015-10-26 Thread shazron
Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/174#issuecomment-151310777
  
Pulled in. Can you add docs too, please? Thanks :) 
Here: 
https://github.com/apache/cordova-docs/blob/master/www/docs/en/edge/guide/platforms/ios/config.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[DISCUSS] Cordova App Hello World Release

2015-10-26 Thread Steven Gill
Does anyone have any reason to delay a cordova-app-hello-world release?
Any outstanding patches to land?


[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-10-26 Thread shazron
Github user shazron commented on the pull request:

https://github.com/apache/cordova-lib/pull/219#issuecomment-151321669
  
Unfortunately I can't take this patch in as is. 
The apple watch sample extension contains source files, which are not 
Apache Licensed: projects/ios-apple-watch/AppleWatch WatchKit Extension (but 
that's not the main point).

Firstly - there is no need to add the source files in. See 
https://github.com/apache/cordova-lib/tree/master/cordova-lib/spec-plugman/projects
 where the projects only contain only the necessary files for the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-10-26 Thread shazron
Github user shazron commented on the pull request:

https://github.com/apache/cordova-lib/pull/219#issuecomment-151323347
  
11 failing tests:

```
Failures:

  1) ios project handler installation of  elements should call 
into xcodeproj's addSourceFile appropriately when element has no target-dir
   Message:
 Expected spy addSourceFile to have been called with [ 
'Plugins/org.test.plugins.dummyplugin/DummyPluginCommand.m', { target : 
'571A463A14DB0A1B007FEAC7' } ] but actual calls were [ 
'Plugins/org.test.plugins.dummyplugin/DummyPluginCommand.m', {  } ]
   Stacktrace:
 Error: Expected spy addSourceFile to have been called with [ 
'Plugins/org.test.plugins.dummyplugin/DummyPluginCommand.m', { target : 
'571A463A14DB0A1B007FEAC7' } ] but actual calls were [ 
'Plugins/org.test.plugins.dummyplugin/DummyPluginCommand.m', {  } ]
at null. 
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/spec-plugman/platforms/ios.spec.js:167:29)

  2) ios project handler installation of  elements should call 
into xcodeproj's addSourceFile appropriately when element has a target-dir
   Message:
 Expected spy addSourceFile to have been called with [ 
'Plugins/org.test.plugins.dummyplugin/targetDir/TargetDirTest.m', { target : 
'571A463A14DB0A1B007FEAC7' } ] but actual calls were [ 
'Plugins/org.test.plugins.dummyplugin/targetDir/TargetDirTest.m', {  } ]
   Stacktrace:
 Error: Expected spy addSourceFile to have been called with [ 
'Plugins/org.test.plugins.dummyplugin/targetDir/TargetDirTest.m', { target : 
'571A463A14DB0A1B007FEAC7' } ] but actual calls were [ 
'Plugins/org.test.plugins.dummyplugin/targetDir/TargetDirTest.m', {  } ]
at null. 
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/spec-plugman/platforms/ios.spec.js:173:29)

  3) ios project handler installation of  elements should call 
into xcodeproj's addFramework appropriately when element has framework=true set
   Message:
 Expected spy addFramework to have been called with [ 
'SampleApp/Plugins/org.test.plugins.dummyplugin/SourceWithFramework.m', { weak 
: false, target : '571A463A14DB0A1B007FEAC7' } ] but actual calls were [ 
'SampleApp/Plugins/org.test.plugins.dummyplugin/SourceWithFramework.m', { weak 
: false } ]
   Stacktrace:
 Error: Expected spy addFramework to have been called with [ 
'SampleApp/Plugins/org.test.plugins.dummyplugin/SourceWithFramework.m', { weak 
: false, target : '571A463A14DB0A1B007FEAC7' } ] but actual calls were [ 
'SampleApp/Plugins/org.test.plugins.dummyplugin/SourceWithFramework.m', { weak 
: false } ]
at null. 
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/spec-plugman/platforms/ios.spec.js:192:29)

  4) ios project handler installation of  elements should 
call into xcodeproj's addResourceFile
   Message:
 Expected spy addResourceFile to have been called with [ 
'Resources/DummyPlugin.bundle', { target : '571A463A14DB0A1B007FEAC7' } ] but 
actual calls were [ 'Resources/DummyPlugin.bundle' ]
   Stacktrace:
 Error: Expected spy addResourceFile to have been called with [ 
'Resources/DummyPlugin.bundle', { target : '571A463A14DB0A1B007FEAC7' } ] but 
actual calls were [ 'Resources/DummyPlugin.bundle' ]
at null. 
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/spec-plugman/platforms/ios.spec.js:258:29)

  5) ios project handler installation of  elements 
should call into xcodeproj's addFramework
   Message:
 Expected spy addFramework to have been called with [ 
'SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework', { 
customFramework : true, target : '571A463A14DB0A1B007FEAC7' } ] but actual 
calls were [ 'SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework', 
{ customFramework : true } ]
   Stacktrace:
 Error: Expected spy addFramework to have been called with [ 
'SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework', { 
customFramework : true, target : '571A463A14DB0A1B007FEAC7' } ] but actual 
calls were [ 'SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework', 
{ customFramework : true } ]
at null. 
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/spec-plugman/platforms/ios.spec.js:286:29)

  6) ios project handler uninstallation of  elements should 
call into xcodeproj's removeSourceFile appropriately when element has no 
target-dir
   Message:
 Expected spy removeSourceFile to have been called with [ 
'Plugins/org.test.plugins.dummyplugin/DummyPluginCommand.m', { target : 
'571A463A14DB0A1B007FEAC7' } ] but actual calls were [ 
'Plugins/org.test.plugins.dummyplugin/DummyPluginCommand.m' ]
   Stacktrace:
 Error: Expected spy removeSourceFile to have been called with [ 
'Plugins/org.test.plugins.dummyplugin/DummyPluginCommand.m', { target : 
'571A463A14DB0A1B007FEAC7' } ] but actual 

[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

2015-10-26 Thread shazron
Github user shazron commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-151282089
  
With the next CLI release when it comes out, this PR will not be relevant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device pull request: Don't fail completely if devic...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device pull request: CB-9865 Better simulator detec...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/41


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device pull request: Few changes in Spanish Transla...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova App Hello World Release

2015-10-26 Thread Steven Gill
Issue: https://issues.apache.org/jira/browse/CB-9870

On Mon, Oct 26, 2015 at 4:34 PM, Steven Gill  wrote:

> Does anyone have any reason to delay a cordova-app-hello-world release?
> Any outstanding patches to land?
>
>
>


Re: [DISCUSS] Cordova App Hello World Release

2015-10-26 Thread Steven Gill
RELEASE NOTES:
https://github.com/apache/cordova-app-hello-world/blob/master/RELEASENOTES.md

On Mon, Oct 26, 2015 at 4:36 PM, Steven Gill  wrote:

> Issue: https://issues.apache.org/jira/browse/CB-9870
>
> On Mon, Oct 26, 2015 at 4:34 PM, Steven Gill 
> wrote:
>
>> Does anyone have any reason to delay a cordova-app-hello-world release?
>> Any outstanding patches to land?
>>
>>
>>
>


[GitHub] cordova-docs pull request: Remove misleading reference to "publish...

2015-10-26 Thread dblotsky
Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/402#issuecomment-151297369
  
@stevengill or @purplecabbage: I'm not very familiar with this topic. Could 
either one of you please review this when you have a moment? Or point to 
someone that has knowledge in this area? Thanks, guys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: CB-9836 Add .gitattributes to prevent CR...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/173


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] Cordova-common release

2015-10-26 Thread Steven Gill
I'm going to rescind my +1 and agree with Carlos (in the discuss thread)
that we should bump the version to 1.0.0. Check the discuss thread for his
feedback.

On Fri, Oct 23, 2015 at 5:08 PM, Steven Gill  wrote:

> +1
>
> * Ran coho audit-license-headers over the repo
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ran coho verify-archive successfully.
>
> On Fri, Oct 23, 2015 at 1:34 AM, Vladimir Kotikov (Akvelon) <
> v-vlk...@microsoft.com> wrote:
>
>> Please review and vote on this Cordova-common Release
>> by replying to this email (and keep discussion on the DISCUSS thread)
>>
>> Release issue: https://issues.apache.org/jira/browse/CB-9850
>>
>> Both tools have been published to dist/dev:
>> https://dist.apache.org/repos/dist/dev/cordova/CB-9850/
>>
>> The packages were published from their corresponding git tags:
>> cordova-lib: common-0.1.0 (6ec023d295)
>>
>> Upon a successful vote I will upload the archives to dist/, publish them
>> to NPM, and post the corresponding blog post.
>> Voting guidelines:
>> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>>
>> Voting will go on for a minimum of 48 hours.
>>
>> I vote +1:
>> * Ran coho audit-license-headers over the repo
>> * Ran coho check-license to ensure all dependencies and subdependencies
>> have Apache-compatible licenses
>> * Ensured test were passing when repo was tagged
>>
>> -
>> Best regards, Vladimir
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>
>


[GitHub] cordova-plugin-device pull request: Added basic Android support fo...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device pull request: Don't fail completely if devic...

2015-10-26 Thread purplecabbage
Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/27#issuecomment-151306983
  
Realistically this cannot happen unless somehow the JS side of the plugin 
exists and the native side does not. 
This would be a signal of MUCH bigger issues, and failing completely is 
probably the right thing to do.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: Remove misleading reference to "publish...

2015-10-26 Thread stevengill
Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/402#issuecomment-151317454
  
I think @nikhilkh might have more info on this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...

2015-10-26 Thread charlesverge
Github user charlesverge commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-151165724
  
@nikopolv Does the Sony Aqua M2 with 4.4 kitkat work with the branch issue 
#93 is based off of ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-10-26 Thread csantanapr
Github user csantanapr commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-151138324
  
I'm not android SME, maybe @macdonst can take a look.

My general comment on this PR, is that if you don't know what are not sure 
what's the root cause of the problem, and and not sure about a proper fix you 
should not submit a patch, maybe better to open a new issue in JIRA 
http://issues.cordova.io with all background info you found so far.

PS: Android can be a mess to support, just because something work in one 
version of Android doesn't mean that will work the same way in all other 
versions of Android.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9565: Build failure for Windows 1...

2015-10-26 Thread ghenry22
Github user ghenry22 commented on the pull request:

https://github.com/apache/cordova-windows/pull/123#issuecomment-151123814
  
tested with the mod as in the comments, resolved the error for me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: [DISCUSS] cordova-ios 4.0.0 release

2015-10-26 Thread Vladimir Kotikov (Akvelon)
Hi, guys.

We've cherry-picked all the commits related to iOS9 / Xcode 7 issues into 3.9.x 
and send corresponding PR to 3.9.x branch [1]. Shazrov, Steve please review 
when possible.

Regarding new board for 3.9.2 release - neither Sergey nor me don't have a 
permissions to create a shared queries, so we just tagged issues with 
 label. You can find all tagged issues using a query [2].

---
[1] https://github.com/apache/cordova-ios/pull/175
[2] 
https://issues.apache.org/jira/browse/CB-9729?jql=labels%20%3D%20cordova-ios-3.9.2


-Original Message-
From: Shazron [mailto:shaz...@gmail.com] 
Sent: Friday, October 23, 2015 3:29 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] cordova-ios 4.0.0 release

Sorry for the late reply -- took a sick day.

I'd really like to just get cordova-ios 4.x out without a patch release in 
between, since there are just a few more issues left before we can clear the 
board (I'll triage it again), and a 4.x release would follow closely a 3.9.2 
release.

After mulling it over -- what I want and what is needed is of course two 
things. I really don't want the headache of third-party plugin breakage issues 
on the first day of release, which will happen. The API removals (although our 
prerogative) never had a deprecation warning. In a perfect world, after 
blogging about it and communicating it to plugin authors, they would update 
their plugins in a backwards compatible way immediately (which I plan to write 
a howto included in the platform and/or blog post -- there's a jira issue for 
it)

No plugin author updates things without encountering a breakage after hearing 
from their users -- blog posts just don't have the impact that code breakage 
does :) So -- here's a plan:

A cordova-ios-3.9.2 release, there should be two goals:
1. iOS 9 / Xcode 7 fixes (scan the 4.x kanban board for all fixed issues) 2. 
Add deprecation/removal warnings through the macro 
(https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-ios%2fblob%2fmaster%2fCordovaLib%2fClasses%2fPublic%2fCDVAvailabilityDeprecated.h%23L23=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7cd6ed60025678403e0fd008d2dba59f1b%7c72f988bf86f141af91ab2d7cd011db47%7c1=7p9BQz45eR6YUHUjiySQolzVCT9bNmqidrTQTVkn8OM%3d).
Not a deprecation, but a removal since that is our prerogative for major 
version bumps.

For #2, for the API items that have been removed (through the macros)
-- we include strong language and pointers on how to fix it, and/or 
instructions for users to contact the plugin author to fix. Not sure how hard 
-- we could have some introspection in the plugin to actually print out the 
plugin id responsible.

For cordova-ios-3.9.2 I would create a kanban board "cordova-ios-3.9.2" (linked 
to label 'cordova-ios-3.9.2'), then go through the cordova-ios-4.x board, see 
what issues apply, then add the label "cordova-ios-3.9.2" which would 
automatically appear on the new board. Go through the items in the new board, 
and cherry-pick the patches into the 3.9.x branch.

Can Microsoft take on this 3.9.2 release while I continue to get the 4.x 
release out?

FYI -- ATS is handled by the CLI (should be in the next cli release) and is not 
dependent on the cordova-ios platform.

Thoughts?


On Wed, Oct 21, 2015 at 10:24 AM, Nikhil Khandelwal  
wrote:
> Sent the message before completing it.
>
> What are good tasks to be poached on cordova-ios-4.x? In particular, my team 
> can help out with cordova-lib related ios tasks. Also, fixing plugins or 
> filing issues for upcoming breakages are great areas we can help out. ios 4.x 
> has critical fixes for XCode 7 usage which people need sooner rather than 
> later [1]. Could you mark them with a tag 'poachable'? We can follow up on 
> slack as well if this requires back and forth. I'll ping you later today.
>
> As for breaking change below, I've not been keeping up ios-4.x as closely - I 
> must've missed the communication on it. I understand there is a possibility 
> of breaking because of how "categories" work in Objective-C (I just read up 
> on it - it's a nifty feature). I also understand that they were not 
> *intended* to be used. AFAIK we do not document our platform APIs and even 
> our core plugins (camera) was using this particular API. As we discussed in 
> cordova F2F, developers do not have high confidence with the version of 
> plugins (particularly third party) to pick and choose and anything we could 
> do in how we version our API/manage breaking changes - will make Cordova a 
> smoother experience. The impact of this breaking change is HIGH from the 
> small sample set of plugins we tested.
>
> As far as I understand, Cordova-ios 3.9.x is not usable with XCODE 7 - ATS, 
> ENABLE_BITCODE being two issues[2]. Cordova-ios 4.x is not ready and will 
> likely break the third-party plugins they use when it releases. Should we 
> really push for a patch release for cordova-ios 3.9.x to fix XCODE 7 

[GitHub] cordova-plugin-whitelist pull request: add JIRA issue tracker link

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-whitelist/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device pull request: CB-9865 Better simulator detec...

2015-10-26 Thread alsorokin
Github user alsorokin commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/41#issuecomment-151180573
  
@purplecabbage please have a look, this fixes build failure on older 
versions of XCode


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request: Prepare cordova-ios 3.9.2 release

2015-10-26 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-ios/pull/175

Prepare cordova-ios 3.9.2 release



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-ios 3.9.2-release

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #175


commit 352cc10f4586b9f4b5175c953ae24c1b26d84f7c
Author: sgrebnov 
Date:   2015-10-26T11:23:27Z

CB-9690 Can't submit iPad apps to the App Store for iOS 9

This closes #167

commit 6f771f96afa1bcfa3878550b0a5f94dd95a43866
Author: sgrebnov 
Date:   2015-10-26T11:31:32Z

CB-9610 Fix warning in cordova-ios under Xcode 7

commit 9cab8496c6e45047c0a9cb01a33bf29fa1adab3f
Author: sgrebnov 
Date:   2015-10-26T12:23:09Z

CB-9656 - Xcode can't find CDVViewController.h when archiving in Xcode 7.1 
beta

commit d13597d0b7271b121236612f7479af48e52bca97
Author: sgrebnov 
Date:   2015-10-26T12:36:46Z

CB-9679 - Resource rules issue with iOS 9

commit 8fe5e65390cfd031e351ea54cc0a1ff0d365e980
Author: Vladimir Kotikov 
Date:   2015-10-26T15:26:18Z

Enable NSAllowsArbitraryLoads by default




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device pull request: CB-9865 Better simulator detec...

2015-10-26 Thread alsorokin
GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-device/pull/41

CB-9865 Better simulator detection for iOS

https://issues.apache.org/jira/browse/CB-9865

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-device CB-9865

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit ffc819d5661f5aed98c0b08a5e524fc2d5087320
Author: Alexander Sorokin 
Date:   2015-10-26T15:37:21Z

CB-9865 Better simulator detection for iOS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-whitelist pull request: Update some confusing comme...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-whitelist/pull/8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-10-26 Thread infil00p
Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-151176788
  
Is there a JIRA issue related to this pull request.  We need to be able to 
see what the problem is before we can talk about this issue.  We're not going 
to accept a pull request where you comment code out, especially since git is 
version control and we can just delete it anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: [DISCUSS] Tools Release

2015-10-26 Thread Nikhil Khandelwal
Looking forward to the release today.

Btw, cordova-app-hello-world also needs to be released at the same time and 
cordova-lib needs to take a dependency on the new version. This will resolve 
the npm@3 bug that I’ve seen being reported by multiple people. We should push 
to get that resolved and should be part of our release blog – support for npm@3.

-Nikhil

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Friday, October 23, 2015 2:35 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Tools Release

Okay. I will start work on this release Monday unless anyone has concerns.

-Steve

On Fri, Oct 23, 2015 at 12:57 PM, Nikhil Khandelwal 
wrote:

> +1 - I'm hoping we'll release iOS as well before the next CLI release.
>
> -Nikhil
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Friday, October 23, 2015 12:48 PM
> To: dev@cordova.apache.org
> Subject: [DISCUSS] Tools Release
>
> I think we should release a version of the CLI now, from what Steve 
> told me there is a lot changes going in, and also contains the switch 
> to use npm instead of CPR, and other changes around npm3 and nodejs4
>
> This will allow for trains to move forward and get feedback on the 
> releases.
>
> Propose sequence:
> 1. Release CLI
> 2. Release Android
> 3. Release Plugins
> 4. Release CLI with latest released platformed pinned
>
> Rinse and repeat while singing choo choo !
>


[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

2015-10-26 Thread daserge
Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-151242639
  
@jeroenv, thanks for your contribution!
Could you please file a [Jira 
bug](https://issues.apache.org/jira/browse/CB) with the issue details and 
environment?
The commits then should be squashed into a single one having CB- prefix.
Please also sign the ICLA so that your code could be pulled in: 
http://www.apache.org/dev/new-committers-guide.html#cla


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Tools Release

2015-10-26 Thread Steven Gill
Sounds good. I'll be going through the process today.

On Mon, Oct 26, 2015 at 8:45 AM, Nikhil Khandelwal 
wrote:

> Looking forward to the release today.
>
> Btw, cordova-app-hello-world also needs to be released at the same time
> and cordova-lib needs to take a dependency on the new version. This will
> resolve the npm@3 bug that I’ve seen being reported by multiple people.
> We should push to get that resolved and should be part of our release blog
> – support for npm@3.
>
> -Nikhil
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Friday, October 23, 2015 2:35 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Tools Release
>
> Okay. I will start work on this release Monday unless anyone has concerns.
>
> -Steve
>
> On Fri, Oct 23, 2015 at 12:57 PM, Nikhil Khandelwal <
> nikhi...@microsoft.com>
> wrote:
>
> > +1 - I'm hoping we'll release iOS as well before the next CLI release.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Carlos Santana [mailto:csantan...@gmail.com]
> > Sent: Friday, October 23, 2015 12:48 PM
> > To: dev@cordova.apache.org
> > Subject: [DISCUSS] Tools Release
> >
> > I think we should release a version of the CLI now, from what Steve
> > told me there is a lot changes going in, and also contains the switch
> > to use npm instead of CPR, and other changes around npm3 and nodejs4
> >
> > This will allow for trains to move forward and get feedback on the
> > releases.
> >
> > Propose sequence:
> > 1. Release CLI
> > 2. Release Android
> > 3. Release Plugins
> > 4. Release CLI with latest released platformed pinned
> >
> > Rinse and repeat while singing choo choo !
> >
>