[GitHub] cordova-lib pull request: CB-10108 Fixes android frameworks instal...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/348


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/95


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[daserge]

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46653820
  
--- Diff: tests/tests.js ---
@@ -31,9 +31,11 @@ exports.defineAutoTests = function () {
 var ONE_SECOND = 1000; // in milliseconds
 var GRACE_TIME_DELTA = 600; // in milliseconds
 var DEFAULT_FILESYSTEM_SIZE = 1024 * 50; // filesystem size in bytes
+var WINDOWS_GRACE_TIME_DELTA = 5 * ONE_SECOND; // Some Windows devices 
need a few seconds to create an upload/download operation.
 var UNKNOWN_HOST = "http://foobar.apache.org";;
 var HEADERS_ECHO = "http://whatheaders.com";; // NOTE: this site is 
very useful!
 var DOWNLOAD_TIMEOUT = 7 * ONE_SECOND;
+var WINDOWS_UNKNOWN_HOST_TIMEOUT = 30 * ONE_SECOND;
--- End diff --

The filetransfer.spec.15 takes 20-30 seconds to finish so 7 seconds is just 
not enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

[snstarosciak]

Github user snstarosciak commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-161878128
  
@ghenry22 Oh man, this is great! I'll try this all out and let you know how 
it goes. I appreciate you nudging me into the right direction for stuff to try 
out and test :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

[ghenry22]

Github user ghenry22 commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-161844312
  
@snstarosciak I'm not going to be much help to you on this one 
unfortunately.  The media plugin is for audio and my app only plays audio not 
video so I haven't messed around with the video stuff so much.

You may need to find something like this:
https://github.com/moust/cordova-plugin-videoplayer

I am not sure how well HTML5 video plays with cordova apps as I haven't 
really used it.

You could try using safari debug tools while running on the emulator or on 
a device to get the JS Console and see if there are any errors being spit out, 
you may be hitting whitelisting errors or CORS or something as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Carlos Santana]

+1 let's move forward this items with WKWebview I don't see holding up the
platform.

Don't see any changes going on the platform, if any they will go into the
pluggable webview plugin or creating new plugin to handle.
On Wed, Dec 2, 2015 at 8:40 PM Shazron  wrote:

> Regarding Platform API, Vladimir Kotikov and Sergey Grebnov agree in
> the PR comments that the changes can go in to cordova-ios-4.x:
> https://github.com/apache/cordova-ios/pull/176
>
> On Wed, Dec 2, 2015 at 5:38 PM, Shazron  wrote:
> > Also, check footnote 3 above.
> >
> > Yes, WebKit defines window.openDatabase but it doesn't do anything.
> > Not sure why their tests didn't catch this... (see footnote for the
> > bug)
> >
> > With CSP off to rule things out:
> > XHR to yourself of course works, but doesn't really make sense for
> > real-world use. XHR to a sibling file, parent file, or any child file
> > results in the error ""Cross origin requests are only supported for
> > HTTP”.
> >
> > To illustrate:
> >
> >   |
> > parent.xml
> >   |
> > www
> >   | index.html (file currently loaded)
> >   | sibling.xml
> >   | child-folder
> >   |   | child.xml
> >
> > index.html is the currently loaded file in the WebView. From it, you
> > can't load parent.xml, sibling.xml nor child.xml using XHR according
> > to my tests.
> >
> > Regarding *why* we have these storage tests, that is out of scope for
> > this discussion, but I agree.
> >
> >
> > On Wed, Dec 2, 2015 at 6:37 AM, Carlos Santana 
> wrote:
> >> I'm guessing "pending" is the same as skipping the test.
> >> I'm guessing WKWebView doesn't support Web SQL, but window.openDatabase
> >> exist but it doesn't do anything?
> >> I ask because I only saw the pending for wkwebview spec.18 for using it,
> >> not for spec.9 where it checks that exists.
> >> Anyway after all questions, why the we are still testing for storage
> APIs?
> >> Cordova doesn't supported code to provide this storage APIs.
> >> I think we should remove the storage tests all together, this is
> >> webview/browser testing space.
> >>
> >> As for local xhr, is the problem only with specifying "../" relative
> path
> >> in the xhr url and not local resources?
> >> I see that doing xhr "index.html" that's a local resource and it works,
> and
> >> also "./" also passes.
> >> Aren't all this relative paths transform into full urls, and they will
> have
> >> file:// in the final path used?
> >> This means that xhr "folder1/data.json" works, but xhr
> >> "../someparent/data.json" doesn't?
> >>
> >>
> >> On Wed, Dec 2, 2015 at 4:52 AM Shazron  wrote:
> >>
> >>> Marked the two known failures as pending. Now everything is green (and
> >>> yellow) across the board for UIWebView and WKWebView.
> >>>
> >>> On Tue, Dec 1, 2015 at 11:49 PM, Jesse 
> wrote:
> >>> >>> Or should I just let it fail still?
> >>> > It depends how long it'll be until we fix them.  The build will be
> broken
> >>> > in the CI until it is fixed so probably marking them as pending is
> the
> >>> > better option.
> >>> >
> >>> >
> >>> > @purplecabbage
> >>> > risingj.com
> >>> >
> >>> > On Tue, Dec 1, 2015 at 10:42 PM, Shazron  wrote:
> >>> >
> >>> >> Couldn't wait. All file-transfer specs now pass for uiwebview and
> >>> >> wkwebview.
> >>> >>
> >>> >> For those two WKWebView tests that are failing, but are expected to
> >>> >> fail -- I'll try to modify the tests to mark the test as pending if
> >>> >> the platform is iOS and the WKWebView bridge is found.
> >>> >>
> >>> >> Or should I just let it fail still?
> >>> >>
> >>> >> On Tue, Dec 1, 2015 at 9:49 PM, Shazron  wrote:
> >>> >> > Thanks! - yeah after I posted it, of course I realized it is all
> open
> >>> >> > source (duh) and I can run a local server or throw it on a
> >>> >> > digitalocean instance or something :)
> >>> >> > I'll do that tomorrow...
> >>> >> >
> >>> >> > On Tue, Dec 1, 2015 at 9:24 PM, Carlos Santana <
> csantan...@gmail.com>
> >>> >> wrote:
> >>> >> >> For a second I read "the bar is clear", but then I went to my
> fridge
> >>> and
> >>> >> >> saw I still have some beer left :-)
> >>> >> >>
> >>> >> >> How long before the INFRA provides the VM for the file transfer,
> I
> >>> >> looked
> >>> >> >> the JIRA and it mentioned something like "complete" and "we are
> in
> >>> >> holding
> >>> >> >> because of capacity" in the same comment, and I was like stupid
> >>> because
> >>> >> I
> >>> >> >> didn't understand :-(
> >>> >> >>
> >>> >> >> If it's going to take a long time, can we do the test with a
> local
> >>> >> machine
> >>> >> >> and vet that it works?
> >>> >> >>
> >>> >> >> For local xhr loading, I left a comment in the JIRA.  I don't
> think
> >>> it's
> >>> >> >> need it but I'm curios on how local xhr loading works when
> fetching
> >>> >> normal
> >>> >> >> files on a web app, meaning dynamically loading js, css, html in
> SPA
> >>> >> using
> >>> >> >> a typical js framework like angular, etc..
> >>> >> >>
> >>> >> >> Platform API is [5], I think is nice to have

Re: [DISCUSS] Deprecate cordova-wp8

[Carlos Santana]

+1
Focusing on Universal and more doc around leveraging native is a good
strategy
On Thu, Dec 3, 2015 at 2:33 AM julio cesar sanchez 
wrote:

> +1, I updated my device as soon as I could and all people I know that had
> WP8 did the same
>
> 2015-12-03 3:38 GMT+01:00 Parashuram N :
>
> > I am in the process of getting number of folks from VS who may be using
> > WP8. These numbers should be able to add more data to this decision.
> >
> >
> >
> >
> > On 12/2/15, 4:05 PM, "Tommy Williams"  wrote:
> >
> > >+1
> > >
> > >
> > >
> > >> On Dec 3 2015, at 10:47 am, Tim Barham  >
> > >wrote:
> > >
> > >>
> > >
> > >> Oh yes please :).
> > >
> > >>
> > >
> > >> \-Original Message-
> > >From: Anis KADRI [mailto:anis.ka...@gmail.com]
> > >Sent: Thursday, December 3, 2015 5:58 AM
> > >To: dev@cordova.apache.org
> > >Subject: Re: [DISCUSS] Deprecate cordova-wp8
> > >
> > >>
> > >
> > >> +1
> > >
> > >>
> > >
> > >> On Wed, Dec 2, 2015 at 11:32 AM Steven Gill &
> lt;stevengil...@gmail.com
> > >
> > >wrote:
> > >
> > >>
> > >
> > >> > +1
> > >>
> > >> On Wed, Dec 2, 2015 at 11:06 AM, Jesse  > >
> > >wrote:
> > >>
> > >> > We've talked about it for awhile, but never moved on it.
> > cordova-wp8
> > >> > has been a work horse that seen us through tough times but the
> > sun
> > >> > is
> > >> setting.
> > >> >
> > >> > cordova-windows has been a viable alternative for some time
> > now, and
> > >> allows
> > >> > developers to target newer device features from wp8.1 and wp10
> > as
> > >well.
> > >> > Removing the responsibility of implementing changes in this
> now
> > >> > ancient code base will free many of us to focus on making the
> > >> > windows universal workflow better.
> > >> >
> > >> > I would like to see this wrapped up by the end of the year,
> > which
> > >> > for me
> > >> is
> > >> > the end of next week.
> > >> >
> > >> > Some suggestions of what needs to happen next :
> > >> > \- display warning message in cli when devs type `cordova
> > platform
> > >> > add
> > >> wp8`
> > >> > ( next cordova-lib/cli release )
> > >> > \- provide a plugin-dev migration guide outlining how to
> > leverage
> > >> > existing C# code in a windows-universal application ( I will
> do
> > this
> > >> > )
> > >> > \- update repos / documentation with polite wording to move on
> > >> > \- close a bunch of wp8 related issues in jira with "won't
> fix'
> > >> > \- put wp8 out to pasture
> > >> >
> > >> > What are your thoughts?
> > >> >
> > >> >
> > >> > Cheers,
> > >> > Jesse
> > >> >
> > >> > @purplecabbage
> > >> >
> > >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=
> > >> > 01%7c01%7cTBARHAM%40064d.mgd.microsoft.com
> > %7ca53ffc23c94641e6e07a08d
> > >> >
> > >2fb52e381%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=2EjA1XtT2K3Oz
> > >> > 3xEt1%2fX9Oq8JkQRl733V4NwkNO7J%2bM%3d
> > >> >
> > >>
> > >
> > >>
> > >
> > >> \-
> > >To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > >For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>

Re: [NOTICE] David Barth has become a committer

[Carlos Santana]

Thanks David, cool to see that an Emulator is available
On Thu, Dec 3, 2015 at 3:05 PM David Barth 
wrote:

> There is an emulator : see https://wiki.ubuntu.com/Touch/Emulator
>  for reference.
>
> The trick for testing on a device is to either have an old Nexus 4 around,
> or get a BQ or Meizu pre-installed.
>
> On Wed, Dec 2, 2015 at 3:40 PM, Carlos Santana 
> wrote:
>
> > There is no Ubuntu simulator/emulator?
> > I think I tried to look for one but didn't find. Then I was looking for a
> > cheap phone for testing and was not able to find one that I could buy
> > locally.
> > Any lottery process to get a Free Ubuntu Phone for dev/testing? :-)
> >
> > On Wed, Dec 2, 2015 at 4:58 AM David Barth 
> > wrote:
> >
> > > Thanks everyone for the kind welcome messages.
> > >
> > > Yeah, Ubuntu is here, either as a host platform for cordova-android or
> > as a
> > > target with cordova-ubuntu (desktop, device or as a converged
> platform).
> > So
> > > let me know if you have questions or issues you'd like me to look at.
> > >
> > > David
> > >
> > > On Wed, Dec 2, 2015 at 5:23 AM, Carlos Santana 
> > > wrote:
> > >
> > > > Great idea Steve to do the announcements here. A lot of benefits I
> > think
> > > > come out of it.
> > > >
> > > > Welcome David !  Ubuntu is back !!
> > > >
> > > >
> > > > On Tue, Dec 1, 2015 at 4:31 PM Ryan J. Salva 
> > > wrote:
> > > >
> > > > > Congratulations and welcome, David!
> > > > >
> > > > >
> > > > >
> > > > > Ryan J. Salva  |  Principal Program Manager Lead
> > > > > Visual Studio Tools for Apache Cordova
> > > > > rsa...@microsoft.com
> > > > > 425 706 5270 office
> > > > > 206 612 5079 mobile
> > > > >
> > > > > Has someone helped you today? Let them (and their manager) know
> with
> > > > Kudos.
> > > > >
> > > > > 
> > > > > From: Jesse 
> > > > > Sent: Tuesday, December 1, 2015 1:04 PM
> > > > > To: dev@cordova.apache.org
> > > > > Subject: Re: [NOTICE] David Barth has become a committer
> > > > >
> > > > > Congrats and welcome David!
> > > > >
> > > > >
> > > > > @purplecabbage
> > > > >
> > > > >
> > > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7crsalva%40microsoft.com%7c7473b4c746db438ffa6508d2fa931136%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=j9utNOtN6Kv84TbpyhCbaSbLX5z7J4KEQw5g41V3TMw%3d
> > > > >
> > > > > On Tue, Dec 1, 2015 at 1:03 PM, Steven Gill <
> stevengil...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Hey everyone!
> > > > > >
> > > > > > Just wanted to start sending out notices to the dev mailing list
> > when
> > > > we
> > > > > > accept a new committer.
> > > > > >
> > > > > > David Barth from Canonical has recently been voted in as a
> > committer!
> > > > He
> > > > > is
> > > > > > primarily working on cordova-ubuntu.
> > > > > >
> > > > > > Congrats!
> > > > > >
> > > > > > Cheers,
> > > > > > -Steve
> > > > > >
> > > > >
> > > > >
> -
> > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > >
> > > > >
> > > >
> > >
> >
>

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

[TimBarham]

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-lib/pull/349#issuecomment-161826181
  
Thanks - LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9964 - Add --template to online docu...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/432#issuecomment-161821043
  
Was this PR stale? Is the change invalid?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Von Miss Esther Desmond.

[Esther Desmond]

Von Miss Esther Desmond.

Mein Lieber,

Ich hoffe, dieser Mail trifft man gut, lassen Sie mich bitte zu mir selbst 
vorstellen, ich bin Fräulein Esther Desmond die Tochter des verstorbenen Herrn 
und Frau Michael Desmond von der Elfenbeinküste. Wer war ein berühmter 
Kakaohändler hier in Abidjan das ökonomische Kapital der Elfenbeinküste (Cote 
d'Ivoire) basiert. Ich suche für Ihre Hilfe, um mich die Summe von $ (7500, 
000.00USD), die ich geerbt von meinem verstorbenen Vater auf Ihr Bankkonto 
überweisen.

Ich bin bereit, die Sie als eine Art der Vergütung nach der Übertragung für 
Ihre Zeit und Mühe bieten 20% des gesamten Fonds. Alle notwendigen Dokumente im 
Zusammenhang mit diesem Fonds sind intakt. Für weitere Informationen über 
diesen Fonds, und ich werde gleich sende Ihnen meine Bilder, so dass Sie sehen 
und wissen, wer ich bin.

Watling für Ihre Mitarbeit.
Vielen Dank und Gott segne
Hochachtungsvoll.
Esther Desmond.

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46627985
  
--- Diff: tests/tests.js ---
@@ -31,9 +31,11 @@ exports.defineAutoTests = function () {
 var ONE_SECOND = 1000; // in milliseconds
 var GRACE_TIME_DELTA = 600; // in milliseconds
 var DEFAULT_FILESYSTEM_SIZE = 1024 * 50; // filesystem size in bytes
+var WINDOWS_GRACE_TIME_DELTA = 5 * ONE_SECOND; // Some Windows devices 
need a few seconds to create an upload/download operation.
 var UNKNOWN_HOST = "http://foobar.apache.org";;
 var HEADERS_ECHO = "http://whatheaders.com";; // NOTE: this site is 
very useful!
 var DOWNLOAD_TIMEOUT = 7 * ONE_SECOND;
+var WINDOWS_UNKNOWN_HOST_TIMEOUT = 30 * ONE_SECOND;
--- End diff --

What's this for?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Cordova-cli doesn't work with node 5

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-cli/pull/228#issuecomment-161818866
  
@unimonkiez Open a JIRA issue if node 5 having issues in your use cases, 
latest cli works with node 4 and 5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Cordova-cli doesn't work with node 5

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/228


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Cb 9964

[dubeejw]

Github user dubeejw closed the pull request at:

https://github.com/apache/cordova-cli/pull/226


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9964 Make --copy-from use --template ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/227


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9964 - Add --template to create comma...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/339


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9964 - Add --template to online docu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/432


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[jasongin]

Github user jasongin commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161817573
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

[jasongin]

Github user jasongin commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161811902
  
I agree the file path handling code probably should be centralized in the 
platform lib for each platform. But it should be done as part of a broader 
effort to make all plugin APIs more consistent in handling files. (My audit 
supporting that is still in progress.)

I'm OK with adding this bit of duplicated code for now to fix this bug, 
knowing it may be refactored later. Also note ideally the contact photo APIs 
should also support cdvfile:// paths, assuming we don't deprecate cdvfile://. 
But again I wouldn't block this fix because of that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/351#issuecomment-161808443
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/351#issuecomment-161805351
  
Thanks @jasongin, found the references. I was using github to perform 
search, I now realize it was a bad idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10093][CB-9960][android] f...

[sencenan]

Github user sencenan commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/143#issuecomment-161787751
  
@riknoll that's my finding too with regard to ExifInterface class. I do 
think copying the image could be a viable solution like @purplecabbage said. 
Not entirely sure about the performance implications though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] cordova-ubuntu 4.3.1

[Steven Gill]

The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
David Barth
Carlos Santana

The vote has passed. I will now publish to dist and npm.


On Thu, Dec 3, 2015 at 10:02 AM, Carlos Santana 
wrote:

> I vote +1
> verify tags
> verify archive
> recreated archive, with some minor differences in node_modules with no
> impact to functionality
>
>
> On Wed, Dec 2, 2015 at 3:26 PM David Barth 
> wrote:
>
> > +1
> >
> > On Wed, Nov 25, 2015 at 2:33 AM, Steven Gill 
> > wrote:
> >
> > > Please review and vote on this 4.3.1 Ubuntu Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-10030
> > >
> > > The archive has been published to
> > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10030
> > >
> > > The package was published from its corresponding git tag:
> > > cordova-ubuntu: 4.3.1 (745697f422)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add
> https://github.com/apache/cordova-ubuntu#4.3.1
> > >
> > > Upon a successful vote I will upload the archive to dist/ and publish
> it
> > > to npm.
> > >
> > > Voting guidelines:
> > >
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > >
> >
>

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/176#issuecomment-161773866
  
FYI there was one issue that wasn't caught, Steve fixed it:
https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=b89cd71

When doing a 'cordova prepare' the version of the platform was printed to 
stdout.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[Steven Gill]

When you do a cordova platform add https://github.com/apache/cordova-ubuntu,
our tools won't run npm install (it will soon though) when it fetches so
those node_modules will be missing. This issue won't exist when installing
from npm.

To solve this, we check node_modules into github.

On Thu, Dec 3, 2015 at 12:10 PM, David Barth 
wrote:

> Shouldn't that be just pinned versions in package.json ?
>
> Can you share the install issues you had. I can compare and adjust quickly
> with a couple LXD containers.
>
> On Thu, Dec 3, 2015 at 7:03 PM, Carlos Santana 
> wrote:
>
> > We should check into git repo node_modules
> > while recreating the archive I saw differences, I think this was due to
> the
> > npm version I used.
> > But adding from git is broken, since git doesn't node_modules (i.e.
> > shelljs, and others)
> > But this should not stop the release since the dist archive contains the
> > node_modules and from npm will have node_modules
> >
> >
> > On Wed, Dec 2, 2015 at 1:55 PM Steven Gill 
> wrote:
> >
> > > Okay sweet. Can you add a +1 on the vote thread that is open for
> Ubuntu.
> > We
> > > need one other committer to give a +1 so I can wrapnit up and publish
> > > On Dec 2, 2015 10:47 AM, "David Barth" 
> > wrote:
> > >
> > > > On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill  >
> > > > wrote:
> > > >
> > > > > Which raw api changes to cordova@5.3.x make it unusable with
> ubuntu?
> > > As
> > > > > far
> > > > > as I know, cordova-ubuntu should work the same with cordova@4.x
> and
> > > > > cordova@5.x. The platform API changes aren't necessary to work
> with
> > > > > cordova@5.x
> > > > >
> > > >
> > > > It worked for most commands, except with options like build --device.
> > > This
> > > > is now fixed in 5.4 thanks to the recent cordova-lib commit.
> > > >
> > > >
> > > > >
> > > > > We probably won't do a update to cordova@4.x unless a security
> > concern
> > > > > comes up.
> > > > >
> > > >
> > > > Ok, makes sense. Anyway, I have a distro-patched version available in
> > an
> > > > Ubuntu PPA (personal archive) at :
> > > > https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for
> people
> > > who
> > > > want a quick start for Ubuntu only.
> > > >
> > > > I imagine it will be resolved by next month, and then I can propose a
> > > > debian package with cordova-cli 5 or 6 as well.
> > > >
> > > >
> > > > > Good idea to improve CB-9590. We are hoping to get cordova@6 out
> > next
> > > > week
> > > > > sometime. If we can get the fixes in by then, great!
> > > > >
> > > >
> > > > Ok
> > > >
> > > >
> > > > >
> > > > > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib
> > (master).
> > > If
> > > > > thinks look good, we should get you and one other person to vote on
> > the
> > > > > vote thread for cordova-ubuntu so I can officially release it on
> npm.
> > > > >
> > > >
> > > > I have finally been able to test with both cordova-cli @4.3.1 and
> > master,
> > > > ie 5.4.1 as published in npm, all from a clean VM running 14.04.2
> LTS,
> > > to:
> > > >
> > > > platform add ubuntu
> > > > build --device
> > > > run --device
> > > >
> > > > It is still not super pretty but there are no regressions and bugs
> are
> > > > fixed.
> > > >
> > > > So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.
> > > >
> > > > David
> > > >
> > >
> >
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[David Barth]

Shouldn't that be just pinned versions in package.json ?

Can you share the install issues you had. I can compare and adjust quickly
with a couple LXD containers.

On Thu, Dec 3, 2015 at 7:03 PM, Carlos Santana  wrote:

> We should check into git repo node_modules
> while recreating the archive I saw differences, I think this was due to the
> npm version I used.
> But adding from git is broken, since git doesn't node_modules (i.e.
> shelljs, and others)
> But this should not stop the release since the dist archive contains the
> node_modules and from npm will have node_modules
>
>
> On Wed, Dec 2, 2015 at 1:55 PM Steven Gill  wrote:
>
> > Okay sweet. Can you add a +1 on the vote thread that is open for Ubuntu.
> We
> > need one other committer to give a +1 so I can wrapnit up and publish
> > On Dec 2, 2015 10:47 AM, "David Barth" 
> wrote:
> >
> > > On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill 
> > > wrote:
> > >
> > > > Which raw api changes to cordova@5.3.x make it unusable with ubuntu?
> > As
> > > > far
> > > > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > > > cordova@5.x. The platform API changes aren't necessary to work with
> > > > cordova@5.x
> > > >
> > >
> > > It worked for most commands, except with options like build --device.
> > This
> > > is now fixed in 5.4 thanks to the recent cordova-lib commit.
> > >
> > >
> > > >
> > > > We probably won't do a update to cordova@4.x unless a security
> concern
> > > > comes up.
> > > >
> > >
> > > Ok, makes sense. Anyway, I have a distro-patched version available in
> an
> > > Ubuntu PPA (personal archive) at :
> > > https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for people
> > who
> > > want a quick start for Ubuntu only.
> > >
> > > I imagine it will be resolved by next month, and then I can propose a
> > > debian package with cordova-cli 5 or 6 as well.
> > >
> > >
> > > > Good idea to improve CB-9590. We are hoping to get cordova@6 out
> next
> > > week
> > > > sometime. If we can get the fixes in by then, great!
> > > >
> > >
> > > Ok
> > >
> > >
> > > >
> > > > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib
> (master).
> > If
> > > > thinks look good, we should get you and one other person to vote on
> the
> > > > vote thread for cordova-ubuntu so I can officially release it on npm.
> > > >
> > >
> > > I have finally been able to test with both cordova-cli @4.3.1 and
> master,
> > > ie 5.4.1 as published in npm, all from a clean VM running 14.04.2 LTS,
> > to:
> > >
> > > platform add ubuntu
> > > build --device
> > > run --device
> > >
> > > It is still not super pretty but there are no regressions and bugs are
> > > fixed.
> > >
> > > So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.
> > >
> > > David
> > >
> >
>

Re: [NOTICE] David Barth has become a committer

[David Barth]

There is an emulator : see https://wiki.ubuntu.com/Touch/Emulator
 for reference.

The trick for testing on a device is to either have an old Nexus 4 around,
or get a BQ or Meizu pre-installed.

On Wed, Dec 2, 2015 at 3:40 PM, Carlos Santana  wrote:

> There is no Ubuntu simulator/emulator?
> I think I tried to look for one but didn't find. Then I was looking for a
> cheap phone for testing and was not able to find one that I could buy
> locally.
> Any lottery process to get a Free Ubuntu Phone for dev/testing? :-)
>
> On Wed, Dec 2, 2015 at 4:58 AM David Barth 
> wrote:
>
> > Thanks everyone for the kind welcome messages.
> >
> > Yeah, Ubuntu is here, either as a host platform for cordova-android or
> as a
> > target with cordova-ubuntu (desktop, device or as a converged platform).
> So
> > let me know if you have questions or issues you'd like me to look at.
> >
> > David
> >
> > On Wed, Dec 2, 2015 at 5:23 AM, Carlos Santana 
> > wrote:
> >
> > > Great idea Steve to do the announcements here. A lot of benefits I
> think
> > > come out of it.
> > >
> > > Welcome David !  Ubuntu is back !!
> > >
> > >
> > > On Tue, Dec 1, 2015 at 4:31 PM Ryan J. Salva 
> > wrote:
> > >
> > > > Congratulations and welcome, David!
> > > >
> > > >
> > > >
> > > > Ryan J. Salva  |  Principal Program Manager Lead
> > > > Visual Studio Tools for Apache Cordova
> > > > rsa...@microsoft.com
> > > > 425 706 5270 office
> > > > 206 612 5079 mobile
> > > >
> > > > Has someone helped you today? Let them (and their manager) know with
> > > Kudos.
> > > >
> > > > 
> > > > From: Jesse 
> > > > Sent: Tuesday, December 1, 2015 1:04 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: [NOTICE] David Barth has become a committer
> > > >
> > > > Congrats and welcome David!
> > > >
> > > >
> > > > @purplecabbage
> > > >
> > > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7crsalva%40microsoft.com%7c7473b4c746db438ffa6508d2fa931136%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=j9utNOtN6Kv84TbpyhCbaSbLX5z7J4KEQw5g41V3TMw%3d
> > > >
> > > > On Tue, Dec 1, 2015 at 1:03 PM, Steven Gill 
> > > > wrote:
> > > >
> > > > > Hey everyone!
> > > > >
> > > > > Just wanted to start sending out notices to the dev mailing list
> when
> > > we
> > > > > accept a new committer.
> > > > >
> > > > > David Barth from Canonical has recently been voted in as a
> committer!
> > > He
> > > > is
> > > > > primarily working on cordova-ubuntu.
> > > > >
> > > > > Congrats!
> > > > >
> > > > > Cheers,
> > > > > -Steve
> > > > >
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> > >
> >
>

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/176


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[iOS] Github mirror is not mirroring

[Shazron]

https://issues.apache.org/jira/servicedesk/agent/INFRA/issue/INFRA-10889

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-161757437
  
Also, the JIRA is here: 
[CB-10128](https://issues.apache.org/jira/browse/CB-10128)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-161756979
  
@vladimir-kotikov can you check this one out? Looks simple enough, but iOS 
is not my forte. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[jasongin]

Github user jasongin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46598813
  
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -1854,6 +1859,39 @@ public boolean remove(String id) {
 return (result > 0) ? true : false;
 }
 
+/**
+ * Gets birthday date from contact JSON object
+ * @param contact an object to get birthday from
+ * @return birthday or null, if the field isn't present or
+ *   is malformed in the contact
+ */
+private Date getBirthday(JSONObject contact) {
+try {
+Long timestamp = contact.getLong("birthday");
+return new Date(timestamp);
+} catch (JSONException e) {
+Log.d(LOG_TAG, "Could not get birthday: " + e.getMessage());
+return null;
+}
+}
+
+/**
+ * Gets birthday from contacts database cursor object
+ * @param c cursor for the contact
+ * @return birthday or null, if birthday column is empty or
+ * the value can't be parsed into valid date object
+ */
+private Date getBirthday(Cursor c) {
+int colBirthday = 
c.getColumnIndex(CommonDataKinds.Event.START_DATE);
+
+try {
+return Date.valueOf(c.getString(colBirthday));
+} catch (IllegalArgumentException e) {
+Log.d(LOG_TAG, "Failed to get birthday for contact: " + 
e.getMessage());
--- End diff --

As explained previously:  Log.e(LOG_TAG, "Failed...   ", e);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[jasongin]

Github user jasongin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46598691
  
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -1854,6 +1859,39 @@ public boolean remove(String id) {
 return (result > 0) ? true : false;
 }
 
+/**
+ * Gets birthday date from contact JSON object
+ * @param contact an object to get birthday from
+ * @return birthday or null, if the field isn't present or
+ *   is malformed in the contact
+ */
+private Date getBirthday(JSONObject contact) {
+try {
+Long timestamp = contact.getLong("birthday");
+return new Date(timestamp);
+} catch (JSONException e) {
+Log.d(LOG_TAG, "Could not get birthday: " + e.getMessage());
--- End diff --

As a general good practice, instead of appending the exception message to 
the error string, pass the exception object to the log method overload that 
takes a throwable as the third parameter. The exception message and stack trace 
will then be printed to logcat.

Also, it would be more appropriate to use Log.e() instead of Log.d() for 
this kind of unexpected error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[riknoll]

Github user riknoll commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#discussion_r46596545
  
--- Diff: src/android/CameraLauncher.java ---
@@ -178,7 +181,7 @@ else if ((this.srcType == PHOTOLIBRARY) || 
(this.srcType == SAVEDPHOTOALBUM)) {
 // preserve the original exif data and filename in the 
modified file that is
 // created
 if(this.mediaType == PICTURE && (this.destType == 
FILE_URI || this.destType == NATIVE_URI)
-&& fileWillBeModified() && 
!cordova.hasPermission(permissions[0])) {
+&& fileWillBeModified() && 
!cordova.hasPermission(permissions[SAVE_TO_ALBUM_SEC])) {
--- End diff --

I don't think we should be using SAVE_TO_ALBUM_SEC and TAKE_PICTURE_SEC for 
the indices in the permissions array since those values mean something 
different. The action after the permissions is not determined by the 
permissions requested (both the camera and the photolibrary sources require 
READ permission, for example). Could you define some different constants at the 
top of the file; maybe CAMERA_PERMISSION_INDEX and READ_PERMISSION_INDEX?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161748614
  
@ochakov I'll do some testing, but this looks pretty good! In the meantime, 
can you fill out an Apache ICLA? There are instructions for doing so 
[here](http://cordova.apache.org/contribute/contribute_guidelines.html). That 
needs to be submitted/filed before I can merge this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[omefire]

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161746483
  
The mention of BackgroundUploader/Downloaded in the Windows quirks section 
confused me a bit.
At first, I thought they were some options we could use to configure the 
upload/download operations.
Could we maybe mention that it is an implementation detail in Windows land 
? And make it a bit clearer what the alternatives are ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-9891: Fix permission errors d...

[zanemcca]

Github user zanemcca commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-161746193
  
@stevengill Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-9891: Fix permission errors d...

[stevengill]

Github user stevengill commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-161745773
  
@zanemcca it is on npm, just not set to latest until we release cordova 
6.0.0

cordova plugin add cordova-plugin-file@4.0.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161745285
  
@vladimir-kotikov makes sense to me! Thanks for the clarification!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10093][CB-9960][android] f...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/143#issuecomment-16175
  
@purplecabbage @sencenan I agree that getting the file path out of a 
content URI is becoming too convoluted to be sustainable. Getting the 
InputStream from the ContentResolver comes with it's own awkwardness as well, 
however, due to Android's [ExifInterface 
class](http://developer.android.com/reference/android/media/ExifInterface.html).
 We use that class to extract the EXIF data and preserve it as we modify the 
image (for quality, orientation, etc.). Unfortunately, it does not take in an 
InputSteam and so we would have to find/code a new EXIF reader or do something 
weird with writing the image twice (copy image to temp location -> read EXIF 
from temp image -> overwrite temp image with modified image -> return temp 
image URI). Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

[nleclerc]

GitHub user nleclerc opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/144

[iOS] Fixed authorization error when user clicks cancel in image selector 
view.

I'm resurrecting a change from [an old pull 
request](https://github.com/apache/cordova-plugin-camera/pull/24) that was 
closed without any explanation.

[The original issue](https://issues.apache.org/jira/browse/CB-6576) has 
been improperly marked as resolved when it clearly is not.

Problem is there's currently no way to know when a user has just cancelled 
the image capture since clicking cancel send a `has no access to assets` error 
when it really isn't an authorization issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nleclerc/cordova-plugin-camera ios-cancel-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #144


commit c34a6fdc18aaf12aab6c0c43e03bc9c63267b895
Author: Nicolas Leclerc 
Date:   2015-12-03T18:19:27Z

iOS: Fixed plugin sending authorization error when user clicks cancel in 
image selector view.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10093][CB-9960][android] f...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/143#issuecomment-161732640
  
Copy the image to an app accessible temp location and return that url. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161733972
  
@dblotsky, @jasongin, I've addressed the CR notes and also added a few 
fixes for the last commit changed the timeouts - please take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[Carlos Santana]

We should check into git repo node_modules
while recreating the archive I saw differences, I think this was due to the
npm version I used.
But adding from git is broken, since git doesn't node_modules (i.e.
shelljs, and others)
But this should not stop the release since the dist archive contains the
node_modules and from npm will have node_modules


On Wed, Dec 2, 2015 at 1:55 PM Steven Gill  wrote:

> Okay sweet. Can you add a +1 on the vote thread that is open for Ubuntu. We
> need one other committer to give a +1 so I can wrapnit up and publish
> On Dec 2, 2015 10:47 AM, "David Barth"  wrote:
>
> > On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill 
> > wrote:
> >
> > > Which raw api changes to cordova@5.3.x make it unusable with ubuntu?
> As
> > > far
> > > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > > cordova@5.x. The platform API changes aren't necessary to work with
> > > cordova@5.x
> > >
> >
> > It worked for most commands, except with options like build --device.
> This
> > is now fixed in 5.4 thanks to the recent cordova-lib commit.
> >
> >
> > >
> > > We probably won't do a update to cordova@4.x unless a security concern
> > > comes up.
> > >
> >
> > Ok, makes sense. Anyway, I have a distro-patched version available in an
> > Ubuntu PPA (personal archive) at :
> > https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for people
> who
> > want a quick start for Ubuntu only.
> >
> > I imagine it will be resolved by next month, and then I can propose a
> > debian package with cordova-cli 5 or 6 as well.
> >
> >
> > > Good idea to improve CB-9590. We are hoping to get cordova@6 out next
> > week
> > > sometime. If we can get the fixes in by then, great!
> > >
> >
> > Ok
> >
> >
> > >
> > > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master).
> If
> > > thinks look good, we should get you and one other person to vote on the
> > > vote thread for cordova-ubuntu so I can officially release it on npm.
> > >
> >
> > I have finally been able to test with both cordova-cli @4.3.1 and master,
> > ie 5.4.1 as published in npm, all from a clean VM running 14.04.2 LTS,
> to:
> >
> > platform add ubuntu
> > build --device
> > run --device
> >
> > It is still not super pretty but there are no regressions and bugs are
> > fixed.
> >
> > So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.
> >
> > David
> >
>

Re: [VOTE] cordova-ubuntu 4.3.1

[Carlos Santana]

I vote +1
verify tags
verify archive
recreated archive, with some minor differences in node_modules with no
impact to functionality


On Wed, Dec 2, 2015 at 3:26 PM David Barth 
wrote:

> +1
>
> On Wed, Nov 25, 2015 at 2:33 AM, Steven Gill 
> wrote:
>
> > Please review and vote on this 4.3.1 Ubuntu Release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-10030
> >
> > The archive has been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10030
> >
> > The package was published from its corresponding git tag:
> > cordova-ubuntu: 4.3.1 (745697f422)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-ubuntu#4.3.1
> >
> > Upon a successful vote I will upload the archive to dist/ and publish it
> > to npm.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> >
>

[GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...

[jasongin]

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-lib/pull/351#issuecomment-161730103
  
@omefire It is called during the prepare phase when building android. See 
more info including stack trace in the CB-10125 JIRA issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

[snstarosciak]

Github user snstarosciak commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-161729984
  
@ghenry22 Hellooo sir. I know this isn't really the appropriate place to 
ask this question, but it was the only way I knew I could contact you and have 
the question still be relevant. The media plugin stuff works great with iOS 9 
:) 

My problem that I can't seem to solve, no matter how hard I try is 
basically trying to play a mp4 file in an HTML 5 video player like so:

`

  `

resourceURL looks like 
"cdvfile://localhost/library-nosync/resources/resource-0/resource-0.mp4"

when I try playing the same exact video that I'm hosting from an external 
server, the video plays no problem in iOS 9.

Is there some kind of weird file system filepath issue I'm not thinking of? 
Do HTML 5 audio/video tags not like "ng-src"? Even when I try to do a direct 
src to the file in my emulator, it doesn't play. Since the html 5 video player 
only seems to work at all when running ionic emulate ios, instead of ionic 
emulate ios -lcs, I can't see any logs if it's spitting out an error, because 
it definitely isn't when I run it with -lcs.

Here is the code for trying to src it directly to the file that exists on 
the emulator (or at least when I run the emulator in -lcs mode)

`

  `

Are there any alternatives or things I can try? I'd love to answer my 
question in both the ionic and stackoverflow forums for other people who may 
have the same issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] CLI Templates

[Carlos Santana]

I will be working later today with James from my team on merging initial
implementation of --template. it will update a few repos (cli, lib, doc)

Anyone oppose?


On Fri, Nov 13, 2015 at 1:50 PM Carlos Santana  wrote:

> alias, deprecate and later remove
>
> On Fri, Nov 13, 2015 at 1:49 PM Carlos Santana 
> wrote:
>
>> I agree, --template is the new --copy-from :-)
>>
>>
>> On Fri, Nov 13, 2015 at 1:48 PM Shazron  wrote:
>>
>>> Well, we could deprecate --copy-from, and alias --template to it. But
>>> we shouldn't have both, it should just be one implementation.
>>>
>>> On Fri, Nov 13, 2015 at 10:45 AM, Carlos Santana 
>>> wrote:
>>> > In some way we we are enhancing --copy-from
>>> >
>>> > I'm OK to the copy blindly even plugins and platforms, I was trying to
>>> > avoid people creating templates when is not need it if they already
>>> have
>>> > platforms and plugins
>>> > But I'm OK if we want to allow it, but I would not documented :-) it
>>> just
>>> > happens to work
>>> >
>>> >  but I don't like the "--copy-from" name, I want to use "--template"
>>> that
>>> > takes path, giturl, and npm name
>>> >
>>> >
>>> > On Fri, Nov 13, 2015 at 1:41 PM Carlos Santana 
>>> wrote:
>>> >
>>> >> What dynamic nature you want ?
>>> >>
>>> >> I think using yeoman is bad idea, we tried at work at is a huge
>>> dependency
>>> >> in terms of foot print and number of dependencies.
>>> >> We then learned that just using the inquirer npm package gave us what
>>> we
>>> >> wanted to create an interactive experience in the CLI
>>> >>
>>> >> At least the first implementation I want to keep it simple, but you
>>> >> brought a good point about dynamic.
>>> >>
>>> >> I will update proposal, add that if user passed any of the optional
>>> >> arguments for create like app-id, app-name, or app-version they
>>> replace the
>>> >> ones in the template.
>>> >>
>>> >> I will double check with James to see if already implemented this in
>>> his
>>> >> current PR, if not then will added.
>>> >>
>>> >> It terms of dynamic I think after we get the first implementation
>>> out, I
>>> >> would like to enhance on top of it with allowing the template to have
>>> >> scripts that can run
>>> >> like before_create and after_create, then the template can specify
>>> this in
>>> >> the scripts object of the package.json and cordova cli just runs.
>>> This way
>>> >> template owner can run what ever they want even inquirer to ask
>>> questions
>>> >> to user for additional things to setup with the template.
>>> >>
>>> >>
>>> >> [1]: https://www.npmjs.com/package/inquirer
>>> >>
>>> >>
>>> >>
>>> >>
>>> >>
>>> >> On Thu, Nov 12, 2015 at 1:56 PM Parashuram N 
>>> >> wrote:
>>> >>
>>> >>> ReactNative init does use yeoman - that is a good idea !! However,
>>> does
>>> >>> that mean that we need to depend on Yeoman also ? Does it make sense
>>> to
>>> >>> simply have a separate yeoman generator ?
>>> >>>
>>> >>>
>>> >>>
>>> >>>
>>> >>> On 11/12/15, 10:10 AM, "Gorkem Ercan" 
>>> wrote:
>>> >>>
>>> >>> >
>>> >>> >How about adding support for some more dynamic generation.
>>> >>> >Can we add yeoman as an option something like $cordova create myApp
>>> >>> >--template=yo:m
>>> >>> >to invoke the generator m ?
>>> >>> >--
>>> >>> >Gorkem
>>> >>> >
>>> >>> >On 10 Nov 2015, at 19:52, Carlos Santana wrote:
>>> >>> >
>>> >>> >> Parashuram
>>> >>> >>
>>> >>> >> I would say that if they have "platforms" and "plugins" it's not
>>> >>> >> consider a
>>> >>> >> template, its consider a cordova project ready to be use no need
>>> to
>>> >>> >> run
>>> >>> >> create on it.
>>> >>> >>
>>> >>> >> As far as cp-from, it's doesn't copy much only www and
>>> config.xml, I
>>> >>> >> didn't
>>> >>> >> want to change it's behavior for backwards compatibility. I think
>>> it
>>> >>> >> will
>>> >>> >> be good to mark it deprecated for a certain period of time,
>>> >>> >>
>>> >>> >
>>> >>> >+1 for deprecating the copy-from.
>>> >>> >
>>> >>> >>
>>> >>> >> On Tue, Nov 10, 2015 at 5:19 PM Parashuram N <
>>> panar...@microsoft.com>
>>> >>> >> wrote:
>>> >>> >>
>>> >>> >>> Yes, they would. However, there could be cases where folks would
>>> like
>>> >>> >>> to
>>> >>> >>> have templates that have changes stuff in platforms, or added
>>> custom
>>> >>> >>> plugins or hooks. I think that instead of adding extra code to
>>> >>> >>> prevent all
>>> >>> >>> these things, we keep things simple, and copy over everything.
>>> The
>>> >>> >>> templates can then decide what they want to do, and most of them
>>> will
>>> >>> >>> not
>>> >>> >>> bundle plugins or platforms.
>>> >>> >>>
>>> >>> >>> -Original Message-
>>> >>> >>> From: Steven Gill [mailto:stevengil...@gmail.com]
>>> >>> >>> Sent: Tuesday, November 10, 2015 2:16 PM
>>> >>> >>> To: dev@cordova.apache.org
>>> >>> >>> Subject: Re: [DISCUSS] CLI Templates
>>> >>> >>>
>>> >>> >>> If the plugins and platforms are listed in config.xml, wouldn't
>>> they
>>> >>> >>> just
>>> >>> >>> get fetched on prepare?
>>> >>> >>>
>>> >>> >>> O

[GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/351#issuecomment-161728837
  
Where is this method called from ? cordova-android ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161725537
  
@vladimir-kotikov That sounds good to me! I agree we should be handling 
`file://android_asset` URIs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[daserge]

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46582720
  
--- Diff: README.md ---
@@ -230,6 +230,10 @@ __Parameters__:
 
 - Download requests is being cached by native implementation. To avoid 
caching, pass `if-Modified-Since` header to download method.
 
+### Windows Quirks
+
+- Usage of 
[BackgroundDownloader](https://msdn.microsoft.com/en-us/library/windows/apps/windows.networking.backgroundtransfer.backgrounddownloader.aspx)
 entails the latency issues on Windows Phone. You can use XHR or 
[HttpClient](https://msdn.microsoft.com/en-us/library/windows/apps/windows.web.http.httpclient.aspx)
 as a quicker alternative for small downloads.
--- End diff --

Moved quirk out from `download` method section as it affects uploads as 
well; added some details on the latency issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[daserge]

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46581788
  
--- Diff: src/windows/FileTransferProxy.js ---
@@ -49,6 +49,17 @@ function nativePathToCordova(path) {
 return String(path).replace(/\\/g, '/');
 }
 
+function alreadyCancelled(opId, errorCb, filePath, server) {
+var op = fileTransferOps[opId];
+if (op && op.state === FileTransferOperation.CANCELLED) {
+// Here we should call errorCB with ABORT_ERR error
+errorCb(new FTErr(FTErr.ABORT_ERR, nativePathToCordova(filePath), 
server));
--- End diff --

Addressed, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...

[nleclerc]

Github user nleclerc commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-161702527
  
Hi, sorry to resurrect an old thread but i'm having trouble with this 
modification.
When users click cancel in camera interface, we get a `has no access to 
assets` error instead of `no image selected`.

@m-revetria do you have more information about your use case ?
I fail to see how this test is pertinent here.
If user cancels action then it's just a cancellation, not a auth error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

[david-barth-canonical]

Github user david-barth-canonical commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/349#discussion_r46569876
  
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,54 @@ function toCamelCase(str) {
 }).join('');
 }
 
+function getPluginXml(plugin_dir) {
+var et = require('elementtree'),
+fs = require('fs'),
+path = require('path');
+
+var pluginxml;
+var config_path = path.join(plugin_dir, 'plugin.xml');
+
+if (fs.existsSync(config_path)) {
+// Get the current plugin.xml file
+pluginxml = et.parse(fs.readFileSync(config_path, 'utf-8'));
+}
+ 
+return pluginxml;
+}
+
+function findClassName(pluginxml, plugin_id) {
+var class_name;
+
+// first check if we have a class-name parameter in the plugin config
+if (pluginxml) {
+   var platform = pluginxml.find("./platform/[@name='ubuntu']/");
+   if (platform) {
+   var param = 
platform.find("./config-file/[@target='config.xml']/feature/param/[@name='ubuntu-package']");
+   if (param && param.attrib) {
+   class_name = param.attrib.value;
+   return class_name;
+   }
+   }
+}
+
+// fallback to guess work, based on the plugin package name
+
+if (plugin_id.match(/\.[^.]+$/)) {
+// old-style plugin name
+class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
+class_name = toCamelCase(class_name);
+} else {
+   match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
+if (match && match.length > 0)
+   class_name = match[0].substr(15);
+   else
+class_name = toCamelCase(class_name);
+}
+
+return class_name;
+}
--- End diff --

There is a new PR at https://github.com/apache/cordova-lib/pull/349 with
your suggested fixes. Thanks for the review.

On Thu, Dec 3, 2015 at 12:45 AM, Tim Barham 
wrote:

> In cordova-lib/src/plugman/platforms/ubuntu.js
> :
>
> > +// fallback to guess work, based on the plugin package name
> > +
> > +if (plugin_id.match(/\.[^.]+$/)) {
> > +// old-style plugin name
> > +class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
> > +class_name = toCamelCase(class_name);
> > +} else {
> > +   match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
> > +if (match && match.length > 0)
> > +   class_name = match[0].substr(15);
> > +   else
> > +class_name = toCamelCase(class_name);
> > +}
> > +
> > +return class_name;
> > +}
>
> Thanks @david-barth-canonical !
> Some comments:
>
>- Generally the Cordova codebase uses curly braces even around single
>line blocks.
>- There are some tabs in there that should be converted to spaces.
>- The match variable needs a var.
>- Should be calling toCamelCase() for the scenario where we match
>cordova-plugin-...
>- Where we don't match cordova-plugin-..., class_name is not defined
>(should be using plugin_id).
>- Since we will always end up calling toCamelCase(), the logic for the
>second half of this method can be simplified to:
>
> // fallback to guess work, based on the plugin package name
> if (plugin_id.match(/\.[^.]+$/)) {
> // old-style plugin name
> class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
> } else {
> var match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
> if (match && match.length > 0) {
> class_name = match[0].substr(15);
> } else {
> class_name = plugin_id;
> }
> }
>
> return toCamelCase(class_name);
>
> Also, since the original PR has been merged, can you recreate this as a
> new PR which will just include the changes in your last commit (and 
changes
> in response to feedback, of course).
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-ma

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

[nicoabie]

Github user nicoabie commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161656697
  
Thanks @Sinistralis 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161633720
  
@MarsupiL, app crash due to missing permissions, while accessing linked 
contacts already has been fixed in 
https://github.com/apache/cordova-plugin-contacts/commit/617fb764bf1c7047cfe02cf346771dd7fa38ed40.
 The problem, this PR covers is a bit different.

@stevengill, @shazron, could you please take a look?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10112 Parse additional CLI argume...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/241


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161597318
  
@riknoll, other platforms (iOS, Windows) don't try to resolve relative 
paths. Instead they expect image path/URI to be absolute. Probably we should 
follow the same rule here. However, we still need to threat 
`file:///android_asset` URIs differently, so the condition `if 
(path.startsWith(ASSET_URL_PREFIX)) ... ` is still actual. Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161549915
  
@dblotsky, this replaces #77 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161548065
  
@dblotsky, as @purplecabbage mentioned, there is no way to cover this by 
autotests, because from JS perspective everything works well - we convert a 
date to timestamp and send it to native, then we get _exactly the same_ 
timestamp from native (because there was no conversion made on native side).

BTW, this might be a perfect case to cover with UI autotest, @alsorokin 
working on.

@riknoll, The issue is in format which the date should be stored in 
contacts database. The android docs doesn't specify this format (except from 
the fact that [it should be a 
'TEXT'](http://developer.android.com/reference/android/provider/ContactsContract.CommonDataKinds.Event.html#START_DATE)),
 but the birthday in contact card is _displayed correctly_ only if specified as 
`dd-mm-` (from my experience).

There is no inconsistence in Contact objects structure on JS side - the 
`birthday` field is always a valid `Date` object or `null`, despite of current 
platform.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org