[GitHub] cordova-plugin-device pull request: chore: edit package.json licen...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/48#issuecomment-180569344
  
Sure, if you can!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10395 InAppBrowser's ...

[wolframkriesing]

Github user wolframkriesing commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-180591346
  
I think importing the `CookieSyncManager ` is missing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

[tony--]

Github user tony-- commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180593938
  
+1 this fixed the tests for me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52080185
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -115,41 +247,38 @@ As a plugin developer you can define hook scripts 
using `` elements in a `
 
 
 
-
-
-
+
+
+
 ...
 
 
-`before_plugin_install`, `after_plugin_install`, `before_plugin_uninstall` 
plugin hooks will be fired exclusively for the plugin being 
installed/uninstalled.
+`before_plugin_install`, `after_plugin_install`, `before_plugin_uninstall` 
plugin hooks will be fired 
+exclusively for the plugin being installed/uninstalled.
 
-## Script Interface
+### Order of Hooks execution
+
+Hook scripts could be defined by adding them to the special predefined 
folder 
--- End diff --

Hook scripts *can*...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/471#issuecomment-180608678
  
Okay, I just forced pushed some major changes to this PR:

* Addressed most of the code review
* Deleted old pages and combined other pages into single page guide
* Lots of miscellaneous content fixes and reorganization to fit the single 
page platform guide structure
* Rebased to master

Plugin guide is still separate, since that is going to move. Lifecycle is 
also separate, because I need to figure out what to do about that since I've 
been handing out links to that page all over the place because of the 
save-restore API changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10539: Commenting out the v...

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/163

CB-10539: Commenting out the verySmallQvga maxResolution option



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera 
raghav/CB-10539

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #163


commit 654286d373878cef3fd28cbeeffb30ee3ee68962
Author: Raghav Katyal 
Date:   2016-02-05T23:03:19Z

CB-10539: Commenting out the verySmallQvga maxResolution option




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52085523
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -20,63 +20,193 @@ license: >
 title: Hooks Guide
 ---
 
-# Hooks Guide
+# Hooks
+
+## Introduction
 
 Cordova Hooks represent special scripts which could be added by 
application and
 plugin developers or even by your own build system  to customize cordova 
commands.
-Hook scripts could be defined by adding them to the special predefined 
folder 
-(`/hooks`) or via configuration files (`config.xml` and `plugin.xml`) and 
run
-serially in the following order:
-
-* Application hooks from `/hooks`;
-* Application hooks from `config.xml`;
-* Plugin hooks from `plugins/.../plugin.xml`.
 
-__Note__: `/hooks` directory is considered deprecated in favor of the hook 
elements
-in config.xml and plugin.xml.
-
-## Supported hook types
-The following hook types are supported:
-
-after_build
-after_compile
-after_clean
-after_docs
-after_emulate
-after_platform_add
-after_platform_rm
-after_platform_ls
-after_plugin_add
-after_plugin_ls
-after_plugin_rm
-after_plugin_search
-after_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-after_prepare
-after_run
-after_serve
-before_build
-before_clean
-before_compile
-before_docs
-before_emulate
-before_platform_add
-before_platform_rm/
-before_platform_ls
-before_plugin_add
-before_plugin_ls
-before_plugin_rm
-before_plugin_search/
-before_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-before_plugin_uninstall // Plugin hooks in plugin.xml are executed for 
a plugin being uninstalled only
-before_prepare
-before_run
-before_serve
-pre_package // Windows and Windows Phone only
+Cordova hooks allow you to perform special activities around cordova 
commands. For example, 
+you may have a custom tool that checks for code formatting in your 
javascript file. And, you 
+would like to run this tool before every build. In such a case, you could 
use a 
+'before_build' hook and instruct the cordova run time to run the custom 
tool to be invoked 
+before every build. 
+
+There are 2 types of hooks:
+
+- Application hooks
+- Plugins hooks
+
+### Application hooks
+
+These hooks are related to the application. For example, hooks such as 
`before_build`, 
+`after_build`, etc applies to your application. 
+
+### Plugin hooks
+
+These hooks are related to the plugins of your application. For example, 
hooks such as 
+`before_plugin_add`, `after_plugin_add`, etc applies to plugin related 
activities. These
+hooks can be associated with all plugins within your application or be 
specific to only 
+one plugin. 
+
+Cordova supports the following hook types:
+
+
+
+
+
+
+Hook Type
+Associated Cordova Command
+Description
+
+
+
+
+Application hooks
+
+
+before_platform_add
+cordova platform 
add
+To 
be executed before and after adding a platform.
+
+
+after_platform_add
+
+
+before_platform_rm
+cordova platform 
rm
+To 
be executed before and after removing a platform.
+
+
+after_platform_rm
+
+
+before_platform_ls
+cordova platform 
ls
+To 
be executed before and after listing the installed and available platforms.
+
+
+after_platform_ls
+
+
+before_prepare
+cordova 
prepare
+To be executed before 
and after preparing your application.
+
+
+after_prepare
+
+
+before_compile
+cordova 
compile
+To be executed before 
and after compiling your application.
+
+
+after_compile
+
+
+before_build
+cordova build
+To be executed before 
and after building your application.
+
+
+after_build
+
+
+

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-lib/pull/378#issuecomment-180407487
  
@vladimir-kotikov, added the tests for non-default plugman engines, PTAL


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/63#issuecomment-180444839
  
@Fuchur84, please file an issue on [our issue 
tracker](https://issues.apache.org/jira/browse/CB) so it could be seen by other 
devs, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] 4.3.3 Ubuntu Release

[David Barth]

Any feedback on the release? I need your votes ! :)

On Thu, Jan 28, 2016 at 5:25 PM, David Barth 
wrote:

> Please review and vote on this 4.3.3 Ubuntu Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10453
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-10453/
>
> The package was published from its corresponding git tag:
> cordova-ubuntu: 4.3.3 (81381a5f11)
>
> Note that you can test it out via:
>
> cordova platform add
> https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.3
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines: https://github.com/apache/cordova
> -coho/blob/master/docs/release-voting.md
> 
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran the procedure at
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md
> * Ran mobile-spec
> * Created and ran hello world project on device
>
> Most of all, I verified that the test applications continue to run with
> the upcoming Oxide-1.12 release which ceased to work with a deprecated load
> signal cordova-ubuntu had been using so far.
>
> See https://issues.apache.org/jira/browse/CB-10470
>
>
>

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-lib/pull/378#issuecomment-180425340
  
@nikhilkh, @stevengill could you please take a look and confirm if 
[this](https://github.com/apache/cordova-lib/pull/378/files#diff-5c531bb2bcb2db936999aa744a3f2a3cR256)
 is the correct logic for a custom engine tag (this might occur as we are 
removing `cordova-windows8` from the default engines)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Core Plugins and Android API 23

[julio cesar sanchez]

Yeah, that one.


El viernes, 5 de febrero de 2016, Homer, Tony 
escribió:

> It took me a while to find it, but I guess you mean CB-10455?
>
>
>
> On 2/5/16, 7:56 AM, "julio cesar sanchez"  > wrote:
>
> >I think we just forgot, somebody mentioned this on slack and there is an
> >issue open on JIRA.
> >
> >2016-02-05 13:52 GMT+01:00 Homer, Tony  >:
> >
> >> Earlier in this thread, Richard stated:
> >> >> This change has been merged into the file, camera, geolocation, and
> >> contacts plugins (media did not actually require any change).
> >>
> >>
> >> Media was updated on 1/15 but it still has a "cordova-android
> >=5.0.0-dev"
> >> engine tag.
> >> I couldn't find any other discussion about this on the list and wondered
> >> why it was retained for media.
> >> Was this an oversight?
> >>
> >>
> >> Thanks!
> >> Tony
> >>
> >>
> >>
> >>
> >> On 1/15/16, 4:40 PM, "Simon MacDonald"  > wrote:
> >>
> >> >LGTM
> >> >
> >> >+1
> >> >
> >> >Simon Mac Donald
> >> >http://hi.im/simonmacdonald
> >> >
> >> >On Fri, Jan 15, 2016 at 4:32 PM, Joe Bowser  > wrote:
> >> >
> >> >> Sorry, wrong PR:
> >> >> https://github.com/apache/cordova-plugin-inappbrowser/pull/136
> >> >>
> >> >> On Fri, Jan 15, 2016 at 11:42 AM, Joe Bowser  > wrote:
> >> >>
> >> >> > So, what does the timeline look like for a Plugins release.  I just
> >> did a
> >> >> > major change in the InAppBrowser to fix tel: and sms: URIs so they
> do
> >> >> > stuff, and it'd be cool if this also made if this got looked over
> and
> >> >> > landed before the next release.
> >> >> >
> >> >> > https://github.com/apache/cordova-plugin-inappbrowser/pull/135
> >> >> >
> >> >> > On Thu, Jan 14, 2016 at 2:02 PM, Carlos Santana <
> csantan...@gmail.com 
> >> >
> >> >> > wrote:
> >> >> >
> >> >> >> I agree with final compromise, I also had a discussion with Nikhil
> >> >> during
> >> >> >> holiday break offline and understood the situation, some 3rd party
> >> >> plugins
> >> >> >> are not open source and customers/devs don't move as fast as we
> wish,
> >> >> but
> >> >> >> having a CLI 6 with latest plugins being backwards compatible with
> >> lower
> >> >> >> Android API is good base for developers to start upgrading.
> >> >> >>
> >> >> >>
> >> >> >> On Thu, Jan 14, 2016 at 1:23 PM Steven Gill <
> stevengil...@gmail.com >
> >> >> >> wrote:
> >> >> >>
> >> >> >> > Awesome! I'll kick up a discuss thread
> >> >> >> >
> >> >> >> > On Wed, Jan 13, 2016 at 5:42 PM, Richard Knoll <
> >> rikn...@microsoft.com 
> >> >> >
> >> >> >> > wrote:
> >> >> >> >
> >> >> >> > > Hey all,
> >> >> >> > >
> >> >> >> > > This change has been merged into the file, camera,
> geolocation,
> >> and
> >> >> >> > > contacts plugins (media did not actually require any change).
> I
> >> was
> >> >> >> able
> >> >> >> > to
> >> >> >> > > build and run mobilespec on cordova-android 4.0.0 and
> >> >> >> cordova-android's
> >> >> >> > > master. We should probably push for a plugins release soon,
> since
> >> >> >> there
> >> >> >> > are
> >> >> >> > > also some major bug fixes to the contacts and camera plugins
> that
> >> >> were
> >> >> >> > > recently pushed.
> >> >> >> > >
> >> >> >> > > Thanks,
> >> >> >> > > Richard
> >> >> >> > >
> >> >> >> > > -Original Message-
> >> >> >> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com
> ]
> >> >> >> > > Sent: Friday, January 8, 2016 12:12 PM
> >> >> >> > > To: dev@cordova.apache.org 
> >> >> >> > > Subject: RE: [DISCUSS] Core Plugins and Android API 23
> >> >> >> > >
> >> >> >> > > We had a good discussion about this offline with Joe, Simon,
> >> Steve,
> >> >> >> > Jesse,
> >> >> >> > > Parashu and Jason. We came to the following agreement:
> >> >> >> > > This is a temporary fix to the plugins which we need to take
> to
> >> >> ensure
> >> >> >> > > Cordova 5.x tools behavior of using the edge plugins does not
> >> break
> >> >> >> for
> >> >> >> > our
> >> >> >> > > users. We will pursue the change for all the affected plugins.
> >> This
> >> >> >> will
> >> >> >> > go
> >> >> >> > > out in the next PLUGINS release which will happen before the
> >> Cordova
> >> >> >> 6.0
> >> >> >> > > release. Since this a temporary fix, we aim to remove it in 6
> >> months
> >> >> >> > > (giving reasonable time for our user base to move to Cordova
> 6.x+
> >> >> >> which
> >> >> >> > > will have a better plugin version pinning mechanism).
> >> >> >> > >
> >> >> >> > > Thanks,
> >> >> >> > > Nikhil
> >> >> >> > >
> >> >> >> > > -Original Message-
> >> >> >> > > From: Simon MacDonald [mailto:simon.macdon...@gmail.com
> ]
> >> >> >> > > Sent: Thursday, January 7, 2016 4:00 PM
> >> >> >> > > To: dev@cordova.apache.org 
> >> >> >> > > Subject: Re: 

Re: [Vote] 4.3.3 Ubuntu Release

[Steven Gill]

+1

ran coho verify archive
added fine to a project. Can't build due to lack of environment.

On Fri, Feb 5, 2016 at 8:15 AM, David Barth 
wrote:

> Any feedback on the release? I need your votes ! :)
>
> On Thu, Jan 28, 2016 at 5:25 PM, David Barth 
> wrote:
>
> > Please review and vote on this 4.3.3 Ubuntu Release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-10453
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-10453/
> >
> > The package was published from its corresponding git tag:
> > cordova-ubuntu: 4.3.3 (81381a5f11)
> >
> > Note that you can test it out via:
> >
> > cordova platform add
> > https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.3
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines: https://github.com/apache/cordova
> > -coho/blob/master/docs/release-voting.md
> > <
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md>
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran the procedure at
> >
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md
> > * Ran mobile-spec
> > * Created and ran hello world project on device
> >
> > Most of all, I verified that the test applications continue to run with
> > the upcoming Oxide-1.12 release which ceased to work with a deprecated
> load
> > signal cordova-ubuntu had been using so far.
> >
> > See https://issues.apache.org/jira/browse/CB-10470
> >
> >
> >
>

[GitHub] cordova-docs pull request: CB-10549: Fixing 6.0.0 manual TOC links

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/488#issuecomment-180501457
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10549: Fixing 6.0.0 manual TOC links

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/488#issuecomment-180501130
  
@dblotsky please review and push ASAP


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10549: Fixing 6.0.0 manual TOC links

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/488

CB-10549: Fixing 6.0.0 manual TOC links

I did not verify every language (used regex find and replace)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-10549

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/488.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #488


commit 7356162044a3c0456e68733f891aa344ba8debbc
Author: riknoll 
Date:   2016-02-05T18:57:18Z

CB-10549: Fixing 6.0.0 manual TOC links




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

[drbeermann]

Github user drbeermann commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180462324
  
+1 Fixes a few issues for me as well. Still having problems with multiple 
audio files playing on marshmallow however.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180486950
  
This LGTM. Seems like our tests have been failing for a while with 
cordova-plugin-media, and this was the cause


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180492977
  
I have tested this by running cordova-mobile-spec on a 6.0.1 device, 5.1.1 
emulator, and 4.44 emulator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/79

CB-10455 android: Adding permission helper to remove cordova-android 5.0.0 
constraint

Left out of the first round by mistake

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-media CB-10455

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit f0a82b18958fd5291239854ac56ff2c3ff0873d1
Author: riknoll 
Date:   2016-02-05T17:57:08Z

CB-10455 android: Adding permission helper to remove cordova-android 5.0.0 
constraint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/378#issuecomment-180243971
  
Added a few comments, otherwise LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/378#discussion_r51986870
  
--- Diff: cordova-lib/spec-cordova/metadata/windows_parser.spec.js ---
@@ -115,31 +110,9 @@ describe('windows8 project parser', function() {
 read = spyOn(fs, 'readFileSync').andReturn('');
 });
 
-describe('update_from_config method', function() {
--- End diff --

Intead of removing these tests could you please update them to test that 
corresponding script is being required, and the error is thrown when it is 
missing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...

[Fuchur84]

Github user Fuchur84 commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/63#issuecomment-180414183
  
There seems to be a problem with this on Windows 10 / Windows 10 Mobile... 
I get an error on line 502, column 33 in 
"(path)/transfer/src/windows/FileTransferProxy.js":
"0x80070057 - JavaScript runtime error: Wrong parameter.

count"

The value given there is download.progress.bytesReceived (which seems to be 
0 when it is called), but I am not sure what it does expect there and why 0 is 
not a valid value for the first iteration. Any idea what is happening there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/79#issuecomment-180517843
  
Thanks. Also FYI I did the tests including #78 which I plan to merge 
shortly. Tests fail without it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52064153
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -22,61 +22,191 @@ title: Hooks Guide
 
 # Hooks Guide
 
+## Introduction
+
 Cordova Hooks represent special scripts which could be added by 
application and
 plugin developers or even by your own build system  to customize cordova 
commands.
-Hook scripts could be defined by adding them to the special predefined 
folder 
-(`/hooks`) or via configuration files (`config.xml` and `plugin.xml`) and 
run
-serially in the following order:
-
-* Application hooks from `/hooks`;
-* Application hooks from `config.xml`;
-* Plugin hooks from `plugins/.../plugin.xml`.
 
-__Note__: `/hooks` directory is considered deprecated in favor of the hook 
elements
-in config.xml and plugin.xml.
-
-## Supported hook types
-The following hook types are supported:
-
-after_build
-after_compile
-after_clean
-after_docs
-after_emulate
-after_platform_add
-after_platform_rm
-after_platform_ls
-after_plugin_add
-after_plugin_ls
-after_plugin_rm
-after_plugin_search
-after_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-after_prepare
-after_run
-after_serve
-before_build
-before_clean
-before_compile
-before_docs
-before_emulate
-before_platform_add
-before_platform_rm/
-before_platform_ls
-before_plugin_add
-before_plugin_ls
-before_plugin_rm
-before_plugin_search/
-before_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-before_plugin_uninstall // Plugin hooks in plugin.xml are executed for 
a plugin being uninstalled only
-before_prepare
-before_run
-before_serve
-pre_package // Windows and Windows Phone only
+There may be special activities that you would like to perform before 
invoking 
--- End diff --

Consider saying 'Cordova hooks allow you to perform special activities 
around cordova commands'. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/79


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: package discovery

[Steven Gill]

Sorry I meant cordova:tool but I also like cordova:tooling better

On Fri, Feb 5, 2016 at 12:34 PM, Jesse  wrote:

> +1
> Shouldn't cordova-tool be cordova:tool ?
> I might like cordova:tooling better, not sure ...
>
>
> @purplecabbage
> risingj.com
>
> On Fri, Feb 5, 2016 at 12:26 PM, Tommy-Carlos Williams  >
> wrote:
>
> > +1
> >
> >
> > > On 6 Feb 2016, at 6:51 AM, Steven Gill  wrote:
> > >
> > > Hey everyone!
> > >
> > > With templates out now, I wanted to propose a few keywords for
> improving
> > > discoverability.
> > >
> > > Firstly, every package should contain 'ecosystem:cordova'.
> > >
> > > I suggest we add these new keywords.
> > > 'cordova:platform'
> > > 'cordova:plugin'
> > > 'cordova:template'
> > > 'cordova-tool' (don't really need this one)
> > >
> > > then we can eventually create a new template.cordova.io search site
> > based
> > > off the plugins search site that uses the 'cordova:template'.
> > >
> > > I'm going to blog about templates next week as long as we can land some
> > > consensus on this.
> >
> >
>

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52080114
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -178,28 +307,51 @@ module.exports = function(context) {
 `context.opts.plugin` object will only be passed to plugin hooks scripts.
 
 You can also require additional Cordova modules in your script using 
`context.requireCordovaModule` in the following way:
+
 ```javascript
 var Q = context.requireCordovaModule('q');
 ```
 
+You can make your scipts async using Q:
+
+```javascript
+module.exports = function(context) {
+var Q = context.requireCordovaModule('q');
+var deferral = new Q.defer();
+
+setTimeout(function(){
+  console.log('hook.js>> end');
+deferral.resolve();
+}, 1000);
+
+return deferral.promise;
+}
+```
+
+
+
 __Note__:  new module loader script interface is used for the `.js` files 
defined via `config.xml` or `plugin.xml` only.
 For compatibility reasons hook files specified via `/hooks` folders are 
run via Node child_process spawn, see 'Non-javascript' section below.
 
 ### Non-javascript
 
-__Note__: we highly recommend writing your hooks using Node.js so that 
they are cross-platform, see 'Javascript' section above.
-
 Non-javascript scripts are run via Node child_process spawn from the 
project's root directory and have the root directory passes as the first 
argument. All other options are passed to the script using environment 
variables:
 
-* CORDOVA_VERSION - The version of the Cordova-CLI.
-* CORDOVA_PLATFORMS - Comma separated list of platforms that the command 
applies to (e.g.: android, ios).
-* CORDOVA_PLUGINS - Comma separated list of plugin IDs that the command 
applies to (e.g.: org.apache.cordova.file, org.apache.cordova.file-transfer)
-* CORDOVA_HOOK - Path to the hook that is being executed.
-* CORDOVA_CMDLINE - The exact command-line arguments passed to cordova 
(e.g.: cordova run ios --emulate)
+Environment Variable Name | Description
+--|
+CORDOVA_VERSION   | The version of the Cordova-CLI.
+CORDOVA_PLATFORMS | Comma separated list of platforms that the 
command applies to (e.g.: android, ios).
+CORDOVA_PLUGINS   | Comma separated list of plugin IDs that 
the command applies to (e.g.: cordova-plugin-file-transfer, cordova-plugin-file)
+CORDOVA_HOOK  | Path to the hook that is being executed.
+CORDOVA_CMDLINE   | The exact command-line arguments passed to 
cordova (e.g.: cordova run ios --emulate)
 
 If a script returns a non-zero exit code, then the parent cordova command 
will be aborted.
 
-Also, note that even if you are working on Windows, and in case your hook 
scripts aren't bat files (which is recommended, if you want your scripts to 
work in non-Windows operating systems) Cordova CLI will expect a shebang line 
as the first line for it to know the interpreter it needs to use to launch the 
script. The shebang line should match the following example:
+__Note__: we highly recommend writing your hooks using Node.js so that 
they are cross-platform, see [Javascript](#link-javascript) section above.
+
+ Windows Quirks
+
+If you are working on Windows, and in case your hook scripts aren't bat 
files (which is recommended, if you want your scripts to work in non-Windows 
operating systems) Cordova CLI will expect a shebang line as the first line for 
it to know the interpreter it needs to use to launch the script. The shebang 
line should match the following example:
--- End diff --

This sentence reads awkwardly and should be rephrased.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Remove deprecated platform guides?

[Raghav Katyal]

Hi,

We are doing some work on the platform guides. We are converting them to one 
page/platform and updating and modifying the content. Should we remove the 
deprecated platform guides from the website (wp8, fire OS and firefox OS) or 
let them be?

-Raghav

[GitHub] cordova-lib pull request: CB-10235 Added clearer error message for...

[ktop]

Github user ktop closed the pull request at:

https://github.com/apache/cordova-lib/pull/357


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10235 Added clearer error message for...

[ktop]

Github user ktop commented on the pull request:

https://github.com/apache/cordova-lib/pull/357#issuecomment-180583758
  
I will redo this pull request. I was having some repository problems so 
I'll just start over. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[sarangan12]

Github user sarangan12 commented on the pull request:

https://github.com/apache/cordova-docs/pull/489#issuecomment-180586418
  
@rakatyal Why do we want to remove Sample Usage? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/489#issuecomment-180589385
  
No we shouldn't. I didn't see anything in the diff on that so was curious. 
Also do you think it's a good idea to add another sample usage for iOS/windows?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Remove deprecated platform guides?

[Jesse]

I think wp8 still has use, I would leave it and dump the others.


@purplecabbage
risingj.com

On Fri, Feb 5, 2016 at 2:04 PM, Steven Gill  wrote:

> As long as they continue to live in the older version of docs, I'm fine
> with removing them.
>
> On Fri, Feb 5, 2016 at 2:00 PM, Raghav Katyal 
> wrote:
>
> > Hi,
> >
> > We are doing some work on the platform guides. We are converting them to
> > one page/platform and updating and modifying the content. Should we
> remove
> > the deprecated platform guides from the website (wp8, fire OS and firefox
> > OS) or let them be?
> >
> > -Raghav
> >
>

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/471#issuecomment-180609791
  
@rakatyal @nikhilkh @vladimir-kotikov  @infil00p please look this over. I 
have some more updates to content that are coming, like 
[CB-10206](https://issues.apache.org/jira/browse/CB-10206). I just want to get 
the review started now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52085944
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -20,63 +20,193 @@ license: >
 title: Hooks Guide
 ---
 
-# Hooks Guide
+# Hooks
+
+## Introduction
 
 Cordova Hooks represent special scripts which could be added by 
application and
 plugin developers or even by your own build system  to customize cordova 
commands.
-Hook scripts could be defined by adding them to the special predefined 
folder 
-(`/hooks`) or via configuration files (`config.xml` and `plugin.xml`) and 
run
-serially in the following order:
-
-* Application hooks from `/hooks`;
-* Application hooks from `config.xml`;
-* Plugin hooks from `plugins/.../plugin.xml`.
 
-__Note__: `/hooks` directory is considered deprecated in favor of the hook 
elements
-in config.xml and plugin.xml.
-
-## Supported hook types
-The following hook types are supported:
-
-after_build
-after_compile
-after_clean
-after_docs
-after_emulate
-after_platform_add
-after_platform_rm
-after_platform_ls
-after_plugin_add
-after_plugin_ls
-after_plugin_rm
-after_plugin_search
-after_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-after_prepare
-after_run
-after_serve
-before_build
-before_clean
-before_compile
-before_docs
-before_emulate
-before_platform_add
-before_platform_rm/
-before_platform_ls
-before_plugin_add
-before_plugin_ls
-before_plugin_rm
-before_plugin_search/
-before_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-before_plugin_uninstall // Plugin hooks in plugin.xml are executed for 
a plugin being uninstalled only
-before_prepare
-before_run
-before_serve
-pre_package // Windows and Windows Phone only
+Cordova hooks allow you to perform special activities around cordova 
commands. For example, 
+you may have a custom tool that checks for code formatting in your 
javascript file. And, you 
+would like to run this tool before every build. In such a case, you could 
use a 
+'before_build' hook and instruct the cordova run time to run the custom 
tool to be invoked 
+before every build. 
+
+There are 2 types of hooks:
+
+- Application hooks
+- Plugins hooks
+
+### Application hooks
+
+These hooks are related to the application. For example, hooks such as 
`before_build`, 
+`after_build`, etc applies to your application. 
+
+### Plugin hooks
+
+These hooks are related to the plugins of your application. For example, 
hooks such as 
+`before_plugin_add`, `after_plugin_add`, etc applies to plugin related 
activities. These
+hooks can be associated with all plugins within your application or be 
specific to only 
+one plugin. 
+
+Cordova supports the following hook types:
+
+
+
+
+
+
+Hook Type
+Associated Cordova Command
+Description
+
+
+
+
+Application hooks
+
+
+before_platform_add
+cordova platform 
add
+To 
be executed before and after adding a platform.
+
+
+after_platform_add
+
+
+before_platform_rm
+cordova platform 
rm
+To 
be executed before and after removing a platform.
+
+
+after_platform_rm
+
+
+before_platform_ls
+cordova platform 
ls
+To 
be executed before and after listing the installed and available platforms.
+
+
+after_platform_ls
+
+
+before_prepare
+cordova 
prepare
+To be executed before 
and after preparing your application.
+
+
+after_prepare
+
+
+before_compile
+cordova 
compile
+To be executed before 
and after compiling your application.
+
+
+after_compile
+
+
+before_build
+cordova build
+To be executed before 
and after building your application.
+
+
+after_build
+
+
+

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/474#discussion_r52085975
  
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -17,700 +17,489 @@ license: >
 specific language governing permissions and limitations
 under the License.
 
-title: Plugin Specification
+title: Plugin.xml
 ---
 
-# Plugin Specification
-
-The `plugin.xml` file is an XML document in the `plugins` namespace:
-`http://apache.org/cordova/ns/plugins/1.0`. It contains a top-level
-`plugin` element that defines the plugin, and children that define the
-structure of the plugin.
-
-A sample plugin element:
+# Plugin.xml
 
-
-http://apache.org/cordova/ns/plugins/1.0;
-xmlns:android="http://schemas.android.com/apk/res/android;
-id="com.alunny.foo"
-version="1.0.2">
+Plugin.xml file defines the structure and settings required for your 
plugin. It has several elements to provide details about your plugin.
 
-## _plugin_ Element
+## plugin
 
-The `plugin` element is the plugin manifest's top-level element. It
-features the following attributes:
+  The `plugin` element is the plugin manifest's top-level element.
 
-* `xmlns` (required):
-  The plugin namespace, `http://apache.org/cordova/ns/plugins/1.0`. If
-  the document contains XML from other namespaces, such as tags to be
-  added to the `AndroidManifest.xml` file, those namespaces should
-  also be included in the top-level element.
+  Attributes(type) | Description
+   | 
+  xmlns(string) | *Required*  The plugin namespace, 
`http://apache.org/cordova/ns/plugins/1.0`. If the document contains XML from 
other namespaces, such as tags to be added to the `AndroidManifest.xml` file, 
those namespaces should also be included in the  element.
+  id(string) | *Required*  A reverse-domain style identifier for the 
plugin.
+  version(string) | *Required*  A version number for the plugin, that 
matches the following major-minor-patch style regular expression: 
`^\d+[.]\d+[.]\d+$`
 
-* `id` (required):
-  A reverse-domain style identifier for the plugin, such as
-  `com.alunny.foo`
+  Example:
+  ```
+  
+  http://apache.org/cordova/ns/plugins/1.0;
+  xmlns:android="http://schemas.android.com/apk/res/android;
+  id="com.alunny.foo"
+  version="1.0.2">
+  ```
 
-* `version` (required):
-  A version number for the plugin, that matches the following
-  major-minor-patch style regular expression:
+### engines and engine
 
-^\d+[.]\d+[.]\d+$
+  The child elements of the `` element specify versions of Apache 
Cordova-based frameworks that this plugin supports. Plugman aborts with a 
non-zero code for any plugin whose target project does not meet the engine's 
constraints. If no  tags are specified, plugman attempts to install 
into the specified cordova project directory blindly.
 
-## _engines_ and _engine_ Elements
+  Attributes(type) | Description
+   | 
+  name(string) | *Required*  Name of the engine. Here are the default 
engines that are supported :  `cordova`   `cordova-plugman` 
  `cordova-android`   `cordova-ios`   
`cordova-blackberry10`   `cordova-wp8`   `cordova-windows` 
  `android-sdk` // returns the highest Android api level installed 
  `apple-xcode` // returns the xcode version   `apple-ios` // 
returns the highest iOS version installed   `apple-osx` // returns the 
OSX version   `blackberry-ndk` // returns the native blackberry SDK 
version  You can also specify a custom framework apart from the default 
ones.
+  version(string) | *Required*  The version that your framework must 
have in order to install. It should match a major-minor-patch string conforming 
to the regular expression: `^\d+[.]\d+[.]\d+$`
+  scriptSrc(string) | **For custom frameworks only**  *Required* 
  The script file that tells plugman the version of the custom framework. 
Ideally, this file should be within the top level directory of your plugin 
directory.
+  platform(string) | **For custom frameworks only**  *Required*  
The platforms your framework supports. You may use the wildcard `*` to say 
supported for all platforms, specify multiple with a pipe character like 
`android|ios|blackberry10` or just a single platform like `android`.
 
-The child elements of the `` element specify versions of
-Apache Cordova-based frameworks that this plugin supports. An example:
+  Examples:
+  ```
+  
+
+  
+  ```
 
-
-
-
-
-
+  Engine elements may also specify fuzzy matches using '>', '>=' etc. to 
avoid repetition, and to reduce maintenance when the underlying 

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52085942
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -20,63 +20,193 @@ license: >
 title: Hooks Guide
 ---
 
-# Hooks Guide
+# Hooks
+
+## Introduction
 
 Cordova Hooks represent special scripts which could be added by 
application and
 plugin developers or even by your own build system  to customize cordova 
commands.
-Hook scripts could be defined by adding them to the special predefined 
folder 
-(`/hooks`) or via configuration files (`config.xml` and `plugin.xml`) and 
run
-serially in the following order:
-
-* Application hooks from `/hooks`;
-* Application hooks from `config.xml`;
-* Plugin hooks from `plugins/.../plugin.xml`.
 
-__Note__: `/hooks` directory is considered deprecated in favor of the hook 
elements
-in config.xml and plugin.xml.
-
-## Supported hook types
-The following hook types are supported:
-
-after_build
-after_compile
-after_clean
-after_docs
-after_emulate
-after_platform_add
-after_platform_rm
-after_platform_ls
-after_plugin_add
-after_plugin_ls
-after_plugin_rm
-after_plugin_search
-after_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-after_prepare
-after_run
-after_serve
-before_build
-before_clean
-before_compile
-before_docs
-before_emulate
-before_platform_add
-before_platform_rm/
-before_platform_ls
-before_plugin_add
-before_plugin_ls
-before_plugin_rm
-before_plugin_search/
-before_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-before_plugin_uninstall // Plugin hooks in plugin.xml are executed for 
a plugin being uninstalled only
-before_prepare
-before_run
-before_serve
-pre_package // Windows and Windows Phone only
+Cordova hooks allow you to perform special activities around cordova 
commands. For example, 
+you may have a custom tool that checks for code formatting in your 
javascript file. And, you 
+would like to run this tool before every build. In such a case, you could 
use a 
+'before_build' hook and instruct the cordova run time to run the custom 
tool to be invoked 
+before every build. 
+
+There are 2 types of hooks:
+
+- Application hooks
+- Plugins hooks
+
+### Application hooks
+
+These hooks are related to the application. For example, hooks such as 
`before_build`, 
+`after_build`, etc applies to your application. 
+
+### Plugin hooks
+
+These hooks are related to the plugins of your application. For example, 
hooks such as 
+`before_plugin_add`, `after_plugin_add`, etc applies to plugin related 
activities. These
+hooks can be associated with all plugins within your application or be 
specific to only 
+one plugin. 
+
+Cordova supports the following hook types:
+
+
+
+
+
+
+Hook Type
+Associated Cordova Command
+Description
+
+
+
+
+Application hooks
+
+
+before_platform_add
+cordova platform 
add
+To 
be executed before and after adding a platform.
+
+
+after_platform_add
+
+
+before_platform_rm
+cordova platform 
rm
+To 
be executed before and after removing a platform.
+
+
+after_platform_rm
+
+
+before_platform_ls
+cordova platform 
ls
+To 
be executed before and after listing the installed and available platforms.
+
+
+after_platform_ls
+
+
+before_prepare
+cordova 
prepare
+To be executed before 
and after preparing your application.
+
+
+after_prepare
+
+
+before_compile
+cordova 
compile
+To be executed before 
and after compiling your application.
+
+
+after_compile
+
+
+before_build
+cordova build
+To be executed before 
and after building your application.
+
+
+after_build
+
+
+

Re: Remove deprecated platform guides?

[Steven Gill]

As long as they continue to live in the older version of docs, I'm fine
with removing them.

On Fri, Feb 5, 2016 at 2:00 PM, Raghav Katyal 
wrote:

> Hi,
>
> We are doing some work on the platform guides. We are converting them to
> one page/platform and updating and modifying the content. Should we remove
> the deprecated platform guides from the website (wp8, fire OS and firefox
> OS) or let them be?
>
> -Raghav
>

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52079856
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -178,28 +307,51 @@ module.exports = function(context) {
 `context.opts.plugin` object will only be passed to plugin hooks scripts.
 
 You can also require additional Cordova modules in your script using 
`context.requireCordovaModule` in the following way:
+
 ```javascript
 var Q = context.requireCordovaModule('q');
 ```
 
+You can make your scipts async using Q:
+
+```javascript
+module.exports = function(context) {
+var Q = context.requireCordovaModule('q');
+var deferral = new Q.defer();
+
+setTimeout(function(){
+  console.log('hook.js>> end');
+deferral.resolve();
+}, 1000);
+
+return deferral.promise;
+}
+```
+
+
+
 __Note__:  new module loader script interface is used for the `.js` files 
defined via `config.xml` or `plugin.xml` only.
 For compatibility reasons hook files specified via `/hooks` folders are 
run via Node child_process spawn, see 'Non-javascript' section below.
 
 ### Non-javascript
 
-__Note__: we highly recommend writing your hooks using Node.js so that 
they are cross-platform, see 'Javascript' section above.
-
 Non-javascript scripts are run via Node child_process spawn from the 
project's root directory and have the root directory passes as the first 
argument. All other options are passed to the script using environment 
variables:
 
-* CORDOVA_VERSION - The version of the Cordova-CLI.
-* CORDOVA_PLATFORMS - Comma separated list of platforms that the command 
applies to (e.g.: android, ios).
-* CORDOVA_PLUGINS - Comma separated list of plugin IDs that the command 
applies to (e.g.: org.apache.cordova.file, org.apache.cordova.file-transfer)
-* CORDOVA_HOOK - Path to the hook that is being executed.
-* CORDOVA_CMDLINE - The exact command-line arguments passed to cordova 
(e.g.: cordova run ios --emulate)
+Environment Variable Name | Description
--- End diff --

No colon after e.g.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52084953
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -20,63 +20,193 @@ license: >
 title: Hooks Guide
 ---
 
-# Hooks Guide
+# Hooks
+
+## Introduction
 
 Cordova Hooks represent special scripts which could be added by 
application and
 plugin developers or even by your own build system  to customize cordova 
commands.
-Hook scripts could be defined by adding them to the special predefined 
folder 
-(`/hooks`) or via configuration files (`config.xml` and `plugin.xml`) and 
run
-serially in the following order:
-
-* Application hooks from `/hooks`;
-* Application hooks from `config.xml`;
-* Plugin hooks from `plugins/.../plugin.xml`.
 
-__Note__: `/hooks` directory is considered deprecated in favor of the hook 
elements
-in config.xml and plugin.xml.
-
-## Supported hook types
-The following hook types are supported:
-
-after_build
-after_compile
-after_clean
-after_docs
-after_emulate
-after_platform_add
-after_platform_rm
-after_platform_ls
-after_plugin_add
-after_plugin_ls
-after_plugin_rm
-after_plugin_search
-after_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-after_prepare
-after_run
-after_serve
-before_build
-before_clean
-before_compile
-before_docs
-before_emulate
-before_platform_add
-before_platform_rm/
-before_platform_ls
-before_plugin_add
-before_plugin_ls
-before_plugin_rm
-before_plugin_search/
-before_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-before_plugin_uninstall // Plugin hooks in plugin.xml are executed for 
a plugin being uninstalled only
-before_prepare
-before_run
-before_serve
-pre_package // Windows and Windows Phone only
+Cordova hooks allow you to perform special activities around cordova 
commands. For example, 
+you may have a custom tool that checks for code formatting in your 
javascript file. And, you 
+would like to run this tool before every build. In such a case, you could 
use a 
+'before_build' hook and instruct the cordova run time to run the custom 
tool to be invoked 
+before every build. 
+
+There are 2 types of hooks:
+
+- Application hooks
+- Plugins hooks
+
+### Application hooks
+
+These hooks are related to the application. For example, hooks such as 
`before_build`, 
+`after_build`, etc applies to your application. 
+
+### Plugin hooks
+
+These hooks are related to the plugins of your application. For example, 
hooks such as 
+`before_plugin_add`, `after_plugin_add`, etc applies to plugin related 
activities. These
+hooks can be associated with all plugins within your application or be 
specific to only 
+one plugin. 
+
+Cordova supports the following hook types:
+
+
+
+
+
+
+Hook Type
+Associated Cordova Command
+Description
+
+
+
+
+Application hooks
+
+
+before_platform_add
+cordova platform 
add
+To 
be executed before and after adding a platform.
+
+
+after_platform_add
+
+
+before_platform_rm
+cordova platform 
rm
+To 
be executed before and after removing a platform.
+
+
+after_platform_rm
+
+
+before_platform_ls
+cordova platform 
ls
+To 
be executed before and after listing the installed and available platforms.
+
+
+after_platform_ls
+
+
+before_prepare
+cordova 
prepare
+To be executed before 
and after preparing your application.
+
+
+after_prepare
+
+
+before_compile
+cordova 
compile
+To be executed before 
and after compiling your application.
+
+
+after_compile
+
+
+before_build
+cordova build
+To be executed before 
and after building your application.
+
+
+after_build
+
+
+

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

[Titoine]

Github user Titoine commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-180613895
  
@riknoll 
can't test it right now. I'm trying to do a camera/gallery plugin without 
having to use native and avoid this problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52085107
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -178,28 +307,51 @@ module.exports = function(context) {
 `context.opts.plugin` object will only be passed to plugin hooks scripts.
 
 You can also require additional Cordova modules in your script using 
`context.requireCordovaModule` in the following way:
+
 ```javascript
 var Q = context.requireCordovaModule('q');
 ```
 
+You can make your scipts async using Q:
+
+```javascript
+module.exports = function(context) {
+var Q = context.requireCordovaModule('q');
+var deferral = new Q.defer();
+
+setTimeout(function(){
+  console.log('hook.js>> end');
+deferral.resolve();
+}, 1000);
+
+return deferral.promise;
+}
+```
+
+
+
 __Note__:  new module loader script interface is used for the `.js` files 
defined via `config.xml` or `plugin.xml` only.
 For compatibility reasons hook files specified via `/hooks` folders are 
run via Node child_process spawn, see 'Non-javascript' section below.
 
 ### Non-javascript
 
-__Note__: we highly recommend writing your hooks using Node.js so that 
they are cross-platform, see 'Javascript' section above.
-
 Non-javascript scripts are run via Node child_process spawn from the 
project's root directory and have the root directory passes as the first 
argument. All other options are passed to the script using environment 
variables:
 
-* CORDOVA_VERSION - The version of the Cordova-CLI.
-* CORDOVA_PLATFORMS - Comma separated list of platforms that the command 
applies to (e.g.: android, ios).
-* CORDOVA_PLUGINS - Comma separated list of plugin IDs that the command 
applies to (e.g.: org.apache.cordova.file, org.apache.cordova.file-transfer)
-* CORDOVA_HOOK - Path to the hook that is being executed.
-* CORDOVA_CMDLINE - The exact command-line arguments passed to cordova 
(e.g.: cordova run ios --emulate)
+Environment Variable Name | Description
+--|
+CORDOVA_VERSION   | The version of the Cordova-CLI.
+CORDOVA_PLATFORMS | Comma separated list of platforms that the 
command applies to (e.g.: android, ios).
+CORDOVA_PLUGINS   | Comma separated list of plugin IDs that 
the command applies to (e.g.: cordova-plugin-file-transfer, cordova-plugin-file)
+CORDOVA_HOOK  | Path to the hook that is being executed.
+CORDOVA_CMDLINE   | The exact command-line arguments passed to 
cordova (e.g.: cordova run ios --emulate)
 
 If a script returns a non-zero exit code, then the parent cordova command 
will be aborted.
 
-Also, note that even if you are working on Windows, and in case your hook 
scripts aren't bat files (which is recommended, if you want your scripts to 
work in non-Windows operating systems) Cordova CLI will expect a shebang line 
as the first line for it to know the interpreter it needs to use to launch the 
script. The shebang line should match the following example:
+__Note__: we highly recommend writing your hooks using Node.js so that 
they are cross-platform, see [Javascript](#link-javascript) section above.
--- End diff --

Add a `>` before it to make it show up as block-quoted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/79#issuecomment-180511951
  
@tony-- @infil00p @nikhilkh Please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[sarangan12]

GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-docs/pull/489

CB-10353: Make Hooks guide a reference

Making Hooks guide a reference

@nikhilkh @axemclion @rakatyal Can you review this PR?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-docs CB-10353

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/489.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #489


commit 8375e2d37dfeeb47afc400469602d29b2a86d032
Author: Sarangan Rajamanickam 
Date:   2016-02-04T18:38:54Z

CB-10353: Make Hooks guide a reference

Making Hooks guide a reference




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Core Plugins and Android API 23

[Richard Knoll]

Yep, I left it out of the first round by mistake; I was looking at an out of 
date version of cordova-plugin-media at the time. I've got a PR open that adds 
the helper here:

https://github.com/apache/cordova-plugin-media/pull/79

Thanks,
Richard

-Original Message-
From: julio cesar sanchez [mailto:jcesarmob...@gmail.com] 
Sent: Friday, February 5, 2016 7:20 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Core Plugins and Android API 23

Yeah, that one.


El viernes, 5 de febrero de 2016, Homer, Tony 
escribió:

> It took me a while to find it, but I guess you mean CB-10455?
>
>
>
> On 2/5/16, 7:56 AM, "julio cesar sanchez"  > wrote:
>
> >I think we just forgot, somebody mentioned this on slack and there is 
> >an issue open on JIRA.
> >
> >2016-02-05 13:52 GMT+01:00 Homer, Tony  >:
> >
> >> Earlier in this thread, Richard stated:
> >> >> This change has been merged into the file, camera, geolocation, 
> >> >> and
> >> contacts plugins (media did not actually require any change).
> >>
> >>
> >> Media was updated on 1/15 but it still has a "cordova-android
> >=5.0.0-dev"
> >> engine tag.
> >> I couldn't find any other discussion about this on the list and 
> >> wondered why it was retained for media.
> >> Was this an oversight?
> >>
> >>
> >> Thanks!
> >> Tony
> >>
> >>
> >>
> >>
> >> On 1/15/16, 4:40 PM, "Simon MacDonald"  > wrote:
> >>
> >> >LGTM
> >> >
> >> >+1
> >> >
> >> >Simon Mac Donald
> >> >https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi
> >> >.im%2fsimonmacdonald=01%7c01%7cRIKNOLL%40exchange.microsoft.c
> >> >om%7cacc2d663ce574637d10908d32e3fd62d%7c72f988bf86f141af91ab2d7cd0
> >> >11db47%7c1=wCGbmJR3ZKj6lABfwOcjoLypjztI9HNX8%2bak6AhuBqY%3d
> >> >
> >> >On Fri, Jan 15, 2016 at 4:32 PM, Joe Bowser  > wrote:
> >> >
> >> >> Sorry, wrong PR:
> >> >> https://github.com/apache/cordova-plugin-inappbrowser/pull/136
> >> >>
> >> >> On Fri, Jan 15, 2016 at 11:42 AM, Joe Bowser  > wrote:
> >> >>
> >> >> > So, what does the timeline look like for a Plugins release.  I 
> >> >> > just
> >> did a
> >> >> > major change in the InAppBrowser to fix tel: and sms: URIs so 
> >> >> > they
> do
> >> >> > stuff, and it'd be cool if this also made if this got looked 
> >> >> > over
> and
> >> >> > landed before the next release.
> >> >> >
> >> >> > https://github.com/apache/cordova-plugin-inappbrowser/pull/135
> >> >> >
> >> >> > On Thu, Jan 14, 2016 at 2:02 PM, Carlos Santana <
> csantan...@gmail.com 
> >> >
> >> >> > wrote:
> >> >> >
> >> >> >> I agree with final compromise, I also had a discussion with 
> >> >> >> Nikhil
> >> >> during
> >> >> >> holiday break offline and understood the situation, some 3rd 
> >> >> >> party
> >> >> plugins
> >> >> >> are not open source and customers/devs don't move as fast as 
> >> >> >> we
> wish,
> >> >> but
> >> >> >> having a CLI 6 with latest plugins being backwards compatible 
> >> >> >> with
> >> lower
> >> >> >> Android API is good base for developers to start upgrading.
> >> >> >>
> >> >> >>
> >> >> >> On Thu, Jan 14, 2016 at 1:23 PM Steven Gill <
> stevengil...@gmail.com >
> >> >> >> wrote:
> >> >> >>
> >> >> >> > Awesome! I'll kick up a discuss thread
> >> >> >> >
> >> >> >> > On Wed, Jan 13, 2016 at 5:42 PM, Richard Knoll <
> >> rikn...@microsoft.com 
> >> >> >
> >> >> >> > wrote:
> >> >> >> >
> >> >> >> > > Hey all,
> >> >> >> > >
> >> >> >> > > This change has been merged into the file, camera,
> geolocation,
> >> and
> >> >> >> > > contacts plugins (media did not actually require any change).
> I
> >> was
> >> >> >> able
> >> >> >> > to
> >> >> >> > > build and run mobilespec on cordova-android 4.0.0 and
> >> >> >> cordova-android's
> >> >> >> > > master. We should probably push for a plugins release 
> >> >> >> > > soon,
> since
> >> >> >> there
> >> >> >> > are
> >> >> >> > > also some major bug fixes to the contacts and camera 
> >> >> >> > > plugins
> that
> >> >> were
> >> >> >> > > recently pushed.
> >> >> >> > >
> >> >> >> > > Thanks,
> >> >> >> > > Richard
> >> >> >> > >
> >> >> >> > > -Original Message-
> >> >> >> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com
> ]
> >> >> >> > > Sent: Friday, January 8, 2016 12:12 PM
> >> >> >> > > To: dev@cordova.apache.org 
> >> >> >> > > Subject: RE: [DISCUSS] Core Plugins and Android API 23
> >> >> >> > >
> >> >> >> > > We had a good discussion about this offline with Joe, 
> >> >> >> > > Simon,
> >> Steve,
> >> >> >> > Jesse,
> >> >> >> > > Parashu and Jason. We came to the following agreement:
> >> >> >> > > This is a temporary fix to the plugins which we need to 
> >> >> >> > > take
> to
> >> >> ensure
> >> >> >> > > Cordova 5.x tools behavior of using the edge plugins does 
> >> >> >> > > 

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/474#discussion_r52067383
  
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -17,700 +17,491 @@ license: >
 specific language governing permissions and limitations
 under the License.
 
-title: Plugin Specification
+title: Plugin.xml
 ---
 
-# Plugin Specification
-
-The `plugin.xml` file is an XML document in the `plugins` namespace:
-`http://apache.org/cordova/ns/plugins/1.0`. It contains a top-level
-`plugin` element that defines the plugin, and children that define the
-structure of the plugin.
-
-A sample plugin element:
+# Plugin.xml
 
-
-http://apache.org/cordova/ns/plugins/1.0;
-xmlns:android="http://schemas.android.com/apk/res/android;
-id="com.alunny.foo"
-version="1.0.2">
+Plugin.xml file defines the structure and settings required for your 
plugin. It has several elements to provide details about your plugin.
 
-## _plugin_ Element
+## plugin
 
-The `plugin` element is the plugin manifest's top-level element. It
-features the following attributes:
+  The `plugin` element is the plugin manifest's top-level element.
 
-* `xmlns` (required):
-  The plugin namespace, `http://apache.org/cordova/ns/plugins/1.0`. If
-  the document contains XML from other namespaces, such as tags to be
-  added to the `AndroidManifest.xml` file, those namespaces should
-  also be included in the top-level element.
+  Attributes(type) | Description
+   | 
+  xmlns(string) | *Required*  The plugin namespace, 
`http://apache.org/cordova/ns/plugins/1.0`. If the document contains XML from 
other namespaces, such as tags to be added to the `AndroidManifest.xml` file, 
those namespaces should also be included in the  element.
--- End diff --

"... to be added to the `AndroidManifest.xml` "
Might be worth mentioning here that this applies in the case of Android.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-android/pull/257#issuecomment-180554647
  
@riknoll you are going to merge this or there is more work to be done?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52063845
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -22,61 +22,191 @@ title: Hooks Guide
 
 # Hooks Guide
 
+## Introduction
+
 Cordova Hooks represent special scripts which could be added by 
application and
 plugin developers or even by your own build system  to customize cordova 
commands.
-Hook scripts could be defined by adding them to the special predefined 
folder 
-(`/hooks`) or via configuration files (`config.xml` and `plugin.xml`) and 
run
-serially in the following order:
-
-* Application hooks from `/hooks`;
-* Application hooks from `config.xml`;
-* Plugin hooks from `plugins/.../plugin.xml`.
 
-__Note__: `/hooks` directory is considered deprecated in favor of the hook 
elements
-in config.xml and plugin.xml.
-
-## Supported hook types
-The following hook types are supported:
-
-after_build
-after_compile
-after_clean
-after_docs
-after_emulate
-after_platform_add
-after_platform_rm
-after_platform_ls
-after_plugin_add
-after_plugin_ls
-after_plugin_rm
-after_plugin_search
-after_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-after_prepare
-after_run
-after_serve
-before_build
-before_clean
-before_compile
-before_docs
-before_emulate
-before_platform_add
-before_platform_rm/
-before_platform_ls
-before_plugin_add
-before_plugin_ls
-before_plugin_rm
-before_plugin_search/
-before_plugin_install // Plugin hooks in plugin.xml are executed for a 
plugin being installed only
-before_plugin_uninstall // Plugin hooks in plugin.xml are executed for 
a plugin being uninstalled only
-before_prepare
-before_run
-before_serve
-pre_package // Windows and Windows Phone only
+There may be special activities that you would like to perform before 
invoking 
+cordova commands. For example, you may have a custom tool that checks for 
code formatting 
+in your javascript file. And, you would like to run this tool before every 
build. In such
+a case, you could use a 'before_build' hook and instruct the cordova run 
time to run the 
+custom tool to be invoked before every build. 
+
+There are 2 types of hooks:
+
+- Application specific hooks
+- Plugins related hooks
--- End diff --

Plugins specific hooks. Should we rename these to 'Application hooks' and 
'Plugin hooks'? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10549: Fixing 6.0.0 manual TOC links

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/488#issuecomment-180545937
  
Whoops, I made the change just now before I noticed the PR. Sorry! 
Deploying now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: package discovery

[Jesse]

+1
Shouldn't cordova-tool be cordova:tool ?
I might like cordova:tooling better, not sure ...


@purplecabbage
risingj.com

On Fri, Feb 5, 2016 at 12:26 PM, Tommy-Carlos Williams 
wrote:

> +1
>
>
> > On 6 Feb 2016, at 6:51 AM, Steven Gill  wrote:
> >
> > Hey everyone!
> >
> > With templates out now, I wanted to propose a few keywords for improving
> > discoverability.
> >
> > Firstly, every package should contain 'ecosystem:cordova'.
> >
> > I suggest we add these new keywords.
> > 'cordova:platform'
> > 'cordova:plugin'
> > 'cordova:template'
> > 'cordova-tool' (don't really need this one)
> >
> > then we can eventually create a new template.cordova.io search site
> based
> > off the plugins search site that uses the 'cordova:template'.
> >
> > I'm going to blog about templates next week as long as we can land some
> > consensus on this.
>
>

[GitHub] cordova-docs pull request: CB-10549: Fixing 6.0.0 manual TOC links

[riknoll]

Github user riknoll closed the pull request at:

https://github.com/apache/cordova-docs/pull/488


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10541: Changing default max...

[XiMnet]

Github user XiMnet commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/162#issuecomment-180514539
  


Hi,


We are away for the Chinese New Year celebration from 8 February 2016 to 12 
February 2016. We will be back on 15th February 2016 (Monday).


For any request which requires immediate attention, kindly contact Ms. Inez 
(012  3211 265) or Mr. Law (017  218 5918).


Thank you very much for your continuous support. We wish you a Happy 
Chinese New Year and happy holidays.


Cheers.

XiMnet Malaysia Sdn Bhd





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180528497
  
@infil00p to review. I think this should fix most of the errors we are 
seeing in [the 
CI](https://ci.apache.org/builders/cordova-android-win/builds/1523/steps/getting-test-results/logs/stdio).
 Was there a reason for the original change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52066234
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -178,28 +307,51 @@ module.exports = function(context) {
 `context.opts.plugin` object will only be passed to plugin hooks scripts.
 
 You can also require additional Cordova modules in your script using 
`context.requireCordovaModule` in the following way:
+
 ```javascript
 var Q = context.requireCordovaModule('q');
 ```
 
+You can make your scipts async using Q:
+
+```javascript
+module.exports = function(context) {
+var Q = context.requireCordovaModule('q');
+var deferral = new Q.defer();
+
+setTimeout(function(){
+  console.log('hook.js>> end');
+deferral.resolve();
+}, 1000);
+
+return deferral.promise;
+}
+```
+
+
+
 __Note__:  new module loader script interface is used for the `.js` files 
defined via `config.xml` or `plugin.xml` only.
 For compatibility reasons hook files specified via `/hooks` folders are 
run via Node child_process spawn, see 'Non-javascript' section below.
 
 ### Non-javascript
 
-__Note__: we highly recommend writing your hooks using Node.js so that 
they are cross-platform, see 'Javascript' section above.
-
 Non-javascript scripts are run via Node child_process spawn from the 
project's root directory and have the root directory passes as the first 
argument. All other options are passed to the script using environment 
variables:
 
-* CORDOVA_VERSION - The version of the Cordova-CLI.
-* CORDOVA_PLATFORMS - Comma separated list of platforms that the command 
applies to (e.g.: android, ios).
-* CORDOVA_PLUGINS - Comma separated list of plugin IDs that the command 
applies to (e.g.: org.apache.cordova.file, org.apache.cordova.file-transfer)
-* CORDOVA_HOOK - Path to the hook that is being executed.
-* CORDOVA_CMDLINE - The exact command-line arguments passed to cordova 
(e.g.: cordova run ios --emulate)
+Environment Variable Name | Description
+--|
+CORDOVA_VERSION   | The version of the Cordova-CLI.
+CORDOVA_PLATFORMS | Comma separated list of platforms that the 
command applies to (e.g.: android, ios).
+CORDOVA_PLUGINS   | Comma separated list of plugin IDs that 
the command applies to (e.g.: org.apache.cordova.file, 
org.apache.cordova.file-transfer)
--- End diff --

cordova-plugin-file-transfer, cordova-plugin-file


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugin patch release

[Jesse]

+1

cordova-plugin-media has also had commits related to background streaming
on iOS

Also :

cordova-plugin-splashscreen:
CB-10422 Splashscreen displays black screen with no image on Android
CB-10412 AutoHideSplashScreen "false" isn't taken in account on iOS
CB-9516 Android SplashScreen - Spinner Does Not Display
CB-9094: Smarter autohide logic on Android
CB-8396 Add AutoHideSplashScreen logic to Android's Splashscreen

cordova-plugin-statusbar
CB-10102 statusbar removeObserver is wrong





@purplecabbage
risingj.com

On Fri, Feb 5, 2016 at 12:10 PM, Nikhil Khandelwal 
wrote:

> Looks like we might need another plugins release. I have been triaging
> JIRAs after the latest set of releases and these look like high priority
> enough to get a release out for them. There are number of regressions/bug
> fixes that we want to get released. These changes are simple and probably
> require a patch update:
>
> cordova-plugin-file:
> CB-10419 cordova-plugin-file 4.0.0 error with browserify workflow
>
> cordova-plugin-wkwebview-engine:
> CB-10269: Replace cordova exec only when present in wkwebview
>
> cordova-plugin-media:
> CB-10476 cordova-plugin-media 2.1.0 dos not fire mediaSuccess
> CB-10455 android: Adding permission helper to remove cordova-android 5.0.0
> constraint
>
> Are there other regressions/JIRAs that need to be included? Ideally, we
> should keep this release scoped to keep the quality high.
>
> Thanks,
> Nikhil
>

[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-android/pull/257#issuecomment-180556020
  
Sorry @csantanapr, I was dealing with some plugin fixes. I will merge this 
by the end of today; I need to test on a device.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: package discovery

[Carlos Santana]

+1 !!

On Fri, Feb 5, 2016 at 4:01 PM Steven Gill  wrote:

> Sorry I meant cordova:tool but I also like cordova:tooling better
>
> On Fri, Feb 5, 2016 at 12:34 PM, Jesse  wrote:
>
> > +1
> > Shouldn't cordova-tool be cordova:tool ?
> > I might like cordova:tooling better, not sure ...
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Fri, Feb 5, 2016 at 12:26 PM, Tommy-Carlos Williams <
> to...@devgeeks.org
> > >
> > wrote:
> >
> > > +1
> > >
> > >
> > > > On 6 Feb 2016, at 6:51 AM, Steven Gill 
> wrote:
> > > >
> > > > Hey everyone!
> > > >
> > > > With templates out now, I wanted to propose a few keywords for
> > improving
> > > > discoverability.
> > > >
> > > > Firstly, every package should contain 'ecosystem:cordova'.
> > > >
> > > > I suggest we add these new keywords.
> > > > 'cordova:platform'
> > > > 'cordova:plugin'
> > > > 'cordova:template'
> > > > 'cordova-tool' (don't really need this one)
> > > >
> > > > then we can eventually create a new template.cordova.io search site
> > > based
> > > > off the plugins search site that uses the 'cordova:template'.
> > > >
> > > > I'm going to blog about templates next week as long as we can land
> some
> > > > consensus on this.
> > >
> > >
> >
>

[GitHub] cordova-plugin-camera pull request: CB-10541: Changing default max...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/162


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/79#issuecomment-180514813
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52063505
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -22,61 +22,191 @@ title: Hooks Guide
 
 # Hooks Guide
--- End diff --

Let's just call it 'Hooks' since this will be placed inside reference 
folder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

package discovery

[Steven Gill]

Hey everyone!

With templates out now, I wanted to propose a few keywords for improving
discoverability.

Firstly, every package should contain 'ecosystem:cordova'.

I suggest we add these new keywords.
'cordova:platform'
'cordova:plugin'
'cordova:template'
'cordova-tool' (don't really need this one)

then we can eventually create a new template.cordova.io search site based
off the plugins search site that uses the 'cordova:template'.

I'm going to blog about templates next week as long as we can land some
consensus on this.

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/489#discussion_r52065065
  
--- Diff: www/docs/en/dev/guide/appdev/hooks/index.md ---
@@ -158,7 +287,7 @@ module.exports = function(context) {
   "opts": {
 "projectRoot":"C:\\path\\to\\the\\project",
 "cordova": {
-  "platforms": ["wp8"],
+  "platforms": ["android"],
   "plugins": ["com.plugin.withhooks"],
--- End diff --

This uses old ID format. Instead use "plugin-withhooks".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: Try catch finally cursors

[nicoabie]

Github user nicoabie commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/71#issuecomment-180537827
  
Hi @manugb, is this the reason of why I'm getting 

> android.database.CursorWindowAllocationException: Cursor window could not 
be created from binder.

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10455 android: Adding permis...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/79#issuecomment-180512541
  
Tested on Marshmallow device and KitKat emulator using mobilespec media 
auto tests. Did tests using cordova-android's master and cordova-android 4.0.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Plugin patch release

[Nikhil Khandelwal]

Looks like we might need another plugins release. I have been triaging JIRAs 
after the latest set of releases and these look like high priority enough to 
get a release out for them. There are number of regressions/bug fixes that we 
want to get released. These changes are simple and probably require a patch 
update:

cordova-plugin-file:
CB-10419 cordova-plugin-file 4.0.0 error with browserify workflow

cordova-plugin-wkwebview-engine:
CB-10269: Replace cordova exec only when present in wkwebview

cordova-plugin-media:
CB-10476 cordova-plugin-media 2.1.0 dos not fire mediaSuccess
CB-10455 android: Adding permission helper to remove cordova-android 5.0.0 
constraint

Are there other regressions/JIRAs that need to be included? Ideally, we should 
keep this release scoped to keep the quality high.

Thanks,
Nikhil

RE: package discovery

[Nikhil Khandelwal]

I like the idea. However, currently plugins are being identified with 
"ecosystem:cordova" keyword. We might have to maintain that for all plugins 
that do not switch to these new keyword below.

For "tool" there is at least one example of a tool which currently shows up in 
plugin search: https://www.npmjs.com/package/cordova-hot-code-push-cli

So let's add the keyword anyway. 

-Nikhil

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Friday, February 5, 2016 11:52 AM
To: dev@cordova.apache.org
Subject: package discovery

Hey everyone!

With templates out now, I wanted to propose a few keywords for improving 
discoverability.

Firstly, every package should contain 'ecosystem:cordova'.

I suggest we add these new keywords.
'cordova:platform'
'cordova:plugin'
'cordova:template'
'cordova-tool' (don't really need this one)

then we can eventually create a new 
https://na01.safelinks.protection.outlook.com/?url=template.cordova.io=01%7c01%7cnikhilkh%40microsoft.com%7c2cf20074433d482eead908d32e65dce6%7c72f988bf86f141af91ab2d7cd011db47%7c1=csk3hOeXJ%2bJSp1lZCkUba1zeVF51mFCAhjOJ7B8wVa8%3d
 search site based off the plugins search site that uses the 'cordova:template'.

I'm going to blog about templates next week as long as we can land some 
consensus on this.

[GitHub] cordova-docs pull request: CB-10353: Make Hooks guide a reference

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/489#issuecomment-180541475
  
Are we getting rid of the 'Sample usage' section?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/474#discussion_r52068338
  
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -17,700 +17,491 @@ license: >
 specific language governing permissions and limitations
 under the License.
 
-title: Plugin Specification
+title: Plugin.xml
 ---
 
-# Plugin Specification
-
-The `plugin.xml` file is an XML document in the `plugins` namespace:
-`http://apache.org/cordova/ns/plugins/1.0`. It contains a top-level
-`plugin` element that defines the plugin, and children that define the
-structure of the plugin.
-
-A sample plugin element:
+# Plugin.xml
 
-
-http://apache.org/cordova/ns/plugins/1.0;
-xmlns:android="http://schemas.android.com/apk/res/android;
-id="com.alunny.foo"
-version="1.0.2">
+Plugin.xml file defines the structure and settings required for your 
plugin. It has several elements to provide details about your plugin.
 
-## _plugin_ Element
+## plugin
 
-The `plugin` element is the plugin manifest's top-level element. It
-features the following attributes:
+  The `plugin` element is the plugin manifest's top-level element.
 
-* `xmlns` (required):
-  The plugin namespace, `http://apache.org/cordova/ns/plugins/1.0`. If
-  the document contains XML from other namespaces, such as tags to be
-  added to the `AndroidManifest.xml` file, those namespaces should
-  also be included in the top-level element.
+  Attributes(type) | Description
+   | 
+  xmlns(string) | *Required*  The plugin namespace, 
`http://apache.org/cordova/ns/plugins/1.0`. If the document contains XML from 
other namespaces, such as tags to be added to the `AndroidManifest.xml` file, 
those namespaces should also be included in the  element.
+  id(string) | *Required*  A npm-style identifier for the plugin.
+  version(string) | *Required*  A version number for the plugin, that 
matches the following major-minor-patch style regular expression: 
`^\d+[.]\d+[.]\d+$`
 
-* `id` (required):
-  A reverse-domain style identifier for the plugin, such as
-  `com.alunny.foo`
+  Example:
+  ```
+  
+  http://apache.org/cordova/ns/plugins/1.0;
+  xmlns:android="http://schemas.android.com/apk/res/android;
+  id="my-plugin-id"
+  version="1.0.2">
+  ```
 
-* `version` (required):
-  A version number for the plugin, that matches the following
-  major-minor-patch style regular expression:
+### engines and engine
 
-^\d+[.]\d+[.]\d+$
+  The child elements of the `` element specify versions of Apache 
Cordova-based frameworks that this plugin supports. CLI aborts with a non-zero 
code for any plugin whose target project does not meet the engine's 
constraints. If no  tags are specified, CLI attempts to install into 
the specified cordova project directory blindly.
 
-## _engines_ and _engine_ Elements
+  Attributes(type) | Description
+   | 
+  name(string) | *Required*  Name of the engine. Here are the default 
engines that are supported :  `cordova`   `cordova-plugman` 
  `cordova-android`   `cordova-ios`   
`cordova-blackberry10`   `cordova-wp8`   `cordova-windows` 
  `android-sdk` (returns the highest Android api level installed) 
  `apple-xcode` (returns the xcode version)   `apple-ios` 
(returns the highest iOS version installed)   `apple-osx` (returns the 
OSX version)   `blackberry-ndk` (returns the native blackberry SDK 
version)  You can also specify a custom framework apart from the default 
ones.
--- End diff --

There are some missing options:
- cordova-osx
- windows-os


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: package discovery

[Tommy-Carlos Williams]

+1


> On 6 Feb 2016, at 6:51 AM, Steven Gill  wrote:
> 
> Hey everyone!
> 
> With templates out now, I wanted to propose a few keywords for improving
> discoverability.
> 
> Firstly, every package should contain 'ecosystem:cordova'.
> 
> I suggest we add these new keywords.
> 'cordova:platform'
> 'cordova:plugin'
> 'cordova:template'
> 'cordova-tool' (don't really need this one)
> 
> then we can eventually create a new template.cordova.io search site based
> off the plugins search site that uses the 'cordova:template'.
> 
> I'm going to blog about templates next week as long as we can land some
> consensus on this.



signature.asc
Description: Message signed with OpenPGP using GPGMail

[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-android/pull/257#issuecomment-180557444
  
@riknoll sure no problem, I was just curious if there was more you wanted 
me to look at.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [Discuss] Process question

[Sergey Grebnov (Akvelon)]

Yeap, I completely forgot to update associated JIRA issue, fixed. Sean, thank 
you for the patch! 

PS. This is covered in the PR processing documentation[1]:  
Step 7: Update JIRA

[1] 
https://github.com/apache/cordova-coho/blob/master/docs/processing-pull-requests.md

-Sergey
-Original Message-
From: Shazron [mailto:shaz...@gmail.com] 
Sent: Friday, February 5, 2016 3:14 AM
To: dev@cordova.apache.org
Subject: Re: [Discuss] Process question

The committer, in this case sgrebnov, would close the issue, or if you are the 
reporter of the issue, if the fix is satisfactory, you can close it.

On Thu, Feb 4, 2016 at 4:07 PM, Joe Bowser  wrote:
> Ideally either the person who pulled in the request, or you would 
> confirm that it landed in master and that it works as you intended.  
> You can test it and indicate that it's closed if you want to move 
> things forward a bit faster.
>
> On Thu, Feb 4, 2016 at 3:54 PM, Sean Kelly  wrote:
>
>> I see from the mail below that pull request was closed and I see that 
>> master now has my PR code. However, the JIRA issue is still open 
>> where I would have expected it to be marked resolved.  Is there more 
>> that I need to do or?
>>
>> Sean
>>
>>
>> -- Forwarded message --
>> From: asfgit 
>> Date: Thu, Feb 4, 2016 at 3:18 AM
>> Subject: [GitHub] cordova-plugin-inappbrowser pull request: CB-7786
>> android: add new...
>> To: dev@cordova.apache.org
>>
>>
>> Github user asfgit closed the pull request at:
>>
>> https://github.com/apache/cordova-plugin-inappbrowser/pull/132
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and 
>> have your reply appear on GitHub as well. If your project does not 
>> have this feature enabled and wishes so, or if the feature is enabled 
>> but not working, please contact infrastructure at 
>> infrastruct...@apache.org or file a JIRA ticket with INFRA.
>> ---
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] inAppBrowser plugin release

[Sergey Grebnov (Akvelon)]

Thank you Steve - cordova-plugin-inappbrowser@1.2.1 has been published to npm.

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Thursday, February 4, 2016 10:33 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] inAppBrowser plugin release

Gave you permission!

On Thu, Feb 4, 2016 at 5:40 AM, Sergey Grebnov (Akvelon) < 
v-seg...@microsoft.com> wrote:

> Can someone give me npm permissions for the plugin please:
>
> npm owner add sgrebnov cordova-plugin-inappbrowser
>
> -Sergey
> -Original Message-
> From: Sergey Grebnov (Akvelon)
> Sent: Monday, February 1, 2016 2:46 PM
> To: 'dev@cordova.apache.org' 
> Subject: RE: [DISCUSS] inAppBrowser plugin release
>
> Does anyone have any reason to delay InAppBrowser 1.2.1. patch release?
> If not, I will start the release tomorrow.
>
> To be released:
>
> General:
> CB-10428 Fix syntax error when browserifying inAppBrowser plugin
> Android:
> CB-10407 InAppBrowser not firing loadstart event on android
> CB-6702 InAppBrowser hangs when opening more than one instance
> CB-10456 InAppBrowser is not closed if I close it programmatically 
> on Android
> Windows:
> CB-10454 InAppBrowser: 'loaderror' event does not have code and 
> message on Windows
> CB-10452 InAppBrowser: 'exit' event is not triggered on Windows
> CB-10451 InAppBrowser: loadstart event is not triggered on Windows
> CB-10450 InAppBrowser: Unable to get property 'canGoBack' of 
> undefined on Windows
>
> -Sergey
> -Original Message-
> From: Sergey Grebnov (Akvelon)
> Sent: Thursday, January 28, 2016 7:21 PM
> To: 'dev@cordova.apache.org' 
> Subject: RE: [DISCUSS] inAppBrowser plugin release
>
> JFYI  - I've addressed new issues found, could someone review PRs please.
>
> CB-10456 InAppBrowser is not closed if I close it programmatically on 
> Android
> https://github.com/apache/cordova-plugin-inappbrowser/pull/143/files?w
> =1
>
> CB-6702 InAppBrowser hangs when opening more than one instance on 
> Android
> https://github.com/apache/cordova-plugin-inappbrowser/pull/144/files?w
> =1
>
> InAppBrowser bugfixing on Windows: CB-10451, CB-10452, CB-10454
> https://github.com/apache/cordova-plugin-inappbrowser/pull/145/files?w
> =1
>
> -Sergey
> -Original Message-
> From: Sergey Grebnov (Akvelon)
> Sent: Wednesday, January 27, 2016 5:28 PM
> To: 'dev@cordova.apache.org' 
> Subject: RE: [DISCUSS] inAppBrowser plugin release
>
> I've implemented unit tests for plugin core functionality and events 
> (see PR [1]) and reported new bugs below. There is only one bad issue 
> on Android which leads to InAppBrowser window hang (CB-10456, 
> CB-6702), a few issues on Windows; iOS is doing well. I'm going to 
> address them tomorrow so propose to wait one more day and do another plugin 
> release.
>
>
> CB-10456 InAppBrowser hangs if I close it programmatically on Android
> CB-6702 InAppBrowser hangs when opening more than one instance
> CB-10454 InAppBrowser: 'loaderror' event does not have code and 
> message on Windows
> CB-10452 InAppBrowser: 'exit' event is not triggered on Windows
> CB-10451 InAppBrowser: loadstart event is not triggered on Windows
> CB-10450 InAppBrowser: Unable to get property 'canGoBack' of undefined 
> on Windows
>
> [1] https://github.com/apache/cordova-plugin-inappbrowser/pull/142
>
> -Sergey
> -Original Message-
> From: Sergey Grebnov (Akvelon)
> Sent: Tuesday, January 26, 2016 4:19 PM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] inAppBrowser plugin release
>
> Looks like we don't have auto tests for InAppBrowser plugin at all. We 
> should write sanity test to ensure plugin is successfully initialized 
> at least (there is cordova.InAppBrowser.open method available). I also 
> think that it is doable to write auto tests for main events (load 
> start/stop,
> etc) as well.
>
> PS. CB-10428 has been resolved by the following PR:
> https://github.com/apache/cordova-plugin-inappbrowser/pull/141/files?w
> =1
>
> -Sergey
> -Original Message-
> From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> Sent: Tuesday, January 26, 2016 12:43 AM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] inAppBrowser plugin release
>
> Looks like there is another regression w.r.t. browserify workflow 
> CB-10428 for Cordova-inappbrowser.
>
> And this one for cordova-plugin-file:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-10419=01%7c01%7cv-segreb%40micr
> osoft.com%7c87655d4803a54891496f08d325d090c1%7c72f988bf86f141af91ab2d7
> cd011db47%7c1=VT5z308fXUhduPr40kC6zA0IsPT4apTeA%2fnStCYkFG8%3d
>
> We might to rev those and re-release.
>
> -Nikhil
>
> -Original Message-
> From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> Sent: Monday, January 25, 2016 10:23 AM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] inAppBrowser plugin release

[GitHub] cordova-docs pull request: CB-10505 Adds cordova-plugin-inappbrows...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/486


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Core Plugins and Android API 23

[Homer, Tony]

Earlier in this thread, Richard stated:
>> This change has been merged into the file, camera, geolocation, and contacts 
>> plugins (media did not actually require any change).


Media was updated on 1/15 but it still has a "cordova-android >=5.0.0-dev" 
engine tag.
I couldn't find any other discussion about this on the list and wondered why it 
was retained for media.
Was this an oversight?


Thanks!
Tony




On 1/15/16, 4:40 PM, "Simon MacDonald"  wrote:

>LGTM
>
>+1
>
>Simon Mac Donald
>http://hi.im/simonmacdonald
>
>On Fri, Jan 15, 2016 at 4:32 PM, Joe Bowser  wrote:
>
>> Sorry, wrong PR:
>> https://github.com/apache/cordova-plugin-inappbrowser/pull/136
>>
>> On Fri, Jan 15, 2016 at 11:42 AM, Joe Bowser  wrote:
>>
>> > So, what does the timeline look like for a Plugins release.  I just did a
>> > major change in the InAppBrowser to fix tel: and sms: URIs so they do
>> > stuff, and it'd be cool if this also made if this got looked over and
>> > landed before the next release.
>> >
>> > https://github.com/apache/cordova-plugin-inappbrowser/pull/135
>> >
>> > On Thu, Jan 14, 2016 at 2:02 PM, Carlos Santana 
>> > wrote:
>> >
>> >> I agree with final compromise, I also had a discussion with Nikhil
>> during
>> >> holiday break offline and understood the situation, some 3rd party
>> plugins
>> >> are not open source and customers/devs don't move as fast as we wish,
>> but
>> >> having a CLI 6 with latest plugins being backwards compatible with lower
>> >> Android API is good base for developers to start upgrading.
>> >>
>> >>
>> >> On Thu, Jan 14, 2016 at 1:23 PM Steven Gill 
>> >> wrote:
>> >>
>> >> > Awesome! I'll kick up a discuss thread
>> >> >
>> >> > On Wed, Jan 13, 2016 at 5:42 PM, Richard Knoll > >
>> >> > wrote:
>> >> >
>> >> > > Hey all,
>> >> > >
>> >> > > This change has been merged into the file, camera, geolocation, and
>> >> > > contacts plugins (media did not actually require any change). I was
>> >> able
>> >> > to
>> >> > > build and run mobilespec on cordova-android 4.0.0 and
>> >> cordova-android's
>> >> > > master. We should probably push for a plugins release soon, since
>> >> there
>> >> > are
>> >> > > also some major bug fixes to the contacts and camera plugins that
>> were
>> >> > > recently pushed.
>> >> > >
>> >> > > Thanks,
>> >> > > Richard
>> >> > >
>> >> > > -Original Message-
>> >> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
>> >> > > Sent: Friday, January 8, 2016 12:12 PM
>> >> > > To: dev@cordova.apache.org
>> >> > > Subject: RE: [DISCUSS] Core Plugins and Android API 23
>> >> > >
>> >> > > We had a good discussion about this offline with Joe, Simon, Steve,
>> >> > Jesse,
>> >> > > Parashu and Jason. We came to the following agreement:
>> >> > > This is a temporary fix to the plugins which we need to take to
>> ensure
>> >> > > Cordova 5.x tools behavior of using the edge plugins does not break
>> >> for
>> >> > our
>> >> > > users. We will pursue the change for all the affected plugins. This
>> >> will
>> >> > go
>> >> > > out in the next PLUGINS release which will happen before the Cordova
>> >> 6.0
>> >> > > release. Since this a temporary fix, we aim to remove it in 6 months
>> >> > > (giving reasonable time for our user base to move to Cordova 6.x+
>> >> which
>> >> > > will have a better plugin version pinning mechanism).
>> >> > >
>> >> > > Thanks,
>> >> > > Nikhil
>> >> > >
>> >> > > -Original Message-
>> >> > > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
>> >> > > Sent: Thursday, January 7, 2016 4:00 PM
>> >> > > To: dev@cordova.apache.org
>> >> > > Subject: Re: [DISCUSS] Core Plugins and Android API 23
>> >> > >
>> >> > > I'm going to play devils advocate a bit here:
>> >> > >
>> >> > >
>> >> > > > There are valid reasons why many app developers might not be ready
>> >> to
>> >> > > > move to API level 23:
>> >> > > >   1) They have an app which is stabilizing or in maintenance mode
>> >> and
>> >> > > > they don't want to risk destabilization by moving to a new major
>> >> > > > Cordova version, Cordova Android platform, and Android API level.
>> >> > > >
>> >> > >
>> >> > > If the developer is not ready to move to a new version of Cordova
>> >> Android
>> >> > > or the Android API would it not also follow that they shouldn't be
>> >> > changing
>> >> > > their plugin versions?
>> >> > >
>> >> > >
>> >> > > >   2) They are using a 3rd-party plugin which has not yet been
>> >> updated
>> >> > > > to request Android permissions as required by API level 23. There
>> >> are
>> >> > > > probably a lot of plugins affected, since access to any of the
>> >> > > > following things on Android M requires runtime permission
>> requests:
>> >> > > > calendar, contacts, phone, camera, microphone, location, beacons,
>> >> > > sensors, SMS, storage.
>> >> > > >
>> >> > >
>> >> > > Right, so if the 3rd 

[GitHub] cordova-plugin-inappbrowser pull request: CB-10395 InAppBrowser's ...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-180319788
  
pls review updated version


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-lib/pull/378#issuecomment-180348008
  
Vladimir, thanks for review! I've addressed the notes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Core Plugins and Android API 23

[julio cesar sanchez]

I think we just forgot, somebody mentioned this on slack and there is an
issue open on JIRA.

2016-02-05 13:52 GMT+01:00 Homer, Tony :

> Earlier in this thread, Richard stated:
> >> This change has been merged into the file, camera, geolocation, and
> contacts plugins (media did not actually require any change).
>
>
> Media was updated on 1/15 but it still has a "cordova-android >=5.0.0-dev"
> engine tag.
> I couldn't find any other discussion about this on the list and wondered
> why it was retained for media.
> Was this an oversight?
>
>
> Thanks!
> Tony
>
>
>
>
> On 1/15/16, 4:40 PM, "Simon MacDonald"  wrote:
>
> >LGTM
> >
> >+1
> >
> >Simon Mac Donald
> >http://hi.im/simonmacdonald
> >
> >On Fri, Jan 15, 2016 at 4:32 PM, Joe Bowser  wrote:
> >
> >> Sorry, wrong PR:
> >> https://github.com/apache/cordova-plugin-inappbrowser/pull/136
> >>
> >> On Fri, Jan 15, 2016 at 11:42 AM, Joe Bowser  wrote:
> >>
> >> > So, what does the timeline look like for a Plugins release.  I just
> did a
> >> > major change in the InAppBrowser to fix tel: and sms: URIs so they do
> >> > stuff, and it'd be cool if this also made if this got looked over and
> >> > landed before the next release.
> >> >
> >> > https://github.com/apache/cordova-plugin-inappbrowser/pull/135
> >> >
> >> > On Thu, Jan 14, 2016 at 2:02 PM, Carlos Santana  >
> >> > wrote:
> >> >
> >> >> I agree with final compromise, I also had a discussion with Nikhil
> >> during
> >> >> holiday break offline and understood the situation, some 3rd party
> >> plugins
> >> >> are not open source and customers/devs don't move as fast as we wish,
> >> but
> >> >> having a CLI 6 with latest plugins being backwards compatible with
> lower
> >> >> Android API is good base for developers to start upgrading.
> >> >>
> >> >>
> >> >> On Thu, Jan 14, 2016 at 1:23 PM Steven Gill 
> >> >> wrote:
> >> >>
> >> >> > Awesome! I'll kick up a discuss thread
> >> >> >
> >> >> > On Wed, Jan 13, 2016 at 5:42 PM, Richard Knoll <
> rikn...@microsoft.com
> >> >
> >> >> > wrote:
> >> >> >
> >> >> > > Hey all,
> >> >> > >
> >> >> > > This change has been merged into the file, camera, geolocation,
> and
> >> >> > > contacts plugins (media did not actually require any change). I
> was
> >> >> able
> >> >> > to
> >> >> > > build and run mobilespec on cordova-android 4.0.0 and
> >> >> cordova-android's
> >> >> > > master. We should probably push for a plugins release soon, since
> >> >> there
> >> >> > are
> >> >> > > also some major bug fixes to the contacts and camera plugins that
> >> were
> >> >> > > recently pushed.
> >> >> > >
> >> >> > > Thanks,
> >> >> > > Richard
> >> >> > >
> >> >> > > -Original Message-
> >> >> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> >> >> > > Sent: Friday, January 8, 2016 12:12 PM
> >> >> > > To: dev@cordova.apache.org
> >> >> > > Subject: RE: [DISCUSS] Core Plugins and Android API 23
> >> >> > >
> >> >> > > We had a good discussion about this offline with Joe, Simon,
> Steve,
> >> >> > Jesse,
> >> >> > > Parashu and Jason. We came to the following agreement:
> >> >> > > This is a temporary fix to the plugins which we need to take to
> >> ensure
> >> >> > > Cordova 5.x tools behavior of using the edge plugins does not
> break
> >> >> for
> >> >> > our
> >> >> > > users. We will pursue the change for all the affected plugins.
> This
> >> >> will
> >> >> > go
> >> >> > > out in the next PLUGINS release which will happen before the
> Cordova
> >> >> 6.0
> >> >> > > release. Since this a temporary fix, we aim to remove it in 6
> months
> >> >> > > (giving reasonable time for our user base to move to Cordova 6.x+
> >> >> which
> >> >> > > will have a better plugin version pinning mechanism).
> >> >> > >
> >> >> > > Thanks,
> >> >> > > Nikhil
> >> >> > >
> >> >> > > -Original Message-
> >> >> > > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> >> >> > > Sent: Thursday, January 7, 2016 4:00 PM
> >> >> > > To: dev@cordova.apache.org
> >> >> > > Subject: Re: [DISCUSS] Core Plugins and Android API 23
> >> >> > >
> >> >> > > I'm going to play devils advocate a bit here:
> >> >> > >
> >> >> > >
> >> >> > > > There are valid reasons why many app developers might not be
> ready
> >> >> to
> >> >> > > > move to API level 23:
> >> >> > > >   1) They have an app which is stabilizing or in maintenance
> mode
> >> >> and
> >> >> > > > they don't want to risk destabilization by moving to a new
> major
> >> >> > > > Cordova version, Cordova Android platform, and Android API
> level.
> >> >> > > >
> >> >> > >
> >> >> > > If the developer is not ready to move to a new version of Cordova
> >> >> Android
> >> >> > > or the Android API would it not also follow that they shouldn't
> be
> >> >> > changing
> >> >> > > their plugin versions?
> >> >> > >
> >> >> > >
> >> >> > > >   2) They are using a 3rd-party plugin 

Re: [DISCUSS] Core Plugins and Android API 23

[Homer, Tony]

It took me a while to find it, but I guess you mean CB-10455?



On 2/5/16, 7:56 AM, "julio cesar sanchez"  wrote:

>I think we just forgot, somebody mentioned this on slack and there is an
>issue open on JIRA.
>
>2016-02-05 13:52 GMT+01:00 Homer, Tony :
>
>> Earlier in this thread, Richard stated:
>> >> This change has been merged into the file, camera, geolocation, and
>> contacts plugins (media did not actually require any change).
>>
>>
>> Media was updated on 1/15 but it still has a "cordova-android >=5.0.0-dev"
>> engine tag.
>> I couldn't find any other discussion about this on the list and wondered
>> why it was retained for media.
>> Was this an oversight?
>>
>>
>> Thanks!
>> Tony
>>
>>
>>
>>
>> On 1/15/16, 4:40 PM, "Simon MacDonald"  wrote:
>>
>> >LGTM
>> >
>> >+1
>> >
>> >Simon Mac Donald
>> >http://hi.im/simonmacdonald
>> >
>> >On Fri, Jan 15, 2016 at 4:32 PM, Joe Bowser  wrote:
>> >
>> >> Sorry, wrong PR:
>> >> https://github.com/apache/cordova-plugin-inappbrowser/pull/136
>> >>
>> >> On Fri, Jan 15, 2016 at 11:42 AM, Joe Bowser  wrote:
>> >>
>> >> > So, what does the timeline look like for a Plugins release.  I just
>> did a
>> >> > major change in the InAppBrowser to fix tel: and sms: URIs so they do
>> >> > stuff, and it'd be cool if this also made if this got looked over and
>> >> > landed before the next release.
>> >> >
>> >> > https://github.com/apache/cordova-plugin-inappbrowser/pull/135
>> >> >
>> >> > On Thu, Jan 14, 2016 at 2:02 PM, Carlos Santana > >
>> >> > wrote:
>> >> >
>> >> >> I agree with final compromise, I also had a discussion with Nikhil
>> >> during
>> >> >> holiday break offline and understood the situation, some 3rd party
>> >> plugins
>> >> >> are not open source and customers/devs don't move as fast as we wish,
>> >> but
>> >> >> having a CLI 6 with latest plugins being backwards compatible with
>> lower
>> >> >> Android API is good base for developers to start upgrading.
>> >> >>
>> >> >>
>> >> >> On Thu, Jan 14, 2016 at 1:23 PM Steven Gill 
>> >> >> wrote:
>> >> >>
>> >> >> > Awesome! I'll kick up a discuss thread
>> >> >> >
>> >> >> > On Wed, Jan 13, 2016 at 5:42 PM, Richard Knoll <
>> rikn...@microsoft.com
>> >> >
>> >> >> > wrote:
>> >> >> >
>> >> >> > > Hey all,
>> >> >> > >
>> >> >> > > This change has been merged into the file, camera, geolocation,
>> and
>> >> >> > > contacts plugins (media did not actually require any change). I
>> was
>> >> >> able
>> >> >> > to
>> >> >> > > build and run mobilespec on cordova-android 4.0.0 and
>> >> >> cordova-android's
>> >> >> > > master. We should probably push for a plugins release soon, since
>> >> >> there
>> >> >> > are
>> >> >> > > also some major bug fixes to the contacts and camera plugins that
>> >> were
>> >> >> > > recently pushed.
>> >> >> > >
>> >> >> > > Thanks,
>> >> >> > > Richard
>> >> >> > >
>> >> >> > > -Original Message-
>> >> >> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
>> >> >> > > Sent: Friday, January 8, 2016 12:12 PM
>> >> >> > > To: dev@cordova.apache.org
>> >> >> > > Subject: RE: [DISCUSS] Core Plugins and Android API 23
>> >> >> > >
>> >> >> > > We had a good discussion about this offline with Joe, Simon,
>> Steve,
>> >> >> > Jesse,
>> >> >> > > Parashu and Jason. We came to the following agreement:
>> >> >> > > This is a temporary fix to the plugins which we need to take to
>> >> ensure
>> >> >> > > Cordova 5.x tools behavior of using the edge plugins does not
>> break
>> >> >> for
>> >> >> > our
>> >> >> > > users. We will pursue the change for all the affected plugins.
>> This
>> >> >> will
>> >> >> > go
>> >> >> > > out in the next PLUGINS release which will happen before the
>> Cordova
>> >> >> 6.0
>> >> >> > > release. Since this a temporary fix, we aim to remove it in 6
>> months
>> >> >> > > (giving reasonable time for our user base to move to Cordova 6.x+
>> >> >> which
>> >> >> > > will have a better plugin version pinning mechanism).
>> >> >> > >
>> >> >> > > Thanks,
>> >> >> > > Nikhil
>> >> >> > >
>> >> >> > > -Original Message-
>> >> >> > > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
>> >> >> > > Sent: Thursday, January 7, 2016 4:00 PM
>> >> >> > > To: dev@cordova.apache.org
>> >> >> > > Subject: Re: [DISCUSS] Core Plugins and Android API 23
>> >> >> > >
>> >> >> > > I'm going to play devils advocate a bit here:
>> >> >> > >
>> >> >> > >
>> >> >> > > > There are valid reasons why many app developers might not be
>> ready
>> >> >> to
>> >> >> > > > move to API level 23:
>> >> >> > > >   1) They have an app which is stabilizing or in maintenance
>> mode
>> >> >> and
>> >> >> > > > they don't want to risk destabilization by moving to a new
>> major
>> >> >> > > > Cordova version, Cordova Android platform, and Android API
>> level.
>> >> >> > > >
>> >> >> > >
>> >> >> > > If the 

[GitHub] cordova-docs pull request: Doc Anchor Fixes

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/487#issuecomment-180636960
  
I'm assuming you grep'd for any `#link-` anchor links on our site that need 
to be changed now as we change the slugify scheme and prefix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180658516
  
Actually it might have to wait until Monday before I can get to this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180658674
  
In the meantime, @jclalala can you [submit an 
ICLA](http://www.apache.org/licenses/#clas)? It's better for us to have one on 
file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-180656412
  
Alright, I'm going to merge this in. It's small enough to not require an 
ICLA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10539: Commenting out the v...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/163#issuecomment-180633771
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Doc Anchor Fixes

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/487#discussion_r52092001
  
--- Diff: www/static/js/docs.js ---
@@ -17,49 +17,81 @@
 
 $(document).ready(function () {
 
-function getAnchorName(i, heading, prefix) {
-var name = prefix;
+function slugify(text) {
+text = text.toLowerCase();
+
+// replace unaccepted characters with spaces
+// NOTE:
+//  a better regex would have been /[^\d\s\w]/ug, but the 'u' 
flag
+//  (Unicode) is not supported in some browsers, and we support
+//  many languages that use Unicode characters
+text = text.replace(/[\[\]\(\)\=\+\?]/g, ' ');
+
+// trim whitespace and replace runs of whitespace with single 
dashes
+text = text.trim().replace(/ +/g, '-');
+
+return text;
+}
+
+function getIdForHeading(heading) {
 if (heading.id) {
-name += heading.id;
+return heading.id;
 } else if (heading.name) {
-name += heading.name;
+return heading.name;
 } else {
-name += i;
+return slugify(heading.innerText);
 }
-return name;
 }
 
-var anchorLink = function (id) {
-var anchor = document.createElement("a");
+function permalinkTo(id) {
+var anchor   = document.createElement("a");
 anchor.className = "header-link";
 anchor.href  = "#" + id;
 anchor.innerHTML = "";
 return anchor;
 }
 
+function anchorFor(id) {
+var anchor   = document.createElement("a");
+anchor.className = "fragment-anchor";
+anchor.id= id;
+return anchor;
+}
+
+// go through all headings in the content and add some links
+$('#page-toc-source h1, #page-toc-source h2').each(function (i, 
heading) {
+
+headingId = getIdForHeading(heading);
+
+// add an anchor for linking to the heading
+// NOTE:
+//  we could have set the ID on the heading itself but we 
didn't
+//  because the  has some extra CSS that floats it above the
+//  heading and makes it easier to see when linked
+$(heading).before(anchorFor(headingId))
+
+// add a permalink to all but the first heading
+if (i > 0) {
+$(heading).append(permalinkTo(headingId));
+}
+});
+
 // Table of Contents
 $('#page-toc').toc({
 'selectors': 'h1,h2', // elements to use as headings
 'container': '#page-toc-source', // element to find all 
selectors in
-'prefix':'link-', // prefix for anchor tags and class 
names
+'prefix':'toc-', // prefix for anchor tags and class 
names
--- End diff --

can we remove the prefix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10539: Commenting out the v...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/163


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/257


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Doc Anchor Fixes

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/487#discussion_r52091918
  
--- Diff: www/static/js/docs.js ---
@@ -17,49 +17,81 @@
 
 $(document).ready(function () {
 
-function getAnchorName(i, heading, prefix) {
-var name = prefix;
+function slugify(text) {
+text = text.toLowerCase();
+
+// replace unaccepted characters with spaces
+// NOTE:
+//  a better regex would have been /[^\d\s\w]/ug, but the 'u' 
flag
+//  (Unicode) is not supported in some browsers, and we support
+//  many languages that use Unicode characters
+text = text.replace(/[\[\]\(\)\=\+\?]/g, ' ');
+
+// trim whitespace and replace runs of whitespace with single 
dashes
+text = text.trim().replace(/ +/g, '-');
+
+return text;
+}
+
+function getIdForHeading(heading) {
 if (heading.id) {
-name += heading.id;
+return heading.id;
 } else if (heading.name) {
-name += heading.name;
+return heading.name;
 } else {
-name += i;
+return slugify(heading.innerText);
 }
-return name;
 }
 
-var anchorLink = function (id) {
-var anchor = document.createElement("a");
+function permalinkTo(id) {
+var anchor   = document.createElement("a");
 anchor.className = "header-link";
 anchor.href  = "#" + id;
 anchor.innerHTML = "";
 return anchor;
 }
 
+function anchorFor(id) {
+var anchor   = document.createElement("a");
+anchor.className = "fragment-anchor";
+anchor.id= id;
+return anchor;
+}
+
+// go through all headings in the content and add some links
+$('#page-toc-source h1, #page-toc-source h2').each(function (i, 
heading) {
--- End diff --

Does this still couple it to the TOC - `#page-toc-source`? Also, we should 
add links for all headings h3+ should be included.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Doc Anchor Fixes

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/487#discussion_r52092095
  
--- Diff: www/static/js/docs.js ---
@@ -17,49 +17,81 @@
 
 $(document).ready(function () {
 
-function getAnchorName(i, heading, prefix) {
-var name = prefix;
+function slugify(text) {
+text = text.toLowerCase();
+
+// replace unaccepted characters with spaces
+// NOTE:
+//  a better regex would have been /[^\d\s\w]/ug, but the 'u' 
flag
+//  (Unicode) is not supported in some browsers, and we support
+//  many languages that use Unicode characters
+text = text.replace(/[\[\]\(\)\=\+\?]/g, ' ');
+
+// trim whitespace and replace runs of whitespace with single 
dashes
+text = text.trim().replace(/ +/g, '-');
+
+return text;
+}
+
+function getIdForHeading(heading) {
 if (heading.id) {
-name += heading.id;
+return heading.id;
 } else if (heading.name) {
-name += heading.name;
+return heading.name;
 } else {
-name += i;
+return slugify(heading.innerText);
 }
-return name;
 }
 
-var anchorLink = function (id) {
-var anchor = document.createElement("a");
+function permalinkTo(id) {
+var anchor   = document.createElement("a");
 anchor.className = "header-link";
 anchor.href  = "#" + id;
 anchor.innerHTML = "";
 return anchor;
 }
 
+function anchorFor(id) {
+var anchor   = document.createElement("a");
+anchor.className = "fragment-anchor";
+anchor.id= id;
+return anchor;
+}
+
+// go through all headings in the content and add some links
+$('#page-toc-source h1, #page-toc-source h2').each(function (i, 
heading) {
--- End diff --

+1 The Android guide definitely requires referencing H3+


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request: CB-9366 Log error.stack as it helps with ...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-js/pull/118#issuecomment-180637928
  
@jimmont Why is the `try-catch` a pain? Is it because the stack gets reset 
here? You have a fair point about the callback not being deleted on exception 
scenarios.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/490

CB-10206: Documenting uses-sdk attribute support in config.xml

And stripped a lot of trailing whitespace. I recommend you append `?w=1` to 
the URL (lets you view diff without whitespace changes)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/riknoll/cordova-docs CB-10206

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/490.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #490


commit e8fff492077c8857195a107c95f88ff91f1e20a5
Author: riknoll 
Date:   2016-02-06T01:15:37Z

CB-10206: Documenting uses-sdk attribute support in config.xml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org