Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

[Jesse]

Make that: "I know we all hate the android emulator but "

No offense intended. 

> On Mar 24, 2016, at 5:04 PM, Joe Bowser  wrote:
> 
> Was this really necessary?
> 
>> On Thu, Mar 24, 2016 at 4:03 PM, Jesse  wrote:
>> 
>> The CI uses emulators, so this in an AVD running KitKat.
>> I know you hate the android emulator Joe, but that is probably the repro
>> step you need.
>> 
>> 
>> @purplecabbage
>> risingj.com
>> 
>>> On Thu, Mar 24, 2016 at 8:07 AM, Joe Bowser  wrote:
>>> 
>>> I managed to get a repro on a Jellybean device.
>>> 
>>> BTW: Nexus devices can be downgraded in a pinch, but I usually test my
>>> KitKat stuff on a Moto E, because it's cheap.
>>> 
>>> On Thu, Mar 24, 2016 at 11:01 AM, Richard Knoll 
>>> wrote:
>>> 
 Yep, I'm sure. I double-checked just now to verify and the
 cordova-android-osx AVD is definitely running KitKat. I was also able
>> to
 reproduce this on a Jellybean device and a KitKat emulator locally with
>>> the
 mobilespec auto tests. I don't have an actual KitKat device on hand,
>>> though.
 
 Thanks,
 Richard
 
 -Original Message-
 From: Joe Bowser [mailto:bows...@gmail.com]
 Sent: Thursday, March 24, 2016 10:41 AM
 To: dev 
 Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin
 
 Are you sure? I couldn't reproduce this on my KitKat devices, or my
 Jellybean Devices. I had to dig up a Moto RAZR running 4.0.3 to see
>> this
 bug happen.
 
 On Thu, Mar 24, 2016 at 10:08 AM, Richard Knoll >> 
 wrote:
 
> Both of the Android CI builders run KitKat. We should probably
> document that somewhere or have medic print it out; I'll look into
>>> doing
 that.
> 
> Thanks,
> Richard
> 
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Thursday, March 24, 2016 8:43 AM
> To: dev 
> Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin
> 
> Seriously, it would be super helpful to know which version of Android
> this failure happened on.  I'm having a really difficult time trying
> to reproduce this bug, and I'm not keen on just throwing things at
>> the
> CI to see what passes.
> 
> On Wed, Mar 23, 2016 at 7:56 PM, Joe Bowser 
>> wrote:
> 
>> Well, that's an easy fix, but it would be helpful to know which AVD
>> is failing, since I have no idea which version of getDrawable() is
>> falling apart.
>> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fstac
>> ko
>> verflow.com
>> %2fquestions%2f30266971%2fwhy-getdrawable-doesnt-work-on-
>> so
>> me-android-devices=01%7c01%7criknoll%40microsoft.com
>> %7c2ea8dcd3
>> d9
>> 10419c401208d353faf1d6%7c72f988bf86f141af91ab2d7cd011db47%7c1=
>> Vy g7%2bB1J3YlK0jvy4NyhgsFt62b8FXCV607V5m6vwLY%3d
>> 
>> On Wed, Mar 23, 2016 at 6:32 PM, Dmitry Blotsky
>> 
>> wrote:
>> 
>>> Hey folks,
>>> 
>>> There’s a crash in the InAppBrowser plugin breaking the CI builds.
 JIRA:
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
>>> su
>>> es.apache.org
>> %2fjira%2fbrowse%2fCB-10944.=01%7c01%7criknoll%40
>>> mi
>>> crosoft.com
>> %7c2ea8dcd3d910419c401208d353faf1d6%7c72f988bf86f141af91
>>> ab
>> 2d7cd011db47%7c1=OwCRnauGzyWnPMZEBLEanP%2fQLqaVqfRl22KX8WtecQ
>>> A%
>>> 3d
>>> 
>>> Kindly,
>>> Dmitry
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
 For additional commands, e-mail: dev-h...@cordova.apache.org
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-10771: Fixing failur...

[rakatyal]

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-201103598
  
I believe so. As mentioned, passing empty string as a value for SetText 
function. It also fails when we skip specifying a value for it. One way to 
avoid this is leaving out this chunk, but then we lose sending the key for the 
option parameter. I can document it as a quirk. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: GitHub pull request housekeeping

[Jesse]

Yeah, I also have done the allow-empty way:
git commit --allow-empty -m "Closing stale pull requests: close #99, close
#46, close #82" ...




@purplecabbage
risingj.com

On Wed, Mar 23, 2016 at 12:01 PM, Carlos Santana 
wrote:

> I have done cleaning by using coho instructions on other repos in the past
>
> You can close multiple PRs with one commit
>
> - Carlos
> @csantanapr
>
> > On Mar 23, 2016, at 4:10 PM, julio cesar sanchez 
> wrote:
> >
> > On cordova coho there is a section "Stale Pull Requests"
> >
> > To close a pull request that is no longer relevant / active:
> >
> >   - Create an empty commit in the repo of the pull request via:
> >  - `git commit --allow-empty -m "Closing stale pull request: close
> #99"
> >
> > So I think it can be done without editing the README.md (never tried)
> >
> >
> > I sometimes ask the PR owner to close it if it's not going to be merged,
> > but if he doesn't close it in a few days we can do this.
> >
> >
> >
> >
> >
> > 2016-03-23 21:05 GMT+01:00 Joe Bowser :
> >
> >> Hey
> >>
> >> So, I don't know about the other repositories, but cordova-android on
> >> GitHub has a lot of pull requests that are obviously never going to be
> >> accepted because they're out of date or are not on the master branch.
> >> Since we have no plans to merge things onto 3.7.x or the 4.1.x
> branches, it
> >> would be good if we could somehow close them.
> >>
> >> AFAIK, the only way we can close them is by editing README.md and
> putting
> >> in the git message. "This closes #", but it would be
> kind
> >> of annoying to have to do that.  That said, may be we should do that for
> >> housekeeping.
> >>
> >> What do people think?
> >>
> >> Joe
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-file-transfer pull request: CB-10771: Fixing failur...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-201085977
  
Is this the only workaround? If so, this quirk should definitely be 
documented.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-10771: Fixing failur...

[rakatyal]

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-201082490
  
@riknoll, @jasongin: Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-10771: Fixing failur...

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/133

CB-10771: Fixing failure when empty string passed as a value for opti…

…on parameter in upload function

CreateUploadAsync fails when passed an empty string as a value for SetText 
function. It also fails when we skip specifying a value for it. So when a user 
passes an empty string, pass " " instead.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
raghav-CB-10771

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #133


commit 45c98415c4e56ac7cc014c23b7453eddacc332ef
Author: Raghav Katyal 
Date:   2016-03-25T00:17:15Z

CB-10771: Fixing failure when empty string passed as a value for option 
parameter in upload function




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

[Joe Bowser]

Was this really necessary?

On Thu, Mar 24, 2016 at 4:03 PM, Jesse  wrote:

> The CI uses emulators, so this in an AVD running KitKat.
> I know you hate the android emulator Joe, but that is probably the repro
> step you need.
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Mar 24, 2016 at 8:07 AM, Joe Bowser  wrote:
>
> > I managed to get a repro on a Jellybean device.
> >
> > BTW: Nexus devices can be downgraded in a pinch, but I usually test my
> > KitKat stuff on a Moto E, because it's cheap.
> >
> > On Thu, Mar 24, 2016 at 11:01 AM, Richard Knoll 
> > wrote:
> >
> > > Yep, I'm sure. I double-checked just now to verify and the
> > > cordova-android-osx AVD is definitely running KitKat. I was also able
> to
> > > reproduce this on a Jellybean device and a KitKat emulator locally with
> > the
> > > mobilespec auto tests. I don't have an actual KitKat device on hand,
> > though.
> > >
> > > Thanks,
> > > Richard
> > >
> > > -Original Message-
> > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > Sent: Thursday, March 24, 2016 10:41 AM
> > > To: dev 
> > > Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin
> > >
> > > Are you sure? I couldn't reproduce this on my KitKat devices, or my
> > > Jellybean Devices. I had to dig up a Moto RAZR running 4.0.3 to see
> this
> > > bug happen.
> > >
> > > On Thu, Mar 24, 2016 at 10:08 AM, Richard Knoll  >
> > > wrote:
> > >
> > > > Both of the Android CI builders run KitKat. We should probably
> > > > document that somewhere or have medic print it out; I'll look into
> > doing
> > > that.
> > > >
> > > > Thanks,
> > > > Richard
> > > >
> > > > -Original Message-
> > > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > > Sent: Thursday, March 24, 2016 8:43 AM
> > > > To: dev 
> > > > Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin
> > > >
> > > > Seriously, it would be super helpful to know which version of Android
> > > > this failure happened on.  I'm having a really difficult time trying
> > > > to reproduce this bug, and I'm not keen on just throwing things at
> the
> > > > CI to see what passes.
> > > >
> > > > On Wed, Mar 23, 2016 at 7:56 PM, Joe Bowser 
> wrote:
> > > >
> > > > > Well, that's an easy fix, but it would be helpful to know which AVD
> > > > > is failing, since I have no idea which version of getDrawable() is
> > > > > falling apart.
> > > > >
> > > > >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fstac
> > > > > ko
> > > > > verflow.com
> %2fquestions%2f30266971%2fwhy-getdrawable-doesnt-work-on-
> > > > > so
> > > > > me-android-devices=01%7c01%7criknoll%40microsoft.com
> %7c2ea8dcd3
> > > > > d9
> > > > >
> 10419c401208d353faf1d6%7c72f988bf86f141af91ab2d7cd011db47%7c1=
> > > > > Vy g7%2bB1J3YlK0jvy4NyhgsFt62b8FXCV607V5m6vwLY%3d
> > > > >
> > > > > On Wed, Mar 23, 2016 at 6:32 PM, Dmitry Blotsky
> > > > > 
> > > > > wrote:
> > > > >
> > > > >> Hey folks,
> > > > >>
> > > > >> There’s a crash in the InAppBrowser plugin breaking the CI builds.
> > > JIRA:
> > > > >>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
> > > > >> su
> > > > >> es.apache.org
> %2fjira%2fbrowse%2fCB-10944.=01%7c01%7criknoll%40
> > > > >> mi
> > > > >> crosoft.com
> %7c2ea8dcd3d910419c401208d353faf1d6%7c72f988bf86f141af91
> > > > >> ab
> > > > >>
> 2d7cd011db47%7c1=OwCRnauGzyWnPMZEBLEanP%2fQLqaVqfRl22KX8WtecQ
> > > > >> A%
> > > > >> 3d
> > > > >>
> > > > >> Kindly,
> > > > >> Dmitry
> > > > >>
> > > > >
> > > > >
> > > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> >
>

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

[Jesse]

The CI uses emulators, so this in an AVD running KitKat.
I know you hate the android emulator Joe, but that is probably the repro
step you need.


@purplecabbage
risingj.com

On Thu, Mar 24, 2016 at 8:07 AM, Joe Bowser  wrote:

> I managed to get a repro on a Jellybean device.
>
> BTW: Nexus devices can be downgraded in a pinch, but I usually test my
> KitKat stuff on a Moto E, because it's cheap.
>
> On Thu, Mar 24, 2016 at 11:01 AM, Richard Knoll 
> wrote:
>
> > Yep, I'm sure. I double-checked just now to verify and the
> > cordova-android-osx AVD is definitely running KitKat. I was also able to
> > reproduce this on a Jellybean device and a KitKat emulator locally with
> the
> > mobilespec auto tests. I don't have an actual KitKat device on hand,
> though.
> >
> > Thanks,
> > Richard
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Thursday, March 24, 2016 10:41 AM
> > To: dev 
> > Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin
> >
> > Are you sure? I couldn't reproduce this on my KitKat devices, or my
> > Jellybean Devices. I had to dig up a Moto RAZR running 4.0.3 to see this
> > bug happen.
> >
> > On Thu, Mar 24, 2016 at 10:08 AM, Richard Knoll 
> > wrote:
> >
> > > Both of the Android CI builders run KitKat. We should probably
> > > document that somewhere or have medic print it out; I'll look into
> doing
> > that.
> > >
> > > Thanks,
> > > Richard
> > >
> > > -Original Message-
> > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > Sent: Thursday, March 24, 2016 8:43 AM
> > > To: dev 
> > > Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin
> > >
> > > Seriously, it would be super helpful to know which version of Android
> > > this failure happened on.  I'm having a really difficult time trying
> > > to reproduce this bug, and I'm not keen on just throwing things at the
> > > CI to see what passes.
> > >
> > > On Wed, Mar 23, 2016 at 7:56 PM, Joe Bowser  wrote:
> > >
> > > > Well, that's an easy fix, but it would be helpful to know which AVD
> > > > is failing, since I have no idea which version of getDrawable() is
> > > > falling apart.
> > > >
> > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fstac
> > > > ko
> > > > verflow.com%2fquestions%2f30266971%2fwhy-getdrawable-doesnt-work-on-
> > > > so
> > > > me-android-devices=01%7c01%7criknoll%40microsoft.com%7c2ea8dcd3
> > > > d9
> > > > 10419c401208d353faf1d6%7c72f988bf86f141af91ab2d7cd011db47%7c1=
> > > > Vy g7%2bB1J3YlK0jvy4NyhgsFt62b8FXCV607V5m6vwLY%3d
> > > >
> > > > On Wed, Mar 23, 2016 at 6:32 PM, Dmitry Blotsky
> > > > 
> > > > wrote:
> > > >
> > > >> Hey folks,
> > > >>
> > > >> There’s a crash in the InAppBrowser plugin breaking the CI builds.
> > JIRA:
> > > >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
> > > >> su
> > > >> es.apache.org%2fjira%2fbrowse%2fCB-10944.=01%7c01%7criknoll%40
> > > >> mi
> > > >> crosoft.com%7c2ea8dcd3d910419c401208d353faf1d6%7c72f988bf86f141af91
> > > >> ab
> > > >> 2d7cd011db47%7c1=OwCRnauGzyWnPMZEBLEanP%2fQLqaVqfRl22KX8WtecQ
> > > >> A%
> > > >> 3d
> > > >>
> > > >> Kindly,
> > > >> Dmitry
> > > >>
> > > >
> > > >
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>

How do we include fonts?

[Dmitry Blotsky]

Hey folks,

Have any of you added or referenced fonts in Apache projects before? I'm doing 
a slight docs styling redesign on the site (PR: 
https://github.com/apache/cordova-docs/pull/567). As part of the redesign it 
was suggested that we use this font on the site: 
https://www.google.com/fonts/specimen/Raleway. However it has this license: 
http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi=OFL#5667e9e4, which 
requires some extra attribution steps (confirmed in 
http://www.apache.org/legal/resolved.html#category-b). I'm including the font 
this way: 
https://github.com/apache/cordova-docs/pull/567/files#diff-67c0e26637b10d352ce571fe6fc8c82aR29.

Do you folks know who would be the best person/mailing list to ask if we're 
using/attributing the font appropriately?

Kindly,
Dmitry

[GitHub] cordova-docs pull request: Changing docs styling.

[dblotsky]

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/567

Changing docs styling.

- Styling ToC
- Changing color scheme for headings
- Changing the font

Result:

![capture](https://cloud.githubusercontent.com/assets/405489/14032929/639bc052-f1d3-11e5-85d5-f6c52a587bc2.PNG)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs toc-styling

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/567.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #567


commit f109dc0c6ac10db961e345cdfb4917f146840960
Author: Dmitry Blotsky 
Date:   2016-03-23T01:35:41Z

Changing docs styling: improving ToC, changing color scheme for headings, 
and changing the font.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: [CB-10689] fix issue with app_name c...

[akofman]

Github user akofman commented on the pull request:

https://github.com/apache/cordova-android/pull/272#issuecomment-201023548
  
@infil00p any status about that ?
It's a quite annoying issue when you have an app with an apostrophe and 
having to juggle between ios and android. Thanks !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugins pull request: CB-10959: Retain the index page as p...

[ankon]

GitHub user ankon opened a pull request:

https://github.com/apache/cordova-plugins/pull/25

CB-10959: Retain the index page as path of the generated URL


Note that this includes CB-10958 / #24 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ankon/cordova-plugins upstream/CB-10959

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugins/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #25


commit b43189e2667fb0cc3fbe643e32045830e5de5afa
Author: Andreas Kohn 
Date:   2016-03-24T14:33:34Z

CB-10958: Retain the `src` attribute of the `content` element when it 
already points to localhost

commit 9e6f436d67d135f27cf066163eb8c71bb5dba653
Author: Andreas Kohn 
Date:   2016-03-24T16:54:46Z

CB-10959: Retain the index page as path of the generated URL




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugins pull request: CB-10958: Retain the `src` attribute...

[ankon]

GitHub user ankon opened a pull request:

https://github.com/apache/cordova-plugins/pull/24

CB-10958: Retain the `src` attribute of the `content` element when it…

… already points to localhost


Note that this does also add a package.json file for the urijs dependency.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ankon/cordova-plugins upstream/CB-10958

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugins/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit b43189e2667fb0cc3fbe643e32045830e5de5afa
Author: Andreas Kohn 
Date:   2016-03-24T14:33:34Z

CB-10958: Retain the `src` attribute of the `content` element when it 
already points to localhost




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugins pull request: CB-10956: Update the GCDWebServer

[ankon]

GitHub user ankon opened a pull request:

https://github.com/apache/cordova-plugins/pull/23

CB-10956: Update the GCDWebServer

These are multiple parts:
1. Fix the README.md
2. Drop the existing GCDWebServer subtree, and readd it at the new path, 
with the same revision as before
3. Follow the README.md instructions to update it

It's hard to squash these together (besides, I think it is easier to follow 
the changes this way), and my git-foo isn't enough to modify the commit 
messages to include the ticket number unfortunately.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ankon/cordova-plugins 
improvement/update-gcdwebserver

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugins/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #23


commit d9d12af9ee6386a8e1d2df241c25287f39f19f51
Author: Andreas Kohn 
Date:   2016-03-24T11:28:13Z

Remove old GCDWebServer

commit 65207dca6f2e6d096d7992464dc1e182be6502cb
Author: Andreas Kohn 
Date:   2016-03-24T11:31:04Z

Update README.md

After the plugin moved into the cordova-plugins repository the instructions
for updating GCDWebServer did no longer work.

commit 1547b6bcc17fad312449c2d522935370e0552b77
Author: Andreas Kohn 
Date:   2016-03-24T11:39:29Z

Squashed 'local-webserver/src/ios/GCDWebServer/' content from commit 15caa9c

git-subtree-dir: local-webserver/src/ios/GCDWebServer
git-subtree-split: 15caa9cd20ed6b32bd69704a90261efe1ca71b77

commit 9f15b12f9ea14728179f827c47b776792a1801c5
Author: Andreas Kohn 
Date:   2016-03-24T11:39:29Z

Merge commit '1547b6bcc17fad312449c2d522935370e0552b77' as 
'local-webserver/src/ios/GCDWebServer'

commit 394cfb12f80de35255a506c0dcbf4a21910e849a
Author: Andreas Kohn 
Date:   2016-03-24T11:42:43Z

Squashed 'local-webserver/src/ios/GCDWebServer/' changes from 
15caa9c..55104e5

55104e5 Update README.md
fcc95fd Merge pull request #260 from jjrscott/master
10a94e3 Removed guards around __kindof usage as the project is Xcode 7 only.
010ef9b Added __kindof keyword where appropriate to avoid errors of the 
form "incompatible block pointer types sending 'GCDWebServerResponse 
*(^)(GCDWebServerDataRequest *__strong)' to parameter of type 
'GCDWebServerProcessBlock' (aka 'GCDWebServerResponse *(^)(GCDWebServerRequest 
*__strong)')"
5ca7c27 Bumped version
c663263 Disabled address sanitizer
5b6eebb Fixed build warning
a4c61bd Bumped version
2543279 Merge pull request #256 from anton-matosov/master
95231b1 Fixed CocoaLumberjack deps
5f2877b Merge pull request #255 from iosphere/check-range-location
47a51c3 Fix NSRangeException by checking range of NSTextCheckingResult
3873dd1 Merge pull request #248 from dcrawshay/master
2ff1025 Fixed WebDAV test response files to correctly represent the 
requested byte-range response instead of the entire file.
4360c4f Support WebDAV GET request byte ranges
8a6a139 Merge pull request #236 from maeldur/master
4eba86f Merge pull request #238 from bendytree/master
ea97373 Also set CFBundleVersion in Info.plist
5707076 Updated to Xcode 7.2
e1fb807 Bumped version
7157572 Added libz and header instructions to readme
94e30f6 Added libz and header instructions to readme
c989411 Use Xcode 7.1 in Travis CI
4ee9c30 Fixed build script
48cf20b Updated iOS app to latest best practices
ac9b8a5 Added support for tvOS
cad428c Removed deprecation warnings on tvOS
bb5c1a5 No need to link explicitly to Foundation
bef9523 Updated for Xcode 7.1
0192c36 Fix
062a0dc allow serverURL to be assigned on tvOS with wifi connection
21d9fc2 Merge pull request #228 from CrossWaterBridge/tvos
614ff58 Enable support for tvOS.
7b0477b Merge pull request #219 from macdrevx/pods-use-frameworks
a674614 Enable support for Podfiles with use_frameworks!
b549f11 Merge pull request #218 from tifroz/master
9d38bb4 Workaround for Swift2 which apparently fails to retain the 
completion blocks passed as parameters
44c6a8a Update README.md
aaf8679 Increased Bonjour resolution timeout to 5 seconds
81d74b4 Fix
f7de5ca Fix
a1c6835 Bumped version to 3.3
e70a333 Added support for NAT port mapping
3c33e9f Bumped version to 3.2.7
d160e5f Merge pull request #213 from 0xpablo/master
2d2343a Turn 'buildForRunning' on for 'GCDWebServers' iOS and Mac Schemes
f6783da Updated test script to run built-in tests
99cae36 Added minimal tests for Mac framework
b292710 Fix
b8b4a35 Add version to framework Info.plist
ecc572a Bumped version to 3.2.6

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

[Joe Bowser]

I managed to get a repro on a Jellybean device.

BTW: Nexus devices can be downgraded in a pinch, but I usually test my
KitKat stuff on a Moto E, because it's cheap.

On Thu, Mar 24, 2016 at 11:01 AM, Richard Knoll 
wrote:

> Yep, I'm sure. I double-checked just now to verify and the
> cordova-android-osx AVD is definitely running KitKat. I was also able to
> reproduce this on a Jellybean device and a KitKat emulator locally with the
> mobilespec auto tests. I don't have an actual KitKat device on hand, though.
>
> Thanks,
> Richard
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Thursday, March 24, 2016 10:41 AM
> To: dev 
> Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin
>
> Are you sure? I couldn't reproduce this on my KitKat devices, or my
> Jellybean Devices. I had to dig up a Moto RAZR running 4.0.3 to see this
> bug happen.
>
> On Thu, Mar 24, 2016 at 10:08 AM, Richard Knoll 
> wrote:
>
> > Both of the Android CI builders run KitKat. We should probably
> > document that somewhere or have medic print it out; I'll look into doing
> that.
> >
> > Thanks,
> > Richard
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Thursday, March 24, 2016 8:43 AM
> > To: dev 
> > Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin
> >
> > Seriously, it would be super helpful to know which version of Android
> > this failure happened on.  I'm having a really difficult time trying
> > to reproduce this bug, and I'm not keen on just throwing things at the
> > CI to see what passes.
> >
> > On Wed, Mar 23, 2016 at 7:56 PM, Joe Bowser  wrote:
> >
> > > Well, that's an easy fix, but it would be helpful to know which AVD
> > > is failing, since I have no idea which version of getDrawable() is
> > > falling apart.
> > >
> > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fstac
> > > ko
> > > verflow.com%2fquestions%2f30266971%2fwhy-getdrawable-doesnt-work-on-
> > > so
> > > me-android-devices=01%7c01%7criknoll%40microsoft.com%7c2ea8dcd3
> > > d9
> > > 10419c401208d353faf1d6%7c72f988bf86f141af91ab2d7cd011db47%7c1=
> > > Vy g7%2bB1J3YlK0jvy4NyhgsFt62b8FXCV607V5m6vwLY%3d
> > >
> > > On Wed, Mar 23, 2016 at 6:32 PM, Dmitry Blotsky
> > > 
> > > wrote:
> > >
> > >> Hey folks,
> > >>
> > >> There’s a crash in the InAppBrowser plugin breaking the CI builds.
> JIRA:
> > >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
> > >> su
> > >> es.apache.org%2fjira%2fbrowse%2fCB-10944.=01%7c01%7criknoll%40
> > >> mi
> > >> crosoft.com%7c2ea8dcd3d910419c401208d353faf1d6%7c72f988bf86f141af91
> > >> ab
> > >> 2d7cd011db47%7c1=OwCRnauGzyWnPMZEBLEanP%2fQLqaVqfRl22KX8WtecQ
> > >> A%
> > >> 3d
> > >>
> > >> Kindly,
> > >> Dmitry
> > >>
> > >
> > >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

RE: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

[Richard Knoll]

Yep, I'm sure. I double-checked just now to verify and the cordova-android-osx 
AVD is definitely running KitKat. I was also able to reproduce this on a 
Jellybean device and a KitKat emulator locally with the mobilespec auto tests. 
I don't have an actual KitKat device on hand, though.

Thanks,
Richard

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Thursday, March 24, 2016 10:41 AM
To: dev 
Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

Are you sure? I couldn't reproduce this on my KitKat devices, or my Jellybean 
Devices. I had to dig up a Moto RAZR running 4.0.3 to see this bug happen.

On Thu, Mar 24, 2016 at 10:08 AM, Richard Knoll 
wrote:

> Both of the Android CI builders run KitKat. We should probably 
> document that somewhere or have medic print it out; I'll look into doing that.
>
> Thanks,
> Richard
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Thursday, March 24, 2016 8:43 AM
> To: dev 
> Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin
>
> Seriously, it would be super helpful to know which version of Android 
> this failure happened on.  I'm having a really difficult time trying 
> to reproduce this bug, and I'm not keen on just throwing things at the 
> CI to see what passes.
>
> On Wed, Mar 23, 2016 at 7:56 PM, Joe Bowser  wrote:
>
> > Well, that's an easy fix, but it would be helpful to know which AVD 
> > is failing, since I have no idea which version of getDrawable() is 
> > falling apart.
> >
> > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fstac
> > ko 
> > verflow.com%2fquestions%2f30266971%2fwhy-getdrawable-doesnt-work-on-
> > so
> > me-android-devices=01%7c01%7criknoll%40microsoft.com%7c2ea8dcd3
> > d9 
> > 10419c401208d353faf1d6%7c72f988bf86f141af91ab2d7cd011db47%7c1=
> > Vy g7%2bB1J3YlK0jvy4NyhgsFt62b8FXCV607V5m6vwLY%3d
> >
> > On Wed, Mar 23, 2016 at 6:32 PM, Dmitry Blotsky 
> > 
> > wrote:
> >
> >> Hey folks,
> >>
> >> There’s a crash in the InAppBrowser plugin breaking the CI builds. JIRA:
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
> >> su 
> >> es.apache.org%2fjira%2fbrowse%2fCB-10944.=01%7c01%7criknoll%40
> >> mi 
> >> crosoft.com%7c2ea8dcd3d910419c401208d353faf1d6%7c72f988bf86f141af91
> >> ab 
> >> 2d7cd011db47%7c1=OwCRnauGzyWnPMZEBLEanP%2fQLqaVqfRl22KX8WtecQ
> >> A%
> >> 3d
> >>
> >> Kindly,
> >> Dmitry
> >>
> >
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10944 : NoSuchMethodE...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/158


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

[Joe Bowser]

Are you sure? I couldn't reproduce this on my KitKat devices, or my
Jellybean Devices. I had to dig up a Moto RAZR running 4.0.3 to see this
bug happen.

On Thu, Mar 24, 2016 at 10:08 AM, Richard Knoll 
wrote:

> Both of the Android CI builders run KitKat. We should probably document
> that somewhere or have medic print it out; I'll look into doing that.
>
> Thanks,
> Richard
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Thursday, March 24, 2016 8:43 AM
> To: dev 
> Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin
>
> Seriously, it would be super helpful to know which version of Android this
> failure happened on.  I'm having a really difficult time trying to
> reproduce this bug, and I'm not keen on just throwing things at the CI to
> see what passes.
>
> On Wed, Mar 23, 2016 at 7:56 PM, Joe Bowser  wrote:
>
> > Well, that's an easy fix, but it would be helpful to know which AVD is
> > failing, since I have no idea which version of getDrawable() is
> > falling apart.
> >
> > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fstacko
> > verflow.com%2fquestions%2f30266971%2fwhy-getdrawable-doesnt-work-on-so
> > me-android-devices=01%7c01%7criknoll%40microsoft.com%7c2ea8dcd3d9
> > 10419c401208d353faf1d6%7c72f988bf86f141af91ab2d7cd011db47%7c1=Vy
> > g7%2bB1J3YlK0jvy4NyhgsFt62b8FXCV607V5m6vwLY%3d
> >
> > On Wed, Mar 23, 2016 at 6:32 PM, Dmitry Blotsky
> > 
> > wrote:
> >
> >> Hey folks,
> >>
> >> There’s a crash in the InAppBrowser plugin breaking the CI builds. JIRA:
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissu
> >> es.apache.org%2fjira%2fbrowse%2fCB-10944.=01%7c01%7criknoll%40mi
> >> crosoft.com%7c2ea8dcd3d910419c401208d353faf1d6%7c72f988bf86f141af91ab
> >> 2d7cd011db47%7c1=OwCRnauGzyWnPMZEBLEanP%2fQLqaVqfRl22KX8WtecQA%
> >> 3d
> >>
> >> Kindly,
> >> Dmitry
> >>
> >
> >
>

[GitHub] cordova-plugins pull request: Return after calling complete

[ankon]

Github user ankon commented on the pull request:

https://github.com/apache/cordova-plugins/pull/22#issuecomment-200932334
  
FWIW: This is the fix for the issue 
https://issues.apache.org/jira/browse/CB-10953


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

[Richard Knoll]

Both of the Android CI builders run KitKat. We should probably document that 
somewhere or have medic print it out; I'll look into doing that.

Thanks,
Richard

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Thursday, March 24, 2016 8:43 AM
To: dev 
Subject: Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

Seriously, it would be super helpful to know which version of Android this 
failure happened on.  I'm having a really difficult time trying to reproduce 
this bug, and I'm not keen on just throwing things at the CI to see what passes.

On Wed, Mar 23, 2016 at 7:56 PM, Joe Bowser  wrote:

> Well, that's an easy fix, but it would be helpful to know which AVD is 
> failing, since I have no idea which version of getDrawable() is 
> falling apart.
>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fstacko
> verflow.com%2fquestions%2f30266971%2fwhy-getdrawable-doesnt-work-on-so
> me-android-devices=01%7c01%7criknoll%40microsoft.com%7c2ea8dcd3d9
> 10419c401208d353faf1d6%7c72f988bf86f141af91ab2d7cd011db47%7c1=Vy
> g7%2bB1J3YlK0jvy4NyhgsFt62b8FXCV607V5m6vwLY%3d
>
> On Wed, Mar 23, 2016 at 6:32 PM, Dmitry Blotsky 
> 
> wrote:
>
>> Hey folks,
>>
>> There’s a crash in the InAppBrowser plugin breaking the CI builds. JIRA:
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissu
>> es.apache.org%2fjira%2fbrowse%2fCB-10944.=01%7c01%7criknoll%40mi
>> crosoft.com%7c2ea8dcd3d910419c401208d353faf1d6%7c72f988bf86f141af91ab
>> 2d7cd011db47%7c1=OwCRnauGzyWnPMZEBLEanP%2fQLqaVqfRl22KX8WtecQA%
>> 3d
>>
>> Kindly,
>> Dmitry
>>
>
>

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

[swbradshaw]

Github user swbradshaw commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-200913136
  
I personally saw the issue on on LG G2(5.0.2) and LG V10 (5.1).  

I believe it affects all devices running Android 4.4 and newer because the 
existing code won't correctly pull the orientation from the MediaStore on API19+



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: Transition bugfix

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/92#issuecomment-200910910
  
Tested and merged in bea0a4e4083f2c19b71606f76a334439b0b17b40, thanks, 
@jeroenv!
Could you please close the PR? (looks like github did not like an absence 
of space in `github close#92`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

[kukikiloke]

Github user kukikiloke commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-200909071
  
@swbradshaw what devices did you see this issue?

I am seeing similar issue only on Samsung devices (S6 5.1.1 and S3 5.1.1) 
that selecting a photo taken in portrait from photo library does not correct 
the orientation (displayed in landscape)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: 6.1.0 (cordova-lib@undefined) ?

[Steven Gill]

Shoot! So I am checking this out at the airport.

So usually cordova-lib version is not supposed to show. It is for
development only and I find it very useful.

Looks like I made a mistake when publishing cordova-lib :(  I was doing
some tests to see what modules were being picked up when running npm pack.
I ended up not deleting those test files from cordova-lib directory and
they got included. I published the tag from the repo when I should have npm
published the tgz. My bad guys. It needs to get repackaged and published,
but with npm, only way to do that is to bump version. So 6.1.1. Sucks that
we have to vote for a repackage with no changes.

Sorry. Can someone do this?

-Steve
On Mar 24, 2016 8:49 AM, "Carlos Santana"  wrote:

> Why do we need to print the version of cordova-lib inside CLI ?
>
> $ cordova -v
> 6.1.0 (cordova-lib@undefined)
>
> I opened a JIRA [1]
>
> Do we want to remove the extra info of cordova-lib and only print the CLI
> version?
>
> cordova-lib is a npm dependency on cordova-cli like any of the other
> dependencies [2]
>
> Does someone using this extra info?
> Do we need to provide more info or less info or provide more info behind -d
> flag (i.e cordova -v -d)?
>
> [1]: https://issues.apache.org/jira/browse/CB-10952
> [2]: https://github.com/apache/cordova-cli/blob/master/package.json#L31
>

[GitHub] cordova-plugin-media pull request: Request audio focus when playin...

[fafaman]

GitHub user fafaman opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/88

Request audio focus when playing, pause when focus lost…

This solves https://issues.apache.org/jira/browse/CB-10951

Request audio focus when playing.
Pause audio when audio focus is lost.
Resume playing when audio focus is granted again.

In my opinion, this is closer to the developers expected behaviour and less 
intrusive to the user. Also this is closer to the iOS behavior of 
cordova-plugin-media. Maybe this should depend on a config.xml setting to 
accommodate developers using cordova-plugin-media for sound effects.

Thanks for considering this pull request,  I would be happy to enhance the 
patch if needed.

Regards,
Fabrice.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fafaman/cordova-plugin-media 
android-handle-audio-focus

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit 01e80d70fc97cda1c16ad58ddb62ee0f4427effb
Author: Fabrice Lebas 
Date:   2016-03-24T12:28:20Z

Request audio focus when playing; Pause audio when audio focus is lost; 
resume playing when audio focus is granted again.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [BUG] CB-10944 NoSuchMethodError in InAppBrowser plugin

[Joe Bowser]

Seriously, it would be super helpful to know which version of Android this
failure happened on.  I'm having a really difficult time trying to
reproduce this bug, and I'm not keen on just throwing things at the CI to
see what passes.

On Wed, Mar 23, 2016 at 7:56 PM, Joe Bowser  wrote:

> Well, that's an easy fix, but it would be helpful to know which AVD is
> failing, since I have no idea which version of getDrawable() is falling
> apart.
>
> http://stackoverflow.com/questions/30266971/why-getdrawable-doesnt-work-on-some-android-devices
>
> On Wed, Mar 23, 2016 at 6:32 PM, Dmitry Blotsky 
> wrote:
>
>> Hey folks,
>>
>> There’s a crash in the InAppBrowser plugin breaking the CI builds. JIRA:
>> https://issues.apache.org/jira/browse/CB-10944.
>>
>> Kindly,
>> Dmitry
>>
>
>

6.1.0 (cordova-lib@undefined) ?

[Carlos Santana]

Why do we need to print the version of cordova-lib inside CLI ?

$ cordova -v
6.1.0 (cordova-lib@undefined)

I opened a JIRA [1]

Do we want to remove the extra info of cordova-lib and only print the CLI
version?

cordova-lib is a npm dependency on cordova-cli like any of the other
dependencies [2]

Does someone using this extra info?
Do we need to provide more info or less info or provide more info behind -d
flag (i.e cordova -v -d)?

[1]: https://issues.apache.org/jira/browse/CB-10952
[2]: https://github.com/apache/cordova-cli/blob/master/package.json#L31

[GitHub] cordova-plugins pull request: Return after calling complete

[ankon]

GitHub user ankon opened a pull request:

https://github.com/apache/cordova-plugins/pull/22

Return after calling complete

This fixes a SIGABRT in `GCDWebServerConnection`: calling `complete` twice 
fails, because we already have a `_responseMessage` for the connection after 
the first `complete`.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ankon/cordova-plugins 
bugs/error-multiple-complete

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugins/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22


commit 78305d6a28579b94e9e6551d12ef1ae711415ad3
Author: Andreas Kohn 
Date:   2016-03-24T15:37:07Z

Return after calling complete




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10944 : NoSuchMethodE...

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/158#issuecomment-200886254
  
It's fine.  I'll do a check on Android 4.4 today to make sure this is 
resolved.  I missed it on this end while doing a quick test here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [ANNOUNCE] Tools Release!

[Carlos Santana]

Anyone having problems installing cordova cli 6.1.0  from npm?

I tried this morning cordova help works it provided the update message

┌──┐

│ Update available: 6.1.0 (current: 6.0.0) │

│ Run npm install -g cordova to update.│

└──┘

But when I run npm install -g cordova

cordova doesn't get installed, it looks like it installs cordova@1.0.0 but
nothing get's installed

I'm using npm@3.6.0 node@5.7.1

Then I run again with @latest
npm install -g cordova@latest
And this time it works

Should we tell users to always use @latest when installing/upgrading as
best practice?
This will be places like the docs "Installing Cordova" [1] [2]

[1]: http://cordova.apache.org
[2]: http://cordova.apache.org/docs/en/latest/guide/cli/index.html


On Wed, Mar 23, 2016 at 3:38 PM Steven Gill  wrote:

> Blog: http://cordova.apache.org/news/2016/03/23/tools-release.html
> Tweet: https://twitter.com/apachecordova/status/712724158640054272
>

[GitHub] cordova-android pull request: Update SystemWebViewEngine

[infil00p]

Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/266#issuecomment-200885817
  
Please create a JIRA issue with repro steps so that we can see what's 
actually being fixed, otherwise we can't accept this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios release

[Edna Y Morales]

bump to this discussion since cordova-common has been released

Thanks,
Edna Morales



From:   Shazron 
To: "dev@cordova.apache.org" 
Date:   03/18/2016 10:34 PM
Subject:Re: [DISCUSS] cordova-ios release



Another issue, the bundled ios-sim should be updated:
https://issues.apache.org/jira/browse/CB-10912

On Thu, Mar 17, 2016 at 1:58 PM, Edna Y Morales 
wrote:

> Ok sounds good
>
> Thanks,
> *Edna Morales*
>
> [image: Inactive hide details for Carlos Santana ---03/17/2016 04:48:19
> PM---I agree Steve - Carlos]Carlos Santana ---03/17/2016 04:48:19 PM---I
> agree Steve - Carlos
>
> From: Carlos Santana 
> To: dev@cordova.apache.org
> Date: 03/17/2016 04:48 PM
> Subject: Re: [DISCUSS] cordova-ios release
> --
>
>
>
> I agree Steve
>
> - Carlos
> @csantanapr
>
> > On Mar 17, 2016, at 4:17 PM, Steven Gill 
wrote:
> >
> > Lets do a common release first and then follow that up with patch ios
> > release
> >
> >> On Thu, Mar 17, 2016 at 11:24 AM, Shazron  wrote:
> >>
> >> I would say patch release. I had some items I wanted in the next
> >> release (labeled cordova-ios-4.1.1), but that shouldn't hold up
> >> releasing often, keep the train running...
> >>
> >> Ideally it should be accompanied with the patches I did yesterday for
> >> cordova-common (since cordova-common is bundled in to cordova-ios),
> >> but those bugs only really affect cordova-cli functionality
> >>
> >> On Thu, Mar 17, 2016 at 11:09 AM, Edna Y Morales 
> >> wrote:
> >>>
> >>> Hi,
> >>>
> >>> We are interested in a cordova-ios release, specifically for this
jira
> >>> item: https://issues.apache.org/jira/browse/CB-10773
> >>>
> >>> Is there any opposition to this or any reason to wait? Steve would it
> >> make
> >>> sense to wait for a cordova-common release to happen first, before
> doing
> >>> the cordova-ios release?
> >>>
> >>> Would it be a patch release or a minor release?
> >>>
> >>> Thanks,
> >>> Edna Morales
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
>
>
>

[GitHub] cordova-windows pull request: CB-10845 Invalidate manifest cache i...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-windows/pull/164

CB-10845 Invalidate manifest cache in prepare

This fixes [CB-10845](https://issues.apache.org/jira/browse/CB-10845)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-10845

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #164


commit c11819169b976f64cdf286dcf7ae4e111b4f61f7
Author: Vladimir Kotikov 
Date:   2016-03-24T13:04:13Z

CB-10845 Invalidate manifest cache in prepare




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10562 hide() not work...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/91


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: Transition bugfix

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/92#issuecomment-200817652
  
Corresponding Jira issue:
[CB-10895](https://issues.apache.org/jira/browse/CB-10895) Transparent 
Splashscreen view sometimes remains


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-200816701
  
Thanks for the pull request. I've had a look at it and think it looks good. 
Before we can merge it though, you need to sign Apache's Contributor License 
Agreement (can be done online): http://www.apache.org/licenses/#clas


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10942 - Cannot

[jcesarmobile]

Github user jcesarmobile commented on the pull request:

https://github.com/apache/cordova-ios/pull/211#issuecomment-200759257
  
Tested and working fine

I think the first if can be removed
```
if (allowNavigationsPass && allowIntentPass) {
return CDVIntentAndNavigationFilterValueNavigationAllowed;
}``` 

This one is enough
```
if (allowNavigationsPass) {
return CDVIntentAndNavigationFilterValueNavigationAllowed;
}```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-dialogs pull request: Added options to customize ke...

[chemerisuk]

GitHub user chemerisuk opened a pull request:

https://github.com/apache/cordova-plugin-dialogs/pull/69

Added options to customize keyboard for prompt and theme on Andorid

Hi. I found that ability to customize keyboard on the `prompt` dialog is 
very useful. For example, if you expect a user to enter PIN code or phone 
number you do not need letters etc. There are 
[some](https://github.com/Paldom/PinDialog) 
[plugins](https://www.npmjs.com/package/cordova-plugin-number-dialog) that aim 
to solve this problem, but the solution they provide is limited. I prefer 
flexibility.

Every platform has its own mechanic to customize keyboard for a text input, 
but at least Android and iOS have common part - both use some kind of `flags` 
parameter (check 
http://developer.android.com/reference/android/text/InputType.html and 
https://developer.apple.com/library/ios/documentation/UIKit/Reference/UITextInputTraits_Protocol/#//apple_ref/c/tdef/UIKeyboardType).
 I've done very basic implementation and put extra parameter `inputType` which 
is of course a platform specific.

This is how you can implement a prompt for a phone number:

```js
navigator.notification.promptPhone = function(message, callback, 
dialogTitle, buttonLabels, defaultText) {
  var inputType;

  if (cordova.platformId === "ios") {
inputType = 5;
  } else if (cordova.platformId === "android") {
inputType = 3;
  }

  return navigator.notification.prompt(message, callback, dialogTitle, 
buttonLabels, defaultText, inputType);
}
```

I think the implementation can be improved, because I haven't done anything 
for other platforms. So feel free to make your comments.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chemerisuk/cordova-plugin-dialogs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-dialogs/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #69


commit 4c2d0732b254887edb521670a529160e0ef8a90b
Author: Maksim Chemerisuk 
Date:   2016-03-01T14:17:17Z

add themes support for android

commit d0be912ac17e876ed64e4ca53e81919c8435884f
Author: Maksim Chemerisuk 
Date:   2016-03-01T14:20:21Z

add inputType support for android

commit 4e10a31ca913dd455a0e80def8d491e861580959
Author: Maksim Chemerisuk 
Date:   2016-03-01T14:31:42Z

fix typo

commit 23ec6345fae405d8cc66eb6db44065d1175e5031
Author: Maksim Chemerisuk 
Date:   2016-03-01T14:47:41Z

update arguments order for prompt dialog

commit b35b536b3c794d1336dd4c0731c26b711fb183cb
Author: Maksim Chemerisuk 
Date:   2016-03-02T11:12:34Z

implement inputType argumnet support for iOS

commit acc411c8420a52ef8706e392c9bc479020011e14
Author: Maksim Chemerisuk 
Date:   2016-03-02T12:33:38Z

update jsdocs for the inputType parameter

commit dae3ef6f45485dafe43646d3e33653c9a49f387f
Author: Maksim Chemerisuk 
Date:   2016-03-18T10:50:10Z

default inputType is undefined




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: Update SystemWebViewEngine

[alin1771]

Github user alin1771 commented on the pull request:

https://github.com/apache/cordova-android/pull/266#issuecomment-200705741
  
No, I didn't create a jira issue. I've just had this issue on my own apps


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10944 : NoSuchMethodE...

[akofman]

GitHub user akofman opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/158

CB-10944 : NoSuchMethodError in InAppBrowser plugin

Sorry for that guys.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/akofman/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #158


commit b928b1ad610a3925facc8c9f360d2213039f478f
Author: Alexis Kofman 
Date:   2016-03-24T07:06:20Z

CB-10944 : NoSuchMethodError in InAppBrowser plugin




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10937 fix stretched i...

[akofman]

Github user akofman closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/157


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org