date:20160329

[GitHub] cordova-plugin-media pull request: CB-10783: Media Plugin - Modify...

2016-03-29 Thread rakatyal

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203159625
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Buildbot: buildslave cordova-windows-slave was lost

2016-03-29 Thread buildbot

The Buildbot working for ''
has noticed that the buildslave named cordova-windows-slave went away

It last disconnected at Tue Mar 29 23:02:35 2016 (buildmaster-local time)

The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky 
'.

Sincerely,
 The Buildbot
 https://ci.apache.org/

https://ci.apache.org/buildslaves/cordova-windows-slave

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Buildbot: buildslave cordova-osx-slave was lost

2016-03-29 Thread buildbot

The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away

It last disconnected at Tue Mar 29 22:36:41 2016 (buildmaster-local time)

The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky 
'.

Sincerely,
 The Buildbot
 https://ci.apache.org/

https://ci.apache.org/buildslaves/cordova-osx-slave

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-03-29 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/569#discussion_r57813112
  
--- Diff: www/.htaccess ---
@@ -18,29 +18,31 @@ RewriteEngine on
 #   pages to new pages.
 
 # 302 (temp):
-#   docs -> docs/en/latest/
-#   docs/-> docs/en/latest/
-#   docs/XX  -> docs/XX/latest/
-#   docs/XX/ -> docs/XX/latest/
+#   docs/  -> docs/[default language]/
+#   docs/XX-> docs/XX/
+#   docs/XX/   -> docs/XX/latest
+#   docs/XX/latest -> docs/XX/latest/
 #
 # NOTE:
-#   these can both apply, turning "/docs" into "/docs/en/latest/"
-RewriteRule ^.*docs/$ {{site.baseurl}}/docs/en/
-RewriteRule ^.*docs/(\w\w)/$ {{site.baseurl}}/docs/$1/latest/ [R=302,L]
-
-# 302 (temp):
-#   docs/XX/latest -> docs/XX/latest/
-RewriteRule ^.*docs/(\w\w)/latest$ {{site.baseurl}}/docs/$1/latest/ 
[R=302,L]
+#   these can all apply, turning "/docs" into "/docs/[default 
language]/latest/"
+RewriteRule ^.*docs/$ {{site.baseurl}}/docs/{{site.language}}/
+RewriteRule ^.*docs/(\w\w(?:-\w\w)?)$ {{site.baseurl}}/docs/$1/
--- End diff --

Yep, that's exactly what it's doing. This way `/docs/en` and `/docs/zh-tw` 
become `/docs/en/` and `/docs/zh-tw/` respectively. This is because `/docs/en` 
resolves to `/docs/en` (which doesn't exist), and `/docs/en/` resolves to 
`/docs/en/index.html`, which exists.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/285


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10783: Media Plugin - Modify...

2016-03-29 Thread rakatyal

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203137750
  
Is there any reason to specify the upper bound?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Inclusion of Evothings Studio on https://cordova.apache.org/

2016-03-29 Thread Parashuram N

Hey,

While the discussion on including additional tools is still happening on the 
mailing list, I had a quick question about the Evothings Studio. I was looking 
at the website and it was not clear if the tool is based on Cordova/Phonegap. 
Is Evothiongs based on Cordova and are the device APIs based on Apache Cordova 
? 

The purpose of the tooling showcase is to show off the various Cordova 
development tools, and it would be helpful if you could also tell us how 
Cordova is used. Maybe we should add that as a part of the description in the 
pull request ? 

-Original Message-
From: Mikael Kindborg [mailto:mikael.kindb...@gmail.com] 
Sent: Thursday, March 24, 2016 2:15 AM
To: dev@cordova.apache.org
Subject: Inclusion of Evothings Studio on https://cordova.apache.org/

Hi everyone on the Cordova Project,

We got reject for our pull request to include Evothings Studio in the listing 
of Cordova Tools on 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcordova.apache.org%2f=01%7c01%7cpanarasi%40microsoft.com%7cf83708e8019a4c60331a08d354d2e319%7c72f988bf86f141af91ab2d7cd011db47%7c1=aXHnr%2bw7ivaSmJyaN8yLTa9LsDZASBhw1WU8M416qz8%3d

See this comment in the pull request:

https://github.com/apache/cordova-docs/pull/410#issuecomment-198858128

Note that Evothings Studio is not a Cordova Showcase App, but a tool for 
developing apps for Apache Cordova.

Are you also rejecting new tools? Evothings Studio is a very useful tool for 
Cordova developers, in particular for development of IoT apps. It is 100% 
Cordova compatible, no lock-in or dependencies, an Evothings project is fully 
compatible with Cordova.

I think the Cordova developer community would appreciate this tool.

Best regards, Mikael Kindborg

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-29 Thread rakatyal

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-windows/pull/163#issuecomment-203131675
  
Also I couldn't understand the reason for creating a new testproj 
directory. Couldn't we have used the existing DummyProject repo for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Curating Apps

2016-03-29 Thread Parashuram N

I think it would not be fair to say "submissions now closed", since we had 
never initially mentioned such a timeframe for submitting apps. The question 
is, if more folks submit apps, what is the policy on accepting them ? 

-Original Message-
From: Dmitry Blotsky [mailto:dblot...@microsoft.com] 
Sent: Tuesday, March 29, 2016 11:01 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Curating Apps

I put apps and tools in the same bucket when it came to adding them to the 
site. I interpreted our last discussion as, “we’ve gotten enough; close the 
submissions now”. If we’re cool to still add this tool, then let’s just add it.

Kindly,
Dmitry

On Mar 29, 2016, at 7:53 AM, julio cesar sanchez 
> wrote:

I meant rejecting because it was an old PR and it was rejected now.

But even if there is no button, people can still send PRs. It's less likely, 
but still possible. And as most of the topic here was about apps, I wanted to 
know if we have an official statement for tools.

So, if I review this tool now and find it useful, I should open a vote thread 
before adding it, right? Should it get 3 positive votes as releases?

2016-03-29 16:02 GMT+02:00 Carlos Santana 
>:

Julio "rejecting" sounds so harsh

Since we removed the "add app" and "add tool" from the webpage, there is no 
process to submit something to be accepted or rejected

I think right now my opinion is that a PMC member would need to do the leg work 
to review, propose something to be added, and do the work of adding it. PMC 
members always look out for the best interest of the project, but as always we 
have lazy consensus it should bring up to other PMC members to see if any would 
vote -1 for any good reason to no accept the content to be added.

Like I said this is only my opinion of one way of getting something added to 
tools or apps on the website.

On Tue, Mar 29, 2016 at 9:38 AM julio cesar sanchez < 
jcesarmob...@gmail.com>
wrote:

I bring the topic back again because recently a tool was rejected and the 
author mailed us asking (and we have not answered him yet)

So, are we rejecting tools too?

The original topic was "[DISCUSS] Curating Apps" and all the messages were 
about apps, except this one from Steve that mentions removing "add a tool"
and "add a plugin"

"YES! Removing the "add a tool" and "add a plugin" is the best way to go.
Those PRs require way to much management. Leave it up to PMC to nominate apps."

2015-10-24 3:24 GMT+02:00 Dmitry Blotsky 
>:

Sure, I’m also down for removing the “add your app” option. Switching to 
putting apps up only at our own discretion makes sense. My only concern is that 
I personally haven’t tried out many Cordova apps, so I would expect us to have 
a shortage of apps this way. But if other PMC members have apps to suggest, 
then we should be good.

To move forward with Carlos’ proposal, we ought to:
- curate the existing list
- have someone explain the change of policy to the PRs still open

Any takers for those two tasks?

Kindly,
Dmitry

On Oct 23, 2015, at 6:01 PM, Steven Gill 
>
wrote:

YES! Removing the "add a tool" and "add a plugin" is the best way to go.
Those PRs require way to much management. Leave it up to PMC to nominate apps.

On Fri, Oct 23, 2015 at 5:41 PM, Nikhil Khandelwal < 
nikhi...@microsoft.com>
wrote:

I like Carlos' proposal. Reviewing PRs for these apps and judging by whatever 
criteria we finally decide (however objective/subjective) will not be worth our 
time. The volume of PRs over the last couple of weeks has been quite 
significant in this area.

At the end of the day, we just need 5-10 showcase apps.

-Nikhil

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Friday, October 23, 2015 5:37 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Curating Apps

I think we make it more simpler, a PMC member to propose to add an app that 
he/she tried out and feels that it deserves to be show case as a good example 
of a great Cordova App.
- remove the "add your app"
- PMC members mails the list, that he evaluated the app and a short description 
on why to added and he is planning to added, and ask if someone opposed with a 
-1
- Like Joe said, we don't need a tons of Apps, just a few will satisfy the goal
- The Apache way, if there are no -1 app get's added.

On Wed, Oct 21, 2015 at 7:27 PM Dmitry Blotsky < 
dblot...@microsoft.com>
wrote:

Sounds like we’ve got some (potentially mutually exclusive) points:
- request detailed app descriptions from submitters
- curate based on detailed criteria
- curate based on loose criteria
- only accept blog posts, and get rid of the showcase
- just

RE: Adding Examples for Plugins in the ReadMe

2016-03-29 Thread Parashuram N

I agree that we should not call these tests yet - they are just 
showcases/examples. Let me ask if the folks contributing the example are ok 
with contributing them to an Apache repo. The only hesitation they may have is 
that some of these examples may include services from a specific company, that 
may not make sense for adding to the Apache repo. 


-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Tuesday, March 29, 2016 10:31 AM
To: dev@cordova.apache.org
Subject: Re: Adding Examples for Plugins in the ReadMe

Calling these 'tests' to me is way out of scope, and very easily broken.

Adding a demo project to a plugin makes sense from both a development 
perspective AND a demonstration perspective. When developing, you need 
something to actually exercise the api you are writing, so putting this in the 
repo makes sense because it also allows someone else to use it to augment the 
apis, and provides a simple demonstration of the apis in use.

If you find yourself writing a demo/example that involves several plugins, then 
I would recommend we put all of those in a new repo: demos, examples, recipes, 
...




@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cpanarasi%40microsoft.com%7c3648ba39e890472fa5b808d357f7f5c1%7c72f988bf86f141af91ab2d7cd011db47%7c1=ZzCCjFTzOeyaPPvizeN3rZUSED706mcbi7qPL4xUYCo%3d

On Tue, Mar 29, 2016 at 7:09 AM, Carlos Santana 
wrote:

> "With great power comes great responsibilities"
>
> Adding this would require responsibilities of maintenance and up to 
> date working examples backed up with CI.
>
> In other words it's good idea to add docs with more complex examples 
> on how to use the plugin, some of them already are located in 
> mobilespec and plugin test cases, which give us confident that scenario are 
> in good shape.
> anything not already covered by CI would require to write test cases 
> to make sure examples continue to work with plugin and platforms changes.
>
> I would not put the content in a 3rd party Git Repo if it's something 
> that is part of the Apache Cordova project. Just request a INFRA 
> ticket for git repo to be created.
> We can start with one like Jesse said "cordova-demos" or "cordova-examples"
> either one is fine
>
>
>
>
> On Tue, Mar 29, 2016 at 12:56 AM Robert Posener 
> wrote:
>
> > Also...
> > These examples could be developed in such a way as to become part of 
> > the Cordova automated testing that is performed before a new version 
> > release, thereby adding more complex tests to the test suite.
> > You'll need to be careful of this anyway (ie, It would look pretty 
> > bad if these examples were copied by a Cordova app developer exactly 
> > as shown
> and
> > then they didn't work).
> >
> > Regards
> > *Rob Posener*
> > 0419 012 627
> >
> > On 29 March 2016 at 11:10, Parashuram N  wrote:
> >
> > > Including a demo folder in each plugin is good. If it is checked 
> > > in, we ensure that the example and the plugin use the same version of the 
> > > API.
> > > However, there may be some examples (typically in the file plugin 
> > > area) where a good scenario would mean using 2 plugins. What do we 
> > > do for
> that
> > ?
> > >
> > > -Original Message-
> > > From: Jesse [mailto:purplecabb...@gmail.com]
> > > Sent: Monday, March 28, 2016 4:51 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: Adding Examples for Plugins in the ReadMe
> > >
> > > Awesome.
> > > I typically include a demo folder with inside my plugin repos, but 
> > > this does mean that this demo code gets copied all over the place 
> > > if a user installs a plugin via git-repo or clone.
> > > I npm-ignore the demo folder so at least it does not go to npm ...
> > >
> > > Here's an example:
> > > https://github.com/purplecabbage/phonegap-plugin-sidebar/
> > >
> > >
> > > We could also create a cordova-demos repo in apache which has a 
> > > demo project for each core plugin.
> > >
> > > Cheers,
> > >   Jesse
> > >
> > >
> > >
> > > @purplecabbage
> > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01
> %7c01%7cpanarasi%40microsoft.com%7c11a99a9b7d574cb3752408d35763e384%7c
> 72f988bf86f141af91ab2d7cd011db47%7c1=7NrDVGF57%2f02i6dLIGOb9tKyJ
> bxoj8QgVa3cyTUAKLg%3d
> > >
> > > On Mon, Mar 28, 2016 at 4:26 PM, Robert Posener 
> > > 
> > > wrote:
> > >
> > > > +500
> > > >
> > > > Regards
> > > > *Rob Posener*
> > > > 0419 012 627
> > > >
> > > > On 29 March 2016 at 08:47, Parashuram N 
> > wrote:
> > > >
> > > > > Hey folks,
> > > > >
> > > > > At the moment, the sample code in our plugins is limited to 
> > > > > only show basic usage of the API. While this is great for 
> > > > > someone who
> has
> > > > > already written Cordova projects, I believe that we may need 
> > > > > more examples for folks who are just getting started with Cordova.
> > > > > To

RE: Cordova for browser extensions

2016-03-29 Thread Parashuram N

We do not have platforms that are specific for browser-extensions. Browser 
extensions in themselves may not blend well with the "plugin model" or don't 
really need a "bridge", two of the key things that Cordova provides.

Also, most modern browsers have "similar" ways to build extensions, so I am not 
sure if Cordova is the right tool for the job. 

-Original Message-
From: Tim Montague [mailto:tfmonta...@gmail.com] 
Sent: Tuesday, March 29, 2016 8:00 AM
To: dev@cordova.apache.org
Subject: Cordova for browser extensions

Is it possible to create browser extensions with Cordova?

> cordova platform add safari-extension
> cordova platform add chrome-extension
> cordova platform add explorer-extension

Best,
Tim
ᐧ

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-03-29 Thread riknoll

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/569#discussion_r57806664
  
--- Diff: www/.htaccess ---
@@ -18,29 +18,31 @@ RewriteEngine on
 #   pages to new pages.
 
 # 302 (temp):
-#   docs -> docs/en/latest/
-#   docs/-> docs/en/latest/
-#   docs/XX  -> docs/XX/latest/
-#   docs/XX/ -> docs/XX/latest/
+#   docs/  -> docs/[default language]/
+#   docs/XX-> docs/XX/
+#   docs/XX/   -> docs/XX/latest
+#   docs/XX/latest -> docs/XX/latest/
 #
 # NOTE:
-#   these can both apply, turning "/docs" into "/docs/en/latest/"
-RewriteRule ^.*docs/$ {{site.baseurl}}/docs/en/
-RewriteRule ^.*docs/(\w\w)/$ {{site.baseurl}}/docs/$1/latest/ [R=302,L]
-
-# 302 (temp):
-#   docs/XX/latest -> docs/XX/latest/
-RewriteRule ^.*docs/(\w\w)/latest$ {{site.baseurl}}/docs/$1/latest/ 
[R=302,L]
+#   these can all apply, turning "/docs" into "/docs/[default 
language]/latest/"
+RewriteRule ^.*docs/$ {{site.baseurl}}/docs/{{site.language}}/
+RewriteRule ^.*docs/(\w\w(?:-\w\w)?)$ {{site.baseurl}}/docs/$1/
--- End diff --

What is this rule doing? Looks like it is just adding a slash to the end of 
the URL?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10881 Add extra logging t...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/111


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10783: Media Plugin - Modify...

2016-03-29 Thread sarangan12

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203122183
  
Locally always...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-03-29 Thread dblotsky

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/569#issuecomment-203118863
  
@rakatyal @riknoll ping.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10881 Add extra logging t...

2016-03-29 Thread omefire

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/111

CB-10881 Add extra logging to gather more information about tests behavior



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-plugin-contacts CB-10881

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #111


commit 0d256c56cdafb788d82ecf645966f52f14b943c6
Author: Omar Mefire 
Date:   2016-03-29T19:51:46Z

CB-10881 Add extra logging to gather more information about tests behavior




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[CI] Status for 03/29

2016-03-29 Thread Dmitry Blotsky

Hey folks,

Here is the CI status for last week. Sorry that I missed sending it yesterday!

Build Status (# of test failures):
3 - Android on Windows
3 - Android on OS X
13 - iOS
0 - WP 8.1
0 - Windows

JIRAs that need attention:
- CB-10944: NoSuchMethodError in InAppBrowser plugin
- CB-10933: Windows-store-8 crash while running tests

Kindly,
Dmitry

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

2016-03-29 Thread riknoll

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-203109141
  
So, I've done a bit of testing on Marshmallow and it seems like this works 
pretty well. It does have the caveat of returning a `content://` URI, but that 
isn't a huge deal in my book. Currently, depending on the camera options you 
pass it is possible to get back either a `content://` URI, `file://` URI, or a 
file path back, so we aren't consistent at all anyway.

@jcesarmobile does this look alright to you? I plan to do some more testing 
on Jelly Bean in a bit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: CB-10884 Inappbrowser break...

2016-03-29 Thread jcesarmobile

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/53#issuecomment-203104592
  
LGTM

The bug I told you about on slack was already present, it's not caused by 
this code. I'll file a new issue for it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-29 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/163#discussion_r57799518
  
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -85,12 +85,12 @@ var handlers = {
 var src = obj.src;
 var dest = src;
 var type = obj.type;
+var targetDir = obj.targetDir || '';
 
 if(type === 'projectReference') {
-project.addProjectReference(path.join(plugin.dir,src), 
getTargetConditions(obj));
-}
-else {
-var targetDir = obj.targetDir || '';
+dest = path.join('plugins', plugin.id, targetDir, src);
+project.addProjectReference(dest, 
getTargetConditions(obj));
--- End diff --

Since this is common to both conditions, consider taking it out and putting 
it after the if else statement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-29 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/163#discussion_r57799378
  
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -85,12 +85,12 @@ var handlers = {
 var src = obj.src;
 var dest = src;
 var type = obj.type;
+var targetDir = obj.targetDir || '';
--- End diff --

Consider keeping this variable inside the else statement since it applies 
there only. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Update plugin.xml

2016-03-29 Thread riknoll

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/199#issuecomment-203098986
  
I believe we do actually require that permission even in API level 19+. The 
current code requires access to the photos directory, which is outside of the 
application storage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-29 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/163#discussion_r57798321
  
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -441,40 +451,47 @@ describe('windows project handler', function () {
 });
 });
 
-describe('of  elements', function () {
+   describe('of  elements', function () {
 // This could be separated into individual specs, but that 
results in a lot of copying and deleting the
 // project files, which is not needed.
 it('should remove from correct project files when conditions 
specified', function () {
+var curDir;
+curDir = __dirname;
+process.chdir(path.join(curDir, '..', 'fixtures', 
'testProj'));
+
 var frameworks = copyArray(valid_frameworks);
 
 frameworks.forEach(function(framework) {
 PluginHandler.getInstaller('framework')(framework, 
dummyPluginInfo, dummyProject);
 });
 
-var path = 'ItemGroup/Reference';
--- End diff --

Is there a need to rename this to path2?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-29 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/163#discussion_r57797833
  
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -164,6 +164,7 @@ describe('windows project handler', function () {
 }
 });
 
+   // throw JSON.stringify(elementToInstall, null, 2) + ' ' + 
JSON.stringify(dummyPluginInfo, null ,2) + ' ' + JSON.stringify(dummyProject, 
null, 2);
--- End diff --

What is the significance of this comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-29 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/163#discussion_r57797472
  
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -305,17 +306,25 @@ describe('windows project handler', function () {
 var frameworks = copyArray(valid_frameworks);
 
 it('should write to correct project files when conditions are 
specified', function () {
-var xpath = 'ProjectReference[@Include="' + 
winJoin(dummyplugin, 'src', 'windows', 'dummy1.vcxproj') + 
'"][@Condition="\'$(Platform)\'==\'x64\'"]';
+var curDir;
+var xpath;
+
+curDir = __dirname;
+process.chdir(path.join(curDir, '..', 'fixtures', 
'testProj'));
+
+xpath = 'ProjectReference[@Include="' + winJoin('..', 
'..', 'plugins', 'org.test.plugins.dummyplugin', 'src', 'windows', 
'dummy1.vcxproj') + '"][@Condition="\'$(Platform)\'==\'x64\'"]';
 validateInstalledProjects('framework', frameworks[6], 
xpath, ['all']);
 
-xpath = 'ProjectReference[@Include="' + 
winJoin(dummyplugin, 'src', 'windows', 'dummy2.vcxproj') + '"]';
+xpath = 'ProjectReference[@Include="' + winJoin('..', 
'..', 'plugins', 'org.test.plugins.dummyplugin', 'src', 'windows', 
'dummy2.vcxproj') + '"]';
 validateInstalledProjects('framework', frameworks[7], 
xpath, ['windows8']);
 
-xpath = 'ProjectReference[@Include="' + 
winJoin(dummyplugin, 'src', 'windows', 'dummy3.vcxproj') + '"]';
+xpath = 'ProjectReference[@Include="' + winJoin('..', 
'..', 'plugins', 'org.test.plugins.dummyplugin', 'src', 'windows', 
'dummy3.vcxproj') + '"]';
 validateInstalledProjects('framework', frameworks[8], 
xpath, ['windows', 'windows8', 'windows10']);
 
-xpath = 'ProjectReference[@Include="' + 
winJoin(dummyplugin, 'src', 'windows', 'dummy4.vcxproj') + 
'"][@Condition="\'$(Platform)\'==\'x86\'"]';
--- End diff --

Don't we need this condition anymore?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-windows patch release

2016-03-29 Thread Carlos Santana

Can you merge and include CB-10927 [1] ?

[1]: https://github.com/apache/cordova-windows/pull/163



On Tue, Mar 29, 2016 at 10:47 AM Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> Hi all
>
> We'd like to do a cordova-windows patch release to fix the following
> issues:
>   * CB-10845 Invalidate manifest cache in prepare (a4c673e3)
>   * CB-10714 Ignore case for --archs (49812d44)
>   * CB-10138 Adds missing plugin metadata to plugin_list module for
> Windows (45e5bd13)
>
> The proposed version number for this release is 4.3.2
>
> Does anyone have any reason to delay this release? Any other patches I
> need to include into this release?
>
> -
> Best regards, Vladimir
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: Does Cordova have a problem making developers happy?

2016-03-29 Thread Robert Posener

I did, but as my reply said, it wasn't showing up.

Regards
*Rob Posener*
0419 012 627

On 30 March 2016 at 05:01, Jesse  wrote:

> Good observations Julio, we should definitely talk to stack-overflow about
> the merged tags.
>
> Robert, you didn't send the pull request back to cordova/cordova-discuss,
> so no one could see it.  I have done so here:
> https://github.com/cordova/cordova-discuss/pull/35
>
>
>
>
> @purplecabbage
> risingj.com
>
> On Tue, Mar 29, 2016 at 4:29 AM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > Joe said:
> >
> > "I also find it interesting that people are hating on Cordova, and not
> > PhoneGap, Ionic, Taco or the other distributions."
> >
> > It's curious that Ionic has it's own tag, with about the same number of
> > questions that Cordova tag, but it's not on any of the lists (and it's
> not
> > because all Ionic questios are tagged with Cordova tag too, in fact, most
> > of them aren't)
> >
> > But when people is using Phonegap and add the Phonegap tag to the
> question,
> > stack overflow replaces it with a Cordova tag because they decided long
> > time ago that they were synonyms, so you can't use Phonegap tag and we
> > can't be sure if they are using Cordova or Phonegap unless they tell it
> on
> > the question.
> >
> > I think that's a mistake by stack overflow part, because people using
> > phonegap doesn't follow same workflow that people using cordova as
> Phonegap
> > docs are different, they mostly use the developer app to test, and
> phonegap
> > users might have different problems.
> >
> > There are a lot of questions about  "- 3rd party plugin isn't
> > working on my app", and the problem is they are using the phonegap
> > developer app. But they don't mention that they are using phonegap, they
> > just add the phonegap tag, and stack overflow replaces it with a Cordova
> > tag. They don't mention that they are using the Phonegap developer app
> > neither because they think that's the way of running Phonegap apps. I see
> > at least one of those everyday on stack overflow or some other forums.
> >
> > I've filed a few issues on the phonegap docs page so they can make
> clearer
> > to users that when using the phonegap developer app they are not really
> > running their app, and they have some issues open to list the developer
> app
> > limitations. Once they are addressed, maybe the developers are a bit
> > happier.
> >
> > But I'm not sure what to do about the stack overflow synonym, should we
> > tell them to remove the synonym so people can use Phonegap and Cordova as
> > different tags?
> >
> >
> >
> >
> > 2016-03-29 8:23 GMT+02:00 Robert Posener :
> >
> > > I think I have created a discussion, but it is not showing up... yet
> > > another frustrations!
> > >
> > > Rob
> > >
> > > Regards
> > > *Rob Posener*
> > > 0419 012 627
> > >
> > > On 29 March 2016 at 16:48, Parashuram N 
> wrote:
> > >
> > > > I am not sure if everyone got the attachment. Rob, can I request  you
> > to
> > > > create an issue on https://github.com/cordova/cordova-discuss so
> that
> > we
> > > > could start following up on specific issues there ?
> > > >
> > > > From: Robert Posener 
> > > > Reply-To: "dev@cordova.apache.org" 
> > > > Date: Monday, March 28, 2016 at 10:08 PM
> > > > To: "dev@cordova.apache.org" 
> > > > Subject: Re: Does Cordova have a problem making developers happy?
> > > >
> > > > Gerday all,
> > > > Because of the serious nature of this thread, I have produced a
> 6-page
> > > > contribution of issues together with recommendations for fixing them
> in
> > > the
> > > > attachment to this email.
> > > >
> > > > Regards
> > > >
> > > > Rob Posener
> > > >
> > > > Regards
> > > > Rob Posener
> > > > 0419 012 627
> > > >
> > > > On 19 March 2016 at 08:31, Joe Bowser  > > bows...@gmail.com>> wrote:
> > > > I don't entirely agree with this, since usually we do respond.  We
> > don't
> > > > just accept things that get thrown at us, which I think is the
> > > expectation.
> > > >
> > > > I think we need to make sure we come to some resolution and actually
> > > solve
> > > > the problem in a timely manner.  We've had both extremes of
> discussing
> > a
> > > > problem to death and cowboy coding, and neither extreme works well.
> > > >
> > > > As for getting there, I have no idea.  Any thoughts?
> > > >
> > > > On Fri, Mar 18, 2016, 2:23 PM Raghav Katyal  > > > > wrote:
> > > >
> > > > > I guess responding to JIRA quickly and acting on contributors' PRs
> > > could
> > > > > be candidates for improvement.
> > > > >
> > > > > -Original Message-
> > > > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com > > > nikhi...@microsoft.com>]
> > > > > Sent: Friday, March 18, 2016 11:18 AM
> > > > > To:

Re: [DISCUSS] Curating Apps

2016-03-29 Thread Dmitry Blotsky

I put apps and tools in the same bucket when it came to adding them to the 
site. I interpreted our last discussion as, “we’ve gotten enough; close the 
submissions now”. If we’re cool to still add this tool, then let’s just add it.

Kindly,
Dmitry

On Mar 29, 2016, at 7:53 AM, julio cesar sanchez 
> wrote:

I meant rejecting because it was an old PR and it was rejected now.

But even if there is no button, people can still send PRs. It's less
likely, but still possible. And as most of the topic here was about apps, I
wanted to know if we have an official statement for tools.

So, if I review this tool now and find it useful, I should open a vote
thread before adding it, right? Should it get 3 positive votes as releases?

2016-03-29 16:02 GMT+02:00 Carlos Santana 
>:

Julio "rejecting" sounds so harsh

Since we removed the "add app" and "add tool" from the webpage, there is no
process to submit something to be accepted or rejected

I think right now my opinion is that a PMC member would need to do the leg
work to review, propose something to be added, and do the work of adding
it. PMC members always look out for the best interest of the project, but
as always we have lazy consensus it should bring up to other PMC members to
see if any would vote -1 for any good reason to no accept the content to be
added.

Like I said this is only my opinion of one way of getting something added
to tools or apps on the website.

On Tue, Mar 29, 2016 at 9:38 AM julio cesar sanchez <
jcesarmob...@gmail.com>
wrote:

I bring the topic back again because recently a tool was rejected and the
author mailed us asking (and we have not answered him yet)

So, are we rejecting tools too?

The original topic was "[DISCUSS] Curating Apps" and all the messages
were
about apps, except this one from Steve that mentions removing "add a
tool"
and "add a plugin"

"YES! Removing the "add a tool" and "add a plugin" is the best way to go.
Those PRs require way to much management. Leave it up to PMC to nominate
apps."

2015-10-24 3:24 GMT+02:00 Dmitry Blotsky 
>:

Sure, I’m also down for removing the “add your app” option. Switching
to
putting apps up only at our own discretion makes sense. My only concern
is
that I personally haven’t tried out many Cordova apps, so I would
expect
us
to have a shortage of apps this way. But if other PMC members have apps
to
suggest, then we should be good.

To move forward with Carlos’ proposal, we ought to:
- curate the existing list
- have someone explain the change of policy to the PRs still open

Any takers for those two tasks?

Kindly,
Dmitry

On Oct 23, 2015, at 6:01 PM, Steven Gill 
>
wrote:

YES! Removing the "add a tool" and "add a plugin" is the best way to
go.
Those PRs require way to much management. Leave it up to PMC to
nominate
apps.

On Fri, Oct 23, 2015 at 5:41 PM, Nikhil Khandelwal <
nikhi...@microsoft.com>
wrote:

I like Carlos' proposal. Reviewing PRs for these apps and judging by
whatever criteria we finally decide (however objective/subjective)
will
not
be worth our time. The volume of PRs over the last couple of weeks
has
been
quite significant in this area.

At the end of the day, we just need 5-10 showcase apps.

-Nikhil

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Friday, October 23, 2015 5:37 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Curating Apps

I think we make it more simpler, a PMC member to propose to add an
app
that he/she tried out and feels that it deserves to be show case as
a
good
example of a great Cordova App.
- remove the "add your app"
- PMC members mails the list, that he evaluated the app and a short
description on why to added and he is planning to added, and ask if
someone
opposed with a -1
- Like Joe said, we don't need a tons of Apps, just a few will
satisfy
the
goal
- The Apache way, if there are no -1 app get's added.

On Wed, Oct 21, 2015 at 7:27 PM Dmitry Blotsky <
dblot...@microsoft.com>
wrote:

Sounds like we’ve got some (potentially mutually exclusive) points:
- request detailed app descriptions from submitters
- curate based on detailed criteria
- curate based on loose criteria
- only accept blog posts, and get rid of the showcase
- just accept all requests

Should this be a proposal on cordova-discuss? Or does someone feel
like we have a consensus? The ultimate goal is to have something
that
displays good use of Cordova. I’d personally like to go with the
easiest way to achieve this.

Kindly,
Dmitry

On Oct 19, 2015, at 1:28 PM, Joerg Holz 
> wrote:

I like the slogan: "submit something that helps other developers
build a

Re: Does Cordova have a problem making developers happy?

2016-03-29 Thread Jesse

Good observations Julio, we should definitely talk to stack-overflow about
the merged tags.

Robert, you didn't send the pull request back to cordova/cordova-discuss,
so no one could see it.  I have done so here:
https://github.com/cordova/cordova-discuss/pull/35




@purplecabbage
risingj.com

On Tue, Mar 29, 2016 at 4:29 AM, julio cesar sanchez  wrote:

> Joe said:
>
> "I also find it interesting that people are hating on Cordova, and not
> PhoneGap, Ionic, Taco or the other distributions."
>
> It's curious that Ionic has it's own tag, with about the same number of
> questions that Cordova tag, but it's not on any of the lists (and it's not
> because all Ionic questios are tagged with Cordova tag too, in fact, most
> of them aren't)
>
> But when people is using Phonegap and add the Phonegap tag to the question,
> stack overflow replaces it with a Cordova tag because they decided long
> time ago that they were synonyms, so you can't use Phonegap tag and we
> can't be sure if they are using Cordova or Phonegap unless they tell it on
> the question.
>
> I think that's a mistake by stack overflow part, because people using
> phonegap doesn't follow same workflow that people using cordova as Phonegap
> docs are different, they mostly use the developer app to test, and phonegap
> users might have different problems.
>
> There are a lot of questions about  "- 3rd party plugin isn't
> working on my app", and the problem is they are using the phonegap
> developer app. But they don't mention that they are using phonegap, they
> just add the phonegap tag, and stack overflow replaces it with a Cordova
> tag. They don't mention that they are using the Phonegap developer app
> neither because they think that's the way of running Phonegap apps. I see
> at least one of those everyday on stack overflow or some other forums.
>
> I've filed a few issues on the phonegap docs page so they can make clearer
> to users that when using the phonegap developer app they are not really
> running their app, and they have some issues open to list the developer app
> limitations. Once they are addressed, maybe the developers are a bit
> happier.
>
> But I'm not sure what to do about the stack overflow synonym, should we
> tell them to remove the synonym so people can use Phonegap and Cordova as
> different tags?
>
>
>
>
> 2016-03-29 8:23 GMT+02:00 Robert Posener :
>
> > I think I have created a discussion, but it is not showing up... yet
> > another frustrations!
> >
> > Rob
> >
> > Regards
> > *Rob Posener*
> > 0419 012 627
> >
> > On 29 March 2016 at 16:48, Parashuram N  wrote:
> >
> > > I am not sure if everyone got the attachment. Rob, can I request  you
> to
> > > create an issue on https://github.com/cordova/cordova-discuss so that
> we
> > > could start following up on specific issues there ?
> > >
> > > From: Robert Posener 
> > > Reply-To: "dev@cordova.apache.org" 
> > > Date: Monday, March 28, 2016 at 10:08 PM
> > > To: "dev@cordova.apache.org" 
> > > Subject: Re: Does Cordova have a problem making developers happy?
> > >
> > > Gerday all,
> > > Because of the serious nature of this thread, I have produced a 6-page
> > > contribution of issues together with recommendations for fixing them in
> > the
> > > attachment to this email.
> > >
> > > Regards
> > >
> > > Rob Posener
> > >
> > > Regards
> > > Rob Posener
> > > 0419 012 627
> > >
> > > On 19 March 2016 at 08:31, Joe Bowser  > bows...@gmail.com>> wrote:
> > > I don't entirely agree with this, since usually we do respond.  We
> don't
> > > just accept things that get thrown at us, which I think is the
> > expectation.
> > >
> > > I think we need to make sure we come to some resolution and actually
> > solve
> > > the problem in a timely manner.  We've had both extremes of discussing
> a
> > > problem to death and cowboy coding, and neither extreme works well.
> > >
> > > As for getting there, I have no idea.  Any thoughts?
> > >
> > > On Fri, Mar 18, 2016, 2:23 PM Raghav Katyal  > > > wrote:
> > >
> > > > I guess responding to JIRA quickly and acting on contributors' PRs
> > could
> > > > be candidates for improvement.
> > > >
> > > > -Original Message-
> > > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com > > nikhi...@microsoft.com>]
> > > > Sent: Friday, March 18, 2016 11:18 AM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: Does Cordova have a problem making developers happy?
> > > >
> > > > I have been guilty of not spending too much time on stackoverflow
> > > > answering questions. It’s on my TODO list. For those who have, what
> are
> > > > there general themes of improvement here that will make a huge
> impact?
> > > >
> > > > I remember Julio summarized this last year [1] and I believe we

Cordova for browser extensions

2016-03-29 Thread Tim Montague

Is it possible to create browser extensions with Cordova?

> cordova platform add safari-extension
> cordova platform add chrome-extension
> cordova platform add explorer-extension

Best,
Tim
ᐧ

[GitHub] cordova-plugin-media-capture pull request: Removing global state a...

2016-03-29 Thread riknoll

Github user riknoll commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/59#discussion_r57764840
  
--- Diff: src/android/Capture.java ---
@@ -250,13 +304,17 @@ private static void createWritableFile(File file) 
throws IOException {
  * Sets up an intent to capture video.  Result handled by 
onActivityResult()
  */
 private void captureVideo(int duration, int quality) {
-Intent intent = new 
Intent(android.provider.MediaStore.ACTION_VIDEO_CAPTURE);
+if(cameraPermissionInManifest && 
!PermissionHelper.hasPermission(this, Manifest.permission.CAMERA)) {
+PermissionHelper.requestPermission(this, CAPTURE_VIDEO_SEC, 
Manifest.permission.CAMERA);
+} else {
+Intent intent = new 
Intent(android.provider.MediaStore.ACTION_VIDEO_CAPTURE);
 
-if(Build.VERSION.SDK_INT > 7){
-intent.putExtra("android.intent.extra.durationLimit", 
duration);
-intent.putExtra("android.intent.extra.videoQuality", quality);
+if(Build.VERSION.SDK_INT > 7){
--- End diff --

Oh, wow, I think I glanced over that! I agree that we should remove it. 
I'll update the PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Adding Examples for Plugins in the ReadMe

2016-03-29 Thread Jesse

Calling these 'tests' to me is way out of scope, and very easily broken.

Adding a demo project to a plugin makes sense from both a development
perspective AND a demonstration perspective. When developing, you need
something to actually exercise the api you are writing, so putting this in
the repo makes sense because it also allows someone else to use it to
augment the apis, and provides a simple demonstration of the apis in use.

If you find yourself writing a demo/example that involves several plugins,
then I would recommend we put all of those in a new repo: demos, examples,
recipes, ...




@purplecabbage
risingj.com

On Tue, Mar 29, 2016 at 7:09 AM, Carlos Santana 
wrote:

> "With great power comes great responsibilities"
>
> Adding this would require responsibilities of maintenance and up to date
> working examples backed up with CI.
>
> In other words it's good idea to add docs with more complex examples on how
> to use the plugin, some of them already are located in mobilespec and
> plugin test cases, which give us confident that scenario are in good shape.
> anything not already covered by CI would require to write test cases to
> make sure examples continue to work with plugin and platforms changes.
>
> I would not put the content in a 3rd party Git Repo if it's something that
> is part of the Apache Cordova project. Just request a INFRA ticket for git
> repo to be created.
> We can start with one like Jesse said "cordova-demos" or "cordova-examples"
> either one is fine
>
>
>
>
> On Tue, Mar 29, 2016 at 12:56 AM Robert Posener 
> wrote:
>
> > Also...
> > These examples could be developed in such a way as to become part of the
> > Cordova automated testing that is performed before a new version release,
> > thereby adding more complex tests to the test suite.
> > You'll need to be careful of this anyway (ie, It would look pretty bad if
> > these examples were copied by a Cordova app developer exactly as shown
> and
> > then they didn't work).
> >
> > Regards
> > *Rob Posener*
> > 0419 012 627
> >
> > On 29 March 2016 at 11:10, Parashuram N  wrote:
> >
> > > Including a demo folder in each plugin is good. If it is checked in, we
> > > ensure that the example and the plugin use the same version of the API.
> > > However, there may be some examples (typically in the file plugin area)
> > > where a good scenario would mean using 2 plugins. What do we do for
> that
> > ?
> > >
> > > -Original Message-
> > > From: Jesse [mailto:purplecabb...@gmail.com]
> > > Sent: Monday, March 28, 2016 4:51 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: Adding Examples for Plugins in the ReadMe
> > >
> > > Awesome.
> > > I typically include a demo folder with inside my plugin repos, but this
> > > does mean that this demo code gets copied all over the place if a user
> > > installs a plugin via git-repo or clone.
> > > I npm-ignore the demo folder so at least it does not go to npm ...
> > >
> > > Here's an example:
> > > https://github.com/purplecabbage/phonegap-plugin-sidebar/
> > >
> > >
> > > We could also create a cordova-demos repo in apache which has a demo
> > > project for each core plugin.
> > >
> > > Cheers,
> > >   Jesse
> > >
> > >
> > >
> > > @purplecabbage
> > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cpanarasi%40microsoft.com%7c11a99a9b7d574cb3752408d35763e384%7c72f988bf86f141af91ab2d7cd011db47%7c1=7NrDVGF57%2f02i6dLIGOb9tKyJbxoj8QgVa3cyTUAKLg%3d
> > >
> > > On Mon, Mar 28, 2016 at 4:26 PM, Robert Posener 
> > > wrote:
> > >
> > > > +500
> > > >
> > > > Regards
> > > > *Rob Posener*
> > > > 0419 012 627
> > > >
> > > > On 29 March 2016 at 08:47, Parashuram N 
> > wrote:
> > > >
> > > > > Hey folks,
> > > > >
> > > > > At the moment, the sample code in our plugins is limited to only
> > > > > show basic usage of the API. While this is great for someone who
> has
> > > > > already written Cordova projects, I believe that we may need more
> > > > > examples for folks who are just getting started with Cordova.
> > > > > To improve our documentation, Norm has sent out a pull request with
> > > > > additional examples that show the typical use cases for the plugins
> > > > > -
> https://github.com/apache/cordova-plugin-geolocation/pull/74/files
> > > > >
> > > > > This PR is the first in a set of work that we would like to do, to
> > > > improve
> > > > > documentation for plugins. A few questions to the community about
> > > > > this direction
> > > > >
> > > > >
> > > > > 1.   Is it ok to include this as a part of the README ? That
> > would
> > > > > increase the visibility of the examples much more. We could have a
> > > > > "REFERENCE" section that is for quick reference, and then this set
> > > > > of detailed examples showing how the plugins work. Anyone have
> > > > > objections to that ? Note that the README would be longer,

[GitHub] cordova-plugin-media-capture pull request: Removing global state a...

2016-03-29 Thread infil00p

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/59#issuecomment-203012656
  
LGTM. Don't be afraid to delete conditionals that check for things that are 
below the minimum supported API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: Removing global state a...

2016-03-29 Thread infil00p

Github user infil00p commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/59#discussion_r57764130
  
--- Diff: src/android/Capture.java ---
@@ -250,13 +304,17 @@ private static void createWritableFile(File file) 
throws IOException {
  * Sets up an intent to capture video.  Result handled by 
onActivityResult()
  */
 private void captureVideo(int duration, int quality) {
-Intent intent = new 
Intent(android.provider.MediaStore.ACTION_VIDEO_CAPTURE);
+if(cameraPermissionInManifest && 
!PermissionHelper.hasPermission(this, Manifest.permission.CAMERA)) {
+PermissionHelper.requestPermission(this, CAPTURE_VIDEO_SEC, 
Manifest.permission.CAMERA);
+} else {
+Intent intent = new 
Intent(android.provider.MediaStore.ACTION_VIDEO_CAPTURE);
 
-if(Build.VERSION.SDK_INT > 7){
-intent.putExtra("android.intent.extra.durationLimit", 
duration);
-intent.putExtra("android.intent.extra.videoQuality", quality);
+if(Build.VERSION.SDK_INT > 7){
--- End diff --

You could have gotten away with deleting this.  SDK level 7? Wow, the 
Cordova codebase is OLD


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10977 android: Removing globa...

2016-03-29 Thread riknoll

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/174#discussion_r57762270
  
--- Diff: src/android/FileUtils.java ---
@@ -1151,51 +1140,55 @@ private long truncateFile(String srcURLstr, long 
size) throws FileNotFoundExcept
 
 public void onRequestPermissionResult(int requestCode, String[] 
permissions,
   int[] grantResults) throws 
JSONException {
-for(int r:grantResults)
-{
-if(r == PackageManager.PERMISSION_DENIED)
+
+final PendingRequests.Request req = 
pendingRequests.getAndRemove(requestCode);
+if (req != null) {
+for(int r:grantResults)
 {
-callback.sendPluginResult(new 
PluginResult(PluginResult.Status.ERROR, SECURITY_ERR));
+if(r == PackageManager.PERMISSION_DENIED)
+{
+req.getCallbackContext().sendPluginResult(new 
PluginResult(PluginResult.Status.ERROR, SECURITY_ERR));
--- End diff --

Ha, yep! Good catch! It doesn't look like there was a return there before 
either so I wonder how that worked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10977 android: Removing globa...

2016-03-29 Thread jasongin

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/174#discussion_r57761716
  
--- Diff: src/android/FileUtils.java ---
@@ -1151,51 +1140,55 @@ private long truncateFile(String srcURLstr, long 
size) throws FileNotFoundExcept
 
 public void onRequestPermissionResult(int requestCode, String[] 
permissions,
   int[] grantResults) throws 
JSONException {
-for(int r:grantResults)
-{
-if(r == PackageManager.PERMISSION_DENIED)
+
+final PendingRequests.Request req = 
pendingRequests.getAndRemove(requestCode);
+if (req != null) {
+for(int r:grantResults)
 {
-callback.sendPluginResult(new 
PluginResult(PluginResult.Status.ERROR, SECURITY_ERR));
+if(r == PackageManager.PERMISSION_DENIED)
+{
+req.getCallbackContext().sendPluginResult(new 
PluginResult(PluginResult.Status.ERROR, SECURITY_ERR));
--- End diff --

Should there be a return after this line?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-29 Thread csantanapr

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-windows/pull/163#issuecomment-202988290
  
ping @rakatyal can you review this PR and merge if its good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Update plugin.xml

2016-03-29 Thread mehmetcodes

GitHub user mehmetcodes opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/199

Update plugin.xml

In principle Cordova should not use a permission where it is no longer 
relevant as it might leave things less secure.

You can see this documentation here 
http://developer.android.com/guide/topics/manifest/uses-permission-element.html

Note the following in the documentation:



android:maxSdkVersion
The highest API level at which this permission should be granted to your 
app. Setting this attribute is useful if the permission your app requires is no 
longer needed beginning at a certain API level.
For example, beginning with Android 4.4 (API level 19), it's no longer 
necessary for your app to request the WRITE_EXTERNAL_STORAGE permission when 
your app wants to write to its own application-specific directories on external 
storage (the directories provided by getExternalFilesDir()). However, the 
permission is required for API level 18 and lower. So you can declare that this 
permission is needed only up to API level 18 with a declaration such as this:


This way, beginning with API level 19, the system will no longer grant your 
app the WRITE_EXTERNAL_STORAGE permission.

This attribute was added in API level 19.

==

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mehmetcodes/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #199


commit f20d1d5c8f59766bdb67ec2e25d7dacf19cbd91c
Author: mehmetcodes 
Date:   2016-03-29T15:56:43Z

Update plugin.xml

In principle Cordova should not use a permission where it is no longer 
relevant as it might leave things less secure.

You can see this documentation here 
http://developer.android.com/guide/topics/manifest/uses-permission-element.html

Note the following in the documentation:



android:maxSdkVersion
The highest API level at which this permission should be granted to your 
app. Setting this attribute is useful if the permission your app requires is no 
longer needed beginning at a certain API level.
For example, beginning with Android 4.4 (API level 19), it's no longer 
necessary for your app to request the WRITE_EXTERNAL_STORAGE permission when 
your app wants to write to its own application-specific directories on external 
storage (the directories provided by getExternalFilesDir()). However, the 
permission is required for API level 18 and lower. So you can declare that this 
permission is needed only up to API level 18 with a declaration such as this:


This way, beginning with API level 19, the system will no longer grant your 
app the WRITE_EXTERNAL_STORAGE permission.

This attribute was added in API level 19.

==




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Curating Apps

2016-03-29 Thread julio cesar sanchez

I meant rejecting because it was an old PR and it was rejected now.

But even if there is no button, people can still send PRs. It's less
likely, but still possible. And as most of the topic here was about apps, I
wanted to know if we have an official statement for tools.


So, if I review this tool now and find it useful, I should open a vote
thread before adding it, right? Should it get 3 positive votes as releases?




2016-03-29 16:02 GMT+02:00 Carlos Santana :

> Julio "rejecting" sounds so harsh
>
> Since we removed the "add app" and "add tool" from the webpage, there is no
> process to submit something to be accepted or rejected
>
> I think right now my opinion is that a PMC member would need to do the leg
> work to review, propose something to be added, and do the work of adding
> it. PMC members always look out for the best interest of the project, but
> as always we have lazy consensus it should bring up to other PMC members to
> see if any would vote -1 for any good reason to no accept the content to be
> added.
>
> Like I said this is only my opinion of one way of getting something added
> to tools or apps on the website.
>
>
> On Tue, Mar 29, 2016 at 9:38 AM julio cesar sanchez <
> jcesarmob...@gmail.com>
> wrote:
>
> > I bring the topic back again because recently a tool was rejected and the
> > author mailed us asking (and we have not answered him yet)
> >
> > So, are we rejecting tools too?
> >
> > The original topic was "[DISCUSS] Curating Apps" and all the messages
> were
> > about apps, except this one from Steve that mentions removing "add a
> tool"
> > and "add a plugin"
> >
> > "YES! Removing the "add a tool" and "add a plugin" is the best way to go.
> > Those PRs require way to much management. Leave it up to PMC to nominate
> > apps."
> >
> >
> >
> >
> >
> > 2015-10-24 3:24 GMT+02:00 Dmitry Blotsky :
> >
> > > Sure, I’m also down for removing the “add your app” option. Switching
> to
> > > putting apps up only at our own discretion makes sense. My only concern
> > is
> > > that I personally haven’t tried out many Cordova apps, so I would
> expect
> > us
> > > to have a shortage of apps this way. But if other PMC members have apps
> > to
> > > suggest, then we should be good.
> > >
> > > To move forward with Carlos’ proposal, we ought to:
> > > - curate the existing list
> > > - have someone explain the change of policy to the PRs still open
> > >
> > > Any takers for those two tasks?
> > >
> > > Kindly,
> > > Dmitry
> > >
> > > > On Oct 23, 2015, at 6:01 PM, Steven Gill 
> > wrote:
> > > >
> > > > YES! Removing the "add a tool" and "add a plugin" is the best way to
> > go.
> > > > Those PRs require way to much management. Leave it up to PMC to
> > nominate
> > > > apps.
> > > >
> > > > On Fri, Oct 23, 2015 at 5:41 PM, Nikhil Khandelwal <
> > > nikhi...@microsoft.com>
> > > > wrote:
> > > >
> > > >> I like Carlos' proposal. Reviewing PRs for these apps and judging by
> > > >> whatever criteria we finally decide (however objective/subjective)
> > will
> > > not
> > > >> be worth our time. The volume of PRs over the last couple of weeks
> has
> > > been
> > > >> quite significant in this area.
> > > >>
> > > >> At the end of the day, we just need 5-10 showcase apps.
> > > >>
> > > >> -Nikhil
> > > >>
> > > >> -Original Message-
> > > >> From: Carlos Santana [mailto:csantan...@gmail.com]
> > > >> Sent: Friday, October 23, 2015 5:37 PM
> > > >> To: dev@cordova.apache.org
> > > >> Subject: Re: [DISCUSS] Curating Apps
> > > >>
> > > >> I think we make it more simpler, a PMC member to propose to add an
> app
> > > >> that he/she tried out and feels that it deserves to be show case as
> a
> > > good
> > > >> example of a great Cordova App.
> > > >> - remove the "add your app"
> > > >> - PMC members mails the list, that he evaluated the app and a short
> > > >> description on why to added and he is planning to added, and ask if
> > > someone
> > > >> opposed with a -1
> > > >> - Like Joe said, we don't need a tons of Apps, just a few will
> satisfy
> > > the
> > > >> goal
> > > >> - The Apache way, if there are no -1 app get's added.
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> On Wed, Oct 21, 2015 at 7:27 PM Dmitry Blotsky <
> > dblot...@microsoft.com>
> > > >> wrote:
> > > >>
> > > >>> Sounds like we’ve got some (potentially mutually exclusive) points:
> > > >>> - request detailed app descriptions from submitters
> > > >>> - curate based on detailed criteria
> > > >>> - curate based on loose criteria
> > > >>> - only accept blog posts, and get rid of the showcase
> > > >>> - just accept all requests
> > > >>>
> > > >>> Should this be a proposal on cordova-discuss? Or does someone feel
> > > >>> like we have a consensus? The ultimate goal is to have something
> that
> > > >>> displays good use of Cordova. I’d personally like to go with the
> > > >>> easiest way to achieve this.
> > > >>>
> > > >>> Kindly,
> > >

[DISCUSS] cordova-windows patch release

2016-03-29 Thread Vladimir Kotikov (Akvelon)

Hi all

We'd like to do a cordova-windows patch release to fix the following issues:
  * CB-10845 Invalidate manifest cache in prepare (a4c673e3)
  * CB-10714 Ignore case for --archs (49812d44)
  * CB-10138 Adds missing plugin metadata to plugin_list module for Windows 
(45e5bd13)

The proposed version number for this release is 4.3.2

Does anyone have any reason to delay this release? Any other patches I need to 
include into this release?

-
Best regards, Vladimir

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] Tools release attempt 2

2016-03-29 Thread Vladimir Kotikov (Akvelon)

Please review and vote on this Tools Release by replying to this email (and 
keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10980
Both tools have been published to dist/dev: 
https://dist.apache.org/repos/dist/dev/cordova/CB-10980

The packages were published from their corresponding git tags:
cordova-lib: 6.1.1 (107e273647)
cordova-plugman: 1.2.1 (f05a7ef8cf)
cordova-cli: 6.1.1 (8e730ac376)

Upon a successful vote I will upload the archives to dist/, publish them to 
NPM, and post the corresponding blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ensured continuous build was green when repos were tagged
* Created and ran mobilespec app on Android and Windows
* Ran mobilespec app with --browserify flag on Android
* Ensured unit tests are passing for cli, lib and plugman

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

2016-03-29 Thread mikaelkindborg

Github user mikaelkindborg commented on the pull request:

https://github.com/apache/cordova-docs/pull/410#issuecomment-202922042
  
@jcesarmobile Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Adding Examples for Plugins in the ReadMe

2016-03-29 Thread Carlos Santana

"With great power comes great responsibilities"

Adding this would require responsibilities of maintenance and up to date
working examples backed up with CI.

In other words it's good idea to add docs with more complex examples on how
to use the plugin, some of them already are located in mobilespec and
plugin test cases, which give us confident that scenario are in good shape.
anything not already covered by CI would require to write test cases to
make sure examples continue to work with plugin and platforms changes.

I would not put the content in a 3rd party Git Repo if it's something that
is part of the Apache Cordova project. Just request a INFRA ticket for git
repo to be created.
We can start with one like Jesse said "cordova-demos" or "cordova-examples"
either one is fine




On Tue, Mar 29, 2016 at 12:56 AM Robert Posener  wrote:

> Also...
> These examples could be developed in such a way as to become part of the
> Cordova automated testing that is performed before a new version release,
> thereby adding more complex tests to the test suite.
> You'll need to be careful of this anyway (ie, It would look pretty bad if
> these examples were copied by a Cordova app developer exactly as shown and
> then they didn't work).
>
> Regards
> *Rob Posener*
> 0419 012 627
>
> On 29 March 2016 at 11:10, Parashuram N  wrote:
>
> > Including a demo folder in each plugin is good. If it is checked in, we
> > ensure that the example and the plugin use the same version of the API.
> > However, there may be some examples (typically in the file plugin area)
> > where a good scenario would mean using 2 plugins. What do we do for that
> ?
> >
> > -Original Message-
> > From: Jesse [mailto:purplecabb...@gmail.com]
> > Sent: Monday, March 28, 2016 4:51 PM
> > To: dev@cordova.apache.org
> > Subject: Re: Adding Examples for Plugins in the ReadMe
> >
> > Awesome.
> > I typically include a demo folder with inside my plugin repos, but this
> > does mean that this demo code gets copied all over the place if a user
> > installs a plugin via git-repo or clone.
> > I npm-ignore the demo folder so at least it does not go to npm ...
> >
> > Here's an example:
> > https://github.com/purplecabbage/phonegap-plugin-sidebar/
> >
> >
> > We could also create a cordova-demos repo in apache which has a demo
> > project for each core plugin.
> >
> > Cheers,
> >   Jesse
> >
> >
> >
> > @purplecabbage
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cpanarasi%40microsoft.com%7c11a99a9b7d574cb3752408d35763e384%7c72f988bf86f141af91ab2d7cd011db47%7c1=7NrDVGF57%2f02i6dLIGOb9tKyJbxoj8QgVa3cyTUAKLg%3d
> >
> > On Mon, Mar 28, 2016 at 4:26 PM, Robert Posener 
> > wrote:
> >
> > > +500
> > >
> > > Regards
> > > *Rob Posener*
> > > 0419 012 627
> > >
> > > On 29 March 2016 at 08:47, Parashuram N 
> wrote:
> > >
> > > > Hey folks,
> > > >
> > > > At the moment, the sample code in our plugins is limited to only
> > > > show basic usage of the API. While this is great for someone who has
> > > > already written Cordova projects, I believe that we may need more
> > > > examples for folks who are just getting started with Cordova.
> > > > To improve our documentation, Norm has sent out a pull request with
> > > > additional examples that show the typical use cases for the plugins
> > > > - https://github.com/apache/cordova-plugin-geolocation/pull/74/files
> > > >
> > > > This PR is the first in a set of work that we would like to do, to
> > > improve
> > > > documentation for plugins. A few questions to the community about
> > > > this direction
> > > >
> > > >
> > > > 1.   Is it ok to include this as a part of the README ? That
> would
> > > > increase the visibility of the examples much more. We could have a
> > > > "REFERENCE" section that is for quick reference, and then this set
> > > > of detailed examples showing how the plugins work. Anyone have
> > > > objections to that ? Note that the README would be longer, but I
> > > > think that should be
> > > ok.
> > > > Also note that the README is imported into the Cordova docs, so
> > > > these examples will also show up there
> > > >
> > > > 2.   Some of the example have links to full projects that use the
> > > > plugin. We did not find a place on the Apache github organization to
> > > > put
> > > it
> > > > all up, so they currently reside in a Microsoft-github organization.
> > > > Is that ok ? Is there a place to put full fledged Cordova samples on
> > > > the Apache repos ?
> > > >
> > >
> >
>

Re: [DISCUSS] Curating Apps

2016-03-29 Thread Carlos Santana

Julio "rejecting" sounds so harsh

Since we removed the "add app" and "add tool" from the webpage, there is no
process to submit something to be accepted or rejected

I think right now my opinion is that a PMC member would need to do the leg
work to review, propose something to be added, and do the work of adding
it. PMC members always look out for the best interest of the project, but
as always we have lazy consensus it should bring up to other PMC members to
see if any would vote -1 for any good reason to no accept the content to be
added.

Like I said this is only my opinion of one way of getting something added
to tools or apps on the website.


On Tue, Mar 29, 2016 at 9:38 AM julio cesar sanchez 
wrote:

> I bring the topic back again because recently a tool was rejected and the
> author mailed us asking (and we have not answered him yet)
>
> So, are we rejecting tools too?
>
> The original topic was "[DISCUSS] Curating Apps" and all the messages were
> about apps, except this one from Steve that mentions removing "add a tool"
> and "add a plugin"
>
> "YES! Removing the "add a tool" and "add a plugin" is the best way to go.
> Those PRs require way to much management. Leave it up to PMC to nominate
> apps."
>
>
>
>
>
> 2015-10-24 3:24 GMT+02:00 Dmitry Blotsky :
>
> > Sure, I’m also down for removing the “add your app” option. Switching to
> > putting apps up only at our own discretion makes sense. My only concern
> is
> > that I personally haven’t tried out many Cordova apps, so I would expect
> us
> > to have a shortage of apps this way. But if other PMC members have apps
> to
> > suggest, then we should be good.
> >
> > To move forward with Carlos’ proposal, we ought to:
> > - curate the existing list
> > - have someone explain the change of policy to the PRs still open
> >
> > Any takers for those two tasks?
> >
> > Kindly,
> > Dmitry
> >
> > > On Oct 23, 2015, at 6:01 PM, Steven Gill 
> wrote:
> > >
> > > YES! Removing the "add a tool" and "add a plugin" is the best way to
> go.
> > > Those PRs require way to much management. Leave it up to PMC to
> nominate
> > > apps.
> > >
> > > On Fri, Oct 23, 2015 at 5:41 PM, Nikhil Khandelwal <
> > nikhi...@microsoft.com>
> > > wrote:
> > >
> > >> I like Carlos' proposal. Reviewing PRs for these apps and judging by
> > >> whatever criteria we finally decide (however objective/subjective)
> will
> > not
> > >> be worth our time. The volume of PRs over the last couple of weeks has
> > been
> > >> quite significant in this area.
> > >>
> > >> At the end of the day, we just need 5-10 showcase apps.
> > >>
> > >> -Nikhil
> > >>
> > >> -Original Message-
> > >> From: Carlos Santana [mailto:csantan...@gmail.com]
> > >> Sent: Friday, October 23, 2015 5:37 PM
> > >> To: dev@cordova.apache.org
> > >> Subject: Re: [DISCUSS] Curating Apps
> > >>
> > >> I think we make it more simpler, a PMC member to propose to add an app
> > >> that he/she tried out and feels that it deserves to be show case as a
> > good
> > >> example of a great Cordova App.
> > >> - remove the "add your app"
> > >> - PMC members mails the list, that he evaluated the app and a short
> > >> description on why to added and he is planning to added, and ask if
> > someone
> > >> opposed with a -1
> > >> - Like Joe said, we don't need a tons of Apps, just a few will satisfy
> > the
> > >> goal
> > >> - The Apache way, if there are no -1 app get's added.
> > >>
> > >>
> > >>
> > >>
> > >> On Wed, Oct 21, 2015 at 7:27 PM Dmitry Blotsky <
> dblot...@microsoft.com>
> > >> wrote:
> > >>
> > >>> Sounds like we’ve got some (potentially mutually exclusive) points:
> > >>> - request detailed app descriptions from submitters
> > >>> - curate based on detailed criteria
> > >>> - curate based on loose criteria
> > >>> - only accept blog posts, and get rid of the showcase
> > >>> - just accept all requests
> > >>>
> > >>> Should this be a proposal on cordova-discuss? Or does someone feel
> > >>> like we have a consensus? The ultimate goal is to have something that
> > >>> displays good use of Cordova. I’d personally like to go with the
> > >>> easiest way to achieve this.
> > >>>
> > >>> Kindly,
> > >>> Dmitry
> > >>>
> >  On Oct 19, 2015, at 1:28 PM, Joerg Holz  wrote:
> > 
> >  I like the slogan: "submit something that helps other developers
> >  build a
> > >>> better app“.
> > 
> >  I disagree about your app store points, staring, public store, we
> >  don’t
> > >>> need that.
> > 
> >  And my opion is, that we should promote apps, which are clean or
> >  mostly
> > >>> clean from any Framework.
> > 
> > 
> >  Joerg
> > 
> > 
> > > Am 19.10.2015 um 20:11 schrieb Ryan J. Salva  >:
> > >
> > > The original goal for including the app showcase was to demonstrate
> > >>> that developers can build rockstar-quality apps using

[GitHub] cordova-plugin-statusbar pull request: CB-10884 Inappbrowser break...

2016-03-29 Thread daserge

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/53

CB-10884 Inappbrowser breaks UI while Screen orientation changes fromâ¦

â¦ landscape to portrait on iOS

[Jira issue](https://issues.apache.org/jira/browse/CB-10884)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-statusbar CB-10884

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #53


commit 244eb717fda536adad073b727fd4af1dd3cd58fd
Author: daserge 
Date:   2016-03-29T13:49:29Z

CB-10884 Inappbrowser breaks UI while Screen orientation changes from 
landscape to portrait on iOS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

2016-03-29 Thread jcesarmobile

Github user jcesarmobile commented on the pull request:

https://github.com/apache/cordova-docs/pull/410#issuecomment-202902395
  
We are still discussing it, we'll let you know when something is decided.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Curating Apps

2016-03-29 Thread julio cesar sanchez

I bring the topic back again because recently a tool was rejected and the
author mailed us asking (and we have not answered him yet)

So, are we rejecting tools too?

The original topic was "[DISCUSS] Curating Apps" and all the messages were
about apps, except this one from Steve that mentions removing "add a tool"
and "add a plugin"

"YES! Removing the "add a tool" and "add a plugin" is the best way to go.
Those PRs require way to much management. Leave it up to PMC to nominate
apps."





2015-10-24 3:24 GMT+02:00 Dmitry Blotsky :

> Sure, I’m also down for removing the “add your app” option. Switching to
> putting apps up only at our own discretion makes sense. My only concern is
> that I personally haven’t tried out many Cordova apps, so I would expect us
> to have a shortage of apps this way. But if other PMC members have apps to
> suggest, then we should be good.
>
> To move forward with Carlos’ proposal, we ought to:
> - curate the existing list
> - have someone explain the change of policy to the PRs still open
>
> Any takers for those two tasks?
>
> Kindly,
> Dmitry
>
> > On Oct 23, 2015, at 6:01 PM, Steven Gill  wrote:
> >
> > YES! Removing the "add a tool" and "add a plugin" is the best way to go.
> > Those PRs require way to much management. Leave it up to PMC to nominate
> > apps.
> >
> > On Fri, Oct 23, 2015 at 5:41 PM, Nikhil Khandelwal <
> nikhi...@microsoft.com>
> > wrote:
> >
> >> I like Carlos' proposal. Reviewing PRs for these apps and judging by
> >> whatever criteria we finally decide (however objective/subjective) will
> not
> >> be worth our time. The volume of PRs over the last couple of weeks has
> been
> >> quite significant in this area.
> >>
> >> At the end of the day, we just need 5-10 showcase apps.
> >>
> >> -Nikhil
> >>
> >> -Original Message-
> >> From: Carlos Santana [mailto:csantan...@gmail.com]
> >> Sent: Friday, October 23, 2015 5:37 PM
> >> To: dev@cordova.apache.org
> >> Subject: Re: [DISCUSS] Curating Apps
> >>
> >> I think we make it more simpler, a PMC member to propose to add an app
> >> that he/she tried out and feels that it deserves to be show case as a
> good
> >> example of a great Cordova App.
> >> - remove the "add your app"
> >> - PMC members mails the list, that he evaluated the app and a short
> >> description on why to added and he is planning to added, and ask if
> someone
> >> opposed with a -1
> >> - Like Joe said, we don't need a tons of Apps, just a few will satisfy
> the
> >> goal
> >> - The Apache way, if there are no -1 app get's added.
> >>
> >>
> >>
> >>
> >> On Wed, Oct 21, 2015 at 7:27 PM Dmitry Blotsky 
> >> wrote:
> >>
> >>> Sounds like we’ve got some (potentially mutually exclusive) points:
> >>> - request detailed app descriptions from submitters
> >>> - curate based on detailed criteria
> >>> - curate based on loose criteria
> >>> - only accept blog posts, and get rid of the showcase
> >>> - just accept all requests
> >>>
> >>> Should this be a proposal on cordova-discuss? Or does someone feel
> >>> like we have a consensus? The ultimate goal is to have something that
> >>> displays good use of Cordova. I’d personally like to go with the
> >>> easiest way to achieve this.
> >>>
> >>> Kindly,
> >>> Dmitry
> >>>
>  On Oct 19, 2015, at 1:28 PM, Joerg Holz  wrote:
> 
>  I like the slogan: "submit something that helps other developers
>  build a
> >>> better app“.
> 
>  I disagree about your app store points, staring, public store, we
>  don’t
> >>> need that.
> 
>  And my opion is, that we should promote apps, which are clean or
>  mostly
> >>> clean from any Framework.
> 
> 
>  Joerg
> 
> 
> > Am 19.10.2015 um 20:11 schrieb Ryan J. Salva :
> >
> > The original goal for including the app showcase was to demonstrate
> >>> that developers can build rockstar-quality apps using Cordova. I agree
> >>> that by opening the invitation to anyone without a vetting process, we
> >>> fall short of the original goal. Indeed, we might end up with a throng
> >>> of hobo-quality apps using any technology under the sun :-)
> >
> > At the same time, I don't want to sign up any of the Cordova
> > committers
> >>> to navigate the prejudicial question of "what counts as good?" Thus, I
> >>> like Jörg's proposal that we raise the empirical bar for entry. App
> >>> developers need to prove not only that their app is a Cordova app, but
> >>> they have to submit something that helps other developers build a
> better
> >> app.
> >
> > Here's a straw man proposal intended to provoke response:
> >
> > Must appear in a public store
> > Must use Cordova
> > Minimum 4 start rating
> > Minimum 1,000 downloads
> > Submitter must write a 200+ word blog post answering – Which
> > platforms are supported (minimum two) – Which plugins are

RE: [Vote] Tools Release

2016-03-29 Thread Vladimir Kotikov (Akvelon)

The vote has failed. I will start a new VOTE thread soon

-
Best regards, Vladimir

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Friday, March 25, 2016 4:59 PM
To: dev@cordova.apache.org
Subject: Re: [Vote] Tools Release

I vote -1
I think this is a critical problem we should fix
https://issues.apache.org/jira/browse/CB-10961


On Fri, Mar 25, 2016 at 8:51 AM Vladimir Kotikov (Akvelon) < 
v-vlk...@microsoft.com> wrote:

> Please review and vote on this Tools Release by replying to this email 
> (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10902
> Tools have been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-10902/
>
> The packages were published from their corresponding git tags:
> cordova-cli: 6.1.1 (ed5c366130)
> cordova-lib: 6.1.1 (96f89aa216)
> cordova-plugman: 1.2.1 (482b670510)
>
> Upon a successful vote I will upload the archives to dist/, publish 
> them to NPM, and post the corresponding blog post.
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> .md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and 
> subdependencies have Apache-compatible licenses
> * Ensured continuous build was green when repos were tagged
>
> -
> Best regards, Vladimir
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

RE: 6.1.0 (cordova-lib@undefined) ?

2016-03-29 Thread Vladimir Kotikov (Akvelon)

Created a jira for cordova-common removal from lib package:
CB-10981 Cordova-lib should not bundle cordova-common anymore  
(https://issues.apache.org/jira/browse/CB-10981)

-
Best regards, Vladimir

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Friday, March 25, 2016 5:51 PM
To: dev@cordova.apache.org
Subject: Re: 6.1.0 (cordova-lib@undefined) ?

The malformed package published didn't have any functional impact, just extra 
files, So I don't see the need to do a release just for that, But I found a 
critical issue as I kept testing 6.1.0 more in depth

Any way we should follow process as normal, do a CLI bug/patch 6.1.1 and have a 
[DISCUSS] on what should be in it like any bugs already fix in master and 
anything else that is almost ready/fix



On Fri, Mar 25, 2016 at 10:18 AM Vladimir Kotikov (Akvelon) < 
v-vlk...@microsoft.com> wrote:

> Hmm.. I thought the idea of 6.1.1 was to fix malformed package 
> contents on NPM and upload a correct package.
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Friday, March 25, 2016 4:18 PM
> To: dev@cordova.apache.org
> Subject: Re: 6.1.0 (cordova-lib@undefined) ?
>
> Vladimir, every Vote needs a new email thread "[DISCUSS]" so we can 
> discuss what would be in the new release
>
> I found a bad regression in 6.1.0, I think we should fix it and 
> release the fix with 6.1.1 Can you take a look at the JIRA and help 
> fix
>
> As for the removing the cordova-common, let's do that in next patch 
> release maybe a 6.1.2, right now at least is critical for my work to 
> get a working 6.1.1, people are already using 6.1.0 and broke
>
> [1]: 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-10961=01%7c01%7cv-vlkoti%40micr
> osoft.com%7cae80d8b5873c4aee8f7908d354bcddc6%7c72f988bf86f141af91ab2d7
> cd011db47%7c1=N5KjUiUkrmv2fu1wdsG6PSHYXiEjaOt47IL9QYBF%2flI%3d
>
>
> On Fri, Mar 25, 2016 at 8:58 AM Vladimir Kotikov (Akvelon) < 
> v-vlk...@microsoft.com> wrote:
>
> > I've started a vote thread. Voters are welcome :)
> >
> > Also I've notices that we bundle `cordova-common` into cordova-lib 
> > package. This is probably just a legacy of the time when 
> > cordova-common hadn't been released yet.
> > However this is not a problem anymore so we should remove this 
> > `bundleDependencies` section?
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > Sent: Friday, March 25, 2016 9:40 AM
> > To: dev@cordova.apache.org
> > Subject: RE: 6.1.0 (cordova-lib@undefined) ?
> >
> > I'll take care of it
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Thursday, March 24, 2016 7:11 PM
> > To: dev@cordova.apache.org
> > Subject: Re: 6.1.0 (cordova-lib@undefined) ?
> >
> > Shoot! So I am checking this out at the airport.
> >
> > So usually cordova-lib version is not supposed to show. It is for 
> > development only and I find it very useful.
> >
> > Looks like I made a mistake when publishing cordova-lib :(  I was 
> > doing some tests to see what modules were being picked up when 
> > running
> npm pack.
> > I ended up not deleting those test files from cordova-lib directory 
> > and they got included. I published the tag from the repo when I 
> > should have npm published the tgz. My bad guys. It needs to get 
> > repackaged and published, but with npm, only way to do that is to bump 
> > version.
> > So 6.1.1. Sucks that we have to vote for a repackage with no changes.
> >
> > Sorry. Can someone do this?
> >
> > -Steve
> > On Mar 24, 2016 8:49 AM, "Carlos Santana"  wrote:
> >
> > > Why do we need to print the version of cordova-lib inside CLI ?
> > >
> > > $ cordova -v
> > > 6.1.0 (cordova-lib@undefined)
> > >
> > > I opened a JIRA [1]
> > >
> > > Do we want to remove the extra info of cordova-lib and only print 
> > > the CLI version?
> > >
> > > cordova-lib is a npm dependency on cordova-cli like any of the 
> > > other dependencies [2]
> > >
> > > Does someone using this extra info?
> > > Do we need to provide more info or less info or provide more info 
> > > behind -d flag (i.e cordova -v -d)?
> > >
> > > [1]:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fi
> > > ss
> > > ue
> > > s.apache.org%2fjira%2fbrowse%2fCB-10952=01%7c01%7cv-vlkoti%40
> > > mi
> > > cr
> > > osoft.com%7c8eae6527f8614b78403808d353ff0b68%7c72f988bf86f141af91a
> > > b2
> > > d7
> > > cd011db47%7c1=Pvc1SOKl%2fgMyUhAwUP%2fRmlZzy%2buQV5OE7tzSJWbW
> > > hr
> > > M%
> > > 3d
> > > [2]:
> > > https://github.com/apache/cordova-cli/blob/master/package.json#L31
> > >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands,

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

2016-03-29 Thread mikaelkindborg

Github user mikaelkindborg commented on the pull request:

https://github.com/apache/cordova-docs/pull/410#issuecomment-202873303
  
@dblotsky Hi, I emailed the dev list as you suggested, but got no response 
as far as I can tell. Note that this pull request is not the app showcase, but 
for the tools section. Are you also rejecting additions to the tools section?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Tools Release CLI/LIB 6.1.1

2016-03-29 Thread Carlos Santana

I agree, we can discuss later the release for cordova-commons

- Carlos
@csantanapr

> On Mar 29, 2016, at 7:27 AM, Vladimir Kotikov (Akvelon) 
>  wrote:
> 
> Carlos, I've reviewed and merged these PRs. However the only two PRs that 
> need to be included into this release are #415 [1] and #416 [2]. The other 
> two are for cordova-common and I guess we have nothing to do with them for 
> now.
> 
> Summarizing, the release notes for 6.1.1 will look like this:
> 
> ### 6.1.1 (Mar 29, 2016)
> * CB-10961 Error no such file or directory adding ios platform when plugins 
> present or required
> * CB-10908 Reload the config.xml before writing the saved plugin
> 
> [1] https://github.com/apache/cordova-lib/pull/415
> [2] https://github.com/apache/cordova-lib/pull/416 
> 
> -
> Best regards, Vladimir
> 
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com] 
> Sent: Monday, March 28, 2016 10:50 PM
> To: dev@cordova.apache.org
> Subject: [DISCUSS] Tools Release CLI/LIB 6.1.1
> 
> I would like to see a patch release for the tools
> 
> Interested if someone can review and merge these PRs and get include it in 
> the release:
> 
> https://github.com/apache/cordova-lib/pull/418
> https://github.com/apache/cordova-lib/pull/417
> https://github.com/apache/cordova-lib/pull/416
> https://github.com/apache/cordova-lib/pull/415
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Does Cordova have a problem making developers happy?

2016-03-29 Thread julio cesar sanchez

Joe said:

"I also find it interesting that people are hating on Cordova, and not
PhoneGap, Ionic, Taco or the other distributions."

It's curious that Ionic has it's own tag, with about the same number of
questions that Cordova tag, but it's not on any of the lists (and it's not
because all Ionic questios are tagged with Cordova tag too, in fact, most
of them aren't)

But when people is using Phonegap and add the Phonegap tag to the question,
stack overflow replaces it with a Cordova tag because they decided long
time ago that they were synonyms, so you can't use Phonegap tag and we
can't be sure if they are using Cordova or Phonegap unless they tell it on
the question.

I think that's a mistake by stack overflow part, because people using
phonegap doesn't follow same workflow that people using cordova as Phonegap
docs are different, they mostly use the developer app to test, and phonegap
users might have different problems.

There are a lot of questions about  "- 3rd party plugin isn't
working on my app", and the problem is they are using the phonegap
developer app. But they don't mention that they are using phonegap, they
just add the phonegap tag, and stack overflow replaces it with a Cordova
tag. They don't mention that they are using the Phonegap developer app
neither because they think that's the way of running Phonegap apps. I see
at least one of those everyday on stack overflow or some other forums.

I've filed a few issues on the phonegap docs page so they can make clearer
to users that when using the phonegap developer app they are not really
running their app, and they have some issues open to list the developer app
limitations. Once they are addressed, maybe the developers are a bit
happier.

But I'm not sure what to do about the stack overflow synonym, should we
tell them to remove the synonym so people can use Phonegap and Cordova as
different tags?

2016-03-29 8:23 GMT+02:00 Robert Posener :

> I think I have created a discussion, but it is not showing up... yet
> another frustrations!
>
> Rob
>
> Regards
> *Rob Posener*
> 0419 012 627
>
> On 29 March 2016 at 16:48, Parashuram N  wrote:
>
> > I am not sure if everyone got the attachment. Rob, can I request  you to
> > create an issue on https://github.com/cordova/cordova-discuss so that we
> > could start following up on specific issues there ?
> >
> > From: Robert Posener 
> > Reply-To: "dev@cordova.apache.org" 
> > Date: Monday, March 28, 2016 at 10:08 PM
> > To: "dev@cordova.apache.org" 
> > Subject: Re: Does Cordova have a problem making developers happy?
> >
> > Gerday all,
> > Because of the serious nature of this thread, I have produced a 6-page
> > contribution of issues together with recommendations for fixing them in
> the
> > attachment to this email.
> >
> > Regards
> >
> > Rob Posener
> >
> > Regards
> > Rob Posener
> > 0419 012 627
> >
> > On 19 March 2016 at 08:31, Joe Bowser  bows...@gmail.com>> wrote:
> > I don't entirely agree with this, since usually we do respond.  We don't
> > just accept things that get thrown at us, which I think is the
> expectation.
> >
> > I think we need to make sure we come to some resolution and actually
> solve
> > the problem in a timely manner.  We've had both extremes of discussing a
> > problem to death and cowboy coding, and neither extreme works well.
> >
> > As for getting there, I have no idea.  Any thoughts?
> >
> > On Fri, Mar 18, 2016, 2:23 PM Raghav Katyal  > > wrote:
> >
> > > I guess responding to JIRA quickly and acting on contributors' PRs
> could
> > > be candidates for improvement.
> > >
> > > -Original Message-
> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com > nikhi...@microsoft.com>]
> > > Sent: Friday, March 18, 2016 11:18 AM
> > > To: dev@cordova.apache.org
> > > Subject: Re: Does Cordova have a problem making developers happy?
> > >
> > > I have been guilty of not spending too much time on stackoverflow
> > > answering questions. It’s on my TODO list. For those who have, what are
> > > there general themes of improvement here that will make a huge impact?
> > >
> > > I remember Julio summarized this last year [1] and I believe we have
> made
> > > progress on a lot of these – docs, PATH setup. Though the impact of our
> > > docs work is yet to be seen – we just did a big update in terms of
> > > organization [2]. There’s probably more to be done in terms of docs –
> > > tutorials, examples for plugin API usage, integration with other tools
> > like
> > > gulp, browserify etc. What are other good candidates for improvement?
> > >
> > > I found it interesting that our own survey [3] in October had somewhat
> > > high Net promoter score (NPS).
> > >
> > > [1]
> > >
> >
>

RE: [DISCUSS] Tools Release CLI/LIB 6.1.1

2016-03-29 Thread Vladimir Kotikov (Akvelon)

Carlos, I've reviewed and merged these PRs. However the only two PRs that need 
to be included into this release are #415 [1] and #416 [2]. The other two are 
for cordova-common and I guess we have nothing to do with them for now.

Summarizing, the release notes for 6.1.1 will look like this:

### 6.1.1 (Mar 29, 2016)
* CB-10961 Error no such file or directory adding ios platform when plugins 
present or required
* CB-10908 Reload the config.xml before writing the saved plugin

[1] https://github.com/apache/cordova-lib/pull/415
[2] https://github.com/apache/cordova-lib/pull/416 

-
Best regards, Vladimir

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Monday, March 28, 2016 10:50 PM
To: dev@cordova.apache.org
Subject: [DISCUSS] Tools Release CLI/LIB 6.1.1

I would like to see a patch release for the tools

Interested if someone can review and merge these PRs and get include it in the 
release:

https://github.com/apache/cordova-lib/pull/418
https://github.com/apache/cordova-lib/pull/417
https://github.com/apache/cordova-lib/pull/416
https://github.com/apache/cordova-lib/pull/415

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10979 Fix splashscree...

2016-03-29 Thread daserge

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/96

CB-10979 Fix splashscreen ios native tests

Added jshintignore for tests/ios

[Jira issue](https://issues.apache.org/jira/browse/CB-10979)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen 
CB-10979

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #96


commit 99ce77910f7aef20ea8f2ac28cc9ebb08c9092ea
Author: daserge 
Date:   2016-03-29T11:05:49Z

CB-10979 Fix splashscreen ios native tests
Added jshintignore for tests/ios




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

2016-03-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/416#issuecomment-202818205
  
@csantanapr, i merged a bit different change, which uses `preparePlatforms` 
method instead of `prepare` .It is a subset of `prepare` but doesn't include 
the actions that are not expected to ran at this moment, like restoring 
platforms, plugins, fire hooks. Tested it with the case described in JIRA and 
it works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/416


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10908 - Add a plugin with the --save ...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/415


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/418


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/417


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

2016-03-29 Thread elsewhat

Github user elsewhat commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-202773421
  
Pull request has been tested by debugging. The cordova-plugin-camera plugin 
was added to a local cordova project from my forked repository and the new 
commit. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

2016-03-29 Thread elsewhat

GitHub user elsewhat opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/198

CB-10857 android : Camera.getPicture return null for Google Drive (camera 
2.1.1)

FileHelper getRealPath will fallback to URI string if no other type of
path has been found

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/elsewhat/cordova-plugin-camera 
CB-10857cordova-plugin-camera

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #198


commit b8b9b5abced904f1b0990eef6ee8acf3e6b44987
Author: Dagfinn Parnas 
Date:   2016-03-29T06:56:52Z

CB-10857: Camera.getPicture return null for Google Drive (camera 2.1.1)

FileHelper getRealPath will fallback to URI string if no other type of
path has been found




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/418#issuecomment-202768180
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-29 Thread daserge

Github user daserge commented on the pull request:

https://github.com/apache/cordova-lib/pull/418#issuecomment-202764912
  
Addressed, thanks @vladimir-kotikov, please take a look when you have a 
moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/149


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10622 Support any MRT qualifiers ...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/159


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10622 Fix targetsize images being...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/162


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10622 Support any MRT qualifiers ...

2016-03-29 Thread sgrebnov

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/159#issuecomment-202743738
  
Reviewed and verified on sample config/images :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10845 Invalidate manifest cache i...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/164


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

2016-03-29 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/418#discussion_r57676830
  
--- Diff: cordova-common/spec/events.spec.js ---
@@ -0,0 +1,30 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var events = require('../src/events');
+
+describe('forwardEventsTo method', function () {
+afterEach(function() {
+events.forwardEventsTo(null);
+});
+it('should not go to infinite loop when trying to forward to self', 
function () {
+events.forwardEventsTo(events);
+events.emit('log', 'test message');
--- End diff --

> This test will fail if we go into an infinite recursion as the title 
says. 

You mean that this will be caught by Jasmine and reported as failure? Then 
it makes sense, please add a comment clarifying this.

> to verify that forwarding has been reset after 
events.forwardEventsTo(events) call

Nice. Let's do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Does Cordova have a problem making developers happy?

2016-03-29 Thread Robert Posener

I think I have created a discussion, but it is not showing up... yet
another frustrations!

Rob

Regards
*Rob Posener*
0419 012 627

On 29 March 2016 at 16:48, Parashuram N  wrote:

> I am not sure if everyone got the attachment. Rob, can I request  you to
> create an issue on https://github.com/cordova/cordova-discuss so that we
> could start following up on specific issues there ?
>
> From: Robert Posener 
> Reply-To: "dev@cordova.apache.org" 
> Date: Monday, March 28, 2016 at 10:08 PM
> To: "dev@cordova.apache.org" 
> Subject: Re: Does Cordova have a problem making developers happy?
>
> Gerday all,
> Because of the serious nature of this thread, I have produced a 6-page
> contribution of issues together with recommendations for fixing them in the
> attachment to this email.
>
> Regards
>
> Rob Posener
>
> Regards
> Rob Posener
> 0419 012 627
>
> On 19 March 2016 at 08:31, Joe Bowser > wrote:
> I don't entirely agree with this, since usually we do respond.  We don't
> just accept things that get thrown at us, which I think is the expectation.
>
> I think we need to make sure we come to some resolution and actually solve
> the problem in a timely manner.  We've had both extremes of discussing a
> problem to death and cowboy coding, and neither extreme works well.
>
> As for getting there, I have no idea.  Any thoughts?
>
> On Fri, Mar 18, 2016, 2:23 PM Raghav Katyal  > wrote:
>
> > I guess responding to JIRA quickly and acting on contributors' PRs could
> > be candidates for improvement.
> >
> > -Original Message-
> > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com nikhi...@microsoft.com>]
> > Sent: Friday, March 18, 2016 11:18 AM
> > To: dev@cordova.apache.org
> > Subject: Re: Does Cordova have a problem making developers happy?
> >
> > I have been guilty of not spending too much time on stackoverflow
> > answering questions. It’s on my TODO list. For those who have, what are
> > there general themes of improvement here that will make a huge impact?
> >
> > I remember Julio summarized this last year [1] and I believe we have made
> > progress on a lot of these – docs, PATH setup. Though the impact of our
> > docs work is yet to be seen – we just did a big update in terms of
> > organization [2]. There’s probably more to be done in terms of docs –
> > tutorials, examples for plugin API usage, integration with other tools
> like
> > gulp, browserify etc. What are other good candidates for improvement?
> >
> > I found it interesting that our own survey [3] in October had somewhat
> > high Net promoter score (NPS).
> >
> > [1]
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail-archives.apache.org%2fmod_mbox%2fcordova-dev%2f201504.mbox%2f%253CetPan.552c9004.643c9869.b8b8%40Kerris-MacBook-Pro.local%253E=01%7c01%7crakatyal%40microsoft.com%7c1371f56d47e84d4fb7c808d34f59b0e9%7c72f988bf86f141af91ab2d7cd011db47%7c1=dPkMBS3I8mA7uqmezeLaxknf4ujYsmymcco50y9piYg%3d
> > [2]
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcordova.apache.org%2fannouncements%2f2016%2f03%2f03%2fdocs-improvement.html=01%7c01%7crakatyal%40microsoft.com%7c1371f56d47e84d4fb7c808d34f59b0e9%7c72f988bf86f141af91ab2d7cd011db47%7c1=fYJCb131SFY%2bAA0RS2cxrDyf3m74EAHSGPuhd6oR7xo%3d
> > [3]
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fapachecordovabot.typeform.com%2freport%2fBCc5co%2fJQLG=01%7c01%7crakatyal%40microsoft.com%7c1371f56d47e84d4fb7c808d34f59b0e9%7c72f988bf86f141af91ab2d7cd011db47%7c1=eH8cPNyXnPD2ltm%2bKbFfLCq4ifGQeBItD5rAXbgSOhg%3d
> >
> > On 3/17/16, 5:55 PM, "Carlos Santana" > wrote:
> >
> > >I agree Joe
> > >
> > >It's easy to create a stackoverflow subscription that emails you once a
> > >day.
> > >
> > >I have one that covers "cordova" "worklight" "mobilefirst"
> > >
> > >I tried to answer what I can, but reading it daily which is not every
> > >day that I get something probably most every other day with a few.
> > >
> > >At least reading all the new questions gives me a sense on what people
> > >are having problems on.
> > >
> > >
> > >
> > >On Thu, Mar 17, 2016 at 8:46 PM Joe Bowser > wrote:
> > >
> > >> BTW: The last one was a joke.  But in all honesty, we should all
> > >> spend a bit more time on Stack seeing what's going on there with our
> > >> respective products/distributions.
> > >>
> > >> On Thu, Mar 17, 2016 at 5:43 PM, Joe Bowser  > wrote:
> > >>
> > >> >
> > >> >
> > >> > On Thu, Mar 17, 2016 at 5:23 PM, Ryan J. Salva
> > >> > >
> > >> > wrote:
> > >> >
> > >> >> Keep in mind that the answers are limited to the technologies that
> > >> >> Stack

[GitHub] cordova-plugin-file-transfer pull request: CB-10978 Fix file-trans...

2016-03-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/134


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-10978 Fix file-trans...

2016-03-29 Thread daserge

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/134

CB-10978 Fix file-transfer.tests JSHint issues

[Jira issue](https://issues.apache.org/jira/browse/CB-10978)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
CB-10978

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #134


commit 2b8c1a6101c57198000a8d9ab6d48d239c1c5014
Author: daserge 
Date:   2016-03-29T05:57:57Z

CB-10978 Fix file-transfer.tests JSHint issues




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

72 matches

Mail list logo