Re: [Vote] 4.3.1 iOS Release

[Jesse]

This should be in a discuss thread.


@purplecabbage
risingj.com

On Wed, Nov 30, 2016 at 8:24 PM, Steven Gill  wrote:

> We don't update the deps every release. It is more just a reminder to check
> them, make sure bundled deps match wanted. If releaser is feeling
> ambitious, they can update the deps. Might require more in depth testing.
> We have run into issues updating deps before (like shelljs). Something like
> greenkeeper would lead to faster dep updates.
>
> P. S. Usually we do the discussion in the discuss thread and leave the vote
> threads just for voting.
>
> On Nov 30, 2016 7:29 PM, "Filip Maj"  wrote:
>
> > The release notes in coho [1] note to check npm outdated dependencies.
> > When I run that against commit
> > 0c201c42344f63c7590c4190ba2285fa199300bb, I get:
> >
> > ~/src/cordova-ios on master via ⬢ v6.9.1
> > ➔ npm outdated --depth=0
> > Package   Current  Wanted  Latest  Location
> > nodeunit0.8.8   0.8.8  0.10.2  cordova-ios
> > plist   1.2.0   1.2.0   2.0.1  cordova-ios
> > shelljs 0.5.3   0.5.3   0.7.5  cordova-ios
> > tmp0.0.26  0.0.26  0.0.31  cordova-ios
> >
> > I might be rusty, is this a showstopper? Or do we not care about this
> > and the release notes need updating?
> >
> > [1] https://github.com/apache/cordova-coho/blob/master/docs/
> > platforms-release-process.md#update-and-pin-dependencies
> >
> > On Wed, Nov 30, 2016 at 5:28 PM, Shazron  wrote:
> > > Please review and vote on this 4.3.1 iOS Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-12203
> > >
> > > The archive has been published to dist/dev:
> > > https://dist.apache.org/repos/dist/dev/cordova/CB-12203
> > >
> > > The package was published from its corresponding git tag:
> > > cordova-ios: 4.3.1 (8fe24d41b0)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add https://github.com/apache/cordova-ios#4.3.1
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> to
> > > npm, and post the blog post.
> > >
> > > Voting guidelines:
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> > release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> sub-dependencies
> > > have Apache-compatible licenses
> > > * Ensured continuous build was green when repo was tagged
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Re: [Vote] 4.3.1 iOS Release

[Steven Gill]

We don't update the deps every release. It is more just a reminder to check
them, make sure bundled deps match wanted. If releaser is feeling
ambitious, they can update the deps. Might require more in depth testing.
We have run into issues updating deps before (like shelljs). Something like
greenkeeper would lead to faster dep updates.

P. S. Usually we do the discussion in the discuss thread and leave the vote
threads just for voting.

On Nov 30, 2016 7:29 PM, "Filip Maj"  wrote:

> The release notes in coho [1] note to check npm outdated dependencies.
> When I run that against commit
> 0c201c42344f63c7590c4190ba2285fa199300bb, I get:
>
> ~/src/cordova-ios on master via ⬢ v6.9.1
> ➔ npm outdated --depth=0
> Package   Current  Wanted  Latest  Location
> nodeunit0.8.8   0.8.8  0.10.2  cordova-ios
> plist   1.2.0   1.2.0   2.0.1  cordova-ios
> shelljs 0.5.3   0.5.3   0.7.5  cordova-ios
> tmp0.0.26  0.0.26  0.0.31  cordova-ios
>
> I might be rusty, is this a showstopper? Or do we not care about this
> and the release notes need updating?
>
> [1] https://github.com/apache/cordova-coho/blob/master/docs/
> platforms-release-process.md#update-and-pin-dependencies
>
> On Wed, Nov 30, 2016 at 5:28 PM, Shazron  wrote:
> > Please review and vote on this 4.3.1 iOS Release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-12203
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-12203
> >
> > The package was published from its corresponding git tag:
> > cordova-ios: 4.3.1 (8fe24d41b0)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-ios#4.3.1
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/
> release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and sub-dependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: [Vote] 4.3.1 iOS Release

[Filip Maj]

The release notes in coho [1] note to check npm outdated dependencies.
When I run that against commit
0c201c42344f63c7590c4190ba2285fa199300bb, I get:

~/src/cordova-ios on master via ⬢ v6.9.1
➔ npm outdated --depth=0
Package   Current  Wanted  Latest  Location
nodeunit0.8.8   0.8.8  0.10.2  cordova-ios
plist   1.2.0   1.2.0   2.0.1  cordova-ios
shelljs 0.5.3   0.5.3   0.7.5  cordova-ios
tmp0.0.26  0.0.26  0.0.31  cordova-ios

I might be rusty, is this a showstopper? Or do we not care about this
and the release notes need updating?

[1] 
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#update-and-pin-dependencies

On Wed, Nov 30, 2016 at 5:28 PM, Shazron  wrote:
> Please review and vote on this 4.3.1 iOS Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-12203
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-12203
>
> The package was published from its corresponding git tag:
> cordova-ios: 4.3.1 (8fe24d41b0)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-ios#4.3.1
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and sub-dependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request #142: [CB-12186] [create script] Support pa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/142


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #243 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #243 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/243/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] 4.3.1 iOS Release

[Shazron]

Please review and vote on this 4.3.1 iOS Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-12203

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-12203

The package was published from its corresponding git tag:
cordova-ios: 4.3.1 (8fe24d41b0)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-ios#4.3.1

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and sub-dependencies
have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged

Re: Hello again!

[Filip Maj]

Thanks for the clarification Alexander! I think I got confused between
the PR and periodic builds. I see in the periodic builds, indeed the
job is cloning down the relevant platform and using the latest HEAD
from master. In the PR builds, the logs are sparser and don't
explicitly log out versions of dependent libraries consumed, so I will
assume you are right!

I have one more question: how does everyone feel about cordova-qa's
GitHub comments with test results (passing example: [1], failing
example: [2])? What about integrating these kinds of checks into the
GitHub UI for per-commit checks (this is the green checkmark you'll
see in GH UI)? I'm probably missing a reason why it is integrated in
this way, so forgive me if it's a naive question :)

It looks like Travis test runs are integrated using the GitHub
pass/fail integrations / UI. I'm wondering why not the Jenkins tests?
I believe we can set up the integration such that each discrete check
(i.e. a specific plugin/platform combination) can set up as a separate
check, posting a separate result. Might be less confusing / less "made
in house" than a custom QA bot? Just a thought. Currently, the 'fail'
comment from cordova-qa requires contributors to click through all the
various links to figure out which particular platform errored out. By
splitting the checks out, it would make that more apparent more
immediately.

I think the UI as viewed from GitHub would be cleaner: from the pull
req list it would be instantly visible which PRs are passing and which
are failing, and the merge instructions could be simplified to "if the
green check mark shows up, merge away", instead of right now needing
to wait for both the green checkmark representing Travis + cordova-qa
bot comment.

It's a UI nitpick but I think it might improve the contribution
experience. Feel free to shoot me down or direct me to more pressing
issues :D

[1] 
https://github.com/apache/cordova-plugin-device/pull/58#issuecomment-263793786
[2] 
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-263013516

On Tue, Nov 29, 2016 at 12:28 AM,   wrote:
> Hi again Filip, you are most welcome!
>
>>> - cordova-paramedic configs are pulled from cordova-medic repo.
>>> (?) requires an extra pull in CI.
> Yeah. This is kind of rudimentary thing, I think we can safely transfer them 
> to cordova-paramedic repo. This will require some Jenkins jobs changes, I can 
> assist with that.
>
>> >  - paramedic setup for individual plugins install latest HEAD of
>> > master of platform code (at least, cordova-android + device plugin)
> What makes you think so? I double-checked, our current CI setup for per-PR 
> jobs is using the released versions of all the platforms. Master versions are 
> used only for periodic build.
>
>> >  - there are plugins tests that run via a jenkins instance on
>> > cloudapp.net, and there are travis tests too. travis is pull-req
>> > triggered, cloud app runs nightly. why?
> Regarding cloudapp (Jenkins) builds:
> The goal of nightly tests is to verify the master versions of plugins against 
> the master versions of platforms and CLI. We also run per-PR jobs against the 
> released versions of platform and CLI, you can find them here:
> http://cordova-ci.cloudapp.net:8080/view/Pull%20requests/
>
> Feel free to contact me via email or Slack if you have any questions 
> regarding our current CI setup or need an assistance.
>
> Thanks,
> Alexander Sorokin
>
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Monday, November 28, 2016 11:00 PM
> To: dev@cordova.apache.org
> Subject: Re: Hello again!
>
> Welcome back!
>
>
> @purplecabbage
> risingj.com
>
> On Mon, Nov 28, 2016 at 11:50 AM, Simon MacDonald > wrote:
>
>> Never heard of this guy.
>> Simon Mac Donald
>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsimonm
>> acdonald.com=02%7C01%7Cv-alsoro%40microsoft.com%7Cdcdee276682a4ff
>> 9353408d417c92e87%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6361596
>> 00215033744=zPpzT0F5p5rlW71wFWe0DtB2cG8rednMPQyiqtUw%2BZg%3D
>> erved=0
>>
>>
>> On Mon, Nov 28, 2016 at 2:48 PM, Filip Maj  wrote:
>> > Hi everyone!
>> >
>> > Just wanted to (re)introduce myself after a 3 year or so hiatus :)
>> >
>> > I used to be an active member of the group between 2011 and 2013
>> > when I was on the Adobe PhoneGap team. I took a 3 year detour
>> > focusing on mobile testing infrastructure at Sauce Labs, but
>> > recently rejoined the Adobe PhoneGap team. I have been lurking more
>> > intently on this list for the past month or so and aim to be more involved 
>> > these days.
>> >
>> > I've been poking around and getting my bearings around the testing
>> > suites, infrastructure and CI in Cordova the past week or so. I
>> > think I will try to contribute in that area initially. In
>> > particular, I am interested in enabling functional end-to-end
>> > testing for all repos in 

[GitHub] cordova-plugin-file-transfer issue #170: CB-12154 file-transfer progressEven...

[erikramalho]

Github user erikramalho commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/170
  
I've tested @daserge commit and it works perfectly! please, merge it asap!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

[jlchereau]

Github user jlchereau commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
  
Definitely ++1 for this one.

https://github.com/kidoju/Kidoju-Mobile:
1) Loads a script library as text from a local file using $.ajax.
2) Executes a series of functions in web workers using this library.

(1) would fail with latest 
https://github.com/apache/cordova-plugin-wkwebview-engine but would succeed 
with latest https://github.com/driftyco/cordova-plugin-wkwebview-engine.git as 
of today.

What is the roadmap / ETA for merging Ionic's PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...

[cjpearson]

Github user cjpearson commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90223157
  
--- Diff: src/ios/CDVWKWebViewEngine.m ---
@@ -123,6 +123,32 @@ - (void)pluginInitialize
name:UIApplicationWillEnterForegroundNotification 
object:nil];
 
 NSLog(@"Using WKWebView");
+
+[self addURLObserver];
+}
+
+- (void)onReset {
+[self addURLObserver];
+}
+
+static void * KVOContext = 
+
+- (void)addURLObserver {
+if(![[NSProcessInfo processInfo] 
isOperatingSystemAtLeastVersion:(NSOperatingSystemVersion){.majorVersion = 9, 
.minorVersion = 0, .patchVersion = 0 }]){
--- End diff --

Yeah I was using the local webserver plugin to support iOS 8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

[jlchereau]

Github user jlchereau commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/162
  
I have experienced the defect described here with oAuth flows but 
considering [Google deprecation of webviews for oAuth 
flows](https://developers.googleblog.com/2016/08/modernizing-oauth-interactions-in-native-apps.html),
 I have decided to pursue another route explained here: 
https://medium.com/@jlchereau/stop-using-inappbrowser-for-your-cordova-phonegap-oauth-flow-a806b61a2dc5.
 I am looking forward to your opinion on this alternative especially regarding 
any security flaws I might have overlooked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

[jlchereau]

Github user jlchereau commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/187
  
I have experienced the defect described here with oAuth flows but 
considering [Google deprecation of webviews for oAuth 
flows](https://developers.googleblog.com/2016/08/modernizing-oauth-interactions-in-native-apps.html),
 I have decided to pursue another route explained here: 
https://medium.com/@jlchereau/stop-using-inappbrowser-for-your-cordova-phonegap-oauth-flow-a806b61a2dc5.
 I am looking forward to your opinion on this alternative especially regarding 
any security flaws I might have overlooked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #170: CB-12154 file-transfer progressEven...

[daserge]

Github user daserge commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/170
  
@jcesarmobile, @shazron, @stevengill could you please take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #169: CB-10974 Cordova file transfer Cont...

[daserge]

Github user daserge commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/169
  
@jcesarmobile, @shazron, @stevengill could you please take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: CB-10974 FileTransfer chunkedMode=false + HTTPS

[Sergey Shakhnazarov (Akvelon)]

Hi guys,

Shazron - in fact we have the checks in the onprogress events in the doc 
checking if an event is computable (and it was false for chunkedMode=true), so 
docs are valid.

Could you please review and comment on these PRs?
1. https://github.com/apache/cordova-plugin-file-transfer/pull/169 - this does 
not force chunkedMode=true for HTTPS if it was specified as false in the 
options,
2. https://github.com/apache/cordova-plugin-file-transfer/pull/170 - this adds 
back Content-Length to chunkedMode=true case on iOS so that progress events 
will be computable and contain total.

Please let me know if you have any questions or considerations.

Best regards,
Sergey Shakhnazarov,
Akvelon developer.

-Original Message-
From: Shazron [mailto:shaz...@gmail.com] 
Sent: Thursday, November 24, 2016 03:06
To: dev@cordova.apache.org
Subject: Re: CB-10974 FileTransfer chunkedMode=false + HTTPS

Microsoft emails are still being sent to spam for me (using Gmail) so I didn't 
see this until later.

You said: "should we care about specification or about functionality?"

We care firstly about what we documented. In this case, according to our docs, 
chunkedMode defaults to true, and in our example we show the use of an 
onprogress event.

This runs counter to what you have observed -- there are no progress events. In 
my opinion, at first glance, this is a bug in what we are documenting should 
happen, therefore we should have progress events for chunkedMode=true (the 
default) -- and we record the quirk which I recommend a major version bump for.



On Wed, Nov 23, 2016 at 7:14 AM, Sergey Shakhnazarov (Akvelon) < 
v-ses...@microsoft.com> wrote:

> There is a related issue on Ios platform [3] - having chunkedMode=true 
> causes progress not to be computable as we don't include 
> Content-Length header to the request in this case.
> Reverting that logic fixes the onprogress event but breaks our tests - 
> so this is a question again - should we care about specification or 
> about functionality?
> Should we revert this to make the progress computable for chunkedMode=true?
>
> Does anyone has knowledge to advise about the drawbacks of this 
> specific decision would it be taken (tests show that progress is being 
> reported correctly but this is again is kind of an internal 
> implementation we will depend on)?
>
> [3]: 
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissue
> s.apache.org%2Fjira%2Fbrowse%2FCB-12154=02%7C01%7Cv-seshak%40micr
> osoft.com%7Cc12922d6191348652e0208d413fdd724%7C72f988bf86f141af91ab2d7
> cd011db47%7C1%7C0%7C636155428348550982=Mdp5yQ6CcT5igUeRukjhf8vb%
> 2Bm6bgBMb1sV6lrOfmAE%3D=0
>
> Please let me know if you have any questions or considerations.
>
> Best regards,
> Sergey Shakhnazarov.
>
> -Original Message-
> From: Sergey Shakhnazarov (Akvelon) [mailto:v-ses...@microsoft.com]
> Sent: Wednesday, November 23, 2016 14:47
> To: dev@cordova.apache.org
> Subject: CB-10974 FileTransfer chunkedMode=false + HTTPS
>
> Hi guys,
>
> There were several user reports recently about the upload failures 
> caused by the lack of Content-Length header in case of HTTPS uploads.
> This issue is caused by the FileTransfer code, which forces 
> chunkedMode=true for HTTPS uploads due to possible OutOfMemoryException.
> As a solution I've send a PR [1], which does not touch chunkedMode if 
> it was specified as false in the UploadOptions.
>
> Do you think this a correct solution?
>
> According to the HTTP specification [2]:
>
> Ø  Messages MUST NOT include both a Content-Length header field and a 
> non-identity transfer-coding. If the message does include a non- 
> identity transfer-coding, the Content-Length MUST be ignored.
>
>
>
> So including a Content-Length for the chunkedMode=true case would be wrong.
>
> Furthermore we don't control the underlying implementation so can't 
> define the summary length of chunks beforehand.
>
>
>
> [1]: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-plugin-
> file-transfer%2Fpull%2F169=02%7C01%7Cv-seshak%40microsoft.com%
> 7C9a4c5183e2ef4ac549d008d413968086%7C72f988bf86f141af91ab2d7cd011
> db47%7C1%7C0%7C636154984504057421=ggfYGmC0FX%
> 2F2rclFaF8T1PuNAUARywO0LSUxHIRXecE%3D=0
>
> [2]: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.w3.org%2FProtocols%2Frfc2616%
> 2Frfc2616-sec4.html%23sec4.4=02%7C01%7Cv-seshak%40microsoft.com%
> 7C9a4c5183e2ef4ac549d008d413968086%7C72f988bf86f141af91ab2d7cd011
> db47%7C1%7C0%7C636154984504057421=hDLgzBvz%
> 2FvKkq50Oo2R04Q9kmP6rZAQbpXpiD9hgHEI%3D=0
>
> Please let me know if you have any questions or considerations.
>
> Best regards,
> Sergey Shakhnazarov.
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>